{"action":"created","issue":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/68","repository_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning","labels_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/68/comments","events_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/68/events","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/68","id":343296204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTkxODY2","number":68,"title":"[msgs::ChannelReestablish] implement encoding and decoding","user":{"login":"savil","id":676452,"node_id":"MDQ6VXNlcjY3NjQ1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/676452?v=4","gravatar_id":"","url":"https://api.github.com/users/savil","html_url":"https://github.com/savil","followers_url":"https://api.github.com/users/savil/followers","following_url":"https://api.github.com/users/savil/following{/other_user}","gists_url":"https://api.github.com/users/savil/gists{/gist_id}","starred_url":"https://api.github.com/users/savil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savil/subscriptions","organizations_url":"https://api.github.com/users/savil/orgs","repos_url":"https://api.github.com/users/savil/repos","events_url":"https://api.github.com/users/savil/events{/privacy}","received_events_url":"https://api.github.com/users/savil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-21T04:28:11Z","updated_at":"2018-07-21T05:31:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/pulls/68","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/68","diff_url":"https://github.com/rust-bitcoin/rust-lightning/pull/68.diff","patch_url":"https://github.com/rust-bitcoin/rust-lightning/pull/68.patch"},"body":"Summary:\r\n\r\nImplementing these, taking inspiration from the surrounding code since i'm a rust n00b.\r\n\r\nTest Plan:\r\n```\r\ncargo build\r\ncargo test channel_reestablish\r\n```\r\noutput:\r\n```\r\nrunning 3 tests\r\ntest ln::msgs::tests::encoding_channel_reestablish_with_secret ... ok\r\ntest ln::msgs::tests::decode_channel_reestablish_bad_length ... ok\r\ntest ln::msgs::tests::encoding_channel_reestablish_no_secret ... ok\r\n\r\ntest result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 14 filtered out\r\n```"},"comment":{"url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/comments/406772164","html_url":"https://github.com/rust-bitcoin/rust-lightning/pull/68#issuecomment-406772164","issue_url":"https://api.github.com/repos/rust-bitcoin/rust-lightning/issues/68","id":406772164,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjc3MjE2NA==","user":{"login":"savil","id":676452,"node_id":"MDQ6VXNlcjY3NjQ1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/676452?v=4","gravatar_id":"","url":"https://api.github.com/users/savil","html_url":"https://github.com/savil","followers_url":"https://api.github.com/users/savil/followers","following_url":"https://api.github.com/users/savil/following{/other_user}","gists_url":"https://api.github.com/users/savil/gists{/gist_id}","starred_url":"https://api.github.com/users/savil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/savil/subscriptions","organizations_url":"https://api.github.com/users/savil/orgs","repos_url":"https://api.github.com/users/savil/repos","events_url":"https://api.github.com/users/savil/events{/privacy}","received_events_url":"https://api.github.com/users/savil/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T05:31:38Z","updated_at":"2018-07-21T05:31:38Z","author_association":"CONTRIBUTOR","body":"@yuntai ah, thanks!\r\n\r\n- I'm looking at `fuzz/fuzz_targets/msg_targets`. I don't 100% follow all of it, but it seems like I would need to add `ChannelReestablish` to `gen_targets.sh`. Is that correct? Is there anything else to add?\r\n- there seems to be some problem with `gen_targets.sh`. If I run it on `master` branch, I get this output: https://gist.github.com/savil/2b3114eaf34c3ef8499b65005e374841. I couldn't spot the problem yet. Am going to sleep but can revisit it over the weekend."}}
{"actor":{"display_login":"savil"}}