{"action":"closed","number":900,"pull_request":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900","id":190912403,"html_url":"https://github.com/kubernetes/autoscaler/pull/900","diff_url":"https://github.com/kubernetes/autoscaler/pull/900.diff","patch_url":"https://github.com/kubernetes/autoscaler/pull/900.patch","issue_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/900","number":900,"state":"closed","locked":false,"title":"Move some GKE-specific logic outside core","user":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"body":"At some point we added a whole bunch of GKE-specific code to core. This is the first part of cleaning that mess up.\r\n\r\nNo change in actual logic. Added a new NodeGroupListProcessor interface to encapsulate the existing logic. Moved PodListProcessor and refactor how it's passed around to make it consistent and easy to add more 'processor' interfaces.\r\n\r\nI thought about placing processors in context, but gave up on that due to problems with cyclic imports. Instead I put all processors into a single struct to avoid passing multiple processors around.","created_at":"2018-05-28T11:59:28Z","updated_at":"2018-05-29T11:58:42Z","closed_at":"2018-05-29T11:58:42Z","merged_at":"2018-05-29T11:58:42Z","merge_commit_sha":"7546dff1a4ee8a2892cdac32007a15e5ebdfc86f","assignee":{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false},"assignees":[{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false},{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars2.githubusercontent.com/u/11994812?v=4","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":587167715,"url":"https://api.github.com/repos/kubernetes/autoscaler/labels/cluster-autoscaler","name":"cluster-autoscaler","color":"d4c5f9","default":false},{"id":586404823,"url":"https://api.github.com/repos/kubernetes/autoscaler/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":586406145,"url":"https://api.github.com/repos/kubernetes/autoscaler/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":677003768,"url":"https://api.github.com/repos/kubernetes/autoscaler/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900/commits","review_comments_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900/comments","review_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/900/comments","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/856855987b7a18fd382cf7950c652cb30ecfb26d","head":{"label":"MaciekPytel:nodegroup_processor","ref":"nodegroup_processor","sha":"856855987b7a18fd382cf7950c652cb30ecfb26d","user":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"repo":{"id":88637049,"name":"autoscaler","full_name":"MaciekPytel/autoscaler","owner":{"login":"MaciekPytel","id":7901030,"avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaciekPytel/autoscaler","description":null,"fork":true,"url":"https://api.github.com/repos/MaciekPytel/autoscaler","forks_url":"https://api.github.com/repos/MaciekPytel/autoscaler/forks","keys_url":"https://api.github.com/repos/MaciekPytel/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaciekPytel/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaciekPytel/autoscaler/teams","hooks_url":"https://api.github.com/repos/MaciekPytel/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/MaciekPytel/autoscaler/events","assignees_url":"https://api.github.com/repos/MaciekPytel/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/MaciekPytel/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/MaciekPytel/autoscaler/tags","blobs_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaciekPytel/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/MaciekPytel/autoscaler/languages","stargazers_url":"https://api.github.com/repos/MaciekPytel/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/MaciekPytel/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/MaciekPytel/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/MaciekPytel/autoscaler/subscription","commits_url":"https://api.github.com/repos/MaciekPytel/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaciekPytel/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaciekPytel/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaciekPytel/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/MaciekPytel/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaciekPytel/autoscaler/merges","archive_url":"https://api.github.com/repos/MaciekPytel/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaciekPytel/autoscaler/downloads","issues_url":"https://api.github.com/repos/MaciekPytel/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/MaciekPytel/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/MaciekPytel/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/MaciekPytel/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaciekPytel/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/MaciekPytel/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/MaciekPytel/autoscaler/deployments","created_at":"2017-04-18T14:51:45Z","updated_at":"2017-04-18T14:51:47Z","pushed_at":"2018-05-29T10:57:36Z","git_url":"git://github.com/MaciekPytel/autoscaler.git","ssh_url":"git@github.com:MaciekPytel/autoscaler.git","clone_url":"https://github.com/MaciekPytel/autoscaler.git","svn_url":"https://github.com/MaciekPytel/autoscaler","homepage":null,"size":37790,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5d04a11dbf6e7f09642c0d7957734d6856230f31","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":87990209,"name":"autoscaler","full_name":"kubernetes/autoscaler","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/autoscaler","description":"Autoscaling components for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/autoscaler","forks_url":"https://api.github.com/repos/kubernetes/autoscaler/forks","keys_url":"https://api.github.com/repos/kubernetes/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/autoscaler/teams","hooks_url":"https://api.github.com/repos/kubernetes/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/autoscaler/events","assignees_url":"https://api.github.com/repos/kubernetes/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/autoscaler/tags","blobs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/autoscaler/languages","stargazers_url":"https://api.github.com/repos/kubernetes/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/autoscaler/subscription","commits_url":"https://api.github.com/repos/kubernetes/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/autoscaler/merges","archive_url":"https://api.github.com/repos/kubernetes/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/autoscaler/downloads","issues_url":"https://api.github.com/repos/kubernetes/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/autoscaler/deployments","created_at":"2017-04-12T00:03:40Z","updated_at":"2018-05-29T10:52:06Z","pushed_at":"2018-05-29T11:58:42Z","git_url":"git://github.com/kubernetes/autoscaler.git","ssh_url":"git@github.com:kubernetes/autoscaler.git","clone_url":"https://github.com/kubernetes/autoscaler.git","svn_url":"https://github.com/kubernetes/autoscaler","homepage":"","size":30715,"stargazers_count":730,"watchers_count":730,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":319,"open_issues":61,"watchers":730,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/900"},"issue":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/900"},"comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/autoscaler/statuses/856855987b7a18fd382cf7950c652cb30ecfb26d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bskiba","id":3731277,"avatar_url":"https://avatars1.githubusercontent.com/u/3731277?v=4","gravatar_id":"","url":"https://api.github.com/users/bskiba","html_url":"https://github.com/bskiba","followers_url":"https://api.github.com/users/bskiba/followers","following_url":"https://api.github.com/users/bskiba/following{/other_user}","gists_url":"https://api.github.com/users/bskiba/gists{/gist_id}","starred_url":"https://api.github.com/users/bskiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bskiba/subscriptions","organizations_url":"https://api.github.com/users/bskiba/orgs","repos_url":"https://api.github.com/users/bskiba/repos","events_url":"https://api.github.com/users/bskiba/events{/privacy}","received_events_url":"https://api.github.com/users/bskiba/received_events","type":"User","site_admin":false},"comments":3,"review_comments":12,"maintainer_can_modify":false,"commits":2,"additions":363,"deletions":168,"changed_files":12}}
{"actor":{"display_login":"bskiba"}}