{"action":"opened","number":252,"pull_request":{"url":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252","id":194357230,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzU3MjMw","html_url":"https://github.com/status-im/react-native-desktop/pull/252","diff_url":"https://github.com/status-im/react-native-desktop/pull/252.diff","patch_url":"https://github.com/status-im/react-native-desktop/pull/252.patch","issue_url":"https://api.github.com/repos/status-im/react-native-desktop/issues/252","number":252,"state":"open","locked":false,"title":"Reset visual item parent on item delete request","user":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"body":"The change should resolve UI glitches, for example, on array of react-native components (issues with messages list in status-react app).\r\nDescription of issue:\r\n- react-native has optimization to render UI components defined inside array. It's implemented inside function reconcileChildrenArray ( file `Libraries/Renderer/ReactNativeRenderer-dev.js` ). On recalculation old instances might be reused for new components instances.\r\n- Sometimes arrays optimization deletes multiple UI components one by one too fast and QML scene is not able to recalculate child items for the parent container from where we resolve indexes of child items to be removed.\r\n- Setting setParentItem to nullptr seems asks parent to remove child from children list just on time of calling, so the issue is not occur any more.","created_at":"2018-06-12T17:43:38Z","updated_at":"2018-06-12T17:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252/commits","review_comments_url":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252/comments","review_comment_url":"https://api.github.com/repos/status-im/react-native-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/react-native-desktop/issues/252/comments","statuses_url":"https://api.github.com/repos/status-im/react-native-desktop/statuses/9bbbc89f2b5e33316b4e81879d092ee8446e28d6","head":{"label":"MaxRis:bug/array-reconcile-remove-childs","ref":"bug/array-reconcile-remove-childs","sha":"9bbbc89f2b5e33316b4e81879d092ee8446e28d6","user":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"repo":{"id":98623819,"node_id":"MDEwOlJlcG9zaXRvcnk5ODYyMzgxOQ==","name":"react-native-desktop","full_name":"MaxRis/react-native-desktop","owner":{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaxRis/react-native-desktop","description":"A Desktop port of React Native, driven by Qt.","fork":true,"url":"https://api.github.com/repos/MaxRis/react-native-desktop","forks_url":"https://api.github.com/repos/MaxRis/react-native-desktop/forks","keys_url":"https://api.github.com/repos/MaxRis/react-native-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaxRis/react-native-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaxRis/react-native-desktop/teams","hooks_url":"https://api.github.com/repos/MaxRis/react-native-desktop/hooks","issue_events_url":"https://api.github.com/repos/MaxRis/react-native-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/MaxRis/react-native-desktop/events","assignees_url":"https://api.github.com/repos/MaxRis/react-native-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/MaxRis/react-native-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/MaxRis/react-native-desktop/tags","blobs_url":"https://api.github.com/repos/MaxRis/react-native-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaxRis/react-native-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaxRis/react-native-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaxRis/react-native-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaxRis/react-native-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/MaxRis/react-native-desktop/languages","stargazers_url":"https://api.github.com/repos/MaxRis/react-native-desktop/stargazers","contributors_url":"https://api.github.com/repos/MaxRis/react-native-desktop/contributors","subscribers_url":"https://api.github.com/repos/MaxRis/react-native-desktop/subscribers","subscription_url":"https://api.github.com/repos/MaxRis/react-native-desktop/subscription","commits_url":"https://api.github.com/repos/MaxRis/react-native-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaxRis/react-native-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaxRis/react-native-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaxRis/react-native-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaxRis/react-native-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/MaxRis/react-native-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaxRis/react-native-desktop/merges","archive_url":"https://api.github.com/repos/MaxRis/react-native-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaxRis/react-native-desktop/downloads","issues_url":"https://api.github.com/repos/MaxRis/react-native-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/MaxRis/react-native-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/MaxRis/react-native-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/MaxRis/react-native-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaxRis/react-native-desktop/labels{/name}","releases_url":"https://api.github.com/repos/MaxRis/react-native-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/MaxRis/react-native-desktop/deployments","created_at":"2017-07-28T07:48:56Z","updated_at":"2018-05-14T17:24:27Z","pushed_at":"2018-06-12T17:31:00Z","git_url":"git://github.com/MaxRis/react-native-desktop.git","ssh_url":"git@github.com:MaxRis/react-native-desktop.git","clone_url":"https://github.com/MaxRis/react-native-desktop.git","svn_url":"https://github.com/MaxRis/react-native-desktop","homepage":null,"size":82535,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"status-im:master","ref":"master","sha":"61935b2f8e566a13def360ea357ad56f7560c652","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":98602175,"node_id":"MDEwOlJlcG9zaXRvcnk5ODYwMjE3NQ==","name":"react-native-desktop","full_name":"status-im/react-native-desktop","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/react-native-desktop","description":"A Desktop port of React Native, driven by Qt, forked from Canonical","fork":false,"url":"https://api.github.com/repos/status-im/react-native-desktop","forks_url":"https://api.github.com/repos/status-im/react-native-desktop/forks","keys_url":"https://api.github.com/repos/status-im/react-native-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/react-native-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/react-native-desktop/teams","hooks_url":"https://api.github.com/repos/status-im/react-native-desktop/hooks","issue_events_url":"https://api.github.com/repos/status-im/react-native-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/react-native-desktop/events","assignees_url":"https://api.github.com/repos/status-im/react-native-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/react-native-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/react-native-desktop/tags","blobs_url":"https://api.github.com/repos/status-im/react-native-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/react-native-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/react-native-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/react-native-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/react-native-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/react-native-desktop/languages","stargazers_url":"https://api.github.com/repos/status-im/react-native-desktop/stargazers","contributors_url":"https://api.github.com/repos/status-im/react-native-desktop/contributors","subscribers_url":"https://api.github.com/repos/status-im/react-native-desktop/subscribers","subscription_url":"https://api.github.com/repos/status-im/react-native-desktop/subscription","commits_url":"https://api.github.com/repos/status-im/react-native-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/react-native-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/react-native-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/react-native-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/react-native-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/react-native-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/react-native-desktop/merges","archive_url":"https://api.github.com/repos/status-im/react-native-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/react-native-desktop/downloads","issues_url":"https://api.github.com/repos/status-im/react-native-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/react-native-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/react-native-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/react-native-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/react-native-desktop/labels{/name}","releases_url":"https://api.github.com/repos/status-im/react-native-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/react-native-desktop/deployments","created_at":"2017-07-28T03:04:23Z","updated_at":"2018-06-12T17:10:46Z","pushed_at":"2018-06-12T17:10:45Z","git_url":"git://github.com/status-im/react-native-desktop.git","ssh_url":"git@github.com:status-im/react-native-desktop.git","clone_url":"https://github.com/status-im/react-native-desktop.git","svn_url":"https://github.com/status-im/react-native-desktop","homepage":"","size":105693,"stargazers_count":281,"watchers_count":281,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":35,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252"},"html":{"href":"https://github.com/status-im/react-native-desktop/pull/252"},"issue":{"href":"https://api.github.com/repos/status-im/react-native-desktop/issues/252"},"comments":{"href":"https://api.github.com/repos/status-im/react-native-desktop/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/react-native-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/react-native-desktop/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/react-native-desktop/statuses/9bbbc89f2b5e33316b4e81879d092ee8446e28d6"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"MaxRis"}}