{"action":"created","comment":{"url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/comments/199715518","pull_request_review_id":133886132,"id":199715518,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTcxNTUxOA==","diff_hunk":"@@ -0,0 +1,39 @@\n+namespace Starcounter.Nova.Administration\n+{\n+    using System;\n+    using System.Collections.Generic;\n+    using System.IO;\n+    using System.Linq;\n+\n+    public class DbList\n+    {\n+        private string _path;\n+        private IDirectoryHelper _dirHelper;\n+        private IDbAnalyzer _analyzer;\n+        public IEnumerable<(string name, string path)> Databases { get; }\n+\n+        public DbList(string path, IDirectoryHelper dirHelper = null, IDbAnalyzer analyzer = null)\n+        {\n+            _path = path ?? throw new ArgumentNullException(nameof(path));\n+            _dirHelper = dirHelper ?? new SystemDirectoryHelper();\n+            _analyzer = analyzer ?? new LenientDbAnalyzer();\n+\n+            if (!_dirHelper.DirectoryExists(path))","path":"src/Starcounter.Nova.Administration/Database/DbList.cs","position":21,"original_position":21,"commit_id":"9c983f8901a5df24229187f6a2b0ee195955a2a8","original_commit_id":"9c983f8901a5df24229187f6a2b0ee195955a2a8","user":{"login":"per-samuelsson","id":2902045,"node_id":"MDQ6VXNlcjI5MDIwNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2902045?v=4","gravatar_id":"","url":"https://api.github.com/users/per-samuelsson","html_url":"https://github.com/per-samuelsson","followers_url":"https://api.github.com/users/per-samuelsson/followers","following_url":"https://api.github.com/users/per-samuelsson/following{/other_user}","gists_url":"https://api.github.com/users/per-samuelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/per-samuelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/per-samuelsson/subscriptions","organizations_url":"https://api.github.com/users/per-samuelsson/orgs","repos_url":"https://api.github.com/users/per-samuelsson/repos","events_url":"https://api.github.com/users/per-samuelsson/events{/privacy}","received_events_url":"https://api.github.com/users/per-samuelsson/received_events","type":"User","site_admin":false},"body":"In other places, you use brackets even for single-line statements. Make them consistent?","created_at":"2018-07-03T08:00:26Z","updated_at":"2018-07-03T08:10:37Z","html_url":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27#discussion_r199715518","pull_request_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/comments/199715518"},"html":{"href":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27#discussion_r199715518"},"pull_request":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27","id":198875709,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODc1NzA5","html_url":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27","diff_url":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27.diff","patch_url":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27.patch","issue_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/27","number":27,"state":"open","locked":false,"title":"Implement list command","user":{"login":"Mackiovello","id":19392292,"node_id":"MDQ6VXNlcjE5MzkyMjky","avatar_url":"https://avatars2.githubusercontent.com/u/19392292?v=4","gravatar_id":"","url":"https://api.github.com/users/Mackiovello","html_url":"https://github.com/Mackiovello","followers_url":"https://api.github.com/users/Mackiovello/followers","following_url":"https://api.github.com/users/Mackiovello/following{/other_user}","gists_url":"https://api.github.com/users/Mackiovello/gists{/gist_id}","starred_url":"https://api.github.com/users/Mackiovello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mackiovello/subscriptions","organizations_url":"https://api.github.com/users/Mackiovello/orgs","repos_url":"https://api.github.com/users/Mackiovello/repos","events_url":"https://api.github.com/users/Mackiovello/events{/privacy}","received_events_url":"https://api.github.com/users/Mackiovello/received_events","type":"User","site_admin":false},"body":"Very simple implementation of the list command, it just lists the names of the databases in a directory. \r\n\r\n```\r\n$ star list --help\r\nList databases in directory\r\n\r\nUsage:  list [arguments] [options]\r\n\r\nArguments:\r\n  directory     The directory with databases\r\n\r\nOptions:\r\n  -?|-h|--help  Show help information\r\n```\r\n\r\nI think we should keep the default implementation like this, and if people want to be able to get information when they list the databases, we can add flags for that.","created_at":"2018-07-03T07:43:10Z","updated_at":"2018-07-03T08:10:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eabb69a1d4ff801228d67b0aba04dbf12149736","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/27/comments","statuses_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/statuses/9c983f8901a5df24229187f6a2b0ee195955a2a8","head":{"label":"Starcounter:issue/15","ref":"issue/15","sha":"9c983f8901a5df24229187f6a2b0ee195955a2a8","user":{"login":"Starcounter","id":1219066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":137748602,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NDg2MDI=","name":"Starcounter.Nova.Cli","full_name":"Starcounter/Starcounter.Nova.Cli","owner":{"login":"Starcounter","id":1219066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Starcounter.Nova.Cli","description":"Command Line Interface to manage Nova applications","fork":false,"url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli","forks_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/forks","keys_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/teams","hooks_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/events","assignees_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/tags","blobs_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/subscription","commits_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/merges","archive_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/downloads","issues_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/deployments","created_at":"2018-06-18T12:24:14Z","updated_at":"2018-07-02T13:07:35Z","pushed_at":"2018-07-03T07:43:11Z","git_url":"git://github.com/Starcounter/Starcounter.Nova.Cli.git","ssh_url":"git@github.com:Starcounter/Starcounter.Nova.Cli.git","clone_url":"https://github.com/Starcounter/Starcounter.Nova.Cli.git","svn_url":"https://github.com/Starcounter/Starcounter.Nova.Cli","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"base":{"label":"Starcounter:develop","ref":"develop","sha":"aabc51d19f4986b7513f04490c42721ca8e11c15","user":{"login":"Starcounter","id":1219066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":137748602,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NDg2MDI=","name":"Starcounter.Nova.Cli","full_name":"Starcounter/Starcounter.Nova.Cli","owner":{"login":"Starcounter","id":1219066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTkwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Starcounter.Nova.Cli","description":"Command Line Interface to manage Nova applications","fork":false,"url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli","forks_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/forks","keys_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/teams","hooks_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/events","assignees_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/tags","blobs_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/subscription","commits_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/merges","archive_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/downloads","issues_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/deployments","created_at":"2018-06-18T12:24:14Z","updated_at":"2018-07-02T13:07:35Z","pushed_at":"2018-07-03T07:43:11Z","git_url":"git://github.com/Starcounter/Starcounter.Nova.Cli.git","ssh_url":"git@github.com:Starcounter/Starcounter.Nova.Cli.git","clone_url":"https://github.com/Starcounter/Starcounter.Nova.Cli.git","svn_url":"https://github.com/Starcounter/Starcounter.Nova.Cli","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27"},"html":{"href":"https://github.com/Starcounter/Starcounter.Nova.Cli/pull/27"},"issue":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/27"},"comments":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Starcounter/Starcounter.Nova.Cli/statuses/9c983f8901a5df24229187f6a2b0ee195955a2a8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"per-samuelsson"}}