{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/214428773","pull_request_review_id":151491665,"id":214428773,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQyODc3Mw==","diff_hunk":"@@ -57,5 +44,73 @@ def parse\n     def inventory_collections\n       parse.inventory_collections\n     end\n+\n+    # Based on the given provider/manager class, this returns correct persister class\n+    #\n+    # @param klass class of the Provider/Manager\n+    # @return [Class] Correct class name of the persister\n+    def self.persister_class_for(klass)","path":"app/models/manageiq/providers/inventory.rb","position":43,"original_position":43,"commit_id":"f3fd91df916f7e414cf4f9dd82108fbe379fd3e3","original_commit_id":"340565cd58f6a616169ae564f0ee4125ed1d365f","user":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"body":"I'm good with this for now, I think these should all be private and then all of the yardoc comments are unnecessary","created_at":"2018-08-31T17:47:22Z","updated_at":"2018-08-31T17:47:22Z","html_url":"https://github.com/ManageIQ/manageiq/pull/17907#discussion_r214428773","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/214428773"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17907#discussion_r214428773"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907"}},"in_reply_to_id":214274958},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907","id":211097583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDk3NTgz","html_url":"https://github.com/ManageIQ/manageiq/pull/17907","diff_url":"https://github.com/ManageIQ/manageiq/pull/17907.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17907.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17907","number":17907,"state":"open","locked":false,"title":"Moving Inventory::Builder's functions to Inventory class","user":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"body":"Before this PR all providers with graph refresh repeats the same code for their inventory builders.\r\nThey didn't inherit from any common class (except Object, of course :).\r\nThis PR makes common methods in `ManageIQ::Providers::Inventory`, then all provider-specific builders can be removed.\r\n- **dependent** https://github.com/ManageIQ/manageiq-providers-amazon/pull/480\r\n- **dependent** https://github.com/ManageIQ/manageiq-providers-google/pull/67","created_at":"2018-08-27T12:41:57Z","updated_at":"2018-08-31T17:47:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c75d613a956227b40123f0485ca211897eb6ae1","assignee":{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"assignees":[{"login":"agrare","id":12851112,"node_id":"MDQ6VXNlcjEyODUxMTEy","avatar_url":"https://avatars2.githubusercontent.com/u/12851112?v=4","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":110594929,"node_id":"MDU6TGFiZWwxMTA1OTQ5Mjk=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04","default":false},{"id":495693084,"node_id":"MDU6TGFiZWw0OTU2OTMwODQ=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/unmergeable","name":"unmergeable","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17907/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f3fd91df916f7e414cf4f9dd82108fbe379fd3e3","head":{"label":"slemrmartin:inventory-builder","ref":"inventory-builder","sha":"f3fd91df916f7e414cf4f9dd82108fbe379fd3e3","user":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"repo":{"id":123601697,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2MDE2OTc=","name":"manageiq","full_name":"slemrmartin/manageiq","owner":{"login":"slemrmartin","id":1814995,"node_id":"MDQ6VXNlcjE4MTQ5OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1814995?v=4","gravatar_id":"","url":"https://api.github.com/users/slemrmartin","html_url":"https://github.com/slemrmartin","followers_url":"https://api.github.com/users/slemrmartin/followers","following_url":"https://api.github.com/users/slemrmartin/following{/other_user}","gists_url":"https://api.github.com/users/slemrmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/slemrmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slemrmartin/subscriptions","organizations_url":"https://api.github.com/users/slemrmartin/orgs","repos_url":"https://api.github.com/users/slemrmartin/repos","events_url":"https://api.github.com/users/slemrmartin/events{/privacy}","received_events_url":"https://api.github.com/users/slemrmartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slemrmartin/manageiq","description":"ManageIQ Open-Source Management Platform","fork":true,"url":"https://api.github.com/repos/slemrmartin/manageiq","forks_url":"https://api.github.com/repos/slemrmartin/manageiq/forks","keys_url":"https://api.github.com/repos/slemrmartin/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slemrmartin/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slemrmartin/manageiq/teams","hooks_url":"https://api.github.com/repos/slemrmartin/manageiq/hooks","issue_events_url":"https://api.github.com/repos/slemrmartin/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/slemrmartin/manageiq/events","assignees_url":"https://api.github.com/repos/slemrmartin/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/slemrmartin/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/slemrmartin/manageiq/tags","blobs_url":"https://api.github.com/repos/slemrmartin/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slemrmartin/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slemrmartin/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/slemrmartin/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slemrmartin/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/slemrmartin/manageiq/languages","stargazers_url":"https://api.github.com/repos/slemrmartin/manageiq/stargazers","contributors_url":"https://api.github.com/repos/slemrmartin/manageiq/contributors","subscribers_url":"https://api.github.com/repos/slemrmartin/manageiq/subscribers","subscription_url":"https://api.github.com/repos/slemrmartin/manageiq/subscription","commits_url":"https://api.github.com/repos/slemrmartin/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/slemrmartin/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/slemrmartin/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/slemrmartin/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/slemrmartin/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/slemrmartin/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slemrmartin/manageiq/merges","archive_url":"https://api.github.com/repos/slemrmartin/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slemrmartin/manageiq/downloads","issues_url":"https://api.github.com/repos/slemrmartin/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/slemrmartin/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/slemrmartin/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/slemrmartin/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slemrmartin/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/slemrmartin/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/slemrmartin/manageiq/deployments","created_at":"2018-03-02T16:16:29Z","updated_at":"2018-07-25T07:39:02Z","pushed_at":"2018-08-31T17:46:16Z","git_url":"git://github.com/slemrmartin/manageiq.git","ssh_url":"git@github.com:slemrmartin/manageiq.git","clone_url":"https://github.com/slemrmartin/manageiq.git","svn_url":"https://github.com/slemrmartin/manageiq","homepage":"manageiq.org","size":244563,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2f9a1dda0a934a9078a20f16e86a109db78ba357","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc4OTc1Nw==","name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2018-08-31T14:50:01Z","pushed_at":"2018-08-31T17:46:18Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":256249,"stargazers_count":696,"watchers_count":696,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":653,"mirror_url":null,"archived":false,"open_issues_count":591,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":653,"open_issues":591,"watchers":696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/17907"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17907"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/17907/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17907/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f3fd91df916f7e414cf4f9dd82108fbe379fd3e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agrare"}}