{"action":"closed","issue":{"url":"https://api.github.com/repos/skatejs/skatejs/issues/1523","repository_url":"https://api.github.com/repos/skatejs/skatejs","labels_url":"https://api.github.com/repos/skatejs/skatejs/issues/1523/labels{/name}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/1523/comments","events_url":"https://api.github.com/repos/skatejs/skatejs/issues/1523/events","html_url":"https://github.com/skatejs/skatejs/issues/1523","id":356574019,"node_id":"MDU6SXNzdWUzNTY1NzQwMTk=","number":1523,"title":"[v6-trey] avoid equality checking of props, leaving it to end users","user":{"login":"trusktr","id":297678,"node_id":"MDQ6VXNlcjI5NzY3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/297678?v=4","gravatar_id":"","url":"https://api.github.com/users/trusktr","html_url":"https://github.com/trusktr","followers_url":"https://api.github.com/users/trusktr/followers","following_url":"https://api.github.com/users/trusktr/following{/other_user}","gists_url":"https://api.github.com/users/trusktr/gists{/gist_id}","starred_url":"https://api.github.com/users/trusktr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trusktr/subscriptions","organizations_url":"https://api.github.com/users/trusktr/orgs","repos_url":"https://api.github.com/users/trusktr/repos","events_url":"https://api.github.com/users/trusktr/events{/privacy}","received_events_url":"https://api.github.com/users/trusktr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-03T17:53:43Z","updated_at":"2018-09-04T12:29:26Z","closed_at":"2018-09-04T12:29:26Z","author_association":"CONTRIBUTOR","body":"https://github.com/skatejs/skatejs/blob/4aa99272e2a4e1fd8663464340f25c1fe6ead72e/packages/skatejs/src/component.ts#L47-L50\r\n\r\nIf a prop is designed to return the same instance (there are reasons!), then this check will not work.\r\n\r\nIt would be better to add the changed props to a list when they are set, regardless of equality. Then the user can either check the list of changed props, or decide to do equality checking. It's more flexible that way.\r\n\r\nThe idea would be more like in PR https://github.com/skatejs/skatejs/pull/1510, where we give the user old values as well as a list of props that were set (even if the value is the same)."}}
{"actor":{"display_login":"treshugart"}}