{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/comments/207915760","pull_request_review_id":143622333,"id":207915760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzkxNTc2MA==","diff_hunk":"@@ -1,6 +1,6 @@\n julia 0.6\n-MathProgBase 0.6 0.8\n-ReverseDiffSparse 0.8 0.9\n-ForwardDiff 0.5 0.8\n+MathProgBase 0.6","path":"REQUIRE","position":5,"original_position":5,"commit_id":"76c1c3f0aa3bf767a77376c175998e31adf1affb","original_commit_id":"76c1c3f0aa3bf767a77376c175998e31adf1affb","user":{"login":"blegat","id":1048205,"node_id":"MDQ6VXNlcjEwNDgyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1048205?v=4","gravatar_id":"","url":"https://api.github.com/users/blegat","html_url":"https://github.com/blegat","followers_url":"https://api.github.com/users/blegat/followers","following_url":"https://api.github.com/users/blegat/following{/other_user}","gists_url":"https://api.github.com/users/blegat/gists{/gist_id}","starred_url":"https://api.github.com/users/blegat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blegat/subscriptions","organizations_url":"https://api.github.com/users/blegat/orgs","repos_url":"https://api.github.com/users/blegat/repos","events_url":"https://api.github.com/users/blegat/events{/privacy}","received_events_url":"https://api.github.com/users/blegat/received_events","type":"User","site_admin":false},"body":"Why removing the upper bounds ?","created_at":"2018-08-06T14:40:48Z","updated_at":"2018-08-06T14:40:48Z","html_url":"https://github.com/JuliaOpt/JuMP.jl/pull/1404#discussion_r207915760","pull_request_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/comments/207915760"},"html":{"href":"https://github.com/JuliaOpt/JuMP.jl/pull/1404#discussion_r207915760"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404","id":206256198,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjU2MTk4","html_url":"https://github.com/JuliaOpt/JuMP.jl/pull/1404","diff_url":"https://github.com/JuliaOpt/JuMP.jl/pull/1404.diff","patch_url":"https://github.com/JuliaOpt/JuMP.jl/pull/1404.patch","issue_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/1404","number":1404,"state":"open","locked":false,"title":"[release-0.18] more fixes for 0.7","user":{"login":"ExpandingMan","id":11379353,"node_id":"MDQ6VXNlcjExMzc5MzUz","avatar_url":"https://avatars0.githubusercontent.com/u/11379353?v=4","gravatar_id":"","url":"https://api.github.com/users/ExpandingMan","html_url":"https://github.com/ExpandingMan","followers_url":"https://api.github.com/users/ExpandingMan/followers","following_url":"https://api.github.com/users/ExpandingMan/following{/other_user}","gists_url":"https://api.github.com/users/ExpandingMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ExpandingMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExpandingMan/subscriptions","organizations_url":"https://api.github.com/users/ExpandingMan/orgs","repos_url":"https://api.github.com/users/ExpandingMan/repos","events_url":"https://api.github.com/users/ExpandingMan/events{/privacy}","received_events_url":"https://api.github.com/users/ExpandingMan/received_events","type":"User","site_admin":false},"body":"Hello all.  I've continued the process of getting 0.18 up and running on 0.7.  As this will be a long process, I'm hoping that we can do this with lots of small PR's like this one, not worrying much about whether we are passing tests on 0.7 until things are a little further along.  (When I updated DataFrames.jl for 0.7 I did one gigantic PR, and it was not a good way of doing it.)\r\n\r\nThe biggest changes I've made so far are probably implementing `iterate` methods and constructors (as now `convert` falls back to constructors and not vice versa).\r\n\r\nMany of the errors are macro errors, and as the macro code is incredibly dense these will be the hardest to work on, so I've avoided fixing macros so far.\r\n\r\nI have a question concerning the desired print behavior, so that perhaps I can make another fix before this gets merged.  Looking at the test set starting [here](https://github.com/JuliaOpt/JuMP.jl/blob/release-0.18/test/print.jl#L179) I cannot understand why `empty_set` and `empty_free` would be expected to print differently.  They are both variables being initialized with empty arrays, both of those macros create `JuMPContainer` objects with very similar type signatures exactly as I would expect them to.  The code in `print.jl` prints `empty_free` as `empty_free (no indices)` and, having poured through that code, it seems like the intended behavior, so I don't understand why that test is that way.  Note that [this line](https://github.com/JuliaOpt/JuMP.jl/blob/release-0.18/src/print.jl#L411) causes all `JuMPContainer`s to print with the name they were initialized with, as I would expect.  Perhaps this is an error in the macro parsing and `empty_free` was supposed to be an `Array{Variable}`?\r\n\r\nAnyway, any suggestions for simply fixing this PR up a bit more before moving onto the next iteration would be appreciated.  Thanks!","created_at":"2018-08-05T20:28:42Z","updated_at":"2018-08-06T14:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49bcbf47aaad6666e675bcfb75b98d76be5a75ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/1404/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/statuses/76c1c3f0aa3bf767a77376c175998e31adf1affb","head":{"label":"ExpandingMan:more7fixes","ref":"more7fixes","sha":"76c1c3f0aa3bf767a77376c175998e31adf1affb","user":{"login":"ExpandingMan","id":11379353,"node_id":"MDQ6VXNlcjExMzc5MzUz","avatar_url":"https://avatars0.githubusercontent.com/u/11379353?v=4","gravatar_id":"","url":"https://api.github.com/users/ExpandingMan","html_url":"https://github.com/ExpandingMan","followers_url":"https://api.github.com/users/ExpandingMan/followers","following_url":"https://api.github.com/users/ExpandingMan/following{/other_user}","gists_url":"https://api.github.com/users/ExpandingMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ExpandingMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExpandingMan/subscriptions","organizations_url":"https://api.github.com/users/ExpandingMan/orgs","repos_url":"https://api.github.com/users/ExpandingMan/repos","events_url":"https://api.github.com/users/ExpandingMan/events{/privacy}","received_events_url":"https://api.github.com/users/ExpandingMan/received_events","type":"User","site_admin":false},"repo":{"id":75661928,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY2MTkyOA==","name":"JuMP.jl","full_name":"ExpandingMan/JuMP.jl","owner":{"login":"ExpandingMan","id":11379353,"node_id":"MDQ6VXNlcjExMzc5MzUz","avatar_url":"https://avatars0.githubusercontent.com/u/11379353?v=4","gravatar_id":"","url":"https://api.github.com/users/ExpandingMan","html_url":"https://github.com/ExpandingMan","followers_url":"https://api.github.com/users/ExpandingMan/followers","following_url":"https://api.github.com/users/ExpandingMan/following{/other_user}","gists_url":"https://api.github.com/users/ExpandingMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ExpandingMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExpandingMan/subscriptions","organizations_url":"https://api.github.com/users/ExpandingMan/orgs","repos_url":"https://api.github.com/users/ExpandingMan/repos","events_url":"https://api.github.com/users/ExpandingMan/events{/privacy}","received_events_url":"https://api.github.com/users/ExpandingMan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ExpandingMan/JuMP.jl","description":"Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)","fork":true,"url":"https://api.github.com/repos/ExpandingMan/JuMP.jl","forks_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/forks","keys_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/teams","hooks_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/hooks","issue_events_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/events","assignees_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/tags","blobs_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/languages","stargazers_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/stargazers","contributors_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/contributors","subscribers_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/subscribers","subscription_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/subscription","commits_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/merges","archive_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/downloads","issues_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/labels{/name}","releases_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/ExpandingMan/JuMP.jl/deployments","created_at":"2016-12-05T20:10:20Z","updated_at":"2016-12-05T20:10:22Z","pushed_at":"2018-08-06T14:33:00Z","git_url":"git://github.com/ExpandingMan/JuMP.jl.git","ssh_url":"git@github.com:ExpandingMan/JuMP.jl.git","clone_url":"https://github.com/ExpandingMan/JuMP.jl.git","svn_url":"https://github.com/ExpandingMan/JuMP.jl","homepage":"","size":6912,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaOpt:release-0.18","ref":"release-0.18","sha":"5c30d4fc9f3098fba6a70817013d5869b6729681","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":6150069,"node_id":"MDEwOlJlcG9zaXRvcnk2MTUwMDY5","name":"JuMP.jl","full_name":"JuliaOpt/JuMP.jl","owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/JuMP.jl","description":"Modeling language for Mathematical Optimization (linear, mixed-integer, conic, semidefinite, nonlinear)","fork":false,"url":"https://api.github.com/repos/JuliaOpt/JuMP.jl","forks_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/JuMP.jl/deployments","created_at":"2012-10-10T00:34:45Z","updated_at":"2018-08-06T14:02:33Z","pushed_at":"2018-08-06T14:33:02Z","git_url":"git://github.com/JuliaOpt/JuMP.jl.git","ssh_url":"git@github.com:JuliaOpt/JuMP.jl.git","clone_url":"https://github.com/JuliaOpt/JuMP.jl.git","svn_url":"https://github.com/JuliaOpt/JuMP.jl","homepage":"","size":10859,"stargazers_count":515,"watchers_count":515,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":80,"watchers":515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404"},"html":{"href":"https://github.com/JuliaOpt/JuMP.jl/pull/1404"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/1404"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/issues/1404/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/pulls/1404/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/JuMP.jl/statuses/76c1c3f0aa3bf767a77376c175998e31adf1affb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blegat"}}