{"action":"created","issue":{"url":"https://api.github.com/repos/fulcrologic/fulcro/issues/220","repository_url":"https://api.github.com/repos/fulcrologic/fulcro","labels_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/220/comments","events_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/220/events","html_url":"https://github.com/fulcrologic/fulcro/pull/220","id":342444244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzQyODg1","number":220,"title":"Added remove-ident function with specs to primitives","user":{"login":"currentoor","id":2679997,"node_id":"MDQ6VXNlcjI2Nzk5OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2679997?v=4","gravatar_id":"","url":"https://api.github.com/users/currentoor","html_url":"https://github.com/currentoor","followers_url":"https://api.github.com/users/currentoor/followers","following_url":"https://api.github.com/users/currentoor/following{/other_user}","gists_url":"https://api.github.com/users/currentoor/gists{/gist_id}","starred_url":"https://api.github.com/users/currentoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/currentoor/subscriptions","organizations_url":"https://api.github.com/users/currentoor/orgs","repos_url":"https://api.github.com/users/currentoor/repos","events_url":"https://api.github.com/users/currentoor/events{/privacy}","received_events_url":"https://api.github.com/users/currentoor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-18T18:36:28Z","updated_at":"2018-07-24T14:53:29Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fulcrologic/fulcro/pulls/220","html_url":"https://github.com/fulcrologic/fulcro/pull/220","diff_url":"https://github.com/fulcrologic/fulcro/pull/220.diff","patch_url":"https://github.com/fulcrologic/fulcro/pull/220.patch"},"body":"@awkay you said\r\n\r\n> 1. Helper functions for targeted state manipulation when you know what you want to remove. Not really GC, but helpful. These would be functions like remove-ident, delete-form-state, etc.\r\n> 2. Semi-automated GC...e.g. (recursive-delete some-ident), which delete the table entry at ident, and ALSO follows idents starting at that entity, and removes all children. This requires something like a white-list/black-list of table names, or a set of \"isComponent\" Datomic-like indicators to prevent unintentional traversal.\r\n> 3. Fully-automated GC. The function scans entire app state removing things that are not referenced. This one also needs \"help\" in that unions may not be currently pointing at data that needs to be kept.\r\n\r\nAt the moment I only needed (1), so that's all I did. If the need for (2) or (3) arrises, I'll submit another PR.\r\n\r\nAlso, after this is merged I can update the book examples to use it. \r\n\r\nhttps://github.com/fulcrologic/fulcro/issues/216"},"comment":{"url":"https://api.github.com/repos/fulcrologic/fulcro/issues/comments/407436004","html_url":"https://github.com/fulcrologic/fulcro/pull/220#issuecomment-407436004","issue_url":"https://api.github.com/repos/fulcrologic/fulcro/issues/220","id":407436004,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzQzNjAwNA==","user":{"login":"awkay","id":1177083,"node_id":"MDQ6VXNlcjExNzcwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1177083?v=4","gravatar_id":"","url":"https://api.github.com/users/awkay","html_url":"https://github.com/awkay","followers_url":"https://api.github.com/users/awkay/followers","following_url":"https://api.github.com/users/awkay/following{/other_user}","gists_url":"https://api.github.com/users/awkay/gists{/gist_id}","starred_url":"https://api.github.com/users/awkay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awkay/subscriptions","organizations_url":"https://api.github.com/users/awkay/orgs","repos_url":"https://api.github.com/users/awkay/repos","events_url":"https://api.github.com/users/awkay/events{/privacy}","received_events_url":"https://api.github.com/users/awkay/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T14:53:29Z","updated_at":"2018-07-24T14:53:29Z","author_association":"MEMBER","body":"Getting closer...just one code thing to test (no sente options) and a docstring fix."}}
{"actor":{"display_login":"awkay"}}