{"action":"created","issue":{"url":"https://api.github.com/repos/google/ggrc-core/issues/8580","repository_url":"https://api.github.com/repos/google/ggrc-core","labels_url":"https://api.github.com/repos/google/ggrc-core/issues/8580/labels{/name}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/8580/comments","events_url":"https://api.github.com/repos/google/ggrc-core/issues/8580/events","html_url":"https://github.com/google/ggrc-core/pull/8580","id":371855307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjA3MzIw","number":8580,"title":"GGRC-3374 fix CAD reindexing after Creation/Deleting ","user":{"login":"alekseev-aa","id":43849923,"node_id":"MDQ6VXNlcjQzODQ5OTIz","avatar_url":"https://avatars1.githubusercontent.com/u/43849923?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseev-aa","html_url":"https://github.com/alekseev-aa","followers_url":"https://api.github.com/users/alekseev-aa/followers","following_url":"https://api.github.com/users/alekseev-aa/following{/other_user}","gists_url":"https://api.github.com/users/alekseev-aa/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseev-aa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseev-aa/subscriptions","organizations_url":"https://api.github.com/users/alekseev-aa/orgs","repos_url":"https://api.github.com/users/alekseev-aa/repos","events_url":"https://api.github.com/users/alekseev-aa/events{/privacy}","received_events_url":"https://api.github.com/users/alekseev-aa/received_events","type":"User","site_admin":false},"labels":[{"id":653911749,"node_id":"MDU6TGFiZWw2NTM5MTE3NDk=","url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":835304430,"node_id":"MDU6TGFiZWw4MzUzMDQ0MzA=","url":"https://api.github.com/repos/google/ggrc-core/labels/needs%20selenium%20fix","name":"needs selenium fix","color":"f75be2","default":false},{"id":86898803,"node_id":"MDU6TGFiZWw4Njg5ODgwMw==","url":"https://api.github.com/repos/google/ggrc-core/labels/needs%20work","name":"needs work","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"mashabarashko","id":2690200,"node_id":"MDQ6VXNlcjI2OTAyMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2690200?v=4","gravatar_id":"","url":"https://api.github.com/users/mashabarashko","html_url":"https://github.com/mashabarashko","followers_url":"https://api.github.com/users/mashabarashko/followers","following_url":"https://api.github.com/users/mashabarashko/following{/other_user}","gists_url":"https://api.github.com/users/mashabarashko/gists{/gist_id}","starred_url":"https://api.github.com/users/mashabarashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mashabarashko/subscriptions","organizations_url":"https://api.github.com/users/mashabarashko/orgs","repos_url":"https://api.github.com/users/mashabarashko/repos","events_url":"https://api.github.com/users/mashabarashko/events{/privacy}","received_events_url":"https://api.github.com/users/mashabarashko/received_events","type":"User","site_admin":false},"assignees":[{"login":"mashabarashko","id":2690200,"node_id":"MDQ6VXNlcjI2OTAyMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2690200?v=4","gravatar_id":"","url":"https://api.github.com/users/mashabarashko","html_url":"https://github.com/mashabarashko","followers_url":"https://api.github.com/users/mashabarashko/followers","following_url":"https://api.github.com/users/mashabarashko/following{/other_user}","gists_url":"https://api.github.com/users/mashabarashko/gists{/gist_id}","starred_url":"https://api.github.com/users/mashabarashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mashabarashko/subscriptions","organizations_url":"https://api.github.com/users/mashabarashko/orgs","repos_url":"https://api.github.com/users/mashabarashko/repos","events_url":"https://api.github.com/users/mashabarashko/events{/privacy}","received_events_url":"https://api.github.com/users/mashabarashko/received_events","type":"User","site_admin":false},{"login":"Tobichimaru","id":7455821,"node_id":"MDQ6VXNlcjc0NTU4MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7455821?v=4","gravatar_id":"","url":"https://api.github.com/users/Tobichimaru","html_url":"https://github.com/Tobichimaru","followers_url":"https://api.github.com/users/Tobichimaru/followers","following_url":"https://api.github.com/users/Tobichimaru/following{/other_user}","gists_url":"https://api.github.com/users/Tobichimaru/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobichimaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobichimaru/subscriptions","organizations_url":"https://api.github.com/users/Tobichimaru/orgs","repos_url":"https://api.github.com/users/Tobichimaru/repos","events_url":"https://api.github.com/users/Tobichimaru/events{/privacy}","received_events_url":"https://api.github.com/users/Tobichimaru/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/119","html_url":"https://github.com/google/ggrc-core/milestone/119","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/119/labels","id":3764391,"node_id":"MDk6TWlsZXN0b25lMzc2NDM5MQ==","number":119,"title":"1.31.0-Strawberry","description":"","creator":{"login":"k-alexey","id":38530214,"node_id":"MDQ6VXNlcjM4NTMwMjE0","avatar_url":"https://avatars0.githubusercontent.com/u/38530214?v=4","gravatar_id":"","url":"https://api.github.com/users/k-alexey","html_url":"https://github.com/k-alexey","followers_url":"https://api.github.com/users/k-alexey/followers","following_url":"https://api.github.com/users/k-alexey/following{/other_user}","gists_url":"https://api.github.com/users/k-alexey/gists{/gist_id}","starred_url":"https://api.github.com/users/k-alexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-alexey/subscriptions","organizations_url":"https://api.github.com/users/k-alexey/orgs","repos_url":"https://api.github.com/users/k-alexey/repos","events_url":"https://api.github.com/users/k-alexey/events{/privacy}","received_events_url":"https://api.github.com/users/k-alexey/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":13,"state":"open","created_at":"2018-10-24T09:08:07Z","updated_at":"2018-11-08T07:55:47Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-10-19T08:26:33Z","updated_at":"2018-11-08T09:43:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/8580","html_url":"https://github.com/google/ggrc-core/pull/8580","diff_url":"https://github.com/google/ggrc-core/pull/8580.diff","patch_url":"https://github.com/google/ggrc-core/pull/8580.patch"},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\n*Creation/Editing of CAD doesn't bring to reindexing of all the entities connected with CAD.*\r\n\r\n# Steps to test the changes\r\n\r\n1. Create CAD (checkbox) for any object type, e.g. assessment \r\n2. Search by CAD, \"CAD = no\": no result \r\n3. Update assessment, but do not update CAD \r\n4. Search by CAD, \"CAD = no\": success\r\n\r\n# Solution description\r\n\r\n*Changed hook after creating or deleting CustomAttributeDefinition. Revisions and reindex are created using chunks*\r\n\r\n# Sanity checklist\r\n\r\n- [ ] I have clicked through the app to make sure my changes work and not break the app.\r\n- [x] I have applied the correct milestone and labels.\r\n- [ ] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [x] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [x] Labels and milestone are correctly set.\r\n- [x] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [x] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/google/ggrc-core/issues/comments/436933943","html_url":"https://github.com/google/ggrc-core/pull/8580#issuecomment-436933943","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/8580","id":436933943,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjkzMzk0Mw==","user":{"login":"mashabarashko","id":2690200,"node_id":"MDQ6VXNlcjI2OTAyMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2690200?v=4","gravatar_id":"","url":"https://api.github.com/users/mashabarashko","html_url":"https://github.com/mashabarashko","followers_url":"https://api.github.com/users/mashabarashko/followers","following_url":"https://api.github.com/users/mashabarashko/following{/other_user}","gists_url":"https://api.github.com/users/mashabarashko/gists{/gist_id}","starred_url":"https://api.github.com/users/mashabarashko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mashabarashko/subscriptions","organizations_url":"https://api.github.com/users/mashabarashko/orgs","repos_url":"https://api.github.com/users/mashabarashko/repos","events_url":"https://api.github.com/users/mashabarashko/events{/privacy}","received_events_url":"https://api.github.com/users/mashabarashko/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T09:43:41Z","updated_at":"2018-11-08T09:43:41Z","author_association":"COLLABORATOR","body":"@alekseev-aa Could you please remove merge commit and do rebase instead?"}}
{"actor":{"display_login":"mashabarashko"}}