{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/241043287","pull_request_review_id":184214770,"id":241043287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTA0MzI4Nw==","diff_hunk":"@@ -78,16 +78,15 @@ MiCheckForUserStackOverflow(IN PVOID Address,\n     /* This is where the stack will start now */\n     NextStackAddress = (PVOID)((ULONG_PTR)PAGE_ALIGN(Address) - GuaranteedSize);\n \n-    /* Do we have at least one page between here and the end of the stack? */\n-    if (((ULONG_PTR)NextStackAddress - PAGE_SIZE) <= (ULONG_PTR)DeallocationStack)\n+    /* Do we have enough additional memory between here and the end of the stack? */\n+    if (((ULONG_PTR)NextStackAddress - GuaranteedSize) <= (ULONG_PTR)DeallocationStack)","path":"ntoskrnl/mm/ARM3/pagfault.c","position":16,"original_position":16,"commit_id":"aa3c7575c5229ccafd423875f08a4032c403997b","original_commit_id":"aa3c7575c5229ccafd423875f08a4032c403997b","user":{"login":"HeisSpiter","id":1531741,"node_id":"MDQ6VXNlcjE1MzE3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1531741?v=4","gravatar_id":"","url":"https://api.github.com/users/HeisSpiter","html_url":"https://github.com/HeisSpiter","followers_url":"https://api.github.com/users/HeisSpiter/followers","following_url":"https://api.github.com/users/HeisSpiter/following{/other_user}","gists_url":"https://api.github.com/users/HeisSpiter/gists{/gist_id}","starred_url":"https://api.github.com/users/HeisSpiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeisSpiter/subscriptions","organizations_url":"https://api.github.com/users/HeisSpiter/orgs","repos_url":"https://api.github.com/users/HeisSpiter/repos","events_url":"https://api.github.com/users/HeisSpiter/events{/privacy}","received_events_url":"https://api.github.com/users/HeisSpiter/received_events","type":"User","site_admin":false},"body":"Code","created_at":"2018-12-12T14:49:44Z","updated_at":"2018-12-12T14:49:44Z","html_url":"https://github.com/reactos/reactos/pull/1074#discussion_r241043287","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/1074","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/241043287"},"html":{"href":"https://github.com/reactos/reactos/pull/1074#discussion_r241043287"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1074"}},"in_reply_to_id":241023806},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/1074","id":233459139,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDU5MTM5","html_url":"https://github.com/reactos/reactos/pull/1074","diff_url":"https://github.com/reactos/reactos/pull/1074.diff","patch_url":"https://github.com/reactos/reactos/pull/1074.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/1074","number":1074,"state":"open","locked":false,"title":"[NTOS:MM] MiCheckForUserStackOverflow(): Improve comments and logs","user":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nMostly addendum to 8a04950.\r\n\r\nPlease, check I understood this function correctly.\r\n","created_at":"2018-11-26T07:18:15Z","updated_at":"2018-12-12T14:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"145b6999d5231d5e9fd9ff5b935a508c33393492","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/1074/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/1074/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/1074/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/aa3c7575c5229ccafd423875f08a4032c403997b","head":{"label":"SergeGautherie:SergeGautherie/PRonly_MiCheckForUserStackOverflow_ImproveCloseToDeath","ref":"SergeGautherie/PRonly_MiCheckForUserStackOverflow_ImproveCloseToDeath","sha":"aa3c7575c5229ccafd423875f08a4032c403997b","user":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"repo":{"id":106214785,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyMTQ3ODU=","name":"reactos","full_name":"SergeGautherie/reactos","private":false,"owner":{"login":"SergeGautherie","id":32623169,"node_id":"MDQ6VXNlcjMyNjIzMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/32623169?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeGautherie","html_url":"https://github.com/SergeGautherie","followers_url":"https://api.github.com/users/SergeGautherie/followers","following_url":"https://api.github.com/users/SergeGautherie/following{/other_user}","gists_url":"https://api.github.com/users/SergeGautherie/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeGautherie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeGautherie/subscriptions","organizations_url":"https://api.github.com/users/SergeGautherie/orgs","repos_url":"https://api.github.com/users/SergeGautherie/repos","events_url":"https://api.github.com/users/SergeGautherie/events{/privacy}","received_events_url":"https://api.github.com/users/SergeGautherie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SergeGautherie/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/SergeGautherie/reactos","forks_url":"https://api.github.com/repos/SergeGautherie/reactos/forks","keys_url":"https://api.github.com/repos/SergeGautherie/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergeGautherie/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergeGautherie/reactos/teams","hooks_url":"https://api.github.com/repos/SergeGautherie/reactos/hooks","issue_events_url":"https://api.github.com/repos/SergeGautherie/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/SergeGautherie/reactos/events","assignees_url":"https://api.github.com/repos/SergeGautherie/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/SergeGautherie/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/SergeGautherie/reactos/tags","blobs_url":"https://api.github.com/repos/SergeGautherie/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergeGautherie/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergeGautherie/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergeGautherie/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergeGautherie/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/SergeGautherie/reactos/languages","stargazers_url":"https://api.github.com/repos/SergeGautherie/reactos/stargazers","contributors_url":"https://api.github.com/repos/SergeGautherie/reactos/contributors","subscribers_url":"https://api.github.com/repos/SergeGautherie/reactos/subscribers","subscription_url":"https://api.github.com/repos/SergeGautherie/reactos/subscription","commits_url":"https://api.github.com/repos/SergeGautherie/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergeGautherie/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergeGautherie/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergeGautherie/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergeGautherie/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/SergeGautherie/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergeGautherie/reactos/merges","archive_url":"https://api.github.com/repos/SergeGautherie/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergeGautherie/reactos/downloads","issues_url":"https://api.github.com/repos/SergeGautherie/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/SergeGautherie/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/SergeGautherie/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/SergeGautherie/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergeGautherie/reactos/labels{/name}","releases_url":"https://api.github.com/repos/SergeGautherie/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/SergeGautherie/reactos/deployments","created_at":"2017-10-08T22:37:01Z","updated_at":"2018-12-12T13:18:36Z","pushed_at":"2018-12-12T14:01:15Z","git_url":"git://github.com/SergeGautherie/reactos.git","ssh_url":"git@github.com:SergeGautherie/reactos.git","clone_url":"https://github.com/SergeGautherie/reactos.git","svn_url":"https://github.com/SergeGautherie/reactos","homepage":null,"size":465283,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"3ba51dc21894bd5c2d1574af1db5094ab4e3d6ae","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","private":false,"owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-12-12T11:57:25Z","pushed_at":"2018-12-12T14:04:42Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":464963,"stargazers_count":5621,"watchers_count":5621,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":494,"open_issues":81,"watchers":5621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1074"},"html":{"href":"https://github.com/reactos/reactos/pull/1074"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/1074"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/1074/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1074/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1074/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/aa3c7575c5229ccafd423875f08a4032c403997b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HeisSpiter"}}