{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments/233926156","pull_request_review_id":175453741,"id":233926156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzkyNjE1Ng==","diff_hunk":"@@ -61,6 +61,17 @@ class SpanAllocator {\n     return Find(size, next, pos, align);\n   }\n \n+  // Finds the farthest position at which an element could be allocated.\n+  bool FindForUnbounded(T_index &pos) {","path":"include/dxc/HLSL/DxilSpanAllocator.h","position":5,"original_position":5,"commit_id":"80442b1b72a9e7c2467fb36a5cd4d745ee32c86a","original_commit_id":"80442b1b72a9e7c2467fb36a5cd4d745ee32c86a","user":{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false},"body":"I can do that","created_at":"2018-11-15T16:55:42Z","updated_at":"2018-11-15T16:55:42Z","html_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687#discussion_r233926156","pull_request_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments/233926156"},"html":{"href":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687#discussion_r233926156"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687"}},"in_reply_to_id":233698743},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687","id":229789957,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzg5OTU3","html_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687","diff_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687.diff","patch_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1687","number":1687,"state":"open","locked":false,"title":"Added support for pre-SM5.1 resource allocation algorithm","user":{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false},"body":"- Added front-end `-flegacy-resource-reservations` to control behavior (added automatically for SM <= 5.0)\r\n- Added a mechanism for `DxilModule` to preserve intermediate options during its passes but not in the final DXIL\r\n- Changed `HLModule` to not remove unreferenced `DxilResources` but rather make their symbol UndefValue\r\n- Fixed assumptions of `DxilResources` having a valid `GlobalVariable`\r\n- Added reserved resource range gather pass before elimination of unused resources (if SM <= 5.0)\r\n- Changed resource allocation to account for reserved ranges\r\n\r\nFixes #1660","created_at":"2018-11-09T19:06:08Z","updated_at":"2018-11-15T16:55:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5790372d6fde4375448a8844f1f83c94898a7231","assignee":{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false},"assignees":[{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1687/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/80442b1b72a9e7c2467fb36a5cd4d745ee32c86a","head":{"label":"MrTrillian:SM50ResourceAllocation","ref":"SM50ResourceAllocation","sha":"80442b1b72a9e7c2467fb36a5cd4d745ee32c86a","user":{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false},"repo":{"id":155423861,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0MjM4NjE=","name":"DirectXShaderCompiler","full_name":"MrTrillian/DirectXShaderCompiler","private":false,"owner":{"login":"MrTrillian","id":2314287,"node_id":"MDQ6VXNlcjIzMTQyODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2314287?v=4","gravatar_id":"","url":"https://api.github.com/users/MrTrillian","html_url":"https://github.com/MrTrillian","followers_url":"https://api.github.com/users/MrTrillian/followers","following_url":"https://api.github.com/users/MrTrillian/following{/other_user}","gists_url":"https://api.github.com/users/MrTrillian/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTrillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTrillian/subscriptions","organizations_url":"https://api.github.com/users/MrTrillian/orgs","repos_url":"https://api.github.com/users/MrTrillian/repos","events_url":"https://api.github.com/users/MrTrillian/events{/privacy}","received_events_url":"https://api.github.com/users/MrTrillian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MrTrillian/DirectXShaderCompiler","description":"This repo hosts the source for the DirectX Shader Compiler which is based on LLVM/Clang.","fork":true,"url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler","forks_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/forks","keys_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/teams","hooks_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/hooks","issue_events_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/events","assignees_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/tags","blobs_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/languages","stargazers_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/stargazers","contributors_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/contributors","subscribers_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/subscribers","subscription_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/subscription","commits_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/merges","archive_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/downloads","issues_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/labels{/name}","releases_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/MrTrillian/DirectXShaderCompiler/deployments","created_at":"2018-10-30T16:56:10Z","updated_at":"2018-11-09T18:37:33Z","pushed_at":"2018-11-15T16:50:45Z","git_url":"git://github.com/MrTrillian/DirectXShaderCompiler.git","ssh_url":"git@github.com:MrTrillian/DirectXShaderCompiler.git","clone_url":"https://github.com/MrTrillian/DirectXShaderCompiler.git","svn_url":"https://github.com/MrTrillian/DirectXShaderCompiler","homepage":null,"size":39235,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"90ed5a43a4fb7bce52484fde19de96d7c378d8e5","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75787966,"node_id":"MDEwOlJlcG9zaXRvcnk3NTc4Nzk2Ng==","name":"DirectXShaderCompiler","full_name":"Microsoft/DirectXShaderCompiler","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/DirectXShaderCompiler","description":"This repo hosts the source for the DirectX Shader Compiler which is based on LLVM/Clang.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler","forks_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/deployments","created_at":"2016-12-07T01:42:19Z","updated_at":"2018-11-15T16:50:46Z","pushed_at":"2018-11-15T16:50:41Z","git_url":"git://github.com/Microsoft/DirectXShaderCompiler.git","ssh_url":"git@github.com:Microsoft/DirectXShaderCompiler.git","clone_url":"https://github.com/Microsoft/DirectXShaderCompiler.git","svn_url":"https://github.com/Microsoft/DirectXShaderCompiler","homepage":null,"size":39273,"stargazers_count":1001,"watchers_count":1001,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":154,"open_issues":85,"watchers":1001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687"},"html":{"href":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1687"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1687"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1687/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1687/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/80442b1b72a9e7c2467fb36a5cd4d745ee32c86a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MrTrillian"}}