{"action":"created","comment":{"url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/comments/198822681","pull_request_review_id":132820503,"id":198822681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODgyMjY4MQ==","diff_hunk":"@@ -14,9 +15,22 @@ import Button from 'components/base/Button'\n import AccountsList from 'components/base/AccountsList'\n import IconExclamationCircleThin from 'icons/ExclamationCircleThin'\n import TranslatedError from '../../../TranslatedError'\n+import Spinner from '../../../base/Spinner'\n \n import type { StepProps } from '../index'\n \n+const LoadingRow = styled(Box).attrs({\n+  horizontal: true,\n+  borderRadius: 1,\n+  px: 3,\n+  align: 'center',\n+  justify: 'center',\n+  mt: 1,","path":"src/components/modals/AddAccounts/steps/03-step-import.js","position":22,"original_position":22,"commit_id":"9a32695441ed3527976e76988e9d913f25ff8df9","original_commit_id":"648d0d193054d330beff35ce3d071e066d15e262","user":{"login":"gre","id":211411,"node_id":"MDQ6VXNlcjIxMTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"body":"pushing the logic more far, that means we never want to do `styled(Box).attr` right?","created_at":"2018-06-28T12:34:40Z","updated_at":"2018-06-28T12:34:40Z","html_url":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740#discussion_r198822681","pull_request_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/comments/198822681"},"html":{"href":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740#discussion_r198822681"},"pull_request":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740"}},"in_reply_to_id":198812776},"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740","id":197967166,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTY3MTY2","html_url":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740","diff_url":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740.diff","patch_url":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740.patch","issue_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/740","number":740,"state":"open","locked":false,"title":"Refactor and Polish Add Accounts","user":{"login":"gre","id":211411,"node_id":"MDQ6VXNlcjIxMTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"body":"✅  validated by design with pixel push.\r\n✅  not yet wording pass. (first pass. another will come later)\r\n\r\n- one spinner at a time, to reflect better the technical reality of the scanning\r\n- Adding a imported account category to avoid confusion when seeing nothing because all is imported (better to show what accounts than a text. for instance, you can also figure out like that which accounts your device have)\r\n- autofocus the first input because we want more engagement on setting an initial name\r\n- input are editable in place. no more 'edit name' editing state\r\n- account name validation! trimmed, max length + handling empty case\r\n- Add more to import more cryptos from step 4\r\n- the new account take the same naming semantic so the naming are consistent if you leave the default ones and you don't end up with all accounts named 'New Account'\r\n- prefer to grey out when you don't select anything to make sure user understand you have to select things to move on.\r\n- fix spoiler to be touchable on the icon itself.\r\n\r\n### Type\r\n\r\n- mostly Polish + minor features\r\n\r\n### Parts of the app affected / Test plan\r\n\r\n- Add Accounts\r\n- Edit Account, because now sharing the logic for account name validation","created_at":"2018-06-28T09:20:52Z","updated_at":"2018-06-28T12:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f885f71bdae8b183865c1287a083556ecf261b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/740/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/statuses/9a32695441ed3527976e76988e9d913f25ff8df9","head":{"label":"gre:polish/add-account","ref":"polish/add-account","sha":"9a32695441ed3527976e76988e9d913f25ff8df9","user":{"login":"gre","id":211411,"node_id":"MDQ6VXNlcjIxMTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"repo":{"id":123317033,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMTcwMzM=","name":"ledger-live-desktop","full_name":"gre/ledger-live-desktop","owner":{"login":"gre","id":211411,"node_id":"MDQ6VXNlcjIxMTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gre/ledger-live-desktop","description":null,"fork":true,"url":"https://api.github.com/repos/gre/ledger-live-desktop","forks_url":"https://api.github.com/repos/gre/ledger-live-desktop/forks","keys_url":"https://api.github.com/repos/gre/ledger-live-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gre/ledger-live-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gre/ledger-live-desktop/teams","hooks_url":"https://api.github.com/repos/gre/ledger-live-desktop/hooks","issue_events_url":"https://api.github.com/repos/gre/ledger-live-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/gre/ledger-live-desktop/events","assignees_url":"https://api.github.com/repos/gre/ledger-live-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/gre/ledger-live-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/gre/ledger-live-desktop/tags","blobs_url":"https://api.github.com/repos/gre/ledger-live-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gre/ledger-live-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gre/ledger-live-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/gre/ledger-live-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gre/ledger-live-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/gre/ledger-live-desktop/languages","stargazers_url":"https://api.github.com/repos/gre/ledger-live-desktop/stargazers","contributors_url":"https://api.github.com/repos/gre/ledger-live-desktop/contributors","subscribers_url":"https://api.github.com/repos/gre/ledger-live-desktop/subscribers","subscription_url":"https://api.github.com/repos/gre/ledger-live-desktop/subscription","commits_url":"https://api.github.com/repos/gre/ledger-live-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/gre/ledger-live-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/gre/ledger-live-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/gre/ledger-live-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/gre/ledger-live-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/gre/ledger-live-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gre/ledger-live-desktop/merges","archive_url":"https://api.github.com/repos/gre/ledger-live-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gre/ledger-live-desktop/downloads","issues_url":"https://api.github.com/repos/gre/ledger-live-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/gre/ledger-live-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/gre/ledger-live-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/gre/ledger-live-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gre/ledger-live-desktop/labels{/name}","releases_url":"https://api.github.com/repos/gre/ledger-live-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/gre/ledger-live-desktop/deployments","created_at":"2018-02-28T17:15:08Z","updated_at":"2018-06-26T12:08:23Z","pushed_at":"2018-06-28T12:32:09Z","git_url":"git://github.com/gre/ledger-live-desktop.git","ssh_url":"git@github.com:gre/ledger-live-desktop.git","clone_url":"https://github.com/gre/ledger-live-desktop.git","svn_url":"https://github.com/gre/ledger-live-desktop","homepage":"","size":8900,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LedgerHQ:develop","ref":"develop","sha":"2dd342f49205901979098e1fc05f39e16d7e7a61","user":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":82679495,"node_id":"MDEwOlJlcG9zaXRvcnk4MjY3OTQ5NQ==","name":"ledger-live-desktop","full_name":"LedgerHQ/ledger-live-desktop","owner":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-live-desktop","description":"Ledger Live (Desktop)","fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/deployments","created_at":"2017-02-21T12:52:13Z","updated_at":"2018-06-28T10:45:49Z","pushed_at":"2018-06-28T12:32:11Z","git_url":"git://github.com/LedgerHQ/ledger-live-desktop.git","ssh_url":"git@github.com:LedgerHQ/ledger-live-desktop.git","clone_url":"https://github.com/LedgerHQ/ledger-live-desktop.git","svn_url":"https://github.com/LedgerHQ/ledger-live-desktop","homepage":"https://ledgerhq.github.io/ledger-live-desktop/","size":10316,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22,"open_issues":4,"watchers":48,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740"},"html":{"href":"https://github.com/LedgerHQ/ledger-live-desktop/pull/740"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/740"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/issues/740/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/pulls/740/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/ledger-live-desktop/statuses/9a32695441ed3527976e76988e9d913f25ff8df9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gre"}}