{"action":"closed","number":409,"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-core/pulls/409","id":219309053,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MzA5MDUz","html_url":"https://github.com/openhab/openhab-core/pull/409","diff_url":"https://github.com/openhab/openhab-core/pull/409.diff","patch_url":"https://github.com/openhab/openhab-core/pull/409.patch","issue_url":"https://api.github.com/repos/openhab/openhab-core/issues/409","number":409,"state":"closed","locked":false,"title":"prevent System.exit() calls","user":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"This PR prevents openHAB from being shut down by `System.exit()` calls as long as the core bundle is started (we obviously do not want to prevent the container from ever shutting down).\r\n\r\nThis is specifically meant as a workaround for https://github.com/eclipse/smarthome/issues/6291, but\r\nmakes the server in general more robust wrt malicious third party code.\r\n\r\nSigned-off-by: Kai Kreuzer <kai@openhab.org>","created_at":"2018-10-01T09:22:29Z","updated_at":"2018-10-01T19:18:47Z","closed_at":"2018-10-01T19:18:47Z","merged_at":"2018-10-01T19:18:47Z","merge_commit_sha":"d3ffb2db5a8e77294d5ad8dd2e852d715fac67ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-core/pulls/409/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-core/pulls/409/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-core/issues/409/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/02ffa197db41914c794a8eca12fc04e14474cea7","head":{"label":"kaikreuzer:sysexit","ref":"sysexit","sha":"02ffa197db41914c794a8eca12fc04e14474cea7","user":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"repo":{"id":92823493,"node_id":"MDEwOlJlcG9zaXRvcnk5MjgyMzQ5Mw==","name":"openhab-core","full_name":"kaikreuzer/openhab-core","private":false,"owner":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kaikreuzer/openhab-core","description":null,"fork":true,"url":"https://api.github.com/repos/kaikreuzer/openhab-core","forks_url":"https://api.github.com/repos/kaikreuzer/openhab-core/forks","keys_url":"https://api.github.com/repos/kaikreuzer/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaikreuzer/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaikreuzer/openhab-core/teams","hooks_url":"https://api.github.com/repos/kaikreuzer/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/kaikreuzer/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/kaikreuzer/openhab-core/events","assignees_url":"https://api.github.com/repos/kaikreuzer/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/kaikreuzer/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/kaikreuzer/openhab-core/tags","blobs_url":"https://api.github.com/repos/kaikreuzer/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaikreuzer/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaikreuzer/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaikreuzer/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaikreuzer/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kaikreuzer/openhab-core/languages","stargazers_url":"https://api.github.com/repos/kaikreuzer/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/kaikreuzer/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/kaikreuzer/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/kaikreuzer/openhab-core/subscription","commits_url":"https://api.github.com/repos/kaikreuzer/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaikreuzer/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaikreuzer/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaikreuzer/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaikreuzer/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/kaikreuzer/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaikreuzer/openhab-core/merges","archive_url":"https://api.github.com/repos/kaikreuzer/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaikreuzer/openhab-core/downloads","issues_url":"https://api.github.com/repos/kaikreuzer/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/kaikreuzer/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kaikreuzer/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kaikreuzer/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaikreuzer/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/kaikreuzer/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/kaikreuzer/openhab-core/deployments","created_at":"2017-05-30T10:54:19Z","updated_at":"2018-02-09T21:46:08Z","pushed_at":"2018-10-01T09:20:02Z","git_url":"git://github.com/kaikreuzer/openhab-core.git","ssh_url":"git@github.com:kaikreuzer/openhab-core.git","clone_url":"https://github.com/kaikreuzer/openhab-core.git","svn_url":"https://github.com/kaikreuzer/openhab-core","homepage":null,"size":11433,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"1e7955be881834b6442e6b9aa25f47085b910567","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":48337670,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMzNzY3MA==","name":"openhab-core","full_name":"openhab/openhab-core","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab-core","description":null,"fork":false,"url":"https://api.github.com/repos/openhab/openhab-core","forks_url":"https://api.github.com/repos/openhab/openhab-core/forks","keys_url":"https://api.github.com/repos/openhab/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-core/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-core/events","assignees_url":"https://api.github.com/repos/openhab/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-core/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-core/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-core/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-core/merges","archive_url":"https://api.github.com/repos/openhab/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-core/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-core/deployments","created_at":"2015-12-20T21:23:20Z","updated_at":"2018-10-01T07:54:17Z","pushed_at":"2018-10-01T19:18:47Z","git_url":"git://github.com/openhab/openhab-core.git","ssh_url":"git@github.com:openhab/openhab-core.git","clone_url":"https://github.com/openhab/openhab-core.git","svn_url":"https://github.com/openhab/openhab-core","homepage":null,"size":11500,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":101,"open_issues":33,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/409"},"html":{"href":"https://github.com/openhab/openhab-core/pull/409"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/409"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-core/statuses/02ffa197db41914c794a8eca12fc04e14474cea7"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wborn","id":12213581,"node_id":"MDQ6VXNlcjEyMjEzNTgx","avatar_url":"https://avatars1.githubusercontent.com/u/12213581?v=4","gravatar_id":"","url":"https://api.github.com/users/wborn","html_url":"https://github.com/wborn","followers_url":"https://api.github.com/users/wborn/followers","following_url":"https://api.github.com/users/wborn/following{/other_user}","gists_url":"https://api.github.com/users/wborn/gists{/gist_id}","starred_url":"https://api.github.com/users/wborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wborn/subscriptions","organizations_url":"https://api.github.com/users/wborn/orgs","repos_url":"https://api.github.com/users/wborn/repos","events_url":"https://api.github.com/users/wborn/events{/privacy}","received_events_url":"https://api.github.com/users/wborn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"wborn"}}