{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13309","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13309/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13309/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13309/events","html_url":"https://github.com/bitcoin/bitcoin/pull/13309","id":325568307,"number":13309,"title":"Directly operate with CMutableTransaction in SignSignature (faster unit tests)","user":{"login":"martinus","id":14386,"avatar_url":"https://avatars3.githubusercontent.com/u/14386?v=4","gravatar_id":"","url":"https://api.github.com/users/martinus","html_url":"https://github.com/martinus","followers_url":"https://api.github.com/users/martinus/followers","following_url":"https://api.github.com/users/martinus/following{/other_user}","gists_url":"https://api.github.com/users/martinus/gists{/gist_id}","starred_url":"https://api.github.com/users/martinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinus/subscriptions","organizations_url":"https://api.github.com/users/martinus/orgs","repos_url":"https://api.github.com/users/martinus/repos","events_url":"https://api.github.com/users/martinus/events{/privacy}","received_events_url":"https://api.github.com/users/martinus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-23T06:41:26Z","updated_at":"2018-05-23T14:31:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13309","html_url":"https://github.com/bitcoin/bitcoin/pull/13309","diff_url":"https://github.com/bitcoin/bitcoin/pull/13309.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13309.patch"},"body":"Refactored `TransactionSignatureCreator` into a templated `GenericTransactionSignatureCreator` that works with both `CMutableTransaction` and `CTransaction`.\r\n\r\nThe advantage is that now in `SignSignature`, the `MutableTransactionSignatureCreator` can now operate directly with the `CMutableTransaction` without the need to copy the data into a `CTransaction`.\r\n\r\nRunning all unit tests brings a very noticable speedup on my machine:\r\n\r\n    48.4 sec before this change\r\n    36.4 sec with this change\r\n    --------\r\n    12.0 seconds saved\r\n\r\nrunning only `--run_test=transaction_tests/test_big_witness_transaction`:\r\n\r\n    16.7 sec before this change\r\n     5.9 sec with this change\r\n    --------\r\n    10.8 seconds saved\r\n\r\nThis relates to my first attempt with the const_cast hack #13202, and to the slow unit test issue #10026.\r\n\r\nAlso see #13050 which modifies the tests but not the production code (like this PR) to get a speedup."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/391369000","html_url":"https://github.com/bitcoin/bitcoin/pull/13309#issuecomment-391369000","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13309","id":391369000,"user":{"login":"practicalswift","id":7826565,"avatar_url":"https://avatars3.githubusercontent.com/u/7826565?v=4","gravatar_id":"","url":"https://api.github.com/users/practicalswift","html_url":"https://github.com/practicalswift","followers_url":"https://api.github.com/users/practicalswift/followers","following_url":"https://api.github.com/users/practicalswift/following{/other_user}","gists_url":"https://api.github.com/users/practicalswift/gists{/gist_id}","starred_url":"https://api.github.com/users/practicalswift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/practicalswift/subscriptions","organizations_url":"https://api.github.com/users/practicalswift/orgs","repos_url":"https://api.github.com/users/practicalswift/repos","events_url":"https://api.github.com/users/practicalswift/events{/privacy}","received_events_url":"https://api.github.com/users/practicalswift/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T14:31:13Z","updated_at":"2018-05-23T14:31:13Z","author_association":"MEMBER","body":"Very nice!\r\n\r\nConcept ACK"}}
{"actor":{"display_login":"practicalswift"}}