{"action":"created","comment":{"url":"https://api.github.com/repos/sdelements/shtdlib/pulls/comments/235806201","pull_request_review_id":177759500,"id":235806201,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTgwNjIwMQ==","diff_hunk":"@@ -1996,13 +1996,44 @@ function ln_sf {\n # Create string of random characters\n #  - First param is length, default: 20\n #  - Second param is characters, default: A-Za-z0-9_ (Note: '-' specifies range)\n-gen_rand_chars() {\n+function gen_rand_chars {\n+    shopt_decorator_option_name='pipefail'\n+    shopt_decorator_option_value='false'\n+    # shellcheck disable=2015\n+    shopt_decorator \"${FUNCNAME[0]}\" \"${@:-}\" && return || conditional_exit_on_fail 121 \"Failed to run ${FUNCNAME[0]} with shopt_decorator\"","path":"shtdlib.sh","position":9,"original_position":9,"commit_id":"f4b8aba998d155730382fd3e58e616375f9c7d9e","original_commit_id":"f4b8aba998d155730382fd3e58e616375f9c7d9e","user":{"login":"antevens","id":3581159,"node_id":"MDQ6VXNlcjM1ODExNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3581159?v=4","gravatar_id":"","url":"https://api.github.com/users/antevens","html_url":"https://github.com/antevens","followers_url":"https://api.github.com/users/antevens/followers","following_url":"https://api.github.com/users/antevens/following{/other_user}","gists_url":"https://api.github.com/users/antevens/gists{/gist_id}","starred_url":"https://api.github.com/users/antevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antevens/subscriptions","organizations_url":"https://api.github.com/users/antevens/orgs","repos_url":"https://api.github.com/users/antevens/repos","events_url":"https://api.github.com/users/antevens/events{/privacy}","received_events_url":"https://api.github.com/users/antevens/received_events","type":"User","site_admin":false},"body":"Makes sense, I'll change to 141, I think I remember reading that 128+n before so 121 must be a typo or something.","created_at":"2018-11-22T19:12:20Z","updated_at":"2018-11-22T19:12:20Z","html_url":"https://github.com/sdelements/shtdlib/pull/29#discussion_r235806201","pull_request_url":"https://api.github.com/repos/sdelements/shtdlib/pulls/29","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/comments/235806201"},"html":{"href":"https://github.com/sdelements/shtdlib/pull/29#discussion_r235806201"},"pull_request":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/29"}},"in_reply_to_id":235783552},"pull_request":{"url":"https://api.github.com/repos/sdelements/shtdlib/pulls/29","id":233025161,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDI1MTYx","html_url":"https://github.com/sdelements/shtdlib/pull/29","diff_url":"https://github.com/sdelements/shtdlib/pull/29.diff","patch_url":"https://github.com/sdelements/shtdlib/pull/29.patch","issue_url":"https://api.github.com/repos/sdelements/shtdlib/issues/29","number":29,"state":"open","locked":false,"title":"Add auto_ensure_key_exists","user":{"login":"antevens","id":3581159,"node_id":"MDQ6VXNlcjM1ODExNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3581159?v=4","gravatar_id":"","url":"https://api.github.com/users/antevens","html_url":"https://github.com/antevens","followers_url":"https://api.github.com/users/antevens/followers","following_url":"https://api.github.com/users/antevens/following{/other_user}","gists_url":"https://api.github.com/users/antevens/gists{/gist_id}","starred_url":"https://api.github.com/users/antevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antevens/subscriptions","organizations_url":"https://api.github.com/users/antevens/orgs","repos_url":"https://api.github.com/users/antevens/repos","events_url":"https://api.github.com/users/antevens/events{/privacy}","received_events_url":"https://api.github.com/users/antevens/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-22T16:01:48Z","updated_at":"2018-11-22T19:12:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91c21f999b42ac9d18926d3612877702b2051642","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mroote","id":2685144,"node_id":"MDQ6VXNlcjI2ODUxNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2685144?v=4","gravatar_id":"","url":"https://api.github.com/users/mroote","html_url":"https://github.com/mroote","followers_url":"https://api.github.com/users/mroote/followers","following_url":"https://api.github.com/users/mroote/following{/other_user}","gists_url":"https://api.github.com/users/mroote/gists{/gist_id}","starred_url":"https://api.github.com/users/mroote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroote/subscriptions","organizations_url":"https://api.github.com/users/mroote/orgs","repos_url":"https://api.github.com/users/mroote/repos","events_url":"https://api.github.com/users/mroote/events{/privacy}","received_events_url":"https://api.github.com/users/mroote/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sdelements/shtdlib/pulls/29/commits","review_comments_url":"https://api.github.com/repos/sdelements/shtdlib/pulls/29/comments","review_comment_url":"https://api.github.com/repos/sdelements/shtdlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdelements/shtdlib/issues/29/comments","statuses_url":"https://api.github.com/repos/sdelements/shtdlib/statuses/f4b8aba998d155730382fd3e58e616375f9c7d9e","head":{"label":"sdelements:feature/add_case_functions","ref":"feature/add_case_functions","sha":"f4b8aba998d155730382fd3e58e616375f9c7d9e","user":{"login":"sdelements","id":739346,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTM0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/739346?v=4","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"repo":{"id":135175639,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNzU2Mzk=","name":"shtdlib","full_name":"sdelements/shtdlib","private":false,"owner":{"login":"sdelements","id":739346,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTM0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/739346?v=4","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sdelements/shtdlib","description":"Shell Standard Library","fork":false,"url":"https://api.github.com/repos/sdelements/shtdlib","forks_url":"https://api.github.com/repos/sdelements/shtdlib/forks","keys_url":"https://api.github.com/repos/sdelements/shtdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdelements/shtdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdelements/shtdlib/teams","hooks_url":"https://api.github.com/repos/sdelements/shtdlib/hooks","issue_events_url":"https://api.github.com/repos/sdelements/shtdlib/issues/events{/number}","events_url":"https://api.github.com/repos/sdelements/shtdlib/events","assignees_url":"https://api.github.com/repos/sdelements/shtdlib/assignees{/user}","branches_url":"https://api.github.com/repos/sdelements/shtdlib/branches{/branch}","tags_url":"https://api.github.com/repos/sdelements/shtdlib/tags","blobs_url":"https://api.github.com/repos/sdelements/shtdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdelements/shtdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdelements/shtdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdelements/shtdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdelements/shtdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/sdelements/shtdlib/languages","stargazers_url":"https://api.github.com/repos/sdelements/shtdlib/stargazers","contributors_url":"https://api.github.com/repos/sdelements/shtdlib/contributors","subscribers_url":"https://api.github.com/repos/sdelements/shtdlib/subscribers","subscription_url":"https://api.github.com/repos/sdelements/shtdlib/subscription","commits_url":"https://api.github.com/repos/sdelements/shtdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdelements/shtdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdelements/shtdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdelements/shtdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdelements/shtdlib/contents/{+path}","compare_url":"https://api.github.com/repos/sdelements/shtdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdelements/shtdlib/merges","archive_url":"https://api.github.com/repos/sdelements/shtdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdelements/shtdlib/downloads","issues_url":"https://api.github.com/repos/sdelements/shtdlib/issues{/number}","pulls_url":"https://api.github.com/repos/sdelements/shtdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/sdelements/shtdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/sdelements/shtdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdelements/shtdlib/labels{/name}","releases_url":"https://api.github.com/repos/sdelements/shtdlib/releases{/id}","deployments_url":"https://api.github.com/repos/sdelements/shtdlib/deployments","created_at":"2018-05-28T14:58:59Z","updated_at":"2018-11-20T16:11:37Z","pushed_at":"2018-11-22T17:08:12Z","git_url":"git://github.com/sdelements/shtdlib.git","ssh_url":"git@github.com:sdelements/shtdlib.git","clone_url":"https://github.com/sdelements/shtdlib.git","svn_url":"https://github.com/sdelements/shtdlib","homepage":null,"size":342,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"sdelements:master","ref":"master","sha":"9baf2f755df82fcccfd20ba185a242302e6f6f11","user":{"login":"sdelements","id":739346,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTM0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/739346?v=4","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"repo":{"id":135175639,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNzU2Mzk=","name":"shtdlib","full_name":"sdelements/shtdlib","private":false,"owner":{"login":"sdelements","id":739346,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTM0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/739346?v=4","gravatar_id":"","url":"https://api.github.com/users/sdelements","html_url":"https://github.com/sdelements","followers_url":"https://api.github.com/users/sdelements/followers","following_url":"https://api.github.com/users/sdelements/following{/other_user}","gists_url":"https://api.github.com/users/sdelements/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelements/subscriptions","organizations_url":"https://api.github.com/users/sdelements/orgs","repos_url":"https://api.github.com/users/sdelements/repos","events_url":"https://api.github.com/users/sdelements/events{/privacy}","received_events_url":"https://api.github.com/users/sdelements/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sdelements/shtdlib","description":"Shell Standard Library","fork":false,"url":"https://api.github.com/repos/sdelements/shtdlib","forks_url":"https://api.github.com/repos/sdelements/shtdlib/forks","keys_url":"https://api.github.com/repos/sdelements/shtdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdelements/shtdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdelements/shtdlib/teams","hooks_url":"https://api.github.com/repos/sdelements/shtdlib/hooks","issue_events_url":"https://api.github.com/repos/sdelements/shtdlib/issues/events{/number}","events_url":"https://api.github.com/repos/sdelements/shtdlib/events","assignees_url":"https://api.github.com/repos/sdelements/shtdlib/assignees{/user}","branches_url":"https://api.github.com/repos/sdelements/shtdlib/branches{/branch}","tags_url":"https://api.github.com/repos/sdelements/shtdlib/tags","blobs_url":"https://api.github.com/repos/sdelements/shtdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdelements/shtdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdelements/shtdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdelements/shtdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdelements/shtdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/sdelements/shtdlib/languages","stargazers_url":"https://api.github.com/repos/sdelements/shtdlib/stargazers","contributors_url":"https://api.github.com/repos/sdelements/shtdlib/contributors","subscribers_url":"https://api.github.com/repos/sdelements/shtdlib/subscribers","subscription_url":"https://api.github.com/repos/sdelements/shtdlib/subscription","commits_url":"https://api.github.com/repos/sdelements/shtdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdelements/shtdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdelements/shtdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdelements/shtdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdelements/shtdlib/contents/{+path}","compare_url":"https://api.github.com/repos/sdelements/shtdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdelements/shtdlib/merges","archive_url":"https://api.github.com/repos/sdelements/shtdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdelements/shtdlib/downloads","issues_url":"https://api.github.com/repos/sdelements/shtdlib/issues{/number}","pulls_url":"https://api.github.com/repos/sdelements/shtdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/sdelements/shtdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/sdelements/shtdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdelements/shtdlib/labels{/name}","releases_url":"https://api.github.com/repos/sdelements/shtdlib/releases{/id}","deployments_url":"https://api.github.com/repos/sdelements/shtdlib/deployments","created_at":"2018-05-28T14:58:59Z","updated_at":"2018-11-20T16:11:37Z","pushed_at":"2018-11-22T17:08:12Z","git_url":"git://github.com/sdelements/shtdlib.git","ssh_url":"git@github.com:sdelements/shtdlib.git","clone_url":"https://github.com/sdelements/shtdlib.git","svn_url":"https://github.com/sdelements/shtdlib","homepage":null,"size":342,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/29"},"html":{"href":"https://github.com/sdelements/shtdlib/pull/29"},"issue":{"href":"https://api.github.com/repos/sdelements/shtdlib/issues/29"},"comments":{"href":"https://api.github.com/repos/sdelements/shtdlib/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdelements/shtdlib/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/sdelements/shtdlib/statuses/f4b8aba998d155730382fd3e58e616375f9c7d9e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"antevens"}}