{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments/223887941","pull_request_review_id":163126347,"id":223887941,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg4Nzk0MQ==","diff_hunk":"@@ -110,6 +137,22 @@\n         end\n     end\n \n+    for f in (MOIU.load, MOIU.allocate)\n+        @testset \"$f errors\" begin","path":"test/errors.jl","position":103,"original_position":103,"commit_id":"db0e6e53421cf83f6e9737cce813a60cac8adda9","original_commit_id":"db0e6e53421cf83f6e9737cce813a60cac8adda9","user":{"login":"mlubin","id":1733683,"node_id":"MDQ6VXNlcjE3MzM2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1733683?v=4","gravatar_id":"","url":"https://api.github.com/users/mlubin","html_url":"https://github.com/mlubin","followers_url":"https://api.github.com/users/mlubin/followers","following_url":"https://api.github.com/users/mlubin/following{/other_user}","gists_url":"https://api.github.com/users/mlubin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlubin/subscriptions","organizations_url":"https://api.github.com/users/mlubin/orgs","repos_url":"https://api.github.com/users/mlubin/repos","events_url":"https://api.github.com/users/mlubin/events{/privacy}","received_events_url":"https://api.github.com/users/mlubin/received_events","type":"User","site_admin":false},"body":"`@testset \"$f errors\" for f in (MOIU.load, MOIU.allocate)`","created_at":"2018-10-09T22:43:26Z","updated_at":"2018-10-09T22:44:01Z","html_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534#discussion_r223887941","pull_request_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments/223887941"},"html":{"href":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534#discussion_r223887941"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534","id":221517292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTE3Mjky","html_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534","diff_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534.diff","patch_url":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534.patch","issue_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/534","number":534,"state":"open","locked":false,"title":"Add errors for Allocate-Load and bad constraint","user":{"login":"blegat","id":1048205,"node_id":"MDQ6VXNlcjEwNDgyMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1048205?v=4","gravatar_id":"","url":"https://api.github.com/users/blegat","html_url":"https://github.com/blegat","followers_url":"https://api.github.com/users/blegat/followers","following_url":"https://api.github.com/users/blegat/following{/other_user}","gists_url":"https://api.github.com/users/blegat/gists{/gist_id}","starred_url":"https://api.github.com/users/blegat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blegat/subscriptions","organizations_url":"https://api.github.com/users/blegat/orgs","repos_url":"https://api.github.com/users/blegat/repos","events_url":"https://api.github.com/users/blegat/events{/privacy}","received_events_url":"https://api.github.com/users/blegat/received_events","type":"User","site_admin":false},"body":"This PR brings two improvements to user friendliness:\r\n\r\n* Allocate-Load equivalents to `set` and `add_constraint` now returns nice user-facing errors instead of method errors\r\n* `add_constraint` with VectorFunction-in-ScalarSet or ScalarFunction-in-VectorSet now returns an error instead of an UnsupportedError relying on the fact that the model implements `supports_constraint` correctly or an `AddConstraintNotAllowed` otherwise which are both less user-friendly\r\n\r\nCloses https://github.com/JuliaOpt/MathOptInterface.jl/issues/530","created_at":"2018-10-09T17:08:16Z","updated_at":"2018-10-09T22:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae0a0705f343a876be55a1f61fcc24702cb062fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/534/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/db0e6e53421cf83f6e9737cce813a60cac8adda9","head":{"label":"JuliaOpt:bl/allocateloaderrors","ref":"bl/allocateloaderrors","sha":"db0e6e53421cf83f6e9737cce813a60cac8adda9","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":95823645,"node_id":"MDEwOlJlcG9zaXRvcnk5NTgyMzY0NQ==","name":"MathOptInterface.jl","full_name":"JuliaOpt/MathOptInterface.jl","private":false,"owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaOpt/MathOptInterface.jl","description":"An abstraction layer for mathematical optimization solvers.","fork":false,"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/deployments","created_at":"2017-06-29T22:02:15Z","updated_at":"2018-10-07T13:19:02Z","pushed_at":"2018-10-09T17:08:17Z","git_url":"git://github.com/JuliaOpt/MathOptInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/MathOptInterface.jl.git","clone_url":"https://github.com/JuliaOpt/MathOptInterface.jl.git","svn_url":"https://github.com/JuliaOpt/MathOptInterface.jl","homepage":"http://www.juliaopt.org/","size":3065,"stargazers_count":42,"watchers_count":42,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":49,"watchers":42,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"3391c3ea7c2c27e3a39e998efcb4b4de0327a017","user":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":95823645,"node_id":"MDEwOlJlcG9zaXRvcnk5NTgyMzY0NQ==","name":"MathOptInterface.jl","full_name":"JuliaOpt/MathOptInterface.jl","private":false,"owner":{"login":"JuliaOpt","id":5667382,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NjczODI=","avatar_url":"https://avatars1.githubusercontent.com/u/5667382?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaOpt/MathOptInterface.jl","description":"An abstraction layer for mathematical optimization solvers.","fork":false,"url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/deployments","created_at":"2017-06-29T22:02:15Z","updated_at":"2018-10-07T13:19:02Z","pushed_at":"2018-10-09T17:08:17Z","git_url":"git://github.com/JuliaOpt/MathOptInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/MathOptInterface.jl.git","clone_url":"https://github.com/JuliaOpt/MathOptInterface.jl.git","svn_url":"https://github.com/JuliaOpt/MathOptInterface.jl","homepage":"http://www.juliaopt.org/","size":3065,"stargazers_count":42,"watchers_count":42,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":49,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534"},"html":{"href":"https://github.com/JuliaOpt/MathOptInterface.jl/pull/534"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/534"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/MathOptInterface.jl/statuses/db0e6e53421cf83f6e9737cce813a60cac8adda9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mlubin"}}