{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/214065465","pull_request_review_id":151038167,"id":214065465,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDA2NTQ2NQ==","diff_hunk":"@@ -257,14 +257,51 @@ func processBundles(ui UpdateInfo, c config) ([]*Manifest, error) {\n \n func addUnchangedManifests(appendTo *Manifest, appendFrom *Manifest) {\n \tfor _, f := range appendFrom.Files {\n-\t\tif f.findFileNameInSlice(appendTo.Files) == nil {\n-\t\t\tif f.Name == IndexBundle {\n-\t\t\t\t// this is generated new each time\n-\t\t\t\tcontinue\n-\t\t\t}\n-\t\t\tappendTo.Files = append(appendTo.Files, f)\n+\t\tif f.Name == IndexBundle {\n+\t\t\t// this is generated new each time\n+\t\t\tcontinue\n+\t\t}\n+\t\tif f.Type == TypeManifest &&\n+\t\t\tf.findFileNameInSlice(appendTo.Files) != nil {\n+\t\t\tcontinue\n+\t\t}\n+\t\tif f.Type == TypeIManifest &&\n+\t\t\tf.findIManifestInSlice(appendTo.Files) != nil {\n+\t\t\tcontinue\n+\t\t}\n+\t\tappendTo.Files = append(appendTo.Files, f)\n+\t}\n+}\n+\n+// writeIterativeManifests writes Iterative Manifests for all bundles in\n+// newManifests and add them to the MoM.\n+// Iterative Manifests are manifests with all file changes added in versions\n+// greater than fromVersion.\n+func (MoM *Manifest) writeIterativeManifests(newManifests []*Manifest, out string, fromVersion uint32) error {\n+\tvar err error\n+\t// write manifests then add them to the MoM\n+\tfor _, bMan := range newManifests {\n+\t\t//Don't write I manifest for full and new bundles","path":"swupd/create_manifests.go","position":34,"original_position":34,"commit_id":"3a11e8b829448cee7f77a5094a1f4c4ccb8a036f","original_commit_id":"3a11e8b829448cee7f77a5094a1f4c4ccb8a036f","user":{"login":"matthewrsj","id":12090084,"node_id":"MDQ6VXNlcjEyMDkwMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/12090084?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"body":"We might as well create an iterative manifest since the client will try to download it anyways. It not being there is just an extra network request the client has to make before it can get to work. If they are identical can we just link the two?","created_at":"2018-08-30T14:58:44Z","updated_at":"2018-08-30T14:58:44Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/411#discussion_r214065465","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/214065465"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/411#discussion_r214065465"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411"}}},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411","id":211254103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjU0MTAz","html_url":"https://github.com/clearlinux/mixer-tools/pull/411","diff_url":"https://github.com/clearlinux/mixer-tools/pull/411.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/411.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/411","number":411,"state":"open","locked":false,"title":"Introducing the Iterative to-Manifest","user":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"body":"When creating manifests for a new build, also create to-Manifests\r\nfor each bundle that has changes in this version.\r\n\r\nThe goal on publishing to-Manifests is to reduce the download size\r\non updates, according to what was discussed on\r\nhttps://github.com/clearlinux/swupd-client/issues/498","created_at":"2018-08-27T22:53:35Z","updated_at":"2018-08-30T14:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"699ed6d820e18365a0e4cc0096df4707eb927d17","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/411/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/3a11e8b829448cee7f77a5094a1f4c4ccb8a036f","head":{"label":"otaviobp:iman","ref":"iman","sha":"3a11e8b829448cee7f77a5094a1f4c4ccb8a036f","user":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"repo":{"id":146362968,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzNjI5Njg=","name":"mixer-tools","full_name":"otaviobp/mixer-tools","owner":{"login":"otaviobp","id":36560,"node_id":"MDQ6VXNlcjM2NTYw","avatar_url":"https://avatars2.githubusercontent.com/u/36560?v=4","gravatar_id":"","url":"https://api.github.com/users/otaviobp","html_url":"https://github.com/otaviobp","followers_url":"https://api.github.com/users/otaviobp/followers","following_url":"https://api.github.com/users/otaviobp/following{/other_user}","gists_url":"https://api.github.com/users/otaviobp/gists{/gist_id}","starred_url":"https://api.github.com/users/otaviobp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otaviobp/subscriptions","organizations_url":"https://api.github.com/users/otaviobp/orgs","repos_url":"https://api.github.com/users/otaviobp/repos","events_url":"https://api.github.com/users/otaviobp/events{/privacy}","received_events_url":"https://api.github.com/users/otaviobp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/otaviobp/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/otaviobp/mixer-tools","forks_url":"https://api.github.com/repos/otaviobp/mixer-tools/forks","keys_url":"https://api.github.com/repos/otaviobp/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otaviobp/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otaviobp/mixer-tools/teams","hooks_url":"https://api.github.com/repos/otaviobp/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/otaviobp/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/otaviobp/mixer-tools/events","assignees_url":"https://api.github.com/repos/otaviobp/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/otaviobp/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/otaviobp/mixer-tools/tags","blobs_url":"https://api.github.com/repos/otaviobp/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otaviobp/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otaviobp/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/otaviobp/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otaviobp/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/otaviobp/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/otaviobp/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/otaviobp/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/otaviobp/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/otaviobp/mixer-tools/subscription","commits_url":"https://api.github.com/repos/otaviobp/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/otaviobp/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/otaviobp/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/otaviobp/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/otaviobp/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/otaviobp/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otaviobp/mixer-tools/merges","archive_url":"https://api.github.com/repos/otaviobp/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otaviobp/mixer-tools/downloads","issues_url":"https://api.github.com/repos/otaviobp/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/otaviobp/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/otaviobp/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/otaviobp/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otaviobp/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/otaviobp/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/otaviobp/mixer-tools/deployments","created_at":"2018-08-27T22:51:05Z","updated_at":"2018-08-27T22:51:07Z","pushed_at":"2018-08-30T00:49:31Z","git_url":"git://github.com/otaviobp/mixer-tools.git","ssh_url":"git@github.com:otaviobp/mixer-tools.git","clone_url":"https://github.com/otaviobp/mixer-tools.git","svn_url":"https://github.com/otaviobp/mixer-tools","homepage":null,"size":1425,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"5d9055ebabc43f15bf36df90418e407dc16114cd","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-08-30T07:32:28Z","pushed_at":"2018-08-30T07:32:26Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1409,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":38,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/411"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/411"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/411/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/411/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/3a11e8b829448cee7f77a5094a1f4c4ccb8a036f"}},"author_association":"NONE"}}
{"actor":{"display_login":"matthewrsj"}}