{"action":"closed","number":1096,"pull_request":{"url":"https://api.github.com/repos/fastify/fastify/pulls/1096","id":210912103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTEyMTAz","html_url":"https://github.com/fastify/fastify/pull/1096","diff_url":"https://github.com/fastify/fastify/pull/1096.diff","patch_url":"https://github.com/fastify/fastify/pull/1096.patch","issue_url":"https://api.github.com/repos/fastify/fastify/issues/1096","number":1096,"state":"closed","locked":false,"title":"Ensure that error-in-post test is run","user":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"body":"The test error-in-post was added in commit 01f1039f77ce3ac4396fda286d3d30adc8edb085, but it was never run as file didn't end with `.test.js`. Also, it isn't called from other test files.\r\nThis code change changes file extension to `.test.js` so that it's run \r\n\r\nThe output of `npm run test` before the code change:\r\n```\r\n...\r\ntest/delete.test.js ................................. 43/43\r\ntest/fastify-instance.test.js ......................... 1/1\r\n...\r\n```\r\n\r\nafter the code change:\r\n```\r\n...\r\ntest/delete.test.js ................................. 43/43\r\ntest/error-in-post.test.js ............................ 2/2\r\ntest/fastify-instance.test.js ......................... 1/1\r\n...\r\n```\r\n\r\n#### Checklist\r\n\r\n- [x] run `npm run test` and `npm run benchmark`\r\n- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)\r\n","created_at":"2018-08-25T17:08:25Z","updated_at":"2018-08-25T19:11:45Z","closed_at":"2018-08-25T19:11:45Z","merged_at":"2018-08-25T19:11:45Z","merge_commit_sha":"6bce249e04c60914280b5919efdb4ded6a745925","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastify/fastify/pulls/1096/commits","review_comments_url":"https://api.github.com/repos/fastify/fastify/pulls/1096/comments","review_comment_url":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastify/fastify/issues/1096/comments","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/0439d20e51d958a13798de2767d620721656b6e6","head":{"label":"trivikr:error-in-post","ref":"error-in-post","sha":"0439d20e51d958a13798de2767d620721656b6e6","user":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"repo":{"id":107943778,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5NDM3Nzg=","name":"fastify","full_name":"trivikr/fastify","owner":{"login":"trivikr","id":16024985,"node_id":"MDQ6VXNlcjE2MDI0OTg1","avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trivikr/fastify","description":"Fast and low overhead web framework, for Node.js","fork":true,"url":"https://api.github.com/repos/trivikr/fastify","forks_url":"https://api.github.com/repos/trivikr/fastify/forks","keys_url":"https://api.github.com/repos/trivikr/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trivikr/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trivikr/fastify/teams","hooks_url":"https://api.github.com/repos/trivikr/fastify/hooks","issue_events_url":"https://api.github.com/repos/trivikr/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/trivikr/fastify/events","assignees_url":"https://api.github.com/repos/trivikr/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/trivikr/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/trivikr/fastify/tags","blobs_url":"https://api.github.com/repos/trivikr/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trivikr/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trivikr/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/trivikr/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trivikr/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/trivikr/fastify/languages","stargazers_url":"https://api.github.com/repos/trivikr/fastify/stargazers","contributors_url":"https://api.github.com/repos/trivikr/fastify/contributors","subscribers_url":"https://api.github.com/repos/trivikr/fastify/subscribers","subscription_url":"https://api.github.com/repos/trivikr/fastify/subscription","commits_url":"https://api.github.com/repos/trivikr/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/trivikr/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/trivikr/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/trivikr/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/trivikr/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/trivikr/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trivikr/fastify/merges","archive_url":"https://api.github.com/repos/trivikr/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trivikr/fastify/downloads","issues_url":"https://api.github.com/repos/trivikr/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/trivikr/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/trivikr/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/trivikr/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trivikr/fastify/labels{/name}","releases_url":"https://api.github.com/repos/trivikr/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/trivikr/fastify/deployments","created_at":"2017-10-23T06:59:33Z","updated_at":"2018-08-25T18:42:35Z","pushed_at":"2018-08-25T18:42:34Z","git_url":"git://github.com/trivikr/fastify.git","ssh_url":"git@github.com:trivikr/fastify.git","clone_url":"https://github.com/trivikr/fastify.git","svn_url":"https://github.com/trivikr/fastify","homepage":"https://www.fastify.io","size":1616,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastify:master","ref":"master","sha":"1f750e6d57e6e8f623db6d71b3862b09f62e0063","user":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"repo":{"id":69495170,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQ5NTE3MA==","name":"fastify","full_name":"fastify/fastify","owner":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastify/fastify","description":"Fast and low overhead web framework, for Node.js","fork":false,"url":"https://api.github.com/repos/fastify/fastify","forks_url":"https://api.github.com/repos/fastify/fastify/forks","keys_url":"https://api.github.com/repos/fastify/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastify/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastify/fastify/teams","hooks_url":"https://api.github.com/repos/fastify/fastify/hooks","issue_events_url":"https://api.github.com/repos/fastify/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/fastify/fastify/events","assignees_url":"https://api.github.com/repos/fastify/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/fastify/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/fastify/fastify/tags","blobs_url":"https://api.github.com/repos/fastify/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastify/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastify/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastify/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/fastify/fastify/languages","stargazers_url":"https://api.github.com/repos/fastify/fastify/stargazers","contributors_url":"https://api.github.com/repos/fastify/fastify/contributors","subscribers_url":"https://api.github.com/repos/fastify/fastify/subscribers","subscription_url":"https://api.github.com/repos/fastify/fastify/subscription","commits_url":"https://api.github.com/repos/fastify/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastify/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastify/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastify/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastify/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/fastify/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastify/fastify/merges","archive_url":"https://api.github.com/repos/fastify/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastify/fastify/downloads","issues_url":"https://api.github.com/repos/fastify/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/fastify/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/fastify/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/fastify/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastify/fastify/labels{/name}","releases_url":"https://api.github.com/repos/fastify/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/fastify/fastify/deployments","created_at":"2016-09-28T19:10:14Z","updated_at":"2018-08-25T18:09:15Z","pushed_at":"2018-08-25T19:11:45Z","git_url":"git://github.com/fastify/fastify.git","ssh_url":"git@github.com:fastify/fastify.git","clone_url":"https://github.com/fastify/fastify.git","svn_url":"https://github.com/fastify/fastify","homepage":"https://www.fastify.io","size":1650,"stargazers_count":7850,"watchers_count":7850,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":422,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":422,"open_issues":31,"watchers":7850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1096"},"html":{"href":"https://github.com/fastify/fastify/pull/1096"},"issue":{"href":"https://api.github.com/repos/fastify/fastify/issues/1096"},"comments":{"href":"https://api.github.com/repos/fastify/fastify/issues/1096/comments"},"review_comments":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1096/comments"},"review_comment":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1096/commits"},"statuses":{"href":"https://api.github.com/repos/fastify/fastify/statuses/0439d20e51d958a13798de2767d620721656b6e6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mcollina","id":52195,"node_id":"MDQ6VXNlcjUyMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":1,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"mcollina"}}