{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/comments/224156154","pull_request_review_id":163455619,"id":224156154,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDE1NjE1NA==","diff_hunk":"@@ -49,8 +49,9 @@ public virtual IServiceProvider Build([NotNull] DbContext context)\n             var services = new ServiceCollection()\n                 .AddEntityFrameworkDesignTimeServices(_reporter)\n                 .AddDbContextDesignTimeServices(context);\n-            ConfigureProviderServices(context.GetService<IDatabaseProvider>().Name, services);\n-            ConfigureReferencedServices(services);\n+            var provider = context.GetService<IDatabaseProvider>().Name;\n+            ConfigureProviderServices(provider, services);\n+            ConfigureReferencedServices(services, provider);","path":"src/EFCore.Design/Design/Internal/DesignTimeServicesBuilder.cs","position":8,"original_position":8,"commit_id":"37d60213fea92cadecb304ec9f351e411a7fd433","original_commit_id":"37d60213fea92cadecb304ec9f351e411a7fd433","user":{"login":"bricelam","id":1226749,"node_id":"MDQ6VXNlcjEyMjY3NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1226749?v=4","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"body":"lol, `provider` is first in the top one because it is essential to loading those services. It's last in the second one because it's just metadata used to filter out some services. It fits my personal conventions of parameter ordering perfectly. 🙃","created_at":"2018-10-10T16:44:12Z","updated_at":"2018-10-10T16:44:13Z","html_url":"https://github.com/aspnet/EntityFrameworkCore/pull/13555#discussion_r224156154","pull_request_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/comments/224156154"},"html":{"href":"https://github.com/aspnet/EntityFrameworkCore/pull/13555#discussion_r224156154"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555"}},"in_reply_to_id":223932061},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555","id":221560012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTYwMDEy","html_url":"https://github.com/aspnet/EntityFrameworkCore/pull/13555","diff_url":"https://github.com/aspnet/EntityFrameworkCore/pull/13555.diff","patch_url":"https://github.com/aspnet/EntityFrameworkCore/pull/13555.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/13555","number":13555,"state":"open","locked":false,"title":"Spatial RevEng: Automatically load NetTopologySuite services at design-time","user":{"login":"bricelam","id":1226749,"node_id":"MDQ6VXNlcjEyMjY3NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1226749?v=4","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"body":"Verification: I manually bashed on this. I verified it works with multiple provider-specific services and non-provider-specific services.\r\n\r\nResolves #12083, resolves #13283","created_at":"2018-10-09T19:36:56Z","updated_at":"2018-10-10T16:44:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c1760372f1aa2f1b5e398b98fe1d690bed1d0d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":458847819,"node_id":"MDU6TGFiZWw0NTg4NDc4MTk=","url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/labels/providers-fyi","name":"providers-fyi","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/13555/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/statuses/37d60213fea92cadecb304ec9f351e411a7fd433","head":{"label":"bricelam:global-reveng","ref":"global-reveng","sha":"37d60213fea92cadecb304ec9f351e411a7fd433","user":{"login":"bricelam","id":1226749,"node_id":"MDQ6VXNlcjEyMjY3NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1226749?v=4","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"repo":{"id":19745314,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0NTMxNA==","name":"EFCore","full_name":"bricelam/EFCore","private":false,"owner":{"login":"bricelam","id":1226749,"node_id":"MDQ6VXNlcjEyMjY3NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1226749?v=4","gravatar_id":"","url":"https://api.github.com/users/bricelam","html_url":"https://github.com/bricelam","followers_url":"https://api.github.com/users/bricelam/followers","following_url":"https://api.github.com/users/bricelam/following{/other_user}","gists_url":"https://api.github.com/users/bricelam/gists{/gist_id}","starred_url":"https://api.github.com/users/bricelam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bricelam/subscriptions","organizations_url":"https://api.github.com/users/bricelam/orgs","repos_url":"https://api.github.com/users/bricelam/repos","events_url":"https://api.github.com/users/bricelam/events{/privacy}","received_events_url":"https://api.github.com/users/bricelam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bricelam/EFCore","description":"My fork for contributing to EntityFramework","fork":true,"url":"https://api.github.com/repos/bricelam/EFCore","forks_url":"https://api.github.com/repos/bricelam/EFCore/forks","keys_url":"https://api.github.com/repos/bricelam/EFCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bricelam/EFCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bricelam/EFCore/teams","hooks_url":"https://api.github.com/repos/bricelam/EFCore/hooks","issue_events_url":"https://api.github.com/repos/bricelam/EFCore/issues/events{/number}","events_url":"https://api.github.com/repos/bricelam/EFCore/events","assignees_url":"https://api.github.com/repos/bricelam/EFCore/assignees{/user}","branches_url":"https://api.github.com/repos/bricelam/EFCore/branches{/branch}","tags_url":"https://api.github.com/repos/bricelam/EFCore/tags","blobs_url":"https://api.github.com/repos/bricelam/EFCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bricelam/EFCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bricelam/EFCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/bricelam/EFCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bricelam/EFCore/statuses/{sha}","languages_url":"https://api.github.com/repos/bricelam/EFCore/languages","stargazers_url":"https://api.github.com/repos/bricelam/EFCore/stargazers","contributors_url":"https://api.github.com/repos/bricelam/EFCore/contributors","subscribers_url":"https://api.github.com/repos/bricelam/EFCore/subscribers","subscription_url":"https://api.github.com/repos/bricelam/EFCore/subscription","commits_url":"https://api.github.com/repos/bricelam/EFCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/bricelam/EFCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/bricelam/EFCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/bricelam/EFCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/bricelam/EFCore/contents/{+path}","compare_url":"https://api.github.com/repos/bricelam/EFCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bricelam/EFCore/merges","archive_url":"https://api.github.com/repos/bricelam/EFCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bricelam/EFCore/downloads","issues_url":"https://api.github.com/repos/bricelam/EFCore/issues{/number}","pulls_url":"https://api.github.com/repos/bricelam/EFCore/pulls{/number}","milestones_url":"https://api.github.com/repos/bricelam/EFCore/milestones{/number}","notifications_url":"https://api.github.com/repos/bricelam/EFCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bricelam/EFCore/labels{/name}","releases_url":"https://api.github.com/repos/bricelam/EFCore/releases{/id}","deployments_url":"https://api.github.com/repos/bricelam/EFCore/deployments","created_at":"2014-05-13T15:45:50Z","updated_at":"2018-10-05T21:22:15Z","pushed_at":"2018-10-09T21:19:30Z","git_url":"git://github.com/bricelam/EFCore.git","ssh_url":"git@github.com:bricelam/EFCore.git","clone_url":"https://github.com/bricelam/EFCore.git","svn_url":"https://github.com/bricelam/EFCore","homepage":"","size":64987,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"release/2.2"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"17bcfb4acf4a045ccbd8a8b711d581bbef4200d5","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE1Nzc0Ng==","name":"EntityFrameworkCore","full_name":"aspnet/EntityFrameworkCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/EntityFrameworkCore","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFrameworkCore","forks_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/deployments","created_at":"2014-01-23T00:52:01Z","updated_at":"2018-10-10T15:07:41Z","pushed_at":"2018-10-10T01:49:05Z","git_url":"git://github.com/aspnet/EntityFrameworkCore.git","ssh_url":"git@github.com:aspnet/EntityFrameworkCore.git","clone_url":"https://github.com/aspnet/EntityFrameworkCore.git","svn_url":"https://github.com/aspnet/EntityFrameworkCore","homepage":"https://docs.microsoft.com/ef/core","size":65986,"stargazers_count":6552,"watchers_count":6552,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1758,"mirror_url":null,"archived":false,"open_issues_count":1038,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1758,"open_issues":1038,"watchers":6552,"default_branch":"release/2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555"},"html":{"href":"https://github.com/aspnet/EntityFrameworkCore/pull/13555"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/13555"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/13555/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/pulls/13555/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFrameworkCore/statuses/37d60213fea92cadecb304ec9f351e411a7fd433"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bricelam"}}