{"action":"reopened","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12044","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12044/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12044/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/12044/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/12044","id":328437511,"node_id":"MDU6SXNzdWUzMjg0Mzc1MTE=","number":12044,"title":"Integration test: query-test ","user":{"login":"tobrun","id":2151639,"node_id":"MDQ6VXNlcjIxNTE2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/2151639?v=4","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"labels":[{"id":143173729,"node_id":"MDU6TGFiZWwxNDMxNzM3Mjk=","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"000000","default":false},{"id":1100303563,"node_id":"MDU6TGFiZWwxMTAwMzAzNTYz","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/archived","name":"archived","color":"9e211f","default":false},{"id":211558588,"node_id":"MDU6TGFiZWwyMTE1NTg1ODg=","url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/tests","name":"tests","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"LukasPaczos","id":16925074,"node_id":"MDQ6VXNlcjE2OTI1MDc0","avatar_url":"https://avatars0.githubusercontent.com/u/16925074?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasPaczos","html_url":"https://github.com/LukasPaczos","followers_url":"https://api.github.com/users/LukasPaczos/followers","following_url":"https://api.github.com/users/LukasPaczos/following{/other_user}","gists_url":"https://api.github.com/users/LukasPaczos/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasPaczos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasPaczos/subscriptions","organizations_url":"https://api.github.com/users/LukasPaczos/orgs","repos_url":"https://api.github.com/users/LukasPaczos/repos","events_url":"https://api.github.com/users/LukasPaczos/events{/privacy}","received_events_url":"https://api.github.com/users/LukasPaczos/received_events","type":"User","site_admin":false},"assignees":[{"login":"LukasPaczos","id":16925074,"node_id":"MDQ6VXNlcjE2OTI1MDc0","avatar_url":"https://avatars0.githubusercontent.com/u/16925074?v=4","gravatar_id":"","url":"https://api.github.com/users/LukasPaczos","html_url":"https://github.com/LukasPaczos","followers_url":"https://api.github.com/users/LukasPaczos/followers","following_url":"https://api.github.com/users/LukasPaczos/following{/other_user}","gists_url":"https://api.github.com/users/LukasPaczos/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasPaczos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasPaczos/subscriptions","organizations_url":"https://api.github.com/users/LukasPaczos/orgs","repos_url":"https://api.github.com/users/LukasPaczos/repos","events_url":"https://api.github.com/users/LukasPaczos/events{/privacy}","received_events_url":"https://api.github.com/users/LukasPaczos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-01T09:02:50Z","updated_at":"2018-12-12T15:34:15Z","closed_at":null,"author_association":"MEMBER","body":"In the [`test/integration/query-test`](https://github.com/mapbox/mapbox-gl-js/tree/a5a8dfe5b90737dbb295eaca7f41c667ae4060a8/test/integration/query-tests), we define query tests to verify correctness and consistency between mapbox-gl-js and mapbox-gl-native. With render tests now executing on Android in https://github.com/mapbox/mapbox-gl-native/pull/12041 we can add the same integration for query tests. \r\n\r\n### Example query test:\r\n\r\n```json\r\n{\r\n  \"version\": 8,\r\n  \"metadata\": {\r\n    \"test\": {\r\n      \"height\": 256,\r\n      \"queryGeometry\": [\r\n        10,\r\n        100\r\n      ]\r\n    }\r\n  },\r\n  \"center\": [\r\n    13.418056,\r\n    52.499167\r\n  ],\r\n  \"zoom\": 14,\r\n  \"sources\": {\r\n    \"mapbox\": {\r\n      \"type\": \"vector\",\r\n      \"maxzoom\": 14,\r\n      \"tiles\": [\r\n        \"local://tiles/{z}-{x}-{y}.mvt\"\r\n      ]\r\n    }\r\n  },\r\n  \"layers\": [\r\n    {\r\n      \"id\": \"road\",\r\n      \"type\": \"circle\",\r\n      \"source\": \"mapbox\",\r\n      \"source-layer\": \"road\",\r\n      \"paint\": {\r\n        \"circle-radius\": 10\r\n      },\r\n      \"interactive\": true\r\n    }\r\n  ]\r\n}\r\n```\r\n\r\n### MapSnapshotter#queryRenderedFeatures\r\nTo support this kind of test we need to Integrate query render features on MapSnapshotter. Flagging that this can also be useful for end-users (eg. if they want to dynamically define Marker placement based on the results from a query). To integrate the tes itselft, we need to read out the `queryGeometry` from the test json and feed that to the MapSnapshotter. \r\n\r\ncc @LukasPaczos @ChrisLoer \r\n\r\n"}}
{"actor":{"display_login":"tobrun"}}