{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/44541","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/44541/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/44541/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/44541/events","html_url":"https://github.com/ansible/ansible/pull/44541","id":353145231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjc5NTY5","number":44541,"title":"Add 'chars' parameter support to passwordstore lookup plugin","user":{"login":"MegaphoneJon","id":1796012,"node_id":"MDQ6VXNlcjE3OTYwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1796012?v=4","gravatar_id":"","url":"https://api.github.com/users/MegaphoneJon","html_url":"https://github.com/MegaphoneJon","followers_url":"https://api.github.com/users/MegaphoneJon/followers","following_url":"https://api.github.com/users/MegaphoneJon/following{/other_user}","gists_url":"https://api.github.com/users/MegaphoneJon/gists{/gist_id}","starred_url":"https://api.github.com/users/MegaphoneJon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MegaphoneJon/subscriptions","organizations_url":"https://api.github.com/users/MegaphoneJon/orgs","repos_url":"https://api.github.com/users/MegaphoneJon/repos","events_url":"https://api.github.com/users/MegaphoneJon/events{/privacy}","received_events_url":"https://api.github.com/users/MegaphoneJon/received_events","type":"User","site_admin":false},"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-22T22:12:01Z","updated_at":"2018-08-23T02:52:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/44541","html_url":"https://github.com/ansible/ansible/pull/44541","diff_url":"https://github.com/ansible/ansible/pull/44541.diff","patch_url":"https://github.com/ansible/ansible/pull/44541.patch"},"body":"##### SUMMARY\r\nThe `password` lookup plugin has a `chars` parameter, which allows you to specify allowable characters in the passwords it generates.  The `passwordstore` lookup plugin lacks this parameter.  This PR adds the equivalent `chars` parameter to the `passwordstore` plugin.\r\n\r\n##### ISSUE TYPE\r\nFeature Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\npasswordstore lookup plugin\r\n\r\n##### ANSIBLE VERSION\r\n```\r\ndevel\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\nThe new feature is identical to the `chars` parameter in the `password` plugin, and takes the same values.  I added an example to demonstrate its use in the `EXAMPLES` variable.\r\n\r\nThis is my first submission to Ansible.  If this requires changes to be merged and someone from the community can provide guidance, I'd be very grateful!"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/415265916","html_url":"https://github.com/ansible/ansible/pull/44541#issuecomment-415265916","issue_url":"https://api.github.com/repos/ansible/ansible/issues/44541","id":415265916,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTI2NTkxNg==","user":{"login":"ansibot","id":6585283,"node_id":"MDQ6VXNlcjY1ODUyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T02:52:46Z","updated_at":"2018-08-23T02:52:46Z","author_association":"CONTRIBUTOR","body":"The test `ansible-test sanity --test pep8` [[explain](https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/pep8.html)] failed with 2 errors:\n```\nlib/ansible/plugins/lookup/passwordstore.py:113:1: E302 expected 2 blank lines, found 1\nlib/ansible/plugins/lookup/passwordstore.py:147:1: E302 expected 2 blank lines, found 1\n```\n<!-- job_id: 5b7ddfb892cece070052e727 -->\n<!-- job_id: 5b7ddfddc3b8bd0800cd030c -->\n<!-- job_id: /testresults/ansible-test-sanity-pep8.json -->\n\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: shippable_test_result --->"}}
{"actor":{"display_login":"ansibot"}}