{"action":"created","issue":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2862","repository_url":"https://api.github.com/repos/MvvmCross/MvvmCross","labels_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2862/labels{/name}","comments_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2862/comments","events_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2862/events","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2862","id":321180371,"number":2862,"title":"Plugin loading on references of core assemblies","user":{"login":"rdorta","id":2000203,"avatar_url":"https://avatars3.githubusercontent.com/u/2000203?v=4","gravatar_id":"","url":"https://api.github.com/users/rdorta","html_url":"https://github.com/rdorta","followers_url":"https://api.github.com/users/rdorta/followers","following_url":"https://api.github.com/users/rdorta/following{/other_user}","gists_url":"https://api.github.com/users/rdorta/gists{/gist_id}","starred_url":"https://api.github.com/users/rdorta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdorta/subscriptions","organizations_url":"https://api.github.com/users/rdorta/orgs","repos_url":"https://api.github.com/users/rdorta/repos","events_url":"https://api.github.com/users/rdorta/events{/privacy}","received_events_url":"https://api.github.com/users/rdorta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-08T13:12:17Z","updated_at":"2018-05-08T13:12:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/pulls/2862","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2862","diff_url":"https://github.com/MvvmCross/MvvmCross/pull/2862.diff","patch_url":"https://github.com/MvvmCross/MvvmCross/pull/2862.patch"},"body":"### :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)\r\nFixes cases of plugin usage in core assembly with no explicit reference on the entry point assembly.\r\nThis makes MvxSetup load all referenced assemblies in the entry point referenced assemblies.\r\nFixes cases where in WPF as an example, we don't need to have a LinkerPleaseIncludeFile and also have no need to create an instance or static reference to a Plugin.\r\n\r\n### :arrow_heading_down: What is the current behavior?\r\nIf you use a plugin in a WPF project as an example you have to create a strong reference to a Plugin type so that the plugin assembly can be loaded in AppDomain.\r\n\r\n### :new: What is the new behavior (if this is a feature change)?\r\nNow you don't need a strong reference, because you probably already have it in your Core project, so MvxSetup will look for plugins in the core project references as well.\r\n\r\n### :boom: Does this PR introduce a breaking change?\r\nNo.\r\n\r\n### :bug: Recommendations for testing\r\nRunning any plugin in all projects without having a strong reference type to any type in plugin assembly.\r\n\r\n### :memo: Links to relevant issues/docs\r\n\r\n\r\n### :thinking: Checklist before submitting\r\n\r\n- [X ] All projects build\r\n- [ X] Follows style guide lines ([code style guide](https://github.com/MvvmCross/MvvmCross#code-style-guidelines))\r\n- [ ] Relevant documentation was updated ([docs style guide](https://www.mvvmcross.com/documentation/contribute/mvvmcross-docs-style-guide))\r\n- [X ] Rebased onto current develop\r\n"},"comment":{"url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/comments/387397295","html_url":"https://github.com/MvvmCross/MvvmCross/pull/2862#issuecomment-387397295","issue_url":"https://api.github.com/repos/MvvmCross/MvvmCross/issues/2862","id":387397295,"user":{"login":"dnfclas","id":10201666,"avatar_url":"https://avatars3.githubusercontent.com/u/10201666?v=4","gravatar_id":"","url":"https://api.github.com/users/dnfclas","html_url":"https://github.com/dnfclas","followers_url":"https://api.github.com/users/dnfclas/followers","following_url":"https://api.github.com/users/dnfclas/following{/other_user}","gists_url":"https://api.github.com/users/dnfclas/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfclas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfclas/subscriptions","organizations_url":"https://api.github.com/users/dnfclas/orgs","repos_url":"https://api.github.com/users/dnfclas/repos","events_url":"https://api.github.com/users/dnfclas/events{/privacy}","received_events_url":"https://api.github.com/users/dnfclas/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T13:12:28Z","updated_at":"2018-05-08T13:12:28Z","author_association":"NONE","body":"[![CLA assistant check](https://cla.dotnetfoundation.org/pull/badge/not_signed)](https://cla.dotnetfoundation.org/MvvmCross/MvvmCross?pullRequest=2862) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.dotnetfoundation.org/MvvmCross/MvvmCross?pullRequest=2862) before we can accept your contribution.<br/><br/>:x: rdorta [sign now](https://cla.dotnetfoundation.org/MvvmCross/MvvmCross?pullRequest=2862)<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla.dotnetfoundation.org/check/MvvmCross/MvvmCross?pullRequest=2862) it.</sub>"}}
{"actor":{"display_login":"dnfclas"}}