{"action":"closed","number":2348,"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348","id":233086664,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDg2NjY0","html_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2348","diff_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2348.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2348.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2348","number":2348,"state":"closed","locked":false,"title":"[IMPROVEMENT][PERFORMANCE] Optimize size calculation performance on messages cell","user":{"login":"rafaelks","id":551004,"node_id":"MDQ6VXNlcjU1MTAwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/551004?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelks","html_url":"https://github.com/rafaelks","followers_url":"https://api.github.com/users/rafaelks/followers","following_url":"https://api.github.com/users/rafaelks/following{/other_user}","gists_url":"https://api.github.com/users/rafaelks/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelks/subscriptions","organizations_url":"https://api.github.com/users/rafaelks/orgs","repos_url":"https://api.github.com/users/rafaelks/repos","events_url":"https://api.github.com/users/rafaelks/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelks/received_events","type":"User","site_admin":false},"body":"@RocketChat/ios\r\n\r\nThis PR includes the following changes in order to achieve better scrolling/processing performance on the messages list:\r\n\r\n1. Removed unnecessary processing from size calculation: image loading, UIActivityViewController manipulation, basic and fixed labels attributions;\r\n2. Removed the usage of `imageWithTint()` from the read receipt. Now the app has the two colors as assets instead;\r\n3. Removed the redundant calls for `superview.theme` on the Theme class;\r\n4. Cache all nibs and views instantiated in order to calculate the size of the cell. Now each cell will be only instantiated once;\r\n","created_at":"2018-11-22T23:58:57Z","updated_at":"2018-11-23T14:12:50Z","closed_at":"2018-11-23T14:12:50Z","merged_at":"2018-11-23T14:12:50Z","merge_commit_sha":"193596b5592591c18814d41d1e5746fd5cbd92da","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cardoso","id":5606812,"node_id":"MDQ6VXNlcjU2MDY4MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/5606812?v=4","gravatar_id":"","url":"https://api.github.com/users/cardoso","html_url":"https://github.com/cardoso","followers_url":"https://api.github.com/users/cardoso/followers","following_url":"https://api.github.com/users/cardoso/following{/other_user}","gists_url":"https://api.github.com/users/cardoso/gists{/gist_id}","starred_url":"https://api.github.com/users/cardoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cardoso/subscriptions","organizations_url":"https://api.github.com/users/cardoso/orgs","repos_url":"https://api.github.com/users/cardoso/repos","events_url":"https://api.github.com/users/cardoso/events{/privacy}","received_events_url":"https://api.github.com/users/cardoso/received_events","type":"User","site_admin":false},{"login":"Sameesunkaria","id":7317008,"node_id":"MDQ6VXNlcjczMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7317008?v=4","gravatar_id":"","url":"https://api.github.com/users/Sameesunkaria","html_url":"https://github.com/Sameesunkaria","followers_url":"https://api.github.com/users/Sameesunkaria/followers","following_url":"https://api.github.com/users/Sameesunkaria/following{/other_user}","gists_url":"https://api.github.com/users/Sameesunkaria/gists{/gist_id}","starred_url":"https://api.github.com/users/Sameesunkaria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sameesunkaria/subscriptions","organizations_url":"https://api.github.com/users/Sameesunkaria/orgs","repos_url":"https://api.github.com/users/Sameesunkaria/repos","events_url":"https://api.github.com/users/Sameesunkaria/events{/privacy}","received_events_url":"https://api.github.com/users/Sameesunkaria/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":583832924,"node_id":"MDU6TGFiZWw1ODM4MzI5MjQ=","url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/labels/%F0%9F%9A%80%20performance","name":"🚀 performance","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/milestones/43","html_url":"https://github.com/RocketChat/Rocket.Chat.iOS/milestone/43","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/milestones/43/labels","id":3508031,"node_id":"MDk6TWlsZXN0b25lMzUwODAzMQ==","number":43,"title":"3.2.0","description":"","creator":{"login":"rafaelks","id":551004,"node_id":"MDQ6VXNlcjU1MTAwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/551004?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelks","html_url":"https://github.com/rafaelks","followers_url":"https://api.github.com/users/rafaelks/followers","following_url":"https://api.github.com/users/rafaelks/following{/other_user}","gists_url":"https://api.github.com/users/rafaelks/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelks/subscriptions","organizations_url":"https://api.github.com/users/rafaelks/orgs","repos_url":"https://api.github.com/users/rafaelks/repos","events_url":"https://api.github.com/users/rafaelks/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelks/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":118,"state":"open","created_at":"2018-07-19T03:00:37Z","updated_at":"2018-11-23T14:12:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2348/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/a1f7d7601bf3e1ba5cfb4a16188da3a7061595e9","head":{"label":"RocketChat:improvement/optimize_size_calculation","ref":"improvement/optimize_size_calculation","sha":"a1f7d7601bf3e1ba5cfb4a16188da3a7061595e9","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":40144228,"node_id":"MDEwOlJlcG9zaXRvcnk0MDE0NDIyOA==","name":"Rocket.Chat.iOS","full_name":"RocketChat/Rocket.Chat.iOS","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.iOS","description":"Rocket.Chat client in Swift for iOS","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/deployments","created_at":"2015-08-03T19:37:05Z","updated_at":"2018-11-23T12:22:12Z","pushed_at":"2018-11-23T14:12:50Z","git_url":"git://github.com/RocketChat/Rocket.Chat.iOS.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.iOS.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.iOS.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.iOS","homepage":"https://rocket.chat","size":122815,"stargazers_count":767,"watchers_count":767,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":303,"open_issues":102,"watchers":767,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"fc039312250903708f4a17cb397e8d86bf6e79bb","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":40144228,"node_id":"MDEwOlJlcG9zaXRvcnk0MDE0NDIyOA==","name":"Rocket.Chat.iOS","full_name":"RocketChat/Rocket.Chat.iOS","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.iOS","description":"Rocket.Chat client in Swift for iOS","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/deployments","created_at":"2015-08-03T19:37:05Z","updated_at":"2018-11-23T12:22:12Z","pushed_at":"2018-11-23T14:12:50Z","git_url":"git://github.com/RocketChat/Rocket.Chat.iOS.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.iOS.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.iOS.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.iOS","homepage":"https://rocket.chat","size":122815,"stargazers_count":767,"watchers_count":767,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":303,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":303,"open_issues":102,"watchers":767,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.iOS/pull/2348"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2348"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/issues/2348/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/pulls/2348/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.iOS/statuses/a1f7d7601bf3e1ba5cfb4a16188da3a7061595e9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rafaelks","id":551004,"node_id":"MDQ6VXNlcjU1MTAwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/551004?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelks","html_url":"https://github.com/rafaelks","followers_url":"https://api.github.com/users/rafaelks/followers","following_url":"https://api.github.com/users/rafaelks/following{/other_user}","gists_url":"https://api.github.com/users/rafaelks/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelks/subscriptions","organizations_url":"https://api.github.com/users/rafaelks/orgs","repos_url":"https://api.github.com/users/rafaelks/repos","events_url":"https://api.github.com/users/rafaelks/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelks/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"maintainer_can_modify":false,"commits":19,"additions":289,"deletions":263,"changed_files":46}}
{"actor":{"display_login":"rafaelks"}}