{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/236048861","pull_request_review_id":178057307,"id":236048861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA0ODg2MQ==","diff_hunk":"@@ -68,23 +77,52 @@ message HttpService {\n   // Sets the HTTP server URI which the authorization requests must be sent to.\n   envoy.api.v2.core.HttpUri server_uri = 1;\n \n-  // Sets an optional prefix to the value of authorization request header *Path*.\n-  string path_prefix = 2;\n-\n+  reserved 2;\n   reserved 3;\n+  reserved 4;\n+  reserved 5;\n+  reserved 6;\n+\n+  // Settings for controlling request headers forwarded from the filter to the authorization server.\n+  AuthorizationRequest authorization_request = 7;\n+\n+  // Settings for controlling authorization response forwarded from the filter to a client,\n+  // or to an upstream service.\n+  AuthorizationResponse authorization_response = 8;\n+}\n+\n+message AuthorizationRequest {\n+  // Sets an optional prefix to the value of authorization request header *Path*.\n+  string path_prefix = 1;\n \n-  // Sets a list of headers that can be sent from the authorization server to the upstream service,\n-  // or to the downstream client when present in the authorization response. Note that a matched\n-  // request header will have its value overridden by the ones sent from the authorization server.\n-  repeated string allowed_authorization_headers = 4;\n+  // Sets a list of keys that are used to determine which client request headers should\n+  // be forwarded *from the filter* to the authorization server. Note that *Content-Length*,\n+  // *Authority*, *Method*, *Path* and *Authorization* are always dispatched to the authorization\n+  // server by default. The message will not contain body data and the *Content-Length* will be set\n+  // to zero.\n+  repeated string allowed_headers = 2;","path":"api/envoy/config/filter/http/ext_authz/v2alpha/ext_authz.proto","position":57,"original_position":66,"commit_id":"5be20053c51a497720cb0c30151c2eff994fe402","original_commit_id":"c2baabbbaf74ba1f89d11d4ef9870219eb941b98","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"Ping on this?","created_at":"2018-11-24T17:42:33Z","updated_at":"2018-11-24T17:43:13Z","html_url":"https://github.com/envoyproxy/envoy/pull/4947#discussion_r236048861","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/236048861"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4947#discussion_r236048861"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947"}},"in_reply_to_id":231646364},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947","id":227881409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODgxNDA5","html_url":"https://github.com/envoyproxy/envoy/pull/4947","diff_url":"https://github.com/envoyproxy/envoy/pull/4947.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4947.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4947","number":4947,"state":"open","locked":false,"title":"ext-authz: added authentication and authorization context headers to the filter whitelist default","user":{"login":"gsagula","id":587468,"node_id":"MDQ6VXNlcjU4NzQ2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"body":"*Description*: This PR adds headers that are normally used in the context of authentication and authorization to the respective whitelists. It also introduce a feature that allows the operator to have more control over headers that are sent from the authorization server back to the client. In addition to that, the HTTP service configuration has modified to support the new features and also provide more comprehensive structure. I also included the necessary changes to the documentation, tests as well as some test suite cleanup.\r\n\r\n*Risk Level*: medium\r\n*Testing*: unit and manual testing\r\n*Docs Changes*: yes\r\n*Release Notes*: yes\r\n*Fixes* #4756 ","created_at":"2018-11-02T09:44:46Z","updated_at":"2018-11-24T17:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38101834b6dfedde3aeb919c74f6ef4590b6a9f4","assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4947/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/5be20053c51a497720cb0c30151c2eff994fe402","head":{"label":"gsagula:authz_headers","ref":"authz_headers","sha":"5be20053c51a497720cb0c30151c2eff994fe402","user":{"login":"gsagula","id":587468,"node_id":"MDQ6VXNlcjU4NzQ2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"repo":{"id":97367677,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM2NzY3Nw==","name":"envoy","full_name":"gsagula/envoy","private":false,"owner":{"login":"gsagula","id":587468,"node_id":"MDQ6VXNlcjU4NzQ2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/587468?v=4","gravatar_id":"","url":"https://api.github.com/users/gsagula","html_url":"https://github.com/gsagula","followers_url":"https://api.github.com/users/gsagula/followers","following_url":"https://api.github.com/users/gsagula/following{/other_user}","gists_url":"https://api.github.com/users/gsagula/gists{/gist_id}","starred_url":"https://api.github.com/users/gsagula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsagula/subscriptions","organizations_url":"https://api.github.com/users/gsagula/orgs","repos_url":"https://api.github.com/users/gsagula/repos","events_url":"https://api.github.com/users/gsagula/events{/privacy}","received_events_url":"https://api.github.com/users/gsagula/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gsagula/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/gsagula/envoy","forks_url":"https://api.github.com/repos/gsagula/envoy/forks","keys_url":"https://api.github.com/repos/gsagula/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsagula/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsagula/envoy/teams","hooks_url":"https://api.github.com/repos/gsagula/envoy/hooks","issue_events_url":"https://api.github.com/repos/gsagula/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/gsagula/envoy/events","assignees_url":"https://api.github.com/repos/gsagula/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/gsagula/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/gsagula/envoy/tags","blobs_url":"https://api.github.com/repos/gsagula/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsagula/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsagula/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsagula/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsagula/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/gsagula/envoy/languages","stargazers_url":"https://api.github.com/repos/gsagula/envoy/stargazers","contributors_url":"https://api.github.com/repos/gsagula/envoy/contributors","subscribers_url":"https://api.github.com/repos/gsagula/envoy/subscribers","subscription_url":"https://api.github.com/repos/gsagula/envoy/subscription","commits_url":"https://api.github.com/repos/gsagula/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsagula/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsagula/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsagula/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsagula/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/gsagula/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsagula/envoy/merges","archive_url":"https://api.github.com/repos/gsagula/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsagula/envoy/downloads","issues_url":"https://api.github.com/repos/gsagula/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/gsagula/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/gsagula/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/gsagula/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsagula/envoy/labels{/name}","releases_url":"https://api.github.com/repos/gsagula/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/gsagula/envoy/deployments","created_at":"2017-07-16T07:30:34Z","updated_at":"2018-08-18T16:56:49Z","pushed_at":"2018-11-21T20:27:21Z","git_url":"git://github.com/gsagula/envoy.git","ssh_url":"git@github.com:gsagula/envoy.git","clone_url":"https://github.com/gsagula/envoy.git","svn_url":"https://github.com/gsagula/envoy","homepage":"https://lyft.github.io/envoy","size":24018,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"08310eb305059ce64d04d0640f13fdf931c1e10e","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-11-24T17:39:59Z","pushed_at":"2018-11-24T17:39:51Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":23867,"stargazers_count":7272,"watchers_count":7272,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1013,"mirror_url":null,"archived":false,"open_issues_count":360,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1013,"open_issues":360,"watchers":7272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4947"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4947"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4947/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4947/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/5be20053c51a497720cb0c30151c2eff994fe402"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattklein123"}}