{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/244843385","pull_request_review_id":188814566,"id":244843385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDg0MzM4NQ==","diff_hunk":"@@ -190,6 +190,7 @@ func newClient(apiURL *url.URL, httpClientToUse *http.Client, controlPlaneNamesp\n \t}, nil\n }\n \n+// NewInternalClient creates a new Public API client intended to run inside a Kubernetes cluster.","path":"controller/api/public/client.go","position":4,"original_position":4,"commit_id":"063d968306da357e1c1532814cae1a27c6f88d80","original_commit_id":"063d968306da357e1c1532814cae1a27c6f88d80","user":{"login":"klingerf","id":9226,"node_id":"MDQ6VXNlcjkyMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9226?v=4","gravatar_id":"","url":"https://api.github.com/users/klingerf","html_url":"https://github.com/klingerf","followers_url":"https://api.github.com/users/klingerf/followers","following_url":"https://api.github.com/users/klingerf/following{/other_user}","gists_url":"https://api.github.com/users/klingerf/gists{/gist_id}","starred_url":"https://api.github.com/users/klingerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klingerf/subscriptions","organizations_url":"https://api.github.com/users/klingerf/orgs","repos_url":"https://api.github.com/users/klingerf/repos","events_url":"https://api.github.com/users/klingerf/events{/privacy}","received_events_url":"https://api.github.com/users/klingerf/received_events","type":"User","site_admin":false},"body":"Mind wrapping this at 80 characters? Same goes for the comment on line 203 in this file.","created_at":"2019-01-02T20:21:42Z","updated_at":"2019-01-02T20:33:43Z","html_url":"https://github.com/linkerd/linkerd2/pull/2023#discussion_r244843385","pull_request_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/244843385"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/2023#discussion_r244843385"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023"}}},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023","id":240605419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjA1NDE5","html_url":"https://github.com/linkerd/linkerd2/pull/2023","diff_url":"https://github.com/linkerd/linkerd2/pull/2023.diff","patch_url":"https://github.com/linkerd/linkerd2/pull/2023.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/2023","number":2023,"state":"open","locked":false,"title":"Enable lint check for comments","user":{"login":"siggy","id":236915,"node_id":"MDQ6VXNlcjIzNjkxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/236915?v=4","gravatar_id":"","url":"https://api.github.com/users/siggy","html_url":"https://github.com/siggy","followers_url":"https://api.github.com/users/siggy/followers","following_url":"https://api.github.com/users/siggy/following{/other_user}","gists_url":"https://api.github.com/users/siggy/gists{/gist_id}","starred_url":"https://api.github.com/users/siggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siggy/subscriptions","organizations_url":"https://api.github.com/users/siggy/orgs","repos_url":"https://api.github.com/users/siggy/repos","events_url":"https://api.github.com/users/siggy/events{/privacy}","received_events_url":"https://api.github.com/users/siggy/received_events","type":"User","site_admin":false},"body":"Part of #217. Follow up from #1982 and #2018.\r\n\r\nA subsequent commit will fix the ci failure.\r\n\r\nSigned-off-by: Andrew Seigner <siggy@buoyant.io>\r\n\r\n### 2nd commit\r\n\r\nAddress all comment-related linter errors.\r\n\r\nThis change addresses all comment-related linter errors by doing the\r\nfollowing:\r\n- Add comments to exported symbols\r\n- Make some exported symbols private\r\n- Recommend via TODOs that some exported symbols should should move or\r\n  be removed\r\n\r\nThis PR does not:\r\n- Modify, move, or remove any code\r\n- Modify existing comments\r\n\r\nSigned-off-by: Andrew Seigner <siggy@buoyant.io>","created_at":"2018-12-22T00:36:38Z","updated_at":"2019-01-02T20:33:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bf221d77997c9bd3c78d6ea18f34a6bf940b86a","assignee":{"login":"siggy","id":236915,"node_id":"MDQ6VXNlcjIzNjkxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/236915?v=4","gravatar_id":"","url":"https://api.github.com/users/siggy","html_url":"https://github.com/siggy","followers_url":"https://api.github.com/users/siggy/followers","following_url":"https://api.github.com/users/siggy/following{/other_user}","gists_url":"https://api.github.com/users/siggy/gists{/gist_id}","starred_url":"https://api.github.com/users/siggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siggy/subscriptions","organizations_url":"https://api.github.com/users/siggy/orgs","repos_url":"https://api.github.com/users/siggy/repos","events_url":"https://api.github.com/users/siggy/events{/privacy}","received_events_url":"https://api.github.com/users/siggy/received_events","type":"User","site_admin":false},"assignees":[{"login":"siggy","id":236915,"node_id":"MDQ6VXNlcjIzNjkxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/236915?v=4","gravatar_id":"","url":"https://api.github.com/users/siggy","html_url":"https://github.com/siggy","followers_url":"https://api.github.com/users/siggy/followers","following_url":"https://api.github.com/users/siggy/following{/other_user}","gists_url":"https://api.github.com/users/siggy/gists{/gist_id}","starred_url":"https://api.github.com/users/siggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siggy/subscriptions","organizations_url":"https://api.github.com/users/siggy/orgs","repos_url":"https://api.github.com/users/siggy/repos","events_url":"https://api.github.com/users/siggy/events{/privacy}","received_events_url":"https://api.github.com/users/siggy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":782680695,"node_id":"MDU6TGFiZWw3ODI2ODA2OTU=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/area/build","name":"area/build","color":"0052CC","default":false},{"id":880299250,"node_id":"MDU6TGFiZWw4ODAyOTkyNTA=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/area/test","name":"area/test","color":"0052CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/2023/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/063d968306da357e1c1532814cae1a27c6f88d80","head":{"label":"linkerd:siggy/all-the-comments","ref":"siggy/all-the-comments","sha":"063d968306da357e1c1532814cae1a27c6f88d80","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"linkerd2","full_name":"linkerd/linkerd2","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd2","description":"A service mesh for Kubernetes and beyond. Main repo for Linkerd 2.x.","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd2","forks_url":"https://api.github.com/repos/linkerd/linkerd2/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd2/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd2/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd2/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd2/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd2/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd2/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd2/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd2/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2019-01-02T20:14:21Z","pushed_at":"2019-01-02T20:13:15Z","git_url":"git://github.com/linkerd/linkerd2.git","ssh_url":"git@github.com:linkerd/linkerd2.git","clone_url":"https://github.com/linkerd/linkerd2.git","svn_url":"https://github.com/linkerd/linkerd2","homepage":"https://linkerd.io","size":22592,"stargazers_count":3091,"watchers_count":3091,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":220,"open_issues":231,"watchers":3091,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"a9511aba06fddb64b429b3c269d07e0da6e91738","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"linkerd2","full_name":"linkerd/linkerd2","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd2","description":"A service mesh for Kubernetes and beyond. Main repo for Linkerd 2.x.","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd2","forks_url":"https://api.github.com/repos/linkerd/linkerd2/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd2/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd2/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd2/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd2/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd2/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd2/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd2/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd2/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2019-01-02T20:14:21Z","pushed_at":"2019-01-02T20:13:15Z","git_url":"git://github.com/linkerd/linkerd2.git","ssh_url":"git@github.com:linkerd/linkerd2.git","clone_url":"https://github.com/linkerd/linkerd2.git","svn_url":"https://github.com/linkerd/linkerd2","homepage":"https://linkerd.io","size":22592,"stargazers_count":3091,"watchers_count":3091,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":231,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":220,"open_issues":231,"watchers":3091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/2023"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/2023"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/2023/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/2023/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd2/statuses/063d968306da357e1c1532814cae1a27c6f88d80"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"klingerf"}}