{"action":"opened","number":33318,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33318","id":229207730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjA3NzMw","html_url":"https://github.com/dotnet/corefx/pull/33318","diff_url":"https://github.com/dotnet/corefx/pull/33318.diff","patch_url":"https://github.com/dotnet/corefx/pull/33318.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33318","number":33318,"state":"open","locked":false,"title":"filter out MSG_PEEK so it does not loop back","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"fixes  #31766\r\n\r\nThe problem is that if ReceiveAsync() is called with 0 size buffer we add MSG_PEEK and wait for data to arrive. (caller has nothing to do with it) This works ok on Linux & Windows. However on OSX the MSG_PEEK get also set in msg_control flags. That get pushed  to SocketFlags in EventArgs.\r\nWhen that is reused to make the call with real buffer the MSG_PEEK is still set and we will never finish reading and draining the socket buffer. \r\n\r\nSince this is platform difference I decided to fix it in PAL layer. I did testing on Linux and MSG_PEEK would never be set by os as far as I know. ","created_at":"2018-11-07T23:55:40Z","updated_at":"2018-11-07T23:55:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"assignees":[{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":205613895,"node_id":"MDU6TGFiZWwyMDU2MTM4OTU=","url":"https://api.github.com/repos/dotnet/corefx/labels/os-mac-os-x","name":"os-mac-os-x","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/21","html_url":"https://github.com/dotnet/corefx/milestone/21","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/21/labels","id":3242632,"node_id":"MDk6TWlsZXN0b25lMzI0MjYzMg==","number":21,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":328,"closed_issues":2498,"state":"open","created_at":"2018-04-04T16:40:10Z","updated_at":"2018-11-07T23:55:40Z","due_on":"2019-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33318/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33318/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33318/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/641040a54b9d66cc7c0cc3b80284205064dbc14a","head":{"label":"wfurt:osx_0read","ref":"osx_0read","sha":"641040a54b9d66cc7c0cc3b80284205064dbc14a","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"repo":{"id":91738855,"node_id":"MDEwOlJlcG9zaXRvcnk5MTczODg1NQ==","name":"corefx","full_name":"wfurt/corefx","private":false,"owner":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wfurt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/wfurt/corefx","forks_url":"https://api.github.com/repos/wfurt/corefx/forks","keys_url":"https://api.github.com/repos/wfurt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wfurt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wfurt/corefx/teams","hooks_url":"https://api.github.com/repos/wfurt/corefx/hooks","issue_events_url":"https://api.github.com/repos/wfurt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/wfurt/corefx/events","assignees_url":"https://api.github.com/repos/wfurt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/wfurt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/wfurt/corefx/tags","blobs_url":"https://api.github.com/repos/wfurt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wfurt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wfurt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/wfurt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wfurt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/wfurt/corefx/languages","stargazers_url":"https://api.github.com/repos/wfurt/corefx/stargazers","contributors_url":"https://api.github.com/repos/wfurt/corefx/contributors","subscribers_url":"https://api.github.com/repos/wfurt/corefx/subscribers","subscription_url":"https://api.github.com/repos/wfurt/corefx/subscription","commits_url":"https://api.github.com/repos/wfurt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/wfurt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/wfurt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/wfurt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/wfurt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/wfurt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wfurt/corefx/merges","archive_url":"https://api.github.com/repos/wfurt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wfurt/corefx/downloads","issues_url":"https://api.github.com/repos/wfurt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/wfurt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/wfurt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/wfurt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wfurt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/wfurt/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/wfurt/corefx/deployments","created_at":"2017-05-18T21:24:08Z","updated_at":"2018-10-17T01:00:11Z","pushed_at":"2018-11-07T23:38:12Z","git_url":"git://github.com/wfurt/corefx.git","ssh_url":"git@github.com:wfurt/corefx.git","clone_url":"https://github.com/wfurt/corefx.git","svn_url":"https://github.com/wfurt/corefx","homepage":"https://github.com/dotnet/core","size":188095,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"684704de20c28103ea8e0063bda7ed98f0912c58","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-07T21:50:01Z","pushed_at":"2018-11-07T23:49:21Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":190928,"stargazers_count":15101,"watchers_count":15101,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4470,"mirror_url":null,"archived":false,"open_issues_count":2607,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4470,"open_issues":2607,"watchers":15101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33318"},"html":{"href":"https://github.com/dotnet/corefx/pull/33318"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33318"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33318/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33318/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33318/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/641040a54b9d66cc7c0cc3b80284205064dbc14a"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"wfurt"}}