{"action":"opened","number":62874,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874","id":182876620,"html_url":"https://github.com/kubernetes/kubernetes/pull/62874","diff_url":"https://github.com/kubernetes/kubernetes/pull/62874.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62874.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62874","number":62874,"state":"open","locked":false,"title":"dockershim/sandbox: clean up pod network even if SetUpPod() failed","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"body":"If the CNI network plugin completes successfully, but something fails\r\nbetween that success and dockerhsim's sandbox setup code, plugin resources\r\nmay not be cleaned up. A non-trivial amount of code runs after the\r\nplugin itself exits and the CNI driver's SetUpPod() returns, and any error\r\ncondition recognized by that code would cause this leakage.\r\n\r\nThe Kubernetes CRI RunPodSandbox() request does not attempt to clean\r\nup on errors, since it cannot know how much (if any) networking\r\nwas actually set up. It depends on the CRI implementation to do\r\nthat cleanup for it.\r\n\r\nIn the dockershim case, a SetUpPod() failure means networkReady is\r\nFALSE for the sandbox, and TearDownPod() will not be called later by\r\ngarbage collection even though networking was configured, because\r\ndockershim can't know how far SetUpPod() got.\r\n\r\nConcrete examples include if the sandbox's container is somehow\r\nremoved during during that time, or another OS error is encountered,\r\nor the plugin returns a malformed result to the CNI driver.\r\n\r\nFixes: https://bugzilla.redhat.com/show_bug.cgi?id=1532965\r\n\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-04-19T19:34:48Z","updated_at":"2018-04-19T19:34:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62874/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/6dddcd9722ab0b459823212f02f3232f2901ca37","head":{"label":"dcbw:dockershim-SetUpPod-cleanup-on-failure","ref":"dockershim-SetUpPod-cleanup-on-failure","sha":"6dddcd9722ab0b459823212f02f3232f2901ca37","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"repo":{"id":43094783,"name":"kubernetes","full_name":"dcbw/kubernetes","owner":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcbw/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dcbw/kubernetes","forks_url":"https://api.github.com/repos/dcbw/kubernetes/forks","keys_url":"https://api.github.com/repos/dcbw/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbw/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbw/kubernetes/teams","hooks_url":"https://api.github.com/repos/dcbw/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dcbw/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dcbw/kubernetes/events","assignees_url":"https://api.github.com/repos/dcbw/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dcbw/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dcbw/kubernetes/tags","blobs_url":"https://api.github.com/repos/dcbw/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbw/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbw/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbw/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbw/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbw/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dcbw/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dcbw/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dcbw/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dcbw/kubernetes/subscription","commits_url":"https://api.github.com/repos/dcbw/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbw/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbw/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbw/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcbw/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dcbw/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbw/kubernetes/merges","archive_url":"https://api.github.com/repos/dcbw/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbw/kubernetes/downloads","issues_url":"https://api.github.com/repos/dcbw/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dcbw/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbw/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbw/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbw/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dcbw/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dcbw/kubernetes/deployments","created_at":"2015-09-24T21:46:52Z","updated_at":"2017-07-20T10:20:15Z","pushed_at":"2018-04-19T19:22:31Z","git_url":"git://github.com/dcbw/kubernetes.git","ssh_url":"git@github.com:dcbw/kubernetes.git","clone_url":"https://github.com/dcbw/kubernetes.git","svn_url":"https://github.com/dcbw/kubernetes","homepage":"http://kubernetes.io","size":525845,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c778d871e0336bef0f4be39a754897f3611b193d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-19T19:31:09Z","pushed_at":"2018-04-19T19:27:20Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":771516,"stargazers_count":35274,"watchers_count":35274,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12481,"mirror_url":null,"archived":false,"open_issues_count":3460,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12481,"open_issues":3460,"watchers":35274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62874"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62874"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62874/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62874/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/6dddcd9722ab0b459823212f02f3232f2901ca37"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"dcbw"}}