{"action":"opened","number":43,"pull_request":{"url":"https://api.github.com/repos/pynbody/tangos/pulls/43","id":178334969,"html_url":"https://github.com/pynbody/tangos/pull/43","diff_url":"https://github.com/pynbody/tangos/pull/43.diff","patch_url":"https://github.com/pynbody/tangos/pull/43.patch","issue_url":"https://api.github.com/repos/pynbody/tangos/issues/43","number":43,"state":"open","locked":false,"title":"Rollbacking something that does not exist","user":{"login":"Martin-Rey","id":22526234,"avatar_url":"https://avatars0.githubusercontent.com/u/22526234?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Rey","html_url":"https://github.com/Martin-Rey","followers_url":"https://api.github.com/users/Martin-Rey/followers","following_url":"https://api.github.com/users/Martin-Rey/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Rey/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Rey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Rey/subscriptions","organizations_url":"https://api.github.com/users/Martin-Rey/orgs","repos_url":"https://api.github.com/users/Martin-Rey/repos","events_url":"https://api.github.com/users/Martin-Rey/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Rey/received_events","type":"User","site_admin":false},"body":"This is a one line change that raises a more meaningful error message if trying to rollback a calculation that does not exist.\r\n\r\nPreviously you would get\r\n```\r\nTraceback (most recent call last):\r\n  File \"/Users/mrey/anaconda3/bin/tangos\", line 11, in <module>\r\n    load_entry_point('tangos', 'console_scripts', 'tangos')()\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/__init__.py\", line 49, in main\r\n    args.func(args)\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/manager.py\", line 320, in rollback\r\n    rem_run(run_id, not options.force)\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/manager.py\", line 295, in rem_run\r\n    run.print_info()\r\nAttributeError: 'NoneType' object has no attribute 'print_info'\r\n```\r\n\r\nNow \r\n```\r\nTraceback (most recent call last):\r\n  File \"/Users/mrey/anaconda3/bin/tangos\", line 11, in <module>\r\n    load_entry_point('tangos', 'console_scripts', 'tangos')()\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/__init__.py\", line 49, in main\r\n    args.func(args)\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/manager.py\", line 324, in rollback\r\n    rem_run(run_id, not options.force)\r\n  File \"/Users/mrey/Documents/tangos/tangos/scripts/manager.py\", line 296, in rem_run\r\n    raise ValueError(\" Run %i does not exist\" % id)\r\nValueError:  Run 4 does not exist\r\n```","created_at":"2018-03-29T13:51:36Z","updated_at":"2018-03-29T13:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pynbody/tangos/pulls/43/commits","review_comments_url":"https://api.github.com/repos/pynbody/tangos/pulls/43/comments","review_comment_url":"https://api.github.com/repos/pynbody/tangos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pynbody/tangos/issues/43/comments","statuses_url":"https://api.github.com/repos/pynbody/tangos/statuses/c050bf389098ffd12e1083d2c26ac74addfe4f29","head":{"label":"Martin-Rey:rollback","ref":"rollback","sha":"c050bf389098ffd12e1083d2c26ac74addfe4f29","user":{"login":"Martin-Rey","id":22526234,"avatar_url":"https://avatars0.githubusercontent.com/u/22526234?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Rey","html_url":"https://github.com/Martin-Rey","followers_url":"https://api.github.com/users/Martin-Rey/followers","following_url":"https://api.github.com/users/Martin-Rey/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Rey/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Rey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Rey/subscriptions","organizations_url":"https://api.github.com/users/Martin-Rey/orgs","repos_url":"https://api.github.com/users/Martin-Rey/repos","events_url":"https://api.github.com/users/Martin-Rey/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Rey/received_events","type":"User","site_admin":false},"repo":{"id":109735317,"name":"tangos","full_name":"Martin-Rey/tangos","owner":{"login":"Martin-Rey","id":22526234,"avatar_url":"https://avatars0.githubusercontent.com/u/22526234?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin-Rey","html_url":"https://github.com/Martin-Rey","followers_url":"https://api.github.com/users/Martin-Rey/followers","following_url":"https://api.github.com/users/Martin-Rey/following{/other_user}","gists_url":"https://api.github.com/users/Martin-Rey/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin-Rey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin-Rey/subscriptions","organizations_url":"https://api.github.com/users/Martin-Rey/orgs","repos_url":"https://api.github.com/users/Martin-Rey/repos","events_url":"https://api.github.com/users/Martin-Rey/events{/privacy}","received_events_url":"https://api.github.com/users/Martin-Rey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Martin-Rey/tangos","description":"The Amazing Numerical Galaxy Organisation System","fork":true,"url":"https://api.github.com/repos/Martin-Rey/tangos","forks_url":"https://api.github.com/repos/Martin-Rey/tangos/forks","keys_url":"https://api.github.com/repos/Martin-Rey/tangos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Martin-Rey/tangos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Martin-Rey/tangos/teams","hooks_url":"https://api.github.com/repos/Martin-Rey/tangos/hooks","issue_events_url":"https://api.github.com/repos/Martin-Rey/tangos/issues/events{/number}","events_url":"https://api.github.com/repos/Martin-Rey/tangos/events","assignees_url":"https://api.github.com/repos/Martin-Rey/tangos/assignees{/user}","branches_url":"https://api.github.com/repos/Martin-Rey/tangos/branches{/branch}","tags_url":"https://api.github.com/repos/Martin-Rey/tangos/tags","blobs_url":"https://api.github.com/repos/Martin-Rey/tangos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Martin-Rey/tangos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Martin-Rey/tangos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Martin-Rey/tangos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Martin-Rey/tangos/statuses/{sha}","languages_url":"https://api.github.com/repos/Martin-Rey/tangos/languages","stargazers_url":"https://api.github.com/repos/Martin-Rey/tangos/stargazers","contributors_url":"https://api.github.com/repos/Martin-Rey/tangos/contributors","subscribers_url":"https://api.github.com/repos/Martin-Rey/tangos/subscribers","subscription_url":"https://api.github.com/repos/Martin-Rey/tangos/subscription","commits_url":"https://api.github.com/repos/Martin-Rey/tangos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Martin-Rey/tangos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Martin-Rey/tangos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Martin-Rey/tangos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Martin-Rey/tangos/contents/{+path}","compare_url":"https://api.github.com/repos/Martin-Rey/tangos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Martin-Rey/tangos/merges","archive_url":"https://api.github.com/repos/Martin-Rey/tangos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Martin-Rey/tangos/downloads","issues_url":"https://api.github.com/repos/Martin-Rey/tangos/issues{/number}","pulls_url":"https://api.github.com/repos/Martin-Rey/tangos/pulls{/number}","milestones_url":"https://api.github.com/repos/Martin-Rey/tangos/milestones{/number}","notifications_url":"https://api.github.com/repos/Martin-Rey/tangos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Martin-Rey/tangos/labels{/name}","releases_url":"https://api.github.com/repos/Martin-Rey/tangos/releases{/id}","deployments_url":"https://api.github.com/repos/Martin-Rey/tangos/deployments","created_at":"2017-11-06T18:46:16Z","updated_at":"2018-03-29T13:29:01Z","pushed_at":"2018-03-29T13:31:33Z","git_url":"git://github.com/Martin-Rey/tangos.git","ssh_url":"git@github.com:Martin-Rey/tangos.git","clone_url":"https://github.com/Martin-Rey/tangos.git","svn_url":"https://github.com/Martin-Rey/tangos","homepage":null,"size":3075,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pynbody:master","ref":"master","sha":"811444efd5b06c080470e0672da59784fffc87e9","user":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars3.githubusercontent.com/u/4417908?v=4","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"repo":{"id":105990932,"name":"tangos","full_name":"pynbody/tangos","owner":{"login":"pynbody","id":4417908,"avatar_url":"https://avatars3.githubusercontent.com/u/4417908?v=4","gravatar_id":"","url":"https://api.github.com/users/pynbody","html_url":"https://github.com/pynbody","followers_url":"https://api.github.com/users/pynbody/followers","following_url":"https://api.github.com/users/pynbody/following{/other_user}","gists_url":"https://api.github.com/users/pynbody/gists{/gist_id}","starred_url":"https://api.github.com/users/pynbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pynbody/subscriptions","organizations_url":"https://api.github.com/users/pynbody/orgs","repos_url":"https://api.github.com/users/pynbody/repos","events_url":"https://api.github.com/users/pynbody/events{/privacy}","received_events_url":"https://api.github.com/users/pynbody/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pynbody/tangos","description":"The Agile Numerical Galaxy Organisation System","fork":false,"url":"https://api.github.com/repos/pynbody/tangos","forks_url":"https://api.github.com/repos/pynbody/tangos/forks","keys_url":"https://api.github.com/repos/pynbody/tangos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pynbody/tangos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pynbody/tangos/teams","hooks_url":"https://api.github.com/repos/pynbody/tangos/hooks","issue_events_url":"https://api.github.com/repos/pynbody/tangos/issues/events{/number}","events_url":"https://api.github.com/repos/pynbody/tangos/events","assignees_url":"https://api.github.com/repos/pynbody/tangos/assignees{/user}","branches_url":"https://api.github.com/repos/pynbody/tangos/branches{/branch}","tags_url":"https://api.github.com/repos/pynbody/tangos/tags","blobs_url":"https://api.github.com/repos/pynbody/tangos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pynbody/tangos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pynbody/tangos/git/refs{/sha}","trees_url":"https://api.github.com/repos/pynbody/tangos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pynbody/tangos/statuses/{sha}","languages_url":"https://api.github.com/repos/pynbody/tangos/languages","stargazers_url":"https://api.github.com/repos/pynbody/tangos/stargazers","contributors_url":"https://api.github.com/repos/pynbody/tangos/contributors","subscribers_url":"https://api.github.com/repos/pynbody/tangos/subscribers","subscription_url":"https://api.github.com/repos/pynbody/tangos/subscription","commits_url":"https://api.github.com/repos/pynbody/tangos/commits{/sha}","git_commits_url":"https://api.github.com/repos/pynbody/tangos/git/commits{/sha}","comments_url":"https://api.github.com/repos/pynbody/tangos/comments{/number}","issue_comment_url":"https://api.github.com/repos/pynbody/tangos/issues/comments{/number}","contents_url":"https://api.github.com/repos/pynbody/tangos/contents/{+path}","compare_url":"https://api.github.com/repos/pynbody/tangos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pynbody/tangos/merges","archive_url":"https://api.github.com/repos/pynbody/tangos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pynbody/tangos/downloads","issues_url":"https://api.github.com/repos/pynbody/tangos/issues{/number}","pulls_url":"https://api.github.com/repos/pynbody/tangos/pulls{/number}","milestones_url":"https://api.github.com/repos/pynbody/tangos/milestones{/number}","notifications_url":"https://api.github.com/repos/pynbody/tangos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pynbody/tangos/labels{/name}","releases_url":"https://api.github.com/repos/pynbody/tangos/releases{/id}","deployments_url":"https://api.github.com/repos/pynbody/tangos/deployments","created_at":"2017-10-06T10:07:07Z","updated_at":"2018-03-29T08:15:25Z","pushed_at":"2018-03-29T08:15:29Z","git_url":"git://github.com/pynbody/tangos.git","ssh_url":"git@github.com:pynbody/tangos.git","clone_url":"https://github.com/pynbody/tangos.git","svn_url":"https://github.com/pynbody/tangos","homepage":"","size":3070,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":2,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pynbody/tangos/pulls/43"},"html":{"href":"https://github.com/pynbody/tangos/pull/43"},"issue":{"href":"https://api.github.com/repos/pynbody/tangos/issues/43"},"comments":{"href":"https://api.github.com/repos/pynbody/tangos/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/pynbody/tangos/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/pynbody/tangos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pynbody/tangos/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/pynbody/tangos/statuses/c050bf389098ffd12e1083d2c26ac74addfe4f29"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"Martin-Rey"}}