{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/comments/172033247","pull_request_review_id":99182371,"id":172033247,"diff_hunk":"@@ -0,0 +1,121 @@\n+require 'minitest/pride'\n+require 'minitest/autorun'\n+require 'minitest/reporters'\n+require 'minitest/skip_dsl'\n+\n+require_relative '../lib/player'\n+\n+# Get that nice colorized output\n+Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new\n+\n+describe 'Player' do\n+  describe 'initialize' do\n+    it 'takes player name' do\n+      maja = Scrabble::Player.new(\"Maja\")\n+      maja.must_respond_to :name\n+      maja.name.must_be_kind_of String\n+\n+      maja.must_respond_to :won\n+      maja.won.must_equal false\n+    end\n+    it 'plays returns an array of words' do\n+      player = Scrabble::Player.new(\"maja\")\n+\n+      player.plays.must_be_instance_of Array\n+      player.plays.length.must_equal 0\n+    end\n+  end\n+\n+  describe 'play method' do\n+    it 'takes a word and add it to an array' do\n+      brenda = Scrabble::Player.new(\"Brenda\")\n+\n+      brenda.play(\"line\")\n+      brenda.play(\"fish\")\n+      brenda.play(\"knife\")\n+      brenda.play(\"cookie\")\n+\n+      brenda.plays.include? \"knife\"\n+    end\n+    it 'returns the score of a player' do\n+      john = Scrabble::Player.new(\"John\")\n+      john.play('cookie').must_equal 12\n+    end\n+    it 'returns false if player already won' do\n+      john = Scrabble::Player.new(\"John\")\n+      john.play(\"squeeze\")\n+      john.play(\"jukebox\")\n+\n+      john.won.must_equal false\n+    end\n+  end\n+\n+  describe 'total_score method' do\n+    it 'returns the total_score for a player' do\n+      sarah = Scrabble::Player.new(\"sarah\")\n+      sarah.play('cookie')\n+      sarah.play('key')\n+      sarah.play('fish')\n+      sarah.total_score.must_equal 32\n+    end\n+  end\n+\n+  describe 'highest_scoring word' do\n+    it 'returns the highest scoring word' do\n+      sarah = Scrabble::Player.new(\"sarah\")\n+      sarah.play('cookie')\n+      sarah.play('cake')\n+      sarah.play('alcohol')\n+      sarah.highest_scoring_word.must_equal 'alcohol'\n+    end\n+\n+    it 'returns a string' do\n+      sarah = Scrabble::Player.new(\"sarah\")\n+      sarah.play('cookie')\n+      sarah.play('cake')\n+      sarah.play('alcohol')\n+      sarah.highest_scoring_word.must_be_instance_of String\n+    end\n+  end\n+\n+  describe 'highest_word_score' do\n+    it 'returns the highest scoring word score' do\n+      sarah = Scrabble::Player.new(\"sarah\")\n+      sarah.play('cookie')\n+      sarah.play('cake')\n+      sarah.play('alcohol')\n+\n+      sarah.highest_word_score.must_equal 62\n+    end\n+  end\n+\n+  describe 'won method' do\n+    it 'returns true if score is > 100' do\n+      john = Scrabble::Player.new(\"John\")\n+      john.play(\"squeeze\")","path":"specs/player_spec.rb","position":95,"original_position":95,"commit_id":"92ed4c6e41c190e0cff5b4c9a72c24d80fd48965","original_commit_id":"92ed4c6e41c190e0cff5b4c9a72c24d80fd48965","user":{"login":"droberts-ada","id":21064499,"avatar_url":"https://avatars1.githubusercontent.com/u/21064499?v=4","gravatar_id":"","url":"https://api.github.com/users/droberts-ada","html_url":"https://github.com/droberts-ada","followers_url":"https://api.github.com/users/droberts-ada/followers","following_url":"https://api.github.com/users/droberts-ada/following{/other_user}","gists_url":"https://api.github.com/users/droberts-ada/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts-ada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts-ada/subscriptions","organizations_url":"https://api.github.com/users/droberts-ada/orgs","repos_url":"https://api.github.com/users/droberts-ada/repos","events_url":"https://api.github.com/users/droberts-ada/events{/privacy}","received_events_url":"https://api.github.com/users/droberts-ada/received_events","type":"User","site_admin":false},"body":"I would like to see more precision around the \"edge\" between winning and not winning. What happens if the player has:\r\n\r\n- 99 points\r\n- 100 points\r\n- 101 points","created_at":"2018-03-04T00:35:32Z","updated_at":"2018-03-04T00:41:29Z","html_url":"https://github.com/Ada-C9/Scrabble/pull/16#discussion_r172033247","pull_request_url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/comments/172033247"},"html":{"href":"https://github.com/Ada-C9/Scrabble/pull/16#discussion_r172033247"},"pull_request":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16","id":171155653,"html_url":"https://github.com/Ada-C9/Scrabble/pull/16","diff_url":"https://github.com/Ada-C9/Scrabble/pull/16.diff","patch_url":"https://github.com/Ada-C9/Scrabble/pull/16.patch","issue_url":"https://api.github.com/repos/Ada-C9/Scrabble/issues/16","number":16,"state":"open","locked":false,"title":"Octos Maja Brenda Scrabble","user":{"login":"mgraonic","id":11452799,"avatar_url":"https://avatars0.githubusercontent.com/u/11452799?v=4","gravatar_id":"","url":"https://api.github.com/users/mgraonic","html_url":"https://github.com/mgraonic","followers_url":"https://api.github.com/users/mgraonic/followers","following_url":"https://api.github.com/users/mgraonic/following{/other_user}","gists_url":"https://api.github.com/users/mgraonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mgraonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgraonic/subscriptions","organizations_url":"https://api.github.com/users/mgraonic/orgs","repos_url":"https://api.github.com/users/mgraonic/repos","events_url":"https://api.github.com/users/mgraonic/events{/privacy}","received_events_url":"https://api.github.com/users/mgraonic/received_events","type":"User","site_admin":false},"body":"# Scrabble\r\nCongratulations! You're submitting your assignment.\r\n\r\n## Comprehension Questions\r\n\r\nFeature | Feedback\r\n--- | ---\r\nWhat are the advantages of using git when collaboratively working on one code base? | By using git both persons can collaborate and work at the same time.\r\nWhy do you think we chose to make the `score` method in the `Scoring` class a **class method** instead of an **instance method**? | We made the Score method a Class method because it does not have to do anything with a particular instance so we didn't require an instance method.\r\nDescribe an example of a test you wrote for a _nominal case_. | When we tested a valid word and got the score for it.\r\nDescribe an example of a test you wrote for an _edge case_. | When we tested a letter of more than 7 letters.\r\nDoes your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful? | Yes, in the self.highest_score_from method in the file Scoring we used the method min to get break a tie when two letters get the same score so with min we were able to compare the words and choose the one with less letters.<br><br>Also, we used the delete_if method in the draw_tiles method in the Tilebag file to delete the letter if its quantity was 0. They were very useful to complete and meet the requirements.\r\nWhat was one method you and your pair used to debug code? | We used several times the pry gem to find out the problem and debug. We also debugged by hardcoding values to better see where things were going wrong.\r\nIs there a specific piece of code you'd like feedback on? | The self.highest_score_from method. Are there places where we could have used fewer extra data structures? Or made the code shorter?\r\nWhat are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? | About how useful is to talk to each other about our ideas, and that thinking out loud can also be very useful.\r\n","created_at":"2018-02-24T02:23:21Z","updated_at":"2018-03-04T00:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16/commits","review_comments_url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16/comments","review_comment_url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C9/Scrabble/issues/16/comments","statuses_url":"https://api.github.com/repos/Ada-C9/Scrabble/statuses/92ed4c6e41c190e0cff5b4c9a72c24d80fd48965","head":{"label":"mgraonic:master","ref":"master","sha":"92ed4c6e41c190e0cff5b4c9a72c24d80fd48965","user":{"login":"mgraonic","id":11452799,"avatar_url":"https://avatars0.githubusercontent.com/u/11452799?v=4","gravatar_id":"","url":"https://api.github.com/users/mgraonic","html_url":"https://github.com/mgraonic","followers_url":"https://api.github.com/users/mgraonic/followers","following_url":"https://api.github.com/users/mgraonic/following{/other_user}","gists_url":"https://api.github.com/users/mgraonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mgraonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgraonic/subscriptions","organizations_url":"https://api.github.com/users/mgraonic/orgs","repos_url":"https://api.github.com/users/mgraonic/repos","events_url":"https://api.github.com/users/mgraonic/events{/privacy}","received_events_url":"https://api.github.com/users/mgraonic/received_events","type":"User","site_admin":false},"repo":{"id":122263155,"name":"Scrabble","full_name":"mgraonic/Scrabble","owner":{"login":"mgraonic","id":11452799,"avatar_url":"https://avatars0.githubusercontent.com/u/11452799?v=4","gravatar_id":"","url":"https://api.github.com/users/mgraonic","html_url":"https://github.com/mgraonic","followers_url":"https://api.github.com/users/mgraonic/followers","following_url":"https://api.github.com/users/mgraonic/following{/other_user}","gists_url":"https://api.github.com/users/mgraonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mgraonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgraonic/subscriptions","organizations_url":"https://api.github.com/users/mgraonic/orgs","repos_url":"https://api.github.com/users/mgraonic/repos","events_url":"https://api.github.com/users/mgraonic/events{/privacy}","received_events_url":"https://api.github.com/users/mgraonic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgraonic/Scrabble","description":"A ruby implementation of the game Scrabble","fork":true,"url":"https://api.github.com/repos/mgraonic/Scrabble","forks_url":"https://api.github.com/repos/mgraonic/Scrabble/forks","keys_url":"https://api.github.com/repos/mgraonic/Scrabble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgraonic/Scrabble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgraonic/Scrabble/teams","hooks_url":"https://api.github.com/repos/mgraonic/Scrabble/hooks","issue_events_url":"https://api.github.com/repos/mgraonic/Scrabble/issues/events{/number}","events_url":"https://api.github.com/repos/mgraonic/Scrabble/events","assignees_url":"https://api.github.com/repos/mgraonic/Scrabble/assignees{/user}","branches_url":"https://api.github.com/repos/mgraonic/Scrabble/branches{/branch}","tags_url":"https://api.github.com/repos/mgraonic/Scrabble/tags","blobs_url":"https://api.github.com/repos/mgraonic/Scrabble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgraonic/Scrabble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgraonic/Scrabble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgraonic/Scrabble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgraonic/Scrabble/statuses/{sha}","languages_url":"https://api.github.com/repos/mgraonic/Scrabble/languages","stargazers_url":"https://api.github.com/repos/mgraonic/Scrabble/stargazers","contributors_url":"https://api.github.com/repos/mgraonic/Scrabble/contributors","subscribers_url":"https://api.github.com/repos/mgraonic/Scrabble/subscribers","subscription_url":"https://api.github.com/repos/mgraonic/Scrabble/subscription","commits_url":"https://api.github.com/repos/mgraonic/Scrabble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgraonic/Scrabble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgraonic/Scrabble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgraonic/Scrabble/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgraonic/Scrabble/contents/{+path}","compare_url":"https://api.github.com/repos/mgraonic/Scrabble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgraonic/Scrabble/merges","archive_url":"https://api.github.com/repos/mgraonic/Scrabble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgraonic/Scrabble/downloads","issues_url":"https://api.github.com/repos/mgraonic/Scrabble/issues{/number}","pulls_url":"https://api.github.com/repos/mgraonic/Scrabble/pulls{/number}","milestones_url":"https://api.github.com/repos/mgraonic/Scrabble/milestones{/number}","notifications_url":"https://api.github.com/repos/mgraonic/Scrabble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgraonic/Scrabble/labels{/name}","releases_url":"https://api.github.com/repos/mgraonic/Scrabble/releases{/id}","deployments_url":"https://api.github.com/repos/mgraonic/Scrabble/deployments","created_at":"2018-02-20T22:13:53Z","updated_at":"2018-02-20T22:13:55Z","pushed_at":"2018-02-24T00:06:21Z","git_url":"git://github.com/mgraonic/Scrabble.git","ssh_url":"git@github.com:mgraonic/Scrabble.git","clone_url":"https://github.com/mgraonic/Scrabble.git","svn_url":"https://github.com/mgraonic/Scrabble","homepage":"","size":55,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C9:master","ref":"master","sha":"b41d1cd56709f4768f05a6ed45598107155f49bb","user":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"repo":{"id":122153348,"name":"Scrabble","full_name":"Ada-C9/Scrabble","owner":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C9/Scrabble","description":"A ruby implementation of the game Scrabble","fork":true,"url":"https://api.github.com/repos/Ada-C9/Scrabble","forks_url":"https://api.github.com/repos/Ada-C9/Scrabble/forks","keys_url":"https://api.github.com/repos/Ada-C9/Scrabble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C9/Scrabble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C9/Scrabble/teams","hooks_url":"https://api.github.com/repos/Ada-C9/Scrabble/hooks","issue_events_url":"https://api.github.com/repos/Ada-C9/Scrabble/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C9/Scrabble/events","assignees_url":"https://api.github.com/repos/Ada-C9/Scrabble/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C9/Scrabble/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C9/Scrabble/tags","blobs_url":"https://api.github.com/repos/Ada-C9/Scrabble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C9/Scrabble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C9/Scrabble/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C9/Scrabble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C9/Scrabble/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C9/Scrabble/languages","stargazers_url":"https://api.github.com/repos/Ada-C9/Scrabble/stargazers","contributors_url":"https://api.github.com/repos/Ada-C9/Scrabble/contributors","subscribers_url":"https://api.github.com/repos/Ada-C9/Scrabble/subscribers","subscription_url":"https://api.github.com/repos/Ada-C9/Scrabble/subscription","commits_url":"https://api.github.com/repos/Ada-C9/Scrabble/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C9/Scrabble/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C9/Scrabble/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C9/Scrabble/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C9/Scrabble/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C9/Scrabble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C9/Scrabble/merges","archive_url":"https://api.github.com/repos/Ada-C9/Scrabble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C9/Scrabble/downloads","issues_url":"https://api.github.com/repos/Ada-C9/Scrabble/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C9/Scrabble/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C9/Scrabble/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C9/Scrabble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C9/Scrabble/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C9/Scrabble/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C9/Scrabble/deployments","created_at":"2018-02-20T04:02:27Z","updated_at":"2018-02-20T04:02:29Z","pushed_at":"2018-02-27T21:23:31Z","git_url":"git://github.com/Ada-C9/Scrabble.git","ssh_url":"git@github.com:Ada-C9/Scrabble.git","clone_url":"https://github.com/Ada-C9/Scrabble.git","svn_url":"https://github.com/Ada-C9/Scrabble","homepage":"","size":42,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":29,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16"},"html":{"href":"https://github.com/Ada-C9/Scrabble/pull/16"},"issue":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/issues/16"},"comments":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C9/Scrabble/statuses/92ed4c6e41c190e0cff5b4c9a72c24d80fd48965"}},"author_association":"NONE"}}
{"actor":{"display_login":"droberts-ada"}}