{"action":"created","issue":{"url":"https://api.github.com/repos/jasarien/Provenance/issues/667","repository_url":"https://api.github.com/repos/jasarien/Provenance","labels_url":"https://api.github.com/repos/jasarien/Provenance/issues/667/labels{/name}","comments_url":"https://api.github.com/repos/jasarien/Provenance/issues/667/comments","events_url":"https://api.github.com/repos/jasarien/Provenance/issues/667/events","html_url":"https://github.com/jasarien/Provenance/pull/667","id":291062660,"number":667,"title":"Mednafen improvements","user":{"login":"braindx","id":2925848,"avatar_url":"https://avatars2.githubusercontent.com/u/2925848?v=4","gravatar_id":"","url":"https://api.github.com/users/braindx","html_url":"https://github.com/braindx","followers_url":"https://api.github.com/users/braindx/followers","following_url":"https://api.github.com/users/braindx/following{/other_user}","gists_url":"https://api.github.com/users/braindx/gists{/gist_id}","starred_url":"https://api.github.com/users/braindx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braindx/subscriptions","organizations_url":"https://api.github.com/users/braindx/orgs","repos_url":"https://api.github.com/users/braindx/repos","events_url":"https://api.github.com/users/braindx/events{/privacy}","received_events_url":"https://api.github.com/users/braindx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-01-24T02:25:21Z","updated_at":"2018-02-01T13:18:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jasarien/Provenance/pulls/667","html_url":"https://github.com/jasarien/Provenance/pull/667","diff_url":"https://github.com/jasarien/Provenance/pull/667.diff","patch_url":"https://github.com/jasarien/Provenance/pull/667.patch"},"body":"Posting this PR for consideration as discussed in #566 \r\n\r\nRenderer will now function correctly when an emulator core does not write its final image to the top-left of the frame buffer, as is the case with PSX in Mednafen. As a result, I've removed the \"wideScreen\" flag as I believe that was hack to try and correct this behavior.\r\n\r\nCores can now implement double buffering and return YES from isDoubleBuffered to have the renderer take advantage of that fact and render in parallel to the emulation when needed. Mednafen now has double buffering implemented.\r\n\r\nReplaced the mednafenCoreTiming hack with a call to setGameSpeed each frame as this will ensure that gameInterval stays in sync and it seems to fix various speed issues I was getting with PSX emulation.\r\n\r\nAdded some NULL checks to fix crashes I ran into in cases where a Mednafen ROM failed to load."},"comment":{"url":"https://api.github.com/repos/jasarien/Provenance/issues/comments/362263086","html_url":"https://github.com/jasarien/Provenance/pull/667#issuecomment-362263086","issue_url":"https://api.github.com/repos/jasarien/Provenance/issues/667","id":362263086,"user":{"login":"JoeMatt","id":399864,"avatar_url":"https://avatars2.githubusercontent.com/u/399864?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeMatt","html_url":"https://github.com/JoeMatt","followers_url":"https://api.github.com/users/JoeMatt/followers","following_url":"https://api.github.com/users/JoeMatt/following{/other_user}","gists_url":"https://api.github.com/users/JoeMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeMatt/subscriptions","organizations_url":"https://api.github.com/users/JoeMatt/orgs","repos_url":"https://api.github.com/users/JoeMatt/repos","events_url":"https://api.github.com/users/JoeMatt/events{/privacy}","received_events_url":"https://api.github.com/users/JoeMatt/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T13:18:08Z","updated_at":"2018-02-01T13:18:08Z","author_association":"COLLABORATOR","body":"it'll load in the simulator. It used to load on device too but I noticed at some point that broke. DYLD used to be completely forbidden in iOS but when they added framework support (iOS 7?) it was added, but only for signed code. Off the top of my head, I'm going to assume maybe the framework isn't getting signed so that's why device won't load it but sim will, since sim doesn't check code signing. I could be completely off base here, but it kind of makes sense to me in my head without actually looking at it."}}
{"actor":{"display_login":"JoeMatt"}}