{"action":"created","issue":{"url":"https://api.github.com/repos/CompFUSE/DCA/issues/29","repository_url":"https://api.github.com/repos/CompFUSE/DCA","labels_url":"https://api.github.com/repos/CompFUSE/DCA/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/CompFUSE/DCA/issues/29/comments","events_url":"https://api.github.com/repos/CompFUSE/DCA/issues/29/events","html_url":"https://github.com/CompFUSE/DCA/issues/29","id":358640894,"node_id":"MDU6SXNzdWUzNTg2NDA4OTQ=","number":29,"title":"Improper use of CACHE vars in DCA CMake","user":{"login":"biddisco","id":941548,"node_id":"MDQ6VXNlcjk0MTU0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/941548?v=4","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-10T14:09:32Z","updated_at":"2018-09-10T20:45:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In many places (see here for example https://github.com/CompFUSE/DCA/blob/12c6c1279139994e8eb1656806f4fbb235f49296/cmake/dca_cuda.cmake#L10-L12 ) vars are set and made CACHE vars. This is annoying because if you compile WITH cuda, then change the option later to turn it off, the variable is not set (CACHE vars are not ovewritten unless FORCE is used), so you have to manaully edit the cache, or wipe it.\r\nExample\r\ncmake -DDCA_WITH_CUDA=ON blah blah\r\nbuild and test ok\r\ncmake -DDCA_WITH_CUDA=OFF blah blah\r\n```\r\nCMake Error at src/linalg/blas/CMakeLists.txt:4 (CUDA_ADD_LIBRARY):\r\n  Unknown CMake command \"CUDA_ADD_LIBRARY\".\r\n```\r\ncuda is still on even though you asked for it off. \r\nSame with MPI, and all the other vars that are CACHE when they should not be.\r\n"},"comment":{"url":"https://api.github.com/repos/CompFUSE/DCA/issues/comments/420054822","html_url":"https://github.com/CompFUSE/DCA/issues/29#issuecomment-420054822","issue_url":"https://api.github.com/repos/CompFUSE/DCA/issues/29","id":420054822,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDA1NDgyMg==","user":{"login":"PDoakORNL","id":11856692,"node_id":"MDQ6VXNlcjExODU2Njky","avatar_url":"https://avatars1.githubusercontent.com/u/11856692?v=4","gravatar_id":"","url":"https://api.github.com/users/PDoakORNL","html_url":"https://github.com/PDoakORNL","followers_url":"https://api.github.com/users/PDoakORNL/followers","following_url":"https://api.github.com/users/PDoakORNL/following{/other_user}","gists_url":"https://api.github.com/users/PDoakORNL/gists{/gist_id}","starred_url":"https://api.github.com/users/PDoakORNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PDoakORNL/subscriptions","organizations_url":"https://api.github.com/users/PDoakORNL/orgs","repos_url":"https://api.github.com/users/PDoakORNL/repos","events_url":"https://api.github.com/users/PDoakORNL/events{/privacy}","received_events_url":"https://api.github.com/users/PDoakORNL/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T20:45:55Z","updated_at":"2018-09-10T20:45:55Z","author_association":"CONTRIBUTOR","body":"So I noticed this was the \"style\" when I started working on this cmake and I admit to propograting it further. So when I reconfigure I've taken to either wiping the build directory or making a new one. Do we have any legitimate reason for it other than not wanting to deal with people thinking the build is broken when it gets in a strange state from being reconfigured?"}}
{"actor":{"display_login":"PDoakORNL"}}