{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/237042074","pull_request_review_id":179244034,"id":237042074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA0MjA3NA==","diff_hunk":"@@ -1059,11 +1045,7 @@ void CommandLineInterface::handleAst(string const& _argStr)\n \t\t\t\tsout() << endl << \"======= \" << sourceCode.first << \" =======\" << endl;\n \t\t\t\tif (_argStr == g_argAst)\n \t\t\t\t{\n-\t\t\t\t\tASTPrinter printer(\n-\t\t\t\t\t\tm_compiler->ast(sourceCode.first),\n-\t\t\t\t\t\tsourceCode.second,\n-\t\t\t\t\t\tgasCosts","path":"solc/CommandLineInterface.cpp","position":28,"original_position":28,"commit_id":"62c86fca015b88952f4b019307f07a1e6a581e3e","original_commit_id":"62c86fca015b88952f4b019307f07a1e6a581e3e","user":{"login":"chriseth","id":9073706,"node_id":"MDQ6VXNlcjkwNzM3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Please also change `ASTPrinter` to remove the gas costs altogether.","created_at":"2018-11-28T11:21:43Z","updated_at":"2018-11-28T11:21:44Z","html_url":"https://github.com/ethereum/solidity/pull/5515#discussion_r237042074","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/5515","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/237042074"},"html":{"href":"https://github.com/ethereum/solidity/pull/5515#discussion_r237042074"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5515"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/5515","id":233873389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODczMzg5","html_url":"https://github.com/ethereum/solidity/pull/5515","diff_url":"https://github.com/ethereum/solidity/pull/5515.diff","patch_url":"https://github.com/ethereum/solidity/pull/5515.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/5515","number":5515,"state":"open","locked":false,"title":"Removes gas estimation from AST output","user":{"login":"bit-shift","id":20012009,"node_id":"MDQ6VXNlcjIwMDEyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/20012009?v=4","gravatar_id":"","url":"https://api.github.com/users/bit-shift","html_url":"https://github.com/bit-shift","followers_url":"https://api.github.com/users/bit-shift/followers","following_url":"https://api.github.com/users/bit-shift/following{/other_user}","gists_url":"https://api.github.com/users/bit-shift/gists{/gist_id}","starred_url":"https://api.github.com/users/bit-shift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bit-shift/subscriptions","organizations_url":"https://api.github.com/users/bit-shift/orgs","repos_url":"https://api.github.com/users/bit-shift/repos","events_url":"https://api.github.com/users/bit-shift/events{/privacy}","received_events_url":"https://api.github.com/users/bit-shift/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/ethereum/solidity/issues/5501\r\n\r\nThe Heisenbug (https://github.com/ethereum/solidity/issues/3718 was re-introduced by https://github.com/ethereum/solidity/pull/5225. After a quick discussion with @chriseth, it turned out that removing the gas estimation output completely seems to be a good option, since it is (most likely) not used by anyone and would fix (hide) the Heisenbug once and for all :) \r\n","created_at":"2018-11-27T11:22:31Z","updated_at":"2018-11-28T11:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d1ca0b073de28ee2aaf78736cf9b9549620fe96","assignee":{"login":"bit-shift","id":20012009,"node_id":"MDQ6VXNlcjIwMDEyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/20012009?v=4","gravatar_id":"","url":"https://api.github.com/users/bit-shift","html_url":"https://github.com/bit-shift","followers_url":"https://api.github.com/users/bit-shift/followers","following_url":"https://api.github.com/users/bit-shift/following{/other_user}","gists_url":"https://api.github.com/users/bit-shift/gists{/gist_id}","starred_url":"https://api.github.com/users/bit-shift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bit-shift/subscriptions","organizations_url":"https://api.github.com/users/bit-shift/orgs","repos_url":"https://api.github.com/users/bit-shift/repos","events_url":"https://api.github.com/users/bit-shift/events{/privacy}","received_events_url":"https://api.github.com/users/bit-shift/received_events","type":"User","site_admin":false},"assignees":[{"login":"bit-shift","id":20012009,"node_id":"MDQ6VXNlcjIwMDEyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/20012009?v=4","gravatar_id":"","url":"https://api.github.com/users/bit-shift","html_url":"https://github.com/bit-shift","followers_url":"https://api.github.com/users/bit-shift/followers","following_url":"https://api.github.com/users/bit-shift/following{/other_user}","gists_url":"https://api.github.com/users/bit-shift/gists{/gist_id}","starred_url":"https://api.github.com/users/bit-shift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bit-shift/subscriptions","organizations_url":"https://api.github.com/users/bit-shift/orgs","repos_url":"https://api.github.com/users/bit-shift/repos","events_url":"https://api.github.com/users/bit-shift/events{/privacy}","received_events_url":"https://api.github.com/users/bit-shift/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/5515/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/5515/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/5515/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/62c86fca015b88952f4b019307f07a1e6a581e3e","head":{"label":"ethereum:remove-ast-gas","ref":"remove-ast-gas","sha":"62c86fca015b88952f4b019307f07a1e6a581e3e","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-11-28T10:33:42Z","pushed_at":"2018-11-28T11:19:37Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":24860,"stargazers_count":6368,"watchers_count":6368,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":638,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1722,"open_issues":638,"watchers":6368,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"5e55cb17299e1c8f9a685637703e9bd956cfc826","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-11-28T10:33:42Z","pushed_at":"2018-11-28T11:19:37Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":24860,"stargazers_count":6368,"watchers_count":6368,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":638,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1722,"open_issues":638,"watchers":6368,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5515"},"html":{"href":"https://github.com/ethereum/solidity/pull/5515"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/5515"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/5515/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5515/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5515/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/62c86fca015b88952f4b019307f07a1e6a581e3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chriseth"}}