{"action":"opened","number":7378,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7378","id":207919215,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTE5MjE1","html_url":"https://github.com/pingcap/tidb/pull/7378","diff_url":"https://github.com/pingcap/tidb/pull/7378.diff","patch_url":"https://github.com/pingcap/tidb/pull/7378.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7378","number":7378,"state":"open","locked":false,"title":"parser: support of character in create table statement","user":{"login":"imtbkcat","id":13135466,"node_id":"MDQ6VXNlcjEzMTM1NDY2","avatar_url":"https://avatars3.githubusercontent.com/u/13135466?v=4","gravatar_id":"","url":"https://api.github.com/users/imtbkcat","html_url":"https://github.com/imtbkcat","followers_url":"https://api.github.com/users/imtbkcat/followers","following_url":"https://api.github.com/users/imtbkcat/following{/other_user}","gists_url":"https://api.github.com/users/imtbkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/imtbkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtbkcat/subscriptions","organizations_url":"https://api.github.com/users/imtbkcat/orgs","repos_url":"https://api.github.com/users/imtbkcat/repos","events_url":"https://api.github.com/users/imtbkcat/events{/privacy}","received_events_url":"https://api.github.com/users/imtbkcat/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\nFix #7371 to make some JDBC test cases happy.\r\n\r\n### What is changed and how it works?\r\nSupport `NATIONAL CHARACTER` type in create table statement, like `create table t (c1 NATIONAL CHARACTER(10));` by add parser rules. Because `NATIONAL CHARACTER` is same as `NATIONAL CHAR`, just change parser is okay.\r\n\r\nReference link: https://dev.mysql.com/doc/refman/5.7/en/charset-national.html\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n\r\nCode changes\r\n\r\n - Has exported function/method change\r\n\r\nSide effects\r\nno\r\n\r\nRelated changes\r\nno","created_at":"2018-08-13T09:31:41Z","updated_at":"2018-08-13T09:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7378/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7378/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7378/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/0619e6135d4280b3bcec06984836e513e3b5e72f","head":{"label":"imtbkcat:fix7371","ref":"fix7371","sha":"0619e6135d4280b3bcec06984836e513e3b5e72f","user":{"login":"imtbkcat","id":13135466,"node_id":"MDQ6VXNlcjEzMTM1NDY2","avatar_url":"https://avatars3.githubusercontent.com/u/13135466?v=4","gravatar_id":"","url":"https://api.github.com/users/imtbkcat","html_url":"https://github.com/imtbkcat","followers_url":"https://api.github.com/users/imtbkcat/followers","following_url":"https://api.github.com/users/imtbkcat/following{/other_user}","gists_url":"https://api.github.com/users/imtbkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/imtbkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtbkcat/subscriptions","organizations_url":"https://api.github.com/users/imtbkcat/orgs","repos_url":"https://api.github.com/users/imtbkcat/repos","events_url":"https://api.github.com/users/imtbkcat/events{/privacy}","received_events_url":"https://api.github.com/users/imtbkcat/received_events","type":"User","site_admin":false},"repo":{"id":138816671,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4MTY2NzE=","name":"tidb","full_name":"imtbkcat/tidb","owner":{"login":"imtbkcat","id":13135466,"node_id":"MDQ6VXNlcjEzMTM1NDY2","avatar_url":"https://avatars3.githubusercontent.com/u/13135466?v=4","gravatar_id":"","url":"https://api.github.com/users/imtbkcat","html_url":"https://github.com/imtbkcat","followers_url":"https://api.github.com/users/imtbkcat/followers","following_url":"https://api.github.com/users/imtbkcat/following{/other_user}","gists_url":"https://api.github.com/users/imtbkcat/gists{/gist_id}","starred_url":"https://api.github.com/users/imtbkcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtbkcat/subscriptions","organizations_url":"https://api.github.com/users/imtbkcat/orgs","repos_url":"https://api.github.com/users/imtbkcat/repos","events_url":"https://api.github.com/users/imtbkcat/events{/privacy}","received_events_url":"https://api.github.com/users/imtbkcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imtbkcat/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":true,"url":"https://api.github.com/repos/imtbkcat/tidb","forks_url":"https://api.github.com/repos/imtbkcat/tidb/forks","keys_url":"https://api.github.com/repos/imtbkcat/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imtbkcat/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imtbkcat/tidb/teams","hooks_url":"https://api.github.com/repos/imtbkcat/tidb/hooks","issue_events_url":"https://api.github.com/repos/imtbkcat/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/imtbkcat/tidb/events","assignees_url":"https://api.github.com/repos/imtbkcat/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/imtbkcat/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/imtbkcat/tidb/tags","blobs_url":"https://api.github.com/repos/imtbkcat/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imtbkcat/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imtbkcat/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/imtbkcat/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imtbkcat/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/imtbkcat/tidb/languages","stargazers_url":"https://api.github.com/repos/imtbkcat/tidb/stargazers","contributors_url":"https://api.github.com/repos/imtbkcat/tidb/contributors","subscribers_url":"https://api.github.com/repos/imtbkcat/tidb/subscribers","subscription_url":"https://api.github.com/repos/imtbkcat/tidb/subscription","commits_url":"https://api.github.com/repos/imtbkcat/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/imtbkcat/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/imtbkcat/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/imtbkcat/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/imtbkcat/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/imtbkcat/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imtbkcat/tidb/merges","archive_url":"https://api.github.com/repos/imtbkcat/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imtbkcat/tidb/downloads","issues_url":"https://api.github.com/repos/imtbkcat/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/imtbkcat/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/imtbkcat/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/imtbkcat/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imtbkcat/tidb/labels{/name}","releases_url":"https://api.github.com/repos/imtbkcat/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/imtbkcat/tidb/deployments","created_at":"2018-06-27T02:02:23Z","updated_at":"2018-06-27T02:02:29Z","pushed_at":"2018-08-13T09:24:19Z","git_url":"git://github.com/imtbkcat/tidb.git","ssh_url":"git@github.com:imtbkcat/tidb.git","clone_url":"https://github.com/imtbkcat/tidb.git","svn_url":"https://github.com/imtbkcat/tidb","homepage":"https://pingcap.com","size":53910,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"87b16fca27d6d772af2f67f9da68ba12348753c8","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-08-13T09:18:37Z","pushed_at":"2018-08-13T09:30:20Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":79767,"stargazers_count":14363,"watchers_count":14363,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1991,"mirror_url":null,"archived":false,"open_issues_count":511,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1991,"open_issues":511,"watchers":14363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7378"},"html":{"href":"https://github.com/pingcap/tidb/pull/7378"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7378"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7378/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7378/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7378/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/0619e6135d4280b3bcec06984836e513e3b5e72f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"imtbkcat"}}