{"action":"closed","number":1455,"pull_request":{"url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455","id":236281569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjgxNTY5","html_url":"https://github.com/fossasia/pslab-android/pull/1455","diff_url":"https://github.com/fossasia/pslab-android/pull/1455.diff","patch_url":"https://github.com/fossasia/pslab-android/pull/1455.patch","issue_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1455","number":1455,"state":"closed","locked":false,"title":"fix: crash in Luxmeter when no data is saved","user":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"body":"Fixes #1452 \r\n\r\n**Changes**: \r\n- When there were no recorded data as user closes the app quickly, app crashed. It was fixed and a message is displayed\r\n\r\n**Screenshot/s for the changes**: \r\n> Not available\r\n\r\n**Checklist**: [Please tick following check boxes with `[x]` if the respective task is completed]\r\n- [x] I have used resources from `strings.xml`, `dimens.xml` and `colors.xml` without hard-coding them\r\n- [x] No modifications done at the end of resource files `strings.xml`, `dimens.xml` or `colors.xml`\r\n- [x] I have reformatted code in every file included in this PR [<kbd>CTRL</kbd>+<kbd>ALT</kbd>+<kbd>L</kbd>]\r\n- [x] My code does not contain any extra lines or extra spaces\r\n- [x] I have requested reviews from other members\r\n\r\n**APK for testing**: \r\n[LuxMeterFix.zip](https://github.com/fossasia/pslab-android/files/2650067/LuxMeterFix.zip)\r\n\r\n","created_at":"2018-12-05T18:42:30Z","updated_at":"2018-12-06T00:59:23Z","closed_at":"2018-12-06T00:59:23Z","merged_at":"2018-12-06T00:59:22Z","merge_commit_sha":"f1a091364f782b7738d8e0268a8cb6a9e44b2d55","assignee":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"assignees":[{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":945443198,"node_id":"MDU6TGFiZWw5NDU0NDMxOTg=","url":"https://api.github.com/repos/fossasia/pslab-android/labels/review-required","name":"review-required","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455/commits","review_comments_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455/comments","review_comment_url":"https://api.github.com/repos/fossasia/pslab-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/pslab-android/issues/1455/comments","statuses_url":"https://api.github.com/repos/fossasia/pslab-android/statuses/8902c60bf69f53c19401d30ee9e5d6441fffc404","head":{"label":"CloudyPadmal:LuxNav","ref":"LuxNav","sha":"8902c60bf69f53c19401d30ee9e5d6441fffc404","user":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"repo":{"id":90036880,"node_id":"MDEwOlJlcG9zaXRvcnk5MDAzNjg4MA==","name":"pslab-android","full_name":"CloudyPadmal/pslab-android","private":false,"owner":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CloudyPadmal/pslab-android","description":"PSLab Android App https://github.com/fossasia/pslab-android/raw/apk/app-debug.apk","fork":true,"url":"https://api.github.com/repos/CloudyPadmal/pslab-android","forks_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/forks","keys_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/teams","hooks_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/hooks","issue_events_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/issues/events{/number}","events_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/events","assignees_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/assignees{/user}","branches_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/branches{/branch}","tags_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/tags","blobs_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/languages","stargazers_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/stargazers","contributors_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/contributors","subscribers_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/subscribers","subscription_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/subscription","commits_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/contents/{+path}","compare_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/merges","archive_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/downloads","issues_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/issues{/number}","pulls_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/labels{/name}","releases_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/releases{/id}","deployments_url":"https://api.github.com/repos/CloudyPadmal/pslab-android/deployments","created_at":"2017-05-02T13:31:09Z","updated_at":"2018-11-22T00:20:13Z","pushed_at":"2018-12-05T18:36:40Z","git_url":"git://github.com/CloudyPadmal/pslab-android.git","ssh_url":"git@github.com:CloudyPadmal/pslab-android.git","clone_url":"https://github.com/CloudyPadmal/pslab-android.git","svn_url":"https://github.com/CloudyPadmal/pslab-android","homepage":"http://pslab.fossasia.org","size":11600,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"b6d9bc8959c04a2b6204940b76a905d7e16f8b89","user":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":86480252,"node_id":"MDEwOlJlcG9zaXRvcnk4NjQ4MDI1Mg==","name":"pslab-android","full_name":"fossasia/pslab-android","private":false,"owner":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fossasia/pslab-android","description":"PSLab Android App https://github.com/fossasia/pslab-android/blob/apk/app-master-release.apk","fork":false,"url":"https://api.github.com/repos/fossasia/pslab-android","forks_url":"https://api.github.com/repos/fossasia/pslab-android/forks","keys_url":"https://api.github.com/repos/fossasia/pslab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/pslab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/pslab-android/teams","hooks_url":"https://api.github.com/repos/fossasia/pslab-android/hooks","issue_events_url":"https://api.github.com/repos/fossasia/pslab-android/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/pslab-android/events","assignees_url":"https://api.github.com/repos/fossasia/pslab-android/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/pslab-android/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/pslab-android/tags","blobs_url":"https://api.github.com/repos/fossasia/pslab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/pslab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/pslab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/pslab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/pslab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/pslab-android/languages","stargazers_url":"https://api.github.com/repos/fossasia/pslab-android/stargazers","contributors_url":"https://api.github.com/repos/fossasia/pslab-android/contributors","subscribers_url":"https://api.github.com/repos/fossasia/pslab-android/subscribers","subscription_url":"https://api.github.com/repos/fossasia/pslab-android/subscription","commits_url":"https://api.github.com/repos/fossasia/pslab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/pslab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/pslab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/pslab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/pslab-android/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/pslab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/pslab-android/merges","archive_url":"https://api.github.com/repos/fossasia/pslab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/pslab-android/downloads","issues_url":"https://api.github.com/repos/fossasia/pslab-android/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/pslab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/pslab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/pslab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/pslab-android/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/pslab-android/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/pslab-android/deployments","created_at":"2017-03-28T16:03:15Z","updated_at":"2018-12-05T14:10:14Z","pushed_at":"2018-12-06T00:59:22Z","git_url":"git://github.com/fossasia/pslab-android.git","ssh_url":"git@github.com:fossasia/pslab-android.git","clone_url":"https://github.com/fossasia/pslab-android.git","svn_url":"https://github.com/fossasia/pslab-android","homepage":"https://pslab.io","size":522075,"stargazers_count":938,"watchers_count":938,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":264,"open_issues":39,"watchers":938,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455"},"html":{"href":"https://github.com/fossasia/pslab-android/pull/1455"},"issue":{"href":"https://api.github.com/repos/fossasia/pslab-android/issues/1455"},"comments":{"href":"https://api.github.com/repos/fossasia/pslab-android/issues/1455/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/pslab-android/pulls/1455/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/pslab-android/statuses/8902c60bf69f53c19401d30ee9e5d6441fffc404"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CloudyPadmal","id":14261304,"node_id":"MDQ6VXNlcjE0MjYxMzA0","avatar_url":"https://avatars1.githubusercontent.com/u/14261304?v=4","gravatar_id":"","url":"https://api.github.com/users/CloudyPadmal","html_url":"https://github.com/CloudyPadmal","followers_url":"https://api.github.com/users/CloudyPadmal/followers","following_url":"https://api.github.com/users/CloudyPadmal/following{/other_user}","gists_url":"https://api.github.com/users/CloudyPadmal/gists{/gist_id}","starred_url":"https://api.github.com/users/CloudyPadmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloudyPadmal/subscriptions","organizations_url":"https://api.github.com/users/CloudyPadmal/orgs","repos_url":"https://api.github.com/users/CloudyPadmal/repos","events_url":"https://api.github.com/users/CloudyPadmal/events{/privacy}","received_events_url":"https://api.github.com/users/CloudyPadmal/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"CloudyPadmal"}}