{"action":"opened","number":5959,"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5959","id":236912067,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTEyMDY3","html_url":"https://github.com/oppia/oppia/pull/5959","diff_url":"https://github.com/oppia/oppia/pull/5959.diff","patch_url":"https://github.com/oppia/oppia/pull/5959.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5959","number":5959,"state":"open","locked":false,"title":"Fix part of #5134, adding tests for core/storage/email/gae_models.py.","user":{"login":"CelineDknp","id":17687122,"node_id":"MDQ6VXNlcjE3Njg3MTIy","avatar_url":"https://avatars1.githubusercontent.com/u/17687122?v=4","gravatar_id":"","url":"https://api.github.com/users/CelineDknp","html_url":"https://github.com/CelineDknp","followers_url":"https://api.github.com/users/CelineDknp/followers","following_url":"https://api.github.com/users/CelineDknp/following{/other_user}","gists_url":"https://api.github.com/users/CelineDknp/gists{/gist_id}","starred_url":"https://api.github.com/users/CelineDknp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelineDknp/subscriptions","organizations_url":"https://api.github.com/users/CelineDknp/orgs","repos_url":"https://api.github.com/users/CelineDknp/repos","events_url":"https://api.github.com/users/CelineDknp/events{/privacy}","received_events_url":"https://api.github.com/users/CelineDknp/received_events","type":"User","site_admin":false},"body":"## Explanation\r\nThis PR fixes part of #5134, by writing tests for the file core/storage/email/gae_models.py. I did not attain full coverage because I could not find an idea to test the BulkEmailModel, and to make the unique id generators thows because of collision. If you have an idea, I'll be happy to implement it !\r\nSorry for the ridiculous amount of commits, I'm new with linters...\r\n\r\n## Checklist\r\n- [ ] The PR title starts with \"Fix #bugnum: \", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with \"Fix part of #bugnum: ...\".)\r\n- [X] The PR explanation includes the words \"Fixes #bugnum: ...\" (or \"Fixes part of #bugnum\" if the PR only partially fixes an issue).\r\n- [X] The linter/Karma presubmit checks have passed.\r\n  - These should run automatically, but if not, you can manually trigger them locally using `python scripts/pre_commit_linter.py` and `bash scripts/run_frontend_tests.sh`.\r\n- [X] The PR is made from a branch that's **not** called \"develop\".\r\n- [X] The PR follows the [style guide](https://github.com/oppia/oppia/wiki/Coding-style-guide).\r\n- [ ] The PR is assigned to an appropriate reviewer. -> Asking on the chat\r\n","created_at":"2018-12-07T15:53:45Z","updated_at":"2018-12-07T15:53:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5959/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5959/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5959/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/45f064d83a421e2521ae78a319f099722b301d74","head":{"label":"CelineDknp:test_gae_models","ref":"test_gae_models","sha":"45f064d83a421e2521ae78a319f099722b301d74","user":{"login":"CelineDknp","id":17687122,"node_id":"MDQ6VXNlcjE3Njg3MTIy","avatar_url":"https://avatars1.githubusercontent.com/u/17687122?v=4","gravatar_id":"","url":"https://api.github.com/users/CelineDknp","html_url":"https://github.com/CelineDknp","followers_url":"https://api.github.com/users/CelineDknp/followers","following_url":"https://api.github.com/users/CelineDknp/following{/other_user}","gists_url":"https://api.github.com/users/CelineDknp/gists{/gist_id}","starred_url":"https://api.github.com/users/CelineDknp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelineDknp/subscriptions","organizations_url":"https://api.github.com/users/CelineDknp/orgs","repos_url":"https://api.github.com/users/CelineDknp/repos","events_url":"https://api.github.com/users/CelineDknp/events{/privacy}","received_events_url":"https://api.github.com/users/CelineDknp/received_events","type":"User","site_admin":false},"repo":{"id":155342956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNDI5NTY=","name":"oppia","full_name":"CelineDknp/oppia","private":false,"owner":{"login":"CelineDknp","id":17687122,"node_id":"MDQ6VXNlcjE3Njg3MTIy","avatar_url":"https://avatars1.githubusercontent.com/u/17687122?v=4","gravatar_id":"","url":"https://api.github.com/users/CelineDknp","html_url":"https://github.com/CelineDknp","followers_url":"https://api.github.com/users/CelineDknp/followers","following_url":"https://api.github.com/users/CelineDknp/following{/other_user}","gists_url":"https://api.github.com/users/CelineDknp/gists{/gist_id}","starred_url":"https://api.github.com/users/CelineDknp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelineDknp/subscriptions","organizations_url":"https://api.github.com/users/CelineDknp/orgs","repos_url":"https://api.github.com/users/CelineDknp/repos","events_url":"https://api.github.com/users/CelineDknp/events{/privacy}","received_events_url":"https://api.github.com/users/CelineDknp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CelineDknp/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/CelineDknp/oppia","forks_url":"https://api.github.com/repos/CelineDknp/oppia/forks","keys_url":"https://api.github.com/repos/CelineDknp/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CelineDknp/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CelineDknp/oppia/teams","hooks_url":"https://api.github.com/repos/CelineDknp/oppia/hooks","issue_events_url":"https://api.github.com/repos/CelineDknp/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/CelineDknp/oppia/events","assignees_url":"https://api.github.com/repos/CelineDknp/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/CelineDknp/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/CelineDknp/oppia/tags","blobs_url":"https://api.github.com/repos/CelineDknp/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CelineDknp/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CelineDknp/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CelineDknp/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CelineDknp/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/CelineDknp/oppia/languages","stargazers_url":"https://api.github.com/repos/CelineDknp/oppia/stargazers","contributors_url":"https://api.github.com/repos/CelineDknp/oppia/contributors","subscribers_url":"https://api.github.com/repos/CelineDknp/oppia/subscribers","subscription_url":"https://api.github.com/repos/CelineDknp/oppia/subscription","commits_url":"https://api.github.com/repos/CelineDknp/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CelineDknp/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CelineDknp/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CelineDknp/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CelineDknp/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/CelineDknp/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CelineDknp/oppia/merges","archive_url":"https://api.github.com/repos/CelineDknp/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CelineDknp/oppia/downloads","issues_url":"https://api.github.com/repos/CelineDknp/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/CelineDknp/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/CelineDknp/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/CelineDknp/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CelineDknp/oppia/labels{/name}","releases_url":"https://api.github.com/repos/CelineDknp/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/CelineDknp/oppia/deployments","created_at":"2018-10-30T07:32:37Z","updated_at":"2018-10-30T07:32:45Z","pushed_at":"2018-12-07T15:44:48Z","git_url":"git://github.com/CelineDknp/oppia.git","ssh_url":"git@github.com:CelineDknp/oppia.git","clone_url":"https://github.com/CelineDknp/oppia.git","svn_url":"https://github.com/CelineDknp/oppia","homepage":"https://www.oppia.org","size":108274,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"7126b42bf105724cb82dd2d4df377e7a35c3ca18","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","private":false,"owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-12-07T12:50:04Z","pushed_at":"2018-12-07T15:28:29Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":108727,"stargazers_count":831,"watchers_count":831,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":407,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":819,"open_issues":407,"watchers":831,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5959"},"html":{"href":"https://github.com/oppia/oppia/pull/5959"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5959"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5959/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5959/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5959/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/45f064d83a421e2521ae78a319f099722b301d74"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":15,"additions":151,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"CelineDknp"}}