{"action":"created","comment":{"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments/169414769","pull_request_review_id":97937624,"id":169414769,"diff_hunk":"@@ -3,36 +3,112 @@ import PropTypes from 'prop-types';\n import classnames from 'classnames';\n import { Icon } from './../Icon';\n import { Button } from './../Button';\n+import './Pill.scss';\n+\n+const propTypes = {\n+  /**\n+   * Children will be used in place of the label, to allow customization\n+   */\n+  children: PropTypes.node,\n+  /**\n+   * ClassName to be added\n+   */\n+  className: PropTypes.string,\n+  /**\n+   * Icon to be added to the Pill, defined by category & icon\n+   */\n+  icon: PropTypes.shape({\n+    category: PropTypes.string,\n+    icon: PropTypes.string,\n+  }),\n+  /**\n+   * If the Pill is disabled, it will not allow the pill to be removed.\n+   */\n+  isDisabled: PropTypes.bool,\n+  /**\n+   * Should we truncate the string to fit within a fixed width pill?\n+   */\n+  isTruncated: PropTypes.bool,\n+  /**\n+   * Either define the label as a string, or use the children to customize it further\n+   */\n+  label: PropTypes.string,\n+  /**\n+   * Function to be called when the user clicks on the Pill itself.\n+   */\n+  onClick: PropTypes.func,\n+  /**\n+   * Function to be called when the user clicks on the Remove button.\n+   */\n+  onRemove: PropTypes.func,\n+  /**\n+   * Refrerence to the pill\n+   */\n+  pillRef: PropTypes.func,\n+  /**\n+   * Ability to override the tag of the pill, defaults to 'a'\n+   */\n+  tag: PropTypes.string,\n+};\n+\n+const defaultProps = {\n+  children: null,\n+  className: '',\n+  icon: null,\n+  isDisabled: false,\n+  isTruncated: false,\n+  label: '',\n+  onClick: null,\n+  onRemove: null,\n+  pillRef: null,\n+  tag: 'a',\n+};\n \n class Pill extends Component {\n-  onPillClick(e) {\n+  getTagName = () => {\n+    const tagName = this.props.isDisabled ? 'span' : this.props.tag;","path":"lib/components/Pill/Pill.js","position":68,"original_position":68,"commit_id":"12208f2db5b9bfb8c77b35f88226ef11c6514d31","original_commit_id":"12208f2db5b9bfb8c77b35f88226ef11c6514d31","user":{"login":"sheela-svmx","id":34457496,"avatar_url":"https://avatars1.githubusercontent.com/u/34457496?v=4","gravatar_id":"","url":"https://api.github.com/users/sheela-svmx","html_url":"https://github.com/sheela-svmx","followers_url":"https://api.github.com/users/sheela-svmx/followers","following_url":"https://api.github.com/users/sheela-svmx/following{/other_user}","gists_url":"https://api.github.com/users/sheela-svmx/gists{/gist_id}","starred_url":"https://api.github.com/users/sheela-svmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheela-svmx/subscriptions","organizations_url":"https://api.github.com/users/sheela-svmx/orgs","repos_url":"https://api.github.com/users/sheela-svmx/repos","events_url":"https://api.github.com/users/sheela-svmx/events{/privacy}","received_events_url":"https://api.github.com/users/sheela-svmx/received_events","type":"User","site_admin":false},"body":"should we just move all the props to the top ? \r\n```\r\nconst {tag, isDisabled, children, label, onclick } = this.props\r\n```","created_at":"2018-02-20T18:29:22Z","updated_at":"2018-02-20T18:29:22Z","html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34#discussion_r169414769","pull_request_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments/169414769"},"html":{"href":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34#discussion_r169414769"},"pull_request":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34","id":170270556,"html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34","diff_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34.diff","patch_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34.patch","issue_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/34","number":34,"state":"open","locked":false,"title":"UI-507 Pill component, stories ","user":{"login":"joshsylvester","id":30244294,"avatar_url":"https://avatars2.githubusercontent.com/u/30244294?v=4","gravatar_id":"","url":"https://api.github.com/users/joshsylvester","html_url":"https://github.com/joshsylvester","followers_url":"https://api.github.com/users/joshsylvester/followers","following_url":"https://api.github.com/users/joshsylvester/following{/other_user}","gists_url":"https://api.github.com/users/joshsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/joshsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshsylvester/subscriptions","organizations_url":"https://api.github.com/users/joshsylvester/orgs","repos_url":"https://api.github.com/users/joshsylvester/repos","events_url":"https://api.github.com/users/joshsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/joshsylvester/received_events","type":"User","site_admin":false},"body":"* Updated `Pill` component\r\n* Added `PillStories`\r\n* Re-ordered all stories to be alphabetized.","created_at":"2018-02-20T18:19:43Z","updated_at":"2018-02-20T18:29:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50020f8066f6fc2a852ae85c7f5fc5edd383e680","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mallik-svmx","id":34659014,"avatar_url":"https://avatars0.githubusercontent.com/u/34659014?v=4","gravatar_id":"","url":"https://api.github.com/users/mallik-svmx","html_url":"https://github.com/mallik-svmx","followers_url":"https://api.github.com/users/mallik-svmx/followers","following_url":"https://api.github.com/users/mallik-svmx/following{/other_user}","gists_url":"https://api.github.com/users/mallik-svmx/gists{/gist_id}","starred_url":"https://api.github.com/users/mallik-svmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mallik-svmx/subscriptions","organizations_url":"https://api.github.com/users/mallik-svmx/orgs","repos_url":"https://api.github.com/users/mallik-svmx/repos","events_url":"https://api.github.com/users/mallik-svmx/events{/privacy}","received_events_url":"https://api.github.com/users/mallik-svmx/received_events","type":"User","site_admin":false},{"login":"hanzge","id":35934070,"avatar_url":"https://avatars3.githubusercontent.com/u/35934070?v=4","gravatar_id":"","url":"https://api.github.com/users/hanzge","html_url":"https://github.com/hanzge","followers_url":"https://api.github.com/users/hanzge/followers","following_url":"https://api.github.com/users/hanzge/following{/other_user}","gists_url":"https://api.github.com/users/hanzge/gists{/gist_id}","starred_url":"https://api.github.com/users/hanzge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanzge/subscriptions","organizations_url":"https://api.github.com/users/hanzge/orgs","repos_url":"https://api.github.com/users/hanzge/repos","events_url":"https://api.github.com/users/hanzge/events{/privacy}","received_events_url":"https://api.github.com/users/hanzge/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/34/comments","statuses_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/12208f2db5b9bfb8c77b35f88226ef11c6514d31","head":{"label":"joshsylvester:UI-507","ref":"UI-507","sha":"12208f2db5b9bfb8c77b35f88226ef11c6514d31","user":{"login":"joshsylvester","id":30244294,"avatar_url":"https://avatars2.githubusercontent.com/u/30244294?v=4","gravatar_id":"","url":"https://api.github.com/users/joshsylvester","html_url":"https://github.com/joshsylvester","followers_url":"https://api.github.com/users/joshsylvester/followers","following_url":"https://api.github.com/users/joshsylvester/following{/other_user}","gists_url":"https://api.github.com/users/joshsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/joshsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshsylvester/subscriptions","organizations_url":"https://api.github.com/users/joshsylvester/orgs","repos_url":"https://api.github.com/users/joshsylvester/repos","events_url":"https://api.github.com/users/joshsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/joshsylvester/received_events","type":"User","site_admin":false},"repo":{"id":118158495,"name":"ui-components-lightning","full_name":"joshsylvester/ui-components-lightning","owner":{"login":"joshsylvester","id":30244294,"avatar_url":"https://avatars2.githubusercontent.com/u/30244294?v=4","gravatar_id":"","url":"https://api.github.com/users/joshsylvester","html_url":"https://github.com/joshsylvester","followers_url":"https://api.github.com/users/joshsylvester/followers","following_url":"https://api.github.com/users/joshsylvester/following{/other_user}","gists_url":"https://api.github.com/users/joshsylvester/gists{/gist_id}","starred_url":"https://api.github.com/users/joshsylvester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshsylvester/subscriptions","organizations_url":"https://api.github.com/users/joshsylvester/orgs","repos_url":"https://api.github.com/users/joshsylvester/repos","events_url":"https://api.github.com/users/joshsylvester/events{/privacy}","received_events_url":"https://api.github.com/users/joshsylvester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshsylvester/ui-components-lightning","description":"UI 2.0 Lightning NPM repository for all Salesforce Lightning Design System components","fork":true,"url":"https://api.github.com/repos/joshsylvester/ui-components-lightning","forks_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/forks","keys_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/teams","hooks_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/hooks","issue_events_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/events","assignees_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/tags","blobs_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/languages","stargazers_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/stargazers","contributors_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/contributors","subscribers_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/subscribers","subscription_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/subscription","commits_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/merges","archive_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/downloads","issues_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/labels{/name}","releases_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/joshsylvester/ui-components-lightning/deployments","created_at":"2018-01-19T17:49:07Z","updated_at":"2018-01-19T17:49:09Z","pushed_at":"2018-02-20T18:18:42Z","git_url":"git://github.com/joshsylvester/ui-components-lightning.git","ssh_url":"git@github.com:joshsylvester/ui-components-lightning.git","clone_url":"https://github.com/joshsylvester/ui-components-lightning.git","svn_url":"https://github.com/joshsylvester/ui-components-lightning","homepage":"","size":17207,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ServiceMax-Engineering:master","ref":"master","sha":"7dbde6193aebda973b7bf4b797364eeb174bd5d9","user":{"login":"ServiceMax-Engineering","id":13987655,"avatar_url":"https://avatars0.githubusercontent.com/u/13987655?v=4","gravatar_id":"","url":"https://api.github.com/users/ServiceMax-Engineering","html_url":"https://github.com/ServiceMax-Engineering","followers_url":"https://api.github.com/users/ServiceMax-Engineering/followers","following_url":"https://api.github.com/users/ServiceMax-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/ServiceMax-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/ServiceMax-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServiceMax-Engineering/subscriptions","organizations_url":"https://api.github.com/users/ServiceMax-Engineering/orgs","repos_url":"https://api.github.com/users/ServiceMax-Engineering/repos","events_url":"https://api.github.com/users/ServiceMax-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/ServiceMax-Engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":117293842,"name":"ui-components-lightning","full_name":"ServiceMax-Engineering/ui-components-lightning","owner":{"login":"ServiceMax-Engineering","id":13987655,"avatar_url":"https://avatars0.githubusercontent.com/u/13987655?v=4","gravatar_id":"","url":"https://api.github.com/users/ServiceMax-Engineering","html_url":"https://github.com/ServiceMax-Engineering","followers_url":"https://api.github.com/users/ServiceMax-Engineering/followers","following_url":"https://api.github.com/users/ServiceMax-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/ServiceMax-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/ServiceMax-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServiceMax-Engineering/subscriptions","organizations_url":"https://api.github.com/users/ServiceMax-Engineering/orgs","repos_url":"https://api.github.com/users/ServiceMax-Engineering/repos","events_url":"https://api.github.com/users/ServiceMax-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/ServiceMax-Engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning","description":"UI 2.0 Lightning NPM repository for all Salesforce Lightning Design System components","fork":true,"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning","forks_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/forks","keys_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/teams","hooks_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/hooks","issue_events_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/events","assignees_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/tags","blobs_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/languages","stargazers_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/stargazers","contributors_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/contributors","subscribers_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/subscribers","subscription_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/subscription","commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/merges","archive_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/downloads","issues_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/labels{/name}","releases_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/deployments","created_at":"2018-01-12T22:28:07Z","updated_at":"2018-01-19T17:49:02Z","pushed_at":"2018-02-20T18:19:43Z","git_url":"git://github.com/ServiceMax-Engineering/ui-components-lightning.git","ssh_url":"git@github.com:ServiceMax-Engineering/ui-components-lightning.git","clone_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning.git","svn_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning","homepage":"","size":17214,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":8,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34"},"html":{"href":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/34"},"issue":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/34"},"comments":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/12208f2db5b9bfb8c77b35f88226ef11c6514d31"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sheela-svmx"}}