{"action":"created","comment":{"url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/comments/227643915","pull_request_review_id":167730443,"id":227643915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzY0MzkxNQ==","diff_hunk":"@@ -35,11 +38,13 @@ const ActionButton = (props) => {\n     commonStyles = { ...commonStyles, ...rectStyles };\n     break;\n   }\n+\n   return (\n     <button\n       css={{\n         ...commonStyles\n       }}\n+      data-cy={props.dataCy}","path":"src/components/ActionButton.js","position":34,"original_position":34,"commit_id":"4e5f03cf550b2365ac4e6d3131ecb6651848ed30","original_commit_id":"4e5f03cf550b2365ac4e6d3131ecb6651848ed30","user":{"login":"RobertWSaunders","id":13367451,"node_id":"MDQ6VXNlcjEzMzY3NDUx","avatar_url":"https://avatars2.githubusercontent.com/u/13367451?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertWSaunders","html_url":"https://github.com/RobertWSaunders","followers_url":"https://api.github.com/users/RobertWSaunders/followers","following_url":"https://api.github.com/users/RobertWSaunders/following{/other_user}","gists_url":"https://api.github.com/users/RobertWSaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertWSaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertWSaunders/subscriptions","organizations_url":"https://api.github.com/users/RobertWSaunders/orgs","repos_url":"https://api.github.com/users/RobertWSaunders/repos","events_url":"https://api.github.com/users/RobertWSaunders/events{/privacy}","received_events_url":"https://api.github.com/users/RobertWSaunders/received_events","type":"User","site_admin":false},"body":"The reason we add these `data-cy` attributes on HTML elements is so Cypress can use them to select elements. I suggest you guys read this section in the [docs](https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements) to see why I did this. I actually went into the Cypress chat to ask what the best practice was because I found it hard to query elements based off of their CSS class name because we are using CSS-in-JS the class names gets randomly generated every time. I'm stilly pretty torn because it seems shitty to pass the values through props, especially when you have scenarios like the sign up form where there are multiple elements that need the attributes. I'm going to express my concerns in the chat and see what people think.","created_at":"2018-10-24T05:13:45Z","updated_at":"2018-10-24T05:16:34Z","html_url":"https://github.com/qhacks/qhacks-website/pull/144#discussion_r227643915","pull_request_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/comments/227643915"},"html":{"href":"https://github.com/qhacks/qhacks-website/pull/144#discussion_r227643915"},"pull_request":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144","id":225264790,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjY0Nzkw","html_url":"https://github.com/qhacks/qhacks-website/pull/144","diff_url":"https://github.com/qhacks/qhacks-website/pull/144.diff","patch_url":"https://github.com/qhacks/qhacks-website/pull/144.patch","issue_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/144","number":144,"state":"open","locked":false,"title":"Add Cypress browser integration tests","user":{"login":"RobertWSaunders","id":13367451,"node_id":"MDQ6VXNlcjEzMzY3NDUx","avatar_url":"https://avatars2.githubusercontent.com/u/13367451?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertWSaunders","html_url":"https://github.com/RobertWSaunders","followers_url":"https://api.github.com/users/RobertWSaunders/followers","following_url":"https://api.github.com/users/RobertWSaunders/following{/other_user}","gists_url":"https://api.github.com/users/RobertWSaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertWSaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertWSaunders/subscriptions","organizations_url":"https://api.github.com/users/RobertWSaunders/orgs","repos_url":"https://api.github.com/users/RobertWSaunders/repos","events_url":"https://api.github.com/users/RobertWSaunders/events{/privacy}","received_events_url":"https://api.github.com/users/RobertWSaunders/received_events","type":"User","site_admin":false},"body":"## Proposed Change\r\n\r\nFixes: #143 \r\n\r\nAdds Cypress to our project! 😃 \r\n\r\n### How did you do this?\r\n\r\nSee list of changes, mostly reading Cypress [docs](https://docs.cypress.io/guides/overview/why-cypress.html).\r\n\r\n### Why are you choosing this approach?\r\n\r\nTry out cool new tech, make our code better with tests!\r\n\r\n### Any open questions you want to ask code reviewers?\r\n\r\nThoughts on the `data-cy` implementation?\r\n\r\nSee comments! 🤔 \r\n\r\n### List of changes:\r\n\r\n  - Updates our PR template to add a new checklist item\r\n  - Updates to our CircleCI config to have the following:\r\n    - Caching and shared workspaces for faster build times\r\n    - Workflow requirements for faster failures\r\n    - Uses `npm ci` to install dependencies\r\n    - Browser integration testing job\r\n  - Commits our `package-lock.json` to support CircleCI config changes.\r\n  - Update README with new scripts description\r\n  - Adds `data-cy` attributes to HTML elements for Cypress querying\r\n  - Uses moment.js for copyright year now\r\n  - Adds a few Cypress tests\r\n\r\n## Pull Request Checklist:\r\n\r\n  - [x] My submission passes all tests.\r\n  - [x] I have lint my code locally prior to submission.\r\n  - [x] I have written new tests for my core changes (where applicable).\r\n  - [x] I have referenced all useful information (issues, tasks, etc) in the pull request.\r\n","created_at":"2018-10-24T04:56:07Z","updated_at":"2018-10-24T05:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e45d5fec154e6cd2bd10ca0a401290f8bb917b","assignee":{"login":"RobertWSaunders","id":13367451,"node_id":"MDQ6VXNlcjEzMzY3NDUx","avatar_url":"https://avatars2.githubusercontent.com/u/13367451?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertWSaunders","html_url":"https://github.com/RobertWSaunders","followers_url":"https://api.github.com/users/RobertWSaunders/followers","following_url":"https://api.github.com/users/RobertWSaunders/following{/other_user}","gists_url":"https://api.github.com/users/RobertWSaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertWSaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertWSaunders/subscriptions","organizations_url":"https://api.github.com/users/RobertWSaunders/orgs","repos_url":"https://api.github.com/users/RobertWSaunders/repos","events_url":"https://api.github.com/users/RobertWSaunders/events{/privacy}","received_events_url":"https://api.github.com/users/RobertWSaunders/received_events","type":"User","site_admin":false},"assignees":[{"login":"RobertWSaunders","id":13367451,"node_id":"MDQ6VXNlcjEzMzY3NDUx","avatar_url":"https://avatars2.githubusercontent.com/u/13367451?v=4","gravatar_id":"","url":"https://api.github.com/users/RobertWSaunders","html_url":"https://github.com/RobertWSaunders","followers_url":"https://api.github.com/users/RobertWSaunders/followers","following_url":"https://api.github.com/users/RobertWSaunders/following{/other_user}","gists_url":"https://api.github.com/users/RobertWSaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertWSaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertWSaunders/subscriptions","organizations_url":"https://api.github.com/users/RobertWSaunders/orgs","repos_url":"https://api.github.com/users/RobertWSaunders/repos","events_url":"https://api.github.com/users/RobertWSaunders/events{/privacy}","received_events_url":"https://api.github.com/users/RobertWSaunders/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"QHacks Engineering","id":2717138,"node_id":"MDQ6VGVhbTI3MTcxMzg=","slug":"qhacks-engineering","description":"This is the engineering team on the QHacks executive team!","privacy":"closed","url":"https://api.github.com/teams/2717138","members_url":"https://api.github.com/teams/2717138/members{/member}","repositories_url":"https://api.github.com/teams/2717138/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144/commits","review_comments_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144/comments","review_comment_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/144/comments","statuses_url":"https://api.github.com/repos/qhacks/qhacks-website/statuses/4e5f03cf550b2365ac4e6d3131ecb6651848ed30","head":{"label":"qhacks:feature/add-cypress-browser-integration-tests","ref":"feature/add-cypress-browser-integration-tests","sha":"4e5f03cf550b2365ac4e6d3131ecb6651848ed30","user":{"login":"qhacks","id":17298342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/17298342?v=4","gravatar_id":"","url":"https://api.github.com/users/qhacks","html_url":"https://github.com/qhacks","followers_url":"https://api.github.com/users/qhacks/followers","following_url":"https://api.github.com/users/qhacks/following{/other_user}","gists_url":"https://api.github.com/users/qhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/qhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qhacks/subscriptions","organizations_url":"https://api.github.com/users/qhacks/orgs","repos_url":"https://api.github.com/users/qhacks/repos","events_url":"https://api.github.com/users/qhacks/events{/privacy}","received_events_url":"https://api.github.com/users/qhacks/received_events","type":"Organization","site_admin":false},"repo":{"id":53641748,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY0MTc0OA==","name":"qhacks-website","full_name":"qhacks/qhacks-website","private":false,"owner":{"login":"qhacks","id":17298342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/17298342?v=4","gravatar_id":"","url":"https://api.github.com/users/qhacks","html_url":"https://github.com/qhacks","followers_url":"https://api.github.com/users/qhacks/followers","following_url":"https://api.github.com/users/qhacks/following{/other_user}","gists_url":"https://api.github.com/users/qhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/qhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qhacks/subscriptions","organizations_url":"https://api.github.com/users/qhacks/orgs","repos_url":"https://api.github.com/users/qhacks/repos","events_url":"https://api.github.com/users/qhacks/events{/privacy}","received_events_url":"https://api.github.com/users/qhacks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qhacks/qhacks-website","description":"QHacks main website! :tada: :electric_plug:","fork":false,"url":"https://api.github.com/repos/qhacks/qhacks-website","forks_url":"https://api.github.com/repos/qhacks/qhacks-website/forks","keys_url":"https://api.github.com/repos/qhacks/qhacks-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qhacks/qhacks-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qhacks/qhacks-website/teams","hooks_url":"https://api.github.com/repos/qhacks/qhacks-website/hooks","issue_events_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/events{/number}","events_url":"https://api.github.com/repos/qhacks/qhacks-website/events","assignees_url":"https://api.github.com/repos/qhacks/qhacks-website/assignees{/user}","branches_url":"https://api.github.com/repos/qhacks/qhacks-website/branches{/branch}","tags_url":"https://api.github.com/repos/qhacks/qhacks-website/tags","blobs_url":"https://api.github.com/repos/qhacks/qhacks-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qhacks/qhacks-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qhacks/qhacks-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/qhacks/qhacks-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qhacks/qhacks-website/statuses/{sha}","languages_url":"https://api.github.com/repos/qhacks/qhacks-website/languages","stargazers_url":"https://api.github.com/repos/qhacks/qhacks-website/stargazers","contributors_url":"https://api.github.com/repos/qhacks/qhacks-website/contributors","subscribers_url":"https://api.github.com/repos/qhacks/qhacks-website/subscribers","subscription_url":"https://api.github.com/repos/qhacks/qhacks-website/subscription","commits_url":"https://api.github.com/repos/qhacks/qhacks-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/qhacks/qhacks-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/qhacks/qhacks-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/qhacks/qhacks-website/contents/{+path}","compare_url":"https://api.github.com/repos/qhacks/qhacks-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qhacks/qhacks-website/merges","archive_url":"https://api.github.com/repos/qhacks/qhacks-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qhacks/qhacks-website/downloads","issues_url":"https://api.github.com/repos/qhacks/qhacks-website/issues{/number}","pulls_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls{/number}","milestones_url":"https://api.github.com/repos/qhacks/qhacks-website/milestones{/number}","notifications_url":"https://api.github.com/repos/qhacks/qhacks-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qhacks/qhacks-website/labels{/name}","releases_url":"https://api.github.com/repos/qhacks/qhacks-website/releases{/id}","deployments_url":"https://api.github.com/repos/qhacks/qhacks-website/deployments","created_at":"2016-03-11T05:20:22Z","updated_at":"2018-10-22T22:58:26Z","pushed_at":"2018-10-24T04:58:57Z","git_url":"git://github.com/qhacks/qhacks-website.git","ssh_url":"git@github.com:qhacks/qhacks-website.git","clone_url":"https://github.com/qhacks/qhacks-website.git","svn_url":"https://github.com/qhacks/qhacks-website","homepage":"https://qhacks.io/","size":39537,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":25,"watchers":7,"default_branch":"dev"}},"base":{"label":"qhacks:dev","ref":"dev","sha":"e4c90a04a9cb5da90c6cbfc47631e373ef6d3155","user":{"login":"qhacks","id":17298342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/17298342?v=4","gravatar_id":"","url":"https://api.github.com/users/qhacks","html_url":"https://github.com/qhacks","followers_url":"https://api.github.com/users/qhacks/followers","following_url":"https://api.github.com/users/qhacks/following{/other_user}","gists_url":"https://api.github.com/users/qhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/qhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qhacks/subscriptions","organizations_url":"https://api.github.com/users/qhacks/orgs","repos_url":"https://api.github.com/users/qhacks/repos","events_url":"https://api.github.com/users/qhacks/events{/privacy}","received_events_url":"https://api.github.com/users/qhacks/received_events","type":"Organization","site_admin":false},"repo":{"id":53641748,"node_id":"MDEwOlJlcG9zaXRvcnk1MzY0MTc0OA==","name":"qhacks-website","full_name":"qhacks/qhacks-website","private":false,"owner":{"login":"qhacks","id":17298342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Mjk4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/17298342?v=4","gravatar_id":"","url":"https://api.github.com/users/qhacks","html_url":"https://github.com/qhacks","followers_url":"https://api.github.com/users/qhacks/followers","following_url":"https://api.github.com/users/qhacks/following{/other_user}","gists_url":"https://api.github.com/users/qhacks/gists{/gist_id}","starred_url":"https://api.github.com/users/qhacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qhacks/subscriptions","organizations_url":"https://api.github.com/users/qhacks/orgs","repos_url":"https://api.github.com/users/qhacks/repos","events_url":"https://api.github.com/users/qhacks/events{/privacy}","received_events_url":"https://api.github.com/users/qhacks/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qhacks/qhacks-website","description":"QHacks main website! :tada: :electric_plug:","fork":false,"url":"https://api.github.com/repos/qhacks/qhacks-website","forks_url":"https://api.github.com/repos/qhacks/qhacks-website/forks","keys_url":"https://api.github.com/repos/qhacks/qhacks-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qhacks/qhacks-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qhacks/qhacks-website/teams","hooks_url":"https://api.github.com/repos/qhacks/qhacks-website/hooks","issue_events_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/events{/number}","events_url":"https://api.github.com/repos/qhacks/qhacks-website/events","assignees_url":"https://api.github.com/repos/qhacks/qhacks-website/assignees{/user}","branches_url":"https://api.github.com/repos/qhacks/qhacks-website/branches{/branch}","tags_url":"https://api.github.com/repos/qhacks/qhacks-website/tags","blobs_url":"https://api.github.com/repos/qhacks/qhacks-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qhacks/qhacks-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qhacks/qhacks-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/qhacks/qhacks-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qhacks/qhacks-website/statuses/{sha}","languages_url":"https://api.github.com/repos/qhacks/qhacks-website/languages","stargazers_url":"https://api.github.com/repos/qhacks/qhacks-website/stargazers","contributors_url":"https://api.github.com/repos/qhacks/qhacks-website/contributors","subscribers_url":"https://api.github.com/repos/qhacks/qhacks-website/subscribers","subscription_url":"https://api.github.com/repos/qhacks/qhacks-website/subscription","commits_url":"https://api.github.com/repos/qhacks/qhacks-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/qhacks/qhacks-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/qhacks/qhacks-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/qhacks/qhacks-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/qhacks/qhacks-website/contents/{+path}","compare_url":"https://api.github.com/repos/qhacks/qhacks-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qhacks/qhacks-website/merges","archive_url":"https://api.github.com/repos/qhacks/qhacks-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qhacks/qhacks-website/downloads","issues_url":"https://api.github.com/repos/qhacks/qhacks-website/issues{/number}","pulls_url":"https://api.github.com/repos/qhacks/qhacks-website/pulls{/number}","milestones_url":"https://api.github.com/repos/qhacks/qhacks-website/milestones{/number}","notifications_url":"https://api.github.com/repos/qhacks/qhacks-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qhacks/qhacks-website/labels{/name}","releases_url":"https://api.github.com/repos/qhacks/qhacks-website/releases{/id}","deployments_url":"https://api.github.com/repos/qhacks/qhacks-website/deployments","created_at":"2016-03-11T05:20:22Z","updated_at":"2018-10-22T22:58:26Z","pushed_at":"2018-10-24T04:58:57Z","git_url":"git://github.com/qhacks/qhacks-website.git","ssh_url":"git@github.com:qhacks/qhacks-website.git","clone_url":"https://github.com/qhacks/qhacks-website.git","svn_url":"https://github.com/qhacks/qhacks-website","homepage":"https://qhacks.io/","size":39537,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":25,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144"},"html":{"href":"https://github.com/qhacks/qhacks-website/pull/144"},"issue":{"href":"https://api.github.com/repos/qhacks/qhacks-website/issues/144"},"comments":{"href":"https://api.github.com/repos/qhacks/qhacks-website/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qhacks/qhacks-website/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/qhacks/qhacks-website/statuses/4e5f03cf550b2365ac4e6d3131ecb6651848ed30"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RobertWSaunders"}}