{"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8","id":195967426,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTY3NDI2","html_url":"https://github.com/stefanofornari/BshConsole/pull/8","diff_url":"https://github.com/stefanofornari/BshConsole/pull/8.diff","patch_url":"https://github.com/stefanofornari/BshConsole/pull/8.patch","issue_url":"https://api.github.com/repos/stefanofornari/BshConsole/issues/8","number":8,"state":"open","locked":false,"title":"Interrupt script not shell","user":{"login":"nickl-","id":1404606,"node_id":"MDQ6VXNlcjE0MDQ2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1404606?v=4","gravatar_id":"","url":"https://api.github.com/users/nickl-","html_url":"https://github.com/nickl-","followers_url":"https://api.github.com/users/nickl-/followers","following_url":"https://api.github.com/users/nickl-/following{/other_user}","gists_url":"https://api.github.com/users/nickl-/gists{/gist_id}","starred_url":"https://api.github.com/users/nickl-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickl-/subscriptions","organizations_url":"https://api.github.com/users/nickl-/orgs","repos_url":"https://api.github.com/users/nickl-/repos","events_url":"https://api.github.com/users/nickl-/events{/privacy}","received_events_url":"https://api.github.com/users/nickl-/received_events","type":"User","site_admin":false},"body":"You did it!!! Bloody marvellous it all works like a charm! Well done bro!!!!!\r\n\r\nEverything works!!! Whoop whoop!!! .... if you use beanshell HEAD that is\r\n\r\nIt was a real mission to try and merge my old repository and commits with the latest updates upstream, I decided to just pull a fresh repository and start over. When I tested again it wasn't working =( but I vas sure it was working before, then I noticed you are still using v 2.0b5\r\n\r\nI can't tell you why it's not working, I am more surprised that you are actually using that version at all. You probably never tried to build master?!?!? It's broken dude!!!! If I recall more than 70% of the tests were failing but even if you disabled the tests it won't build without problems. It's not even intact the latest release of beanshell.\r\n\r\nSomewhere before they were approached to go into apache incubation, after which a whole bunch of fixes were applied to the source code, another team of developers forked the repository and went their own way with beanshell2, you are probably better off using that version it is far more stable.\r\n\r\nI have spent the last 6 months merging the two forks, beanshell2 made many noteworthy fixes over the course of 2 years which are simply crucial but at then there were other additions made during the apache intake not presently available in beanshell2. It was crystal clear, if I wanted to see any improvement with beanshell I will first have to merge the two branches or it will become an impossible task if I don't. Took the best part of 4 months and was not much fun.... but it is done.\r\n\r\nSo also don't decide now to go and start using beanshell2 just because there is a release, everything is already included here. Over the last 6 weeks development was more satisfying, we've made a lot of progress but it's still been conservative, fixing or completing unfinished implementations or aiming to satisfy existing test cases. I can't wait to be done with this phase so we can get to the really fun stuff.\r\n\r\nI have included the dependency change to use the custom build development version and I hope you will merge it but the choice is yours. Oh yes before I forget everything is ready to be committed if you agree, it is not like last time. I don't want to make things difficult for you but I am confident you shouldn't have any problems to pull the repository and build it with `mvn install` using either JDK 8, Java 9 or Java 10. All the tests will pass as well no sweats. Once it's installed to m2 you won't even notice it anymore. =)\r\n\r\nThere is no point for me to use the old version, I need to sort out the final issues in the latest version. I don't know how many issues because there are probably many still I haven't even seen yet. I am the only person testing it, which is why it would really help if you would use it and report any problems you discover. \r\n\r\nIt's been how many years since the last release so there is no need to rush a release what is waiting another month or three? What is more important for me is to me is that when we release and start promoting the new beanshell that it will be a product that we have confidence in and something that can start gaining trust from a community again. The last thing we need is releasing something and we start getting issues like \"it doesn't compile with `@SuppressWarnings`\" yip it is true, parser error and something I only saw yesterday. =/   \r\n\r\nI'm liking the jline more now that it is starting to come together, who knows perhaps this is ready by the time we have sufficient test coverage and we include it in the release. That would go a long way to gaining favour in the community once more. Anyway... went on a nice tangent there, thank you for listening. Let me submit and I will follow up with more details on the commits shortly.  \r\n\r\nOh b.t.w mvn still can't find one dependency:\r\n\r\n```xml\r\n        <dependency>\r\n            <groupId>ste.test</groupId>\r\n            <artifactId>xtest</artifactId>\r\n            <version>1.19.1</version>\r\n            <scope>test</scope>\r\n        </dependency>\r\n```\r\n\r\nI found the repo on your profile and managed to build it after hunting down several other dependencies those dependencies have. Not sure what it's used for because the tests don't even compile, perhaps it is because I am using version 1.20.1-SNAPSHOT... just thought you should know.\r\n\r\n","created_at":"2018-06-19T21:46:50Z","updated_at":"2018-06-19T21:46:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8/commits","review_comments_url":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8/comments","review_comment_url":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stefanofornari/BshConsole/issues/8/comments","statuses_url":"https://api.github.com/repos/stefanofornari/BshConsole/statuses/23b473b694360a3eb71264f2ebf1c6f8f695f995","head":{"label":"nickl-:interrupt-script-not-shell","ref":"interrupt-script-not-shell","sha":"23b473b694360a3eb71264f2ebf1c6f8f695f995","user":{"login":"nickl-","id":1404606,"node_id":"MDQ6VXNlcjE0MDQ2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1404606?v=4","gravatar_id":"","url":"https://api.github.com/users/nickl-","html_url":"https://github.com/nickl-","followers_url":"https://api.github.com/users/nickl-/followers","following_url":"https://api.github.com/users/nickl-/following{/other_user}","gists_url":"https://api.github.com/users/nickl-/gists{/gist_id}","starred_url":"https://api.github.com/users/nickl-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickl-/subscriptions","organizations_url":"https://api.github.com/users/nickl-/orgs","repos_url":"https://api.github.com/users/nickl-/repos","events_url":"https://api.github.com/users/nickl-/events{/privacy}","received_events_url":"https://api.github.com/users/nickl-/received_events","type":"User","site_admin":false},"repo":{"id":136648054,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2NDgwNTQ=","name":"BshConsole","full_name":"nickl-/BshConsole","owner":{"login":"nickl-","id":1404606,"node_id":"MDQ6VXNlcjE0MDQ2MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1404606?v=4","gravatar_id":"","url":"https://api.github.com/users/nickl-","html_url":"https://github.com/nickl-","followers_url":"https://api.github.com/users/nickl-/followers","following_url":"https://api.github.com/users/nickl-/following{/other_user}","gists_url":"https://api.github.com/users/nickl-/gists{/gist_id}","starred_url":"https://api.github.com/users/nickl-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickl-/subscriptions","organizations_url":"https://api.github.com/users/nickl-/orgs","repos_url":"https://api.github.com/users/nickl-/repos","events_url":"https://api.github.com/users/nickl-/events{/privacy}","received_events_url":"https://api.github.com/users/nickl-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickl-/BshConsole","description":"A BeanShell console with history, vars/commands completion and more...","fork":true,"url":"https://api.github.com/repos/nickl-/BshConsole","forks_url":"https://api.github.com/repos/nickl-/BshConsole/forks","keys_url":"https://api.github.com/repos/nickl-/BshConsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickl-/BshConsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickl-/BshConsole/teams","hooks_url":"https://api.github.com/repos/nickl-/BshConsole/hooks","issue_events_url":"https://api.github.com/repos/nickl-/BshConsole/issues/events{/number}","events_url":"https://api.github.com/repos/nickl-/BshConsole/events","assignees_url":"https://api.github.com/repos/nickl-/BshConsole/assignees{/user}","branches_url":"https://api.github.com/repos/nickl-/BshConsole/branches{/branch}","tags_url":"https://api.github.com/repos/nickl-/BshConsole/tags","blobs_url":"https://api.github.com/repos/nickl-/BshConsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickl-/BshConsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickl-/BshConsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickl-/BshConsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickl-/BshConsole/statuses/{sha}","languages_url":"https://api.github.com/repos/nickl-/BshConsole/languages","stargazers_url":"https://api.github.com/repos/nickl-/BshConsole/stargazers","contributors_url":"https://api.github.com/repos/nickl-/BshConsole/contributors","subscribers_url":"https://api.github.com/repos/nickl-/BshConsole/subscribers","subscription_url":"https://api.github.com/repos/nickl-/BshConsole/subscription","commits_url":"https://api.github.com/repos/nickl-/BshConsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickl-/BshConsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickl-/BshConsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickl-/BshConsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickl-/BshConsole/contents/{+path}","compare_url":"https://api.github.com/repos/nickl-/BshConsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickl-/BshConsole/merges","archive_url":"https://api.github.com/repos/nickl-/BshConsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickl-/BshConsole/downloads","issues_url":"https://api.github.com/repos/nickl-/BshConsole/issues{/number}","pulls_url":"https://api.github.com/repos/nickl-/BshConsole/pulls{/number}","milestones_url":"https://api.github.com/repos/nickl-/BshConsole/milestones{/number}","notifications_url":"https://api.github.com/repos/nickl-/BshConsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickl-/BshConsole/labels{/name}","releases_url":"https://api.github.com/repos/nickl-/BshConsole/releases{/id}","deployments_url":"https://api.github.com/repos/nickl-/BshConsole/deployments","created_at":"2018-06-08T17:30:34Z","updated_at":"2018-06-08T17:33:11Z","pushed_at":"2018-06-19T20:00:56Z","git_url":"git://github.com/nickl-/BshConsole.git","ssh_url":"git@github.com:nickl-/BshConsole.git","clone_url":"https://github.com/nickl-/BshConsole.git","svn_url":"https://github.com/nickl-/BshConsole","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stefanofornari:master","ref":"master","sha":"0b53541855bfcca9fcdb7934bc95b6401d61431b","user":{"login":"stefanofornari","id":43138,"node_id":"MDQ6VXNlcjQzMTM4","avatar_url":"https://avatars2.githubusercontent.com/u/43138?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanofornari","html_url":"https://github.com/stefanofornari","followers_url":"https://api.github.com/users/stefanofornari/followers","following_url":"https://api.github.com/users/stefanofornari/following{/other_user}","gists_url":"https://api.github.com/users/stefanofornari/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanofornari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanofornari/subscriptions","organizations_url":"https://api.github.com/users/stefanofornari/orgs","repos_url":"https://api.github.com/users/stefanofornari/repos","events_url":"https://api.github.com/users/stefanofornari/events{/privacy}","received_events_url":"https://api.github.com/users/stefanofornari/received_events","type":"User","site_admin":false},"repo":{"id":131700004,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3MDAwMDQ=","name":"BshConsole","full_name":"stefanofornari/BshConsole","owner":{"login":"stefanofornari","id":43138,"node_id":"MDQ6VXNlcjQzMTM4","avatar_url":"https://avatars2.githubusercontent.com/u/43138?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanofornari","html_url":"https://github.com/stefanofornari","followers_url":"https://api.github.com/users/stefanofornari/followers","following_url":"https://api.github.com/users/stefanofornari/following{/other_user}","gists_url":"https://api.github.com/users/stefanofornari/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanofornari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanofornari/subscriptions","organizations_url":"https://api.github.com/users/stefanofornari/orgs","repos_url":"https://api.github.com/users/stefanofornari/repos","events_url":"https://api.github.com/users/stefanofornari/events{/privacy}","received_events_url":"https://api.github.com/users/stefanofornari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanofornari/BshConsole","description":"A BeanShell console with history, vars/commands completion and more...","fork":false,"url":"https://api.github.com/repos/stefanofornari/BshConsole","forks_url":"https://api.github.com/repos/stefanofornari/BshConsole/forks","keys_url":"https://api.github.com/repos/stefanofornari/BshConsole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanofornari/BshConsole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanofornari/BshConsole/teams","hooks_url":"https://api.github.com/repos/stefanofornari/BshConsole/hooks","issue_events_url":"https://api.github.com/repos/stefanofornari/BshConsole/issues/events{/number}","events_url":"https://api.github.com/repos/stefanofornari/BshConsole/events","assignees_url":"https://api.github.com/repos/stefanofornari/BshConsole/assignees{/user}","branches_url":"https://api.github.com/repos/stefanofornari/BshConsole/branches{/branch}","tags_url":"https://api.github.com/repos/stefanofornari/BshConsole/tags","blobs_url":"https://api.github.com/repos/stefanofornari/BshConsole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanofornari/BshConsole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanofornari/BshConsole/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanofornari/BshConsole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanofornari/BshConsole/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanofornari/BshConsole/languages","stargazers_url":"https://api.github.com/repos/stefanofornari/BshConsole/stargazers","contributors_url":"https://api.github.com/repos/stefanofornari/BshConsole/contributors","subscribers_url":"https://api.github.com/repos/stefanofornari/BshConsole/subscribers","subscription_url":"https://api.github.com/repos/stefanofornari/BshConsole/subscription","commits_url":"https://api.github.com/repos/stefanofornari/BshConsole/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanofornari/BshConsole/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanofornari/BshConsole/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanofornari/BshConsole/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanofornari/BshConsole/contents/{+path}","compare_url":"https://api.github.com/repos/stefanofornari/BshConsole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanofornari/BshConsole/merges","archive_url":"https://api.github.com/repos/stefanofornari/BshConsole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanofornari/BshConsole/downloads","issues_url":"https://api.github.com/repos/stefanofornari/BshConsole/issues{/number}","pulls_url":"https://api.github.com/repos/stefanofornari/BshConsole/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanofornari/BshConsole/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanofornari/BshConsole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanofornari/BshConsole/labels{/name}","releases_url":"https://api.github.com/repos/stefanofornari/BshConsole/releases{/id}","deployments_url":"https://api.github.com/repos/stefanofornari/BshConsole/deployments","created_at":"2018-05-01T10:17:19Z","updated_at":"2018-06-19T13:00:56Z","pushed_at":"2018-06-19T13:00:55Z","git_url":"git://github.com/stefanofornari/BshConsole.git","ssh_url":"git@github.com:stefanofornari/BshConsole.git","clone_url":"https://github.com/stefanofornari/BshConsole.git","svn_url":"https://github.com/stefanofornari/BshConsole","homepage":null,"size":53,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8"},"html":{"href":"https://github.com/stefanofornari/BshConsole/pull/8"},"issue":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/issues/8"},"comments":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/stefanofornari/BshConsole/statuses/23b473b694360a3eb71264f2ebf1c6f8f695f995"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":30,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"nickl-"}}