{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/21119","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/21119/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21119/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/21119/events","html_url":"https://github.com/flutter/flutter/pull/21119","id":354787184,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDY2MzIx","number":21119,"title":"Allow FlutterTester to be provided with the working directory for execution","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-28T15:35:05Z","updated_at":"2018-08-28T17:00:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/21119","html_url":"https://github.com/flutter/flutter/pull/21119","diff_url":"https://github.com/flutter/flutter/pull/21119.diff","patch_url":"https://github.com/flutter/flutter/pull/21119.patch"},"body":"Previously these tests set `fs.currentDirectory` which prevents running tests concurrently. This change allows providing the working directory for a FlutterTester in the constructor and provides the location from the test (without setting `fs.currentDirectory`)."},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/416663229","html_url":"https://github.com/flutter/flutter/pull/21119#issuecomment-416663229","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21119","id":416663229,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjY2MzIyOQ==","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T17:00:38Z","updated_at":"2018-08-28T17:00:38Z","author_association":"MEMBER","body":"> Could you add tests in flutter_tester_test.dart for these changes? Make sure that we're not changing the cwd...\r\n\r\nDo you mean to ensure the `flutter_tester` class doesn't changing it internally?\r\n\r\n> Also, have you checked in with @Hixie about this: he was looking at something similar to this last week, I think.\r\n\r\nWe did exchange some emails - he made a start on this but isn't actively working on it so I'm picking it up. I fixed a few obvious issues today and he's going to share the changes he'd made if deemed worthwhile.\r\n\r\nWith the few changes from today, they do seem to all pass when I run them locally (minus some Windows issues I'm still investigating after moving to the MemoryFileSystem using the Windows style) but I'll enable them on a fork and run them repeatedly once that's sorted in case there are others that that I might not have found from searching (or that are for reasons other than `currentDirectory`). Fixing up tests is probably relatively low risk, but actually removing the `-j1` might be a different story :-)"}}
{"actor":{"display_login":"DanTup"}}