{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/comments/184979431","pull_request_review_id":116272519,"id":184979431,"diff_hunk":"@@ -51,11 +51,22 @@ namespace brayns\n  * forward.\n  * @todo Move this loaded to Brion\n  */\n-class NESTLoader : public ProgressReporter\n+class NESTLoader : public Loader\n {\n public:\n     NESTLoader(const GeometryParameters& geometryParameters);\n \n+    void importFromBlob(Blob&&, Scene&, const Matrix4f&, const size_t) final\n+    {\n+        throw std::runtime_error(\"Unsupported\");\n+    }\n+\n+    void importFromFile(const std::string&, Scene&, const Matrix4f&,\n+                        const size_t) final\n+    {\n+        throw std::runtime_error(\"Unsupported\");","path":"brayns/io/NESTLoader.h","position":29,"original_position":29,"commit_id":"d66f893d5e70b8e913da5c4c1c80d083df26dd05","original_commit_id":"d66f893d5e70b8e913da5c4c1c80d083df26dd05","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars2.githubusercontent.com/u/5166658?v=4","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"body":"this class also can't load anything? Why is it not calling importCircuit() / importSpikeReport()?","created_at":"2018-04-30T13:00:05Z","updated_at":"2018-04-30T13:07:13Z","html_url":"https://github.com/BlueBrain/Brayns/pull/375#discussion_r184979431","pull_request_url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/comments/184979431"},"html":{"href":"https://github.com/BlueBrain/Brayns/pull/375#discussion_r184979431"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375","id":184922445,"html_url":"https://github.com/BlueBrain/Brayns/pull/375","diff_url":"https://github.com/BlueBrain/Brayns/pull/375.diff","patch_url":"https://github.com/BlueBrain/Brayns/pull/375.patch","issue_url":"https://api.github.com/repos/BlueBrain/Brayns/issues/375","number":375,"state":"open","locked":false,"title":"Add loader API and registry","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"* Allows plugins to load data from client load RPCs\n* Cleanups handling of different data types in LoadDataFunctor\n* Extract CircuitLoader from MorphologyLoader\n* Removes unused SceneLoader\n* Adds support for loading folders from upload-path RPC","created_at":"2018-04-30T10:24:14Z","updated_at":"2018-04-30T13:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2aae5d6e3cbcab5c381add89b118628811516b9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"favreau","id":8790943,"avatar_url":"https://avatars1.githubusercontent.com/u/8790943?v=4","gravatar_id":"","url":"https://api.github.com/users/favreau","html_url":"https://github.com/favreau","followers_url":"https://api.github.com/users/favreau/followers","following_url":"https://api.github.com/users/favreau/following{/other_user}","gists_url":"https://api.github.com/users/favreau/gists{/gist_id}","starred_url":"https://api.github.com/users/favreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/favreau/subscriptions","organizations_url":"https://api.github.com/users/favreau/orgs","repos_url":"https://api.github.com/users/favreau/repos","events_url":"https://api.github.com/users/favreau/events{/privacy}","received_events_url":"https://api.github.com/users/favreau/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Brayns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Brayns/issues/375/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Brayns/statuses/d66f893d5e70b8e913da5c4c1c80d083df26dd05","head":{"label":"tribal-tec:master","ref":"master","sha":"d66f893d5e70b8e913da5c4c1c80d083df26dd05","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"repo":{"id":71445281,"name":"Brayns","full_name":"tribal-tec/Brayns","owner":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tribal-tec/Brayns","description":"Visualizer for large-scale and interactive ray-tracing of neurons","fork":true,"url":"https://api.github.com/repos/tribal-tec/Brayns","forks_url":"https://api.github.com/repos/tribal-tec/Brayns/forks","keys_url":"https://api.github.com/repos/tribal-tec/Brayns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tribal-tec/Brayns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tribal-tec/Brayns/teams","hooks_url":"https://api.github.com/repos/tribal-tec/Brayns/hooks","issue_events_url":"https://api.github.com/repos/tribal-tec/Brayns/issues/events{/number}","events_url":"https://api.github.com/repos/tribal-tec/Brayns/events","assignees_url":"https://api.github.com/repos/tribal-tec/Brayns/assignees{/user}","branches_url":"https://api.github.com/repos/tribal-tec/Brayns/branches{/branch}","tags_url":"https://api.github.com/repos/tribal-tec/Brayns/tags","blobs_url":"https://api.github.com/repos/tribal-tec/Brayns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tribal-tec/Brayns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tribal-tec/Brayns/git/refs{/sha}","trees_url":"https://api.github.com/repos/tribal-tec/Brayns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tribal-tec/Brayns/statuses/{sha}","languages_url":"https://api.github.com/repos/tribal-tec/Brayns/languages","stargazers_url":"https://api.github.com/repos/tribal-tec/Brayns/stargazers","contributors_url":"https://api.github.com/repos/tribal-tec/Brayns/contributors","subscribers_url":"https://api.github.com/repos/tribal-tec/Brayns/subscribers","subscription_url":"https://api.github.com/repos/tribal-tec/Brayns/subscription","commits_url":"https://api.github.com/repos/tribal-tec/Brayns/commits{/sha}","git_commits_url":"https://api.github.com/repos/tribal-tec/Brayns/git/commits{/sha}","comments_url":"https://api.github.com/repos/tribal-tec/Brayns/comments{/number}","issue_comment_url":"https://api.github.com/repos/tribal-tec/Brayns/issues/comments{/number}","contents_url":"https://api.github.com/repos/tribal-tec/Brayns/contents/{+path}","compare_url":"https://api.github.com/repos/tribal-tec/Brayns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tribal-tec/Brayns/merges","archive_url":"https://api.github.com/repos/tribal-tec/Brayns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tribal-tec/Brayns/downloads","issues_url":"https://api.github.com/repos/tribal-tec/Brayns/issues{/number}","pulls_url":"https://api.github.com/repos/tribal-tec/Brayns/pulls{/number}","milestones_url":"https://api.github.com/repos/tribal-tec/Brayns/milestones{/number}","notifications_url":"https://api.github.com/repos/tribal-tec/Brayns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tribal-tec/Brayns/labels{/name}","releases_url":"https://api.github.com/repos/tribal-tec/Brayns/releases{/id}","deployments_url":"https://api.github.com/repos/tribal-tec/Brayns/deployments","created_at":"2016-10-20T09:11:29Z","updated_at":"2018-04-30T11:51:25Z","pushed_at":"2018-04-30T11:51:24Z","git_url":"git://github.com/tribal-tec/Brayns.git","ssh_url":"git@github.com:tribal-tec/Brayns.git","clone_url":"https://github.com/tribal-tec/Brayns.git","svn_url":"https://github.com/tribal-tec/Brayns","homepage":"","size":76577,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"7192c898221f028cbf2930f1d1d2cb73c87a0afd","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":61363694,"name":"Brayns","full_name":"BlueBrain/Brayns","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Brayns","description":"Interactive raytracing of neuroscience data","fork":false,"url":"https://api.github.com/repos/BlueBrain/Brayns","forks_url":"https://api.github.com/repos/BlueBrain/Brayns/forks","keys_url":"https://api.github.com/repos/BlueBrain/Brayns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Brayns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Brayns/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Brayns/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Brayns/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Brayns/events","assignees_url":"https://api.github.com/repos/BlueBrain/Brayns/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Brayns/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Brayns/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Brayns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Brayns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Brayns/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Brayns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Brayns/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Brayns/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Brayns/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Brayns/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Brayns/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Brayns/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Brayns/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Brayns/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Brayns/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Brayns/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Brayns/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Brayns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Brayns/merges","archive_url":"https://api.github.com/repos/BlueBrain/Brayns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Brayns/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Brayns/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Brayns/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Brayns/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Brayns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Brayns/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Brayns/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Brayns/deployments","created_at":"2016-06-17T09:49:06Z","updated_at":"2018-04-30T08:03:27Z","pushed_at":"2018-04-30T11:51:25Z","git_url":"git://github.com/BlueBrain/Brayns.git","ssh_url":"git@github.com:BlueBrain/Brayns.git","clone_url":"https://github.com/BlueBrain/Brayns.git","svn_url":"https://github.com/BlueBrain/Brayns","homepage":"","size":76104,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":20,"open_issues":32,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375"},"html":{"href":"https://github.com/BlueBrain/Brayns/pull/375"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Brayns/issues/375"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Brayns/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Brayns/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Brayns/statuses/d66f893d5e70b8e913da5c4c1c80d083df26dd05"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rdumusc"}}