{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/security_monkey/issues/1044","repository_url":"https://api.github.com/repos/Netflix/security_monkey","labels_url":"https://api.github.com/repos/Netflix/security_monkey/issues/1044/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/security_monkey/issues/1044/comments","events_url":"https://api.github.com/repos/Netflix/security_monkey/issues/1044/events","html_url":"https://github.com/Netflix/security_monkey/pull/1044","id":316520061,"number":1044,"title":"WIP: Docker speedup and celery env config","user":{"login":"tabletcorry","id":456754,"avatar_url":"https://avatars0.githubusercontent.com/u/456754?v=4","gravatar_id":"","url":"https://api.github.com/users/tabletcorry","html_url":"https://github.com/tabletcorry","followers_url":"https://api.github.com/users/tabletcorry/followers","following_url":"https://api.github.com/users/tabletcorry/following{/other_user}","gists_url":"https://api.github.com/users/tabletcorry/gists{/gist_id}","starred_url":"https://api.github.com/users/tabletcorry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tabletcorry/subscriptions","organizations_url":"https://api.github.com/users/tabletcorry/orgs","repos_url":"https://api.github.com/users/tabletcorry/repos","events_url":"https://api.github.com/users/tabletcorry/events{/privacy}","received_events_url":"https://api.github.com/users/tabletcorry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-21T19:46:21Z","updated_at":"2018-04-22T23:15:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Netflix/security_monkey/pulls/1044","html_url":"https://github.com/Netflix/security_monkey/pull/1044","diff_url":"https://github.com/Netflix/security_monkey/pull/1044.diff","patch_url":"https://github.com/Netflix/security_monkey/pull/1044.patch"},"body":"- Configure celery redis from environment\r\n- Define redis host in Docker Compose file\r\n- Break up monolithic docker build\r\n- Re-order docker builds so work is done before code is imported (allows caching)\r\n- Remove virtual environment (not necessary on docker container)\r\n\r\nCopying the `install_requires` into the Dockerfile is not ideal, but is a considerable speed boost. If `setup.py` drifts, it will fail-safe by simply re-installing the correct version."},"comment":{"url":"https://api.github.com/repos/Netflix/security_monkey/issues/comments/383419971","html_url":"https://github.com/Netflix/security_monkey/pull/1044#issuecomment-383419971","issue_url":"https://api.github.com/repos/Netflix/security_monkey/issues/1044","id":383419971,"user":{"login":"tabletcorry","id":456754,"avatar_url":"https://avatars0.githubusercontent.com/u/456754?v=4","gravatar_id":"","url":"https://api.github.com/users/tabletcorry","html_url":"https://github.com/tabletcorry","followers_url":"https://api.github.com/users/tabletcorry/followers","following_url":"https://api.github.com/users/tabletcorry/following{/other_user}","gists_url":"https://api.github.com/users/tabletcorry/gists{/gist_id}","starred_url":"https://api.github.com/users/tabletcorry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tabletcorry/subscriptions","organizations_url":"https://api.github.com/users/tabletcorry/orgs","repos_url":"https://api.github.com/users/tabletcorry/repos","events_url":"https://api.github.com/users/tabletcorry/events{/privacy}","received_events_url":"https://api.github.com/users/tabletcorry/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T23:15:22Z","updated_at":"2018-04-22T23:15:22Z","author_association":"CONTRIBUTOR","body":"On mobile, so a little hard to go into detail.\r\n\r\nBut the goal of my changes is to do as much as possible before copying the code into the container, as this makes rebuilding the docker image vastly faster.\r\n\r\nThe clean way would be to copy only the requirements file over, but secmonkey doesn’t have one.\r\n\r\nEven though I am hardcoding it, setup.py will override and install the correct versions if the docket file is out of date."}}
{"actor":{"display_login":"tabletcorry"}}