{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/169895673","pull_request_review_id":98493463,"id":169895673,"diff_hunk":"@@ -232,6 +250,80 @@ def store\n       def init\n         self.value = filesystem.label\n       end\n+\n+      # Validates uniqueness of the given label. The presence of the label is also\n+      # checked when the filesystem is set to be mounted by label.\n+      #\n+      # @note An error popup message is presented when it is needed.\n+      #\n+      # @return [Boolean]\n+      def validate\n+        presence_validation && uniqueness_validation\n+      end\n+\n+    private\n+\n+      # @return [Widgets::FstabOptions]\n+      attr_reader :parent_widget\n+\n+      # Checks whether a label is given when the filesystem is mounted by label\n+      #\n+      # @note An error popup is presented when the filesystem is mounted by label\n+      #   but a label is not given.\n+      #\n+      # @return [Boolean]\n+      def presence_validation\n+        return true unless mounted_by_label?\n+        return true unless value.empty?\n+\n+        # TRANSLATORS: Error messagge when the label is not given.\n+        Yast::Popup.Error(_(\"Provide a volume label to mount by label.\"))","path":"src/lib/y2partitioner/widgets/fstab_options.rb","position":106,"original_position":106,"commit_id":"8308b8089fe8421ecc5e73ae8c1fa356d0707293","original_commit_id":"8308b8089fe8421ecc5e73ae8c1fa356d0707293","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"Same than before again ;)","created_at":"2018-02-22T09:23:39Z","updated_at":"2018-02-22T09:23:39Z","html_url":"https://github.com/yast/yast-storage-ng/pull/529#discussion_r169895673","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/169895673"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/529#discussion_r169895673"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529"}},"in_reply_to_id":169804860},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529","id":169935074,"html_url":"https://github.com/yast/yast-storage-ng/pull/529","diff_url":"https://github.com/yast/yast-storage-ng/pull/529.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/529.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/529","number":529,"state":"open","locked":false,"title":"Set default mount_by","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"PBI: https://trello.com/c/rsjOOfOt/66-3-partitioner-settings-mount-by","created_at":"2018-02-19T11:20:28Z","updated_at":"2018-02-22T09:23:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a6d4d1435ef739ffff4173741e202c66cc4a7c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/529/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/8308b8089fe8421ecc5e73ae8c1fa356d0707293","head":{"label":"joseivanlopez:settings_mount_by","ref":"settings_mount_by","sha":"8308b8089fe8421ecc5e73ae8c1fa356d0707293","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"repo":{"id":81220643,"name":"yast-storage-ng","full_name":"joseivanlopez/yast-storage-ng","owner":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joseivanlopez/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":true,"url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng","forks_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/joseivanlopez/yast-storage-ng/deployments","created_at":"2017-02-07T15:04:53Z","updated_at":"2017-02-07T15:04:56Z","pushed_at":"2018-02-21T18:34:48Z","git_url":"git://github.com/joseivanlopez/yast-storage-ng.git","ssh_url":"git@github.com:joseivanlopez/yast-storage-ng.git","clone_url":"https://github.com/joseivanlopez/yast-storage-ng.git","svn_url":"https://github.com/joseivanlopez/yast-storage-ng","homepage":"http://yast.github.io/","size":4614,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"5ef18f15a77dfdc71fa23dddd66c9bf2fdeb3027","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-12-13T17:35:51Z","pushed_at":"2018-02-21T18:52:35Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":4573,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/529"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/529"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/8308b8089fe8421ecc5e73ae8c1fa356d0707293"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joseivanlopez"}}