{"action":"created","comment":{"url":"https://api.github.com/repos/WTW-IM/es-components/pulls/comments/237929721","pull_request_review_id":180356789,"id":237929721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzkyOTcyMQ==","diff_hunk":"@@ -1,28 +1,25 @@\n-/* eslint-disable no-confusing-arrow */\n-\n import React, { useState, useRef, useEffect } from 'react';\n import PropTypes from 'prop-types';\n import styled from 'styled-components';\n \n import Icon from '../../base/icons/Icon';\n import Button from '../../controls/buttons/Button';\n+import LinkButton from '../../controls/buttons/LinkButton';\n+import OutlineButton from '../../controls/buttons/OutlineButton';","path":"packages/es-components/src/components/containers/popover/Popover.js","position":null,"original_position":10,"commit_id":"604af909e15bfc83ee6a5d4fcabb6680fc4921e3","original_commit_id":"01f467518e9dece9b8d24fdf3fe04460e3d7375b","user":{"login":"Darrken","id":797074,"node_id":"MDQ6VXNlcjc5NzA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/797074?v=4","gravatar_id":"","url":"https://api.github.com/users/Darrken","html_url":"https://github.com/Darrken","followers_url":"https://api.github.com/users/Darrken/followers","following_url":"https://api.github.com/users/Darrken/following{/other_user}","gists_url":"https://api.github.com/users/Darrken/gists{/gist_id}","starred_url":"https://api.github.com/users/Darrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darrken/subscriptions","organizations_url":"https://api.github.com/users/Darrken/orgs","repos_url":"https://api.github.com/users/Darrken/repos","events_url":"https://api.github.com/users/Darrken/events{/privacy}","received_events_url":"https://api.github.com/users/Darrken/received_events","type":"User","site_admin":false},"body":"Okay, I've got Popover working with a render prop now. It seems slightly more tricky to use downstream, but it does simplify Popover quite a bit and gives a lot more flexibility. The doc samples should help too.","created_at":"2018-11-30T16:57:55Z","updated_at":"2018-11-30T16:57:55Z","html_url":"https://github.com/WTW-IM/es-components/pull/235#discussion_r237929721","pull_request_url":"https://api.github.com/repos/WTW-IM/es-components/pulls/235","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/comments/237929721"},"html":{"href":"https://github.com/WTW-IM/es-components/pull/235#discussion_r237929721"},"pull_request":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/235"}},"in_reply_to_id":237266576},"pull_request":{"url":"https://api.github.com/repos/WTW-IM/es-components/pulls/235","id":233977154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTc3MTU0","html_url":"https://github.com/WTW-IM/es-components/pull/235","diff_url":"https://github.com/WTW-IM/es-components/pull/235.diff","patch_url":"https://github.com/WTW-IM/es-components/pull/235.patch","issue_url":"https://api.github.com/repos/WTW-IM/es-components/issues/235","number":235,"state":"open","locked":false,"title":"Button Refactor","user":{"login":"Darrken","id":797074,"node_id":"MDQ6VXNlcjc5NzA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/797074?v=4","gravatar_id":"","url":"https://api.github.com/users/Darrken","html_url":"https://github.com/Darrken","followers_url":"https://api.github.com/users/Darrken/followers","following_url":"https://api.github.com/users/Darrken/following{/other_user}","gists_url":"https://api.github.com/users/Darrken/gists{/gist_id}","starred_url":"https://api.github.com/users/Darrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darrken/subscriptions","organizations_url":"https://api.github.com/users/Darrken/orgs","repos_url":"https://api.github.com/users/Darrken/repos","events_url":"https://api.github.com/users/Darrken/events{/privacy}","received_events_url":"https://api.github.com/users/Darrken/received_events","type":"User","site_admin":false},"body":"Splitting up Button into separate components. Also making some requisite changes to Dropdown and Toggle.","created_at":"2018-11-27T16:28:11Z","updated_at":"2018-11-30T16:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34b3cf5c602329c1b425d7dc97bcf68b5ea41974","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":777897456,"node_id":"MDU6TGFiZWw3Nzc4OTc0NTY=","url":"https://api.github.com/repos/WTW-IM/es-components/labels/Work%20In%20Progress","name":"Work In Progress","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WTW-IM/es-components/pulls/235/commits","review_comments_url":"https://api.github.com/repos/WTW-IM/es-components/pulls/235/comments","review_comment_url":"https://api.github.com/repos/WTW-IM/es-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WTW-IM/es-components/issues/235/comments","statuses_url":"https://api.github.com/repos/WTW-IM/es-components/statuses/604af909e15bfc83ee6a5d4fcabb6680fc4921e3","head":{"label":"Darrken:button-refactor","ref":"button-refactor","sha":"604af909e15bfc83ee6a5d4fcabb6680fc4921e3","user":{"login":"Darrken","id":797074,"node_id":"MDQ6VXNlcjc5NzA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/797074?v=4","gravatar_id":"","url":"https://api.github.com/users/Darrken","html_url":"https://github.com/Darrken","followers_url":"https://api.github.com/users/Darrken/followers","following_url":"https://api.github.com/users/Darrken/following{/other_user}","gists_url":"https://api.github.com/users/Darrken/gists{/gist_id}","starred_url":"https://api.github.com/users/Darrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darrken/subscriptions","organizations_url":"https://api.github.com/users/Darrken/orgs","repos_url":"https://api.github.com/users/Darrken/repos","events_url":"https://api.github.com/users/Darrken/events{/privacy}","received_events_url":"https://api.github.com/users/Darrken/received_events","type":"User","site_admin":false},"repo":{"id":88305900,"node_id":"MDEwOlJlcG9zaXRvcnk4ODMwNTkwMA==","name":"es-components","full_name":"Darrken/es-components","private":false,"owner":{"login":"Darrken","id":797074,"node_id":"MDQ6VXNlcjc5NzA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/797074?v=4","gravatar_id":"","url":"https://api.github.com/users/Darrken","html_url":"https://github.com/Darrken","followers_url":"https://api.github.com/users/Darrken/followers","following_url":"https://api.github.com/users/Darrken/following{/other_user}","gists_url":"https://api.github.com/users/Darrken/gists{/gist_id}","starred_url":"https://api.github.com/users/Darrken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darrken/subscriptions","organizations_url":"https://api.github.com/users/Darrken/orgs","repos_url":"https://api.github.com/users/Darrken/repos","events_url":"https://api.github.com/users/Darrken/events{/privacy}","received_events_url":"https://api.github.com/users/Darrken/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Darrken/es-components","description":"React components built for products in Exchange Solutions","fork":true,"url":"https://api.github.com/repos/Darrken/es-components","forks_url":"https://api.github.com/repos/Darrken/es-components/forks","keys_url":"https://api.github.com/repos/Darrken/es-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Darrken/es-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Darrken/es-components/teams","hooks_url":"https://api.github.com/repos/Darrken/es-components/hooks","issue_events_url":"https://api.github.com/repos/Darrken/es-components/issues/events{/number}","events_url":"https://api.github.com/repos/Darrken/es-components/events","assignees_url":"https://api.github.com/repos/Darrken/es-components/assignees{/user}","branches_url":"https://api.github.com/repos/Darrken/es-components/branches{/branch}","tags_url":"https://api.github.com/repos/Darrken/es-components/tags","blobs_url":"https://api.github.com/repos/Darrken/es-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Darrken/es-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Darrken/es-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Darrken/es-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Darrken/es-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Darrken/es-components/languages","stargazers_url":"https://api.github.com/repos/Darrken/es-components/stargazers","contributors_url":"https://api.github.com/repos/Darrken/es-components/contributors","subscribers_url":"https://api.github.com/repos/Darrken/es-components/subscribers","subscription_url":"https://api.github.com/repos/Darrken/es-components/subscription","commits_url":"https://api.github.com/repos/Darrken/es-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Darrken/es-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Darrken/es-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Darrken/es-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Darrken/es-components/contents/{+path}","compare_url":"https://api.github.com/repos/Darrken/es-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Darrken/es-components/merges","archive_url":"https://api.github.com/repos/Darrken/es-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Darrken/es-components/downloads","issues_url":"https://api.github.com/repos/Darrken/es-components/issues{/number}","pulls_url":"https://api.github.com/repos/Darrken/es-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Darrken/es-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Darrken/es-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Darrken/es-components/labels{/name}","releases_url":"https://api.github.com/repos/Darrken/es-components/releases{/id}","deployments_url":"https://api.github.com/repos/Darrken/es-components/deployments","created_at":"2017-04-14T21:51:21Z","updated_at":"2018-11-19T18:19:00Z","pushed_at":"2018-11-30T16:54:21Z","git_url":"git://github.com/Darrken/es-components.git","ssh_url":"git@github.com:Darrken/es-components.git","clone_url":"https://github.com/Darrken/es-components.git","svn_url":"https://github.com/Darrken/es-components","homepage":null,"size":19235,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WTW-IM:next","ref":"next","sha":"bcea3b53f7eba293b4191dbe625303921b6a99c8","user":{"login":"WTW-IM","id":11860511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwNTEx","avatar_url":"https://avatars3.githubusercontent.com/u/11860511?v=4","gravatar_id":"","url":"https://api.github.com/users/WTW-IM","html_url":"https://github.com/WTW-IM","followers_url":"https://api.github.com/users/WTW-IM/followers","following_url":"https://api.github.com/users/WTW-IM/following{/other_user}","gists_url":"https://api.github.com/users/WTW-IM/gists{/gist_id}","starred_url":"https://api.github.com/users/WTW-IM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WTW-IM/subscriptions","organizations_url":"https://api.github.com/users/WTW-IM/orgs","repos_url":"https://api.github.com/users/WTW-IM/repos","events_url":"https://api.github.com/users/WTW-IM/events{/privacy}","received_events_url":"https://api.github.com/users/WTW-IM/received_events","type":"Organization","site_admin":false},"repo":{"id":87821346,"node_id":"MDEwOlJlcG9zaXRvcnk4NzgyMTM0Ng==","name":"es-components","full_name":"WTW-IM/es-components","private":false,"owner":{"login":"WTW-IM","id":11860511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODYwNTEx","avatar_url":"https://avatars3.githubusercontent.com/u/11860511?v=4","gravatar_id":"","url":"https://api.github.com/users/WTW-IM","html_url":"https://github.com/WTW-IM","followers_url":"https://api.github.com/users/WTW-IM/followers","following_url":"https://api.github.com/users/WTW-IM/following{/other_user}","gists_url":"https://api.github.com/users/WTW-IM/gists{/gist_id}","starred_url":"https://api.github.com/users/WTW-IM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WTW-IM/subscriptions","organizations_url":"https://api.github.com/users/WTW-IM/orgs","repos_url":"https://api.github.com/users/WTW-IM/repos","events_url":"https://api.github.com/users/WTW-IM/events{/privacy}","received_events_url":"https://api.github.com/users/WTW-IM/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WTW-IM/es-components","description":"React components built for products in Exchange Solutions","fork":false,"url":"https://api.github.com/repos/WTW-IM/es-components","forks_url":"https://api.github.com/repos/WTW-IM/es-components/forks","keys_url":"https://api.github.com/repos/WTW-IM/es-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WTW-IM/es-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WTW-IM/es-components/teams","hooks_url":"https://api.github.com/repos/WTW-IM/es-components/hooks","issue_events_url":"https://api.github.com/repos/WTW-IM/es-components/issues/events{/number}","events_url":"https://api.github.com/repos/WTW-IM/es-components/events","assignees_url":"https://api.github.com/repos/WTW-IM/es-components/assignees{/user}","branches_url":"https://api.github.com/repos/WTW-IM/es-components/branches{/branch}","tags_url":"https://api.github.com/repos/WTW-IM/es-components/tags","blobs_url":"https://api.github.com/repos/WTW-IM/es-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WTW-IM/es-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WTW-IM/es-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/WTW-IM/es-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WTW-IM/es-components/statuses/{sha}","languages_url":"https://api.github.com/repos/WTW-IM/es-components/languages","stargazers_url":"https://api.github.com/repos/WTW-IM/es-components/stargazers","contributors_url":"https://api.github.com/repos/WTW-IM/es-components/contributors","subscribers_url":"https://api.github.com/repos/WTW-IM/es-components/subscribers","subscription_url":"https://api.github.com/repos/WTW-IM/es-components/subscription","commits_url":"https://api.github.com/repos/WTW-IM/es-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/WTW-IM/es-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/WTW-IM/es-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/WTW-IM/es-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/WTW-IM/es-components/contents/{+path}","compare_url":"https://api.github.com/repos/WTW-IM/es-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WTW-IM/es-components/merges","archive_url":"https://api.github.com/repos/WTW-IM/es-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WTW-IM/es-components/downloads","issues_url":"https://api.github.com/repos/WTW-IM/es-components/issues{/number}","pulls_url":"https://api.github.com/repos/WTW-IM/es-components/pulls{/number}","milestones_url":"https://api.github.com/repos/WTW-IM/es-components/milestones{/number}","notifications_url":"https://api.github.com/repos/WTW-IM/es-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WTW-IM/es-components/labels{/name}","releases_url":"https://api.github.com/repos/WTW-IM/es-components/releases{/id}","deployments_url":"https://api.github.com/repos/WTW-IM/es-components/deployments","created_at":"2017-04-10T14:34:48Z","updated_at":"2018-11-30T16:27:40Z","pushed_at":"2018-11-30T16:54:22Z","git_url":"git://github.com/WTW-IM/es-components.git","ssh_url":"git@github.com:WTW-IM/es-components.git","clone_url":"https://github.com/WTW-IM/es-components.git","svn_url":"https://github.com/WTW-IM/es-components","homepage":"https://wtw-im.github.io/es-components/","size":22263,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":9,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/235"},"html":{"href":"https://github.com/WTW-IM/es-components/pull/235"},"issue":{"href":"https://api.github.com/repos/WTW-IM/es-components/issues/235"},"comments":{"href":"https://api.github.com/repos/WTW-IM/es-components/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WTW-IM/es-components/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/WTW-IM/es-components/statuses/604af909e15bfc83ee6a5d4fcabb6680fc4921e3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Darrken"}}