{"action":"created","comment":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/170362399","pull_request_review_id":99045785,"id":170362399,"diff_hunk":"@@ -448,17 +416,19 @@ def __scp_string(files):\n                 scpstr = [\"scp\", \"-i\", self.database_identity_file]\n                 for file in files:\n                     scpstr.append(file)\n-                scpstr.append(\"%s@%s:~/\" % (self.database_user, self.database_host))\n+                scpstr.append(\"%s@%s:~/%s/\" % (self.database_user, self.database_host, database))\n                 return scpstr\n \n+            p = subprocess.Popen(self.database_ssh_string, shell=True, stdin=subprocess.PIPE, stdout=self.quiet_out, stderr=subprocess.STDOUT)\n+            p.communicate(\"mkdir -p %s\" % database)\n             dbpath = os.path.join(self.fwroot, \"toolset\", \"setup\", \"linux\", \"docker\", \"databases\", database)\n             dbfiles = \"\"\n             for dbfile in os.listdir(dbpath):\n                 dbfiles += \"%s \" % os.path.join(dbpath,dbfile)\n             p = subprocess.Popen(__scp_string(dbfiles.split()), stdin=subprocess.PIPE, stdout=self.quiet_out, stderr=subprocess.STDOUT)\n             p.communicate()\n             p = subprocess.Popen(self.database_ssh_string, shell=True, stdin=subprocess.PIPE, stdout=self.quiet_out, stderr=subprocess.STDOUT)\n-            p.communicate(\"docker build -f ~/%s.dockerfile -t %s ~/\" % (database, database))\n+            p.communicate(\"docker build -f ~/%s/%s.dockerfile -t %s ~/%s\" % (database, database, database, database))","path":"toolset/benchmark/benchmarker.py","position":57,"original_position":57,"commit_id":"509eadfb55ce00a0c1b0dda65b772f996f318676","original_commit_id":"509eadfb55ce00a0c1b0dda65b772f996f318676","user":{"login":"msmith-techempower","id":4983416,"avatar_url":"https://avatars2.githubusercontent.com/u/4983416?v=4","gravatar_id":"","url":"https://api.github.com/users/msmith-techempower","html_url":"https://github.com/msmith-techempower","followers_url":"https://api.github.com/users/msmith-techempower/followers","following_url":"https://api.github.com/users/msmith-techempower/following{/other_user}","gists_url":"https://api.github.com/users/msmith-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/msmith-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmith-techempower/subscriptions","organizations_url":"https://api.github.com/users/msmith-techempower/orgs","repos_url":"https://api.github.com/users/msmith-techempower/repos","events_url":"https://api.github.com/users/msmith-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/msmith-techempower/received_events","type":"User","site_admin":false},"body":"This is probably the funniest line ever in a commit.","created_at":"2018-02-23T20:41:54Z","updated_at":"2018-02-23T20:41:54Z","html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330#discussion_r170362399","pull_request_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments/170362399"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330#discussion_r170362399"},"pull_request":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330"}}},"pull_request":{"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330","id":171111406,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330","diff_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330.diff","patch_url":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330.patch","issue_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3330","number":3330,"state":"open","locked":false,"title":"Put databases into a folder","user":{"login":"msmith-techempower","id":4983416,"avatar_url":"https://avatars2.githubusercontent.com/u/4983416?v=4","gravatar_id":"","url":"https://api.github.com/users/msmith-techempower","html_url":"https://github.com/msmith-techempower","followers_url":"https://api.github.com/users/msmith-techempower/followers","following_url":"https://api.github.com/users/msmith-techempower/following{/other_user}","gists_url":"https://api.github.com/users/msmith-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/msmith-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmith-techempower/subscriptions","organizations_url":"https://api.github.com/users/msmith-techempower/orgs","repos_url":"https://api.github.com/users/msmith-techempower/repos","events_url":"https://api.github.com/users/msmith-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/msmith-techempower/received_events","type":"User","site_admin":false},"body":"This will ensure the docker context at built time does NOT include FrameworkBenchmarks (or anything else at `~/`)\r\n\r\nAlso, removed two functions that have not been called in literally 5 years.","created_at":"2018-02-23T20:41:23Z","updated_at":"2018-02-23T20:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d404d79a3dd1768d77e784fd92c76f919766448f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330/commits","review_comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330/comments","review_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3330/comments","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/509eadfb55ce00a0c1b0dda65b772f996f318676","head":{"label":"msmith-techempower:docker","ref":"docker","sha":"509eadfb55ce00a0c1b0dda65b772f996f318676","user":{"login":"msmith-techempower","id":4983416,"avatar_url":"https://avatars2.githubusercontent.com/u/4983416?v=4","gravatar_id":"","url":"https://api.github.com/users/msmith-techempower","html_url":"https://github.com/msmith-techempower","followers_url":"https://api.github.com/users/msmith-techempower/followers","following_url":"https://api.github.com/users/msmith-techempower/following{/other_user}","gists_url":"https://api.github.com/users/msmith-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/msmith-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmith-techempower/subscriptions","organizations_url":"https://api.github.com/users/msmith-techempower/orgs","repos_url":"https://api.github.com/users/msmith-techempower/repos","events_url":"https://api.github.com/users/msmith-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/msmith-techempower/received_events","type":"User","site_admin":false},"repo":{"id":22895496,"name":"FrameworkBenchmarks","full_name":"msmith-techempower/FrameworkBenchmarks","owner":{"login":"msmith-techempower","id":4983416,"avatar_url":"https://avatars2.githubusercontent.com/u/4983416?v=4","gravatar_id":"","url":"https://api.github.com/users/msmith-techempower","html_url":"https://github.com/msmith-techempower","followers_url":"https://api.github.com/users/msmith-techempower/followers","following_url":"https://api.github.com/users/msmith-techempower/following{/other_user}","gists_url":"https://api.github.com/users/msmith-techempower/gists{/gist_id}","starred_url":"https://api.github.com/users/msmith-techempower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmith-techempower/subscriptions","organizations_url":"https://api.github.com/users/msmith-techempower/orgs","repos_url":"https://api.github.com/users/msmith-techempower/repos","events_url":"https://api.github.com/users/msmith-techempower/events{/privacy}","received_events_url":"https://api.github.com/users/msmith-techempower/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msmith-techempower/FrameworkBenchmarks","description":"Source code for the framework benchmarking project","fork":true,"url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/msmith-techempower/FrameworkBenchmarks/deployments","created_at":"2014-08-12T23:12:11Z","updated_at":"2018-02-06T21:48:02Z","pushed_at":"2018-02-23T20:38:44Z","git_url":"git://github.com/msmith-techempower/FrameworkBenchmarks.git","ssh_url":"git@github.com:msmith-techempower/FrameworkBenchmarks.git","clone_url":"https://github.com/msmith-techempower/FrameworkBenchmarks.git","svn_url":"https://github.com/msmith-techempower/FrameworkBenchmarks","homepage":"http://www.techempower.com/benchmarks/","size":270044,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"TechEmpower:docker","ref":"docker","sha":"661059a87b3b392115b58dd6d8d31595183d7181","user":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"repo":{"id":8957264,"name":"FrameworkBenchmarks","full_name":"TechEmpower/FrameworkBenchmarks","owner":{"login":"TechEmpower","id":3910062,"avatar_url":"https://avatars2.githubusercontent.com/u/3910062?v=4","gravatar_id":"","url":"https://api.github.com/users/TechEmpower","html_url":"https://github.com/TechEmpower","followers_url":"https://api.github.com/users/TechEmpower/followers","following_url":"https://api.github.com/users/TechEmpower/following{/other_user}","gists_url":"https://api.github.com/users/TechEmpower/gists{/gist_id}","starred_url":"https://api.github.com/users/TechEmpower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechEmpower/subscriptions","organizations_url":"https://api.github.com/users/TechEmpower/orgs","repos_url":"https://api.github.com/users/TechEmpower/repos","events_url":"https://api.github.com/users/TechEmpower/events{/privacy}","received_events_url":"https://api.github.com/users/TechEmpower/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TechEmpower/FrameworkBenchmarks","description":"Source for the TechEmpower Framework Benchmarks project","fork":false,"url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks","forks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/forks","keys_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/teams","hooks_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/hooks","issue_events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/events{/number}","events_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/events","assignees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/assignees{/user}","branches_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/branches{/branch}","tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/tags","blobs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/{sha}","languages_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/languages","stargazers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/stargazers","contributors_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contributors","subscribers_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscribers","subscription_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/subscription","commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/contents/{+path}","compare_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/merges","archive_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/downloads","issues_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues{/number}","pulls_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls{/number}","milestones_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/milestones{/number}","notifications_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/labels{/name}","releases_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/releases{/id}","deployments_url":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/deployments","created_at":"2013-03-22T17:33:54Z","updated_at":"2018-02-23T03:54:29Z","pushed_at":"2018-02-23T20:41:24Z","git_url":"git://github.com/TechEmpower/FrameworkBenchmarks.git","ssh_url":"git@github.com:TechEmpower/FrameworkBenchmarks.git","clone_url":"https://github.com/TechEmpower/FrameworkBenchmarks.git","svn_url":"https://github.com/TechEmpower/FrameworkBenchmarks","homepage":"https://www.techempower.com/benchmarks/","size":270372,"stargazers_count":3061,"watchers_count":3061,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1015,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1015,"open_issues":27,"watchers":3061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330"},"html":{"href":"https://github.com/TechEmpower/FrameworkBenchmarks/pull/3330"},"issue":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3330"},"comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/issues/3330/comments"},"review_comments":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330/comments"},"review_comment":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/pulls/3330/commits"},"statuses":{"href":"https://api.github.com/repos/TechEmpower/FrameworkBenchmarks/statuses/509eadfb55ce00a0c1b0dda65b772f996f318676"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"msmith-techempower"}}