{"action":"created","comment":{"url":"https://api.github.com/repos/systers/vms/pulls/comments/199311014","pull_request_review_id":133413280,"id":199311014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMxMTAxNA==","diff_hunk":"@@ -204,119 +233,127 @@ def test_jobs_page_with_no_jobs(self):\n     def test_assign_shifts_with_no_shifts(self):\n         sign_up_page = self.sign_up_page\n         manage_shift_page = self.manage_shift_page\n-        self.manage_shift_page.live_server_url = self.live_server_url\n+        manage_shift_page.live_server_url = self.live_server_url\n \n-        # register volunteers\n-        v1 = create_volunteer_with_details(self.volunteer_1)\n+        # Register volunteers\n+        volunteer_1 = create_volunteer_with_details(self.volunteer_1)\n \n-        # create events\n+        # Create events\n         event = ['event-name', '2017-05-20', '2017-05-20']\n-        e1 = create_event_with_details(event)\n+        event_1 = create_event_with_details(event)\n \n-        # create jobs\n-        job = ['job name', '2017-05-20', '2017-05-20', 'job description', e1]\n-        j1 = create_job_with_details(job)\n+        # Create jobs\n+        job = ['job name', '2017-05-20', '2017-05-20', 'job description', event_1]\n+        job_1 = create_job_with_details(job)\n \n-        # open manage volunteer shift\n+        self.wait_for_home_page()\n+\n+        # Open manage volunteer shift\n         manage_shift_page.navigate_to_manage_shift_page()\n         manage_shift_page.select_volunteer(1)\n         manage_shift_page.assign_shift()\n \n-        # no events shown in table\n+        # No events shown in table\n         self.assertEqual(sign_up_page.get_info_box().text,\n                          sign_up_page.no_event_message)\n \n     def test_assign_shifts_with_registered_shifts(self):\n         sign_up_page = self.sign_up_page\n         manage_shift_page = self.manage_shift_page\n-        self.manage_shift_page.live_server_url = self.live_server_url\n+        manage_shift_page.live_server_url = self.live_server_url\n \n-        # register volunteers\n-        v1 = create_volunteer_with_details(self.volunteer_1)\n+        # Register volunteers\n+        volunteer_1 = create_volunteer_with_details(self.volunteer_1)\n \n         shift = ['09:00', '15:00', '1']\n-        s1 = self.create_shift(shift)\n+        shift_1 = self.create_shift(shift)\n+\n+        self.wait_for_home_page()\n \n-        # volunteer-one does not have any registered shifts\n+        # Volunteer-one does not have any registered shifts\n         manage_shift_page.navigate_to_manage_shift_page()\n         manage_shift_page.select_volunteer(1)\n         self.assertEqual(manage_shift_page.get_info_box(),\n                          manage_shift_page.no_volunteer_shift_message)\n \n         manage_shift_page.assign_shift()\n \n-        # events shown in table\n-        with self.assertRaises(NoSuchElementException):\n-            sign_up_page.get_info_box()\n+        # Events shown in table\n+        self.assertRaisesRegexp(NoSuchElementException,\n+                                'Unable to locate element: .alert-info',\n+                                sign_up_page.get_info_box)\n         manage_shift_page.navigate_to_shift_assignment_page()\n \n-        # confirm on shift assignment to volunteer-one\n+        # Confirm on shift assignment to volunteer-one\n         manage_shift_page.submit_form()\n-        with self.assertRaises(NoSuchElementException):\n-            sign_up_page.get_danger_box()\n+        self.assertRaisesRegexp(NoSuchElementException,\n+                                'Unable to locate element: .alert-danger',\n+                                sign_up_page.get_danger_box)\n \n-        # check shift assignment to volunteer-one\n+        # Check shift assignment to volunteer-one\n         manage_shift_page.navigate_to_manage_shift_page()\n         manage_shift_page.select_volunteer(1)\n         self.check_job_details(\n-            ['job name', 'May 20, 2017', '9 a.m.', '3 p.m.'])\n-\n-        # database check to ensure volunteer has been assigned the shift\n-        self.assertEqual(len(VolunteerShift.objects.all()), 1)\n-        self.assertNotEqual(\n-            len(\n-                VolunteerShift.objects.filter(\n-                    volunteer_id=v1.id, shift_id=s1.id)), 0)\n+            ['job name', 'May 20, 2050', '9 a.m.', '3 p.m.'])\n+ ","path":"vms/shift/tests/test_manageVolunteerShift.py","position":330,"original_position":330,"commit_id":"6f9c10901520a4fab8a97437c0451ae31d3d7952","original_commit_id":"6f9c10901520a4fab8a97437c0451ae31d3d7952","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Trailing whitespace](https://app.codacy.com/app/Systers/vms/pullRequest?prid=1746665)","created_at":"2018-06-30T02:52:40Z","updated_at":"2018-06-30T02:52:40Z","html_url":"https://github.com/systers/vms/pull/716#discussion_r199311014","pull_request_url":"https://api.github.com/repos/systers/vms/pulls/716","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/comments/199311014"},"html":{"href":"https://github.com/systers/vms/pull/716#discussion_r199311014"},"pull_request":{"href":"https://api.github.com/repos/systers/vms/pulls/716"}}},"pull_request":{"url":"https://api.github.com/repos/systers/vms/pulls/716","id":193121419,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTIxNDE5","html_url":"https://github.com/systers/vms/pull/716","diff_url":"https://github.com/systers/vms/pull/716.diff","patch_url":"https://github.com/systers/vms/pull/716.patch","issue_url":"https://api.github.com/repos/systers/vms/issues/716","number":716,"state":"open","locked":false,"title":"Email Notification for volunteers","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"body":"# Description\r\nThe volunteers are notified by an email whenever a shift has been assigned to them or it is cancelled.\r\n\r\nFixes #714 \r\n\r\n# Type of Change:\r\n- Code\r\n\r\n**Code/Quality Assurance Only**\r\n- New feature (non-breaking change which adds functionality pre-approved by mentors)\r\n\r\n# How Has This Been Tested?\r\n![image](https://user-images.githubusercontent.com/22369767/41205667-49f560d0-6d15-11e8-992e-2f72f275c62f.png)\r\n\r\n# Checklist:\r\n- [x] My PR follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code or materials\r\n- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n- [x] I have made corresponding changes to the documentation\r\n- [x] Any dependent changes have been merged \r\n\r\n**Code/Quality Assurance Only**\r\n- [x] My changes generate no new warnings \r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] Any dependent changes have been published in downstream modules\r\n","created_at":"2018-06-06T19:49:25Z","updated_at":"2018-06-30T02:52:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a64f6195640e79d0c8471dc6ea68ea26a4ea9ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":779157433,"node_id":"MDU6TGFiZWw3NzkxNTc0MzM=","url":"https://api.github.com/repos/systers/vms/labels/Category:%20Coding","name":"Category: Coding","color":"005c88","default":false},{"id":779159474,"node_id":"MDU6TGFiZWw3NzkxNTk0NzQ=","url":"https://api.github.com/repos/systers/vms/labels/Program:%20GSoC","name":"Program: GSoC","color":"fac07e","default":false},{"id":94268591,"node_id":"MDU6TGFiZWw5NDI2ODU5MQ==","url":"https://api.github.com/repos/systers/vms/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"f6b2cf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systers/vms/pulls/716/commits","review_comments_url":"https://api.github.com/repos/systers/vms/pulls/716/comments","review_comment_url":"https://api.github.com/repos/systers/vms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/vms/issues/716/comments","statuses_url":"https://api.github.com/repos/systers/vms/statuses/6f9c10901520a4fab8a97437c0451ae31d3d7952","head":{"label":"anjali-dhanuka:notify_volunteers","ref":"notify_volunteers","sha":"6f9c10901520a4fab8a97437c0451ae31d3d7952","user":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"repo":{"id":113863490,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4NjM0OTA=","name":"vms","full_name":"anjali-dhanuka/vms","owner":{"login":"anjali-dhanuka","id":22369767,"node_id":"MDQ6VXNlcjIyMzY5NzY3","avatar_url":"https://avatars3.githubusercontent.com/u/22369767?v=4","gravatar_id":"","url":"https://api.github.com/users/anjali-dhanuka","html_url":"https://github.com/anjali-dhanuka","followers_url":"https://api.github.com/users/anjali-dhanuka/followers","following_url":"https://api.github.com/users/anjali-dhanuka/following{/other_user}","gists_url":"https://api.github.com/users/anjali-dhanuka/gists{/gist_id}","starred_url":"https://api.github.com/users/anjali-dhanuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjali-dhanuka/subscriptions","organizations_url":"https://api.github.com/users/anjali-dhanuka/orgs","repos_url":"https://api.github.com/users/anjali-dhanuka/repos","events_url":"https://api.github.com/users/anjali-dhanuka/events{/privacy}","received_events_url":"https://api.github.com/users/anjali-dhanuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anjali-dhanuka/vms","description":"Volunteer Management System","fork":true,"url":"https://api.github.com/repos/anjali-dhanuka/vms","forks_url":"https://api.github.com/repos/anjali-dhanuka/vms/forks","keys_url":"https://api.github.com/repos/anjali-dhanuka/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anjali-dhanuka/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anjali-dhanuka/vms/teams","hooks_url":"https://api.github.com/repos/anjali-dhanuka/vms/hooks","issue_events_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/events{/number}","events_url":"https://api.github.com/repos/anjali-dhanuka/vms/events","assignees_url":"https://api.github.com/repos/anjali-dhanuka/vms/assignees{/user}","branches_url":"https://api.github.com/repos/anjali-dhanuka/vms/branches{/branch}","tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/tags","blobs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anjali-dhanuka/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/anjali-dhanuka/vms/languages","stargazers_url":"https://api.github.com/repos/anjali-dhanuka/vms/stargazers","contributors_url":"https://api.github.com/repos/anjali-dhanuka/vms/contributors","subscribers_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscribers","subscription_url":"https://api.github.com/repos/anjali-dhanuka/vms/subscription","commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/anjali-dhanuka/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/anjali-dhanuka/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/anjali-dhanuka/vms/contents/{+path}","compare_url":"https://api.github.com/repos/anjali-dhanuka/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anjali-dhanuka/vms/merges","archive_url":"https://api.github.com/repos/anjali-dhanuka/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anjali-dhanuka/vms/downloads","issues_url":"https://api.github.com/repos/anjali-dhanuka/vms/issues{/number}","pulls_url":"https://api.github.com/repos/anjali-dhanuka/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/anjali-dhanuka/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/anjali-dhanuka/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anjali-dhanuka/vms/labels{/name}","releases_url":"https://api.github.com/repos/anjali-dhanuka/vms/releases{/id}","deployments_url":"https://api.github.com/repos/anjali-dhanuka/vms/deployments","created_at":"2017-12-11T13:39:21Z","updated_at":"2018-04-07T17:17:20Z","pushed_at":"2018-06-30T02:49:13Z","git_url":"git://github.com/anjali-dhanuka/vms.git","ssh_url":"git@github.com:anjali-dhanuka/vms.git","clone_url":"https://github.com/anjali-dhanuka/vms.git","svn_url":"https://github.com/anjali-dhanuka/vms","homepage":null,"size":3020,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:gsoc18-code","ref":"gsoc18-code","sha":"8c724eaf6a9396fd0890d67558d8ff8cc4093a12","user":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":19032264,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzMjI2NA==","name":"vms","full_name":"systers/vms","owner":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systers/vms","description":"Volunteer Management System","fork":false,"url":"https://api.github.com/repos/systers/vms","forks_url":"https://api.github.com/repos/systers/vms/forks","keys_url":"https://api.github.com/repos/systers/vms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/vms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/vms/teams","hooks_url":"https://api.github.com/repos/systers/vms/hooks","issue_events_url":"https://api.github.com/repos/systers/vms/issues/events{/number}","events_url":"https://api.github.com/repos/systers/vms/events","assignees_url":"https://api.github.com/repos/systers/vms/assignees{/user}","branches_url":"https://api.github.com/repos/systers/vms/branches{/branch}","tags_url":"https://api.github.com/repos/systers/vms/tags","blobs_url":"https://api.github.com/repos/systers/vms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/vms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/vms/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/vms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/vms/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/vms/languages","stargazers_url":"https://api.github.com/repos/systers/vms/stargazers","contributors_url":"https://api.github.com/repos/systers/vms/contributors","subscribers_url":"https://api.github.com/repos/systers/vms/subscribers","subscription_url":"https://api.github.com/repos/systers/vms/subscription","commits_url":"https://api.github.com/repos/systers/vms/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/vms/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/vms/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/vms/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/vms/contents/{+path}","compare_url":"https://api.github.com/repos/systers/vms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/vms/merges","archive_url":"https://api.github.com/repos/systers/vms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/vms/downloads","issues_url":"https://api.github.com/repos/systers/vms/issues{/number}","pulls_url":"https://api.github.com/repos/systers/vms/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/vms/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/vms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/vms/labels{/name}","releases_url":"https://api.github.com/repos/systers/vms/releases{/id}","deployments_url":"https://api.github.com/repos/systers/vms/deployments","created_at":"2014-04-22T14:13:57Z","updated_at":"2018-06-28T10:48:54Z","pushed_at":"2018-06-30T02:49:15Z","git_url":"git://github.com/systers/vms.git","ssh_url":"git@github.com:systers/vms.git","clone_url":"https://github.com/systers/vms.git","svn_url":"https://github.com/systers/vms","homepage":"http://52.8.110.63/","size":2877,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":149,"open_issues":92,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/vms/pulls/716"},"html":{"href":"https://github.com/systers/vms/pull/716"},"issue":{"href":"https://api.github.com/repos/systers/vms/issues/716"},"comments":{"href":"https://api.github.com/repos/systers/vms/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/vms/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/vms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/vms/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/systers/vms/statuses/6f9c10901520a4fab8a97437c0451ae31d3d7952"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codacy-bot"}}