{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/gscan/pulls/comments/205056950","pull_request_review_id":140249326,"id":205056950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTA1Njk1MA==","diff_hunk":"@@ -48,9 +48,14 @@ app.post('/',\n             path: req.file.path,\n             name: req.file.originalname\n         };\n+        var options = {\n+            checkVersion: req.body.version || 'v2'","path":"app/index.js","position":5,"original_position":5,"commit_id":"a3f6a75261340e5fed3557325281fbe7d7efa2b8","original_commit_id":"a3f6a75261340e5fed3557325281fbe7d7efa2b8","user":{"login":"AileenCGN","id":8037602,"node_id":"MDQ6VXNlcjgwMzc2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/8037602?v=4","gravatar_id":"","url":"https://api.github.com/users/AileenCGN","html_url":"https://github.com/AileenCGN","followers_url":"https://api.github.com/users/AileenCGN/followers","following_url":"https://api.github.com/users/AileenCGN/following{/other_user}","gists_url":"https://api.github.com/users/AileenCGN/gists{/gist_id}","starred_url":"https://api.github.com/users/AileenCGN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AileenCGN/subscriptions","organizations_url":"https://api.github.com/users/AileenCGN/orgs","repos_url":"https://api.github.com/users/AileenCGN/repos","events_url":"https://api.github.com/users/AileenCGN/events{/privacy}","received_events_url":"https://api.github.com/users/AileenCGN/received_events","type":"User","site_admin":false},"body":"> But it would be nice to have it globally defined somewhere, so we don't need to change it in x places.\r\n\r\nYeah, that was my intention behind this. Will look where we can do this.","created_at":"2018-07-25T10:20:42Z","updated_at":"2018-07-25T10:20:43Z","html_url":"https://github.com/TryGhost/gscan/pull/118#discussion_r205056950","pull_request_url":"https://api.github.com/repos/TryGhost/gscan/pulls/118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/comments/205056950"},"html":{"href":"https://github.com/TryGhost/gscan/pull/118#discussion_r205056950"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/118"}},"in_reply_to_id":205051993},"pull_request":{"url":"https://api.github.com/repos/TryGhost/gscan/pulls/118","id":203704424,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzA0NDI0","html_url":"https://github.com/TryGhost/gscan/pull/118","diff_url":"https://github.com/TryGhost/gscan/pull/118.diff","patch_url":"https://github.com/TryGhost/gscan/pull/118.patch","issue_url":"https://api.github.com/repos/TryGhost/gscan/issues/118","number":118,"state":"open","locked":false,"title":"[WIP] ✨Allow GScan to scan different versions","user":{"login":"AileenCGN","id":8037602,"node_id":"MDQ6VXNlcjgwMzc2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/8037602?v=4","gravatar_id":"","url":"https://api.github.com/users/AileenCGN","html_url":"https://github.com/AileenCGN","followers_url":"https://api.github.com/users/AileenCGN/followers","following_url":"https://api.github.com/users/AileenCGN/following{/other_user}","gists_url":"https://api.github.com/users/AileenCGN/gists{/gist_id}","starred_url":"https://api.github.com/users/AileenCGN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AileenCGN/subscriptions","organizations_url":"https://api.github.com/users/AileenCGN/orgs","repos_url":"https://api.github.com/users/AileenCGN/repos","events_url":"https://api.github.com/users/AileenCGN/events{/privacy}","received_events_url":"https://api.github.com/users/AileenCGN/received_events","type":"User","site_admin":false},"body":"closes #116\r\n\r\n- CLI\r\n    - Added `-1, --v1` option to allow cli usage of GScan to check for 1.0 theme compatibility\r\n    - Pass `options` that includes a `checkVersion` property, which is set to `v1` when cli called with `-1`, or `v2` by default.\r\n- Restructure current specs\r\n    - create a new `/specs` directory\r\n    - rename current `spec.js` to `v1.js`\r\n    - duplicate current `spec.js` to `v2.js` -> will contain only differences later\r\n- App\r\n    - Offer a select box with the - currently - two accepted versions, whereas the latest is set to default\r\n    - Pass the selected version to gscan\r\n- Checks\r\n    - move checks properties (regex, helpername, cssclass) to the rules in spec\r\n    - use list of rules to specify which rules have to run for each version (concat them with `_.union`, if applicable)\r\n    - require the version of the spec that we need for the checks\r\n\r\n----\r\n\r\nTodos:\r\n- [ ] Tidy up CSS for new `select` option\r\n- [ ] Update text for new version in `index.hbs`\r\n- [ ] Refactor specs to use two versions\r\n    - [x] 001 deprecations\r\n    - [x] 002 comment_id\r\n    - [x] 005 template compiler\r\n    - [ ] 010 package.json\r\n    - [x] 020 theme structure\r\n    - [x] 030 assets\r\n    - [x] 040 ghost head and foot\r\n- [ ] Update v2 rules to only contain differences to v1","created_at":"2018-07-25T02:30:04Z","updated_at":"2018-07-25T10:20:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"891ecaad94f5afc66a7b31fa903574320ebef3cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/gscan/pulls/118/commits","review_comments_url":"https://api.github.com/repos/TryGhost/gscan/pulls/118/comments","review_comment_url":"https://api.github.com/repos/TryGhost/gscan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/gscan/issues/118/comments","statuses_url":"https://api.github.com/repos/TryGhost/gscan/statuses/a3f6a75261340e5fed3557325281fbe7d7efa2b8","head":{"label":"TryGhost:2.0","ref":"2.0","sha":"a3f6a75261340e5fed3557325281fbe7d7efa2b8","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":24979466,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk3OTQ2Ng==","name":"gscan","full_name":"TryGhost/gscan","owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/gscan","description":"Ghost theme scanner - checks for errors and feature support","fork":false,"url":"https://api.github.com/repos/TryGhost/gscan","forks_url":"https://api.github.com/repos/TryGhost/gscan/forks","keys_url":"https://api.github.com/repos/TryGhost/gscan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/gscan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/gscan/teams","hooks_url":"https://api.github.com/repos/TryGhost/gscan/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/gscan/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/gscan/events","assignees_url":"https://api.github.com/repos/TryGhost/gscan/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/gscan/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/gscan/tags","blobs_url":"https://api.github.com/repos/TryGhost/gscan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/gscan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/gscan/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/gscan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/gscan/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/gscan/languages","stargazers_url":"https://api.github.com/repos/TryGhost/gscan/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/gscan/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/gscan/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/gscan/subscription","commits_url":"https://api.github.com/repos/TryGhost/gscan/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/gscan/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/gscan/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/gscan/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/gscan/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/gscan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/gscan/merges","archive_url":"https://api.github.com/repos/TryGhost/gscan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/gscan/downloads","issues_url":"https://api.github.com/repos/TryGhost/gscan/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/gscan/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/gscan/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/gscan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/gscan/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/gscan/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/gscan/deployments","created_at":"2014-10-09T08:05:01Z","updated_at":"2018-07-25T04:40:33Z","pushed_at":"2018-07-25T09:56:43Z","git_url":"git://github.com/TryGhost/gscan.git","ssh_url":"git@github.com:TryGhost/gscan.git","clone_url":"https://github.com/TryGhost/gscan.git","svn_url":"https://github.com/TryGhost/gscan","homepage":"http://gscan.ghost.org","size":362,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":28,"watchers":26,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"087a4b278fe6c7926b5b3b4ee292a7b30036e663","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":24979466,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk3OTQ2Ng==","name":"gscan","full_name":"TryGhost/gscan","owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/gscan","description":"Ghost theme scanner - checks for errors and feature support","fork":false,"url":"https://api.github.com/repos/TryGhost/gscan","forks_url":"https://api.github.com/repos/TryGhost/gscan/forks","keys_url":"https://api.github.com/repos/TryGhost/gscan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/gscan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/gscan/teams","hooks_url":"https://api.github.com/repos/TryGhost/gscan/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/gscan/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/gscan/events","assignees_url":"https://api.github.com/repos/TryGhost/gscan/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/gscan/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/gscan/tags","blobs_url":"https://api.github.com/repos/TryGhost/gscan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/gscan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/gscan/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/gscan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/gscan/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/gscan/languages","stargazers_url":"https://api.github.com/repos/TryGhost/gscan/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/gscan/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/gscan/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/gscan/subscription","commits_url":"https://api.github.com/repos/TryGhost/gscan/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/gscan/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/gscan/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/gscan/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/gscan/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/gscan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/gscan/merges","archive_url":"https://api.github.com/repos/TryGhost/gscan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/gscan/downloads","issues_url":"https://api.github.com/repos/TryGhost/gscan/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/gscan/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/gscan/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/gscan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/gscan/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/gscan/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/gscan/deployments","created_at":"2014-10-09T08:05:01Z","updated_at":"2018-07-25T04:40:33Z","pushed_at":"2018-07-25T09:56:43Z","git_url":"git://github.com/TryGhost/gscan.git","ssh_url":"git@github.com:TryGhost/gscan.git","clone_url":"https://github.com/TryGhost/gscan.git","svn_url":"https://github.com/TryGhost/gscan","homepage":"http://gscan.ghost.org","size":362,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":28,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/118"},"html":{"href":"https://github.com/TryGhost/gscan/pull/118"},"issue":{"href":"https://api.github.com/repos/TryGhost/gscan/issues/118"},"comments":{"href":"https://api.github.com/repos/TryGhost/gscan/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/gscan/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/gscan/statuses/a3f6a75261340e5fed3557325281fbe7d7efa2b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AileenCGN"}}