{"action":"created","issue":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2109","repository_url":"https://api.github.com/repos/lightningnetwork/lnd","labels_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2109/labels{/name}","comments_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2109/comments","events_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2109/events","html_url":"https://github.com/lightningnetwork/lnd/pull/2109","id":374685329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzIxNDg5","number":2109,"title":"config+rpcserver: adding a Private field to enable private nodes","user":{"login":"ccdle12","id":18324680,"node_id":"MDQ6VXNlcjE4MzI0Njgw","avatar_url":"https://avatars2.githubusercontent.com/u/18324680?v=4","gravatar_id":"","url":"https://api.github.com/users/ccdle12","html_url":"https://github.com/ccdle12","followers_url":"https://api.github.com/users/ccdle12/followers","following_url":"https://api.github.com/users/ccdle12/following{/other_user}","gists_url":"https://api.github.com/users/ccdle12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccdle12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccdle12/subscriptions","organizations_url":"https://api.github.com/users/ccdle12/orgs","repos_url":"https://api.github.com/users/ccdle12/repos","events_url":"https://api.github.com/users/ccdle12/events{/privacy}","received_events_url":"https://api.github.com/users/ccdle12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-27T20:26:01Z","updated_at":"2018-10-28T23:08:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lnd/pulls/2109","html_url":"https://github.com/lightningnetwork/lnd/pull/2109","diff_url":"https://github.com/lightningnetwork/lnd/pull/2109.diff","patch_url":"https://github.com/lightningnetwork/lnd/pull/2109.patch"},"body":"In this PR, we add a Private field in `config.go` to allow a node to \r\ncreate private channels by default and deploy a private node.\r\n \r\nThis also adds a check in `rpcserver.go` when `OpenChannel()` \r\nis called, to see if the Private field was set in the configuration.\r\nIf the field was set, then the channel will be created as private.\r\n\r\nThis will also prevent the private node from forwarding HTLCs \r\nunless the HTLC is meant for a node on the private channel.\r\n\r\nFixes #1298"},"comment":{"url":"https://api.github.com/repos/lightningnetwork/lnd/issues/comments/433751180","html_url":"https://github.com/lightningnetwork/lnd/pull/2109#issuecomment-433751180","issue_url":"https://api.github.com/repos/lightningnetwork/lnd/issues/2109","id":433751180,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzc1MTE4MA==","user":{"login":"Roasbeef","id":998190,"node_id":"MDQ6VXNlcjk5ODE5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/998190?v=4","gravatar_id":"","url":"https://api.github.com/users/Roasbeef","html_url":"https://github.com/Roasbeef","followers_url":"https://api.github.com/users/Roasbeef/followers","following_url":"https://api.github.com/users/Roasbeef/following{/other_user}","gists_url":"https://api.github.com/users/Roasbeef/gists{/gist_id}","starred_url":"https://api.github.com/users/Roasbeef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roasbeef/subscriptions","organizations_url":"https://api.github.com/users/Roasbeef/orgs","repos_url":"https://api.github.com/users/Roasbeef/repos","events_url":"https://api.github.com/users/Roasbeef/events{/privacy}","received_events_url":"https://api.github.com/users/Roasbeef/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T23:08:23Z","updated_at":"2018-10-28T23:08:23Z","author_association":"MEMBER","body":"Users can already make each channel un advertised via the command line or the direct RPC, do we really need this extra functionality? I think that issue wants to be able to have public channels, yet instruct the switch to cancel back all HTLCs, and also ensure that the side of the channel belonging to the node is disabled (channel update) at all times. "}}
{"actor":{"display_login":"Roasbeef"}}