{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/210517375","pull_request_review_id":146744096,"id":210517375,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDUxNzM3NQ==","diff_hunk":"@@ -0,0 +1,39 @@\n+// tag::use-slf4j[]\n+import org.slf4j.Logger","path":"subprojects/docs/src/samples/userguide/tutorial/logging/kotlin/build.gradle.kts","position":2,"original_position":2,"commit_id":"3ca865eb1f5e173ca481fde4e5e7844db5822957","original_commit_id":"3ca865eb1f5e173ca481fde4e5e7844db5822957","user":{"login":"eskatos","id":132773,"node_id":"MDQ6VXNlcjEzMjc3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/132773?v=4","gravatar_id":"","url":"https://api.github.com/users/eskatos","html_url":"https://github.com/eskatos","followers_url":"https://api.github.com/users/eskatos/followers","following_url":"https://api.github.com/users/eskatos/following{/other_user}","gists_url":"https://api.github.com/users/eskatos/gists{/gist_id}","starred_url":"https://api.github.com/users/eskatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eskatos/subscriptions","organizations_url":"https://api.github.com/users/eskatos/orgs","repos_url":"https://api.github.com/users/eskatos/repos","events_url":"https://api.github.com/users/eskatos/events{/privacy}","received_events_url":"https://api.github.com/users/eskatos/received_events","type":"User","site_admin":false},"body":":x: unused import","created_at":"2018-08-16T08:37:42Z","updated_at":"2018-08-16T08:43:16Z","html_url":"https://github.com/gradle/gradle/pull/6321#discussion_r210517375","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/6321","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/210517375"},"html":{"href":"https://github.com/gradle/gradle/pull/6321#discussion_r210517375"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6321"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/6321","id":207469387,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDY5Mzg3","html_url":"https://github.com/gradle/gradle/pull/6321","diff_url":"https://github.com/gradle/gradle/pull/6321.diff","patch_url":"https://github.com/gradle/gradle/pull/6321.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/6321","number":6321,"state":"open","locked":false,"title":"[WIP] Kotlin samples for the logging user manual chapter","user":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"body":"This change introduces Kotlin DSL samples for the logging chapter.\r\n\r\nIt leverages a new `include::sample` asciidoctor macro I wrote (sources not open yet, but internal link is [here](https://github.com/gradle/dotorg-docs/tree/master/docs-asciidoctor-extensions)).\r\n\r\nItems for discussion that we want to definitively decide before we write a whole lot of Kotlin DSL samples:\r\n\r\n * We are completely cool using this task creation syntax for Kotlin examples. \r\n   * I think the Groovy and Kotlin samples should be as close as possible. This implies that we should _not_ use lazy configuration Kotlin APIs _unless_ we also use them for Groovy DSL.\r\n * Should we change anything _now_ about how we declare samples and expected output? With Exemplar we now have the ability to extract samples and output from the docs and test it. \r\n   * I think @adammurdoch and I agreed that the sample _sources should remain external_ but perhaps the _expected output should be embedded_. Do we want to do this now?\r\n\r\nNOTE: Please ignore changes to `head.html`. I will not merge these but instead fix `https://docs.gradle.org/build-tool.js` to work even if the docs are served locally. \r\n\r\n![screenflow](https://user-images.githubusercontent.com/51534/43930721-d78ea038-9bef-11e8-9edf-10bdf989b0fc.gif)\r\n","created_at":"2018-08-09T23:19:15Z","updated_at":"2018-08-16T08:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51b4a29b710f821e6c2ca0e7f8ae1b5f3ebffd5c","assignee":{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false},"assignees":[{"login":"eriwen","id":51534,"node_id":"MDQ6VXNlcjUxNTM0","avatar_url":"https://avatars2.githubusercontent.com/u/51534?v=4","gravatar_id":"","url":"https://api.github.com/users/eriwen","html_url":"https://github.com/eriwen","followers_url":"https://api.github.com/users/eriwen/followers","following_url":"https://api.github.com/users/eriwen/following{/other_user}","gists_url":"https://api.github.com/users/eriwen/gists{/gist_id}","starred_url":"https://api.github.com/users/eriwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriwen/subscriptions","organizations_url":"https://api.github.com/users/eriwen/orgs","repos_url":"https://api.github.com/users/eriwen/repos","events_url":"https://api.github.com/users/eriwen/events{/privacy}","received_events_url":"https://api.github.com/users/eriwen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bamboo","id":51689,"node_id":"MDQ6VXNlcjUxNjg5","avatar_url":"https://avatars1.githubusercontent.com/u/51689?v=4","gravatar_id":"","url":"https://api.github.com/users/bamboo","html_url":"https://github.com/bamboo","followers_url":"https://api.github.com/users/bamboo/followers","following_url":"https://api.github.com/users/bamboo/following{/other_user}","gists_url":"https://api.github.com/users/bamboo/gists{/gist_id}","starred_url":"https://api.github.com/users/bamboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamboo/subscriptions","organizations_url":"https://api.github.com/users/bamboo/orgs","repos_url":"https://api.github.com/users/bamboo/repos","events_url":"https://api.github.com/users/bamboo/events{/privacy}","received_events_url":"https://api.github.com/users/bamboo/received_events","type":"User","site_admin":false},{"login":"pioterj","id":1292566,"node_id":"MDQ6VXNlcjEyOTI1NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1292566?v=4","gravatar_id":"","url":"https://api.github.com/users/pioterj","html_url":"https://github.com/pioterj","followers_url":"https://api.github.com/users/pioterj/followers","following_url":"https://api.github.com/users/pioterj/following{/other_user}","gists_url":"https://api.github.com/users/pioterj/gists{/gist_id}","starred_url":"https://api.github.com/users/pioterj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioterj/subscriptions","organizations_url":"https://api.github.com/users/pioterj/orgs","repos_url":"https://api.github.com/users/pioterj/repos","events_url":"https://api.github.com/users/pioterj/events{/privacy}","received_events_url":"https://api.github.com/users/pioterj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":289469033,"node_id":"MDU6TGFiZWwyODk0NjkwMzM=","url":"https://api.github.com/repos/gradle/gradle/labels/from:member","name":"from:member","color":"0052cc","default":false},{"id":290482145,"node_id":"MDU6TGFiZWwyOTA0ODIxNDU=","url":"https://api.github.com/repos/gradle/gradle/labels/in:docs","name":"in:docs","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/59","html_url":"https://github.com/gradle/gradle/milestone/59","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/59/labels","id":3014889,"node_id":"MDk6TWlsZXN0b25lMzAxNDg4OQ==","number":59,"title":"5.0 RC1","description":"","creator":{"login":"jjohannes","id":1963746,"node_id":"MDQ6VXNlcjE5NjM3NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1963746?v=4","gravatar_id":"","url":"https://api.github.com/users/jjohannes","html_url":"https://github.com/jjohannes","followers_url":"https://api.github.com/users/jjohannes/followers","following_url":"https://api.github.com/users/jjohannes/following{/other_user}","gists_url":"https://api.github.com/users/jjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjohannes/subscriptions","organizations_url":"https://api.github.com/users/jjohannes/orgs","repos_url":"https://api.github.com/users/jjohannes/repos","events_url":"https://api.github.com/users/jjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/jjohannes/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":30,"state":"open","created_at":"2018-01-05T10:38:20Z","updated_at":"2018-08-15T23:33:19Z","due_on":"2018-09-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/6321/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/6321/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/6321/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/3ca865eb1f5e173ca481fde4e5e7844db5822957","head":{"label":"gradle:ew/docs/logging-kts","ref":"ew/docs/logging-kts","sha":"3ca865eb1f5e173ca481fde4e5e7844db5822957","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-08-16T08:18:15Z","pushed_at":"2018-08-16T07:52:54Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":222196,"stargazers_count":7339,"watchers_count":7339,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2263,"mirror_url":null,"archived":false,"open_issues_count":1224,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2263,"open_issues":1224,"watchers":7339,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"f2ca55723d3b43bd3742df363f5e2154bad301b2","user":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIzMjI=","name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDE1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/124156?v=4","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2018-08-16T08:18:15Z","pushed_at":"2018-08-16T07:52:54Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":222196,"stargazers_count":7339,"watchers_count":7339,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2263,"mirror_url":null,"archived":false,"open_issues_count":1224,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2263,"open_issues":1224,"watchers":7339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6321"},"html":{"href":"https://github.com/gradle/gradle/pull/6321"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/6321"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/6321/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6321/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/6321/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/3ca865eb1f5e173ca481fde4e5e7844db5822957"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eskatos"}}