{"action":"created","issue":{"url":"https://api.github.com/repos/code-dot-org/dance-party/issues/186","repository_url":"https://api.github.com/repos/code-dot-org/dance-party","labels_url":"https://api.github.com/repos/code-dot-org/dance-party/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/code-dot-org/dance-party/issues/186/comments","events_url":"https://api.github.com/repos/code-dot-org/dance-party/issues/186/events","html_url":"https://github.com/code-dot-org/dance-party/pull/186","id":378500391,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTkyNDE0","number":186,"title":"Safe to call commands with empty group names","user":{"login":"islemaster","id":1615761,"node_id":"MDQ6VXNlcjE2MTU3NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1615761?v=4","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T22:40:09Z","updated_at":"2018-11-07T22:40:31Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/code-dot-org/dance-party/pulls/186","html_url":"https://github.com/code-dot-org/dance-party/pull/186","diff_url":"https://github.com/code-dot-org/dance-party/pull/186.diff","patch_url":"https://github.com/code-dot-org/dance-party/pull/186.patch"},"body":"Fixes #168 \r\n\r\nRetrieving a sprite group by name that doesn't exist yet now creates and returns the empty group, which should resolve this issue for all group commands.\r\n\r\nMade sure to add testing for sprite layouts in case there were surprise divide-by-zero issues after this change."},"comment":{"url":"https://api.github.com/repos/code-dot-org/dance-party/issues/comments/436804304","html_url":"https://github.com/code-dot-org/dance-party/pull/186#issuecomment-436804304","issue_url":"https://api.github.com/repos/code-dot-org/dance-party/issues/186","id":436804304,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjgwNDMwNA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T22:40:31Z","updated_at":"2018-11-07T22:40:31Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=h1) Report\n> Merging [#186](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=desc) into [master](https://codecov.io/gh/code-dot-org/dance-party/commit/dffdf04b6a1a7f28c0509660c2dde7faf85e888d?src=pr&el=desc) will **increase** coverage by `0.11%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/code-dot-org/dance-party/pull/186/graphs/tree.svg?width=650&token=s1b3qndiqo&height=150&src=pr)](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #186      +/-   ##\n==========================================\n+ Coverage   65.31%   65.43%   +0.11%     \n==========================================\n  Files          10       10              \n  Lines         813      810       -3     \n==========================================\n- Hits          531      530       -1     \n+ Misses        282      280       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/p5.dance.js](https://codecov.io/gh/code-dot-org/dance-party/pull/186/diff?src=pr&el=tree#diff-c3JjL3A1LmRhbmNlLmpz) | `80.23% <100%> (+0.27%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=footer). Last update [dffdf04...c56c131](https://codecov.io/gh/code-dot-org/dance-party/pull/186?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}