{"action":"created","comment":{"url":"https://api.github.com/repos/spekframework/spek/pulls/comments/173587370","pull_request_review_id":102812673,"id":173587370,"diff_hunk":"@@ -58,4 +52,19 @@ actual class SpekRuntime: AbstractRuntime() {\n             .map { it.objectInstance ?: it.primaryConstructor!!.call() }\n             .firstOrNull() ?: defaultInstanceFactory\n     }\n+\n+    private fun createReflections(testDirs: List<String>): Reflections {\n+        val urls = if (testDirs.isEmpty()) {\n+            ClasspathHelper.forClassLoader()\n+        } else {\n+            testDirs.map { java.nio.file.Paths.get(it) }\n+                .map { it.toUri().toURL() }\n+        }\n+\n+        return Reflections(","path":"spek-runtime/jvm/src/main/kotlin/org/spekframework/spek2/runtime/SpekJvmRuntime.kt","position":35,"original_position":35,"commit_id":"898c0ca4e622ef9c1228194e211ab7fb60b691a1","original_commit_id":"898c0ca4e622ef9c1228194e211ab7fb60b691a1","user":{"login":"raniejade","id":1041919,"avatar_url":"https://avatars2.githubusercontent.com/u/1041919?v=4","gravatar_id":"","url":"https://api.github.com/users/raniejade","html_url":"https://github.com/raniejade","followers_url":"https://api.github.com/users/raniejade/followers","following_url":"https://api.github.com/users/raniejade/following{/other_user}","gists_url":"https://api.github.com/users/raniejade/gists{/gist_id}","starred_url":"https://api.github.com/users/raniejade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raniejade/subscriptions","organizations_url":"https://api.github.com/users/raniejade/orgs","repos_url":"https://api.github.com/users/raniejade/repos","events_url":"https://api.github.com/users/raniejade/events{/privacy}","received_events_url":"https://api.github.com/users/raniejade/received_events","type":"User","site_admin":false},"body":"Not limited per se, you just need to do a lot of manual tedious hacking. `Reflections` does it clear and neat way. Basically, less things to think about.","created_at":"2018-03-09T22:43:25Z","updated_at":"2018-03-09T22:43:25Z","html_url":"https://github.com/spekframework/spek/pull/377#discussion_r173587370","pull_request_url":"https://api.github.com/repos/spekframework/spek/pulls/377","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spekframework/spek/pulls/comments/173587370"},"html":{"href":"https://github.com/spekframework/spek/pull/377#discussion_r173587370"},"pull_request":{"href":"https://api.github.com/repos/spekframework/spek/pulls/377"}},"in_reply_to_id":173549522},"pull_request":{"url":"https://api.github.com/repos/spekframework/spek/pulls/377","id":173706714,"html_url":"https://github.com/spekframework/spek/pull/377","diff_url":"https://github.com/spekframework/spek/pull/377.diff","patch_url":"https://github.com/spekframework/spek/pull/377.patch","issue_url":"https://api.github.com/repos/spekframework/spek/issues/377","number":377,"state":"open","locked":false,"title":"Narrow down spec discovery","user":{"login":"raniejade","id":1041919,"avatar_url":"https://avatars2.githubusercontent.com/u/1041919?v=4","gravatar_id":"","url":"https://api.github.com/users/raniejade","html_url":"https://github.com/raniejade","followers_url":"https://api.github.com/users/raniejade/followers","following_url":"https://api.github.com/users/raniejade/following{/other_user}","gists_url":"https://api.github.com/users/raniejade/gists{/gist_id}","starred_url":"https://api.github.com/users/raniejade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raniejade/subscriptions","organizations_url":"https://api.github.com/users/raniejade/orgs","repos_url":"https://api.github.com/users/raniejade/repos","events_url":"https://api.github.com/users/raniejade/events{/privacy}","received_events_url":"https://api.github.com/users/raniejade/received_events","type":"User","site_admin":false},"body":"This an attempt to solve #328. Introduced `sourceDirs` during discovery which will be used to build up `Reflections`, if empty it will re-use the current class loader's classpath.","created_at":"2018-03-08T11:04:08Z","updated_at":"2018-03-09T22:43:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a6014cc5d79a6e428e245676ec92d510a570b84","assignee":null,"assignees":[],"requested_reviewers":[{"login":"artem-zinnatullin","id":967132,"avatar_url":"https://avatars0.githubusercontent.com/u/967132?v=4","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spekframework/spek/pulls/377/commits","review_comments_url":"https://api.github.com/repos/spekframework/spek/pulls/377/comments","review_comment_url":"https://api.github.com/repos/spekframework/spek/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spekframework/spek/issues/377/comments","statuses_url":"https://api.github.com/repos/spekframework/spek/statuses/898c0ca4e622ef9c1228194e211ab7fb60b691a1","head":{"label":"spekframework:narrow-down-spec-search","ref":"narrow-down-spec-search","sha":"898c0ca4e622ef9c1228194e211ab7fb60b691a1","user":{"login":"spekframework","id":24952163,"avatar_url":"https://avatars0.githubusercontent.com/u/24952163?v=4","gravatar_id":"","url":"https://api.github.com/users/spekframework","html_url":"https://github.com/spekframework","followers_url":"https://api.github.com/users/spekframework/followers","following_url":"https://api.github.com/users/spekframework/following{/other_user}","gists_url":"https://api.github.com/users/spekframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spekframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekframework/subscriptions","organizations_url":"https://api.github.com/users/spekframework/orgs","repos_url":"https://api.github.com/users/spekframework/repos","events_url":"https://api.github.com/users/spekframework/events{/privacy}","received_events_url":"https://api.github.com/users/spekframework/received_events","type":"Organization","site_admin":false},"repo":{"id":6551658,"name":"spek","full_name":"spekframework/spek","owner":{"login":"spekframework","id":24952163,"avatar_url":"https://avatars0.githubusercontent.com/u/24952163?v=4","gravatar_id":"","url":"https://api.github.com/users/spekframework","html_url":"https://github.com/spekframework","followers_url":"https://api.github.com/users/spekframework/followers","following_url":"https://api.github.com/users/spekframework/following{/other_user}","gists_url":"https://api.github.com/users/spekframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spekframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekframework/subscriptions","organizations_url":"https://api.github.com/users/spekframework/orgs","repos_url":"https://api.github.com/users/spekframework/repos","events_url":"https://api.github.com/users/spekframework/events{/privacy}","received_events_url":"https://api.github.com/users/spekframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spekframework/spek","description":"A specification framework for Kotlin","fork":false,"url":"https://api.github.com/repos/spekframework/spek","forks_url":"https://api.github.com/repos/spekframework/spek/forks","keys_url":"https://api.github.com/repos/spekframework/spek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spekframework/spek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spekframework/spek/teams","hooks_url":"https://api.github.com/repos/spekframework/spek/hooks","issue_events_url":"https://api.github.com/repos/spekframework/spek/issues/events{/number}","events_url":"https://api.github.com/repos/spekframework/spek/events","assignees_url":"https://api.github.com/repos/spekframework/spek/assignees{/user}","branches_url":"https://api.github.com/repos/spekframework/spek/branches{/branch}","tags_url":"https://api.github.com/repos/spekframework/spek/tags","blobs_url":"https://api.github.com/repos/spekframework/spek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spekframework/spek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spekframework/spek/git/refs{/sha}","trees_url":"https://api.github.com/repos/spekframework/spek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spekframework/spek/statuses/{sha}","languages_url":"https://api.github.com/repos/spekframework/spek/languages","stargazers_url":"https://api.github.com/repos/spekframework/spek/stargazers","contributors_url":"https://api.github.com/repos/spekframework/spek/contributors","subscribers_url":"https://api.github.com/repos/spekframework/spek/subscribers","subscription_url":"https://api.github.com/repos/spekframework/spek/subscription","commits_url":"https://api.github.com/repos/spekframework/spek/commits{/sha}","git_commits_url":"https://api.github.com/repos/spekframework/spek/git/commits{/sha}","comments_url":"https://api.github.com/repos/spekframework/spek/comments{/number}","issue_comment_url":"https://api.github.com/repos/spekframework/spek/issues/comments{/number}","contents_url":"https://api.github.com/repos/spekframework/spek/contents/{+path}","compare_url":"https://api.github.com/repos/spekframework/spek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spekframework/spek/merges","archive_url":"https://api.github.com/repos/spekframework/spek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spekframework/spek/downloads","issues_url":"https://api.github.com/repos/spekframework/spek/issues{/number}","pulls_url":"https://api.github.com/repos/spekframework/spek/pulls{/number}","milestones_url":"https://api.github.com/repos/spekframework/spek/milestones{/number}","notifications_url":"https://api.github.com/repos/spekframework/spek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spekframework/spek/labels{/name}","releases_url":"https://api.github.com/repos/spekframework/spek/releases{/id}","deployments_url":"https://api.github.com/repos/spekframework/spek/deployments","created_at":"2012-11-05T20:59:59Z","updated_at":"2018-03-08T22:10:20Z","pushed_at":"2018-03-09T12:26:56Z","git_url":"git://github.com/spekframework/spek.git","ssh_url":"git@github.com:spekframework/spek.git","clone_url":"https://github.com/spekframework/spek.git","svn_url":"https://github.com/spekframework/spek","homepage":null,"size":15029,"stargazers_count":1122,"watchers_count":1122,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":121,"open_issues":76,"watchers":1122,"default_branch":"2.x"}},"base":{"label":"spekframework:2.x","ref":"2.x","sha":"d6a986efd933f869f6faef55209a89ce82bc67e2","user":{"login":"spekframework","id":24952163,"avatar_url":"https://avatars0.githubusercontent.com/u/24952163?v=4","gravatar_id":"","url":"https://api.github.com/users/spekframework","html_url":"https://github.com/spekframework","followers_url":"https://api.github.com/users/spekframework/followers","following_url":"https://api.github.com/users/spekframework/following{/other_user}","gists_url":"https://api.github.com/users/spekframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spekframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekframework/subscriptions","organizations_url":"https://api.github.com/users/spekframework/orgs","repos_url":"https://api.github.com/users/spekframework/repos","events_url":"https://api.github.com/users/spekframework/events{/privacy}","received_events_url":"https://api.github.com/users/spekframework/received_events","type":"Organization","site_admin":false},"repo":{"id":6551658,"name":"spek","full_name":"spekframework/spek","owner":{"login":"spekframework","id":24952163,"avatar_url":"https://avatars0.githubusercontent.com/u/24952163?v=4","gravatar_id":"","url":"https://api.github.com/users/spekframework","html_url":"https://github.com/spekframework","followers_url":"https://api.github.com/users/spekframework/followers","following_url":"https://api.github.com/users/spekframework/following{/other_user}","gists_url":"https://api.github.com/users/spekframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spekframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekframework/subscriptions","organizations_url":"https://api.github.com/users/spekframework/orgs","repos_url":"https://api.github.com/users/spekframework/repos","events_url":"https://api.github.com/users/spekframework/events{/privacy}","received_events_url":"https://api.github.com/users/spekframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spekframework/spek","description":"A specification framework for Kotlin","fork":false,"url":"https://api.github.com/repos/spekframework/spek","forks_url":"https://api.github.com/repos/spekframework/spek/forks","keys_url":"https://api.github.com/repos/spekframework/spek/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spekframework/spek/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spekframework/spek/teams","hooks_url":"https://api.github.com/repos/spekframework/spek/hooks","issue_events_url":"https://api.github.com/repos/spekframework/spek/issues/events{/number}","events_url":"https://api.github.com/repos/spekframework/spek/events","assignees_url":"https://api.github.com/repos/spekframework/spek/assignees{/user}","branches_url":"https://api.github.com/repos/spekframework/spek/branches{/branch}","tags_url":"https://api.github.com/repos/spekframework/spek/tags","blobs_url":"https://api.github.com/repos/spekframework/spek/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spekframework/spek/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spekframework/spek/git/refs{/sha}","trees_url":"https://api.github.com/repos/spekframework/spek/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spekframework/spek/statuses/{sha}","languages_url":"https://api.github.com/repos/spekframework/spek/languages","stargazers_url":"https://api.github.com/repos/spekframework/spek/stargazers","contributors_url":"https://api.github.com/repos/spekframework/spek/contributors","subscribers_url":"https://api.github.com/repos/spekframework/spek/subscribers","subscription_url":"https://api.github.com/repos/spekframework/spek/subscription","commits_url":"https://api.github.com/repos/spekframework/spek/commits{/sha}","git_commits_url":"https://api.github.com/repos/spekframework/spek/git/commits{/sha}","comments_url":"https://api.github.com/repos/spekframework/spek/comments{/number}","issue_comment_url":"https://api.github.com/repos/spekframework/spek/issues/comments{/number}","contents_url":"https://api.github.com/repos/spekframework/spek/contents/{+path}","compare_url":"https://api.github.com/repos/spekframework/spek/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spekframework/spek/merges","archive_url":"https://api.github.com/repos/spekframework/spek/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spekframework/spek/downloads","issues_url":"https://api.github.com/repos/spekframework/spek/issues{/number}","pulls_url":"https://api.github.com/repos/spekframework/spek/pulls{/number}","milestones_url":"https://api.github.com/repos/spekframework/spek/milestones{/number}","notifications_url":"https://api.github.com/repos/spekframework/spek/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spekframework/spek/labels{/name}","releases_url":"https://api.github.com/repos/spekframework/spek/releases{/id}","deployments_url":"https://api.github.com/repos/spekframework/spek/deployments","created_at":"2012-11-05T20:59:59Z","updated_at":"2018-03-08T22:10:20Z","pushed_at":"2018-03-09T12:26:56Z","git_url":"git://github.com/spekframework/spek.git","ssh_url":"git@github.com:spekframework/spek.git","clone_url":"https://github.com/spekframework/spek.git","svn_url":"https://github.com/spekframework/spek","homepage":null,"size":15029,"stargazers_count":1122,"watchers_count":1122,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":121,"open_issues":76,"watchers":1122,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/spekframework/spek/pulls/377"},"html":{"href":"https://github.com/spekframework/spek/pull/377"},"issue":{"href":"https://api.github.com/repos/spekframework/spek/issues/377"},"comments":{"href":"https://api.github.com/repos/spekframework/spek/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/spekframework/spek/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/spekframework/spek/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spekframework/spek/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/spekframework/spek/statuses/898c0ca4e622ef9c1228194e211ab7fb60b691a1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"raniejade"}}