{"action":"closed","number":242,"pull_request":{"url":"https://api.github.com/repos/batfish/pybatfish/pulls/242","id":238874133,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODc0MTMz","html_url":"https://github.com/batfish/pybatfish/pull/242","diff_url":"https://github.com/batfish/pybatfish/pull/242.diff","patch_url":"https://github.com/batfish/pybatfish/pull/242.patch","issue_url":"https://api.github.com/repos/batfish/pybatfish/issues/242","number":242,"state":"closed","locked":false,"title":"Support zip files with old timestamps","user":{"login":"sfraint","id":33436396,"node_id":"MDQ6VXNlcjMzNDM2Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/33436396?v=4","gravatar_id":"","url":"https://api.github.com/users/sfraint","html_url":"https://github.com/sfraint","followers_url":"https://api.github.com/users/sfraint/followers","following_url":"https://api.github.com/users/sfraint/following{/other_user}","gists_url":"https://api.github.com/users/sfraint/gists{/gist_id}","starred_url":"https://api.github.com/users/sfraint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfraint/subscriptions","organizations_url":"https://api.github.com/users/sfraint/orgs","repos_url":"https://api.github.com/users/sfraint/repos","events_url":"https://api.github.com/users/sfraint/events{/privacy}","received_events_url":"https://api.github.com/users/sfraint/received_events","type":"User","site_admin":false},"body":"When trying to zip files with timestamps from before 1980, users see error:  `ValueError: ZIP does not support timestamps before 1980` (see issue here https://bugs.python.org/issue34097).\r\n\r\nFor files that are too old, this update just creates a new temp file to zip instead of the original.\r\n","created_at":"2018-12-15T00:06:37Z","updated_at":"2018-12-17T18:59:20Z","closed_at":"2018-12-17T18:59:20Z","merged_at":"2018-12-17T18:59:20Z","merge_commit_sha":"7d5659b9b1c52bfb9e7fb0e9eef0bedb703b7ac1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/batfish/pybatfish/pulls/242/commits","review_comments_url":"https://api.github.com/repos/batfish/pybatfish/pulls/242/comments","review_comment_url":"https://api.github.com/repos/batfish/pybatfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/batfish/pybatfish/issues/242/comments","statuses_url":"https://api.github.com/repos/batfish/pybatfish/statuses/2310ae28d6f8b585ecae610969ee0e66fbeaf18f","head":{"label":"batfish:zip-timestamp","ref":"zip-timestamp","sha":"2310ae28d6f8b585ecae610969ee0e66fbeaf18f","user":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":142918121,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MTgxMjE=","name":"pybatfish","full_name":"batfish/pybatfish","private":false,"owner":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/batfish/pybatfish","description":"Python client for Batfish: https://github.com/batfish/batfish","fork":false,"url":"https://api.github.com/repos/batfish/pybatfish","forks_url":"https://api.github.com/repos/batfish/pybatfish/forks","keys_url":"https://api.github.com/repos/batfish/pybatfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/pybatfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/pybatfish/teams","hooks_url":"https://api.github.com/repos/batfish/pybatfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/pybatfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/pybatfish/events","assignees_url":"https://api.github.com/repos/batfish/pybatfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/pybatfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/pybatfish/tags","blobs_url":"https://api.github.com/repos/batfish/pybatfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/pybatfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/pybatfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/pybatfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/pybatfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/pybatfish/languages","stargazers_url":"https://api.github.com/repos/batfish/pybatfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/pybatfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/pybatfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/pybatfish/subscription","commits_url":"https://api.github.com/repos/batfish/pybatfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/pybatfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/pybatfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/pybatfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/pybatfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/pybatfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/pybatfish/merges","archive_url":"https://api.github.com/repos/batfish/pybatfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/pybatfish/downloads","issues_url":"https://api.github.com/repos/batfish/pybatfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/pybatfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/pybatfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/pybatfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/pybatfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/pybatfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/pybatfish/deployments","created_at":"2018-07-30T19:16:59Z","updated_at":"2018-12-14T23:35:28Z","pushed_at":"2018-12-17T18:59:20Z","git_url":"git://github.com/batfish/pybatfish.git","ssh_url":"git@github.com:batfish/pybatfish.git","clone_url":"https://github.com/batfish/pybatfish.git","svn_url":"https://github.com/batfish/pybatfish","homepage":"","size":2171,"stargazers_count":36,"watchers_count":36,"language":"Jupyter Notebook","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":4,"watchers":36,"default_branch":"master"}},"base":{"label":"batfish:master","ref":"master","sha":"817bf69b2703546dd72fa10fce51d3bd5026894c","user":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":142918121,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MTgxMjE=","name":"pybatfish","full_name":"batfish/pybatfish","private":false,"owner":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/batfish/pybatfish","description":"Python client for Batfish: https://github.com/batfish/batfish","fork":false,"url":"https://api.github.com/repos/batfish/pybatfish","forks_url":"https://api.github.com/repos/batfish/pybatfish/forks","keys_url":"https://api.github.com/repos/batfish/pybatfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/pybatfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/pybatfish/teams","hooks_url":"https://api.github.com/repos/batfish/pybatfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/pybatfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/pybatfish/events","assignees_url":"https://api.github.com/repos/batfish/pybatfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/pybatfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/pybatfish/tags","blobs_url":"https://api.github.com/repos/batfish/pybatfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/pybatfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/pybatfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/pybatfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/pybatfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/pybatfish/languages","stargazers_url":"https://api.github.com/repos/batfish/pybatfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/pybatfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/pybatfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/pybatfish/subscription","commits_url":"https://api.github.com/repos/batfish/pybatfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/pybatfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/pybatfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/pybatfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/pybatfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/pybatfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/pybatfish/merges","archive_url":"https://api.github.com/repos/batfish/pybatfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/pybatfish/downloads","issues_url":"https://api.github.com/repos/batfish/pybatfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/pybatfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/pybatfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/pybatfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/pybatfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/pybatfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/pybatfish/deployments","created_at":"2018-07-30T19:16:59Z","updated_at":"2018-12-14T23:35:28Z","pushed_at":"2018-12-17T18:59:20Z","git_url":"git://github.com/batfish/pybatfish.git","ssh_url":"git@github.com:batfish/pybatfish.git","clone_url":"https://github.com/batfish/pybatfish.git","svn_url":"https://github.com/batfish/pybatfish","homepage":"","size":2171,"stargazers_count":36,"watchers_count":36,"language":"Jupyter Notebook","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":4,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/batfish/pybatfish/pulls/242"},"html":{"href":"https://github.com/batfish/pybatfish/pull/242"},"issue":{"href":"https://api.github.com/repos/batfish/pybatfish/issues/242"},"comments":{"href":"https://api.github.com/repos/batfish/pybatfish/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/batfish/pybatfish/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/batfish/pybatfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/batfish/pybatfish/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/batfish/pybatfish/statuses/2310ae28d6f8b585ecae610969ee0e66fbeaf18f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sfraint","id":33436396,"node_id":"MDQ6VXNlcjMzNDM2Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/33436396?v=4","gravatar_id":"","url":"https://api.github.com/users/sfraint","html_url":"https://github.com/sfraint","followers_url":"https://api.github.com/users/sfraint/followers","following_url":"https://api.github.com/users/sfraint/following{/other_user}","gists_url":"https://api.github.com/users/sfraint/gists{/gist_id}","starred_url":"https://api.github.com/users/sfraint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfraint/subscriptions","organizations_url":"https://api.github.com/users/sfraint/orgs","repos_url":"https://api.github.com/users/sfraint/repos","events_url":"https://api.github.com/users/sfraint/events{/privacy}","received_events_url":"https://api.github.com/users/sfraint/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":82,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"sfraint"}}