{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/166062125","pull_request_review_id":94090737,"id":166062125,"diff_hunk":"@@ -255,7 +252,7 @@ void NodeList::reset() {\n     _avatarGainMap.clear();\n     _avatarGainMapLock.unlock();\n \n-    if (sender() != &_domainHandler) {\n+    if (!skipDomainHandlerReset) {","path":"libraries/networking/src/NodeList.cpp","position":54,"original_position":54,"commit_id":"7a21ae8d89b9f3510adab017c9df6ddda7394e08","original_commit_id":"7a21ae8d89b9f3510adab017c9df6ddda7394e08","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"I had to stop using the sender here because a reset from domain checkins no longer being responded to was moved to the DomainHandler.","created_at":"2018-02-05T18:21:45Z","updated_at":"2018-02-05T18:21:45Z","html_url":"https://github.com/highfidelity/hifi/pull/12195#discussion_r166062125","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12195","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/166062125"},"html":{"href":"https://github.com/highfidelity/hifi/pull/12195#discussion_r166062125"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12195"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12195","id":163568789,"html_url":"https://github.com/highfidelity/hifi/pull/12195","diff_url":"https://github.com/highfidelity/hifi/pull/12195.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12195.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12195","number":12195,"state":"open","locked":false,"title":"clear silent connection attempt counter on DomainHandler soft reset","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"- fixed a bug where the domain connection would be reset early while negotiating connection for a logged in user","created_at":"2018-01-17T22:22:52Z","updated_at":"2018-02-05T18:21:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215e2e235ef98a446d304aa8d19b25d4e8be57da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/16","html_url":"https://github.com/highfidelity/hifi/milestone/16","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/16/labels","id":3011512,"number":16,"title":"RC64","description":"","creator":{"login":"divyaelango88","id":30877259,"avatar_url":"https://avatars3.githubusercontent.com/u/30877259?v=4","gravatar_id":"","url":"https://api.github.com/users/divyaelango88","html_url":"https://github.com/divyaelango88","followers_url":"https://api.github.com/users/divyaelango88/followers","following_url":"https://api.github.com/users/divyaelango88/following{/other_user}","gists_url":"https://api.github.com/users/divyaelango88/gists{/gist_id}","starred_url":"https://api.github.com/users/divyaelango88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divyaelango88/subscriptions","organizations_url":"https://api.github.com/users/divyaelango88/orgs","repos_url":"https://api.github.com/users/divyaelango88/repos","events_url":"https://api.github.com/users/divyaelango88/events{/privacy}","received_events_url":"https://api.github.com/users/divyaelango88/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":37,"state":"open","created_at":"2018-01-03T21:16:30Z","updated_at":"2018-02-05T17:58:36Z","due_on":"2018-02-05T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12195/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/12195/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12195/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/7a21ae8d89b9f3510adab017c9df6ddda7394e08","head":{"label":"birarda:bug/connection-refused","ref":"bug/connection-refused","sha":"7a21ae8d89b9f3510adab017c9df6ddda7394e08","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"repo":{"id":9376753,"name":"hifi","full_name":"birarda/hifi","owner":{"login":"birarda","id":724069,"avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/birarda/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/birarda/hifi","forks_url":"https://api.github.com/repos/birarda/hifi/forks","keys_url":"https://api.github.com/repos/birarda/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/birarda/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/birarda/hifi/teams","hooks_url":"https://api.github.com/repos/birarda/hifi/hooks","issue_events_url":"https://api.github.com/repos/birarda/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/birarda/hifi/events","assignees_url":"https://api.github.com/repos/birarda/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/birarda/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/birarda/hifi/tags","blobs_url":"https://api.github.com/repos/birarda/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/birarda/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/birarda/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/birarda/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/birarda/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/birarda/hifi/languages","stargazers_url":"https://api.github.com/repos/birarda/hifi/stargazers","contributors_url":"https://api.github.com/repos/birarda/hifi/contributors","subscribers_url":"https://api.github.com/repos/birarda/hifi/subscribers","subscription_url":"https://api.github.com/repos/birarda/hifi/subscription","commits_url":"https://api.github.com/repos/birarda/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/birarda/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/birarda/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/birarda/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/birarda/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/birarda/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/birarda/hifi/merges","archive_url":"https://api.github.com/repos/birarda/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/birarda/hifi/downloads","issues_url":"https://api.github.com/repos/birarda/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/birarda/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/birarda/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/birarda/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/birarda/hifi/labels{/name}","releases_url":"https://api.github.com/repos/birarda/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/birarda/hifi/deployments","created_at":"2013-04-11T17:58:46Z","updated_at":"2016-10-26T00:25:02Z","pushed_at":"2018-02-02T23:25:49Z","git_url":"git://github.com/birarda/hifi.git","ssh_url":"git@github.com:birarda/hifi.git","clone_url":"https://github.com/birarda/hifi.git","svn_url":"https://github.com/birarda/hifi","homepage":null,"size":452546,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"28c9cd15a4ca5727c3a37a0d5a7e7b07bcea9292","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-02-03T11:09:11Z","pushed_at":"2018-02-05T18:19:19Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":463623,"stargazers_count":580,"watchers_count":580,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":392,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":392,"open_issues":136,"watchers":580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12195"},"html":{"href":"https://github.com/highfidelity/hifi/pull/12195"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12195"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/12195/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12195/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/12195/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/7a21ae8d89b9f3510adab017c9df6ddda7394e08"}},"author_association":"OWNER"}}
{"actor":{"display_login":"birarda"}}