{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10568","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10568/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10568/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10568/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/10568","id":388366194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NjQ3Mzk5","number":10568,"title":"make/docker: adapt mount of localtime","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"labels":[{"id":97338598,"node_id":"MDU6TGFiZWw5NzMzODU5OA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Area:%20build%20system","name":"Area: build system","color":"6600ff","default":false},{"id":214816571,"node_id":"MDU6TGFiZWwyMTQ4MTY1NzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/CI:%20ready%20for%20build","name":"CI: ready for build","color":"66ffcc","default":false},{"id":108195264,"node_id":"MDU6TGFiZWwxMDgxOTUyNjQ=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/OS:%20Mac%20OS%20X","name":"OS: Mac OS X","color":"993333","default":false},{"id":23399100,"node_id":"MDU6TGFiZWwyMzM5OTEwMA==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Type:%20enhancement","name":"Type: enhancement","color":"ffff66","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-06T19:38:08Z","updated_at":"2018-12-07T12:40:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10568","html_url":"https://github.com/RIOT-OS/RIOT/pull/10568","diff_url":"https://github.com/RIOT-OS/RIOT/pull/10568.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/10568.patch"},"body":"\r\n\r\n<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nMounting `/etc/localtime` directly does not work on macOS (anymore).\r\nHowever, by resolving the symlink to its real path docker can handle\r\nthe mount on macOS again - should also work with Linux.\r\n\r\n\r\n### Testing procedure\r\n\r\nTry to run `BUILD_IN_DOCKER=1 make -C tests/minimal` on macOS, which will fail with one or the other error regarding either that `/etc` is not shared and hence not accessible by docker, or if you do add it to the list of shared folders, it will fail with mounting `/etc/localtime` into docker. With this PR it works again.\r\n\r\n\r\n### Issues/PRs references\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/445221336","html_url":"https://github.com/RIOT-OS/RIOT/pull/10568#issuecomment-445221336","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10568","id":445221336,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTIyMTMzNg==","user":{"login":"smlng","id":10532675,"node_id":"MDQ6VXNlcjEwNTMyNjc1","avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T12:40:59Z","updated_at":"2018-12-07T12:40:59Z","author_association":"MEMBER","body":"To really solve this once and for all RIOT needs a proper system init, that is: check the OS and lookup all the tools and stuff and set ENV accordingly."}}
{"actor":{"display_login":"smlng"}}