{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/235599469","pull_request_review_id":177501932,"id":235599469,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU5OTQ2OQ==","diff_hunk":"@@ -188,19 +189,13 @@ export function getThemeForSiteGoals( siteGoals ) {\n }\n \n export function getDesignTypeForSiteType( siteType, flow ) {\n-\tif ( 'business' === siteType || flow === 'store-nux' ) {\n-\t\treturn 'page';\n-\t}\n+\tconst theSiteType = find( allSiteTypes, { type: siteType } ) || allSiteTypes[ 0 ];\n \n-\tif ( 'professional' === siteType ) {\n-\t\treturn 'portfolio';\n-\t}\n-\n-\tif ( 'non-profit' === siteType ) {\n+\tif ( flow === 'store-nux' ) {","path":"client/signup/utils.js","position":15,"original_position":24,"commit_id":"3abacbe2e0100b8ae26f148be8b2a68c49927c33","original_commit_id":"121f3f1160522747ddfdefb41deba7b6a16aaffb","user":{"login":"taggon","id":212034,"node_id":"MDQ6VXNlcjIxMjAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"body":"@michaeldcain Updated!","created_at":"2018-11-22T04:33:28Z","updated_at":"2018-11-22T04:33:28Z","html_url":"https://github.com/Automattic/wp-calypso/pull/28754#discussion_r235599469","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/235599469"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/28754#discussion_r235599469"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754"}},"in_reply_to_id":235598867},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754","id":232655444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjU1NDQ0","html_url":"https://github.com/Automattic/wp-calypso/pull/28754","diff_url":"https://github.com/Automattic/wp-calypso/pull/28754.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/28754.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28754","number":28754,"state":"open","locked":false,"title":"Checklist: Support for segments","user":{"login":"taggon","id":212034,"node_id":"MDQ6VXNlcjIxMjAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"body":"#### Changes proposed in this Pull Request\r\n\r\n* Our new segment sites are showing the same checklist tasks for everyone since it depends on the design types that are replaced with site types. This will personalize the checklist even for the users who come via the new onboarding flow.\r\n\r\n#### Testing instructions\r\n\r\n<!--\r\nAdd as many details as possible to help others reproduce the issue and test the fix.\r\n\"Before / After\" screenshots can also be very helpful when the change is visual.\r\n-->\r\n\r\n* Run the following command in console to activate the new onboarding flow.\r\n```\r\nlocalStorage.setItem( 'debug', 'calypso:wpcom-task-list' );\r\nlocalStorage.setItem( 'ABTests', '{\"improvedOnboarding_20181023\":\"onboarding\"}' );\r\n```\r\n\r\n* Visit `/start/` and make sure that it is redirected to `/start/site-type`.\r\n* Follow the flow to create a website.\r\n* You should be able to see the checklist at the end of the flow. Also, the console should show the correct design type and the tasks based on the site type you chose like the following:\r\n<img width=\"773\" alt=\"2018-11-21 9 53 40\" src=\"https://user-images.githubusercontent.com/212034/48842634-140e4b00-edd8-11e8-9241-50968f0a0581.png\">\r\n\r\n* Here is the list of site types and mapped design types:\r\n  * Blog - blog\r\n  * Business - store\r\n  * Professional - portfolio\r\n  * Education - page\r\n  * Non-profit Organization - page\r\n","created_at":"2018-11-21T13:01:29Z","updated_at":"2018-11-22T04:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2b3cf805080abe6f757e6adf64cc8597ec44e92","assignee":{"login":"taggon","id":212034,"node_id":"MDQ6VXNlcjIxMjAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false},"assignees":[{"login":"taggon","id":212034,"node_id":"MDQ6VXNlcjIxMjAzNA==","avatar_url":"https://avatars2.githubusercontent.com/u/212034?v=4","gravatar_id":"","url":"https://api.github.com/users/taggon","html_url":"https://github.com/taggon","followers_url":"https://api.github.com/users/taggon/followers","following_url":"https://api.github.com/users/taggon/following{/other_user}","gists_url":"https://api.github.com/users/taggon/gists{/gist_id}","starred_url":"https://api.github.com/users/taggon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taggon/subscriptions","organizations_url":"https://api.github.com/users/taggon/orgs","repos_url":"https://api.github.com/users/taggon/repos","events_url":"https://api.github.com/users/taggon/events{/privacy}","received_events_url":"https://api.github.com/users/taggon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":758762135,"node_id":"MDU6TGFiZWw3NTg3NjIxMzU=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Checklist","name":"Checklist","color":"006b75","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28754/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/3abacbe2e0100b8ae26f148be8b2a68c49927c33","head":{"label":"Automattic:checklist/support-for-segments","ref":"checklist/support-for-segments","sha":"3abacbe2e0100b8ae26f148be8b2a68c49927c33","user":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzNjg5NQ==","name":"wp-calypso","full_name":"Automattic/wp-calypso","private":false,"owner":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-11-22T01:22:12Z","pushed_at":"2018-11-22T04:32:58Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":117970,"stargazers_count":10612,"watchers_count":10612,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1501,"mirror_url":null,"archived":false,"open_issues_count":1661,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1501,"open_issues":1661,"watchers":10612,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"35ebfdcd42d731d861fd7db4ce90666f8ba8a66c","user":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzNjg5NQ==","name":"wp-calypso","full_name":"Automattic/wp-calypso","private":false,"owner":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-11-22T01:22:12Z","pushed_at":"2018-11-22T04:32:58Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":117970,"stargazers_count":10612,"watchers_count":10612,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1501,"mirror_url":null,"archived":false,"open_issues_count":1661,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1501,"open_issues":1661,"watchers":10612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/28754"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/28754"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/28754/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/28754/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/3abacbe2e0100b8ae26f148be8b2a68c49927c33"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"taggon"}}