{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/comments/176999820","pull_request_review_id":106795307,"id":176999820,"diff_hunk":"@@ -21,6 +21,7 @@ public class ItembankConfigurationDataService : IItembankConfigurationDataServic\n         private const string GRADE_PROP_NAME = \"Grade\";\r\n \r\n         private readonly IItembankConfigurationDataQueryService itembankConfigurationDataQueryService;\r\n+        private readonly ITestPackageDao<ClientDTO> clientDao;\r","path":"Common/TDSQASystemAPI/BL/testpackage/administration/ItembankConfigurationDataService.cs","position":4,"original_position":4,"commit_id":"ad16c7ea1bc9937ccf8ddd414888cf37753cd172","original_commit_id":"ad16c7ea1bc9937ccf8ddd414888cf37753cd172","user":{"login":"jeffjohnson9046","id":1435800,"avatar_url":"https://avatars3.githubusercontent.com/u/1435800?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffjohnson9046","html_url":"https://github.com/jeffjohnson9046","followers_url":"https://api.github.com/users/jeffjohnson9046/followers","following_url":"https://api.github.com/users/jeffjohnson9046/following{/other_user}","gists_url":"https://api.github.com/users/jeffjohnson9046/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffjohnson9046/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffjohnson9046/subscriptions","organizations_url":"https://api.github.com/users/jeffjohnson9046/orgs","repos_url":"https://api.github.com/users/jeffjohnson9046/repos","events_url":"https://api.github.com/users/jeffjohnson9046/events{/privacy}","received_events_url":"https://api.github.com/users/jeffjohnson9046/received_events","type":"User","site_admin":false},"body":"Turns out I needed this after all.  Initially, I created the `IItembankConfigurationDataQueryService` to handle all the finds/lookups.  I'm not sure if `IItembankConfigurationDataQueryService` provides much value, but it was too risky at this point to remove it.","created_at":"2018-03-26T07:31:25Z","updated_at":"2018-03-26T07:31:25Z","html_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9#discussion_r176999820","pull_request_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/comments/176999820"},"html":{"href":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9#discussion_r176999820"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9","id":177360686,"html_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9","diff_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9.diff","patch_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9.patch","issue_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/9","number":9,"state":"open","locked":false,"title":"Feature/load test package","user":{"login":"jeffjohnson9046","id":1435800,"avatar_url":"https://avatars3.githubusercontent.com/u/1435800?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffjohnson9046","html_url":"https://github.com/jeffjohnson9046","followers_url":"https://api.github.com/users/jeffjohnson9046/followers","following_url":"https://api.github.com/users/jeffjohnson9046/following{/other_user}","gists_url":"https://api.github.com/users/jeffjohnson9046/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffjohnson9046/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffjohnson9046/subscriptions","organizations_url":"https://api.github.com/users/jeffjohnson9046/orgs","repos_url":"https://api.github.com/users/jeffjohnson9046/repos","events_url":"https://api.github.com/users/jeffjohnson9046/events{/privacy}","received_events_url":"https://api.github.com/users/jeffjohnson9046/received_events","type":"User","site_admin":false},"body":"[TDS-1524](https://jira.fairwaytech.com/browse/TDS-1524):  Loading test package into TIS.\r\n\r\n**NOTE:** _This PR does not necessarily complete TDS-1524; this is all the work I've done on it so far._\r\n\r\n* Adds facade service (`TestPackageLoaderService`) which leverages all other relevant services to insert data into TIS databases.\r\n* Adds new controller (`TestPackageController`), a web service endpoint that can receive a `POST` with the new-format test package XML\r\n* Additional unit and integration tests ","created_at":"2018-03-26T07:18:49Z","updated_at":"2018-03-26T07:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5c3b82a60d77ea6931f54f9890a1354925079e6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mtrupkin","id":681993,"avatar_url":"https://avatars1.githubusercontent.com/u/681993?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrupkin","html_url":"https://github.com/mtrupkin","followers_url":"https://api.github.com/users/mtrupkin/followers","following_url":"https://api.github.com/users/mtrupkin/following{/other_user}","gists_url":"https://api.github.com/users/mtrupkin/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrupkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrupkin/subscriptions","organizations_url":"https://api.github.com/users/mtrupkin/orgs","repos_url":"https://api.github.com/users/mtrupkin/repos","events_url":"https://api.github.com/users/mtrupkin/events{/privacy}","received_events_url":"https://api.github.com/users/mtrupkin/received_events","type":"User","site_admin":false},{"login":"burzum619","id":1046191,"avatar_url":"https://avatars0.githubusercontent.com/u/1046191?v=4","gravatar_id":"","url":"https://api.github.com/users/burzum619","html_url":"https://github.com/burzum619","followers_url":"https://api.github.com/users/burzum619/followers","following_url":"https://api.github.com/users/burzum619/following{/other_user}","gists_url":"https://api.github.com/users/burzum619/gists{/gist_id}","starred_url":"https://api.github.com/users/burzum619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burzum619/subscriptions","organizations_url":"https://api.github.com/users/burzum619/orgs","repos_url":"https://api.github.com/users/burzum619/repos","events_url":"https://api.github.com/users/burzum619/events{/privacy}","received_events_url":"https://api.github.com/users/burzum619/received_events","type":"User","site_admin":false},{"login":"trapnine","id":5377313,"avatar_url":"https://avatars2.githubusercontent.com/u/5377313?v=4","gravatar_id":"","url":"https://api.github.com/users/trapnine","html_url":"https://github.com/trapnine","followers_url":"https://api.github.com/users/trapnine/followers","following_url":"https://api.github.com/users/trapnine/following{/other_user}","gists_url":"https://api.github.com/users/trapnine/gists{/gist_id}","starred_url":"https://api.github.com/users/trapnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trapnine/subscriptions","organizations_url":"https://api.github.com/users/trapnine/orgs","repos_url":"https://api.github.com/users/trapnine/repos","events_url":"https://api.github.com/users/trapnine/events{/privacy}","received_events_url":"https://api.github.com/users/trapnine/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/9/comments","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/statuses/ad16c7ea1bc9937ccf8ddd414888cf37753cd172","head":{"label":"SmarterApp:feature/load-test-packge","ref":"feature/load-test-packge","sha":"ad16c7ea1bc9937ccf8ddd414888cf37753cd172","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60319536,"name":"TDS_TestIntegrationSystem","full_name":"SmarterApp/TDS_TestIntegrationSystem","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem","description":null,"fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem","forks_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/deployments","created_at":"2016-06-03T05:01:12Z","updated_at":"2018-03-23T17:08:07Z","pushed_at":"2018-03-26T07:28:25Z","git_url":"git://github.com/SmarterApp/TDS_TestIntegrationSystem.git","ssh_url":"git@github.com:SmarterApp/TDS_TestIntegrationSystem.git","clone_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem.git","svn_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem","homepage":null,"size":8451,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"f0a024bb82f5e5bcdcaf3b055fcf7a53c0abd5a0","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":60319536,"name":"TDS_TestIntegrationSystem","full_name":"SmarterApp/TDS_TestIntegrationSystem","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem","description":null,"fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem","forks_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/deployments","created_at":"2016-06-03T05:01:12Z","updated_at":"2018-03-23T17:08:07Z","pushed_at":"2018-03-26T07:28:25Z","git_url":"git://github.com/SmarterApp/TDS_TestIntegrationSystem.git","ssh_url":"git@github.com:SmarterApp/TDS_TestIntegrationSystem.git","clone_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem.git","svn_url":"https://github.com/SmarterApp/TDS_TestIntegrationSystem","homepage":null,"size":8451,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9"},"html":{"href":"https://github.com/SmarterApp/TDS_TestIntegrationSystem/pull/9"},"issue":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/9"},"comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/TDS_TestIntegrationSystem/statuses/ad16c7ea1bc9937ccf8ddd414888cf37753cd172"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jeffjohnson9046"}}