{"action":"closed","number":7294,"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7294","id":206600561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjAwNTYx","html_url":"https://github.com/pingcap/tidb/pull/7294","diff_url":"https://github.com/pingcap/tidb/pull/7294.diff","patch_url":"https://github.com/pingcap/tidb/pull/7294.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7294","number":7294,"state":"closed","locked":false,"title":"ddl: add fsp checking for time/timestamp/datetime column definition","user":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"body":"## What have you changed? (mandatory)\r\n\r\n- rename `checkPointTypeColumn` to `checkColumnAttribute`\r\n- add fsp check for time/datetime/timestamp in `checkColumnAttribute`\r\n\r\n## What is the type of the changes? (mandatory)\r\n\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\n- unit tests\r\n- integration tests\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nno\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\n\r\nno\r\n\r\n## Does this PR need to be added to the release notes? (mandatory)\r\n\r\n```\r\nadd fsp checking for time/timestamp/datetime column definition\r\n```\r\n-->\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n```\r\ncreate table pa(d time(7));\r\n```\r\nexpect:\r\n\r\n```\r\nERROR 1426 (42000): Too-big precision 7 specified for 'd'. Maximum is 6.\r\n```\r\nbut got:\r\n\r\n```\r\nQuery OK, 0 rows affected(0.12 sec)\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pingcap/tidb/7294)\n<!-- Reviewable:end -->\n","created_at":"2018-08-07T07:12:14Z","updated_at":"2018-08-07T08:39:55Z","closed_at":"2018-08-07T08:39:55Z","merged_at":"2018-08-07T08:39:55Z","merge_commit_sha":"61b4ff23213de3da2eb152a83b04ed63328ef2ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":745133021,"node_id":"MDU6TGFiZWw3NDUxMzMwMjE=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/DDL-need-LGT3","name":"component/DDL-need-LGT3","color":"00bff4","default":false},{"id":541179553,"node_id":"MDU6TGFiZWw1NDExNzk1NTM=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/compatibility","name":"type/compatibility","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7294/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7294/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7294/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/366b83444b6a48217953f1ef38a10bfcea27a61f","head":{"label":"lysu:dev/add_fsp_for_time_def","ref":"dev/add_fsp_for_time_def","sha":"366b83444b6a48217953f1ef38a10bfcea27a61f","user":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"repo":{"id":133315666,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzMTU2NjY=","name":"tidb","full_name":"lysu/tidb","owner":{"login":"lysu","id":528332,"node_id":"MDQ6VXNlcjUyODMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/528332?v=4","gravatar_id":"","url":"https://api.github.com/users/lysu","html_url":"https://github.com/lysu","followers_url":"https://api.github.com/users/lysu/followers","following_url":"https://api.github.com/users/lysu/following{/other_user}","gists_url":"https://api.github.com/users/lysu/gists{/gist_id}","starred_url":"https://api.github.com/users/lysu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lysu/subscriptions","organizations_url":"https://api.github.com/users/lysu/orgs","repos_url":"https://api.github.com/users/lysu/repos","events_url":"https://api.github.com/users/lysu/events{/privacy}","received_events_url":"https://api.github.com/users/lysu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lysu/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":true,"url":"https://api.github.com/repos/lysu/tidb","forks_url":"https://api.github.com/repos/lysu/tidb/forks","keys_url":"https://api.github.com/repos/lysu/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lysu/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lysu/tidb/teams","hooks_url":"https://api.github.com/repos/lysu/tidb/hooks","issue_events_url":"https://api.github.com/repos/lysu/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/lysu/tidb/events","assignees_url":"https://api.github.com/repos/lysu/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/lysu/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/lysu/tidb/tags","blobs_url":"https://api.github.com/repos/lysu/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lysu/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lysu/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/lysu/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lysu/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/lysu/tidb/languages","stargazers_url":"https://api.github.com/repos/lysu/tidb/stargazers","contributors_url":"https://api.github.com/repos/lysu/tidb/contributors","subscribers_url":"https://api.github.com/repos/lysu/tidb/subscribers","subscription_url":"https://api.github.com/repos/lysu/tidb/subscription","commits_url":"https://api.github.com/repos/lysu/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/lysu/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/lysu/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/lysu/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/lysu/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/lysu/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lysu/tidb/merges","archive_url":"https://api.github.com/repos/lysu/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lysu/tidb/downloads","issues_url":"https://api.github.com/repos/lysu/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/lysu/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/lysu/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/lysu/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lysu/tidb/labels{/name}","releases_url":"https://api.github.com/repos/lysu/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/lysu/tidb/deployments","created_at":"2018-05-14T06:37:16Z","updated_at":"2018-08-07T07:16:22Z","pushed_at":"2018-08-07T07:46:47Z","git_url":"git://github.com/lysu/tidb.git","ssh_url":"git@github.com:lysu/tidb.git","clone_url":"https://github.com/lysu/tidb.git","svn_url":"https://github.com/lysu/tidb","homepage":"https://pingcap.com","size":54335,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"f6dbad0f5c3cc42cafdfa00275abbd2197b8376b","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-08-07T08:18:40Z","pushed_at":"2018-08-07T08:39:55Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":79416,"stargazers_count":14275,"watchers_count":14275,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1968,"mirror_url":null,"archived":false,"open_issues_count":486,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1968,"open_issues":486,"watchers":14275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7294"},"html":{"href":"https://github.com/pingcap/tidb/pull/7294"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7294"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7294/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7294/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7294/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/366b83444b6a48217953f1ef38a10bfcea27a61f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jackysp","id":4352397,"node_id":"MDQ6VXNlcjQzNTIzOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4352397?v=4","gravatar_id":"","url":"https://api.github.com/users/jackysp","html_url":"https://github.com/jackysp","followers_url":"https://api.github.com/users/jackysp/followers","following_url":"https://api.github.com/users/jackysp/following{/other_user}","gists_url":"https://api.github.com/users/jackysp/gists{/gist_id}","starred_url":"https://api.github.com/users/jackysp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackysp/subscriptions","organizations_url":"https://api.github.com/users/jackysp/orgs","repos_url":"https://api.github.com/users/jackysp/repos","events_url":"https://api.github.com/users/jackysp/events{/privacy}","received_events_url":"https://api.github.com/users/jackysp/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":34,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"jackysp"}}