{"action":"created","issue":{"url":"https://api.github.com/repos/steemit/steem/issues/3014","repository_url":"https://api.github.com/repos/steemit/steem","labels_url":"https://api.github.com/repos/steemit/steem/issues/3014/labels{/name}","comments_url":"https://api.github.com/repos/steemit/steem/issues/3014/comments","events_url":"https://api.github.com/repos/steemit/steem/issues/3014/events","html_url":"https://github.com/steemit/steem/issues/3014","id":365507838,"node_id":"MDU6SXNzdWUzNjU1MDc4Mzg=","number":3014,"title":"Community - Are the default config values for RC and bandwidth checking correct?","user":{"login":"TimCliff","id":20735105,"node_id":"MDQ6VXNlcjIwNzM1MTA1","avatar_url":"https://avatars3.githubusercontent.com/u/20735105?v=4","gravatar_id":"","url":"https://api.github.com/users/TimCliff","html_url":"https://github.com/TimCliff","followers_url":"https://api.github.com/users/TimCliff/followers","following_url":"https://api.github.com/users/TimCliff/following{/other_user}","gists_url":"https://api.github.com/users/TimCliff/gists{/gist_id}","starred_url":"https://api.github.com/users/TimCliff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimCliff/subscriptions","organizations_url":"https://api.github.com/users/TimCliff/orgs","repos_url":"https://api.github.com/users/TimCliff/repos","events_url":"https://api.github.com/users/TimCliff/events{/privacy}","received_events_url":"https://api.github.com/users/TimCliff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"theoreticalbts","id":10215982,"node_id":"MDQ6VXNlcjEwMjE1OTgy","avatar_url":"https://avatars3.githubusercontent.com/u/10215982?v=4","gravatar_id":"","url":"https://api.github.com/users/theoreticalbts","html_url":"https://github.com/theoreticalbts","followers_url":"https://api.github.com/users/theoreticalbts/followers","following_url":"https://api.github.com/users/theoreticalbts/following{/other_user}","gists_url":"https://api.github.com/users/theoreticalbts/gists{/gist_id}","starred_url":"https://api.github.com/users/theoreticalbts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theoreticalbts/subscriptions","organizations_url":"https://api.github.com/users/theoreticalbts/orgs","repos_url":"https://api.github.com/users/theoreticalbts/repos","events_url":"https://api.github.com/users/theoreticalbts/events{/privacy}","received_events_url":"https://api.github.com/users/theoreticalbts/received_events","type":"User","site_admin":false},"assignees":[{"login":"theoreticalbts","id":10215982,"node_id":"MDQ6VXNlcjEwMjE1OTgy","avatar_url":"https://avatars3.githubusercontent.com/u/10215982?v=4","gravatar_id":"","url":"https://api.github.com/users/theoreticalbts","html_url":"https://github.com/theoreticalbts","followers_url":"https://api.github.com/users/theoreticalbts/followers","following_url":"https://api.github.com/users/theoreticalbts/following{/other_user}","gists_url":"https://api.github.com/users/theoreticalbts/gists{/gist_id}","starred_url":"https://api.github.com/users/theoreticalbts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theoreticalbts/subscriptions","organizations_url":"https://api.github.com/users/theoreticalbts/orgs","repos_url":"https://api.github.com/users/theoreticalbts/repos","events_url":"https://api.github.com/users/theoreticalbts/events{/privacy}","received_events_url":"https://api.github.com/users/theoreticalbts/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-01T15:09:34Z","updated_at":"2018-10-01T20:42:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"If I build and launch a fresh instance of steemd, the config.ini file is auto-generated with the following defaults:\r\n\r\n```\r\nrc-skip-reject-not-enough-rc = false\r\nwitness-skip-enforce-bandwidth = false\r\n```\r\n\r\nIs this correct?"},"comment":{"url":"https://api.github.com/repos/steemit/steem/issues/comments/426055559","html_url":"https://github.com/steemit/steem/issues/3014#issuecomment-426055559","issue_url":"https://api.github.com/repos/steemit/steem/issues/3014","id":426055559,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjA1NTU1OQ==","user":{"login":"theoreticalbts","id":10215982,"node_id":"MDQ6VXNlcjEwMjE1OTgy","avatar_url":"https://avatars3.githubusercontent.com/u/10215982?v=4","gravatar_id":"","url":"https://api.github.com/users/theoreticalbts","html_url":"https://github.com/theoreticalbts","followers_url":"https://api.github.com/users/theoreticalbts/followers","following_url":"https://api.github.com/users/theoreticalbts/following{/other_user}","gists_url":"https://api.github.com/users/theoreticalbts/gists{/gist_id}","starred_url":"https://api.github.com/users/theoreticalbts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theoreticalbts/subscriptions","organizations_url":"https://api.github.com/users/theoreticalbts/orgs","repos_url":"https://api.github.com/users/theoreticalbts/repos","events_url":"https://api.github.com/users/theoreticalbts/events{/privacy}","received_events_url":"https://api.github.com/users/theoreticalbts/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T20:42:32Z","updated_at":"2018-10-01T20:42:32Z","author_association":"CONTRIBUTOR","body":"Related:  https://github.com/steemit/steem/issues/2703\r\n\r\nThere's an actual problem here.  There's a known problem where the default `config.ini` generated in an empty `--data-dir` doesn't have a usable flag combination, contrary to what's specified in the code.  I searched, but I can't seem to find the exact issue number, so let's use this issue for that problem.\r\n\r\nUpon reading the `boost::program_options` docs, I think the problem is caused by using `bool_switch()` instead of `value<bool>` for config file options.  I've located all places in the code, and changed them appropriately.  This should fix the auto-generated configuration file.\r\n\r\nHere's the backstory on the naming:  The internal API for the `database` class has a bunch of flags that can disable parts of normal processing (for example, blocks read from local disk are assumed to be trusted, so no need to cryptographically check signatures -- we assume you checked them when you first downloaded the chain).\r\n\r\nThe `database` class flags are \"skip flags,\" which have the semantics of:\r\n\r\n- `false` -- do the usual, full checking\r\n- `true` -- skip something for performance or other reasons\r\n\r\nThe flags exposed by the plugins follow the same rule:\r\n\r\n- `false` -- do full checking of bandwidth and rejection of transactions that exceed it\r\n- `true` -- skip checking bandwidth for whatever reason\r\n\r\nThe old bandwidth algorithm is going to be removed from the witness plugin, see #3006, so in some future release, only one of these flags will be relevant.\r\n"}}
{"actor":{"display_login":"theoreticalbts"}}