{"action":"created","issue":{"url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/303","repository_url":"https://api.github.com/repos/NAVCoin/navcoin-core","labels_url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/303/comments","events_url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/303/events","html_url":"https://github.com/NAVCoin/navcoin-core/issues/303","id":365193920,"node_id":"MDU6SXNzdWUzNjUxOTM5MjA=","number":303,"title":"cfund: Invalidating first block of new cycle does not revert proposal votes","user":{"login":"gagor15","id":16151403,"node_id":"MDQ6VXNlcjE2MTUxNDAz","avatar_url":"https://avatars0.githubusercontent.com/u/16151403?v=4","gravatar_id":"","url":"https://api.github.com/users/gagor15","html_url":"https://github.com/gagor15","followers_url":"https://api.github.com/users/gagor15/followers","following_url":"https://api.github.com/users/gagor15/following{/other_user}","gists_url":"https://api.github.com/users/gagor15/gists{/gist_id}","starred_url":"https://api.github.com/users/gagor15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagor15/subscriptions","organizations_url":"https://api.github.com/users/gagor15/orgs","repos_url":"https://api.github.com/users/gagor15/repos","events_url":"https://api.github.com/users/gagor15/events{/privacy}","received_events_url":"https://api.github.com/users/gagor15/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-30T05:30:58Z","updated_at":"2018-09-30T22:00:46Z","closed_at":null,"author_association":"NONE","body":"On the first block of a new voting cycle, the proposal's `votingCycle` increments and `votesYes` and `votesNo` get set to 0 from their values in the previous cycle.\r\n\r\nIf this first block of a new voting cycle gets invalidated, the `votingCycle` reverts, but the votes still remain at 0.\r\n\r\nI found this by running the `qa/pull-tester/rpc-tests.py cfund-vote` test which fails because of this.\r\nMight be related to #302 "},"comment":{"url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/comments/425755614","html_url":"https://github.com/NAVCoin/navcoin-core/issues/303#issuecomment-425755614","issue_url":"https://api.github.com/repos/NAVCoin/navcoin-core/issues/303","id":425755614,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTc1NTYxNA==","user":{"login":"gagor15","id":16151403,"node_id":"MDQ6VXNlcjE2MTUxNDAz","avatar_url":"https://avatars0.githubusercontent.com/u/16151403?v=4","gravatar_id":"","url":"https://api.github.com/users/gagor15","html_url":"https://github.com/gagor15","followers_url":"https://api.github.com/users/gagor15/followers","following_url":"https://api.github.com/users/gagor15/following{/other_user}","gists_url":"https://api.github.com/users/gagor15/gists{/gist_id}","starred_url":"https://api.github.com/users/gagor15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagor15/subscriptions","organizations_url":"https://api.github.com/users/gagor15/orgs","repos_url":"https://api.github.com/users/gagor15/repos","events_url":"https://api.github.com/users/gagor15/events{/privacy}","received_events_url":"https://api.github.com/users/gagor15/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T22:00:46Z","updated_at":"2018-09-30T22:00:46Z","author_association":"NONE","body":"Yep, that fixes it.\r\n\r\nThere is a small side effect for me though:\r\nWhen expiring, a proposal goes from `'status': 'expired waiting for end of voting period', 'state': 0` to `'status': 'pending', 'state': 3` instead of `'status': 'expired', 'state': 3`\r\n\r\nI guess it's just cosmetic, but I couldn't figure out why it happens.\r\nThis does not happen for expiring payment requests."}}
{"actor":{"display_login":"gagor15"}}