{"action":"created","comment":{"url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/comments/220910920","pull_request_review_id":159429765,"id":220910920,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDkxMDkyMA==","diff_hunk":"@@ -266,7 +277,7 @@\n             ;\n             return typeof tst === 'undefined' ? str : ('[object ' + tst + ']');\n           };\n-          dP(ObjectProto, 'toString', descriptor);\n+          dP(/** @type {!Object} */(ObjectProto), 'toString', descriptor);","path":"src/get-own-property-symbols.js","position":225,"original_position":225,"commit_id":"f549b136320c25a206f108246791e8c016c7043f","original_commit_id":"f549b136320c25a206f108246791e8c016c7043f","user":{"login":"ljharb","id":45469,"node_id":"MDQ6VXNlcjQ1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Your type checker shouldn’t be checking code you didn’t write.\r\n\r\nThe way Flow and TS handle this is with external packages that define the types for a package’s interface. Does Closure Compiler not have a similar capability?","created_at":"2018-09-27T12:54:43Z","updated_at":"2018-09-27T12:54:43Z","html_url":"https://github.com/es-shims/get-own-property-symbols/pull/14#discussion_r220910920","pull_request_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/comments/220910920"},"html":{"href":"https://github.com/es-shims/get-own-property-symbols/pull/14#discussion_r220910920"},"pull_request":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14"}},"in_reply_to_id":220905250},"pull_request":{"url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14","id":218609811,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjA5ODEx","html_url":"https://github.com/es-shims/get-own-property-symbols/pull/14","diff_url":"https://github.com/es-shims/get-own-property-symbols/pull/14.diff","patch_url":"https://github.com/es-shims/get-own-property-symbols/pull/14.patch","issue_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/14","number":14,"state":"open","locked":false,"title":"Typecheck with Closure compiler and fix warnings","user":{"login":"TimvdLippe","id":5948271,"node_id":"MDQ6VXNlcjU5NDgyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"body":"We are using this polyfill in a project which also uses Closure Compiler. The compiler was not able to follow some of the implementation practices. In particular, the usage of `defineProperty` by reassigning to the same `descriptor` was not typecheckable.\r\n\r\nI have added the required JSDoc and refactored some of the definitions to make this more clear. This mostly meant that instead of doing `descriptor.value = ...`, it now inlines that `value` definition directly in the `defineProperty` call.","created_at":"2018-09-27T11:00:29Z","updated_at":"2018-09-27T12:54:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71c465397108022a08defd7cc968c338c1e920cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14/commits","review_comments_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14/comments","review_comment_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/comments{/number}","comments_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/14/comments","statuses_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/statuses/f549b136320c25a206f108246791e8c016c7043f","head":{"label":"TimvdLippe:typecheck-closure-compiler","ref":"typecheck-closure-compiler","sha":"f549b136320c25a206f108246791e8c016c7043f","user":{"login":"TimvdLippe","id":5948271,"node_id":"MDQ6VXNlcjU5NDgyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"repo":{"id":150572843,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1NzI4NDM=","name":"get-own-property-symbols","full_name":"TimvdLippe/get-own-property-symbols","private":false,"owner":{"login":"TimvdLippe","id":5948271,"node_id":"MDQ6VXNlcjU5NDgyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TimvdLippe/get-own-property-symbols","description":"ES6 Object.getOwnPropertySymbols partial polyfill","fork":true,"url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols","forks_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/forks","keys_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/teams","hooks_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/hooks","issue_events_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/issues/events{/number}","events_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/events","assignees_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/assignees{/user}","branches_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/branches{/branch}","tags_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/tags","blobs_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/statuses/{sha}","languages_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/languages","stargazers_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/stargazers","contributors_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/contributors","subscribers_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/subscribers","subscription_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/subscription","commits_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/contents/{+path}","compare_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/merges","archive_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/downloads","issues_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/issues{/number}","pulls_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/pulls{/number}","milestones_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/milestones{/number}","notifications_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/labels{/name}","releases_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/releases{/id}","deployments_url":"https://api.github.com/repos/TimvdLippe/get-own-property-symbols/deployments","created_at":"2018-09-27T10:56:57Z","updated_at":"2018-09-27T10:56:59Z","pushed_at":"2018-09-27T10:58:59Z","git_url":"git://github.com/TimvdLippe/get-own-property-symbols.git","ssh_url":"git@github.com:TimvdLippe/get-own-property-symbols.git","clone_url":"https://github.com/TimvdLippe/get-own-property-symbols.git","svn_url":"https://github.com/TimvdLippe/get-own-property-symbols","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"es-shims:master","ref":"master","sha":"824eddd62e3bca26952ccd40f0404a2f1f3850e6","user":{"login":"es-shims","id":6288429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODg0Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"repo":{"id":34051495,"node_id":"MDEwOlJlcG9zaXRvcnkzNDA1MTQ5NQ==","name":"get-own-property-symbols","full_name":"es-shims/get-own-property-symbols","private":false,"owner":{"login":"es-shims","id":6288429,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODg0Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/6288429?v=4","gravatar_id":"","url":"https://api.github.com/users/es-shims","html_url":"https://github.com/es-shims","followers_url":"https://api.github.com/users/es-shims/followers","following_url":"https://api.github.com/users/es-shims/following{/other_user}","gists_url":"https://api.github.com/users/es-shims/gists{/gist_id}","starred_url":"https://api.github.com/users/es-shims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es-shims/subscriptions","organizations_url":"https://api.github.com/users/es-shims/orgs","repos_url":"https://api.github.com/users/es-shims/repos","events_url":"https://api.github.com/users/es-shims/events{/privacy}","received_events_url":"https://api.github.com/users/es-shims/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/es-shims/get-own-property-symbols","description":"ES6 Object.getOwnPropertySymbols partial polyfill","fork":false,"url":"https://api.github.com/repos/es-shims/get-own-property-symbols","forks_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/forks","keys_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/keys{/key_id}","collaborators_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/teams","hooks_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/hooks","issue_events_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/events{/number}","events_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/events","assignees_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/assignees{/user}","branches_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/branches{/branch}","tags_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/tags","blobs_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/git/refs{/sha}","trees_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/git/trees{/sha}","statuses_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/statuses/{sha}","languages_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/languages","stargazers_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/stargazers","contributors_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/contributors","subscribers_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/subscribers","subscription_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/subscription","commits_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/commits{/sha}","git_commits_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/git/commits{/sha}","comments_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/comments{/number}","issue_comment_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/comments{/number}","contents_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/contents/{+path}","compare_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/compare/{base}...{head}","merges_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/merges","archive_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/downloads","issues_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues{/number}","pulls_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls{/number}","milestones_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/milestones{/number}","notifications_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/labels{/name}","releases_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/releases{/id}","deployments_url":"https://api.github.com/repos/es-shims/get-own-property-symbols/deployments","created_at":"2015-04-16T11:18:06Z","updated_at":"2018-07-11T10:23:06Z","pushed_at":"2018-09-27T11:00:30Z","git_url":"git://github.com/es-shims/get-own-property-symbols.git","ssh_url":"git@github.com:es-shims/get-own-property-symbols.git","clone_url":"https://github.com/es-shims/get-own-property-symbols.git","svn_url":"https://github.com/es-shims/get-own-property-symbols","homepage":null,"size":69,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14"},"html":{"href":"https://github.com/es-shims/get-own-property-symbols/pull/14"},"issue":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/14"},"comments":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/es-shims/get-own-property-symbols/statuses/f549b136320c25a206f108246791e8c016c7043f"}},"author_association":"NONE"}}
{"actor":{"display_login":"ljharb"}}