{"push_id":2716745077,"size":1,"distinct_size":1,"ref":"refs/heads/dnf-makecache-systemd","head":"4565035958aad2784b23086ec99b2bcb7588e389","before":"3b4b1463bd8f99cd0218ee7b433a5e5f9deacfab","commits":[{"sha":"4565035958aad2784b23086ec99b2bcb7588e389","author":{"name":"Adam Williamson","email":"9343557fe728326ecca60ea600eccabb6754179b@redhat.com"},"message":"dnf-makecache.timer: move to multi-user to fix loop\n\nIn ee96304, `After=network-online.target` was added to the\ndnf-makecache.timer service definition. However, it was already\n`WantedBy=basic.target`. These two requests are contradictory\nin Fedora and probably most distributions, as it seems that\nnetwork-online.target requires NetworkManager.service, and\nNetworkManger.service requires basic.target. systemd is forced\nto break this loop somehow: my testing suggests that it usually\ndoes so by throwing dnf-makecache.timer out of the process, but\nsometimes does it by throwing NetworkManager out of the process,\nresulting in the network unexpectedly not coming up.\n\nThis commit resolves this simply having dnf-makecache.timer\nWantedBy multi-user.target, not basic.target. I don't think we\n*really* want DNF refreshing its caches in what is basically a\nrecovery environment, after all, and NetworkManager itself is\nWantedBy multi-user.target, so if you actually only boot to\nbasic.target, there is no network up at all after boot (I've\ntested this).\n\nThere are other options (e.g. dropping the After network-online\nordering and just trusting the Wants and the ten-minute startup\ndelay to be sufficient), but we certainly should resolve this\none way or another.\n\nResolves: rhbz#1600823\n\nSigned-off-by: Adam Williamson <awilliam@redhat.com>","distinct":true,"url":"https://api.github.com/repos/AdamWill/dnf/commits/4565035958aad2784b23086ec99b2bcb7588e389"}]}
{"actor":{"display_login":"AdamWill"}}