{"action":"created","comment":{"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments/172258959","pull_request_review_id":101245698,"id":172258959,"diff_hunk":"@@ -466,6 +520,40 @@ describe(\"ouiField\", () => {\n             });\n         });\n \n+        describe(\"with validation\", () => {","path":"packages/oui-field/src/index.spec.js","position":95,"original_position":95,"commit_id":"008cb896e543313836a6f5e9a373196e01d2f21f","original_commit_id":"0e3254335c9c319a977ba801f12e43ce1ed4be53","user":{"login":"tremblaymath","id":10472038,"avatar_url":"https://avatars2.githubusercontent.com/u/10472038?v=4","gravatar_id":"","url":"https://api.github.com/users/tremblaymath","html_url":"https://github.com/tremblaymath","followers_url":"https://api.github.com/users/tremblaymath/followers","following_url":"https://api.github.com/users/tremblaymath/following{/other_user}","gists_url":"https://api.github.com/users/tremblaymath/gists{/gist_id}","starred_url":"https://api.github.com/users/tremblaymath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremblaymath/subscriptions","organizations_url":"https://api.github.com/users/tremblaymath/orgs","repos_url":"https://api.github.com/users/tremblaymath/repos","events_url":"https://api.github.com/users/tremblaymath/events{/privacy}","received_events_url":"https://api.github.com/users/tremblaymath/received_events","type":"User","site_admin":false},"body":"Yes I agree, provider should be mocked and we should only \"verify it's actually using the one from the provider\"\r\nThere was already missing tests before you start","created_at":"2018-03-05T17:06:35Z","updated_at":"2018-03-05T17:06:35Z","html_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/109#discussion_r172258959","pull_request_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments/172258959"},"html":{"href":"https://github.com/ovh-ux/ovh-ui-angular/pull/109#discussion_r172258959"},"pull_request":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109"}},"in_reply_to_id":171936346},"pull_request":{"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109","id":172031016,"html_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/109","diff_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/109.diff","patch_url":"https://github.com/ovh-ux/ovh-ui-angular/pull/109.patch","issue_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/109","number":109,"state":"open","locked":false,"title":"feat(field): add custom error message and ng-pattern support","user":{"login":"JDownloader","id":1476965,"avatar_url":"https://avatars1.githubusercontent.com/u/1476965?v=4","gravatar_id":"","url":"https://api.github.com/users/JDownloader","html_url":"https://github.com/JDownloader","followers_url":"https://api.github.com/users/JDownloader/followers","following_url":"https://api.github.com/users/JDownloader/following{/other_user}","gists_url":"https://api.github.com/users/JDownloader/gists{/gist_id}","starred_url":"https://api.github.com/users/JDownloader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDownloader/subscriptions","organizations_url":"https://api.github.com/users/JDownloader/orgs","repos_url":"https://api.github.com/users/JDownloader/repos","events_url":"https://api.github.com/users/JDownloader/events{/privacy}","received_events_url":"https://api.github.com/users/JDownloader/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-28T18:12:33Z","updated_at":"2018-03-05T17:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bb930c5b18a3b3419b56b4152eef98811483714","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":651886040,"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109/commits","review_comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109/comments","review_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/109/comments","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/008cb896e543313836a6f5e9a373196e01d2f21f","head":{"label":"ovh-ux:feature/field-custom-error-messages","ref":"feature/field-custom-error-messages","sha":"008cb896e543313836a6f5e9a373196e01d2f21f","user":{"login":"ovh-ux","id":26575234,"avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":97920934,"name":"ovh-ui-angular","full_name":"ovh-ux/ovh-ui-angular","owner":{"login":"ovh-ux","id":26575234,"avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh-ux/ovh-ui-angular","description":"A set of maintainable components for the OVH ecosystem (Angular).","fork":false,"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular","forks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/forks","keys_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/events","assignees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/merges","archive_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/deployments","created_at":"2017-07-21T07:46:15Z","updated_at":"2018-02-26T20:42:40Z","pushed_at":"2018-03-05T16:59:28Z","git_url":"git://github.com/ovh-ux/ovh-ui-angular.git","ssh_url":"git@github.com:ovh-ux/ovh-ui-angular.git","clone_url":"https://github.com/ovh-ux/ovh-ui-angular.git","svn_url":"https://github.com/ovh-ux/ovh-ui-angular","homepage":"http://ui-kit.ovh","size":3144,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"ovh-ux:master","ref":"master","sha":"a448aa5e77deaaa51dde7ff8d65adaec03de03e9","user":{"login":"ovh-ux","id":26575234,"avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"repo":{"id":97920934,"name":"ovh-ui-angular","full_name":"ovh-ux/ovh-ui-angular","owner":{"login":"ovh-ux","id":26575234,"avatar_url":"https://avatars2.githubusercontent.com/u/26575234?v=4","gravatar_id":"","url":"https://api.github.com/users/ovh-ux","html_url":"https://github.com/ovh-ux","followers_url":"https://api.github.com/users/ovh-ux/followers","following_url":"https://api.github.com/users/ovh-ux/following{/other_user}","gists_url":"https://api.github.com/users/ovh-ux/gists{/gist_id}","starred_url":"https://api.github.com/users/ovh-ux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovh-ux/subscriptions","organizations_url":"https://api.github.com/users/ovh-ux/orgs","repos_url":"https://api.github.com/users/ovh-ux/repos","events_url":"https://api.github.com/users/ovh-ux/events{/privacy}","received_events_url":"https://api.github.com/users/ovh-ux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ovh-ux/ovh-ui-angular","description":"A set of maintainable components for the OVH ecosystem (Angular).","fork":false,"url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular","forks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/forks","keys_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/teams","hooks_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/hooks","issue_events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/events{/number}","events_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/events","assignees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/assignees{/user}","branches_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/branches{/branch}","tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/tags","blobs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/languages","stargazers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/stargazers","contributors_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contributors","subscribers_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscribers","subscription_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/subscription","commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/contents/{+path}","compare_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/merges","archive_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/downloads","issues_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues{/number}","pulls_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/labels{/name}","releases_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/releases{/id}","deployments_url":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/deployments","created_at":"2017-07-21T07:46:15Z","updated_at":"2018-02-26T20:42:40Z","pushed_at":"2018-03-05T16:59:28Z","git_url":"git://github.com/ovh-ux/ovh-ui-angular.git","ssh_url":"git@github.com:ovh-ux/ovh-ui-angular.git","clone_url":"https://github.com/ovh-ux/ovh-ui-angular.git","svn_url":"https://github.com/ovh-ux/ovh-ui-angular","homepage":"http://ui-kit.ovh","size":3144,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109"},"html":{"href":"https://github.com/ovh-ux/ovh-ui-angular/pull/109"},"issue":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/109"},"comments":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/ovh-ux/ovh-ui-angular/statuses/008cb896e543313836a6f5e9a373196e01d2f21f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tremblaymath"}}