{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/comments/165235889","pull_request_review_id":93140624,"id":165235889,"diff_hunk":"@@ -0,0 +1,87 @@\n+﻿// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.\n+\n+using System.Linq;\n+using Microsoft.VisualStudio.Shell;\n+using Microsoft.VisualStudio.ProjectSystem.Input;\n+using System.Threading.Tasks;\n+using System;\n+using System.Collections.Generic;\n+\n+namespace Microsoft.VisualStudio.ProjectSystem.VS.Input.Commands.Ordering\n+{\n+    internal abstract class AbstractAddItemCommand : AbstractSingleNodeProjectCommand\n+    {\n+        private readonly IPhysicalProjectTree _projectTree;\n+        private readonly IUnconfiguredProjectVsServices _projectVsServices;\n+        private readonly SVsServiceProvider _serviceProvider;\n+\n+        public AbstractAddItemCommand(IPhysicalProjectTree projectTree, IUnconfiguredProjectVsServices projectVsServices, SVsServiceProvider serviceProvider)\n+        {\n+            Requires.NotNull(projectTree, nameof(IPhysicalProjectTree));\n+            Requires.NotNull(projectVsServices, nameof(IUnconfiguredProjectVsServices));\n+            Requires.NotNull(serviceProvider, nameof(SVsServiceProvider));\n+\n+            _projectTree = projectTree;\n+            _projectVsServices = projectVsServices;\n+            _serviceProvider = serviceProvider;\n+        }\n+\n+        protected abstract bool CanAdd(IProjectTree target);\n+\n+        protected abstract IProjectTree GetNodeToAddTo(IProjectTree target);\n+\n+        protected abstract System.Threading.Tasks.Task OnAddingNodesAsync(IProjectTree nodeToAddTo);\n+\n+        protected abstract System.Threading.Tasks.Task OnAddedNodesAsync(ConfiguredProject configuredProject, IEnumerable<IProjectTree> addedNodes, IProjectTree target);\n+\n+        protected System.Threading.Tasks.Task ShowAddNewFileDialogAsync(IProjectTree target)","path":"src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Input/Commands/Ordering/AbstractAddItemCommand.cs","position":37,"original_position":37,"commit_id":"5143b276c9af69e7bb50046917aa706a29545df1","original_commit_id":"5143b276c9af69e7bb50046917aa706a29545df1","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars3.githubusercontent.com/u/312835?v=4","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"body":"Nit: Does this need to be qualified?  Consider a using alias for `Task` if so.","created_at":"2018-02-01T01:11:43Z","updated_at":"2018-02-01T01:19:41Z","html_url":"https://github.com/dotnet/project-system/pull/3206#discussion_r165235889","pull_request_url":"https://api.github.com/repos/dotnet/project-system/pulls/3206","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments/165235889"},"html":{"href":"https://github.com/dotnet/project-system/pull/3206#discussion_r165235889"},"pull_request":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/3206"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/3206","id":166406646,"html_url":"https://github.com/dotnet/project-system/pull/3206","diff_url":"https://github.com/dotnet/project-system/pull/3206.diff","patch_url":"https://github.com/dotnet/project-system/pull/3206.patch","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/3206","number":3206,"state":"open","locked":false,"title":"Added Add Above and Add Below commands for files","user":{"login":"TIHan","id":1278959,"avatar_url":"https://avatars3.githubusercontent.com/u/1278959?v=4","gravatar_id":"","url":"https://api.github.com/users/TIHan","html_url":"https://github.com/TIHan","followers_url":"https://api.github.com/users/TIHan/followers","following_url":"https://api.github.com/users/TIHan/following{/other_user}","gists_url":"https://api.github.com/users/TIHan/gists{/gist_id}","starred_url":"https://api.github.com/users/TIHan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TIHan/subscriptions","organizations_url":"https://api.github.com/users/TIHan/orgs","repos_url":"https://api.github.com/users/TIHan/repos","events_url":"https://api.github.com/users/TIHan/events{/privacy}","received_events_url":"https://api.github.com/users/TIHan/received_events","type":"User","site_admin":false},"body":"**Customer scenario**\r\n\r\nUsers need to be able to add files above and below existing files in solution explorer for languages that need file ordering, such as F#.\r\n\r\n**Bugs this fixes:** \r\n\r\nhttps://github.com/dotnet/project-system/issues/2887\r\n\r\n**Workarounds, if any**\r\n\r\nAdd a file and move it using solution explorer or editing the proj file.\r\n\r\n**Risk**\r\n\r\nAdds some changes to existing ordering for moving up and down, but nothing significant. Ordering work is self contained.\r\n\r\n**Performance impact**\r\n\r\nNo performance impact.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo\r\n\r\n**Root cause analysis:**\r\n\r\nFeature was not implemented to begin with.\r\n\r\n**How was the bug found?**\r\n\r\nFeature was not implemented to begin with.\r\n\r\n---\r\n\r\nA few comments:\r\n\r\nThese changes are only just for adding files above and below other files or folders. It also overrides the behavior for the standard add new item/add existing item for languages that need file ordering, F#.\r\n\r\nThe commands for ordering are in their own folder to keep everything organized.","created_at":"2018-01-31T23:38:20Z","updated_at":"2018-02-01T01:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c43ed172ba80a2656fdb47220a850d22ee356f3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars2.githubusercontent.com/u/9797472?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/project-system/pulls/3206/commits","review_comments_url":"https://api.github.com/repos/dotnet/project-system/pulls/3206/comments","review_comment_url":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/3206/comments","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/5143b276c9af69e7bb50046917aa706a29545df1","head":{"label":"TIHan:AddAboveAndBelowCommands","ref":"AddAboveAndBelowCommands","sha":"5143b276c9af69e7bb50046917aa706a29545df1","user":{"login":"TIHan","id":1278959,"avatar_url":"https://avatars3.githubusercontent.com/u/1278959?v=4","gravatar_id":"","url":"https://api.github.com/users/TIHan","html_url":"https://github.com/TIHan","followers_url":"https://api.github.com/users/TIHan/followers","following_url":"https://api.github.com/users/TIHan/following{/other_user}","gists_url":"https://api.github.com/users/TIHan/gists{/gist_id}","starred_url":"https://api.github.com/users/TIHan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TIHan/subscriptions","organizations_url":"https://api.github.com/users/TIHan/orgs","repos_url":"https://api.github.com/users/TIHan/repos","events_url":"https://api.github.com/users/TIHan/events{/privacy}","received_events_url":"https://api.github.com/users/TIHan/received_events","type":"User","site_admin":false},"repo":{"id":114840369,"name":"project-system","full_name":"TIHan/project-system","owner":{"login":"TIHan","id":1278959,"avatar_url":"https://avatars3.githubusercontent.com/u/1278959?v=4","gravatar_id":"","url":"https://api.github.com/users/TIHan","html_url":"https://github.com/TIHan","followers_url":"https://api.github.com/users/TIHan/followers","following_url":"https://api.github.com/users/TIHan/following{/other_user}","gists_url":"https://api.github.com/users/TIHan/gists{/gist_id}","starred_url":"https://api.github.com/users/TIHan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TIHan/subscriptions","organizations_url":"https://api.github.com/users/TIHan/orgs","repos_url":"https://api.github.com/users/TIHan/repos","events_url":"https://api.github.com/users/TIHan/events{/privacy}","received_events_url":"https://api.github.com/users/TIHan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TIHan/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":true,"url":"https://api.github.com/repos/TIHan/project-system","forks_url":"https://api.github.com/repos/TIHan/project-system/forks","keys_url":"https://api.github.com/repos/TIHan/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TIHan/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TIHan/project-system/teams","hooks_url":"https://api.github.com/repos/TIHan/project-system/hooks","issue_events_url":"https://api.github.com/repos/TIHan/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/TIHan/project-system/events","assignees_url":"https://api.github.com/repos/TIHan/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/TIHan/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/TIHan/project-system/tags","blobs_url":"https://api.github.com/repos/TIHan/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TIHan/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TIHan/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/TIHan/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TIHan/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/TIHan/project-system/languages","stargazers_url":"https://api.github.com/repos/TIHan/project-system/stargazers","contributors_url":"https://api.github.com/repos/TIHan/project-system/contributors","subscribers_url":"https://api.github.com/repos/TIHan/project-system/subscribers","subscription_url":"https://api.github.com/repos/TIHan/project-system/subscription","commits_url":"https://api.github.com/repos/TIHan/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/TIHan/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/TIHan/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/TIHan/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/TIHan/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/TIHan/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TIHan/project-system/merges","archive_url":"https://api.github.com/repos/TIHan/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TIHan/project-system/downloads","issues_url":"https://api.github.com/repos/TIHan/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/TIHan/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/TIHan/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/TIHan/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TIHan/project-system/labels{/name}","releases_url":"https://api.github.com/repos/TIHan/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/TIHan/project-system/deployments","created_at":"2017-12-20T03:51:25Z","updated_at":"2017-12-20T03:51:32Z","pushed_at":"2018-02-01T00:24:21Z","git_url":"git://github.com/TIHan/project-system.git","ssh_url":"git@github.com:TIHan/project-system.git","clone_url":"https://github.com/TIHan/project-system.git","svn_url":"https://github.com/TIHan/project-system","homepage":"","size":17281,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev15.6.x","ref":"dev15.6.x","sha":"b8ab88b8ec7f517d6748221599be4c4068185024","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"project-system","full_name":"dotnet/project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":false,"url":"https://api.github.com/repos/dotnet/project-system","forks_url":"https://api.github.com/repos/dotnet/project-system/forks","keys_url":"https://api.github.com/repos/dotnet/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/project-system/events","assignees_url":"https://api.github.com/repos/dotnet/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/project-system/merges","archive_url":"https://api.github.com/repos/dotnet/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2018-01-30T18:15:06Z","pushed_at":"2018-02-01T00:24:22Z","git_url":"git://github.com/dotnet/project-system.git","ssh_url":"git@github.com:dotnet/project-system.git","clone_url":"https://github.com/dotnet/project-system.git","svn_url":"https://github.com/dotnet/project-system","homepage":"","size":17277,"stargazers_count":318,"watchers_count":318,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":520,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":111,"open_issues":520,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/3206"},"html":{"href":"https://github.com/dotnet/project-system/pull/3206"},"issue":{"href":"https://api.github.com/repos/dotnet/project-system/issues/3206"},"comments":{"href":"https://api.github.com/repos/dotnet/project-system/issues/3206/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/3206/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/3206/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/project-system/statuses/5143b276c9af69e7bb50046917aa706a29545df1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Pilchie"}}