{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/204240483","pull_request_review_id":139287736,"id":204240483,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI0MDQ4Mw==","diff_hunk":"@@ -71,6 +71,18 @@ def initialize(controller, env, defaults)\n     end\n \n     # Render templates with any options from ActionController::Base#render_to_string.\n+    #\n+    # The primary options are:\n+    # * <tt>:partial</tt> - See <tt>ActionView::PartialRenderer</tt> for details.\n+    # * <tt>:file</tt> - Renders an explicit template file. Add <tt>:locals</tt> to pass in, if so desired.","path":"actionpack/lib/action_controller/renderer.rb","position":7,"original_position":7,"commit_id":"e28cef0e341b6265b93ccffa327212139275f304","original_commit_id":"e28cef0e341b6265b93ccffa327212139275f304","user":{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"body":"I’m fine as written but would love mentioning. That we Rails performs no validation for you and that it shouldn’t be used directly with unsanitized user input.","created_at":"2018-07-22T13:36:23Z","updated_at":"2018-07-22T13:37:39Z","html_url":"https://github.com/rails/rails/pull/30745#discussion_r204240483","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/30745","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/204240483"},"html":{"href":"https://github.com/rails/rails/pull/30745#discussion_r204240483"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/30745"}},"in_reply_to_id":183594127},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/30745","id":143729575,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQzNzI5NTc1","html_url":"https://github.com/rails/rails/pull/30745","diff_url":"https://github.com/rails/rails/pull/30745.diff","patch_url":"https://github.com/rails/rails/pull/30745.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/30745","number":30745,"state":"open","locked":false,"title":"Add render options in action_controller/renderer for api docs [ci skip]","user":{"login":"PHedkvist","id":2817059,"node_id":"MDQ6VXNlcjI4MTcwNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2817059?v=4","gravatar_id":"","url":"https://api.github.com/users/PHedkvist","html_url":"https://github.com/PHedkvist","followers_url":"https://api.github.com/users/PHedkvist/followers","following_url":"https://api.github.com/users/PHedkvist/following{/other_user}","gists_url":"https://api.github.com/users/PHedkvist/gists{/gist_id}","starred_url":"https://api.github.com/users/PHedkvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHedkvist/subscriptions","organizations_url":"https://api.github.com/users/PHedkvist/orgs","repos_url":"https://api.github.com/users/PHedkvist/repos","events_url":"https://api.github.com/users/PHedkvist/events{/privacy}","received_events_url":"https://api.github.com/users/PHedkvist/received_events","type":"User","site_admin":false},"body":"Added render options as described in issue #28484. I continued from the pr https://github.com/rails/rails/pull/28784. I removed `text` as requested by @rafaelfrance since its no longer a valid option, and moved the render options to `ActionController::Rendering#render` as suggested in the previous pr. Are there any other options missing?\r\n","created_at":"2017-09-28T19:02:06Z","updated_at":"2018-07-22T13:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"729e37526f1e8704f632bd7a9d4709ead834f2fe","assignee":{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"assignees":[{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/30745/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/30745/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/30745/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e28cef0e341b6265b93ccffa327212139275f304","head":{"label":"PHedkvist:update_renderer_api_docs","ref":"update_renderer_api_docs","sha":"e28cef0e341b6265b93ccffa327212139275f304","user":{"login":"PHedkvist","id":2817059,"node_id":"MDQ6VXNlcjI4MTcwNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2817059?v=4","gravatar_id":"","url":"https://api.github.com/users/PHedkvist","html_url":"https://github.com/PHedkvist","followers_url":"https://api.github.com/users/PHedkvist/followers","following_url":"https://api.github.com/users/PHedkvist/following{/other_user}","gists_url":"https://api.github.com/users/PHedkvist/gists{/gist_id}","starred_url":"https://api.github.com/users/PHedkvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHedkvist/subscriptions","organizations_url":"https://api.github.com/users/PHedkvist/orgs","repos_url":"https://api.github.com/users/PHedkvist/repos","events_url":"https://api.github.com/users/PHedkvist/events{/privacy}","received_events_url":"https://api.github.com/users/PHedkvist/received_events","type":"User","site_admin":false},"repo":{"id":102251342,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIyNTEzNDI=","name":"rails","full_name":"PHedkvist/rails","owner":{"login":"PHedkvist","id":2817059,"node_id":"MDQ6VXNlcjI4MTcwNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2817059?v=4","gravatar_id":"","url":"https://api.github.com/users/PHedkvist","html_url":"https://github.com/PHedkvist","followers_url":"https://api.github.com/users/PHedkvist/followers","following_url":"https://api.github.com/users/PHedkvist/following{/other_user}","gists_url":"https://api.github.com/users/PHedkvist/gists{/gist_id}","starred_url":"https://api.github.com/users/PHedkvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHedkvist/subscriptions","organizations_url":"https://api.github.com/users/PHedkvist/orgs","repos_url":"https://api.github.com/users/PHedkvist/repos","events_url":"https://api.github.com/users/PHedkvist/events{/privacy}","received_events_url":"https://api.github.com/users/PHedkvist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PHedkvist/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/PHedkvist/rails","forks_url":"https://api.github.com/repos/PHedkvist/rails/forks","keys_url":"https://api.github.com/repos/PHedkvist/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHedkvist/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHedkvist/rails/teams","hooks_url":"https://api.github.com/repos/PHedkvist/rails/hooks","issue_events_url":"https://api.github.com/repos/PHedkvist/rails/issues/events{/number}","events_url":"https://api.github.com/repos/PHedkvist/rails/events","assignees_url":"https://api.github.com/repos/PHedkvist/rails/assignees{/user}","branches_url":"https://api.github.com/repos/PHedkvist/rails/branches{/branch}","tags_url":"https://api.github.com/repos/PHedkvist/rails/tags","blobs_url":"https://api.github.com/repos/PHedkvist/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHedkvist/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHedkvist/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHedkvist/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHedkvist/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/PHedkvist/rails/languages","stargazers_url":"https://api.github.com/repos/PHedkvist/rails/stargazers","contributors_url":"https://api.github.com/repos/PHedkvist/rails/contributors","subscribers_url":"https://api.github.com/repos/PHedkvist/rails/subscribers","subscription_url":"https://api.github.com/repos/PHedkvist/rails/subscription","commits_url":"https://api.github.com/repos/PHedkvist/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHedkvist/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHedkvist/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHedkvist/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHedkvist/rails/contents/{+path}","compare_url":"https://api.github.com/repos/PHedkvist/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHedkvist/rails/merges","archive_url":"https://api.github.com/repos/PHedkvist/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHedkvist/rails/downloads","issues_url":"https://api.github.com/repos/PHedkvist/rails/issues{/number}","pulls_url":"https://api.github.com/repos/PHedkvist/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/PHedkvist/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/PHedkvist/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHedkvist/rails/labels{/name}","releases_url":"https://api.github.com/repos/PHedkvist/rails/releases{/id}","deployments_url":"https://api.github.com/repos/PHedkvist/rails/deployments","created_at":"2017-09-03T08:35:40Z","updated_at":"2018-06-17T08:37:55Z","pushed_at":"2018-06-17T08:37:23Z","git_url":"git://github.com/PHedkvist/rails.git","ssh_url":"git@github.com:PHedkvist/rails.git","clone_url":"https://github.com/PHedkvist/rails.git","svn_url":"https://github.com/PHedkvist/rails","homepage":"http://rubyonrails.org","size":162172,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"fbcc4bfe9a211e219da5d0bb01d894fcdaef0a0e","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-07-22T13:31:49Z","pushed_at":"2018-07-22T13:29:21Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":164446,"stargazers_count":40256,"watchers_count":40256,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16244,"mirror_url":null,"archived":false,"open_issues_count":1124,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16244,"open_issues":1124,"watchers":40256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/30745"},"html":{"href":"https://github.com/rails/rails/pull/30745"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/30745"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/30745/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/30745/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/30745/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e28cef0e341b6265b93ccffa327212139275f304"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"schneems"}}