{"action":"created","comment":{"url":"https://api.github.com/repos/mikedh/trimesh/pulls/comments/186293553","pull_request_review_id":117846233,"id":186293553,"diff_hunk":"@@ -266,6 +291,62 @@ def voxelize_subdivide(mesh, pitch, max_iter=10):\n \n     return voxels_sparse, origin_position\n \n+def voxelize_subdivide_solid(mesh,pitch,max_iter=10):\n+    voxels_sparse,origin_position=voxelize_subdivide(mesh,pitch,max_iter)\n+    #create grid and mark inner voxels\n+    max=voxels_sparse.max()+1","path":"trimesh/voxel.py","position":54,"original_position":54,"commit_id":"4b47a7931a88ae1f3f525a3211cc9f8dcf7ab887","original_commit_id":"4b47a7931a88ae1f3f525a3211cc9f8dcf7ab887","user":{"login":"mikedh","id":1403074,"avatar_url":"https://avatars2.githubusercontent.com/u/1403074?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedh","html_url":"https://github.com/mikedh","followers_url":"https://api.github.com/users/mikedh/followers","following_url":"https://api.github.com/users/mikedh/following{/other_user}","gists_url":"https://api.github.com/users/mikedh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedh/subscriptions","organizations_url":"https://api.github.com/users/mikedh/orgs","repos_url":"https://api.github.com/users/mikedh/repos","events_url":"https://api.github.com/users/mikedh/events{/privacy}","received_events_url":"https://api.github.com/users/mikedh/received_events","type":"User","site_admin":false},"body":"`max` is a builtin function- I might rename this to `max_value` or something","created_at":"2018-05-06T15:02:49Z","updated_at":"2018-05-06T15:02:49Z","html_url":"https://github.com/mikedh/trimesh/pull/166#discussion_r186293553","pull_request_url":"https://api.github.com/repos/mikedh/trimesh/pulls/166","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/comments/186293553"},"html":{"href":"https://github.com/mikedh/trimesh/pull/166#discussion_r186293553"},"pull_request":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/mikedh/trimesh/pulls/166","id":186174088,"html_url":"https://github.com/mikedh/trimesh/pull/166","diff_url":"https://github.com/mikedh/trimesh/pull/166.diff","patch_url":"https://github.com/mikedh/trimesh/pull/166.patch","issue_url":"https://api.github.com/repos/mikedh/trimesh/issues/166","number":166,"state":"open","locked":false,"title":"enhancement: solid voxelization","user":{"login":"LinJiarui","id":1543101,"avatar_url":"https://avatars0.githubusercontent.com/u/1543101?v=4","gravatar_id":"","url":"https://api.github.com/users/LinJiarui","html_url":"https://github.com/LinJiarui","followers_url":"https://api.github.com/users/LinJiarui/followers","following_url":"https://api.github.com/users/LinJiarui/following{/other_user}","gists_url":"https://api.github.com/users/LinJiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/LinJiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinJiarui/subscriptions","organizations_url":"https://api.github.com/users/LinJiarui/orgs","repos_url":"https://api.github.com/users/LinJiarui/repos","events_url":"https://api.github.com/users/LinJiarui/events{/privacy}","received_events_url":"https://api.github.com/users/LinJiarui/received_events","type":"User","site_admin":false},"body":"add methods for solid voxelization, the inner space of a trimesh can be filled by voxels, call show(solid_mode=True) for visualization","created_at":"2018-05-05T20:18:31Z","updated_at":"2018-05-06T15:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e92f485629191c64bd071d564f9e5d7423b169","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mikedh/trimesh/pulls/166/commits","review_comments_url":"https://api.github.com/repos/mikedh/trimesh/pulls/166/comments","review_comment_url":"https://api.github.com/repos/mikedh/trimesh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mikedh/trimesh/issues/166/comments","statuses_url":"https://api.github.com/repos/mikedh/trimesh/statuses/4b47a7931a88ae1f3f525a3211cc9f8dcf7ab887","head":{"label":"LinJiarui:master","ref":"master","sha":"4b47a7931a88ae1f3f525a3211cc9f8dcf7ab887","user":{"login":"LinJiarui","id":1543101,"avatar_url":"https://avatars0.githubusercontent.com/u/1543101?v=4","gravatar_id":"","url":"https://api.github.com/users/LinJiarui","html_url":"https://github.com/LinJiarui","followers_url":"https://api.github.com/users/LinJiarui/followers","following_url":"https://api.github.com/users/LinJiarui/following{/other_user}","gists_url":"https://api.github.com/users/LinJiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/LinJiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinJiarui/subscriptions","organizations_url":"https://api.github.com/users/LinJiarui/orgs","repos_url":"https://api.github.com/users/LinJiarui/repos","events_url":"https://api.github.com/users/LinJiarui/events{/privacy}","received_events_url":"https://api.github.com/users/LinJiarui/received_events","type":"User","site_admin":false},"repo":{"id":132199157,"name":"trimesh","full_name":"LinJiarui/trimesh","owner":{"login":"LinJiarui","id":1543101,"avatar_url":"https://avatars0.githubusercontent.com/u/1543101?v=4","gravatar_id":"","url":"https://api.github.com/users/LinJiarui","html_url":"https://github.com/LinJiarui","followers_url":"https://api.github.com/users/LinJiarui/followers","following_url":"https://api.github.com/users/LinJiarui/following{/other_user}","gists_url":"https://api.github.com/users/LinJiarui/gists{/gist_id}","starred_url":"https://api.github.com/users/LinJiarui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LinJiarui/subscriptions","organizations_url":"https://api.github.com/users/LinJiarui/orgs","repos_url":"https://api.github.com/users/LinJiarui/repos","events_url":"https://api.github.com/users/LinJiarui/events{/privacy}","received_events_url":"https://api.github.com/users/LinJiarui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LinJiarui/trimesh","description":"Python library for loading and using triangular meshes.","fork":true,"url":"https://api.github.com/repos/LinJiarui/trimesh","forks_url":"https://api.github.com/repos/LinJiarui/trimesh/forks","keys_url":"https://api.github.com/repos/LinJiarui/trimesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LinJiarui/trimesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LinJiarui/trimesh/teams","hooks_url":"https://api.github.com/repos/LinJiarui/trimesh/hooks","issue_events_url":"https://api.github.com/repos/LinJiarui/trimesh/issues/events{/number}","events_url":"https://api.github.com/repos/LinJiarui/trimesh/events","assignees_url":"https://api.github.com/repos/LinJiarui/trimesh/assignees{/user}","branches_url":"https://api.github.com/repos/LinJiarui/trimesh/branches{/branch}","tags_url":"https://api.github.com/repos/LinJiarui/trimesh/tags","blobs_url":"https://api.github.com/repos/LinJiarui/trimesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LinJiarui/trimesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LinJiarui/trimesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/LinJiarui/trimesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LinJiarui/trimesh/statuses/{sha}","languages_url":"https://api.github.com/repos/LinJiarui/trimesh/languages","stargazers_url":"https://api.github.com/repos/LinJiarui/trimesh/stargazers","contributors_url":"https://api.github.com/repos/LinJiarui/trimesh/contributors","subscribers_url":"https://api.github.com/repos/LinJiarui/trimesh/subscribers","subscription_url":"https://api.github.com/repos/LinJiarui/trimesh/subscription","commits_url":"https://api.github.com/repos/LinJiarui/trimesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/LinJiarui/trimesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/LinJiarui/trimesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/LinJiarui/trimesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/LinJiarui/trimesh/contents/{+path}","compare_url":"https://api.github.com/repos/LinJiarui/trimesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LinJiarui/trimesh/merges","archive_url":"https://api.github.com/repos/LinJiarui/trimesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LinJiarui/trimesh/downloads","issues_url":"https://api.github.com/repos/LinJiarui/trimesh/issues{/number}","pulls_url":"https://api.github.com/repos/LinJiarui/trimesh/pulls{/number}","milestones_url":"https://api.github.com/repos/LinJiarui/trimesh/milestones{/number}","notifications_url":"https://api.github.com/repos/LinJiarui/trimesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LinJiarui/trimesh/labels{/name}","releases_url":"https://api.github.com/repos/LinJiarui/trimesh/releases{/id}","deployments_url":"https://api.github.com/repos/LinJiarui/trimesh/deployments","created_at":"2018-05-04T23:48:14Z","updated_at":"2018-05-05T09:15:42Z","pushed_at":"2018-05-05T09:15:41Z","git_url":"git://github.com/LinJiarui/trimesh.git","ssh_url":"git@github.com:LinJiarui/trimesh.git","clone_url":"https://github.com/LinJiarui/trimesh.git","svn_url":"https://github.com/LinJiarui/trimesh","homepage":"","size":8680,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mikedh:master","ref":"master","sha":"2d8bd552ecf39b823ccac273b03abcd1334f9e58","user":{"login":"mikedh","id":1403074,"avatar_url":"https://avatars2.githubusercontent.com/u/1403074?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedh","html_url":"https://github.com/mikedh","followers_url":"https://api.github.com/users/mikedh/followers","following_url":"https://api.github.com/users/mikedh/following{/other_user}","gists_url":"https://api.github.com/users/mikedh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedh/subscriptions","organizations_url":"https://api.github.com/users/mikedh/orgs","repos_url":"https://api.github.com/users/mikedh/repos","events_url":"https://api.github.com/users/mikedh/events{/privacy}","received_events_url":"https://api.github.com/users/mikedh/received_events","type":"User","site_admin":false},"repo":{"id":11745275,"name":"trimesh","full_name":"mikedh/trimesh","owner":{"login":"mikedh","id":1403074,"avatar_url":"https://avatars2.githubusercontent.com/u/1403074?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedh","html_url":"https://github.com/mikedh","followers_url":"https://api.github.com/users/mikedh/followers","following_url":"https://api.github.com/users/mikedh/following{/other_user}","gists_url":"https://api.github.com/users/mikedh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedh/subscriptions","organizations_url":"https://api.github.com/users/mikedh/orgs","repos_url":"https://api.github.com/users/mikedh/repos","events_url":"https://api.github.com/users/mikedh/events{/privacy}","received_events_url":"https://api.github.com/users/mikedh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedh/trimesh","description":"Python library for loading and using triangular meshes.","fork":false,"url":"https://api.github.com/repos/mikedh/trimesh","forks_url":"https://api.github.com/repos/mikedh/trimesh/forks","keys_url":"https://api.github.com/repos/mikedh/trimesh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedh/trimesh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedh/trimesh/teams","hooks_url":"https://api.github.com/repos/mikedh/trimesh/hooks","issue_events_url":"https://api.github.com/repos/mikedh/trimesh/issues/events{/number}","events_url":"https://api.github.com/repos/mikedh/trimesh/events","assignees_url":"https://api.github.com/repos/mikedh/trimesh/assignees{/user}","branches_url":"https://api.github.com/repos/mikedh/trimesh/branches{/branch}","tags_url":"https://api.github.com/repos/mikedh/trimesh/tags","blobs_url":"https://api.github.com/repos/mikedh/trimesh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedh/trimesh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedh/trimesh/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedh/trimesh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedh/trimesh/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedh/trimesh/languages","stargazers_url":"https://api.github.com/repos/mikedh/trimesh/stargazers","contributors_url":"https://api.github.com/repos/mikedh/trimesh/contributors","subscribers_url":"https://api.github.com/repos/mikedh/trimesh/subscribers","subscription_url":"https://api.github.com/repos/mikedh/trimesh/subscription","commits_url":"https://api.github.com/repos/mikedh/trimesh/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedh/trimesh/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedh/trimesh/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedh/trimesh/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedh/trimesh/contents/{+path}","compare_url":"https://api.github.com/repos/mikedh/trimesh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedh/trimesh/merges","archive_url":"https://api.github.com/repos/mikedh/trimesh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedh/trimesh/downloads","issues_url":"https://api.github.com/repos/mikedh/trimesh/issues{/number}","pulls_url":"https://api.github.com/repos/mikedh/trimesh/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedh/trimesh/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedh/trimesh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedh/trimesh/labels{/name}","releases_url":"https://api.github.com/repos/mikedh/trimesh/releases{/id}","deployments_url":"https://api.github.com/repos/mikedh/trimesh/deployments","created_at":"2013-07-29T17:25:42Z","updated_at":"2018-05-05T04:08:19Z","pushed_at":"2018-05-05T20:18:32Z","git_url":"git://github.com/mikedh/trimesh.git","ssh_url":"git@github.com:mikedh/trimesh.git","clone_url":"https://github.com/mikedh/trimesh.git","svn_url":"https://github.com/mikedh/trimesh","homepage":"","size":8690,"stargazers_count":204,"watchers_count":204,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":68,"open_issues":7,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/166"},"html":{"href":"https://github.com/mikedh/trimesh/pull/166"},"issue":{"href":"https://api.github.com/repos/mikedh/trimesh/issues/166"},"comments":{"href":"https://api.github.com/repos/mikedh/trimesh/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mikedh/trimesh/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/mikedh/trimesh/statuses/4b47a7931a88ae1f3f525a3211cc9f8dcf7ab887"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikedh"}}