{"action":"created","comment":{"url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/comments/205177977","pull_request_review_id":140396811,"id":205177977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE3Nzk3Nw==","diff_hunk":"@@ -363,6 +567,19 @@ void loop() {\n       #elif defined ADAFRUIT_ADS1115\n       Serial.println(F(\"Light Sensor: ADS1115\"));\n       #endif\n+      #if defined(ENDSTOPS_MIN)||defined(ENDSTOPS_MAX)","path":"arduino_code/openflexure_nano_motor_controller/openflexure_nano_motor_controller.ino","position":381,"original_position":342,"commit_id":"b5a25f1d2bdec2519756ac156c476b28f3ad3add","original_commit_id":"e0baaddc7896123b27779d6ddc67cf42f3e6b7eb","user":{"login":"codeTom","id":2260855,"node_id":"MDQ6VXNlcjIyNjA4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2260855?v=4","gravatar_id":"","url":"https://api.github.com/users/codeTom","html_url":"https://github.com/codeTom","followers_url":"https://api.github.com/users/codeTom/followers","following_url":"https://api.github.com/users/codeTom/following{/other_user}","gists_url":"https://api.github.com/users/codeTom/gists{/gist_id}","starred_url":"https://api.github.com/users/codeTom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeTom/subscriptions","organizations_url":"https://api.github.com/users/codeTom/orgs","repos_url":"https://api.github.com/users/codeTom/repos","events_url":"https://api.github.com/users/codeTom/events{/privacy}","received_events_url":"https://api.github.com/users/codeTom/received_events","type":"User","site_admin":false},"body":"Soft endstops currently only work with one set of physical endstops, so that is intentional (`ENDSTOPS_SOFT` is defined inside `defined(ENDSTOPS_MIN) || defined(ENDSTOPS_MAX)","created_at":"2018-07-25T16:30:54Z","updated_at":"2018-07-25T16:30:54Z","html_url":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31#discussion_r205177977","pull_request_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/comments/205177977"},"html":{"href":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31#discussion_r205177977"},"pull_request":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31"}},"in_reply_to_id":205125831},"pull_request":{"url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31","id":203181260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTgxMjYw","html_url":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31","diff_url":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31.diff","patch_url":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31.patch","issue_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/31","number":31,"state":"open","locked":false,"title":"Endstops","user":{"login":"codeTom","id":2260855,"node_id":"MDQ6VXNlcjIyNjA4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2260855?v=4","gravatar_id":"","url":"https://api.github.com/users/codeTom","html_url":"https://github.com/codeTom","followers_url":"https://api.github.com/users/codeTom/followers","following_url":"https://api.github.com/users/codeTom/following{/other_user}","gists_url":"https://api.github.com/users/codeTom/gists{/gist_id}","starred_url":"https://api.github.com/users/codeTom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeTom/subscriptions","organizations_url":"https://api.github.com/users/codeTom/orgs","repos_url":"https://api.github.com/users/codeTom/repos","events_url":"https://api.github.com/users/codeTom/events{/privacy}","received_events_url":"https://api.github.com/users/codeTom/received_events","type":"User","site_admin":false},"body":"Adds support for endstops as OptionalModule, enabled with the ENDSTOPS_{MAX,MIN} defines in the arduino code,. Resolves #25 ","created_at":"2018-07-23T10:53:44Z","updated_at":"2018-07-25T16:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31f094854f9a44dfb88632dba3888168447c5f7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31/commits","review_comments_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31/comments","review_comment_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/31/comments","statuses_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/statuses/b5a25f1d2bdec2519756ac156c476b28f3ad3add","head":{"label":"codeTom:endstops","ref":"endstops","sha":"b5a25f1d2bdec2519756ac156c476b28f3ad3add","user":{"login":"codeTom","id":2260855,"node_id":"MDQ6VXNlcjIyNjA4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2260855?v=4","gravatar_id":"","url":"https://api.github.com/users/codeTom","html_url":"https://github.com/codeTom","followers_url":"https://api.github.com/users/codeTom/followers","following_url":"https://api.github.com/users/codeTom/following{/other_user}","gists_url":"https://api.github.com/users/codeTom/gists{/gist_id}","starred_url":"https://api.github.com/users/codeTom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeTom/subscriptions","organizations_url":"https://api.github.com/users/codeTom/orgs","repos_url":"https://api.github.com/users/codeTom/repos","events_url":"https://api.github.com/users/codeTom/events{/privacy}","received_events_url":"https://api.github.com/users/codeTom/received_events","type":"User","site_admin":false},"repo":{"id":138999299,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5OTkyOTk=","name":"openflexure_nano_motor_controller","full_name":"codeTom/openflexure_nano_motor_controller","owner":{"login":"codeTom","id":2260855,"node_id":"MDQ6VXNlcjIyNjA4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/2260855?v=4","gravatar_id":"","url":"https://api.github.com/users/codeTom","html_url":"https://github.com/codeTom","followers_url":"https://api.github.com/users/codeTom/followers","following_url":"https://api.github.com/users/codeTom/following{/other_user}","gists_url":"https://api.github.com/users/codeTom/gists{/gist_id}","starred_url":"https://api.github.com/users/codeTom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeTom/subscriptions","organizations_url":"https://api.github.com/users/codeTom/orgs","repos_url":"https://api.github.com/users/codeTom/repos","events_url":"https://api.github.com/users/codeTom/events{/privacy}","received_events_url":"https://api.github.com/users/codeTom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codeTom/openflexure_nano_motor_controller","description":"A very basic Arduino Nano based unipolar motor controller.","fork":true,"url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller","forks_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/forks","keys_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/teams","hooks_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/hooks","issue_events_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/issues/events{/number}","events_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/events","assignees_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/assignees{/user}","branches_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/branches{/branch}","tags_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/tags","blobs_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/statuses/{sha}","languages_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/languages","stargazers_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/stargazers","contributors_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/contributors","subscribers_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/subscribers","subscription_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/subscription","commits_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/contents/{+path}","compare_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/merges","archive_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/downloads","issues_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/issues{/number}","pulls_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/pulls{/number}","milestones_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/milestones{/number}","notifications_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/labels{/name}","releases_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/releases{/id}","deployments_url":"https://api.github.com/repos/codeTom/openflexure_nano_motor_controller/deployments","created_at":"2018-06-28T09:49:20Z","updated_at":"2018-07-06T11:39:16Z","pushed_at":"2018-07-25T16:26:11Z","git_url":"git://github.com/codeTom/openflexure_nano_motor_controller.git","ssh_url":"git@github.com:codeTom/openflexure_nano_motor_controller.git","clone_url":"https://github.com/codeTom/openflexure_nano_motor_controller.git","svn_url":"https://github.com/codeTom/openflexure_nano_motor_controller","homepage":null,"size":1870,"stargazers_count":0,"watchers_count":0,"language":"PLSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwb27:master","ref":"master","sha":"eb538b7f479ced86458485ca120731ef406601cd","user":{"login":"rwb27","id":5029703,"node_id":"MDQ6VXNlcjUwMjk3MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5029703?v=4","gravatar_id":"","url":"https://api.github.com/users/rwb27","html_url":"https://github.com/rwb27","followers_url":"https://api.github.com/users/rwb27/followers","following_url":"https://api.github.com/users/rwb27/following{/other_user}","gists_url":"https://api.github.com/users/rwb27/gists{/gist_id}","starred_url":"https://api.github.com/users/rwb27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwb27/subscriptions","organizations_url":"https://api.github.com/users/rwb27/orgs","repos_url":"https://api.github.com/users/rwb27/repos","events_url":"https://api.github.com/users/rwb27/events{/privacy}","received_events_url":"https://api.github.com/users/rwb27/received_events","type":"User","site_admin":false},"repo":{"id":94751615,"node_id":"MDEwOlJlcG9zaXRvcnk5NDc1MTYxNQ==","name":"openflexure_nano_motor_controller","full_name":"rwb27/openflexure_nano_motor_controller","owner":{"login":"rwb27","id":5029703,"node_id":"MDQ6VXNlcjUwMjk3MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5029703?v=4","gravatar_id":"","url":"https://api.github.com/users/rwb27","html_url":"https://github.com/rwb27","followers_url":"https://api.github.com/users/rwb27/followers","following_url":"https://api.github.com/users/rwb27/following{/other_user}","gists_url":"https://api.github.com/users/rwb27/gists{/gist_id}","starred_url":"https://api.github.com/users/rwb27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwb27/subscriptions","organizations_url":"https://api.github.com/users/rwb27/orgs","repos_url":"https://api.github.com/users/rwb27/repos","events_url":"https://api.github.com/users/rwb27/events{/privacy}","received_events_url":"https://api.github.com/users/rwb27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwb27/openflexure_nano_motor_controller","description":"A very basic Arduino Nano based unipolar motor controller.","fork":false,"url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller","forks_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/forks","keys_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/teams","hooks_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/hooks","issue_events_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/events{/number}","events_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/events","assignees_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/assignees{/user}","branches_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/branches{/branch}","tags_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/tags","blobs_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/statuses/{sha}","languages_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/languages","stargazers_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/stargazers","contributors_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/contributors","subscribers_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/subscribers","subscription_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/subscription","commits_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/contents/{+path}","compare_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/merges","archive_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/downloads","issues_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues{/number}","pulls_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls{/number}","milestones_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/milestones{/number}","notifications_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/labels{/name}","releases_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/releases{/id}","deployments_url":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/deployments","created_at":"2017-06-19T08:00:43Z","updated_at":"2018-07-20T16:43:23Z","pushed_at":"2018-07-25T16:26:12Z","git_url":"git://github.com/rwb27/openflexure_nano_motor_controller.git","ssh_url":"git@github.com:rwb27/openflexure_nano_motor_controller.git","clone_url":"https://github.com/rwb27/openflexure_nano_motor_controller.git","svn_url":"https://github.com/rwb27/openflexure_nano_motor_controller","homepage":"https://openflexure-stage.readthedocs.io/en/latest/index.html","size":1874,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31"},"html":{"href":"https://github.com/rwb27/openflexure_nano_motor_controller/pull/31"},"issue":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/31"},"comments":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/rwb27/openflexure_nano_motor_controller/statuses/b5a25f1d2bdec2519756ac156c476b28f3ad3add"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codeTom"}}