{"action":"created","issue":{"url":"https://api.github.com/repos/github/markup/issues/1095","repository_url":"https://api.github.com/repos/github/markup","labels_url":"https://api.github.com/repos/github/markup/issues/1095/labels{/name}","comments_url":"https://api.github.com/repos/github/markup/issues/1095/comments","events_url":"https://api.github.com/repos/github/markup/issues/1095/events","html_url":"https://github.com/github/markup/issues/1095","id":251579065,"number":1095,"title":"Asciidoctor: support include directives for other asciidoc files","user":{"login":"miltador","id":17062283,"avatar_url":"https://avatars3.githubusercontent.com/u/17062283?v=4","gravatar_id":"","url":"https://api.github.com/users/miltador","html_url":"https://github.com/miltador","followers_url":"https://api.github.com/users/miltador/followers","following_url":"https://api.github.com/users/miltador/following{/other_user}","gists_url":"https://api.github.com/users/miltador/gists{/gist_id}","starred_url":"https://api.github.com/users/miltador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miltador/subscriptions","organizations_url":"https://api.github.com/users/miltador/orgs","repos_url":"https://api.github.com/users/miltador/repos","events_url":"https://api.github.com/users/miltador/events{/privacy}","received_events_url":"https://api.github.com/users/miltador/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-08-21T08:03:43Z","updated_at":"2018-02-20T20:51:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"A lot of time has passed since latest comments from devs in #172 and #335.\r\nI think after years things have changed in your infrastructure, why not to bring up this issue again with some more input and news?\r\n\r\nFor example, AFAIK GitHub started to use [containers](https://githubengineering.com/kubernetes-at-github/) which could help to isolate things from unintentional access and improve security.\r\n\r\nAlso take a look at asciidoctor/asciidoctor#1088. The author of Asciidoctor is [ready for a conversation](https://github.com/asciidoctor/asciidoctor/issues/1088#issuecomment-323672651) about this, there is even proposed a way to implement this with [custom include preprocessor](https://github.com/asciidoctor/asciidoctor/issues/1088#issuecomment-87685739). If there are still some concerns about resolving the issue, please provide a constructive feedback so both sides can collaborate."},"comment":{"url":"https://api.github.com/repos/github/markup/issues/comments/367115014","html_url":"https://github.com/github/markup/issues/1095#issuecomment-367115014","issue_url":"https://api.github.com/repos/github/markup/issues/1095","id":367115014,"user":{"login":"kavaliro","id":898803,"avatar_url":"https://avatars2.githubusercontent.com/u/898803?v=4","gravatar_id":"","url":"https://api.github.com/users/kavaliro","html_url":"https://github.com/kavaliro","followers_url":"https://api.github.com/users/kavaliro/followers","following_url":"https://api.github.com/users/kavaliro/following{/other_user}","gists_url":"https://api.github.com/users/kavaliro/gists{/gist_id}","starred_url":"https://api.github.com/users/kavaliro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kavaliro/subscriptions","organizations_url":"https://api.github.com/users/kavaliro/orgs","repos_url":"https://api.github.com/users/kavaliro/repos","events_url":"https://api.github.com/users/kavaliro/events{/privacy}","received_events_url":"https://api.github.com/users/kavaliro/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T20:51:52Z","updated_at":"2018-02-20T20:51:52Z","author_association":"NONE","body":"This issue was an unpleasant surprise. I agree with @ericis; this is fundamental functionality which is expected by Asciidoc users. \r\n\r\nSince @mojavelinux has [enabled custom handling](https://github.com/github/markup/issues/1095#issuecomment-339221372) , this seems simple: \r\n\r\n1. check for infinite recursion\r\n2. only allow relative links. (i.e., links to files within the repository.)\r\n\r\nThis seems fairly solvable."}}
{"actor":{"display_login":"kavaliro"}}