{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/194603680","pull_request_review_id":127806225,"id":194603680,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYwMzY4MA==","diff_hunk":"@@ -0,0 +1,158 @@\n+import 'dart:math' as math;\n+\n+import 'package:flutter/foundation.dart';\n+import 'package:flutter/rendering.dart';\n+\n+/// Computes notches in the outline of a shape.\n+///\n+/// Typically used to compute notches by a [BottomAppBar].\n+abstract class NotchComputer {\n+  /// Abstract const constructor. This constructor enables subclasses to provide\n+  /// const constructors so that they can be used in const expressions.\n+  const NotchComputer();\n+\n+  /// Returns a path for a notch in the outline of a shape.\n+  ///\n+  /// The path makes a notch in the host shape that can contain the guest shape.\n+  ///\n+  /// The `host` is the bounding rectangle for the shape into which the notch will\n+  /// be applied. The `guest` is the bounding rectangle of the shape for which we\n+  /// are creating a notch in the host.\n+  ///\n+  /// The `start` and `end` arguments are points on the outline of the host shape\n+  /// that will be connected by the returned path.\n+  ///\n+  /// The returned path may pass anywhere, including inside the guest bounds area,\n+  /// and may contain multiple subpaths. The returned path ends at `end` and does\n+  /// not end with a [Path.close]. The returned [Path] is built under the\n+  /// assumption it will be added to an existing path that is at the `start`\n+  /// coordinates using [Path.addPath].\n+  Path compute(Rect host, Rect guest, Offset start, Offset end);","path":"packages/flutter/lib/src/material/notch_computers.dart","position":30,"original_position":30,"commit_id":"609d011080d06dda00bb4900673195d72d657c74","original_commit_id":"609d011080d06dda00bb4900673195d72d657c74","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-12T03:02:56Z","updated_at":"2018-06-12T03:02:56Z","html_url":"https://github.com/flutter/flutter/pull/18372#discussion_r194603680","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/18372","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/194603680"},"html":{"href":"https://github.com/flutter/flutter/pull/18372#discussion_r194603680"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18372"}},"in_reply_to_id":194585446},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/18372","id":194097864,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDk3ODY0","html_url":"https://github.com/flutter/flutter/pull/18372","diff_url":"https://github.com/flutter/flutter/pull/18372.diff","patch_url":"https://github.com/flutter/flutter/pull/18372.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/18372","number":18372,"state":"open","locked":false,"title":"Move the notch computation from the FAB to the BAB.","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"body":"The notch in the bottom action bar for the floating action button was previously\r\nkept as part of the FAB's implementation to keep the shape of the FAB and the\r\nshape of the notch coupled.\r\nThat approach resulted in a somewhat complex and 'non Fluttery'\r\nmechanism for propagating the notch computation from the FAB to the BAB.\r\n\r\nThis CL uncouples the FAB and the notch computation, by making the notch\r\ncomputer an independent property of the BottomAppBar.\r\n\r\nThis includes multiple breaking changes:\r\n  * Scaffold.setFloatingActionButtonNotchFor is deleted.\r\n  * The ComputeNotch type is deleted.\r\n  * The hasNotch property of BottomAppBar is deleted.\r\n  * The notchMargin property of FloatingActionButton is deleted.","created_at":"2018-06-11T20:44:26Z","updated_at":"2018-06-12T03:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8c1b54a03e4cf0abfa255c2c447c13b4c06473c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/18372/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/18372/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/18372/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/609d011080d06dda00bb4900673195d72d657c74","head":{"label":"amirh:fab_notch","ref":"fab_notch","sha":"609d011080d06dda00bb4900673195d72d657c74","user":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"repo":{"id":78148410,"node_id":"MDEwOlJlcG9zaXRvcnk3ODE0ODQxMA==","name":"flutter","full_name":"amirh/flutter","owner":{"login":"amirh","id":1024117,"node_id":"MDQ6VXNlcjEwMjQxMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1024117?v=4","gravatar_id":"","url":"https://api.github.com/users/amirh","html_url":"https://github.com/amirh","followers_url":"https://api.github.com/users/amirh/followers","following_url":"https://api.github.com/users/amirh/following{/other_user}","gists_url":"https://api.github.com/users/amirh/gists{/gist_id}","starred_url":"https://api.github.com/users/amirh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirh/subscriptions","organizations_url":"https://api.github.com/users/amirh/orgs","repos_url":"https://api.github.com/users/amirh/repos","events_url":"https://api.github.com/users/amirh/events{/privacy}","received_events_url":"https://api.github.com/users/amirh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amirh/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/amirh/flutter","forks_url":"https://api.github.com/repos/amirh/flutter/forks","keys_url":"https://api.github.com/repos/amirh/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amirh/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amirh/flutter/teams","hooks_url":"https://api.github.com/repos/amirh/flutter/hooks","issue_events_url":"https://api.github.com/repos/amirh/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/amirh/flutter/events","assignees_url":"https://api.github.com/repos/amirh/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/amirh/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/amirh/flutter/tags","blobs_url":"https://api.github.com/repos/amirh/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amirh/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amirh/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/amirh/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amirh/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/amirh/flutter/languages","stargazers_url":"https://api.github.com/repos/amirh/flutter/stargazers","contributors_url":"https://api.github.com/repos/amirh/flutter/contributors","subscribers_url":"https://api.github.com/repos/amirh/flutter/subscribers","subscription_url":"https://api.github.com/repos/amirh/flutter/subscription","commits_url":"https://api.github.com/repos/amirh/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/amirh/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/amirh/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/amirh/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/amirh/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/amirh/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amirh/flutter/merges","archive_url":"https://api.github.com/repos/amirh/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amirh/flutter/downloads","issues_url":"https://api.github.com/repos/amirh/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/amirh/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/amirh/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/amirh/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amirh/flutter/labels{/name}","releases_url":"https://api.github.com/repos/amirh/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/amirh/flutter/deployments","created_at":"2017-01-05T21:08:15Z","updated_at":"2017-10-31T16:35:14Z","pushed_at":"2018-06-11T20:44:03Z","git_url":"git://github.com/amirh/flutter.git","ssh_url":"git@github.com:amirh/flutter.git","clone_url":"https://github.com/amirh/flutter.git","svn_url":"https://github.com/amirh/flutter","homepage":"https://flutter.io","size":39929,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"3019ad976d333cceb903b3f53885cd9ae678a622","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-06-12T03:02:46Z","pushed_at":"2018-06-12T02:36:38Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":39769,"stargazers_count":26324,"watchers_count":26324,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2380,"mirror_url":null,"archived":false,"open_issues_count":3302,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2380,"open_issues":3302,"watchers":26324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18372"},"html":{"href":"https://github.com/flutter/flutter/pull/18372"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/18372"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/18372/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18372/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18372/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/609d011080d06dda00bb4900673195d72d657c74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amirh"}}