{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/188836962","pull_request_review_id":120893704,"id":188836962,"diff_hunk":"@@ -0,0 +1,180 @@\n+#include \"extensions/filters/http/jwt_authn/jwks_cache.h\"","path":"source/extensions/filters/http/jwt_authn/jwks_cache.cc","position":1,"original_position":1,"commit_id":"966b1704932387dd67df8d7f0071df2135862bdf","original_commit_id":"966b1704932387dd67df8d7f0071df2135862bdf","user":{"login":"lizan","id":1016047,"avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"body":"I think you should push almost all of this code to jwt_verifier_lib, it doesn't have to belong to Envoy code base. The only dependency seems to be the configuration, but it is only audiences (vector<string>) and jwks (string) so you should be able to pass by parameter.","created_at":"2018-05-17T04:36:28Z","updated_at":"2018-05-17T04:36:28Z","html_url":"https://github.com/envoyproxy/envoy/pull/3339#discussion_r188836962","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/188836962"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3339#discussion_r188836962"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339","id":187083925,"html_url":"https://github.com/envoyproxy/envoy/pull/3339","diff_url":"https://github.com/envoyproxy/envoy/pull/3339.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3339.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3339","number":3339,"state":"open","locked":false,"title":"Jwt_authn: first draft of Http filter implementation.","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Wayne Zhang <qiwzhang@google.com>\r\n\r\n*Description*:\r\nThis is first draft of porting jwt authentication filter from istio/proxy to Envoy.  \r\n* jwt_verify repo code PR (https://github.com/google/jwt_verify_lib/pull/4) is under review. \r\n* test code will be added later into this PR. This PR is for people to review design.  \r\n\r\n*Risk Level*: Low \r\n","created_at":"2018-05-10T02:09:13Z","updated_at":"2018-05-17T04:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96bd8e73b08dda83813a0ee4fd0e13d3da1f4d37","assignee":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3339/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/966b1704932387dd67df8d7f0071df2135862bdf","head":{"label":"qiwzhang:jwt_authn_all0","ref":"jwt_authn_all0","sha":"966b1704932387dd67df8d7f0071df2135862bdf","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"repo":{"id":80474148,"name":"envoy","full_name":"qiwzhang/envoy","owner":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qiwzhang/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/qiwzhang/envoy","forks_url":"https://api.github.com/repos/qiwzhang/envoy/forks","keys_url":"https://api.github.com/repos/qiwzhang/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiwzhang/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiwzhang/envoy/teams","hooks_url":"https://api.github.com/repos/qiwzhang/envoy/hooks","issue_events_url":"https://api.github.com/repos/qiwzhang/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/qiwzhang/envoy/events","assignees_url":"https://api.github.com/repos/qiwzhang/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/qiwzhang/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/qiwzhang/envoy/tags","blobs_url":"https://api.github.com/repos/qiwzhang/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiwzhang/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiwzhang/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiwzhang/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiwzhang/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/qiwzhang/envoy/languages","stargazers_url":"https://api.github.com/repos/qiwzhang/envoy/stargazers","contributors_url":"https://api.github.com/repos/qiwzhang/envoy/contributors","subscribers_url":"https://api.github.com/repos/qiwzhang/envoy/subscribers","subscription_url":"https://api.github.com/repos/qiwzhang/envoy/subscription","commits_url":"https://api.github.com/repos/qiwzhang/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiwzhang/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiwzhang/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiwzhang/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiwzhang/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/qiwzhang/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiwzhang/envoy/merges","archive_url":"https://api.github.com/repos/qiwzhang/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiwzhang/envoy/downloads","issues_url":"https://api.github.com/repos/qiwzhang/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/qiwzhang/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/qiwzhang/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/qiwzhang/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiwzhang/envoy/labels{/name}","releases_url":"https://api.github.com/repos/qiwzhang/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/qiwzhang/envoy/deployments","created_at":"2017-01-30T23:25:24Z","updated_at":"2017-01-30T23:25:27Z","pushed_at":"2018-05-17T02:20:30Z","git_url":"git://github.com/qiwzhang/envoy.git","ssh_url":"git@github.com:qiwzhang/envoy.git","clone_url":"https://github.com/qiwzhang/envoy.git","svn_url":"https://github.com/qiwzhang/envoy","homepage":"https://lyft.github.io/envoy","size":20163,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"42863c971a9b10eac291adce0cdcf15cd30a5700","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-05-17T04:29:18Z","pushed_at":"2018-05-17T02:20:32Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":15582,"stargazers_count":4917,"watchers_count":4917,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":629,"mirror_url":null,"archived":false,"open_issues_count":318,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":629,"open_issues":318,"watchers":4917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3339"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3339"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3339/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3339/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/966b1704932387dd67df8d7f0071df2135862bdf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lizan"}}