{"action":"created","issue":{"url":"https://api.github.com/repos/gitcoinco/web/issues/445","repository_url":"https://api.github.com/repos/gitcoinco/web","labels_url":"https://api.github.com/repos/gitcoinco/web/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/gitcoinco/web/issues/445/comments","events_url":"https://api.github.com/repos/gitcoinco/web/issues/445/events","html_url":"https://github.com/gitcoinco/web/issues/445","id":297186920,"number":445,"title":"better bounds checking in kill/submit/accept bounty","user":{"login":"owocki","id":513929,"avatar_url":"https://avatars2.githubusercontent.com/u/513929?v=4","gravatar_id":"","url":"https://api.github.com/users/owocki","html_url":"https://github.com/owocki","followers_url":"https://api.github.com/users/owocki/followers","following_url":"https://api.github.com/users/owocki/following{/other_user}","gists_url":"https://api.github.com/users/owocki/gists{/gist_id}","starred_url":"https://api.github.com/users/owocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owocki/subscriptions","organizations_url":"https://api.github.com/users/owocki/orgs","repos_url":"https://api.github.com/users/owocki/repos","events_url":"https://api.github.com/users/owocki/events{/privacy}","received_events_url":"https://api.github.com/users/owocki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-02-14T17:47:33Z","updated_at":"2018-04-16T18:29:39Z","closed_at":null,"author_association":"OWNER","body":"# what\r\n\r\nright now, we don't do a great job of bounds checking in the follow places :\r\n\r\n## surface area:\r\n1. kill bounty\r\n2. submit bounty\r\n3. accept bounty\r\n\r\nif you fail to meet the boundary conditions , youll see a nasty metamask module that shows you using up too much gas : http://bits.owocki.com/0h1R3J3r1j1w\r\n\r\n# current functionality\r\n\r\nupon form submission on these pages, metamask will show this module, which shows that theres too much gas being used: http://bits.owocki.com/0h1R3J3r1j1w\r\n\r\n# desired functionality\r\n\r\nupon form submission on these pages,  an `_alert` is shown telling the user what bounds they crossed (the most common one is likely to be that the bounty has expired)\r\n\r\nexample error message: \"Error: Cannot submit bounty as it has expired. Please contact bounty submitter directly to resolve.\"\r\n\r\n# bounds conditions to check\r\n1. try to submit work on an issue you are the funder\r\n2. you submit work on an issue that is on a different network than you (mainnet vs rinkeby)\r\n3. any other conditions enforced in [StandardBounties](https://github.com/ConsenSys/StandardBounties/)\r\n4. network of bounty != network that the users current metamask instance is on\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gitcoinco/web/issues/comments/381703911","html_url":"https://github.com/gitcoinco/web/issues/445#issuecomment-381703911","issue_url":"https://api.github.com/repos/gitcoinco/web/issues/445","id":381703911,"user":{"login":"owocki","id":513929,"avatar_url":"https://avatars2.githubusercontent.com/u/513929?v=4","gravatar_id":"","url":"https://api.github.com/users/owocki","html_url":"https://github.com/owocki","followers_url":"https://api.github.com/users/owocki/followers","following_url":"https://api.github.com/users/owocki/following{/other_user}","gists_url":"https://api.github.com/users/owocki/gists{/gist_id}","starred_url":"https://api.github.com/users/owocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owocki/subscriptions","organizations_url":"https://api.github.com/users/owocki/orgs","repos_url":"https://api.github.com/users/owocki/repos","events_url":"https://api.github.com/users/owocki/events{/privacy}","received_events_url":"https://api.github.com/users/owocki/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T18:29:39Z","updated_at":"2018-04-16T18:29:39Z","author_association":"OWNER","body":"reviewing PR now"}}
{"actor":{"display_login":"owocki"}}