{"action":"created","issue":{"url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/165","repository_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework","labels_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/165/comments","events_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/165/events","html_url":"https://github.com/Seneral/Node_Editor_Framework/issues/165","id":325093413,"number":165,"title":"New memory issue with large node networks ","user":{"login":"Physicalpariah","id":5343720,"avatar_url":"https://avatars0.githubusercontent.com/u/5343720?v=4","gravatar_id":"","url":"https://api.github.com/users/Physicalpariah","html_url":"https://github.com/Physicalpariah","followers_url":"https://api.github.com/users/Physicalpariah/followers","following_url":"https://api.github.com/users/Physicalpariah/following{/other_user}","gists_url":"https://api.github.com/users/Physicalpariah/gists{/gist_id}","starred_url":"https://api.github.com/users/Physicalpariah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Physicalpariah/subscriptions","organizations_url":"https://api.github.com/users/Physicalpariah/orgs","repos_url":"https://api.github.com/users/Physicalpariah/repos","events_url":"https://api.github.com/users/Physicalpariah/events{/privacy}","received_events_url":"https://api.github.com/users/Physicalpariah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-21T23:37:28Z","updated_at":"2018-05-23T21:37:45Z","closed_at":null,"author_association":"NONE","body":"Seems like the new culling feature introduced a bunch of new foreach loops (and seemingly some other kind of memory blockage) \r\n\r\nI tried to isolate it specifically, but a combination of time + unity being unresponsive meant I had to give up my hunt. \r\n\r\nMemory + CPU usage are more than enough to crash a modern imac with 16gb ram. \r\n\r\nHere's a few instances of new foreach loops:\r\n\r\nNodeInspector.cs l:54\r\nCanvasCalculator.cs l:63\r\nXMLImport\r\n\t39\r\n\t52\r\n\t65\r\n\t76\r\n\t93\r\n\t111\r\n\t123\r\n\t181\r\n\t194\r\n\t222\r\n\t235\r\n\t259\r\n\t271\r\n\t283\r\nRTCanvasCalculator.cs\r\n\t45\r\n\t50\r\n\r\nHope this helps."},"comment":{"url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/comments/391504905","html_url":"https://github.com/Seneral/Node_Editor_Framework/issues/165#issuecomment-391504905","issue_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/165","id":391504905,"user":{"login":"Seneral","id":12800840,"avatar_url":"https://avatars3.githubusercontent.com/u/12800840?v=4","gravatar_id":"","url":"https://api.github.com/users/Seneral","html_url":"https://github.com/Seneral","followers_url":"https://api.github.com/users/Seneral/followers","following_url":"https://api.github.com/users/Seneral/following{/other_user}","gists_url":"https://api.github.com/users/Seneral/gists{/gist_id}","starred_url":"https://api.github.com/users/Seneral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seneral/subscriptions","organizations_url":"https://api.github.com/users/Seneral/orgs","repos_url":"https://api.github.com/users/Seneral/repos","events_url":"https://api.github.com/users/Seneral/events{/privacy}","received_events_url":"https://api.github.com/users/Seneral/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T21:37:45Z","updated_at":"2018-05-23T21:37:45Z","author_association":"OWNER","body":"Hm, culling definitely shouldn't cause it, it's just a pre-drawing condition checking whether the node is visible.\r\nThe foreach loops you listed are not new and also are not critical (called just occasionally or not at all). Definitely not enough garbage to crash a machine.\r\nJust how many nodes do you have in the editor?"}}
{"actor":{"display_login":"Seneral"}}