{"action":"created","issue":{"url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/220","repository_url":"https://api.github.com/repos/crawler-commons/crawler-commons","labels_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/220/comments","events_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/220/events","html_url":"https://github.com/crawler-commons/crawler-commons/pull/220","id":386781821,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDE4Njg2","number":220,"title":"In case of the use of a different locale, price tag can be formatted …","user":{"login":"goldenlink","id":999042,"node_id":"MDQ6VXNlcjk5OTA0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/999042?v=4","gravatar_id":"","url":"https://api.github.com/users/goldenlink","html_url":"https://github.com/goldenlink","followers_url":"https://api.github.com/users/goldenlink/followers","following_url":"https://api.github.com/users/goldenlink/following{/other_user}","gists_url":"https://api.github.com/users/goldenlink/gists{/gist_id}","starred_url":"https://api.github.com/users/goldenlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldenlink/subscriptions","organizations_url":"https://api.github.com/users/goldenlink/orgs","repos_url":"https://api.github.com/users/goldenlink/repos","events_url":"https://api.github.com/users/goldenlink/events{/privacy}","received_events_url":"https://api.github.com/users/goldenlink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T11:48:11Z","updated_at":"2018-12-03T15:02:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/crawler-commons/crawler-commons/pulls/220","html_url":"https://github.com/crawler-commons/crawler-commons/pull/220","diff_url":"https://github.com/crawler-commons/crawler-commons/pull/220.diff","patch_url":"https://github.com/crawler-commons/crawler-commons/pull/220.patch"},"body":"…with ',' instead of '.' leading to a NPE.\r\n\r\nNPE is generated because parseFloat returns a Float object that can be set null in case of NumberFormatException, but the VideoPrice accepts only float.\r\nTo bypass this issue and avoid reccuring errors, I've moved the VideoPrice price field to a Float object instead accepting null in case of.\r\n\r\nIt is far from ideal, and parseFloat would enjoy being able to parse different locale formatting. Anyway, in a first quick fix, this allows the rest of the file to be parsed,\r\nwhereas the previous error had all the file to fail while parsing."},"comment":{"url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/comments/443740356","html_url":"https://github.com/crawler-commons/crawler-commons/pull/220#issuecomment-443740356","issue_url":"https://api.github.com/repos/crawler-commons/crawler-commons/issues/220","id":443740356,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzc0MDM1Ng==","user":{"login":"kkrugler","id":66217,"node_id":"MDQ6VXNlcjY2MjE3","avatar_url":"https://avatars3.githubusercontent.com/u/66217?v=4","gravatar_id":"","url":"https://api.github.com/users/kkrugler","html_url":"https://github.com/kkrugler","followers_url":"https://api.github.com/users/kkrugler/followers","following_url":"https://api.github.com/users/kkrugler/following{/other_user}","gists_url":"https://api.github.com/users/kkrugler/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrugler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrugler/subscriptions","organizations_url":"https://api.github.com/users/kkrugler/orgs","repos_url":"https://api.github.com/users/kkrugler/repos","events_url":"https://api.github.com/users/kkrugler/events{/privacy}","received_events_url":"https://api.github.com/users/kkrugler/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T15:02:12Z","updated_at":"2018-12-03T15:02:12Z","author_association":"CONTRIBUTOR","body":"This is a currency value. Instead of trying to parse it as a float, it needs special handling. Lots of articles online about this, e.g. https://dzone.com/articles/currency-format-validation-and. If the locale is unknown, then best is a (limited) set of common locales that are tried until it parses successfully. If it fails, then logging the error and returning something that is ultimately interpreted as 0.0 might be a better option, versus a null Float object."}}
{"actor":{"display_login":"kkrugler"}}