{"action":"created","comment":{"url":"https://api.github.com/repos/sem5640-2018/docs/pulls/comments/241723812","pull_request_review_id":185067344,"id":241723812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTcyMzgxMg==","diff_hunk":"@@ -0,0 +1,8 @@\n+\\section{Static Analysis}\n+\\subsection{PMD}\n+\\par\n+Initially Java used \\textit{CheckStyle} to also enforce coding style conventions. However the rules were over-specified. Additionally, unlike other formatting tools there was no option to emit a patch-file which allows developers to automatically fix-up many errors such as incorrect white space or formatting.\n+\n+\\par\n+The Java teams later migrated to the \\textit{PMD}\\cite{PMD} static analysis tool: this warns about unused fields and variables, unsafe constructs,and dangerous coding patterns.","path":"final_report/Chapter6-Testing/static-analysis.tex","position":7,"original_position":7,"commit_id":"c452b686c19ec6a3706430d25aeaa6c1dd1161ff","original_commit_id":"c452b686c19ec6a3706430d25aeaa6c1dd1161ff","user":{"login":"dkmonaghan","id":920215,"node_id":"MDQ6VXNlcjkyMDIxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/920215?v=4","gravatar_id":"","url":"https://api.github.com/users/dkmonaghan","html_url":"https://github.com/dkmonaghan","followers_url":"https://api.github.com/users/dkmonaghan/followers","following_url":"https://api.github.com/users/dkmonaghan/following{/other_user}","gists_url":"https://api.github.com/users/dkmonaghan/gists{/gist_id}","starred_url":"https://api.github.com/users/dkmonaghan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkmonaghan/subscriptions","organizations_url":"https://api.github.com/users/dkmonaghan/orgs","repos_url":"https://api.github.com/users/dkmonaghan/repos","events_url":"https://api.github.com/users/dkmonaghan/events{/privacy}","received_events_url":"https://api.github.com/users/dkmonaghan/received_events","type":"User","site_admin":false},"body":"Space after \"constructs,\" ","created_at":"2018-12-14T11:25:08Z","updated_at":"2018-12-14T11:37:45Z","html_url":"https://github.com/sem5640-2018/docs/pull/24#discussion_r241723812","pull_request_url":"https://api.github.com/repos/sem5640-2018/docs/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/comments/241723812"},"html":{"href":"https://github.com/sem5640-2018/docs/pull/24#discussion_r241723812"},"pull_request":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/sem5640-2018/docs/pulls/24","id":238408724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDA4NzI0","html_url":"https://github.com/sem5640-2018/docs/pull/24","diff_url":"https://github.com/sem5640-2018/docs/pull/24.diff","patch_url":"https://github.com/sem5640-2018/docs/pull/24.patch","issue_url":"https://api.github.com/repos/sem5640-2018/docs/issues/24","number":24,"state":"open","locked":false,"title":"Testing chpt","user":{"login":"DavidFair","id":1817032,"node_id":"MDQ6VXNlcjE4MTcwMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1817032?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-13T14:27:39Z","updated_at":"2018-12-14T11:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c292a656032a0ea3f2d2a903a468b0f686d2ee5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1155008731,"node_id":"MDU6TGFiZWwxMTU1MDA4NzMx","url":"https://api.github.com/repos/sem5640-2018/docs/labels/new%20content","name":"new content","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sem5640-2018/docs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/sem5640-2018/docs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/sem5640-2018/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sem5640-2018/docs/issues/24/comments","statuses_url":"https://api.github.com/repos/sem5640-2018/docs/statuses/c452b686c19ec6a3706430d25aeaa6c1dd1161ff","head":{"label":"sem5640-2018:Testing_chpt","ref":"Testing_chpt","sha":"c452b686c19ec6a3706430d25aeaa6c1dd1161ff","user":{"login":"sem5640-2018","id":44270510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MjcwNTEw","avatar_url":"https://avatars3.githubusercontent.com/u/44270510?v=4","gravatar_id":"","url":"https://api.github.com/users/sem5640-2018","html_url":"https://github.com/sem5640-2018","followers_url":"https://api.github.com/users/sem5640-2018/followers","following_url":"https://api.github.com/users/sem5640-2018/following{/other_user}","gists_url":"https://api.github.com/users/sem5640-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sem5640-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sem5640-2018/subscriptions","organizations_url":"https://api.github.com/users/sem5640-2018/orgs","repos_url":"https://api.github.com/users/sem5640-2018/repos","events_url":"https://api.github.com/users/sem5640-2018/events{/privacy}","received_events_url":"https://api.github.com/users/sem5640-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":154192810,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxOTI4MTA=","name":"docs","full_name":"sem5640-2018/docs","private":false,"owner":{"login":"sem5640-2018","id":44270510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MjcwNTEw","avatar_url":"https://avatars3.githubusercontent.com/u/44270510?v=4","gravatar_id":"","url":"https://api.github.com/users/sem5640-2018","html_url":"https://github.com/sem5640-2018","followers_url":"https://api.github.com/users/sem5640-2018/followers","following_url":"https://api.github.com/users/sem5640-2018/following{/other_user}","gists_url":"https://api.github.com/users/sem5640-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sem5640-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sem5640-2018/subscriptions","organizations_url":"https://api.github.com/users/sem5640-2018/orgs","repos_url":"https://api.github.com/users/sem5640-2018/repos","events_url":"https://api.github.com/users/sem5640-2018/events{/privacy}","received_events_url":"https://api.github.com/users/sem5640-2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sem5640-2018/docs","description":"LaTeX Documents","fork":false,"url":"https://api.github.com/repos/sem5640-2018/docs","forks_url":"https://api.github.com/repos/sem5640-2018/docs/forks","keys_url":"https://api.github.com/repos/sem5640-2018/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sem5640-2018/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sem5640-2018/docs/teams","hooks_url":"https://api.github.com/repos/sem5640-2018/docs/hooks","issue_events_url":"https://api.github.com/repos/sem5640-2018/docs/issues/events{/number}","events_url":"https://api.github.com/repos/sem5640-2018/docs/events","assignees_url":"https://api.github.com/repos/sem5640-2018/docs/assignees{/user}","branches_url":"https://api.github.com/repos/sem5640-2018/docs/branches{/branch}","tags_url":"https://api.github.com/repos/sem5640-2018/docs/tags","blobs_url":"https://api.github.com/repos/sem5640-2018/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sem5640-2018/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sem5640-2018/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sem5640-2018/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sem5640-2018/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/sem5640-2018/docs/languages","stargazers_url":"https://api.github.com/repos/sem5640-2018/docs/stargazers","contributors_url":"https://api.github.com/repos/sem5640-2018/docs/contributors","subscribers_url":"https://api.github.com/repos/sem5640-2018/docs/subscribers","subscription_url":"https://api.github.com/repos/sem5640-2018/docs/subscription","commits_url":"https://api.github.com/repos/sem5640-2018/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sem5640-2018/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sem5640-2018/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sem5640-2018/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sem5640-2018/docs/contents/{+path}","compare_url":"https://api.github.com/repos/sem5640-2018/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sem5640-2018/docs/merges","archive_url":"https://api.github.com/repos/sem5640-2018/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sem5640-2018/docs/downloads","issues_url":"https://api.github.com/repos/sem5640-2018/docs/issues{/number}","pulls_url":"https://api.github.com/repos/sem5640-2018/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/sem5640-2018/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/sem5640-2018/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sem5640-2018/docs/labels{/name}","releases_url":"https://api.github.com/repos/sem5640-2018/docs/releases{/id}","deployments_url":"https://api.github.com/repos/sem5640-2018/docs/deployments","created_at":"2018-10-22T18:14:21Z","updated_at":"2018-12-13T12:40:03Z","pushed_at":"2018-12-13T15:48:27Z","git_url":"git://github.com/sem5640-2018/docs.git","ssh_url":"git@github.com:sem5640-2018/docs.git","clone_url":"https://github.com/sem5640-2018/docs.git","svn_url":"https://github.com/sem5640-2018/docs","homepage":null,"size":5689,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"sem5640-2018:master","ref":"master","sha":"22e99285eb000e41224fd46486c28bc9c252d620","user":{"login":"sem5640-2018","id":44270510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MjcwNTEw","avatar_url":"https://avatars3.githubusercontent.com/u/44270510?v=4","gravatar_id":"","url":"https://api.github.com/users/sem5640-2018","html_url":"https://github.com/sem5640-2018","followers_url":"https://api.github.com/users/sem5640-2018/followers","following_url":"https://api.github.com/users/sem5640-2018/following{/other_user}","gists_url":"https://api.github.com/users/sem5640-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sem5640-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sem5640-2018/subscriptions","organizations_url":"https://api.github.com/users/sem5640-2018/orgs","repos_url":"https://api.github.com/users/sem5640-2018/repos","events_url":"https://api.github.com/users/sem5640-2018/events{/privacy}","received_events_url":"https://api.github.com/users/sem5640-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":154192810,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxOTI4MTA=","name":"docs","full_name":"sem5640-2018/docs","private":false,"owner":{"login":"sem5640-2018","id":44270510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MjcwNTEw","avatar_url":"https://avatars3.githubusercontent.com/u/44270510?v=4","gravatar_id":"","url":"https://api.github.com/users/sem5640-2018","html_url":"https://github.com/sem5640-2018","followers_url":"https://api.github.com/users/sem5640-2018/followers","following_url":"https://api.github.com/users/sem5640-2018/following{/other_user}","gists_url":"https://api.github.com/users/sem5640-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/sem5640-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sem5640-2018/subscriptions","organizations_url":"https://api.github.com/users/sem5640-2018/orgs","repos_url":"https://api.github.com/users/sem5640-2018/repos","events_url":"https://api.github.com/users/sem5640-2018/events{/privacy}","received_events_url":"https://api.github.com/users/sem5640-2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sem5640-2018/docs","description":"LaTeX Documents","fork":false,"url":"https://api.github.com/repos/sem5640-2018/docs","forks_url":"https://api.github.com/repos/sem5640-2018/docs/forks","keys_url":"https://api.github.com/repos/sem5640-2018/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sem5640-2018/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sem5640-2018/docs/teams","hooks_url":"https://api.github.com/repos/sem5640-2018/docs/hooks","issue_events_url":"https://api.github.com/repos/sem5640-2018/docs/issues/events{/number}","events_url":"https://api.github.com/repos/sem5640-2018/docs/events","assignees_url":"https://api.github.com/repos/sem5640-2018/docs/assignees{/user}","branches_url":"https://api.github.com/repos/sem5640-2018/docs/branches{/branch}","tags_url":"https://api.github.com/repos/sem5640-2018/docs/tags","blobs_url":"https://api.github.com/repos/sem5640-2018/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sem5640-2018/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sem5640-2018/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sem5640-2018/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sem5640-2018/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/sem5640-2018/docs/languages","stargazers_url":"https://api.github.com/repos/sem5640-2018/docs/stargazers","contributors_url":"https://api.github.com/repos/sem5640-2018/docs/contributors","subscribers_url":"https://api.github.com/repos/sem5640-2018/docs/subscribers","subscription_url":"https://api.github.com/repos/sem5640-2018/docs/subscription","commits_url":"https://api.github.com/repos/sem5640-2018/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sem5640-2018/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sem5640-2018/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sem5640-2018/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sem5640-2018/docs/contents/{+path}","compare_url":"https://api.github.com/repos/sem5640-2018/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sem5640-2018/docs/merges","archive_url":"https://api.github.com/repos/sem5640-2018/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sem5640-2018/docs/downloads","issues_url":"https://api.github.com/repos/sem5640-2018/docs/issues{/number}","pulls_url":"https://api.github.com/repos/sem5640-2018/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/sem5640-2018/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/sem5640-2018/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sem5640-2018/docs/labels{/name}","releases_url":"https://api.github.com/repos/sem5640-2018/docs/releases{/id}","deployments_url":"https://api.github.com/repos/sem5640-2018/docs/deployments","created_at":"2018-10-22T18:14:21Z","updated_at":"2018-12-13T12:40:03Z","pushed_at":"2018-12-13T15:48:27Z","git_url":"git://github.com/sem5640-2018/docs.git","ssh_url":"git@github.com:sem5640-2018/docs.git","clone_url":"https://github.com/sem5640-2018/docs.git","svn_url":"https://github.com/sem5640-2018/docs","homepage":null,"size":5689,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/24"},"html":{"href":"https://github.com/sem5640-2018/docs/pull/24"},"issue":{"href":"https://api.github.com/repos/sem5640-2018/docs/issues/24"},"comments":{"href":"https://api.github.com/repos/sem5640-2018/docs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sem5640-2018/docs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/sem5640-2018/docs/statuses/c452b686c19ec6a3706430d25aeaa6c1dd1161ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dkmonaghan"}}