{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/ptvsd/issues/463","repository_url":"https://api.github.com/repos/Microsoft/ptvsd","labels_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/463/comments","events_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/463/events","html_url":"https://github.com/Microsoft/ptvsd/pull/463","id":329229158,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTM3NjQ1","number":463,"title":"Fix 459 wait on exit","user":{"login":"ericsnowcurrently","id":1152074,"node_id":"MDQ6VXNlcjExNTIwNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1152074?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsnowcurrently","html_url":"https://github.com/ericsnowcurrently","followers_url":"https://api.github.com/users/ericsnowcurrently/followers","following_url":"https://api.github.com/users/ericsnowcurrently/following{/other_user}","gists_url":"https://api.github.com/users/ericsnowcurrently/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsnowcurrently/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsnowcurrently/subscriptions","organizations_url":"https://api.github.com/users/ericsnowcurrently/orgs","repos_url":"https://api.github.com/users/ericsnowcurrently/repos","events_url":"https://api.github.com/users/ericsnowcurrently/events{/privacy}","received_events_url":"https://api.github.com/users/ericsnowcurrently/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-04T21:48:13Z","updated_at":"2018-06-05T00:00:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/ptvsd/pulls/463","html_url":"https://github.com/Microsoft/ptvsd/pull/463","diff_url":"https://github.com/Microsoft/ptvsd/pull/463.diff","patch_url":"https://github.com/Microsoft/ptvsd/pull/463.patch"},"body":"(fixes #459)\r\n\r\nThe Daemon.close() code is set up to wait for the user (via stdin) under some conditions.  This code relied on there being a current session at the time the daemon is closed.  However, the session might have been closed already.\r\n\r\nThis PR makes sure that we can trigger the user-waiting code even if no session is current.  It also distinguishes between daemons that run only a single session (e.g. launch) and those that may handle many (e.g. remote attach)."},"comment":{"url":"https://api.github.com/repos/Microsoft/ptvsd/issues/comments/394537307","html_url":"https://github.com/Microsoft/ptvsd/pull/463#issuecomment-394537307","issue_url":"https://api.github.com/repos/Microsoft/ptvsd/issues/463","id":394537307,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDUzNzMwNw==","user":{"login":"huguesv","id":1696845,"node_id":"MDQ6VXNlcjE2OTY4NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1696845?v=4","gravatar_id":"","url":"https://api.github.com/users/huguesv","html_url":"https://github.com/huguesv","followers_url":"https://api.github.com/users/huguesv/followers","following_url":"https://api.github.com/users/huguesv/following{/other_user}","gists_url":"https://api.github.com/users/huguesv/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesv/subscriptions","organizations_url":"https://api.github.com/users/huguesv/orgs","repos_url":"https://api.github.com/users/huguesv/repos","events_url":"https://api.github.com/users/huguesv/events{/privacy}","received_events_url":"https://api.github.com/users/huguesv/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T00:00:08Z","updated_at":"2018-06-05T00:00:08Z","author_association":"NONE","body":"From VS, we start up a process: `python.exe ptvsd_launcher.py <bunch of args>`, which calls into `ptvsd.debug()`\r\nhttps://github.com/Microsoft/PTVS/blob/master/Python/Product/PythonTools/ptvsd_launcher.py#L111\r\n"}}
{"actor":{"display_login":"huguesv"}}