{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50","id":217411920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDExOTIw","html_url":"https://github.com/usnistgov/oar-dist-service/pull/50","diff_url":"https://github.com/usnistgov/oar-dist-service/pull/50.diff","patch_url":"https://github.com/usnistgov/oar-dist-service/pull/50.patch","issue_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/50","number":50,"state":"closed","locked":false,"title":"Add Preservation Bag Service, refactor Download Service","user":{"login":"RayPlante","id":1027700,"node_id":"MDQ6VXNlcjEwMjc3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1027700?v=4","gravatar_id":"","url":"https://api.github.com/users/RayPlante","html_url":"https://github.com/RayPlante","followers_url":"https://api.github.com/users/RayPlante/followers","following_url":"https://api.github.com/users/RayPlante/following{/other_user}","gists_url":"https://api.github.com/users/RayPlante/gists{/gist_id}","starred_url":"https://api.github.com/users/RayPlante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RayPlante/subscriptions","organizations_url":"https://api.github.com/users/RayPlante/orgs","repos_url":"https://api.github.com/users/RayPlante/repos","events_url":"https://api.github.com/users/RayPlante/events{/privacy}","received_events_url":"https://api.github.com/users/RayPlante/received_events","type":"User","site_admin":false},"body":"This PR is addresses task [ODD-619 (\"Build the PreservationBagService\")](http://mml.nist.gov:8080/browse/ODD-619) which is, in effect, a subtask of task [ODD-650 (\"Support dataset updates in the Preservation Service\")](http://mml.nist.gov:8080/browse/ODD-650).  It is a companion to the [oar-pdr PR#46](https://github.com/usnistgov/oar-pdr/pull/46); together, they address [ODD-650](http://mml.nist.gov:8080/browse/ODD-650).  One of the key capabilities this latter issue addresses is enabling the Preservation Service to support updates to previously published datasets; to do this, that service needs to pull in the head bag from the previous publication to build off of.  This PR adds the Preservation Bag Service into the general Data Distribution Service (DDS), allowing the Preservation Service to pull the head bags it needs from long-term storage. \r\n\r\nThis PR adds more than was originally spec-ed for [ODD-619](http://mml.nist.gov:8080/browse/ODD-619) task.  The task was conceived as the first step of a broad redesign of the DDS where the DDS would be composed of three sub-services: the `PreservationBagService`, a `FileDownloadService`, and a `DataPackagingService` (see [DataDistribCodeDesign](http://odiwiki.nist.gov/ODI/DataDistribCodeDesign)); the ODD-619 task was to deliver the first of these (under a new Java package, [gov.nist.oar.distrib](https://github.com/usnistgov/oar-dist-service/tree/feature/ODD619-presbagsvc/src/main/java/gov/nist/oar/distrib)).  While the code for the Bag service was being developed, substantial changes were being made to the mainline branch to fix downloading problems.  Rather merging the new code with the recently fixed code, it seem better and more robust to refactor the fixed code into the new design.  As a result this PR delivers both the [`PreservationBagService`](https://github.com/usnistgov/oar-dist-service/blob/feature/ODD619-presbagsvc/src/main/java/gov/nist/oar/distrib/service/PreservationBagService.java) and the [`FileDownloadService`](https://github.com/usnistgov/oar-dist-service/blob/feature/ODD619-presbagsvc/src/main/java/gov/nist/oar/distrib/service/FileDownloadService.java).  The old download implementation (under [gov.nist.oar.ds](https://github.com/usnistgov/oar-dist-service/tree/1.0.6/src/main/java/gov/nist/oar/ds)) has been fully deprecated.\r\n\r\n(Note the `DataPackagingService` is intended to handle the creation of custom \"zipped\" downloads from the \"download all\" button and the data cart.  Memory issues associated with the already deployed download-all function caused it to be removed; the data cart-supporting service, not yet deployed, has the same issues, and thus should _not_ be deployed without fixes.  This PR recommends that the fixes be made in the context of the new design.)","created_at":"2018-09-21T22:00:16Z","updated_at":"2018-10-25T19:12:00Z","closed_at":"2018-10-25T19:12:00Z","merged_at":"2018-10-25T19:12:00Z","merge_commit_sha":"626c6fa5d705861702d6a7b539f04d9d6886b678","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50/commits","review_comments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50/comments","review_comment_url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/50/comments","statuses_url":"https://api.github.com/repos/usnistgov/oar-dist-service/statuses/d801fb8fba252e474429e86ff801760d22915107","head":{"label":"usnistgov:feature/ODD619-presbagsvc","ref":"feature/ODD619-presbagsvc","sha":"d801fb8fba252e474429e86ff801760d22915107","user":{"login":"usnistgov","id":5330158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzAxNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"repo":{"id":71503916,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwMzkxNg==","name":"oar-dist-service","full_name":"usnistgov/oar-dist-service","private":false,"owner":{"login":"usnistgov","id":5330158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzAxNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/usnistgov/oar-dist-service","description":"OAR Distribution Service Repo","fork":false,"url":"https://api.github.com/repos/usnistgov/oar-dist-service","forks_url":"https://api.github.com/repos/usnistgov/oar-dist-service/forks","keys_url":"https://api.github.com/repos/usnistgov/oar-dist-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usnistgov/oar-dist-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usnistgov/oar-dist-service/teams","hooks_url":"https://api.github.com/repos/usnistgov/oar-dist-service/hooks","issue_events_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/events{/number}","events_url":"https://api.github.com/repos/usnistgov/oar-dist-service/events","assignees_url":"https://api.github.com/repos/usnistgov/oar-dist-service/assignees{/user}","branches_url":"https://api.github.com/repos/usnistgov/oar-dist-service/branches{/branch}","tags_url":"https://api.github.com/repos/usnistgov/oar-dist-service/tags","blobs_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usnistgov/oar-dist-service/statuses/{sha}","languages_url":"https://api.github.com/repos/usnistgov/oar-dist-service/languages","stargazers_url":"https://api.github.com/repos/usnistgov/oar-dist-service/stargazers","contributors_url":"https://api.github.com/repos/usnistgov/oar-dist-service/contributors","subscribers_url":"https://api.github.com/repos/usnistgov/oar-dist-service/subscribers","subscription_url":"https://api.github.com/repos/usnistgov/oar-dist-service/subscription","commits_url":"https://api.github.com/repos/usnistgov/oar-dist-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/usnistgov/oar-dist-service/contents/{+path}","compare_url":"https://api.github.com/repos/usnistgov/oar-dist-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usnistgov/oar-dist-service/merges","archive_url":"https://api.github.com/repos/usnistgov/oar-dist-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usnistgov/oar-dist-service/downloads","issues_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues{/number}","pulls_url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls{/number}","milestones_url":"https://api.github.com/repos/usnistgov/oar-dist-service/milestones{/number}","notifications_url":"https://api.github.com/repos/usnistgov/oar-dist-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usnistgov/oar-dist-service/labels{/name}","releases_url":"https://api.github.com/repos/usnistgov/oar-dist-service/releases{/id}","deployments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/deployments","created_at":"2016-10-20T20:58:15Z","updated_at":"2018-09-19T02:35:52Z","pushed_at":"2018-10-25T19:12:00Z","git_url":"git://github.com/usnistgov/oar-dist-service.git","ssh_url":"git@github.com:usnistgov/oar-dist-service.git","clone_url":"https://github.com/usnistgov/oar-dist-service.git","svn_url":"https://github.com/usnistgov/oar-dist-service","homepage":null,"size":1332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":6,"open_issues":2,"watchers":0,"default_branch":"integration"}},"base":{"label":"usnistgov:integration","ref":"integration","sha":"f01e81474831bd7192848e14b8b905e775954514","user":{"login":"usnistgov","id":5330158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzAxNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"repo":{"id":71503916,"node_id":"MDEwOlJlcG9zaXRvcnk3MTUwMzkxNg==","name":"oar-dist-service","full_name":"usnistgov/oar-dist-service","private":false,"owner":{"login":"usnistgov","id":5330158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzAxNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5330158?v=4","gravatar_id":"","url":"https://api.github.com/users/usnistgov","html_url":"https://github.com/usnistgov","followers_url":"https://api.github.com/users/usnistgov/followers","following_url":"https://api.github.com/users/usnistgov/following{/other_user}","gists_url":"https://api.github.com/users/usnistgov/gists{/gist_id}","starred_url":"https://api.github.com/users/usnistgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usnistgov/subscriptions","organizations_url":"https://api.github.com/users/usnistgov/orgs","repos_url":"https://api.github.com/users/usnistgov/repos","events_url":"https://api.github.com/users/usnistgov/events{/privacy}","received_events_url":"https://api.github.com/users/usnistgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/usnistgov/oar-dist-service","description":"OAR Distribution Service Repo","fork":false,"url":"https://api.github.com/repos/usnistgov/oar-dist-service","forks_url":"https://api.github.com/repos/usnistgov/oar-dist-service/forks","keys_url":"https://api.github.com/repos/usnistgov/oar-dist-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usnistgov/oar-dist-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usnistgov/oar-dist-service/teams","hooks_url":"https://api.github.com/repos/usnistgov/oar-dist-service/hooks","issue_events_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/events{/number}","events_url":"https://api.github.com/repos/usnistgov/oar-dist-service/events","assignees_url":"https://api.github.com/repos/usnistgov/oar-dist-service/assignees{/user}","branches_url":"https://api.github.com/repos/usnistgov/oar-dist-service/branches{/branch}","tags_url":"https://api.github.com/repos/usnistgov/oar-dist-service/tags","blobs_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usnistgov/oar-dist-service/statuses/{sha}","languages_url":"https://api.github.com/repos/usnistgov/oar-dist-service/languages","stargazers_url":"https://api.github.com/repos/usnistgov/oar-dist-service/stargazers","contributors_url":"https://api.github.com/repos/usnistgov/oar-dist-service/contributors","subscribers_url":"https://api.github.com/repos/usnistgov/oar-dist-service/subscribers","subscription_url":"https://api.github.com/repos/usnistgov/oar-dist-service/subscription","commits_url":"https://api.github.com/repos/usnistgov/oar-dist-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/usnistgov/oar-dist-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/usnistgov/oar-dist-service/contents/{+path}","compare_url":"https://api.github.com/repos/usnistgov/oar-dist-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usnistgov/oar-dist-service/merges","archive_url":"https://api.github.com/repos/usnistgov/oar-dist-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usnistgov/oar-dist-service/downloads","issues_url":"https://api.github.com/repos/usnistgov/oar-dist-service/issues{/number}","pulls_url":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls{/number}","milestones_url":"https://api.github.com/repos/usnistgov/oar-dist-service/milestones{/number}","notifications_url":"https://api.github.com/repos/usnistgov/oar-dist-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usnistgov/oar-dist-service/labels{/name}","releases_url":"https://api.github.com/repos/usnistgov/oar-dist-service/releases{/id}","deployments_url":"https://api.github.com/repos/usnistgov/oar-dist-service/deployments","created_at":"2016-10-20T20:58:15Z","updated_at":"2018-09-19T02:35:52Z","pushed_at":"2018-10-25T19:12:00Z","git_url":"git://github.com/usnistgov/oar-dist-service.git","ssh_url":"git@github.com:usnistgov/oar-dist-service.git","clone_url":"https://github.com/usnistgov/oar-dist-service.git","svn_url":"https://github.com/usnistgov/oar-dist-service","homepage":null,"size":1332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":6,"open_issues":2,"watchers":0,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50"},"html":{"href":"https://github.com/usnistgov/oar-dist-service/pull/50"},"issue":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/50"},"comments":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/usnistgov/oar-dist-service/statuses/d801fb8fba252e474429e86ff801760d22915107"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RayPlante","id":1027700,"node_id":"MDQ6VXNlcjEwMjc3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1027700?v=4","gravatar_id":"","url":"https://api.github.com/users/RayPlante","html_url":"https://github.com/RayPlante","followers_url":"https://api.github.com/users/RayPlante/followers","following_url":"https://api.github.com/users/RayPlante/following{/other_user}","gists_url":"https://api.github.com/users/RayPlante/gists{/gist_id}","starred_url":"https://api.github.com/users/RayPlante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RayPlante/subscriptions","organizations_url":"https://api.github.com/users/RayPlante/orgs","repos_url":"https://api.github.com/users/RayPlante/repos","events_url":"https://api.github.com/users/RayPlante/events{/privacy}","received_events_url":"https://api.github.com/users/RayPlante/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":57,"additions":7977,"deletions":2793,"changed_files":97}}
{"actor":{"display_login":"RayPlante"}}