{"action":"created","issue":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/2289","repository_url":"https://api.github.com/repos/rails-api/active_model_serializers","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/2289/labels{/name}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/2289/comments","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/2289/events","html_url":"https://github.com/rails-api/active_model_serializers/pull/2289","id":367925702,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjIyMDc2","number":2289,"title":"Eagerload on application boot","user":{"login":"f-mer","id":17234623,"node_id":"MDQ6VXNlcjE3MjM0NjIz","avatar_url":"https://avatars3.githubusercontent.com/u/17234623?v=4","gravatar_id":"","url":"https://api.github.com/users/f-mer","html_url":"https://github.com/f-mer","followers_url":"https://api.github.com/users/f-mer/followers","following_url":"https://api.github.com/users/f-mer/following{/other_user}","gists_url":"https://api.github.com/users/f-mer/gists{/gist_id}","starred_url":"https://api.github.com/users/f-mer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-mer/subscriptions","organizations_url":"https://api.github.com/users/f-mer/orgs","repos_url":"https://api.github.com/users/f-mer/repos","events_url":"https://api.github.com/users/f-mer/events{/privacy}","received_events_url":"https://api.github.com/users/f-mer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T19:38:17Z","updated_at":"2018-10-08T20:54:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/2289","html_url":"https://github.com/rails-api/active_model_serializers/pull/2289","diff_url":"https://github.com/rails-api/active_model_serializers/pull/2289.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/2289.patch"},"body":"#### Purpose\r\nLoad all modules and classes during application boot. This is needed because rails 5 unhooks autoloading (rails/rails@a71350cae0082193ad8c66d65ab62e8bb0b7853b) after the application has booted.\r\n\r\n#### Changes\r\nEagerload dependencies during application boot by using `eager_autoload`.\r\n\r\n#### Related GitHub issues\r\n#2255\r\n\r\n#### Additional helpful information\r\nNot sure if eagerloading `ActiveModelSerializers::Adapter::JsonApi` should be the default or the user has  to add explicitly `config.eager_load_namespaces << ActiveModelSerializers::Adapter::JsonApi` to reduce memory usage if another adapter is used. \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments/427975909","html_url":"https://github.com/rails-api/active_model_serializers/pull/2289#issuecomment-427975909","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/2289","id":427975909,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzk3NTkwOQ==","user":{"login":"bf4","id":142914,"node_id":"MDQ6VXNlcjE0MjkxNA==","avatar_url":"https://avatars2.githubusercontent.com/u/142914?v=4","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T20:54:26Z","updated_at":"2018-10-08T20:54:26Z","author_association":"MEMBER","body":"Looks good. Looks like there was a change in minitest run_one_method\r\n\r\n```\r\n/home/travis/build/rails-api/active_model_serializers/vendor/bundle/ruby/2.2.0/gems/minitest-5.11.3/lib/minitest.rb:961:in `run_one_method': RailtieTest::WithRailsRequiredFirst#run _must_ return a Result (RuntimeError)\r\n\tfrom /home/travis/build/rails-api/active_model_serializers/vendor/bundle/ruby/2.2.0/gems/minitest-5.11.3/lib/minitest/parallel.rb:33:in `block (2 levels) in start'\r\nrake aborted!\r\n```"}}
{"actor":{"display_login":"bf4"}}