{"action":"created","comment":{"url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/comments/190862533","pull_request_review_id":123331846,"id":190862533,"diff_hunk":"@@ -22,32 +22,22 @@ module.exports = {\n   ],\n \n   copy: [\n-    { from: path.resolve(source_folder, 'ecl-icons/fonts'), to: path.resolve(__dirname, 'fonts')},\n-    { from: path.resolve(source_folder, 'ecl-forms-checkboxes/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder, 'ecl-forms-feedback-messages/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder, 'ecl-forms-radios/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder, 'ecl-forms-selects/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder, 'ecl-logos/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder, 'ecl-messages/images'), to: path.resolve(__dirname, 'images')},\n-    { from: path.resolve(source_folder), patterns: 'ecl-accordions/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-breadcrumbs/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-buttons/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-fields/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-forms-checkboxes/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-forms-labels/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-forms-radios/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-link-blocks/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-links/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-logos/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-messages/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-navigation-lists/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-navigation-menus/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-pagers/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-skip-links/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-lang-select-sites/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-language-list/*.twig', to: path.resolve(__dirname, 'templates/components') },\n-    { from: path.resolve(source_folder), patterns: 'ecl-dialogs/*.twig', to: path.resolve(__dirname, 'templates/components') },","path":"ecl-builder.config.js","position":80,"original_position":42,"commit_id":"a8c8c16568b290a331c7f606d49f80072d03af85","original_commit_id":"ecf445a38b37e55e798b0e67689d6c01844d40f6","user":{"login":"voidtek","id":186827,"avatar_url":"https://avatars2.githubusercontent.com/u/186827?v=4","gravatar_id":"","url":"https://api.github.com/users/voidtek","html_url":"https://github.com/voidtek","followers_url":"https://api.github.com/users/voidtek/followers","following_url":"https://api.github.com/users/voidtek/following{/other_user}","gists_url":"https://api.github.com/users/voidtek/gists{/gist_id}","starred_url":"https://api.github.com/users/voidtek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidtek/subscriptions","organizations_url":"https://api.github.com/users/voidtek/orgs","repos_url":"https://api.github.com/users/voidtek/repos","events_url":"https://api.github.com/users/voidtek/events{/privacy}","received_events_url":"https://api.github.com/users/voidtek/received_events","type":"User","site_admin":false},"body":"My idea is to optimize and implement a very generic approach. For example, for images, it is not possible with the actual runner to put a generic step.\r\nIn addition, if we have to put all the necessary components and dependencies, we will add more than 20 lines in the runner, I think it's useless and not optimized.","created_at":"2018-05-25T11:10:20Z","updated_at":"2018-05-25T11:10:21Z","html_url":"https://github.com/openeuropa/oe_theme/pull/73#discussion_r190862533","pull_request_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/comments/190862533"},"html":{"href":"https://github.com/openeuropa/oe_theme/pull/73#discussion_r190862533"},"pull_request":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73"}},"in_reply_to_id":190256799},"pull_request":{"url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73","id":189723854,"html_url":"https://github.com/openeuropa/oe_theme/pull/73","diff_url":"https://github.com/openeuropa/oe_theme/pull/73.diff","patch_url":"https://github.com/openeuropa/oe_theme/pull/73.patch","issue_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/73","number":73,"state":"open","locked":false,"title":"OPENEUROPA-581: Update ECL library to 1.0.0.","user":{"login":"voidtek","id":186827,"avatar_url":"https://avatars2.githubusercontent.com/u/186827?v=4","gravatar_id":"","url":"https://api.github.com/users/voidtek","html_url":"https://github.com/voidtek","followers_url":"https://api.github.com/users/voidtek/followers","following_url":"https://api.github.com/users/voidtek/following{/other_user}","gists_url":"https://api.github.com/users/voidtek/gists{/gist_id}","starred_url":"https://api.github.com/users/voidtek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voidtek/subscriptions","organizations_url":"https://api.github.com/users/voidtek/orgs","repos_url":"https://api.github.com/users/voidtek/repos","events_url":"https://api.github.com/users/voidtek/events{/privacy}","received_events_url":"https://api.github.com/users/voidtek/received_events","type":"User","site_admin":false},"body":"## OPENEUROPA-581\r\n\r\n## Description\r\n\r\nUpdate ECL library to 1.0.0.","created_at":"2018-05-22T16:34:21Z","updated_at":"2018-05-25T11:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c856d7e5bac50863f65d3fbd94716855e2791f61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73/commits","review_comments_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73/comments","review_comment_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/73/comments","statuses_url":"https://api.github.com/repos/openeuropa/oe_theme/statuses/a8c8c16568b290a331c7f606d49f80072d03af85","head":{"label":"openeuropa:OPENEUROPA-581","ref":"OPENEUROPA-581","sha":"a8c8c16568b290a331c7f606d49f80072d03af85","user":{"login":"openeuropa","id":35874187,"avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"repo":{"id":91689679,"name":"oe_theme","full_name":"openeuropa/oe_theme","owner":{"login":"openeuropa","id":35874187,"avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openeuropa/oe_theme","description":"OpenEuropa Drupal 8 theme based on the Europa Component Library.","fork":false,"url":"https://api.github.com/repos/openeuropa/oe_theme","forks_url":"https://api.github.com/repos/openeuropa/oe_theme/forks","keys_url":"https://api.github.com/repos/openeuropa/oe_theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openeuropa/oe_theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openeuropa/oe_theme/teams","hooks_url":"https://api.github.com/repos/openeuropa/oe_theme/hooks","issue_events_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/events{/number}","events_url":"https://api.github.com/repos/openeuropa/oe_theme/events","assignees_url":"https://api.github.com/repos/openeuropa/oe_theme/assignees{/user}","branches_url":"https://api.github.com/repos/openeuropa/oe_theme/branches{/branch}","tags_url":"https://api.github.com/repos/openeuropa/oe_theme/tags","blobs_url":"https://api.github.com/repos/openeuropa/oe_theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openeuropa/oe_theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openeuropa/oe_theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/openeuropa/oe_theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openeuropa/oe_theme/statuses/{sha}","languages_url":"https://api.github.com/repos/openeuropa/oe_theme/languages","stargazers_url":"https://api.github.com/repos/openeuropa/oe_theme/stargazers","contributors_url":"https://api.github.com/repos/openeuropa/oe_theme/contributors","subscribers_url":"https://api.github.com/repos/openeuropa/oe_theme/subscribers","subscription_url":"https://api.github.com/repos/openeuropa/oe_theme/subscription","commits_url":"https://api.github.com/repos/openeuropa/oe_theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/openeuropa/oe_theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/openeuropa/oe_theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/openeuropa/oe_theme/contents/{+path}","compare_url":"https://api.github.com/repos/openeuropa/oe_theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openeuropa/oe_theme/merges","archive_url":"https://api.github.com/repos/openeuropa/oe_theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openeuropa/oe_theme/downloads","issues_url":"https://api.github.com/repos/openeuropa/oe_theme/issues{/number}","pulls_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls{/number}","milestones_url":"https://api.github.com/repos/openeuropa/oe_theme/milestones{/number}","notifications_url":"https://api.github.com/repos/openeuropa/oe_theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openeuropa/oe_theme/labels{/name}","releases_url":"https://api.github.com/repos/openeuropa/oe_theme/releases{/id}","deployments_url":"https://api.github.com/repos/openeuropa/oe_theme/deployments","created_at":"2017-05-18T12:15:38Z","updated_at":"2018-05-14T13:21:36Z","pushed_at":"2018-05-25T09:45:13Z","git_url":"git://github.com/openeuropa/oe_theme.git","ssh_url":"git@github.com:openeuropa/oe_theme.git","clone_url":"https://github.com/openeuropa/oe_theme.git","svn_url":"https://github.com/openeuropa/oe_theme","homepage":"","size":1637,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1"},"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"openeuropa:master","ref":"master","sha":"a5f68facac2af746ef1c42fff507a2b2ca4413ba","user":{"login":"openeuropa","id":35874187,"avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"repo":{"id":91689679,"name":"oe_theme","full_name":"openeuropa/oe_theme","owner":{"login":"openeuropa","id":35874187,"avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openeuropa/oe_theme","description":"OpenEuropa Drupal 8 theme based on the Europa Component Library.","fork":false,"url":"https://api.github.com/repos/openeuropa/oe_theme","forks_url":"https://api.github.com/repos/openeuropa/oe_theme/forks","keys_url":"https://api.github.com/repos/openeuropa/oe_theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openeuropa/oe_theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openeuropa/oe_theme/teams","hooks_url":"https://api.github.com/repos/openeuropa/oe_theme/hooks","issue_events_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/events{/number}","events_url":"https://api.github.com/repos/openeuropa/oe_theme/events","assignees_url":"https://api.github.com/repos/openeuropa/oe_theme/assignees{/user}","branches_url":"https://api.github.com/repos/openeuropa/oe_theme/branches{/branch}","tags_url":"https://api.github.com/repos/openeuropa/oe_theme/tags","blobs_url":"https://api.github.com/repos/openeuropa/oe_theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openeuropa/oe_theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openeuropa/oe_theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/openeuropa/oe_theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openeuropa/oe_theme/statuses/{sha}","languages_url":"https://api.github.com/repos/openeuropa/oe_theme/languages","stargazers_url":"https://api.github.com/repos/openeuropa/oe_theme/stargazers","contributors_url":"https://api.github.com/repos/openeuropa/oe_theme/contributors","subscribers_url":"https://api.github.com/repos/openeuropa/oe_theme/subscribers","subscription_url":"https://api.github.com/repos/openeuropa/oe_theme/subscription","commits_url":"https://api.github.com/repos/openeuropa/oe_theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/openeuropa/oe_theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/openeuropa/oe_theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/openeuropa/oe_theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/openeuropa/oe_theme/contents/{+path}","compare_url":"https://api.github.com/repos/openeuropa/oe_theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openeuropa/oe_theme/merges","archive_url":"https://api.github.com/repos/openeuropa/oe_theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openeuropa/oe_theme/downloads","issues_url":"https://api.github.com/repos/openeuropa/oe_theme/issues{/number}","pulls_url":"https://api.github.com/repos/openeuropa/oe_theme/pulls{/number}","milestones_url":"https://api.github.com/repos/openeuropa/oe_theme/milestones{/number}","notifications_url":"https://api.github.com/repos/openeuropa/oe_theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openeuropa/oe_theme/labels{/name}","releases_url":"https://api.github.com/repos/openeuropa/oe_theme/releases{/id}","deployments_url":"https://api.github.com/repos/openeuropa/oe_theme/deployments","created_at":"2017-05-18T12:15:38Z","updated_at":"2018-05-14T13:21:36Z","pushed_at":"2018-05-25T09:45:13Z","git_url":"git://github.com/openeuropa/oe_theme.git","ssh_url":"git@github.com:openeuropa/oe_theme.git","clone_url":"https://github.com/openeuropa/oe_theme.git","svn_url":"https://github.com/openeuropa/oe_theme","homepage":"","size":1637,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1"},"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73"},"html":{"href":"https://github.com/openeuropa/oe_theme/pull/73"},"issue":{"href":"https://api.github.com/repos/openeuropa/oe_theme/issues/73"},"comments":{"href":"https://api.github.com/repos/openeuropa/oe_theme/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openeuropa/oe_theme/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/openeuropa/oe_theme/statuses/a8c8c16568b290a331c7f606d49f80072d03af85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"voidtek"}}