{"action":"created","issue":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/2345","repository_url":"https://api.github.com/repos/dreamwidth/dw-free","labels_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/2345/labels{/name}","comments_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/2345/comments","events_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/2345/events","html_url":"https://github.com/dreamwidth/dw-free/pull/2345","id":333055498,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzczMjYy","number":2345,"title":"Allow email spell-checking to be overridden","user":{"login":"chrisboyle","id":127305,"node_id":"MDQ6VXNlcjEyNzMwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/127305?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisboyle","html_url":"https://github.com/chrisboyle","followers_url":"https://api.github.com/users/chrisboyle/followers","following_url":"https://api.github.com/users/chrisboyle/following{/other_user}","gists_url":"https://api.github.com/users/chrisboyle/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisboyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisboyle/subscriptions","organizations_url":"https://api.github.com/users/chrisboyle/orgs","repos_url":"https://api.github.com/users/chrisboyle/repos","events_url":"https://api.github.com/users/chrisboyle/events{/privacy}","received_events_url":"https://api.github.com/users/chrisboyle/received_events","type":"User","site_admin":false},"labels":[{"id":109437720,"node_id":"MDU6TGFiZWwxMDk0Mzc3MjA=","url":"https://api.github.com/repos/dreamwidth/dw-free/labels/status:%20untriaged","name":"status: untriaged","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-17T11:27:59Z","updated_at":"2018-06-17T18:11:59Z","closed_at":"2018-06-17T18:11:06Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dreamwidth/dw-free/pulls/2345","html_url":"https://github.com/dreamwidth/dw-free/pull/2345","diff_url":"https://github.com/dreamwidth/dw-free/pull/2345.diff","patch_url":"https://github.com/dreamwidth/dw-free/pull/2345.patch"},"body":"Fixes #2304, in the many, many places where we check email addresses.\r\n\r\nWhere possible, this gives you a tickbox near the input saying \"Yes I'm sure this is correct\".\r\n\r\nThe **display** email, set on the Edit Profile page, is simply excluded from spell-checking because that page doesn't have a way to hold unsaved edits while showing you a checkbox, and reworking it to do so looked too complicated, see 972d7b437ad365077ec3ed40c200a68c0dd6dee9. That page will also now tell you if your email address is more seriously invalid, rather than silently dropping that part of the change.\r\n\r\nThe sysbans page has similar issues. For that one I've made the ticky always visible up-front (if the type is email).\r\n\r\nFor the admin console command `email_alias`, you can append `!` to the address to achieve the override, and will be prompted to do so.\r\n\r\nAlso added `mail.com`, `ymail.com` to known-good domains as per original discussion on #993."},"comment":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/comments/397896280","html_url":"https://github.com/dreamwidth/dw-free/pull/2345#issuecomment-397896280","issue_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/2345","id":397896280,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzg5NjI4MA==","user":{"login":"zorkian","id":361428,"node_id":"MDQ6VXNlcjM2MTQyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/361428?v=4","gravatar_id":"","url":"https://api.github.com/users/zorkian","html_url":"https://github.com/zorkian","followers_url":"https://api.github.com/users/zorkian/followers","following_url":"https://api.github.com/users/zorkian/following{/other_user}","gists_url":"https://api.github.com/users/zorkian/gists{/gist_id}","starred_url":"https://api.github.com/users/zorkian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zorkian/subscriptions","organizations_url":"https://api.github.com/users/zorkian/orgs","repos_url":"https://api.github.com/users/zorkian/repos","events_url":"https://api.github.com/users/zorkian/events{/privacy}","received_events_url":"https://api.github.com/users/zorkian/received_events","type":"User","site_admin":false},"created_at":"2018-06-17T18:11:59Z","updated_at":"2018-06-17T18:11:59Z","author_association":"MEMBER","body":"Thank you for doing this, and especially for being so thorough to each of the places we touch emails. That's appreciated! Also some cleanup in date presentation in some places?\r\n\r\nAnyway I read through the code and it seems sane, so I'm merging!"}}
{"actor":{"display_login":"zorkian"}}