{"action":"created","comment":{"url":"https://api.github.com/repos/unosquare/tubular-react/pulls/comments/236398460","pull_request_review_id":178465872,"id":236398460,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjM5ODQ2MA==","diff_hunk":"@@ -10,13 +10,13 @@ export default class ToolbarOptions {\n \n     constructor(options?: any) {\n        // TODO: Apply options\n-       this.advancePagination = true;\n-       this.bottomPager = true;\n-       this.exportButton = true;\n-       this.printButton = true;\n-       this.searchText = true;\n-       this.topPager = true;\n-       this.rowsPerPageOptions = [10, 20, 50, 100];\n-       this.itemsPerPage = 10;\n+       this.advancePagination = options && 'advancePagination' in options? options.advancePagination : true;\n+       this.bottomPager = options && 'bottomPager' in options? options.bottomPager : true;\n+       this.exportButton = options && 'exportButton' in options? options.exportButton : true;\n+       this.printButton = options && 'printButton' in options? options.printButton : true;\n+       this.searchText = options && 'searchText' in options? options.searchText : true;\n+       this.topPager = options && 'topPager' in options? options.topPager : true;\n+       this.rowsPerPageOptions = options && 'rowsPerPageOptions' in options? options.rowsPerPageOptions : [10, 20, 50, 100];","path":"src/Models/ToolbarOptions.ts","position":18,"original_position":18,"commit_id":"93af82e0cd653911d1106c9215803072671dfbe3","original_commit_id":"93af82e0cd653911d1106c9215803072671dfbe3","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [missing whitespace](https://app.codacy.com/app/UnosquareLabs/tubular-react/pullRequest?prid=2627077)","created_at":"2018-11-26T19:40:10Z","updated_at":"2018-11-26T19:40:10Z","html_url":"https://github.com/unosquare/tubular-react/pull/265#discussion_r236398460","pull_request_url":"https://api.github.com/repos/unosquare/tubular-react/pulls/265","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/comments/236398460"},"html":{"href":"https://github.com/unosquare/tubular-react/pull/265#discussion_r236398460"},"pull_request":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/unosquare/tubular-react/pulls/265","id":233647514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjQ3NTE0","html_url":"https://github.com/unosquare/tubular-react/pull/265","diff_url":"https://github.com/unosquare/tubular-react/pull/265.diff","patch_url":"https://github.com/unosquare/tubular-react/pull/265.patch","issue_url":"https://api.github.com/repos/unosquare/tubular-react/issues/265","number":265,"state":"open","locked":false,"title":"Simple Grid #260","user":{"login":"metalerk","id":13503868,"node_id":"MDQ6VXNlcjEzNTAzODY4","avatar_url":"https://avatars2.githubusercontent.com/u/13503868?v=4","gravatar_id":"","url":"https://api.github.com/users/metalerk","html_url":"https://github.com/metalerk","followers_url":"https://api.github.com/users/metalerk/followers","following_url":"https://api.github.com/users/metalerk/following{/other_user}","gists_url":"https://api.github.com/users/metalerk/gists{/gist_id}","starred_url":"https://api.github.com/users/metalerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalerk/subscriptions","organizations_url":"https://api.github.com/users/metalerk/orgs","repos_url":"https://api.github.com/users/metalerk/repos","events_url":"https://api.github.com/users/metalerk/events{/privacy}","received_events_url":"https://api.github.com/users/metalerk/received_events","type":"User","site_admin":false},"body":"# Pull request for #260 \r\n\r\n## Changes\r\n\r\n- __Modify__ `src/Models/ToolbarOptions.ts` to allow Datagrids to accept incoming configs instead just overwriting with defaults.\r\n\r\n- __Update__ `srcdocs/BasicFeatures.tsx` and `src/SampleFeatures.tsx` with the desired config (simple pagination, drop export/print button and search text). ","created_at":"2018-11-26T18:01:14Z","updated_at":"2018-11-26T19:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c7cbd955072458667eff01aaae7899565ed1e7","assignee":{"login":"metalerk","id":13503868,"node_id":"MDQ6VXNlcjEzNTAzODY4","avatar_url":"https://avatars2.githubusercontent.com/u/13503868?v=4","gravatar_id":"","url":"https://api.github.com/users/metalerk","html_url":"https://github.com/metalerk","followers_url":"https://api.github.com/users/metalerk/followers","following_url":"https://api.github.com/users/metalerk/following{/other_user}","gists_url":"https://api.github.com/users/metalerk/gists{/gist_id}","starred_url":"https://api.github.com/users/metalerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalerk/subscriptions","organizations_url":"https://api.github.com/users/metalerk/orgs","repos_url":"https://api.github.com/users/metalerk/repos","events_url":"https://api.github.com/users/metalerk/events{/privacy}","received_events_url":"https://api.github.com/users/metalerk/received_events","type":"User","site_admin":false},"assignees":[{"login":"metalerk","id":13503868,"node_id":"MDQ6VXNlcjEzNTAzODY4","avatar_url":"https://avatars2.githubusercontent.com/u/13503868?v=4","gravatar_id":"","url":"https://api.github.com/users/metalerk","html_url":"https://github.com/metalerk","followers_url":"https://api.github.com/users/metalerk/followers","following_url":"https://api.github.com/users/metalerk/following{/other_user}","gists_url":"https://api.github.com/users/metalerk/gists{/gist_id}","starred_url":"https://api.github.com/users/metalerk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalerk/subscriptions","organizations_url":"https://api.github.com/users/metalerk/orgs","repos_url":"https://api.github.com/users/metalerk/repos","events_url":"https://api.github.com/users/metalerk/events{/privacy}","received_events_url":"https://api.github.com/users/metalerk/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"geoperez","id":1775792,"node_id":"MDQ6VXNlcjE3NzU3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1775792?v=4","gravatar_id":"","url":"https://api.github.com/users/geoperez","html_url":"https://github.com/geoperez","followers_url":"https://api.github.com/users/geoperez/followers","following_url":"https://api.github.com/users/geoperez/following{/other_user}","gists_url":"https://api.github.com/users/geoperez/gists{/gist_id}","starred_url":"https://api.github.com/users/geoperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoperez/subscriptions","organizations_url":"https://api.github.com/users/geoperez/orgs","repos_url":"https://api.github.com/users/geoperez/repos","events_url":"https://api.github.com/users/geoperez/events{/privacy}","received_events_url":"https://api.github.com/users/geoperez/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":805707558,"node_id":"MDU6TGFiZWw4MDU3MDc1NTg=","url":"https://api.github.com/repos/unosquare/tubular-react/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/unosquare/tubular-react/milestones/4","html_url":"https://github.com/unosquare/tubular-react/milestone/4","labels_url":"https://api.github.com/repos/unosquare/tubular-react/milestones/4/labels","id":3561609,"node_id":"MDk6TWlsZXN0b25lMzU2MTYwOQ==","number":4,"title":"0.6","description":"","creator":{"login":"geoperez","id":1775792,"node_id":"MDQ6VXNlcjE3NzU3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1775792?v=4","gravatar_id":"","url":"https://api.github.com/users/geoperez","html_url":"https://github.com/geoperez","followers_url":"https://api.github.com/users/geoperez/followers","following_url":"https://api.github.com/users/geoperez/following{/other_user}","gists_url":"https://api.github.com/users/geoperez/gists{/gist_id}","starred_url":"https://api.github.com/users/geoperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoperez/subscriptions","organizations_url":"https://api.github.com/users/geoperez/orgs","repos_url":"https://api.github.com/users/geoperez/repos","events_url":"https://api.github.com/users/geoperez/events{/privacy}","received_events_url":"https://api.github.com/users/geoperez/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":40,"state":"open","created_at":"2018-08-10T18:16:33Z","updated_at":"2018-11-26T19:15:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/unosquare/tubular-react/pulls/265/commits","review_comments_url":"https://api.github.com/repos/unosquare/tubular-react/pulls/265/comments","review_comment_url":"https://api.github.com/repos/unosquare/tubular-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unosquare/tubular-react/issues/265/comments","statuses_url":"https://api.github.com/repos/unosquare/tubular-react/statuses/93af82e0cd653911d1106c9215803072671dfbe3","head":{"label":"unosquare:issue-260-simple-grid","ref":"issue-260-simple-grid","sha":"93af82e0cd653911d1106c9215803072671dfbe3","user":{"login":"unosquare","id":5685705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5685705?v=4","gravatar_id":"","url":"https://api.github.com/users/unosquare","html_url":"https://github.com/unosquare","followers_url":"https://api.github.com/users/unosquare/followers","following_url":"https://api.github.com/users/unosquare/following{/other_user}","gists_url":"https://api.github.com/users/unosquare/gists{/gist_id}","starred_url":"https://api.github.com/users/unosquare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unosquare/subscriptions","organizations_url":"https://api.github.com/users/unosquare/orgs","repos_url":"https://api.github.com/users/unosquare/repos","events_url":"https://api.github.com/users/unosquare/events{/privacy}","received_events_url":"https://api.github.com/users/unosquare/received_events","type":"Organization","site_admin":false},"repo":{"id":117600909,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MDA5MDk=","name":"tubular-react","full_name":"unosquare/tubular-react","private":false,"owner":{"login":"unosquare","id":5685705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5685705?v=4","gravatar_id":"","url":"https://api.github.com/users/unosquare","html_url":"https://github.com/unosquare","followers_url":"https://api.github.com/users/unosquare/followers","following_url":"https://api.github.com/users/unosquare/following{/other_user}","gists_url":"https://api.github.com/users/unosquare/gists{/gist_id}","starred_url":"https://api.github.com/users/unosquare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unosquare/subscriptions","organizations_url":"https://api.github.com/users/unosquare/orgs","repos_url":"https://api.github.com/users/unosquare/repos","events_url":"https://api.github.com/users/unosquare/events{/privacy}","received_events_url":"https://api.github.com/users/unosquare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unosquare/tubular-react","description":"Tubular React","fork":false,"url":"https://api.github.com/repos/unosquare/tubular-react","forks_url":"https://api.github.com/repos/unosquare/tubular-react/forks","keys_url":"https://api.github.com/repos/unosquare/tubular-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unosquare/tubular-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unosquare/tubular-react/teams","hooks_url":"https://api.github.com/repos/unosquare/tubular-react/hooks","issue_events_url":"https://api.github.com/repos/unosquare/tubular-react/issues/events{/number}","events_url":"https://api.github.com/repos/unosquare/tubular-react/events","assignees_url":"https://api.github.com/repos/unosquare/tubular-react/assignees{/user}","branches_url":"https://api.github.com/repos/unosquare/tubular-react/branches{/branch}","tags_url":"https://api.github.com/repos/unosquare/tubular-react/tags","blobs_url":"https://api.github.com/repos/unosquare/tubular-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unosquare/tubular-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unosquare/tubular-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/unosquare/tubular-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unosquare/tubular-react/statuses/{sha}","languages_url":"https://api.github.com/repos/unosquare/tubular-react/languages","stargazers_url":"https://api.github.com/repos/unosquare/tubular-react/stargazers","contributors_url":"https://api.github.com/repos/unosquare/tubular-react/contributors","subscribers_url":"https://api.github.com/repos/unosquare/tubular-react/subscribers","subscription_url":"https://api.github.com/repos/unosquare/tubular-react/subscription","commits_url":"https://api.github.com/repos/unosquare/tubular-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/unosquare/tubular-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/unosquare/tubular-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/unosquare/tubular-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/unosquare/tubular-react/contents/{+path}","compare_url":"https://api.github.com/repos/unosquare/tubular-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unosquare/tubular-react/merges","archive_url":"https://api.github.com/repos/unosquare/tubular-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unosquare/tubular-react/downloads","issues_url":"https://api.github.com/repos/unosquare/tubular-react/issues{/number}","pulls_url":"https://api.github.com/repos/unosquare/tubular-react/pulls{/number}","milestones_url":"https://api.github.com/repos/unosquare/tubular-react/milestones{/number}","notifications_url":"https://api.github.com/repos/unosquare/tubular-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unosquare/tubular-react/labels{/name}","releases_url":"https://api.github.com/repos/unosquare/tubular-react/releases{/id}","deployments_url":"https://api.github.com/repos/unosquare/tubular-react/deployments","created_at":"2018-01-15T22:12:45Z","updated_at":"2018-11-20T19:46:06Z","pushed_at":"2018-11-26T19:37:13Z","git_url":"git://github.com/unosquare/tubular-react.git","ssh_url":"git@github.com:unosquare/tubular-react.git","clone_url":"https://github.com/unosquare/tubular-react.git","svn_url":"https://github.com/unosquare/tubular-react","homepage":"https://unosquare.github.io/tubular-react","size":12512,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":7,"watchers":6,"default_branch":"master"}},"base":{"label":"unosquare:master","ref":"master","sha":"27cd62e52be7a7b3d7ef14bbe1275ca8d8d2a2b0","user":{"login":"unosquare","id":5685705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5685705?v=4","gravatar_id":"","url":"https://api.github.com/users/unosquare","html_url":"https://github.com/unosquare","followers_url":"https://api.github.com/users/unosquare/followers","following_url":"https://api.github.com/users/unosquare/following{/other_user}","gists_url":"https://api.github.com/users/unosquare/gists{/gist_id}","starred_url":"https://api.github.com/users/unosquare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unosquare/subscriptions","organizations_url":"https://api.github.com/users/unosquare/orgs","repos_url":"https://api.github.com/users/unosquare/repos","events_url":"https://api.github.com/users/unosquare/events{/privacy}","received_events_url":"https://api.github.com/users/unosquare/received_events","type":"Organization","site_admin":false},"repo":{"id":117600909,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MDA5MDk=","name":"tubular-react","full_name":"unosquare/tubular-react","private":false,"owner":{"login":"unosquare","id":5685705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5685705?v=4","gravatar_id":"","url":"https://api.github.com/users/unosquare","html_url":"https://github.com/unosquare","followers_url":"https://api.github.com/users/unosquare/followers","following_url":"https://api.github.com/users/unosquare/following{/other_user}","gists_url":"https://api.github.com/users/unosquare/gists{/gist_id}","starred_url":"https://api.github.com/users/unosquare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unosquare/subscriptions","organizations_url":"https://api.github.com/users/unosquare/orgs","repos_url":"https://api.github.com/users/unosquare/repos","events_url":"https://api.github.com/users/unosquare/events{/privacy}","received_events_url":"https://api.github.com/users/unosquare/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unosquare/tubular-react","description":"Tubular React","fork":false,"url":"https://api.github.com/repos/unosquare/tubular-react","forks_url":"https://api.github.com/repos/unosquare/tubular-react/forks","keys_url":"https://api.github.com/repos/unosquare/tubular-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unosquare/tubular-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unosquare/tubular-react/teams","hooks_url":"https://api.github.com/repos/unosquare/tubular-react/hooks","issue_events_url":"https://api.github.com/repos/unosquare/tubular-react/issues/events{/number}","events_url":"https://api.github.com/repos/unosquare/tubular-react/events","assignees_url":"https://api.github.com/repos/unosquare/tubular-react/assignees{/user}","branches_url":"https://api.github.com/repos/unosquare/tubular-react/branches{/branch}","tags_url":"https://api.github.com/repos/unosquare/tubular-react/tags","blobs_url":"https://api.github.com/repos/unosquare/tubular-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unosquare/tubular-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unosquare/tubular-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/unosquare/tubular-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unosquare/tubular-react/statuses/{sha}","languages_url":"https://api.github.com/repos/unosquare/tubular-react/languages","stargazers_url":"https://api.github.com/repos/unosquare/tubular-react/stargazers","contributors_url":"https://api.github.com/repos/unosquare/tubular-react/contributors","subscribers_url":"https://api.github.com/repos/unosquare/tubular-react/subscribers","subscription_url":"https://api.github.com/repos/unosquare/tubular-react/subscription","commits_url":"https://api.github.com/repos/unosquare/tubular-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/unosquare/tubular-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/unosquare/tubular-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/unosquare/tubular-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/unosquare/tubular-react/contents/{+path}","compare_url":"https://api.github.com/repos/unosquare/tubular-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unosquare/tubular-react/merges","archive_url":"https://api.github.com/repos/unosquare/tubular-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unosquare/tubular-react/downloads","issues_url":"https://api.github.com/repos/unosquare/tubular-react/issues{/number}","pulls_url":"https://api.github.com/repos/unosquare/tubular-react/pulls{/number}","milestones_url":"https://api.github.com/repos/unosquare/tubular-react/milestones{/number}","notifications_url":"https://api.github.com/repos/unosquare/tubular-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unosquare/tubular-react/labels{/name}","releases_url":"https://api.github.com/repos/unosquare/tubular-react/releases{/id}","deployments_url":"https://api.github.com/repos/unosquare/tubular-react/deployments","created_at":"2018-01-15T22:12:45Z","updated_at":"2018-11-20T19:46:06Z","pushed_at":"2018-11-26T19:37:13Z","git_url":"git://github.com/unosquare/tubular-react.git","ssh_url":"git@github.com:unosquare/tubular-react.git","clone_url":"https://github.com/unosquare/tubular-react.git","svn_url":"https://github.com/unosquare/tubular-react","homepage":"https://unosquare.github.io/tubular-react","size":12512,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/265"},"html":{"href":"https://github.com/unosquare/tubular-react/pull/265"},"issue":{"href":"https://api.github.com/repos/unosquare/tubular-react/issues/265"},"comments":{"href":"https://api.github.com/repos/unosquare/tubular-react/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unosquare/tubular-react/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/unosquare/tubular-react/statuses/93af82e0cd653911d1106c9215803072671dfbe3"}},"author_association":"NONE"}}
{"actor":{"display_login":"codacy-bot"}}