{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/243149924","pull_request_review_id":186841066,"id":243149924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE0OTkyNA==","diff_hunk":"@@ -0,0 +1,130 @@\n+###########################################################################\n+#\n+# Copyright 2018 Samsung Electronics All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing,\n+# software distributed under the License is distributed on an\n+# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,\n+# either express or implied. See the License for the specific\n+# language governing permissions and limitations under the License.\n+#\n+###########################################################################\n+############################################################################\n+# configs/stm32f407-disc1/hello/Make.defs\n+#\n+#   Copyright (C) 2011-2012 Gregory Nutt. All rights reserved.\n+#   Author: Gregory Nutt <gnutt@nuttx.org>\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions\n+# are met:\n+#\n+# 1. Redistributions of source code must retain the above copyright\n+#    notice, this list of conditions and the following disclaimer.\n+# 2. Redistributions in binary form must reproduce the above copyright\n+#    notice, this list of conditions and the following disclaimer in\n+#    the documentation and/or other materials provided with the\n+#    distribution.\n+# 3. Neither the name NuttX nor the names of its contributors may be\n+#    used to endorse or promote products derived from this software\n+#    without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+# \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS\n+# FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE\n+# COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\n+# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,\n+# BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS\n+# OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED\n+# AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN\n+# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+# POSSIBILITY OF SUCH DAMAGE.\n+#\n+############################################################################\n+\n+include ${TOPDIR}/.config\n+include ${TOPDIR}/tools/Config.mk\n+include ${TOPDIR}/arch/arm/src/armv7-m/Toolchain.defs\n+\n+LDSCRIPT = ld.script\n+\n+ifeq ($(WINTOOL),y)\n+  # Windows-native toolchains\n+  DIRLINK = $(TOPDIR)/tools/copydir.sh\n+  DIRUNLINK = $(TOPDIR)/tools/unlink.sh\n+  MKDEP = $(TOPDIR)/tools/mkwindeps.sh\n+  ARCHINCLUDES = -I. -isystem \"${shell cygpath -w $(TOPDIR)/include}\" -isystem \"${shell cygpath -w $(TOPDIR)/../framework/include}\"\n+  ARCHXXINCLUDES = -I. -isystem \"${shell cygpath -w $(TOPDIR)/include}\" -isystem \"${shell cygpath -w $(TOPDIR)/include/cxx}\"\n+  ARCHSCRIPT = -T \"${shell cygpath -w $(TOPDIR)/../build/configs/$(CONFIG_ARCH_BOARD)/scripts/$(LDSCRIPT)}\"\n+else\n+  # Linux/Cygwin-native toolchain\n+  MKDEP = $(TOPDIR)/tools/mkdeps$(HOSTEXEEXT)\n+  ARCHINCLUDES = -I. -isystem $(TOPDIR)/include -isystem $(TOPDIR)/../framework/include","path":"build/configs/stm32f407-disc1/hello/Make.defs","position":70,"original_position":70,"commit_id":"562adde77e9da181d178d56d317d78ce3d36d632","original_commit_id":"bda73d324b6ff74308410c6f0bde4d1583a3c505","user":{"login":"manoharahk","id":25977863,"node_id":"MDQ6VXNlcjI1OTc3ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/25977863?v=4","gravatar_id":"","url":"https://api.github.com/users/manoharahk","html_url":"https://github.com/manoharahk","followers_url":"https://api.github.com/users/manoharahk/followers","following_url":"https://api.github.com/users/manoharahk/following{/other_user}","gists_url":"https://api.github.com/users/manoharahk/gists{/gist_id}","starred_url":"https://api.github.com/users/manoharahk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoharahk/subscriptions","organizations_url":"https://api.github.com/users/manoharahk/orgs","repos_url":"https://api.github.com/users/manoharahk/repos","events_url":"https://api.github.com/users/manoharahk/events{/privacy}","received_events_url":"https://api.github.com/users/manoharahk/received_events","type":"User","site_admin":false},"body":"For hello application, do we really need external/include?","created_at":"2018-12-20T03:53:38Z","updated_at":"2018-12-20T03:53:38Z","html_url":"https://github.com/Samsung/TizenRT/pull/2558#discussion_r243149924","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/243149924"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2558#discussion_r243149924"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558"}},"in_reply_to_id":243135021},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558","id":239786059,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Nzg2MDU5","html_url":"https://github.com/Samsung/TizenRT/pull/2558","diff_url":"https://github.com/Samsung/TizenRT/pull/2558.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/2558.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2558","number":2558,"state":"open","locked":false,"title":"Port stm32f429i-disc and stm32f407-disc1 boards to TizenRT","user":{"login":"manoharahk","id":25977863,"node_id":"MDQ6VXNlcjI1OTc3ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/25977863?v=4","gravatar_id":"","url":"https://api.github.com/users/manoharahk","html_url":"https://github.com/manoharahk","followers_url":"https://api.github.com/users/manoharahk/followers","following_url":"https://api.github.com/users/manoharahk/following{/other_user}","gists_url":"https://api.github.com/users/manoharahk/gists{/gist_id}","starred_url":"https://api.github.com/users/manoharahk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoharahk/subscriptions","organizations_url":"https://api.github.com/users/manoharahk/orgs","repos_url":"https://api.github.com/users/manoharahk/repos","events_url":"https://api.github.com/users/manoharahk/events{/privacy}","received_events_url":"https://api.github.com/users/manoharahk/received_events","type":"User","site_admin":false},"body":"This patch set ports stm32 chip, stm32f429i-disc and stm32f407-disc1 to TizenRT\r\n\r\nNote: \r\nThis was back ported from NuttX to TizenRT long back and it was present in internal branch.\r\nThis patch set ports the same code to latest TizenRT and making it opensource.\r\n\r\n ","created_at":"2018-12-19T10:34:07Z","updated_at":"2018-12-20T03:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7f4f95f8cb733666ec3907b70f1a5bb1a48f08f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2558/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/562adde77e9da181d178d56d317d78ce3d36d632","head":{"label":"manoharahk:stm-port","ref":"stm-port","sha":"562adde77e9da181d178d56d317d78ce3d36d632","user":{"login":"manoharahk","id":25977863,"node_id":"MDQ6VXNlcjI1OTc3ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/25977863?v=4","gravatar_id":"","url":"https://api.github.com/users/manoharahk","html_url":"https://github.com/manoharahk","followers_url":"https://api.github.com/users/manoharahk/followers","following_url":"https://api.github.com/users/manoharahk/following{/other_user}","gists_url":"https://api.github.com/users/manoharahk/gists{/gist_id}","starred_url":"https://api.github.com/users/manoharahk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoharahk/subscriptions","organizations_url":"https://api.github.com/users/manoharahk/orgs","repos_url":"https://api.github.com/users/manoharahk/repos","events_url":"https://api.github.com/users/manoharahk/events{/privacy}","received_events_url":"https://api.github.com/users/manoharahk/received_events","type":"User","site_admin":false},"repo":{"id":91425005,"node_id":"MDEwOlJlcG9zaXRvcnk5MTQyNTAwNQ==","name":"TizenRT","full_name":"manoharahk/TizenRT","private":false,"owner":{"login":"manoharahk","id":25977863,"node_id":"MDQ6VXNlcjI1OTc3ODYz","avatar_url":"https://avatars1.githubusercontent.com/u/25977863?v=4","gravatar_id":"","url":"https://api.github.com/users/manoharahk","html_url":"https://github.com/manoharahk","followers_url":"https://api.github.com/users/manoharahk/followers","following_url":"https://api.github.com/users/manoharahk/following{/other_user}","gists_url":"https://api.github.com/users/manoharahk/gists{/gist_id}","starred_url":"https://api.github.com/users/manoharahk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoharahk/subscriptions","organizations_url":"https://api.github.com/users/manoharahk/orgs","repos_url":"https://api.github.com/users/manoharahk/repos","events_url":"https://api.github.com/users/manoharahk/events{/privacy}","received_events_url":"https://api.github.com/users/manoharahk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manoharahk/TizenRT","description":"Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/manoharahk/TizenRT","forks_url":"https://api.github.com/repos/manoharahk/TizenRT/forks","keys_url":"https://api.github.com/repos/manoharahk/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manoharahk/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manoharahk/TizenRT/teams","hooks_url":"https://api.github.com/repos/manoharahk/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/manoharahk/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/manoharahk/TizenRT/events","assignees_url":"https://api.github.com/repos/manoharahk/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/manoharahk/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/manoharahk/TizenRT/tags","blobs_url":"https://api.github.com/repos/manoharahk/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manoharahk/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manoharahk/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/manoharahk/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manoharahk/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/manoharahk/TizenRT/languages","stargazers_url":"https://api.github.com/repos/manoharahk/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/manoharahk/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/manoharahk/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/manoharahk/TizenRT/subscription","commits_url":"https://api.github.com/repos/manoharahk/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/manoharahk/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/manoharahk/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/manoharahk/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/manoharahk/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/manoharahk/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manoharahk/TizenRT/merges","archive_url":"https://api.github.com/repos/manoharahk/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manoharahk/TizenRT/downloads","issues_url":"https://api.github.com/repos/manoharahk/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/manoharahk/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/manoharahk/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/manoharahk/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manoharahk/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/manoharahk/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/manoharahk/TizenRT/deployments","created_at":"2017-05-16T06:47:01Z","updated_at":"2017-05-16T06:47:17Z","pushed_at":"2018-12-20T02:45:17Z","git_url":"git://github.com/manoharahk/TizenRT.git","ssh_url":"git@github.com:manoharahk/TizenRT.git","clone_url":"https://github.com/manoharahk/TizenRT.git","svn_url":"https://github.com/manoharahk/TizenRT","homepage":"","size":110221,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"fa233dcdf55905d1a95affc35664caaa6aefb691","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"node_id":"MDEwOlJlcG9zaXRvcnk4MjUxNzI1Mg==","name":"TizenRT","full_name":"Samsung/TizenRT","private":false,"owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-12-18T08:58:22Z","pushed_at":"2018-12-20T03:17:16Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":107501,"stargazers_count":216,"watchers_count":216,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":375,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":375,"open_issues":68,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2558"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2558"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2558/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2558/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/562adde77e9da181d178d56d317d78ce3d36d632"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"manoharahk"}}