{"action":"closed","number":30316,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316","id":228772192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzcyMTky","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30316","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30316.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30316.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30316","number":30316,"state":"closed","locked":false,"title":"Add 'error' event to minio-js types' BucketStream","user":{"login":"OutdatedVersion","id":11138610,"node_id":"MDQ6VXNlcjExMTM4NjEw","avatar_url":"https://avatars2.githubusercontent.com/u/11138610?v=4","gravatar_id":"","url":"https://api.github.com/users/OutdatedVersion","html_url":"https://github.com/OutdatedVersion","followers_url":"https://api.github.com/users/OutdatedVersion/followers","following_url":"https://api.github.com/users/OutdatedVersion/following{/other_user}","gists_url":"https://api.github.com/users/OutdatedVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/OutdatedVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutdatedVersion/subscriptions","organizations_url":"https://api.github.com/users/OutdatedVersion/orgs","repos_url":"https://api.github.com/users/OutdatedVersion/repos","events_url":"https://api.github.com/users/OutdatedVersion/events{/privacy}","received_events_url":"https://api.github.com/users/OutdatedVersion/received_events","type":"User","site_admin":false},"body":"The current definition does not take into account that the returned `Stream` may emit events under the name `error`.\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/minio/minio-js/blob/d18a76ac44c65ed06ca606c91745fa81e20ac3f7/src/main/minio.js#L1342\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-11-06T17:22:58Z","updated_at":"2018-11-06T20:54:34Z","closed_at":"2018-11-06T20:54:34Z","merged_at":"2018-11-06T20:54:34Z","merge_commit_sha":"1d83e020481991fcd6115a531c211074064cdd92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":798737478,"node_id":"MDU6TGFiZWw3OTg3Mzc0Nzg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Author%20is%20Owner","name":"Author is Owner","color":"6fede0","default":false},{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095236,"node_id":"MDU6TGFiZWw2NDQwOTUyMzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:Express","name":"Merge:Express","color":"00AA00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30316/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/0030aa60a98442f10306a34da9057acb61fb3ef9","head":{"label":"OutdatedVersion:master","ref":"master","sha":"0030aa60a98442f10306a34da9057acb61fb3ef9","user":{"login":"OutdatedVersion","id":11138610,"node_id":"MDQ6VXNlcjExMTM4NjEw","avatar_url":"https://avatars2.githubusercontent.com/u/11138610?v=4","gravatar_id":"","url":"https://api.github.com/users/OutdatedVersion","html_url":"https://github.com/OutdatedVersion","followers_url":"https://api.github.com/users/OutdatedVersion/followers","following_url":"https://api.github.com/users/OutdatedVersion/following{/other_user}","gists_url":"https://api.github.com/users/OutdatedVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/OutdatedVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutdatedVersion/subscriptions","organizations_url":"https://api.github.com/users/OutdatedVersion/orgs","repos_url":"https://api.github.com/users/OutdatedVersion/repos","events_url":"https://api.github.com/users/OutdatedVersion/events{/privacy}","received_events_url":"https://api.github.com/users/OutdatedVersion/received_events","type":"User","site_admin":false},"repo":{"id":156418352,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY0MTgzNTI=","name":"DefinitelyTyped","full_name":"OutdatedVersion/DefinitelyTyped","private":false,"owner":{"login":"OutdatedVersion","id":11138610,"node_id":"MDQ6VXNlcjExMTM4NjEw","avatar_url":"https://avatars2.githubusercontent.com/u/11138610?v=4","gravatar_id":"","url":"https://api.github.com/users/OutdatedVersion","html_url":"https://github.com/OutdatedVersion","followers_url":"https://api.github.com/users/OutdatedVersion/followers","following_url":"https://api.github.com/users/OutdatedVersion/following{/other_user}","gists_url":"https://api.github.com/users/OutdatedVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/OutdatedVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutdatedVersion/subscriptions","organizations_url":"https://api.github.com/users/OutdatedVersion/orgs","repos_url":"https://api.github.com/users/OutdatedVersion/repos","events_url":"https://api.github.com/users/OutdatedVersion/events{/privacy}","received_events_url":"https://api.github.com/users/OutdatedVersion/received_events","type":"User","site_admin":false},"html_url":"https://github.com/OutdatedVersion/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped","forks_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/OutdatedVersion/DefinitelyTyped/deployments","created_at":"2018-11-06T17:04:39Z","updated_at":"2018-11-06T17:18:45Z","pushed_at":"2018-11-06T17:18:38Z","git_url":"git://github.com/OutdatedVersion/DefinitelyTyped.git","ssh_url":"git@github.com:OutdatedVersion/DefinitelyTyped.git","clone_url":"https://github.com/OutdatedVersion/DefinitelyTyped.git","svn_url":"https://github.com/OutdatedVersion/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":376005,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"7500ae46094b60251362bc33c1c9658698e68d9c","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-11-06T20:36:22Z","pushed_at":"2018-11-06T20:54:34Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":376144,"stargazers_count":18375,"watchers_count":18375,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15257,"mirror_url":null,"archived":false,"open_issues_count":2481,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15257,"open_issues":2481,"watchers":18375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30316"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30316"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30316/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30316/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/0030aa60a98442f10306a34da9057acb61fb3ef9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"armanio123","id":13305542,"node_id":"MDQ6VXNlcjEzMzA1NTQy","avatar_url":"https://avatars0.githubusercontent.com/u/13305542?v=4","gravatar_id":"","url":"https://api.github.com/users/armanio123","html_url":"https://github.com/armanio123","followers_url":"https://api.github.com/users/armanio123/followers","following_url":"https://api.github.com/users/armanio123/following{/other_user}","gists_url":"https://api.github.com/users/armanio123/gists{/gist_id}","starred_url":"https://api.github.com/users/armanio123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armanio123/subscriptions","organizations_url":"https://api.github.com/users/armanio123/orgs","repos_url":"https://api.github.com/users/armanio123/repos","events_url":"https://api.github.com/users/armanio123/events{/privacy}","received_events_url":"https://api.github.com/users/armanio123/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"armanio123"}}