{"action":"closed","number":62,"pull_request":{"url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62","id":189032737,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MDMyNzM3","html_url":"https://github.com/arthurbergmz/webpack-pwa-manifest/pull/62","diff_url":"https://github.com/arthurbergmz/webpack-pwa-manifest/pull/62.diff","patch_url":"https://github.com/arthurbergmz/webpack-pwa-manifest/pull/62.patch","issue_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/62","number":62,"state":"closed","locked":false,"title":"Add crossorigin option","user":{"login":"Remcoman","id":564275,"node_id":"MDQ6VXNlcjU2NDI3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/564275?v=4","gravatar_id":"","url":"https://api.github.com/users/Remcoman","html_url":"https://github.com/Remcoman","followers_url":"https://api.github.com/users/Remcoman/followers","following_url":"https://api.github.com/users/Remcoman/following{/other_user}","gists_url":"https://api.github.com/users/Remcoman/gists{/gist_id}","starred_url":"https://api.github.com/users/Remcoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remcoman/subscriptions","organizations_url":"https://api.github.com/users/Remcoman/orgs","repos_url":"https://api.github.com/users/Remcoman/repos","events_url":"https://api.github.com/users/Remcoman/events{/privacy}","received_events_url":"https://api.github.com/users/Remcoman/received_events","type":"User","site_admin":false},"body":"This change adds the crossorigin option which can be undefined, use-credentials or anonymous. \r\n\r\nThis fixes the issue were Chrome will not send cookies with the request for the manifest if a crossorigin value of 'use-credentials' is not present.\r\n\r\nps I also changed the tests but i seem to have some problems running them: \r\n\r\n- The package.json requires webpack 4 but the webpack configs are not updated for webpack 4\r\n- The path to ../app.js seems to be wrong\r\n- The output folder is not cleaned before running the tests","created_at":"2018-05-18T13:51:05Z","updated_at":"2018-08-03T16:39:51Z","closed_at":"2018-08-03T16:39:50Z","merged_at":"2018-08-03T16:39:50Z","merge_commit_sha":"ee8ddfe414995d9de85c5516796eb7b7c038e38b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62/commits","review_comments_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62/comments","review_comment_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/62/comments","statuses_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/statuses/f3ef1c528a87b7d941e34d2cf4161b761d1a9cef","head":{"label":"Remcoman:master","ref":"master","sha":"f3ef1c528a87b7d941e34d2cf4161b761d1a9cef","user":{"login":"Remcoman","id":564275,"node_id":"MDQ6VXNlcjU2NDI3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/564275?v=4","gravatar_id":"","url":"https://api.github.com/users/Remcoman","html_url":"https://github.com/Remcoman","followers_url":"https://api.github.com/users/Remcoman/followers","following_url":"https://api.github.com/users/Remcoman/following{/other_user}","gists_url":"https://api.github.com/users/Remcoman/gists{/gist_id}","starred_url":"https://api.github.com/users/Remcoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remcoman/subscriptions","organizations_url":"https://api.github.com/users/Remcoman/orgs","repos_url":"https://api.github.com/users/Remcoman/repos","events_url":"https://api.github.com/users/Remcoman/events{/privacy}","received_events_url":"https://api.github.com/users/Remcoman/received_events","type":"User","site_admin":false},"repo":{"id":133951381,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NTEzODE=","name":"webpack-pwa-manifest","full_name":"Remcoman/webpack-pwa-manifest","owner":{"login":"Remcoman","id":564275,"node_id":"MDQ6VXNlcjU2NDI3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/564275?v=4","gravatar_id":"","url":"https://api.github.com/users/Remcoman","html_url":"https://github.com/Remcoman","followers_url":"https://api.github.com/users/Remcoman/followers","following_url":"https://api.github.com/users/Remcoman/following{/other_user}","gists_url":"https://api.github.com/users/Remcoman/gists{/gist_id}","starred_url":"https://api.github.com/users/Remcoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remcoman/subscriptions","organizations_url":"https://api.github.com/users/Remcoman/orgs","repos_url":"https://api.github.com/users/Remcoman/repos","events_url":"https://api.github.com/users/Remcoman/events{/privacy}","received_events_url":"https://api.github.com/users/Remcoman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Remcoman/webpack-pwa-manifest","description":"Progressive Web App Manifest Generator for Webpack, with auto icon resizing and fingerprinting support.","fork":true,"url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest","forks_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/forks","keys_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/teams","hooks_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/hooks","issue_events_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/events","assignees_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/tags","blobs_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/languages","stargazers_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/stargazers","contributors_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/contributors","subscribers_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/subscribers","subscription_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/subscription","commits_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/merges","archive_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/downloads","issues_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/labels{/name}","releases_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/Remcoman/webpack-pwa-manifest/deployments","created_at":"2018-05-18T12:28:25Z","updated_at":"2018-08-01T20:34:36Z","pushed_at":"2018-08-01T20:34:34Z","git_url":"git://github.com/Remcoman/webpack-pwa-manifest.git","ssh_url":"git@github.com:Remcoman/webpack-pwa-manifest.git","clone_url":"https://github.com/Remcoman/webpack-pwa-manifest.git","svn_url":"https://github.com/Remcoman/webpack-pwa-manifest","homepage":"","size":442,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arthurbergmz:master","ref":"master","sha":"2c3431c5f820443c2d8d4b733735bd35c71bb148","user":{"login":"arthurbergmz","id":13095084,"node_id":"MDQ6VXNlcjEzMDk1MDg0","avatar_url":"https://avatars0.githubusercontent.com/u/13095084?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurbergmz","html_url":"https://github.com/arthurbergmz","followers_url":"https://api.github.com/users/arthurbergmz/followers","following_url":"https://api.github.com/users/arthurbergmz/following{/other_user}","gists_url":"https://api.github.com/users/arthurbergmz/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurbergmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurbergmz/subscriptions","organizations_url":"https://api.github.com/users/arthurbergmz/orgs","repos_url":"https://api.github.com/users/arthurbergmz/repos","events_url":"https://api.github.com/users/arthurbergmz/events{/privacy}","received_events_url":"https://api.github.com/users/arthurbergmz/received_events","type":"User","site_admin":false},"repo":{"id":90435473,"node_id":"MDEwOlJlcG9zaXRvcnk5MDQzNTQ3Mw==","name":"webpack-pwa-manifest","full_name":"arthurbergmz/webpack-pwa-manifest","owner":{"login":"arthurbergmz","id":13095084,"node_id":"MDQ6VXNlcjEzMDk1MDg0","avatar_url":"https://avatars0.githubusercontent.com/u/13095084?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurbergmz","html_url":"https://github.com/arthurbergmz","followers_url":"https://api.github.com/users/arthurbergmz/followers","following_url":"https://api.github.com/users/arthurbergmz/following{/other_user}","gists_url":"https://api.github.com/users/arthurbergmz/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurbergmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurbergmz/subscriptions","organizations_url":"https://api.github.com/users/arthurbergmz/orgs","repos_url":"https://api.github.com/users/arthurbergmz/repos","events_url":"https://api.github.com/users/arthurbergmz/events{/privacy}","received_events_url":"https://api.github.com/users/arthurbergmz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arthurbergmz/webpack-pwa-manifest","description":"Progressive Web App Manifest Generator for Webpack, with auto icon resizing and fingerprinting support.","fork":false,"url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest","forks_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/forks","keys_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/teams","hooks_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/hooks","issue_events_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/events","assignees_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/tags","blobs_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/languages","stargazers_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/stargazers","contributors_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/contributors","subscribers_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/subscribers","subscription_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/subscription","commits_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/merges","archive_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/downloads","issues_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/labels{/name}","releases_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/deployments","created_at":"2017-05-06T03:47:16Z","updated_at":"2018-08-03T03:19:16Z","pushed_at":"2018-08-03T16:39:50Z","git_url":"git://github.com/arthurbergmz/webpack-pwa-manifest.git","ssh_url":"git@github.com:arthurbergmz/webpack-pwa-manifest.git","clone_url":"https://github.com/arthurbergmz/webpack-pwa-manifest.git","svn_url":"https://github.com/arthurbergmz/webpack-pwa-manifest","homepage":"","size":449,"stargazers_count":192,"watchers_count":192,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":16,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62"},"html":{"href":"https://github.com/arthurbergmz/webpack-pwa-manifest/pull/62"},"issue":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/62"},"comments":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/arthurbergmz/webpack-pwa-manifest/statuses/f3ef1c528a87b7d941e34d2cf4161b761d1a9cef"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"doug-wade","id":3477707,"node_id":"MDQ6VXNlcjM0Nzc3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/3477707?v=4","gravatar_id":"","url":"https://api.github.com/users/doug-wade","html_url":"https://github.com/doug-wade","followers_url":"https://api.github.com/users/doug-wade/followers","following_url":"https://api.github.com/users/doug-wade/following{/other_user}","gists_url":"https://api.github.com/users/doug-wade/gists{/gist_id}","starred_url":"https://api.github.com/users/doug-wade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doug-wade/subscriptions","organizations_url":"https://api.github.com/users/doug-wade/orgs","repos_url":"https://api.github.com/users/doug-wade/repos","events_url":"https://api.github.com/users/doug-wade/events{/privacy}","received_events_url":"https://api.github.com/users/doug-wade/received_events","type":"User","site_admin":false},"comments":5,"review_comments":13,"maintainer_can_modify":false,"commits":6,"additions":19,"deletions":7,"changed_files":8}}
{"actor":{"display_login":"doug-wade"}}