{"action":"closed","issue":{"url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles/issues/58","repository_url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles","labels_url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles/issues/58/comments","events_url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles/issues/58/events","html_url":"https://github.com/micronaut-projects/micronaut-profiles/issues/58","id":348481143,"node_id":"MDU6SXNzdWUzNDg0ODExNDM=","number":58,"title":"Add Hamcrest when including Junit ","user":{"login":"sdelamo","id":864788,"node_id":"MDQ6VXNlcjg2NDc4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/864788?v=4","gravatar_id":"","url":"https://api.github.com/users/sdelamo","html_url":"https://github.com/sdelamo","followers_url":"https://api.github.com/users/sdelamo/followers","following_url":"https://api.github.com/users/sdelamo/following{/other_user}","gists_url":"https://api.github.com/users/sdelamo/gists{/gist_id}","starred_url":"https://api.github.com/users/sdelamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdelamo/subscriptions","organizations_url":"https://api.github.com/users/sdelamo/orgs","repos_url":"https://api.github.com/users/sdelamo/repos","events_url":"https://api.github.com/users/sdelamo/events{/privacy}","received_events_url":"https://api.github.com/users/sdelamo/received_events","type":"User","site_admin":false},"labels":[{"id":899691176,"node_id":"MDU6TGFiZWw4OTk2OTExNzY=","url":"https://api.github.com/repos/micronaut-projects/micronaut-profiles/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"closed","locked":false,"assignee":{"login":"ZacharyKlein","id":114379,"node_id":"MDQ6VXNlcjExNDM3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/114379?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacharyKlein","html_url":"https://github.com/ZacharyKlein","followers_url":"https://api.github.com/users/ZacharyKlein/followers","following_url":"https://api.github.com/users/ZacharyKlein/following{/other_user}","gists_url":"https://api.github.com/users/ZacharyKlein/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacharyKlein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacharyKlein/subscriptions","organizations_url":"https://api.github.com/users/ZacharyKlein/orgs","repos_url":"https://api.github.com/users/ZacharyKlein/repos","events_url":"https://api.github.com/users/ZacharyKlein/events{/privacy}","received_events_url":"https://api.github.com/users/ZacharyKlein/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZacharyKlein","id":114379,"node_id":"MDQ6VXNlcjExNDM3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/114379?v=4","gravatar_id":"","url":"https://api.github.com/users/ZacharyKlein","html_url":"https://github.com/ZacharyKlein","followers_url":"https://api.github.com/users/ZacharyKlein/followers","following_url":"https://api.github.com/users/ZacharyKlein/following{/other_user}","gists_url":"https://api.github.com/users/ZacharyKlein/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacharyKlein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacharyKlein/subscriptions","organizations_url":"https://api.github.com/users/ZacharyKlein/orgs","repos_url":"https://api.github.com/users/ZacharyKlein/repos","events_url":"https://api.github.com/users/ZacharyKlein/events{/privacy}","received_events_url":"https://api.github.com/users/ZacharyKlein/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-07T20:47:02Z","updated_at":"2018-08-18T06:46:52Z","closed_at":"2018-08-18T06:46:52Z","author_association":"CONTRIBUTOR","body":"Since Micronaut HTTP Client throws exceptions often. E.g. when a resource is not found . I think such a test will be pretty common when using JUnit: \r\n\r\n```\r\nimport org.junit.rules.ExpectedException;\r\n\r\nimport static org.hamcrest.Matchers.hasProperty;\r\nimport static org.hamcrest.Matchers.is;\r\n...\r\n..\r\n.\r\n    @Rule\r\n    public ExpectedException thrown = ExpectedException.none();\r\n\r\n    @Test\r\n    public void testBooksControllerWithNonExistingIsbn() {\r\n        thrown.expect(HttpClientResponseException.class);\r\n        thrown.expect(hasProperty(\"response\", hasProperty(\"status\", is(HttpStatus.NOT_FOUND))));\r\n        rxHttpClient.toBlocking().exchange(HttpRequest.GET(\"/books/stock/XXXXX\"), Boolean.class);\r\n    }\r\n```\r\n\r\nI believe we should include harmcrest dependency when Junit is present.\r\n\r\n` testCompile \"org.hamcrest:hamcrest-all:1.3\"`"}}
{"actor":{"display_login":"ZacharyKlein"}}