{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/20986","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/20986/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/20986/comments","events_url":"https://api.github.com/repos/apache/spark/issues/20986/events","html_url":"https://github.com/apache/spark/pull/20986","id":311670600,"number":20986,"title":"[SPARK-23864][SQL] Add unsafe object writing to UnsafeWriter","user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars2.githubusercontent.com/u/9616802?v=4","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-05T15:58:04Z","updated_at":"2018-04-06T11:32:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20986","html_url":"https://github.com/apache/spark/pull/20986","diff_url":"https://github.com/apache/spark/pull/20986.diff","patch_url":"https://github.com/apache/spark/pull/20986.patch"},"body":"## What changes were proposed in this pull request?\r\nThis PR moves writing of `UnsafeRow`, `UnsafeArrayData` & `UnsafeMapData` out of the `GenerateUnsafeProjection`/`InterpretedUnsafeProjection` classes into the `UnsafeWriter` interface. This cleans up the code a little bit, and it should also result in less byte code for the code generated path.\r\n\r\n## How was this patch tested?\r\nExisting tests"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/379226856","html_url":"https://github.com/apache/spark/pull/20986#issuecomment-379226856","issue_url":"https://api.github.com/repos/apache/spark/issues/20986","id":379226856,"user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars2.githubusercontent.com/u/9616802?v=4","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T11:32:59Z","updated_at":"2018-04-06T11:32:59Z","author_association":"CONTRIBUTOR","body":"@kiszk @cloud-fan I made all code generation in `GenerateUnsafeProjection` follow the code template standard of using pipes as a margin and `stripmargin` at the end. The only downside is that this makes the diff a bit larger and git blame does not work as well."}}
{"actor":{"display_login":"hvanhovell"}}