{"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265","id":173820414,"html_url":"https://github.com/synapsestudios/oidc-platform/pull/265","diff_url":"https://github.com/synapsestudios/oidc-platform/pull/265.diff","patch_url":"https://github.com/synapsestudios/oidc-platform/pull/265.patch","issue_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/265","number":265,"state":"closed","locked":false,"title":"228 | Add check if pending_email_lower exists, return 403 if falsy","user":{"login":"DemarcatedTitle","id":13124650,"avatar_url":"https://avatars1.githubusercontent.com/u/13124650?v=4","gravatar_id":"","url":"https://api.github.com/users/DemarcatedTitle","html_url":"https://github.com/DemarcatedTitle","followers_url":"https://api.github.com/users/DemarcatedTitle/followers","following_url":"https://api.github.com/users/DemarcatedTitle/following{/other_user}","gists_url":"https://api.github.com/users/DemarcatedTitle/gists{/gist_id}","starred_url":"https://api.github.com/users/DemarcatedTitle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DemarcatedTitle/subscriptions","organizations_url":"https://api.github.com/users/DemarcatedTitle/orgs","repos_url":"https://api.github.com/users/DemarcatedTitle/repos","events_url":"https://api.github.com/users/DemarcatedTitle/events{/privacy}","received_events_url":"https://api.github.com/users/DemarcatedTitle/received_events","type":"User","site_admin":false},"body":"Adds a try/catch in server.js findToken function.\r\nThen, uses the error caught from that in email-token-scheme in order to throw a 403 instead of a 500 in the case that a good token isn't found. \r\n\r\nAlso adds a tokenValidator to check if the token has been canceled, which sets the pending_email and pending_email_lower to null. \r\n\r\nRelated to: \r\nUsing cancelled email verification link returns a 500 error #228","created_at":"2018-03-08T18:58:02Z","updated_at":"2018-03-12T15:59:15Z","closed_at":"2018-03-12T15:59:15Z","merged_at":"2018-03-12T15:59:15Z","merge_commit_sha":"56159a6c43040ba6de0a07062e31208f332f74b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265/commits","review_comments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265/comments","review_comment_url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/265/comments","statuses_url":"https://api.github.com/repos/synapsestudios/oidc-platform/statuses/34672cda16f926e25c8e2c70324cb5b81fd12bd6","head":{"label":"synapsestudios:228-canceled-email-verification-returns-500","ref":"228-canceled-email-verification-returns-500","sha":"34672cda16f926e25c8e2c70324cb5b81fd12bd6","user":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars0.githubusercontent.com/u/197868?v=4","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"repo":{"id":80448014,"name":"oidc-platform","full_name":"synapsestudios/oidc-platform","owner":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars0.githubusercontent.com/u/197868?v=4","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapsestudios/oidc-platform","description":"OpenID Connect Identity Platform","fork":false,"url":"https://api.github.com/repos/synapsestudios/oidc-platform","forks_url":"https://api.github.com/repos/synapsestudios/oidc-platform/forks","keys_url":"https://api.github.com/repos/synapsestudios/oidc-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapsestudios/oidc-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapsestudios/oidc-platform/teams","hooks_url":"https://api.github.com/repos/synapsestudios/oidc-platform/hooks","issue_events_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/events{/number}","events_url":"https://api.github.com/repos/synapsestudios/oidc-platform/events","assignees_url":"https://api.github.com/repos/synapsestudios/oidc-platform/assignees{/user}","branches_url":"https://api.github.com/repos/synapsestudios/oidc-platform/branches{/branch}","tags_url":"https://api.github.com/repos/synapsestudios/oidc-platform/tags","blobs_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapsestudios/oidc-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/synapsestudios/oidc-platform/languages","stargazers_url":"https://api.github.com/repos/synapsestudios/oidc-platform/stargazers","contributors_url":"https://api.github.com/repos/synapsestudios/oidc-platform/contributors","subscribers_url":"https://api.github.com/repos/synapsestudios/oidc-platform/subscribers","subscription_url":"https://api.github.com/repos/synapsestudios/oidc-platform/subscription","commits_url":"https://api.github.com/repos/synapsestudios/oidc-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/synapsestudios/oidc-platform/contents/{+path}","compare_url":"https://api.github.com/repos/synapsestudios/oidc-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapsestudios/oidc-platform/merges","archive_url":"https://api.github.com/repos/synapsestudios/oidc-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapsestudios/oidc-platform/downloads","issues_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues{/number}","pulls_url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/synapsestudios/oidc-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/synapsestudios/oidc-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapsestudios/oidc-platform/labels{/name}","releases_url":"https://api.github.com/repos/synapsestudios/oidc-platform/releases{/id}","deployments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/deployments","created_at":"2017-01-30T18:03:35Z","updated_at":"2018-02-19T20:35:01Z","pushed_at":"2018-03-12T15:59:15Z","git_url":"git://github.com/synapsestudios/oidc-platform.git","ssh_url":"git@github.com:synapsestudios/oidc-platform.git","clone_url":"https://github.com/synapsestudios/oidc-platform.git","svn_url":"https://github.com/synapsestudios/oidc-platform","homepage":null,"size":887,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":23,"watchers":5,"default_branch":"master"}},"base":{"label":"synapsestudios:release/v2.2.1","ref":"release/v2.2.1","sha":"7af70dd45234d6b16b0b391606d6fc95d3264d2b","user":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars0.githubusercontent.com/u/197868?v=4","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"repo":{"id":80448014,"name":"oidc-platform","full_name":"synapsestudios/oidc-platform","owner":{"login":"synapsestudios","id":197868,"avatar_url":"https://avatars0.githubusercontent.com/u/197868?v=4","gravatar_id":"","url":"https://api.github.com/users/synapsestudios","html_url":"https://github.com/synapsestudios","followers_url":"https://api.github.com/users/synapsestudios/followers","following_url":"https://api.github.com/users/synapsestudios/following{/other_user}","gists_url":"https://api.github.com/users/synapsestudios/gists{/gist_id}","starred_url":"https://api.github.com/users/synapsestudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synapsestudios/subscriptions","organizations_url":"https://api.github.com/users/synapsestudios/orgs","repos_url":"https://api.github.com/users/synapsestudios/repos","events_url":"https://api.github.com/users/synapsestudios/events{/privacy}","received_events_url":"https://api.github.com/users/synapsestudios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/synapsestudios/oidc-platform","description":"OpenID Connect Identity Platform","fork":false,"url":"https://api.github.com/repos/synapsestudios/oidc-platform","forks_url":"https://api.github.com/repos/synapsestudios/oidc-platform/forks","keys_url":"https://api.github.com/repos/synapsestudios/oidc-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/synapsestudios/oidc-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/synapsestudios/oidc-platform/teams","hooks_url":"https://api.github.com/repos/synapsestudios/oidc-platform/hooks","issue_events_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/events{/number}","events_url":"https://api.github.com/repos/synapsestudios/oidc-platform/events","assignees_url":"https://api.github.com/repos/synapsestudios/oidc-platform/assignees{/user}","branches_url":"https://api.github.com/repos/synapsestudios/oidc-platform/branches{/branch}","tags_url":"https://api.github.com/repos/synapsestudios/oidc-platform/tags","blobs_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/synapsestudios/oidc-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/synapsestudios/oidc-platform/languages","stargazers_url":"https://api.github.com/repos/synapsestudios/oidc-platform/stargazers","contributors_url":"https://api.github.com/repos/synapsestudios/oidc-platform/contributors","subscribers_url":"https://api.github.com/repos/synapsestudios/oidc-platform/subscribers","subscription_url":"https://api.github.com/repos/synapsestudios/oidc-platform/subscription","commits_url":"https://api.github.com/repos/synapsestudios/oidc-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/synapsestudios/oidc-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/synapsestudios/oidc-platform/contents/{+path}","compare_url":"https://api.github.com/repos/synapsestudios/oidc-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/synapsestudios/oidc-platform/merges","archive_url":"https://api.github.com/repos/synapsestudios/oidc-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/synapsestudios/oidc-platform/downloads","issues_url":"https://api.github.com/repos/synapsestudios/oidc-platform/issues{/number}","pulls_url":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/synapsestudios/oidc-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/synapsestudios/oidc-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/synapsestudios/oidc-platform/labels{/name}","releases_url":"https://api.github.com/repos/synapsestudios/oidc-platform/releases{/id}","deployments_url":"https://api.github.com/repos/synapsestudios/oidc-platform/deployments","created_at":"2017-01-30T18:03:35Z","updated_at":"2018-02-19T20:35:01Z","pushed_at":"2018-03-12T15:59:15Z","git_url":"git://github.com/synapsestudios/oidc-platform.git","ssh_url":"git@github.com:synapsestudios/oidc-platform.git","clone_url":"https://github.com/synapsestudios/oidc-platform.git","svn_url":"https://github.com/synapsestudios/oidc-platform","homepage":null,"size":887,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":23,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265"},"html":{"href":"https://github.com/synapsestudios/oidc-platform/pull/265"},"issue":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/265"},"comments":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/synapsestudios/oidc-platform/statuses/34672cda16f926e25c8e2c70324cb5b81fd12bd6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"spruce-bruce","id":59978,"avatar_url":"https://avatars0.githubusercontent.com/u/59978?v=4","gravatar_id":"","url":"https://api.github.com/users/spruce-bruce","html_url":"https://github.com/spruce-bruce","followers_url":"https://api.github.com/users/spruce-bruce/followers","following_url":"https://api.github.com/users/spruce-bruce/following{/other_user}","gists_url":"https://api.github.com/users/spruce-bruce/gists{/gist_id}","starred_url":"https://api.github.com/users/spruce-bruce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spruce-bruce/subscriptions","organizations_url":"https://api.github.com/users/spruce-bruce/orgs","repos_url":"https://api.github.com/users/spruce-bruce/repos","events_url":"https://api.github.com/users/spruce-bruce/events{/privacy}","received_events_url":"https://api.github.com/users/spruce-bruce/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"maintainer_can_modify":false,"commits":20,"additions":27,"deletions":13,"changed_files":6}}
{"actor":{"display_login":"spruce-bruce"}}