{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/clarity/pulls/comments/230464116","pull_request_review_id":171215643,"id":230464116,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQ2NDExNg==","diff_hunk":"@@ -7,16 +7,15 @@\n import { Injectable, OnDestroy } from '@angular/core';\n import { NgControl } from '@angular/forms';\n import { Observable, Subject, Subscription } from 'rxjs';\n-import { filter } from 'rxjs/operators';\n \n import { NgControlService } from '../providers/ng-control.service';\n \n @Injectable()\n export class IfErrorService implements OnDestroy {\n   // Implement our own status changes observable, since Angular controls don't\n   // fire on events like blur, and we want to return the control instead of a string","path":"src/clr-angular/forms/common/if-error/if-error.service.ts","position":null,"original_position":11,"commit_id":"e371bb11acc70aef844dc0bc791c969075db27c9","original_commit_id":"185b6d7dc7020a13beca5e3565ecf1990926a85c","user":{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-11-02T18:16:12Z","updated_at":"2018-11-02T18:16:13Z","html_url":"https://github.com/vmware/clarity/pull/2735#discussion_r230464116","pull_request_url":"https://api.github.com/repos/vmware/clarity/pulls/2735","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments/230464116"},"html":{"href":"https://github.com/vmware/clarity/pull/2735#discussion_r230464116"},"pull_request":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2735"}},"in_reply_to_id":230426066},"pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/2735","id":223090529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDkwNTI5","html_url":"https://github.com/vmware/clarity/pull/2735","diff_url":"https://github.com/vmware/clarity/pull/2735.diff","patch_url":"https://github.com/vmware/clarity/pull/2735.patch","issue_url":"https://api.github.com/repos/vmware/clarity/issues/2735","number":2735,"state":"open","locked":false,"title":"[NG] support reset and forced validation","user":{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false},"body":"The forms now handle form resets (which will clear validation errors) by calling `reset()` on a form group or control.\r\n\r\nThe new API for forcing validation is to get ahold of a `ClrForm` instance and call `markAsDirty()` which will mark every control as dirty in the form. I chose this naming to be very explicit about what happens (instead of saying 'validate' which is a side effect).\r\n\r\nThis also introduces some internal refactorings for the controls to remove the duplicate logic from individual controls and put it into the WrappedFormControl. Most of the changes are from carrying this change through all the controls. It also refactors the private ifErrorService to return a boolean instead of the control itself so that logic is contained in one place.\r\n\r\ncloses #2678 ","created_at":"2018-10-16T01:42:52Z","updated_at":"2018-11-02T18:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12278641808ec26e6a4f28ad4ec25010d27d2116","assignee":{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false},"assignees":[{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":473349721,"node_id":"MDU6TGFiZWw0NzMzNDk3MjE=","url":"https://api.github.com/repos/vmware/clarity/labels/Dev","name":"Dev","color":"bfdadc","default":false},{"id":452262118,"node_id":"MDU6TGFiZWw0NTIyNjIxMTg=","url":"https://api.github.com/repos/vmware/clarity/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/vmware/clarity/milestones/57","html_url":"https://github.com/vmware/clarity/milestone/57","labels_url":"https://api.github.com/repos/vmware/clarity/milestones/57/labels","id":2802750,"node_id":"MDk6TWlsZXN0b25lMjgwMjc1MA==","number":57,"title":"1.0","description":"","creator":{"login":"mathisscott","id":2728359,"node_id":"MDQ6VXNlcjI3MjgzNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2728359?v=4","gravatar_id":"","url":"https://api.github.com/users/mathisscott","html_url":"https://github.com/mathisscott","followers_url":"https://api.github.com/users/mathisscott/followers","following_url":"https://api.github.com/users/mathisscott/following{/other_user}","gists_url":"https://api.github.com/users/mathisscott/gists{/gist_id}","starred_url":"https://api.github.com/users/mathisscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathisscott/subscriptions","organizations_url":"https://api.github.com/users/mathisscott/orgs","repos_url":"https://api.github.com/users/mathisscott/repos","events_url":"https://api.github.com/users/mathisscott/events{/privacy}","received_events_url":"https://api.github.com/users/mathisscott/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":21,"state":"open","created_at":"2017-09-29T12:48:07Z","updated_at":"2018-11-02T17:26:00Z","due_on":"2018-11-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vmware/clarity/pulls/2735/commits","review_comments_url":"https://api.github.com/repos/vmware/clarity/pulls/2735/comments","review_comment_url":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/2735/comments","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/e371bb11acc70aef844dc0bc791c969075db27c9","head":{"label":"gnomeontherun:forms/reset","ref":"forms/reset","sha":"e371bb11acc70aef844dc0bc791c969075db27c9","user":{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false},"repo":{"id":74230390,"node_id":"MDEwOlJlcG9zaXRvcnk3NDIzMDM5MA==","name":"clarity","full_name":"gnomeontherun/clarity","private":false,"owner":{"login":"gnomeontherun","id":79500,"node_id":"MDQ6VXNlcjc5NTAw","avatar_url":"https://avatars3.githubusercontent.com/u/79500?v=4","gravatar_id":"","url":"https://api.github.com/users/gnomeontherun","html_url":"https://github.com/gnomeontherun","followers_url":"https://api.github.com/users/gnomeontherun/followers","following_url":"https://api.github.com/users/gnomeontherun/following{/other_user}","gists_url":"https://api.github.com/users/gnomeontherun/gists{/gist_id}","starred_url":"https://api.github.com/users/gnomeontherun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnomeontherun/subscriptions","organizations_url":"https://api.github.com/users/gnomeontherun/orgs","repos_url":"https://api.github.com/users/gnomeontherun/repos","events_url":"https://api.github.com/users/gnomeontherun/events{/privacy}","received_events_url":"https://api.github.com/users/gnomeontherun/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gnomeontherun/clarity","description":"Clarity Design System: UX guidelines, HTML/CSS framework, and Angular 2 components working together to craft exceptional experiences","fork":true,"url":"https://api.github.com/repos/gnomeontherun/clarity","forks_url":"https://api.github.com/repos/gnomeontherun/clarity/forks","keys_url":"https://api.github.com/repos/gnomeontherun/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnomeontherun/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnomeontherun/clarity/teams","hooks_url":"https://api.github.com/repos/gnomeontherun/clarity/hooks","issue_events_url":"https://api.github.com/repos/gnomeontherun/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/gnomeontherun/clarity/events","assignees_url":"https://api.github.com/repos/gnomeontherun/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/gnomeontherun/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/gnomeontherun/clarity/tags","blobs_url":"https://api.github.com/repos/gnomeontherun/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnomeontherun/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnomeontherun/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnomeontherun/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnomeontherun/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/gnomeontherun/clarity/languages","stargazers_url":"https://api.github.com/repos/gnomeontherun/clarity/stargazers","contributors_url":"https://api.github.com/repos/gnomeontherun/clarity/contributors","subscribers_url":"https://api.github.com/repos/gnomeontherun/clarity/subscribers","subscription_url":"https://api.github.com/repos/gnomeontherun/clarity/subscription","commits_url":"https://api.github.com/repos/gnomeontherun/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnomeontherun/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnomeontherun/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnomeontherun/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnomeontherun/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/gnomeontherun/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnomeontherun/clarity/merges","archive_url":"https://api.github.com/repos/gnomeontherun/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnomeontherun/clarity/downloads","issues_url":"https://api.github.com/repos/gnomeontherun/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/gnomeontherun/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/gnomeontherun/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/gnomeontherun/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnomeontherun/clarity/labels{/name}","releases_url":"https://api.github.com/repos/gnomeontherun/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/gnomeontherun/clarity/deployments","created_at":"2016-11-19T19:27:08Z","updated_at":"2018-06-11T15:28:49Z","pushed_at":"2018-11-02T17:38:34Z","git_url":"git://github.com/gnomeontherun/clarity.git","ssh_url":"git@github.com:gnomeontherun/clarity.git","clone_url":"https://github.com/gnomeontherun/clarity.git","svn_url":"https://github.com/gnomeontherun/clarity","homepage":"https://vmware.github.io/clarity/","size":279420,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"ce6018da54de3d5fe33f2b1c93fe2ad09e603797","user":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":69590701,"node_id":"MDEwOlJlcG9zaXRvcnk2OTU5MDcwMQ==","name":"clarity","full_name":"vmware/clarity","private":false,"owner":{"login":"vmware","id":473334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vmware/clarity","description":"UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences","fork":false,"url":"https://api.github.com/repos/vmware/clarity","forks_url":"https://api.github.com/repos/vmware/clarity/forks","keys_url":"https://api.github.com/repos/vmware/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/clarity/teams","hooks_url":"https://api.github.com/repos/vmware/clarity/hooks","issue_events_url":"https://api.github.com/repos/vmware/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/clarity/events","assignees_url":"https://api.github.com/repos/vmware/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/clarity/tags","blobs_url":"https://api.github.com/repos/vmware/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/clarity/languages","stargazers_url":"https://api.github.com/repos/vmware/clarity/stargazers","contributors_url":"https://api.github.com/repos/vmware/clarity/contributors","subscribers_url":"https://api.github.com/repos/vmware/clarity/subscribers","subscription_url":"https://api.github.com/repos/vmware/clarity/subscription","commits_url":"https://api.github.com/repos/vmware/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/clarity/merges","archive_url":"https://api.github.com/repos/vmware/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/clarity/downloads","issues_url":"https://api.github.com/repos/vmware/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/clarity/labels{/name}","releases_url":"https://api.github.com/repos/vmware/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/clarity/deployments","created_at":"2016-09-29T17:24:17Z","updated_at":"2018-11-02T17:26:05Z","pushed_at":"2018-11-02T17:38:36Z","git_url":"git://github.com/vmware/clarity.git","ssh_url":"git@github.com:vmware/clarity.git","clone_url":"https://github.com/vmware/clarity.git","svn_url":"https://github.com/vmware/clarity","homepage":"http://clarity.design","size":320893,"stargazers_count":4168,"watchers_count":4168,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":391,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":391,"open_issues":293,"watchers":4168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2735"},"html":{"href":"https://github.com/vmware/clarity/pull/2735"},"issue":{"href":"https://api.github.com/repos/vmware/clarity/issues/2735"},"comments":{"href":"https://api.github.com/repos/vmware/clarity/issues/2735/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2735/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2735/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/clarity/statuses/e371bb11acc70aef844dc0bc791c969075db27c9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gnomeontherun"}}