{"action":"created","issue":{"url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1052","repository_url":"https://api.github.com/repos/reactstrap/reactstrap","labels_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1052/labels{/name}","comments_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1052/comments","events_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1052/events","html_url":"https://github.com/reactstrap/reactstrap/issues/1052","id":328246540,"node_id":"MDU6SXNzdWUzMjgyNDY1NDA=","number":1052,"title":"Inconsistent propTypes for valid/invalid on FormFeedback","user":{"login":"haldunanil","id":9256828,"node_id":"MDQ6VXNlcjkyNTY4Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/9256828?v=4","gravatar_id":"","url":"https://api.github.com/users/haldunanil","html_url":"https://github.com/haldunanil","followers_url":"https://api.github.com/users/haldunanil/followers","following_url":"https://api.github.com/users/haldunanil/following{/other_user}","gists_url":"https://api.github.com/users/haldunanil/gists{/gist_id}","starred_url":"https://api.github.com/users/haldunanil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haldunanil/subscriptions","organizations_url":"https://api.github.com/users/haldunanil/orgs","repos_url":"https://api.github.com/users/haldunanil/repos","events_url":"https://api.github.com/users/haldunanil/events{/privacy}","received_events_url":"https://api.github.com/users/haldunanil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-31T18:22:42Z","updated_at":"2018-09-08T19:52:46Z","closed_at":null,"author_association":"NONE","body":"<!-- The following is part of our issue template, feel free to remove this if it doesn't apply -->\r\n### Issue description\r\n\r\n- components: `FormFeedback`\r\n- reactstrap version `#6.0.1`\r\n- import method `es`\r\n- react version `#16.4.0`\r\n- bootstrap version `#4.1.1`\r\n\r\n### What is happening?\r\n\r\nPassing `true` as a value to `invalid` attribute raises a Warning message, even though passing `true` into `valid` does not.\r\n\r\n### What should be happening?\r\n\r\nI should not get this error, `invalid` should accept a boolean value.\r\n\r\n### Error message in console\r\n\r\n```\r\nwarning.js:33 Warning: Received `true` for a non-boolean attribute `invalid`.\r\n\r\nIf you want to write it to the DOM, pass a string instead: invalid=\"true\" or invalid={value.toString()}.\r\n    in div (created by FormFeedback)\r\n    in FormFeedback (created by FormBaseInput)\r\n    in div (created by FormGroup)\r\n    in FormGroup (created by FormBaseInput)\r\n    in FormBaseInput\r\n    in div (created by Story)\r\n    in div (created by Story)\r\n    in ThemeProvider (created by Story)\r\n    in Story\r\n    in WrapStory\r\n```\r\n\r\n### Code\r\n\r\n<FormFeedback valid={this.props.valid} invalid={this.props.invalid}>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/reactstrap/reactstrap/issues/comments/419668744","html_url":"https://github.com/reactstrap/reactstrap/issues/1052#issuecomment-419668744","issue_url":"https://api.github.com/repos/reactstrap/reactstrap/issues/1052","id":419668744,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTY2ODc0NA==","user":{"login":"mFingers","id":1946506,"node_id":"MDQ6VXNlcjE5NDY1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1946506?v=4","gravatar_id":"","url":"https://api.github.com/users/mFingers","html_url":"https://github.com/mFingers","followers_url":"https://api.github.com/users/mFingers/followers","following_url":"https://api.github.com/users/mFingers/following{/other_user}","gists_url":"https://api.github.com/users/mFingers/gists{/gist_id}","starred_url":"https://api.github.com/users/mFingers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mFingers/subscriptions","organizations_url":"https://api.github.com/users/mFingers/orgs","repos_url":"https://api.github.com/users/mFingers/repos","events_url":"https://api.github.com/users/mFingers/events{/privacy}","received_events_url":"https://api.github.com/users/mFingers/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T19:52:46Z","updated_at":"2018-09-08T19:52:46Z","author_association":"NONE","body":"I had the same confusion at first.  It's not a big deal, but it did add a little bit of overhead to learning the components.\r\n\r\nTo show the \"input is good\" message::\r\n```jsx\r\n<Input valid={true} ... />\r\n<FormFeedback valid>Hey!  Nice job!</FormFeedback>\r\n```\r\n\r\nAnd when you want to show an \"input is bad\" message:\r\n```jsx\r\n<Input invalid={true} ... />\r\n<FormFeedback>Oops!  You need to fix that.</FormFeedback>\r\n```\r\nHaving the valid and invalid states separate on `Input` is wonderful - it makes it very clear. I'd love to have the same clarity on `FormFeedback`:\r\n```jsx\r\n<Input invalid={true} ... />\r\n<FormFeedback invalid>Oops!  You need to fix that.</FormFeedback>\r\n```"}}
{"actor":{"display_login":"mFingers"}}