{"action":"opened","number":5841,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841","id":184967047,"html_url":"https://github.com/bbatsov/rubocop/pull/5841","diff_url":"https://github.com/bbatsov/rubocop/pull/5841.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/5841.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5841","number":5841,"state":"open","locked":false,"title":"Fixes #5838 and unit test","user":{"login":"andy-smith-msm","id":27726985,"avatar_url":"https://avatars2.githubusercontent.com/u/27726985?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-smith-msm","html_url":"https://github.com/andy-smith-msm","followers_url":"https://api.github.com/users/andy-smith-msm/followers","following_url":"https://api.github.com/users/andy-smith-msm/following{/other_user}","gists_url":"https://api.github.com/users/andy-smith-msm/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-smith-msm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-smith-msm/subscriptions","organizations_url":"https://api.github.com/users/andy-smith-msm/orgs","repos_url":"https://api.github.com/users/andy-smith-msm/repos","events_url":"https://api.github.com/users/andy-smith-msm/events{/privacy}","received_events_url":"https://api.github.com/users/andy-smith-msm/received_events","type":"User","site_admin":false},"body":"Issue based upon CommentConfig#extra_enabled_comments returning individually enabled cops after finding enable all where the default state would have been for them to be enabled anyway.\r\n\r\nThis caused comment to contain rubocop:enabel all but the name of the offence to match the individual cop and a failure in cop_name_indentation to index the position.\r\n\r\nWorkaround is to reject offences in the cop containing enable all in the comment.\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [ ] Wrote [good commit messages][1].\r\n* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [ ] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [ ] Squashed related commits together.\r\n* [ ] Added tests.\r\n* [ ] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [ ] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [ ] Run `rake default` or `rake parallel`. It executes all tests and RuboCop for itself, and generates the documentation.\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/","created_at":"2018-04-30T14:12:07Z","updated_at":"2018-04-30T14:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/5841/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/54e1a032df58f7424dfd34ee8cdd49efbd8cd65e","head":{"label":"andy-smith-msm:ajs-rubocop-5838","ref":"ajs-rubocop-5838","sha":"54e1a032df58f7424dfd34ee8cdd49efbd8cd65e","user":{"login":"andy-smith-msm","id":27726985,"avatar_url":"https://avatars2.githubusercontent.com/u/27726985?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-smith-msm","html_url":"https://github.com/andy-smith-msm","followers_url":"https://api.github.com/users/andy-smith-msm/followers","following_url":"https://api.github.com/users/andy-smith-msm/following{/other_user}","gists_url":"https://api.github.com/users/andy-smith-msm/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-smith-msm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-smith-msm/subscriptions","organizations_url":"https://api.github.com/users/andy-smith-msm/orgs","repos_url":"https://api.github.com/users/andy-smith-msm/repos","events_url":"https://api.github.com/users/andy-smith-msm/events{/privacy}","received_events_url":"https://api.github.com/users/andy-smith-msm/received_events","type":"User","site_admin":false},"repo":{"id":131593649,"name":"rubocop","full_name":"andy-smith-msm/rubocop","owner":{"login":"andy-smith-msm","id":27726985,"avatar_url":"https://avatars2.githubusercontent.com/u/27726985?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-smith-msm","html_url":"https://github.com/andy-smith-msm","followers_url":"https://api.github.com/users/andy-smith-msm/followers","following_url":"https://api.github.com/users/andy-smith-msm/following{/other_user}","gists_url":"https://api.github.com/users/andy-smith-msm/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-smith-msm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-smith-msm/subscriptions","organizations_url":"https://api.github.com/users/andy-smith-msm/orgs","repos_url":"https://api.github.com/users/andy-smith-msm/repos","events_url":"https://api.github.com/users/andy-smith-msm/events{/privacy}","received_events_url":"https://api.github.com/users/andy-smith-msm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy-smith-msm/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/andy-smith-msm/rubocop","forks_url":"https://api.github.com/repos/andy-smith-msm/rubocop/forks","keys_url":"https://api.github.com/repos/andy-smith-msm/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-smith-msm/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-smith-msm/rubocop/teams","hooks_url":"https://api.github.com/repos/andy-smith-msm/rubocop/hooks","issue_events_url":"https://api.github.com/repos/andy-smith-msm/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/andy-smith-msm/rubocop/events","assignees_url":"https://api.github.com/repos/andy-smith-msm/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/andy-smith-msm/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/andy-smith-msm/rubocop/tags","blobs_url":"https://api.github.com/repos/andy-smith-msm/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-smith-msm/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-smith-msm/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-smith-msm/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-smith-msm/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-smith-msm/rubocop/languages","stargazers_url":"https://api.github.com/repos/andy-smith-msm/rubocop/stargazers","contributors_url":"https://api.github.com/repos/andy-smith-msm/rubocop/contributors","subscribers_url":"https://api.github.com/repos/andy-smith-msm/rubocop/subscribers","subscription_url":"https://api.github.com/repos/andy-smith-msm/rubocop/subscription","commits_url":"https://api.github.com/repos/andy-smith-msm/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-smith-msm/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-smith-msm/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-smith-msm/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-smith-msm/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/andy-smith-msm/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-smith-msm/rubocop/merges","archive_url":"https://api.github.com/repos/andy-smith-msm/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-smith-msm/rubocop/downloads","issues_url":"https://api.github.com/repos/andy-smith-msm/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/andy-smith-msm/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-smith-msm/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-smith-msm/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-smith-msm/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/andy-smith-msm/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/andy-smith-msm/rubocop/deployments","created_at":"2018-04-30T12:33:41Z","updated_at":"2018-04-30T12:33:46Z","pushed_at":"2018-04-30T14:08:12Z","git_url":"git://github.com/andy-smith-msm/rubocop.git","ssh_url":"git@github.com:andy-smith-msm/rubocop.git","clone_url":"https://github.com/andy-smith-msm/rubocop.git","svn_url":"https://github.com/andy-smith-msm/rubocop","homepage":"http://rubocop.readthedocs.io","size":21057,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"628ab0f69fc30664a0bc77a2e9e37f704097b545","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2018-04-30T12:54:48Z","pushed_at":"2018-04-30T12:21:39Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":21057,"stargazers_count":8958,"watchers_count":8958,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1741,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1741,"open_issues":335,"watchers":8958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/5841"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5841"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/5841/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/5841/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/54e1a032df58f7424dfd34ee8cdd49efbd8cd65e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":13,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"andy-smith-msm"}}