{"action":"created","issue":{"url":"https://api.github.com/repos/desktop/desktop/issues/4470","repository_url":"https://api.github.com/repos/desktop/desktop","labels_url":"https://api.github.com/repos/desktop/desktop/issues/4470/labels{/name}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/4470/comments","events_url":"https://api.github.com/repos/desktop/desktop/issues/4470/events","html_url":"https://github.com/desktop/desktop/issues/4470","id":315774980,"number":4470,"title":"Add syntax highlighting for JSP files","user":{"login":"Kyhel","id":4179331,"avatar_url":"https://avatars2.githubusercontent.com/u/4179331?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyhel","html_url":"https://github.com/Kyhel","followers_url":"https://api.github.com/users/Kyhel/followers","following_url":"https://api.github.com/users/Kyhel/following{/other_user}","gists_url":"https://api.github.com/users/Kyhel/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyhel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyhel/subscriptions","organizations_url":"https://api.github.com/users/Kyhel/orgs","repos_url":"https://api.github.com/users/Kyhel/repos","events_url":"https://api.github.com/users/Kyhel/events{/privacy}","received_events_url":"https://api.github.com/users/Kyhel/received_events","type":"User","site_admin":false},"labels":[{"id":374514539,"url":"https://api.github.com/repos/desktop/desktop/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":596685860,"url":"https://api.github.com/repos/desktop/desktop/labels/help%20wanted","name":"help wanted","color":"59e58c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-19T08:26:23Z","updated_at":"2018-04-19T12:47:21Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nFirst and foremost, we’d like to thank you for taking the time to contribute to our project. Before submitting your issue, please follow these steps:\r\n\r\n1. Familiarize yourself with our contributing guide:\r\n\t* https://github.com/desktop/desktop/blob/master/CONTRIBUTING.md#contributing-to-github-desktop\r\n2. Check if your issue (and sometimes workaround) is in the known-issues doc:\r\n\t* https://github.com/desktop/desktop/blob/master/docs/known-issues.md\r\n3. Make sure your issue isn’t a duplicate of another issue\r\n4. If you have made it to this step, go ahead and fill out the template below\r\n-->\r\n\r\n## Description\r\n<!--\r\nProvide a detailed description of the behavior you're seeing or the behavior you'd like to see **below** this comment.\r\n-->\r\nThe JSP (Java Server Pages) files are not highlighted in the diffs.\r\nBy reading the file https://github.com/desktop/desktop/blob/master/docs/technical/syntax-highlighting.md I've seen it's not in the supported language list, but since it says that if it's in the CodeMirror's supported language list (https://codemirror.net/mode/htmlembedded/index.html) I just need to open an issue to have it covered, there it is.\r\n\r\n\r\n## Version\r\n<!--\r\nPlace the version of GitHub Desktop you have installed **below** this comment. This is displayed under the 'About GitHub Desktop' menu item. If you are running from source, include the commit by running `git rev-parse HEAD` from the local repository.\r\n-->\r\n* GitHub Desktop: 1.1.2-beta3\r\n<!--\r\nPlace the version of your operating system **below** this comment. The operating system you are running on may also help with reproducing the issue. If you are on macOS, launch 'About This Mac' and write down the OS version listed. If you are on Windows, open 'Command Prompt' and attach the output of this command: 'cmd /c ver'\r\n-->\r\n* Operating system: Windows 7 Pro\r\n\r\n\r\n## Steps to Reproduce\r\n<!--\r\nList the steps to reproduce your issue **below** this comment\r\nex,\r\n1. `step 1`\r\n2. `step 2`\r\n3. `and so on…`\r\n-->\r\n\r\n1. Commit a file ending with the JSP extension (.jsp)\r\n\r\n### Expected Behavior\r\n<!-- What you expected to happen -->\r\nThe file's syntax is highlighted.\r\n### Actual Behavior\r\n<!-- What actually happens -->\r\nThe file's synatx is not highlighted.\r\n\r\n## Additional Information\r\n<!--\r\nPlace any additional information, configuration, or data that might be necessary to reproduce the issue **below** this comment.\r\n\r\nIf you have screen shots or gifs that demonstrate the issue, please include them.\r\n\r\nIf the issue involves a specific public repository, including the information about it will make it easier to recreate the issue.\r\n\r\nIf you are dealing with a performance issue or regression, attaching a Timeline profile of the task will help the developers understand the runtime behavior of the application on your machine.\r\nhttps://github.com/desktop/desktop/blob/master/docs/contributing/timeline-profile.md\r\n-->\r\nI don't think any more information is needed since this is pretty straightforward, but just in case, here is a sample file from my project. (Which also shows here what kind of highlighting could be expected)\r\n\r\n```jsp\r\n\r\n<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"\r\n\"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\r\n<%@ page language=\"java\" contentType=\"text/html;charset=UTF-8\" %>\r\n<%@ taglib prefix=\"template\" uri=\"http://www.jahia.org/tags/templateLib\" %>\r\n<%@ taglib prefix=\"c\" uri=\"http://java.sun.com/jsp/jstl/core\" %>\r\n<%@ taglib prefix=\"fn\" uri=\"http://java.sun.com/jsp/jstl/functions\" %>\r\n<%@ taglib prefix=\"jcr\" uri=\"http://www.jahia.org/tags/jcr\" %>\r\n<%--@elvariable id=\"currentNode\" type=\"org.jahia.services.content.JCRNodeWrapper\"--%>\r\n<%--@elvariable id=\"out\" type=\"java.io.PrintWriter\"--%>\r\n<%--@elvariable id=\"script\" type=\"org.jahia.services.render.scripting.Script\"--%>\r\n<%--@elvariable id=\"scriptInfo\" type=\"java.lang.String\"--%>\r\n<%--@elvariable id=\"workspace\" type=\"java.lang.String\"--%>\r\n<%--@elvariable id=\"renderContext\" type=\"org.jahia.services.render.RenderContext\"--%>\r\n<%--@elvariable id=\"currentResource\" type=\"org.jahia.services.render.Resource\"--%>\r\n<%--@elvariable id=\"url\" type=\"org.jahia.services.render.URLGenerator\"--%>\r\n\r\n\r\n<html lang=\"fr\">\r\n  <head>\r\n    \r\n    <template:include view=\"hidden.head\" />\r\n    \r\n  </head>\r\n  \r\n  <body>\r\n    <div id=\"page-wrapper\">\r\n      \r\n      <template:include view=\"hidden.header\" />\r\n      \r\n      <div class=\"content\" id=\"top\">\r\n      \r\n        <template:area path=\"zone-profiling-guard\" nodeTypes=\"awebnt:profilingGuard\" listLimit=\"1\" />\r\n\r\n        <template:area path=\"document\" moduleType=\"absoluteArea\" level=\"1\" nodeTypes=\"awebnt:listedocs\" listLimit=\"1\" limitedAbsoluteAreaEdit=\"false\" />\r\n        \r\n        <div class=\"wrapper sm border-bottom t16\">\r\n          <template:area path=\"pagecontent\"/>\r\n        </div>\r\n      </div>\r\n    \r\n      <template:include view=\"hidden.footer\" />\r\n\r\n    </div>\r\n\r\n    <script src=\"${url.context}${url.currentModule}/javascript/jquery/jquery.follow-me.js\"></script>\r\n    <script type=\"text/javascript\" src=\"${url.context}${url.currentModule}/javascript/app.js\"></script>\r\n    \r\n  </body>\r\n</html>\r\n```\r\n\r\n### Logs\r\n<!--\r\nAttach your log file (You can simply drag your file here to insert it) to this issue. Please make sure the generated link to your log file is **below** this comment section otherwise it will not appear when you submit your issue.\r\n\r\nmacOS logs location: `~/Library/Application Support/GitHub Desktop/logs/*.desktop.production.log`\r\nWindows logs location: `%APPDATA%\\GitHub Desktop\\logs\\*.desktop.production.log`\r\n\r\nThe log files are organized by date, so see if anything was generated for today's date.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/desktop/desktop/issues/comments/382720846","html_url":"https://github.com/desktop/desktop/issues/4470#issuecomment-382720846","issue_url":"https://api.github.com/repos/desktop/desktop/issues/4470","id":382720846,"user":{"login":"Kyhel","id":4179331,"avatar_url":"https://avatars2.githubusercontent.com/u/4179331?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyhel","html_url":"https://github.com/Kyhel","followers_url":"https://api.github.com/users/Kyhel/followers","following_url":"https://api.github.com/users/Kyhel/following{/other_user}","gists_url":"https://api.github.com/users/Kyhel/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyhel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyhel/subscriptions","organizations_url":"https://api.github.com/users/Kyhel/orgs","repos_url":"https://api.github.com/users/Kyhel/repos","events_url":"https://api.github.com/users/Kyhel/events{/privacy}","received_events_url":"https://api.github.com/users/Kyhel/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T12:47:21Z","updated_at":"2018-04-19T12:47:21Z","author_association":"NONE","body":"Is the way to add the highlighting for this language as simple as for this PR https://github.com/desktop/desktop/pull/4445 ?\r\nIf so, I may be able to do it myself. \r\nAlso, if it's that simple, maybe I could consider adding other languages that are present in CodeMirror but not here, should I make a different PR for each, or could I do several of them in the same PR ?"}}
{"actor":{"display_login":"Kyhel"}}