{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1","id":192572465,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTcyNDY1","html_url":"https://github.com/mrtheb/env-aws-params/pull/1","diff_url":"https://github.com/mrtheb/env-aws-params/pull/1.diff","patch_url":"https://github.com/mrtheb/env-aws-params/pull/1.patch","issue_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/1","number":1,"state":"closed","locked":false,"title":"Fix command call args","user":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"body":"As per https://golang.org/pkg/os/#StartProcess the argv slice will\r\nbecome os.Args in the new process, so it normally starts with the\r\nprogram name.\r\n\r\nDefining 3 parameters in SSM\r\n- `enabled`\r\n- `connect`\r\n- `saycurity`\r\n\r\nWithout the fix, `printenv` doesn't care about saysecurity positioned at argv[0] (where the command should be), so it prints all environment variables:\r\n```\r\nenv-aws-params --aws-region us-east-1 --prefix /prod/thing/main --pristine /usr/bin/printenv saycurity \r\nINFO[0000] PID 16710 running /usr/bin/printenv saycurity \r\nenabled=true\r\nsaycurity=abc1234*\r\nconnect=10.100.0.1:2181,10.100.1.1:2181\r\n```\r\n\r\nWith the fix, printenv only prints the value of the `saycurity` parameter, as expected.\r\n```\r\nenv-aws-params --aws-region us-east-1 --prefix /prod/thing/main --pristine /usr/bin/printenv saycurity \r\nINFO[0000] PID 16696 running /usr/bin/printenv saycurity \r\nabc1234*\r\n```","created_at":"2018-06-05T02:06:12Z","updated_at":"2018-06-05T02:07:34Z","closed_at":"2018-06-05T02:07:34Z","merged_at":"2018-06-05T02:07:34Z","merge_commit_sha":"d84da8aeb0112715fd1f13f46f89b368819eab5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/1/comments","statuses_url":"https://api.github.com/repos/mrtheb/env-aws-params/statuses/e8f781476d542f41e62be1696c98ccbbf50bc826","head":{"label":"mrtheb:fix-command-call-args","ref":"fix-command-call-args","sha":"e8f781476d542f41e62be1696c98ccbbf50bc826","user":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"repo":{"id":136002987,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMDI5ODc=","name":"env-aws-params","full_name":"mrtheb/env-aws-params","owner":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrtheb/env-aws-params","description":"Inject AWS SSM Parameters as Environment Variables","fork":true,"url":"https://api.github.com/repos/mrtheb/env-aws-params","forks_url":"https://api.github.com/repos/mrtheb/env-aws-params/forks","keys_url":"https://api.github.com/repos/mrtheb/env-aws-params/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrtheb/env-aws-params/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrtheb/env-aws-params/teams","hooks_url":"https://api.github.com/repos/mrtheb/env-aws-params/hooks","issue_events_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/events{/number}","events_url":"https://api.github.com/repos/mrtheb/env-aws-params/events","assignees_url":"https://api.github.com/repos/mrtheb/env-aws-params/assignees{/user}","branches_url":"https://api.github.com/repos/mrtheb/env-aws-params/branches{/branch}","tags_url":"https://api.github.com/repos/mrtheb/env-aws-params/tags","blobs_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrtheb/env-aws-params/statuses/{sha}","languages_url":"https://api.github.com/repos/mrtheb/env-aws-params/languages","stargazers_url":"https://api.github.com/repos/mrtheb/env-aws-params/stargazers","contributors_url":"https://api.github.com/repos/mrtheb/env-aws-params/contributors","subscribers_url":"https://api.github.com/repos/mrtheb/env-aws-params/subscribers","subscription_url":"https://api.github.com/repos/mrtheb/env-aws-params/subscription","commits_url":"https://api.github.com/repos/mrtheb/env-aws-params/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrtheb/env-aws-params/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrtheb/env-aws-params/contents/{+path}","compare_url":"https://api.github.com/repos/mrtheb/env-aws-params/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrtheb/env-aws-params/merges","archive_url":"https://api.github.com/repos/mrtheb/env-aws-params/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrtheb/env-aws-params/downloads","issues_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues{/number}","pulls_url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls{/number}","milestones_url":"https://api.github.com/repos/mrtheb/env-aws-params/milestones{/number}","notifications_url":"https://api.github.com/repos/mrtheb/env-aws-params/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrtheb/env-aws-params/labels{/name}","releases_url":"https://api.github.com/repos/mrtheb/env-aws-params/releases{/id}","deployments_url":"https://api.github.com/repos/mrtheb/env-aws-params/deployments","created_at":"2018-06-04T09:34:05Z","updated_at":"2018-06-04T09:34:06Z","pushed_at":"2018-06-05T02:07:34Z","git_url":"git://github.com/mrtheb/env-aws-params.git","ssh_url":"git@github.com:mrtheb/env-aws-params.git","clone_url":"https://github.com/mrtheb/env-aws-params.git","svn_url":"https://github.com/mrtheb/env-aws-params","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrtheb:master","ref":"master","sha":"3b9b47957fac44ce2c984f3624f5608213d75fa0","user":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"repo":{"id":136002987,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMDI5ODc=","name":"env-aws-params","full_name":"mrtheb/env-aws-params","owner":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrtheb/env-aws-params","description":"Inject AWS SSM Parameters as Environment Variables","fork":true,"url":"https://api.github.com/repos/mrtheb/env-aws-params","forks_url":"https://api.github.com/repos/mrtheb/env-aws-params/forks","keys_url":"https://api.github.com/repos/mrtheb/env-aws-params/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrtheb/env-aws-params/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrtheb/env-aws-params/teams","hooks_url":"https://api.github.com/repos/mrtheb/env-aws-params/hooks","issue_events_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/events{/number}","events_url":"https://api.github.com/repos/mrtheb/env-aws-params/events","assignees_url":"https://api.github.com/repos/mrtheb/env-aws-params/assignees{/user}","branches_url":"https://api.github.com/repos/mrtheb/env-aws-params/branches{/branch}","tags_url":"https://api.github.com/repos/mrtheb/env-aws-params/tags","blobs_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrtheb/env-aws-params/statuses/{sha}","languages_url":"https://api.github.com/repos/mrtheb/env-aws-params/languages","stargazers_url":"https://api.github.com/repos/mrtheb/env-aws-params/stargazers","contributors_url":"https://api.github.com/repos/mrtheb/env-aws-params/contributors","subscribers_url":"https://api.github.com/repos/mrtheb/env-aws-params/subscribers","subscription_url":"https://api.github.com/repos/mrtheb/env-aws-params/subscription","commits_url":"https://api.github.com/repos/mrtheb/env-aws-params/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrtheb/env-aws-params/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrtheb/env-aws-params/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrtheb/env-aws-params/contents/{+path}","compare_url":"https://api.github.com/repos/mrtheb/env-aws-params/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrtheb/env-aws-params/merges","archive_url":"https://api.github.com/repos/mrtheb/env-aws-params/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrtheb/env-aws-params/downloads","issues_url":"https://api.github.com/repos/mrtheb/env-aws-params/issues{/number}","pulls_url":"https://api.github.com/repos/mrtheb/env-aws-params/pulls{/number}","milestones_url":"https://api.github.com/repos/mrtheb/env-aws-params/milestones{/number}","notifications_url":"https://api.github.com/repos/mrtheb/env-aws-params/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrtheb/env-aws-params/labels{/name}","releases_url":"https://api.github.com/repos/mrtheb/env-aws-params/releases{/id}","deployments_url":"https://api.github.com/repos/mrtheb/env-aws-params/deployments","created_at":"2018-06-04T09:34:05Z","updated_at":"2018-06-04T09:34:06Z","pushed_at":"2018-06-05T02:07:34Z","git_url":"git://github.com/mrtheb/env-aws-params.git","ssh_url":"git@github.com:mrtheb/env-aws-params.git","clone_url":"https://github.com/mrtheb/env-aws-params.git","svn_url":"https://github.com/mrtheb/env-aws-params","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1"},"html":{"href":"https://github.com/mrtheb/env-aws-params/pull/1"},"issue":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/issues/1"},"comments":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mrtheb/env-aws-params/statuses/e8f781476d542f41e62be1696c98ccbbf50bc826"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mrtheb","id":1655357,"node_id":"MDQ6VXNlcjE2NTUzNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1655357?v=4","gravatar_id":"","url":"https://api.github.com/users/mrtheb","html_url":"https://github.com/mrtheb","followers_url":"https://api.github.com/users/mrtheb/followers","following_url":"https://api.github.com/users/mrtheb/following{/other_user}","gists_url":"https://api.github.com/users/mrtheb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtheb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtheb/subscriptions","organizations_url":"https://api.github.com/users/mrtheb/orgs","repos_url":"https://api.github.com/users/mrtheb/repos","events_url":"https://api.github.com/users/mrtheb/events{/privacy}","received_events_url":"https://api.github.com/users/mrtheb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mrtheb"}}