{"action":"created","issue":{"url":"https://api.github.com/repos/timoh6/GenPhrase/issues/6","repository_url":"https://api.github.com/repos/timoh6/GenPhrase","labels_url":"https://api.github.com/repos/timoh6/GenPhrase/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/timoh6/GenPhrase/issues/6/comments","events_url":"https://api.github.com/repos/timoh6/GenPhrase/issues/6/events","html_url":"https://github.com/timoh6/GenPhrase/issues/6","id":363230829,"node_id":"MDU6SXNzdWUzNjMyMzA4Mjk=","number":6,"title":"[Feature Request] Wordlists with > 65536 words","user":{"login":"ProjectCleverWeb","id":1664987,"node_id":"MDQ6VXNlcjE2NjQ5ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/1664987?v=4","gravatar_id":"","url":"https://api.github.com/users/ProjectCleverWeb","html_url":"https://github.com/ProjectCleverWeb","followers_url":"https://api.github.com/users/ProjectCleverWeb/followers","following_url":"https://api.github.com/users/ProjectCleverWeb/following{/other_user}","gists_url":"https://api.github.com/users/ProjectCleverWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectCleverWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectCleverWeb/subscriptions","organizations_url":"https://api.github.com/users/ProjectCleverWeb/orgs","repos_url":"https://api.github.com/users/ProjectCleverWeb/repos","events_url":"https://api.github.com/users/ProjectCleverWeb/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectCleverWeb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-24T16:50:22Z","updated_at":"2018-09-25T07:30:19Z","closed_at":null,"author_association":"NONE","body":"Right now, if you supply a wordlists with more than 65536 words, it errors our with:\r\n\r\n> $poolSize must be between 2 and 65536\r\n\r\nIf you change `Random::MAX_ALLOWED_POOL_SIZE` to 16,777,216 (2^24) and `Random::MAX_ALLOWED_POWER_OF_TWO` to 2,147,483,648 (2^31) you could start supporting wordlists with up to 16,777,216 words.\r\n\r\nRight now, in order to get my current wordlist to work (125,000 words), I have had to change these values manually. But there's no reason I can think of why this shouldn't be supported out of the box?"},"comment":{"url":"https://api.github.com/repos/timoh6/GenPhrase/issues/comments/424236685","html_url":"https://github.com/timoh6/GenPhrase/issues/6#issuecomment-424236685","issue_url":"https://api.github.com/repos/timoh6/GenPhrase/issues/6","id":424236685,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDIzNjY4NQ==","user":{"login":"timoh6","id":851306,"node_id":"MDQ6VXNlcjg1MTMwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/851306?v=4","gravatar_id":"","url":"https://api.github.com/users/timoh6","html_url":"https://github.com/timoh6","followers_url":"https://api.github.com/users/timoh6/followers","following_url":"https://api.github.com/users/timoh6/following{/other_user}","gists_url":"https://api.github.com/users/timoh6/gists{/gist_id}","starred_url":"https://api.github.com/users/timoh6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoh6/subscriptions","organizations_url":"https://api.github.com/users/timoh6/orgs","repos_url":"https://api.github.com/users/timoh6/repos","events_url":"https://api.github.com/users/timoh6/events{/privacy}","received_events_url":"https://api.github.com/users/timoh6/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T07:30:19Z","updated_at":"2018-09-25T07:30:19Z","author_association":"OWNER","body":"I think it is enough if we just adjust the MAX_ALLOWED_POOL_SIZE to, say, 262144. This should not affect performance too much (the cases a new random number have to be generated as it is too high) and should be great enough for wordlists (that I can think of).\r\n\r\nAdjusting MAX_ALLOWED_POWER_OF_TWO to a bigger number shouldn't be a problem per se, 2^25 would be fine, but testing the random int generator for uniform distribution gets slower (much bigger range of numbers).\r\n\r\nI think MAX_ALLOWED_POOL_SIZE: 262144 and MAX_ALLOWED_POWER_OF_TWO: 33554432 would be a reasonable compromise. What do you think?"}}
{"actor":{"display_login":"timoh6"}}