{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/228079316","pull_request_review_id":168263009,"id":228079316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODA3OTMxNg==","diff_hunk":"@@ -0,0 +1,65 @@\n+/*\n+ * Copyright (C) 2018 Freie Universität Berlin\n+ *\n+ * This file is subject to the terms and conditions of the GNU Lesser\n+ * General Public License v2.1. See the file LICENSE in the top level\n+ * directory for more details.\n+ */\n+\n+/**\n+ * @defgroup    net_gnrc_ipv6_ext_rh Support for IPv6 routing header extension\n+ * @ingroup     net_gnrc_ipv6_ext\n+ * @brief       GNRC implementation of IPv6 routing header extension.\n+ * @{\n+ *\n+ * @file\n+ * @brief   GNRC routing extension header definitions.\n+ *\n+ * @author  Martine Lenders <m.lenders@fu-berlin.de>\n+ */\n+#ifndef NET_GNRC_IPV6_EXT_RH_H\n+#define NET_GNRC_IPV6_EXT_RH_H\n+\n+#include \"net/ipv6/hdr.h\"\n+\n+#include \"net/ipv6/ext/rh.h\"\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+enum {\n+    /**\n+     * @brief   The routing header was successfully processed and this node\n+     *          is the destination\n+     */\n+    GNRC_IPV6_EXT_RH_OK = 0,","path":"sys/include/net/gnrc/ipv6/ext/rh.h","position":36,"original_position":36,"commit_id":"8fbf089d3db0ec09f134b2a9ec18882d9e7654f3","original_commit_id":"8fbf089d3db0ec09f134b2a9ec18882d9e7654f3","user":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"(since this enum values are providing the most headache when rebasing, this will be fun to rename ;-D, but I think you are right regarding the naming)","created_at":"2018-10-25T08:31:20Z","updated_at":"2018-10-25T08:31:20Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/10231#discussion_r228079316","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/228079316"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/10231#discussion_r228079316"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231"}},"in_reply_to_id":228078388},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231","id":225133960,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTMzOTYw","html_url":"https://github.com/RIOT-OS/RIOT/pull/10231","diff_url":"https://github.com/RIOT-OS/RIOT/pull/10231.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/10231.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10231","number":10231,"state":"open","locked":false,"title":" gnrc_ipv6_ext: move ipv6_ext_rh (partly) to GNRC","user":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"### Contribution description\r\nThis moves all implementation specific parts of the `ipv6_ext_rh` module to `gnrc_ipv6_ext_rh`.\r\n\r\nIt also removes a module that isn't used after this change and doesn't contain any code (but isn't a pseudo-module for some reason).\r\n\r\n### Testing procedure\r\nTry to compile `gnrc_networking` with `USEMODULE = gnrc_rpl_srh`. It should still work.\r\n\r\nAlso (at least when run without DEBUG) `tests/gnrc_ipv6_ext` should still work without crashing (I will rework them once the integration process progressed).\r\n\r\n### Issues/PRs references\r\nAddresses parts of #10133 \r\n\r\n![PR dependencies](http://page.mi.fu-berlin.de/mlenders/ipv6_rework.svg)","created_at":"2018-10-23T18:03:42Z","updated_at":"2018-10-25T08:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85c3d2d622e7e053f7b2a8278651c5a3249cf188","assignee":{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"assignees":[{"login":"bergzand","id":5160052,"node_id":"MDQ6VXNlcjUxNjAwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cgundogan","id":739129,"node_id":"MDQ6VXNlcjczOTEyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/739129?v=4","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":86443543,"node_id":"MDU6TGFiZWw4NjQ0MzU0Mw==","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Area:%20network","name":"Area: network","color":"6600ff","default":false},{"id":127102429,"node_id":"MDU6TGFiZWwxMjcxMDI0Mjk=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Process:%20API%20change","name":"Process: API change","color":"ff9933","default":false},{"id":122032371,"node_id":"MDU6TGFiZWwxMjIwMzIzNzE=","url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Type:%20cleanup","name":"Type: cleanup","color":"ffff66","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10231/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/8fbf089d3db0ec09f134b2a9ec18882d9e7654f3","head":{"label":"miri64:gnrc_ipv6_ext/enh/move-rh-to-gnrc","ref":"gnrc_ipv6_ext/enh/move-rh-to-gnrc","sha":"8fbf089d3db0ec09f134b2a9ec18882d9e7654f3","user":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"repo":{"id":7667624,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY3NjI0","name":"RIOT","full_name":"miri64/RIOT","private":false,"owner":{"login":"miri64","id":675644,"node_id":"MDQ6VXNlcjY3NTY0NA==","avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"html_url":"https://github.com/miri64/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/miri64/RIOT","forks_url":"https://api.github.com/repos/miri64/RIOT/forks","keys_url":"https://api.github.com/repos/miri64/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miri64/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miri64/RIOT/teams","hooks_url":"https://api.github.com/repos/miri64/RIOT/hooks","issue_events_url":"https://api.github.com/repos/miri64/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/miri64/RIOT/events","assignees_url":"https://api.github.com/repos/miri64/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/miri64/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/miri64/RIOT/tags","blobs_url":"https://api.github.com/repos/miri64/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miri64/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miri64/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/miri64/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miri64/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/miri64/RIOT/languages","stargazers_url":"https://api.github.com/repos/miri64/RIOT/stargazers","contributors_url":"https://api.github.com/repos/miri64/RIOT/contributors","subscribers_url":"https://api.github.com/repos/miri64/RIOT/subscribers","subscription_url":"https://api.github.com/repos/miri64/RIOT/subscription","commits_url":"https://api.github.com/repos/miri64/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/miri64/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/miri64/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/miri64/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/miri64/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/miri64/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miri64/RIOT/merges","archive_url":"https://api.github.com/repos/miri64/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miri64/RIOT/downloads","issues_url":"https://api.github.com/repos/miri64/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/miri64/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/miri64/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/miri64/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miri64/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/miri64/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/miri64/RIOT/deployments","created_at":"2013-01-17T14:31:57Z","updated_at":"2018-10-24T17:10:45Z","pushed_at":"2018-10-25T08:21:56Z","git_url":"git://github.com/miri64/RIOT.git","ssh_url":"git@github.com:miri64/RIOT.git","clone_url":"https://github.com/miri64/RIOT.git","svn_url":"https://github.com/miri64/RIOT","homepage":"","size":58983,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"6f37f7eda7edd98741ea5596221f1a360d1a9c42","user":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcwMjQx","name":"RIOT","full_name":"RIOT-OS/RIOT","private":false,"owner":{"login":"RIOT-OS","id":3079480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzk0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-10-25T06:44:43Z","pushed_at":"2018-10-25T08:22:00Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":58909,"stargazers_count":2068,"watchers_count":2068,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1162,"mirror_url":null,"archived":false,"open_issues_count":859,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1162,"open_issues":859,"watchers":2068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/10231"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10231"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/10231/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/10231/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/8fbf089d3db0ec09f134b2a9ec18882d9e7654f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"miri64"}}