{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-tooltip/pulls/comments/183254873","pull_request_review_id":114218123,"id":183254873,"diff_hunk":"@@ -175,9 +175,8 @@ export class Handler {\n    * The handler function.\n    */\n   private handler(handler: any, event: MouseEvent, item: any, value: any) {\n-    // console.log(handler, event, item, value);\n-\n-    if (value === null) {\n+    // hide tooltip for any of these. Undefined included for backward compatibility","path":"src/index.ts","position":7,"original_position":7,"commit_id":"40528090bdffbafe7d7cce74c2c9a96695c627ec","original_commit_id":"40528090bdffbafe7d7cce74c2c9a96695c627ec","user":{"login":"domoritz","id":589034,"avatar_url":"https://avatars2.githubusercontent.com/u/589034?v=4","gravatar_id":"","url":"https://api.github.com/users/domoritz","html_url":"https://github.com/domoritz","followers_url":"https://api.github.com/users/domoritz/followers","following_url":"https://api.github.com/users/domoritz/following{/other_user}","gists_url":"https://api.github.com/users/domoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoritz/subscriptions","organizations_url":"https://api.github.com/users/domoritz/orgs","repos_url":"https://api.github.com/users/domoritz/repos","events_url":"https://api.github.com/users/domoritz/events{/privacy}","received_events_url":"https://api.github.com/users/domoritz/received_events","type":"User","site_admin":false},"body":"Can you leave the log statement in there?","created_at":"2018-04-22T23:04:26Z","updated_at":"2018-04-22T23:04:26Z","html_url":"https://github.com/vega/vega-tooltip/pull/191#discussion_r183254873","pull_request_url":"https://api.github.com/repos/vega/vega-tooltip/pulls/191","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/comments/183254873"},"html":{"href":"https://github.com/vega/vega-tooltip/pull/191#discussion_r183254873"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-tooltip/pulls/191","id":183299265,"html_url":"https://github.com/vega/vega-tooltip/pull/191","diff_url":"https://github.com/vega/vega-tooltip/pull/191.diff","patch_url":"https://github.com/vega/vega-tooltip/pull/191.patch","issue_url":"https://api.github.com/repos/vega/vega-tooltip/issues/191","number":191,"state":"open","locked":false,"title":"hide tooltip on empty string","user":{"login":"nyurik","id":1641515,"avatar_url":"https://avatars0.githubusercontent.com/u/1641515?v=4","gravatar_id":"","url":"https://api.github.com/users/nyurik","html_url":"https://github.com/nyurik","followers_url":"https://api.github.com/users/nyurik/followers","following_url":"https://api.github.com/users/nyurik/following{/other_user}","gists_url":"https://api.github.com/users/nyurik/gists{/gist_id}","starred_url":"https://api.github.com/users/nyurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyurik/subscriptions","organizations_url":"https://api.github.com/users/nyurik/orgs","repos_url":"https://api.github.com/users/nyurik/repos","events_url":"https://api.github.com/users/nyurik/events{/privacy}","received_events_url":"https://api.github.com/users/nyurik/received_events","type":"User","site_admin":false},"body":"Empty string shows an empty box, even though the expectation is that it's not shown.","created_at":"2018-04-22T22:59:15Z","updated_at":"2018-04-22T23:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06d2853756957796471f7f3599af5e44ebc64f2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sirahd","id":16433906,"avatar_url":"https://avatars3.githubusercontent.com/u/16433906?v=4","gravatar_id":"","url":"https://api.github.com/users/sirahd","html_url":"https://github.com/sirahd","followers_url":"https://api.github.com/users/sirahd/followers","following_url":"https://api.github.com/users/sirahd/following{/other_user}","gists_url":"https://api.github.com/users/sirahd/gists{/gist_id}","starred_url":"https://api.github.com/users/sirahd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirahd/subscriptions","organizations_url":"https://api.github.com/users/sirahd/orgs","repos_url":"https://api.github.com/users/sirahd/repos","events_url":"https://api.github.com/users/sirahd/events{/privacy}","received_events_url":"https://api.github.com/users/sirahd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-tooltip/pulls/191/commits","review_comments_url":"https://api.github.com/repos/vega/vega-tooltip/pulls/191/comments","review_comment_url":"https://api.github.com/repos/vega/vega-tooltip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-tooltip/issues/191/comments","statuses_url":"https://api.github.com/repos/vega/vega-tooltip/statuses/40528090bdffbafe7d7cce74c2c9a96695c627ec","head":{"label":"vega:hideonempty","ref":"hideonempty","sha":"40528090bdffbafe7d7cce74c2c9a96695c627ec","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":52128009,"name":"vega-tooltip","full_name":"vega/vega-tooltip","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-tooltip","description":"Tooltip Plugin for Vega-Lite","fork":false,"url":"https://api.github.com/repos/vega/vega-tooltip","forks_url":"https://api.github.com/repos/vega/vega-tooltip/forks","keys_url":"https://api.github.com/repos/vega/vega-tooltip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-tooltip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-tooltip/teams","hooks_url":"https://api.github.com/repos/vega/vega-tooltip/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-tooltip/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-tooltip/events","assignees_url":"https://api.github.com/repos/vega/vega-tooltip/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-tooltip/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-tooltip/tags","blobs_url":"https://api.github.com/repos/vega/vega-tooltip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-tooltip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-tooltip/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-tooltip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-tooltip/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-tooltip/languages","stargazers_url":"https://api.github.com/repos/vega/vega-tooltip/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-tooltip/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-tooltip/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-tooltip/subscription","commits_url":"https://api.github.com/repos/vega/vega-tooltip/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-tooltip/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-tooltip/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-tooltip/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-tooltip/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-tooltip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-tooltip/merges","archive_url":"https://api.github.com/repos/vega/vega-tooltip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-tooltip/downloads","issues_url":"https://api.github.com/repos/vega/vega-tooltip/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-tooltip/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-tooltip/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-tooltip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-tooltip/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-tooltip/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-tooltip/deployments","created_at":"2016-02-20T00:33:03Z","updated_at":"2018-04-22T22:21:17Z","pushed_at":"2018-04-22T22:59:16Z","git_url":"git://github.com/vega/vega-tooltip.git","ssh_url":"git@github.com:vega/vega-tooltip.git","clone_url":"https://github.com/vega/vega-tooltip.git","svn_url":"https://github.com/vega/vega-tooltip","homepage":"http://vega.github.io/vega-tooltip/","size":6537,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":12,"open_issues":3,"watchers":38,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"1cdb9c328b2eb1cf1b21666d110aa833ca126b4d","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":52128009,"name":"vega-tooltip","full_name":"vega/vega-tooltip","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-tooltip","description":"Tooltip Plugin for Vega-Lite","fork":false,"url":"https://api.github.com/repos/vega/vega-tooltip","forks_url":"https://api.github.com/repos/vega/vega-tooltip/forks","keys_url":"https://api.github.com/repos/vega/vega-tooltip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-tooltip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-tooltip/teams","hooks_url":"https://api.github.com/repos/vega/vega-tooltip/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-tooltip/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-tooltip/events","assignees_url":"https://api.github.com/repos/vega/vega-tooltip/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-tooltip/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-tooltip/tags","blobs_url":"https://api.github.com/repos/vega/vega-tooltip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-tooltip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-tooltip/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-tooltip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-tooltip/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-tooltip/languages","stargazers_url":"https://api.github.com/repos/vega/vega-tooltip/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-tooltip/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-tooltip/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-tooltip/subscription","commits_url":"https://api.github.com/repos/vega/vega-tooltip/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-tooltip/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-tooltip/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-tooltip/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-tooltip/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-tooltip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-tooltip/merges","archive_url":"https://api.github.com/repos/vega/vega-tooltip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-tooltip/downloads","issues_url":"https://api.github.com/repos/vega/vega-tooltip/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-tooltip/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-tooltip/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-tooltip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-tooltip/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-tooltip/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-tooltip/deployments","created_at":"2016-02-20T00:33:03Z","updated_at":"2018-04-22T22:21:17Z","pushed_at":"2018-04-22T22:59:16Z","git_url":"git://github.com/vega/vega-tooltip.git","ssh_url":"git@github.com:vega/vega-tooltip.git","clone_url":"https://github.com/vega/vega-tooltip.git","svn_url":"https://github.com/vega/vega-tooltip","homepage":"http://vega.github.io/vega-tooltip/","size":6537,"stargazers_count":38,"watchers_count":38,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":12,"open_issues":3,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/191"},"html":{"href":"https://github.com/vega/vega-tooltip/pull/191"},"issue":{"href":"https://api.github.com/repos/vega/vega-tooltip/issues/191"},"comments":{"href":"https://api.github.com/repos/vega/vega-tooltip/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-tooltip/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-tooltip/statuses/40528090bdffbafe7d7cce74c2c9a96695c627ec"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"domoritz"}}