{"action":"created","comment":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments/199508488","pull_request_review_id":133639618,"id":199508488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTUwODQ4OA==","diff_hunk":"@@ -73,31 +73,31 @@ public UserDetails(String name, String institute, Role role) {\n      * @return The user's full name.\n      */\n \tpublic String getName() {\n-\t\treturn name;\n+\t\treturn name.replaceAll(\"^\\\\s+|\\\\s+$\", \"\");","path":"base/uk.ac.stfc.isis.ibex.experimentdetails/src/uk/ac/stfc/isis/ibex/experimentdetails/UserDetails.java","position":5,"original_position":5,"commit_id":"c1402e5f20451c3b82ae2e664c284c24b0f6a575","original_commit_id":"c1402e5f20451c3b82ae2e664c284c24b0f6a575","user":{"login":"RichardTysonIsis","id":40176733,"node_id":"MDQ6VXNlcjQwMTc2NzMz","avatar_url":"https://avatars3.githubusercontent.com/u/40176733?v=4","gravatar_id":"","url":"https://api.github.com/users/RichardTysonIsis","html_url":"https://github.com/RichardTysonIsis","followers_url":"https://api.github.com/users/RichardTysonIsis/followers","following_url":"https://api.github.com/users/RichardTysonIsis/following{/other_user}","gists_url":"https://api.github.com/users/RichardTysonIsis/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardTysonIsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardTysonIsis/subscriptions","organizations_url":"https://api.github.com/users/RichardTysonIsis/orgs","repos_url":"https://api.github.com/users/RichardTysonIsis/repos","events_url":"https://api.github.com/users/RichardTysonIsis/events{/privacy}","received_events_url":"https://api.github.com/users/RichardTysonIsis/received_events","type":"User","site_admin":false},"body":"Ok thanks!","created_at":"2018-07-02T14:05:25Z","updated_at":"2018-07-02T14:05:26Z","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/729#discussion_r199508488","pull_request_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments/199508488"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/729#discussion_r199508488"},"pull_request":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729"}},"in_reply_to_id":199501292},"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729","id":198354222,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzU0MjIy","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/729","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/729.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/729.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/729","number":729,"state":"open","locked":false,"title":"Trimmed any leading or following whitespace from the various names.","user":{"login":"RichardTysonIsis","id":40176733,"node_id":"MDQ6VXNlcjQwMTc2NzMz","avatar_url":"https://avatars3.githubusercontent.com/u/40176733?v=4","gravatar_id":"","url":"https://api.github.com/users/RichardTysonIsis","html_url":"https://github.com/RichardTysonIsis","followers_url":"https://api.github.com/users/RichardTysonIsis/followers","following_url":"https://api.github.com/users/RichardTysonIsis/following{/other_user}","gists_url":"https://api.github.com/users/RichardTysonIsis/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardTysonIsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardTysonIsis/subscriptions","organizations_url":"https://api.github.com/users/RichardTysonIsis/orgs","repos_url":"https://api.github.com/users/RichardTysonIsis/repos","events_url":"https://api.github.com/users/RichardTysonIsis/events{/privacy}","received_events_url":"https://api.github.com/users/RichardTysonIsis/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nI trimmed any leading or following white space (tabs, spaces etc.) from the user name and institute name in the experiment team table.\r\n\r\n### Ticket\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/3305\r\n\r\n\r\n### NB:\r\nPlease notice the name of this branch starts with two Ts (TT) when trying to check it out.\r\n\r\n### Acceptance criteria\r\n\r\n- [x] Institute name and user name should be trimmed.\r\n- [x] Tabs and other white space should be trimmed.\r\n- [x] When setting a name followed by a space (e.g. \"Richard Tyson \"), the user field is not blank.\r\n\r\n### Unit tests\r\n\r\nNone required.\r\n\r\n### System tests\r\n\r\nNone required.\r\n\r\n### Documentation\r\nNone found.\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [x] Do the changes function as described and is it robust?\r\n- [x] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev)?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n\r\n","created_at":"2018-06-29T15:39:26Z","updated_at":"2018-07-02T14:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25017711b349c2b514bceb56ebbe88424774307","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/729/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/c1402e5f20451c3b82ae2e664c284c24b0f6a575","head":{"label":"ISISComputingGroup:TTicket3305_Spaces_are_not_trimmed_from_experiment_team","ref":"TTicket3305_Spaces_are_not_trimmed_from_experiment_team","sha":"c1402e5f20451c3b82ae2e664c284c24b0f6a575","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4NzY2OA==","name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-06-29T12:42:36Z","pushed_at":"2018-07-02T13:55:03Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":56259,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":2,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"f1172e058decde0b33db8fa080b6fd4cd5c8c65d","user":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4NzY2OA==","name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDE5ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/7941980?v=4","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2018-06-29T12:42:36Z","pushed_at":"2018-07-02T13:55:03Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":56259,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/729"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/729"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/729/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/729/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/c1402e5f20451c3b82ae2e664c284c24b0f6a575"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RichardTysonIsis"}}