{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/18333","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/18333/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/18333/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/18333/events","html_url":"https://github.com/ceph/ceph/pull/18333","id":265913291,"number":18333,"title":"migrate rand() to new random number library","user":{"login":"chardan","id":1643380,"avatar_url":"https://avatars3.githubusercontent.com/u/1643380?v=4","gravatar_id":"","url":"https://api.github.com/users/chardan","html_url":"https://github.com/chardan","followers_url":"https://api.github.com/users/chardan/followers","following_url":"https://api.github.com/users/chardan/following{/other_user}","gists_url":"https://api.github.com/users/chardan/gists{/gist_id}","starred_url":"https://api.github.com/users/chardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chardan/subscriptions","organizations_url":"https://api.github.com/users/chardan/orgs","repos_url":"https://api.github.com/users/chardan/repos","events_url":"https://api.github.com/users/chardan/events{/privacy}","received_events_url":"https://api.github.com/users/chardan/received_events","type":"User","site_admin":false},"labels":[{"id":199292951,"url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-10-16T20:54:37Z","updated_at":"2018-02-06T17:13:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/18333","html_url":"https://github.com/ceph/ceph/pull/18333","diff_url":"https://github.com/ceph/ceph/pull/18333.diff","patch_url":"https://github.com/ceph/ceph/pull/18333.patch"},"body":"Migrates call sites to the new random number library. Should affect any rand() calls, as well as calls to Boost random and other random number generation. Also includes enhancements to Ceph random number library to allow parametric parameters to the default calls, along with simplifications to the implementation (could make a separate PR if desired).\r\n\r\nPlease check to see if I have migrated things appropriately, there were lots of moving parts in some of these!\r\n\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/363495141","html_url":"https://github.com/ceph/ceph/pull/18333#issuecomment-363495141","issue_url":"https://api.github.com/repos/ceph/ceph/issues/18333","id":363495141,"user":{"login":"chardan","id":1643380,"avatar_url":"https://avatars3.githubusercontent.com/u/1643380?v=4","gravatar_id":"","url":"https://api.github.com/users/chardan","html_url":"https://github.com/chardan","followers_url":"https://api.github.com/users/chardan/followers","following_url":"https://api.github.com/users/chardan/following{/other_user}","gists_url":"https://api.github.com/users/chardan/gists{/gist_id}","starred_url":"https://api.github.com/users/chardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chardan/subscriptions","organizations_url":"https://api.github.com/users/chardan/orgs","repos_url":"https://api.github.com/users/chardan/repos","events_url":"https://api.github.com/users/chardan/events{/privacy}","received_events_url":"https://api.github.com/users/chardan/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T17:13:38Z","updated_at":"2018-02-06T17:13:38Z","author_association":"CONTRIBUTOR","body":"One thing I've realized I need to do here is to make a pass checking places that were using %, which creates the range [A, Z - 1) rather than [A, Z]. But feel free to scan and make general comments. Thank you!"}}
{"actor":{"display_login":"chardan"}}