{"action":"closed","number":179,"pull_request":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179","id":199896228,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODk2MjI4","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/179","diff_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/179.diff","patch_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/179.patch","issue_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/179","number":179,"state":"closed","locked":false,"title":"Accessibility review for content page ( #178 )","user":{"login":"martinfrances107","id":1259969,"node_id":"MDQ6VXNlcjEyNTk5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1259969?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfrances107","html_url":"https://github.com/martinfrances107","followers_url":"https://api.github.com/users/martinfrances107/followers","following_url":"https://api.github.com/users/martinfrances107/following{/other_user}","gists_url":"https://api.github.com/users/martinfrances107/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfrances107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfrances107/subscriptions","organizations_url":"https://api.github.com/users/martinfrances107/orgs","repos_url":"https://api.github.com/users/martinfrances107/repos","events_url":"https://api.github.com/users/martinfrances107/events{/privacy}","received_events_url":"https://api.github.com/users/martinfrances107/received_events","type":"User","site_admin":false},"body":"Accessibility review for content page ( Errors seen in Chrome's lighthouse )\r\n\r\nA) Link between Select#action and label was broken [ typo in htmlFor ]\r\n\r\nB) Made table column 2 the label for the column select element.\r\n\r\nC) Added aria-label to the buttons in the TablePagination element\r\n\r\nSee issue #178","created_at":"2018-07-07T13:04:59Z","updated_at":"2018-07-25T11:43:10Z","closed_at":"2018-07-25T11:43:10Z","merged_at":"2018-07-25T11:43:10Z","merge_commit_sha":"f1fa13f1b5655806f1e13b819749c60f39719732","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179/commits","review_comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179/comments","review_comment_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/179/comments","statuses_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/97fc6cf874f49a4835fcf8196ae57ff879b9e02e","head":{"label":"martinfrances107:minorAccessibilityReivew","ref":"minorAccessibilityReivew","sha":"97fc6cf874f49a4835fcf8196ae57ff879b9e02e","user":{"login":"martinfrances107","id":1259969,"node_id":"MDQ6VXNlcjEyNTk5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1259969?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfrances107","html_url":"https://github.com/martinfrances107","followers_url":"https://api.github.com/users/martinfrances107/followers","following_url":"https://api.github.com/users/martinfrances107/following{/other_user}","gists_url":"https://api.github.com/users/martinfrances107/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfrances107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfrances107/subscriptions","organizations_url":"https://api.github.com/users/martinfrances107/orgs","repos_url":"https://api.github.com/users/martinfrances107/repos","events_url":"https://api.github.com/users/martinfrances107/events{/privacy}","received_events_url":"https://api.github.com/users/martinfrances107/received_events","type":"User","site_admin":false},"repo":{"id":138721236,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MjEyMzY=","name":"drupal-admin-ui","full_name":"martinfrances107/drupal-admin-ui","owner":{"login":"martinfrances107","id":1259969,"node_id":"MDQ6VXNlcjEyNTk5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1259969?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfrances107","html_url":"https://github.com/martinfrances107","followers_url":"https://api.github.com/users/martinfrances107/followers","following_url":"https://api.github.com/users/martinfrances107/following{/other_user}","gists_url":"https://api.github.com/users/martinfrances107/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfrances107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfrances107/subscriptions","organizations_url":"https://api.github.com/users/martinfrances107/orgs","repos_url":"https://api.github.com/users/martinfrances107/repos","events_url":"https://api.github.com/users/martinfrances107/events{/privacy}","received_events_url":"https://api.github.com/users/martinfrances107/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinfrances107/drupal-admin-ui","description":"v fancy ⬅️✌️➡️","fork":true,"url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui","forks_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/forks","keys_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/teams","hooks_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/events","assignees_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/tags","blobs_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/languages","stargazers_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/subscription","commits_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/merges","archive_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/downloads","issues_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/martinfrances107/drupal-admin-ui/deployments","created_at":"2018-06-26T10:15:59Z","updated_at":"2018-07-24T17:04:01Z","pushed_at":"2018-07-25T10:17:17Z","git_url":"git://github.com/martinfrances107/drupal-admin-ui.git","ssh_url":"git@github.com:martinfrances107/drupal-admin-ui.git","clone_url":"https://github.com/martinfrances107/drupal-admin-ui.git","svn_url":"https://github.com/martinfrances107/drupal-admin-ui","homepage":"","size":822,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsdrupal:master","ref":"master","sha":"79e79dec44b498ed48b13b0992f79dbb4bf55ff1","user":{"login":"jsdrupal","id":34455645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/34455645?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdrupal","html_url":"https://github.com/jsdrupal","followers_url":"https://api.github.com/users/jsdrupal/followers","following_url":"https://api.github.com/users/jsdrupal/following{/other_user}","gists_url":"https://api.github.com/users/jsdrupal/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdrupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdrupal/subscriptions","organizations_url":"https://api.github.com/users/jsdrupal/orgs","repos_url":"https://api.github.com/users/jsdrupal/repos","events_url":"https://api.github.com/users/jsdrupal/events{/privacy}","received_events_url":"https://api.github.com/users/jsdrupal/received_events","type":"Organization","site_admin":false},"repo":{"id":121880923,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODA5MjM=","name":"drupal-admin-ui","full_name":"jsdrupal/drupal-admin-ui","owner":{"login":"jsdrupal","id":34455645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1NjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/34455645?v=4","gravatar_id":"","url":"https://api.github.com/users/jsdrupal","html_url":"https://github.com/jsdrupal","followers_url":"https://api.github.com/users/jsdrupal/followers","following_url":"https://api.github.com/users/jsdrupal/following{/other_user}","gists_url":"https://api.github.com/users/jsdrupal/gists{/gist_id}","starred_url":"https://api.github.com/users/jsdrupal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsdrupal/subscriptions","organizations_url":"https://api.github.com/users/jsdrupal/orgs","repos_url":"https://api.github.com/users/jsdrupal/repos","events_url":"https://api.github.com/users/jsdrupal/events{/privacy}","received_events_url":"https://api.github.com/users/jsdrupal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jsdrupal/drupal-admin-ui","description":"v fancy ⬅️✌️➡️","fork":false,"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui","forks_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/forks","keys_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/teams","hooks_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/hooks","issue_events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/events","assignees_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/tags","blobs_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/languages","stargazers_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/stargazers","contributors_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/contributors","subscribers_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/subscribers","subscription_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/subscription","commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/merges","archive_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/downloads","issues_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/labels{/name}","releases_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/releases{/id}","deployments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/deployments","created_at":"2018-02-17T18:26:58Z","updated_at":"2018-07-24T18:24:56Z","pushed_at":"2018-07-25T11:43:10Z","git_url":"git://github.com/jsdrupal/drupal-admin-ui.git","ssh_url":"git@github.com:jsdrupal/drupal-admin-ui.git","clone_url":"https://github.com/jsdrupal/drupal-admin-ui.git","svn_url":"https://github.com/jsdrupal/drupal-admin-ui","homepage":"","size":785,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":53,"license":null,"forks":32,"open_issues":53,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179"},"html":{"href":"https://github.com/jsdrupal/drupal-admin-ui/pull/179"},"issue":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/179"},"comments":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/statuses/97fc6cf874f49a4835fcf8196ae57ff879b9e02e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lauriii","id":1845495,"node_id":"MDQ6VXNlcjE4NDU0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1845495?v=4","gravatar_id":"","url":"https://api.github.com/users/lauriii","html_url":"https://github.com/lauriii","followers_url":"https://api.github.com/users/lauriii/followers","following_url":"https://api.github.com/users/lauriii/following{/other_user}","gists_url":"https://api.github.com/users/lauriii/gists{/gist_id}","starred_url":"https://api.github.com/users/lauriii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauriii/subscriptions","organizations_url":"https://api.github.com/users/lauriii/orgs","repos_url":"https://api.github.com/users/lauriii/repos","events_url":"https://api.github.com/users/lauriii/events{/privacy}","received_events_url":"https://api.github.com/users/lauriii/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":15,"additions":9,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"lauriii"}}