{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7196","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7196/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7196/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7196/events","html_url":"https://github.com/coq/coq/pull/7196","id":312266452,"number":7196,"title":"[tactics] Remove reliance of fix/cofix on the proof name.","user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"labels":[{"id":485985791,"url":"https://api.github.com/repos/coq/coq/labels/kind:%20cleanup","name":"kind: cleanup","color":"3366ff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":119,"closed_issues":35,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-04-08T03:02:27Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-04-08T03:02:27Z","updated_at":"2018-04-08T14:53:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7196","html_url":"https://github.com/coq/coq/pull/7196","diff_url":"https://github.com/coq/coq/pull/7196.diff","patch_url":"https://github.com/coq/coq/pull/7196.patch"},"body":"This yet incomplete patch removes the dependency of fix on the \"proof\"\r\ncontext; this is an experiment as this is one of the main\r\nroad-blockers to handle the state functionally in the upper layers;\r\nhowever, this will break scripts using the `fix n` form.\r\n\r\nIt is not clear how to proceed further, we have several choices:\r\n\r\n- deprecate the `fix n` form,\r\n- add naming information inside the proof monad,\r\n- thread the proof state all the way down to fix [this is bad], tho\r\n  doable by making a version of `FUNCTIONAL TACTIC EXTEND` and\r\n  adapting `coretactics:fix`.\r\n\r\nBut the deeper question here is why `proofs` is laying below `tactics`\r\nhere. In an ideal world, `proofs` would be indeed above `tactics` as\r\ntactics should not be able to jump outside the monad. The uses of\r\n`get_current_context` et al. are indeed suspicious.\r\n\r\nThe only \"right\" user is abstract, but it should be adapted to work\r\nslightly differently or even provided as a proof-aware tactic and thus\r\nmoved to `proofs`.\r\n\r\ncc: @ppedrot, @herbelin\r\n"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/379556415","html_url":"https://github.com/coq/coq/pull/7196#issuecomment-379556415","issue_url":"https://api.github.com/repos/coq/coq/issues/7196","id":379556415,"user":{"login":"ejgallego","id":7192257,"avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"created_at":"2018-04-08T14:53:47Z","updated_at":"2018-04-08T14:53:47Z","author_association":"MEMBER","body":"Anyways deprecation seems well withing range given the travis results, we are talking about a very small patch it seems."}}
{"actor":{"display_login":"ejgallego"}}