{"action":"opened","number":1792,"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792","id":209746577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzQ2NTc3","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1792","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1792.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1792.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1792","number":1792,"state":"open","locked":false,"title":"JBIDE-26309 Fixing correct class for DefaultLoginProvider in plugin.xml","user":{"login":"jkopriva","id":17871936,"node_id":"MDQ6VXNlcjE3ODcxOTM2","avatar_url":"https://avatars2.githubusercontent.com/u/17871936?v=4","gravatar_id":"","url":"https://api.github.com/users/jkopriva","html_url":"https://github.com/jkopriva","followers_url":"https://api.github.com/users/jkopriva/followers","following_url":"https://api.github.com/users/jkopriva/following{/other_user}","gists_url":"https://api.github.com/users/jkopriva/gists{/gist_id}","starred_url":"https://api.github.com/users/jkopriva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkopriva/subscriptions","organizations_url":"https://api.github.com/users/jkopriva/orgs","repos_url":"https://api.github.com/users/jkopriva/repos","events_url":"https://api.github.com/users/jkopriva/events{/privacy}","received_events_url":"https://api.github.com/users/jkopriva/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Josef Kopriva <jkopriva@redhat.com>\r\n\r\n# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n","created_at":"2018-08-21T08:30:49Z","updated_at":"2018-08-21T08:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1792/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/1b10fda829ecb1affe646e16a02aca4a2158257f","head":{"label":"jkopriva:JBIDE-26309","ref":"JBIDE-26309","sha":"1b10fda829ecb1affe646e16a02aca4a2158257f","user":{"login":"jkopriva","id":17871936,"node_id":"MDQ6VXNlcjE3ODcxOTM2","avatar_url":"https://avatars2.githubusercontent.com/u/17871936?v=4","gravatar_id":"","url":"https://api.github.com/users/jkopriva","html_url":"https://github.com/jkopriva","followers_url":"https://api.github.com/users/jkopriva/followers","following_url":"https://api.github.com/users/jkopriva/following{/other_user}","gists_url":"https://api.github.com/users/jkopriva/gists{/gist_id}","starred_url":"https://api.github.com/users/jkopriva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkopriva/subscriptions","organizations_url":"https://api.github.com/users/jkopriva/orgs","repos_url":"https://api.github.com/users/jkopriva/repos","events_url":"https://api.github.com/users/jkopriva/events{/privacy}","received_events_url":"https://api.github.com/users/jkopriva/received_events","type":"User","site_admin":false},"repo":{"id":99904422,"node_id":"MDEwOlJlcG9zaXRvcnk5OTkwNDQyMg==","name":"jbosstools-openshift","full_name":"jkopriva/jbosstools-openshift","owner":{"login":"jkopriva","id":17871936,"node_id":"MDQ6VXNlcjE3ODcxOTM2","avatar_url":"https://avatars2.githubusercontent.com/u/17871936?v=4","gravatar_id":"","url":"https://api.github.com/users/jkopriva","html_url":"https://github.com/jkopriva","followers_url":"https://api.github.com/users/jkopriva/followers","following_url":"https://api.github.com/users/jkopriva/following{/other_user}","gists_url":"https://api.github.com/users/jkopriva/gists{/gist_id}","starred_url":"https://api.github.com/users/jkopriva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkopriva/subscriptions","organizations_url":"https://api.github.com/users/jkopriva/orgs","repos_url":"https://api.github.com/users/jkopriva/repos","events_url":"https://api.github.com/users/jkopriva/events{/privacy}","received_events_url":"https://api.github.com/users/jkopriva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkopriva/jbosstools-openshift","description":"JBoss Tools :: OpenShift { openshift }","fork":true,"url":"https://api.github.com/repos/jkopriva/jbosstools-openshift","forks_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/forks","keys_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/teams","hooks_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/hooks","issue_events_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/events","assignees_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/tags","blobs_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/languages","stargazers_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/stargazers","contributors_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/contributors","subscribers_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/subscribers","subscription_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/subscription","commits_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/merges","archive_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/downloads","issues_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jkopriva/jbosstools-openshift/deployments","created_at":"2017-08-10T09:13:10Z","updated_at":"2018-08-21T08:20:55Z","pushed_at":"2018-08-21T08:26:31Z","git_url":"git://github.com/jkopriva/jbosstools-openshift.git","ssh_url":"git@github.com:jkopriva/jbosstools-openshift.git","clone_url":"https://github.com/jkopriva/jbosstools-openshift.git","svn_url":"https://github.com/jkopriva/jbosstools-openshift","homepage":"","size":20178,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"5898cbd2428ac917cbb78c19ab77f80774a99d55","user":{"login":"jbosstools","id":619871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTg3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/619871?v=4","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308288,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA4Mjg4","name":"jbosstools-openshift","full_name":"jbosstools/jbosstools-openshift","owner":{"login":"jbosstools","id":619871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTg3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/619871?v=4","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-openshift","description":"JBoss Tools :: OpenShift { openshift }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/deployments","created_at":"2012-10-20T11:23:01Z","updated_at":"2018-08-16T13:51:30Z","pushed_at":"2018-08-20T02:52:48Z","git_url":"git://github.com/jbosstools/jbosstools-openshift.git","ssh_url":"git@github.com:jbosstools/jbosstools-openshift.git","clone_url":"https://github.com/jbosstools/jbosstools-openshift.git","svn_url":"https://github.com/jbosstools/jbosstools-openshift","homepage":"","size":20073,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":56,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792"},"html":{"href":"https://github.com/jbosstools/jbosstools-openshift/pull/1792"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1792"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1792/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1792/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/1b10fda829ecb1affe646e16a02aca4a2158257f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jkopriva"}}