{"action":"created","comment":{"url":"https://api.github.com/repos/finagle/finch/pulls/comments/234835356","pull_request_review_id":176558985,"id":234835356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgzNTM1Ng==","diff_hunk":"@@ -0,0 +1,20 @@\n+package io.finch.streaming\n+\n+import com.twitter.io.{Buf, Reader}\n+\n+/**\n+  * Create stream S[F, Buf] from com.twitter.io.Reader[Buf]\n+  */\n+trait StreamFromReader[S[_[_], _], F[_]] {","path":"core/src/main/scala/io/finch/streaming/StreamFromReader.scala","position":8,"original_position":8,"commit_id":"219c0a147ac27dc2c3f59ce4a9cf3ceb97902519","original_commit_id":"219c0a147ac27dc2c3f59ce4a9cf3ceb97902519","user":{"login":"vkostyukov","id":1098539,"node_id":"MDQ6VXNlcjEwOTg1Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1098539?v=4","gravatar_id":"","url":"https://api.github.com/users/vkostyukov","html_url":"https://github.com/vkostyukov","followers_url":"https://api.github.com/users/vkostyukov/followers","following_url":"https://api.github.com/users/vkostyukov/following{/other_user}","gists_url":"https://api.github.com/users/vkostyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkostyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkostyukov/subscriptions","organizations_url":"https://api.github.com/users/vkostyukov/orgs","repos_url":"https://api.github.com/users/vkostyukov/repos","events_url":"https://api.github.com/users/vkostyukov/events{/privacy}","received_events_url":"https://api.github.com/users/vkostyukov/received_events","type":"User","site_admin":false},"body":"I'm trying to understand why we need this. Is there a reason, `StreamDecode` can't take `Reader[Buf]` as an input?","created_at":"2018-11-20T00:46:51Z","updated_at":"2018-11-20T00:54:53Z","html_url":"https://github.com/finagle/finch/pull/1042#discussion_r234835356","pull_request_url":"https://api.github.com/repos/finagle/finch/pulls/1042","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/finagle/finch/pulls/comments/234835356"},"html":{"href":"https://github.com/finagle/finch/pull/1042#discussion_r234835356"},"pull_request":{"href":"https://api.github.com/repos/finagle/finch/pulls/1042"}}},"pull_request":{"url":"https://api.github.com/repos/finagle/finch/pulls/1042","id":231800259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODAwMjU5","html_url":"https://github.com/finagle/finch/pull/1042","diff_url":"https://github.com/finagle/finch/pull/1042.diff","patch_url":"https://github.com/finagle/finch/pull/1042.patch","issue_url":"https://api.github.com/repos/finagle/finch/issues/1042","number":1042,"state":"open","locked":false,"title":"fs2 support","user":{"login":"sergeykolbasov","id":2317121,"node_id":"MDQ6VXNlcjIzMTcxMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2317121?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykolbasov","html_url":"https://github.com/sergeykolbasov","followers_url":"https://api.github.com/users/sergeykolbasov/followers","following_url":"https://api.github.com/users/sergeykolbasov/following{/other_user}","gists_url":"https://api.github.com/users/sergeykolbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykolbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykolbasov/subscriptions","organizations_url":"https://api.github.com/users/sergeykolbasov/orgs","repos_url":"https://api.github.com/users/sergeykolbasov/repos","events_url":"https://api.github.com/users/sergeykolbasov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykolbasov/received_events","type":"User","site_admin":false},"body":"Related to #1001 \r\n\r\nIdea is to have `streamBody` and `jsonStreamBody` endpoints in core, along with `StreamingLaws`, so modules like iteratee and fs2 could implement only neccessary type classes and couple of specs while the rest of machinery is done inside of the core.\r\n\r\n- [x] Refactoring\r\n- [x] fs2 module + circe instances for it","created_at":"2018-11-18T17:01:52Z","updated_at":"2018-11-20T00:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4a37b61003d088681c67d471d6ee5e63698ac25","assignee":null,"assignees":[],"requested_reviewers":[{"login":"travisbrown","id":316049,"node_id":"MDQ6VXNlcjMxNjA0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316049?v=4","gravatar_id":"","url":"https://api.github.com/users/travisbrown","html_url":"https://github.com/travisbrown","followers_url":"https://api.github.com/users/travisbrown/followers","following_url":"https://api.github.com/users/travisbrown/following{/other_user}","gists_url":"https://api.github.com/users/travisbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/travisbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisbrown/subscriptions","organizations_url":"https://api.github.com/users/travisbrown/orgs","repos_url":"https://api.github.com/users/travisbrown/repos","events_url":"https://api.github.com/users/travisbrown/events{/privacy}","received_events_url":"https://api.github.com/users/travisbrown/received_events","type":"User","site_admin":false},{"login":"rpless","id":2407674,"node_id":"MDQ6VXNlcjI0MDc2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2407674?v=4","gravatar_id":"","url":"https://api.github.com/users/rpless","html_url":"https://github.com/rpless","followers_url":"https://api.github.com/users/rpless/followers","following_url":"https://api.github.com/users/rpless/following{/other_user}","gists_url":"https://api.github.com/users/rpless/gists{/gist_id}","starred_url":"https://api.github.com/users/rpless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpless/subscriptions","organizations_url":"https://api.github.com/users/rpless/orgs","repos_url":"https://api.github.com/users/rpless/repos","events_url":"https://api.github.com/users/rpless/events{/privacy}","received_events_url":"https://api.github.com/users/rpless/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/finagle/finch/pulls/1042/commits","review_comments_url":"https://api.github.com/repos/finagle/finch/pulls/1042/comments","review_comment_url":"https://api.github.com/repos/finagle/finch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finagle/finch/issues/1042/comments","statuses_url":"https://api.github.com/repos/finagle/finch/statuses/219c0a147ac27dc2c3f59ce4a9cf3ceb97902519","head":{"label":"sergeykolbasov:fs2-support","ref":"fs2-support","sha":"219c0a147ac27dc2c3f59ce4a9cf3ceb97902519","user":{"login":"sergeykolbasov","id":2317121,"node_id":"MDQ6VXNlcjIzMTcxMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2317121?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykolbasov","html_url":"https://github.com/sergeykolbasov","followers_url":"https://api.github.com/users/sergeykolbasov/followers","following_url":"https://api.github.com/users/sergeykolbasov/following{/other_user}","gists_url":"https://api.github.com/users/sergeykolbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykolbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykolbasov/subscriptions","organizations_url":"https://api.github.com/users/sergeykolbasov/orgs","repos_url":"https://api.github.com/users/sergeykolbasov/repos","events_url":"https://api.github.com/users/sergeykolbasov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykolbasov/received_events","type":"User","site_admin":false},"repo":{"id":32941298,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk0MTI5OA==","name":"finch","full_name":"sergeykolbasov/finch","private":false,"owner":{"login":"sergeykolbasov","id":2317121,"node_id":"MDQ6VXNlcjIzMTcxMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/2317121?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeykolbasov","html_url":"https://github.com/sergeykolbasov","followers_url":"https://api.github.com/users/sergeykolbasov/followers","following_url":"https://api.github.com/users/sergeykolbasov/following{/other_user}","gists_url":"https://api.github.com/users/sergeykolbasov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeykolbasov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeykolbasov/subscriptions","organizations_url":"https://api.github.com/users/sergeykolbasov/orgs","repos_url":"https://api.github.com/users/sergeykolbasov/repos","events_url":"https://api.github.com/users/sergeykolbasov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeykolbasov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sergeykolbasov/finch","description":"Your REST API as a Monad","fork":true,"url":"https://api.github.com/repos/sergeykolbasov/finch","forks_url":"https://api.github.com/repos/sergeykolbasov/finch/forks","keys_url":"https://api.github.com/repos/sergeykolbasov/finch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergeykolbasov/finch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergeykolbasov/finch/teams","hooks_url":"https://api.github.com/repos/sergeykolbasov/finch/hooks","issue_events_url":"https://api.github.com/repos/sergeykolbasov/finch/issues/events{/number}","events_url":"https://api.github.com/repos/sergeykolbasov/finch/events","assignees_url":"https://api.github.com/repos/sergeykolbasov/finch/assignees{/user}","branches_url":"https://api.github.com/repos/sergeykolbasov/finch/branches{/branch}","tags_url":"https://api.github.com/repos/sergeykolbasov/finch/tags","blobs_url":"https://api.github.com/repos/sergeykolbasov/finch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergeykolbasov/finch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergeykolbasov/finch/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergeykolbasov/finch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergeykolbasov/finch/statuses/{sha}","languages_url":"https://api.github.com/repos/sergeykolbasov/finch/languages","stargazers_url":"https://api.github.com/repos/sergeykolbasov/finch/stargazers","contributors_url":"https://api.github.com/repos/sergeykolbasov/finch/contributors","subscribers_url":"https://api.github.com/repos/sergeykolbasov/finch/subscribers","subscription_url":"https://api.github.com/repos/sergeykolbasov/finch/subscription","commits_url":"https://api.github.com/repos/sergeykolbasov/finch/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergeykolbasov/finch/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergeykolbasov/finch/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergeykolbasov/finch/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergeykolbasov/finch/contents/{+path}","compare_url":"https://api.github.com/repos/sergeykolbasov/finch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergeykolbasov/finch/merges","archive_url":"https://api.github.com/repos/sergeykolbasov/finch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergeykolbasov/finch/downloads","issues_url":"https://api.github.com/repos/sergeykolbasov/finch/issues{/number}","pulls_url":"https://api.github.com/repos/sergeykolbasov/finch/pulls{/number}","milestones_url":"https://api.github.com/repos/sergeykolbasov/finch/milestones{/number}","notifications_url":"https://api.github.com/repos/sergeykolbasov/finch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergeykolbasov/finch/labels{/name}","releases_url":"https://api.github.com/repos/sergeykolbasov/finch/releases{/id}","deployments_url":"https://api.github.com/repos/sergeykolbasov/finch/deployments","created_at":"2015-03-26T17:12:56Z","updated_at":"2018-11-17T10:27:50Z","pushed_at":"2018-11-19T22:29:56Z","git_url":"git://github.com/sergeykolbasov/finch.git","ssh_url":"git@github.com:sergeykolbasov/finch.git","clone_url":"https://github.com/sergeykolbasov/finch.git","svn_url":"https://github.com/sergeykolbasov/finch","homepage":"http://finagle.github.io/finch/docs/","size":4111,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"finagle:master","ref":"master","sha":"3d2849b29d79b0b290302a8fd206e57bed588917","user":{"login":"finagle","id":7944306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDQzMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7944306?v=4","gravatar_id":"","url":"https://api.github.com/users/finagle","html_url":"https://github.com/finagle","followers_url":"https://api.github.com/users/finagle/followers","following_url":"https://api.github.com/users/finagle/following{/other_user}","gists_url":"https://api.github.com/users/finagle/gists{/gist_id}","starred_url":"https://api.github.com/users/finagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finagle/subscriptions","organizations_url":"https://api.github.com/users/finagle/orgs","repos_url":"https://api.github.com/users/finagle/repos","events_url":"https://api.github.com/users/finagle/events{/privacy}","received_events_url":"https://api.github.com/users/finagle/received_events","type":"Organization","site_admin":false},"repo":{"id":18798826,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5ODgyNg==","name":"finch","full_name":"finagle/finch","private":false,"owner":{"login":"finagle","id":7944306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5NDQzMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7944306?v=4","gravatar_id":"","url":"https://api.github.com/users/finagle","html_url":"https://github.com/finagle","followers_url":"https://api.github.com/users/finagle/followers","following_url":"https://api.github.com/users/finagle/following{/other_user}","gists_url":"https://api.github.com/users/finagle/gists{/gist_id}","starred_url":"https://api.github.com/users/finagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finagle/subscriptions","organizations_url":"https://api.github.com/users/finagle/orgs","repos_url":"https://api.github.com/users/finagle/repos","events_url":"https://api.github.com/users/finagle/events{/privacy}","received_events_url":"https://api.github.com/users/finagle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/finagle/finch","description":"Scala combinator library for building Finagle HTTP services","fork":false,"url":"https://api.github.com/repos/finagle/finch","forks_url":"https://api.github.com/repos/finagle/finch/forks","keys_url":"https://api.github.com/repos/finagle/finch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finagle/finch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finagle/finch/teams","hooks_url":"https://api.github.com/repos/finagle/finch/hooks","issue_events_url":"https://api.github.com/repos/finagle/finch/issues/events{/number}","events_url":"https://api.github.com/repos/finagle/finch/events","assignees_url":"https://api.github.com/repos/finagle/finch/assignees{/user}","branches_url":"https://api.github.com/repos/finagle/finch/branches{/branch}","tags_url":"https://api.github.com/repos/finagle/finch/tags","blobs_url":"https://api.github.com/repos/finagle/finch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finagle/finch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finagle/finch/git/refs{/sha}","trees_url":"https://api.github.com/repos/finagle/finch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finagle/finch/statuses/{sha}","languages_url":"https://api.github.com/repos/finagle/finch/languages","stargazers_url":"https://api.github.com/repos/finagle/finch/stargazers","contributors_url":"https://api.github.com/repos/finagle/finch/contributors","subscribers_url":"https://api.github.com/repos/finagle/finch/subscribers","subscription_url":"https://api.github.com/repos/finagle/finch/subscription","commits_url":"https://api.github.com/repos/finagle/finch/commits{/sha}","git_commits_url":"https://api.github.com/repos/finagle/finch/git/commits{/sha}","comments_url":"https://api.github.com/repos/finagle/finch/comments{/number}","issue_comment_url":"https://api.github.com/repos/finagle/finch/issues/comments{/number}","contents_url":"https://api.github.com/repos/finagle/finch/contents/{+path}","compare_url":"https://api.github.com/repos/finagle/finch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finagle/finch/merges","archive_url":"https://api.github.com/repos/finagle/finch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finagle/finch/downloads","issues_url":"https://api.github.com/repos/finagle/finch/issues{/number}","pulls_url":"https://api.github.com/repos/finagle/finch/pulls{/number}","milestones_url":"https://api.github.com/repos/finagle/finch/milestones{/number}","notifications_url":"https://api.github.com/repos/finagle/finch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finagle/finch/labels{/name}","releases_url":"https://api.github.com/repos/finagle/finch/releases{/id}","deployments_url":"https://api.github.com/repos/finagle/finch/deployments","created_at":"2014-04-15T12:17:44Z","updated_at":"2018-11-19T21:46:12Z","pushed_at":"2018-11-20T00:22:16Z","git_url":"git://github.com/finagle/finch.git","ssh_url":"git@github.com:finagle/finch.git","clone_url":"https://github.com/finagle/finch.git","svn_url":"https://github.com/finagle/finch","homepage":"https://finagle.github.io/finch","size":8298,"stargazers_count":1286,"watchers_count":1286,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":197,"open_issues":41,"watchers":1286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finagle/finch/pulls/1042"},"html":{"href":"https://github.com/finagle/finch/pull/1042"},"issue":{"href":"https://api.github.com/repos/finagle/finch/issues/1042"},"comments":{"href":"https://api.github.com/repos/finagle/finch/issues/1042/comments"},"review_comments":{"href":"https://api.github.com/repos/finagle/finch/pulls/1042/comments"},"review_comment":{"href":"https://api.github.com/repos/finagle/finch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finagle/finch/pulls/1042/commits"},"statuses":{"href":"https://api.github.com/repos/finagle/finch/statuses/219c0a147ac27dc2c3f59ce4a9cf3ceb97902519"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vkostyukov"}}