{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/1688","repository_url":"https://api.github.com/repos/ethereum-mining/ethminer","labels_url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/1688/labels{/name}","comments_url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/1688/comments","events_url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/1688/events","html_url":"https://github.com/ethereum-mining/ethminer/issues/1688","id":382003319,"node_id":"MDU6SXNzdWUzODIwMDMzMTk=","number":1688,"title":"Mail parameter passing is broken in previous commit","user":{"login":"pZFi","id":45151813,"node_id":"MDQ6VXNlcjQ1MTUxODEz","avatar_url":"https://avatars0.githubusercontent.com/u/45151813?v=4","gravatar_id":"","url":"https://api.github.com/users/pZFi","html_url":"https://github.com/pZFi","followers_url":"https://api.github.com/users/pZFi/followers","following_url":"https://api.github.com/users/pZFi/following{/other_user}","gists_url":"https://api.github.com/users/pZFi/gists{/gist_id}","starred_url":"https://api.github.com/users/pZFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pZFi/subscriptions","organizations_url":"https://api.github.com/users/pZFi/orgs","repos_url":"https://api.github.com/users/pZFi/repos","events_url":"https://api.github.com/users/pZFi/events{/privacy}","received_events_url":"https://api.github.com/users/pZFi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-18T21:41:13Z","updated_at":"2018-11-18T22:08:14Z","closed_at":null,"author_association":"NONE","body":"Ethminer later  then 0.15.0 stopped working with ubiqpool.io.\r\n\r\nIt was launched with:\r\n`./ethminer -R -U -P stratum1+tcp://0xAddress.Miner@eu1.ubiqpool.io:8008 ... --stratum-email mail@domain.com`\r\n After commit 4021a9948e3eefc70b1794e8c96bfbf1ba0b889e for #1477 code was removed:\r\n`        if (!m_email.empty())\r\n            jReq[\"params\"].append(m_email);`\r\nThat broke everything.\r\nIn versions after that commit parameter is unsupported: `The following argument was not expected: --stratum-email`.\r\n\r\nIf you try to use it in \"new modern way\" like:\r\n`    Example 2:    stratum://0x012345678901234567890234567890123.miner1@nanopool.org:9999/john.doe@gmail.com`\r\n`    Example 3:    stratum://0x012345678901234567890234567890123@nanopool.org:9999/miner1/john.doe@gmail.com`\r\n\"Very intellectual\" autodetection algorithm goes the wrong way in case selector and decides that it's for ETHPROXY (WTF???):\r\n`    switch (m_conn->StratumMode())\r\n    {\r\n    case EthStratumClient::STRATUM:\r\n\r\n        jReq[\"jsonrpc\"] = \"2.0\";\r\n\r\n        break;\r\n\r\n    case EthStratumClient::ETHPROXY:\r\n\r\n        jReq[\"method\"] = \"eth_submitLogin\";\r\n        if (m_worker.length())\r\n            jReq[\"worker\"] = m_worker;\r\n        jReq[\"params\"].append(m_user + m_conn->Path());\r\n\r\n        break;\r\n\r\n    case EthStratumClient::ETHEREUMSTRATUM:\r\n\r\n        jReq[\"params\"].append(ethminer_get_buildinfo()->project_name_with_version);\r\n        jReq[\"params\"].append(\"EthereumStratum/1.0.0\");\r\n\r\n        break;\r\n    }`\r\n\r\nThat results in wrong login:\r\n`2018-11-18 02-33-51 -  m 02:33:51 ethminer ethminer 0.16.1`\r\n`2018-11-18 02-33-51 -  m 02:33:51 ethminer Build: linux/release`\r\n`2018-11-18 02-33-51 - cu 02:33:51 ethminer Using grid size: 8�192, block size: 128`\r\n`2018-11-18 02-33-52 -  i 02:33:52 ethminer Configured pool eu2.ubiqpool.io:8008`\r\n`2018-11-18 02-33-52 -  i 02:33:52 main     Selected pool eu2.ubiqpool.io:8008`\r\n`2018-11-18 02-33-52 -  i 02:33:52 stratum  Stratum mode detected: ETHPROXY Compatible`\r\n`2018-11-18 02-33-52 -  i 02:33:52 stratum  Could not login:code:-1 message:Invalid login `\r\n`2018-11-18 02-33-52 -  i 02:33:52 main     Disconnected from  [104.238.171.4:8008]`\r\n`2018-11-18 02-33-53 -  i 02:33:53 main     No more connections to try. Exiting...`\r\n`2018-11-18 02-33-54 -  i 02:33:54 ethminer Terminated!`\r\n\r\nPlease return `--stratum-email` argument and passing E-Mail in parameters part of JSON:\r\n`        if (!m_email.empty())\r\n            jReq[\"params\"].append(m_email);`\r\n\r\nP.S. In my way it's pretty shitty to drop legacy feature support for some magic algorithms that always work in unexpected way."},"comment":{"url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/comments/439730197","html_url":"https://github.com/ethereum-mining/ethminer/issues/1688#issuecomment-439730197","issue_url":"https://api.github.com/repos/ethereum-mining/ethminer/issues/1688","id":439730197,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTczMDE5Nw==","user":{"login":"AndreaLanfranchi","id":15280851,"node_id":"MDQ6VXNlcjE1MjgwODUx","avatar_url":"https://avatars0.githubusercontent.com/u/15280851?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreaLanfranchi","html_url":"https://github.com/AndreaLanfranchi","followers_url":"https://api.github.com/users/AndreaLanfranchi/followers","following_url":"https://api.github.com/users/AndreaLanfranchi/following{/other_user}","gists_url":"https://api.github.com/users/AndreaLanfranchi/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaLanfranchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaLanfranchi/subscriptions","organizations_url":"https://api.github.com/users/AndreaLanfranchi/orgs","repos_url":"https://api.github.com/users/AndreaLanfranchi/repos","events_url":"https://api.github.com/users/AndreaLanfranchi/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaLanfranchi/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T22:08:14Z","updated_at":"2018-11-18T22:08:14Z","author_association":"COLLABORATOR","body":"You can easily bypass auto detection.\r\nRtfm"}}
{"actor":{"display_login":"AndreaLanfranchi"}}