{"action":"created","comment":{"url":"https://api.github.com/repos/i-machine-think/machine/pulls/comments/235104376","pull_request_review_id":176894099,"id":235104376,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTEwNDM3Ng==","diff_hunk":"@@ -0,0 +1,49 @@\n+import torch.nn as nn\n+import torch.nn.functional as F\n+\n+class Model(nn.Module):\n+    \"\"\" \n+    Abstract base class for models.\n+\n+    Args:\n+        encoder_module (baseRNN) :  module that encodes inputs\n+        decoder_module (baseRNN, optional):   module to decode encoded inputs","path":"machine/models/baseModel.py","position":10,"original_position":10,"commit_id":"2c365e3e61931f2a7969784334522e9fe9787307","original_commit_id":"6cc9aebf98702ec6366948ec01927dad2691fa63","user":{"login":"YannDubs","id":24327668,"node_id":"MDQ6VXNlcjI0MzI3NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/24327668?v=4","gravatar_id":"","url":"https://api.github.com/users/YannDubs","html_url":"https://github.com/YannDubs","followers_url":"https://api.github.com/users/YannDubs/followers","following_url":"https://api.github.com/users/YannDubs/following{/other_user}","gists_url":"https://api.github.com/users/YannDubs/gists{/gist_id}","starred_url":"https://api.github.com/users/YannDubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannDubs/subscriptions","organizations_url":"https://api.github.com/users/YannDubs/orgs","repos_url":"https://api.github.com/users/YannDubs/repos","events_url":"https://api.github.com/users/YannDubs/events{/privacy}","received_events_url":"https://api.github.com/users/YannDubs/received_events","type":"User","site_admin":false},"body":"Agreed","created_at":"2018-11-20T17:44:40Z","updated_at":"2018-11-20T17:44:41Z","html_url":"https://github.com/i-machine-think/machine/pull/49#discussion_r235104376","pull_request_url":"https://api.github.com/repos/i-machine-think/machine/pulls/49","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/comments/235104376"},"html":{"href":"https://github.com/i-machine-think/machine/pull/49#discussion_r235104376"},"pull_request":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/49"}},"in_reply_to_id":235082902},"pull_request":{"url":"https://api.github.com/repos/i-machine-think/machine/pulls/49","id":232283903,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjgzOTAz","html_url":"https://github.com/i-machine-think/machine/pull/49","diff_url":"https://github.com/i-machine-think/machine/pull/49.diff","patch_url":"https://github.com/i-machine-think/machine/pull/49.patch","issue_url":"https://api.github.com/repos/i-machine-think/machine/issues/49","number":49,"state":"open","locked":false,"title":"Basemodel","user":{"login":"dieuwkehupkes","id":2862560,"node_id":"MDQ6VXNlcjI4NjI1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2862560?v=4","gravatar_id":"","url":"https://api.github.com/users/dieuwkehupkes","html_url":"https://github.com/dieuwkehupkes","followers_url":"https://api.github.com/users/dieuwkehupkes/followers","following_url":"https://api.github.com/users/dieuwkehupkes/following{/other_user}","gists_url":"https://api.github.com/users/dieuwkehupkes/gists{/gist_id}","starred_url":"https://api.github.com/users/dieuwkehupkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dieuwkehupkes/subscriptions","organizations_url":"https://api.github.com/users/dieuwkehupkes/orgs","repos_url":"https://api.github.com/users/dieuwkehupkes/repos","events_url":"https://api.github.com/users/dieuwkehupkes/events{/privacy}","received_events_url":"https://api.github.com/users/dieuwkehupkes/received_events","type":"User","site_admin":false},"body":"Add a basemodel class from which seq2seq inherits, and a shell language model class.\r\nCurrently the basemodel class just defines a model should have some module to encode inputs and a module or function that decodes them. The decoder module can be empty, allowing also to implement language models.","created_at":"2018-11-20T11:32:52Z","updated_at":"2018-11-20T17:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"768d2f3c9cf8c187568c448be3f874f2a7e487e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/i-machine-think/machine/pulls/49/commits","review_comments_url":"https://api.github.com/repos/i-machine-think/machine/pulls/49/comments","review_comment_url":"https://api.github.com/repos/i-machine-think/machine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/i-machine-think/machine/issues/49/comments","statuses_url":"https://api.github.com/repos/i-machine-think/machine/statuses/2c365e3e61931f2a7969784334522e9fe9787307","head":{"label":"i-machine-think:basemodel","ref":"basemodel","sha":"2c365e3e61931f2a7969784334522e9fe9787307","user":{"login":"i-machine-think","id":33779726,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc5NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/33779726?v=4","gravatar_id":"","url":"https://api.github.com/users/i-machine-think","html_url":"https://github.com/i-machine-think","followers_url":"https://api.github.com/users/i-machine-think/followers","following_url":"https://api.github.com/users/i-machine-think/following{/other_user}","gists_url":"https://api.github.com/users/i-machine-think/gists{/gist_id}","starred_url":"https://api.github.com/users/i-machine-think/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-machine-think/subscriptions","organizations_url":"https://api.github.com/users/i-machine-think/orgs","repos_url":"https://api.github.com/users/i-machine-think/repos","events_url":"https://api.github.com/users/i-machine-think/events{/privacy}","received_events_url":"https://api.github.com/users/i-machine-think/received_events","type":"Organization","site_admin":false},"repo":{"id":111230646,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyMzA2NDY=","name":"machine","full_name":"i-machine-think/machine","private":false,"owner":{"login":"i-machine-think","id":33779726,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc5NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/33779726?v=4","gravatar_id":"","url":"https://api.github.com/users/i-machine-think","html_url":"https://github.com/i-machine-think","followers_url":"https://api.github.com/users/i-machine-think/followers","following_url":"https://api.github.com/users/i-machine-think/following{/other_user}","gists_url":"https://api.github.com/users/i-machine-think/gists{/gist_id}","starred_url":"https://api.github.com/users/i-machine-think/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-machine-think/subscriptions","organizations_url":"https://api.github.com/users/i-machine-think/orgs","repos_url":"https://api.github.com/users/i-machine-think/repos","events_url":"https://api.github.com/users/i-machine-think/events{/privacy}","received_events_url":"https://api.github.com/users/i-machine-think/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/i-machine-think/machine","description":"Codebase for the i-machine-think project, a modular and fully tested Pytorch implementation for seq2seq models.","fork":false,"url":"https://api.github.com/repos/i-machine-think/machine","forks_url":"https://api.github.com/repos/i-machine-think/machine/forks","keys_url":"https://api.github.com/repos/i-machine-think/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i-machine-think/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i-machine-think/machine/teams","hooks_url":"https://api.github.com/repos/i-machine-think/machine/hooks","issue_events_url":"https://api.github.com/repos/i-machine-think/machine/issues/events{/number}","events_url":"https://api.github.com/repos/i-machine-think/machine/events","assignees_url":"https://api.github.com/repos/i-machine-think/machine/assignees{/user}","branches_url":"https://api.github.com/repos/i-machine-think/machine/branches{/branch}","tags_url":"https://api.github.com/repos/i-machine-think/machine/tags","blobs_url":"https://api.github.com/repos/i-machine-think/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i-machine-think/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i-machine-think/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/i-machine-think/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i-machine-think/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/i-machine-think/machine/languages","stargazers_url":"https://api.github.com/repos/i-machine-think/machine/stargazers","contributors_url":"https://api.github.com/repos/i-machine-think/machine/contributors","subscribers_url":"https://api.github.com/repos/i-machine-think/machine/subscribers","subscription_url":"https://api.github.com/repos/i-machine-think/machine/subscription","commits_url":"https://api.github.com/repos/i-machine-think/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/i-machine-think/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/i-machine-think/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/i-machine-think/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/i-machine-think/machine/contents/{+path}","compare_url":"https://api.github.com/repos/i-machine-think/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i-machine-think/machine/merges","archive_url":"https://api.github.com/repos/i-machine-think/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i-machine-think/machine/downloads","issues_url":"https://api.github.com/repos/i-machine-think/machine/issues{/number}","pulls_url":"https://api.github.com/repos/i-machine-think/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/i-machine-think/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/i-machine-think/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i-machine-think/machine/labels{/name}","releases_url":"https://api.github.com/repos/i-machine-think/machine/releases{/id}","deployments_url":"https://api.github.com/repos/i-machine-think/machine/deployments","created_at":"2017-11-18T18:52:37Z","updated_at":"2018-11-20T10:35:23Z","pushed_at":"2018-11-20T17:27:22Z","git_url":"git://github.com/i-machine-think/machine.git","ssh_url":"git@github.com:i-machine-think/machine.git","clone_url":"https://github.com/i-machine-think/machine.git","svn_url":"https://github.com/i-machine-think/machine","homepage":"","size":35233,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":17,"open_issues":6,"watchers":7,"default_branch":"master"}},"base":{"label":"i-machine-think:master","ref":"master","sha":"9ceb13ea26fd3484262a9e7438edf5e7f9c2b650","user":{"login":"i-machine-think","id":33779726,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc5NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/33779726?v=4","gravatar_id":"","url":"https://api.github.com/users/i-machine-think","html_url":"https://github.com/i-machine-think","followers_url":"https://api.github.com/users/i-machine-think/followers","following_url":"https://api.github.com/users/i-machine-think/following{/other_user}","gists_url":"https://api.github.com/users/i-machine-think/gists{/gist_id}","starred_url":"https://api.github.com/users/i-machine-think/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-machine-think/subscriptions","organizations_url":"https://api.github.com/users/i-machine-think/orgs","repos_url":"https://api.github.com/users/i-machine-think/repos","events_url":"https://api.github.com/users/i-machine-think/events{/privacy}","received_events_url":"https://api.github.com/users/i-machine-think/received_events","type":"Organization","site_admin":false},"repo":{"id":111230646,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyMzA2NDY=","name":"machine","full_name":"i-machine-think/machine","private":false,"owner":{"login":"i-machine-think","id":33779726,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzc5NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/33779726?v=4","gravatar_id":"","url":"https://api.github.com/users/i-machine-think","html_url":"https://github.com/i-machine-think","followers_url":"https://api.github.com/users/i-machine-think/followers","following_url":"https://api.github.com/users/i-machine-think/following{/other_user}","gists_url":"https://api.github.com/users/i-machine-think/gists{/gist_id}","starred_url":"https://api.github.com/users/i-machine-think/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-machine-think/subscriptions","organizations_url":"https://api.github.com/users/i-machine-think/orgs","repos_url":"https://api.github.com/users/i-machine-think/repos","events_url":"https://api.github.com/users/i-machine-think/events{/privacy}","received_events_url":"https://api.github.com/users/i-machine-think/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/i-machine-think/machine","description":"Codebase for the i-machine-think project, a modular and fully tested Pytorch implementation for seq2seq models.","fork":false,"url":"https://api.github.com/repos/i-machine-think/machine","forks_url":"https://api.github.com/repos/i-machine-think/machine/forks","keys_url":"https://api.github.com/repos/i-machine-think/machine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i-machine-think/machine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i-machine-think/machine/teams","hooks_url":"https://api.github.com/repos/i-machine-think/machine/hooks","issue_events_url":"https://api.github.com/repos/i-machine-think/machine/issues/events{/number}","events_url":"https://api.github.com/repos/i-machine-think/machine/events","assignees_url":"https://api.github.com/repos/i-machine-think/machine/assignees{/user}","branches_url":"https://api.github.com/repos/i-machine-think/machine/branches{/branch}","tags_url":"https://api.github.com/repos/i-machine-think/machine/tags","blobs_url":"https://api.github.com/repos/i-machine-think/machine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i-machine-think/machine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i-machine-think/machine/git/refs{/sha}","trees_url":"https://api.github.com/repos/i-machine-think/machine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i-machine-think/machine/statuses/{sha}","languages_url":"https://api.github.com/repos/i-machine-think/machine/languages","stargazers_url":"https://api.github.com/repos/i-machine-think/machine/stargazers","contributors_url":"https://api.github.com/repos/i-machine-think/machine/contributors","subscribers_url":"https://api.github.com/repos/i-machine-think/machine/subscribers","subscription_url":"https://api.github.com/repos/i-machine-think/machine/subscription","commits_url":"https://api.github.com/repos/i-machine-think/machine/commits{/sha}","git_commits_url":"https://api.github.com/repos/i-machine-think/machine/git/commits{/sha}","comments_url":"https://api.github.com/repos/i-machine-think/machine/comments{/number}","issue_comment_url":"https://api.github.com/repos/i-machine-think/machine/issues/comments{/number}","contents_url":"https://api.github.com/repos/i-machine-think/machine/contents/{+path}","compare_url":"https://api.github.com/repos/i-machine-think/machine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i-machine-think/machine/merges","archive_url":"https://api.github.com/repos/i-machine-think/machine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i-machine-think/machine/downloads","issues_url":"https://api.github.com/repos/i-machine-think/machine/issues{/number}","pulls_url":"https://api.github.com/repos/i-machine-think/machine/pulls{/number}","milestones_url":"https://api.github.com/repos/i-machine-think/machine/milestones{/number}","notifications_url":"https://api.github.com/repos/i-machine-think/machine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i-machine-think/machine/labels{/name}","releases_url":"https://api.github.com/repos/i-machine-think/machine/releases{/id}","deployments_url":"https://api.github.com/repos/i-machine-think/machine/deployments","created_at":"2017-11-18T18:52:37Z","updated_at":"2018-11-20T10:35:23Z","pushed_at":"2018-11-20T17:27:22Z","git_url":"git://github.com/i-machine-think/machine.git","ssh_url":"git@github.com:i-machine-think/machine.git","clone_url":"https://github.com/i-machine-think/machine.git","svn_url":"https://github.com/i-machine-think/machine","homepage":"","size":35233,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":17,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/49"},"html":{"href":"https://github.com/i-machine-think/machine/pull/49"},"issue":{"href":"https://api.github.com/repos/i-machine-think/machine/issues/49"},"comments":{"href":"https://api.github.com/repos/i-machine-think/machine/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/i-machine-think/machine/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/i-machine-think/machine/statuses/2c365e3e61931f2a7969784334522e9fe9787307"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"YannDubs"}}