{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/208228097","pull_request_review_id":143992130,"id":208228097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODIyODA5Nw==","diff_hunk":"@@ -51,21 +55,21 @@ protected function getOptions()\n \t\t}\n \n \t\t// Get a list of files in the search path with the given filter.\n-\t\t$files = \\JFolder::files(JPATH_INSTALLATION . '/sql/' . $type, '^sample.*\\.sql$');\n+\t\t$files = Folder::files(JPATH_INSTALLATION . '/sql/' . $type, '^sample.*\\.sql$');\n \n \t\t// Add option to not install sample data.\n-\t\t$options[] = \\JHtml::_('select.option', '',\n-\t\t\t\\JHtml::_('tooltip', \\JText::_('INSTL_SITE_INSTALL_SAMPLE_NONE_DESC'), '', '', \\JText::_('JNO'))\n+\t\t$options[] = HTMLHelper::_('select.option', '',\n+\t\t\tHTMLHelper::_('tooltip', Text::_('INSTL_SITE_INSTALL_SAMPLE_NONE_DESC'), '', '', Text::_('JNO'))\n \t\t);\n \n \t\t// Build the options list from the list of files.\n \t\tif (is_array($files))\n \t\t{\n \t\t\tforeach ($files as $file)\n \t\t\t{\n-\t\t\t\t$options[] = \\JHtml::_('select.option', $file, Factory::getLanguage()->hasKey($key = 'INSTL_' . ($file = \\JFile::stripExt($file)) . '_SET') ?\n-\t\t\t\t\t\\JHtml::_('tooltip', \\JText::_('INSTL_' . strtoupper($file = \\JFile::stripExt($file)) . '_SET_DESC'), '', '',\n-\t\t\t\t\t\t\\JText::_('JYES')\n+\t\t\t\t$options[] = HTMLHelper::_('select.option', $file, Factory::getLanguage()->hasKey($key = 'INSTL_' . ($file = File::stripExt($file)) . '_SET') ?\n+\t\t\t\t\tHTMLHelper::_('tooltip', Text::_('INSTL_' . strtoupper($file = File::stripExt($file)) . '_SET_DESC'), '', '',","path":"installation/src/Form/Field/Installation/SampleField.php","position":34,"original_position":34,"commit_id":"db4c4efcede61fb6e5f189076ff7af7cb64adf00","original_commit_id":"db4c4efcede61fb6e5f189076ff7af7cb64adf00","user":{"login":"dgrammatiko","id":3889375,"node_id":"MDQ6VXNlcjM4ODkzNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/3889375?v=4","gravatar_id":"","url":"https://api.github.com/users/dgrammatiko","html_url":"https://github.com/dgrammatiko","followers_url":"https://api.github.com/users/dgrammatiko/followers","following_url":"https://api.github.com/users/dgrammatiko/following{/other_user}","gists_url":"https://api.github.com/users/dgrammatiko/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrammatiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrammatiko/subscriptions","organizations_url":"https://api.github.com/users/dgrammatiko/orgs","repos_url":"https://api.github.com/users/dgrammatiko/repos","events_url":"https://api.github.com/users/dgrammatiko/events{/privacy}","received_events_url":"https://api.github.com/users/dgrammatiko/received_events","type":"User","site_admin":false},"body":"There are no tooltips in the installation, neither I think there will ever be a need for tooltips if everything is self-explanatory ","created_at":"2018-08-07T13:25:06Z","updated_at":"2018-08-07T13:25:06Z","html_url":"https://github.com/joomla/joomla-cms/pull/21447#discussion_r208228097","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/208228097"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/21447#discussion_r208228097"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447","id":206691842,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjkxODQy","html_url":"https://github.com/joomla/joomla-cms/pull/21447","diff_url":"https://github.com/joomla/joomla-cms/pull/21447.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/21447.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21447","number":21447,"state":"open","locked":false,"title":"[4.0] Installer review","user":{"login":"brianteeman","id":1296369,"node_id":"MDQ6VXNlcjEyOTYzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"body":"Fixes lots of small things - shouldn't really be in a single PR but otherwise it would be merge conflict hell\r\n\r\n- [a11y] Joomla logo is a decorative image only so should not have an alt description\r\n- Remove duplicate system-message-container div - important so we have unique id\r\n- fontawesome is include in the template.css by the sccs - no need to load it again\r\n- update code comment it is super user not super admin etc\r\n- use quote and quotename not q and qn\r\n- namespace - JText\r\n- Namespace JHtml\r\n- [a11y] Help Docs link - add a link to the docs site and meaningful text for screenreaders to the \"lightbulb\"\r\n- [a11y] Add h1 to the page\r\n- [a11y] change section role=main to just < main >\r\n- You can not use a custom element to display the noscript message - obviously that's not going to work because the custom element is javascript - inception\r\n- [a11y] Move message about installing languages to be a caption \r\n- [a11y] add scope to languages table\r\n- [a11y] contrast on language version number\r\n- [a11y] Section headings not nested correctly h1->h3 now h1->h2\r\n- Namespace JFile\r\n- Namespace Jfolder\r\n- target blank on mysql8 link to docs\r\n- [a11y] footer link color and hover fixes #21359\r\n- Validate name of database fixes #15583\r\n- remove all references to switcher - not being used and it breaks scss compile\r\n- template.css after running npm build:css [note this hadn't been run for a while as it was missing from the build scripts] #21446","created_at":"2018-08-07T13:07:39Z","updated_at":"2018-08-07T13:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3201cf373720ea6de9e71478e235e2f5b1414e48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":198658453,"node_id":"MDU6TGFiZWwxOTg2NTg0NTM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/21447/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/db4c4efcede61fb6e5f189076ff7af7cb64adf00","head":{"label":"brianteeman:instaler-review","ref":"instaler-review","sha":"db4c4efcede61fb6e5f189076ff7af7cb64adf00","user":{"login":"brianteeman","id":1296369,"node_id":"MDQ6VXNlcjEyOTYzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"repo":{"id":76056079,"node_id":"MDEwOlJlcG9zaXRvcnk3NjA1NjA3OQ==","name":"joomla-cms","full_name":"brianteeman/joomla-cms","owner":{"login":"brianteeman","id":1296369,"node_id":"MDQ6VXNlcjEyOTYzNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1296369?v=4","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianteeman/joomla-cms","description":"DEV attachments field for Joomla custom fields","fork":true,"url":"https://api.github.com/repos/brianteeman/joomla-cms","forks_url":"https://api.github.com/repos/brianteeman/joomla-cms/forks","keys_url":"https://api.github.com/repos/brianteeman/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianteeman/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianteeman/joomla-cms/teams","hooks_url":"https://api.github.com/repos/brianteeman/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/brianteeman/joomla-cms/events","assignees_url":"https://api.github.com/repos/brianteeman/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/brianteeman/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/brianteeman/joomla-cms/tags","blobs_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianteeman/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/brianteeman/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/brianteeman/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/brianteeman/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/brianteeman/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/brianteeman/joomla-cms/subscription","commits_url":"https://api.github.com/repos/brianteeman/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianteeman/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianteeman/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianteeman/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/brianteeman/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianteeman/joomla-cms/merges","archive_url":"https://api.github.com/repos/brianteeman/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianteeman/joomla-cms/downloads","issues_url":"https://api.github.com/repos/brianteeman/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/brianteeman/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/brianteeman/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/brianteeman/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianteeman/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/brianteeman/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/brianteeman/joomla-cms/deployments","created_at":"2016-12-09T17:27:35Z","updated_at":"2017-03-27T16:53:19Z","pushed_at":"2018-08-07T13:24:44Z","git_url":"git://github.com/brianteeman/joomla-cms.git","ssh_url":"git@github.com:brianteeman/joomla-cms.git","clone_url":"https://github.com/brianteeman/joomla-cms.git","svn_url":"https://github.com/brianteeman/joomla-cms","homepage":"https://brian.teeman.net","size":239641,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"eaecec42ccde7fe8563da6f0d43775c628f648e6","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-08-07T13:24:55Z","pushed_at":"2018-08-07T13:24:05Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":239741,"stargazers_count":2827,"watchers_count":2827,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2726,"mirror_url":null,"archived":false,"open_issues_count":758,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2726,"open_issues":758,"watchers":2827,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/21447"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/21447"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/21447/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/21447/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/db4c4efcede61fb6e5f189076ff7af7cb64adf00"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgrammatiko"}}