{"action":"created","comment":{"url":"https://api.github.com/repos/fluid-project/kettle/pulls/comments/193031412","pull_request_review_id":125919405,"id":193031412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzAzMTQxMg==","diff_hunk":"@@ -252,13 +261,12 @@ kettle.dataSource.get = function (that, directModel, options) {\n  * transforming promise chain (in the opposite direction to that applied on `get`, and then applies it to the dataSource's `setImpl` method.\n  * Any return from this is then pushed forwards through a limited range of the transforms (typically, e.g. just decoding it as JSON)\n  * on its way back to the user.\n- * @param that {Component} The dataSource itself\n- * @param directModel {Object} The direct model expressing the \"coordinates\" of the model to be written\n- * @param model {Object} The payload to be written to the dataSource\n- * @param options {Object} A structure of options configuring the action of this set request - many of these will be specific to the particular concrete DataSource\n+ * @param {Component} that - The dataSource itself\n+ * @param {Object} directModel - The direct model expressing the \"coordinates\" of the model to be written\n+ * @param {Object} model - The payload to be written to the dataSource\n+ * @param {Object} options - A structure of options configuring the action of this set request - many of these will be specific to the particular concrete DataSource","path":"lib/dataSource-core.js","position":71,"original_position":71,"commit_id":"7af2daeca583509274da1adaa3be04a1635330e4","original_commit_id":"7af2daeca583509274da1adaa3be04a1635330e4","user":{"login":"the-t-in-rtf","id":5765222,"node_id":"MDQ6VXNlcjU3NjUyMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5765222?v=4","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"body":"Same here, isn't options also optional?","created_at":"2018-06-05T11:03:27Z","updated_at":"2018-06-05T11:03:27Z","html_url":"https://github.com/fluid-project/kettle/pull/42#discussion_r193031412","pull_request_url":"https://api.github.com/repos/fluid-project/kettle/pulls/42","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/comments/193031412"},"html":{"href":"https://github.com/fluid-project/kettle/pull/42#discussion_r193031412"},"pull_request":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/fluid-project/kettle/pulls/42","id":192664887,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjY0ODg3","html_url":"https://github.com/fluid-project/kettle/pull/42","diff_url":"https://github.com/fluid-project/kettle/pull/42.diff","patch_url":"https://github.com/fluid-project/kettle/pull/42.patch","issue_url":"https://api.github.com/repos/fluid-project/kettle/issues/42","number":42,"state":"open","locked":false,"title":"KETTLE-67: Improvements to linting, general dependency update, and improvement to error handlers","user":{"login":"amb26","id":561418,"node_id":"MDQ6VXNlcjU2MTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/561418?v=4","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-05T10:46:48Z","updated_at":"2018-06-05T11:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2ed1817f1dbe371d4ddfcba4de0b17068a819fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluid-project/kettle/pulls/42/commits","review_comments_url":"https://api.github.com/repos/fluid-project/kettle/pulls/42/comments","review_comment_url":"https://api.github.com/repos/fluid-project/kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluid-project/kettle/issues/42/comments","statuses_url":"https://api.github.com/repos/fluid-project/kettle/statuses/7af2daeca583509274da1adaa3be04a1635330e4","head":{"label":"amb26:KETTLE-67","ref":"KETTLE-67","sha":"7af2daeca583509274da1adaa3be04a1635330e4","user":{"login":"amb26","id":561418,"node_id":"MDQ6VXNlcjU2MTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/561418?v=4","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"repo":{"id":15988875,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4ODg3NQ==","name":"kettle","full_name":"amb26/kettle","owner":{"login":"amb26","id":561418,"node_id":"MDQ6VXNlcjU2MTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/561418?v=4","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amb26/kettle","description":"A serverside framework based on Fluid's Infusion framework","fork":true,"url":"https://api.github.com/repos/amb26/kettle","forks_url":"https://api.github.com/repos/amb26/kettle/forks","keys_url":"https://api.github.com/repos/amb26/kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amb26/kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amb26/kettle/teams","hooks_url":"https://api.github.com/repos/amb26/kettle/hooks","issue_events_url":"https://api.github.com/repos/amb26/kettle/issues/events{/number}","events_url":"https://api.github.com/repos/amb26/kettle/events","assignees_url":"https://api.github.com/repos/amb26/kettle/assignees{/user}","branches_url":"https://api.github.com/repos/amb26/kettle/branches{/branch}","tags_url":"https://api.github.com/repos/amb26/kettle/tags","blobs_url":"https://api.github.com/repos/amb26/kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amb26/kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amb26/kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/amb26/kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amb26/kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/amb26/kettle/languages","stargazers_url":"https://api.github.com/repos/amb26/kettle/stargazers","contributors_url":"https://api.github.com/repos/amb26/kettle/contributors","subscribers_url":"https://api.github.com/repos/amb26/kettle/subscribers","subscription_url":"https://api.github.com/repos/amb26/kettle/subscription","commits_url":"https://api.github.com/repos/amb26/kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/amb26/kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/amb26/kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/amb26/kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/amb26/kettle/contents/{+path}","compare_url":"https://api.github.com/repos/amb26/kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amb26/kettle/merges","archive_url":"https://api.github.com/repos/amb26/kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amb26/kettle/downloads","issues_url":"https://api.github.com/repos/amb26/kettle/issues{/number}","pulls_url":"https://api.github.com/repos/amb26/kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/amb26/kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/amb26/kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amb26/kettle/labels{/name}","releases_url":"https://api.github.com/repos/amb26/kettle/releases{/id}","deployments_url":"https://api.github.com/repos/amb26/kettle/deployments","created_at":"2014-01-17T03:19:32Z","updated_at":"2014-02-15T19:22:58Z","pushed_at":"2018-06-01T22:00:13Z","git_url":"git://github.com/amb26/kettle.git","ssh_url":"git@github.com:amb26/kettle.git","clone_url":"https://github.com/amb26/kettle.git","svn_url":"https://github.com/amb26/kettle","homepage":"","size":821,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluid-project:master","ref":"master","sha":"f203a56fff1a0a9c0089e009d2488fe297b41daa","user":{"login":"fluid-project","id":560119,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDExOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/560119?v=4","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"repo":{"id":11035862,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNTg2Mg==","name":"kettle","full_name":"fluid-project/kettle","owner":{"login":"fluid-project","id":560119,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MDExOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/560119?v=4","gravatar_id":"","url":"https://api.github.com/users/fluid-project","html_url":"https://github.com/fluid-project","followers_url":"https://api.github.com/users/fluid-project/followers","following_url":"https://api.github.com/users/fluid-project/following{/other_user}","gists_url":"https://api.github.com/users/fluid-project/gists{/gist_id}","starred_url":"https://api.github.com/users/fluid-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluid-project/subscriptions","organizations_url":"https://api.github.com/users/fluid-project/orgs","repos_url":"https://api.github.com/users/fluid-project/repos","events_url":"https://api.github.com/users/fluid-project/events{/privacy}","received_events_url":"https://api.github.com/users/fluid-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluid-project/kettle","description":"A server side framework based on Fluid's Infusion framework","fork":false,"url":"https://api.github.com/repos/fluid-project/kettle","forks_url":"https://api.github.com/repos/fluid-project/kettle/forks","keys_url":"https://api.github.com/repos/fluid-project/kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluid-project/kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluid-project/kettle/teams","hooks_url":"https://api.github.com/repos/fluid-project/kettle/hooks","issue_events_url":"https://api.github.com/repos/fluid-project/kettle/issues/events{/number}","events_url":"https://api.github.com/repos/fluid-project/kettle/events","assignees_url":"https://api.github.com/repos/fluid-project/kettle/assignees{/user}","branches_url":"https://api.github.com/repos/fluid-project/kettle/branches{/branch}","tags_url":"https://api.github.com/repos/fluid-project/kettle/tags","blobs_url":"https://api.github.com/repos/fluid-project/kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluid-project/kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluid-project/kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluid-project/kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluid-project/kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/fluid-project/kettle/languages","stargazers_url":"https://api.github.com/repos/fluid-project/kettle/stargazers","contributors_url":"https://api.github.com/repos/fluid-project/kettle/contributors","subscribers_url":"https://api.github.com/repos/fluid-project/kettle/subscribers","subscription_url":"https://api.github.com/repos/fluid-project/kettle/subscription","commits_url":"https://api.github.com/repos/fluid-project/kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluid-project/kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluid-project/kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluid-project/kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluid-project/kettle/contents/{+path}","compare_url":"https://api.github.com/repos/fluid-project/kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluid-project/kettle/merges","archive_url":"https://api.github.com/repos/fluid-project/kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluid-project/kettle/downloads","issues_url":"https://api.github.com/repos/fluid-project/kettle/issues{/number}","pulls_url":"https://api.github.com/repos/fluid-project/kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/fluid-project/kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/fluid-project/kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluid-project/kettle/labels{/name}","releases_url":"https://api.github.com/repos/fluid-project/kettle/releases{/id}","deployments_url":"https://api.github.com/repos/fluid-project/kettle/deployments","created_at":"2013-06-28T19:35:53Z","updated_at":"2018-06-01T22:12:04Z","pushed_at":"2018-06-05T10:46:48Z","git_url":"git://github.com/fluid-project/kettle.git","ssh_url":"git@github.com:fluid-project/kettle.git","clone_url":"https://github.com/fluid-project/kettle.git","svn_url":"https://github.com/fluid-project/kettle","homepage":"","size":817,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":17,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/42"},"html":{"href":"https://github.com/fluid-project/kettle/pull/42"},"issue":{"href":"https://api.github.com/repos/fluid-project/kettle/issues/42"},"comments":{"href":"https://api.github.com/repos/fluid-project/kettle/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluid-project/kettle/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/fluid-project/kettle/statuses/7af2daeca583509274da1adaa3be04a1635330e4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"the-t-in-rtf"}}