{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/171263345","pull_request_review_id":100084394,"id":171263345,"diff_hunk":"@@ -0,0 +1,80 @@\n+#!/bin/bash\n+\n+#\n+# Helper script for deploying the Broker to an existing OpenShift cluster\n+# using an OpenShift template.\n+#\n+\n+#\n+# VERIFY and UPDATE the variables below\n+#\n+CLUSTER_ADMIN_USER=\"system:admin\"\n+TEMPLATE_URL=${TEMPLATE_URL:-\"https://raw.githubusercontent.com/openshift/ansible-service-broker/master/templates/deploy-ansible-service-broker.template.yaml\"}\n+DOCKERHUB_ORG=${DOCKERHUB_ORG:-\"ansibleplaybookbundle\"} # DocherHub org where APBs can be found, default 'ansibleplaybookbundle'","path":"scripts/deploy_broker.sh","position":13,"original_position":13,"commit_id":"3cdf2ba9a095133b5605b226b7843bb2cf0c24ad","original_commit_id":"3cdf2ba9a095133b5605b226b7843bb2cf0c24ad","user":{"login":"jmrodri","id":17137,"avatar_url":"https://avatars2.githubusercontent.com/u/17137?v=4","gravatar_id":"","url":"https://api.github.com/users/jmrodri","html_url":"https://github.com/jmrodri","followers_url":"https://api.github.com/users/jmrodri/followers","following_url":"https://api.github.com/users/jmrodri/following{/other_user}","gists_url":"https://api.github.com/users/jmrodri/gists{/gist_id}","starred_url":"https://api.github.com/users/jmrodri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmrodri/subscriptions","organizations_url":"https://api.github.com/users/jmrodri/orgs","repos_url":"https://api.github.com/users/jmrodri/repos","events_url":"https://api.github.com/users/jmrodri/events{/privacy}","received_events_url":"https://api.github.com/users/jmrodri/received_events","type":"User","site_admin":false},"body":"TYPO in the comment: DocherHub should be DockerHub","created_at":"2018-02-28T14:35:36Z","updated_at":"2018-02-28T14:43:52Z","html_url":"https://github.com/openshift/ansible-service-broker/pull/799#discussion_r171263345","pull_request_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments/171263345"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/799#discussion_r171263345"},"pull_request":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799","id":171968994,"html_url":"https://github.com/openshift/ansible-service-broker/pull/799","diff_url":"https://github.com/openshift/ansible-service-broker/pull/799.diff","patch_url":"https://github.com/openshift/ansible-service-broker/pull/799.patch","issue_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/799","number":799,"state":"open","locked":false,"title":"Parametize namespace in deployment template and update the 'run latest build' script","user":{"login":"johnkim76","id":2566892,"avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"body":"Parameterize the ASB namespace in the deployment template and changed the run_latest_build script so that it would be easier to update AWS broker templates and scripts\r\n\r\nChanges proposed in this pull request\r\n - replaced 'ansible-service-broker' with ${NAMESPACE} in the deployment template where appropriate\r\n - created a 'deploy_broker.sh' script to launch the broker in an existing cluster\r\n - modified the 'run_latest_build.sh' script to utilize the 'deploy_broker.sh' script\r\n\r\nTo test the run script BEFORE merging this PR, the TEMPLATE_URL should be defined:\r\n$ TEMPLATE_URL=<link-to-updated-template-file> ./run_latest_build.sh","created_at":"2018-02-28T14:29:41Z","updated_at":"2018-02-28T14:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d46c9bfa1978718b828559551dc78128d7548416","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shawn-hurley","id":1891063,"avatar_url":"https://avatars3.githubusercontent.com/u/1891063?v=4","gravatar_id":"","url":"https://api.github.com/users/shawn-hurley","html_url":"https://github.com/shawn-hurley","followers_url":"https://api.github.com/users/shawn-hurley/followers","following_url":"https://api.github.com/users/shawn-hurley/following{/other_user}","gists_url":"https://api.github.com/users/shawn-hurley/gists{/gist_id}","starred_url":"https://api.github.com/users/shawn-hurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shawn-hurley/subscriptions","organizations_url":"https://api.github.com/users/shawn-hurley/orgs","repos_url":"https://api.github.com/users/shawn-hurley/repos","events_url":"https://api.github.com/users/shawn-hurley/events{/privacy}","received_events_url":"https://api.github.com/users/shawn-hurley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":711534248,"url":"https://api.github.com/repos/openshift/ansible-service-broker/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799/commits","review_comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799/comments","review_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/799/comments","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/3cdf2ba9a095133b5605b226b7843bb2cf0c24ad","head":{"label":"johnkim76:update_deployment_template","ref":"update_deployment_template","sha":"3cdf2ba9a095133b5605b226b7843bb2cf0c24ad","user":{"login":"johnkim76","id":2566892,"avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"repo":{"id":93653493,"name":"ansible-service-broker","full_name":"johnkim76/ansible-service-broker","owner":{"login":"johnkim76","id":2566892,"avatar_url":"https://avatars0.githubusercontent.com/u/2566892?v=4","gravatar_id":"","url":"https://api.github.com/users/johnkim76","html_url":"https://github.com/johnkim76","followers_url":"https://api.github.com/users/johnkim76/followers","following_url":"https://api.github.com/users/johnkim76/following{/other_user}","gists_url":"https://api.github.com/users/johnkim76/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkim76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkim76/subscriptions","organizations_url":"https://api.github.com/users/johnkim76/orgs","repos_url":"https://api.github.com/users/johnkim76/repos","events_url":"https://api.github.com/users/johnkim76/events{/privacy}","received_events_url":"https://api.github.com/users/johnkim76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnkim76/ansible-service-broker","description":"Ansible Service Broker","fork":true,"url":"https://api.github.com/repos/johnkim76/ansible-service-broker","forks_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/johnkim76/ansible-service-broker/deployments","created_at":"2017-06-07T15:56:12Z","updated_at":"2017-06-07T15:56:14Z","pushed_at":"2018-02-27T21:23:38Z","git_url":"git://github.com/johnkim76/ansible-service-broker.git","ssh_url":"git@github.com:johnkim76/ansible-service-broker.git","clone_url":"https://github.com/johnkim76/ansible-service-broker.git","svn_url":"https://github.com/johnkim76/ansible-service-broker","homepage":null,"size":77284,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c4f94833d1d464e18be4aa3e04ed6a818ab15463","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":79371528,"name":"ansible-service-broker","full_name":"openshift/ansible-service-broker","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/ansible-service-broker","description":"Ansible Service Broker","fork":false,"url":"https://api.github.com/repos/openshift/ansible-service-broker","forks_url":"https://api.github.com/repos/openshift/ansible-service-broker/forks","keys_url":"https://api.github.com/repos/openshift/ansible-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/ansible-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/ansible-service-broker/teams","hooks_url":"https://api.github.com/repos/openshift/ansible-service-broker/hooks","issue_events_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/ansible-service-broker/events","assignees_url":"https://api.github.com/repos/openshift/ansible-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/ansible-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/tags","blobs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/ansible-service-broker/languages","stargazers_url":"https://api.github.com/repos/openshift/ansible-service-broker/stargazers","contributors_url":"https://api.github.com/repos/openshift/ansible-service-broker/contributors","subscribers_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscribers","subscription_url":"https://api.github.com/repos/openshift/ansible-service-broker/subscription","commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/ansible-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/ansible-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/ansible-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/ansible-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/ansible-service-broker/merges","archive_url":"https://api.github.com/repos/openshift/ansible-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/ansible-service-broker/downloads","issues_url":"https://api.github.com/repos/openshift/ansible-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/ansible-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/ansible-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/ansible-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/ansible-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/openshift/ansible-service-broker/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/ansible-service-broker/deployments","created_at":"2017-01-18T18:40:49Z","updated_at":"2018-02-28T06:08:53Z","pushed_at":"2018-02-28T14:35:44Z","git_url":"git://github.com/openshift/ansible-service-broker.git","ssh_url":"git@github.com:openshift/ansible-service-broker.git","clone_url":"https://github.com/openshift/ansible-service-broker.git","svn_url":"https://github.com/openshift/ansible-service-broker","homepage":null,"size":77340,"stargazers_count":89,"watchers_count":89,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":47,"open_issues":43,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799"},"html":{"href":"https://github.com/openshift/ansible-service-broker/pull/799"},"issue":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/799"},"comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/ansible-service-broker/statuses/3cdf2ba9a095133b5605b226b7843bb2cf0c24ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmrodri"}}