{"action":"created","comment":{"url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/comments/214247932","pull_request_review_id":151262148,"id":214247932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDI0NzkzMg==","diff_hunk":"@@ -0,0 +1,38 @@\n+/**\n+ * @fileoverview Report internal state variables without underscore suffix.\n+ */\n+\n+\"use strict\";\n+\n+module.exports = {\n+    meta: {\n+        docs: {\n+            recommended: true,\n+            type: \"error\",\n+            description: \"Report internal state variables without underscore suffix\"\n+        },\n+        schema: []\n+    },\n+\n+    create: function(context) {\n+\n+        function inspectStateVariableDeclaration(emitted) {\n+            if (emitted.exit) {\n+                return;\n+            }\n+            emitted.node.params.forEach(param => {","path":"rules/internal-state-suffix.js","position":23,"original_position":23,"commit_id":"ffa94376b3e835d39f5228aa9d50c794faf66683","original_commit_id":"ffa94376b3e835d39f5228aa9d50c794faf66683","user":{"login":"elopio","id":617831,"node_id":"MDQ6VXNlcjYxNzgzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/617831?v=4","gravatar_id":"","url":"https://api.github.com/users/elopio","html_url":"https://github.com/elopio","followers_url":"https://api.github.com/users/elopio/followers","following_url":"https://api.github.com/users/elopio/following{/other_user}","gists_url":"https://api.github.com/users/elopio/gists{/gist_id}","starred_url":"https://api.github.com/users/elopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopio/subscriptions","organizations_url":"https://api.github.com/users/elopio/orgs","repos_url":"https://api.github.com/users/elopio/repos","events_url":"https://api.github.com/users/elopio/events{/privacy}","received_events_url":"https://api.github.com/users/elopio/received_events","type":"User","site_admin":false},"body":"in this case, there are no params. So remove this forEach loop.\r\nWe just need to check:\r\n`emitted.node.name.charAt(emitted.node.name.length - 1) !== \"_\"`\r\n\r\nThe function `inspectStateVariableDeclaration` will be called for each declaration, so the loop is already happening, but one level higher.","created_at":"2018-08-31T05:35:32Z","updated_at":"2018-08-31T05:38:47Z","html_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31#discussion_r214247932","pull_request_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/comments/214247932"},"html":{"href":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31#discussion_r214247932"},"pull_request":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31","id":211448349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNDQ4MzQ5","html_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31","diff_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31.diff","patch_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31.patch","issue_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/31","number":31,"state":"open","locked":false,"title":"Added rule for \"_\" suffix for internal variables","user":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"body":"New rule for \"_\" suffix for internal variables: variables with no visibility qualifier or private or internal variables. Does not apply for variables in a function","created_at":"2018-08-28T14:43:09Z","updated_at":"2018-08-31T05:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6ca6c7a1ac8dcd93188dc2139082fea16726f01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31/commits","review_comments_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31/comments","review_comment_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/31/comments","statuses_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/statuses/ffa94376b3e835d39f5228aa9d50c794faf66683","head":{"label":"viquezclaudio:rule/internal_state_suffix","ref":"rule/internal_state_suffix","sha":"ffa94376b3e835d39f5228aa9d50c794faf66683","user":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"repo":{"id":145631530,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MzE1MzA=","name":"solium-plugin-zeppelin","full_name":"viquezclaudio/solium-plugin-zeppelin","owner":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viquezclaudio/solium-plugin-zeppelin","description":"Solium plugin for Zeppelin audits","fork":true,"url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin","forks_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/forks","keys_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/teams","hooks_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/events","assignees_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/tags","blobs_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/languages","stargazers_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/subscription","commits_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/merges","archive_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/downloads","issues_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/viquezclaudio/solium-plugin-zeppelin/deployments","created_at":"2018-08-21T23:46:33Z","updated_at":"2018-08-21T23:46:35Z","pushed_at":"2018-08-28T14:42:10Z","git_url":"git://github.com/viquezclaudio/solium-plugin-zeppelin.git","ssh_url":"git@github.com:viquezclaudio/solium-plugin-zeppelin.git","clone_url":"https://github.com/viquezclaudio/solium-plugin-zeppelin.git","svn_url":"https://github.com/viquezclaudio/solium-plugin-zeppelin","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenZeppelin:master","ref":"master","sha":"aec043c90d158210a6baa95b5247fa2dedd8775e","user":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"repo":{"id":114819013,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MTkwMTM=","name":"solium-plugin-zeppelin","full_name":"OpenZeppelin/solium-plugin-zeppelin","owner":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin","description":"Solium plugin for Zeppelin audits","fork":false,"url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin","forks_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/forks","keys_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/teams","hooks_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/events","assignees_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/tags","blobs_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/languages","stargazers_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/subscription","commits_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/merges","archive_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/downloads","issues_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/deployments","created_at":"2017-12-19T22:52:42Z","updated_at":"2018-08-13T13:07:39Z","pushed_at":"2018-08-28T14:43:10Z","git_url":"git://github.com/OpenZeppelin/solium-plugin-zeppelin.git","ssh_url":"git@github.com:OpenZeppelin/solium-plugin-zeppelin.git","clone_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin.git","svn_url":"https://github.com/OpenZeppelin/solium-plugin-zeppelin","homepage":"","size":61,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31"},"html":{"href":"https://github.com/OpenZeppelin/solium-plugin-zeppelin/pull/31"},"issue":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/31"},"comments":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/OpenZeppelin/solium-plugin-zeppelin/statuses/ffa94376b3e835d39f5228aa9d50c794faf66683"}},"author_association":"NONE"}}
{"actor":{"display_login":"elopio"}}