{"action":"created","comment":{"url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/comments/217508869","pull_request_review_id":155239127,"id":217508869,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzUwODg2OQ==","diff_hunk":"@@ -87,20 +84,20 @@ def start_solr(solr_config_type, port_number, SOLR_INSTALL_DIR=\"/usr/local/solr\"\n     else:\n         enable_nodes = \"'-Denable.master=true -Denable.slave=true'\"\n \n-    start_solr_command = \"{SOLR_INSTALL_DIR}/bin/solr start -d {SOLR_INSTALL_DIR}/server -s {SOLR_HOME}/{solr_config_type}-{port_number} -p {port_number} -a {enable_nodes} -m 512m\".format(SOLR_INSTALL_DIR=SOLR_INSTALL_DIR, SOLR_HOME=SOLR_HOME, solr_config_type=solr_config_type, port_number=port_number, enable_nodes=enable_nodes)\n-    print \"start solr command:\", start_solr_command\n-    esg_functions.stream_subprocess_output(start_solr_command)\n+    server_directory = \"{}/server\".format(SOLR_INSTALL_DIR)\n+    solr_solr_home = \"{}/{}-{}\".format(SOLR_HOME, solr_config_type, port_number)\n+    start_solr_options = [\"start\", \"-d\", server_directory, \"-s\", solr_solr_home, \"-p\", port_number, \"-a\", enable_nodes, \"-m\", \"512m\"]\n+    esg_functions.call_binary(\"/usr/local/bin/solr\", start_solr_options)\n \n     solr_status(SOLR_INSTALL_DIR)\n \n def solr_status(SOLR_INSTALL_DIR):\n     '''Check the status of solr'''\n     try:\n-        esg_functions.stream_subprocess_output(\"{SOLR_INSTALL_DIR}/bin/solr status\".format(SOLR_INSTALL_DIR=SOLR_INSTALL_DIR))\n-    except OSError:\n-        pass\n-    except SubprocessError:\n-        raise(\"Error checking solr status\")\n+        esg_functions.call_binary(\"/usr/local/bin/solr\", [\"status\"])\n+    except ProcessExecutionError:","path":"index_node/solr.py","position":42,"original_position":42,"commit_id":"988882b934abe1d7c8dfc7ca609761583625523d","original_commit_id":"988882b934abe1d7c8dfc7ca609761583625523d","user":{"login":"nathanlcarlson","id":22420382,"node_id":"MDQ6VXNlcjIyNDIwMzgy","avatar_url":"https://avatars2.githubusercontent.com/u/22420382?v=4","gravatar_id":"","url":"https://api.github.com/users/nathanlcarlson","html_url":"https://github.com/nathanlcarlson","followers_url":"https://api.github.com/users/nathanlcarlson/followers","following_url":"https://api.github.com/users/nathanlcarlson/following{/other_user}","gists_url":"https://api.github.com/users/nathanlcarlson/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanlcarlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanlcarlson/subscriptions","organizations_url":"https://api.github.com/users/nathanlcarlson/orgs","repos_url":"https://api.github.com/users/nathanlcarlson/repos","events_url":"https://api.github.com/users/nathanlcarlson/events{/privacy}","received_events_url":"https://api.github.com/users/nathanlcarlson/received_events","type":"User","site_admin":false},"body":"Is there a difference between `/usr/local/bin/solr` and the `/usr/local/solr/bin/solr` used elsewhere?","created_at":"2018-09-13T19:38:07Z","updated_at":"2018-09-13T19:38:16Z","html_url":"https://github.com/ESGF/esgf-installer/pull/540#discussion_r217508869","pull_request_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/comments/217508869"},"html":{"href":"https://github.com/ESGF/esgf-installer/pull/540#discussion_r217508869"},"pull_request":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540"}}},"pull_request":{"url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540","id":215370803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzcwODAz","html_url":"https://github.com/ESGF/esgf-installer/pull/540","diff_url":"https://github.com/ESGF/esgf-installer/pull/540.diff","patch_url":"https://github.com/ESGF/esgf-installer/pull/540.patch","issue_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/540","number":540,"state":"open","locked":false,"title":"replaced use of subprocess with call_binary() where possible (index_node)","user":{"login":"William-Hill","id":1959072,"node_id":"MDQ6VXNlcjE5NTkwNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1959072?v=4","gravatar_id":"","url":"https://api.github.com/users/William-Hill","html_url":"https://github.com/William-Hill","followers_url":"https://api.github.com/users/William-Hill/followers","following_url":"https://api.github.com/users/William-Hill/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill/subscriptions","organizations_url":"https://api.github.com/users/William-Hill/orgs","repos_url":"https://api.github.com/users/William-Hill/repos","events_url":"https://api.github.com/users/William-Hill/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-13T18:17:47Z","updated_at":"2018-09-13T19:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a1d99ecdc246b8ab359c97963a90986361ac05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":884042469,"node_id":"MDU6TGFiZWw4ODQwNDI0Njk=","url":"https://api.github.com/repos/ESGF/esgf-installer/labels/3.0-alpha","name":"3.0-alpha","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540/commits","review_comments_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540/comments","review_comment_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/540/comments","statuses_url":"https://api.github.com/repos/ESGF/esgf-installer/statuses/988882b934abe1d7c8dfc7ca609761583625523d","head":{"label":"ESGF:plumbum_index_node","ref":"plumbum_index_node","sha":"988882b934abe1d7c8dfc7ca609761583625523d","user":{"login":"ESGF","id":1236619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzY2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1236619?v=4","gravatar_id":"","url":"https://api.github.com/users/ESGF","html_url":"https://github.com/ESGF","followers_url":"https://api.github.com/users/ESGF/followers","following_url":"https://api.github.com/users/ESGF/following{/other_user}","gists_url":"https://api.github.com/users/ESGF/gists{/gist_id}","starred_url":"https://api.github.com/users/ESGF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESGF/subscriptions","organizations_url":"https://api.github.com/users/ESGF/orgs","repos_url":"https://api.github.com/users/ESGF/repos","events_url":"https://api.github.com/users/ESGF/events{/privacy}","received_events_url":"https://api.github.com/users/ESGF/received_events","type":"Organization","site_admin":false},"repo":{"id":3100048,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAwMDQ4","name":"esgf-installer","full_name":"ESGF/esgf-installer","owner":{"login":"ESGF","id":1236619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzY2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1236619?v=4","gravatar_id":"","url":"https://api.github.com/users/ESGF","html_url":"https://github.com/ESGF","followers_url":"https://api.github.com/users/ESGF/followers","following_url":"https://api.github.com/users/ESGF/following{/other_user}","gists_url":"https://api.github.com/users/ESGF/gists{/gist_id}","starred_url":"https://api.github.com/users/ESGF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESGF/subscriptions","organizations_url":"https://api.github.com/users/ESGF/orgs","repos_url":"https://api.github.com/users/ESGF/repos","events_url":"https://api.github.com/users/ESGF/events{/privacy}","received_events_url":"https://api.github.com/users/ESGF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESGF/esgf-installer","description":"ESGF P2P Node Installer","fork":false,"url":"https://api.github.com/repos/ESGF/esgf-installer","forks_url":"https://api.github.com/repos/ESGF/esgf-installer/forks","keys_url":"https://api.github.com/repos/ESGF/esgf-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESGF/esgf-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESGF/esgf-installer/teams","hooks_url":"https://api.github.com/repos/ESGF/esgf-installer/hooks","issue_events_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/events{/number}","events_url":"https://api.github.com/repos/ESGF/esgf-installer/events","assignees_url":"https://api.github.com/repos/ESGF/esgf-installer/assignees{/user}","branches_url":"https://api.github.com/repos/ESGF/esgf-installer/branches{/branch}","tags_url":"https://api.github.com/repos/ESGF/esgf-installer/tags","blobs_url":"https://api.github.com/repos/ESGF/esgf-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESGF/esgf-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESGF/esgf-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESGF/esgf-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESGF/esgf-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/ESGF/esgf-installer/languages","stargazers_url":"https://api.github.com/repos/ESGF/esgf-installer/stargazers","contributors_url":"https://api.github.com/repos/ESGF/esgf-installer/contributors","subscribers_url":"https://api.github.com/repos/ESGF/esgf-installer/subscribers","subscription_url":"https://api.github.com/repos/ESGF/esgf-installer/subscription","commits_url":"https://api.github.com/repos/ESGF/esgf-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESGF/esgf-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESGF/esgf-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESGF/esgf-installer/contents/{+path}","compare_url":"https://api.github.com/repos/ESGF/esgf-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESGF/esgf-installer/merges","archive_url":"https://api.github.com/repos/ESGF/esgf-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESGF/esgf-installer/downloads","issues_url":"https://api.github.com/repos/ESGF/esgf-installer/issues{/number}","pulls_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/ESGF/esgf-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/ESGF/esgf-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESGF/esgf-installer/labels{/name}","releases_url":"https://api.github.com/repos/ESGF/esgf-installer/releases{/id}","deployments_url":"https://api.github.com/repos/ESGF/esgf-installer/deployments","created_at":"2012-01-04T05:59:31Z","updated_at":"2018-08-22T16:18:30Z","pushed_at":"2018-09-13T19:26:24Z","git_url":"git://github.com/ESGF/esgf-installer.git","ssh_url":"git@github.com:ESGF/esgf-installer.git","clone_url":"https://github.com/ESGF/esgf-installer.git","svn_url":"https://github.com/ESGF/esgf-installer","homepage":"https://esgf.llnl.gov/","size":9169,"stargazers_count":14,"watchers_count":14,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":71,"watchers":14,"default_branch":"master"}},"base":{"label":"ESGF:python_devel","ref":"python_devel","sha":"ea3b006cb418d02f3fb8422ae535cc1d76391934","user":{"login":"ESGF","id":1236619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzY2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1236619?v=4","gravatar_id":"","url":"https://api.github.com/users/ESGF","html_url":"https://github.com/ESGF","followers_url":"https://api.github.com/users/ESGF/followers","following_url":"https://api.github.com/users/ESGF/following{/other_user}","gists_url":"https://api.github.com/users/ESGF/gists{/gist_id}","starred_url":"https://api.github.com/users/ESGF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESGF/subscriptions","organizations_url":"https://api.github.com/users/ESGF/orgs","repos_url":"https://api.github.com/users/ESGF/repos","events_url":"https://api.github.com/users/ESGF/events{/privacy}","received_events_url":"https://api.github.com/users/ESGF/received_events","type":"Organization","site_admin":false},"repo":{"id":3100048,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAwMDQ4","name":"esgf-installer","full_name":"ESGF/esgf-installer","owner":{"login":"ESGF","id":1236619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzY2MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1236619?v=4","gravatar_id":"","url":"https://api.github.com/users/ESGF","html_url":"https://github.com/ESGF","followers_url":"https://api.github.com/users/ESGF/followers","following_url":"https://api.github.com/users/ESGF/following{/other_user}","gists_url":"https://api.github.com/users/ESGF/gists{/gist_id}","starred_url":"https://api.github.com/users/ESGF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ESGF/subscriptions","organizations_url":"https://api.github.com/users/ESGF/orgs","repos_url":"https://api.github.com/users/ESGF/repos","events_url":"https://api.github.com/users/ESGF/events{/privacy}","received_events_url":"https://api.github.com/users/ESGF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ESGF/esgf-installer","description":"ESGF P2P Node Installer","fork":false,"url":"https://api.github.com/repos/ESGF/esgf-installer","forks_url":"https://api.github.com/repos/ESGF/esgf-installer/forks","keys_url":"https://api.github.com/repos/ESGF/esgf-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ESGF/esgf-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ESGF/esgf-installer/teams","hooks_url":"https://api.github.com/repos/ESGF/esgf-installer/hooks","issue_events_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/events{/number}","events_url":"https://api.github.com/repos/ESGF/esgf-installer/events","assignees_url":"https://api.github.com/repos/ESGF/esgf-installer/assignees{/user}","branches_url":"https://api.github.com/repos/ESGF/esgf-installer/branches{/branch}","tags_url":"https://api.github.com/repos/ESGF/esgf-installer/tags","blobs_url":"https://api.github.com/repos/ESGF/esgf-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ESGF/esgf-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ESGF/esgf-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ESGF/esgf-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ESGF/esgf-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/ESGF/esgf-installer/languages","stargazers_url":"https://api.github.com/repos/ESGF/esgf-installer/stargazers","contributors_url":"https://api.github.com/repos/ESGF/esgf-installer/contributors","subscribers_url":"https://api.github.com/repos/ESGF/esgf-installer/subscribers","subscription_url":"https://api.github.com/repos/ESGF/esgf-installer/subscription","commits_url":"https://api.github.com/repos/ESGF/esgf-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ESGF/esgf-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ESGF/esgf-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ESGF/esgf-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ESGF/esgf-installer/contents/{+path}","compare_url":"https://api.github.com/repos/ESGF/esgf-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ESGF/esgf-installer/merges","archive_url":"https://api.github.com/repos/ESGF/esgf-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ESGF/esgf-installer/downloads","issues_url":"https://api.github.com/repos/ESGF/esgf-installer/issues{/number}","pulls_url":"https://api.github.com/repos/ESGF/esgf-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/ESGF/esgf-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/ESGF/esgf-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ESGF/esgf-installer/labels{/name}","releases_url":"https://api.github.com/repos/ESGF/esgf-installer/releases{/id}","deployments_url":"https://api.github.com/repos/ESGF/esgf-installer/deployments","created_at":"2012-01-04T05:59:31Z","updated_at":"2018-08-22T16:18:30Z","pushed_at":"2018-09-13T19:26:24Z","git_url":"git://github.com/ESGF/esgf-installer.git","ssh_url":"git@github.com:ESGF/esgf-installer.git","clone_url":"https://github.com/ESGF/esgf-installer.git","svn_url":"https://github.com/ESGF/esgf-installer","homepage":"https://esgf.llnl.gov/","size":9169,"stargazers_count":14,"watchers_count":14,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":19,"open_issues":71,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540"},"html":{"href":"https://github.com/ESGF/esgf-installer/pull/540"},"issue":{"href":"https://api.github.com/repos/ESGF/esgf-installer/issues/540"},"comments":{"href":"https://api.github.com/repos/ESGF/esgf-installer/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ESGF/esgf-installer/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/ESGF/esgf-installer/statuses/988882b934abe1d7c8dfc7ca609761583625523d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nathanlcarlson"}}