{"action":"created","comment":{"url":"https://api.github.com/repos/metabase/metabase/pulls/comments/180619114","pull_request_review_id":111069837,"id":180619114,"diff_hunk":"@@ -235,10 +235,10 @@\n ;; e.g. the ORDER BY in the source-query should refer the 'stddev' aggregation, NOT the 'avg' aggregation\n (expect\n   {:query (str \"SELECT avg(\\\"stddev\\\") AS \\\"avg\\\" FROM (\"\n-                   \"SELECT STDDEV(\\\"PUBLIC\\\".\\\"VENUES\\\".\\\"ID\\\") AS \\\"stddev\\\", \\\"PUBLIC\\\".\\\"VENUES\\\".\\\"PRICE\\\" AS \\\"PRICE\\\" \"\n-                   \"FROM \\\"PUBLIC\\\".\\\"VENUES\\\" \"\n-                   \"GROUP BY \\\"PUBLIC\\\".\\\"VENUES\\\".\\\"PRICE\\\" \"\n-                   \"ORDER BY \\\"stddev\\\" DESC, \\\"PUBLIC\\\".\\\"VENUES\\\".\\\"PRICE\\\" ASC\"\n+                   \"SELECT STDDEV(\\\"t1\\\".\\\"ID\\\") AS \\\"stddev\\\", \\\"t1\\\".\\\"PRICE\\\" AS \\\"PRICE\\\" \"\n+                   \"FROM \\\"PUBLIC\\\".\\\"VENUES\\\" \\\"t1\\\" \"\n+                   \"GROUP BY \\\"t1\\\".\\\"PRICE\\\" \"\n+                   \"ORDER BY \\\"stddev\\\" DESC, \\\"t1\\\".\\\"PRICE\\\" ASC\"","path":"test/metabase/query_processor_test/nested_queries_test.clj","position":24,"original_position":24,"commit_id":"ac9a737168d1a15752709ceb87d63b43bc56f963","original_commit_id":"6dd2eda172e28d56fe6e07efc14b34ee850319fc","user":{"login":"camsaul","id":1455846,"avatar_url":"https://avatars3.githubusercontent.com/u/1455846?v=4","gravatar_id":"","url":"https://api.github.com/users/camsaul","html_url":"https://github.com/camsaul","followers_url":"https://api.github.com/users/camsaul/followers","following_url":"https://api.github.com/users/camsaul/following{/other_user}","gists_url":"https://api.github.com/users/camsaul/gists{/gist_id}","starred_url":"https://api.github.com/users/camsaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camsaul/subscriptions","organizations_url":"https://api.github.com/users/camsaul/orgs","repos_url":"https://api.github.com/users/camsaul/repos","events_url":"https://api.github.com/users/camsaul/events{/privacy}","received_events_url":"https://api.github.com/users/camsaul/received_events","type":"User","site_admin":false},"body":"fixed in #7323","created_at":"2018-04-11T02:25:03Z","updated_at":"2018-04-11T02:25:03Z","html_url":"https://github.com/metabase/metabase/pull/4645#discussion_r180619114","pull_request_url":"https://api.github.com/repos/metabase/metabase/pulls/4645","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments/180619114"},"html":{"href":"https://github.com/metabase/metabase/pull/4645#discussion_r180619114"},"pull_request":{"href":"https://api.github.com/repos/metabase/metabase/pulls/4645"}},"in_reply_to_id":147843479},"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/4645","id":113464917,"html_url":"https://github.com/metabase/metabase/pull/4645","diff_url":"https://github.com/metabase/metabase/pull/4645.diff","patch_url":"https://github.com/metabase/metabase/pull/4645.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/4645","number":4645,"state":"open","locked":false,"title":"Add support for Spark SQL","user":{"login":"wjoel","id":252950,"avatar_url":"https://avatars0.githubusercontent.com/u/252950?v=4","gravatar_id":"","url":"https://api.github.com/users/wjoel","html_url":"https://github.com/wjoel","followers_url":"https://api.github.com/users/wjoel/followers","following_url":"https://api.github.com/users/wjoel/following{/other_user}","gists_url":"https://api.github.com/users/wjoel/gists{/gist_id}","starred_url":"https://api.github.com/users/wjoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjoel/subscriptions","organizations_url":"https://api.github.com/users/wjoel/orgs","repos_url":"https://api.github.com/users/wjoel/repos","events_url":"https://api.github.com/users/wjoel/events{/privacy}","received_events_url":"https://api.github.com/users/wjoel/received_events","type":"User","site_admin":false},"body":"Only tested with the Spark Thrift Server and Drill #2157, but might work with other Hive compatible SQL engines (Hive itself)\r\n\r\n\r\n\r\n###### TODO \r\n-  [x] Sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform)\r\n(unless it's a tiny documentation change).\r\n-  [x] Add tests? If so, I might need some help. (edit: 2208 tests pass)","created_at":"2017-03-30T16:01:18Z","updated_at":"2018-04-11T02:25:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2f09048be2c26b665ecea01400acdc0441e3339","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":276687551,"url":"https://api.github.com/repos/metabase/metabase/labels/CLA/Signed","name":"CLA/Signed","color":"BFFFC0","default":false}],"milestone":{"url":"https://api.github.com/repos/metabase/metabase/milestones/55","html_url":"https://github.com/metabase/metabase/milestone/55","labels_url":"https://api.github.com/repos/metabase/metabase/milestones/55/labels","id":2987494,"number":55,"title":"0.29","description":"","creator":{"login":"salsakran","id":107439,"avatar_url":"https://avatars0.githubusercontent.com/u/107439?v=4","gravatar_id":"","url":"https://api.github.com/users/salsakran","html_url":"https://github.com/salsakran","followers_url":"https://api.github.com/users/salsakran/followers","following_url":"https://api.github.com/users/salsakran/following{/other_user}","gists_url":"https://api.github.com/users/salsakran/gists{/gist_id}","starred_url":"https://api.github.com/users/salsakran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsakran/subscriptions","organizations_url":"https://api.github.com/users/salsakran/orgs","repos_url":"https://api.github.com/users/salsakran/repos","events_url":"https://api.github.com/users/salsakran/events{/privacy}","received_events_url":"https://api.github.com/users/salsakran/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":35,"state":"open","created_at":"2017-12-18T21:59:28Z","updated_at":"2018-04-11T00:13:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/4645/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/4645/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/4645/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/ac9a737168d1a15752709ceb87d63b43bc56f963","head":{"label":"wjoel:spark-sql","ref":"spark-sql","sha":"ac9a737168d1a15752709ceb87d63b43bc56f963","user":{"login":"wjoel","id":252950,"avatar_url":"https://avatars0.githubusercontent.com/u/252950?v=4","gravatar_id":"","url":"https://api.github.com/users/wjoel","html_url":"https://github.com/wjoel","followers_url":"https://api.github.com/users/wjoel/followers","following_url":"https://api.github.com/users/wjoel/following{/other_user}","gists_url":"https://api.github.com/users/wjoel/gists{/gist_id}","starred_url":"https://api.github.com/users/wjoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjoel/subscriptions","organizations_url":"https://api.github.com/users/wjoel/orgs","repos_url":"https://api.github.com/users/wjoel/repos","events_url":"https://api.github.com/users/wjoel/events{/privacy}","received_events_url":"https://api.github.com/users/wjoel/received_events","type":"User","site_admin":false},"repo":{"id":86719809,"name":"metabase","full_name":"wjoel/metabase","owner":{"login":"wjoel","id":252950,"avatar_url":"https://avatars0.githubusercontent.com/u/252950?v=4","gravatar_id":"","url":"https://api.github.com/users/wjoel","html_url":"https://github.com/wjoel","followers_url":"https://api.github.com/users/wjoel/followers","following_url":"https://api.github.com/users/wjoel/following{/other_user}","gists_url":"https://api.github.com/users/wjoel/gists{/gist_id}","starred_url":"https://api.github.com/users/wjoel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjoel/subscriptions","organizations_url":"https://api.github.com/users/wjoel/orgs","repos_url":"https://api.github.com/users/wjoel/repos","events_url":"https://api.github.com/users/wjoel/events{/privacy}","received_events_url":"https://api.github.com/users/wjoel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjoel/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":true,"url":"https://api.github.com/repos/wjoel/metabase","forks_url":"https://api.github.com/repos/wjoel/metabase/forks","keys_url":"https://api.github.com/repos/wjoel/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjoel/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjoel/metabase/teams","hooks_url":"https://api.github.com/repos/wjoel/metabase/hooks","issue_events_url":"https://api.github.com/repos/wjoel/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/wjoel/metabase/events","assignees_url":"https://api.github.com/repos/wjoel/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/wjoel/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/wjoel/metabase/tags","blobs_url":"https://api.github.com/repos/wjoel/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjoel/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjoel/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjoel/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjoel/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/wjoel/metabase/languages","stargazers_url":"https://api.github.com/repos/wjoel/metabase/stargazers","contributors_url":"https://api.github.com/repos/wjoel/metabase/contributors","subscribers_url":"https://api.github.com/repos/wjoel/metabase/subscribers","subscription_url":"https://api.github.com/repos/wjoel/metabase/subscription","commits_url":"https://api.github.com/repos/wjoel/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjoel/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjoel/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjoel/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjoel/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/wjoel/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjoel/metabase/merges","archive_url":"https://api.github.com/repos/wjoel/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjoel/metabase/downloads","issues_url":"https://api.github.com/repos/wjoel/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/wjoel/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/wjoel/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/wjoel/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjoel/metabase/labels{/name}","releases_url":"https://api.github.com/repos/wjoel/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/wjoel/metabase/deployments","created_at":"2017-03-30T15:40:00Z","updated_at":"2017-03-30T15:40:05Z","pushed_at":"2018-03-24T18:15:10Z","git_url":"git://github.com/wjoel/metabase.git","ssh_url":"git@github.com:wjoel/metabase.git","clone_url":"https://github.com/wjoel/metabase.git","svn_url":"https://github.com/wjoel/metabase","homepage":"http://metabase.com","size":65484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metabase:master","ref":"master","sha":"33402b94ccdbb7144eb881ba9de5a6a0fd3a20b4","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2018-04-11T01:16:51Z","pushed_at":"2018-04-11T02:23:36Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"https://metabase.com","size":68103,"stargazers_count":9367,"watchers_count":9367,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1150,"mirror_url":null,"archived":false,"open_issues_count":1603,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1150,"open_issues":1603,"watchers":9367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/4645"},"html":{"href":"https://github.com/metabase/metabase/pull/4645"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/4645"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/4645/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/4645/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/4645/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/ac9a737168d1a15752709ceb87d63b43bc56f963"}},"author_association":"NONE"}}
{"actor":{"display_login":"camsaul"}}