{"action":"created","issue":{"url":"https://api.github.com/repos/octobercms/library/issues/335","repository_url":"https://api.github.com/repos/octobercms/library","labels_url":"https://api.github.com/repos/octobercms/library/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/octobercms/library/issues/335/comments","events_url":"https://api.github.com/repos/octobercms/library/issues/335/events","html_url":"https://github.com/octobercms/library/pull/335","id":340890864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTk0MjMz","number":335,"title":"Enable use of unencrypted cookies","user":{"login":"pikanji","id":610221,"node_id":"MDQ6VXNlcjYxMDIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/610221?v=4","gravatar_id":"","url":"https://api.github.com/users/pikanji","html_url":"https://github.com/pikanji","followers_url":"https://api.github.com/users/pikanji/followers","following_url":"https://api.github.com/users/pikanji/following{/other_user}","gists_url":"https://api.github.com/users/pikanji/gists{/gist_id}","starred_url":"https://api.github.com/users/pikanji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pikanji/subscriptions","organizations_url":"https://api.github.com/users/pikanji/orgs","repos_url":"https://api.github.com/users/pikanji/repos","events_url":"https://api.github.com/users/pikanji/events{/privacy}","received_events_url":"https://api.github.com/users/pikanji/received_events","type":"User","site_admin":false},"labels":[{"id":409066024,"node_id":"MDU6TGFiZWw0MDkwNjYwMjQ=","url":"https://api.github.com/repos/octobercms/library/labels/Status:%20Revision%20Needed","name":"Status: Revision Needed","color":"E11D21","default":false},{"id":409066030,"node_id":"MDU6TGFiZWw0MDkwNjYwMzA=","url":"https://api.github.com/repos/octobercms/library/labels/Type:%20Conceptual%20Enhancement","name":"Type: Conceptual Enhancement","color":"BFE5BF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-13T05:56:02Z","updated_at":"2018-07-15T04:50:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/octobercms/library/pulls/335","html_url":"https://github.com/octobercms/library/pull/335","diff_url":"https://github.com/octobercms/library/pull/335.diff","patch_url":"https://github.com/octobercms/library/pull/335.patch"},"body":"Currently OctoberCMS encrypts all cookies, and thus it always tries to decrypt them on read.\r\nThis PR gives developers a chance to specify cookies that should not be decrypted.\r\n\r\nEven though `\\Illuminate\\Cookie\\Middleware\\EncryptCookies` provides `$except` field and `disableFor` method to specify a list of cookies that shouldn't be decrypted, current implementation of october lib does not make use of them.\r\n\r\nWith this modification, developer will be able to specify unencrypted cookies in `config/cookie.php` like below.\r\n```\r\n<?php\r\nreturn [\r\n    \"unencrypted_cookies\" => [\r\n        \"my_cookie\",\r\n    ],\r\n];\r\n```\r\n\r\nThis is useful when a developer wants to create cookies in frontend to pass data to backend."},"comment":{"url":"https://api.github.com/repos/octobercms/library/issues/comments/405067240","html_url":"https://github.com/octobercms/library/pull/335#issuecomment-405067240","issue_url":"https://api.github.com/repos/octobercms/library/issues/335","id":405067240,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTA2NzI0MA==","user":{"login":"LukeTowers","id":7253840,"node_id":"MDQ6VXNlcjcyNTM4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7253840?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeTowers","html_url":"https://github.com/LukeTowers","followers_url":"https://api.github.com/users/LukeTowers/followers","following_url":"https://api.github.com/users/LukeTowers/following{/other_user}","gists_url":"https://api.github.com/users/LukeTowers/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeTowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeTowers/subscriptions","organizations_url":"https://api.github.com/users/LukeTowers/orgs","repos_url":"https://api.github.com/users/LukeTowers/repos","events_url":"https://api.github.com/users/LukeTowers/events{/privacy}","received_events_url":"https://api.github.com/users/LukeTowers/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T04:50:24Z","updated_at":"2018-07-15T04:50:24Z","author_association":"MEMBER","body":"@pikanji thanks for the submission! I'll need a PR to octobercms/october adding config/cookie.php with a detailed comment following the style of the other config files on how this works (using the key `unecryptedCookies`) and then if you could also add some information to octobercms/docs that would be perfect."}}
{"actor":{"display_login":"LukeTowers"}}