{"action":"created","comment":{"url":"https://api.github.com/repos/Haivision/srt/pulls/comments/188447713","pull_request_review_id":120404947,"id":188447713,"diff_hunk":"@@ -434,16 +434,20 @@ endif()\n set (VIRTUAL_srt $<TARGET_OBJECTS:srt_virtual> $<TARGET_OBJECTS:haicrypt_virtual>)\n set (HEADERS_srt ${HEADERS_srt} ${HEADERS_srt_win32})\n \n+macro(srt_update_library_deps target)\n+\tlist (APPEND INSTALL_TARGETS ${target})\n+\ttarget_link_libraries(${target} PRIVATE ${SSL_LIBRARIES})\n+\tif (MICROSOFT)\n+\t\ttarget_link_libraries(${target} PRIVATE ws2_32.lib Iphlpapi.lib)","path":"CMakeLists.txt","position":8,"original_position":8,"commit_id":"7aaeeb34f98e16a6f153034e531cd1dbe97a9a2c","original_commit_id":"7aaeeb34f98e16a6f153034e531cd1dbe97a9a2c","user":{"login":"rndi","id":5641420,"avatar_url":"https://avatars0.githubusercontent.com/u/5641420?v=4","gravatar_id":"","url":"https://api.github.com/users/rndi","html_url":"https://github.com/rndi","followers_url":"https://api.github.com/users/rndi/followers","following_url":"https://api.github.com/users/rndi/following{/other_user}","gists_url":"https://api.github.com/users/rndi/gists{/gist_id}","starred_url":"https://api.github.com/users/rndi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rndi/subscriptions","organizations_url":"https://api.github.com/users/rndi/orgs","repos_url":"https://api.github.com/users/rndi/repos","events_url":"https://api.github.com/users/rndi/events{/privacy}","received_events_url":"https://api.github.com/users/rndi/received_events","type":"User","site_admin":false},"body":"I can't say I like adding a hard dependency on iphlpapi.dll just to add a check for API usage error that can arguably happen only during early prototyping/testing phase of an app. I think adding a note on the subject in API docs is much easier, safer, and cleaner.","created_at":"2018-05-15T21:50:58Z","updated_at":"2018-05-15T21:51:21Z","html_url":"https://github.com/Haivision/srt/pull/377#discussion_r188447713","pull_request_url":"https://api.github.com/repos/Haivision/srt/pulls/377","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Haivision/srt/pulls/comments/188447713"},"html":{"href":"https://github.com/Haivision/srt/pull/377#discussion_r188447713"},"pull_request":{"href":"https://api.github.com/repos/Haivision/srt/pulls/377"}}},"pull_request":{"url":"https://api.github.com/repos/Haivision/srt/pulls/377","id":186895163,"html_url":"https://github.com/Haivision/srt/pull/377","diff_url":"https://github.com/Haivision/srt/pull/377.diff","patch_url":"https://github.com/Haivision/srt/pull/377.patch","issue_url":"https://api.github.com/repos/Haivision/srt/issues/377","number":377,"state":"open","locked":false,"title":"Added check code for attempting rendezvous to self","user":{"login":"ethouris","id":9600392,"avatar_url":"https://avatars0.githubusercontent.com/u/9600392?v=4","gravatar_id":"","url":"https://api.github.com/users/ethouris","html_url":"https://github.com/ethouris","followers_url":"https://api.github.com/users/ethouris/followers","following_url":"https://api.github.com/users/ethouris/following{/other_user}","gists_url":"https://api.github.com/users/ethouris/gists{/gist_id}","starred_url":"https://api.github.com/users/ethouris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethouris/subscriptions","organizations_url":"https://api.github.com/users/ethouris/orgs","repos_url":"https://api.github.com/users/ethouris/repos","events_url":"https://api.github.com/users/ethouris/events{/privacy}","received_events_url":"https://api.github.com/users/ethouris/received_events","type":"User","site_admin":false},"body":"There's a problem when the Rendezvous connection mistakenly specifies a self address. In this case the connection facility gets confused by getting back packets that the agent himself has sent, taking these sent packets as if they came from the peer. This leads to misleading errors that result from interpreting packets that the agent shouldn't have received in the first place.\r\n\r\nThis fix causes error when `srt_connect` is called with target address that:\r\n* matches the adapter address, if the adapter IP was configured\r\n* matches any of the local machine IP addresses, if the socket was bound to INADDR_ANY","created_at":"2018-05-09T11:37:08Z","updated_at":"2018-05-15T21:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11509f209f5bf46842dc3f137a724fef8d8a5326","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Haivision/srt/pulls/377/commits","review_comments_url":"https://api.github.com/repos/Haivision/srt/pulls/377/comments","review_comment_url":"https://api.github.com/repos/Haivision/srt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Haivision/srt/issues/377/comments","statuses_url":"https://api.github.com/repos/Haivision/srt/statuses/7aaeeb34f98e16a6f153034e531cd1dbe97a9a2c","head":{"label":"ethouris:dev-add-rendezvous-to-self-prevention","ref":"dev-add-rendezvous-to-self-prevention","sha":"7aaeeb34f98e16a6f153034e531cd1dbe97a9a2c","user":{"login":"ethouris","id":9600392,"avatar_url":"https://avatars0.githubusercontent.com/u/9600392?v=4","gravatar_id":"","url":"https://api.github.com/users/ethouris","html_url":"https://github.com/ethouris","followers_url":"https://api.github.com/users/ethouris/followers","following_url":"https://api.github.com/users/ethouris/following{/other_user}","gists_url":"https://api.github.com/users/ethouris/gists{/gist_id}","starred_url":"https://api.github.com/users/ethouris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethouris/subscriptions","organizations_url":"https://api.github.com/users/ethouris/orgs","repos_url":"https://api.github.com/users/ethouris/repos","events_url":"https://api.github.com/users/ethouris/events{/privacy}","received_events_url":"https://api.github.com/users/ethouris/received_events","type":"User","site_admin":false},"repo":{"id":89270864,"name":"srt","full_name":"ethouris/srt","owner":{"login":"ethouris","id":9600392,"avatar_url":"https://avatars0.githubusercontent.com/u/9600392?v=4","gravatar_id":"","url":"https://api.github.com/users/ethouris","html_url":"https://github.com/ethouris","followers_url":"https://api.github.com/users/ethouris/followers","following_url":"https://api.github.com/users/ethouris/following{/other_user}","gists_url":"https://api.github.com/users/ethouris/gists{/gist_id}","starred_url":"https://api.github.com/users/ethouris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethouris/subscriptions","organizations_url":"https://api.github.com/users/ethouris/orgs","repos_url":"https://api.github.com/users/ethouris/repos","events_url":"https://api.github.com/users/ethouris/events{/privacy}","received_events_url":"https://api.github.com/users/ethouris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethouris/srt","description":"Secure, Reliable, Transport","fork":true,"url":"https://api.github.com/repos/ethouris/srt","forks_url":"https://api.github.com/repos/ethouris/srt/forks","keys_url":"https://api.github.com/repos/ethouris/srt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethouris/srt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethouris/srt/teams","hooks_url":"https://api.github.com/repos/ethouris/srt/hooks","issue_events_url":"https://api.github.com/repos/ethouris/srt/issues/events{/number}","events_url":"https://api.github.com/repos/ethouris/srt/events","assignees_url":"https://api.github.com/repos/ethouris/srt/assignees{/user}","branches_url":"https://api.github.com/repos/ethouris/srt/branches{/branch}","tags_url":"https://api.github.com/repos/ethouris/srt/tags","blobs_url":"https://api.github.com/repos/ethouris/srt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethouris/srt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethouris/srt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethouris/srt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethouris/srt/statuses/{sha}","languages_url":"https://api.github.com/repos/ethouris/srt/languages","stargazers_url":"https://api.github.com/repos/ethouris/srt/stargazers","contributors_url":"https://api.github.com/repos/ethouris/srt/contributors","subscribers_url":"https://api.github.com/repos/ethouris/srt/subscribers","subscription_url":"https://api.github.com/repos/ethouris/srt/subscription","commits_url":"https://api.github.com/repos/ethouris/srt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethouris/srt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethouris/srt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethouris/srt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethouris/srt/contents/{+path}","compare_url":"https://api.github.com/repos/ethouris/srt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethouris/srt/merges","archive_url":"https://api.github.com/repos/ethouris/srt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethouris/srt/downloads","issues_url":"https://api.github.com/repos/ethouris/srt/issues{/number}","pulls_url":"https://api.github.com/repos/ethouris/srt/pulls{/number}","milestones_url":"https://api.github.com/repos/ethouris/srt/milestones{/number}","notifications_url":"https://api.github.com/repos/ethouris/srt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethouris/srt/labels{/name}","releases_url":"https://api.github.com/repos/ethouris/srt/releases{/id}","deployments_url":"https://api.github.com/repos/ethouris/srt/deployments","created_at":"2017-04-24T17:57:54Z","updated_at":"2017-04-24T17:57:56Z","pushed_at":"2018-05-15T14:11:51Z","git_url":"git://github.com/ethouris/srt.git","ssh_url":"git@github.com:ethouris/srt.git","clone_url":"https://github.com/ethouris/srt.git","svn_url":"https://github.com/ethouris/srt","homepage":"http://srtalliance.org","size":3155,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Haivision:master","ref":"master","sha":"b851180429ea32297e5332e0c08e39ebc5cec334","user":{"login":"Haivision","id":1405927,"avatar_url":"https://avatars1.githubusercontent.com/u/1405927?v=4","gravatar_id":"","url":"https://api.github.com/users/Haivision","html_url":"https://github.com/Haivision","followers_url":"https://api.github.com/users/Haivision/followers","following_url":"https://api.github.com/users/Haivision/following{/other_user}","gists_url":"https://api.github.com/users/Haivision/gists{/gist_id}","starred_url":"https://api.github.com/users/Haivision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haivision/subscriptions","organizations_url":"https://api.github.com/users/Haivision/orgs","repos_url":"https://api.github.com/users/Haivision/repos","events_url":"https://api.github.com/users/Haivision/events{/privacy}","received_events_url":"https://api.github.com/users/Haivision/received_events","type":"Organization","site_admin":false},"repo":{"id":87443396,"name":"srt","full_name":"Haivision/srt","owner":{"login":"Haivision","id":1405927,"avatar_url":"https://avatars1.githubusercontent.com/u/1405927?v=4","gravatar_id":"","url":"https://api.github.com/users/Haivision","html_url":"https://github.com/Haivision","followers_url":"https://api.github.com/users/Haivision/followers","following_url":"https://api.github.com/users/Haivision/following{/other_user}","gists_url":"https://api.github.com/users/Haivision/gists{/gist_id}","starred_url":"https://api.github.com/users/Haivision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haivision/subscriptions","organizations_url":"https://api.github.com/users/Haivision/orgs","repos_url":"https://api.github.com/users/Haivision/repos","events_url":"https://api.github.com/users/Haivision/events{/privacy}","received_events_url":"https://api.github.com/users/Haivision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Haivision/srt","description":"Secure, Reliable, Transport","fork":false,"url":"https://api.github.com/repos/Haivision/srt","forks_url":"https://api.github.com/repos/Haivision/srt/forks","keys_url":"https://api.github.com/repos/Haivision/srt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Haivision/srt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Haivision/srt/teams","hooks_url":"https://api.github.com/repos/Haivision/srt/hooks","issue_events_url":"https://api.github.com/repos/Haivision/srt/issues/events{/number}","events_url":"https://api.github.com/repos/Haivision/srt/events","assignees_url":"https://api.github.com/repos/Haivision/srt/assignees{/user}","branches_url":"https://api.github.com/repos/Haivision/srt/branches{/branch}","tags_url":"https://api.github.com/repos/Haivision/srt/tags","blobs_url":"https://api.github.com/repos/Haivision/srt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Haivision/srt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Haivision/srt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Haivision/srt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Haivision/srt/statuses/{sha}","languages_url":"https://api.github.com/repos/Haivision/srt/languages","stargazers_url":"https://api.github.com/repos/Haivision/srt/stargazers","contributors_url":"https://api.github.com/repos/Haivision/srt/contributors","subscribers_url":"https://api.github.com/repos/Haivision/srt/subscribers","subscription_url":"https://api.github.com/repos/Haivision/srt/subscription","commits_url":"https://api.github.com/repos/Haivision/srt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Haivision/srt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Haivision/srt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Haivision/srt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Haivision/srt/contents/{+path}","compare_url":"https://api.github.com/repos/Haivision/srt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Haivision/srt/merges","archive_url":"https://api.github.com/repos/Haivision/srt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Haivision/srt/downloads","issues_url":"https://api.github.com/repos/Haivision/srt/issues{/number}","pulls_url":"https://api.github.com/repos/Haivision/srt/pulls{/number}","milestones_url":"https://api.github.com/repos/Haivision/srt/milestones{/number}","notifications_url":"https://api.github.com/repos/Haivision/srt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Haivision/srt/labels{/name}","releases_url":"https://api.github.com/repos/Haivision/srt/releases{/id}","deployments_url":"https://api.github.com/repos/Haivision/srt/deployments","created_at":"2017-04-06T15:11:42Z","updated_at":"2018-05-15T06:01:29Z","pushed_at":"2018-05-15T14:11:10Z","git_url":"git://github.com/Haivision/srt.git","ssh_url":"git@github.com:Haivision/srt.git","clone_url":"https://github.com/Haivision/srt.git","svn_url":"https://github.com/Haivision/srt","homepage":"https://www.srtalliance.org","size":2003,"stargazers_count":271,"watchers_count":271,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":83,"open_issues":124,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Haivision/srt/pulls/377"},"html":{"href":"https://github.com/Haivision/srt/pull/377"},"issue":{"href":"https://api.github.com/repos/Haivision/srt/issues/377"},"comments":{"href":"https://api.github.com/repos/Haivision/srt/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/Haivision/srt/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/Haivision/srt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Haivision/srt/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/Haivision/srt/statuses/7aaeeb34f98e16a6f153034e531cd1dbe97a9a2c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rndi"}}