{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1","id":169693847,"html_url":"https://github.com/tech-ascent/tech.datatype/pull/1","diff_url":"https://github.com/tech-ascent/tech.datatype/pull/1.diff","patch_url":"https://github.com/tech-ascent/tech.datatype/pull/1.patch","issue_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/1","number":1,"state":"open","locked":false,"title":"Graph based conversion","user":{"login":"cnuernber","id":40426,"avatar_url":"https://avatars2.githubusercontent.com/u/40426?v=4","gravatar_id":"","url":"https://api.github.com/users/cnuernber","html_url":"https://github.com/cnuernber","followers_url":"https://api.github.com/users/cnuernber/followers","following_url":"https://api.github.com/users/cnuernber/following{/other_user}","gists_url":"https://api.github.com/users/cnuernber/gists{/gist_id}","starred_url":"https://api.github.com/users/cnuernber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnuernber/subscriptions","organizations_url":"https://api.github.com/users/cnuernber/orgs","repos_url":"https://api.github.com/users/cnuernber/repos","events_url":"https://api.github.com/users/cnuernber/events{/privacy}","received_events_url":"https://api.github.com/users/cnuernber/received_events","type":"User","site_admin":false},"body":"The previous conversion system used protocols do to do n^2 conversion lookup.  So for example you have arrays and nio buffers.  And 6 datatypes.  That gives you 36 datatype conversion routines across 2 containers which adds another multiple of 4.  So there are more than 100 conversion routines just with this.  Trying to come up with a protocol-base conversion mechanism to take care of a full marshalling system between these two container types and 6 datatypes ended up with something that was very confusing.\r\n\r\nSo, in addition to moving things into the tech namespace I moved the entire marshalling system into a set of maps that point to functions.  \r\n\r\nThere is a base copy table that is complete for all combinations of  arrays, nio buffers, and datatypes.\r\n\r\nThere is also a conversion table that is checked if the base copy table doesn't contain the container type pairs.  So views, or a c pointer type would have a conversion to an array or a nio buffer, respectively and then the original conversion functions would work fine.  This cuts down dramatically on the complexity of integrating new container types into the mix.  Given that I have found many times where a mis-implemented protocol cause the system to hit the slow path (1000 times slower) I think it is wise to attempt to design a system that is a simple as possible around this rather performance sensitive area.","created_at":"2018-02-16T18:26:43Z","updated_at":"2018-02-16T18:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/1/comments","statuses_url":"https://api.github.com/repos/tech-ascent/tech.datatype/statuses/21937da26d71288b32742f78b628f030322e4a83","head":{"label":"tech-ascent:graph-based-conversion","ref":"graph-based-conversion","sha":"21937da26d71288b32742f78b628f030322e4a83","user":{"login":"tech-ascent","id":35818444,"avatar_url":"https://avatars1.githubusercontent.com/u/35818444?v=4","gravatar_id":"","url":"https://api.github.com/users/tech-ascent","html_url":"https://github.com/tech-ascent","followers_url":"https://api.github.com/users/tech-ascent/followers","following_url":"https://api.github.com/users/tech-ascent/following{/other_user}","gists_url":"https://api.github.com/users/tech-ascent/gists{/gist_id}","starred_url":"https://api.github.com/users/tech-ascent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech-ascent/subscriptions","organizations_url":"https://api.github.com/users/tech-ascent/orgs","repos_url":"https://api.github.com/users/tech-ascent/repos","events_url":"https://api.github.com/users/tech-ascent/events{/privacy}","received_events_url":"https://api.github.com/users/tech-ascent/received_events","type":"Organization","site_admin":false},"repo":{"id":121683412,"name":"tech.datatype","full_name":"tech-ascent/tech.datatype","owner":{"login":"tech-ascent","id":35818444,"avatar_url":"https://avatars1.githubusercontent.com/u/35818444?v=4","gravatar_id":"","url":"https://api.github.com/users/tech-ascent","html_url":"https://github.com/tech-ascent","followers_url":"https://api.github.com/users/tech-ascent/followers","following_url":"https://api.github.com/users/tech-ascent/following{/other_user}","gists_url":"https://api.github.com/users/tech-ascent/gists{/gist_id}","starred_url":"https://api.github.com/users/tech-ascent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech-ascent/subscriptions","organizations_url":"https://api.github.com/users/tech-ascent/orgs","repos_url":"https://api.github.com/users/tech-ascent/repos","events_url":"https://api.github.com/users/tech-ascent/events{/privacy}","received_events_url":"https://api.github.com/users/tech-ascent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tech-ascent/tech.datatype","description":null,"fork":true,"url":"https://api.github.com/repos/tech-ascent/tech.datatype","forks_url":"https://api.github.com/repos/tech-ascent/tech.datatype/forks","keys_url":"https://api.github.com/repos/tech-ascent/tech.datatype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tech-ascent/tech.datatype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tech-ascent/tech.datatype/teams","hooks_url":"https://api.github.com/repos/tech-ascent/tech.datatype/hooks","issue_events_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/events{/number}","events_url":"https://api.github.com/repos/tech-ascent/tech.datatype/events","assignees_url":"https://api.github.com/repos/tech-ascent/tech.datatype/assignees{/user}","branches_url":"https://api.github.com/repos/tech-ascent/tech.datatype/branches{/branch}","tags_url":"https://api.github.com/repos/tech-ascent/tech.datatype/tags","blobs_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/refs{/sha}","trees_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tech-ascent/tech.datatype/statuses/{sha}","languages_url":"https://api.github.com/repos/tech-ascent/tech.datatype/languages","stargazers_url":"https://api.github.com/repos/tech-ascent/tech.datatype/stargazers","contributors_url":"https://api.github.com/repos/tech-ascent/tech.datatype/contributors","subscribers_url":"https://api.github.com/repos/tech-ascent/tech.datatype/subscribers","subscription_url":"https://api.github.com/repos/tech-ascent/tech.datatype/subscription","commits_url":"https://api.github.com/repos/tech-ascent/tech.datatype/commits{/sha}","git_commits_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/commits{/sha}","comments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/comments{/number}","issue_comment_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/comments{/number}","contents_url":"https://api.github.com/repos/tech-ascent/tech.datatype/contents/{+path}","compare_url":"https://api.github.com/repos/tech-ascent/tech.datatype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tech-ascent/tech.datatype/merges","archive_url":"https://api.github.com/repos/tech-ascent/tech.datatype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tech-ascent/tech.datatype/downloads","issues_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues{/number}","pulls_url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls{/number}","milestones_url":"https://api.github.com/repos/tech-ascent/tech.datatype/milestones{/number}","notifications_url":"https://api.github.com/repos/tech-ascent/tech.datatype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tech-ascent/tech.datatype/labels{/name}","releases_url":"https://api.github.com/repos/tech-ascent/tech.datatype/releases{/id}","deployments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/deployments","created_at":"2018-02-15T21:12:42Z","updated_at":"2018-02-15T21:13:13Z","pushed_at":"2018-02-16T18:14:24Z","git_url":"git://github.com/tech-ascent/tech.datatype.git","ssh_url":"git@github.com:tech-ascent/tech.datatype.git","clone_url":"https://github.com/tech-ascent/tech.datatype.git","svn_url":"https://github.com/tech-ascent/tech.datatype","homepage":null,"size":61,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tech-ascent:master","ref":"master","sha":"28b9c4b8adee3ca97f4c4d9f25c92cf46bf0d1ba","user":{"login":"tech-ascent","id":35818444,"avatar_url":"https://avatars1.githubusercontent.com/u/35818444?v=4","gravatar_id":"","url":"https://api.github.com/users/tech-ascent","html_url":"https://github.com/tech-ascent","followers_url":"https://api.github.com/users/tech-ascent/followers","following_url":"https://api.github.com/users/tech-ascent/following{/other_user}","gists_url":"https://api.github.com/users/tech-ascent/gists{/gist_id}","starred_url":"https://api.github.com/users/tech-ascent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech-ascent/subscriptions","organizations_url":"https://api.github.com/users/tech-ascent/orgs","repos_url":"https://api.github.com/users/tech-ascent/repos","events_url":"https://api.github.com/users/tech-ascent/events{/privacy}","received_events_url":"https://api.github.com/users/tech-ascent/received_events","type":"Organization","site_admin":false},"repo":{"id":121683412,"name":"tech.datatype","full_name":"tech-ascent/tech.datatype","owner":{"login":"tech-ascent","id":35818444,"avatar_url":"https://avatars1.githubusercontent.com/u/35818444?v=4","gravatar_id":"","url":"https://api.github.com/users/tech-ascent","html_url":"https://github.com/tech-ascent","followers_url":"https://api.github.com/users/tech-ascent/followers","following_url":"https://api.github.com/users/tech-ascent/following{/other_user}","gists_url":"https://api.github.com/users/tech-ascent/gists{/gist_id}","starred_url":"https://api.github.com/users/tech-ascent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tech-ascent/subscriptions","organizations_url":"https://api.github.com/users/tech-ascent/orgs","repos_url":"https://api.github.com/users/tech-ascent/repos","events_url":"https://api.github.com/users/tech-ascent/events{/privacy}","received_events_url":"https://api.github.com/users/tech-ascent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tech-ascent/tech.datatype","description":null,"fork":true,"url":"https://api.github.com/repos/tech-ascent/tech.datatype","forks_url":"https://api.github.com/repos/tech-ascent/tech.datatype/forks","keys_url":"https://api.github.com/repos/tech-ascent/tech.datatype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tech-ascent/tech.datatype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tech-ascent/tech.datatype/teams","hooks_url":"https://api.github.com/repos/tech-ascent/tech.datatype/hooks","issue_events_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/events{/number}","events_url":"https://api.github.com/repos/tech-ascent/tech.datatype/events","assignees_url":"https://api.github.com/repos/tech-ascent/tech.datatype/assignees{/user}","branches_url":"https://api.github.com/repos/tech-ascent/tech.datatype/branches{/branch}","tags_url":"https://api.github.com/repos/tech-ascent/tech.datatype/tags","blobs_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/refs{/sha}","trees_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tech-ascent/tech.datatype/statuses/{sha}","languages_url":"https://api.github.com/repos/tech-ascent/tech.datatype/languages","stargazers_url":"https://api.github.com/repos/tech-ascent/tech.datatype/stargazers","contributors_url":"https://api.github.com/repos/tech-ascent/tech.datatype/contributors","subscribers_url":"https://api.github.com/repos/tech-ascent/tech.datatype/subscribers","subscription_url":"https://api.github.com/repos/tech-ascent/tech.datatype/subscription","commits_url":"https://api.github.com/repos/tech-ascent/tech.datatype/commits{/sha}","git_commits_url":"https://api.github.com/repos/tech-ascent/tech.datatype/git/commits{/sha}","comments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/comments{/number}","issue_comment_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/comments{/number}","contents_url":"https://api.github.com/repos/tech-ascent/tech.datatype/contents/{+path}","compare_url":"https://api.github.com/repos/tech-ascent/tech.datatype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tech-ascent/tech.datatype/merges","archive_url":"https://api.github.com/repos/tech-ascent/tech.datatype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tech-ascent/tech.datatype/downloads","issues_url":"https://api.github.com/repos/tech-ascent/tech.datatype/issues{/number}","pulls_url":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls{/number}","milestones_url":"https://api.github.com/repos/tech-ascent/tech.datatype/milestones{/number}","notifications_url":"https://api.github.com/repos/tech-ascent/tech.datatype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tech-ascent/tech.datatype/labels{/name}","releases_url":"https://api.github.com/repos/tech-ascent/tech.datatype/releases{/id}","deployments_url":"https://api.github.com/repos/tech-ascent/tech.datatype/deployments","created_at":"2018-02-15T21:12:42Z","updated_at":"2018-02-15T21:13:13Z","pushed_at":"2018-02-16T18:14:24Z","git_url":"git://github.com/tech-ascent/tech.datatype.git","ssh_url":"git@github.com:tech-ascent/tech.datatype.git","clone_url":"https://github.com/tech-ascent/tech.datatype.git","svn_url":"https://github.com/tech-ascent/tech.datatype","homepage":null,"size":61,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1"},"html":{"href":"https://github.com/tech-ascent/tech.datatype/pull/1"},"issue":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/1"},"comments":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tech-ascent/tech.datatype/statuses/21937da26d71288b32742f78b628f030322e4a83"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":262,"deletions":220,"changed_files":3}}
{"actor":{"display_login":"cnuernber"}}