{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28249","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28249/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28249/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28249/events","html_url":"https://github.com/cockroachdb/cockroach/pull/28249","id":347464986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDgzMzY0","number":28249,"title":"cli: allow `node status` to work in unavailable/broken clusters","user":{"login":"petermattis","id":6201335,"node_id":"MDQ6VXNlcjYyMDEzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-03T16:44:33Z","updated_at":"2018-08-03T18:03:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28249","html_url":"https://github.com/cockroachdb/cockroach/pull/28249","diff_url":"https://github.com/cockroachdb/cockroach/pull/28249.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28249.patch"},"body":"Expand the `crdb_internal.gossip_liveness` table to include columns\nneeded to satisfy the basic usage of `node status`. Specifically, added\n`address`, `build`, `started_at`, `updated_at` and `replicas`\ncolumns. Changed `node status` to use `gossip_liveness` instead of\n`kv_node_status`. The latter table requires the range containing the\nconsistent node status descriptors to be available, while\n`gossip_liveness` only retrieves info from gossip.\n\n`node status` and `node status --decommission` will work on\nunavailable/broken clusters as long as the node they are pointed to is\nup. `node status {--stats,--ranges,--all}` continue to require a\nreasonably healthy cluster.\n\nFixes #16489\n\nRelease note (cli change): Enhance `node status` to work on\nunavailable/broken clusters."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/410331872","html_url":"https://github.com/cockroachdb/cockroach/pull/28249#issuecomment-410331872","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28249","id":410331872,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDMzMTg3Mg==","user":{"login":"petermattis","id":6201335,"node_id":"MDQ6VXNlcjYyMDEzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T18:03:29Z","updated_at":"2018-08-03T18:03:29Z","author_association":"CONTRIBUTOR","body":"> Rather than extend gossip_liveness, perhaps I should be adding these new fields to gossip_nodes and then joining with that table.\r\n\r\nThis is done. Still need to add a test. "}}
{"actor":{"display_login":"petermattis"}}