{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/188339599","pull_request_review_id":120297622,"id":188339599,"diff_hunk":"@@ -22,4 +22,4 @@ COPY ./jaeger-ui-build /go/src/jaeger-ui-build\n COPY ./cmd/standalone/standalone-linux /go/bin/\n COPY ./cmd/standalone/sampling_strategies.json /go/src/config/\n \n-CMD [\"/go/bin/standalone-linux\",\"--query.static-files=/go/src/jaeger-ui-build/build/\",\"--sampling.strategies-file=/go/src/config/sampling_strategies.json\"]\n+ENTRYPOINT [\"/go/bin/standalone-linux\", \"--query.static-files=/go/src/jaeger-ui-build/build/\", \"--sampling.strategies-file=/go/src/config/sampling_strategies.json\"]","path":"cmd/standalone/Dockerfile","position":5,"original_position":5,"commit_id":"864d66b645a3c1e05c7abcde07f9a970e918c349","original_commit_id":"864d66b645a3c1e05c7abcde07f9a970e918c349","user":{"login":"zdicesare","id":1680362,"avatar_url":"https://avatars0.githubusercontent.com/u/1680362?v=4","gravatar_id":"","url":"https://api.github.com/users/zdicesare","html_url":"https://github.com/zdicesare","followers_url":"https://api.github.com/users/zdicesare/followers","following_url":"https://api.github.com/users/zdicesare/following{/other_user}","gists_url":"https://api.github.com/users/zdicesare/gists{/gist_id}","starred_url":"https://api.github.com/users/zdicesare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdicesare/subscriptions","organizations_url":"https://api.github.com/users/zdicesare/orgs","repos_url":"https://api.github.com/users/zdicesare/repos","events_url":"https://api.github.com/users/zdicesare/events{/privacy}","received_events_url":"https://api.github.com/users/zdicesare/received_events","type":"User","site_admin":false},"body":"I had interpreted the suggested change as eliminating all other flags, so that passing in `--collector.queue-size=10` instead of specifying it in the config file would be an error.\r\n\r\nAlso,  overriding the config file will require a volume mount specified in `docker run`, right?","created_at":"2018-05-15T15:47:35Z","updated_at":"2018-05-15T15:47:35Z","html_url":"https://github.com/jaegertracing/jaeger/pull/815#discussion_r188339599","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/188339599"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/815#discussion_r188339599"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815"}},"in_reply_to_id":188199126},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815","id":187651110,"html_url":"https://github.com/jaegertracing/jaeger/pull/815","diff_url":"https://github.com/jaegertracing/jaeger/pull/815.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/815.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/815","number":815,"state":"open","locked":false,"title":"Update Dockerfiles to reference executable via ENTRYPOINT","user":{"login":"zdicesare","id":1680362,"avatar_url":"https://avatars0.githubusercontent.com/u/1680362?v=4","gravatar_id":"","url":"https://api.github.com/users/zdicesare","html_url":"https://github.com/zdicesare","followers_url":"https://api.github.com/users/zdicesare/followers","following_url":"https://api.github.com/users/zdicesare/following{/other_user}","gists_url":"https://api.github.com/users/zdicesare/gists{/gist_id}","starred_url":"https://api.github.com/users/zdicesare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdicesare/subscriptions","organizations_url":"https://api.github.com/users/zdicesare/orgs","repos_url":"https://api.github.com/users/zdicesare/repos","events_url":"https://api.github.com/users/zdicesare/events{/privacy}","received_events_url":"https://api.github.com/users/zdicesare/received_events","type":"User","site_admin":false},"body":"In all Dockerfiles, reference the executable in ENTRYPOINT to allow\r\nconsumers to override default parameters without needing to specify\r\nthe executable path. Standard defaults move to ENTRYPOINT too for the same reason.\r\n\r\nSigned-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>\r\n\r\n<!--\r\nWe appreciate your contribution to the Jaeger project! 👋🎉\r\n\r\nBefore creating a pull request, please make sure:\r\n- Your PR is solving one problem\r\n- You have read the guide for contributing\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md\r\n- You signed all your commits (otherwise we won't be able to merge the PR)\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING.md#sign-your-work\r\n- You added unit tests for the new functionality\r\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\r\n-->\r\n\r\n## Which problem is this PR solving?\r\n-  Resolves #802 \r\n\r\n## Short description of the changes\r\n- In all Dockerfiles, reference the executable path and standard default arguments in ENTRYPOINT \r\nto allow consumers to override defaults without needing to specify them again.\r\n\r\n- Move hotrod default argument to CMD\r\n","created_at":"2018-05-13T03:53:05Z","updated_at":"2018-05-15T15:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55d47bf8d5fe95d15fa8fca734dec6ca3c8c3957","assignee":null,"assignees":[],"requested_reviewers":[{"login":"black-adder","id":791791,"avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/815/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/864d66b645a3c1e05c7abcde07f9a970e918c349","head":{"label":"zdicesare:feature/dockerfile-entrypoint","ref":"feature/dockerfile-entrypoint","sha":"864d66b645a3c1e05c7abcde07f9a970e918c349","user":{"login":"zdicesare","id":1680362,"avatar_url":"https://avatars0.githubusercontent.com/u/1680362?v=4","gravatar_id":"","url":"https://api.github.com/users/zdicesare","html_url":"https://github.com/zdicesare","followers_url":"https://api.github.com/users/zdicesare/followers","following_url":"https://api.github.com/users/zdicesare/following{/other_user}","gists_url":"https://api.github.com/users/zdicesare/gists{/gist_id}","starred_url":"https://api.github.com/users/zdicesare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdicesare/subscriptions","organizations_url":"https://api.github.com/users/zdicesare/orgs","repos_url":"https://api.github.com/users/zdicesare/repos","events_url":"https://api.github.com/users/zdicesare/events{/privacy}","received_events_url":"https://api.github.com/users/zdicesare/received_events","type":"User","site_admin":false},"repo":{"id":133191964,"name":"jaeger","full_name":"zdicesare/jaeger","owner":{"login":"zdicesare","id":1680362,"avatar_url":"https://avatars0.githubusercontent.com/u/1680362?v=4","gravatar_id":"","url":"https://api.github.com/users/zdicesare","html_url":"https://github.com/zdicesare","followers_url":"https://api.github.com/users/zdicesare/followers","following_url":"https://api.github.com/users/zdicesare/following{/other_user}","gists_url":"https://api.github.com/users/zdicesare/gists{/gist_id}","starred_url":"https://api.github.com/users/zdicesare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdicesare/subscriptions","organizations_url":"https://api.github.com/users/zdicesare/orgs","repos_url":"https://api.github.com/users/zdicesare/repos","events_url":"https://api.github.com/users/zdicesare/events{/privacy}","received_events_url":"https://api.github.com/users/zdicesare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zdicesare/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/zdicesare/jaeger","forks_url":"https://api.github.com/repos/zdicesare/jaeger/forks","keys_url":"https://api.github.com/repos/zdicesare/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zdicesare/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zdicesare/jaeger/teams","hooks_url":"https://api.github.com/repos/zdicesare/jaeger/hooks","issue_events_url":"https://api.github.com/repos/zdicesare/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/zdicesare/jaeger/events","assignees_url":"https://api.github.com/repos/zdicesare/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/zdicesare/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/zdicesare/jaeger/tags","blobs_url":"https://api.github.com/repos/zdicesare/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zdicesare/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zdicesare/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/zdicesare/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zdicesare/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/zdicesare/jaeger/languages","stargazers_url":"https://api.github.com/repos/zdicesare/jaeger/stargazers","contributors_url":"https://api.github.com/repos/zdicesare/jaeger/contributors","subscribers_url":"https://api.github.com/repos/zdicesare/jaeger/subscribers","subscription_url":"https://api.github.com/repos/zdicesare/jaeger/subscription","commits_url":"https://api.github.com/repos/zdicesare/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/zdicesare/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/zdicesare/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/zdicesare/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/zdicesare/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/zdicesare/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zdicesare/jaeger/merges","archive_url":"https://api.github.com/repos/zdicesare/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zdicesare/jaeger/downloads","issues_url":"https://api.github.com/repos/zdicesare/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/zdicesare/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/zdicesare/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/zdicesare/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zdicesare/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/zdicesare/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/zdicesare/jaeger/deployments","created_at":"2018-05-12T23:56:50Z","updated_at":"2018-05-12T23:56:53Z","pushed_at":"2018-05-15T00:51:28Z","git_url":"git://github.com/zdicesare/jaeger.git","ssh_url":"git@github.com:zdicesare/jaeger.git","clone_url":"https://github.com/zdicesare/jaeger.git","svn_url":"https://github.com/zdicesare/jaeger","homepage":"https://jaegertracing.io/","size":2793,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"a4706c0d0ea9e11377581cbf42c0c11de7f91df8","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"name":"jaeger","full_name":"jaegertracing/jaeger","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-05-15T15:47:14Z","pushed_at":"2018-05-15T00:51:31Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":2791,"stargazers_count":4660,"watchers_count":4660,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":373,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":373,"open_issues":170,"watchers":4660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/815"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/815"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/815/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/815/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/864d66b645a3c1e05c7abcde07f9a970e918c349"}},"author_association":"NONE"}}
{"actor":{"display_login":"zdicesare"}}