{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/SignalR/issues/2511","repository_url":"https://api.github.com/repos/aspnet/SignalR","labels_url":"https://api.github.com/repos/aspnet/SignalR/issues/2511/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/SignalR/issues/2511/comments","events_url":"https://api.github.com/repos/aspnet/SignalR/issues/2511/events","html_url":"https://github.com/aspnet/SignalR/issues/2511","id":333521619,"node_id":"MDU6SXNzdWUzMzM1MjE2MTk=","number":2511,"title":"signalr-protocol-msgpack.js points to the app directory to look for msgpack5.js","user":{"login":"dr130873","id":35321450,"node_id":"MDQ6VXNlcjM1MzIxNDUw","avatar_url":"https://avatars1.githubusercontent.com/u/35321450?v=4","gravatar_id":"","url":"https://api.github.com/users/dr130873","html_url":"https://github.com/dr130873","followers_url":"https://api.github.com/users/dr130873/followers","following_url":"https://api.github.com/users/dr130873/following{/other_user}","gists_url":"https://api.github.com/users/dr130873/gists{/gist_id}","starred_url":"https://api.github.com/users/dr130873/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dr130873/subscriptions","organizations_url":"https://api.github.com/users/dr130873/orgs","repos_url":"https://api.github.com/users/dr130873/repos","events_url":"https://api.github.com/users/dr130873/events{/privacy}","received_events_url":"https://api.github.com/users/dr130873/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-19T05:13:42Z","updated_at":"2018-06-19T21:56:03Z","closed_at":"2018-06-19T21:56:03Z","author_association":"NONE","body":"Hi there,\r\n\r\nFirst of all I would like to apologize if this seems like a silly question, but I think there is a issue in the signalr-protocol-msgpack.\r\n\r\nWe use gulp to bundle our js files, everything is working until I decided to use signalr-protocol-msgpack.\r\nNow when we execute gulp, I get an error stating that msgpack5.js could not be found in the application directory, other npm packages we use do not behave the same so can you please help me.\r\n\r\nThank you...\r\n\r\nversions indicated below \r\n{\r\n  \"@aspnet/signalr\": \"^1.0.0\",\r\n  \"@aspnet/signalr-protocol-msgpack\": \"^1.0.0\",\r\n  \"requirejs\": \"^2.3.5\",\r\n  \"devDependencies\": {\r\n    \"del\": \"^3.0.0\",\r\n    \"gulp\": \"^3.9.1\",\r\n    \"gulp-bundle-assets\": \"^2.29.0\",\r\n    \"gulp-clean\": \"^0.3.2\",\r\n    \"gulp-requirejs\": \"^1.0.0\",\r\n    \"gulp-strip-debug\": \"^1.1.0\",\r\n    \"gulp-uglify\": \"^3.0.0\",\r\n    \"pump\": \"^1.0.3\"\r\n  },\r\n\r\nvar gulp = require('gulp');\r\nvar rjs = require(\"requirejs\");\r\n\r\ngulp.task('signalr-bundle', function () {\r\n    var config = {\r\n        baseUrl: \"./\",\r\n        out: \"wwwroot/dist/signalr-bundle.js\",\r\n        include: [\r\n\r\n            './node_modules/@aspnet/signalr/dist/browser/signalr.min.js',\r\n            './node_modules/msgpack5/dist/msgpack5.js',\r\n            './node_modules/@aspnet/signalr-protocol-msgpack/dist/browser/signalr-protocol-msgpack.js'\r\n\r\n        ]\r\n    };\r\n    rjs.optimize(config, function (e) {\r\n        console.log(e);\r\n    });\r\n});\r\n\r\nwhen running this gulp task i get the following error\r\n\r\n{ [Error: Error: ENOENT: no such file or directory, open '{app folder}\\msgpack5.js'\r\nIn module tree:\r\n    node_modules/@aspnet/signalr-protocol-msgpack/dist/browser/signalr-protocol-msgpack.js\r\n    at Error (native)\r\n]\r\n  originalError: \r\n   { [Error: ENOENT: no such file or directory, open '{app folder}\\msgpack5.js']\r\n     errno: -4058,\r\n     code: 'ENOENT',\r\n     syscall: 'open',\r\n     path: 'C:\\\\{app folder}\\\\msgpack5.js',\r\n     fileName: 'C:/{app folder/msgpack5.js',\r\n     moduleTree: [ 'node_modules/@aspnet/signalr-protocol-msgpack/dist/browser/signalr-protocol-msgpack.js' ] } }\r\nProcess terminated with code 1.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/aspnet/SignalR/issues/comments/398559271","html_url":"https://github.com/aspnet/SignalR/issues/2511#issuecomment-398559271","issue_url":"https://api.github.com/repos/aspnet/SignalR/issues/2511","id":398559271,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODU1OTI3MQ==","user":{"login":"anurse","id":7574,"node_id":"MDQ6VXNlcjc1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7574?v=4","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T21:56:03Z","updated_at":"2018-06-19T21:56:03Z","author_association":"MEMBER","body":"You really should avoid using the full paths in `include`, it's not how requirejs is designed to work. I'd strongly suggest you try just specifying `@aspnet/signalr`, `@aspnet/signalr-protocol-msgpack` and `msgpack5` in `include` and, if necessary, use the `paths` value to point requirejs at the right files.\r\n\r\nAnyway, I'm closing this as the question has been answered. Feel free to comment further if you need clarification on something!"}}
{"actor":{"display_login":"anurse"}}