{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/174852545","pull_request_review_id":104286344,"id":174852545,"diff_hunk":"@@ -402,6 +403,12 @@ protected function configureFormFields(FormMapper $formMapper): void\n                             'siteId' => $this->getSubject() ? $this->getSubject()->getSite()->getId() : null,\n                         ],\n                     ])\n+                ->add('targetRedirectType', ChoiceType::class, [\n+                        'choices' => [\n+                            Response::HTTP_MOVED_PERMANENTLY => $this->trans('choice.redirect_permanent'),","path":"src/Admin/PageAdmin.php","position":14,"original_position":14,"commit_id":"37edc8534f0583186634e0525aeeb10b6b9560cb","original_commit_id":"37edc8534f0583186634e0525aeeb10b6b9560cb","user":{"login":"core23","id":3440437,"avatar_url":"https://avatars1.githubusercontent.com/u/3440437?v=4","gravatar_id":"","url":"https://api.github.com/users/core23","html_url":"https://github.com/core23","followers_url":"https://api.github.com/users/core23/followers","following_url":"https://api.github.com/users/core23/following{/other_user}","gists_url":"https://api.github.com/users/core23/gists{/gist_id}","starred_url":"https://api.github.com/users/core23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/core23/subscriptions","organizations_url":"https://api.github.com/users/core23/orgs","repos_url":"https://api.github.com/users/core23/repos","events_url":"https://api.github.com/users/core23/events{/privacy}","received_events_url":"https://api.github.com/users/core23/received_events","type":"User","site_admin":false},"body":"Please don't use `trans` anymore. It is deprecated: https://github.com/sonata-project/SonataAdminBundle/blob/3.x/src/Admin/AbstractAdmin.php#L1943\r\n\r\nTry to use `translation_domain` / `choice_translation_domain`.","created_at":"2018-03-15T16:46:15Z","updated_at":"2018-03-15T16:46:19Z","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/975#discussion_r174852545","pull_request_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/174852545"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/975#discussion_r174852545"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975","id":174650785,"html_url":"https://github.com/sonata-project/SonataPageBundle/pull/975","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/975.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/975.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/975","number":975,"state":"open","locked":false,"title":"add target redirect type to page","user":{"login":"n3o77","id":321891,"avatar_url":"https://avatars3.githubusercontent.com/u/321891?v=4","gravatar_id":"","url":"https://api.github.com/users/n3o77","html_url":"https://github.com/n3o77","followers_url":"https://api.github.com/users/n3o77/followers","following_url":"https://api.github.com/users/n3o77/following{/other_user}","gists_url":"https://api.github.com/users/n3o77/gists{/gist_id}","starred_url":"https://api.github.com/users/n3o77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3o77/subscriptions","organizations_url":"https://api.github.com/users/n3o77/orgs","repos_url":"https://api.github.com/users/n3o77/repos","events_url":"https://api.github.com/users/n3o77/events{/privacy}","received_events_url":"https://api.github.com/users/n3o77/received_events","type":"User","site_admin":false},"body":"I am targeting this branch, because it adds functionality to the latest version. This PR contains BC (needs database update for the page entity).\r\n\r\n## Changelog\r\n```markdown\r\n\r\n### Changed\r\n\r\n- Allow to specify the type of the redirect (301 or 302) when a target on the page is selected.\r\n- Displays if a page is redirected and if so to which route and its redirect type in the tree view.\r\n- Allows to filter pages which are a redirect or not.\r\n- Displays the status code of the redirect on the redirect page.\r\n\r\n```\r\n## Subject\r\n\r\nWe had to add multiple 301 redirects via the backend for some SEO stuff. This PR adds the functionality for this in configurable manner. I assume this could be useful for others.","created_at":"2018-03-13T12:55:27Z","updated_at":"2018-03-15T16:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4a51195851fba00de26d1c6da301e50864e6b0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":369793264,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels/major","name":"major","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/975/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/37edc8534f0583186634e0525aeeb10b6b9560cb","head":{"label":"n3o77:master","ref":"master","sha":"37edc8534f0583186634e0525aeeb10b6b9560cb","user":{"login":"n3o77","id":321891,"avatar_url":"https://avatars3.githubusercontent.com/u/321891?v=4","gravatar_id":"","url":"https://api.github.com/users/n3o77","html_url":"https://github.com/n3o77","followers_url":"https://api.github.com/users/n3o77/followers","following_url":"https://api.github.com/users/n3o77/following{/other_user}","gists_url":"https://api.github.com/users/n3o77/gists{/gist_id}","starred_url":"https://api.github.com/users/n3o77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3o77/subscriptions","organizations_url":"https://api.github.com/users/n3o77/orgs","repos_url":"https://api.github.com/users/n3o77/repos","events_url":"https://api.github.com/users/n3o77/events{/privacy}","received_events_url":"https://api.github.com/users/n3o77/received_events","type":"User","site_admin":false},"repo":{"id":76723692,"name":"SonataPageBundle","full_name":"n3o77/SonataPageBundle","owner":{"login":"n3o77","id":321891,"avatar_url":"https://avatars3.githubusercontent.com/u/321891?v=4","gravatar_id":"","url":"https://api.github.com/users/n3o77","html_url":"https://github.com/n3o77","followers_url":"https://api.github.com/users/n3o77/followers","following_url":"https://api.github.com/users/n3o77/following{/other_user}","gists_url":"https://api.github.com/users/n3o77/gists{/gist_id}","starred_url":"https://api.github.com/users/n3o77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3o77/subscriptions","organizations_url":"https://api.github.com/users/n3o77/orgs","repos_url":"https://api.github.com/users/n3o77/repos","events_url":"https://api.github.com/users/n3o77/events{/privacy}","received_events_url":"https://api.github.com/users/n3o77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n3o77/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/n3o77/SonataPageBundle","forks_url":"https://api.github.com/repos/n3o77/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/n3o77/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n3o77/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n3o77/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/n3o77/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/n3o77/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/n3o77/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/n3o77/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/n3o77/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/n3o77/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/n3o77/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n3o77/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n3o77/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/n3o77/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n3o77/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/n3o77/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/n3o77/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/n3o77/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/n3o77/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/n3o77/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/n3o77/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/n3o77/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/n3o77/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/n3o77/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/n3o77/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/n3o77/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n3o77/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/n3o77/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n3o77/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/n3o77/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/n3o77/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/n3o77/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/n3o77/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n3o77/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/n3o77/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/n3o77/SonataPageBundle/deployments","created_at":"2016-12-17T12:47:46Z","updated_at":"2016-12-17T12:47:49Z","pushed_at":"2018-03-14T12:18:58Z","git_url":"git://github.com/n3o77/SonataPageBundle.git","ssh_url":"git@github.com:n3o77/SonataPageBundle.git","clone_url":"https://github.com/n3o77/SonataPageBundle.git","svn_url":"https://github.com/n3o77/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":4278,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:master","ref":"master","sha":"6c551cd75f56ff2ac8ac122a7d844537301703fa","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/deployments","created_at":"2010-12-06T00:18:21Z","updated_at":"2018-02-22T12:59:54Z","pushed_at":"2018-03-14T12:19:00Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"https://sonata-project.org/","size":4261,"stargazers_count":162,"watchers_count":162,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":200,"open_issues":55,"watchers":162,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/975"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/975"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/975/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/975/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/37edc8534f0583186634e0525aeeb10b6b9560cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"core23"}}