{"action":"created","comment":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/comments/220978863","pull_request_review_id":159517163,"id":220978863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDk3ODg2Mw==","diff_hunk":"@@ -48,7 +48,10 @@ def validate(experiment_json: str, fuzz: bool=False) -> bool:\n \n     # validate experiment.json\n     experiment_validator = SpaceTxValidator(_get_absolute_schema_path('experiment.json'))\n-    valid &= experiment_validator.validate_object(experiment, name, fuzz=fuzz)\n+    if fuzz:","path":"validate_sptx/validate_sptx.py","position":5,"original_position":5,"commit_id":"c2c243085a45335eec62a2f5ba7fc4a98eb568c9","original_commit_id":"619ba7b87152ada7161f9d2e6ddbf403133264b3","user":{"login":"ambrosejcarr","id":5239152,"node_id":"MDQ6VXNlcjUyMzkxNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5239152?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrosejcarr","html_url":"https://github.com/ambrosejcarr","followers_url":"https://api.github.com/users/ambrosejcarr/followers","following_url":"https://api.github.com/users/ambrosejcarr/following{/other_user}","gists_url":"https://api.github.com/users/ambrosejcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrosejcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrosejcarr/subscriptions","organizations_url":"https://api.github.com/users/ambrosejcarr/orgs","repos_url":"https://api.github.com/users/ambrosejcarr/repos","events_url":"https://api.github.com/users/ambrosejcarr/events{/privacy}","received_events_url":"https://api.github.com/users/ambrosejcarr/received_events","type":"User","site_admin":false},"body":"> Interesting. I actually remembered the parent schema's referring to the child schemas. Perhaps this was something on the HCA side. I've listed this as a follow-up in #539.\r\n\r\nMy current level of understanding is that explicit `$ref` linking means that the file expects to see an `object` in place of the schema, rather than a file containing the object, meaning that we'd end up with one big json blob. If that's _wrong_, then there is a big opportunity for us to clean up the specification by removing these implicit links...","created_at":"2018-09-27T15:50:55Z","updated_at":"2018-09-27T15:50:56Z","html_url":"https://github.com/spacetx/starfish/pull/538#discussion_r220978863","pull_request_url":"https://api.github.com/repos/spacetx/starfish/pulls/538","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments/220978863"},"html":{"href":"https://github.com/spacetx/starfish/pull/538#discussion_r220978863"},"pull_request":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/538"}},"in_reply_to_id":219663769},"pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/538","id":214545199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTQ1MTk5","html_url":"https://github.com/spacetx/starfish/pull/538","diff_url":"https://github.com/spacetx/starfish/pull/538.diff","patch_url":"https://github.com/spacetx/starfish/pull/538.patch","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/538","number":538,"state":"closed","locked":false,"title":"Propagate validation","user":{"login":"joshmoore","id":88113,"node_id":"MDQ6VXNlcjg4MTEz","avatar_url":"https://avatars2.githubusercontent.com/u/88113?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"body":" * [x] handle @ttung comments from gh-523\r\n * [x] idea for a `strict` flag (and/or `STARFISH_STRICT_LOADING` variable) to `Experiment.from_json` \r\n   - [x] prevents needing to find every experiment loading and explicitly adding validation\r\n   - [ ] needs to cache the json rather than using `resolve_path_or_url` twice\r\n* [x] (temporarily) demonstrate tying together starfish & slicedimage without a release of slicedimage\r\n* [ ] decide between (or for both of) eager and lazy validation\r\n\r\nTest plan:\r\n * set STARFISH_STRICT_LOADING to true in your environment and then do any loading via Experiment.from_json.\r\n * Also try either corrupting a fileset or loading an older fileset and see the failure.","created_at":"2018-09-11T08:02:37Z","updated_at":"2018-09-27T15:50:56Z","closed_at":"2018-09-24T19:52:30Z","merged_at":"2018-09-24T19:52:30Z","merge_commit_sha":"7fbe21309419bfbf658276b23b62791a9f8fc9a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetx/starfish/pulls/538/commits","review_comments_url":"https://api.github.com/repos/spacetx/starfish/pulls/538/comments","review_comment_url":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/538/comments","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/c2c243085a45335eec62a2f5ba7fc4a98eb568c9","head":{"label":"joshmoore:propagate-validation","ref":"propagate-validation","sha":"c2c243085a45335eec62a2f5ba7fc4a98eb568c9","user":{"login":"joshmoore","id":88113,"node_id":"MDQ6VXNlcjg4MTEz","avatar_url":"https://avatars2.githubusercontent.com/u/88113?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"repo":{"id":138727687,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3Mjc2ODc=","name":"starfish","full_name":"joshmoore/starfish","private":false,"owner":{"login":"joshmoore","id":88113,"node_id":"MDQ6VXNlcjg4MTEz","avatar_url":"https://avatars2.githubusercontent.com/u/88113?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshmoore/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":true,"url":"https://api.github.com/repos/joshmoore/starfish","forks_url":"https://api.github.com/repos/joshmoore/starfish/forks","keys_url":"https://api.github.com/repos/joshmoore/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshmoore/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshmoore/starfish/teams","hooks_url":"https://api.github.com/repos/joshmoore/starfish/hooks","issue_events_url":"https://api.github.com/repos/joshmoore/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/joshmoore/starfish/events","assignees_url":"https://api.github.com/repos/joshmoore/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/joshmoore/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/joshmoore/starfish/tags","blobs_url":"https://api.github.com/repos/joshmoore/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshmoore/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshmoore/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshmoore/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshmoore/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/joshmoore/starfish/languages","stargazers_url":"https://api.github.com/repos/joshmoore/starfish/stargazers","contributors_url":"https://api.github.com/repos/joshmoore/starfish/contributors","subscribers_url":"https://api.github.com/repos/joshmoore/starfish/subscribers","subscription_url":"https://api.github.com/repos/joshmoore/starfish/subscription","commits_url":"https://api.github.com/repos/joshmoore/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshmoore/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshmoore/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshmoore/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshmoore/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/joshmoore/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshmoore/starfish/merges","archive_url":"https://api.github.com/repos/joshmoore/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshmoore/starfish/downloads","issues_url":"https://api.github.com/repos/joshmoore/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/joshmoore/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/joshmoore/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/joshmoore/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshmoore/starfish/labels{/name}","releases_url":"https://api.github.com/repos/joshmoore/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/joshmoore/starfish/deployments","created_at":"2018-06-26T11:20:55Z","updated_at":"2018-06-26T11:20:57Z","pushed_at":"2018-09-27T15:27:09Z","git_url":"git://github.com/joshmoore/starfish.git","ssh_url":"git@github.com:joshmoore/starfish.git","clone_url":"https://github.com/joshmoore/starfish.git","svn_url":"https://github.com/joshmoore/starfish","homepage":"","size":63073,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetx:master","ref":"master","sha":"6b4a0cc30ac05949658c6d1df9fcaa2a6db3b62a","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-09-27T08:40:59Z","pushed_at":"2018-09-27T15:27:10Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":63326,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":94,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/538"},"html":{"href":"https://github.com/spacetx/starfish/pull/538"},"issue":{"href":"https://api.github.com/repos/spacetx/starfish/issues/538"},"comments":{"href":"https://api.github.com/repos/spacetx/starfish/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/spacetx/starfish/statuses/c2c243085a45335eec62a2f5ba7fc4a98eb568c9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ambrosejcarr"}}