{"action":"opened","number":1258,"pull_request":{"url":"https://api.github.com/repos/OCA/server-tools/pulls/1258","id":190530800,"html_url":"https://github.com/OCA/server-tools/pull/1258","diff_url":"https://github.com/OCA/server-tools/pull/1258.diff","patch_url":"https://github.com/OCA/server-tools/pull/1258.patch","issue_url":"https://api.github.com/repos/OCA/server-tools/issues/1258","number":1258,"state":"open","locked":false,"title":"[FIX] auth_brute_force: Avoid storing false login attempts","user":{"login":"Yajo","id":973709,"avatar_url":"https://avatars0.githubusercontent.com/u/973709?v=4","gravatar_id":"","url":"https://api.github.com/users/Yajo","html_url":"https://github.com/Yajo","followers_url":"https://api.github.com/users/Yajo/followers","following_url":"https://api.github.com/users/Yajo/following{/other_user}","gists_url":"https://api.github.com/users/Yajo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yajo/subscriptions","organizations_url":"https://api.github.com/users/Yajo/orgs","repos_url":"https://api.github.com/users/Yajo/repos","events_url":"https://api.github.com/users/Yajo/events{/privacy}","received_events_url":"https://api.github.com/users/Yajo/received_events","type":"User","site_admin":false},"body":"In Odoo v9, every request calls `res.users.check()`, which stores one authentication attempt per request, which is false.\r\n\r\nBesides, it easily leads to hitting ip-api.com rate limits, so now that API is only asked when seeing in form view (simply by setting the computed field as not stored).\r\n\r\nAlso, form view was hidden, so it's now visible.\r\n\r\n@Tecnativa","created_at":"2018-05-25T09:29:40Z","updated_at":"2018-05-25T09:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/server-tools/pulls/1258/commits","review_comments_url":"https://api.github.com/repos/OCA/server-tools/pulls/1258/comments","review_comment_url":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/server-tools/issues/1258/comments","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/40ec9fc4eee5fcb7c6de7c46773d5a0255ade1b5","head":{"label":"Tecnativa:9.0-auth_brute_force","ref":"9.0-auth_brute_force","sha":"40ec9fc4eee5fcb7c6de7c46773d5a0255ade1b5","user":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars2.githubusercontent.com/u/18120193?v=4","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"repo":{"id":58931886,"name":"server-tools","full_name":"Tecnativa/server-tools","owner":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars2.githubusercontent.com/u/18120193?v=4","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tecnativa/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":true,"url":"https://api.github.com/repos/Tecnativa/server-tools","forks_url":"https://api.github.com/repos/Tecnativa/server-tools/forks","keys_url":"https://api.github.com/repos/Tecnativa/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tecnativa/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tecnativa/server-tools/teams","hooks_url":"https://api.github.com/repos/Tecnativa/server-tools/hooks","issue_events_url":"https://api.github.com/repos/Tecnativa/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Tecnativa/server-tools/events","assignees_url":"https://api.github.com/repos/Tecnativa/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Tecnativa/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Tecnativa/server-tools/tags","blobs_url":"https://api.github.com/repos/Tecnativa/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tecnativa/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tecnativa/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tecnativa/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tecnativa/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Tecnativa/server-tools/languages","stargazers_url":"https://api.github.com/repos/Tecnativa/server-tools/stargazers","contributors_url":"https://api.github.com/repos/Tecnativa/server-tools/contributors","subscribers_url":"https://api.github.com/repos/Tecnativa/server-tools/subscribers","subscription_url":"https://api.github.com/repos/Tecnativa/server-tools/subscription","commits_url":"https://api.github.com/repos/Tecnativa/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tecnativa/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tecnativa/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tecnativa/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tecnativa/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Tecnativa/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tecnativa/server-tools/merges","archive_url":"https://api.github.com/repos/Tecnativa/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tecnativa/server-tools/downloads","issues_url":"https://api.github.com/repos/Tecnativa/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Tecnativa/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Tecnativa/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Tecnativa/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tecnativa/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/Tecnativa/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Tecnativa/server-tools/deployments","created_at":"2016-05-16T12:48:36Z","updated_at":"2018-05-25T09:28:29Z","pushed_at":"2018-05-25T09:29:10Z","git_url":"git://github.com/Tecnativa/server-tools.git","ssh_url":"git@github.com:Tecnativa/server-tools.git","clone_url":"https://github.com/Tecnativa/server-tools.git","svn_url":"https://github.com/Tecnativa/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":18040,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"f61cb5ac0b8b87873a1de54f193905ad0f420682","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20896532,"name":"server-tools","full_name":"OCA/server-tools","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":false,"url":"https://api.github.com/repos/OCA/server-tools","forks_url":"https://api.github.com/repos/OCA/server-tools/forks","keys_url":"https://api.github.com/repos/OCA/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/server-tools/teams","hooks_url":"https://api.github.com/repos/OCA/server-tools/hooks","issue_events_url":"https://api.github.com/repos/OCA/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/server-tools/events","assignees_url":"https://api.github.com/repos/OCA/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/server-tools/tags","blobs_url":"https://api.github.com/repos/OCA/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/server-tools/languages","stargazers_url":"https://api.github.com/repos/OCA/server-tools/stargazers","contributors_url":"https://api.github.com/repos/OCA/server-tools/contributors","subscribers_url":"https://api.github.com/repos/OCA/server-tools/subscribers","subscription_url":"https://api.github.com/repos/OCA/server-tools/subscription","commits_url":"https://api.github.com/repos/OCA/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/server-tools/merges","archive_url":"https://api.github.com/repos/OCA/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/server-tools/downloads","issues_url":"https://api.github.com/repos/OCA/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/OCA/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/server-tools/deployments","created_at":"2014-06-16T18:52:44Z","updated_at":"2018-05-22T12:21:22Z","pushed_at":"2018-05-25T03:26:52Z","git_url":"git://github.com/OCA/server-tools.git","ssh_url":"git@github.com:OCA/server-tools.git","clone_url":"https://github.com/OCA/server-tools.git","svn_url":"https://github.com/OCA/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":18071,"stargazers_count":231,"watchers_count":231,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":677,"mirror_url":null,"archived":false,"open_issues_count":229,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":677,"open_issues":229,"watchers":231,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1258"},"html":{"href":"https://github.com/OCA/server-tools/pull/1258"},"issue":{"href":"https://api.github.com/repos/OCA/server-tools/issues/1258"},"comments":{"href":"https://api.github.com/repos/OCA/server-tools/issues/1258/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1258/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/1258/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/server-tools/statuses/40ec9fc4eee5fcb7c6de7c46773d5a0255ade1b5"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":7,"changed_files":4}}
{"actor":{"display_login":"Yajo"}}