{"action":"created","issue":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1744","repository_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework","labels_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1744/labels{/name}","comments_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1744/comments","events_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1744/events","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1744","id":315514402,"number":1744,"title":"Inline-images: Fix image distortion","user":{"login":"lyubomir-popov","id":2741678,"avatar_url":"https://avatars2.githubusercontent.com/u/2741678?v=4","gravatar_id":"","url":"https://api.github.com/users/lyubomir-popov","html_url":"https://github.com/lyubomir-popov","followers_url":"https://api.github.com/users/lyubomir-popov/followers","following_url":"https://api.github.com/users/lyubomir-popov/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir-popov/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir-popov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir-popov/subscriptions","organizations_url":"https://api.github.com/users/lyubomir-popov/orgs","repos_url":"https://api.github.com/users/lyubomir-popov/repos","events_url":"https://api.github.com/users/lyubomir-popov/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir-popov/received_events","type":"User","site_admin":false},"labels":[{"id":385881389,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Review:%20Code%20-1","name":"Review: Code -1","color":"c7162b","default":false},{"id":385881378,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Review:%20QA%20+1","name":"Review: QA +1","color":"0e8420","default":false},{"id":385881382,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Status:%20Review","name":"Status: Review","color":"888888","default":false}],"state":"open","locked":false,"assignee":{"login":"Caleb-Ellis","id":25733845,"avatar_url":"https://avatars3.githubusercontent.com/u/25733845?v=4","gravatar_id":"","url":"https://api.github.com/users/Caleb-Ellis","html_url":"https://github.com/Caleb-Ellis","followers_url":"https://api.github.com/users/Caleb-Ellis/followers","following_url":"https://api.github.com/users/Caleb-Ellis/following{/other_user}","gists_url":"https://api.github.com/users/Caleb-Ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/Caleb-Ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caleb-Ellis/subscriptions","organizations_url":"https://api.github.com/users/Caleb-Ellis/orgs","repos_url":"https://api.github.com/users/Caleb-Ellis/repos","events_url":"https://api.github.com/users/Caleb-Ellis/events{/privacy}","received_events_url":"https://api.github.com/users/Caleb-Ellis/received_events","type":"User","site_admin":false},"assignees":[{"login":"Caleb-Ellis","id":25733845,"avatar_url":"https://avatars3.githubusercontent.com/u/25733845?v=4","gravatar_id":"","url":"https://api.github.com/users/Caleb-Ellis","html_url":"https://github.com/Caleb-Ellis","followers_url":"https://api.github.com/users/Caleb-Ellis/followers","following_url":"https://api.github.com/users/Caleb-Ellis/following{/other_user}","gists_url":"https://api.github.com/users/Caleb-Ellis/gists{/gist_id}","starred_url":"https://api.github.com/users/Caleb-Ellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caleb-Ellis/subscriptions","organizations_url":"https://api.github.com/users/Caleb-Ellis/orgs","repos_url":"https://api.github.com/users/Caleb-Ellis/repos","events_url":"https://api.github.com/users/Caleb-Ellis/events{/privacy}","received_events_url":"https://api.github.com/users/Caleb-Ellis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-04-18T14:50:49Z","updated_at":"2018-04-19T09:17:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/pulls/1744","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1744","diff_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1744.diff","patch_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1744.patch"},"body":"## Done\r\n\r\n[List of work items including drive-bys]\r\n\r\n## QA\r\n\r\n- Pull code\r\n- Run `./run serve --watch`\r\n- Open http://0.0.0.0:8101/vanilla-framework/\r\n- [Add additional steps]\r\n\r\n## Details\r\n\r\n[List of links to issues/bugs and cards if needed]\r\n\r\n## Screenshots\r\n\r\n[if relevant, include a screenshot]\r\n"},"comment":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/comments/382668124","html_url":"https://github.com/vanilla-framework/vanilla-framework/pull/1744#issuecomment-382668124","issue_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1744","id":382668124,"user":{"login":"lyubomir-popov","id":2741678,"avatar_url":"https://avatars2.githubusercontent.com/u/2741678?v=4","gravatar_id":"","url":"https://api.github.com/users/lyubomir-popov","html_url":"https://github.com/lyubomir-popov","followers_url":"https://api.github.com/users/lyubomir-popov/followers","following_url":"https://api.github.com/users/lyubomir-popov/following{/other_user}","gists_url":"https://api.github.com/users/lyubomir-popov/gists{/gist_id}","starred_url":"https://api.github.com/users/lyubomir-popov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyubomir-popov/subscriptions","organizations_url":"https://api.github.com/users/lyubomir-popov/orgs","repos_url":"https://api.github.com/users/lyubomir-popov/repos","events_url":"https://api.github.com/users/lyubomir-popov/events{/privacy}","received_events_url":"https://api.github.com/users/lyubomir-popov/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T09:17:54Z","updated_at":"2018-04-19T09:17:54Z","author_association":"CONTRIBUTOR","body":"@Caleb-Ellis normally - yes, normally this should use $sph-inter. I've reverted the margin to what it was ($sp-xxx-large) as this pattern has a lot of hardcoded values and changing them without reiewing all instances is a bit risky. (The value from the map I had put in the above commit was equal to the old one).\r\n\r\nSo in the latest commit I've only replaced the max-height, leaving the margin as it was.\r\n\r\n"}}
{"actor":{"display_login":"lyubomir-popov"}}