{"action":"created","issue":{"url":"https://api.github.com/repos/Talend/ui/issues/1818","repository_url":"https://api.github.com/repos/Talend/ui","labels_url":"https://api.github.com/repos/Talend/ui/issues/1818/labels{/name}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1818/comments","events_url":"https://api.github.com/repos/Talend/ui/issues/1818/events","html_url":"https://github.com/Talend/ui/pull/1818","id":379733979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTAxNzQ2","number":1818,"title":"fix(forms): Exclude readonly fields from label focus style","user":{"login":"annilsson","id":36537247,"node_id":"MDQ6VXNlcjM2NTM3MjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/36537247?v=4","gravatar_id":"","url":"https://api.github.com/users/annilsson","html_url":"https://github.com/annilsson","followers_url":"https://api.github.com/users/annilsson/followers","following_url":"https://api.github.com/users/annilsson/following{/other_user}","gists_url":"https://api.github.com/users/annilsson/gists{/gist_id}","starred_url":"https://api.github.com/users/annilsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annilsson/subscriptions","organizations_url":"https://api.github.com/users/annilsson/orgs","repos_url":"https://api.github.com/users/annilsson/repos","events_url":"https://api.github.com/users/annilsson/events{/privacy}","received_events_url":"https://api.github.com/users/annilsson/received_events","type":"User","site_admin":false},"labels":[{"id":530809343,"node_id":"MDU6TGFiZWw1MzA4MDkzNDM=","url":"https://api.github.com/repos/Talend/ui/labels/easy%20review","name":"easy review","color":"ff69b4","default":false},{"id":521021722,"node_id":"MDU6TGFiZWw1MjEwMjE3MjI=","url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-12T11:25:59Z","updated_at":"2018-11-12T16:50:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1818","html_url":"https://github.com/Talend/ui/pull/1818","diff_url":"https://github.com/Talend/ui/pull/1818.diff","patch_url":"https://github.com/Talend/ui/pull/1818.patch"},"body":"**What is the problem this PR is trying to solve?**\r\nIf you click on a readonly empty field the label will move up. This is confusing since you can't write anything anyway. \r\n\r\n![readonly-empty](https://user-images.githubusercontent.com/36537247/48350725-5cb35f00-e688-11e8-97bc-0ae7d5612ab7.gif)\r\n\r\n**What is the chosen solution to this problem?**\r\nExclude readonly fields from the focus style on the label. \r\n\r\nstorybook: Add an empty readonly in forms -> widgets\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n* [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n* [ ] Tests for the changes have been added (for bug fixes / features) And [non reg](./screenshots.md) done before need review\r\n* [ ] Docs have been added / updated (for bug fixes / features)\r\n* [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- if the PR introduces a breaking change, add the description here. So when you merge this PR, add this description into the [breaking change wiki](https://github.com/Talend/ui/wiki/BREAKING-CHANGE) in the next version -->\r\n\r\n<!-- **Original Template** -->\r\n\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n"},"comment":{"url":"https://api.github.com/repos/Talend/ui/issues/comments/437951733","html_url":"https://github.com/Talend/ui/pull/1818#issuecomment-437951733","issue_url":"https://api.github.com/repos/Talend/ui/issues/1818","id":437951733,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzk1MTczMw==","user":{"login":"build-travis-ci","id":28656273,"node_id":"MDQ6VXNlcjI4NjU2Mjcz","avatar_url":"https://avatars0.githubusercontent.com/u/28656273?v=4","gravatar_id":"","url":"https://api.github.com/users/build-travis-ci","html_url":"https://github.com/build-travis-ci","followers_url":"https://api.github.com/users/build-travis-ci/followers","following_url":"https://api.github.com/users/build-travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/build-travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/build-travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-travis-ci/subscriptions","organizations_url":"https://api.github.com/users/build-travis-ci/orgs","repos_url":"https://api.github.com/users/build-travis-ci/repos","events_url":"https://api.github.com/users/build-travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/build-travis-ci/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T16:50:31Z","updated_at":"2018-11-12T16:50:31Z","author_association":"COLLABORATOR","body":":octocat: [Demo is available here](http://1818.talend.surge.sh) "}}
{"actor":{"display_login":"build-travis-ci"}}