{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/221280740","pull_request_review_id":159893887,"id":221280740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI4MDc0MA==","diff_hunk":"@@ -656,15 +657,24 @@ private void removeVertex(StreamNode toRemove) {\n \t */\n \t@SuppressWarnings(\"deprecation\")\n \tpublic JobGraph getJobGraph() {\n+\t\treturn getJobGraph(null);\n+\t}","path":"flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java","position":13,"original_position":13,"commit_id":"738860d213cf35f168f1c7dc27ffa64439a7c566","original_commit_id":"738860d213cf35f168f1c7dc27ffa64439a7c566","user":{"login":"tillrohrmann","id":5756858,"node_id":"MDQ6VXNlcjU3NTY4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5756858?v=4","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"We could move this implementation into `StreamingPlan`.","created_at":"2018-09-28T14:52:29Z","updated_at":"2018-09-28T14:54:52Z","html_url":"https://github.com/apache/flink/pull/6733#discussion_r221280740","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/6733","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/221280740"},"html":{"href":"https://github.com/apache/flink/pull/6733#discussion_r221280740"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/6733"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6733","id":217452315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDUyMzE1","html_url":"https://github.com/apache/flink/pull/6733","diff_url":"https://github.com/apache/flink/pull/6733.diff","patch_url":"https://github.com/apache/flink/pull/6733.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6733","number":6733,"state":"open","locked":false,"title":"[FLINK-10291] Generate JobGraph with fixed/configurable JobID in StandaloneJobClusterEntrypoint","user":{"login":"yanghua","id":2283778,"node_id":"MDQ6VXNlcjIyODM3Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\n*This pull request generate JobGraph with fixed JobID in StandaloneJobClusterEntrypoint*\r\n\r\n## Brief change log\r\n\r\n  - *Generate JobGraph with fixed JobID in StandaloneJobClusterEntrypoint*\r\n\r\n## Verifying this change\r\n\r\nThis change is already covered by existing tests, such as *StandaloneJobClusterEntryPointTest#testJobGraphRetrieval , testSavepointRestoreSettings*.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n  - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)\r\n","created_at":"2018-09-22T11:12:38Z","updated_at":"2018-09-28T14:54:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dfdadfa4f3cdd62743b545ac4f5354fb747730b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6733/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6733/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6733/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/738860d213cf35f168f1c7dc27ffa64439a7c566","head":{"label":"yanghua:FLINK-10291","ref":"FLINK-10291","sha":"738860d213cf35f168f1c7dc27ffa64439a7c566","user":{"login":"yanghua","id":2283778,"node_id":"MDQ6VXNlcjIyODM3Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"repo":{"id":90591055,"node_id":"MDEwOlJlcG9zaXRvcnk5MDU5MTA1NQ==","name":"flink","full_name":"yanghua/flink","private":false,"owner":{"login":"yanghua","id":2283778,"node_id":"MDQ6VXNlcjIyODM3Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yanghua/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/yanghua/flink","forks_url":"https://api.github.com/repos/yanghua/flink/forks","keys_url":"https://api.github.com/repos/yanghua/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanghua/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanghua/flink/teams","hooks_url":"https://api.github.com/repos/yanghua/flink/hooks","issue_events_url":"https://api.github.com/repos/yanghua/flink/issues/events{/number}","events_url":"https://api.github.com/repos/yanghua/flink/events","assignees_url":"https://api.github.com/repos/yanghua/flink/assignees{/user}","branches_url":"https://api.github.com/repos/yanghua/flink/branches{/branch}","tags_url":"https://api.github.com/repos/yanghua/flink/tags","blobs_url":"https://api.github.com/repos/yanghua/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanghua/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanghua/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanghua/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanghua/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/yanghua/flink/languages","stargazers_url":"https://api.github.com/repos/yanghua/flink/stargazers","contributors_url":"https://api.github.com/repos/yanghua/flink/contributors","subscribers_url":"https://api.github.com/repos/yanghua/flink/subscribers","subscription_url":"https://api.github.com/repos/yanghua/flink/subscription","commits_url":"https://api.github.com/repos/yanghua/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanghua/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanghua/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanghua/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanghua/flink/contents/{+path}","compare_url":"https://api.github.com/repos/yanghua/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanghua/flink/merges","archive_url":"https://api.github.com/repos/yanghua/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanghua/flink/downloads","issues_url":"https://api.github.com/repos/yanghua/flink/issues{/number}","pulls_url":"https://api.github.com/repos/yanghua/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/yanghua/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/yanghua/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanghua/flink/labels{/name}","releases_url":"https://api.github.com/repos/yanghua/flink/releases{/id}","deployments_url":"https://api.github.com/repos/yanghua/flink/deployments","created_at":"2017-05-08T05:51:50Z","updated_at":"2017-05-08T05:52:11Z","pushed_at":"2018-09-28T08:54:14Z","git_url":"git://github.com/yanghua/flink.git","ssh_url":"git@github.com:yanghua/flink.git","clone_url":"https://github.com/yanghua/flink.git","svn_url":"https://github.com/yanghua/flink","homepage":null,"size":161170,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f3432042fef908829dbdc1dcdc2b869fa6fc4005","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-28T14:37:03Z","pushed_at":"2018-09-28T14:35:12Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":165680,"stargazers_count":4496,"watchers_count":4496,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2926,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2926,"open_issues":400,"watchers":4496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6733"},"html":{"href":"https://github.com/apache/flink/pull/6733"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6733"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6733/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6733/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6733/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/738860d213cf35f168f1c7dc27ffa64439a7c566"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tillrohrmann"}}