{"action":"created","comment":{"url":"https://api.github.com/repos/solson/miri/pulls/comments/202587540","pull_request_review_id":137315337,"id":202587540,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU4NzU0MA==","diff_hunk":"@@ -81,7 +83,9 @@ impl<'a, 'mir, 'tcx> EvalContextExt<'tcx> for EvalContext<'a, 'mir, 'tcx, super:\n                     (Scalar::Bits { .. }, Scalar::Bits { .. }) => {\n                         left.to_bits(left_layout.size)? == right.to_bits(right_layout.size)?\n                     },\n+                    // FIXME: Test if both allocations are still live *or* if they are in the same allocation? (same for Ne below)","path":"src/operator.rs","position":13,"original_position":13,"commit_id":"d11c668a3900fcbad336eb470da8748a04000253","original_commit_id":"d11c668a3900fcbad336eb470da8748a04000253","user":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"makes sense. So we disallow comparing anything with dangling pointers and we're good?","created_at":"2018-07-16T07:07:20Z","updated_at":"2018-07-16T07:07:20Z","html_url":"https://github.com/solson/miri/pull/408#discussion_r202587540","pull_request_url":"https://api.github.com/repos/solson/miri/pulls/408","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/comments/202587540"},"html":{"href":"https://github.com/solson/miri/pull/408#discussion_r202587540"},"pull_request":{"href":"https://api.github.com/repos/solson/miri/pulls/408"}},"in_reply_to_id":202585943},"pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/408","id":201550843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTUwODQz","html_url":"https://github.com/solson/miri/pull/408","diff_url":"https://github.com/solson/miri/pull/408.diff","patch_url":"https://github.com/solson/miri/pull/408.patch","issue_url":"https://api.github.com/repos/solson/miri/issues/408","number":408,"state":"open","locked":false,"title":"Rustup","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"body":"Also leave some FIXMEs for the future in `operator.rs`.","created_at":"2018-07-16T06:41:01Z","updated_at":"2018-07-16T07:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0298b3be4c5f9a48a94d22d7e71365ab829de292","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solson/miri/pulls/408/commits","review_comments_url":"https://api.github.com/repos/solson/miri/pulls/408/comments","review_comment_url":"https://api.github.com/repos/solson/miri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solson/miri/issues/408/comments","statuses_url":"https://api.github.com/repos/solson/miri/statuses/d11c668a3900fcbad336eb470da8748a04000253","head":{"label":"RalfJung:rustup","ref":"rustup","sha":"d11c668a3900fcbad336eb470da8748a04000253","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"repo":{"id":92201225,"node_id":"MDEwOlJlcG9zaXRvcnk5MjIwMTIyNQ==","name":"miri","full_name":"RalfJung/miri","owner":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RalfJung/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":true,"url":"https://api.github.com/repos/RalfJung/miri","forks_url":"https://api.github.com/repos/RalfJung/miri/forks","keys_url":"https://api.github.com/repos/RalfJung/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RalfJung/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RalfJung/miri/teams","hooks_url":"https://api.github.com/repos/RalfJung/miri/hooks","issue_events_url":"https://api.github.com/repos/RalfJung/miri/issues/events{/number}","events_url":"https://api.github.com/repos/RalfJung/miri/events","assignees_url":"https://api.github.com/repos/RalfJung/miri/assignees{/user}","branches_url":"https://api.github.com/repos/RalfJung/miri/branches{/branch}","tags_url":"https://api.github.com/repos/RalfJung/miri/tags","blobs_url":"https://api.github.com/repos/RalfJung/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RalfJung/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RalfJung/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/RalfJung/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RalfJung/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/RalfJung/miri/languages","stargazers_url":"https://api.github.com/repos/RalfJung/miri/stargazers","contributors_url":"https://api.github.com/repos/RalfJung/miri/contributors","subscribers_url":"https://api.github.com/repos/RalfJung/miri/subscribers","subscription_url":"https://api.github.com/repos/RalfJung/miri/subscription","commits_url":"https://api.github.com/repos/RalfJung/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/RalfJung/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/RalfJung/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/RalfJung/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/RalfJung/miri/contents/{+path}","compare_url":"https://api.github.com/repos/RalfJung/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RalfJung/miri/merges","archive_url":"https://api.github.com/repos/RalfJung/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RalfJung/miri/downloads","issues_url":"https://api.github.com/repos/RalfJung/miri/issues{/number}","pulls_url":"https://api.github.com/repos/RalfJung/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/RalfJung/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/RalfJung/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RalfJung/miri/labels{/name}","releases_url":"https://api.github.com/repos/RalfJung/miri/releases{/id}","deployments_url":"https://api.github.com/repos/RalfJung/miri/deployments","created_at":"2017-05-23T17:32:26Z","updated_at":"2017-05-23T17:32:27Z","pushed_at":"2018-07-16T06:39:43Z","git_url":"git://github.com/RalfJung/miri.git","ssh_url":"git@github.com:RalfJung/miri.git","clone_url":"https://github.com/RalfJung/miri.git","svn_url":"https://github.com/RalfJung/miri","homepage":"","size":3076,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solson:master","ref":"master","sha":"fd6dad78f4b6d0babf0ae227221349388e80c405","user":{"login":"solson","id":26806,"node_id":"MDQ6VXNlcjI2ODA2","avatar_url":"https://avatars0.githubusercontent.com/u/26806?v=4","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"repo":{"id":46083140,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA4MzE0MA==","name":"miri","full_name":"solson/miri","owner":{"login":"solson","id":26806,"node_id":"MDQ6VXNlcjI2ODA2","avatar_url":"https://avatars0.githubusercontent.com/u/26806?v=4","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solson/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":false,"url":"https://api.github.com/repos/solson/miri","forks_url":"https://api.github.com/repos/solson/miri/forks","keys_url":"https://api.github.com/repos/solson/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solson/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solson/miri/teams","hooks_url":"https://api.github.com/repos/solson/miri/hooks","issue_events_url":"https://api.github.com/repos/solson/miri/issues/events{/number}","events_url":"https://api.github.com/repos/solson/miri/events","assignees_url":"https://api.github.com/repos/solson/miri/assignees{/user}","branches_url":"https://api.github.com/repos/solson/miri/branches{/branch}","tags_url":"https://api.github.com/repos/solson/miri/tags","blobs_url":"https://api.github.com/repos/solson/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solson/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solson/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/solson/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solson/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/solson/miri/languages","stargazers_url":"https://api.github.com/repos/solson/miri/stargazers","contributors_url":"https://api.github.com/repos/solson/miri/contributors","subscribers_url":"https://api.github.com/repos/solson/miri/subscribers","subscription_url":"https://api.github.com/repos/solson/miri/subscription","commits_url":"https://api.github.com/repos/solson/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/solson/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/solson/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/solson/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/solson/miri/contents/{+path}","compare_url":"https://api.github.com/repos/solson/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solson/miri/merges","archive_url":"https://api.github.com/repos/solson/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solson/miri/downloads","issues_url":"https://api.github.com/repos/solson/miri/issues{/number}","pulls_url":"https://api.github.com/repos/solson/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/solson/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/solson/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solson/miri/labels{/name}","releases_url":"https://api.github.com/repos/solson/miri/releases{/id}","deployments_url":"https://api.github.com/repos/solson/miri/deployments","created_at":"2015-11-12T21:51:25Z","updated_at":"2018-07-15T19:24:46Z","pushed_at":"2018-07-16T06:41:01Z","git_url":"git://github.com/solson/miri.git","ssh_url":"git@github.com:solson/miri.git","clone_url":"https://github.com/solson/miri.git","svn_url":"https://github.com/solson/miri","homepage":"","size":3089,"stargazers_count":399,"watchers_count":399,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":45,"open_issues":33,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/408"},"html":{"href":"https://github.com/solson/miri/pull/408"},"issue":{"href":"https://api.github.com/repos/solson/miri/issues/408"},"comments":{"href":"https://api.github.com/repos/solson/miri/issues/408/comments"},"review_comments":{"href":"https://api.github.com/repos/solson/miri/pulls/408/comments"},"review_comment":{"href":"https://api.github.com/repos/solson/miri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solson/miri/pulls/408/commits"},"statuses":{"href":"https://api.github.com/repos/solson/miri/statuses/d11c668a3900fcbad336eb470da8748a04000253"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"oli-obk"}}