{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments/231502769","pull_request_review_id":172486685,"id":231502769,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTUwMjc2OQ==","diff_hunk":"@@ -935,12 +942,142 @@ public ServerStatistics stats() {\n             buf[i] = (byte) executeResult.get(i);\n         }\n         try {\n+        \tif (buf.length != 0 ) {\n             return (T) jb.objectFromByteBuffer(buf);\n+        \t}","path":"jni/src/main/java/org/infinispan/client/hotrod/impl/RemoteCacheImpl.java","position":27,"original_position":27,"commit_id":"7d435667c8b8efb562acb2c37b17deee02c83544","original_commit_id":"7d435667c8b8efb562acb2c37b17deee02c83544","user":{"login":"alanfx","id":3027310,"node_id":"MDQ6VXNlcjMwMjczMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3027310?v=4","gravatar_id":"","url":"https://api.github.com/users/alanfx","html_url":"https://github.com/alanfx","followers_url":"https://api.github.com/users/alanfx/followers","following_url":"https://api.github.com/users/alanfx/following{/other_user}","gists_url":"https://api.github.com/users/alanfx/gists{/gist_id}","starred_url":"https://api.github.com/users/alanfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanfx/subscriptions","organizations_url":"https://api.github.com/users/alanfx/orgs","repos_url":"https://api.github.com/users/alanfx/repos","events_url":"https://api.github.com/users/alanfx/events{/privacy}","received_events_url":"https://api.github.com/users/alanfx/received_events","type":"User","site_admin":false},"body":"This should be `} else {` and the indentation looks a little weird here too. The `if (buf.length != 0 )` statement above doesn't line up with the `return`.","created_at":"2018-11-07T13:29:19Z","updated_at":"2018-11-07T13:44:13Z","html_url":"https://github.com/infinispan/cpp-client/pull/346#discussion_r231502769","pull_request_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/346","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments/231502769"},"html":{"href":"https://github.com/infinispan/cpp-client/pull/346#discussion_r231502769"},"pull_request":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/cpp-client/pulls/346","id":228854744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODU0NzQ0","html_url":"https://github.com/infinispan/cpp-client/pull/346","diff_url":"https://github.com/infinispan/cpp-client/pull/346.diff","patch_url":"https://github.com/infinispan/cpp-client/pull/346.patch","issue_url":"https://api.github.com/repos/infinispan/cpp-client/issues/346","number":346,"state":"open","locked":false,"title":"HRCPP-474 Updated to 9.4.1.Final","user":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"body":"Updated java test suite to 9.4.1.Final\r\nhttps://issues.jboss.org/browse/HRCPP-474","created_at":"2018-11-06T22:21:46Z","updated_at":"2018-11-07T13:44:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfa66d562deaa3ad596b83849c787e7d3b1cc03b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/346/commits","review_comments_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/346/comments","review_comment_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/cpp-client/issues/346/comments","statuses_url":"https://api.github.com/repos/infinispan/cpp-client/statuses/7d435667c8b8efb562acb2c37b17deee02c83544","head":{"label":"rigazilla:HRCPP-474/update_java_923","ref":"HRCPP-474/update_java_923","sha":"7d435667c8b8efb562acb2c37b17deee02c83544","user":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"repo":{"id":46785648,"node_id":"MDEwOlJlcG9zaXRvcnk0Njc4NTY0OA==","name":"cpp-client","full_name":"rigazilla/cpp-client","private":false,"owner":{"login":"rigazilla","id":7080882,"node_id":"MDQ6VXNlcjcwODA4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/7080882?v=4","gravatar_id":"","url":"https://api.github.com/users/rigazilla","html_url":"https://github.com/rigazilla","followers_url":"https://api.github.com/users/rigazilla/followers","following_url":"https://api.github.com/users/rigazilla/following{/other_user}","gists_url":"https://api.github.com/users/rigazilla/gists{/gist_id}","starred_url":"https://api.github.com/users/rigazilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigazilla/subscriptions","organizations_url":"https://api.github.com/users/rigazilla/orgs","repos_url":"https://api.github.com/users/rigazilla/repos","events_url":"https://api.github.com/users/rigazilla/events{/privacy}","received_events_url":"https://api.github.com/users/rigazilla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rigazilla/cpp-client","description":"C++ client for Infinispan, over the Hot Rod wire protocol","fork":true,"url":"https://api.github.com/repos/rigazilla/cpp-client","forks_url":"https://api.github.com/repos/rigazilla/cpp-client/forks","keys_url":"https://api.github.com/repos/rigazilla/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rigazilla/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rigazilla/cpp-client/teams","hooks_url":"https://api.github.com/repos/rigazilla/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/rigazilla/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/rigazilla/cpp-client/events","assignees_url":"https://api.github.com/repos/rigazilla/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/rigazilla/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/rigazilla/cpp-client/tags","blobs_url":"https://api.github.com/repos/rigazilla/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rigazilla/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rigazilla/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rigazilla/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rigazilla/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rigazilla/cpp-client/languages","stargazers_url":"https://api.github.com/repos/rigazilla/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/rigazilla/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/rigazilla/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/rigazilla/cpp-client/subscription","commits_url":"https://api.github.com/repos/rigazilla/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rigazilla/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rigazilla/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rigazilla/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/rigazilla/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/rigazilla/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rigazilla/cpp-client/merges","archive_url":"https://api.github.com/repos/rigazilla/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rigazilla/cpp-client/downloads","issues_url":"https://api.github.com/repos/rigazilla/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/rigazilla/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rigazilla/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rigazilla/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rigazilla/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/rigazilla/cpp-client/releases{/id}","deployments_url":"https://api.github.com/repos/rigazilla/cpp-client/deployments","created_at":"2015-11-24T10:52:55Z","updated_at":"2016-02-03T09:25:47Z","pushed_at":"2018-11-06T21:57:39Z","git_url":"git://github.com/rigazilla/cpp-client.git","ssh_url":"git@github.com:rigazilla/cpp-client.git","clone_url":"https://github.com/rigazilla/cpp-client.git","svn_url":"https://github.com/rigazilla/cpp-client","homepage":null,"size":2089,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"98c96127039371161a0f2512100eedffb794d0f4","user":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":9675051,"node_id":"MDEwOlJlcG9zaXRvcnk5Njc1MDUx","name":"cpp-client","full_name":"infinispan/cpp-client","private":false,"owner":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infinispan/cpp-client","description":"C++ client for Infinispan, over the Hot Rod wire protocol","fork":false,"url":"https://api.github.com/repos/infinispan/cpp-client","forks_url":"https://api.github.com/repos/infinispan/cpp-client/forks","keys_url":"https://api.github.com/repos/infinispan/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/cpp-client/teams","hooks_url":"https://api.github.com/repos/infinispan/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/infinispan/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/cpp-client/events","assignees_url":"https://api.github.com/repos/infinispan/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/cpp-client/tags","blobs_url":"https://api.github.com/repos/infinispan/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/cpp-client/languages","stargazers_url":"https://api.github.com/repos/infinispan/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/infinispan/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/infinispan/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/infinispan/cpp-client/subscription","commits_url":"https://api.github.com/repos/infinispan/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/cpp-client/merges","archive_url":"https://api.github.com/repos/infinispan/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/cpp-client/downloads","issues_url":"https://api.github.com/repos/infinispan/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/cpp-client/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/cpp-client/deployments","created_at":"2013-04-25T15:33:11Z","updated_at":"2018-11-02T16:17:33Z","pushed_at":"2018-11-06T22:21:46Z","git_url":"git://github.com/infinispan/cpp-client.git","ssh_url":"git@github.com:infinispan/cpp-client.git","clone_url":"https://github.com/infinispan/cpp-client.git","svn_url":"https://github.com/infinispan/cpp-client","homepage":null,"size":1754,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/346"},"html":{"href":"https://github.com/infinispan/cpp-client/pull/346"},"issue":{"href":"https://api.github.com/repos/infinispan/cpp-client/issues/346"},"comments":{"href":"https://api.github.com/repos/infinispan/cpp-client/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/cpp-client/statuses/7d435667c8b8efb562acb2c37b17deee02c83544"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alanfx"}}