{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/207043027","pull_request_review_id":142576991,"id":207043027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzA0MzAyNw==","diff_hunk":"@@ -0,0 +1,11 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<classpath>\n+\t<classpathentry kind=\"con\" path=\"org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8\" />\n+\t<classpathentry kind=\"con\" path=\"org.eclipse.pde.core.requiredPlugins\"/>\n+\t<classpathentry kind=\"src\" path=\"src/test/java\"/>\n+\t<classpathentry kind=\"output\" path=\"target/classes\"/>\n+\t<classpathentry exported=\"true\" kind=\"lib\" path=\"lib/mockito-all-1.10.19.jar\"/>","path":"addons/io/org.openhab.io.transport.modbus.test/.classpath","position":null,"original_position":7,"commit_id":"1d572c6672a155f1c4a0050268d89baef9bfe5a3","original_commit_id":"509f9163cf50634fea17416ec678491a0fd84fa2","user":{"login":"ssalonen","id":315866,"node_id":"MDQ6VXNlcjMxNTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"Should be OK now","created_at":"2018-08-01T21:48:02Z","updated_at":"2018-08-01T21:48:02Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2246#discussion_r207043027","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/207043027"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2246#discussion_r207043027"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246"}},"in_reply_to_id":206539350},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246","id":119345837,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE5MzQ1ODM3","html_url":"https://github.com/openhab/openhab2-addons/pull/2246","diff_url":"https://github.com/openhab/openhab2-addons/pull/2246.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2246.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246","number":2246,"state":"open","locked":false,"title":"[modbus] Modbus openhab2 native binding","user":{"login":"ssalonen","id":315866,"node_id":"MDQ6VXNlcjMxNTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"body":"As discussed in #362, a new PR for native openhab2 modbus binding.\r\n\r\nUpdate 21.10.:\r\nFunctionality should be there roughly, see discussio in the community https://community.openhab.org/t/modbus-openhab2-binding-available-for-alpha-testing/27657/154","created_at":"2017-05-07T16:55:52Z","updated_at":"2018-08-01T21:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd78bc840273f5cbfcc25edcf48ce100fe7ec434","assignee":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":159935827,"node_id":"MDU6TGFiZWwxNTk5MzU4Mjc=","url":"https://api.github.com/repos/openhab/openhab2-addons/labels/newbinding","name":"newbinding","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/1d572c6672a155f1c4a0050268d89baef9bfe5a3","head":{"label":"ssalonen:modbus-openhab2-native-binding","ref":"modbus-openhab2-native-binding","sha":"1d572c6672a155f1c4a0050268d89baef9bfe5a3","user":{"login":"ssalonen","id":315866,"node_id":"MDQ6VXNlcjMxNTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"repo":{"id":88195575,"node_id":"MDEwOlJlcG9zaXRvcnk4ODE5NTU3NQ==","name":"openhab2-addons","full_name":"ssalonen/openhab2-addons","owner":{"login":"ssalonen","id":315866,"node_id":"MDQ6VXNlcjMxNTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/315866?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalonen","html_url":"https://github.com/ssalonen","followers_url":"https://api.github.com/users/ssalonen/followers","following_url":"https://api.github.com/users/ssalonen/following{/other_user}","gists_url":"https://api.github.com/users/ssalonen/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalonen/subscriptions","organizations_url":"https://api.github.com/users/ssalonen/orgs","repos_url":"https://api.github.com/users/ssalonen/repos","events_url":"https://api.github.com/users/ssalonen/events{/privacy}","received_events_url":"https://api.github.com/users/ssalonen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssalonen/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/ssalonen/openhab2-addons","forks_url":"https://api.github.com/repos/ssalonen/openhab2-addons/forks","keys_url":"https://api.github.com/repos/ssalonen/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssalonen/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssalonen/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/ssalonen/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/ssalonen/openhab2-addons/events","assignees_url":"https://api.github.com/repos/ssalonen/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/ssalonen/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/ssalonen/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssalonen/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/ssalonen/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/ssalonen/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/ssalonen/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/ssalonen/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/ssalonen/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/ssalonen/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssalonen/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssalonen/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssalonen/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/ssalonen/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssalonen/openhab2-addons/merges","archive_url":"https://api.github.com/repos/ssalonen/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssalonen/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/ssalonen/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/ssalonen/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/ssalonen/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/ssalonen/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssalonen/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/ssalonen/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/ssalonen/openhab2-addons/deployments","created_at":"2017-04-13T18:39:32Z","updated_at":"2017-11-08T11:52:49Z","pushed_at":"2018-08-01T21:45:12Z","git_url":"git://github.com/ssalonen/openhab2-addons.git","ssh_url":"git@github.com:ssalonen/openhab2-addons.git","clone_url":"https://github.com/ssalonen/openhab2-addons.git","svn_url":"https://github.com/ssalonen/openhab2-addons","homepage":"","size":103354,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":6,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"526c42265e26160c67668246adbe28e142e09276","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1MzE5NQ==","name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2018-08-01T12:14:20Z","pushed_at":"2018-08-01T21:45:17Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":276837,"stargazers_count":788,"watchers_count":788,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1503,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1503,"open_issues":421,"watchers":788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2246"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2246/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2246/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/1d572c6672a155f1c4a0050268d89baef9bfe5a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ssalonen"}}