{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-rails/issues/257","repository_url":"https://api.github.com/repos/zurb/foundation-rails","labels_url":"https://api.github.com/repos/zurb/foundation-rails/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-rails/issues/257/comments","events_url":"https://api.github.com/repos/zurb/foundation-rails/issues/257/events","html_url":"https://github.com/zurb/foundation-rails/pull/257","id":314359180,"number":257,"title":"Update JS include order - Fixes responsive accordion tabs","user":{"login":"patricklindsay","id":7923681,"avatar_url":"https://avatars0.githubusercontent.com/u/7923681?v=4","gravatar_id":"","url":"https://api.github.com/users/patricklindsay","html_url":"https://github.com/patricklindsay","followers_url":"https://api.github.com/users/patricklindsay/followers","following_url":"https://api.github.com/users/patricklindsay/following{/other_user}","gists_url":"https://api.github.com/users/patricklindsay/gists{/gist_id}","starred_url":"https://api.github.com/users/patricklindsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patricklindsay/subscriptions","organizations_url":"https://api.github.com/users/patricklindsay/orgs","repos_url":"https://api.github.com/users/patricklindsay/repos","events_url":"https://api.github.com/users/patricklindsay/events{/privacy}","received_events_url":"https://api.github.com/users/patricklindsay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-14T20:25:05Z","updated_at":"2018-04-15T18:27:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zurb/foundation-rails/pulls/257","html_url":"https://github.com/zurb/foundation-rails/pull/257","diff_url":"https://github.com/zurb/foundation-rails/pull/257.diff","patch_url":"https://github.com/zurb/foundation-rails/pull/257.patch"},"body":"Responsive accordion tabs are currently broken due to a load order issue.\r\n\r\nIf you follow the guide on [responsive accordion tabs](https://foundation.zurb.com/sites/docs/responsive-accordion-tabs.html#accordion-html-markup) using this gem JS is throwing the following error;\r\n\r\n```\r\nUncaught TypeError: Right-hand side of 'instanceof' is not an object\r\n    at ResponsiveAccordionTabs._checkMediaQueries (foundation.responsiveAccordionTabs.self-e211e135a08bebf26a061b5d087b3a1269357f6e8af05d2a5f087aaae44e2fa2.js?body=1:305)\r\n    at foundation.responsiveAccordionTabs.self-e211e135a08bebf26a061b5d087b3a1269357f6e8af05d2a5f087aaae44e2fa2.js?body=1:279\r\n    at dispatch (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:5227)\r\n    at elemData.handle (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:4879)\r\n    at Object.trigger (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:5131)\r\n    at jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:5861\r\n    at Function.each (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:371)\r\n    at jQuery.fn.init.each (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:138)\r\n    at jQuery.fn.init.trigger (jquery.self-bd7ddd393353a8d2480a622e80342adf488fb6006d667e8b42e4c0073393abee.js?body=1:5860)\r\n    at foundation.util.mediaQuery.self-3492b7e03031b25b1025fd296476ac7c885b1a29e64ee8092fad06b3ff98a174.js?body=1:308\r\n```\r\n\r\nI've fixed this by updating the JS include order to be inline with [foundation-plugins.js](https://github.com/zurb/foundation-sites/blob/develop/js/entries/foundation-plugins.js)\r\n\r\n@ncoden "},"comment":{"url":"https://api.github.com/repos/zurb/foundation-rails/issues/comments/381427287","html_url":"https://github.com/zurb/foundation-rails/pull/257#issuecomment-381427287","issue_url":"https://api.github.com/repos/zurb/foundation-rails/issues/257","id":381427287,"user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"created_at":"2018-04-15T18:27:07Z","updated_at":"2018-04-15T18:27:07Z","author_association":"MEMBER","body":"Also, `vendor/assets/js/foundation.js` is actually generated by the Rakefile.\r\n\r\nhttps://github.com/zurb/foundation-rails/blob/e5e2eed59097f9af81a4902b3ff958ff7bbe4c88/Rakefile#L22-L28"}}
{"actor":{"display_login":"ncoden"}}