{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/chronograf/pulls/comments/176616700","pull_request_review_id":106352884,"id":176616700,"diff_hunk":"@@ -0,0 +1,43 @@\n+import React from 'react'\n+import {shallow} from 'enzyme'\n+\n+import TasksTable from 'src/kapacitor/components/TasksTable'\n+import {TaskRow} from 'src/kapacitor/components/TasksTable'\n+\n+import {source, kapacitorRules} from 'test/resources'\n+\n+describe('Kapacitor.Components.TasksTable', () => {\n+  describe('rendering', () => {\n+    const props = {","path":"ui/test/kapacitor/components/TasksTable.test.tsx","position":11,"original_position":11,"commit_id":"504e6f938e510a38d5b606f4bda13d7da8669bf0","original_commit_id":"504e6f938e510a38d5b606f4bda13d7da8669bf0","user":{"login":"121watts","id":7582765,"avatar_url":"https://avatars2.githubusercontent.com/u/7582765?v=4","gravatar_id":"","url":"https://api.github.com/users/121watts","html_url":"https://github.com/121watts","followers_url":"https://api.github.com/users/121watts/followers","following_url":"https://api.github.com/users/121watts/following{/other_user}","gists_url":"https://api.github.com/users/121watts/gists{/gist_id}","starred_url":"https://api.github.com/users/121watts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/121watts/subscriptions","organizations_url":"https://api.github.com/users/121watts/orgs","repos_url":"https://api.github.com/users/121watts/repos","events_url":"https://api.github.com/users/121watts/events{/privacy}","received_events_url":"https://api.github.com/users/121watts/received_events","type":"User","site_admin":false},"body":"Using the `setup` function can eliminate a lot of this props duplication.","created_at":"2018-03-23T01:12:09Z","updated_at":"2018-03-23T01:13:04Z","html_url":"https://github.com/influxdata/chronograf/pull/3006#discussion_r176616700","pull_request_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3006","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/comments/176616700"},"html":{"href":"https://github.com/influxdata/chronograf/pull/3006#discussion_r176616700"},"pull_request":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3006"}}},"pull_request":{"url":"https://api.github.com/repos/influxdata/chronograf/pulls/3006","id":175681826,"html_url":"https://github.com/influxdata/chronograf/pull/3006","diff_url":"https://github.com/influxdata/chronograf/pull/3006.diff","patch_url":"https://github.com/influxdata/chronograf/pull/3006.patch","issue_url":"https://api.github.com/repos/influxdata/chronograf/issues/3006","number":3006,"state":"open","locked":false,"title":"Fix Kapacitor Rules task enabled checkboxes to only toggle exactly as clicked","user":{"login":"jaredscheib","id":6403018,"avatar_url":"https://avatars1.githubusercontent.com/u/6403018?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredscheib","html_url":"https://github.com/jaredscheib","followers_url":"https://api.github.com/users/jaredscheib/followers","following_url":"https://api.github.com/users/jaredscheib/following{/other_user}","gists_url":"https://api.github.com/users/jaredscheib/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredscheib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredscheib/subscriptions","organizations_url":"https://api.github.com/users/jaredscheib/orgs","repos_url":"https://api.github.com/users/jaredscheib/repos","events_url":"https://api.github.com/users/jaredscheib/events{/privacy}","received_events_url":"https://api.github.com/users/jaredscheib/received_events","type":"User","site_admin":false},"body":"  - [x] CHANGELOG.md updated with a link to the PR (not the Issue)\r\n  - [x] Rebased/mergable\r\n  - [x] Tests pass\r\n  - [x] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\r\n\r\nConnect #2900 \r\n\r\n### The problem\r\nWhen a user would click a checkbox to enable a Rule/Task on the Manage Tasks page, it would enable/disable the correct task but it would appear as having enabled/disabled the wrong checkbox. This was resulting from the `<input>` for the checkboxes across the two tables being given the same HTML element ID.\r\n\r\n### The Solution\r\nAssign the two corresponding rule & task rows different HTML element IDs.\r\n\r\n### Note\r\n- This PR also introduces a number of more types for TypeScript into the project, especially related to Kapacitor, and converts the two affected components into TypeScript components. It also includes tests to ensure that each table row input is given a unique ID.\r\n- It would be worth considering adding a general test to all of our containers that ensures that all rendered components have a unique HTML id.","created_at":"2018-03-17T03:56:20Z","updated_at":"2018-03-23T01:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c376d11b52e323067c375e44e37ee1f6a0675eb","assignee":{"login":"121watts","id":7582765,"avatar_url":"https://avatars2.githubusercontent.com/u/7582765?v=4","gravatar_id":"","url":"https://api.github.com/users/121watts","html_url":"https://github.com/121watts","followers_url":"https://api.github.com/users/121watts/followers","following_url":"https://api.github.com/users/121watts/following{/other_user}","gists_url":"https://api.github.com/users/121watts/gists{/gist_id}","starred_url":"https://api.github.com/users/121watts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/121watts/subscriptions","organizations_url":"https://api.github.com/users/121watts/orgs","repos_url":"https://api.github.com/users/121watts/repos","events_url":"https://api.github.com/users/121watts/events{/privacy}","received_events_url":"https://api.github.com/users/121watts/received_events","type":"User","site_admin":false},"assignees":[{"login":"121watts","id":7582765,"avatar_url":"https://avatars2.githubusercontent.com/u/7582765?v=4","gravatar_id":"","url":"https://api.github.com/users/121watts","html_url":"https://github.com/121watts","followers_url":"https://api.github.com/users/121watts/followers","following_url":"https://api.github.com/users/121watts/following{/other_user}","gists_url":"https://api.github.com/users/121watts/gists{/gist_id}","starred_url":"https://api.github.com/users/121watts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/121watts/subscriptions","organizations_url":"https://api.github.com/users/121watts/orgs","repos_url":"https://api.github.com/users/121watts/repos","events_url":"https://api.github.com/users/121watts/events{/privacy}","received_events_url":"https://api.github.com/users/121watts/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3006/commits","review_comments_url":"https://api.github.com/repos/influxdata/chronograf/pulls/3006/comments","review_comment_url":"https://api.github.com/repos/influxdata/chronograf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/chronograf/issues/3006/comments","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/504e6f938e510a38d5b606f4bda13d7da8669bf0","head":{"label":"influxdata:bugfix/task_enabled_correct_check","ref":"bugfix/task_enabled_correct_check","sha":"504e6f938e510a38d5b606f4bda13d7da8669bf0","user":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":66506962,"name":"chronograf","full_name":"influxdata/chronograf","owner":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/chronograf","description":"Open source monitoring and visualization UI for the TICK stack","fork":false,"url":"https://api.github.com/repos/influxdata/chronograf","forks_url":"https://api.github.com/repos/influxdata/chronograf/forks","keys_url":"https://api.github.com/repos/influxdata/chronograf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/chronograf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/chronograf/teams","hooks_url":"https://api.github.com/repos/influxdata/chronograf/hooks","issue_events_url":"https://api.github.com/repos/influxdata/chronograf/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/chronograf/events","assignees_url":"https://api.github.com/repos/influxdata/chronograf/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/chronograf/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/chronograf/tags","blobs_url":"https://api.github.com/repos/influxdata/chronograf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/chronograf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/chronograf/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/chronograf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/chronograf/languages","stargazers_url":"https://api.github.com/repos/influxdata/chronograf/stargazers","contributors_url":"https://api.github.com/repos/influxdata/chronograf/contributors","subscribers_url":"https://api.github.com/repos/influxdata/chronograf/subscribers","subscription_url":"https://api.github.com/repos/influxdata/chronograf/subscription","commits_url":"https://api.github.com/repos/influxdata/chronograf/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/chronograf/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/chronograf/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/chronograf/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/chronograf/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/chronograf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/chronograf/merges","archive_url":"https://api.github.com/repos/influxdata/chronograf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/chronograf/downloads","issues_url":"https://api.github.com/repos/influxdata/chronograf/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/chronograf/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/chronograf/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/chronograf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/chronograf/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/chronograf/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/chronograf/deployments","created_at":"2016-08-24T23:28:56Z","updated_at":"2018-03-22T23:24:26Z","pushed_at":"2018-03-22T23:39:01Z","git_url":"git://github.com/influxdata/chronograf.git","ssh_url":"git@github.com:influxdata/chronograf.git","clone_url":"https://github.com/influxdata/chronograf.git","svn_url":"https://github.com/influxdata/chronograf","homepage":"https://www.influxdata.com/time-series-platform/chronograf/","size":49723,"stargazers_count":555,"watchers_count":555,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":549,"license":null,"forks":117,"open_issues":549,"watchers":555,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"b0e7e10d3980a93ecb08824f0185d8ec427bfd78","user":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":66506962,"name":"chronograf","full_name":"influxdata/chronograf","owner":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars2.githubusercontent.com/u/5713248?v=4","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/chronograf","description":"Open source monitoring and visualization UI for the TICK stack","fork":false,"url":"https://api.github.com/repos/influxdata/chronograf","forks_url":"https://api.github.com/repos/influxdata/chronograf/forks","keys_url":"https://api.github.com/repos/influxdata/chronograf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/chronograf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/chronograf/teams","hooks_url":"https://api.github.com/repos/influxdata/chronograf/hooks","issue_events_url":"https://api.github.com/repos/influxdata/chronograf/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/chronograf/events","assignees_url":"https://api.github.com/repos/influxdata/chronograf/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/chronograf/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/chronograf/tags","blobs_url":"https://api.github.com/repos/influxdata/chronograf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/chronograf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/chronograf/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/chronograf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/chronograf/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/chronograf/languages","stargazers_url":"https://api.github.com/repos/influxdata/chronograf/stargazers","contributors_url":"https://api.github.com/repos/influxdata/chronograf/contributors","subscribers_url":"https://api.github.com/repos/influxdata/chronograf/subscribers","subscription_url":"https://api.github.com/repos/influxdata/chronograf/subscription","commits_url":"https://api.github.com/repos/influxdata/chronograf/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/chronograf/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/chronograf/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/chronograf/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/chronograf/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/chronograf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/chronograf/merges","archive_url":"https://api.github.com/repos/influxdata/chronograf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/chronograf/downloads","issues_url":"https://api.github.com/repos/influxdata/chronograf/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/chronograf/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/chronograf/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/chronograf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/chronograf/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/chronograf/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/chronograf/deployments","created_at":"2016-08-24T23:28:56Z","updated_at":"2018-03-22T23:24:26Z","pushed_at":"2018-03-22T23:39:01Z","git_url":"git://github.com/influxdata/chronograf.git","ssh_url":"git@github.com:influxdata/chronograf.git","clone_url":"https://github.com/influxdata/chronograf.git","svn_url":"https://github.com/influxdata/chronograf","homepage":"https://www.influxdata.com/time-series-platform/chronograf/","size":49723,"stargazers_count":555,"watchers_count":555,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":549,"license":null,"forks":117,"open_issues":549,"watchers":555,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3006"},"html":{"href":"https://github.com/influxdata/chronograf/pull/3006"},"issue":{"href":"https://api.github.com/repos/influxdata/chronograf/issues/3006"},"comments":{"href":"https://api.github.com/repos/influxdata/chronograf/issues/3006/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3006/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/chronograf/pulls/3006/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/chronograf/statuses/504e6f938e510a38d5b606f4bda13d7da8669bf0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"121watts"}}