{"action":"closed","number":1028,"pull_request":{"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028","id":215954161,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTU0MTYx","html_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1028","diff_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1028.diff","patch_url":"https://github.com/azerothcore/azerothcore-wotlk/pull/1028.patch","issue_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1028","number":1028,"state":"closed","locked":false,"title":"Core/Achiev: Warning if GM mode enabled","user":{"login":"BarbzYHOOL","id":29780637,"node_id":"MDQ6VXNlcjI5NzgwNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/29780637?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbzYHOOL","html_url":"https://github.com/BarbzYHOOL","followers_url":"https://api.github.com/users/BarbzYHOOL/followers","following_url":"https://api.github.com/users/BarbzYHOOL/following{/other_user}","gists_url":"https://api.github.com/users/BarbzYHOOL/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbzYHOOL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbzYHOOL/subscriptions","organizations_url":"https://api.github.com/users/BarbzYHOOL/orgs","repos_url":"https://api.github.com/users/BarbzYHOOL/repos","events_url":"https://api.github.com/users/BarbzYHOOL/events{/privacy}","received_events_url":"https://api.github.com/users/BarbzYHOOL/received_events","type":"User","site_admin":false},"body":"<!-- First of all, THANK YOU for your contribution.\r\n Please fill this template unless your PR is very simple/straightforward.\r\n Do not forget to have a look at our Pull Request tutorial: https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request\r\n-->\r\n\r\n\r\n<!-- WRITE A RELEVANT TITLE -->\r\n\r\n\r\n##### CHANGES PROPOSED:\r\n\r\n1. Added a warning ingame and in console when you're a GM testing achievements (else it was confusing).\r\n2. Added another GM mode check in ResetAchievement from TrinityCore.\r\n3. Added an extra type check in UpdateAchievementCriteria, ported from TrinityCore.\r\n\r\n\r\n\r\n##### TESTS PERFORMED:\r\n<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->\r\n\r\nNone yet.\r\n\r\n##### HOW TO TEST THE CHANGES:\r\n<!-- We need to confirm the changes first, so try to make the work easy for testers, please:\r\n - Which commands to use? Which NPC to teleport to?\r\n - Do we need to enable debug flags on Cmake?\r\n - Do we need to look at the console? etc...\r\n - Other steps\r\n-->\r\n\r\n- Compile\r\n- Enter the game in GM mode on\r\n- Type `.achiev add 504` and see if it warns you ingame and in console.\r\n- I'm not sure how to test change 3) though :P\r\n\r\n\r\n##### Target branch(es):\r\n\r\nMaster\r\n\r\n\r\n<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->\r\n\r\n<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel!\r\n The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->\r\n","created_at":"2018-09-17T11:47:56Z","updated_at":"2018-12-08T22:02:41Z","closed_at":"2018-12-08T22:02:41Z","merged_at":"2018-12-08T22:02:41Z","merge_commit_sha":"b8d2396398e53b941289d696eba95f0360279e1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":723999956,"node_id":"MDU6TGFiZWw3MjM5OTk5NTY=","url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels/CORE","name":"CORE","color":"ff8000","default":false},{"id":723999302,"node_id":"MDU6TGFiZWw3MjM5OTkzMDI=","url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels/Priority%20-%20Low","name":"Priority - Low","color":"006b75","default":false},{"id":949182838,"node_id":"MDU6TGFiZWw5NDkxODI4Mzg=","url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels/To%20Be%20Merged","name":"To Be Merged","color":"6088c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1028/comments","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/457d425d961162701590a668b17f584cd8f81a78","head":{"label":"azerothcore:BarbzYHOOL-achievements","ref":"BarbzYHOOL-achievements","sha":"457d425d961162701590a668b17f584cd8f81a78","user":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61980658,"node_id":"MDEwOlJlcG9zaXRvcnk2MTk4MDY1OA==","name":"azerothcore-wotlk","full_name":"azerothcore/azerothcore-wotlk","private":false,"owner":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/azerothcore/azerothcore-wotlk","description":"AZeroThCore - MMORPG Server. Based on MaNGOS -> TrinityCore -> SunwellCore","fork":false,"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk","forks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/deployments","created_at":"2016-06-26T08:40:05Z","updated_at":"2018-12-08T10:26:14Z","pushed_at":"2018-12-08T22:02:41Z","git_url":"git://github.com/azerothcore/azerothcore-wotlk.git","ssh_url":"git@github.com:azerothcore/azerothcore-wotlk.git","clone_url":"https://github.com/azerothcore/azerothcore-wotlk.git","svn_url":"https://github.com/azerothcore/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":256556,"stargazers_count":278,"watchers_count":278,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":287,"open_issues":201,"watchers":278,"default_branch":"master"}},"base":{"label":"azerothcore:master","ref":"master","sha":"9d2fa9a8c9fcb128c1883eb399e018b7e1752154","user":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"repo":{"id":61980658,"node_id":"MDEwOlJlcG9zaXRvcnk2MTk4MDY1OA==","name":"azerothcore-wotlk","full_name":"azerothcore/azerothcore-wotlk","private":false,"owner":{"login":"azerothcore","id":20147732,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTQ3NzMy","avatar_url":"https://avatars0.githubusercontent.com/u/20147732?v=4","gravatar_id":"","url":"https://api.github.com/users/azerothcore","html_url":"https://github.com/azerothcore","followers_url":"https://api.github.com/users/azerothcore/followers","following_url":"https://api.github.com/users/azerothcore/following{/other_user}","gists_url":"https://api.github.com/users/azerothcore/gists{/gist_id}","starred_url":"https://api.github.com/users/azerothcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azerothcore/subscriptions","organizations_url":"https://api.github.com/users/azerothcore/orgs","repos_url":"https://api.github.com/users/azerothcore/repos","events_url":"https://api.github.com/users/azerothcore/events{/privacy}","received_events_url":"https://api.github.com/users/azerothcore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/azerothcore/azerothcore-wotlk","description":"AZeroThCore - MMORPG Server. Based on MaNGOS -> TrinityCore -> SunwellCore","fork":false,"url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk","forks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/forks","keys_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/teams","hooks_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/hooks","issue_events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/events{/number}","events_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/events","assignees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/assignees{/user}","branches_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/branches{/branch}","tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/tags","blobs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/refs{/sha}","trees_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/{sha}","languages_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/languages","stargazers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/stargazers","contributors_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contributors","subscribers_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscribers","subscription_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/subscription","commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/commits{/sha}","git_commits_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/git/commits{/sha}","comments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/comments{/number}","issue_comment_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/comments{/number}","contents_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/contents/{+path}","compare_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/merges","archive_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/downloads","issues_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues{/number}","pulls_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls{/number}","milestones_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/milestones{/number}","notifications_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/labels{/name}","releases_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/releases{/id}","deployments_url":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/deployments","created_at":"2016-06-26T08:40:05Z","updated_at":"2018-12-08T10:26:14Z","pushed_at":"2018-12-08T22:02:41Z","git_url":"git://github.com/azerothcore/azerothcore-wotlk.git","ssh_url":"git@github.com:azerothcore/azerothcore-wotlk.git","clone_url":"https://github.com/azerothcore/azerothcore-wotlk.git","svn_url":"https://github.com/azerothcore/azerothcore-wotlk","homepage":"http://www.azerothcore.org","size":256556,"stargazers_count":278,"watchers_count":278,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":287,"open_issues":201,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028"},"html":{"href":"https://github.com/azerothcore/azerothcore-wotlk/pull/1028"},"issue":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1028"},"comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/azerothcore/azerothcore-wotlk/statuses/457d425d961162701590a668b17f584cd8f81a78"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"BarbzYHOOL","id":29780637,"node_id":"MDQ6VXNlcjI5NzgwNjM3","avatar_url":"https://avatars3.githubusercontent.com/u/29780637?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbzYHOOL","html_url":"https://github.com/BarbzYHOOL","followers_url":"https://api.github.com/users/BarbzYHOOL/followers","following_url":"https://api.github.com/users/BarbzYHOOL/following{/other_user}","gists_url":"https://api.github.com/users/BarbzYHOOL/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbzYHOOL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbzYHOOL/subscriptions","organizations_url":"https://api.github.com/users/BarbzYHOOL/orgs","repos_url":"https://api.github.com/users/BarbzYHOOL/repos","events_url":"https://api.github.com/users/BarbzYHOOL/events{/privacy}","received_events_url":"https://api.github.com/users/BarbzYHOOL/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":33,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"BarbzYHOOL"}}