{"action":"created","comment":{"url":"https://api.github.com/repos/kokkos/kokkos/pulls/comments/190956835","pull_request_review_id":123449472,"id":190956835,"diff_hunk":"@@ -2973,6 +2958,138 @@ class ViewMapping< DstTraits , SrcTraits ,\n     }\n };\n \n+//----------------------------------------------------------------------------\n+//Create new specialization for SrcType of LayoutStride. Runtime check for compatible layout\n+template< class DstTraits , class SrcTraits >\n+class ViewMapping< DstTraits , SrcTraits ,\n+  typename std::enable_if<(\n+    (std::is_same<typename SrcTraits::array_layout, LayoutStride>::value) &&\n+    // default mappings\n+    std::is_same< typename DstTraits::specialize , void >::value\n+    &&\n+    std::is_same< typename SrcTraits::specialize , void >::value\n+    &&\n+    (\n+      // same layout\n+      std::is_same< typename DstTraits::array_layout , typename SrcTraits::array_layout >::value\n+      ||\n+      // known layout\n+      (\n+        (\n+          std::is_same< typename DstTraits::array_layout , Kokkos::LayoutLeft >::value ||\n+          std::is_same< typename DstTraits::array_layout , Kokkos::LayoutRight >::value ||\n+          std::is_same< typename DstTraits::array_layout , Kokkos::LayoutStride >::value\n+        )\n+        &&\n+        (\n+          std::is_same< typename SrcTraits::array_layout , Kokkos::LayoutLeft >::value ||\n+          std::is_same< typename SrcTraits::array_layout , Kokkos::LayoutRight >::value ||\n+          std::is_same< typename SrcTraits::array_layout , Kokkos::LayoutStride >::value\n+        )\n+      )\n+    )\n+  )>::type >\n+{\n+private:\n+\n+  enum { is_assignable_space =\n+#if 1\n+   Kokkos::Impl::MemorySpaceAccess\n+     < typename DstTraits::memory_space\n+     , typename SrcTraits::memory_space >::assignable };\n+#else","path":"core/src/impl/Kokkos_ViewMapping.hpp","position":96,"original_position":96,"commit_id":"2b3c1460f3651300c11d7e7b12c3f5a46b0b2e12","original_commit_id":"2b3c1460f3651300c11d7e7b12c3f5a46b0b2e12","user":{"login":"crtrott","id":9490481,"avatar_url":"https://avatars1.githubusercontent.com/u/9490481?v=4","gravatar_id":"","url":"https://api.github.com/users/crtrott","html_url":"https://github.com/crtrott","followers_url":"https://api.github.com/users/crtrott/followers","following_url":"https://api.github.com/users/crtrott/following{/other_user}","gists_url":"https://api.github.com/users/crtrott/gists{/gist_id}","starred_url":"https://api.github.com/users/crtrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crtrott/subscriptions","organizations_url":"https://api.github.com/users/crtrott/orgs","repos_url":"https://api.github.com/users/crtrott/repos","events_url":"https://api.github.com/users/crtrott/events{/privacy}","received_events_url":"https://api.github.com/users/crtrott/received_events","type":"User","site_admin":false},"body":"Can you remove the non used branch here.","created_at":"2018-05-25T17:12:47Z","updated_at":"2018-05-25T17:12:54Z","html_url":"https://github.com/kokkos/kokkos/pull/1629#discussion_r190956835","pull_request_url":"https://api.github.com/repos/kokkos/kokkos/pulls/1629","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/comments/190956835"},"html":{"href":"https://github.com/kokkos/kokkos/pull/1629#discussion_r190956835"},"pull_request":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/1629"}}},"pull_request":{"url":"https://api.github.com/repos/kokkos/kokkos/pulls/1629","id":188767758,"html_url":"https://github.com/kokkos/kokkos/pull/1629","diff_url":"https://github.com/kokkos/kokkos/pull/1629.diff","patch_url":"https://github.com/kokkos/kokkos/pull/1629.patch","issue_url":"https://api.github.com/repos/kokkos/kokkos/issues/1629","number":1629,"state":"open","locked":false,"title":"View Assignment: LayoutStride -> LayoutLeft/Right","user":{"login":"vqd8a","id":18294424,"avatar_url":"https://avatars2.githubusercontent.com/u/18294424?v=4","gravatar_id":"","url":"https://api.github.com/users/vqd8a","html_url":"https://github.com/vqd8a","followers_url":"https://api.github.com/users/vqd8a/followers","following_url":"https://api.github.com/users/vqd8a/following{/other_user}","gists_url":"https://api.github.com/users/vqd8a/gists{/gist_id}","starred_url":"https://api.github.com/users/vqd8a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vqd8a/subscriptions","organizations_url":"https://api.github.com/users/vqd8a/orgs","repos_url":"https://api.github.com/users/vqd8a/repos","events_url":"https://api.github.com/users/vqd8a/events{/privacy}","received_events_url":"https://api.github.com/users/vqd8a/received_events","type":"User","site_admin":false},"body":"Resolving #1594.\r\nCreate a specialization for SrcType of LayoutStride for assign compatible default mappings in [Kokkos_ViewMapping.hpp](https://github.com/kokkos/kokkos/blob/issue-1594/core/src/impl/Kokkos_ViewMapping.hpp)","created_at":"2018-05-17T15:02:45Z","updated_at":"2018-05-25T17:12:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01319042b095fc3e59edd3c4aa9885e060ffa65b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kokkos/kokkos/pulls/1629/commits","review_comments_url":"https://api.github.com/repos/kokkos/kokkos/pulls/1629/comments","review_comment_url":"https://api.github.com/repos/kokkos/kokkos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kokkos/kokkos/issues/1629/comments","statuses_url":"https://api.github.com/repos/kokkos/kokkos/statuses/2b3c1460f3651300c11d7e7b12c3f5a46b0b2e12","head":{"label":"kokkos:issue-1594","ref":"issue-1594","sha":"2b3c1460f3651300c11d7e7b12c3f5a46b0b2e12","user":{"login":"kokkos","id":10199860,"avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"repo":{"id":33634359,"name":"kokkos","full_name":"kokkos/kokkos","owner":{"login":"kokkos","id":10199860,"avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kokkos/kokkos","description":"Kokkos C++ Performance Portability Programming EcoSystem: The Programming Model - Parallel Execution and Memory Abstraction","fork":false,"url":"https://api.github.com/repos/kokkos/kokkos","forks_url":"https://api.github.com/repos/kokkos/kokkos/forks","keys_url":"https://api.github.com/repos/kokkos/kokkos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokkos/kokkos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokkos/kokkos/teams","hooks_url":"https://api.github.com/repos/kokkos/kokkos/hooks","issue_events_url":"https://api.github.com/repos/kokkos/kokkos/issues/events{/number}","events_url":"https://api.github.com/repos/kokkos/kokkos/events","assignees_url":"https://api.github.com/repos/kokkos/kokkos/assignees{/user}","branches_url":"https://api.github.com/repos/kokkos/kokkos/branches{/branch}","tags_url":"https://api.github.com/repos/kokkos/kokkos/tags","blobs_url":"https://api.github.com/repos/kokkos/kokkos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokkos/kokkos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokkos/kokkos/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokkos/kokkos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokkos/kokkos/statuses/{sha}","languages_url":"https://api.github.com/repos/kokkos/kokkos/languages","stargazers_url":"https://api.github.com/repos/kokkos/kokkos/stargazers","contributors_url":"https://api.github.com/repos/kokkos/kokkos/contributors","subscribers_url":"https://api.github.com/repos/kokkos/kokkos/subscribers","subscription_url":"https://api.github.com/repos/kokkos/kokkos/subscription","commits_url":"https://api.github.com/repos/kokkos/kokkos/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokkos/kokkos/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokkos/kokkos/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokkos/kokkos/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokkos/kokkos/contents/{+path}","compare_url":"https://api.github.com/repos/kokkos/kokkos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokkos/kokkos/merges","archive_url":"https://api.github.com/repos/kokkos/kokkos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokkos/kokkos/downloads","issues_url":"https://api.github.com/repos/kokkos/kokkos/issues{/number}","pulls_url":"https://api.github.com/repos/kokkos/kokkos/pulls{/number}","milestones_url":"https://api.github.com/repos/kokkos/kokkos/milestones{/number}","notifications_url":"https://api.github.com/repos/kokkos/kokkos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokkos/kokkos/labels{/name}","releases_url":"https://api.github.com/repos/kokkos/kokkos/releases{/id}","deployments_url":"https://api.github.com/repos/kokkos/kokkos/deployments","created_at":"2015-04-08T21:55:55Z","updated_at":"2018-05-25T17:03:23Z","pushed_at":"2018-05-25T17:05:31Z","git_url":"git://github.com/kokkos/kokkos.git","ssh_url":"git@github.com:kokkos/kokkos.git","clone_url":"https://github.com/kokkos/kokkos.git","svn_url":"https://github.com/kokkos/kokkos","homepage":"","size":8758,"stargazers_count":231,"watchers_count":231,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":78,"open_issues":132,"watchers":231,"default_branch":"master"}},"base":{"label":"kokkos:develop","ref":"develop","sha":"04790a625d9fc0a2c6d7568ec6dd82b6879bf6e3","user":{"login":"kokkos","id":10199860,"avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"repo":{"id":33634359,"name":"kokkos","full_name":"kokkos/kokkos","owner":{"login":"kokkos","id":10199860,"avatar_url":"https://avatars3.githubusercontent.com/u/10199860?v=4","gravatar_id":"","url":"https://api.github.com/users/kokkos","html_url":"https://github.com/kokkos","followers_url":"https://api.github.com/users/kokkos/followers","following_url":"https://api.github.com/users/kokkos/following{/other_user}","gists_url":"https://api.github.com/users/kokkos/gists{/gist_id}","starred_url":"https://api.github.com/users/kokkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokkos/subscriptions","organizations_url":"https://api.github.com/users/kokkos/orgs","repos_url":"https://api.github.com/users/kokkos/repos","events_url":"https://api.github.com/users/kokkos/events{/privacy}","received_events_url":"https://api.github.com/users/kokkos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kokkos/kokkos","description":"Kokkos C++ Performance Portability Programming EcoSystem: The Programming Model - Parallel Execution and Memory Abstraction","fork":false,"url":"https://api.github.com/repos/kokkos/kokkos","forks_url":"https://api.github.com/repos/kokkos/kokkos/forks","keys_url":"https://api.github.com/repos/kokkos/kokkos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokkos/kokkos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokkos/kokkos/teams","hooks_url":"https://api.github.com/repos/kokkos/kokkos/hooks","issue_events_url":"https://api.github.com/repos/kokkos/kokkos/issues/events{/number}","events_url":"https://api.github.com/repos/kokkos/kokkos/events","assignees_url":"https://api.github.com/repos/kokkos/kokkos/assignees{/user}","branches_url":"https://api.github.com/repos/kokkos/kokkos/branches{/branch}","tags_url":"https://api.github.com/repos/kokkos/kokkos/tags","blobs_url":"https://api.github.com/repos/kokkos/kokkos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokkos/kokkos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokkos/kokkos/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokkos/kokkos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokkos/kokkos/statuses/{sha}","languages_url":"https://api.github.com/repos/kokkos/kokkos/languages","stargazers_url":"https://api.github.com/repos/kokkos/kokkos/stargazers","contributors_url":"https://api.github.com/repos/kokkos/kokkos/contributors","subscribers_url":"https://api.github.com/repos/kokkos/kokkos/subscribers","subscription_url":"https://api.github.com/repos/kokkos/kokkos/subscription","commits_url":"https://api.github.com/repos/kokkos/kokkos/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokkos/kokkos/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokkos/kokkos/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokkos/kokkos/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokkos/kokkos/contents/{+path}","compare_url":"https://api.github.com/repos/kokkos/kokkos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokkos/kokkos/merges","archive_url":"https://api.github.com/repos/kokkos/kokkos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokkos/kokkos/downloads","issues_url":"https://api.github.com/repos/kokkos/kokkos/issues{/number}","pulls_url":"https://api.github.com/repos/kokkos/kokkos/pulls{/number}","milestones_url":"https://api.github.com/repos/kokkos/kokkos/milestones{/number}","notifications_url":"https://api.github.com/repos/kokkos/kokkos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokkos/kokkos/labels{/name}","releases_url":"https://api.github.com/repos/kokkos/kokkos/releases{/id}","deployments_url":"https://api.github.com/repos/kokkos/kokkos/deployments","created_at":"2015-04-08T21:55:55Z","updated_at":"2018-05-25T17:03:23Z","pushed_at":"2018-05-25T17:05:31Z","git_url":"git://github.com/kokkos/kokkos.git","ssh_url":"git@github.com:kokkos/kokkos.git","clone_url":"https://github.com/kokkos/kokkos.git","svn_url":"https://github.com/kokkos/kokkos","homepage":"","size":8758,"stargazers_count":231,"watchers_count":231,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":78,"open_issues":132,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/1629"},"html":{"href":"https://github.com/kokkos/kokkos/pull/1629"},"issue":{"href":"https://api.github.com/repos/kokkos/kokkos/issues/1629"},"comments":{"href":"https://api.github.com/repos/kokkos/kokkos/issues/1629/comments"},"review_comments":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/1629/comments"},"review_comment":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kokkos/kokkos/pulls/1629/commits"},"statuses":{"href":"https://api.github.com/repos/kokkos/kokkos/statuses/2b3c1460f3651300c11d7e7b12c3f5a46b0b2e12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"crtrott"}}