{"action":"created","issue":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2214","repository_url":"https://api.github.com/repos/MithrilJS/mithril.js","labels_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2214/labels{/name}","comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2214/comments","events_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2214/events","html_url":"https://github.com/MithrilJS/mithril.js/pull/2214","id":354676908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzgwOTAy","number":2214,"title":"Simplify component removal","user":{"login":"isiahmeadows","id":4483844,"node_id":"MDQ6VXNlcjQ0ODM4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4483844?v=4","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"labels":[{"id":1042057871,"node_id":"MDU6TGFiZWwxMDQyMDU3ODcx","url":"https://api.github.com/repos/MithrilJS/mithril.js/labels/backport%20to%20v1","name":"backport to v1","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-28T10:53:40Z","updated_at":"2018-09-19T06:27:09Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2214","html_url":"https://github.com/MithrilJS/mithril.js/pull/2214","diff_url":"https://github.com/MithrilJS/mithril.js/pull/2214.diff","patch_url":"https://github.com/MithrilJS/mithril.js/pull/2214.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nJust a minor simplification of how elements are removed. It doesn't noticeably change performance, but it saves a few gzip'd bytes, and it avoids a function that was only really used for that one thing.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nIt just cleans up the code some.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nRan all the unit tests and perf tests to check for regressions in both. Performance changes appear statistically insignificant.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation change\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] I have updated `docs/change-log.md`\r\n"},"comment":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/comments/422670778","html_url":"https://github.com/MithrilJS/mithril.js/pull/2214#issuecomment-422670778","issue_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2214","id":422670778,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjY3MDc3OA==","user":{"login":"isiahmeadows","id":4483844,"node_id":"MDQ6VXNlcjQ0ODM4NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4483844?v=4","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T06:27:09Z","updated_at":"2018-09-19T06:27:09Z","author_association":"COLLABORATOR","body":"I fixed the Git mess on my end - the history should be a lot cleaner and less polluted now."}}
{"actor":{"display_login":"isiahmeadows"}}