{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/samples/issues/585","repository_url":"https://api.github.com/repos/GoogleChrome/samples","labels_url":"https://api.github.com/repos/GoogleChrome/samples/issues/585/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/samples/issues/585/comments","events_url":"https://api.github.com/repos/GoogleChrome/samples/issues/585/events","html_url":"https://github.com/GoogleChrome/samples/pull/585","id":322117392,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3MzMwOTY1","number":585,"title":"Fix payment-request demos w/ regards to new specs","user":{"login":"jonathanGB","id":8869660,"node_id":"MDQ6VXNlcjg4Njk2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8869660?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanGB","html_url":"https://github.com/jonathanGB","followers_url":"https://api.github.com/users/jonathanGB/followers","following_url":"https://api.github.com/users/jonathanGB/following{/other_user}","gists_url":"https://api.github.com/users/jonathanGB/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanGB/subscriptions","organizations_url":"https://api.github.com/users/jonathanGB/orgs","repos_url":"https://api.github.com/users/jonathanGB/repos","events_url":"https://api.github.com/users/jonathanGB/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanGB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-10T23:12:43Z","updated_at":"2018-06-28T16:29:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/GoogleChrome/samples/pulls/585","html_url":"https://github.com/GoogleChrome/samples/pull/585","diff_url":"https://github.com/GoogleChrome/samples/pull/585.diff","patch_url":"https://github.com/GoogleChrome/samples/pull/585.patch"},"body":"Current state of **PaymentRequest** demos had two problems related to the ongoing specs:\r\n\r\n1. Use of `supportedMethods` is now a *String* rather than an *Array*\r\n2. Re-using the same **PaymentRequest** instance when clicking on \"Buy\" would lead to errors (at least on FF). I have not delved too much into the causes, but my intuitition is that showing a previous **PaymentRequest** causes an error (as it wasn't part of \"user activation\")\r\n<img width=\"775\" alt=\"image\" src=\"https://user-images.githubusercontent.com/8869660/39898255-451849f0-54b6-11e8-928a-3a13670d442c.png\">\r\n<img width=\"759\" alt=\"image\" src=\"https://user-images.githubusercontent.com/8869660/39898387-bcb9daaa-54b6-11e8-9567-dfb607b05739.png\">\r\n\r\n\r\nFix to **1** was trivial. \r\nFix to **2** required to create a new **PaymentRequest** instance every time we wanted to show the interface. \r\n\r\nWith the current PR, the demos now work well with the new specs.\r\n\r\nNote: this can replace PR #534.\r\n\r\nCC: @rsolomakhin @mnoorenberghe \r\n"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/samples/issues/comments/401094619","html_url":"https://github.com/GoogleChrome/samples/pull/585#issuecomment-401094619","issue_url":"https://api.github.com/repos/GoogleChrome/samples/issues/585","id":401094619,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTA5NDYxOQ==","user":{"login":"jonathanGB","id":8869660,"node_id":"MDQ6VXNlcjg4Njk2NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8869660?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanGB","html_url":"https://github.com/jonathanGB","followers_url":"https://api.github.com/users/jonathanGB/followers","following_url":"https://api.github.com/users/jonathanGB/following{/other_user}","gists_url":"https://api.github.com/users/jonathanGB/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanGB/subscriptions","organizations_url":"https://api.github.com/users/jonathanGB/orgs","repos_url":"https://api.github.com/users/jonathanGB/repos","events_url":"https://api.github.com/users/jonathanGB/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanGB/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T16:29:12Z","updated_at":"2018-06-28T16:29:12Z","author_association":"NONE","body":"I'm gonna look at it this week!"}}
{"actor":{"display_login":"jonathanGB"}}