{"action":"created","issue":{"url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/214","repository_url":"https://api.github.com/repos/infor-design/enterprise-ng","labels_url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/214/comments","events_url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/214/events","html_url":"https://github.com/infor-design/enterprise-ng/issues/214","id":369574578,"node_id":"MDU6SXNzdWUzNjk1NzQ1Nzg=","number":214,"title":"Wrap renderLoop with Angular Component","user":{"login":"krishollenbeck","id":1056684,"node_id":"MDQ6VXNlcjEwNTY2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1056684?v=4","gravatar_id":"","url":"https://api.github.com/users/krishollenbeck","html_url":"https://github.com/krishollenbeck","followers_url":"https://api.github.com/users/krishollenbeck/followers","following_url":"https://api.github.com/users/krishollenbeck/following{/other_user}","gists_url":"https://api.github.com/users/krishollenbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/krishollenbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishollenbeck/subscriptions","organizations_url":"https://api.github.com/users/krishollenbeck/orgs","repos_url":"https://api.github.com/users/krishollenbeck/repos","events_url":"https://api.github.com/users/krishollenbeck/events{/privacy}","received_events_url":"https://api.github.com/users/krishollenbeck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-12T14:25:12Z","updated_at":"2018-10-12T15:49:10Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Is your feature request related to a problem? Please describe.**\r\n`renderLoop` appears to trigger a handful of the setTimeout violations we are seeing in chrome. Seems like this is a potential performance bottleneck.\r\n\r\n**Describe the solution you'd like**\r\nCurrently `renderLoop` is initialized via Sohoxi.js. If we wrap this with an Angular wrapper (possibly a service), we could initialize it via  app.module. For example..\r\n\r\n```\r\nSohoRenderLoopService,\r\n    {\r\n      provide:    APP_INITIALIZER,\r\n      useFactory: ... ,\r\n      deps:       [ ]\r\n    },\r\n```\r\n\r\nAnd then in the service have something like..\r\n\r\n```\r\n  this.ngZone.runOutsideAngular(() => {\r\n      renderLoop()\r\n  });\r\n```\r\n\r\nThis way we can ensure `requestAnimationFrame` is running outside of Angular Zone.\r\n"},"comment":{"url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/comments/429371891","html_url":"https://github.com/infor-design/enterprise-ng/issues/214#issuecomment-429371891","issue_url":"https://api.github.com/repos/infor-design/enterprise-ng/issues/214","id":429371891,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTM3MTg5MQ==","user":{"login":"pwpatton","id":4737815,"node_id":"MDQ6VXNlcjQ3Mzc4MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4737815?v=4","gravatar_id":"","url":"https://api.github.com/users/pwpatton","html_url":"https://github.com/pwpatton","followers_url":"https://api.github.com/users/pwpatton/followers","following_url":"https://api.github.com/users/pwpatton/following{/other_user}","gists_url":"https://api.github.com/users/pwpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/pwpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwpatton/subscriptions","organizations_url":"https://api.github.com/users/pwpatton/orgs","repos_url":"https://api.github.com/users/pwpatton/repos","events_url":"https://api.github.com/users/pwpatton/events{/privacy}","received_events_url":"https://api.github.com/users/pwpatton/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T15:49:10Z","updated_at":"2018-10-12T15:49:10Z","author_association":"COLLABORATOR","body":"Does this get started just due to sohoxi.js being loaded ? or is there function ep-ng calls where we could run outside angular?"}}
{"actor":{"display_login":"pwpatton"}}