{"action":"created","comment":{"url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/comments/227861326","pull_request_review_id":167993769,"id":227861326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzg2MTMyNg==","diff_hunk":"@@ -0,0 +1,15 @@\n+package pl.skipcode.kotlinbaseappmvvm.utils.configuration\n+\n+import io.reactivex.Observable\n+import io.reactivex.subjects.PublishSubject\n+\n+interface ConfigurationInterface {","path":"app/src/main/java/pl/skipcode/kotlinbaseappmvvm/utils/configuration/ConfigurationInterface.kt","position":6,"original_position":6,"commit_id":"1eae72abf2d05706670d15193494cc2f325c4446","original_commit_id":"1eae72abf2d05706670d15193494cc2f325c4446","user":{"login":"jothaen","id":6339642,"node_id":"MDQ6VXNlcjYzMzk2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6339642?v=4","gravatar_id":"","url":"https://api.github.com/users/jothaen","html_url":"https://github.com/jothaen","followers_url":"https://api.github.com/users/jothaen/followers","following_url":"https://api.github.com/users/jothaen/following{/other_user}","gists_url":"https://api.github.com/users/jothaen/gists{/gist_id}","starred_url":"https://api.github.com/users/jothaen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jothaen/subscriptions","organizations_url":"https://api.github.com/users/jothaen/orgs","repos_url":"https://api.github.com/users/jothaen/repos","events_url":"https://api.github.com/users/jothaen/events{/privacy}","received_events_url":"https://api.github.com/users/jothaen/received_events","type":"User","site_admin":false},"body":"nie powinno się dawać Interface w nazwie, albo użyj starej Javowej konwencji czyli IConfiguration, albo tu daj Configuration a klasa implementujaca ConfigurationImpl","created_at":"2018-10-24T16:17:59Z","updated_at":"2018-10-24T16:29:21Z","html_url":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1#discussion_r227861326","pull_request_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/comments/227861326"},"html":{"href":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1#discussion_r227861326"},"pull_request":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1","id":225453407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDUzNDA3","html_url":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1","diff_url":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1.diff","patch_url":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1.patch","issue_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/1","number":1,"state":"open","locked":false,"title":"Develop","user":{"login":"Michax94","id":12932236,"node_id":"MDQ6VXNlcjEyOTMyMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/12932236?v=4","gravatar_id":"","url":"https://api.github.com/users/Michax94","html_url":"https://github.com/Michax94","followers_url":"https://api.github.com/users/Michax94/followers","following_url":"https://api.github.com/users/Michax94/following{/other_user}","gists_url":"https://api.github.com/users/Michax94/gists{/gist_id}","starred_url":"https://api.github.com/users/Michax94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michax94/subscriptions","organizations_url":"https://api.github.com/users/Michax94/orgs","repos_url":"https://api.github.com/users/Michax94/repos","events_url":"https://api.github.com/users/Michax94/events{/privacy}","received_events_url":"https://api.github.com/users/Michax94/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-24T15:38:08Z","updated_at":"2018-10-24T16:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8835b8a14b9e1a094c8b5e23e64d9eb4b8132a3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/1/comments","statuses_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/statuses/1eae72abf2d05706670d15193494cc2f325c4446","head":{"label":"Michax94:develop","ref":"develop","sha":"1eae72abf2d05706670d15193494cc2f325c4446","user":{"login":"Michax94","id":12932236,"node_id":"MDQ6VXNlcjEyOTMyMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/12932236?v=4","gravatar_id":"","url":"https://api.github.com/users/Michax94","html_url":"https://github.com/Michax94","followers_url":"https://api.github.com/users/Michax94/followers","following_url":"https://api.github.com/users/Michax94/following{/other_user}","gists_url":"https://api.github.com/users/Michax94/gists{/gist_id}","starred_url":"https://api.github.com/users/Michax94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michax94/subscriptions","organizations_url":"https://api.github.com/users/Michax94/orgs","repos_url":"https://api.github.com/users/Michax94/repos","events_url":"https://api.github.com/users/Michax94/events{/privacy}","received_events_url":"https://api.github.com/users/Michax94/received_events","type":"User","site_admin":false},"repo":{"id":154134326,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMzQzMjY=","name":"KotlinBaseApp_MVVM","full_name":"Michax94/KotlinBaseApp_MVVM","private":false,"owner":{"login":"Michax94","id":12932236,"node_id":"MDQ6VXNlcjEyOTMyMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/12932236?v=4","gravatar_id":"","url":"https://api.github.com/users/Michax94","html_url":"https://github.com/Michax94","followers_url":"https://api.github.com/users/Michax94/followers","following_url":"https://api.github.com/users/Michax94/following{/other_user}","gists_url":"https://api.github.com/users/Michax94/gists{/gist_id}","starred_url":"https://api.github.com/users/Michax94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michax94/subscriptions","organizations_url":"https://api.github.com/users/Michax94/orgs","repos_url":"https://api.github.com/users/Michax94/repos","events_url":"https://api.github.com/users/Michax94/events{/privacy}","received_events_url":"https://api.github.com/users/Michax94/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Michax94/KotlinBaseApp_MVVM","description":null,"fork":false,"url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM","forks_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/forks","keys_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/teams","hooks_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/hooks","issue_events_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/events{/number}","events_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/events","assignees_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/assignees{/user}","branches_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/branches{/branch}","tags_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/tags","blobs_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/statuses/{sha}","languages_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/languages","stargazers_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/stargazers","contributors_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/contributors","subscribers_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/subscribers","subscription_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/subscription","commits_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/contents/{+path}","compare_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/merges","archive_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/downloads","issues_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues{/number}","pulls_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls{/number}","milestones_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/milestones{/number}","notifications_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/labels{/name}","releases_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/releases{/id}","deployments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/deployments","created_at":"2018-10-22T11:47:54Z","updated_at":"2018-10-22T11:47:54Z","pushed_at":"2018-10-24T15:38:09Z","git_url":"git://github.com/Michax94/KotlinBaseApp_MVVM.git","ssh_url":"git@github.com:Michax94/KotlinBaseApp_MVVM.git","clone_url":"https://github.com/Michax94/KotlinBaseApp_MVVM.git","svn_url":"https://github.com/Michax94/KotlinBaseApp_MVVM","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Michax94:master","ref":"master","sha":"d486e6de7734271752bc2337f1b08c7a75968853","user":{"login":"Michax94","id":12932236,"node_id":"MDQ6VXNlcjEyOTMyMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/12932236?v=4","gravatar_id":"","url":"https://api.github.com/users/Michax94","html_url":"https://github.com/Michax94","followers_url":"https://api.github.com/users/Michax94/followers","following_url":"https://api.github.com/users/Michax94/following{/other_user}","gists_url":"https://api.github.com/users/Michax94/gists{/gist_id}","starred_url":"https://api.github.com/users/Michax94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michax94/subscriptions","organizations_url":"https://api.github.com/users/Michax94/orgs","repos_url":"https://api.github.com/users/Michax94/repos","events_url":"https://api.github.com/users/Michax94/events{/privacy}","received_events_url":"https://api.github.com/users/Michax94/received_events","type":"User","site_admin":false},"repo":{"id":154134326,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMzQzMjY=","name":"KotlinBaseApp_MVVM","full_name":"Michax94/KotlinBaseApp_MVVM","private":false,"owner":{"login":"Michax94","id":12932236,"node_id":"MDQ6VXNlcjEyOTMyMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/12932236?v=4","gravatar_id":"","url":"https://api.github.com/users/Michax94","html_url":"https://github.com/Michax94","followers_url":"https://api.github.com/users/Michax94/followers","following_url":"https://api.github.com/users/Michax94/following{/other_user}","gists_url":"https://api.github.com/users/Michax94/gists{/gist_id}","starred_url":"https://api.github.com/users/Michax94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michax94/subscriptions","organizations_url":"https://api.github.com/users/Michax94/orgs","repos_url":"https://api.github.com/users/Michax94/repos","events_url":"https://api.github.com/users/Michax94/events{/privacy}","received_events_url":"https://api.github.com/users/Michax94/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Michax94/KotlinBaseApp_MVVM","description":null,"fork":false,"url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM","forks_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/forks","keys_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/teams","hooks_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/hooks","issue_events_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/events{/number}","events_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/events","assignees_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/assignees{/user}","branches_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/branches{/branch}","tags_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/tags","blobs_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/statuses/{sha}","languages_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/languages","stargazers_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/stargazers","contributors_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/contributors","subscribers_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/subscribers","subscription_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/subscription","commits_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/contents/{+path}","compare_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/merges","archive_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/downloads","issues_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues{/number}","pulls_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls{/number}","milestones_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/milestones{/number}","notifications_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/labels{/name}","releases_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/releases{/id}","deployments_url":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/deployments","created_at":"2018-10-22T11:47:54Z","updated_at":"2018-10-22T11:47:54Z","pushed_at":"2018-10-24T15:38:09Z","git_url":"git://github.com/Michax94/KotlinBaseApp_MVVM.git","ssh_url":"git@github.com:Michax94/KotlinBaseApp_MVVM.git","clone_url":"https://github.com/Michax94/KotlinBaseApp_MVVM.git","svn_url":"https://github.com/Michax94/KotlinBaseApp_MVVM","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1"},"html":{"href":"https://github.com/Michax94/KotlinBaseApp_MVVM/pull/1"},"issue":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/1"},"comments":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Michax94/KotlinBaseApp_MVVM/statuses/1eae72abf2d05706670d15193494cc2f325c4446"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jothaen"}}