{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/10998","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/10998/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/10998/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/10998/events","html_url":"https://github.com/flutter/flutter/issues/10998","id":238932358,"node_id":"MDU6SXNzdWUyMzg5MzIzNTg=","number":10998,"title":"Run memory benchmarks in release mode","user":{"login":"yjbanov","id":211513,"node_id":"MDQ6VXNlcjIxMTUxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"labels":[{"id":283479128,"node_id":"MDU6TGFiZWwyODM0NzkxMjg=","url":"https://api.github.com/repos/flutter/flutter/labels/a:%20tests","name":"a: tests","color":"38d8c8","default":false},{"id":298590876,"node_id":"MDU6TGFiZWwyOTg1OTA4NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/severe:%20performance","name":"severe: performance","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"assignees":[{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/flutter/flutter/milestones/8","html_url":"https://github.com/flutter/flutter/milestone/8","labels_url":"https://api.github.com/repos/flutter/flutter/milestones/8/labels","id":1561714,"node_id":"MDk6TWlsZXN0b25lMTU2MTcxNA==","number":8,"title":"No milestone necessary","description":"This milestone contains metaissues, technical debt issues, team infrastructure, and other topics that have been triaged but don't need a priority level or milestone. Customer requests shouldn't end up in this milestone.\r\n\r\nThe date on this milestone is utterly arbitrary and just intended to sort the milestone appropriately.","creator":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"open_issues":210,"closed_issues":321,"state":"open","created_at":"2016-02-03T18:50:46Z","updated_at":"2018-07-12T02:01:11Z","due_on":"2035-01-01T08:00:00Z","closed_at":null},"comments":1,"created_at":"2017-06-27T17:55:08Z","updated_at":"2018-07-18T21:59:23Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We currently run memory benchmarks in `--profile` mode. This allows us to use the VM service to synchronize the framework with memory measurements, but it also adds overhead from the VM service and timeline skewing the results. We should be able to run these benchmarks in release mode. However, we'd need a replacement for the VM service. We perform the following operations via the VM service:\r\n\r\n- wait for the first frame to render before measuring the initial memory usage (`start_total_kb`)\r\n  * this can be replaced by a simple `print` statement and read out of the `logcat`\r\n- run a driver test that exercises the app in order to get a \"cruising\" memory usage (`end_total_kb`)\r\n  * this can be replaced by an ad hoc test that drives the app from within the app process\r\n\r\n/cc @rmacnak-google @eseidelGoogle"},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/406087507","html_url":"https://github.com/flutter/flutter/issues/10998#issuecomment-406087507","issue_url":"https://api.github.com/repos/flutter/flutter/issues/10998","id":406087507,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjA4NzUwNw==","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T21:59:23Z","updated_at":"2018-07-18T21:59:23Z","author_association":"CONTRIBUTOR","body":"Two options I can think of:\r\n- make the memory benchmark process much more long-lived (right now this test takes a few seconds at most)\r\n- run the test multiple times and use the median each time, rather than running it just once\r\n\r\n@rmacnak-google @a-siva Any advice as to what would be a good way to get less noisy and more useful data regarding memory usage of Flutter apps?"}}
{"actor":{"display_login":"Hixie"}}