{"action":"closed","number":1229,"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1229","id":170872816,"html_url":"https://github.com/lagom/lagom/pull/1229","diff_url":"https://github.com/lagom/lagom/pull/1229.diff","patch_url":"https://github.com/lagom/lagom/pull/1229.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1229","number":1229,"state":"closed","locked":false,"title":"use proper plugin reference at scala docs","user":{"login":"jaros","id":903893,"avatar_url":"https://avatars1.githubusercontent.com/u/903893?v=4","gravatar_id":"","url":"https://api.github.com/users/jaros","html_url":"https://github.com/jaros","followers_url":"https://api.github.com/users/jaros/followers","following_url":"https://api.github.com/users/jaros/following{/other_user}","gists_url":"https://api.github.com/users/jaros/gists{/gist_id}","starred_url":"https://api.github.com/users/jaros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaros/subscriptions","organizations_url":"https://api.github.com/users/jaros/orgs","repos_url":"https://api.github.com/users/jaros/repos","events_url":"https://api.github.com/users/jaros/events{/privacy}","received_events_url":"https://api.github.com/users/jaros/received_events","type":"User","site_admin":false},"body":"at https://www.lagomframework.com/documentation/1.4.x/scala/ServicePort.html\r\nwould be more logical to use .enablePlugins(LagomScala) for sbt scala project\r\n\r\n# Pull Request Checklist\r\n\r\n* [x] Have you read through the [contributor guidelines](https://github.com/lagom/lagom/tree/master/CONTRIBUTING.md)?\r\n* [x] Have you signed the [Lightbend CLA](https://www.lightbend.com/contribute/cla)?\r\n* [x] Have you [squashed your commits](https://github.com/lagom/lagom/tree/master/WorkingWithGit.md)?\r\n* [x] Have you added copyright headers to new files?\r\n* [x] Have you updated the documentation?\r\n* [x] Have you added tests for any changed functionality?\r\n\r\n## Fixes\r\n\r\nFixes #xxxx\r\n\r\n## Purpose\r\n\r\nWhat does this PR do?\r\n\r\n## Background Context\r\n\r\nWhy did you take this approach?\r\n\r\n## References\r\n\r\nAre there any relevant issues / PRs / mailing lists discussions?\r\n","created_at":"2018-02-22T21:37:29Z","updated_at":"2018-02-22T22:08:54Z","closed_at":"2018-02-22T22:08:54Z","merged_at":null,"merge_commit_sha":"eedd8d3ff2e55a9faaa1bfc4a39c7f392cd7a814","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1229/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/c3f8df30bad5fd40495b5ae4842514d47fd63aef","head":{"label":"jaros:patch-1","ref":"patch-1","sha":"c3f8df30bad5fd40495b5ae4842514d47fd63aef","user":{"login":"jaros","id":903893,"avatar_url":"https://avatars1.githubusercontent.com/u/903893?v=4","gravatar_id":"","url":"https://api.github.com/users/jaros","html_url":"https://github.com/jaros","followers_url":"https://api.github.com/users/jaros/followers","following_url":"https://api.github.com/users/jaros/following{/other_user}","gists_url":"https://api.github.com/users/jaros/gists{/gist_id}","starred_url":"https://api.github.com/users/jaros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaros/subscriptions","organizations_url":"https://api.github.com/users/jaros/orgs","repos_url":"https://api.github.com/users/jaros/repos","events_url":"https://api.github.com/users/jaros/events{/privacy}","received_events_url":"https://api.github.com/users/jaros/received_events","type":"User","site_admin":false},"repo":{"id":122537477,"name":"lagom","full_name":"jaros/lagom","owner":{"login":"jaros","id":903893,"avatar_url":"https://avatars1.githubusercontent.com/u/903893?v=4","gravatar_id":"","url":"https://api.github.com/users/jaros","html_url":"https://github.com/jaros","followers_url":"https://api.github.com/users/jaros/followers","following_url":"https://api.github.com/users/jaros/following{/other_user}","gists_url":"https://api.github.com/users/jaros/gists{/gist_id}","starred_url":"https://api.github.com/users/jaros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaros/subscriptions","organizations_url":"https://api.github.com/users/jaros/orgs","repos_url":"https://api.github.com/users/jaros/repos","events_url":"https://api.github.com/users/jaros/events{/privacy}","received_events_url":"https://api.github.com/users/jaros/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaros/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/jaros/lagom","forks_url":"https://api.github.com/repos/jaros/lagom/forks","keys_url":"https://api.github.com/repos/jaros/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaros/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaros/lagom/teams","hooks_url":"https://api.github.com/repos/jaros/lagom/hooks","issue_events_url":"https://api.github.com/repos/jaros/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/jaros/lagom/events","assignees_url":"https://api.github.com/repos/jaros/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/jaros/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/jaros/lagom/tags","blobs_url":"https://api.github.com/repos/jaros/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaros/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaros/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaros/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaros/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/jaros/lagom/languages","stargazers_url":"https://api.github.com/repos/jaros/lagom/stargazers","contributors_url":"https://api.github.com/repos/jaros/lagom/contributors","subscribers_url":"https://api.github.com/repos/jaros/lagom/subscribers","subscription_url":"https://api.github.com/repos/jaros/lagom/subscription","commits_url":"https://api.github.com/repos/jaros/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaros/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaros/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaros/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaros/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/jaros/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaros/lagom/merges","archive_url":"https://api.github.com/repos/jaros/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaros/lagom/downloads","issues_url":"https://api.github.com/repos/jaros/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/jaros/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/jaros/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/jaros/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaros/lagom/labels{/name}","releases_url":"https://api.github.com/repos/jaros/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/jaros/lagom/deployments","created_at":"2018-02-22T21:28:37Z","updated_at":"2018-02-22T21:28:41Z","pushed_at":"2018-02-22T21:32:50Z","git_url":"git://github.com/jaros/lagom.git","ssh_url":"git@github.com:jaros/lagom.git","clone_url":"https://github.com/jaros/lagom.git","svn_url":"https://github.com/jaros/lagom","homepage":"https://www.lagomframework.com","size":7390,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:1.4.x","ref":"1.4.x","sha":"65263d0abfe7d9e97bdf9fbe992e75b9119d3292","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2018-02-22T09:30:11Z","pushed_at":"2018-02-22T21:37:30Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":7390,"stargazers_count":1753,"watchers_count":1753,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":377,"open_issues":226,"watchers":1753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1229"},"html":{"href":"https://github.com/lagom/lagom/pull/1229"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1229"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/c3f8df30bad5fd40495b5ae4842514d47fd63aef"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"renatocaval"}}