{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/234259574","pull_request_review_id":175870295,"id":234259574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDI1OTU3NA==","diff_hunk":"@@ -0,0 +1,10 @@\n+{\n+    \"name\": \"<name of the package>\",\n+    \"version\": \"<version of the package>\",\n+    \"description\": \"<description of the package>\",\n+    \"private\": true,\n+    \"devDependencies\": {\n+        \"grunt\": \"1.0.1\",\n+        \"@sap/grunt-sapui5-bestpractice-build\": \"^1.3.17\"","path":"documentation/docs/scenarios/ui5-sap-cp/files/package.json","position":8,"original_position":8,"commit_id":"1d4c72ef8310e79fd237bf4d4e5d8187f0953ddb","original_commit_id":"1d4c72ef8310e79fd237bf4d4e5d8187f0953ddb","user":{"login":"1084565","id":11404457,"node_id":"MDQ6VXNlcjExNDA0NDU3","avatar_url":"https://avatars3.githubusercontent.com/u/11404457?v=4","gravatar_id":"","url":"https://api.github.com/users/1084565","html_url":"https://github.com/1084565","followers_url":"https://api.github.com/users/1084565/followers","following_url":"https://api.github.com/users/1084565/following{/other_user}","gists_url":"https://api.github.com/users/1084565/gists{/gist_id}","starred_url":"https://api.github.com/users/1084565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1084565/subscriptions","organizations_url":"https://api.github.com/users/1084565/orgs","repos_url":"https://api.github.com/users/1084565/repos","events_url":"https://api.github.com/users/1084565/events{/privacy}","received_events_url":"https://api.github.com/users/1084565/received_events","type":"User","site_admin":false},"body":"I'd opt against the `^` here.","created_at":"2018-11-16T16:08:53Z","updated_at":"2018-11-16T16:20:30Z","html_url":"https://github.com/SAP/jenkins-library/pull/388#discussion_r234259574","pull_request_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/388","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/234259574"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/388#discussion_r234259574"},"pull_request":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/388","id":231465819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDY1ODE5","html_url":"https://github.com/SAP/jenkins-library/pull/388","diff_url":"https://github.com/SAP/jenkins-library/pull/388.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/388.patch","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/388","number":388,"state":"open","locked":false,"title":"Add UI5-SAP-CP scenario","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"We would like to get ride of repo `jenkins-pipelines`. It would be an option to integrate the pipeline script(s) from that repo here as pipeline steps.\r\n\r\nIn order to distiguish those scenarios from 'normal' pipeline steps we should establish a naming convention, e.g. `scenarioXY`.\r\n\r\nSince a scenario differs from 'normal' steps I introduced a 'scenario' entry in the documenation tree.\r\n\r\n  ","created_at":"2018-11-16T09:29:07Z","updated_at":"2018-11-16T16:20:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0cb03a7a8a733310a08eb1a442d40789f7eae91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false},{"login":"OliverNocon","id":33484802,"node_id":"MDQ6VXNlcjMzNDg0ODAy","avatar_url":"https://avatars2.githubusercontent.com/u/33484802?v=4","gravatar_id":"","url":"https://api.github.com/users/OliverNocon","html_url":"https://github.com/OliverNocon","followers_url":"https://api.github.com/users/OliverNocon/followers","following_url":"https://api.github.com/users/OliverNocon/following{/other_user}","gists_url":"https://api.github.com/users/OliverNocon/gists{/gist_id}","starred_url":"https://api.github.com/users/OliverNocon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OliverNocon/subscriptions","organizations_url":"https://api.github.com/users/OliverNocon/orgs","repos_url":"https://api.github.com/users/OliverNocon/repos","events_url":"https://api.github.com/users/OliverNocon/events{/privacy}","received_events_url":"https://api.github.com/users/OliverNocon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":766624870,"node_id":"MDU6TGFiZWw3NjY2MjQ4NzA=","url":"https://api.github.com/repos/SAP/jenkins-library/labels/discussion","name":"discussion","color":"006b75","default":false},{"id":750277627,"node_id":"MDU6TGFiZWw3NTAyNzc2Mjc=","url":"https://api.github.com/repos/SAP/jenkins-library/labels/work%20in%20progress","name":"work in progress","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/388/commits","review_comments_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/388/comments","review_comment_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/388/comments","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/1d4c72ef8310e79fd237bf4d4e5d8187f0953ddb","head":{"label":"marcusholl:pr/scenarioUI5SAPCP","ref":"pr/scenarioUI5SAPCP","sha":"1d4c72ef8310e79fd237bf4d4e5d8187f0953ddb","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"repo":{"id":110531482,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1MzE0ODI=","name":"jenkins-library","full_name":"marcusholl/jenkins-library","private":false,"owner":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcusholl/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":true,"url":"https://api.github.com/repos/marcusholl/jenkins-library","forks_url":"https://api.github.com/repos/marcusholl/jenkins-library/forks","keys_url":"https://api.github.com/repos/marcusholl/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcusholl/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcusholl/jenkins-library/teams","hooks_url":"https://api.github.com/repos/marcusholl/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/marcusholl/jenkins-library/events","assignees_url":"https://api.github.com/repos/marcusholl/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/marcusholl/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/tags","blobs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcusholl/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/marcusholl/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/marcusholl/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/marcusholl/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscription","commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcusholl/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcusholl/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/marcusholl/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcusholl/jenkins-library/merges","archive_url":"https://api.github.com/repos/marcusholl/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcusholl/jenkins-library/downloads","issues_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/marcusholl/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/marcusholl/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/marcusholl/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcusholl/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/marcusholl/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/marcusholl/jenkins-library/deployments","created_at":"2017-11-13T10:05:10Z","updated_at":"2018-11-05T13:12:26Z","pushed_at":"2018-11-16T14:54:44Z","git_url":"git://github.com/marcusholl/jenkins-library.git","ssh_url":"git@github.com:marcusholl/jenkins-library.git","clone_url":"https://github.com/marcusholl/jenkins-library.git","svn_url":"https://github.com/marcusholl/jenkins-library","homepage":null,"size":2268,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"d65a0101583ae8a5bc1bf856088ecabfc5170992","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":107318996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczMTg5OTY=","name":"jenkins-library","full_name":"SAP/jenkins-library","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.  https://sap.github.io/jenkins-library/","fork":false,"url":"https://api.github.com/repos/SAP/jenkins-library","forks_url":"https://api.github.com/repos/SAP/jenkins-library/forks","keys_url":"https://api.github.com/repos/SAP/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/jenkins-library/teams","hooks_url":"https://api.github.com/repos/SAP/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/jenkins-library/events","assignees_url":"https://api.github.com/repos/SAP/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/jenkins-library/tags","blobs_url":"https://api.github.com/repos/SAP/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/SAP/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/SAP/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/SAP/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/SAP/jenkins-library/subscription","commits_url":"https://api.github.com/repos/SAP/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/jenkins-library/merges","archive_url":"https://api.github.com/repos/SAP/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/jenkins-library/downloads","issues_url":"https://api.github.com/repos/SAP/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/SAP/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/jenkins-library/deployments","created_at":"2017-10-17T20:14:48Z","updated_at":"2018-11-16T07:57:14Z","pushed_at":"2018-11-16T14:54:45Z","git_url":"git://github.com/SAP/jenkins-library.git","ssh_url":"git@github.com:SAP/jenkins-library.git","clone_url":"https://github.com/SAP/jenkins-library.git","svn_url":"https://github.com/SAP/jenkins-library","homepage":"","size":3653,"stargazers_count":132,"watchers_count":132,"language":"Groovy","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":32,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/388"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/388"},"issue":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/388"},"comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/jenkins-library/statuses/1d4c72ef8310e79fd237bf4d4e5d8187f0953ddb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"1084565"}}