{"action":"created","comment":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/comments/177200938","pull_request_review_id":107033725,"id":177200938,"diff_hunk":"@@ -73,6 +73,15 @@ class InvalidRepeatedCapabilityError(Exception):\n         super(InvalidRepeatedCapabilityError, self).__init__('An invalid character ({0}) was found in repeated capability string ({1})'.format(invalid_character, invalid_string))\n \n \n+class SelfTestFailureError(Exception):\n+    '''An error due to a failed self test'''","path":"build/templates/errors.py.mako","position":5,"original_position":5,"commit_id":"0c8ef0ce3a480e8358a3d2269d04a59d701018bd","original_commit_id":"0c8ef0ce3a480e8358a3d2269d04a59d701018bd","user":{"login":"marcoskirsch","id":8085768,"avatar_url":"https://avatars0.githubusercontent.com/u/8085768?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoskirsch","html_url":"https://github.com/marcoskirsch","followers_url":"https://api.github.com/users/marcoskirsch/followers","following_url":"https://api.github.com/users/marcoskirsch/following{/other_user}","gists_url":"https://api.github.com/users/marcoskirsch/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoskirsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoskirsch/subscriptions","organizations_url":"https://api.github.com/users/marcoskirsch/orgs","repos_url":"https://api.github.com/users/marcoskirsch/repos","events_url":"https://api.github.com/users/marcoskirsch/events{/privacy}","received_events_url":"https://api.github.com/users/marcoskirsch/received_events","type":"User","site_admin":false},"body":"I believe tech comm says to use \"self-test\".","created_at":"2018-03-26T19:05:20Z","updated_at":"2018-03-26T19:32:31Z","html_url":"https://github.com/ni/nimi-python/pull/777#discussion_r177200938","pull_request_url":"https://api.github.com/repos/ni/nimi-python/pulls/777","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/comments/177200938"},"html":{"href":"https://github.com/ni/nimi-python/pull/777#discussion_r177200938"},"pull_request":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/777","id":176244867,"html_url":"https://github.com/ni/nimi-python/pull/777","diff_url":"https://github.com/ni/nimi-python/pull/777.diff","patch_url":"https://github.com/ni/nimi-python/pull/777.patch","issue_url":"https://api.github.com/repos/ni/nimi-python/issues/777","number":777,"state":"open","locked":false,"title":"Raise an exception when self test returns non zero code","user":{"login":"texasaggie97","id":11483903,"avatar_url":"https://avatars1.githubusercontent.com/u/11483903?v=4","gravatar_id":"","url":"https://api.github.com/users/texasaggie97","html_url":"https://github.com/texasaggie97","followers_url":"https://api.github.com/users/texasaggie97/followers","following_url":"https://api.github.com/users/texasaggie97/following{/other_user}","gists_url":"https://api.github.com/users/texasaggie97/gists{/gist_id}","starred_url":"https://api.github.com/users/texasaggie97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texasaggie97/subscriptions","organizations_url":"https://api.github.com/users/texasaggie97/orgs","repos_url":"https://api.github.com/users/texasaggie97/repos","events_url":"https://api.github.com/users/texasaggie97/events{/privacy}","received_events_url":"https://api.github.com/users/texasaggie97/received_events","type":"User","site_admin":false},"body":"- [X] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md).\r\n- [X] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.\r\n- [X] I've added & updated tests applicable for this pull request\r\n### What does this Pull Request accomplish?\r\n* Add wrapper function around generated self test\r\n* Raise new self test exception if non zero code returned\r\n* Fixes tests\r\n* Add self_test to nifake to allow unit testing\r\n### List issues fixed by this Pull Request below, if any.\r\n\r\n* Fix #668 \r\n\r\n### What testing has been done?\r\n* Unit\r\n* System","created_at":"2018-03-20T16:16:49Z","updated_at":"2018-03-26T19:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c403b0860c8f7100018ee6b79acf8d7cde55b8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ni/nimi-python/pulls/777/commits","review_comments_url":"https://api.github.com/repos/ni/nimi-python/pulls/777/comments","review_comment_url":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/nimi-python/issues/777/comments","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/0c8ef0ce3a480e8358a3d2269d04a59d701018bd","head":{"label":"ni:bug668/self_test","ref":"bug668/self_test","sha":"0c8ef0ce3a480e8358a3d2269d04a59d701018bd","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-03-22T22:56:48Z","pushed_at":"2018-03-22T23:07:20Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":5314,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":57,"watchers":18,"default_branch":"master"}},"base":{"label":"ni:master","ref":"master","sha":"9046ead764a542fcdd407671adafeb26af107919","user":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-03-22T22:56:48Z","pushed_at":"2018-03-22T23:07:20Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":5314,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":57,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/777"},"html":{"href":"https://github.com/ni/nimi-python/pull/777"},"issue":{"href":"https://api.github.com/repos/ni/nimi-python/issues/777"},"comments":{"href":"https://api.github.com/repos/ni/nimi-python/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/ni/nimi-python/statuses/0c8ef0ce3a480e8358a3d2269d04a59d701018bd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marcoskirsch"}}