{"action":"created","issue":{"url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/402","repository_url":"https://api.github.com/repos/ccrama/Slide-iOS","labels_url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/402/comments","events_url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/402/events","html_url":"https://github.com/ccrama/Slide-iOS/issues/402","id":351407447,"node_id":"MDU6SXNzdWUzNTE0MDc0NDc=","number":402,"title":"Browsing through large albums causes crash","user":{"login":"djjcast","id":694435,"node_id":"MDQ6VXNlcjY5NDQzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/694435?v=4","gravatar_id":"","url":"https://api.github.com/users/djjcast","html_url":"https://github.com/djjcast","followers_url":"https://api.github.com/users/djjcast/followers","following_url":"https://api.github.com/users/djjcast/following{/other_user}","gists_url":"https://api.github.com/users/djjcast/gists{/gist_id}","starred_url":"https://api.github.com/users/djjcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djjcast/subscriptions","organizations_url":"https://api.github.com/users/djjcast/orgs","repos_url":"https://api.github.com/users/djjcast/repos","events_url":"https://api.github.com/users/djjcast/events{/privacy}","received_events_url":"https://api.github.com/users/djjcast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ccrama/Slide-iOS/milestones/2","html_url":"https://github.com/ccrama/Slide-iOS/milestone/2","labels_url":"https://api.github.com/repos/ccrama/Slide-iOS/milestones/2/labels","id":3577538,"node_id":"MDk6TWlsZXN0b25lMzU3NzUzOA==","number":2,"title":"Release v1.1","description":"","creator":{"login":"ccrama","id":3819844,"node_id":"MDQ6VXNlcjM4MTk4NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3819844?v=4","gravatar_id":"","url":"https://api.github.com/users/ccrama","html_url":"https://github.com/ccrama","followers_url":"https://api.github.com/users/ccrama/followers","following_url":"https://api.github.com/users/ccrama/following{/other_user}","gists_url":"https://api.github.com/users/ccrama/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrama/subscriptions","organizations_url":"https://api.github.com/users/ccrama/orgs","repos_url":"https://api.github.com/users/ccrama/repos","events_url":"https://api.github.com/users/ccrama/events{/privacy}","received_events_url":"https://api.github.com/users/ccrama/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2018-08-16T23:10:39Z","updated_at":"2018-08-17T07:06:26Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-08-16T23:54:25Z","updated_at":"2018-08-17T18:30:06Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The issue was noticed on an iPhone 6 Plus - 10.3.3 (14G60). Browsing through the following album causes a crash with no error message in Xcode's console.\r\n\r\nhttps://old.reddit.com/r/DIY/comments/96c6yc/we_dont_have_any_trees_but_i_wanted_to_build_a/\r\n\r\nThe following changes resolve the issue for the above album:\r\n\r\nhttps://github.com/djjcast/Slide-iOS/commit/4838113fe8ab7bc0d5995cae9e62bf2c2d4f4a4e\r\n\r\nAlthough, the following, much larger, album still causes a crash with no error message:\r\n\r\nhttps://old.reddit.com/r/MechanicalKeyboards/comments/8vkbzd/june_2018_utah_meetup_higher_quality_pics_in/\r\n\r\nThe following changes seem to improve performance but browsing the above album still eventually causes a crash:\r\n\r\nhttps://github.com/djjcast/Slide-iOS/commit/eba8d5a52b103be9e00ddb4eb460db64c7902934\r\n\r\nMaybe there's a memory leak somewhere? Browsing through albums causes the memory usage to continually increase - see https://stackoverflow.com/a/31819410 (not sure if it's true or still relevant). Maybe UIPageViewController isn't suited to be used as an image browser?\r\n\r\nMaybe the Gallery view can be repurposed as an album viewer since it seemed to perform well?"},"comment":{"url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/comments/413951905","html_url":"https://github.com/ccrama/Slide-iOS/issues/402#issuecomment-413951905","issue_url":"https://api.github.com/repos/ccrama/Slide-iOS/issues/402","id":413951905,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzk1MTkwNQ==","user":{"login":"ccrama","id":3819844,"node_id":"MDQ6VXNlcjM4MTk4NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3819844?v=4","gravatar_id":"","url":"https://api.github.com/users/ccrama","html_url":"https://github.com/ccrama","followers_url":"https://api.github.com/users/ccrama/followers","following_url":"https://api.github.com/users/ccrama/following{/other_user}","gists_url":"https://api.github.com/users/ccrama/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrama/subscriptions","organizations_url":"https://api.github.com/users/ccrama/orgs","repos_url":"https://api.github.com/users/ccrama/repos","events_url":"https://api.github.com/users/ccrama/events{/privacy}","received_events_url":"https://api.github.com/users/ccrama/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T18:30:06Z","updated_at":"2018-08-17T18:30:06Z","author_association":"OWNER","body":"Scrolling through albums now does *not* continuously increase my ram"}}
{"actor":{"display_login":"ccrama"}}