{"action":"created","issue":{"url":"https://api.github.com/repos/subutai-io/p2p/issues/799","repository_url":"https://api.github.com/repos/subutai-io/p2p","labels_url":"https://api.github.com/repos/subutai-io/p2p/issues/799/labels{/name}","comments_url":"https://api.github.com/repos/subutai-io/p2p/issues/799/comments","events_url":"https://api.github.com/repos/subutai-io/p2p/issues/799/events","html_url":"https://github.com/subutai-io/p2p/issues/799","id":312386117,"number":799,"title":"Missing p2p environments on peer.","user":{"login":"AlinaPenkina","id":34295807,"avatar_url":"https://avatars3.githubusercontent.com/u/34295807?v=4","gravatar_id":"","url":"https://api.github.com/users/AlinaPenkina","html_url":"https://github.com/AlinaPenkina","followers_url":"https://api.github.com/users/AlinaPenkina/followers","following_url":"https://api.github.com/users/AlinaPenkina/following{/other_user}","gists_url":"https://api.github.com/users/AlinaPenkina/gists{/gist_id}","starred_url":"https://api.github.com/users/AlinaPenkina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlinaPenkina/subscriptions","organizations_url":"https://api.github.com/users/AlinaPenkina/orgs","repos_url":"https://api.github.com/users/AlinaPenkina/repos","events_url":"https://api.github.com/users/AlinaPenkina/events{/privacy}","received_events_url":"https://api.github.com/users/AlinaPenkina/received_events","type":"User","site_admin":false},"labels":[{"id":790493877,"url":"https://api.github.com/repos/subutai-io/p2p/labels/bug","name":"bug","color":"FF0000","default":true}],"state":"open","locked":false,"assignee":{"login":"azretkenzhaliev","id":7948741,"avatar_url":"https://avatars3.githubusercontent.com/u/7948741?v=4","gravatar_id":"","url":"https://api.github.com/users/azretkenzhaliev","html_url":"https://github.com/azretkenzhaliev","followers_url":"https://api.github.com/users/azretkenzhaliev/followers","following_url":"https://api.github.com/users/azretkenzhaliev/following{/other_user}","gists_url":"https://api.github.com/users/azretkenzhaliev/gists{/gist_id}","starred_url":"https://api.github.com/users/azretkenzhaliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azretkenzhaliev/subscriptions","organizations_url":"https://api.github.com/users/azretkenzhaliev/orgs","repos_url":"https://api.github.com/users/azretkenzhaliev/repos","events_url":"https://api.github.com/users/azretkenzhaliev/events{/privacy}","received_events_url":"https://api.github.com/users/azretkenzhaliev/received_events","type":"User","site_admin":false},"assignees":[{"login":"azretkenzhaliev","id":7948741,"avatar_url":"https://avatars3.githubusercontent.com/u/7948741?v=4","gravatar_id":"","url":"https://api.github.com/users/azretkenzhaliev","html_url":"https://github.com/azretkenzhaliev","followers_url":"https://api.github.com/users/azretkenzhaliev/followers","following_url":"https://api.github.com/users/azretkenzhaliev/following{/other_user}","gists_url":"https://api.github.com/users/azretkenzhaliev/gists{/gist_id}","starred_url":"https://api.github.com/users/azretkenzhaliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azretkenzhaliev/subscriptions","organizations_url":"https://api.github.com/users/azretkenzhaliev/orgs","repos_url":"https://api.github.com/users/azretkenzhaliev/repos","events_url":"https://api.github.com/users/azretkenzhaliev/events{/privacy}","received_events_url":"https://api.github.com/users/azretkenzhaliev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-04-09T04:07:07Z","updated_at":"2018-04-12T06:56:37Z","closed_at":null,"author_association":"NONE","body":"p2p can't see some environments on peer side.\n"},"comment":{"url":"https://api.github.com/repos/subutai-io/p2p/issues/comments/380698614","html_url":"https://github.com/subutai-io/p2p/issues/799#issuecomment-380698614","issue_url":"https://api.github.com/repos/subutai-io/p2p/issues/799","id":380698614,"user":{"login":"crioto","id":671147,"avatar_url":"https://avatars1.githubusercontent.com/u/671147?v=4","gravatar_id":"","url":"https://api.github.com/users/crioto","html_url":"https://github.com/crioto","followers_url":"https://api.github.com/users/crioto/followers","following_url":"https://api.github.com/users/crioto/following{/other_user}","gists_url":"https://api.github.com/users/crioto/gists{/gist_id}","starred_url":"https://api.github.com/users/crioto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crioto/subscriptions","organizations_url":"https://api.github.com/users/crioto/orgs","repos_url":"https://api.github.com/users/crioto/repos","events_url":"https://api.github.com/users/crioto/events{/privacy}","received_events_url":"https://api.github.com/users/crioto/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T06:56:37Z","updated_at":"2018-04-12T06:56:37Z","author_association":"MEMBER","body":"Improve tests for Encode and Decode methods. Currently you cover only one situation - when every setting was provided:\r\n```\r\n        P2Pinstance.Args.IP = \"10.10.10.1\"\r\n\tP2Pinstance.Args.Mac = \"Mac\"\r\n\tP2Pinstance.Args.Dev = \"Dev\"\r\n\tP2Pinstance.Args.Hash = \"Hash\"\r\n\tP2Pinstance.Args.Dht = \"Dht\"\r\n\tP2Pinstance.Args.Keyfile = \"Keyfile\"\r\n\tP2Pinstance.Args.Key = \"Key\"\r\n\tP2Pinstance.Args.TTL = \"TTL\"\r\n\tP2Pinstance.Args.Fwd = true\r\n\tP2Pinstance.Args.Port = 0\r\n```\r\nWhat you need to do is to exclude different configuration lines and check in test how it behaves. For example:\r\n```\r\n        P2Pinstance.Args.IP = \"10.10.10.1\"\r\n\tP2Pinstance.Args.Mac = \"Mac\"\r\n\tP2Pinstance.Args.Dht = \"Dht\"\r\n\tP2Pinstance.Args.Keyfile = \"Keyfile\"\r\n\tP2Pinstance.Args.Key = \"Key\"\r\n\tP2Pinstance.Args.TTL = \"TTL\"\r\n\tP2Pinstance.Args.Fwd = true\r\n\tP2Pinstance.Args.Port = 0\r\n```\r\nIn the example above we are missing two arguments. Make your tests more generic and cover all possible cases"}}
{"actor":{"display_login":"crioto"}}