{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/blink/pulls/comments/205859551","pull_request_review_id":141218948,"id":205859551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTg1OTU1MQ==","diff_hunk":"@@ -2,14 +2,20 @@\n BLINK_APP_DEFAULT_PREFETCH_COUNT=30\n BLINK_APP_DEFAULT_RATE_LIMIT=60\n BLINK_APP_DEFAULT_RETRY_LIMIT=18000\n+BLINK_APP_AUTH_NAME=puppet\n+BLINK_APP_AUTH_PASSWORD=sloth\n+\n+# Redis\n+REDIS_URL=redis://redis@localhost:6379\n \n # Disale New Relic locally\n NEW_RELIC_NO_CONFIG_FILE=true\n NEW_RELIC_ENABLED=false\n \n # Gambit Conversations\n-GAMBIT_CONVERSATIONS_API_KEY=dG90YWxseXNlY3JldA==\n GAMBIT_CONVERSATIONS_API_BASE_URL=http://localhost:5100/api/v2\n+GAMBIT_CONVERSATIONS_API_KEY=dG90YWxseXNlY3JldA==","path":".env.example","position":17,"original_position":17,"commit_id":"9573d1cfa27b4bdf07329a053d21eb7e0b6f3383","original_commit_id":"9573d1cfa27b4bdf07329a053d21eb7e0b6f3383","user":{"login":"rapala61","id":863301,"node_id":"MDQ6VXNlcjg2MzMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/863301?v=4","gravatar_id":"","url":"https://api.github.com/users/rapala61","html_url":"https://github.com/rapala61","followers_url":"https://api.github.com/users/rapala61/followers","following_url":"https://api.github.com/users/rapala61/following{/other_user}","gists_url":"https://api.github.com/users/rapala61/gists{/gist_id}","starred_url":"https://api.github.com/users/rapala61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapala61/subscriptions","organizations_url":"https://api.github.com/users/rapala61/orgs","repos_url":"https://api.github.com/users/rapala61/repos","events_url":"https://api.github.com/users/rapala61/events{/privacy}","received_events_url":"https://api.github.com/users/rapala61/received_events","type":"User","site_admin":false},"body":"Looks legit, but it's a base64 encoded dummy key.","created_at":"2018-07-27T18:19:56Z","updated_at":"2018-07-27T18:19:56Z","html_url":"https://github.com/DoSomething/blink/pull/216#discussion_r205859551","pull_request_url":"https://api.github.com/repos/DoSomething/blink/pulls/216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/comments/205859551"},"html":{"href":"https://github.com/DoSomething/blink/pull/216#discussion_r205859551"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/blink/pulls/216","id":204494894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDk0ODk0","html_url":"https://github.com/DoSomething/blink/pull/216","diff_url":"https://github.com/DoSomething/blink/pull/216.diff","patch_url":"https://github.com/DoSomething/blink/pull/216.patch","issue_url":"https://api.github.com/repos/DoSomething/blink/issues/216","number":216,"state":"open","locked":false,"title":"Use the `REDIS_URL` to tokenize Redis ENV variables internally [pr]","user":{"login":"rapala61","id":863301,"node_id":"MDQ6VXNlcjg2MzMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/863301?v=4","gravatar_id":"","url":"https://api.github.com/users/rapala61","html_url":"https://github.com/rapala61","followers_url":"https://api.github.com/users/rapala61/followers","following_url":"https://api.github.com/users/rapala61/following{/other_user}","gists_url":"https://api.github.com/users/rapala61/gists{/gist_id}","starred_url":"https://api.github.com/users/rapala61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapala61/subscriptions","organizations_url":"https://api.github.com/users/rapala61/orgs","repos_url":"https://api.github.com/users/rapala61/repos","events_url":"https://api.github.com/users/rapala61/events{/privacy}","received_events_url":"https://api.github.com/users/rapala61/received_events","type":"User","site_admin":false},"body":"## What's this PR do?\r\n\r\nIt parses the `REDIS_URL` that is injected by the Heroku Redis Add-on and tokenizes it to be used internally. Before, we were manually tokenizing and setting separate ENV variables. This fix makes the app more resilient to unexpected Redis URL changes. \r\n\r\nHere is what Heroku has to say about the `REDIS_URL` value:\r\n```\r\nIn order for Heroku to manage this add-on for you and respond to a variety of operational\r\nsituations, the REDIS config vars may change at any time. Relying on the config var\r\noutside of your Heroku app may result in you having to re-copy the value if it changes.\r\n```\r\n\r\n> [more info](https://devcenter.heroku.com/articles/heroku-redis#provisioning-the-add-on).\r\n\r\nIt also simplifies the process when Heroku schedules upgrades. With this change, we will no longer have any downtime in between the URL change and us updating the ENV variables.\r\n\r\n## How to test?\r\n\r\n- 👀 \r\n\r\n## Pending tasks\r\n- [x] Deleting the tokenized ENV variables in the Staging  environment.\r\n    - [x] Testing that removing them does not impact the app's connection to the Redis Add-on.","created_at":"2018-07-27T17:35:59Z","updated_at":"2018-07-27T18:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d03c8cdb2fce66b4eb1e1b09ae85b08f866ab078","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aaronschachter","id":1236811,"node_id":"MDQ6VXNlcjEyMzY4MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1236811?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/blink/pulls/216/commits","review_comments_url":"https://api.github.com/repos/DoSomething/blink/pulls/216/comments","review_comment_url":"https://api.github.com/repos/DoSomething/blink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/blink/issues/216/comments","statuses_url":"https://api.github.com/repos/DoSomething/blink/statuses/9573d1cfa27b4bdf07329a053d21eb7e0b6f3383","head":{"label":"DoSomething:chore-#157972674/refactor-redis-url","ref":"chore-#157972674/refactor-redis-url","sha":"9573d1cfa27b4bdf07329a053d21eb7e0b6f3383","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":83058210,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1ODIxMA==","name":"blink","full_name":"DoSomething/blink","owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/blink","description":":postbox: The DoSomething.org message bus.","fork":false,"url":"https://api.github.com/repos/DoSomething/blink","forks_url":"https://api.github.com/repos/DoSomething/blink/forks","keys_url":"https://api.github.com/repos/DoSomething/blink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/blink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/blink/teams","hooks_url":"https://api.github.com/repos/DoSomething/blink/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/blink/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/blink/events","assignees_url":"https://api.github.com/repos/DoSomething/blink/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/blink/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/blink/tags","blobs_url":"https://api.github.com/repos/DoSomething/blink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/blink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/blink/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/blink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/blink/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/blink/languages","stargazers_url":"https://api.github.com/repos/DoSomething/blink/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/blink/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/blink/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/blink/subscription","commits_url":"https://api.github.com/repos/DoSomething/blink/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/blink/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/blink/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/blink/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/blink/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/blink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/blink/merges","archive_url":"https://api.github.com/repos/DoSomething/blink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/blink/downloads","issues_url":"https://api.github.com/repos/DoSomething/blink/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/blink/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/blink/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/blink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/blink/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/blink/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/blink/deployments","created_at":"2017-02-24T15:59:24Z","updated_at":"2018-07-19T18:55:29Z","pushed_at":"2018-07-27T17:40:38Z","git_url":"git://github.com/DoSomething/blink.git","ssh_url":"git@github.com:DoSomething/blink.git","clone_url":"https://github.com/DoSomething/blink.git","svn_url":"https://github.com/DoSomething/blink","homepage":"","size":1043,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":18,"watchers":4,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"97fb7b1b0d2bc7d1f13ef7213de1e1f79d065bc3","user":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":83058210,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1ODIxMA==","name":"blink","full_name":"DoSomething/blink","owner":{"login":"DoSomething","id":731685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTY4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/blink","description":":postbox: The DoSomething.org message bus.","fork":false,"url":"https://api.github.com/repos/DoSomething/blink","forks_url":"https://api.github.com/repos/DoSomething/blink/forks","keys_url":"https://api.github.com/repos/DoSomething/blink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/blink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/blink/teams","hooks_url":"https://api.github.com/repos/DoSomething/blink/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/blink/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/blink/events","assignees_url":"https://api.github.com/repos/DoSomething/blink/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/blink/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/blink/tags","blobs_url":"https://api.github.com/repos/DoSomething/blink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/blink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/blink/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/blink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/blink/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/blink/languages","stargazers_url":"https://api.github.com/repos/DoSomething/blink/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/blink/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/blink/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/blink/subscription","commits_url":"https://api.github.com/repos/DoSomething/blink/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/blink/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/blink/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/blink/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/blink/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/blink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/blink/merges","archive_url":"https://api.github.com/repos/DoSomething/blink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/blink/downloads","issues_url":"https://api.github.com/repos/DoSomething/blink/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/blink/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/blink/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/blink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/blink/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/blink/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/blink/deployments","created_at":"2017-02-24T15:59:24Z","updated_at":"2018-07-19T18:55:29Z","pushed_at":"2018-07-27T17:40:38Z","git_url":"git://github.com/DoSomething/blink.git","ssh_url":"git@github.com:DoSomething/blink.git","clone_url":"https://github.com/DoSomething/blink.git","svn_url":"https://github.com/DoSomething/blink","homepage":"","size":1043,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":18,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/216"},"html":{"href":"https://github.com/DoSomething/blink/pull/216"},"issue":{"href":"https://api.github.com/repos/DoSomething/blink/issues/216"},"comments":{"href":"https://api.github.com/repos/DoSomething/blink/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/blink/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/blink/statuses/9573d1cfa27b4bdf07329a053d21eb7e0b6f3383"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rapala61"}}