{"action":"created","comment":{"url":"https://api.github.com/repos/containerd/containerd/pulls/comments/166449018","pull_request_review_id":94512708,"id":166449018,"diff_hunk":"@@ -140,6 +140,20 @@ func Register(r *Registration) {\n \tregister.r = append(register.r, r)\n }\n \n+// Disable disables a list of plugins by ids\n+func Disable(plugins []string) {","path":"plugin/plugin.go","position":5,"original_position":5,"commit_id":"0d91351d0e902c4b5901e121016f004a3f9e817b","original_commit_id":"0d91351d0e902c4b5901e121016f004a3f9e817b","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Yeah, will move the logic into `Graph`.","created_at":"2018-02-06T21:33:38Z","updated_at":"2018-02-06T21:33:38Z","html_url":"https://github.com/containerd/containerd/pull/2105#discussion_r166449018","pull_request_url":"https://api.github.com/repos/containerd/containerd/pulls/2105","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments/166449018"},"html":{"href":"https://github.com/containerd/containerd/pull/2105#discussion_r166449018"},"pull_request":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2105"}},"in_reply_to_id":166349900},"pull_request":{"url":"https://api.github.com/repos/containerd/containerd/pulls/2105","id":167292684,"html_url":"https://github.com/containerd/containerd/pull/2105","diff_url":"https://github.com/containerd/containerd/pull/2105.diff","patch_url":"https://github.com/containerd/containerd/pull/2105.patch","issue_url":"https://api.github.com/repos/containerd/containerd/issues/2105","number":2105,"state":"open","locked":false,"title":"Support disable plugins.","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/containerd/containerd/issues/2061.\r\n\r\nWith this PR, we can disable a `cri` and `healthcheck` plugin by adding following line in the containerd config file:\r\n```\r\ndisable_plugins = [\"cri\", \"healthcheck\"]\r\n```\r\nSigned-off-by: Lantao Liu <lantaol@google.com>","created_at":"2018-02-06T00:42:09Z","updated_at":"2018-02-06T21:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e625b7aba666e09969cc955add3f6bb6cc614545","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/containerd/containerd/pulls/2105/commits","review_comments_url":"https://api.github.com/repos/containerd/containerd/pulls/2105/comments","review_comment_url":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containerd/containerd/issues/2105/comments","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/0d91351d0e902c4b5901e121016f004a3f9e817b","head":{"label":"Random-Liu:support-disable-plugins","ref":"support-disable-plugins","sha":"0d91351d0e902c4b5901e121016f004a3f9e817b","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"repo":{"id":82423058,"name":"containerd","full_name":"Random-Liu/containerd","owner":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Random-Liu/containerd","description":"An open and reliable container runtime, by Docker","fork":true,"url":"https://api.github.com/repos/Random-Liu/containerd","forks_url":"https://api.github.com/repos/Random-Liu/containerd/forks","keys_url":"https://api.github.com/repos/Random-Liu/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Random-Liu/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Random-Liu/containerd/teams","hooks_url":"https://api.github.com/repos/Random-Liu/containerd/hooks","issue_events_url":"https://api.github.com/repos/Random-Liu/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/Random-Liu/containerd/events","assignees_url":"https://api.github.com/repos/Random-Liu/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/Random-Liu/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/Random-Liu/containerd/tags","blobs_url":"https://api.github.com/repos/Random-Liu/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Random-Liu/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Random-Liu/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Random-Liu/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Random-Liu/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Random-Liu/containerd/languages","stargazers_url":"https://api.github.com/repos/Random-Liu/containerd/stargazers","contributors_url":"https://api.github.com/repos/Random-Liu/containerd/contributors","subscribers_url":"https://api.github.com/repos/Random-Liu/containerd/subscribers","subscription_url":"https://api.github.com/repos/Random-Liu/containerd/subscription","commits_url":"https://api.github.com/repos/Random-Liu/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Random-Liu/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Random-Liu/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Random-Liu/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Random-Liu/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/Random-Liu/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Random-Liu/containerd/merges","archive_url":"https://api.github.com/repos/Random-Liu/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Random-Liu/containerd/downloads","issues_url":"https://api.github.com/repos/Random-Liu/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/Random-Liu/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Random-Liu/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Random-Liu/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Random-Liu/containerd/labels{/name}","releases_url":"https://api.github.com/repos/Random-Liu/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/Random-Liu/containerd/deployments","created_at":"2017-02-18T23:41:16Z","updated_at":"2017-02-18T23:41:18Z","pushed_at":"2018-02-06T02:30:14Z","git_url":"git://github.com/Random-Liu/containerd.git","ssh_url":"git@github.com:Random-Liu/containerd.git","clone_url":"https://github.com/Random-Liu/containerd.git","svn_url":"https://github.com/Random-Liu/containerd","homepage":"https://containerd.io","size":40612,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containerd:master","ref":"master","sha":"aa49e704e2c3b61005bfa41e7eca2951605a90ad","user":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"repo":{"id":46089560,"name":"containerd","full_name":"containerd/containerd","owner":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containerd/containerd","description":"An open and reliable container runtime","fork":false,"url":"https://api.github.com/repos/containerd/containerd","forks_url":"https://api.github.com/repos/containerd/containerd/forks","keys_url":"https://api.github.com/repos/containerd/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containerd/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containerd/containerd/teams","hooks_url":"https://api.github.com/repos/containerd/containerd/hooks","issue_events_url":"https://api.github.com/repos/containerd/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/containerd/containerd/events","assignees_url":"https://api.github.com/repos/containerd/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/containerd/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/containerd/containerd/tags","blobs_url":"https://api.github.com/repos/containerd/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containerd/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containerd/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/containerd/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/containerd/containerd/languages","stargazers_url":"https://api.github.com/repos/containerd/containerd/stargazers","contributors_url":"https://api.github.com/repos/containerd/containerd/contributors","subscribers_url":"https://api.github.com/repos/containerd/containerd/subscribers","subscription_url":"https://api.github.com/repos/containerd/containerd/subscription","commits_url":"https://api.github.com/repos/containerd/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/containerd/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/containerd/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/containerd/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/containerd/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/containerd/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containerd/containerd/merges","archive_url":"https://api.github.com/repos/containerd/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containerd/containerd/downloads","issues_url":"https://api.github.com/repos/containerd/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/containerd/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/containerd/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/containerd/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containerd/containerd/labels{/name}","releases_url":"https://api.github.com/repos/containerd/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/containerd/containerd/deployments","created_at":"2015-11-13T00:27:43Z","updated_at":"2018-02-06T20:46:30Z","pushed_at":"2018-02-06T19:53:31Z","git_url":"git://github.com/containerd/containerd.git","ssh_url":"git@github.com:containerd/containerd.git","clone_url":"https://github.com/containerd/containerd.git","svn_url":"https://github.com/containerd/containerd","homepage":"https://containerd.io","size":39704,"stargazers_count":2251,"watchers_count":2251,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":458,"open_issues":74,"watchers":2251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2105"},"html":{"href":"https://github.com/containerd/containerd/pull/2105"},"issue":{"href":"https://api.github.com/repos/containerd/containerd/issues/2105"},"comments":{"href":"https://api.github.com/repos/containerd/containerd/issues/2105/comments"},"review_comments":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2105/comments"},"review_comment":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2105/commits"},"statuses":{"href":"https://api.github.com/repos/containerd/containerd/statuses/0d91351d0e902c4b5901e121016f004a3f9e817b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Random-Liu"}}