{"action":"created","comment":{"url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/comments/172401268","pull_request_review_id":101410032,"id":172401268,"diff_hunk":"@@ -34,17 +34,19 @@ func (hp *DNSHostProvider) Init(servers []string) error {\n \tfor _, server := range servers {\n \t\thost, port, err := net.SplitHostPort(server)\n \t\tif err != nil {\n-\t\t\treturn err\n+\t\t\t// If one node is down, Init should still continue","path":"zk/dnshostprovider.go","position":5,"original_position":5,"commit_id":"3cc2f46f369e502e604dbb30fa83be3196ccbd42","original_commit_id":"3cc2f46f369e502e604dbb30fa83be3196ccbd42","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars3.githubusercontent.com/u/2348332?v=4","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"why this change? in this case the node isn't down - instead it's a configuration error. shouldn't this fail-fast?","created_at":"2018-03-06T03:37:02Z","updated_at":"2018-03-06T03:38:47Z","html_url":"https://github.com/samuel/go-zookeeper/pull/188#discussion_r172401268","pull_request_url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/comments/172401268"},"html":{"href":"https://github.com/samuel/go-zookeeper/pull/188#discussion_r172401268"},"pull_request":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188","id":173000045,"html_url":"https://github.com/samuel/go-zookeeper/pull/188","diff_url":"https://github.com/samuel/go-zookeeper/pull/188.diff","patch_url":"https://github.com/samuel/go-zookeeper/pull/188.patch","issue_url":"https://api.github.com/repos/samuel/go-zookeeper/issues/188","number":188,"state":"open","locked":false,"title":"Implement ZOOKEEPER-1576 for golang","user":{"login":"juvenzhu","id":32248939,"avatar_url":"https://avatars1.githubusercontent.com/u/32248939?v=4","gravatar_id":"","url":"https://api.github.com/users/juvenzhu","html_url":"https://github.com/juvenzhu","followers_url":"https://api.github.com/users/juvenzhu/followers","following_url":"https://api.github.com/users/juvenzhu/following{/other_user}","gists_url":"https://api.github.com/users/juvenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/juvenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juvenzhu/subscriptions","organizations_url":"https://api.github.com/users/juvenzhu/orgs","repos_url":"https://api.github.com/users/juvenzhu/repos","events_url":"https://api.github.com/users/juvenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/juvenzhu/received_events","type":"User","site_admin":false},"body":"When one node in the zk connection string is down, the current behavior of this library is to fail the connection. In that case, Quorum does maintain but zkclient using this library will not be able to connect to zk.\r\n\r\nThis pull request implements Zookeeper-1576. As far as one node in the zk connection string is alive, zkclient should still able to connect.","created_at":"2018-03-05T22:04:59Z","updated_at":"2018-03-06T03:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b92b9f4b58e4ed3ed2753a1fc98685c4126c78c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188/commits","review_comments_url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188/comments","review_comment_url":"https://api.github.com/repos/samuel/go-zookeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samuel/go-zookeeper/issues/188/comments","statuses_url":"https://api.github.com/repos/samuel/go-zookeeper/statuses/3cc2f46f369e502e604dbb30fa83be3196ccbd42","head":{"label":"juvenzhu:master","ref":"master","sha":"3cc2f46f369e502e604dbb30fa83be3196ccbd42","user":{"login":"juvenzhu","id":32248939,"avatar_url":"https://avatars1.githubusercontent.com/u/32248939?v=4","gravatar_id":"","url":"https://api.github.com/users/juvenzhu","html_url":"https://github.com/juvenzhu","followers_url":"https://api.github.com/users/juvenzhu/followers","following_url":"https://api.github.com/users/juvenzhu/following{/other_user}","gists_url":"https://api.github.com/users/juvenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/juvenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juvenzhu/subscriptions","organizations_url":"https://api.github.com/users/juvenzhu/orgs","repos_url":"https://api.github.com/users/juvenzhu/repos","events_url":"https://api.github.com/users/juvenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/juvenzhu/received_events","type":"User","site_admin":false},"repo":{"id":123983514,"name":"go-zookeeper","full_name":"juvenzhu/go-zookeeper","owner":{"login":"juvenzhu","id":32248939,"avatar_url":"https://avatars1.githubusercontent.com/u/32248939?v=4","gravatar_id":"","url":"https://api.github.com/users/juvenzhu","html_url":"https://github.com/juvenzhu","followers_url":"https://api.github.com/users/juvenzhu/followers","following_url":"https://api.github.com/users/juvenzhu/following{/other_user}","gists_url":"https://api.github.com/users/juvenzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/juvenzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juvenzhu/subscriptions","organizations_url":"https://api.github.com/users/juvenzhu/orgs","repos_url":"https://api.github.com/users/juvenzhu/repos","events_url":"https://api.github.com/users/juvenzhu/events{/privacy}","received_events_url":"https://api.github.com/users/juvenzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juvenzhu/go-zookeeper","description":"Native ZooKeeper client for Go","fork":true,"url":"https://api.github.com/repos/juvenzhu/go-zookeeper","forks_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/forks","keys_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/teams","hooks_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/events","assignees_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/tags","blobs_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/languages","stargazers_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/subscription","commits_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/merges","archive_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/downloads","issues_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/juvenzhu/go-zookeeper/deployments","created_at":"2018-03-05T21:51:57Z","updated_at":"2018-03-05T21:51:58Z","pushed_at":"2018-03-05T22:00:58Z","git_url":"git://github.com/juvenzhu/go-zookeeper.git","ssh_url":"git@github.com:juvenzhu/go-zookeeper.git","clone_url":"https://github.com/juvenzhu/go-zookeeper.git","svn_url":"https://github.com/juvenzhu/go-zookeeper","homepage":null,"size":249,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samuel:master","ref":"master","sha":"c4fab1ac1bec58281ad0667dc3f0907a9476ac47","user":{"login":"samuel","id":8503,"avatar_url":"https://avatars3.githubusercontent.com/u/8503?v=4","gravatar_id":"","url":"https://api.github.com/users/samuel","html_url":"https://github.com/samuel","followers_url":"https://api.github.com/users/samuel/followers","following_url":"https://api.github.com/users/samuel/following{/other_user}","gists_url":"https://api.github.com/users/samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuel/subscriptions","organizations_url":"https://api.github.com/users/samuel/orgs","repos_url":"https://api.github.com/users/samuel/repos","events_url":"https://api.github.com/users/samuel/events{/privacy}","received_events_url":"https://api.github.com/users/samuel/received_events","type":"User","site_admin":false},"repo":{"id":4767354,"name":"go-zookeeper","full_name":"samuel/go-zookeeper","owner":{"login":"samuel","id":8503,"avatar_url":"https://avatars3.githubusercontent.com/u/8503?v=4","gravatar_id":"","url":"https://api.github.com/users/samuel","html_url":"https://github.com/samuel","followers_url":"https://api.github.com/users/samuel/followers","following_url":"https://api.github.com/users/samuel/following{/other_user}","gists_url":"https://api.github.com/users/samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuel/subscriptions","organizations_url":"https://api.github.com/users/samuel/orgs","repos_url":"https://api.github.com/users/samuel/repos","events_url":"https://api.github.com/users/samuel/events{/privacy}","received_events_url":"https://api.github.com/users/samuel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuel/go-zookeeper","description":"Native ZooKeeper client for Go","fork":false,"url":"https://api.github.com/repos/samuel/go-zookeeper","forks_url":"https://api.github.com/repos/samuel/go-zookeeper/forks","keys_url":"https://api.github.com/repos/samuel/go-zookeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuel/go-zookeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuel/go-zookeeper/teams","hooks_url":"https://api.github.com/repos/samuel/go-zookeeper/hooks","issue_events_url":"https://api.github.com/repos/samuel/go-zookeeper/issues/events{/number}","events_url":"https://api.github.com/repos/samuel/go-zookeeper/events","assignees_url":"https://api.github.com/repos/samuel/go-zookeeper/assignees{/user}","branches_url":"https://api.github.com/repos/samuel/go-zookeeper/branches{/branch}","tags_url":"https://api.github.com/repos/samuel/go-zookeeper/tags","blobs_url":"https://api.github.com/repos/samuel/go-zookeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuel/go-zookeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuel/go-zookeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuel/go-zookeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuel/go-zookeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/samuel/go-zookeeper/languages","stargazers_url":"https://api.github.com/repos/samuel/go-zookeeper/stargazers","contributors_url":"https://api.github.com/repos/samuel/go-zookeeper/contributors","subscribers_url":"https://api.github.com/repos/samuel/go-zookeeper/subscribers","subscription_url":"https://api.github.com/repos/samuel/go-zookeeper/subscription","commits_url":"https://api.github.com/repos/samuel/go-zookeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuel/go-zookeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuel/go-zookeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuel/go-zookeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuel/go-zookeeper/contents/{+path}","compare_url":"https://api.github.com/repos/samuel/go-zookeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuel/go-zookeeper/merges","archive_url":"https://api.github.com/repos/samuel/go-zookeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuel/go-zookeeper/downloads","issues_url":"https://api.github.com/repos/samuel/go-zookeeper/issues{/number}","pulls_url":"https://api.github.com/repos/samuel/go-zookeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/samuel/go-zookeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/samuel/go-zookeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuel/go-zookeeper/labels{/name}","releases_url":"https://api.github.com/repos/samuel/go-zookeeper/releases{/id}","deployments_url":"https://api.github.com/repos/samuel/go-zookeeper/deployments","created_at":"2012-06-23T20:22:18Z","updated_at":"2018-03-06T03:06:49Z","pushed_at":"2018-03-05T22:05:00Z","git_url":"git://github.com/samuel/go-zookeeper.git","ssh_url":"git@github.com:samuel/go-zookeeper.git","clone_url":"https://github.com/samuel/go-zookeeper.git","svn_url":"https://github.com/samuel/go-zookeeper","homepage":null,"size":242,"stargazers_count":820,"watchers_count":820,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":338,"open_issues":81,"watchers":820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188"},"html":{"href":"https://github.com/samuel/go-zookeeper/pull/188"},"issue":{"href":"https://api.github.com/repos/samuel/go-zookeeper/issues/188"},"comments":{"href":"https://api.github.com/repos/samuel/go-zookeeper/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samuel/go-zookeeper/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/samuel/go-zookeeper/statuses/3cc2f46f369e502e604dbb30fa83be3196ccbd42"}},"author_association":"NONE"}}
{"actor":{"display_login":"jdef"}}