{"action":"created","comment":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/219870813","pull_request_review_id":158148115,"id":219870813,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTg3MDgxMw==","diff_hunk":"@@ -2245,20 +2264,27 @@ void DeclarationVisitor::Post(const parser::ProcInterface &x) {\n }\n \n void DeclarationVisitor::Post(const parser::ProcDecl &x) {\n-  const auto &name{std::get<parser::Name>(x.t).source};\n+  bool isFunction{false};\n+  bool isSubroutine{false};\n   ProcInterface interface;\n   if (interfaceName_) {\n     if (auto *symbol{FindExplicitInterface(*interfaceName_)}) {\n       interface.set_symbol(*symbol);\n+      isFunction = symbol->test(Symbol::Flag::Function);\n+      isSubroutine = symbol->test(Symbol::Flag::Subroutine);\n     }\n   } else if (auto &type{GetDeclTypeSpec()}) {\n     interface.set_type(*type);\n+    isFunction = true;\n   }\n   auto attrs{GetAttrs()};\n   if (currScope().kind() != Scope::Kind::DerivedType) {\n     attrs.set(Attr::EXTERNAL);\n   }\n-  DeclareProcEntity(name, attrs, interface);\n+  const auto &name{std::get<parser::Name>(x.t).source};","path":"lib/semantics/resolve-names.cc","position":193,"original_position":193,"commit_id":"1d4a84fe3ce2062652e024064cc8efabc3a448bc","original_commit_id":"1d4a84fe3ce2062652e024064cc8efabc3a448bc","user":{"login":"sscalpone","id":504306,"node_id":"MDQ6VXNlcjUwNDMwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/504306?v=4","gravatar_id":"","url":"https://api.github.com/users/sscalpone","html_url":"https://github.com/sscalpone","followers_url":"https://api.github.com/users/sscalpone/followers","following_url":"https://api.github.com/users/sscalpone/following{/other_user}","gists_url":"https://api.github.com/users/sscalpone/gists{/gist_id}","starred_url":"https://api.github.com/users/sscalpone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sscalpone/subscriptions","organizations_url":"https://api.github.com/users/sscalpone/orgs","repos_url":"https://api.github.com/users/sscalpone/repos","events_url":"https://api.github.com/users/sscalpone/events{/privacy}","received_events_url":"https://api.github.com/users/sscalpone/received_events","type":"User","site_admin":false},"body":"I'd feel more comfortable if there was an assertion indicating that only one of isF or isS can get true, if that's true.","created_at":"2018-09-24T15:02:51Z","updated_at":"2018-09-24T15:02:52Z","html_url":"https://github.com/flang-compiler/f18/pull/194#discussion_r219870813","pull_request_url":"https://api.github.com/repos/flang-compiler/f18/pulls/194","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/219870813"},"html":{"href":"https://github.com/flang-compiler/f18/pull/194#discussion_r219870813"},"pull_request":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/194","id":217671233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjcxMjMz","html_url":"https://github.com/flang-compiler/f18/pull/194","diff_url":"https://github.com/flang-compiler/f18/pull/194.diff","patch_url":"https://github.com/flang-compiler/f18/pull/194.patch","issue_url":"https://api.github.com/repos/flang-compiler/f18/issues/194","number":194,"state":"open","locked":false,"title":"Fix issues #188 and #191.","user":{"login":"tskeith","id":20650530,"node_id":"MDQ6VXNlcjIwNjUwNTMw","avatar_url":"https://avatars2.githubusercontent.com/u/20650530?v=4","gravatar_id":"","url":"https://api.github.com/users/tskeith","html_url":"https://github.com/tskeith","followers_url":"https://api.github.com/users/tskeith/followers","following_url":"https://api.github.com/users/tskeith/following{/other_user}","gists_url":"https://api.github.com/users/tskeith/gists{/gist_id}","starred_url":"https://api.github.com/users/tskeith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tskeith/subscriptions","organizations_url":"https://api.github.com/users/tskeith/orgs","repos_url":"https://api.github.com/users/tskeith/repos","events_url":"https://api.github.com/users/tskeith/events{/privacy}","received_events_url":"https://api.github.com/users/tskeith/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-24T14:14:24Z","updated_at":"2018-09-24T15:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"470a485ea8c8d6b19e471499f8cc368be1ce2420","assignee":null,"assignees":[],"requested_reviewers":[{"login":"schweitzpgi","id":22080509,"node_id":"MDQ6VXNlcjIyMDgwNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/22080509?v=4","gravatar_id":"","url":"https://api.github.com/users/schweitzpgi","html_url":"https://github.com/schweitzpgi","followers_url":"https://api.github.com/users/schweitzpgi/followers","following_url":"https://api.github.com/users/schweitzpgi/following{/other_user}","gists_url":"https://api.github.com/users/schweitzpgi/gists{/gist_id}","starred_url":"https://api.github.com/users/schweitzpgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schweitzpgi/subscriptions","organizations_url":"https://api.github.com/users/schweitzpgi/orgs","repos_url":"https://api.github.com/users/schweitzpgi/repos","events_url":"https://api.github.com/users/schweitzpgi/events{/privacy}","received_events_url":"https://api.github.com/users/schweitzpgi/received_events","type":"User","site_admin":false},{"login":"klausler","id":35819229,"node_id":"MDQ6VXNlcjM1ODE5MjI5","avatar_url":"https://avatars1.githubusercontent.com/u/35819229?v=4","gravatar_id":"","url":"https://api.github.com/users/klausler","html_url":"https://github.com/klausler","followers_url":"https://api.github.com/users/klausler/followers","following_url":"https://api.github.com/users/klausler/following{/other_user}","gists_url":"https://api.github.com/users/klausler/gists{/gist_id}","starred_url":"https://api.github.com/users/klausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausler/subscriptions","organizations_url":"https://api.github.com/users/klausler/orgs","repos_url":"https://api.github.com/users/klausler/repos","events_url":"https://api.github.com/users/klausler/events{/privacy}","received_events_url":"https://api.github.com/users/klausler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flang-compiler/f18/pulls/194/commits","review_comments_url":"https://api.github.com/repos/flang-compiler/f18/pulls/194/comments","review_comment_url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flang-compiler/f18/issues/194/comments","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/1d4a84fe3ce2062652e024064cc8efabc3a448bc","head":{"label":"flang-compiler:tsk2","ref":"tsk2","sha":"1d4a84fe3ce2062652e024064cc8efabc3a448bc","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","private":false,"owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-09-22T18:36:37Z","pushed_at":"2018-09-24T14:14:24Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":2426,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":11,"watchers":51,"default_branch":"master"}},"base":{"label":"flang-compiler:master","ref":"master","sha":"c9b323a49b2b0894a3f115d4fce61122b8e0a496","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","private":false,"owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-09-22T18:36:37Z","pushed_at":"2018-09-24T14:14:24Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":2426,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":11,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/194"},"html":{"href":"https://github.com/flang-compiler/f18/pull/194"},"issue":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/194"},"comments":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/flang-compiler/f18/statuses/1d4a84fe3ce2062652e024064cc8efabc3a448bc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sscalpone"}}