{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments/227063848","pull_request_review_id":167020750,"id":227063848,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA2Mzg0OA==","diff_hunk":"@@ -81,13 +80,40 @@ private static FlutterLogEntry parseLoggingEvent(@NotNull Event event) {\n       }\n     }\n \n-    // TODO: If message.getValueAsStringIsTruncated() is true, we'll need to retrieve the full string\n+    // TODO(pq): If message.getValueAsStringIsTruncated() is true, we'll need to retrieve the full string\n     // value and update this entry after creation.\n     String messageStr = message.getValueAsString();\n     if (message.getValueAsStringIsTruncated()) {\n       messageStr += \"...\";\n     }\n-    return new FlutterLogEntry(timestamp(event), category, level, messageStr);\n+\n+    final FlutterLogEntry entry = new FlutterLogEntry(timestamp(event), category, level, messageStr);\n+\n+    final Instance data = new Instance(logRecord.getAsJsonObject().get(\"error\").getAsJsonObject());\n+    if (!data.getValueAsStringIsTruncated()) {\n+      entry.setData(data.getValueAsString());\n+    }\n+    else {\n+      final Isolate isolate = new Isolate(json.get(\"isolate\").getAsJsonObject());\n+      debugProcess.getVmServiceWrapper().getObject(isolate.getId(), data.getId(), new GetObjectConsumer() {\n+        @Override\n+        public void received(Obj response) {\n+          entry.setData(((Instance)response).getValueAsString());\n+        }\n+\n+        @Override\n+        public void received(Sentinel response) {\n+          // ignored","path":"src/io/flutter/logging/FlutterLogEntryParser.java","position":50,"original_position":50,"commit_id":"fba3f5adf471e38b447790c9e9c4f14dc5481e82","original_commit_id":"fba3f5adf471e38b447790c9e9c4f14dc5481e82","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"body":"probably setData \r\nas null here","created_at":"2018-10-22T17:29:18Z","updated_at":"2018-10-22T17:29:19Z","html_url":"https://github.com/flutter/flutter-intellij/pull/2716#discussion_r227063848","pull_request_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments/227063848"},"html":{"href":"https://github.com/flutter/flutter-intellij/pull/2716#discussion_r227063848"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716","id":224688271,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Njg4Mjcx","html_url":"https://github.com/flutter/flutter-intellij/pull/2716","diff_url":"https://github.com/flutter/flutter-intellij/pull/2716.diff","patch_url":"https://github.com/flutter/flutter-intellij/pull/2716.patch","issue_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2716","number":2716,"state":"open","locked":false,"title":"process and present log data","user":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/67586/47296429-1443dc80-d5c7-11e8-9f8e-567e440b2540.png)\r\n\r\n/cc @devoncarew @jacob314 ","created_at":"2018-10-22T13:53:06Z","updated_at":"2018-10-22T17:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcc09117892593eaf2184e9ecd45880e0707c232","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2716/comments","statuses_url":"https://api.github.com/repos/flutter/flutter-intellij/statuses/fba3f5adf471e38b447790c9e9c4f14dc5481e82","head":{"label":"pq:log_data_view","ref":"log_data_view","sha":"fba3f5adf471e38b447790c9e9c4f14dc5481e82","user":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"repo":{"id":67261255,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI2MTI1NQ==","name":"flutter-intellij","full_name":"pq/flutter-intellij","private":false,"owner":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pq/flutter-intellij","description":"Flutter Plugin for IntelliJ","fork":true,"url":"https://api.github.com/repos/pq/flutter-intellij","forks_url":"https://api.github.com/repos/pq/flutter-intellij/forks","keys_url":"https://api.github.com/repos/pq/flutter-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pq/flutter-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pq/flutter-intellij/teams","hooks_url":"https://api.github.com/repos/pq/flutter-intellij/hooks","issue_events_url":"https://api.github.com/repos/pq/flutter-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/pq/flutter-intellij/events","assignees_url":"https://api.github.com/repos/pq/flutter-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/pq/flutter-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/pq/flutter-intellij/tags","blobs_url":"https://api.github.com/repos/pq/flutter-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pq/flutter-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pq/flutter-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/pq/flutter-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pq/flutter-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/pq/flutter-intellij/languages","stargazers_url":"https://api.github.com/repos/pq/flutter-intellij/stargazers","contributors_url":"https://api.github.com/repos/pq/flutter-intellij/contributors","subscribers_url":"https://api.github.com/repos/pq/flutter-intellij/subscribers","subscription_url":"https://api.github.com/repos/pq/flutter-intellij/subscription","commits_url":"https://api.github.com/repos/pq/flutter-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/pq/flutter-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/pq/flutter-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/pq/flutter-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/pq/flutter-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/pq/flutter-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pq/flutter-intellij/merges","archive_url":"https://api.github.com/repos/pq/flutter-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pq/flutter-intellij/downloads","issues_url":"https://api.github.com/repos/pq/flutter-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/pq/flutter-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/pq/flutter-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/pq/flutter-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pq/flutter-intellij/labels{/name}","releases_url":"https://api.github.com/repos/pq/flutter-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/pq/flutter-intellij/deployments","created_at":"2016-09-02T23:37:27Z","updated_at":"2018-06-04T12:59:58Z","pushed_at":"2018-10-22T13:51:00Z","git_url":"git://github.com/pq/flutter-intellij.git","ssh_url":"git@github.com:pq/flutter-intellij.git","clone_url":"https://github.com/pq/flutter-intellij.git","svn_url":"https://github.com/pq/flutter-intellij","homepage":"","size":17055,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"4e15fbdeb84779facc18fc493713e042f0dd1db1","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":64172164,"node_id":"MDEwOlJlcG9zaXRvcnk2NDE3MjE2NA==","name":"flutter-intellij","full_name":"flutter/flutter-intellij","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter-intellij","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter-intellij","forks_url":"https://api.github.com/repos/flutter/flutter-intellij/forks","keys_url":"https://api.github.com/repos/flutter/flutter-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter-intellij/teams","hooks_url":"https://api.github.com/repos/flutter/flutter-intellij/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter-intellij/events","assignees_url":"https://api.github.com/repos/flutter/flutter-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter-intellij/tags","blobs_url":"https://api.github.com/repos/flutter/flutter-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter-intellij/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter-intellij/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter-intellij/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter-intellij/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter-intellij/subscription","commits_url":"https://api.github.com/repos/flutter/flutter-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter-intellij/merges","archive_url":"https://api.github.com/repos/flutter/flutter-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter-intellij/downloads","issues_url":"https://api.github.com/repos/flutter/flutter-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter-intellij/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter-intellij/deployments","created_at":"2016-07-25T22:31:03Z","updated_at":"2018-10-22T15:32:34Z","pushed_at":"2018-10-22T15:32:32Z","git_url":"git://github.com/flutter/flutter-intellij.git","ssh_url":"git@github.com:flutter/flutter-intellij.git","clone_url":"https://github.com/flutter/flutter-intellij.git","svn_url":"https://github.com/flutter/flutter-intellij","homepage":"https://flutter.io/using-ide/","size":17018,"stargazers_count":392,"watchers_count":392,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":264,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":57,"open_issues":264,"watchers":392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716"},"html":{"href":"https://github.com/flutter/flutter-intellij/pull/2716"},"issue":{"href":"https://api.github.com/repos/flutter/flutter-intellij/issues/2716"},"comments":{"href":"https://api.github.com/repos/flutter/flutter-intellij/issues/2716/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2716/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter-intellij/statuses/fba3f5adf471e38b447790c9e9c4f14dc5481e82"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jacob314"}}