{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes/issues/2762","repository_url":"https://api.github.com/repos/zooniverse/Panoptes","labels_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/2762/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/2762/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/2762/events","html_url":"https://github.com/zooniverse/Panoptes/pull/2762","id":322878336,"number":2762,"title":"Allow users to edit and delete their account","user":{"login":"marten","id":277,"avatar_url":"https://avatars1.githubusercontent.com/u/277?v=4","gravatar_id":"","url":"https://api.github.com/users/marten","html_url":"https://github.com/marten","followers_url":"https://api.github.com/users/marten/followers","following_url":"https://api.github.com/users/marten/following{/other_user}","gists_url":"https://api.github.com/users/marten/gists{/gist_id}","starred_url":"https://api.github.com/users/marten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marten/subscriptions","organizations_url":"https://api.github.com/users/marten/orgs","repos_url":"https://api.github.com/users/marten/repos","events_url":"https://api.github.com/users/marten/events{/privacy}","received_events_url":"https://api.github.com/users/marten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-14T15:56:02Z","updated_at":"2018-05-18T11:25:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes/pulls/2762","html_url":"https://github.com/zooniverse/Panoptes/pull/2762","diff_url":"https://github.com/zooniverse/Panoptes/pull/2762.diff","patch_url":"https://github.com/zooniverse/Panoptes/pull/2762.patch"},"body":"I think that it might be easiest to keep features like these in Panoptes as HTML rather than APIs. That way we enforce consistency across frontends.\r\n\r\n* Renamed \"sign up\" to \"create account\". The suble distinction between \"sign up\" and \"sign in\" confuses me every time I look at this screen.\r\n\r\n![image](https://user-images.githubusercontent.com/277/40230352-1e781cc4-5a8f-11e8-8b3c-090d5eda0533.png)\r\n\r\n![image](https://user-images.githubusercontent.com/277/40232224-e02599ae-5a95-11e8-9bef-5356a35e62ce.png)\r\n\r\n![image](https://user-images.githubusercontent.com/277/40232242-ec8f3e3e-5a95-11e8-8c71-19bd834e8ff8.png)\r\n\r\n\r\nCloses #2410 \r\n\r\n# Review checklist\r\n\r\n- [ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.\r\n- [ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).\r\n- [ ] If anything changed with regards to the public API, are those changes also documented in the `apiary.apib` file?\r\n- [ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.\r\n"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes/issues/comments/390178081","html_url":"https://github.com/zooniverse/Panoptes/pull/2762#issuecomment-390178081","issue_url":"https://api.github.com/repos/zooniverse/Panoptes/issues/2762","id":390178081,"user":{"login":"marten","id":277,"avatar_url":"https://avatars1.githubusercontent.com/u/277?v=4","gravatar_id":"","url":"https://api.github.com/users/marten","html_url":"https://github.com/marten","followers_url":"https://api.github.com/users/marten/followers","following_url":"https://api.github.com/users/marten/following{/other_user}","gists_url":"https://api.github.com/users/marten/gists{/gist_id}","starred_url":"https://api.github.com/users/marten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marten/subscriptions","organizations_url":"https://api.github.com/users/marten/orgs","repos_url":"https://api.github.com/users/marten/repos","events_url":"https://api.github.com/users/marten/events{/privacy}","received_events_url":"https://api.github.com/users/marten/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T11:25:44Z","updated_at":"2018-05-18T11:25:44Z","author_association":"MEMBER","body":"@camallen Good catch. I've added a test for that, and also updated all of the other views such that #2410 will now be fixed with this as well. Might want to check it over again."}}
{"actor":{"display_login":"marten"}}