{"action":"closed","number":6712,"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6712","id":202347051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzQ3MDUx","html_url":"https://github.com/helm/charts/pull/6712","diff_url":"https://github.com/helm/charts/pull/6712.diff","patch_url":"https://github.com/helm/charts/pull/6712.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/6712","number":6712,"state":"closed","locked":false,"title":"allow imagePullSecret to be added","user":{"login":"jpke","id":21163267,"node_id":"MDQ6VXNlcjIxMTYzMjY3","avatar_url":"https://avatars0.githubusercontent.com/u/21163267?v=4","gravatar_id":"","url":"https://api.github.com/users/jpke","html_url":"https://github.com/jpke","followers_url":"https://api.github.com/users/jpke/followers","following_url":"https://api.github.com/users/jpke/following{/other_user}","gists_url":"https://api.github.com/users/jpke/gists{/gist_id}","starred_url":"https://api.github.com/users/jpke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpke/subscriptions","organizations_url":"https://api.github.com/users/jpke/orgs","repos_url":"https://api.github.com/users/jpke/repos","events_url":"https://api.github.com/users/jpke/events{/privacy}","received_events_url":"https://api.github.com/users/jpke/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAllows custom fluentd image to be pulled from a private docker repo.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-07-18T18:52:35Z","updated_at":"2018-09-30T23:50:12Z","closed_at":"2018-09-30T23:50:12Z","merged_at":null,"merge_commit_sha":"a6084637453f7c12ddabf6cb07f13099b3e2048b","assignee":{"login":"mgoodness","id":2781657,"node_id":"MDQ6VXNlcjI3ODE2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgoodness","id":2781657,"node_id":"MDQ6VXNlcjI3ODE2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"prydonius","id":1544861,"node_id":"MDQ6VXNlcjE1NDQ4NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1544861?v=4","gravatar_id":"","url":"https://api.github.com/users/prydonius","html_url":"https://github.com/prydonius","followers_url":"https://api.github.com/users/prydonius/followers","following_url":"https://api.github.com/users/prydonius/following{/other_user}","gists_url":"https://api.github.com/users/prydonius/gists{/gist_id}","starred_url":"https://api.github.com/users/prydonius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydonius/subscriptions","organizations_url":"https://api.github.com/users/prydonius/orgs","repos_url":"https://api.github.com/users/prydonius/repos","events_url":"https://api.github.com/users/prydonius/events{/privacy}","received_events_url":"https://api.github.com/users/prydonius/received_events","type":"User","site_admin":false},{"login":"lachie83","id":6912984,"node_id":"MDQ6VXNlcjY5MTI5ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6912984?v=4","gravatar_id":"","url":"https://api.github.com/users/lachie83","html_url":"https://github.com/lachie83","followers_url":"https://api.github.com/users/lachie83/followers","following_url":"https://api.github.com/users/lachie83/following{/other_user}","gists_url":"https://api.github.com/users/lachie83/gists{/gist_id}","starred_url":"https://api.github.com/users/lachie83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachie83/subscriptions","organizations_url":"https://api.github.com/users/lachie83/orgs","repos_url":"https://api.github.com/users/lachie83/repos","events_url":"https://api.github.com/users/lachie83/events{/privacy}","received_events_url":"https://api.github.com/users/lachie83/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778124484,"node_id":"MDU6TGFiZWw3NzgxMjQ0ODQ=","url":"https://api.github.com/repos/helm/charts/labels/lifecycle/stale","name":"lifecycle/stale","color":"795548","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/6712/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/6712/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/6712/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/07b08a9a02ed0a23bacb24b6fe5a304eec4b167f","head":{"label":"jpke:addImagePullSecret","ref":"addImagePullSecret","sha":"07b08a9a02ed0a23bacb24b6fe5a304eec4b167f","user":{"login":"jpke","id":21163267,"node_id":"MDQ6VXNlcjIxMTYzMjY3","avatar_url":"https://avatars0.githubusercontent.com/u/21163267?v=4","gravatar_id":"","url":"https://api.github.com/users/jpke","html_url":"https://github.com/jpke","followers_url":"https://api.github.com/users/jpke/followers","following_url":"https://api.github.com/users/jpke/following{/other_user}","gists_url":"https://api.github.com/users/jpke/gists{/gist_id}","starred_url":"https://api.github.com/users/jpke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpke/subscriptions","organizations_url":"https://api.github.com/users/jpke/orgs","repos_url":"https://api.github.com/users/jpke/repos","events_url":"https://api.github.com/users/jpke/events{/privacy}","received_events_url":"https://api.github.com/users/jpke/received_events","type":"User","site_admin":false},"repo":{"id":130408922,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0MDg5MjI=","name":"charts","full_name":"jpke/charts","private":false,"owner":{"login":"jpke","id":21163267,"node_id":"MDQ6VXNlcjIxMTYzMjY3","avatar_url":"https://avatars0.githubusercontent.com/u/21163267?v=4","gravatar_id":"","url":"https://api.github.com/users/jpke","html_url":"https://github.com/jpke","followers_url":"https://api.github.com/users/jpke/followers","following_url":"https://api.github.com/users/jpke/following{/other_user}","gists_url":"https://api.github.com/users/jpke/gists{/gist_id}","starred_url":"https://api.github.com/users/jpke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpke/subscriptions","organizations_url":"https://api.github.com/users/jpke/orgs","repos_url":"https://api.github.com/users/jpke/repos","events_url":"https://api.github.com/users/jpke/events{/privacy}","received_events_url":"https://api.github.com/users/jpke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jpke/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/jpke/charts","forks_url":"https://api.github.com/repos/jpke/charts/forks","keys_url":"https://api.github.com/repos/jpke/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpke/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpke/charts/teams","hooks_url":"https://api.github.com/repos/jpke/charts/hooks","issue_events_url":"https://api.github.com/repos/jpke/charts/issues/events{/number}","events_url":"https://api.github.com/repos/jpke/charts/events","assignees_url":"https://api.github.com/repos/jpke/charts/assignees{/user}","branches_url":"https://api.github.com/repos/jpke/charts/branches{/branch}","tags_url":"https://api.github.com/repos/jpke/charts/tags","blobs_url":"https://api.github.com/repos/jpke/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpke/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpke/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpke/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpke/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/jpke/charts/languages","stargazers_url":"https://api.github.com/repos/jpke/charts/stargazers","contributors_url":"https://api.github.com/repos/jpke/charts/contributors","subscribers_url":"https://api.github.com/repos/jpke/charts/subscribers","subscription_url":"https://api.github.com/repos/jpke/charts/subscription","commits_url":"https://api.github.com/repos/jpke/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpke/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpke/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpke/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpke/charts/contents/{+path}","compare_url":"https://api.github.com/repos/jpke/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpke/charts/merges","archive_url":"https://api.github.com/repos/jpke/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpke/charts/downloads","issues_url":"https://api.github.com/repos/jpke/charts/issues{/number}","pulls_url":"https://api.github.com/repos/jpke/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/jpke/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/jpke/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpke/charts/labels{/name}","releases_url":"https://api.github.com/repos/jpke/charts/releases{/id}","deployments_url":"https://api.github.com/repos/jpke/charts/deployments","created_at":"2018-04-20T20:06:42Z","updated_at":"2018-07-19T19:52:14Z","pushed_at":"2018-07-18T18:50:03Z","git_url":"git://github.com/jpke/charts.git","ssh_url":"git@github.com:jpke/charts.git","clone_url":"https://github.com/jpke/charts.git","svn_url":"https://github.com/jpke/charts","homepage":"","size":9067,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"09be94a0c031b80175bd42f41929fae635782364","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-09-30T17:58:33Z","pushed_at":"2018-09-30T23:27:53Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":12161,"stargazers_count":4826,"watchers_count":4826,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4279,"mirror_url":null,"archived":false,"open_issues_count":605,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4279,"open_issues":605,"watchers":4826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/6712"},"html":{"href":"https://github.com/helm/charts/pull/6712"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/6712"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/6712/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/6712/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/6712/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/07b08a9a02ed0a23bacb24b6fe5a304eec4b167f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"stale"}}