{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/6362","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/6362/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6362/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/6362/events","html_url":"https://github.com/status-im/status-react/pull/6362","id":371072520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjAxODE3","number":6362,"title":"Synchronize your own messages in 1-to-1","user":{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"labels":[{"id":613726715,"node_id":"MDU6TGFiZWw2MTM3MjY3MTU=","url":"https://api.github.com/repos/status-im/status-react/labels/Tested%20-%20Issues","name":"Tested - Issues","color":"d93f0b","default":false},{"id":795655580,"node_id":"MDU6TGFiZWw3OTU2NTU1ODA=","url":"https://api.github.com/repos/status-im/status-react/labels/chat","name":"chat","color":"f70cb0","default":false}],"state":"open","locked":false,"assignee":{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},"assignees":[{"login":"cammellos","id":1017008,"node_id":"MDQ6VXNlcjEwMTcwMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1017008?v=4","gravatar_id":"","url":"https://api.github.com/users/cammellos","html_url":"https://github.com/cammellos","followers_url":"https://api.github.com/users/cammellos/followers","following_url":"https://api.github.com/users/cammellos/following{/other_user}","gists_url":"https://api.github.com/users/cammellos/gists{/gist_id}","starred_url":"https://api.github.com/users/cammellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammellos/subscriptions","organizations_url":"https://api.github.com/users/cammellos/orgs","repos_url":"https://api.github.com/users/cammellos/repos","events_url":"https://api.github.com/users/cammellos/events{/privacy}","received_events_url":"https://api.github.com/users/cammellos/received_events","type":"User","site_admin":false},{"login":"churik","id":4557972,"node_id":"MDQ6VXNlcjQ1NTc5NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4557972?v=4","gravatar_id":"","url":"https://api.github.com/users/churik","html_url":"https://github.com/churik","followers_url":"https://api.github.com/users/churik/followers","following_url":"https://api.github.com/users/churik/following{/other_user}","gists_url":"https://api.github.com/users/churik/gists{/gist_id}","starred_url":"https://api.github.com/users/churik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/churik/subscriptions","organizations_url":"https://api.github.com/users/churik/orgs","repos_url":"https://api.github.com/users/churik/repos","events_url":"https://api.github.com/users/churik/events{/privacy}","received_events_url":"https://api.github.com/users/churik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2018-10-17T13:23:15Z","updated_at":"2018-11-06T14:03:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6362","html_url":"https://github.com/status-im/status-react/pull/6362","diff_url":"https://github.com/status-im/status-react/pull/6362.diff","patch_url":"https://github.com/status-im/status-react/pull/6362.patch"},"body":"Once two devices are paired, you should see your own messages in 1-to-1 chats on different devices.\r\n\r\nDepends on: #6242 \r\n\r\nIf you have a device with a previous version it will see those messages as coming from you (a chat opened with yourself will receive those messages).\r\n\r\nI don't think is a big deal as the user has control over their devices (they just have to upgrade the version), but let me know if you think otherwise.\r\n\r\nEnabled only in nightlies & when dev-mode is on, same as pairing.\r\n\r\nOnly the last commit is relevant.\r\n\r\nWe allow now the user to set an arbitrary chat-id in the message, so this needs to be properly validated.\r\nThe logic for the validation is here https://github.com/status-im/status-react/blob/62db799d60fe5a852ad6c5285658092488ad7beb/src/status_im/chat/models/message.cljs#L171 and probably needs to be looked at carefully. \r\n\r\n### Step to tests\r\n\r\n1) You need to have enabled development mode\r\n2) Go to settings -> Devices\r\n3) On android/ios click on `+`, desktop click on `pair` to advertise your device\r\n4) Any other device should see the new device with a 3-words random name + device-type under `devices`\r\n5) If you enable the device, it will send 1-to-1 & group messages to that device, make sure that devices are enabled both ways\r\n6) New group chats will also be synchronized\r\n\r\nThe UI is still rough and pending designs.\r\n\r\nIt will only sync max 4 extra devices for now, we will work on the UI to make sure the user don't enable more.\r\n\r\nEnables in nightlis in development mode\r\n\r\nstatus: ready"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/436263258","html_url":"https://github.com/status-im/status-react/pull/6362#issuecomment-436263258","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6362","id":436263258,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjI2MzI1OA==","user":{"login":"status-comment-bot","id":39547077,"node_id":"MDQ6VXNlcjM5NTQ3MDc3","avatar_url":"https://avatars0.githubusercontent.com/u/39547077?v=4","gravatar_id":"","url":"https://api.github.com/users/status-comment-bot","html_url":"https://github.com/status-comment-bot","followers_url":"https://api.github.com/users/status-comment-bot/followers","following_url":"https://api.github.com/users/status-comment-bot/following{/other_user}","gists_url":"https://api.github.com/users/status-comment-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/status-comment-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-comment-bot/subscriptions","organizations_url":"https://api.github.com/users/status-comment-bot/orgs","repos_url":"https://api.github.com/users/status-comment-bot/repos","events_url":"https://api.github.com/users/status-comment-bot/events{/privacy}","received_events_url":"https://api.github.com/users/status-comment-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T14:03:55Z","updated_at":"2018-11-06T14:03:55Z","author_association":"NONE","body":"#### :white_check_mark: CI BUILD SUCCESSFUL\nJenkins job: [#33](https://ci.status.im/job/status-react/job/pull%20requests/job/PR-6362/33/)\n##### Mobile\n* [Android](https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-181106-133919-793612-pr.apk), ([e2e](https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-181106-133919-793612-e2e.apk))\n* [iOS](https://i.diawi.com/E3zqBj)\n##### Desktop\n* [MacOS](https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-181106-133919-793612-pr.dmg)\n* [AppImage](https://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-181106-133919-793612-pr.AppImage)"}}
{"actor":{"display_login":"status-comment-bot"}}