{"action":"closed","number":36166,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/36166","id":169096958,"html_url":"https://github.com/ansible/ansible/pull/36166","diff_url":"https://github.com/ansible/ansible/pull/36166.diff","patch_url":"https://github.com/ansible/ansible/pull/36166.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/36166","number":36166,"state":"closed","locked":false,"title":"VMware: Additional check for RootSnapshot","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThis fix adds an additional check if there is no snapshot available\r\nin VM. `rootSnapshotList` is None, if no snapshot is taken.\r\n\r\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>\r\n\r\n(cherry picked from commit 52f79fa5a42ff97fd7b509a68dd83204149c5f14)\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module, plugin, module or task -->\r\nlib/ansible/modules/cloud/vmware/vmware_guest_snapshot.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nStable-2.5\r\n```","created_at":"2018-02-14T12:28:26Z","updated_at":"2018-02-14T12:38:14Z","closed_at":"2018-02-14T12:38:14Z","merged_at":"2018-02-14T12:38:14Z","merge_commit_sha":"b7f1163ab9e8c6c771f0cf31020d83bd0193c62e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":686214011,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.5","name":"affects_2.5","color":"ededed","default":false},{"id":266246971,"url":"https://api.github.com/repos/ansible/ansible/labels/backport","name":"backport","color":"00ff00","default":false},{"id":48276098,"url":"https://api.github.com/repos/ansible/ansible/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270","default":false},{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":501518759,"url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":427121291,"url":"https://api.github.com/repos/ansible/ansible/labels/vmware","name":"vmware","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/36166/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/36166/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/36166/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/fcdce3280f69500b96a26d234a5c43eee78a4a06","head":{"label":"Akasurde:snapshot_fix_25","ref":"snapshot_fix_25","sha":"fcdce3280f69500b96a26d234a5c43eee78a4a06","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"repo":{"id":87410645,"name":"ansible","full_name":"Akasurde/ansible","owner":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Akasurde/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/Akasurde/ansible","forks_url":"https://api.github.com/repos/Akasurde/ansible/forks","keys_url":"https://api.github.com/repos/Akasurde/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akasurde/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akasurde/ansible/teams","hooks_url":"https://api.github.com/repos/Akasurde/ansible/hooks","issue_events_url":"https://api.github.com/repos/Akasurde/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/Akasurde/ansible/events","assignees_url":"https://api.github.com/repos/Akasurde/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/Akasurde/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/Akasurde/ansible/tags","blobs_url":"https://api.github.com/repos/Akasurde/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akasurde/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akasurde/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akasurde/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akasurde/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/Akasurde/ansible/languages","stargazers_url":"https://api.github.com/repos/Akasurde/ansible/stargazers","contributors_url":"https://api.github.com/repos/Akasurde/ansible/contributors","subscribers_url":"https://api.github.com/repos/Akasurde/ansible/subscribers","subscription_url":"https://api.github.com/repos/Akasurde/ansible/subscription","commits_url":"https://api.github.com/repos/Akasurde/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akasurde/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akasurde/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akasurde/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akasurde/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/Akasurde/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akasurde/ansible/merges","archive_url":"https://api.github.com/repos/Akasurde/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akasurde/ansible/downloads","issues_url":"https://api.github.com/repos/Akasurde/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/Akasurde/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/Akasurde/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/Akasurde/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akasurde/ansible/labels{/name}","releases_url":"https://api.github.com/repos/Akasurde/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/Akasurde/ansible/deployments","created_at":"2017-04-06T09:20:07Z","updated_at":"2017-09-14T20:16:19Z","pushed_at":"2018-02-14T12:27:29Z","git_url":"git://github.com/Akasurde/ansible.git","ssh_url":"git@github.com:Akasurde/ansible.git","clone_url":"https://github.com/Akasurde/ansible.git","svn_url":"https://github.com/Akasurde/ansible","homepage":"http://ansible.com/","size":114254,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:stable-2.5","ref":"stable-2.5","sha":"df751cd834e46a223435148fa963d3f6905a45d7","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-02-14T11:54:05Z","pushed_at":"2018-02-14T12:38:14Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":114562,"stargazers_count":28434,"watchers_count":28434,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10259,"mirror_url":null,"archived":false,"open_issues_count":4691,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":10259,"open_issues":4691,"watchers":28434,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36166"},"html":{"href":"https://github.com/ansible/ansible/pull/36166"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/36166"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/36166/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36166/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/36166/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/fcdce3280f69500b96a26d234a5c43eee78a4a06"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gundalow","id":940557,"avatar_url":"https://avatars1.githubusercontent.com/u/940557?v=4","gravatar_id":"","url":"https://api.github.com/users/gundalow","html_url":"https://github.com/gundalow","followers_url":"https://api.github.com/users/gundalow/followers","following_url":"https://api.github.com/users/gundalow/following{/other_user}","gists_url":"https://api.github.com/users/gundalow/gists{/gist_id}","starred_url":"https://api.github.com/users/gundalow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gundalow/subscriptions","organizations_url":"https://api.github.com/users/gundalow/orgs","repos_url":"https://api.github.com/users/gundalow/repos","events_url":"https://api.github.com/users/gundalow/events{/privacy}","received_events_url":"https://api.github.com/users/gundalow/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"gundalow"}}