{"action":"created","comment":{"url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/comments/184349383","pull_request_review_id":115525548,"id":184349383,"diff_hunk":"@@ -8,11 +8,62 @@ const categoryModel = require('./category');\n const validContentSources = require('./contentSources');\n const pathType = require('./path_type');\n \n+const extendedStringValidator = joi.extend(j => ({\n+  base: j.string(),\n+  name: 'string',\n+  language: {\n+    embeddedEntities:\n+      'can only contain references to entities existing in inline array [bad reference within string: \"{{href}}\"]',\n+    embeddedEntitiesNesting: 'can only be nested within an object'\n+  },\n+  rules: [\n+    {\n+      name: 'embeddedEntities',","path":"models/article.js","position":14,"original_position":14,"commit_id":"a2c43e747a1c11accd128703a199ef773f57dc6c","original_commit_id":"4069c5e03e7a18a7a53853e2d72e09124599bdac","user":{"login":"almostagile","id":2584457,"avatar_url":"https://avatars0.githubusercontent.com/u/2584457?v=4","gravatar_id":"","url":"https://api.github.com/users/almostagile","html_url":"https://github.com/almostagile","followers_url":"https://api.github.com/users/almostagile/followers","following_url":"https://api.github.com/users/almostagile/following{/other_user}","gists_url":"https://api.github.com/users/almostagile/gists{/gist_id}","starred_url":"https://api.github.com/users/almostagile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almostagile/subscriptions","organizations_url":"https://api.github.com/users/almostagile/orgs","repos_url":"https://api.github.com/users/almostagile/repos","events_url":"https://api.github.com/users/almostagile/events{/privacy}","received_events_url":"https://api.github.com/users/almostagile/received_events","type":"User","site_admin":false},"body":"Maybe `allowInlineEmbeds` might read better","created_at":"2018-04-26T11:00:34Z","updated_at":"2018-04-26T11:01:45Z","html_url":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32#discussion_r184349383","pull_request_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/comments/184349383"},"html":{"href":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32#discussion_r184349383"},"pull_request":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32","id":184215930,"html_url":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32","diff_url":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32.diff","patch_url":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32.patch","issue_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/32","number":32,"state":"open","locked":false,"title":"now support validating bodies to ensure all references exist in inline array","user":{"login":"thekemkid","id":6907399,"avatar_url":"https://avatars3.githubusercontent.com/u/6907399?v=4","gravatar_id":"","url":"https://api.github.com/users/thekemkid","html_url":"https://github.com/thekemkid","followers_url":"https://api.github.com/users/thekemkid/followers","following_url":"https://api.github.com/users/thekemkid/following{/other_user}","gists_url":"https://api.github.com/users/thekemkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thekemkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekemkid/subscriptions","organizations_url":"https://api.github.com/users/thekemkid/orgs","repos_url":"https://api.github.com/users/thekemkid/repos","events_url":"https://api.github.com/users/thekemkid/events{/privacy}","received_events_url":"https://api.github.com/users/thekemkid/received_events","type":"User","site_admin":false},"body":"Card: https://app.clubhouse.io/condenastinternational/story/11551/flyway-service-should-error-when-updating-inline-entity-hrefs-if-entity-is-not-found-in-article-inline-array","created_at":"2018-04-26T03:18:33Z","updated_at":"2018-04-26T11:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"affa3b2ad746badefd2a1362ab550508a4570ad4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32/commits","review_comments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32/comments","review_comment_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/32/comments","statuses_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/statuses/a2c43e747a1c11accd128703a199ef773f57dc6c","head":{"label":"conde-nast-international:feature/validate-body-references","ref":"feature/validate-body-references","sha":"a2c43e747a1c11accd128703a199ef773f57dc6c","user":{"login":"conde-nast-international","id":5773286,"avatar_url":"https://avatars2.githubusercontent.com/u/5773286?v=4","gravatar_id":"","url":"https://api.github.com/users/conde-nast-international","html_url":"https://github.com/conde-nast-international","followers_url":"https://api.github.com/users/conde-nast-international/followers","following_url":"https://api.github.com/users/conde-nast-international/following{/other_user}","gists_url":"https://api.github.com/users/conde-nast-international/gists{/gist_id}","starred_url":"https://api.github.com/users/conde-nast-international/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conde-nast-international/subscriptions","organizations_url":"https://api.github.com/users/conde-nast-international/orgs","repos_url":"https://api.github.com/users/conde-nast-international/repos","events_url":"https://api.github.com/users/conde-nast-international/events{/privacy}","received_events_url":"https://api.github.com/users/conde-nast-international/received_events","type":"Organization","site_admin":false},"repo":{"id":112752146,"name":"flyway-schema-validator","full_name":"conde-nast-international/flyway-schema-validator","owner":{"login":"conde-nast-international","id":5773286,"avatar_url":"https://avatars2.githubusercontent.com/u/5773286?v=4","gravatar_id":"","url":"https://api.github.com/users/conde-nast-international","html_url":"https://github.com/conde-nast-international","followers_url":"https://api.github.com/users/conde-nast-international/followers","following_url":"https://api.github.com/users/conde-nast-international/following{/other_user}","gists_url":"https://api.github.com/users/conde-nast-international/gists{/gist_id}","starred_url":"https://api.github.com/users/conde-nast-international/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conde-nast-international/subscriptions","organizations_url":"https://api.github.com/users/conde-nast-international/orgs","repos_url":"https://api.github.com/users/conde-nast-international/repos","events_url":"https://api.github.com/users/conde-nast-international/events{/privacy}","received_events_url":"https://api.github.com/users/conde-nast-international/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conde-nast-international/flyway-schema-validator","description":null,"fork":false,"url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator","forks_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/forks","keys_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/teams","hooks_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/hooks","issue_events_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/events{/number}","events_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/events","assignees_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/assignees{/user}","branches_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/branches{/branch}","tags_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/tags","blobs_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/languages","stargazers_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/stargazers","contributors_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/contributors","subscribers_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/subscribers","subscription_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/subscription","commits_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/contents/{+path}","compare_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/merges","archive_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/downloads","issues_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues{/number}","pulls_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/labels{/name}","releases_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/releases{/id}","deployments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/deployments","created_at":"2017-12-01T14:58:15Z","updated_at":"2018-04-23T14:01:41Z","pushed_at":"2018-04-26T10:58:20Z","git_url":"git://github.com/conde-nast-international/flyway-schema-validator.git","ssh_url":"git@github.com:conde-nast-international/flyway-schema-validator.git","clone_url":"https://github.com/conde-nast-international/flyway-schema-validator.git","svn_url":"https://github.com/conde-nast-international/flyway-schema-validator","homepage":null,"size":129,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"conde-nast-international:master","ref":"master","sha":"8e60c25f27b93b997879a53c6d6c80e8461951a1","user":{"login":"conde-nast-international","id":5773286,"avatar_url":"https://avatars2.githubusercontent.com/u/5773286?v=4","gravatar_id":"","url":"https://api.github.com/users/conde-nast-international","html_url":"https://github.com/conde-nast-international","followers_url":"https://api.github.com/users/conde-nast-international/followers","following_url":"https://api.github.com/users/conde-nast-international/following{/other_user}","gists_url":"https://api.github.com/users/conde-nast-international/gists{/gist_id}","starred_url":"https://api.github.com/users/conde-nast-international/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conde-nast-international/subscriptions","organizations_url":"https://api.github.com/users/conde-nast-international/orgs","repos_url":"https://api.github.com/users/conde-nast-international/repos","events_url":"https://api.github.com/users/conde-nast-international/events{/privacy}","received_events_url":"https://api.github.com/users/conde-nast-international/received_events","type":"Organization","site_admin":false},"repo":{"id":112752146,"name":"flyway-schema-validator","full_name":"conde-nast-international/flyway-schema-validator","owner":{"login":"conde-nast-international","id":5773286,"avatar_url":"https://avatars2.githubusercontent.com/u/5773286?v=4","gravatar_id":"","url":"https://api.github.com/users/conde-nast-international","html_url":"https://github.com/conde-nast-international","followers_url":"https://api.github.com/users/conde-nast-international/followers","following_url":"https://api.github.com/users/conde-nast-international/following{/other_user}","gists_url":"https://api.github.com/users/conde-nast-international/gists{/gist_id}","starred_url":"https://api.github.com/users/conde-nast-international/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conde-nast-international/subscriptions","organizations_url":"https://api.github.com/users/conde-nast-international/orgs","repos_url":"https://api.github.com/users/conde-nast-international/repos","events_url":"https://api.github.com/users/conde-nast-international/events{/privacy}","received_events_url":"https://api.github.com/users/conde-nast-international/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conde-nast-international/flyway-schema-validator","description":null,"fork":false,"url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator","forks_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/forks","keys_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/teams","hooks_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/hooks","issue_events_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/events{/number}","events_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/events","assignees_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/assignees{/user}","branches_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/branches{/branch}","tags_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/tags","blobs_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/languages","stargazers_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/stargazers","contributors_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/contributors","subscribers_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/subscribers","subscription_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/subscription","commits_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/contents/{+path}","compare_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/merges","archive_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/downloads","issues_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues{/number}","pulls_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/labels{/name}","releases_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/releases{/id}","deployments_url":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/deployments","created_at":"2017-12-01T14:58:15Z","updated_at":"2018-04-23T14:01:41Z","pushed_at":"2018-04-26T10:58:20Z","git_url":"git://github.com/conde-nast-international/flyway-schema-validator.git","ssh_url":"git@github.com:conde-nast-international/flyway-schema-validator.git","clone_url":"https://github.com/conde-nast-international/flyway-schema-validator.git","svn_url":"https://github.com/conde-nast-international/flyway-schema-validator","homepage":null,"size":129,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32"},"html":{"href":"https://github.com/conde-nast-international/flyway-schema-validator/pull/32"},"issue":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/32"},"comments":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/conde-nast-international/flyway-schema-validator/statuses/a2c43e747a1c11accd128703a199ef773f57dc6c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"almostagile"}}