{"action":"created","comment":{"url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/comments/179543978","pull_request_review_id":109808468,"id":179543978,"diff_hunk":"@@ -38,13 +38,42 @@ object AkkaGrpcPlugin extends AutoPlugin {\n       akkaGrpcCodeGenerators := GeneratorAndSettings(ScalaServerCodeGenerator, akkaGrpcCodeGeneratorSettings.value) :: Nil,\n       akkaGrpcModelGenerators := Seq[Target]((JvmGenerator(\"scala\", ScalaPbCodeGenerator), akkaGrpcCodeGeneratorSettings.value) -> sourceManaged.value),\n \n+      PB.protoSources in Compile += target.value / \"protobuf\",\n+\n+      sourceDirectory in PB.recompile := sourceDirectory.value / \"protobuf\",\n+      resourceDirectory in PB.recompile := sourceDirectory.value / \"protobuf\",","path":"sbt-plugin/src/main/scala/akka/grpc/sbt/AkkaGrpcPlugin.scala","position":16,"original_position":16,"commit_id":"9d1611d0e55effbf6e64232023cd2cad6dbb62fb","original_commit_id":"9d1611d0e55effbf6e64232023cd2cad6dbb62fb","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"`PB.protoSources in Compile += target.value / \"protobuf\"` added here so users don't have to add it on their `build.sbt`.\r\n\r\n`sourceDirectory.value / \"protobuf\"` hardcoded (or we can switch to `proto`) to prefef convetion over config.\r\n\r\n","created_at":"2018-04-05T17:39:25Z","updated_at":"2018-04-05T17:42:22Z","html_url":"https://github.com/ignasi35/akka-grpc/pull/1#discussion_r179543978","pull_request_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/comments/179543978"},"html":{"href":"https://github.com/ignasi35/akka-grpc/pull/1#discussion_r179543978"},"pull_request":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1","id":179746913,"html_url":"https://github.com/ignasi35/akka-grpc/pull/1","diff_url":"https://github.com/ignasi35/akka-grpc/pull/1.diff","patch_url":"https://github.com/ignasi35/akka-grpc/pull/1.patch","issue_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/1","number":1,"state":"open","locked":false,"title":"Watch .proto files in protobuf folder to trigger PB.recompile","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"body":"This is highly inspired in https://github.com/lagom/sbt-lagom-descriptor-generator/blob/master/lagom-descriptor-generator-sbt-plugin/src/main/scala/com/lightbend/lagom/spec/sbt/LagomOpenApiPlugin.scala#L22-L56\r\n","created_at":"2018-04-05T17:37:16Z","updated_at":"2018-04-05T17:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7e8f06e5db68ba0aab09f1cc3fc056ba454df65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/1/comments","statuses_url":"https://api.github.com/repos/ignasi35/akka-grpc/statuses/9d1611d0e55effbf6e64232023cd2cad6dbb62fb","head":{"label":"ignasi35:148-watch-proto-sources","ref":"148-watch-proto-sources","sha":"9d1611d0e55effbf6e64232023cd2cad6dbb62fb","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"repo":{"id":124920786,"name":"akka-grpc","full_name":"ignasi35/akka-grpc","owner":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignasi35/akka-grpc","description":"Akka GRPC (will be open source)","fork":false,"url":"https://api.github.com/repos/ignasi35/akka-grpc","forks_url":"https://api.github.com/repos/ignasi35/akka-grpc/forks","keys_url":"https://api.github.com/repos/ignasi35/akka-grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignasi35/akka-grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignasi35/akka-grpc/teams","hooks_url":"https://api.github.com/repos/ignasi35/akka-grpc/hooks","issue_events_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/events{/number}","events_url":"https://api.github.com/repos/ignasi35/akka-grpc/events","assignees_url":"https://api.github.com/repos/ignasi35/akka-grpc/assignees{/user}","branches_url":"https://api.github.com/repos/ignasi35/akka-grpc/branches{/branch}","tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/tags","blobs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignasi35/akka-grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ignasi35/akka-grpc/languages","stargazers_url":"https://api.github.com/repos/ignasi35/akka-grpc/stargazers","contributors_url":"https://api.github.com/repos/ignasi35/akka-grpc/contributors","subscribers_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscribers","subscription_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscription","commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignasi35/akka-grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignasi35/akka-grpc/contents/{+path}","compare_url":"https://api.github.com/repos/ignasi35/akka-grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignasi35/akka-grpc/merges","archive_url":"https://api.github.com/repos/ignasi35/akka-grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignasi35/akka-grpc/downloads","issues_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues{/number}","pulls_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ignasi35/akka-grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ignasi35/akka-grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignasi35/akka-grpc/labels{/name}","releases_url":"https://api.github.com/repos/ignasi35/akka-grpc/releases{/id}","deployments_url":"https://api.github.com/repos/ignasi35/akka-grpc/deployments","created_at":"2018-03-12T16:46:08Z","updated_at":"2018-04-05T17:36:15Z","pushed_at":"2018-04-05T17:37:16Z","git_url":"git://github.com/ignasi35/akka-grpc.git","ssh_url":"git@github.com:ignasi35/akka-grpc.git","clone_url":"https://github.com/ignasi35/akka-grpc.git","svn_url":"https://github.com/ignasi35/akka-grpc","homepage":null,"size":410,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ignasi35:master","ref":"master","sha":"8d19ba51bd282a1bb8785f35b538b7a245e65522","user":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"repo":{"id":124920786,"name":"akka-grpc","full_name":"ignasi35/akka-grpc","owner":{"login":"ignasi35","id":762126,"avatar_url":"https://avatars2.githubusercontent.com/u/762126?v=4","gravatar_id":"","url":"https://api.github.com/users/ignasi35","html_url":"https://github.com/ignasi35","followers_url":"https://api.github.com/users/ignasi35/followers","following_url":"https://api.github.com/users/ignasi35/following{/other_user}","gists_url":"https://api.github.com/users/ignasi35/gists{/gist_id}","starred_url":"https://api.github.com/users/ignasi35/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignasi35/subscriptions","organizations_url":"https://api.github.com/users/ignasi35/orgs","repos_url":"https://api.github.com/users/ignasi35/repos","events_url":"https://api.github.com/users/ignasi35/events{/privacy}","received_events_url":"https://api.github.com/users/ignasi35/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignasi35/akka-grpc","description":"Akka GRPC (will be open source)","fork":false,"url":"https://api.github.com/repos/ignasi35/akka-grpc","forks_url":"https://api.github.com/repos/ignasi35/akka-grpc/forks","keys_url":"https://api.github.com/repos/ignasi35/akka-grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignasi35/akka-grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignasi35/akka-grpc/teams","hooks_url":"https://api.github.com/repos/ignasi35/akka-grpc/hooks","issue_events_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/events{/number}","events_url":"https://api.github.com/repos/ignasi35/akka-grpc/events","assignees_url":"https://api.github.com/repos/ignasi35/akka-grpc/assignees{/user}","branches_url":"https://api.github.com/repos/ignasi35/akka-grpc/branches{/branch}","tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/tags","blobs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignasi35/akka-grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ignasi35/akka-grpc/languages","stargazers_url":"https://api.github.com/repos/ignasi35/akka-grpc/stargazers","contributors_url":"https://api.github.com/repos/ignasi35/akka-grpc/contributors","subscribers_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscribers","subscription_url":"https://api.github.com/repos/ignasi35/akka-grpc/subscription","commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignasi35/akka-grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignasi35/akka-grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignasi35/akka-grpc/contents/{+path}","compare_url":"https://api.github.com/repos/ignasi35/akka-grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignasi35/akka-grpc/merges","archive_url":"https://api.github.com/repos/ignasi35/akka-grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignasi35/akka-grpc/downloads","issues_url":"https://api.github.com/repos/ignasi35/akka-grpc/issues{/number}","pulls_url":"https://api.github.com/repos/ignasi35/akka-grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ignasi35/akka-grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ignasi35/akka-grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignasi35/akka-grpc/labels{/name}","releases_url":"https://api.github.com/repos/ignasi35/akka-grpc/releases{/id}","deployments_url":"https://api.github.com/repos/ignasi35/akka-grpc/deployments","created_at":"2018-03-12T16:46:08Z","updated_at":"2018-04-05T17:36:15Z","pushed_at":"2018-04-05T17:37:16Z","git_url":"git://github.com/ignasi35/akka-grpc.git","ssh_url":"git@github.com:ignasi35/akka-grpc.git","clone_url":"https://github.com/ignasi35/akka-grpc.git","svn_url":"https://github.com/ignasi35/akka-grpc","homepage":null,"size":410,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1"},"html":{"href":"https://github.com/ignasi35/akka-grpc/pull/1"},"issue":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/issues/1"},"comments":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ignasi35/akka-grpc/statuses/9d1611d0e55effbf6e64232023cd2cad6dbb62fb"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ignasi35"}}