{"action":"created","comment":{"url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/comments/241495260","pull_request_review_id":184783025,"id":241495260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ5NTI2MA==","diff_hunk":"@@ -0,0 +1,81 @@\n+function rotatePoint(point, angle) {\n+    var x = point.x * Math.cos(angle) + point.y * Math.sin(angle);\n+    var y = -point.x * Math.sin(angle) + point.y * Math.cos(angle);\n+    return {x: x, y: y};\n+}\n+\n+function getXYAngle(p0, p1) {\n+    var dx = p1.x - p0.x;\n+    var dy = p1.y - p0.y;\n+    var angle;\n+    if (dx == 0) {\n+        if (dy < 0) {\n+            angle = -Math.PI / 2;\n+        } else {\n+            angle = Math.PI / 2;\n+        }\n+    } else {\n+        angle = Math.atan(dy / dx);\n+    }\n+    if (dx < 0) {\n+        angle = angle + Math.PI;\n+    }\n+    if (angle < 0) {\n+        angle = angle + 2 * Math.PI;\n+    }\n+    return angle;\n+}\n+\n+function getAngleBetween(angle1, angle2) {\n+    var angle = (angle2 - angle1) / 2;\n+    if (angle < 0)\n+        angle = angle + Math.PI;\n+    return angle;\n+}\n+\n+function getPointByAngle(angle, middlePt, isRight, r, a, b) {\n+    var Xtmp;\n+    if (isRight) {\n+        Xtmp = r / Math.sin(a) + r * Math.cos(angle);\n+\n+    } else {\n+        Xtmp = -r / Math.sin(a) + r * Math.cos(angle);\n+    }\n+    var Ytmp = r * Math.sin(angle);\n+    var newPt = rotatePoint({x: Xtmp, y: Ytmp}, -a - b);\n+    return {x: newPt.x + middlePt.x, y: newPt.y + middlePt.y};\n+}\n+\n+function getRotationPoints(startPt, middlePt, endPt, r, step) {\n+    var pi = Math.PI;\n+    step /= 180 / pi;\n+    var b = getXYAngle(middlePt, startPt);\n+    var c = getXYAngle(middlePt, endPt);\n+    var a = getAngleBetween(b, c);\n+    if (a === parameters.tolerance )\n+        return [middlePt];\n+    var isRight = a < pi / 2;\n+    var startAngle, endAngle;\n+    if (isRight) {\n+        endAngle = pi / 2 + a;\n+        startAngle = 3 * pi / 2 - a;\n+//        step *= -1;\n+    } else {\n+        startAngle = pi / 2 - a;\n+        endAngle = -pi / 2 + a;\n+    }\n+    var rotationPoints = [];\n+    if (isRight) {\n+        for (var angle = startAngle; angle > endAngle; angle -= step) {\n+            if (getDist(startPt,endAngle)> parameters.weightData) rotationPoints.push(getPointByAngle(angle, middlePt, isRight, r, a, b));\n+        }\n+    } else {\n+        for (var angle = startAngle; angle < endAngle; angle += step) {","path":"path_generator/fillet.js","position":73,"original_position":73,"commit_id":"5b8cca81c0183aa6991c095b8f35cb14d6806bf7","original_commit_id":"5b8cca81c0183aa6991c095b8f35cb14d6806bf7","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'angle' is already defined.","created_at":"2018-12-13T17:36:03Z","updated_at":"2018-12-13T17:36:03Z","html_url":"https://github.com/Galaxia5987/BaseBot/pull/5#discussion_r241495260","pull_request_url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/comments/241495260"},"html":{"href":"https://github.com/Galaxia5987/BaseBot/pull/5#discussion_r241495260"},"pull_request":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5","id":237710469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzEwNDY5","html_url":"https://github.com/Galaxia5987/BaseBot/pull/5","diff_url":"https://github.com/Galaxia5987/BaseBot/pull/5.diff","patch_url":"https://github.com/Galaxia5987/BaseBot/pull/5.patch","issue_url":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/5","number":5,"state":"open","locked":false,"title":"Final Pure Pursue pull request","user":{"login":"LiorBarkai58","id":42713106,"node_id":"MDQ6VXNlcjQyNzEzMTA2","avatar_url":"https://avatars3.githubusercontent.com/u/42713106?v=4","gravatar_id":"","url":"https://api.github.com/users/LiorBarkai58","html_url":"https://github.com/LiorBarkai58","followers_url":"https://api.github.com/users/LiorBarkai58/followers","following_url":"https://api.github.com/users/LiorBarkai58/following{/other_user}","gists_url":"https://api.github.com/users/LiorBarkai58/gists{/gist_id}","starred_url":"https://api.github.com/users/LiorBarkai58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiorBarkai58/subscriptions","organizations_url":"https://api.github.com/users/LiorBarkai58/orgs","repos_url":"https://api.github.com/users/LiorBarkai58/repos","events_url":"https://api.github.com/users/LiorBarkai58/events{/privacy}","received_events_url":"https://api.github.com/users/LiorBarkai58/received_events","type":"User","site_admin":false},"body":"After many many many many many, many hours of debugging we have reached the end of an era, an era of great suffering and a slight descent into madness.\r\nWe started off by fixing a few lines that could at times raise an error in the code that being the happy times of our debugging sessions hoping the code would be allright after a little to no work, boy were we were wrong. print after print, variable after variable in the smartdashboard we seemed to notice an error in the generateVelocity command. paulo figured it out and even re wrote the entire method to be better and more accurate, hoping that was the problem we tried running the code again with hope in our eyes and.....\r\nwhat can i say, was a little dissapointing but it was alright we had our heads up high with hopes of finishing it by the end of the day.\r\nAfter realizing we might also had a few mistakes in our original path class we have fixed a few of them and again, had hopes of success and yet again, they were crushed under the sweet tunes of rockafella street.\r\nwe have reached that point where it's the end of thursday, desperate for a touch of hope from the code we finally realized the root of the problem, fucking distanceLookAheaed. We were mad at the method but honestly we were more mad at ourselves, how could we miss it, such a small little fragment of code.\r\nbut, we found it.\r\nwe could hear rockafella street playing in our heads as we realized we had fixed the distanceLookAhead.\r\nWe played the rocky theme for every attempt we had at the final fixes of the code, eventually reaching the 5th attempt with 5 windows of rocky open.\r\nwe were thrilled with adrenaline rushing through our veins and the hype has reached a whole new level.\r\nour hearts started pounding and our eyes filled with hope again as we clicked play on all 5 rocky windows we knew, this was it, the try where it would finally be ready.\r\nwe clicked enable right as the encouraging song reached it's climax and so it happened.\r\nthe path we gave it was 0,0 - 0,1 - -2,2.\r\nthe robot started going forward as it should, then we waited for the second it turns to the left, and so it did, while that version was not perfect having it scribble around a little bit until it reached the end point it happened.\r\nit stopped\r\n-2.12, 2.07 on the smartdashboard\r\nwe did it\r\nalthough it wasn't perfect it only needed some tuning\r\nbut it worked\r\nit finally worked\r\neverything we've worked for is working\r\nwe knew what was coming\r\nrockafella street\r\nfull volume\r\ngood ol fortnite dances\r\nand a good time\r\nthank you for reading the story of how 3 kids from the reali school of beit biram described their nightmares haunting them for the next 30 days after reaching the point of absoloute despair from pure pursue not working, i'm sorry for giving you false hopes\r\n\r\n","created_at":"2018-12-11T14:58:58Z","updated_at":"2018-12-13T17:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b302265880822bb2e8cce902dc37792f00763a20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/5/comments","statuses_url":"https://api.github.com/repos/Galaxia5987/BaseBot/statuses/5b8cca81c0183aa6991c095b8f35cb14d6806bf7","head":{"label":"DanKatzuv:master","ref":"master","sha":"5b8cca81c0183aa6991c095b8f35cb14d6806bf7","user":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"repo":{"id":153307612,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDc2MTI=","name":"BaseBot","full_name":"DanKatzuv/BaseBot","private":false,"owner":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DanKatzuv/BaseBot","description":"Base robot code","fork":true,"url":"https://api.github.com/repos/DanKatzuv/BaseBot","forks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/forks","keys_url":"https://api.github.com/repos/DanKatzuv/BaseBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanKatzuv/BaseBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanKatzuv/BaseBot/teams","hooks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/hooks","issue_events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/events{/number}","events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/events","assignees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/assignees{/user}","branches_url":"https://api.github.com/repos/DanKatzuv/BaseBot/branches{/branch}","tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/tags","blobs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanKatzuv/BaseBot/statuses/{sha}","languages_url":"https://api.github.com/repos/DanKatzuv/BaseBot/languages","stargazers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/stargazers","contributors_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contributors","subscribers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscribers","subscription_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscription","commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contents/{+path}","compare_url":"https://api.github.com/repos/DanKatzuv/BaseBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanKatzuv/BaseBot/merges","archive_url":"https://api.github.com/repos/DanKatzuv/BaseBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanKatzuv/BaseBot/downloads","issues_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues{/number}","pulls_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls{/number}","milestones_url":"https://api.github.com/repos/DanKatzuv/BaseBot/milestones{/number}","notifications_url":"https://api.github.com/repos/DanKatzuv/BaseBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanKatzuv/BaseBot/labels{/name}","releases_url":"https://api.github.com/repos/DanKatzuv/BaseBot/releases{/id}","deployments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/deployments","created_at":"2018-10-16T15:16:44Z","updated_at":"2018-12-13T17:18:34Z","pushed_at":"2018-12-13T17:30:03Z","git_url":"git://github.com/DanKatzuv/BaseBot.git","ssh_url":"git@github.com:DanKatzuv/BaseBot.git","clone_url":"https://github.com/DanKatzuv/BaseBot.git","svn_url":"https://github.com/DanKatzuv/BaseBot","homepage":null,"size":701,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"Galaxia5987:master","ref":"master","sha":"468d9bebb4d4913a28f95f8dcb044b2aaa29bae5","user":{"login":"Galaxia5987","id":35310437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzEwNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/35310437?v=4","gravatar_id":"","url":"https://api.github.com/users/Galaxia5987","html_url":"https://github.com/Galaxia5987","followers_url":"https://api.github.com/users/Galaxia5987/followers","following_url":"https://api.github.com/users/Galaxia5987/following{/other_user}","gists_url":"https://api.github.com/users/Galaxia5987/gists{/gist_id}","starred_url":"https://api.github.com/users/Galaxia5987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galaxia5987/subscriptions","organizations_url":"https://api.github.com/users/Galaxia5987/orgs","repos_url":"https://api.github.com/users/Galaxia5987/repos","events_url":"https://api.github.com/users/Galaxia5987/events{/privacy}","received_events_url":"https://api.github.com/users/Galaxia5987/received_events","type":"Organization","site_admin":false},"repo":{"id":153302801,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDI4MDE=","name":"BaseBot","full_name":"Galaxia5987/BaseBot","private":false,"owner":{"login":"Galaxia5987","id":35310437,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzEwNDM3","avatar_url":"https://avatars3.githubusercontent.com/u/35310437?v=4","gravatar_id":"","url":"https://api.github.com/users/Galaxia5987","html_url":"https://github.com/Galaxia5987","followers_url":"https://api.github.com/users/Galaxia5987/followers","following_url":"https://api.github.com/users/Galaxia5987/following{/other_user}","gists_url":"https://api.github.com/users/Galaxia5987/gists{/gist_id}","starred_url":"https://api.github.com/users/Galaxia5987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Galaxia5987/subscriptions","organizations_url":"https://api.github.com/users/Galaxia5987/orgs","repos_url":"https://api.github.com/users/Galaxia5987/repos","events_url":"https://api.github.com/users/Galaxia5987/events{/privacy}","received_events_url":"https://api.github.com/users/Galaxia5987/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Galaxia5987/BaseBot","description":"Base robot code","fork":false,"url":"https://api.github.com/repos/Galaxia5987/BaseBot","forks_url":"https://api.github.com/repos/Galaxia5987/BaseBot/forks","keys_url":"https://api.github.com/repos/Galaxia5987/BaseBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Galaxia5987/BaseBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Galaxia5987/BaseBot/teams","hooks_url":"https://api.github.com/repos/Galaxia5987/BaseBot/hooks","issue_events_url":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/events{/number}","events_url":"https://api.github.com/repos/Galaxia5987/BaseBot/events","assignees_url":"https://api.github.com/repos/Galaxia5987/BaseBot/assignees{/user}","branches_url":"https://api.github.com/repos/Galaxia5987/BaseBot/branches{/branch}","tags_url":"https://api.github.com/repos/Galaxia5987/BaseBot/tags","blobs_url":"https://api.github.com/repos/Galaxia5987/BaseBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Galaxia5987/BaseBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Galaxia5987/BaseBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Galaxia5987/BaseBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Galaxia5987/BaseBot/statuses/{sha}","languages_url":"https://api.github.com/repos/Galaxia5987/BaseBot/languages","stargazers_url":"https://api.github.com/repos/Galaxia5987/BaseBot/stargazers","contributors_url":"https://api.github.com/repos/Galaxia5987/BaseBot/contributors","subscribers_url":"https://api.github.com/repos/Galaxia5987/BaseBot/subscribers","subscription_url":"https://api.github.com/repos/Galaxia5987/BaseBot/subscription","commits_url":"https://api.github.com/repos/Galaxia5987/BaseBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Galaxia5987/BaseBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Galaxia5987/BaseBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Galaxia5987/BaseBot/contents/{+path}","compare_url":"https://api.github.com/repos/Galaxia5987/BaseBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Galaxia5987/BaseBot/merges","archive_url":"https://api.github.com/repos/Galaxia5987/BaseBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Galaxia5987/BaseBot/downloads","issues_url":"https://api.github.com/repos/Galaxia5987/BaseBot/issues{/number}","pulls_url":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls{/number}","milestones_url":"https://api.github.com/repos/Galaxia5987/BaseBot/milestones{/number}","notifications_url":"https://api.github.com/repos/Galaxia5987/BaseBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Galaxia5987/BaseBot/labels{/name}","releases_url":"https://api.github.com/repos/Galaxia5987/BaseBot/releases{/id}","deployments_url":"https://api.github.com/repos/Galaxia5987/BaseBot/deployments","created_at":"2018-10-16T14:45:36Z","updated_at":"2018-11-23T09:14:17Z","pushed_at":"2018-12-13T17:18:30Z","git_url":"git://github.com/Galaxia5987/BaseBot.git","ssh_url":"git@github.com:Galaxia5987/BaseBot.git","clone_url":"https://github.com/Galaxia5987/BaseBot.git","svn_url":"https://github.com/Galaxia5987/BaseBot","homepage":null,"size":574,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5"},"html":{"href":"https://github.com/Galaxia5987/BaseBot/pull/5"},"issue":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/5"},"comments":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Galaxia5987/BaseBot/statuses/5b8cca81c0183aa6991c095b8f35cb14d6806bf7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}