{"action":"created","comment":{"url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/comments/192054555","pull_request_review_id":124750200,"id":192054555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjA1NDU1NQ==","diff_hunk":"@@ -18,28 +18,40 @@\n  */\n class LIDARmini {\n   private:\n-    hwlib::pin_in &RX;\n+    UARTConnection uart;\n \n   public:\n     /**\n      * @brief Constructor\n      */\n-    LIDARmini(hwlib::pin_in &RX);\n+    explicit LIDARmini();","path":"src/lidar_mini.hpp","position":20,"original_position":20,"commit_id":"3299d9cf434202e1bf911e17eb2d234155df6de8","original_commit_id":"3299d9cf434202e1bf911e17eb2d234155df6de8","user":{"login":"BIGduzy","id":2799556,"node_id":"MDQ6VXNlcjI3OTk1NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2799556?v=4","gravatar_id":"","url":"https://api.github.com/users/BIGduzy","html_url":"https://github.com/BIGduzy","followers_url":"https://api.github.com/users/BIGduzy/followers","following_url":"https://api.github.com/users/BIGduzy/following{/other_user}","gists_url":"https://api.github.com/users/BIGduzy/gists{/gist_id}","starred_url":"https://api.github.com/users/BIGduzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BIGduzy/subscriptions","organizations_url":"https://api.github.com/users/BIGduzy/orgs","repos_url":"https://api.github.com/users/BIGduzy/repos","events_url":"https://api.github.com/users/BIGduzy/events{/privacy}","received_events_url":"https://api.github.com/users/BIGduzy/received_events","type":"User","site_admin":false},"body":"Explicit is only necessary if the constructor has exactly one parameter (because the compiler then thinks it is the copy constructor in some cases).","created_at":"2018-05-31T10:25:39Z","updated_at":"2018-05-31T10:30:07Z","html_url":"https://github.com/R2D2-2018/DISTANCE/pull/6#discussion_r192054555","pull_request_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/comments/192054555"},"html":{"href":"https://github.com/R2D2-2018/DISTANCE/pull/6#discussion_r192054555"},"pull_request":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6","id":191136827,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTM2ODI3","html_url":"https://github.com/R2D2-2018/DISTANCE/pull/6","diff_url":"https://github.com/R2D2-2018/DISTANCE/pull/6.diff","patch_url":"https://github.com/R2D2-2018/DISTANCE/pull/6.patch","issue_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/6","number":6,"state":"open","locked":false,"title":"Development VS2 to Master","user":{"login":"JulianvDoorn","id":11579519,"node_id":"MDQ6VXNlcjExNTc5NTE5","avatar_url":"https://avatars2.githubusercontent.com/u/11579519?v=4","gravatar_id":"","url":"https://api.github.com/users/JulianvDoorn","html_url":"https://github.com/JulianvDoorn","followers_url":"https://api.github.com/users/JulianvDoorn/followers","following_url":"https://api.github.com/users/JulianvDoorn/following{/other_user}","gists_url":"https://api.github.com/users/JulianvDoorn/gists{/gist_id}","starred_url":"https://api.github.com/users/JulianvDoorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulianvDoorn/subscriptions","organizations_url":"https://api.github.com/users/JulianvDoorn/orgs","repos_url":"https://api.github.com/users/JulianvDoorn/repos","events_url":"https://api.github.com/users/JulianvDoorn/events{/privacy}","received_events_url":"https://api.github.com/users/JulianvDoorn/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-29T12:56:04Z","updated_at":"2018-05-31T10:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bef552c5c96370e499ae60c45848e4a24a55b97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6/commits","review_comments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6/comments","review_comment_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/6/comments","statuses_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/statuses/3299d9cf434202e1bf911e17eb2d234155df6de8","head":{"label":"R2D2-2018:development","ref":"development","sha":"3299d9cf434202e1bf911e17eb2d234155df6de8","user":{"login":"R2D2-2018","id":35864604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODY0NjA0","avatar_url":"https://avatars0.githubusercontent.com/u/35864604?v=4","gravatar_id":"","url":"https://api.github.com/users/R2D2-2018","html_url":"https://github.com/R2D2-2018","followers_url":"https://api.github.com/users/R2D2-2018/followers","following_url":"https://api.github.com/users/R2D2-2018/following{/other_user}","gists_url":"https://api.github.com/users/R2D2-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/R2D2-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R2D2-2018/subscriptions","organizations_url":"https://api.github.com/users/R2D2-2018/orgs","repos_url":"https://api.github.com/users/R2D2-2018/repos","events_url":"https://api.github.com/users/R2D2-2018/events{/privacy}","received_events_url":"https://api.github.com/users/R2D2-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":132466894,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NjY4OTQ=","name":"DISTANCE","full_name":"R2D2-2018/DISTANCE","owner":{"login":"R2D2-2018","id":35864604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODY0NjA0","avatar_url":"https://avatars0.githubusercontent.com/u/35864604?v=4","gravatar_id":"","url":"https://api.github.com/users/R2D2-2018","html_url":"https://github.com/R2D2-2018","followers_url":"https://api.github.com/users/R2D2-2018/followers","following_url":"https://api.github.com/users/R2D2-2018/following{/other_user}","gists_url":"https://api.github.com/users/R2D2-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/R2D2-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R2D2-2018/subscriptions","organizations_url":"https://api.github.com/users/R2D2-2018/orgs","repos_url":"https://api.github.com/users/R2D2-2018/repos","events_url":"https://api.github.com/users/R2D2-2018/events{/privacy}","received_events_url":"https://api.github.com/users/R2D2-2018/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/R2D2-2018/DISTANCE","description":null,"fork":false,"url":"https://api.github.com/repos/R2D2-2018/DISTANCE","forks_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/forks","keys_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/teams","hooks_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/hooks","issue_events_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/events{/number}","events_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/events","assignees_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/assignees{/user}","branches_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/branches{/branch}","tags_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/tags","blobs_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/statuses/{sha}","languages_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/languages","stargazers_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/stargazers","contributors_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/contributors","subscribers_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/subscribers","subscription_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/subscription","commits_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/contents/{+path}","compare_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/merges","archive_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/downloads","issues_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues{/number}","pulls_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls{/number}","milestones_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/milestones{/number}","notifications_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/labels{/name}","releases_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/releases{/id}","deployments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/deployments","created_at":"2018-05-07T13:46:51Z","updated_at":"2018-05-29T10:22:18Z","pushed_at":"2018-05-31T09:46:21Z","git_url":"git://github.com/R2D2-2018/DISTANCE.git","ssh_url":"git@github.com:R2D2-2018/DISTANCE.git","clone_url":"https://github.com/R2D2-2018/DISTANCE.git","svn_url":"https://github.com/R2D2-2018/DISTANCE","homepage":null,"size":134,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"R2D2-2018:master","ref":"master","sha":"bacbce053d66aeb908469a109fff17906c133f1f","user":{"login":"R2D2-2018","id":35864604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODY0NjA0","avatar_url":"https://avatars0.githubusercontent.com/u/35864604?v=4","gravatar_id":"","url":"https://api.github.com/users/R2D2-2018","html_url":"https://github.com/R2D2-2018","followers_url":"https://api.github.com/users/R2D2-2018/followers","following_url":"https://api.github.com/users/R2D2-2018/following{/other_user}","gists_url":"https://api.github.com/users/R2D2-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/R2D2-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R2D2-2018/subscriptions","organizations_url":"https://api.github.com/users/R2D2-2018/orgs","repos_url":"https://api.github.com/users/R2D2-2018/repos","events_url":"https://api.github.com/users/R2D2-2018/events{/privacy}","received_events_url":"https://api.github.com/users/R2D2-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":132466894,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0NjY4OTQ=","name":"DISTANCE","full_name":"R2D2-2018/DISTANCE","owner":{"login":"R2D2-2018","id":35864604,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODY0NjA0","avatar_url":"https://avatars0.githubusercontent.com/u/35864604?v=4","gravatar_id":"","url":"https://api.github.com/users/R2D2-2018","html_url":"https://github.com/R2D2-2018","followers_url":"https://api.github.com/users/R2D2-2018/followers","following_url":"https://api.github.com/users/R2D2-2018/following{/other_user}","gists_url":"https://api.github.com/users/R2D2-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/R2D2-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R2D2-2018/subscriptions","organizations_url":"https://api.github.com/users/R2D2-2018/orgs","repos_url":"https://api.github.com/users/R2D2-2018/repos","events_url":"https://api.github.com/users/R2D2-2018/events{/privacy}","received_events_url":"https://api.github.com/users/R2D2-2018/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/R2D2-2018/DISTANCE","description":null,"fork":false,"url":"https://api.github.com/repos/R2D2-2018/DISTANCE","forks_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/forks","keys_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/teams","hooks_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/hooks","issue_events_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/events{/number}","events_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/events","assignees_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/assignees{/user}","branches_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/branches{/branch}","tags_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/tags","blobs_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/statuses/{sha}","languages_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/languages","stargazers_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/stargazers","contributors_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/contributors","subscribers_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/subscribers","subscription_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/subscription","commits_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/contents/{+path}","compare_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/merges","archive_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/downloads","issues_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues{/number}","pulls_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls{/number}","milestones_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/milestones{/number}","notifications_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/labels{/name}","releases_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/releases{/id}","deployments_url":"https://api.github.com/repos/R2D2-2018/DISTANCE/deployments","created_at":"2018-05-07T13:46:51Z","updated_at":"2018-05-29T10:22:18Z","pushed_at":"2018-05-31T09:46:21Z","git_url":"git://github.com/R2D2-2018/DISTANCE.git","ssh_url":"git@github.com:R2D2-2018/DISTANCE.git","clone_url":"https://github.com/R2D2-2018/DISTANCE.git","svn_url":"https://github.com/R2D2-2018/DISTANCE","homepage":null,"size":134,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6"},"html":{"href":"https://github.com/R2D2-2018/DISTANCE/pull/6"},"issue":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/6"},"comments":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/R2D2-2018/DISTANCE/statuses/3299d9cf434202e1bf911e17eb2d234155df6de8"}},"author_association":"NONE"}}
{"actor":{"display_login":"BIGduzy"}}