{"action":"closed","issue":{"url":"https://api.github.com/repos/ExchangeUnion/xud/issues/176","repository_url":"https://api.github.com/repos/ExchangeUnion/xud","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/176/comments","events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/176/events","html_url":"https://github.com/ExchangeUnion/xud/issues/176","id":336381049,"node_id":"MDU6SXNzdWUzMzYzODEwNDk=","number":176,"title":"Split order ids","user":{"login":"moshababo","id":17073733,"node_id":"MDQ6VXNlcjE3MDczNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/17073733?v=4","gravatar_id":"","url":"https://api.github.com/users/moshababo","html_url":"https://github.com/moshababo","followers_url":"https://api.github.com/users/moshababo/followers","following_url":"https://api.github.com/users/moshababo/following{/other_user}","gists_url":"https://api.github.com/users/moshababo/gists{/gist_id}","starred_url":"https://api.github.com/users/moshababo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moshababo/subscriptions","organizations_url":"https://api.github.com/users/moshababo/orgs","repos_url":"https://api.github.com/users/moshababo/repos","events_url":"https://api.github.com/users/moshababo/events{/privacy}","received_events_url":"https://api.github.com/users/moshababo/received_events","type":"User","site_admin":false},"labels":[{"id":930952990,"node_id":"MDU6TGFiZWw5MzA5NTI5OTA=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":969072887,"node_id":"MDU6TGFiZWw5NjkwNzI4ODc=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/top%20priority","name":"top priority","color":"e25c1d","default":false}],"state":"closed","locked":false,"assignee":{"login":"michael1011","id":8138838,"node_id":"MDQ6VXNlcjgxMzg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8138838?v=4","gravatar_id":"","url":"https://api.github.com/users/michael1011","html_url":"https://github.com/michael1011","followers_url":"https://api.github.com/users/michael1011/followers","following_url":"https://api.github.com/users/michael1011/following{/other_user}","gists_url":"https://api.github.com/users/michael1011/gists{/gist_id}","starred_url":"https://api.github.com/users/michael1011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael1011/subscriptions","organizations_url":"https://api.github.com/users/michael1011/orgs","repos_url":"https://api.github.com/users/michael1011/repos","events_url":"https://api.github.com/users/michael1011/events{/privacy}","received_events_url":"https://api.github.com/users/michael1011/received_events","type":"User","site_admin":false},"assignees":[{"login":"michael1011","id":8138838,"node_id":"MDQ6VXNlcjgxMzg4Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8138838?v=4","gravatar_id":"","url":"https://api.github.com/users/michael1011","html_url":"https://github.com/michael1011","followers_url":"https://api.github.com/users/michael1011/followers","following_url":"https://api.github.com/users/michael1011/following{/other_user}","gists_url":"https://api.github.com/users/michael1011/gists{/gist_id}","starred_url":"https://api.github.com/users/michael1011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael1011/subscriptions","organizations_url":"https://api.github.com/users/michael1011/orgs","repos_url":"https://api.github.com/users/michael1011/repos","events_url":"https://api.github.com/users/michael1011/events{/privacy}","received_events_url":"https://api.github.com/users/michael1011/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/2","html_url":"https://github.com/ExchangeUnion/xud/milestone/2","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/2/labels","id":3401503,"node_id":"MDk6TWlsZXN0b25lMzQwMTUwMw==","number":2,"title":"1.0.0-alpha","description":"- Peer-to-Peer basic network simulation pass\r\n- Order book basic stress simulation pass\r\n- Full Integration with LND (Testnet)\r\n- Full Integration with Raiden (Testnet)\r\n- Full Swap Integration with Raiden (Testnet)","creator":{"login":"kilrau","id":19181985,"node_id":"MDQ6VXNlcjE5MTgxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/19181985?v=4","gravatar_id":"","url":"https://api.github.com/users/kilrau","html_url":"https://github.com/kilrau","followers_url":"https://api.github.com/users/kilrau/followers","following_url":"https://api.github.com/users/kilrau/following{/other_user}","gists_url":"https://api.github.com/users/kilrau/gists{/gist_id}","starred_url":"https://api.github.com/users/kilrau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilrau/subscriptions","organizations_url":"https://api.github.com/users/kilrau/orgs","repos_url":"https://api.github.com/users/kilrau/repos","events_url":"https://api.github.com/users/kilrau/events{/privacy}","received_events_url":"https://api.github.com/users/kilrau/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":14,"state":"open","created_at":"2018-06-05T09:35:43Z","updated_at":"2018-08-07T20:33:10Z","due_on":"2018-08-31T07:00:00Z","closed_at":null},"comments":6,"created_at":"2018-06-27T20:45:39Z","updated_at":"2018-08-07T20:33:10Z","closed_at":"2018-08-07T20:33:10Z","author_association":"COLLABORATOR","body":"Each order can be split, locally or remotely, so representing an order merely by its original `orderId` isn't very effective.\r\nOne approach to tackle this would be to generate a new `orderId` for each order split, and to associate them all with the original `orderId`. \r\nAnother approach would be to keep one single `orderId`, but to use the `orderId` + `quantity` tuple for every order-related action (cancellation, swap update, etc.). So for example, if I want to cancel an order, and to invalidate it over the network, i'll do so by specifying the quantity as well, so that in practice each order will be treated as a max sum of potential quantity, which can only be decreased over time. This approach seems more suitable to me, but we need to think this through together, in case I overlooked something.\r\n"}}
{"actor":{"display_login":"michael1011"}}