{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/191776679","pull_request_review_id":124415053,"id":191776679,"diff_hunk":"@@ -59,7 +59,9 @@ void cc430_cpu_init(void)\n     // changed is n x 32 x 32 x f_MCLK / f_FLL_reference. See UCS chapter in 5xx\n     // UG for optimization.\n     // 32 x 32 x 8 MHz / 32,768 Hz = 250000 = MCLK cycles for DCO to settle\n-    for (i = 0xFF; i > 0; i--); // Time for flag to set\n+\n+    // Time for flag to set","path":"boards/chronos/board_init.c","position":6,"original_position":6,"commit_id":"4beb135cca49d0f34f901b43b66334b43681cb68","original_commit_id":"4beb135cca49d0f34f901b43b66334b43681cb68","user":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"body":"and here 😄 ","created_at":"2018-05-30T13:54:58Z","updated_at":"2018-05-30T13:54:59Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/9245#discussion_r191776679","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/191776679"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9245#discussion_r191776679"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245","id":191417086,"html_url":"https://github.com/RIOT-OS/RIOT/pull/9245","diff_url":"https://github.com/RIOT-OS/RIOT/pull/9245.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/9245.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9245","number":9245,"state":"open","locked":false,"title":"codestyle: fix code style in loops","user":{"login":"jia200x","id":1260616,"avatar_url":"https://avatars3.githubusercontent.com/u/1260616?v=4","gravatar_id":"","url":"https://api.github.com/users/jia200x","html_url":"https://github.com/jia200x","followers_url":"https://api.github.com/users/jia200x/followers","following_url":"https://api.github.com/users/jia200x/following{/other_user}","gists_url":"https://api.github.com/users/jia200x/gists{/gist_id}","starred_url":"https://api.github.com/users/jia200x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jia200x/subscriptions","organizations_url":"https://api.github.com/users/jia200x/orgs","repos_url":"https://api.github.com/users/jia200x/repos","events_url":"https://api.github.com/users/jia200x/events{/privacy}","received_events_url":"https://api.github.com/users/jia200x/received_events","type":"User","site_admin":false},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\nThis PR adds curly braces to empty loops which only end with a semicolon. This is done in order to follow our [Coding Convention](https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions), and as a required step towards automatic style checking.\r\n\r\nAlso, moves inline comments to the top of the loop:\r\n```\r\nwhile(...) {} /* This is comment */\r\n```\r\nNow becomes:\r\n```\r\n/* This is comment */\r\nwhile(...) {}\r\n```\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->","created_at":"2018-05-30T11:14:46Z","updated_at":"2018-05-30T13:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d1aed4bbc7d6d57dbfe1e19c36f945a62fb3cdc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cgundogan","id":739129,"avatar_url":"https://avatars2.githubusercontent.com/u/739129?v=4","gravatar_id":"","url":"https://api.github.com/users/cgundogan","html_url":"https://github.com/cgundogan","followers_url":"https://api.github.com/users/cgundogan/followers","following_url":"https://api.github.com/users/cgundogan/following{/other_user}","gists_url":"https://api.github.com/users/cgundogan/gists{/gist_id}","starred_url":"https://api.github.com/users/cgundogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgundogan/subscriptions","organizations_url":"https://api.github.com/users/cgundogan/orgs","repos_url":"https://api.github.com/users/cgundogan/repos","events_url":"https://api.github.com/users/cgundogan/events{/privacy}","received_events_url":"https://api.github.com/users/cgundogan/received_events","type":"User","site_admin":false},{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":433669909,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/contested","name":"contested","color":"d93f0b","default":false},{"id":23399100,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/enhancement","name":"enhancement","color":"f17070","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9245/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/4beb135cca49d0f34f901b43b66334b43681cb68","head":{"label":"jia200x:pr/curly_braces","ref":"pr/curly_braces","sha":"4beb135cca49d0f34f901b43b66334b43681cb68","user":{"login":"jia200x","id":1260616,"avatar_url":"https://avatars3.githubusercontent.com/u/1260616?v=4","gravatar_id":"","url":"https://api.github.com/users/jia200x","html_url":"https://github.com/jia200x","followers_url":"https://api.github.com/users/jia200x/followers","following_url":"https://api.github.com/users/jia200x/following{/other_user}","gists_url":"https://api.github.com/users/jia200x/gists{/gist_id}","starred_url":"https://api.github.com/users/jia200x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jia200x/subscriptions","organizations_url":"https://api.github.com/users/jia200x/orgs","repos_url":"https://api.github.com/users/jia200x/repos","events_url":"https://api.github.com/users/jia200x/events{/privacy}","received_events_url":"https://api.github.com/users/jia200x/received_events","type":"User","site_admin":false},"repo":{"id":52615183,"name":"RIOT","full_name":"jia200x/RIOT","owner":{"login":"jia200x","id":1260616,"avatar_url":"https://avatars3.githubusercontent.com/u/1260616?v=4","gravatar_id":"","url":"https://api.github.com/users/jia200x","html_url":"https://github.com/jia200x","followers_url":"https://api.github.com/users/jia200x/followers","following_url":"https://api.github.com/users/jia200x/following{/other_user}","gists_url":"https://api.github.com/users/jia200x/gists{/gist_id}","starred_url":"https://api.github.com/users/jia200x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jia200x/subscriptions","organizations_url":"https://api.github.com/users/jia200x/orgs","repos_url":"https://api.github.com/users/jia200x/repos","events_url":"https://api.github.com/users/jia200x/events{/privacy}","received_events_url":"https://api.github.com/users/jia200x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jia200x/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/jia200x/RIOT","forks_url":"https://api.github.com/repos/jia200x/RIOT/forks","keys_url":"https://api.github.com/repos/jia200x/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jia200x/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jia200x/RIOT/teams","hooks_url":"https://api.github.com/repos/jia200x/RIOT/hooks","issue_events_url":"https://api.github.com/repos/jia200x/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/jia200x/RIOT/events","assignees_url":"https://api.github.com/repos/jia200x/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/jia200x/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/jia200x/RIOT/tags","blobs_url":"https://api.github.com/repos/jia200x/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jia200x/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jia200x/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/jia200x/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jia200x/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/jia200x/RIOT/languages","stargazers_url":"https://api.github.com/repos/jia200x/RIOT/stargazers","contributors_url":"https://api.github.com/repos/jia200x/RIOT/contributors","subscribers_url":"https://api.github.com/repos/jia200x/RIOT/subscribers","subscription_url":"https://api.github.com/repos/jia200x/RIOT/subscription","commits_url":"https://api.github.com/repos/jia200x/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/jia200x/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/jia200x/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/jia200x/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/jia200x/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/jia200x/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jia200x/RIOT/merges","archive_url":"https://api.github.com/repos/jia200x/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jia200x/RIOT/downloads","issues_url":"https://api.github.com/repos/jia200x/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/jia200x/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/jia200x/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/jia200x/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jia200x/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/jia200x/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/jia200x/RIOT/deployments","created_at":"2016-02-26T15:55:45Z","updated_at":"2018-05-29T08:59:12Z","pushed_at":"2018-05-30T12:15:32Z","git_url":"git://github.com/jia200x/RIOT.git","ssh_url":"git@github.com:jia200x/RIOT.git","clone_url":"https://github.com/jia200x/RIOT.git","svn_url":"https://github.com/jia200x/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":53964,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"b9a29acc92256c64805f95bb385a6c8cf11f212f","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2018-05-30T13:12:25Z","pushed_at":"2018-05-30T13:54:41Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":52978,"stargazers_count":1807,"watchers_count":1807,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1066,"mirror_url":null,"archived":false,"open_issues_count":751,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1066,"open_issues":751,"watchers":1807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/9245"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9245"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/9245/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/9245/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/4beb135cca49d0f34f901b43b66334b43681cb68"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"smlng"}}