{"action":"created","comment":{"url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments/204867030","pull_request_review_id":140025226,"id":204867030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg2NzAzMA==","diff_hunk":"@@ -0,0 +1,150 @@\n+/**\n+* @license Apache-2.0\n+*\n+* Copyright (c) 2018 The Stdlib Authors.\n+*\n+* Licensed under the Apache License, Version 2.0 (the \"License\");\n+* you may not use this file except in compliance with the License.\n+* You may obtain a copy of the License at\n+*\n+*    http://www.apache.org/licenses/LICENSE-2.0\n+*\n+* Unless required by applicable law or agreed to in writing, software\n+* distributed under the License is distributed on an \"AS IS\" BASIS,\n+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+* See the License for the specific language governing permissions and\n+* limitations under the License.\n+*/\n+\n+'use strict';\n+\n+// MODULES //\n+\n+var tape = require( 'tape' );\n+var PINF = require( '@stdlib/constants/math/float64-pinf' );\n+var NINF = require( '@stdlib/constants/math/float64-ninf' );\n+var isnan = require( '@stdlib/math/base/assert/is-nan' );\n+var isNegativeZero = require( '@stdlib/math/base/assert/is-negative-zero' );\n+var isPositiveZero = require( '@stdlib/math/base/assert/is-positive-zero' );\n+var Float64Array = require( '@stdlib/array/float64' );\n+var csig = require( './../lib' );\n+\n+\n+// TESTS //\n+\n+tape( 'main export is a function', function test( t ) {\n+\tt.ok( true, __filename );\n+\tt.strictEqual( typeof csig, 'function', 'main export is a function' );\n+\tt.end();\n+});\n+\n+tape( 'the function calculates the signum function of argument', function test( t ) {\n+\tvar expected;\n+\tvar actual;\n+\n+\tactual = csig( -4.2, 5.5 );","path":"lib/node_modules/@stdlib/math/base/complex/signum/test/test.js","position":null,"original_position":45,"commit_id":"c17c11a5b45b24dd1eb2c1d0c14a73f9c26f4622","original_commit_id":"0be0c9fe41181b0e1bfc594873edc841ea24c5c8","user":{"login":"kgryte","id":2643044,"node_id":"MDQ6VXNlcjI2NDMwNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2643044?v=4","gravatar_id":"","url":"https://api.github.com/users/kgryte","html_url":"https://github.com/kgryte","followers_url":"https://api.github.com/users/kgryte/followers","following_url":"https://api.github.com/users/kgryte/following{/other_user}","gists_url":"https://api.github.com/users/kgryte/gists{/gist_id}","starred_url":"https://api.github.com/users/kgryte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgryte/subscriptions","organizations_url":"https://api.github.com/users/kgryte/orgs","repos_url":"https://api.github.com/users/kgryte/repos","events_url":"https://api.github.com/users/kgryte/events{/privacy}","received_events_url":"https://api.github.com/users/kgryte/received_events","type":"User","site_admin":false},"body":"Yes, that is correct. You'll want to add the fixtures and tests to this PR.","created_at":"2018-07-24T18:37:07Z","updated_at":"2018-07-24T18:37:07Z","html_url":"https://github.com/stdlib-js/stdlib/pull/195#discussion_r204867030","pull_request_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments/204867030"},"html":{"href":"https://github.com/stdlib-js/stdlib/pull/195#discussion_r204867030"},"pull_request":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195"}},"in_reply_to_id":204610410},"pull_request":{"url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195","id":203365870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzY1ODcw","html_url":"https://github.com/stdlib-js/stdlib/pull/195","diff_url":"https://github.com/stdlib-js/stdlib/pull/195.diff","patch_url":"https://github.com/stdlib-js/stdlib/pull/195.patch","issue_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/195","number":195,"state":"open","locked":false,"title":"Add support for evaluating the signum function for complex numbers","user":{"login":"ShraddheyaS","id":21035336,"node_id":"MDQ6VXNlcjIxMDM1MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21035336?v=4","gravatar_id":"","url":"https://api.github.com/users/ShraddheyaS","html_url":"https://github.com/ShraddheyaS","followers_url":"https://api.github.com/users/ShraddheyaS/followers","following_url":"https://api.github.com/users/ShraddheyaS/following{/other_user}","gists_url":"https://api.github.com/users/ShraddheyaS/gists{/gist_id}","starred_url":"https://api.github.com/users/ShraddheyaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShraddheyaS/subscriptions","organizations_url":"https://api.github.com/users/ShraddheyaS/orgs","repos_url":"https://api.github.com/users/ShraddheyaS/repos","events_url":"https://api.github.com/users/ShraddheyaS/events{/privacy}","received_events_url":"https://api.github.com/users/ShraddheyaS/received_events","type":"User","site_admin":false},"body":"Resolves #103 .\r\n\r\n<!--lint disable first-heading-level-->\r\n\r\n## Checklist\r\n\r\n> Please ensure the following tasks are completed before submitting this pull request.\r\n\r\n-   [X] Read, understood, and followed the [contributing guidelines][contributing], including the relevant style guides.\r\n-   [X] Read and understand the [Code of Conduct][code-of-conduct].\r\n-   [X] Read and understood the [licensing terms][license].\r\n-   [X] Searched for existing issues and pull requests **before** submitting this pull request.\r\n-   [X] Filed an issue (or an issue already existed) **prior to** submitting this pull request.\r\n-   [X] Rebased onto latest `develop`.\r\n-   [X] Submitted against `develop` branch.\r\n\r\n## Description\r\n\r\n> What is the purpose of this pull request?\r\n\r\nThis pull request:\r\n\r\n-   Adds the support for signum function for complex numbers\r\n\r\n## Related Issues\r\n\r\n> Does this pull request have any related issues?\r\n\r\nThis pull request:\r\n\r\n-   resolves #103 \r\n\r\n## Questions\r\n\r\n> Any questions for reviewers of this pull request?\r\n\r\nNo.\r\n\r\n## Other\r\n\r\n> Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.\r\n\r\nNo.\r\n\r\n* * *\r\n\r\n@stdlib-js/reviewers\r\n\r\n<!-- <links> -->\r\n\r\n[contributing]: https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md\r\n\r\n[code-of-conduct]: https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md\r\n\r\n[license]: https://github.com/stdlib-js/stdlib/blob/develop/LICENSE\r\n\r\n<!-- </links> -->\r\n","created_at":"2018-07-23T22:54:07Z","updated_at":"2018-07-24T18:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdf96a843151cbcc7d7181abdac2fe6b5c1a2395","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":352649354,"node_id":"MDU6TGFiZWwzNTI2NDkzNTQ=","url":"https://api.github.com/repos/stdlib-js/stdlib/labels/feature","name":"feature","color":"bfd4f2","default":false},{"id":352661057,"node_id":"MDU6TGFiZWwzNTI2NjEwNTc=","url":"https://api.github.com/repos/stdlib-js/stdlib/labels/math","name":"math","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195/commits","review_comments_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195/comments","review_comment_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/195/comments","statuses_url":"https://api.github.com/repos/stdlib-js/stdlib/statuses/c17c11a5b45b24dd1eb2c1d0c14a73f9c26f4622","head":{"label":"ShraddheyaS:develop","ref":"develop","sha":"c17c11a5b45b24dd1eb2c1d0c14a73f9c26f4622","user":{"login":"ShraddheyaS","id":21035336,"node_id":"MDQ6VXNlcjIxMDM1MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21035336?v=4","gravatar_id":"","url":"https://api.github.com/users/ShraddheyaS","html_url":"https://github.com/ShraddheyaS","followers_url":"https://api.github.com/users/ShraddheyaS/followers","following_url":"https://api.github.com/users/ShraddheyaS/following{/other_user}","gists_url":"https://api.github.com/users/ShraddheyaS/gists{/gist_id}","starred_url":"https://api.github.com/users/ShraddheyaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShraddheyaS/subscriptions","organizations_url":"https://api.github.com/users/ShraddheyaS/orgs","repos_url":"https://api.github.com/users/ShraddheyaS/repos","events_url":"https://api.github.com/users/ShraddheyaS/events{/privacy}","received_events_url":"https://api.github.com/users/ShraddheyaS/received_events","type":"User","site_admin":false},"repo":{"id":141922717,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5MjI3MTc=","name":"stdlib","full_name":"ShraddheyaS/stdlib","owner":{"login":"ShraddheyaS","id":21035336,"node_id":"MDQ6VXNlcjIxMDM1MzM2","avatar_url":"https://avatars1.githubusercontent.com/u/21035336?v=4","gravatar_id":"","url":"https://api.github.com/users/ShraddheyaS","html_url":"https://github.com/ShraddheyaS","followers_url":"https://api.github.com/users/ShraddheyaS/followers","following_url":"https://api.github.com/users/ShraddheyaS/following{/other_user}","gists_url":"https://api.github.com/users/ShraddheyaS/gists{/gist_id}","starred_url":"https://api.github.com/users/ShraddheyaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShraddheyaS/subscriptions","organizations_url":"https://api.github.com/users/ShraddheyaS/orgs","repos_url":"https://api.github.com/users/ShraddheyaS/repos","events_url":"https://api.github.com/users/ShraddheyaS/events{/privacy}","received_events_url":"https://api.github.com/users/ShraddheyaS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShraddheyaS/stdlib","description":"✨ Standard library for JavaScript and Node.js. ✨","fork":true,"url":"https://api.github.com/repos/ShraddheyaS/stdlib","forks_url":"https://api.github.com/repos/ShraddheyaS/stdlib/forks","keys_url":"https://api.github.com/repos/ShraddheyaS/stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShraddheyaS/stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShraddheyaS/stdlib/teams","hooks_url":"https://api.github.com/repos/ShraddheyaS/stdlib/hooks","issue_events_url":"https://api.github.com/repos/ShraddheyaS/stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/ShraddheyaS/stdlib/events","assignees_url":"https://api.github.com/repos/ShraddheyaS/stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/ShraddheyaS/stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/ShraddheyaS/stdlib/tags","blobs_url":"https://api.github.com/repos/ShraddheyaS/stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShraddheyaS/stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShraddheyaS/stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShraddheyaS/stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShraddheyaS/stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/ShraddheyaS/stdlib/languages","stargazers_url":"https://api.github.com/repos/ShraddheyaS/stdlib/stargazers","contributors_url":"https://api.github.com/repos/ShraddheyaS/stdlib/contributors","subscribers_url":"https://api.github.com/repos/ShraddheyaS/stdlib/subscribers","subscription_url":"https://api.github.com/repos/ShraddheyaS/stdlib/subscription","commits_url":"https://api.github.com/repos/ShraddheyaS/stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShraddheyaS/stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShraddheyaS/stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShraddheyaS/stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShraddheyaS/stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/ShraddheyaS/stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShraddheyaS/stdlib/merges","archive_url":"https://api.github.com/repos/ShraddheyaS/stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShraddheyaS/stdlib/downloads","issues_url":"https://api.github.com/repos/ShraddheyaS/stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/ShraddheyaS/stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/ShraddheyaS/stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/ShraddheyaS/stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShraddheyaS/stdlib/labels{/name}","releases_url":"https://api.github.com/repos/ShraddheyaS/stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/ShraddheyaS/stdlib/deployments","created_at":"2018-07-22T19:00:03Z","updated_at":"2018-07-24T06:42:34Z","pushed_at":"2018-07-24T06:42:32Z","git_url":"git://github.com/ShraddheyaS/stdlib.git","ssh_url":"git@github.com:ShraddheyaS/stdlib.git","clone_url":"https://github.com/ShraddheyaS/stdlib.git","svn_url":"https://github.com/ShraddheyaS/stdlib","homepage":"https://stdlib.io","size":634754,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"stdlib-js:develop","ref":"develop","sha":"50df747bdba07d5c439a7e819c8f461b9019d3cf","user":{"login":"stdlib-js","id":17805691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODA1Njkx","avatar_url":"https://avatars2.githubusercontent.com/u/17805691?v=4","gravatar_id":"","url":"https://api.github.com/users/stdlib-js","html_url":"https://github.com/stdlib-js","followers_url":"https://api.github.com/users/stdlib-js/followers","following_url":"https://api.github.com/users/stdlib-js/following{/other_user}","gists_url":"https://api.github.com/users/stdlib-js/gists{/gist_id}","starred_url":"https://api.github.com/users/stdlib-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdlib-js/subscriptions","organizations_url":"https://api.github.com/users/stdlib-js/orgs","repos_url":"https://api.github.com/users/stdlib-js/repos","events_url":"https://api.github.com/users/stdlib-js/events{/privacy}","received_events_url":"https://api.github.com/users/stdlib-js/received_events","type":"Organization","site_admin":false},"repo":{"id":54614238,"node_id":"MDEwOlJlcG9zaXRvcnk1NDYxNDIzOA==","name":"stdlib","full_name":"stdlib-js/stdlib","owner":{"login":"stdlib-js","id":17805691,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODA1Njkx","avatar_url":"https://avatars2.githubusercontent.com/u/17805691?v=4","gravatar_id":"","url":"https://api.github.com/users/stdlib-js","html_url":"https://github.com/stdlib-js","followers_url":"https://api.github.com/users/stdlib-js/followers","following_url":"https://api.github.com/users/stdlib-js/following{/other_user}","gists_url":"https://api.github.com/users/stdlib-js/gists{/gist_id}","starred_url":"https://api.github.com/users/stdlib-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdlib-js/subscriptions","organizations_url":"https://api.github.com/users/stdlib-js/orgs","repos_url":"https://api.github.com/users/stdlib-js/repos","events_url":"https://api.github.com/users/stdlib-js/events{/privacy}","received_events_url":"https://api.github.com/users/stdlib-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stdlib-js/stdlib","description":"✨ Standard library for JavaScript and Node.js. ✨","fork":false,"url":"https://api.github.com/repos/stdlib-js/stdlib","forks_url":"https://api.github.com/repos/stdlib-js/stdlib/forks","keys_url":"https://api.github.com/repos/stdlib-js/stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdlib-js/stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdlib-js/stdlib/teams","hooks_url":"https://api.github.com/repos/stdlib-js/stdlib/hooks","issue_events_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/stdlib-js/stdlib/events","assignees_url":"https://api.github.com/repos/stdlib-js/stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/stdlib-js/stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/stdlib-js/stdlib/tags","blobs_url":"https://api.github.com/repos/stdlib-js/stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdlib-js/stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdlib-js/stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdlib-js/stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdlib-js/stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/stdlib-js/stdlib/languages","stargazers_url":"https://api.github.com/repos/stdlib-js/stdlib/stargazers","contributors_url":"https://api.github.com/repos/stdlib-js/stdlib/contributors","subscribers_url":"https://api.github.com/repos/stdlib-js/stdlib/subscribers","subscription_url":"https://api.github.com/repos/stdlib-js/stdlib/subscription","commits_url":"https://api.github.com/repos/stdlib-js/stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdlib-js/stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdlib-js/stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdlib-js/stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdlib-js/stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/stdlib-js/stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdlib-js/stdlib/merges","archive_url":"https://api.github.com/repos/stdlib-js/stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdlib-js/stdlib/downloads","issues_url":"https://api.github.com/repos/stdlib-js/stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/stdlib-js/stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/stdlib-js/stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/stdlib-js/stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdlib-js/stdlib/labels{/name}","releases_url":"https://api.github.com/repos/stdlib-js/stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/stdlib-js/stdlib/deployments","created_at":"2016-03-24T04:19:52Z","updated_at":"2018-07-24T18:12:40Z","pushed_at":"2018-07-24T06:42:34Z","git_url":"git://github.com/stdlib-js/stdlib.git","ssh_url":"git@github.com:stdlib-js/stdlib.git","clone_url":"https://github.com/stdlib-js/stdlib.git","svn_url":"https://github.com/stdlib-js/stdlib","homepage":"https://stdlib.io","size":634738,"stargazers_count":1373,"watchers_count":1373,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":63,"open_issues":89,"watchers":1373,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195"},"html":{"href":"https://github.com/stdlib-js/stdlib/pull/195"},"issue":{"href":"https://api.github.com/repos/stdlib-js/stdlib/issues/195"},"comments":{"href":"https://api.github.com/repos/stdlib-js/stdlib/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stdlib-js/stdlib/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/stdlib-js/stdlib/statuses/c17c11a5b45b24dd1eb2c1d0c14a73f9c26f4622"}},"author_association":"NONE"}}
{"actor":{"display_login":"kgryte"}}