{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/432","repository_url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher","labels_url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/432/labels{/name}","comments_url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/432/comments","events_url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/432/events","html_url":"https://github.com/OpenLauncherTeam/openlauncher/pull/432","id":372206542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDcyMDE3","number":432,"title":"Partial group crash.","user":{"login":"serebryakov-av","id":443680,"node_id":"MDQ6VXNlcjQ0MzY4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/443680?v=4","gravatar_id":"","url":"https://api.github.com/users/serebryakov-av","html_url":"https://github.com/serebryakov-av","followers_url":"https://api.github.com/users/serebryakov-av/followers","following_url":"https://api.github.com/users/serebryakov-av/following{/other_user}","gists_url":"https://api.github.com/users/serebryakov-av/gists{/gist_id}","starred_url":"https://api.github.com/users/serebryakov-av/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serebryakov-av/subscriptions","organizations_url":"https://api.github.com/users/serebryakov-av/orgs","repos_url":"https://api.github.com/users/serebryakov-av/repos","events_url":"https://api.github.com/users/serebryakov-av/events{/privacy}","received_events_url":"https://api.github.com/users/serebryakov-av/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-20T12:29:38Z","updated_at":"2018-10-20T12:47:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/pulls/432","html_url":"https://github.com/OpenLauncherTeam/openlauncher/pull/432","diff_url":"https://github.com/OpenLauncherTeam/openlauncher/pull/432.diff","patch_url":"https://github.com/OpenLauncherTeam/openlauncher/pull/432.patch"},"body":"I discovered launcher's Database and first tried fix [the crash](https://github.com/OpenLauncherTeam/openlauncher/issues/422#issuecomment-428627621):\r\n1. Make group with two items.\r\n2. Take first item from group and put it back again. Items order should change.\r\n3. Restart launcher.\r\n4. Now try to remove item from group with one item (second item should disappear).\r\n5. Crash!\r\n\r\nNow all is okay. I didn't fix icon disappearing but fixed the crash and now group with disappeared item looks like a group with one item that you can get out. The group will became empty, but I think it is better than a crash =)\r\n\r\np.s. I don't know why items are disappearing but I will get it know! Later, with another PR ^_^\r\n"},"comment":{"url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/comments/431577187","html_url":"https://github.com/OpenLauncherTeam/openlauncher/pull/432#issuecomment-431577187","issue_url":"https://api.github.com/repos/OpenLauncherTeam/openlauncher/issues/432","id":431577187,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTU3NzE4Nw==","user":{"login":"dkanada","id":21353219,"node_id":"MDQ6VXNlcjIxMzUzMjE5","avatar_url":"https://avatars1.githubusercontent.com/u/21353219?v=4","gravatar_id":"","url":"https://api.github.com/users/dkanada","html_url":"https://github.com/dkanada","followers_url":"https://api.github.com/users/dkanada/followers","following_url":"https://api.github.com/users/dkanada/following{/other_user}","gists_url":"https://api.github.com/users/dkanada/gists{/gist_id}","starred_url":"https://api.github.com/users/dkanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkanada/subscriptions","organizations_url":"https://api.github.com/users/dkanada/orgs","repos_url":"https://api.github.com/users/dkanada/repos","events_url":"https://api.github.com/users/dkanada/events{/privacy}","received_events_url":"https://api.github.com/users/dkanada/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T12:47:42Z","updated_at":"2018-10-20T12:47:42Z","author_association":"MEMBER","body":"Wow that is a nasty crash, thanks for finding the problem. Most of the problems with groups would be fixed if we allowed items to be moved within a group, but that would require quite a bit of work. Most of the code for dragging items around would have to be rewritten and the the AppItemView might need to be changed to allow for custom child views. Groups would have PopupView as a child and Widgets would have the drag handles as a child view. Then we could assign ClickListeners to trigger the child views.\r\n\r\nThis would also fix the Widget drag handles randomly popping up on a launcher restart. Right now, the handles are set to show for two seconds every time a widget view is created or moved."}}
{"actor":{"display_login":"dkanada"}}