{"action":"created","issue":{"url":"https://api.github.com/repos/szeged/webrender/issues/73","repository_url":"https://api.github.com/repos/szeged/webrender","labels_url":"https://api.github.com/repos/szeged/webrender/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/szeged/webrender/issues/73/comments","events_url":"https://api.github.com/repos/szeged/webrender/issues/73/events","html_url":"https://github.com/szeged/webrender/issues/73","id":298938240,"number":73,"title":"Run WebRender with DX12","user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars2.githubusercontent.com/u/11725775?v=4","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"labels":[{"id":842667053,"url":"https://api.github.com/repos/szeged/webrender/labels/dx12","name":"dx12","color":"b27b0c","default":false},{"id":540001844,"url":"https://api.github.com/repos/szeged/webrender/labels/question","name":"question","color":"cc317c","default":true},{"id":842667152,"url":"https://api.github.com/repos/szeged/webrender/labels/windows","name":"windows","color":"6e60ea","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-21T11:43:11Z","updated_at":"2018-02-21T16:14:27Z","closed_at":null,"author_association":"NONE","body":"The following steps are required\r\n- [ ] Rebase to the current upstream WebRender, for the shader updates. (I cherry-picked them for now)\r\n- [ ] Change array return types in shaders to out parameters (I have a patch for this on my working [branch](https://github.com/zakorgy/webrender/commits/dx12)): \r\nhttps://github.com/zakorgy/webrender/commit/ee7cbf206e0dfb155c72ee3b2ef0f8b164cecdc8\r\n\r\n- [ ] D2Array is not supported in gfx-rs yet: https://github.com/gfx-rs/gfx/blob/8d0ef5ba96bb4a2ecc5671975677323f11773dc5/src/backend/dx12/src/device.rs#L609,\r\nwe fallback to D2 texture for now: https://github.com/zakorgy/webrender/commit/c494908717c6c7d5086ae42832ac11e2a6d7cd38\r\n\r\n- [ ] Find out why the `copy_buffer_to_image` fails on the assert here: https://github.com/gfx-rs/gfx/blob/8d0ef5ba96bb4a2ecc5671975677323f11773dc5/src/backend/dx12/src/command.rs#L1289\r\nWhen runing the `basic_hal` example the third  `copy_buffer_to_image` call fails with values: `buffer_width = 240, width = 1020` because `buffer_width` should be greater or equal than `width`. \r\nThe other strange thing is, that the previous two `copy_buffer_to_image` also generates errors with the debug layer  turned on. Here is a DebugView capture for this:\r\n```\r\n00000001\t0.00000000\t[9276] D3D12 ERROR: ID3D12CommandList::CopyTextureRegion: The region specified by D3D12_TEXTURE_COPY_LOCATION:PlacedFootprint extends past the end of the buffer it is placed on. The size required by PlacedFootprint is 536641536, as the fields of PlacedFootprint::Placement are as follows: RowPitch is 262144, Height is 2048, and Format is R32G32B32A32_FLOAT. PlacedFootprint::Offset is 0, which requires the buffer to have 536641536 bytes; but the buffer only has 67108864 bytes. [ RESOURCE_MANIPULATION ERROR #869: COPYTEXTUREREGION_INVALIDSRCPLACEMENT]\t\r\n00000002\t0.00087751\t[9276] D3D12 ERROR: ID3D12CommandList::CopyTextureRegion: The region specified by D3D12_TEXTURE_COPY_LOCATION:PlacedFootprint extends past the end of the buffer it is placed on. The size required by PlacedFootprint is 536641536, as the fields of PlacedFootprint::Placement are as follows: RowPitch is 262144, Height is 2048, and Format is R32G32B32A32_FLOAT. PlacedFootprint::Offset is 16384, which requires the buffer to have 536657920 bytes; but the buffer only has 67108864 bytes. [ RESOURCE_MANIPULATION ERROR #869: COPYTEXTUREREGION_INVALIDSRCPLACEMENT]\t\r\n00000003\t0.03093249\t[9276] D3D12 WARNING: Process is terminating. Using simple reporting. Please call ReportLiveObjects() at runtime for standard reporting. [ STATE_CREATION WARNING #0: UNKNOWN]\t\r\n```\r\n\r\nWith a newer gfx version and the above mentioned shader patches, the issues in https://github.com/szeged/webrender/issues/53 seem to be solved.\r\n\r\nNOTE: My working branch is not up to date with szeged/master at the moment, because we still have an issue(https://github.com/szeged/webrender/issues/68) on windows, which came in with https://github.com/szeged/webrender/pull/63."},"comment":{"url":"https://api.github.com/repos/szeged/webrender/issues/comments/367379672","html_url":"https://github.com/szeged/webrender/issues/73#issuecomment-367379672","issue_url":"https://api.github.com/repos/szeged/webrender/issues/73","id":367379672,"user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars2.githubusercontent.com/u/11725775?v=4","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T16:14:27Z","updated_at":"2018-02-21T16:14:27Z","author_association":"NONE","body":"> Isn't this fixed in spirv-cross now? See KhronosGroup/SPIRV-Cross#433\r\n\r\nLooks like I missed the updates there. I will update my branch according to that."}}
{"actor":{"display_login":"zakorgy"}}