{"action":"created","issue":{"url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/5","repository_url":"https://api.github.com/repos/kaisermann/svelte-preprocess","labels_url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/5/comments","events_url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/5/events","html_url":"https://github.com/kaisermann/svelte-preprocess/pull/5","id":357323060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzY2ODE5","number":5,"title":"Merge default options with provided options and provide defaults for pug","user":{"login":"jvmccarthy","id":1642221,"node_id":"MDQ6VXNlcjE2NDIyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1642221?v=4","gravatar_id":"","url":"https://api.github.com/users/jvmccarthy","html_url":"https://github.com/jvmccarthy","followers_url":"https://api.github.com/users/jvmccarthy/followers","following_url":"https://api.github.com/users/jvmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/jvmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/jvmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvmccarthy/subscriptions","organizations_url":"https://api.github.com/users/jvmccarthy/orgs","repos_url":"https://api.github.com/users/jvmccarthy/repos","events_url":"https://api.github.com/users/jvmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/jvmccarthy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-05T17:10:27Z","updated_at":"2018-09-05T20:38:33Z","closed_at":"2018-09-05T20:38:30Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kaisermann/svelte-preprocess/pulls/5","html_url":"https://github.com/kaisermann/svelte-preprocess/pull/5","diff_url":"https://github.com/kaisermann/svelte-preprocess/pull/5.diff","patch_url":"https://github.com/kaisermann/svelte-preprocess/pull/5.patch"},"body":"Thank you for your efforts with svelte-preprocess. I'm exploring svelte right now and prefer sass and pug. Your repo saved me the time and effort of writing my own hooks to preprocess. 👍 \r\n\r\nHaving include paths for sass and stylus is good, but unfortunately I was finding the default code paths passed in an empty options object (in [utils.js/runTransformer()](https://github.com/kaisermann/svelte-preprocess/blob/975b08f60ce0ef5d3c9a0ff3caa49949e967b274/src/utils.js#L97)). So, the include paths aren't added by default. This PR merges in the default options with `Object.assign()`. (We could reuse the `options` variable. I opted for a new `opts` variable for clarity but can change it.)\r\n\r\nThis PR also plumbs through sensible defaults for pug - the filename (fixes imports) and html as the default doctype (fixes boolean attributes).\r\n\r\nThanks again!"},"comment":{"url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/comments/418873302","html_url":"https://github.com/kaisermann/svelte-preprocess/pull/5#issuecomment-418873302","issue_url":"https://api.github.com/repos/kaisermann/svelte-preprocess/issues/5","id":418873302,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODg3MzMwMg==","user":{"login":"kaisermann","id":12702016,"node_id":"MDQ6VXNlcjEyNzAyMDE2","avatar_url":"https://avatars3.githubusercontent.com/u/12702016?v=4","gravatar_id":"","url":"https://api.github.com/users/kaisermann","html_url":"https://github.com/kaisermann","followers_url":"https://api.github.com/users/kaisermann/followers","following_url":"https://api.github.com/users/kaisermann/following{/other_user}","gists_url":"https://api.github.com/users/kaisermann/gists{/gist_id}","starred_url":"https://api.github.com/users/kaisermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaisermann/subscriptions","organizations_url":"https://api.github.com/users/kaisermann/orgs","repos_url":"https://api.github.com/users/kaisermann/repos","events_url":"https://api.github.com/users/kaisermann/events{/privacy}","received_events_url":"https://api.github.com/users/kaisermann/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T20:38:33Z","updated_at":"2018-09-05T20:38:33Z","author_association":"OWNER","body":"Oh, thank you! I was meaning to fix that default options issue 😁"}}
{"actor":{"display_login":"kaisermann"}}