{"action":"created","issue":{"url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/490","repository_url":"https://api.github.com/repos/ros-infrastructure/bloom","labels_url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/490/labels{/name}","comments_url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/490/comments","events_url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/490/events","html_url":"https://github.com/ros-infrastructure/bloom/pull/490","id":365133982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTQ4NzQ3","number":490,"title":"Gitlab library","user":{"login":"DLu","id":1016143,"node_id":"MDQ6VXNlcjEwMTYxNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1016143?v=4","gravatar_id":"","url":"https://api.github.com/users/DLu","html_url":"https://github.com/DLu","followers_url":"https://api.github.com/users/DLu/followers","following_url":"https://api.github.com/users/DLu/following{/other_user}","gists_url":"https://api.github.com/users/DLu/gists{/gist_id}","starred_url":"https://api.github.com/users/DLu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLu/subscriptions","organizations_url":"https://api.github.com/users/DLu/orgs","repos_url":"https://api.github.com/users/DLu/repos","events_url":"https://api.github.com/users/DLu/events{/privacy}","received_events_url":"https://api.github.com/users/DLu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-29T13:49:14Z","updated_at":"2018-12-04T19:18:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ros-infrastructure/bloom/pulls/490","html_url":"https://github.com/ros-infrastructure/bloom/pull/490","diff_url":"https://github.com/ros-infrastructure/bloom/pull/490.diff","patch_url":"https://github.com/ros-infrastructure/bloom/pull/490.patch"},"body":"This PR has not been tested in isolation, but is seemingly valid Python. \r\n\r\nThis is mostly to debate whether or not I'm allowed to use Python requests. The conversation was previously [here](https://github.com/ros-infrastructure/bloom/pull/458#issuecomment-402455261) where @nuclearsandwich said they were warming to the new dependency, but I wanted to reopen that conversation. \r\n"},"comment":{"url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/comments/444223079","html_url":"https://github.com/ros-infrastructure/bloom/pull/490#issuecomment-444223079","issue_url":"https://api.github.com/repos/ros-infrastructure/bloom/issues/490","id":444223079,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDIyMzA3OQ==","user":{"login":"nuclearsandwich","id":358882,"node_id":"MDQ6VXNlcjM1ODg4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/358882?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearsandwich","html_url":"https://github.com/nuclearsandwich","followers_url":"https://api.github.com/users/nuclearsandwich/followers","following_url":"https://api.github.com/users/nuclearsandwich/following{/other_user}","gists_url":"https://api.github.com/users/nuclearsandwich/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearsandwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearsandwich/subscriptions","organizations_url":"https://api.github.com/users/nuclearsandwich/orgs","repos_url":"https://api.github.com/users/nuclearsandwich/repos","events_url":"https://api.github.com/users/nuclearsandwich/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearsandwich/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T19:18:10Z","updated_at":"2018-12-04T19:18:10Z","author_association":"CONTRIBUTOR","body":"@DLu I know I mentioned privately that I had no reservations about this PR. And that's still largely the case, but what was the reason for removing the requests module from setup.py? I believe it will still be needed there for when bloom is installed via pip / from source."}}
{"actor":{"display_login":"nuclearsandwich"}}