{"comment":{"url":"https://api.github.com/repos/mpsuzuki/poppler/comments/28216924","html_url":"https://github.com/mpsuzuki/poppler/commit/d085e3467264963abdfe07c60173d28463cde2a2#commitcomment-28216924","id":28216924,"user":{"login":"mpsuzuki","id":2202675,"avatar_url":"https://avatars0.githubusercontent.com/u/2202675?v=4","gravatar_id":"","url":"https://api.github.com/users/mpsuzuki","html_url":"https://github.com/mpsuzuki","followers_url":"https://api.github.com/users/mpsuzuki/followers","following_url":"https://api.github.com/users/mpsuzuki/following{/other_user}","gists_url":"https://api.github.com/users/mpsuzuki/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsuzuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsuzuki/subscriptions","organizations_url":"https://api.github.com/users/mpsuzuki/orgs","repos_url":"https://api.github.com/users/mpsuzuki/repos","events_url":"https://api.github.com/users/mpsuzuki/events{/privacy}","received_events_url":"https://api.github.com/users/mpsuzuki/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"d085e3467264963abdfe07c60173d28463cde2a2","created_at":"2018-03-22T14:25:23Z","updated_at":"2018-03-22T14:25:23Z","author_association":"OWNER","body":"Dear @jeroen , @adamreichold\r\n62de909 , 40ca117 , d085e34 are my temporal fix for TOC issue. On d085e34 , all of 3 fixes are applied.\r\n\r\nMy observation of TOC issue is like this. There are 2 issues.\r\n\r\n* detail::unicode_to_ustring() twices the buffer unnecessarily. this function is a conversion from 16bit (Unicode) to 16bit (unsigned short), no need to twice the buffer. because of unneeded extension of the buffer, trailing garbage (0x00 0x00 0x00...) issue would occur.\r\n\r\n* document::info_key(key) assumes the string value taken from /Info dict is always UTF-8. But, /Info dict may have 2 kind of data types for string. one is ASCII, another is UTF-16BE (with heading BOM). Yet I'm not sure whether it is possible legacy encoding like Latin-1 or Microsoft Codepage 932 can occur, but I added a conditional to check UTF-16BE. Also, ustring::from_utf16 is added which is a conversion from 8bit to 16bit.\r\n\r\nI think there would be more smart solution, because having multiple functions for 16bit to 16bit, 8bit to 16bit functions by ourself is crazy solution. I would rework in later..."}}
{"actor":{"display_login":"mpsuzuki"}}