{"action":"created","comment":{"url":"https://api.github.com/repos/python-rope/rope/pulls/comments/208078912","pull_request_review_id":143817796,"id":208078912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODA3ODkxMg==","diff_hunk":"@@ -0,0 +1,85 @@\n+import base64\n+import hashlib\n+import hmac\n+import multiprocessing\n+try:\n+    import pickle\n+except ImportError:","path":"ropetest/doatest.py","position":7,"original_position":7,"commit_id":"ea501c6fcf89ea5677fe39924d734cff15aaa38b","original_commit_id":"ea501c6fcf89ea5677fe39924d734cff15aaa38b","user":{"login":"soupytwist","id":1455827,"node_id":"MDQ6VXNlcjE0NTU4Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1455827?v=4","gravatar_id":"","url":"https://api.github.com/users/soupytwist","html_url":"https://github.com/soupytwist","followers_url":"https://api.github.com/users/soupytwist/followers","following_url":"https://api.github.com/users/soupytwist/following{/other_user}","gists_url":"https://api.github.com/users/soupytwist/gists{/gist_id}","starred_url":"https://api.github.com/users/soupytwist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupytwist/subscriptions","organizations_url":"https://api.github.com/users/soupytwist/orgs","repos_url":"https://api.github.com/users/soupytwist/repos","events_url":"https://api.github.com/users/soupytwist/events{/privacy}","received_events_url":"https://api.github.com/users/soupytwist/received_events","type":"User","site_admin":false},"body":"Huh, I copied this from elsewhere without noticing. Yeah, that's not right!","created_at":"2018-08-07T02:03:55Z","updated_at":"2018-08-07T02:03:55Z","html_url":"https://github.com/python-rope/rope/pull/251#discussion_r208078912","pull_request_url":"https://api.github.com/repos/python-rope/rope/pulls/251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python-rope/rope/pulls/comments/208078912"},"html":{"href":"https://github.com/python-rope/rope/pull/251#discussion_r208078912"},"pull_request":{"href":"https://api.github.com/repos/python-rope/rope/pulls/251"}},"in_reply_to_id":208044223},"pull_request":{"url":"https://api.github.com/repos/python-rope/rope/pulls/251","id":206499393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDk5Mzkz","html_url":"https://github.com/python-rope/rope/pull/251","diff_url":"https://github.com/python-rope/rope/pull/251.diff","patch_url":"https://github.com/python-rope/rope/pull/251.patch","issue_url":"https://api.github.com/repos/python-rope/rope/issues/251","number":251,"state":"open","locked":false,"title":"Perform signature verification on pickled data transferred over sockets","user":{"login":"soupytwist","id":1455827,"node_id":"MDQ6VXNlcjE0NTU4Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1455827?v=4","gravatar_id":"","url":"https://api.github.com/users/soupytwist","html_url":"https://github.com/soupytwist","followers_url":"https://api.github.com/users/soupytwist/followers","following_url":"https://api.github.com/users/soupytwist/following{/other_user}","gists_url":"https://api.github.com/users/soupytwist/gists{/gist_id}","starred_url":"https://api.github.com/users/soupytwist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soupytwist/subscriptions","organizations_url":"https://api.github.com/users/soupytwist/orgs","repos_url":"https://api.github.com/users/soupytwist/repos","events_url":"https://api.github.com/users/soupytwist/events{/privacy}","received_events_url":"https://api.github.com/users/soupytwist/received_events","type":"User","site_admin":false},"body":"Before unpickling anything, ensure that it has a valid digital\r\nsignature using a randomly-generated shared key. In order for an attacker\r\nto send or tamper with data on the same socket, they must know this key\r\nto compute a valid signature.\r\n\r\nFixes #105 by requiring some authentication before unpickling.","created_at":"2018-08-06T19:52:13Z","updated_at":"2018-08-07T02:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"224602dd19f6f9c9e7d83fbaac62ac43f0d9db11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-rope/rope/pulls/251/commits","review_comments_url":"https://api.github.com/repos/python-rope/rope/pulls/251/comments","review_comment_url":"https://api.github.com/repos/python-rope/rope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-rope/rope/issues/251/comments","statuses_url":"https://api.github.com/repos/python-rope/rope/statuses/ea501c6fcf89ea5677fe39924d734cff15aaa38b","head":{"label":"python-rope:cve-2014-3539","ref":"cve-2014-3539","sha":"ea501c6fcf89ea5677fe39924d734cff15aaa38b","user":{"login":"python-rope","id":6073454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzM0NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6073454?v=4","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"repo":{"id":14823414,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMzQxNA==","name":"rope","full_name":"python-rope/rope","owner":{"login":"python-rope","id":6073454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzM0NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6073454?v=4","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-rope/rope","description":"a python refactoring library","fork":false,"url":"https://api.github.com/repos/python-rope/rope","forks_url":"https://api.github.com/repos/python-rope/rope/forks","keys_url":"https://api.github.com/repos/python-rope/rope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-rope/rope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-rope/rope/teams","hooks_url":"https://api.github.com/repos/python-rope/rope/hooks","issue_events_url":"https://api.github.com/repos/python-rope/rope/issues/events{/number}","events_url":"https://api.github.com/repos/python-rope/rope/events","assignees_url":"https://api.github.com/repos/python-rope/rope/assignees{/user}","branches_url":"https://api.github.com/repos/python-rope/rope/branches{/branch}","tags_url":"https://api.github.com/repos/python-rope/rope/tags","blobs_url":"https://api.github.com/repos/python-rope/rope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-rope/rope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-rope/rope/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-rope/rope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-rope/rope/statuses/{sha}","languages_url":"https://api.github.com/repos/python-rope/rope/languages","stargazers_url":"https://api.github.com/repos/python-rope/rope/stargazers","contributors_url":"https://api.github.com/repos/python-rope/rope/contributors","subscribers_url":"https://api.github.com/repos/python-rope/rope/subscribers","subscription_url":"https://api.github.com/repos/python-rope/rope/subscription","commits_url":"https://api.github.com/repos/python-rope/rope/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-rope/rope/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-rope/rope/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-rope/rope/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-rope/rope/contents/{+path}","compare_url":"https://api.github.com/repos/python-rope/rope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-rope/rope/merges","archive_url":"https://api.github.com/repos/python-rope/rope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-rope/rope/downloads","issues_url":"https://api.github.com/repos/python-rope/rope/issues{/number}","pulls_url":"https://api.github.com/repos/python-rope/rope/pulls{/number}","milestones_url":"https://api.github.com/repos/python-rope/rope/milestones{/number}","notifications_url":"https://api.github.com/repos/python-rope/rope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-rope/rope/labels{/name}","releases_url":"https://api.github.com/repos/python-rope/rope/releases{/id}","deployments_url":"https://api.github.com/repos/python-rope/rope/deployments","created_at":"2013-11-30T15:30:20Z","updated_at":"2018-08-06T23:47:15Z","pushed_at":"2018-08-06T21:44:08Z","git_url":"git://github.com/python-rope/rope.git","ssh_url":"git@github.com:python-rope/rope.git","clone_url":"https://github.com/python-rope/rope.git","svn_url":"https://github.com/python-rope/rope","homepage":"","size":18279,"stargazers_count":570,"watchers_count":570,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":83,"open_issues":71,"watchers":570,"default_branch":"master"}},"base":{"label":"python-rope:master","ref":"master","sha":"97b94211375c3e34d1ca7af27680a429964f474a","user":{"login":"python-rope","id":6073454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzM0NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6073454?v=4","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"repo":{"id":14823414,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMzQxNA==","name":"rope","full_name":"python-rope/rope","owner":{"login":"python-rope","id":6073454,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzM0NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6073454?v=4","gravatar_id":"","url":"https://api.github.com/users/python-rope","html_url":"https://github.com/python-rope","followers_url":"https://api.github.com/users/python-rope/followers","following_url":"https://api.github.com/users/python-rope/following{/other_user}","gists_url":"https://api.github.com/users/python-rope/gists{/gist_id}","starred_url":"https://api.github.com/users/python-rope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-rope/subscriptions","organizations_url":"https://api.github.com/users/python-rope/orgs","repos_url":"https://api.github.com/users/python-rope/repos","events_url":"https://api.github.com/users/python-rope/events{/privacy}","received_events_url":"https://api.github.com/users/python-rope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-rope/rope","description":"a python refactoring library","fork":false,"url":"https://api.github.com/repos/python-rope/rope","forks_url":"https://api.github.com/repos/python-rope/rope/forks","keys_url":"https://api.github.com/repos/python-rope/rope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-rope/rope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-rope/rope/teams","hooks_url":"https://api.github.com/repos/python-rope/rope/hooks","issue_events_url":"https://api.github.com/repos/python-rope/rope/issues/events{/number}","events_url":"https://api.github.com/repos/python-rope/rope/events","assignees_url":"https://api.github.com/repos/python-rope/rope/assignees{/user}","branches_url":"https://api.github.com/repos/python-rope/rope/branches{/branch}","tags_url":"https://api.github.com/repos/python-rope/rope/tags","blobs_url":"https://api.github.com/repos/python-rope/rope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-rope/rope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-rope/rope/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-rope/rope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-rope/rope/statuses/{sha}","languages_url":"https://api.github.com/repos/python-rope/rope/languages","stargazers_url":"https://api.github.com/repos/python-rope/rope/stargazers","contributors_url":"https://api.github.com/repos/python-rope/rope/contributors","subscribers_url":"https://api.github.com/repos/python-rope/rope/subscribers","subscription_url":"https://api.github.com/repos/python-rope/rope/subscription","commits_url":"https://api.github.com/repos/python-rope/rope/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-rope/rope/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-rope/rope/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-rope/rope/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-rope/rope/contents/{+path}","compare_url":"https://api.github.com/repos/python-rope/rope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-rope/rope/merges","archive_url":"https://api.github.com/repos/python-rope/rope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-rope/rope/downloads","issues_url":"https://api.github.com/repos/python-rope/rope/issues{/number}","pulls_url":"https://api.github.com/repos/python-rope/rope/pulls{/number}","milestones_url":"https://api.github.com/repos/python-rope/rope/milestones{/number}","notifications_url":"https://api.github.com/repos/python-rope/rope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-rope/rope/labels{/name}","releases_url":"https://api.github.com/repos/python-rope/rope/releases{/id}","deployments_url":"https://api.github.com/repos/python-rope/rope/deployments","created_at":"2013-11-30T15:30:20Z","updated_at":"2018-08-06T23:47:15Z","pushed_at":"2018-08-06T21:44:08Z","git_url":"git://github.com/python-rope/rope.git","ssh_url":"git@github.com:python-rope/rope.git","clone_url":"https://github.com/python-rope/rope.git","svn_url":"https://github.com/python-rope/rope","homepage":"","size":18279,"stargazers_count":570,"watchers_count":570,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":83,"open_issues":71,"watchers":570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-rope/rope/pulls/251"},"html":{"href":"https://github.com/python-rope/rope/pull/251"},"issue":{"href":"https://api.github.com/repos/python-rope/rope/issues/251"},"comments":{"href":"https://api.github.com/repos/python-rope/rope/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/python-rope/rope/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/python-rope/rope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-rope/rope/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/python-rope/rope/statuses/ea501c6fcf89ea5677fe39924d734cff15aaa38b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"soupytwist"}}