{"action":"closed","number":3022,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/3022","id":219769020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzY5MDIw","html_url":"https://github.com/eclipse/omr/pull/3022","diff_url":"https://github.com/eclipse/omr/pull/3022.diff","patch_url":"https://github.com/eclipse/omr/pull/3022.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/3022","number":3022,"state":"closed","locked":false,"title":"Clean up GC test shutdown; don't run GC tests for disabled features","user":{"login":"rwy0717","id":2774689,"node_id":"MDQ6VXNlcjI3NzQ2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/2774689?v=4","gravatar_id":"","url":"https://api.github.com/users/rwy0717","html_url":"https://github.com/rwy0717","followers_url":"https://api.github.com/users/rwy0717/followers","following_url":"https://api.github.com/users/rwy0717/following{/other_user}","gists_url":"https://api.github.com/users/rwy0717/gists{/gist_id}","starred_url":"https://api.github.com/users/rwy0717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwy0717/subscriptions","organizations_url":"https://api.github.com/users/rwy0717/orgs","repos_url":"https://api.github.com/users/rwy0717/repos","events_url":"https://api.github.com/users/rwy0717/events{/privacy}","received_events_url":"https://api.github.com/users/rwy0717/received_events","type":"User","site_admin":false},"body":"In the GC tests, If the collector fails to initialize, then the testcase will abort before a VM thread is attached. Unfortunately, some of the GC shutdown APIs require a valid thread.  This dependency is bogus--the thread is not really needed. This PR adds some new shutdown APIs that instead take an OMR VM. With these new APIs, the tests can bring everything down safely, even when the test aborts very early.\r\n\r\nThis error condition was exposed when trying to run testing for GC features that are disabled. This is bad--obviously a scavenger test will fail when the scavenger is ifdef'd out. This PR moves the offending tests under the relevant feature ifdefs, so we only run tests when they're actually supported.\r\n\r\n/cc @youngar @charliegracie","created_at":"2018-10-02T16:34:37Z","updated_at":"2018-10-09T14:53:07Z","closed_at":"2018-10-09T14:53:07Z","merged_at":"2018-10-09T14:53:07Z","merge_commit_sha":"c5a3dc5bdc30bca99807d5db98b406ada9eff10d","assignee":{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"assignees":[{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463261367,"node_id":"MDU6TGFiZWw0NjMyNjEzNjc=","url":"https://api.github.com/repos/eclipse/omr/labels/gc","name":"gc","color":"fbca04","default":false},{"id":464798682,"node_id":"MDU6TGFiZWw0NjQ3OTg2ODI=","url":"https://api.github.com/repos/eclipse/omr/labels/test","name":"test","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/3022/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/3022/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/3022/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/84acc0400bdf073f81b2b98f92d867cc04e340a9","head":{"label":"rwy0717:fix-gctest","ref":"fix-gctest","sha":"84acc0400bdf073f81b2b98f92d867cc04e340a9","user":{"login":"rwy0717","id":2774689,"node_id":"MDQ6VXNlcjI3NzQ2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/2774689?v=4","gravatar_id":"","url":"https://api.github.com/users/rwy0717","html_url":"https://github.com/rwy0717","followers_url":"https://api.github.com/users/rwy0717/followers","following_url":"https://api.github.com/users/rwy0717/following{/other_user}","gists_url":"https://api.github.com/users/rwy0717/gists{/gist_id}","starred_url":"https://api.github.com/users/rwy0717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwy0717/subscriptions","organizations_url":"https://api.github.com/users/rwy0717/orgs","repos_url":"https://api.github.com/users/rwy0717/repos","events_url":"https://api.github.com/users/rwy0717/events{/privacy}","received_events_url":"https://api.github.com/users/rwy0717/received_events","type":"User","site_admin":false},"repo":{"id":53353883,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM1Mzg4Mw==","name":"omr","full_name":"rwy0717/omr","private":false,"owner":{"login":"rwy0717","id":2774689,"node_id":"MDQ6VXNlcjI3NzQ2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/2774689?v=4","gravatar_id":"","url":"https://api.github.com/users/rwy0717","html_url":"https://github.com/rwy0717","followers_url":"https://api.github.com/users/rwy0717/followers","following_url":"https://api.github.com/users/rwy0717/following{/other_user}","gists_url":"https://api.github.com/users/rwy0717/gists{/gist_id}","starred_url":"https://api.github.com/users/rwy0717/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwy0717/subscriptions","organizations_url":"https://api.github.com/users/rwy0717/orgs","repos_url":"https://api.github.com/users/rwy0717/repos","events_url":"https://api.github.com/users/rwy0717/events{/privacy}","received_events_url":"https://api.github.com/users/rwy0717/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rwy0717/omr","description":"OMR project","fork":true,"url":"https://api.github.com/repos/rwy0717/omr","forks_url":"https://api.github.com/repos/rwy0717/omr/forks","keys_url":"https://api.github.com/repos/rwy0717/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwy0717/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwy0717/omr/teams","hooks_url":"https://api.github.com/repos/rwy0717/omr/hooks","issue_events_url":"https://api.github.com/repos/rwy0717/omr/issues/events{/number}","events_url":"https://api.github.com/repos/rwy0717/omr/events","assignees_url":"https://api.github.com/repos/rwy0717/omr/assignees{/user}","branches_url":"https://api.github.com/repos/rwy0717/omr/branches{/branch}","tags_url":"https://api.github.com/repos/rwy0717/omr/tags","blobs_url":"https://api.github.com/repos/rwy0717/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwy0717/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwy0717/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwy0717/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwy0717/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/rwy0717/omr/languages","stargazers_url":"https://api.github.com/repos/rwy0717/omr/stargazers","contributors_url":"https://api.github.com/repos/rwy0717/omr/contributors","subscribers_url":"https://api.github.com/repos/rwy0717/omr/subscribers","subscription_url":"https://api.github.com/repos/rwy0717/omr/subscription","commits_url":"https://api.github.com/repos/rwy0717/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwy0717/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwy0717/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwy0717/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwy0717/omr/contents/{+path}","compare_url":"https://api.github.com/repos/rwy0717/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwy0717/omr/merges","archive_url":"https://api.github.com/repos/rwy0717/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwy0717/omr/downloads","issues_url":"https://api.github.com/repos/rwy0717/omr/issues{/number}","pulls_url":"https://api.github.com/repos/rwy0717/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/rwy0717/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/rwy0717/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwy0717/omr/labels{/name}","releases_url":"https://api.github.com/repos/rwy0717/omr/releases{/id}","deployments_url":"https://api.github.com/repos/rwy0717/omr/deployments","created_at":"2016-03-07T19:46:21Z","updated_at":"2018-04-17T18:47:21Z","pushed_at":"2018-10-05T23:52:58Z","git_url":"git://github.com/rwy0717/omr.git","ssh_url":"git@github.com:rwy0717/omr.git","clone_url":"https://github.com/rwy0717/omr.git","svn_url":"https://github.com/rwy0717/omr","homepage":null,"size":28589,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"70c42dcc0202f8e96edbd7d8a35a3ac6019b1ab4","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"node_id":"MDEwOlJlcG9zaXRvcnk1MzA3NzQ3OA==","name":"omr","full_name":"eclipse/omr","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-10-09T07:06:06Z","pushed_at":"2018-10-09T14:53:07Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":28038,"stargazers_count":572,"watchers_count":572,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":497,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":229,"open_issues":497,"watchers":572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3022"},"html":{"href":"https://github.com/eclipse/omr/pull/3022"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/3022"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/3022/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3022/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/3022/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/84acc0400bdf073f81b2b98f92d867cc04e340a9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"charliegracie","id":15161849,"node_id":"MDQ6VXNlcjE1MTYxODQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"comments":2,"review_comments":6,"maintainer_can_modify":false,"commits":4,"additions":52,"deletions":26,"changed_files":3}}
{"actor":{"display_login":"charliegracie"}}