{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18","id":180452554,"html_url":"https://github.com/globality-corp/microcosm-eventsource/pull/18","diff_url":"https://github.com/globality-corp/microcosm-eventsource/pull/18.diff","patch_url":"https://github.com/globality-corp/microcosm-eventsource/pull/18.patch","issue_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/18","number":18,"state":"closed","locked":false,"title":"Improve RollUpStore._filter","user":{"login":"pelegdvir","id":15822443,"avatar_url":"https://avatars3.githubusercontent.com/u/15822443?v=4","gravatar_id":"","url":"https://api.github.com/users/pelegdvir","html_url":"https://github.com/pelegdvir","followers_url":"https://api.github.com/users/pelegdvir/followers","following_url":"https://api.github.com/users/pelegdvir/following{/other_user}","gists_url":"https://api.github.com/users/pelegdvir/gists{/gist_id}","starred_url":"https://api.github.com/users/pelegdvir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelegdvir/subscriptions","organizations_url":"https://api.github.com/users/pelegdvir/orgs","repos_url":"https://api.github.com/users/pelegdvir/repos","events_url":"https://api.github.com/users/pelegdvir/events{/privacy}","received_events_url":"https://api.github.com/users/pelegdvir/received_events","type":"User","site_admin":false},"body":"1. Change `_filter` signature to `_filter(self, query, aggregate, **kwargs)` instead of `_filter(self, query, **aggregate, **kwargs)` - it will allow us to simply separate between aggregated columns and kwargs that passed by the user.\r\n2. Create `exact_count` - slower then `count` but can handle aggregated filters. Do not use by default.\r\n","created_at":"2018-04-09T23:19:28Z","updated_at":"2018-04-10T00:26:11Z","closed_at":"2018-04-10T00:26:11Z","merged_at":"2018-04-10T00:26:11Z","merge_commit_sha":"0ae711a261879a6a1b9360ab26ac49bb224338f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18/commits","review_comments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18/comments","review_comment_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/18/comments","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/statuses/2fd2c9cae25205d4b7680b2a2014d6571a9d5d6f","head":{"label":"globality-corp:feature/improve-rollup-filter","ref":"feature/improve-rollup-filter","sha":"2fd2c9cae25205d4b7680b2a2014d6571a9d5d6f","user":{"login":"globality-corp","id":11172782,"avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"repo":{"id":89189034,"name":"microcosm-eventsource","full_name":"globality-corp/microcosm-eventsource","owner":{"login":"globality-corp","id":11172782,"avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globality-corp/microcosm-eventsource","description":"Event sourced state machines","fork":false,"url":"https://api.github.com/repos/globality-corp/microcosm-eventsource","forks_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/forks","keys_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/teams","hooks_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/hooks","issue_events_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/events{/number}","events_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/events","assignees_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/assignees{/user}","branches_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/branches{/branch}","tags_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/tags","blobs_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/refs{/sha}","trees_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/statuses/{sha}","languages_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/languages","stargazers_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/stargazers","contributors_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/contributors","subscribers_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/subscribers","subscription_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/subscription","commits_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/commits{/sha}","git_commits_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/commits{/sha}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/comments{/number}","issue_comment_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/comments{/number}","contents_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/contents/{+path}","compare_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/merges","archive_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/downloads","issues_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues{/number}","pulls_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls{/number}","milestones_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/milestones{/number}","notifications_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/labels{/name}","releases_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/releases{/id}","deployments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/deployments","created_at":"2017-04-24T02:23:16Z","updated_at":"2018-02-05T10:26:26Z","pushed_at":"2018-04-10T00:26:11Z","git_url":"git://github.com/globality-corp/microcosm-eventsource.git","ssh_url":"git@github.com:globality-corp/microcosm-eventsource.git","clone_url":"https://github.com/globality-corp/microcosm-eventsource.git","svn_url":"https://github.com/globality-corp/microcosm-eventsource","homepage":null,"size":87,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"globality-corp:develop","ref":"develop","sha":"82eae9434c31c0ca1f54b4ba0531eb5fc7adfa0c","user":{"login":"globality-corp","id":11172782,"avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"repo":{"id":89189034,"name":"microcosm-eventsource","full_name":"globality-corp/microcosm-eventsource","owner":{"login":"globality-corp","id":11172782,"avatar_url":"https://avatars2.githubusercontent.com/u/11172782?v=4","gravatar_id":"","url":"https://api.github.com/users/globality-corp","html_url":"https://github.com/globality-corp","followers_url":"https://api.github.com/users/globality-corp/followers","following_url":"https://api.github.com/users/globality-corp/following{/other_user}","gists_url":"https://api.github.com/users/globality-corp/gists{/gist_id}","starred_url":"https://api.github.com/users/globality-corp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globality-corp/subscriptions","organizations_url":"https://api.github.com/users/globality-corp/orgs","repos_url":"https://api.github.com/users/globality-corp/repos","events_url":"https://api.github.com/users/globality-corp/events{/privacy}","received_events_url":"https://api.github.com/users/globality-corp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/globality-corp/microcosm-eventsource","description":"Event sourced state machines","fork":false,"url":"https://api.github.com/repos/globality-corp/microcosm-eventsource","forks_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/forks","keys_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/teams","hooks_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/hooks","issue_events_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/events{/number}","events_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/events","assignees_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/assignees{/user}","branches_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/branches{/branch}","tags_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/tags","blobs_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/refs{/sha}","trees_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/statuses/{sha}","languages_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/languages","stargazers_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/stargazers","contributors_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/contributors","subscribers_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/subscribers","subscription_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/subscription","commits_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/commits{/sha}","git_commits_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/git/commits{/sha}","comments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/comments{/number}","issue_comment_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/comments{/number}","contents_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/contents/{+path}","compare_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/merges","archive_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/downloads","issues_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues{/number}","pulls_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls{/number}","milestones_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/milestones{/number}","notifications_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/labels{/name}","releases_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/releases{/id}","deployments_url":"https://api.github.com/repos/globality-corp/microcosm-eventsource/deployments","created_at":"2017-04-24T02:23:16Z","updated_at":"2018-02-05T10:26:26Z","pushed_at":"2018-04-10T00:26:11Z","git_url":"git://github.com/globality-corp/microcosm-eventsource.git","ssh_url":"git@github.com:globality-corp/microcosm-eventsource.git","clone_url":"https://github.com/globality-corp/microcosm-eventsource.git","svn_url":"https://github.com/globality-corp/microcosm-eventsource","homepage":null,"size":87,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18"},"html":{"href":"https://github.com/globality-corp/microcosm-eventsource/pull/18"},"issue":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/18"},"comments":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/globality-corp/microcosm-eventsource/statuses/2fd2c9cae25205d4b7680b2a2014d6571a9d5d6f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pelegdvir","id":15822443,"avatar_url":"https://avatars3.githubusercontent.com/u/15822443?v=4","gravatar_id":"","url":"https://api.github.com/users/pelegdvir","html_url":"https://github.com/pelegdvir","followers_url":"https://api.github.com/users/pelegdvir/followers","following_url":"https://api.github.com/users/pelegdvir/following{/other_user}","gists_url":"https://api.github.com/users/pelegdvir/gists{/gist_id}","starred_url":"https://api.github.com/users/pelegdvir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelegdvir/subscriptions","organizations_url":"https://api.github.com/users/pelegdvir/orgs","repos_url":"https://api.github.com/users/pelegdvir/repos","events_url":"https://api.github.com/users/pelegdvir/events{/privacy}","received_events_url":"https://api.github.com/users/pelegdvir/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":58,"deletions":15,"changed_files":2}}
{"actor":{"display_login":"pelegdvir"}}