{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/238365684","pull_request_review_id":180889360,"id":238365684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODM2NTY4NA==","diff_hunk":"@@ -225,3 +238,119 @@ def post(self, request, *args, **kwargs):\n                 except ResourceMissing:\n                     messages.add_message(request, messages.ERROR, 'Resource not found')\n         return self.get(request, *args, **kwargs)\n+\n+\n+@location_safe\n+@method_decorator([toggles.APP_TRANSLATIONS_WITH_TRANSIFEX.required_decorator()], name='dispatch')\n+class AppTranslations(BaseTranslationsView):\n+    page_title = ugettext_lazy('App Translations')\n+    urlname = 'app_translations'\n+    template_name = 'app_translations.html'\n+    section_name = ugettext_lazy(\"Translations\")\n+\n+    @use_select2_v4","path":"corehq/apps/translations/views.py","position":null,"original_position":52,"commit_id":"17568722ea41ac2a5a00415cd79dc74c0ea27917","original_commit_id":"798060519fdcd4fb03e4e256994a06d648208031","user":{"login":"mkangia","id":3864163,"node_id":"MDQ6VXNlcjM4NjQxNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3864163?v=4","gravatar_id":"","url":"https://api.github.com/users/mkangia","html_url":"https://github.com/mkangia","followers_url":"https://api.github.com/users/mkangia/followers","following_url":"https://api.github.com/users/mkangia/following{/other_user}","gists_url":"https://api.github.com/users/mkangia/gists{/gist_id}","starred_url":"https://api.github.com/users/mkangia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkangia/subscriptions","organizations_url":"https://api.github.com/users/mkangia/orgs","repos_url":"https://api.github.com/users/mkangia/repos","events_url":"https://api.github.com/users/mkangia/events{/privacy}","received_events_url":"https://api.github.com/users/mkangia/received_events","type":"User","site_admin":false},"body":"okay, thanks @orangejenny ","created_at":"2018-12-03T17:34:29Z","updated_at":"2018-12-03T17:34:30Z","html_url":"https://github.com/dimagi/commcare-hq/pull/22516#discussion_r238365684","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/238365684"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/22516#discussion_r238365684"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516"}},"in_reply_to_id":237849379},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516","id":233386342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzg2MzQy","html_url":"https://github.com/dimagi/commcare-hq/pull/22516","diff_url":"https://github.com/dimagi/commcare-hq/pull/22516.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/22516.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/22516","number":22516,"state":"closed","locked":false,"title":"Populate translation app","user":{"login":"mkangia","id":3864163,"node_id":"MDQ6VXNlcjM4NjQxNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3864163?v=4","gravatar_id":"","url":"https://api.github.com/users/mkangia","html_url":"https://github.com/mkangia","followers_url":"https://api.github.com/users/mkangia/followers","following_url":"https://api.github.com/users/mkangia/following{/other_user}","gists_url":"https://api.github.com/users/mkangia/gists{/gist_id}","starred_url":"https://api.github.com/users/mkangia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkangia/subscriptions","organizations_url":"https://api.github.com/users/mkangia/orgs","repos_url":"https://api.github.com/users/mkangia/repos","events_url":"https://api.github.com/users/mkangia/events{/privacy}","received_events_url":"https://api.github.com/users/mkangia/received_events","type":"User","site_admin":false},"body":"I added translations app during transifex integration. Could not do it then but wanted to move things related to translations out of app_manager and also icds custom app.\r\nEach point below is almost a separate commit and there is no functionality change. Just moving code.\r\n\r\nbest review by commit\r\n\r\n- move transifex related code out of icds code\r\n- move transifex related code out of app manager\r\n- move app translations out of app manager\r\n- move commcare ui translations out of app manager\r\n\r\nhappy to move any more things if that can be added here.\r\n\r\nNext step would be to improve some of this code. For first would be to work on this file https://github.com/dimagi/commcare-hq/blob/mk-populate-translation-app/corehq/apps/translations/app_translations.py\r\n\r\nFor testing that i didn't break anything, i\r\n1. check the transifex integration views\r\n2. app bulk app and ui translations on application to be working\r\n3. tests\r\n4. deploying on staging","created_at":"2018-11-25T16:43:06Z","updated_at":"2018-12-03T17:34:30Z","closed_at":"2018-12-03T12:37:17Z","merged_at":"2018-12-03T12:37:17Z","merge_commit_sha":"1be69549df6d579345fc6f84f43b6ef177ec50d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"esoergel","id":2367539,"node_id":"MDQ6VXNlcjIzNjc1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2367539?v=4","gravatar_id":"","url":"https://api.github.com/users/esoergel","html_url":"https://github.com/esoergel","followers_url":"https://api.github.com/users/esoergel/followers","following_url":"https://api.github.com/users/esoergel/following{/other_user}","gists_url":"https://api.github.com/users/esoergel/gists{/gist_id}","starred_url":"https://api.github.com/users/esoergel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esoergel/subscriptions","organizations_url":"https://api.github.com/users/esoergel/orgs","repos_url":"https://api.github.com/users/esoergel/repos","events_url":"https://api.github.com/users/esoergel/events{/privacy}","received_events_url":"https://api.github.com/users/esoergel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":724787015,"node_id":"MDU6TGFiZWw3MjQ3ODcwMTU=","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/product/invisible","name":"product/invisible","color":"cfd2d6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/22516/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/17568722ea41ac2a5a00415cd79dc74c0ea27917","head":{"label":"dimagi:mk-populate-translation-app","ref":"mk-populate-translation-app","sha":"17568722ea41ac2a5a00415cd79dc74c0ea27917","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2018-12-03T17:32:52Z","pushed_at":"2018-12-03T17:34:10Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":474015,"stargazers_count":317,"watchers_count":317,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":122,"open_issues":72,"watchers":317,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"7ac77a92f83de2b58466d48720ac32b04bf803a0","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2018-12-03T17:32:52Z","pushed_at":"2018-12-03T17:34:10Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":474015,"stargazers_count":317,"watchers_count":317,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":122,"open_issues":72,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/22516"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/22516"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/22516/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/22516/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/17568722ea41ac2a5a00415cd79dc74c0ea27917"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mkangia"}}