{"action":"created","comment":{"url":"https://api.github.com/repos/davidkpiano/xstate/pulls/comments/208148156","pull_request_review_id":143898387,"id":208148156,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE0ODE1Ng==","diff_hunk":"@@ -44,5 +44,7 @@\n     \"webpack\": \"^3.5.6\",\n     \"xml-js\": \"^1.6.2\"\n   },\n-  \"dependencies\": {}\n+  \"dependencies\": {\n+    \"tslib\": \"^1.9.2\"","path":"package.json","position":6,"original_position":6,"commit_id":"66b9332c98f0e862883639f91251a6a1a48ff8c3","original_commit_id":"0ddada0b1970055fa600b68e49df13f5843cc241","user":{"login":"mogsie","id":404666,"node_id":"MDQ6VXNlcjQwNDY2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/404666?v=4","gravatar_id":"","url":"https://api.github.com/users/mogsie","html_url":"https://github.com/mogsie","followers_url":"https://api.github.com/users/mogsie/followers","following_url":"https://api.github.com/users/mogsie/following{/other_user}","gists_url":"https://api.github.com/users/mogsie/gists{/gist_id}","starred_url":"https://api.github.com/users/mogsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogsie/subscriptions","organizations_url":"https://api.github.com/users/mogsie/orgs","repos_url":"https://api.github.com/users/mogsie/repos","events_url":"https://api.github.com/users/mogsie/events{/privacy}","received_events_url":"https://api.github.com/users/mogsie/received_events","type":"User","site_admin":false},"body":"Would it be possible to add this at build time instead?  Perhaps xstate could be persuaded to build two artifacts, one with this dependency and one without?  Different npm package names, but from the same source?  That way, the code base is clean, but bundlers have an option that helps bundlers do their deduping.","created_at":"2018-08-07T08:51:38Z","updated_at":"2018-08-07T08:51:38Z","html_url":"https://github.com/davidkpiano/xstate/pull/127#discussion_r208148156","pull_request_url":"https://api.github.com/repos/davidkpiano/xstate/pulls/127","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/comments/208148156"},"html":{"href":"https://github.com/davidkpiano/xstate/pull/127#discussion_r208148156"},"pull_request":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/127"}},"in_reply_to_id":192933202},"pull_request":{"url":"https://api.github.com/repos/davidkpiano/xstate/pulls/127","id":192501503,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTAxNTAz","html_url":"https://github.com/davidkpiano/xstate/pull/127","diff_url":"https://github.com/davidkpiano/xstate/pull/127.diff","patch_url":"https://github.com/davidkpiano/xstate/pull/127.patch","issue_url":"https://api.github.com/repos/davidkpiano/xstate/issues/127","number":127,"state":"open","locked":false,"title":"Use import helpers from tslib package","user":{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"body":"This should allow bundlers to dedupe typescript helpers across packages using `tslib`.","created_at":"2018-06-04T19:14:12Z","updated_at":"2018-08-07T08:51:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d61e578dab5caa8e4f8c51eab3a7f6af5af6e4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/davidkpiano/xstate/pulls/127/commits","review_comments_url":"https://api.github.com/repos/davidkpiano/xstate/pulls/127/comments","review_comment_url":"https://api.github.com/repos/davidkpiano/xstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidkpiano/xstate/issues/127/comments","statuses_url":"https://api.github.com/repos/davidkpiano/xstate/statuses/66b9332c98f0e862883639f91251a6a1a48ff8c3","head":{"label":"Andarist:use-tslib","ref":"use-tslib","sha":"66b9332c98f0e862883639f91251a6a1a48ff8c3","user":{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"repo":{"id":131270473,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyNzA0NzM=","name":"xstate","full_name":"Andarist/xstate","owner":{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andarist/xstate","description":"Functional, Stateless JS Finite State Machines and Statecharts","fork":true,"url":"https://api.github.com/repos/Andarist/xstate","forks_url":"https://api.github.com/repos/Andarist/xstate/forks","keys_url":"https://api.github.com/repos/Andarist/xstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andarist/xstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andarist/xstate/teams","hooks_url":"https://api.github.com/repos/Andarist/xstate/hooks","issue_events_url":"https://api.github.com/repos/Andarist/xstate/issues/events{/number}","events_url":"https://api.github.com/repos/Andarist/xstate/events","assignees_url":"https://api.github.com/repos/Andarist/xstate/assignees{/user}","branches_url":"https://api.github.com/repos/Andarist/xstate/branches{/branch}","tags_url":"https://api.github.com/repos/Andarist/xstate/tags","blobs_url":"https://api.github.com/repos/Andarist/xstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andarist/xstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andarist/xstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andarist/xstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andarist/xstate/statuses/{sha}","languages_url":"https://api.github.com/repos/Andarist/xstate/languages","stargazers_url":"https://api.github.com/repos/Andarist/xstate/stargazers","contributors_url":"https://api.github.com/repos/Andarist/xstate/contributors","subscribers_url":"https://api.github.com/repos/Andarist/xstate/subscribers","subscription_url":"https://api.github.com/repos/Andarist/xstate/subscription","commits_url":"https://api.github.com/repos/Andarist/xstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andarist/xstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andarist/xstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andarist/xstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andarist/xstate/contents/{+path}","compare_url":"https://api.github.com/repos/Andarist/xstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andarist/xstate/merges","archive_url":"https://api.github.com/repos/Andarist/xstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andarist/xstate/downloads","issues_url":"https://api.github.com/repos/Andarist/xstate/issues{/number}","pulls_url":"https://api.github.com/repos/Andarist/xstate/pulls{/number}","milestones_url":"https://api.github.com/repos/Andarist/xstate/milestones{/number}","notifications_url":"https://api.github.com/repos/Andarist/xstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andarist/xstate/labels{/name}","releases_url":"https://api.github.com/repos/Andarist/xstate/releases{/id}","deployments_url":"https://api.github.com/repos/Andarist/xstate/deployments","created_at":"2018-04-27T08:44:35Z","updated_at":"2018-04-27T08:44:37Z","pushed_at":"2018-07-03T21:12:41Z","git_url":"git://github.com/Andarist/xstate.git","ssh_url":"git@github.com:Andarist/xstate.git","clone_url":"https://github.com/Andarist/xstate.git","svn_url":"https://github.com/Andarist/xstate","homepage":"http://davidkpiano.github.io/xstate/docs","size":1194,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidkpiano:master","ref":"master","sha":"db6c731b6560a72228ab8bccbc8109b159013813","user":{"login":"davidkpiano","id":1093738,"node_id":"MDQ6VXNlcjEwOTM3Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1093738?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkpiano","html_url":"https://github.com/davidkpiano","followers_url":"https://api.github.com/users/davidkpiano/followers","following_url":"https://api.github.com/users/davidkpiano/following{/other_user}","gists_url":"https://api.github.com/users/davidkpiano/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkpiano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkpiano/subscriptions","organizations_url":"https://api.github.com/users/davidkpiano/orgs","repos_url":"https://api.github.com/users/davidkpiano/repos","events_url":"https://api.github.com/users/davidkpiano/events{/privacy}","received_events_url":"https://api.github.com/users/davidkpiano/received_events","type":"User","site_admin":false},"repo":{"id":42455934,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ1NTkzNA==","name":"xstate","full_name":"davidkpiano/xstate","owner":{"login":"davidkpiano","id":1093738,"node_id":"MDQ6VXNlcjEwOTM3Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1093738?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkpiano","html_url":"https://github.com/davidkpiano","followers_url":"https://api.github.com/users/davidkpiano/followers","following_url":"https://api.github.com/users/davidkpiano/following{/other_user}","gists_url":"https://api.github.com/users/davidkpiano/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkpiano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkpiano/subscriptions","organizations_url":"https://api.github.com/users/davidkpiano/orgs","repos_url":"https://api.github.com/users/davidkpiano/repos","events_url":"https://api.github.com/users/davidkpiano/events{/privacy}","received_events_url":"https://api.github.com/users/davidkpiano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidkpiano/xstate","description":"Functional, Stateless JS Finite State Machines and Statecharts","fork":false,"url":"https://api.github.com/repos/davidkpiano/xstate","forks_url":"https://api.github.com/repos/davidkpiano/xstate/forks","keys_url":"https://api.github.com/repos/davidkpiano/xstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidkpiano/xstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidkpiano/xstate/teams","hooks_url":"https://api.github.com/repos/davidkpiano/xstate/hooks","issue_events_url":"https://api.github.com/repos/davidkpiano/xstate/issues/events{/number}","events_url":"https://api.github.com/repos/davidkpiano/xstate/events","assignees_url":"https://api.github.com/repos/davidkpiano/xstate/assignees{/user}","branches_url":"https://api.github.com/repos/davidkpiano/xstate/branches{/branch}","tags_url":"https://api.github.com/repos/davidkpiano/xstate/tags","blobs_url":"https://api.github.com/repos/davidkpiano/xstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidkpiano/xstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidkpiano/xstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidkpiano/xstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidkpiano/xstate/statuses/{sha}","languages_url":"https://api.github.com/repos/davidkpiano/xstate/languages","stargazers_url":"https://api.github.com/repos/davidkpiano/xstate/stargazers","contributors_url":"https://api.github.com/repos/davidkpiano/xstate/contributors","subscribers_url":"https://api.github.com/repos/davidkpiano/xstate/subscribers","subscription_url":"https://api.github.com/repos/davidkpiano/xstate/subscription","commits_url":"https://api.github.com/repos/davidkpiano/xstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidkpiano/xstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidkpiano/xstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidkpiano/xstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidkpiano/xstate/contents/{+path}","compare_url":"https://api.github.com/repos/davidkpiano/xstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidkpiano/xstate/merges","archive_url":"https://api.github.com/repos/davidkpiano/xstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidkpiano/xstate/downloads","issues_url":"https://api.github.com/repos/davidkpiano/xstate/issues{/number}","pulls_url":"https://api.github.com/repos/davidkpiano/xstate/pulls{/number}","milestones_url":"https://api.github.com/repos/davidkpiano/xstate/milestones{/number}","notifications_url":"https://api.github.com/repos/davidkpiano/xstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidkpiano/xstate/labels{/name}","releases_url":"https://api.github.com/repos/davidkpiano/xstate/releases{/id}","deployments_url":"https://api.github.com/repos/davidkpiano/xstate/deployments","created_at":"2015-09-14T15:04:15Z","updated_at":"2018-08-07T08:47:52Z","pushed_at":"2018-08-06T00:59:08Z","git_url":"git://github.com/davidkpiano/xstate.git","ssh_url":"git@github.com:davidkpiano/xstate.git","clone_url":"https://github.com/davidkpiano/xstate.git","svn_url":"https://github.com/davidkpiano/xstate","homepage":"http://davidkpiano.github.io/xstate/docs","size":1373,"stargazers_count":2115,"watchers_count":2115,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":69,"open_issues":29,"watchers":2115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/127"},"html":{"href":"https://github.com/davidkpiano/xstate/pull/127"},"issue":{"href":"https://api.github.com/repos/davidkpiano/xstate/issues/127"},"comments":{"href":"https://api.github.com/repos/davidkpiano/xstate/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidkpiano/xstate/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/davidkpiano/xstate/statuses/66b9332c98f0e862883639f91251a6a1a48ff8c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mogsie"}}