{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/15070","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/15070/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15070/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/15070/events","html_url":"https://github.com/grpc/grpc/pull/15070","id":314291963,"number":15070,"title":"Adding opencensus grpc plugin with bazel support","user":{"login":"Vizerai","id":6879942,"avatar_url":"https://avatars3.githubusercontent.com/u/6879942?v=4","gravatar_id":"","url":"https://api.github.com/users/Vizerai","html_url":"https://github.com/Vizerai","followers_url":"https://api.github.com/users/Vizerai/followers","following_url":"https://api.github.com/users/Vizerai/following{/other_user}","gists_url":"https://api.github.com/users/Vizerai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizerai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizerai/subscriptions","organizations_url":"https://api.github.com/users/Vizerai/orgs","repos_url":"https://api.github.com/users/Vizerai/repos","events_url":"https://api.github.com/users/Vizerai/events{/privacy}","received_events_url":"https://api.github.com/users/Vizerai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars0.githubusercontent.com/u/7281574?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicolasnoble","id":7281574,"avatar_url":"https://avatars0.githubusercontent.com/u/7281574?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasnoble","html_url":"https://github.com/nicolasnoble","followers_url":"https://api.github.com/users/nicolasnoble/followers","following_url":"https://api.github.com/users/nicolasnoble/following{/other_user}","gists_url":"https://api.github.com/users/nicolasnoble/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasnoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasnoble/subscriptions","organizations_url":"https://api.github.com/users/nicolasnoble/orgs","repos_url":"https://api.github.com/users/nicolasnoble/repos","events_url":"https://api.github.com/users/nicolasnoble/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasnoble/received_events","type":"User","site_admin":false}],"milestone":null,"comments":57,"created_at":"2018-04-14T02:24:44Z","updated_at":"2018-04-20T00:41:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15070","html_url":"https://github.com/grpc/grpc/pull/15070","diff_url":"https://github.com/grpc/grpc/pull/15070.diff","patch_url":"https://github.com/grpc/grpc/pull/15070.patch"},"body":"This makes grpc depend on opencensus to build the plugin.\r\n\r\nMake file support with git submodule could be added later.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/grpc/grpc/15070)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/382925950","html_url":"https://github.com/grpc/grpc/pull/15070#issuecomment-382925950","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15070","id":382925950,"user":{"login":"Vizerai","id":6879942,"avatar_url":"https://avatars3.githubusercontent.com/u/6879942?v=4","gravatar_id":"","url":"https://api.github.com/users/Vizerai","html_url":"https://github.com/Vizerai","followers_url":"https://api.github.com/users/Vizerai/followers","following_url":"https://api.github.com/users/Vizerai/following{/other_user}","gists_url":"https://api.github.com/users/Vizerai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizerai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizerai/subscriptions","organizations_url":"https://api.github.com/users/Vizerai/orgs","repos_url":"https://api.github.com/users/Vizerai/repos","events_url":"https://api.github.com/users/Vizerai/events{/privacy}","received_events_url":"https://api.github.com/users/Vizerai/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T00:41:42Z","updated_at":"2018-04-20T00:41:42Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.\n\n---\n\n*[BUILD, line 1961 at r9](https://beta.reviewable.io/reviews/grpc/grpc/15070#-LAU25NIC4OE8PpRCvlI:-LAVTjhF2lF13yGuUX9v:b-70mbpg) ([raw file](https://github.com/grpc/grpc/blob/4fc8c67706c406158876fdb05889c6c6355df32e/BUILD#L1961)):*\n<details><summary><i>Previously, markdroth (Mark D. Roth) wrote…</i></summary><blockquote>\n\nNeed to define this target in build.yaml as well.\n</blockquote></details>\n\nWon't this make it show up in the Makefile?  Wouldn't we would then need to add opencensus as a git submodule then?  At first I thought we were only going to have bazel support.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/grpc/grpc/15070)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Vizerai"}}