{"action":"created","comment":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/232508033","pull_request_review_id":173718681,"id":232508033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjUwODAzMw==","diff_hunk":"@@ -12,6 +12,13 @@ Thank you for contributing to Remacs!\n \n * Follow the existing style for new Rust code. Notes about style\n   can be found in the section on [Remacs style](#remacs-style).\n+* Use rust_src/admin/rustize-emacs to help start a port of a C function\n+  or `DEFUN`. Mark a region around a `DEFUN` and run `M-| rustize-emacs`.\n+  This will do the work to transform the definition into Rust. You can\n+  then yank and paste it into the appropriate Rust file or start a new one.\n+  Now you need to port the body of the function.\n+* Try to use types where possible. `LispObject` is analogous to a void pointer","path":"CONTRIBUTING.md","position":9,"original_position":9,"commit_id":"739537e2b2b17d32e4ac33d7339799f457780f7c","original_commit_id":"739537e2b2b17d32e4ac33d7339799f457780f7c","user":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"body":"It's not directly analogous to a void pointer, is it? It's a tagged pointer. The `Object` example works but I find the `*void` example a little confusing. How about something like this?\r\n\r\n```\r\n* Try to use more exact types where possible. `LispObject` allows anything, and often we can do better.\r\n```","created_at":"2018-11-11T22:43:18Z","updated_at":"2018-11-11T22:43:18Z","html_url":"https://github.com/Wilfred/remacs/pull/1039#discussion_r232508033","pull_request_url":"https://api.github.com/repos/Wilfred/remacs/pulls/1039","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/232508033"},"html":{"href":"https://github.com/Wilfred/remacs/pull/1039#discussion_r232508033"},"pull_request":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/1039"}}},"pull_request":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/1039","id":229966366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTY2MzY2","html_url":"https://github.com/Wilfred/remacs/pull/1039","diff_url":"https://github.com/Wilfred/remacs/pull/1039.diff","patch_url":"https://github.com/Wilfred/remacs/pull/1039.patch","issue_url":"https://api.github.com/repos/Wilfred/remacs/issues/1039","number":1039,"state":"open","locked":false,"title":"Update docs to mention rustize tool and preferring more specific types.","user":{"login":"shaleh","id":1377996,"node_id":"MDQ6VXNlcjEzNzc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-11T17:39:28Z","updated_at":"2018-11-11T22:43:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"877d8dd8fabd43282a862e2b405ea2434d098957","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wilfred/remacs/pulls/1039/commits","review_comments_url":"https://api.github.com/repos/Wilfred/remacs/pulls/1039/comments","review_comment_url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wilfred/remacs/issues/1039/comments","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/739537e2b2b17d32e4ac33d7339799f457780f7c","head":{"label":"Wilfred:shaleh-patch-1","ref":"shaleh-patch-1","sha":"739537e2b2b17d32e4ac33d7339799f457780f7c","user":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":74522337,"node_id":"MDEwOlJlcG9zaXRvcnk3NDUyMjMzNw==","name":"remacs","full_name":"Wilfred/remacs","private":false,"owner":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Wilfred/remacs","description":"Rust :heart: Emacs","fork":false,"url":"https://api.github.com/repos/Wilfred/remacs","forks_url":"https://api.github.com/repos/Wilfred/remacs/forks","keys_url":"https://api.github.com/repos/Wilfred/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/remacs/teams","hooks_url":"https://api.github.com/repos/Wilfred/remacs/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/remacs/events","assignees_url":"https://api.github.com/repos/Wilfred/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/remacs/tags","blobs_url":"https://api.github.com/repos/Wilfred/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/remacs/languages","stargazers_url":"https://api.github.com/repos/Wilfred/remacs/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/remacs/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/remacs/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/remacs/subscription","commits_url":"https://api.github.com/repos/Wilfred/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/remacs/merges","archive_url":"https://api.github.com/repos/Wilfred/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/remacs/downloads","issues_url":"https://api.github.com/repos/Wilfred/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/remacs/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/Wilfred/remacs/deployments","created_at":"2016-11-22T23:29:21Z","updated_at":"2018-11-11T22:29:29Z","pushed_at":"2018-11-11T22:22:14Z","git_url":"git://github.com/Wilfred/remacs.git","ssh_url":"git@github.com:Wilfred/remacs.git","clone_url":"https://github.com/Wilfred/remacs.git","svn_url":"https://github.com/Wilfred/remacs","homepage":"","size":271596,"stargazers_count":2722,"watchers_count":2722,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":219,"open_issues":92,"watchers":2722,"default_branch":"master"}},"base":{"label":"Wilfred:master","ref":"master","sha":"2aebcf4d9e0ec5c4ef602f5918f211edf3015278","user":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":74522337,"node_id":"MDEwOlJlcG9zaXRvcnk3NDUyMjMzNw==","name":"remacs","full_name":"Wilfred/remacs","private":false,"owner":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Wilfred/remacs","description":"Rust :heart: Emacs","fork":false,"url":"https://api.github.com/repos/Wilfred/remacs","forks_url":"https://api.github.com/repos/Wilfred/remacs/forks","keys_url":"https://api.github.com/repos/Wilfred/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/remacs/teams","hooks_url":"https://api.github.com/repos/Wilfred/remacs/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/remacs/events","assignees_url":"https://api.github.com/repos/Wilfred/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/remacs/tags","blobs_url":"https://api.github.com/repos/Wilfred/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/remacs/languages","stargazers_url":"https://api.github.com/repos/Wilfred/remacs/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/remacs/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/remacs/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/remacs/subscription","commits_url":"https://api.github.com/repos/Wilfred/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/remacs/merges","archive_url":"https://api.github.com/repos/Wilfred/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/remacs/downloads","issues_url":"https://api.github.com/repos/Wilfred/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/remacs/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/Wilfred/remacs/deployments","created_at":"2016-11-22T23:29:21Z","updated_at":"2018-11-11T22:29:29Z","pushed_at":"2018-11-11T22:22:14Z","git_url":"git://github.com/Wilfred/remacs.git","ssh_url":"git@github.com:Wilfred/remacs.git","clone_url":"https://github.com/Wilfred/remacs.git","svn_url":"https://github.com/Wilfred/remacs","homepage":"","size":271596,"stargazers_count":2722,"watchers_count":2722,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":219,"open_issues":92,"watchers":2722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/1039"},"html":{"href":"https://github.com/Wilfred/remacs/pull/1039"},"issue":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/1039"},"comments":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/1039/comments"},"review_comments":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/1039/comments"},"review_comment":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/1039/commits"},"statuses":{"href":"https://api.github.com/repos/Wilfred/remacs/statuses/739537e2b2b17d32e4ac33d7339799f457780f7c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Wilfred"}}