{"action":"created","comment":{"url":"https://api.github.com/repos/radargun/radargun/pulls/comments/171659792","pull_request_review_id":100551931,"id":171659792,"diff_hunk":"@@ -0,0 +1,148 @@\n+#!/bin/bash","path":"openshift/openshift.sh","position":1,"original_position":1,"commit_id":"cfadabe6a27c0523fcfef9645078c63f8b2f8bb2","original_commit_id":"cfadabe6a27c0523fcfef9645078c63f8b2f8bb2","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars0.githubusercontent.com/u/8417158?v=4","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"make...file...make...file...make..file...\r\n\r\nI know, you guys hate me for those makefiles everywhere ;)","created_at":"2018-03-01T19:01:36Z","updated_at":"2018-03-01T19:02:51Z","html_url":"https://github.com/radargun/radargun/pull/513#discussion_r171659792","pull_request_url":"https://api.github.com/repos/radargun/radargun/pulls/513","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/radargun/radargun/pulls/comments/171659792"},"html":{"href":"https://github.com/radargun/radargun/pull/513#discussion_r171659792"},"pull_request":{"href":"https://api.github.com/repos/radargun/radargun/pulls/513"}}},"pull_request":{"url":"https://api.github.com/repos/radargun/radargun/pulls/513","id":171924224,"html_url":"https://github.com/radargun/radargun/pull/513","diff_url":"https://github.com/radargun/radargun/pull/513.diff","patch_url":"https://github.com/radargun/radargun/pull/513.patch","issue_url":"https://api.github.com/repos/radargun/radargun/issues/513","number":513,"state":"open","locked":false,"title":"PREVIEW: OpenShift support - library mode","user":{"login":"mgencur","id":336823,"avatar_url":"https://avatars2.githubusercontent.com/u/336823?v=4","gravatar_id":"","url":"https://api.github.com/users/mgencur","html_url":"https://github.com/mgencur","followers_url":"https://api.github.com/users/mgencur/followers","following_url":"https://api.github.com/users/mgencur/following{/other_user}","gists_url":"https://api.github.com/users/mgencur/gists{/gist_id}","starred_url":"https://api.github.com/users/mgencur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgencur/subscriptions","organizations_url":"https://api.github.com/users/mgencur/orgs","repos_url":"https://api.github.com/users/mgencur/repos","events_url":"https://api.github.com/users/mgencur/events{/privacy}","received_events_url":"https://api.github.com/users/mgencur/received_events","type":"User","site_admin":false},"body":"Please review this implementation. It works with Employee openshift but should work with any other instance.\r\n\r\n* There are some TBDs. Please ignore them.\r\n* WDYT about building RadarGun before creating the Docker image vs. including the build in the image itself?\r\n* I've exposed port 7800 by default on all RG slaves. This is specific to JGroups but other plugins could re-use this port. I just wanted to make one port available for intra-cluster communication which is exposed by the Docker container and accessible from other pods. We can possible choose a different port number.\r\n* The JVM opts needs to be tuned and described in readme (this is TBD)\r\n\r\nI can provide config files for JGroups and ISPN that worked for me in OpenShift (upon request).\r\n\r\nDon't integrate this yet. But thoughts are welcome.","created_at":"2018-02-28T11:17:49Z","updated_at":"2018-03-01T19:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9ab3829263e5a7bfe4ba2bc37b6874689b6f76d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radargun/radargun/pulls/513/commits","review_comments_url":"https://api.github.com/repos/radargun/radargun/pulls/513/comments","review_comment_url":"https://api.github.com/repos/radargun/radargun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radargun/radargun/issues/513/comments","statuses_url":"https://api.github.com/repos/radargun/radargun/statuses/cfadabe6a27c0523fcfef9645078c63f8b2f8bb2","head":{"label":"mgencur:openshift","ref":"openshift","sha":"cfadabe6a27c0523fcfef9645078c63f8b2f8bb2","user":{"login":"mgencur","id":336823,"avatar_url":"https://avatars2.githubusercontent.com/u/336823?v=4","gravatar_id":"","url":"https://api.github.com/users/mgencur","html_url":"https://github.com/mgencur","followers_url":"https://api.github.com/users/mgencur/followers","following_url":"https://api.github.com/users/mgencur/following{/other_user}","gists_url":"https://api.github.com/users/mgencur/gists{/gist_id}","starred_url":"https://api.github.com/users/mgencur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgencur/subscriptions","organizations_url":"https://api.github.com/users/mgencur/orgs","repos_url":"https://api.github.com/users/mgencur/repos","events_url":"https://api.github.com/users/mgencur/events{/privacy}","received_events_url":"https://api.github.com/users/mgencur/received_events","type":"User","site_admin":false},"repo":{"id":7259287,"name":"radargun","full_name":"mgencur/radargun","owner":{"login":"mgencur","id":336823,"avatar_url":"https://avatars2.githubusercontent.com/u/336823?v=4","gravatar_id":"","url":"https://api.github.com/users/mgencur","html_url":"https://github.com/mgencur","followers_url":"https://api.github.com/users/mgencur/followers","following_url":"https://api.github.com/users/mgencur/following{/other_user}","gists_url":"https://api.github.com/users/mgencur/gists{/gist_id}","starred_url":"https://api.github.com/users/mgencur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgencur/subscriptions","organizations_url":"https://api.github.com/users/mgencur/orgs","repos_url":"https://api.github.com/users/mgencur/repos","events_url":"https://api.github.com/users/mgencur/events{/privacy}","received_events_url":"https://api.github.com/users/mgencur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgencur/radargun","description":"The RadarGun benchmarking framework for data grids and distributed caches","fork":true,"url":"https://api.github.com/repos/mgencur/radargun","forks_url":"https://api.github.com/repos/mgencur/radargun/forks","keys_url":"https://api.github.com/repos/mgencur/radargun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgencur/radargun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgencur/radargun/teams","hooks_url":"https://api.github.com/repos/mgencur/radargun/hooks","issue_events_url":"https://api.github.com/repos/mgencur/radargun/issues/events{/number}","events_url":"https://api.github.com/repos/mgencur/radargun/events","assignees_url":"https://api.github.com/repos/mgencur/radargun/assignees{/user}","branches_url":"https://api.github.com/repos/mgencur/radargun/branches{/branch}","tags_url":"https://api.github.com/repos/mgencur/radargun/tags","blobs_url":"https://api.github.com/repos/mgencur/radargun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgencur/radargun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgencur/radargun/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgencur/radargun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgencur/radargun/statuses/{sha}","languages_url":"https://api.github.com/repos/mgencur/radargun/languages","stargazers_url":"https://api.github.com/repos/mgencur/radargun/stargazers","contributors_url":"https://api.github.com/repos/mgencur/radargun/contributors","subscribers_url":"https://api.github.com/repos/mgencur/radargun/subscribers","subscription_url":"https://api.github.com/repos/mgencur/radargun/subscription","commits_url":"https://api.github.com/repos/mgencur/radargun/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgencur/radargun/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgencur/radargun/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgencur/radargun/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgencur/radargun/contents/{+path}","compare_url":"https://api.github.com/repos/mgencur/radargun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgencur/radargun/merges","archive_url":"https://api.github.com/repos/mgencur/radargun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgencur/radargun/downloads","issues_url":"https://api.github.com/repos/mgencur/radargun/issues{/number}","pulls_url":"https://api.github.com/repos/mgencur/radargun/pulls{/number}","milestones_url":"https://api.github.com/repos/mgencur/radargun/milestones{/number}","notifications_url":"https://api.github.com/repos/mgencur/radargun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgencur/radargun/labels{/name}","releases_url":"https://api.github.com/repos/mgencur/radargun/releases{/id}","deployments_url":"https://api.github.com/repos/mgencur/radargun/deployments","created_at":"2012-12-20T14:51:51Z","updated_at":"2013-12-11T13:16:58Z","pushed_at":"2018-02-28T10:58:08Z","git_url":"git://github.com/mgencur/radargun.git","ssh_url":"git@github.com:mgencur/radargun.git","clone_url":"https://github.com/mgencur/radargun.git","svn_url":"https://github.com/mgencur/radargun","homepage":"http://radargun.github.com/radargun/","size":6580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radargun:master","ref":"master","sha":"707c3eaeffd3116dbe7f3e80cb63a90d3b6fe49f","user":{"login":"radargun","id":517796,"avatar_url":"https://avatars3.githubusercontent.com/u/517796?v=4","gravatar_id":"","url":"https://api.github.com/users/radargun","html_url":"https://github.com/radargun","followers_url":"https://api.github.com/users/radargun/followers","following_url":"https://api.github.com/users/radargun/following{/other_user}","gists_url":"https://api.github.com/users/radargun/gists{/gist_id}","starred_url":"https://api.github.com/users/radargun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radargun/subscriptions","organizations_url":"https://api.github.com/users/radargun/orgs","repos_url":"https://api.github.com/users/radargun/repos","events_url":"https://api.github.com/users/radargun/events{/privacy}","received_events_url":"https://api.github.com/users/radargun/received_events","type":"Organization","site_admin":false},"repo":{"id":1156136,"name":"radargun","full_name":"radargun/radargun","owner":{"login":"radargun","id":517796,"avatar_url":"https://avatars3.githubusercontent.com/u/517796?v=4","gravatar_id":"","url":"https://api.github.com/users/radargun","html_url":"https://github.com/radargun","followers_url":"https://api.github.com/users/radargun/followers","following_url":"https://api.github.com/users/radargun/following{/other_user}","gists_url":"https://api.github.com/users/radargun/gists{/gist_id}","starred_url":"https://api.github.com/users/radargun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radargun/subscriptions","organizations_url":"https://api.github.com/users/radargun/orgs","repos_url":"https://api.github.com/users/radargun/repos","events_url":"https://api.github.com/users/radargun/events{/privacy}","received_events_url":"https://api.github.com/users/radargun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/radargun/radargun","description":"The RadarGun benchmarking framework for data grids and distributed caches","fork":false,"url":"https://api.github.com/repos/radargun/radargun","forks_url":"https://api.github.com/repos/radargun/radargun/forks","keys_url":"https://api.github.com/repos/radargun/radargun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radargun/radargun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radargun/radargun/teams","hooks_url":"https://api.github.com/repos/radargun/radargun/hooks","issue_events_url":"https://api.github.com/repos/radargun/radargun/issues/events{/number}","events_url":"https://api.github.com/repos/radargun/radargun/events","assignees_url":"https://api.github.com/repos/radargun/radargun/assignees{/user}","branches_url":"https://api.github.com/repos/radargun/radargun/branches{/branch}","tags_url":"https://api.github.com/repos/radargun/radargun/tags","blobs_url":"https://api.github.com/repos/radargun/radargun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radargun/radargun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radargun/radargun/git/refs{/sha}","trees_url":"https://api.github.com/repos/radargun/radargun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radargun/radargun/statuses/{sha}","languages_url":"https://api.github.com/repos/radargun/radargun/languages","stargazers_url":"https://api.github.com/repos/radargun/radargun/stargazers","contributors_url":"https://api.github.com/repos/radargun/radargun/contributors","subscribers_url":"https://api.github.com/repos/radargun/radargun/subscribers","subscription_url":"https://api.github.com/repos/radargun/radargun/subscription","commits_url":"https://api.github.com/repos/radargun/radargun/commits{/sha}","git_commits_url":"https://api.github.com/repos/radargun/radargun/git/commits{/sha}","comments_url":"https://api.github.com/repos/radargun/radargun/comments{/number}","issue_comment_url":"https://api.github.com/repos/radargun/radargun/issues/comments{/number}","contents_url":"https://api.github.com/repos/radargun/radargun/contents/{+path}","compare_url":"https://api.github.com/repos/radargun/radargun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radargun/radargun/merges","archive_url":"https://api.github.com/repos/radargun/radargun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radargun/radargun/downloads","issues_url":"https://api.github.com/repos/radargun/radargun/issues{/number}","pulls_url":"https://api.github.com/repos/radargun/radargun/pulls{/number}","milestones_url":"https://api.github.com/repos/radargun/radargun/milestones{/number}","notifications_url":"https://api.github.com/repos/radargun/radargun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radargun/radargun/labels{/name}","releases_url":"https://api.github.com/repos/radargun/radargun/releases{/id}","deployments_url":"https://api.github.com/repos/radargun/radargun/deployments","created_at":"2010-12-10T13:35:42Z","updated_at":"2018-01-25T09:42:11Z","pushed_at":"2018-02-28T11:17:49Z","git_url":"git://github.com/radargun/radargun.git","ssh_url":"git@github.com:radargun/radargun.git","clone_url":"https://github.com/radargun/radargun.git","svn_url":"https://github.com/radargun/radargun","homepage":"http://radargun.github.io/radargun","size":6679,"stargazers_count":96,"watchers_count":96,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":62,"open_issues":39,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radargun/radargun/pulls/513"},"html":{"href":"https://github.com/radargun/radargun/pull/513"},"issue":{"href":"https://api.github.com/repos/radargun/radargun/issues/513"},"comments":{"href":"https://api.github.com/repos/radargun/radargun/issues/513/comments"},"review_comments":{"href":"https://api.github.com/repos/radargun/radargun/pulls/513/comments"},"review_comment":{"href":"https://api.github.com/repos/radargun/radargun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radargun/radargun/pulls/513/commits"},"statuses":{"href":"https://api.github.com/repos/radargun/radargun/statuses/cfadabe6a27c0523fcfef9645078c63f8b2f8bb2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slaskawi"}}