{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/242125110","pull_request_review_id":185561401,"id":242125110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjEyNTExMA==","diff_hunk":"@@ -8,44 +8,44 @@ import (\n // v20180930preview.OpenShiftManagedCluster.\n func ConvertToV20180930preview(cs *OpenShiftManagedCluster) *v20180930preview.OpenShiftManagedCluster {\n \toc := &v20180930preview.OpenShiftManagedCluster{\n-\t\tID:       &cs.ID,\n-\t\tLocation: &cs.Location,\n-\t\tName:     &cs.Name,\n-\t\tType:     &cs.Type,\n+\t\tID:       nilIfStringEmpty(&cs.ID),\n+\t\tLocation: nilIfStringEmpty(&cs.Location),\n+\t\tName:     nilIfStringEmpty(&cs.Name),\n+\t\tType:     nilIfStringEmpty(&cs.Type),\n \t}\n \toc.Tags = make(map[string]*string, len(cs.Tags))\n \tfor k := range cs.Tags {\n \t\tv := cs.Tags[k]\n-\t\toc.Tags[k] = &v\n+\t\toc.Tags[k] = nilIfStringEmpty(&v)\n \t}\n \n \toc.Plan = &v20180930preview.ResourcePurchasePlan{\n-\t\tName:          &cs.Plan.Name,\n-\t\tProduct:       &cs.Plan.Product,\n-\t\tPromotionCode: &cs.Plan.PromotionCode,\n-\t\tPublisher:     &cs.Plan.Publisher,\n+\t\tName:          nilIfStringEmpty(&cs.Plan.Name),\n+\t\tProduct:       nilIfStringEmpty(&cs.Plan.Product),\n+\t\tPromotionCode: nilIfStringEmpty(&cs.Plan.PromotionCode),\n+\t\tPublisher:     nilIfStringEmpty(&cs.Plan.Publisher),\n \t}\n \n \tprovisioningState := v20180930preview.ProvisioningState(cs.Properties.ProvisioningState)\n \toc.Properties = &v20180930preview.Properties{\n \t\tProvisioningState: &provisioningState,","path":"pkg/api/convertertov20180930preview.go","position":33,"original_position":33,"commit_id":"ce639d337d88cce34aab1537dd61c2d5e7fa069b","original_commit_id":"ce639d337d88cce34aab1537dd61c2d5e7fa069b","user":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Hrm, I think provisioningState, count, vmSize, osType, and role also need to be handled the same way?","created_at":"2018-12-17T12:16:47Z","updated_at":"2018-12-17T12:16:52Z","html_url":"https://github.com/openshift/openshift-azure/pull/918#discussion_r242125110","pull_request_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/918","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments/242125110"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/918#discussion_r242125110"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/918","id":239081618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDgxNjE4","html_url":"https://github.com/openshift/openshift-azure/pull/918","diff_url":"https://github.com/openshift/openshift-azure/pull/918.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/918.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/918","number":918,"state":"open","locked":false,"title":"Changing pointers to empty strings to nil pointers","user":{"login":"Makdaam","id":2552733,"node_id":"MDQ6VXNlcjI1NTI3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2552733?v=4","gravatar_id":"","url":"https://api.github.com/users/Makdaam","html_url":"https://github.com/Makdaam","followers_url":"https://api.github.com/users/Makdaam/followers","following_url":"https://api.github.com/users/Makdaam/following{/other_user}","gists_url":"https://api.github.com/users/Makdaam/gists{/gist_id}","starred_url":"https://api.github.com/users/Makdaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makdaam/subscriptions","organizations_url":"https://api.github.com/users/Makdaam/orgs","repos_url":"https://api.github.com/users/Makdaam/repos","events_url":"https://api.github.com/users/Makdaam/events{/privacy}","received_events_url":"https://api.github.com/users/Makdaam/received_events","type":"User","site_admin":false},"body":"Fixes #908.\r\n\r\nAdded a small func to replace pointers to \"\" strings with nil. Wrapped all string pointers in converttoadmin.go and converttov20180930preview.go with it.","created_at":"2018-12-17T09:47:40Z","updated_at":"2018-12-17T12:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ea26db9ddc8381c039ffc2ddee1fcc2eeb5344d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thekad","id":46422,"node_id":"MDQ6VXNlcjQ2NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/46422?v=4","gravatar_id":"","url":"https://api.github.com/users/thekad","html_url":"https://github.com/thekad","followers_url":"https://api.github.com/users/thekad/followers","following_url":"https://api.github.com/users/thekad/following{/other_user}","gists_url":"https://api.github.com/users/thekad/gists{/gist_id}","starred_url":"https://api.github.com/users/thekad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekad/subscriptions","organizations_url":"https://api.github.com/users/thekad/orgs","repos_url":"https://api.github.com/users/thekad/repos","events_url":"https://api.github.com/users/thekad/events{/privacy}","received_events_url":"https://api.github.com/users/thekad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1006517260,"node_id":"MDU6TGFiZWwxMDA2NTE3MjYw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/918/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/918/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/918/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/ce639d337d88cce34aab1537dd61c2d5e7fa069b","head":{"label":"Makdaam:issue-908","ref":"issue-908","sha":"ce639d337d88cce34aab1537dd61c2d5e7fa069b","user":{"login":"Makdaam","id":2552733,"node_id":"MDQ6VXNlcjI1NTI3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2552733?v=4","gravatar_id":"","url":"https://api.github.com/users/Makdaam","html_url":"https://github.com/Makdaam","followers_url":"https://api.github.com/users/Makdaam/followers","following_url":"https://api.github.com/users/Makdaam/following{/other_user}","gists_url":"https://api.github.com/users/Makdaam/gists{/gist_id}","starred_url":"https://api.github.com/users/Makdaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makdaam/subscriptions","organizations_url":"https://api.github.com/users/Makdaam/orgs","repos_url":"https://api.github.com/users/Makdaam/repos","events_url":"https://api.github.com/users/Makdaam/events{/privacy}","received_events_url":"https://api.github.com/users/Makdaam/received_events","type":"User","site_admin":false},"repo":{"id":160639056,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA2MzkwNTY=","name":"openshift-azure","full_name":"Makdaam/openshift-azure","private":false,"owner":{"login":"Makdaam","id":2552733,"node_id":"MDQ6VXNlcjI1NTI3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2552733?v=4","gravatar_id":"","url":"https://api.github.com/users/Makdaam","html_url":"https://github.com/Makdaam","followers_url":"https://api.github.com/users/Makdaam/followers","following_url":"https://api.github.com/users/Makdaam/following{/other_user}","gists_url":"https://api.github.com/users/Makdaam/gists{/gist_id}","starred_url":"https://api.github.com/users/Makdaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makdaam/subscriptions","organizations_url":"https://api.github.com/users/Makdaam/orgs","repos_url":"https://api.github.com/users/Makdaam/repos","events_url":"https://api.github.com/users/Makdaam/events{/privacy}","received_events_url":"https://api.github.com/users/Makdaam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Makdaam/openshift-azure","description":null,"fork":true,"url":"https://api.github.com/repos/Makdaam/openshift-azure","forks_url":"https://api.github.com/repos/Makdaam/openshift-azure/forks","keys_url":"https://api.github.com/repos/Makdaam/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Makdaam/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Makdaam/openshift-azure/teams","hooks_url":"https://api.github.com/repos/Makdaam/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/Makdaam/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/Makdaam/openshift-azure/events","assignees_url":"https://api.github.com/repos/Makdaam/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/Makdaam/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/Makdaam/openshift-azure/tags","blobs_url":"https://api.github.com/repos/Makdaam/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Makdaam/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Makdaam/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/Makdaam/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Makdaam/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/Makdaam/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/Makdaam/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/Makdaam/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/Makdaam/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/Makdaam/openshift-azure/subscription","commits_url":"https://api.github.com/repos/Makdaam/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/Makdaam/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/Makdaam/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/Makdaam/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/Makdaam/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/Makdaam/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Makdaam/openshift-azure/merges","archive_url":"https://api.github.com/repos/Makdaam/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Makdaam/openshift-azure/downloads","issues_url":"https://api.github.com/repos/Makdaam/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/Makdaam/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/Makdaam/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/Makdaam/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Makdaam/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/Makdaam/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/Makdaam/openshift-azure/deployments","created_at":"2018-12-06T07:52:16Z","updated_at":"2018-12-06T07:52:20Z","pushed_at":"2018-12-17T12:13:56Z","git_url":"git://github.com/Makdaam/openshift-azure.git","ssh_url":"git@github.com:Makdaam/openshift-azure.git","clone_url":"https://github.com/Makdaam/openshift-azure.git","svn_url":"https://github.com/Makdaam/openshift-azure","homepage":null,"size":38689,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"57cef0659780a509c1db5bc22605dbb6ab3ef91d","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-12-17T11:33:58Z","pushed_at":"2018-12-17T12:13:57Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":38702,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":80,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/918"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/918"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/918"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/ce639d337d88cce34aab1537dd61c2d5e7fa069b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kargakis"}}