{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/227639410","pull_request_review_id":167726588,"id":227639410,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYzOTQxMA==","diff_hunk":"@@ -539,6 +542,31 @@ function (Okta, Q, Logger, OktaAuth, Util, Expect, Router,\n         expect(test.router.navigate).toHaveBeenCalledWith('', { trigger: true });\n       });\n     });\n+    itp('triggers a \"navigated\" event when routing to default route and when status is UNAUTHENTICATED', function () {\n+      return setup({ stateToken: 'aStateToken' })\n+      .then(function (test) {\n+        Util.mockRouterNavigate(test.router);\n+        test.setNextResponse(resUnauthenticated);\n+        test.router.navigate('/app/sso');\n+        return Expect.waitForPrimaryAuth(test);\n+      })\n+      .then(function (test) {\n+        expect(test.router.navigate).toHaveBeenCalledWith('', { trigger: true });\n+        expect(test.navigatedSpy.calls.count()).toBe(2);\n+        expect(test.navigatedSpy.calls.allArgs()[0]).toEqual([{\n+          view: '/context.html',\n+          controller: 'refresh-auth-state',\n+          transaction: undefined\n+        }]);\n+        expect(test.navigatedSpy.calls.allArgs()[1]).toEqual([{\n+          view: '/context.html',\n+          controller: 'primary-auth',\n+          transaction: jasmine.objectContaining({","path":"test/unit/spec/LoginRouter_spec.js","position":48,"original_position":48,"commit_id":"1d3049f8e9f651196ca5cc80bc84ed604628085b","original_commit_id":"1d3049f8e9f651196ca5cc80bc84ed604628085b","user":{"login":"jmelberg-okta","id":20212241,"node_id":"MDQ6VXNlcjIwMjEyMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/20212241?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelberg-okta","html_url":"https://github.com/jmelberg-okta","followers_url":"https://api.github.com/users/jmelberg-okta/followers","following_url":"https://api.github.com/users/jmelberg-okta/following{/other_user}","gists_url":"https://api.github.com/users/jmelberg-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelberg-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelberg-okta/subscriptions","organizations_url":"https://api.github.com/users/jmelberg-okta/orgs","repos_url":"https://api.github.com/users/jmelberg-okta/repos","events_url":"https://api.github.com/users/jmelberg-okta/events{/privacy}","received_events_url":"https://api.github.com/users/jmelberg-okta/received_events","type":"User","site_admin":false},"body":"Pushed an update to assert the entire object. Good reminder that we should check for as many values as possible.","created_at":"2018-10-24T04:32:51Z","updated_at":"2018-10-24T04:32:51Z","html_url":"https://github.com/okta/okta-signin-widget/pull/567#discussion_r227639410","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/227639410"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/567#discussion_r227639410"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567"}},"in_reply_to_id":227608174},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567","id":224846967,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODQ2OTY3","html_url":"https://github.com/okta/okta-signin-widget/pull/567","diff_url":"https://github.com/okta/okta-signin-widget/pull/567.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/567.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/567","number":567,"state":"open","locked":false,"title":"feat: Adds new 'navigated' event","user":{"login":"jmelberg-okta","id":20212241,"node_id":"MDQ6VXNlcjIwMjEyMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/20212241?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelberg-okta","html_url":"https://github.com/jmelberg-okta","followers_url":"https://api.github.com/users/jmelberg-okta/followers","following_url":"https://api.github.com/users/jmelberg-okta/following{/other_user}","gists_url":"https://api.github.com/users/jmelberg-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelberg-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelberg-okta/subscriptions","organizations_url":"https://api.github.com/users/jmelberg-okta/orgs","repos_url":"https://api.github.com/users/jmelberg-okta/repos","events_url":"https://api.github.com/users/jmelberg-okta/events{/privacy}","received_events_url":"https://api.github.com/users/jmelberg-okta/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nCreates a new `navigated` event that provides the following `context` information:\r\n\r\n```javascript\r\nsignIn.on('navigated', (context) => {\r\n  // Assume view transitions between Primary Auth and MFA Push\r\n  console.log(context);\r\n  /**\r\n   * {\r\n   *   view: '/signin/verify/okta/push',\r\n   *   controller: 'mfa-verify',\r\n   *   transaction: AuthTransaction\r\n   * }\r\n   */\r\n});\r\n```\r\n\r\n> Note: Since there is no *good* way to deprecate events, we're going to label the existing `pageRendered` event as deprecated.","created_at":"2018-10-22T23:36:51Z","updated_at":"2018-10-24T04:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7484545d0a58ffda62cbd28ca6032b56343d4e43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/567/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/1d3049f8e9f651196ca5cc80bc84ed604628085b","head":{"label":"okta:jm-navigated-event","ref":"jm-navigated-event","sha":"1d3049f8e9f651196ca5cc80bc84ed604628085b","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","private":false,"owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-10-17T23:01:45Z","pushed_at":"2018-10-23T23:20:08Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":20209,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":53,"watchers":77,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"ba25561780f1a36dedd9a26372877f899e895bd1","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","private":false,"owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-10-17T23:01:45Z","pushed_at":"2018-10-23T23:20:08Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":20209,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":53,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/567"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/567"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/1d3049f8e9f651196ca5cc80bc84ed604628085b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jmelberg-okta"}}