{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/comments/172551576","pull_request_review_id":101586705,"id":172551576,"diff_hunk":"@@ -20,49 +20,17 @@ import (\n \t\"context\"\n \t\"testing\"\n \n-\t\"github.com/container-storage-interface/spec/lib/go/csi\"\n+\t\"github.com/container-storage-interface/spec/lib/go/csi/v0\"\n \t\"github.com/stretchr/testify/assert\"\n-\t\"google.golang.org/grpc/codes\"\n-\t\"google.golang.org/grpc/status\"\n )\n \n-func TestGetSupportedVersions(t *testing.T) {\n-\td := NewFakeDriver()\n-\n-\tids := NewDefaultIdentityServer(d)\n-\n-\treq := csi.GetSupportedVersionsRequest{}\n-\n-\t// Test Get supported versions are valid.\n-\tresp, err := ids.GetSupportedVersions(context.Background(), &req)\n-\tassert.NoError(t, err)\n-\n-\tfor _, fv := range fakeVersionsSupported {\n-\t\tfound := false\n-\t\tfor _, rv := range resp.GetSupportedVersions() {\n-\t\t\tif fv.GetMajor() == rv.GetMajor() && fv.GetMinor() == rv.GetMinor() && fv.GetPatch() == rv.GetPatch() {\n-\t\t\t\tfound = true\n-\t\t\t}\n-\t\t}\n-\t\tassert.True(t, found)\n-\t}\n-}\n-\n func TestGetPluginInfo(t *testing.T) {\n \td := NewFakeDriver()\n \n \tids := NewDefaultIdentityServer(d)\n \n-\t// Test invalid request\n \treq := csi.GetPluginInfoRequest{}\n \tresp, err := ids.GetPluginInfo(context.Background(), &req)\n-\ts, ok := status.FromError(err)\n-\tassert.True(t, ok)\n-\tassert.Equal(t, s.Code(), codes.InvalidArgument)\n-\n-\t// Test valid request\n-\treq.Version = &fakeVersion\n-\tresp, err = ids.GetPluginInfo(context.Background(), &req)","path":"pkg/csi-common/identityserver-default_test.go","position":47,"original_position":47,"commit_id":"acc7257e15ed314731225b5777caf96bd9e99227","original_commit_id":"acc7257e15ed314731225b5777caf96bd9e99227","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"GetPluginInfo still has version\r\nhttps://github.com/container-storage-interface/spec/blob/master/lib/go/csi/v0/csi.pb.go#L222","created_at":"2018-03-06T15:23:47Z","updated_at":"2018-03-06T15:23:47Z","html_url":"https://github.com/kubernetes-csi/drivers/pull/56#discussion_r172551576","pull_request_url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/comments/172551576"},"html":{"href":"https://github.com/kubernetes-csi/drivers/pull/56#discussion_r172551576"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56"}},"in_reply_to_id":172547100},"pull_request":{"url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56","id":171463635,"html_url":"https://github.com/kubernetes-csi/drivers/pull/56","diff_url":"https://github.com/kubernetes-csi/drivers/pull/56.diff","patch_url":"https://github.com/kubernetes-csi/drivers/pull/56.patch","issue_url":"https://api.github.com/repos/kubernetes-csi/drivers/issues/56","number":56,"state":"open","locked":false,"title":"refactor csi-common and hostpath plugin  to use new api objects","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"body":"Refactor hostpath plugin and csi-common for new CSI spec ","created_at":"2018-02-26T19:07:09Z","updated_at":"2018-03-06T15:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c8acaddffe8422fd678b2f8023d7e4aa50ef2ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56/commits","review_comments_url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56/comments","review_comment_url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-csi/drivers/issues/56/comments","statuses_url":"https://api.github.com/repos/kubernetes-csi/drivers/statuses/acc7257e15ed314731225b5777caf96bd9e99227","head":{"label":"sbezverk:0.2.0_v0","ref":"0.2.0_v0","sha":"acc7257e15ed314731225b5777caf96bd9e99227","user":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"repo":{"id":116455958,"name":"drivers","full_name":"sbezverk/drivers","owner":{"login":"sbezverk","id":16273360,"avatar_url":"https://avatars3.githubusercontent.com/u/16273360?v=4","gravatar_id":"","url":"https://api.github.com/users/sbezverk","html_url":"https://github.com/sbezverk","followers_url":"https://api.github.com/users/sbezverk/followers","following_url":"https://api.github.com/users/sbezverk/following{/other_user}","gists_url":"https://api.github.com/users/sbezverk/gists{/gist_id}","starred_url":"https://api.github.com/users/sbezverk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbezverk/subscriptions","organizations_url":"https://api.github.com/users/sbezverk/orgs","repos_url":"https://api.github.com/users/sbezverk/repos","events_url":"https://api.github.com/users/sbezverk/events{/privacy}","received_events_url":"https://api.github.com/users/sbezverk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbezverk/drivers","description":"Example CSI Drivers","fork":true,"url":"https://api.github.com/repos/sbezverk/drivers","forks_url":"https://api.github.com/repos/sbezverk/drivers/forks","keys_url":"https://api.github.com/repos/sbezverk/drivers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbezverk/drivers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbezverk/drivers/teams","hooks_url":"https://api.github.com/repos/sbezverk/drivers/hooks","issue_events_url":"https://api.github.com/repos/sbezverk/drivers/issues/events{/number}","events_url":"https://api.github.com/repos/sbezverk/drivers/events","assignees_url":"https://api.github.com/repos/sbezverk/drivers/assignees{/user}","branches_url":"https://api.github.com/repos/sbezverk/drivers/branches{/branch}","tags_url":"https://api.github.com/repos/sbezverk/drivers/tags","blobs_url":"https://api.github.com/repos/sbezverk/drivers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbezverk/drivers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbezverk/drivers/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbezverk/drivers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbezverk/drivers/statuses/{sha}","languages_url":"https://api.github.com/repos/sbezverk/drivers/languages","stargazers_url":"https://api.github.com/repos/sbezverk/drivers/stargazers","contributors_url":"https://api.github.com/repos/sbezverk/drivers/contributors","subscribers_url":"https://api.github.com/repos/sbezverk/drivers/subscribers","subscription_url":"https://api.github.com/repos/sbezverk/drivers/subscription","commits_url":"https://api.github.com/repos/sbezverk/drivers/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbezverk/drivers/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbezverk/drivers/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbezverk/drivers/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbezverk/drivers/contents/{+path}","compare_url":"https://api.github.com/repos/sbezverk/drivers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbezverk/drivers/merges","archive_url":"https://api.github.com/repos/sbezverk/drivers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbezverk/drivers/downloads","issues_url":"https://api.github.com/repos/sbezverk/drivers/issues{/number}","pulls_url":"https://api.github.com/repos/sbezverk/drivers/pulls{/number}","milestones_url":"https://api.github.com/repos/sbezverk/drivers/milestones{/number}","notifications_url":"https://api.github.com/repos/sbezverk/drivers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbezverk/drivers/labels{/name}","releases_url":"https://api.github.com/repos/sbezverk/drivers/releases{/id}","deployments_url":"https://api.github.com/repos/sbezverk/drivers/deployments","created_at":"2018-01-06T05:23:07Z","updated_at":"2018-01-06T05:23:09Z","pushed_at":"2018-03-04T15:11:56Z","git_url":"git://github.com/sbezverk/drivers.git","ssh_url":"git@github.com:sbezverk/drivers.git","clone_url":"https://github.com/sbezverk/drivers.git","svn_url":"https://github.com/sbezverk/drivers","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-csi:master","ref":"master","sha":"b76dcb29608dfc445706dd0f273a75f01f4cc03b","user":{"login":"kubernetes-csi","id":33050221,"avatar_url":"https://avatars0.githubusercontent.com/u/33050221?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-csi","html_url":"https://github.com/kubernetes-csi","followers_url":"https://api.github.com/users/kubernetes-csi/followers","following_url":"https://api.github.com/users/kubernetes-csi/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-csi/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-csi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-csi/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-csi/orgs","repos_url":"https://api.github.com/users/kubernetes-csi/repos","events_url":"https://api.github.com/users/kubernetes-csi/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-csi/received_events","type":"Organization","site_admin":false},"repo":{"id":110882698,"name":"drivers","full_name":"kubernetes-csi/drivers","owner":{"login":"kubernetes-csi","id":33050221,"avatar_url":"https://avatars0.githubusercontent.com/u/33050221?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-csi","html_url":"https://github.com/kubernetes-csi","followers_url":"https://api.github.com/users/kubernetes-csi/followers","following_url":"https://api.github.com/users/kubernetes-csi/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-csi/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-csi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-csi/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-csi/orgs","repos_url":"https://api.github.com/users/kubernetes-csi/repos","events_url":"https://api.github.com/users/kubernetes-csi/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-csi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-csi/drivers","description":"Example CSI Drivers","fork":false,"url":"https://api.github.com/repos/kubernetes-csi/drivers","forks_url":"https://api.github.com/repos/kubernetes-csi/drivers/forks","keys_url":"https://api.github.com/repos/kubernetes-csi/drivers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-csi/drivers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-csi/drivers/teams","hooks_url":"https://api.github.com/repos/kubernetes-csi/drivers/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-csi/drivers/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-csi/drivers/events","assignees_url":"https://api.github.com/repos/kubernetes-csi/drivers/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-csi/drivers/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-csi/drivers/tags","blobs_url":"https://api.github.com/repos/kubernetes-csi/drivers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-csi/drivers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-csi/drivers/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-csi/drivers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-csi/drivers/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-csi/drivers/languages","stargazers_url":"https://api.github.com/repos/kubernetes-csi/drivers/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-csi/drivers/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-csi/drivers/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-csi/drivers/subscription","commits_url":"https://api.github.com/repos/kubernetes-csi/drivers/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-csi/drivers/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-csi/drivers/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-csi/drivers/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-csi/drivers/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-csi/drivers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-csi/drivers/merges","archive_url":"https://api.github.com/repos/kubernetes-csi/drivers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-csi/drivers/downloads","issues_url":"https://api.github.com/repos/kubernetes-csi/drivers/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-csi/drivers/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-csi/drivers/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-csi/drivers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-csi/drivers/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-csi/drivers/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-csi/drivers/deployments","created_at":"2017-11-15T20:25:25Z","updated_at":"2018-02-28T13:08:09Z","pushed_at":"2018-03-04T15:11:57Z","git_url":"git://github.com/kubernetes-csi/drivers.git","ssh_url":"git@github.com:kubernetes-csi/drivers.git","clone_url":"https://github.com/kubernetes-csi/drivers.git","svn_url":"https://github.com/kubernetes-csi/drivers","homepage":"","size":141,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":23,"open_issues":14,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56"},"html":{"href":"https://github.com/kubernetes-csi/drivers/pull/56"},"issue":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/issues/56"},"comments":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-csi/drivers/statuses/acc7257e15ed314731225b5777caf96bd9e99227"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rootfs"}}