{"action":"created","comment":{"url":"https://api.github.com/repos/maps4print/azul/pulls/comments/219670526","pull_request_review_id":157908832,"id":219670526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY3MDUyNg==","diff_hunk":"@@ -291,16 +269,31 @@ pub enum CssParsingError<'a> {\n     UnsupportedCssKey(&'a str, &'a str),\n }\n \n-impl_from!(CssBorderParseError, CssParsingError::CssBorderParseError);\n-impl_from!(CssShadowParseError, CssParsingError::CssShadowParseError);\n-impl_from!(CssColorParseError, CssParsingError::CssColorParseError);\n-impl_from!(InvalidValueErr, CssParsingError::InvalidValueErr);\n-impl_from!(PixelParseError, CssParsingError::PixelParseError);\n-impl_from!(CssImageParseError, CssParsingError::CssImageParseError);\n-impl_from!(CssFontFamilyParseError, CssParsingError::CssFontFamilyParseError);\n-impl_from!(CssBackgroundParseError, CssParsingError::CssBackgroundParseError);\n-impl_from!(CssBorderRadiusParseError, CssParsingError::CssBorderRadiusParseError);\n-impl_from!(LayoutPaddingParseError, CssParsingError::PaddingParseError);\n+impl_display!{ CssParsingError<'a>, {\n+    CssBorderRadiusParseError(e) => format!(\"Invalid border-radius: {}\", e),\n+    CssBorderParseError(e) => format!(\"{}\", e),\n+    CssShadowParseError(e) => format!(\"Invalid shadow: \\\"{}\\\"\", e),","path":"src/css_parser.rs","position":112,"original_position":112,"commit_id":"ce1e6f4f66030e887d06e57516d56760a1612e68","original_commit_id":"13e08b89e2444632de4ae03ba28d27575e45abeb","user":{"login":"fschutt","id":12084016,"node_id":"MDQ6VXNlcjEyMDg0MDE2","avatar_url":"https://avatars1.githubusercontent.com/u/12084016?v=4","gravatar_id":"","url":"https://api.github.com/users/fschutt","html_url":"https://github.com/fschutt","followers_url":"https://api.github.com/users/fschutt/followers","following_url":"https://api.github.com/users/fschutt/following{/other_user}","gists_url":"https://api.github.com/users/fschutt/gists{/gist_id}","starred_url":"https://api.github.com/users/fschutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fschutt/subscriptions","organizations_url":"https://api.github.com/users/fschutt/orgs","repos_url":"https://api.github.com/users/fschutt/repos","events_url":"https://api.github.com/users/fschutt/events{/privacy}","received_events_url":"https://api.github.com/users/fschutt/received_events","type":"User","site_admin":false},"body":"Then do a `Invalid border property` on the `CssBorderParseError`. Otherwise, a border parse error will just display \"Too many values\" - which isn't helpful, since you don't know that it happened when parsing a `border` property.\r\n\r\nYeah, I sometimes reused errors because the parsing functions were essentially the same.","created_at":"2018-09-22T12:40:55Z","updated_at":"2018-09-22T12:40:56Z","html_url":"https://github.com/maps4print/azul/pull/17#discussion_r219670526","pull_request_url":"https://api.github.com/repos/maps4print/azul/pulls/17","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/maps4print/azul/pulls/comments/219670526"},"html":{"href":"https://github.com/maps4print/azul/pull/17#discussion_r219670526"},"pull_request":{"href":"https://api.github.com/repos/maps4print/azul/pulls/17"}},"in_reply_to_id":219664948},"pull_request":{"url":"https://api.github.com/repos/maps4print/azul/pulls/17","id":217405815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDA1ODE1","html_url":"https://github.com/maps4print/azul/pull/17","diff_url":"https://github.com/maps4print/azul/pull/17.diff","patch_url":"https://github.com/maps4print/azul/pull/17.patch","issue_url":"https://api.github.com/repos/maps4print/azul/issues/17","number":17,"state":"open","locked":false,"title":"Add a top-level Azul error type","user":{"login":"Xoronic","id":30958364,"node_id":"MDQ6VXNlcjMwOTU4MzY0","avatar_url":"https://avatars0.githubusercontent.com/u/30958364?v=4","gravatar_id":"","url":"https://api.github.com/users/Xoronic","html_url":"https://github.com/Xoronic","followers_url":"https://api.github.com/users/Xoronic/followers","following_url":"https://api.github.com/users/Xoronic/following{/other_user}","gists_url":"https://api.github.com/users/Xoronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xoronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xoronic/subscriptions","organizations_url":"https://api.github.com/users/Xoronic/orgs","repos_url":"https://api.github.com/users/Xoronic/repos","events_url":"https://api.github.com/users/Xoronic/events{/privacy}","received_events_url":"https://api.github.com/users/Xoronic/received_events","type":"User","site_admin":false},"body":"closes #13 \r\n\r\n## Todo\r\n - [x] Put macro's together in a single `macros.rs` file\r\n - [x] Create a top-level Error which implements `From` for all other `azul`-errors (except for the runtime error)\r\n - [x] Implement `Display`for all of `azul`s errors\r\n - [x] debug print to a display print here: https://github.com/Xoronic/azul/blob/errors/src/css.rs#L224 - so that people get the proper, nicely formatted error instead of the debug information during hot-reloading.\r\n - [x] Add the optional ImageError back in, which I removed while resolving merge-conflicts (added in commit https://github.com/maps4print/azul/commit/4a44cf46a60fe0edbc13c1b66f022f8a9547d6af#diff-b4aea3e418ccdb71239b96952d9cddb6)","created_at":"2018-09-21T21:26:43Z","updated_at":"2018-09-22T12:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5679c1f636355f520c2805e3dcb70c33cdbddaaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maps4print/azul/pulls/17/commits","review_comments_url":"https://api.github.com/repos/maps4print/azul/pulls/17/comments","review_comment_url":"https://api.github.com/repos/maps4print/azul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maps4print/azul/issues/17/comments","statuses_url":"https://api.github.com/repos/maps4print/azul/statuses/ce1e6f4f66030e887d06e57516d56760a1612e68","head":{"label":"Xoronic:errors","ref":"errors","sha":"ce1e6f4f66030e887d06e57516d56760a1612e68","user":{"login":"Xoronic","id":30958364,"node_id":"MDQ6VXNlcjMwOTU4MzY0","avatar_url":"https://avatars0.githubusercontent.com/u/30958364?v=4","gravatar_id":"","url":"https://api.github.com/users/Xoronic","html_url":"https://github.com/Xoronic","followers_url":"https://api.github.com/users/Xoronic/followers","following_url":"https://api.github.com/users/Xoronic/following{/other_user}","gists_url":"https://api.github.com/users/Xoronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xoronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xoronic/subscriptions","organizations_url":"https://api.github.com/users/Xoronic/orgs","repos_url":"https://api.github.com/users/Xoronic/repos","events_url":"https://api.github.com/users/Xoronic/events{/privacy}","received_events_url":"https://api.github.com/users/Xoronic/received_events","type":"User","site_admin":false},"repo":{"id":148919307,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg5MTkzMDc=","name":"azul","full_name":"Xoronic/azul","private":false,"owner":{"login":"Xoronic","id":30958364,"node_id":"MDQ6VXNlcjMwOTU4MzY0","avatar_url":"https://avatars0.githubusercontent.com/u/30958364?v=4","gravatar_id":"","url":"https://api.github.com/users/Xoronic","html_url":"https://github.com/Xoronic","followers_url":"https://api.github.com/users/Xoronic/followers","following_url":"https://api.github.com/users/Xoronic/following{/other_user}","gists_url":"https://api.github.com/users/Xoronic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xoronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xoronic/subscriptions","organizations_url":"https://api.github.com/users/Xoronic/orgs","repos_url":"https://api.github.com/users/Xoronic/repos","events_url":"https://api.github.com/users/Xoronic/events{/privacy}","received_events_url":"https://api.github.com/users/Xoronic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Xoronic/azul","description":"Desktop GUI Framework","fork":true,"url":"https://api.github.com/repos/Xoronic/azul","forks_url":"https://api.github.com/repos/Xoronic/azul/forks","keys_url":"https://api.github.com/repos/Xoronic/azul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xoronic/azul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xoronic/azul/teams","hooks_url":"https://api.github.com/repos/Xoronic/azul/hooks","issue_events_url":"https://api.github.com/repos/Xoronic/azul/issues/events{/number}","events_url":"https://api.github.com/repos/Xoronic/azul/events","assignees_url":"https://api.github.com/repos/Xoronic/azul/assignees{/user}","branches_url":"https://api.github.com/repos/Xoronic/azul/branches{/branch}","tags_url":"https://api.github.com/repos/Xoronic/azul/tags","blobs_url":"https://api.github.com/repos/Xoronic/azul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xoronic/azul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xoronic/azul/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xoronic/azul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xoronic/azul/statuses/{sha}","languages_url":"https://api.github.com/repos/Xoronic/azul/languages","stargazers_url":"https://api.github.com/repos/Xoronic/azul/stargazers","contributors_url":"https://api.github.com/repos/Xoronic/azul/contributors","subscribers_url":"https://api.github.com/repos/Xoronic/azul/subscribers","subscription_url":"https://api.github.com/repos/Xoronic/azul/subscription","commits_url":"https://api.github.com/repos/Xoronic/azul/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xoronic/azul/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xoronic/azul/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xoronic/azul/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xoronic/azul/contents/{+path}","compare_url":"https://api.github.com/repos/Xoronic/azul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xoronic/azul/merges","archive_url":"https://api.github.com/repos/Xoronic/azul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xoronic/azul/downloads","issues_url":"https://api.github.com/repos/Xoronic/azul/issues{/number}","pulls_url":"https://api.github.com/repos/Xoronic/azul/pulls{/number}","milestones_url":"https://api.github.com/repos/Xoronic/azul/milestones{/number}","notifications_url":"https://api.github.com/repos/Xoronic/azul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xoronic/azul/labels{/name}","releases_url":"https://api.github.com/repos/Xoronic/azul/releases{/id}","deployments_url":"https://api.github.com/repos/Xoronic/azul/deployments","created_at":"2018-09-15T16:27:38Z","updated_at":"2018-09-15T16:27:40Z","pushed_at":"2018-09-22T12:37:45Z","git_url":"git://github.com/Xoronic/azul.git","ssh_url":"git@github.com:Xoronic/azul.git","clone_url":"https://github.com/Xoronic/azul.git","svn_url":"https://github.com/Xoronic/azul","homepage":"https://azul.rs/","size":2725,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maps4print:master","ref":"master","sha":"56d6c2bac9b752264871afab1119a34365aceacb","user":{"login":"maps4print","id":35248711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MjQ4NzEx","avatar_url":"https://avatars1.githubusercontent.com/u/35248711?v=4","gravatar_id":"","url":"https://api.github.com/users/maps4print","html_url":"https://github.com/maps4print","followers_url":"https://api.github.com/users/maps4print/followers","following_url":"https://api.github.com/users/maps4print/following{/other_user}","gists_url":"https://api.github.com/users/maps4print/gists{/gist_id}","starred_url":"https://api.github.com/users/maps4print/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maps4print/subscriptions","organizations_url":"https://api.github.com/users/maps4print/orgs","repos_url":"https://api.github.com/users/maps4print/repos","events_url":"https://api.github.com/users/maps4print/events{/privacy}","received_events_url":"https://api.github.com/users/maps4print/received_events","type":"Organization","site_admin":false},"repo":{"id":117740918,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3NDA5MTg=","name":"azul","full_name":"maps4print/azul","private":false,"owner":{"login":"maps4print","id":35248711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MjQ4NzEx","avatar_url":"https://avatars1.githubusercontent.com/u/35248711?v=4","gravatar_id":"","url":"https://api.github.com/users/maps4print","html_url":"https://github.com/maps4print","followers_url":"https://api.github.com/users/maps4print/followers","following_url":"https://api.github.com/users/maps4print/following{/other_user}","gists_url":"https://api.github.com/users/maps4print/gists{/gist_id}","starred_url":"https://api.github.com/users/maps4print/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maps4print/subscriptions","organizations_url":"https://api.github.com/users/maps4print/orgs","repos_url":"https://api.github.com/users/maps4print/repos","events_url":"https://api.github.com/users/maps4print/events{/privacy}","received_events_url":"https://api.github.com/users/maps4print/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/maps4print/azul","description":"Desktop GUI Framework","fork":false,"url":"https://api.github.com/repos/maps4print/azul","forks_url":"https://api.github.com/repos/maps4print/azul/forks","keys_url":"https://api.github.com/repos/maps4print/azul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maps4print/azul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maps4print/azul/teams","hooks_url":"https://api.github.com/repos/maps4print/azul/hooks","issue_events_url":"https://api.github.com/repos/maps4print/azul/issues/events{/number}","events_url":"https://api.github.com/repos/maps4print/azul/events","assignees_url":"https://api.github.com/repos/maps4print/azul/assignees{/user}","branches_url":"https://api.github.com/repos/maps4print/azul/branches{/branch}","tags_url":"https://api.github.com/repos/maps4print/azul/tags","blobs_url":"https://api.github.com/repos/maps4print/azul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maps4print/azul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maps4print/azul/git/refs{/sha}","trees_url":"https://api.github.com/repos/maps4print/azul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maps4print/azul/statuses/{sha}","languages_url":"https://api.github.com/repos/maps4print/azul/languages","stargazers_url":"https://api.github.com/repos/maps4print/azul/stargazers","contributors_url":"https://api.github.com/repos/maps4print/azul/contributors","subscribers_url":"https://api.github.com/repos/maps4print/azul/subscribers","subscription_url":"https://api.github.com/repos/maps4print/azul/subscription","commits_url":"https://api.github.com/repos/maps4print/azul/commits{/sha}","git_commits_url":"https://api.github.com/repos/maps4print/azul/git/commits{/sha}","comments_url":"https://api.github.com/repos/maps4print/azul/comments{/number}","issue_comment_url":"https://api.github.com/repos/maps4print/azul/issues/comments{/number}","contents_url":"https://api.github.com/repos/maps4print/azul/contents/{+path}","compare_url":"https://api.github.com/repos/maps4print/azul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maps4print/azul/merges","archive_url":"https://api.github.com/repos/maps4print/azul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maps4print/azul/downloads","issues_url":"https://api.github.com/repos/maps4print/azul/issues{/number}","pulls_url":"https://api.github.com/repos/maps4print/azul/pulls{/number}","milestones_url":"https://api.github.com/repos/maps4print/azul/milestones{/number}","notifications_url":"https://api.github.com/repos/maps4print/azul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maps4print/azul/labels{/name}","releases_url":"https://api.github.com/repos/maps4print/azul/releases{/id}","deployments_url":"https://api.github.com/repos/maps4print/azul/deployments","created_at":"2018-01-16T20:57:07Z","updated_at":"2018-09-22T02:08:04Z","pushed_at":"2018-09-22T12:37:46Z","git_url":"git://github.com/maps4print/azul.git","ssh_url":"git@github.com:maps4print/azul.git","clone_url":"https://github.com/maps4print/azul.git","svn_url":"https://github.com/maps4print/azul","homepage":"https://azul.rs/","size":2648,"stargazers_count":362,"watchers_count":362,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maps4print/azul/pulls/17"},"html":{"href":"https://github.com/maps4print/azul/pull/17"},"issue":{"href":"https://api.github.com/repos/maps4print/azul/issues/17"},"comments":{"href":"https://api.github.com/repos/maps4print/azul/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/maps4print/azul/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/maps4print/azul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maps4print/azul/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/maps4print/azul/statuses/ce1e6f4f66030e887d06e57516d56760a1612e68"}},"author_association":"NONE"}}
{"actor":{"display_login":"fschutt"}}