{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/174623867","pull_request_review_id":104015112,"id":174623867,"diff_hunk":"@@ -60,8 +59,7 @@ public class NewAzureContainerGroupCommand : ContainerInstanceCmdletBase\n         public string Image { get; set; }\n \n         [Parameter(\n-            Mandatory = true,\n-            ParameterSetName = CreateContainerGroupWithRegistryParamSet,","path":"src/ResourceManager/ContainerInstance/Commands.ContainerInstance/Commands/NewAzureContainerGroupCommand.cs","position":13,"original_position":13,"commit_id":"920e5ba684ccdbce1ae2221cd4c63c382fe795fd","original_commit_id":"920e5ba684ccdbce1ae2221cd4c63c382fe795fd","user":{"login":"maddieclayton","id":8137559,"avatar_url":"https://avatars1.githubusercontent.com/u/8137559?v=4","gravatar_id":"","url":"https://api.github.com/users/maddieclayton","html_url":"https://github.com/maddieclayton","followers_url":"https://api.github.com/users/maddieclayton/followers","following_url":"https://api.github.com/users/maddieclayton/following{/other_user}","gists_url":"https://api.github.com/users/maddieclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/maddieclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddieclayton/subscriptions","organizations_url":"https://api.github.com/users/maddieclayton/orgs","repos_url":"https://api.github.com/users/maddieclayton/repos","events_url":"https://api.github.com/users/maddieclayton/events{/privacy}","received_events_url":"https://api.github.com/users/maddieclayton/received_events","type":"User","site_admin":false},"body":"Okay, these should be your parameter sets then:\r\n\r\nPS1: All parameters that don't need validation (don't include FileVolume or Registry) - all parameters are optional and this is the default\r\nPS2: All parameters that don't need validation, and the two registry parameters as required.\r\nPS3: All parameters that don't need validation, and the FileVolume parameters as required.\r\nPS4: All parameters that don't need validation, and both the registry and FileVolume parameters as required.","created_at":"2018-03-14T22:02:28Z","updated_at":"2018-03-14T22:02:28Z","html_url":"https://github.com/Azure/azure-powershell/pull/5689#discussion_r174623867","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/174623867"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/5689#discussion_r174623867"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689"}},"in_reply_to_id":173951321},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689","id":173323125,"html_url":"https://github.com/Azure/azure-powershell/pull/5689","diff_url":"https://github.com/Azure/azure-powershell/pull/5689.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/5689.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/5689","number":5689,"state":"open","locked":false,"title":"Fix for https://github.com/Azure/azure-powershell/issues/5506","user":{"login":"yolo3301","id":14087829,"avatar_url":"https://avatars1.githubusercontent.com/u/14087829?v=4","gravatar_id":"","url":"https://api.github.com/users/yolo3301","html_url":"https://github.com/yolo3301","followers_url":"https://api.github.com/users/yolo3301/followers","following_url":"https://api.github.com/users/yolo3301/following{/other_user}","gists_url":"https://api.github.com/users/yolo3301/gists{/gist_id}","starred_url":"https://api.github.com/users/yolo3301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yolo3301/subscriptions","organizations_url":"https://api.github.com/users/yolo3301/orgs","repos_url":"https://api.github.com/users/yolo3301/repos","events_url":"https://api.github.com/users/yolo3301/events{/privacy}","received_events_url":"https://api.github.com/users/yolo3301/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n\r\nFix https://github.com/Azure/azure-powershell/issues/5506\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#making-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md)\r\n- [x] The title of the PR is clear and informative\r\n- [ ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/preview/CONTRIBUTING.md#updating-the-change-log)\r\n- [x] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-definition.md)\r\n- [ ] If applicable, the changes made in the PR have proper test coverage\r\n- [ ] For public API changes to cmdlets:\r\n    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr)\r\n    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/preview/documentation/development-docs/help-generation.md)","created_at":"2018-03-07T00:41:24Z","updated_at":"2018-03-14T22:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40d00f0f25afab3411187f8bdb54f44332141ac8","assignee":{"login":"yolo3301","id":14087829,"avatar_url":"https://avatars1.githubusercontent.com/u/14087829?v=4","gravatar_id":"","url":"https://api.github.com/users/yolo3301","html_url":"https://github.com/yolo3301","followers_url":"https://api.github.com/users/yolo3301/followers","following_url":"https://api.github.com/users/yolo3301/following{/other_user}","gists_url":"https://api.github.com/users/yolo3301/gists{/gist_id}","starred_url":"https://api.github.com/users/yolo3301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yolo3301/subscriptions","organizations_url":"https://api.github.com/users/yolo3301/orgs","repos_url":"https://api.github.com/users/yolo3301/repos","events_url":"https://api.github.com/users/yolo3301/events{/privacy}","received_events_url":"https://api.github.com/users/yolo3301/received_events","type":"User","site_admin":false},"assignees":[{"login":"yolo3301","id":14087829,"avatar_url":"https://avatars1.githubusercontent.com/u/14087829?v=4","gravatar_id":"","url":"https://api.github.com/users/yolo3301","html_url":"https://github.com/yolo3301","followers_url":"https://api.github.com/users/yolo3301/followers","following_url":"https://api.github.com/users/yolo3301/following{/other_user}","gists_url":"https://api.github.com/users/yolo3301/gists{/gist_id}","starred_url":"https://api.github.com/users/yolo3301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yolo3301/subscriptions","organizations_url":"https://api.github.com/users/yolo3301/orgs","repos_url":"https://api.github.com/users/yolo3301/repos","events_url":"https://api.github.com/users/yolo3301/events{/privacy}","received_events_url":"https://api.github.com/users/yolo3301/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":556235223,"url":"https://api.github.com/repos/Azure/azure-powershell/labels/needs-revision","name":"needs-revision","color":"fd8c00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/5689/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/920e5ba684ccdbce1ae2221cd4c63c382fe795fd","head":{"label":"yolo3301:fix_reg","ref":"fix_reg","sha":"920e5ba684ccdbce1ae2221cd4c63c382fe795fd","user":{"login":"yolo3301","id":14087829,"avatar_url":"https://avatars1.githubusercontent.com/u/14087829?v=4","gravatar_id":"","url":"https://api.github.com/users/yolo3301","html_url":"https://github.com/yolo3301","followers_url":"https://api.github.com/users/yolo3301/followers","following_url":"https://api.github.com/users/yolo3301/following{/other_user}","gists_url":"https://api.github.com/users/yolo3301/gists{/gist_id}","starred_url":"https://api.github.com/users/yolo3301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yolo3301/subscriptions","organizations_url":"https://api.github.com/users/yolo3301/orgs","repos_url":"https://api.github.com/users/yolo3301/repos","events_url":"https://api.github.com/users/yolo3301/events{/privacy}","received_events_url":"https://api.github.com/users/yolo3301/received_events","type":"User","site_admin":false},"repo":{"id":124151767,"name":"azure-powershell","full_name":"yolo3301/azure-powershell","owner":{"login":"yolo3301","id":14087829,"avatar_url":"https://avatars1.githubusercontent.com/u/14087829?v=4","gravatar_id":"","url":"https://api.github.com/users/yolo3301","html_url":"https://github.com/yolo3301","followers_url":"https://api.github.com/users/yolo3301/followers","following_url":"https://api.github.com/users/yolo3301/following{/other_user}","gists_url":"https://api.github.com/users/yolo3301/gists{/gist_id}","starred_url":"https://api.github.com/users/yolo3301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yolo3301/subscriptions","organizations_url":"https://api.github.com/users/yolo3301/orgs","repos_url":"https://api.github.com/users/yolo3301/repos","events_url":"https://api.github.com/users/yolo3301/events{/privacy}","received_events_url":"https://api.github.com/users/yolo3301/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yolo3301/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/yolo3301/azure-powershell","forks_url":"https://api.github.com/repos/yolo3301/azure-powershell/forks","keys_url":"https://api.github.com/repos/yolo3301/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yolo3301/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yolo3301/azure-powershell/teams","hooks_url":"https://api.github.com/repos/yolo3301/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/yolo3301/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/yolo3301/azure-powershell/events","assignees_url":"https://api.github.com/repos/yolo3301/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/yolo3301/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/yolo3301/azure-powershell/tags","blobs_url":"https://api.github.com/repos/yolo3301/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yolo3301/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yolo3301/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/yolo3301/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yolo3301/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/yolo3301/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/yolo3301/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/yolo3301/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/yolo3301/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/yolo3301/azure-powershell/subscription","commits_url":"https://api.github.com/repos/yolo3301/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/yolo3301/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/yolo3301/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/yolo3301/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/yolo3301/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/yolo3301/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yolo3301/azure-powershell/merges","archive_url":"https://api.github.com/repos/yolo3301/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yolo3301/azure-powershell/downloads","issues_url":"https://api.github.com/repos/yolo3301/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/yolo3301/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/yolo3301/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/yolo3301/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yolo3301/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/yolo3301/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/yolo3301/azure-powershell/deployments","created_at":"2018-03-06T23:33:35Z","updated_at":"2018-03-06T23:34:49Z","pushed_at":"2018-03-12T21:19:32Z","git_url":"git://github.com/yolo3301/azure-powershell.git","ssh_url":"git@github.com:yolo3301/azure-powershell.git","clone_url":"https://github.com/yolo3301/azure-powershell.git","svn_url":"https://github.com/yolo3301/azure-powershell","homepage":null,"size":374523,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"preview"}},"base":{"label":"Azure:preview","ref":"preview","sha":"fc5b69844165de82e7aff5594112659451ed7e65","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2018-03-14T17:13:51Z","pushed_at":"2018-03-14T21:20:08Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":375289,"stargazers_count":943,"watchers_count":943,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":984,"mirror_url":null,"archived":false,"open_issues_count":649,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":984,"open_issues":649,"watchers":943,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/5689"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/5689"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/5689/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/5689/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/920e5ba684ccdbce1ae2221cd4c63c382fe795fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maddieclayton"}}