{"action":"created","issue":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6329","repository_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6329/labels{/name}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6329/comments","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6329/events","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/issues/6329","id":359274956,"node_id":"MDU6SXNzdWUzNTkyNzQ5NTY=","number":6329,"title":"Layer: Capture events leak out of Layer when !eventBubblingEnabled","user":{"login":"jspurlin","id":7033561,"node_id":"MDQ6VXNlcjcwMzM1NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7033561?v=4","gravatar_id":"","url":"https://api.github.com/users/jspurlin","html_url":"https://github.com/jspurlin","followers_url":"https://api.github.com/users/jspurlin/followers","following_url":"https://api.github.com/users/jspurlin/following{/other_user}","gists_url":"https://api.github.com/users/jspurlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jspurlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspurlin/subscriptions","organizations_url":"https://api.github.com/users/jspurlin/orgs","repos_url":"https://api.github.com/users/jspurlin/repos","events_url":"https://api.github.com/users/jspurlin/events{/privacy}","received_events_url":"https://api.github.com/users/jspurlin/received_events","type":"User","site_admin":false},"labels":[{"id":412707026,"node_id":"MDU6TGFiZWw0MTI3MDcwMjY=","url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels/Area:%20Accessibility","name":"Area: Accessibility","color":"1d76db","default":false},{"id":388450675,"node_id":"MDU6TGFiZWwzODg0NTA2NzU=","url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels/Type:%20Bug%20:bug:","name":"Type: Bug :bug:","color":"ee0701","default":false}],"state":"closed","locked":false,"assignee":{"login":"JasonGore","id":26070760,"node_id":"MDQ6VXNlcjI2MDcwNzYw","avatar_url":"https://avatars2.githubusercontent.com/u/26070760?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGore","html_url":"https://github.com/JasonGore","followers_url":"https://api.github.com/users/JasonGore/followers","following_url":"https://api.github.com/users/JasonGore/following{/other_user}","gists_url":"https://api.github.com/users/JasonGore/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGore/subscriptions","organizations_url":"https://api.github.com/users/JasonGore/orgs","repos_url":"https://api.github.com/users/JasonGore/repos","events_url":"https://api.github.com/users/JasonGore/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGore/received_events","type":"User","site_admin":false},"assignees":[{"login":"JasonGore","id":26070760,"node_id":"MDQ6VXNlcjI2MDcwNzYw","avatar_url":"https://avatars2.githubusercontent.com/u/26070760?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGore","html_url":"https://github.com/JasonGore","followers_url":"https://api.github.com/users/JasonGore/followers","following_url":"https://api.github.com/users/JasonGore/following{/other_user}","gists_url":"https://api.github.com/users/JasonGore/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGore/subscriptions","organizations_url":"https://api.github.com/users/JasonGore/orgs","repos_url":"https://api.github.com/users/JasonGore/repos","events_url":"https://api.github.com/users/JasonGore/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGore/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-12T00:49:03Z","updated_at":"2018-09-12T23:35:38Z","closed_at":"2018-09-12T23:35:38Z","author_association":"COLLABORATOR","body":"- __Package version(s)__: 6.66.0\r\n \r\n#### Priorities and help requested:\r\nRequested priority: (High) \r\n \r\nProducts/sites affected: office-online, really anyone who has splitButtons\r\n \r\n#### Describe the issue: \r\nAfter the Layer change to use Portals, any capture handler will now be called if something inside of the portal fires an event (e.g. the capture handlers are getting higher priority than the  in the filterEvent handlers in dispatchListeners array inside of executeDispatchesInOrder in react).\r\n\r\nHere simple repro steps for splitButtons (codepen: https://codepen.io/jspurlin/pen/eLMLYm):\r\n1. Open the ContextualMenu of the splitButton (via mouse or keyboard)\r\n2. Attempt to arrow around controls\r\n\r\n \r\n#### Actual behavior:\r\n Focus is still on the splitButton\r\n \r\n#### Expected behavior:\r\n Focus to be in the ContextualMenu\r\n\r\n\r\n### Additional Notes:\r\nThis breaks accessibility for splitButtons, but the larger issues is now any capture handlers will fire, potentially resulting in unexpected/broken behavior\r\n\r\nNot sure the best approach to keep any of the \"parent\" capture events from firing when Portals are involved... \r\n"},"comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments/420832979","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/issues/6329#issuecomment-420832979","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6329","id":420832979,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDgzMjk3OQ==","user":{"login":"jspurlin","id":7033561,"node_id":"MDQ6VXNlcjcwMzM1NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7033561?v=4","gravatar_id":"","url":"https://api.github.com/users/jspurlin","html_url":"https://github.com/jspurlin","followers_url":"https://api.github.com/users/jspurlin/followers","following_url":"https://api.github.com/users/jspurlin/following{/other_user}","gists_url":"https://api.github.com/users/jspurlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jspurlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspurlin/subscriptions","organizations_url":"https://api.github.com/users/jspurlin/orgs","repos_url":"https://api.github.com/users/jspurlin/repos","events_url":"https://api.github.com/users/jspurlin/events{/privacy}","received_events_url":"https://api.github.com/users/jspurlin/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T23:35:38Z","updated_at":"2018-09-12T23:35:38Z","author_association":"COLLABORATOR","body":"@JasonGore , thanks for doing a pass and while there may be regressions in consumers implementations (if they are using capture handlers) the out-of-box components have not regressed.\r\n\r\nI'm going to go ahead and close this. If it crops up as a larger issue later it can be readdressed from a potential \"general fix\" perspective"}}
{"actor":{"display_login":"jspurlin"}}