{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/comments/237461496","pull_request_review_id":179762934,"id":237461496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ2MTQ5Ng==","diff_hunk":"@@ -27,3 +27,14 @@ export {\n } from './utils/setup-global-error-listener';\n export { selectUserId, selectProjectKeyFromUrl } from './utils';\n export { default as AsyncChunkLoader } from './components/async-chunk-loader';\n+\n+/**\n+ * NOTE:\n+ *    These are library re-exports which are shared between app-kit and\n+ *    MC apps. Not having them re-exported here often leads to bundling\n+ *    them twice given app-kit and any MC app require different versions.\n+ *    Something they never should anyways and causes breakage.\n+ *\n+ *    More information can be found here: https://github.com/commercetools/fe-chapter-notes/issues/61","path":"packages/application-shell/src/index.js","position":12,"original_position":12,"commit_id":"89ef7055236f861ec8cbf22150868bec6cffa00f","original_commit_id":"89ef7055236f861ec8cbf22150868bec6cffa00f","user":{"login":"tdeekens","id":1877073,"node_id":"MDQ6VXNlcjE4NzcwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1877073?v=4","gravatar_id":"","url":"https://api.github.com/users/tdeekens","html_url":"https://github.com/tdeekens","followers_url":"https://api.github.com/users/tdeekens/followers","following_url":"https://api.github.com/users/tdeekens/following{/other_user}","gists_url":"https://api.github.com/users/tdeekens/gists{/gist_id}","starred_url":"https://api.github.com/users/tdeekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdeekens/subscriptions","organizations_url":"https://api.github.com/users/tdeekens/orgs","repos_url":"https://api.github.com/users/tdeekens/repos","events_url":"https://api.github.com/users/tdeekens/events{/privacy}","received_events_url":"https://api.github.com/users/tdeekens/received_events","type":"User","site_admin":false},"body":"Why not. It will show a 404 anyway. It doesn't contain a ticket number of anything. I wouldn't worry too much about it.","created_at":"2018-11-29T12:09:27Z","updated_at":"2018-11-29T12:09:27Z","html_url":"https://github.com/commercetools/merchant-center-application-kit/pull/144#discussion_r237461496","pull_request_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/comments/237461496"},"html":{"href":"https://github.com/commercetools/merchant-center-application-kit/pull/144#discussion_r237461496"},"pull_request":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144"}},"in_reply_to_id":237460688},"pull_request":{"url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144","id":234225627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjI1NjI3","html_url":"https://github.com/commercetools/merchant-center-application-kit/pull/144","diff_url":"https://github.com/commercetools/merchant-center-application-kit/pull/144.diff","patch_url":"https://github.com/commercetools/merchant-center-application-kit/pull/144.patch","issue_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/144","number":144,"state":"closed","locked":false,"title":"Fix double dependency bundling","user":{"login":"tdeekens","id":1877073,"node_id":"MDQ6VXNlcjE4NzcwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1877073?v=4","gravatar_id":"","url":"https://api.github.com/users/tdeekens","html_url":"https://github.com/tdeekens","followers_url":"https://api.github.com/users/tdeekens/followers","following_url":"https://api.github.com/users/tdeekens/following{/other_user}","gists_url":"https://api.github.com/users/tdeekens/gists{/gist_id}","starred_url":"https://api.github.com/users/tdeekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdeekens/subscriptions","organizations_url":"https://api.github.com/users/tdeekens/orgs","repos_url":"https://api.github.com/users/tdeekens/repos","events_url":"https://api.github.com/users/tdeekens/events{/privacy}","received_events_url":"https://api.github.com/users/tdeekens/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n\r\nThis pull request re-exports crucial dependencies and adds ranges to commonly shared utility deps.\r\n\r\n#### Description\r\n\r\nMore information can be found on an internal chapter issue.\r\n","created_at":"2018-11-28T10:36:48Z","updated_at":"2018-11-29T12:09:27Z","closed_at":"2018-11-28T12:12:12Z","merged_at":"2018-11-28T12:12:12Z","merge_commit_sha":"f11b7fc13b6845d7d715fd9b6193ce46fa5cdbfb","assignee":{"login":"tdeekens","id":1877073,"node_id":"MDQ6VXNlcjE4NzcwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1877073?v=4","gravatar_id":"","url":"https://api.github.com/users/tdeekens","html_url":"https://github.com/tdeekens","followers_url":"https://api.github.com/users/tdeekens/followers","following_url":"https://api.github.com/users/tdeekens/following{/other_user}","gists_url":"https://api.github.com/users/tdeekens/gists{/gist_id}","starred_url":"https://api.github.com/users/tdeekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdeekens/subscriptions","organizations_url":"https://api.github.com/users/tdeekens/orgs","repos_url":"https://api.github.com/users/tdeekens/repos","events_url":"https://api.github.com/users/tdeekens/events{/privacy}","received_events_url":"https://api.github.com/users/tdeekens/received_events","type":"User","site_admin":false},"assignees":[{"login":"tdeekens","id":1877073,"node_id":"MDQ6VXNlcjE4NzcwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1877073?v=4","gravatar_id":"","url":"https://api.github.com/users/tdeekens","html_url":"https://github.com/tdeekens","followers_url":"https://api.github.com/users/tdeekens/followers","following_url":"https://api.github.com/users/tdeekens/following{/other_user}","gists_url":"https://api.github.com/users/tdeekens/gists{/gist_id}","starred_url":"https://api.github.com/users/tdeekens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdeekens/subscriptions","organizations_url":"https://api.github.com/users/tdeekens/orgs","repos_url":"https://api.github.com/users/tdeekens/repos","events_url":"https://api.github.com/users/tdeekens/events{/privacy}","received_events_url":"https://api.github.com/users/tdeekens/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1083802566,"node_id":"MDU6TGFiZWwxMDgzODAyNTY2","url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/labels/%F0%9F%92%85%20Type:%20Enhancement","name":"💅 Type: Enhancement","color":"88fca1","default":false},{"id":1083802562,"node_id":"MDU6TGFiZWwxMDgzODAyNTYy","url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/labels/%F0%9F%99%8F%20Status:%20Dev%20Review","name":"🙏 Status: Dev Review","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144/commits","review_comments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144/comments","review_comment_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/144/comments","statuses_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/statuses/89ef7055236f861ec8cbf22150868bec6cffa00f","head":{"label":"commercetools:feat/fix-double-dependency-bundling","ref":"feat/fix-double-dependency-bundling","sha":"89ef7055236f861ec8cbf22150868bec6cffa00f","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":152089521,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwODk1MjE=","name":"merchant-center-application-kit","full_name":"commercetools/merchant-center-application-kit","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/merchant-center-application-kit","description":"Tools and components for developing Merchant Center Applications 🛠","fork":false,"url":"https://api.github.com/repos/commercetools/merchant-center-application-kit","forks_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/forks","keys_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/teams","hooks_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/hooks","issue_events_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/events","assignees_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/tags","blobs_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/languages","stargazers_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/stargazers","contributors_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/contributors","subscribers_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/subscribers","subscription_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/subscription","commits_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/merges","archive_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/downloads","issues_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/deployments","created_at":"2018-10-08T14:01:18Z","updated_at":"2018-11-29T10:34:05Z","pushed_at":"2018-11-29T12:06:54Z","git_url":"git://github.com/commercetools/merchant-center-application-kit.git","ssh_url":"git@github.com:commercetools/merchant-center-application-kit.git","clone_url":"https://github.com/commercetools/merchant-center-application-kit.git","svn_url":"https://github.com/commercetools/merchant-center-application-kit","homepage":"","size":4464,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"42bc1ce20a177bc0ee61241bfcfb692ae1f8560d","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":152089521,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwODk1MjE=","name":"merchant-center-application-kit","full_name":"commercetools/merchant-center-application-kit","private":false,"owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/commercetools/merchant-center-application-kit","description":"Tools and components for developing Merchant Center Applications 🛠","fork":false,"url":"https://api.github.com/repos/commercetools/merchant-center-application-kit","forks_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/forks","keys_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/teams","hooks_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/hooks","issue_events_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/events","assignees_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/tags","blobs_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/languages","stargazers_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/stargazers","contributors_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/contributors","subscribers_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/subscribers","subscription_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/subscription","commits_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/merges","archive_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/downloads","issues_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/merchant-center-application-kit/deployments","created_at":"2018-10-08T14:01:18Z","updated_at":"2018-11-29T10:34:05Z","pushed_at":"2018-11-29T12:06:54Z","git_url":"git://github.com/commercetools/merchant-center-application-kit.git","ssh_url":"git@github.com:commercetools/merchant-center-application-kit.git","clone_url":"https://github.com/commercetools/merchant-center-application-kit.git","svn_url":"https://github.com/commercetools/merchant-center-application-kit","homepage":"","size":4464,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144"},"html":{"href":"https://github.com/commercetools/merchant-center-application-kit/pull/144"},"issue":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/144"},"comments":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/merchant-center-application-kit/statuses/89ef7055236f861ec8cbf22150868bec6cffa00f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tdeekens"}}