{"action":"closed","number":682,"pull_request":{"url":"https://api.github.com/repos/google/xi-editor/pulls/682","id":191807352,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODA3MzUy","html_url":"https://github.com/google/xi-editor/pull/682","diff_url":"https://github.com/google/xi-editor/pull/682.diff","patch_url":"https://github.com/google/xi-editor/pull/682.patch","issue_url":"https://api.github.com/repos/google/xi-editor/issues/682","number":682,"state":"closed","locked":false,"title":"Refactor/configs in config manager","user":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"(includes #680, which should go in first.)\r\n\r\nThis is another batch of cleanup & refactoring. In pointform:\r\n\r\n- the language assigned to a buffer is tracked in the ConfigManager\r\n- the buffer's config is tracked in the ConfigManager. This means that\r\nwe don't need to have a config in order to init an `Editor`, which means\r\nwe now only have one code path for creating a new view.\r\n- configs are passed into `Editor` and `View` as needed; this means the\r\n`View` doesn't need to reach in to the `Editor` to access the config.\r\n\r\nThis will enable and/or simplify some additional feature work:\r\n- allowing the client to set a view's language without saving\r\n- implementing width wrapping via the config system\r\n- auto launching plugins based on language (and other) tags","created_at":"2018-05-31T16:23:15Z","updated_at":"2018-06-08T18:56:57Z","closed_at":"2018-06-08T18:56:57Z","merged_at":"2018-06-08T18:56:56Z","merge_commit_sha":"8d8a4df8606d8c8f1d8330d24dda7da1e577121b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":365718022,"node_id":"MDU6TGFiZWwzNjU3MTgwMjI=","url":"https://api.github.com/repos/google/xi-editor/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/xi-editor/pulls/682/commits","review_comments_url":"https://api.github.com/repos/google/xi-editor/pulls/682/comments","review_comment_url":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/xi-editor/issues/682/comments","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/ebe9c9889f303038bfe3a5fceab9871604283a82","head":{"label":"cmyr:refactor/configs-in-config-manager","ref":"refactor/configs-in-config-manager","sha":"ebe9c9889f303038bfe3a5fceab9871604283a82","user":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"repo":{"id":83341143,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM0MTE0Mw==","name":"xi-editor","full_name":"cmyr/xi-editor","owner":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmyr/xi-editor","description":"A modern editor with a backend written in Rust.","fork":true,"url":"https://api.github.com/repos/cmyr/xi-editor","forks_url":"https://api.github.com/repos/cmyr/xi-editor/forks","keys_url":"https://api.github.com/repos/cmyr/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmyr/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmyr/xi-editor/teams","hooks_url":"https://api.github.com/repos/cmyr/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/cmyr/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/cmyr/xi-editor/events","assignees_url":"https://api.github.com/repos/cmyr/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/cmyr/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/cmyr/xi-editor/tags","blobs_url":"https://api.github.com/repos/cmyr/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmyr/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmyr/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmyr/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmyr/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/cmyr/xi-editor/languages","stargazers_url":"https://api.github.com/repos/cmyr/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/cmyr/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/cmyr/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/cmyr/xi-editor/subscription","commits_url":"https://api.github.com/repos/cmyr/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmyr/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmyr/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmyr/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmyr/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/cmyr/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmyr/xi-editor/merges","archive_url":"https://api.github.com/repos/cmyr/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmyr/xi-editor/downloads","issues_url":"https://api.github.com/repos/cmyr/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/cmyr/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/cmyr/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/cmyr/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmyr/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/cmyr/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/cmyr/xi-editor/deployments","created_at":"2017-02-27T18:08:20Z","updated_at":"2018-04-12T20:37:18Z","pushed_at":"2018-06-08T18:42:00Z","git_url":"git://github.com/cmyr/xi-editor.git","ssh_url":"git@github.com:cmyr/xi-editor.git","clone_url":"https://github.com/cmyr/xi-editor.git","svn_url":"https://github.com/cmyr/xi-editor","homepage":"","size":6303,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0cea1bb768cdb95333647dafbacaea9cc123d09f","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":57167764,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE2Nzc2NA==","name":"xi-editor","full_name":"google/xi-editor","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/xi-editor","description":"A modern editor with a backend written in Rust. https://google.github.io/xi-editor","fork":false,"url":"https://api.github.com/repos/google/xi-editor","forks_url":"https://api.github.com/repos/google/xi-editor/forks","keys_url":"https://api.github.com/repos/google/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/xi-editor/teams","hooks_url":"https://api.github.com/repos/google/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/google/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/google/xi-editor/events","assignees_url":"https://api.github.com/repos/google/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/google/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/google/xi-editor/tags","blobs_url":"https://api.github.com/repos/google/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/xi-editor/languages","stargazers_url":"https://api.github.com/repos/google/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/google/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/google/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/google/xi-editor/subscription","commits_url":"https://api.github.com/repos/google/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/google/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/xi-editor/merges","archive_url":"https://api.github.com/repos/google/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/xi-editor/downloads","issues_url":"https://api.github.com/repos/google/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/google/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/google/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/google/xi-editor/deployments","created_at":"2016-04-26T23:03:23Z","updated_at":"2018-06-08T18:26:30Z","pushed_at":"2018-06-08T18:56:56Z","git_url":"git://github.com/google/xi-editor.git","ssh_url":"git@github.com:google/xi-editor.git","clone_url":"https://github.com/google/xi-editor.git","svn_url":"https://github.com/google/xi-editor","homepage":"","size":5571,"stargazers_count":12776,"watchers_count":12776,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":440,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":440,"open_issues":134,"watchers":12776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/682"},"html":{"href":"https://github.com/google/xi-editor/pull/682"},"issue":{"href":"https://api.github.com/repos/google/xi-editor/issues/682"},"comments":{"href":"https://api.github.com/repos/google/xi-editor/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/google/xi-editor/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/xi-editor/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/google/xi-editor/statuses/ebe9c9889f303038bfe3a5fceab9871604283a82"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmyr","id":3330916,"node_id":"MDQ6VXNlcjMzMzA5MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3330916?v=4","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":338,"deletions":228,"changed_files":5}}
{"actor":{"display_login":"cmyr"}}