{"action":"created","comment":{"url":"https://api.github.com/repos/mhvk/baseband/pulls/comments/204582891","pull_request_review_id":139688489,"id":204582891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU4Mjg5MQ==","diff_hunk":"@@ -40,7 +40,7 @@ We now open a sequential file object for writing::\n     >>> from baseband.helpers import sequentialfile as sf\n     >>> filenames = [\"seqvdif_{0}\".format(i) for i in range(2)]\n     >>> file_size = fh.fh_raw.seek(0, 2) // 2\n-    >>> fwr = sf.open(filenames, mode='wb', file_size=file_size)\n+    >>> fwr = sf.open(filenames, mode='w+b', file_size=file_size)","path":"docs/helpers/index.rst","position":5,"original_position":5,"commit_id":"ceea6c5628b0ef004930a1b74d5c89b4117e33f9","original_commit_id":"17e0455e40e969df962eaa508e8499bd41f3eba3","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"It is mostly that it is surprising that `w+b` is required at all. But let's just leave it as you have it until someone complains!","created_at":"2018-07-23T23:23:05Z","updated_at":"2018-07-23T23:23:05Z","html_url":"https://github.com/mhvk/baseband/pull/254#discussion_r204582891","pull_request_url":"https://api.github.com/repos/mhvk/baseband/pulls/254","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/comments/204582891"},"html":{"href":"https://github.com/mhvk/baseband/pull/254#discussion_r204582891"},"pull_request":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/254"}},"in_reply_to_id":204255198},"pull_request":{"url":"https://api.github.com/repos/mhvk/baseband/pulls/254","id":202936675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTM2Njc1","html_url":"https://github.com/mhvk/baseband/pull/254","diff_url":"https://github.com/mhvk/baseband/pull/254.diff","patch_url":"https://github.com/mhvk/baseband/pull/254.patch","issue_url":"https://api.github.com/repos/mhvk/baseband/issues/254","number":254,"state":"open","locked":false,"title":"Sequential file support openers","user":{"login":"cczhu","id":442891,"node_id":"MDQ6VXNlcjQ0Mjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/442891?v=4","gravatar_id":"","url":"https://api.github.com/users/cczhu","html_url":"https://github.com/cczhu","followers_url":"https://api.github.com/users/cczhu/followers","following_url":"https://api.github.com/users/cczhu/following{/other_user}","gists_url":"https://api.github.com/users/cczhu/gists{/gist_id}","starred_url":"https://api.github.com/users/cczhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cczhu/subscriptions","organizations_url":"https://api.github.com/users/cczhu/orgs","repos_url":"https://api.github.com/users/cczhu/repos","events_url":"https://api.github.com/users/cczhu/events{/privacy}","received_events_url":"https://api.github.com/users/cczhu/received_events","type":"User","site_admin":false},"body":"Reworked `vlbi_base.base.make_opener` to accept lists, tuples and `FileNameSequencer` objects for opening, adding native file sequence support for VLBI formats. Modified and expanded the wrappers for DADA and GUPPI so that both format openers can handle template strings. Made a small modification to `baseband.file_info` so that `baseband.open` can read the same file sequence formats.\r\n\r\nA few minor features and bugfixes:\r\n- It is now possible to pass all stream reader and writer kwargs to the DADA opener; before, 'subset' and 'verify' could not be passed with a template string.\r\n- It is now possible to pass a template string to the DADA opener in 'rs' mode that uses header properties (like 'utc_time'), but not 'obs_offset'.\r\n- For VLBI formats, it is possible to open an iterable of filenames in 'wb' mode. So as not to overcomplicate the header setting process, it's now explicitly disallowed for DADA and GUPPI.\r\n- All opener sections have notes about opening file sequences. Moved the notes for DADA and GUPPI to when making `opener` rather than defining `open`.  This is not entirely appropriate, but now that `make_opener` adds sequential file functionality the distinction between `opener` and `open` can't be cleanly separated in the docstring.\r\n\r\nI still need to revise the documentation and add a note in the changelog, and will do those once the code design has been accepted.\r\n\r\nWe should also decide if this becomes (part of) a 1.2 release.\r\n\r\nAt least partly addresses #231.","created_at":"2018-07-20T19:29:05Z","updated_at":"2018-07-23T23:23:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb830aada11372f00467339b0e2006c71109485","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":273065472,"node_id":"MDU6TGFiZWwyNzMwNjU0NzI=","url":"https://api.github.com/repos/mhvk/baseband/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":675153087,"node_id":"MDU6TGFiZWw2NzUxNTMwODc=","url":"https://api.github.com/repos/mhvk/baseband/labels/refactoring","name":"refactoring","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mhvk/baseband/pulls/254/commits","review_comments_url":"https://api.github.com/repos/mhvk/baseband/pulls/254/comments","review_comment_url":"https://api.github.com/repos/mhvk/baseband/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mhvk/baseband/issues/254/comments","statuses_url":"https://api.github.com/repos/mhvk/baseband/statuses/ceea6c5628b0ef004930a1b74d5c89b4117e33f9","head":{"label":"cczhu:seqfile_support_for_opener","ref":"seqfile_support_for_opener","sha":"ceea6c5628b0ef004930a1b74d5c89b4117e33f9","user":{"login":"cczhu","id":442891,"node_id":"MDQ6VXNlcjQ0Mjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/442891?v=4","gravatar_id":"","url":"https://api.github.com/users/cczhu","html_url":"https://github.com/cczhu","followers_url":"https://api.github.com/users/cczhu/followers","following_url":"https://api.github.com/users/cczhu/following{/other_user}","gists_url":"https://api.github.com/users/cczhu/gists{/gist_id}","starred_url":"https://api.github.com/users/cczhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cczhu/subscriptions","organizations_url":"https://api.github.com/users/cczhu/orgs","repos_url":"https://api.github.com/users/cczhu/repos","events_url":"https://api.github.com/users/cczhu/events{/privacy}","received_events_url":"https://api.github.com/users/cczhu/received_events","type":"User","site_admin":false},"repo":{"id":91695648,"node_id":"MDEwOlJlcG9zaXRvcnk5MTY5NTY0OA==","name":"baseband","full_name":"cczhu/baseband","owner":{"login":"cczhu","id":442891,"node_id":"MDQ6VXNlcjQ0Mjg5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/442891?v=4","gravatar_id":"","url":"https://api.github.com/users/cczhu","html_url":"https://github.com/cczhu","followers_url":"https://api.github.com/users/cczhu/followers","following_url":"https://api.github.com/users/cczhu/following{/other_user}","gists_url":"https://api.github.com/users/cczhu/gists{/gist_id}","starred_url":"https://api.github.com/users/cczhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cczhu/subscriptions","organizations_url":"https://api.github.com/users/cczhu/orgs","repos_url":"https://api.github.com/users/cczhu/repos","events_url":"https://api.github.com/users/cczhu/events{/privacy}","received_events_url":"https://api.github.com/users/cczhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cczhu/baseband","description":null,"fork":true,"url":"https://api.github.com/repos/cczhu/baseband","forks_url":"https://api.github.com/repos/cczhu/baseband/forks","keys_url":"https://api.github.com/repos/cczhu/baseband/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cczhu/baseband/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cczhu/baseband/teams","hooks_url":"https://api.github.com/repos/cczhu/baseband/hooks","issue_events_url":"https://api.github.com/repos/cczhu/baseband/issues/events{/number}","events_url":"https://api.github.com/repos/cczhu/baseband/events","assignees_url":"https://api.github.com/repos/cczhu/baseband/assignees{/user}","branches_url":"https://api.github.com/repos/cczhu/baseband/branches{/branch}","tags_url":"https://api.github.com/repos/cczhu/baseband/tags","blobs_url":"https://api.github.com/repos/cczhu/baseband/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cczhu/baseband/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cczhu/baseband/git/refs{/sha}","trees_url":"https://api.github.com/repos/cczhu/baseband/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cczhu/baseband/statuses/{sha}","languages_url":"https://api.github.com/repos/cczhu/baseband/languages","stargazers_url":"https://api.github.com/repos/cczhu/baseband/stargazers","contributors_url":"https://api.github.com/repos/cczhu/baseband/contributors","subscribers_url":"https://api.github.com/repos/cczhu/baseband/subscribers","subscription_url":"https://api.github.com/repos/cczhu/baseband/subscription","commits_url":"https://api.github.com/repos/cczhu/baseband/commits{/sha}","git_commits_url":"https://api.github.com/repos/cczhu/baseband/git/commits{/sha}","comments_url":"https://api.github.com/repos/cczhu/baseband/comments{/number}","issue_comment_url":"https://api.github.com/repos/cczhu/baseband/issues/comments{/number}","contents_url":"https://api.github.com/repos/cczhu/baseband/contents/{+path}","compare_url":"https://api.github.com/repos/cczhu/baseband/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cczhu/baseband/merges","archive_url":"https://api.github.com/repos/cczhu/baseband/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cczhu/baseband/downloads","issues_url":"https://api.github.com/repos/cczhu/baseband/issues{/number}","pulls_url":"https://api.github.com/repos/cczhu/baseband/pulls{/number}","milestones_url":"https://api.github.com/repos/cczhu/baseband/milestones{/number}","notifications_url":"https://api.github.com/repos/cczhu/baseband/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cczhu/baseband/labels{/name}","releases_url":"https://api.github.com/repos/cczhu/baseband/releases{/id}","deployments_url":"https://api.github.com/repos/cczhu/baseband/deployments","created_at":"2017-05-18T13:19:53Z","updated_at":"2018-07-21T21:44:24Z","pushed_at":"2018-07-23T23:12:17Z","git_url":"git://github.com/cczhu/baseband.git","ssh_url":"git@github.com:cczhu/baseband.git","clone_url":"https://github.com/cczhu/baseband.git","svn_url":"https://github.com/cczhu/baseband","homepage":null,"size":3484,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"mhvk:master","ref":"master","sha":"0a1e22c26f5e8a3627b82a570947cfd9d29b0c2b","user":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"repo":{"id":44264914,"node_id":"MDEwOlJlcG9zaXRvcnk0NDI2NDkxNA==","name":"baseband","full_name":"mhvk/baseband","owner":{"login":"mhvk","id":2789820,"node_id":"MDQ6VXNlcjI3ODk4MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/2789820?v=4","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhvk/baseband","description":"Package to read and write radio baseband data","fork":false,"url":"https://api.github.com/repos/mhvk/baseband","forks_url":"https://api.github.com/repos/mhvk/baseband/forks","keys_url":"https://api.github.com/repos/mhvk/baseband/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhvk/baseband/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhvk/baseband/teams","hooks_url":"https://api.github.com/repos/mhvk/baseband/hooks","issue_events_url":"https://api.github.com/repos/mhvk/baseband/issues/events{/number}","events_url":"https://api.github.com/repos/mhvk/baseband/events","assignees_url":"https://api.github.com/repos/mhvk/baseband/assignees{/user}","branches_url":"https://api.github.com/repos/mhvk/baseband/branches{/branch}","tags_url":"https://api.github.com/repos/mhvk/baseband/tags","blobs_url":"https://api.github.com/repos/mhvk/baseband/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhvk/baseband/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhvk/baseband/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhvk/baseband/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhvk/baseband/statuses/{sha}","languages_url":"https://api.github.com/repos/mhvk/baseband/languages","stargazers_url":"https://api.github.com/repos/mhvk/baseband/stargazers","contributors_url":"https://api.github.com/repos/mhvk/baseband/contributors","subscribers_url":"https://api.github.com/repos/mhvk/baseband/subscribers","subscription_url":"https://api.github.com/repos/mhvk/baseband/subscription","commits_url":"https://api.github.com/repos/mhvk/baseband/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhvk/baseband/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhvk/baseband/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhvk/baseband/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhvk/baseband/contents/{+path}","compare_url":"https://api.github.com/repos/mhvk/baseband/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhvk/baseband/merges","archive_url":"https://api.github.com/repos/mhvk/baseband/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhvk/baseband/downloads","issues_url":"https://api.github.com/repos/mhvk/baseband/issues{/number}","pulls_url":"https://api.github.com/repos/mhvk/baseband/pulls{/number}","milestones_url":"https://api.github.com/repos/mhvk/baseband/milestones{/number}","notifications_url":"https://api.github.com/repos/mhvk/baseband/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhvk/baseband/labels{/name}","releases_url":"https://api.github.com/repos/mhvk/baseband/releases{/id}","deployments_url":"https://api.github.com/repos/mhvk/baseband/deployments","created_at":"2015-10-14T17:33:54Z","updated_at":"2018-07-20T20:34:26Z","pushed_at":"2018-07-23T23:12:18Z","git_url":"git://github.com/mhvk/baseband.git","ssh_url":"git@github.com:mhvk/baseband.git","clone_url":"https://github.com/mhvk/baseband.git","svn_url":"https://github.com/mhvk/baseband","homepage":"http://baseband.readthedocs.io/","size":3320,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":17,"open_issues":16,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/254"},"html":{"href":"https://github.com/mhvk/baseband/pull/254"},"issue":{"href":"https://api.github.com/repos/mhvk/baseband/issues/254"},"comments":{"href":"https://api.github.com/repos/mhvk/baseband/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mhvk/baseband/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/mhvk/baseband/statuses/ceea6c5628b0ef004930a1b74d5c89b4117e33f9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mhvk"}}