{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/192745988","pull_request_review_id":125578963,"id":192745988,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc0NTk4OA==","diff_hunk":"@@ -369,7 +390,12 @@ def test_autoscaling_info_for_resources():\n         mock_state = mock.Mock()\n         mock_utilization_errors = {('westeros-1', 'default',): 0}\n         ret = autoscaling_cluster_lib.autoscaling_info_for_resource(\n-            mock_resources['sfr-blah'], {}, mock_state, mock_utilization_errors,\n+            resource=mock_resources['sfr-blah'],\n+            pool_settings={},\n+            mesos_state=mock_state,\n+            utilization_errors=mock_utilization_errors,\n+            max_increase=0.2,\n+            max_decrease=0.2,","path":"tests/autoscaling/test_autoscaling_cluster_lib.py","position":51,"original_position":51,"commit_id":"34585da98dccca425a96d5466df4ad1804a20f03","original_commit_id":"34585da98dccca425a96d5466df4ad1804a20f03","user":{"login":"vkhromov","id":1240391,"node_id":"MDQ6VXNlcjEyNDAzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1240391?v=4","gravatar_id":"","url":"https://api.github.com/users/vkhromov","html_url":"https://github.com/vkhromov","followers_url":"https://api.github.com/users/vkhromov/followers","following_url":"https://api.github.com/users/vkhromov/following{/other_user}","gists_url":"https://api.github.com/users/vkhromov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkhromov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkhromov/subscriptions","organizations_url":"https://api.github.com/users/vkhromov/orgs","repos_url":"https://api.github.com/users/vkhromov/repos","events_url":"https://api.github.com/users/vkhromov/events{/privacy}","received_events_url":"https://api.github.com/users/vkhromov/received_events","type":"User","site_admin":false},"body":"`max_decrease=0.1,` ?","created_at":"2018-06-04T13:45:31Z","updated_at":"2018-06-04T13:48:41Z","html_url":"https://github.com/Yelp/paasta/pull/1849#discussion_r192745988","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/1849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/192745988"},"html":{"href":"https://github.com/Yelp/paasta/pull/1849#discussion_r192745988"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1849"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/1849","id":192411898,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNDExODk4","html_url":"https://github.com/Yelp/paasta/pull/1849","diff_url":"https://github.com/Yelp/paasta/pull/1849.diff","patch_url":"https://github.com/Yelp/paasta/pull/1849.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/1849","number":1849,"state":"open","locked":false,"title":"Split out MAX_CLUSTER_DELTA for cluster autoscaler","user":{"login":"mattmb","id":2462243,"node_id":"MDQ6VXNlcjI0NjIyNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2462243?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false},"body":"I'm splitting this into a maximum increase and maximum decrease so that\r\nI can reduce the maximum decrease without affecting the autoscaler's\r\nability to scale up.\r\n\r\nThe motivation is that because we now have multiple SFRs to speed up\r\nscaling down we end up decreasing by 20% on each one and because we\r\nround down to the nearest whole number we are effectively being more\r\naggressive than before both in speed and amount that we scale down.\r\nSo I've reduced the default max decrease to 10% and made it\r\nconfigurable via /etc/paasta.","created_at":"2018-06-04T13:40:54Z","updated_at":"2018-06-04T13:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a480dfa303ce75803d91f7e541724d7f9bedde2b","assignee":{"login":"mattmb","id":2462243,"node_id":"MDQ6VXNlcjI0NjIyNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2462243?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmb","id":2462243,"node_id":"MDQ6VXNlcjI0NjIyNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2462243?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmb","html_url":"https://github.com/mattmb","followers_url":"https://api.github.com/users/mattmb/followers","following_url":"https://api.github.com/users/mattmb/following{/other_user}","gists_url":"https://api.github.com/users/mattmb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmb/subscriptions","organizations_url":"https://api.github.com/users/mattmb/orgs","repos_url":"https://api.github.com/users/mattmb/repos","events_url":"https://api.github.com/users/mattmb/events{/privacy}","received_events_url":"https://api.github.com/users/mattmb/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Rob-Johnson","id":1389671,"node_id":"MDQ6VXNlcjEzODk2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1389671?v=4","gravatar_id":"","url":"https://api.github.com/users/Rob-Johnson","html_url":"https://github.com/Rob-Johnson","followers_url":"https://api.github.com/users/Rob-Johnson/followers","following_url":"https://api.github.com/users/Rob-Johnson/following{/other_user}","gists_url":"https://api.github.com/users/Rob-Johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob-Johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob-Johnson/subscriptions","organizations_url":"https://api.github.com/users/Rob-Johnson/orgs","repos_url":"https://api.github.com/users/Rob-Johnson/repos","events_url":"https://api.github.com/users/Rob-Johnson/events{/privacy}","received_events_url":"https://api.github.com/users/Rob-Johnson/received_events","type":"User","site_admin":false},{"login":"stug","id":3210321,"node_id":"MDQ6VXNlcjMyMTAzMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3210321?v=4","gravatar_id":"","url":"https://api.github.com/users/stug","html_url":"https://github.com/stug","followers_url":"https://api.github.com/users/stug/followers","following_url":"https://api.github.com/users/stug/following{/other_user}","gists_url":"https://api.github.com/users/stug/gists{/gist_id}","starred_url":"https://api.github.com/users/stug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stug/subscriptions","organizations_url":"https://api.github.com/users/stug/orgs","repos_url":"https://api.github.com/users/stug/repos","events_url":"https://api.github.com/users/stug/events{/privacy}","received_events_url":"https://api.github.com/users/stug/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":295506239,"node_id":"MDU6TGFiZWwyOTU1MDYyMzk=","url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/1849/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/1849/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/1849/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/34585da98dccca425a96d5466df4ad1804a20f03","head":{"label":"Yelp:autoscaler-configure-max-delta","ref":"autoscaler-configure-max-delta","sha":"34585da98dccca425a96d5466df4ad1804a20f03","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-06-04T13:24:05Z","pushed_at":"2018-06-04T13:40:54Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":55934,"stargazers_count":1227,"watchers_count":1227,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":96,"watchers":1227,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"66e5fc1ff9e23c3ffb8ca6bd7cea3c9bd5b96758","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-06-04T13:24:05Z","pushed_at":"2018-06-04T13:40:54Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":55934,"stargazers_count":1227,"watchers_count":1227,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":96,"watchers":1227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1849"},"html":{"href":"https://github.com/Yelp/paasta/pull/1849"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1849"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1849/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1849/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1849/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/34585da98dccca425a96d5466df4ad1804a20f03"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vkhromov"}}