{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments/226628982","pull_request_review_id":166499816,"id":226628982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjYyODk4Mg==","diff_hunk":"@@ -34,50 +38,59 @@\n \n namespace SonarAnalyzer.UnitTest.TestFramework\n {\n+\n+    class ErrorInUnitTest : Exception\n+    {\n+#pragma warning disable S3963 // \"static\" fields should be initialized inline\n+        static ErrorInUnitTest()\n+        {\n+            var msCoreResourceManager = new ResourceManager(\"mscorlib\", typeof(Object).Assembly);\n+            at = msCoreResourceManager.GetString(\"Word_At\");\n+            inFileLineNum = msCoreResourceManager.GetString(\"StackTrace_InFileLineNumber\");","path":"sonaranalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestFramework/DiagnosticVerifier.cs","position":24,"original_position":24,"commit_id":"8dca8c3228c3b397686081638860df9a3020028c","original_commit_id":"8dca8c3228c3b397686081638860df9a3020028c","user":{"login":"loic-joly-sonarsource","id":37904001,"node_id":"MDQ6VXNlcjM3OTA0MDAx","avatar_url":"https://avatars3.githubusercontent.com/u/37904001?v=4","gravatar_id":"","url":"https://api.github.com/users/loic-joly-sonarsource","html_url":"https://github.com/loic-joly-sonarsource","followers_url":"https://api.github.com/users/loic-joly-sonarsource/followers","following_url":"https://api.github.com/users/loic-joly-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/loic-joly-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-joly-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-joly-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/loic-joly-sonarsource/orgs","repos_url":"https://api.github.com/users/loic-joly-sonarsource/repos","events_url":"https://api.github.com/users/loic-joly-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/loic-joly-sonarsource/received_events","type":"User","site_admin":false},"body":"It cannot be constant, since depending on the language of installation of visual studio, those strings will change:\r\n- The default exception stack will be in the user language\r\n- The mechanism that parses the exception stack expects to see strings in the user language. If I generate an English string on my machine, it will not work.\r\n","created_at":"2018-10-19T12:29:03Z","updated_at":"2018-10-19T12:29:03Z","html_url":"https://github.com/SonarSource/sonar-csharp/pull/2014#discussion_r226628982","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments/226628982"},"html":{"href":"https://github.com/SonarSource/sonar-csharp/pull/2014#discussion_r226628982"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014"}},"in_reply_to_id":226569982},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014","id":224203031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjAzMDMx","html_url":"https://github.com/SonarSource/sonar-csharp/pull/2014","diff_url":"https://github.com/SonarSource/sonar-csharp/pull/2014.diff","patch_url":"https://github.com/SonarSource/sonar-csharp/pull/2014.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/2014","number":2014,"state":"open","locked":false,"title":"[Do not merge] Detect compilation errors in unit test code","user":{"login":"loic-joly-sonarsource","id":37904001,"node_id":"MDQ6VXNlcjM3OTA0MDAx","avatar_url":"https://avatars3.githubusercontent.com/u/37904001?v=4","gravatar_id":"","url":"https://api.github.com/users/loic-joly-sonarsource","html_url":"https://github.com/loic-joly-sonarsource","followers_url":"https://api.github.com/users/loic-joly-sonarsource/followers","following_url":"https://api.github.com/users/loic-joly-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/loic-joly-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-joly-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-joly-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/loic-joly-sonarsource/orgs","repos_url":"https://api.github.com/users/loic-joly-sonarsource/repos","events_url":"https://api.github.com/users/loic-joly-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/loic-joly-sonarsource/received_events","type":"User","site_admin":false},"body":"Fixes #2012 ","created_at":"2018-10-19T08:08:52Z","updated_at":"2018-10-19T12:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef8aaf333e49f8a3ec42dbda756cc52326c342dd","assignee":{"login":"loic-joly-sonarsource","id":37904001,"node_id":"MDQ6VXNlcjM3OTA0MDAx","avatar_url":"https://avatars3.githubusercontent.com/u/37904001?v=4","gravatar_id":"","url":"https://api.github.com/users/loic-joly-sonarsource","html_url":"https://github.com/loic-joly-sonarsource","followers_url":"https://api.github.com/users/loic-joly-sonarsource/followers","following_url":"https://api.github.com/users/loic-joly-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/loic-joly-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-joly-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-joly-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/loic-joly-sonarsource/orgs","repos_url":"https://api.github.com/users/loic-joly-sonarsource/repos","events_url":"https://api.github.com/users/loic-joly-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/loic-joly-sonarsource/received_events","type":"User","site_admin":false},"assignees":[{"login":"loic-joly-sonarsource","id":37904001,"node_id":"MDQ6VXNlcjM3OTA0MDAx","avatar_url":"https://avatars3.githubusercontent.com/u/37904001?v=4","gravatar_id":"","url":"https://api.github.com/users/loic-joly-sonarsource","html_url":"https://github.com/loic-joly-sonarsource","followers_url":"https://api.github.com/users/loic-joly-sonarsource/followers","following_url":"https://api.github.com/users/loic-joly-sonarsource/following{/other_user}","gists_url":"https://api.github.com/users/loic-joly-sonarsource/gists{/gist_id}","starred_url":"https://api.github.com/users/loic-joly-sonarsource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loic-joly-sonarsource/subscriptions","organizations_url":"https://api.github.com/users/loic-joly-sonarsource/orgs","repos_url":"https://api.github.com/users/loic-joly-sonarsource/repos","events_url":"https://api.github.com/users/loic-joly-sonarsource/events{/privacy}","received_events_url":"https://api.github.com/users/loic-joly-sonarsource/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731543503,"node_id":"MDU6TGFiZWw3MzE1NDM1MDM=","url":"https://api.github.com/repos/SonarSource/sonar-csharp/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/2014/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/8dca8c3228c3b397686081638860df9a3020028c","head":{"label":"SonarSource:loic/#2012-compile-errors-in-tests","ref":"loic/#2012-compile-errors-in-tests","sha":"8dca8c3228c3b397686081638860df9a3020028c","user":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5582516,"node_id":"MDEwOlJlcG9zaXRvcnk1NTgyNTE2","name":"sonar-csharp","full_name":"SonarSource/sonar-csharp","private":false,"owner":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SonarSource/sonar-csharp","description":"Code analyzer for C# projects","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-csharp","forks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-csharp/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-csharp/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-csharp/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-csharp/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-csharp/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/deployments","created_at":"2012-08-28T07:37:28Z","updated_at":"2018-10-18T18:59:40Z","pushed_at":"2018-10-19T08:08:53Z","git_url":"git://github.com/SonarSource/sonar-csharp.git","ssh_url":"git@github.com:SonarSource/sonar-csharp.git","clone_url":"https://github.com/SonarSource/sonar-csharp.git","svn_url":"https://github.com/SonarSource/sonar-csharp","homepage":"https://redirect.sonarsource.com/plugins/csharp.html","size":61687,"stargazers_count":220,"watchers_count":220,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":112,"watchers":220,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"8f18703c96f82e9662193b4d6b55127dc99aea8c","user":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":5582516,"node_id":"MDEwOlJlcG9zaXRvcnk1NTgyNTE2","name":"sonar-csharp","full_name":"SonarSource/sonar-csharp","private":false,"owner":{"login":"SonarSource","id":545988,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NTk4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SonarSource/sonar-csharp","description":"Code analyzer for C# projects","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-csharp","forks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-csharp/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-csharp/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-csharp/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-csharp/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-csharp/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-csharp/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-csharp/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-csharp/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-csharp/deployments","created_at":"2012-08-28T07:37:28Z","updated_at":"2018-10-18T18:59:40Z","pushed_at":"2018-10-19T08:08:53Z","git_url":"git://github.com/SonarSource/sonar-csharp.git","ssh_url":"git@github.com:SonarSource/sonar-csharp.git","clone_url":"https://github.com/SonarSource/sonar-csharp.git","svn_url":"https://github.com/SonarSource/sonar-csharp","homepage":"https://redirect.sonarsource.com/plugins/csharp.html","size":61687,"stargazers_count":220,"watchers_count":220,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":107,"open_issues":112,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014"},"html":{"href":"https://github.com/SonarSource/sonar-csharp/pull/2014"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/2014"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/issues/2014/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/pulls/2014/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-csharp/statuses/8dca8c3228c3b397686081638860df9a3020028c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"loic-joly-sonarsource"}}