{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/comments/174245558","pull_request_review_id":103566443,"id":174245558,"diff_hunk":"@@ -0,0 +1,187 @@\n+--TEST--\n+Test for inserting encrypted data into char types columns with different sizes\n+--DESCRIPTION--\n+Test conversions between different char types of different sizes\n+With or without Always Encrypted, implicit conversion works if:\n+1. From input of PDO::PARAM_BOOL to a any char column\n+2. From input of PDO::PARAM_INT to a any char column\n+3. From input of PDO::PARAM_STR to a any char column\n+4. From input of PDO::PARAM_LOB to a any char column\n+--SKIPIF--\n+<?php require('skipif_mid-refactor.inc'); ?>\n+--FILE--\n+<?php\n+require_once(\"MsCommon_mid-refactor.inc\");\n+require_once(\"AEData.inc\");\n+\n+$dataTypes = array(\"char\", \"varchar\", \"varchar(max)\");\n+$lengths = array(1, 8, 64, 512, 4096, 8000);\n+\n+try {\n+    $conn = connect();\n+    foreach ($dataTypes as $dataType) {\n+        $maxcol = strpos($dataType, \"(max)\");\n+        foreach ($lengths as $m) {\n+            if ($maxcol !== false) {\n+                $typeFull = $dataType;\n+            } else {\n+                $typeFull = \"$dataType($m)\";\n+            }\n+            echo \"\\nTesting $typeFull:\\n\";\n+                \n+            //create table containing char(m) or varchar(m) columns\n+            $tbname = \"test_\" . str_replace(array('(', ')'), '', $dataType) . $m;\n+            $colMetaArr = array(new ColumnMeta($typeFull, \"c1\", null, \"randomized\"));\n+            createTable($conn, $tbname, $colMetaArr);","path":"test/functional/pdo_sqlsrv/pdo_ae_insert_pdoparam_char_size.phpt","position":35,"original_position":35,"commit_id":"24938f523229ec6c97244ea14fa6dfe62b547dbb","original_commit_id":"24938f523229ec6c97244ea14fa6dfe62b547dbb","user":{"login":"v-kaywon","id":17915152,"avatar_url":"https://avatars2.githubusercontent.com/u/17915152?v=4","gravatar_id":"","url":"https://api.github.com/users/v-kaywon","html_url":"https://github.com/v-kaywon","followers_url":"https://api.github.com/users/v-kaywon/followers","following_url":"https://api.github.com/users/v-kaywon/following{/other_user}","gists_url":"https://api.github.com/users/v-kaywon/gists{/gist_id}","starred_url":"https://api.github.com/users/v-kaywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-kaywon/subscriptions","organizations_url":"https://api.github.com/users/v-kaywon/orgs","repos_url":"https://api.github.com/users/v-kaywon/repos","events_url":"https://api.github.com/users/v-kaywon/events{/privacy}","received_events_url":"https://api.github.com/users/v-kaywon/received_events","type":"User","site_admin":false},"body":"because with AE off, a row has a maximum column size of 8000 bytes. For lengths of 4096 and 8000 (see line 18), a table with two columns of this size cannot be created.","created_at":"2018-03-13T18:49:12Z","updated_at":"2018-03-13T18:49:12Z","html_url":"https://github.com/Microsoft/msphpsql/pull/698#discussion_r174245558","pull_request_url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/comments/174245558"},"html":{"href":"https://github.com/Microsoft/msphpsql/pull/698#discussion_r174245558"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698"}},"in_reply_to_id":173574057},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698","id":171526924,"html_url":"https://github.com/Microsoft/msphpsql/pull/698","diff_url":"https://github.com/Microsoft/msphpsql/pull/698.diff","patch_url":"https://github.com/Microsoft/msphpsql/pull/698.patch","issue_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/698","number":698,"state":"open","locked":false,"title":"add tests for testing insertion with the pdo drivers with all data ty…","user":{"login":"v-kaywon","id":17915152,"avatar_url":"https://avatars2.githubusercontent.com/u/17915152?v=4","gravatar_id":"","url":"https://api.github.com/users/v-kaywon","html_url":"https://github.com/v-kaywon","followers_url":"https://api.github.com/users/v-kaywon/followers","following_url":"https://api.github.com/users/v-kaywon/following{/other_user}","gists_url":"https://api.github.com/users/v-kaywon/gists{/gist_id}","starred_url":"https://api.github.com/users/v-kaywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-kaywon/subscriptions","organizations_url":"https://api.github.com/users/v-kaywon/orgs","repos_url":"https://api.github.com/users/v-kaywon/repos","events_url":"https://api.github.com/users/v-kaywon/events{/privacy}","received_events_url":"https://api.github.com/users/v-kaywon/received_events","type":"User","site_admin":false},"body":"…pes and variation of precisions and scales\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/msphpsql/698)\n<!-- Reviewable:end -->\n","created_at":"2018-02-26T23:59:49Z","updated_at":"2018-03-13T18:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"481f79d8d86cab4b2e500334a74321d41c48de60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msphpsql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/698/comments","statuses_url":"https://api.github.com/repos/Microsoft/msphpsql/statuses/24938f523229ec6c97244ea14fa6dfe62b547dbb","head":{"label":"v-kaywon:aetests","ref":"aetests","sha":"24938f523229ec6c97244ea14fa6dfe62b547dbb","user":{"login":"v-kaywon","id":17915152,"avatar_url":"https://avatars2.githubusercontent.com/u/17915152?v=4","gravatar_id":"","url":"https://api.github.com/users/v-kaywon","html_url":"https://github.com/v-kaywon","followers_url":"https://api.github.com/users/v-kaywon/followers","following_url":"https://api.github.com/users/v-kaywon/following{/other_user}","gists_url":"https://api.github.com/users/v-kaywon/gists{/gist_id}","starred_url":"https://api.github.com/users/v-kaywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-kaywon/subscriptions","organizations_url":"https://api.github.com/users/v-kaywon/orgs","repos_url":"https://api.github.com/users/v-kaywon/repos","events_url":"https://api.github.com/users/v-kaywon/events{/privacy}","received_events_url":"https://api.github.com/users/v-kaywon/received_events","type":"User","site_admin":false},"repo":{"id":81489251,"name":"msphpsql","full_name":"v-kaywon/msphpsql","owner":{"login":"v-kaywon","id":17915152,"avatar_url":"https://avatars2.githubusercontent.com/u/17915152?v=4","gravatar_id":"","url":"https://api.github.com/users/v-kaywon","html_url":"https://github.com/v-kaywon","followers_url":"https://api.github.com/users/v-kaywon/followers","following_url":"https://api.github.com/users/v-kaywon/following{/other_user}","gists_url":"https://api.github.com/users/v-kaywon/gists{/gist_id}","starred_url":"https://api.github.com/users/v-kaywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v-kaywon/subscriptions","organizations_url":"https://api.github.com/users/v-kaywon/orgs","repos_url":"https://api.github.com/users/v-kaywon/repos","events_url":"https://api.github.com/users/v-kaywon/events{/privacy}","received_events_url":"https://api.github.com/users/v-kaywon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/v-kaywon/msphpsql","description":"Microsoft PHP drivers for SQL Server","fork":true,"url":"https://api.github.com/repos/v-kaywon/msphpsql","forks_url":"https://api.github.com/repos/v-kaywon/msphpsql/forks","keys_url":"https://api.github.com/repos/v-kaywon/msphpsql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v-kaywon/msphpsql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v-kaywon/msphpsql/teams","hooks_url":"https://api.github.com/repos/v-kaywon/msphpsql/hooks","issue_events_url":"https://api.github.com/repos/v-kaywon/msphpsql/issues/events{/number}","events_url":"https://api.github.com/repos/v-kaywon/msphpsql/events","assignees_url":"https://api.github.com/repos/v-kaywon/msphpsql/assignees{/user}","branches_url":"https://api.github.com/repos/v-kaywon/msphpsql/branches{/branch}","tags_url":"https://api.github.com/repos/v-kaywon/msphpsql/tags","blobs_url":"https://api.github.com/repos/v-kaywon/msphpsql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v-kaywon/msphpsql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v-kaywon/msphpsql/git/refs{/sha}","trees_url":"https://api.github.com/repos/v-kaywon/msphpsql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v-kaywon/msphpsql/statuses/{sha}","languages_url":"https://api.github.com/repos/v-kaywon/msphpsql/languages","stargazers_url":"https://api.github.com/repos/v-kaywon/msphpsql/stargazers","contributors_url":"https://api.github.com/repos/v-kaywon/msphpsql/contributors","subscribers_url":"https://api.github.com/repos/v-kaywon/msphpsql/subscribers","subscription_url":"https://api.github.com/repos/v-kaywon/msphpsql/subscription","commits_url":"https://api.github.com/repos/v-kaywon/msphpsql/commits{/sha}","git_commits_url":"https://api.github.com/repos/v-kaywon/msphpsql/git/commits{/sha}","comments_url":"https://api.github.com/repos/v-kaywon/msphpsql/comments{/number}","issue_comment_url":"https://api.github.com/repos/v-kaywon/msphpsql/issues/comments{/number}","contents_url":"https://api.github.com/repos/v-kaywon/msphpsql/contents/{+path}","compare_url":"https://api.github.com/repos/v-kaywon/msphpsql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v-kaywon/msphpsql/merges","archive_url":"https://api.github.com/repos/v-kaywon/msphpsql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v-kaywon/msphpsql/downloads","issues_url":"https://api.github.com/repos/v-kaywon/msphpsql/issues{/number}","pulls_url":"https://api.github.com/repos/v-kaywon/msphpsql/pulls{/number}","milestones_url":"https://api.github.com/repos/v-kaywon/msphpsql/milestones{/number}","notifications_url":"https://api.github.com/repos/v-kaywon/msphpsql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v-kaywon/msphpsql/labels{/name}","releases_url":"https://api.github.com/repos/v-kaywon/msphpsql/releases{/id}","deployments_url":"https://api.github.com/repos/v-kaywon/msphpsql/deployments","created_at":"2017-02-09T19:56:11Z","updated_at":"2017-02-09T19:56:13Z","pushed_at":"2018-03-12T23:46:15Z","git_url":"git://github.com/v-kaywon/msphpsql.git","ssh_url":"git@github.com:v-kaywon/msphpsql.git","clone_url":"https://github.com/v-kaywon/msphpsql.git","svn_url":"https://github.com/v-kaywon/msphpsql","homepage":"","size":85642,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:dev","ref":"dev","sha":"a24a8a703566347e2f40add36891ccfd639a5f90","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":19043988,"name":"msphpsql","full_name":"Microsoft/msphpsql","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msphpsql","description":"Microsoft Drivers for PHP for SQL Server","fork":false,"url":"https://api.github.com/repos/Microsoft/msphpsql","forks_url":"https://api.github.com/repos/Microsoft/msphpsql/forks","keys_url":"https://api.github.com/repos/Microsoft/msphpsql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msphpsql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msphpsql/teams","hooks_url":"https://api.github.com/repos/Microsoft/msphpsql/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msphpsql/events","assignees_url":"https://api.github.com/repos/Microsoft/msphpsql/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msphpsql/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msphpsql/tags","blobs_url":"https://api.github.com/repos/Microsoft/msphpsql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msphpsql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msphpsql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msphpsql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msphpsql/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msphpsql/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msphpsql/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msphpsql/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msphpsql/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msphpsql/subscription","commits_url":"https://api.github.com/repos/Microsoft/msphpsql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msphpsql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msphpsql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msphpsql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msphpsql/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msphpsql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msphpsql/merges","archive_url":"https://api.github.com/repos/Microsoft/msphpsql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msphpsql/downloads","issues_url":"https://api.github.com/repos/Microsoft/msphpsql/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msphpsql/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msphpsql/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msphpsql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msphpsql/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msphpsql/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msphpsql/deployments","created_at":"2014-04-22T19:54:12Z","updated_at":"2018-03-13T18:09:28Z","pushed_at":"2018-03-12T23:49:42Z","git_url":"git://github.com/Microsoft/msphpsql.git","ssh_url":"git@github.com:Microsoft/msphpsql.git","clone_url":"https://github.com/Microsoft/msphpsql.git","svn_url":"https://github.com/Microsoft/msphpsql","homepage":"","size":85756,"stargazers_count":857,"watchers_count":857,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":172,"open_issues":62,"watchers":857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698"},"html":{"href":"https://github.com/Microsoft/msphpsql/pull/698"},"issue":{"href":"https://api.github.com/repos/Microsoft/msphpsql/issues/698"},"comments":{"href":"https://api.github.com/repos/Microsoft/msphpsql/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msphpsql/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msphpsql/statuses/24938f523229ec6c97244ea14fa6dfe62b547dbb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"v-kaywon"}}