{"action":"created","comment":{"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/comments/220756056","pull_request_review_id":159238714,"id":220756056,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDc1NjA1Ng==","diff_hunk":"@@ -195,20 +218,20 @@ impl<T> Channel<T> {\n                     ).is_ok()\n                 {\n                     // If this was the last slot in the block, install a new block.\n-                    if offset + 1 == BLOCK_CAP {\n+                    if offset + 1 == tail_slot_count {\n                         install_next_block();\n                     }\n \n                     unsafe {\n-                        let slot = tail.slots.get_unchecked(offset).get();\n-                        (*slot).msg.get().write(ManuallyDrop::new(msg));\n+                        let slot = tail.slots.get_unchecked(offset);\n+                        *slot.msg.get() = Some(msg);\n                         (*slot).ready.store(true, Ordering::Release);\n                     }\n                     break;\n                 }\n \n                 backoff.spin();\n-            } else if offset == BLOCK_CAP {\n+            } else {","path":"src/flavors/list.rs","position":147,"original_position":147,"commit_id":"3714af4b303fd47bb525ae2bd1aff8431af2fc31","original_commit_id":"3714af4b303fd47bb525ae2bd1aff8431af2fc31","user":{"login":"kleimkuhler","id":4572153,"node_id":"MDQ6VXNlcjQ1NzIxNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4572153?v=4","gravatar_id":"","url":"https://api.github.com/users/kleimkuhler","html_url":"https://github.com/kleimkuhler","followers_url":"https://api.github.com/users/kleimkuhler/followers","following_url":"https://api.github.com/users/kleimkuhler/following{/other_user}","gists_url":"https://api.github.com/users/kleimkuhler/gists{/gist_id}","starred_url":"https://api.github.com/users/kleimkuhler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleimkuhler/subscriptions","organizations_url":"https://api.github.com/users/kleimkuhler/orgs","repos_url":"https://api.github.com/users/kleimkuhler/repos","events_url":"https://api.github.com/users/kleimkuhler/events{/privacy}","received_events_url":"https://api.github.com/users/kleimkuhler/received_events","type":"User","site_admin":false},"body":"I understand being explicit here and I can add it back in, but don't we know based off the way that `new_slot_count` is calculated that if it's not less than, then it must be equal?","created_at":"2018-09-26T23:40:30Z","updated_at":"2018-09-26T23:40:30Z","html_url":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100#discussion_r220756056","pull_request_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/comments/220756056"},"html":{"href":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100#discussion_r220756056"},"pull_request":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100"}},"in_reply_to_id":220744902},"pull_request":{"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100","id":218472587,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDcyNTg3","html_url":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100","diff_url":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100.diff","patch_url":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100.patch","issue_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/100","number":100,"state":"open","locked":false,"title":"Grow unbounded blocks","user":{"login":"kleimkuhler","id":4572153,"node_id":"MDQ6VXNlcjQ1NzIxNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4572153?v=4","gravatar_id":"","url":"https://api.github.com/users/kleimkuhler","html_url":"https://github.com/kleimkuhler","followers_url":"https://api.github.com/users/kleimkuhler/followers","following_url":"https://api.github.com/users/kleimkuhler/following{/other_user}","gists_url":"https://api.github.com/users/kleimkuhler/gists{/gist_id}","starred_url":"https://api.github.com/users/kleimkuhler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleimkuhler/subscriptions","organizations_url":"https://api.github.com/users/kleimkuhler/orgs","repos_url":"https://api.github.com/users/kleimkuhler/repos","events_url":"https://api.github.com/users/kleimkuhler/events{/privacy}","received_events_url":"https://api.github.com/users/kleimkuhler/received_events","type":"User","site_admin":false},"body":"This addresses the initial implementation of dynamically growing the number of slots in `Box`.\r\n\r\nThe optimizations to build on top of this will be embedding `slots` inside `Block` similar to how `Node` embeds `tower` in [crossbeam-skiplist](https://github.com/crossbeam-rs/crossbeam-skiplist). This would remove the indirection of separately allocating `slots` on the heap.","created_at":"2018-09-26T22:23:10Z","updated_at":"2018-09-26T23:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02b5ca6539416b841d55da323fa6b74d40039c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100/commits","review_comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100/comments","review_comment_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/100/comments","statuses_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/statuses/3714af4b303fd47bb525ae2bd1aff8431af2fc31","head":{"label":"kleimkuhler:grow-unbounded-blocks","ref":"grow-unbounded-blocks","sha":"3714af4b303fd47bb525ae2bd1aff8431af2fc31","user":{"login":"kleimkuhler","id":4572153,"node_id":"MDQ6VXNlcjQ1NzIxNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4572153?v=4","gravatar_id":"","url":"https://api.github.com/users/kleimkuhler","html_url":"https://github.com/kleimkuhler","followers_url":"https://api.github.com/users/kleimkuhler/followers","following_url":"https://api.github.com/users/kleimkuhler/following{/other_user}","gists_url":"https://api.github.com/users/kleimkuhler/gists{/gist_id}","starred_url":"https://api.github.com/users/kleimkuhler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleimkuhler/subscriptions","organizations_url":"https://api.github.com/users/kleimkuhler/orgs","repos_url":"https://api.github.com/users/kleimkuhler/repos","events_url":"https://api.github.com/users/kleimkuhler/events{/privacy}","received_events_url":"https://api.github.com/users/kleimkuhler/received_events","type":"User","site_admin":false},"repo":{"id":149387747,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzODc3NDc=","name":"crossbeam-channel","full_name":"kleimkuhler/crossbeam-channel","private":false,"owner":{"login":"kleimkuhler","id":4572153,"node_id":"MDQ6VXNlcjQ1NzIxNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4572153?v=4","gravatar_id":"","url":"https://api.github.com/users/kleimkuhler","html_url":"https://github.com/kleimkuhler","followers_url":"https://api.github.com/users/kleimkuhler/followers","following_url":"https://api.github.com/users/kleimkuhler/following{/other_user}","gists_url":"https://api.github.com/users/kleimkuhler/gists{/gist_id}","starred_url":"https://api.github.com/users/kleimkuhler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleimkuhler/subscriptions","organizations_url":"https://api.github.com/users/kleimkuhler/orgs","repos_url":"https://api.github.com/users/kleimkuhler/repos","events_url":"https://api.github.com/users/kleimkuhler/events{/privacy}","received_events_url":"https://api.github.com/users/kleimkuhler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kleimkuhler/crossbeam-channel","description":"Multi-producer multi-consumer channels for message passing","fork":true,"url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel","forks_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/forks","keys_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/teams","hooks_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/hooks","issue_events_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/issues/events{/number}","events_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/events","assignees_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/assignees{/user}","branches_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/branches{/branch}","tags_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/tags","blobs_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/statuses/{sha}","languages_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/languages","stargazers_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/stargazers","contributors_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/contributors","subscribers_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/subscribers","subscription_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/subscription","commits_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/contents/{+path}","compare_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/merges","archive_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/downloads","issues_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/issues{/number}","pulls_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/pulls{/number}","milestones_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/milestones{/number}","notifications_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/labels{/name}","releases_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/releases{/id}","deployments_url":"https://api.github.com/repos/kleimkuhler/crossbeam-channel/deployments","created_at":"2018-09-19T03:33:48Z","updated_at":"2018-09-22T15:50:23Z","pushed_at":"2018-09-26T22:22:03Z","git_url":"git://github.com/kleimkuhler/crossbeam-channel.git","ssh_url":"git@github.com:kleimkuhler/crossbeam-channel.git","clone_url":"https://github.com/kleimkuhler/crossbeam-channel.git","svn_url":"https://github.com/kleimkuhler/crossbeam-channel","homepage":"","size":1032,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crossbeam-rs:master","ref":"master","sha":"3b0b2d040e46453d6aefbf3b88731ee77709bfa5","user":{"login":"crossbeam-rs","id":26314159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTU5","avatar_url":"https://avatars0.githubusercontent.com/u/26314159?v=4","gravatar_id":"","url":"https://api.github.com/users/crossbeam-rs","html_url":"https://github.com/crossbeam-rs","followers_url":"https://api.github.com/users/crossbeam-rs/followers","following_url":"https://api.github.com/users/crossbeam-rs/following{/other_user}","gists_url":"https://api.github.com/users/crossbeam-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbeam-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbeam-rs/subscriptions","organizations_url":"https://api.github.com/users/crossbeam-rs/orgs","repos_url":"https://api.github.com/users/crossbeam-rs/repos","events_url":"https://api.github.com/users/crossbeam-rs/events{/privacy}","received_events_url":"https://api.github.com/users/crossbeam-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":111470592,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0NzA1OTI=","name":"crossbeam-channel","full_name":"crossbeam-rs/crossbeam-channel","private":false,"owner":{"login":"crossbeam-rs","id":26314159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzE0MTU5","avatar_url":"https://avatars0.githubusercontent.com/u/26314159?v=4","gravatar_id":"","url":"https://api.github.com/users/crossbeam-rs","html_url":"https://github.com/crossbeam-rs","followers_url":"https://api.github.com/users/crossbeam-rs/followers","following_url":"https://api.github.com/users/crossbeam-rs/following{/other_user}","gists_url":"https://api.github.com/users/crossbeam-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/crossbeam-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossbeam-rs/subscriptions","organizations_url":"https://api.github.com/users/crossbeam-rs/orgs","repos_url":"https://api.github.com/users/crossbeam-rs/repos","events_url":"https://api.github.com/users/crossbeam-rs/events{/privacy}","received_events_url":"https://api.github.com/users/crossbeam-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crossbeam-rs/crossbeam-channel","description":"Multi-producer multi-consumer channels for message passing","fork":false,"url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel","forks_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/forks","keys_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/teams","hooks_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/hooks","issue_events_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/events{/number}","events_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/events","assignees_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/assignees{/user}","branches_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/branches{/branch}","tags_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/tags","blobs_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/statuses/{sha}","languages_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/languages","stargazers_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/stargazers","contributors_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/contributors","subscribers_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/subscribers","subscription_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/subscription","commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/contents/{+path}","compare_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/merges","archive_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/downloads","issues_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues{/number}","pulls_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls{/number}","milestones_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/milestones{/number}","notifications_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/labels{/name}","releases_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/releases{/id}","deployments_url":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/deployments","created_at":"2017-11-20T22:40:08Z","updated_at":"2018-09-26T13:26:50Z","pushed_at":"2018-09-26T22:23:11Z","git_url":"git://github.com/crossbeam-rs/crossbeam-channel.git","ssh_url":"git@github.com:crossbeam-rs/crossbeam-channel.git","clone_url":"https://github.com/crossbeam-rs/crossbeam-channel.git","svn_url":"https://github.com/crossbeam-rs/crossbeam-channel","homepage":"","size":1031,"stargazers_count":295,"watchers_count":295,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":12,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100"},"html":{"href":"https://github.com/crossbeam-rs/crossbeam-channel/pull/100"},"issue":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/100"},"comments":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/crossbeam-rs/crossbeam-channel/statuses/3714af4b303fd47bb525ae2bd1aff8431af2fc31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kleimkuhler"}}