{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/184351020","pull_request_review_id":115527533,"id":184351020,"diff_hunk":"@@ -44,6 +44,7 @@ async function publish(config: Config, pkg: any, flags: Object, dir: string): Pr\n   await config.executeLifecycleScript('prepublish');\n   await config.executeLifecycleScript('prepare');\n   await config.executeLifecycleScript('prepublishOnly');\n+  await config.executeLifecycleScript('prepack');","path":"src/cli/commands/publish.js","position":4,"original_position":4,"commit_id":"0b7c2dd81d4529e562b247dc37e1673598aab537","original_commit_id":"a83cfd7bea28e76f730318e4f701b04ae0ea9905","user":{"login":"BYK","id":126780,"avatar_url":"https://avatars3.githubusercontent.com/u/126780?v=4","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"body":"Shall we put that explanation in the code as a comment?","created_at":"2018-04-26T11:07:46Z","updated_at":"2018-04-26T11:07:46Z","html_url":"https://github.com/yarnpkg/yarn/pull/5712#discussion_r184351020","pull_request_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/184351020"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5712#discussion_r184351020"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712"}},"in_reply_to_id":183451605},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712","id":183249251,"html_url":"https://github.com/yarnpkg/yarn/pull/5712","diff_url":"https://github.com/yarnpkg/yarn/pull/5712.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5712.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5712","number":5712,"state":"open","locked":false,"title":"fix(publish): Run pre and postpack lifecycle scripts on publish","user":{"login":"rally25rs","id":38535,"avatar_url":"https://avatars3.githubusercontent.com/u/38535?v=4","gravatar_id":"","url":"https://api.github.com/users/rally25rs","html_url":"https://github.com/rally25rs","followers_url":"https://api.github.com/users/rally25rs/followers","following_url":"https://api.github.com/users/rally25rs/following{/other_user}","gists_url":"https://api.github.com/users/rally25rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rally25rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rally25rs/subscriptions","organizations_url":"https://api.github.com/users/rally25rs/orgs","repos_url":"https://api.github.com/users/rally25rs/repos","events_url":"https://api.github.com/users/rally25rs/events{/privacy}","received_events_url":"https://api.github.com/users/rally25rs/received_events","type":"User","site_admin":false},"body":"**Summary**\r\n\r\nnpm runs the pre and post pack scripts on publish, but yarn was not. Added these scripts.\r\n\r\nfixes #5707\r\n\r\n**Test plan**\r\n\r\nAdded a test that regex's the output to look for scripts being run.\r\nIf you look at the test, the regex is kinda weird, but I did it that way to make sure the log statements were in the correct order in the output.","created_at":"2018-04-22T00:46:16Z","updated_at":"2018-04-26T11:07:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935cafb6010a7ea685ef821a5d4ab9aa0d74b6b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5712/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/0b7c2dd81d4529e562b247dc37e1673598aab537","head":{"label":"rally25rs:publish-lifecycle-scripts-5707","ref":"publish-lifecycle-scripts-5707","sha":"0b7c2dd81d4529e562b247dc37e1673598aab537","user":{"login":"rally25rs","id":38535,"avatar_url":"https://avatars3.githubusercontent.com/u/38535?v=4","gravatar_id":"","url":"https://api.github.com/users/rally25rs","html_url":"https://github.com/rally25rs","followers_url":"https://api.github.com/users/rally25rs/followers","following_url":"https://api.github.com/users/rally25rs/following{/other_user}","gists_url":"https://api.github.com/users/rally25rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rally25rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rally25rs/subscriptions","organizations_url":"https://api.github.com/users/rally25rs/orgs","repos_url":"https://api.github.com/users/rally25rs/repos","events_url":"https://api.github.com/users/rally25rs/events{/privacy}","received_events_url":"https://api.github.com/users/rally25rs/received_events","type":"User","site_admin":false},"repo":{"id":79459660,"name":"yarn","full_name":"rally25rs/yarn","owner":{"login":"rally25rs","id":38535,"avatar_url":"https://avatars3.githubusercontent.com/u/38535?v=4","gravatar_id":"","url":"https://api.github.com/users/rally25rs","html_url":"https://github.com/rally25rs","followers_url":"https://api.github.com/users/rally25rs/followers","following_url":"https://api.github.com/users/rally25rs/following{/other_user}","gists_url":"https://api.github.com/users/rally25rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rally25rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rally25rs/subscriptions","organizations_url":"https://api.github.com/users/rally25rs/orgs","repos_url":"https://api.github.com/users/rally25rs/repos","events_url":"https://api.github.com/users/rally25rs/events{/privacy}","received_events_url":"https://api.github.com/users/rally25rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rally25rs/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/rally25rs/yarn","forks_url":"https://api.github.com/repos/rally25rs/yarn/forks","keys_url":"https://api.github.com/repos/rally25rs/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rally25rs/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rally25rs/yarn/teams","hooks_url":"https://api.github.com/repos/rally25rs/yarn/hooks","issue_events_url":"https://api.github.com/repos/rally25rs/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/rally25rs/yarn/events","assignees_url":"https://api.github.com/repos/rally25rs/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/rally25rs/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/rally25rs/yarn/tags","blobs_url":"https://api.github.com/repos/rally25rs/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rally25rs/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rally25rs/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rally25rs/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rally25rs/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/rally25rs/yarn/languages","stargazers_url":"https://api.github.com/repos/rally25rs/yarn/stargazers","contributors_url":"https://api.github.com/repos/rally25rs/yarn/contributors","subscribers_url":"https://api.github.com/repos/rally25rs/yarn/subscribers","subscription_url":"https://api.github.com/repos/rally25rs/yarn/subscription","commits_url":"https://api.github.com/repos/rally25rs/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rally25rs/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rally25rs/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rally25rs/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rally25rs/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/rally25rs/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rally25rs/yarn/merges","archive_url":"https://api.github.com/repos/rally25rs/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rally25rs/yarn/downloads","issues_url":"https://api.github.com/repos/rally25rs/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/rally25rs/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/rally25rs/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/rally25rs/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rally25rs/yarn/labels{/name}","releases_url":"https://api.github.com/repos/rally25rs/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/rally25rs/yarn/deployments","created_at":"2017-01-19T14:10:38Z","updated_at":"2018-04-15T18:18:09Z","pushed_at":"2018-04-23T18:53:30Z","git_url":"git://github.com/rally25rs/yarn.git","ssh_url":"git@github.com:rally25rs/yarn.git","clone_url":"https://github.com/rally25rs/yarn.git","svn_url":"https://github.com/rally25rs/yarn","homepage":"https://yarnpkg.com","size":114599,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"cbc6c8857cd74b658068c8ebec38d142dc3e6a7c","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-04-26T11:01:59Z","pushed_at":"2018-04-26T11:01:53Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":115506,"stargazers_count":31345,"watchers_count":31345,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1739,"mirror_url":null,"archived":false,"open_issues_count":1124,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1739,"open_issues":1124,"watchers":31345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5712"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5712"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5712/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5712/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/0b7c2dd81d4529e562b247dc37e1673598aab537"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BYK"}}