{"action":"created","issue":{"url":"https://api.github.com/repos/aws/chalice/issues/929","repository_url":"https://api.github.com/repos/aws/chalice","labels_url":"https://api.github.com/repos/aws/chalice/issues/929/labels{/name}","comments_url":"https://api.github.com/repos/aws/chalice/issues/929/comments","events_url":"https://api.github.com/repos/aws/chalice/issues/929/events","html_url":"https://github.com/aws/chalice/issues/929","id":348576939,"node_id":"MDU6SXNzdWUzNDg1NzY5Mzk=","number":929,"title":"Deployment proceeds despite packaging failures","user":{"login":"kadrach","id":206176,"node_id":"MDQ6VXNlcjIwNjE3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/206176?v=4","gravatar_id":"","url":"https://api.github.com/users/kadrach","html_url":"https://github.com/kadrach","followers_url":"https://api.github.com/users/kadrach/followers","following_url":"https://api.github.com/users/kadrach/following{/other_user}","gists_url":"https://api.github.com/users/kadrach/gists{/gist_id}","starred_url":"https://api.github.com/users/kadrach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadrach/subscriptions","organizations_url":"https://api.github.com/users/kadrach/orgs","repos_url":"https://api.github.com/users/kadrach/repos","events_url":"https://api.github.com/users/kadrach/events{/privacy}","received_events_url":"https://api.github.com/users/kadrach/received_events","type":"User","site_admin":false},"labels":[{"id":403474255,"node_id":"MDU6TGFiZWw0MDM0NzQyNTU=","url":"https://api.github.com/repos/aws/chalice/labels/feature-request","name":"feature-request","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-08T05:08:44Z","updated_at":"2018-09-26T22:43:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The `LambdaDeploymentPackager` prints a failure message when trying to build dependencies [here](https://github.com/aws/chalice/blob/master/chalice/deploy/packager.py#L88), but otherwise proceeds with deploying a (likely broken) Lambda function.\r\n\r\nThis is a bit cumbersome in a deployment toolchain as my deploy step currently succeeds and smoke-tests then fail. Is there a recommended way to have Chalice error out when packaging fails? I'm happy to send a PR for a `--strict` or `--abort-when-packaging-incomplete` packaging mode of some sort :)\r\n\r\nSee also #928."},"comment":{"url":"https://api.github.com/repos/aws/chalice/issues/comments/424893075","html_url":"https://github.com/aws/chalice/issues/929#issuecomment-424893075","issue_url":"https://api.github.com/repos/aws/chalice/issues/929","id":424893075,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDg5MzA3NQ==","user":{"login":"kadrach","id":206176,"node_id":"MDQ6VXNlcjIwNjE3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/206176?v=4","gravatar_id":"","url":"https://api.github.com/users/kadrach","html_url":"https://github.com/kadrach","followers_url":"https://api.github.com/users/kadrach/followers","following_url":"https://api.github.com/users/kadrach/following{/other_user}","gists_url":"https://api.github.com/users/kadrach/gists{/gist_id}","starred_url":"https://api.github.com/users/kadrach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadrach/subscriptions","organizations_url":"https://api.github.com/users/kadrach/orgs","repos_url":"https://api.github.com/users/kadrach/repos","events_url":"https://api.github.com/users/kadrach/events{/privacy}","received_events_url":"https://api.github.com/users/kadrach/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T22:43:32Z","updated_at":"2018-09-26T22:43:32Z","author_association":"CONTRIBUTOR","body":"@stealthycoin Two points I'd like to get some clarification on:\r\n- Deploying with a \"broken\" package doesn't make sense to me. Perhaps just warning and exiting is enough?\r\n- If it's a toggle, I think it should be \"strict\" by default, but that may break existing workflows that depend on current behavior.\r\n\r\nThoughts?"}}
{"actor":{"display_login":"kadrach"}}