{"action":"created","issue":{"url":"https://api.github.com/repos/pearson-ux/web-components/issues/182","repository_url":"https://api.github.com/repos/pearson-ux/web-components","labels_url":"https://api.github.com/repos/pearson-ux/web-components/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/pearson-ux/web-components/issues/182/comments","events_url":"https://api.github.com/repos/pearson-ux/web-components/issues/182/events","html_url":"https://github.com/pearson-ux/web-components/pull/182","id":384623734,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzgwNjI5","number":182,"title":"Drawer markup","user":{"login":"dengeist","id":13525251,"node_id":"MDQ6VXNlcjEzNTI1MjUx","avatar_url":"https://avatars2.githubusercontent.com/u/13525251?v=4","gravatar_id":"","url":"https://api.github.com/users/dengeist","html_url":"https://github.com/dengeist","followers_url":"https://api.github.com/users/dengeist/followers","following_url":"https://api.github.com/users/dengeist/following{/other_user}","gists_url":"https://api.github.com/users/dengeist/gists{/gist_id}","starred_url":"https://api.github.com/users/dengeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengeist/subscriptions","organizations_url":"https://api.github.com/users/dengeist/orgs","repos_url":"https://api.github.com/users/dengeist/repos","events_url":"https://api.github.com/users/dengeist/events{/privacy}","received_events_url":"https://api.github.com/users/dengeist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dengeist","id":13525251,"node_id":"MDQ6VXNlcjEzNTI1MjUx","avatar_url":"https://avatars2.githubusercontent.com/u/13525251?v=4","gravatar_id":"","url":"https://api.github.com/users/dengeist","html_url":"https://github.com/dengeist","followers_url":"https://api.github.com/users/dengeist/followers","following_url":"https://api.github.com/users/dengeist/following{/other_user}","gists_url":"https://api.github.com/users/dengeist/gists{/gist_id}","starred_url":"https://api.github.com/users/dengeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengeist/subscriptions","organizations_url":"https://api.github.com/users/dengeist/orgs","repos_url":"https://api.github.com/users/dengeist/repos","events_url":"https://api.github.com/users/dengeist/events{/privacy}","received_events_url":"https://api.github.com/users/dengeist/received_events","type":"User","site_admin":false},"assignees":[{"login":"dengeist","id":13525251,"node_id":"MDQ6VXNlcjEzNTI1MjUx","avatar_url":"https://avatars2.githubusercontent.com/u/13525251?v=4","gravatar_id":"","url":"https://api.github.com/users/dengeist","html_url":"https://github.com/dengeist","followers_url":"https://api.github.com/users/dengeist/followers","following_url":"https://api.github.com/users/dengeist/following{/other_user}","gists_url":"https://api.github.com/users/dengeist/gists{/gist_id}","starred_url":"https://api.github.com/users/dengeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengeist/subscriptions","organizations_url":"https://api.github.com/users/dengeist/orgs","repos_url":"https://api.github.com/users/dengeist/repos","events_url":"https://api.github.com/users/dengeist/events{/privacy}","received_events_url":"https://api.github.com/users/dengeist/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pearson-ux/web-components/milestones/3","html_url":"https://github.com/pearson-ux/web-components/milestone/3","labels_url":"https://api.github.com/repos/pearson-ux/web-components/milestones/3/labels","id":3540115,"node_id":"MDk6TWlsZXN0b25lMzU0MDExNQ==","number":3,"title":"HTML, CSS, JS Complete","description":"Complete all the HTML, CSS, JS for existing UXF and React components.","creator":{"login":"davodey","id":5407196,"node_id":"MDQ6VXNlcjU0MDcxOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":8,"state":"open","created_at":"2018-08-01T18:25:52Z","updated_at":"2018-11-27T04:59:01Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-11-27T04:59:00Z","updated_at":"2018-11-30T03:35:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pearson-ux/web-components/pulls/182","html_url":"https://github.com/pearson-ux/web-components/pull/182","diff_url":"https://github.com/pearson-ux/web-components/pull/182.diff","patch_url":"https://github.com/pearson-ux/web-components/pull/182.patch"},"body":"## Merging blocked, pending a11y discussion\r\n\r\nThe complete drawer markup-kit.\r\n\r\nFixes #180 - Drawer closes with escape key\r\nFixes #181 - Drawer transitions animate\r\n\r\nTodos:\r\n- [ ] Get accessibility feedback from @pauljadam. Paul, aside from any general accessibility opinions, I'd specifically like to know what you think of the following:\r\n  - The topic titles in the drawers being buttons (and those buttons being `aria-labelledby` the following paragraphs)\r\n  - Making the headings the first focusable item in each panel."},"comment":{"url":"https://api.github.com/repos/pearson-ux/web-components/issues/comments/443079767","html_url":"https://github.com/pearson-ux/web-components/pull/182#issuecomment-443079767","issue_url":"https://api.github.com/repos/pearson-ux/web-components/issues/182","id":443079767,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzA3OTc2Nw==","user":{"login":"pauljadam","id":786214,"node_id":"MDQ6VXNlcjc4NjIxNA==","avatar_url":"https://avatars1.githubusercontent.com/u/786214?v=4","gravatar_id":"","url":"https://api.github.com/users/pauljadam","html_url":"https://github.com/pauljadam","followers_url":"https://api.github.com/users/pauljadam/followers","following_url":"https://api.github.com/users/pauljadam/following{/other_user}","gists_url":"https://api.github.com/users/pauljadam/gists{/gist_id}","starred_url":"https://api.github.com/users/pauljadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauljadam/subscriptions","organizations_url":"https://api.github.com/users/pauljadam/orgs","repos_url":"https://api.github.com/users/pauljadam/repos","events_url":"https://api.github.com/users/pauljadam/events{/privacy}","received_events_url":"https://api.github.com/users/pauljadam/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T03:35:06Z","updated_at":"2018-11-30T03:35:06Z","author_association":"CONTRIBUTOR","body":"@dengeist there's a bug with aria-hidden=true not being removed from the drawer sometimes when I open and close it a few times.\r\n\r\nYou should not really need to use aria-hidden to hide the drawer when it's not visible, all you need is CSS for that.  \r\n\r\n![image](https://user-images.githubusercontent.com/786214/49267121-7f7e9b00-f41e-11e8-94da-538f9e32cc64.png)"}}
{"actor":{"display_login":"pauljadam"}}