{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/comments/233172325","pull_request_review_id":174524694,"id":233172325,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE3MjMyNQ==","diff_hunk":"@@ -136,10 +136,11 @@ const inflateEntities = function(node, templates, isRoot) {\n     z: node.rotation.z * THREE.Math.RAD2DEG\n   });\n   el.setAttribute(\"scale\", {\n-    x: node.scale.x,\n-    y: node.scale.y,\n-    z: node.scale.z\n+    x: node.scale.x * (scale !== undefined ? scale : 1),","path":"src/components/gltf-model-plus.js","position":16,"original_position":16,"commit_id":"76fe2ee93fa0e04b13033baac186226f194eb6b8","original_commit_id":"76fe2ee93fa0e04b13033baac186226f194eb6b8","user":{"login":"robertlong","id":1753624,"node_id":"MDQ6VXNlcjE3NTM2MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1753624?v=4","gravatar_id":"","url":"https://api.github.com/users/robertlong","html_url":"https://github.com/robertlong","followers_url":"https://api.github.com/users/robertlong/followers","following_url":"https://api.github.com/users/robertlong/following{/other_user}","gists_url":"https://api.github.com/users/robertlong/gists{/gist_id}","starred_url":"https://api.github.com/users/robertlong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertlong/subscriptions","organizations_url":"https://api.github.com/users/robertlong/orgs","repos_url":"https://api.github.com/users/robertlong/repos","events_url":"https://api.github.com/users/robertlong/events{/privacy}","received_events_url":"https://api.github.com/users/robertlong/received_events","type":"User","site_admin":false},"body":"Should we make scale a vector rather than a scalar value so that the non-uniform scale of persisted models can be set?","created_at":"2018-11-13T18:40:43Z","updated_at":"2018-11-13T18:45:59Z","html_url":"https://github.com/mozilla/hubs/pull/729#discussion_r233172325","pull_request_url":"https://api.github.com/repos/mozilla/hubs/pulls/729","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments/233172325"},"html":{"href":"https://github.com/mozilla/hubs/pull/729#discussion_r233172325"},"pull_request":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/729"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/hubs/pulls/729","id":230567218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTY3MjE4","html_url":"https://github.com/mozilla/hubs/pull/729","diff_url":"https://github.com/mozilla/hubs/pull/729.diff","patch_url":"https://github.com/mozilla/hubs/pull/729.patch","issue_url":"https://api.github.com/repos/mozilla/hubs/issues/729","number":729,"state":"open","locked":false,"title":"Add scale option to gltf model plus","user":{"login":"gfodor","id":220020,"node_id":"MDQ6VXNlcjIyMDAyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/220020?v=4","gravatar_id":"","url":"https://api.github.com/users/gfodor","html_url":"https://github.com/gfodor","followers_url":"https://api.github.com/users/gfodor/followers","following_url":"https://api.github.com/users/gfodor/following{/other_user}","gists_url":"https://api.github.com/users/gfodor/gists{/gist_id}","starred_url":"https://api.github.com/users/gfodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfodor/subscriptions","organizations_url":"https://api.github.com/users/gfodor/orgs","repos_url":"https://api.github.com/users/gfodor/repos","events_url":"https://api.github.com/users/gfodor/events{/privacy}","received_events_url":"https://api.github.com/users/gfodor/received_events","type":"User","site_admin":false},"body":"Address the long standing bug where when you paste a GLTF model you see it at the original scale for one frame (which is potentially huge.) Allows setting a scale modifier on the gltf-model-plus node which will be multiplied against the root object node's scale, and sets that to a small value so the object starts out small (and then is animated to the proper scale.)","created_at":"2018-11-13T17:43:56Z","updated_at":"2018-11-13T18:45:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e06723ad86e67725e18197797ec47f6333e6585","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/hubs/pulls/729/commits","review_comments_url":"https://api.github.com/repos/mozilla/hubs/pulls/729/comments","review_comment_url":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/hubs/issues/729/comments","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/76fe2ee93fa0e04b13033baac186226f194eb6b8","head":{"label":"mozilla:bug/bad-scale-for-one-frame","ref":"bug/bad-scale-for-one-frame","sha":"76fe2ee93fa0e04b13033baac186226f194eb6b8","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2018-11-13T17:33:16Z","pushed_at":"2018-11-13T18:39:48Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":98338,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":33,"open_issues":101,"watchers":155,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"b55c009d8154d030712094647293cac64ba92d10","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":104933644,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MzM2NDQ=","name":"hubs","full_name":"mozilla/hubs","private":false,"owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla/hubs","description":"Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.","fork":false,"url":"https://api.github.com/repos/mozilla/hubs","forks_url":"https://api.github.com/repos/mozilla/hubs/forks","keys_url":"https://api.github.com/repos/mozilla/hubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/hubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/hubs/teams","hooks_url":"https://api.github.com/repos/mozilla/hubs/hooks","issue_events_url":"https://api.github.com/repos/mozilla/hubs/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/hubs/events","assignees_url":"https://api.github.com/repos/mozilla/hubs/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/hubs/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/hubs/tags","blobs_url":"https://api.github.com/repos/mozilla/hubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/hubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/hubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/hubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/hubs/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/hubs/languages","stargazers_url":"https://api.github.com/repos/mozilla/hubs/stargazers","contributors_url":"https://api.github.com/repos/mozilla/hubs/contributors","subscribers_url":"https://api.github.com/repos/mozilla/hubs/subscribers","subscription_url":"https://api.github.com/repos/mozilla/hubs/subscription","commits_url":"https://api.github.com/repos/mozilla/hubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/hubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/hubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/hubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/hubs/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/hubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/hubs/merges","archive_url":"https://api.github.com/repos/mozilla/hubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/hubs/downloads","issues_url":"https://api.github.com/repos/mozilla/hubs/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/hubs/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/hubs/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/hubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/hubs/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/hubs/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/hubs/deployments","created_at":"2017-09-26T20:20:12Z","updated_at":"2018-11-13T17:33:16Z","pushed_at":"2018-11-13T18:39:48Z","git_url":"git://github.com/mozilla/hubs.git","ssh_url":"git@github.com:mozilla/hubs.git","clone_url":"https://github.com/mozilla/hubs.git","svn_url":"https://github.com/mozilla/hubs","homepage":"https://hubs.mozilla.com","size":98338,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":33,"open_issues":101,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/729"},"html":{"href":"https://github.com/mozilla/hubs/pull/729"},"issue":{"href":"https://api.github.com/repos/mozilla/hubs/issues/729"},"comments":{"href":"https://api.github.com/repos/mozilla/hubs/issues/729/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/729/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/hubs/pulls/729/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/hubs/statuses/76fe2ee93fa0e04b13033baac186226f194eb6b8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"robertlong"}}