{"action":"closed","number":102,"pull_request":{"url":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102","id":225062075,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDYyMDc1","html_url":"https://github.com/CelestiaProject/Celestia/pull/102","diff_url":"https://github.com/CelestiaProject/Celestia/pull/102.diff","patch_url":"https://github.com/CelestiaProject/Celestia/pull/102.patch","issue_url":"https://api.github.com/repos/CelestiaProject/Celestia/issues/102","number":102,"state":"closed","locked":false,"title":"[NOT FOR MERGE] VIP 3D audio implementation. Have known bugs.","user":{"login":"pirogronian","id":9281592,"node_id":"MDQ6VXNlcjkyODE1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9281592?v=4","gravatar_id":"","url":"https://api.github.com/users/pirogronian","html_url":"https://github.com/pirogronian","followers_url":"https://api.github.com/users/pirogronian/followers","following_url":"https://api.github.com/users/pirogronian/following{/other_user}","gists_url":"https://api.github.com/users/pirogronian/gists{/gist_id}","starred_url":"https://api.github.com/users/pirogronian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirogronian/subscriptions","organizations_url":"https://api.github.com/users/pirogronian/orgs","repos_url":"https://api.github.com/users/pirogronian/repos","events_url":"https://api.github.com/users/pirogronian/events{/privacy}","received_events_url":"https://api.github.com/users/pirogronian/received_events","type":"User","site_admin":false},"body":"However, if someone really wants... it's for now mergable, but hard to debug, due to lack of Lua interface. Interface will go after merging with LuaWrapper2 branche, which will go with its own PR.\r\n\r\nMentioned bugs are strange behaviour of sound. Maybe due to my misunderstanding of OpenAl parameters.\r\n\r\nTests can be done by editing qtappwin.cpp as follows:\r\n`index d84e7af9..331cd207 100644\r\n--- a/src/celestia/qt/qtappwin.cpp\r\n+++ b/src/celestia/qt/qtappwin.cpp\r\n@@ -407,9 +407,35 @@ void CelestiaAppWindow::init(const QString& qConfigFileName,\r\n     QTimer *t = new QTimer(dynamic_cast<QObject *>(this));\r\n     QObject::connect(t, SIGNAL(timeout()), SLOT(celestia_tick()));\r\n     t->start(0);\r\n+    \r\n+    \r\n+    \r\n+/*    t = new QTimer(this);\r\n+    QObject::connect(t, &QTimer::timeout, this, &CelestiaAppWindow::dumpAudio);\r\n+    t->start(1000);*/\r\n+    QAction *a = new QAction(\"Debug\", this);\r\n+    a->setShortcut(QKeySequence(\"Ctrl+Alt+D\"));\r\n+    connect(a, &QAction::triggered, this, &CelestiaAppWindow::dumpAudio);\r\n+    viewMenu->addAction(a);\r\n+\r\n+    Audio3D::Manager::setDopplerFactor(2);\r\n+    m_appCore->audio3dManager.setGlobalDistanceScale(0.0001);\r\n+    Selection sel = m_appCore->getSimulation()->findObjectFromPath(\"moon\");\r\n+    cout << sel.getName() << endl;\r\n+    AudioObject *o = m_appCore->audio3dManager.getAudioObject(sel);\r\n+    o->setTone(AudioTone::standardTone(432));\r\n+    //o->setPitch(100);\r\n+    //o->setGain(100);\r\n+    o->setMaxDistance(1000000);\r\n+    o->setLooping(true);\r\n+    o->play();\r\n }\r\n \r\n \r\n+void CelestiaAppWindow::dumpAudio() {\r\n+    m_appCore->audio3dManager.dump(m_appCore->getSimulation()->getTime());\r\n+}\r\n+\r\n /*! Set up the application data directory, creating it if necessary. The\r\n  *  directory contains user-specific, persistent information for Celestia\r\n  *  (such as bookmarks) which aren't stored in settings. The location`\r\n\r\nThen, run Celestia_QT, goto \"Moon\", should hear \"bzzz\" at 432 Hz, then slightly accelerate and try to rotate observer direction. Doppler effect appear to be twiced relatively to rotation circle. Is the same in opposite directions (180 deg) and opposite at orthogonal (90 deg).","created_at":"2018-10-23T14:28:41Z","updated_at":"2018-11-13T17:42:26Z","closed_at":"2018-11-13T17:42:26Z","merged_at":null,"merge_commit_sha":"899542359e24a783f7cc6528e1e8bf6b1fe59527","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102/commits","review_comments_url":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102/comments","review_comment_url":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CelestiaProject/Celestia/issues/102/comments","statuses_url":"https://api.github.com/repos/CelestiaProject/Celestia/statuses/b23fde50ff5e532720e582d92989ee7c0f7bf201","head":{"label":"pirogronian:Audio3D","ref":"Audio3D","sha":"b23fde50ff5e532720e582d92989ee7c0f7bf201","user":{"login":"pirogronian","id":9281592,"node_id":"MDQ6VXNlcjkyODE1OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9281592?v=4","gravatar_id":"","url":"https://api.github.com/users/pirogronian","html_url":"https://github.com/pirogronian","followers_url":"https://api.github.com/users/pirogronian/followers","following_url":"https://api.github.com/users/pirogronian/following{/other_user}","gists_url":"https://api.github.com/users/pirogronian/gists{/gist_id}","starred_url":"https://api.github.com/users/pirogronian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirogronian/subscriptions","organizations_url":"https://api.github.com/users/pirogronian/orgs","repos_url":"https://api.github.com/users/pirogronian/repos","events_url":"https://api.github.com/users/pirogronian/events{/privacy}","received_events_url":"https://api.github.com/users/pirogronian/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"CelestiaProject:main","ref":"main","sha":"80a1abbd523017e1b75053d0ec136b831a82960e","user":{"login":"CelestiaProject","id":21341474,"node_id":"MDQ6VXNlcjIxMzQxNDc0","avatar_url":"https://avatars1.githubusercontent.com/u/21341474?v=4","gravatar_id":"","url":"https://api.github.com/users/CelestiaProject","html_url":"https://github.com/CelestiaProject","followers_url":"https://api.github.com/users/CelestiaProject/followers","following_url":"https://api.github.com/users/CelestiaProject/following{/other_user}","gists_url":"https://api.github.com/users/CelestiaProject/gists{/gist_id}","starred_url":"https://api.github.com/users/CelestiaProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelestiaProject/subscriptions","organizations_url":"https://api.github.com/users/CelestiaProject/orgs","repos_url":"https://api.github.com/users/CelestiaProject/repos","events_url":"https://api.github.com/users/CelestiaProject/events{/privacy}","received_events_url":"https://api.github.com/users/CelestiaProject/received_events","type":"User","site_admin":false},"repo":{"id":72038007,"node_id":"MDEwOlJlcG9zaXRvcnk3MjAzODAwNw==","name":"Celestia","full_name":"CelestiaProject/Celestia","private":false,"owner":{"login":"CelestiaProject","id":21341474,"node_id":"MDQ6VXNlcjIxMzQxNDc0","avatar_url":"https://avatars1.githubusercontent.com/u/21341474?v=4","gravatar_id":"","url":"https://api.github.com/users/CelestiaProject","html_url":"https://github.com/CelestiaProject","followers_url":"https://api.github.com/users/CelestiaProject/followers","following_url":"https://api.github.com/users/CelestiaProject/following{/other_user}","gists_url":"https://api.github.com/users/CelestiaProject/gists{/gist_id}","starred_url":"https://api.github.com/users/CelestiaProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelestiaProject/subscriptions","organizations_url":"https://api.github.com/users/CelestiaProject/orgs","repos_url":"https://api.github.com/users/CelestiaProject/repos","events_url":"https://api.github.com/users/CelestiaProject/events{/privacy}","received_events_url":"https://api.github.com/users/CelestiaProject/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CelestiaProject/Celestia","description":"Real-time 3D visualization of space.","fork":false,"url":"https://api.github.com/repos/CelestiaProject/Celestia","forks_url":"https://api.github.com/repos/CelestiaProject/Celestia/forks","keys_url":"https://api.github.com/repos/CelestiaProject/Celestia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CelestiaProject/Celestia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CelestiaProject/Celestia/teams","hooks_url":"https://api.github.com/repos/CelestiaProject/Celestia/hooks","issue_events_url":"https://api.github.com/repos/CelestiaProject/Celestia/issues/events{/number}","events_url":"https://api.github.com/repos/CelestiaProject/Celestia/events","assignees_url":"https://api.github.com/repos/CelestiaProject/Celestia/assignees{/user}","branches_url":"https://api.github.com/repos/CelestiaProject/Celestia/branches{/branch}","tags_url":"https://api.github.com/repos/CelestiaProject/Celestia/tags","blobs_url":"https://api.github.com/repos/CelestiaProject/Celestia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CelestiaProject/Celestia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CelestiaProject/Celestia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CelestiaProject/Celestia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CelestiaProject/Celestia/statuses/{sha}","languages_url":"https://api.github.com/repos/CelestiaProject/Celestia/languages","stargazers_url":"https://api.github.com/repos/CelestiaProject/Celestia/stargazers","contributors_url":"https://api.github.com/repos/CelestiaProject/Celestia/contributors","subscribers_url":"https://api.github.com/repos/CelestiaProject/Celestia/subscribers","subscription_url":"https://api.github.com/repos/CelestiaProject/Celestia/subscription","commits_url":"https://api.github.com/repos/CelestiaProject/Celestia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CelestiaProject/Celestia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CelestiaProject/Celestia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CelestiaProject/Celestia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CelestiaProject/Celestia/contents/{+path}","compare_url":"https://api.github.com/repos/CelestiaProject/Celestia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CelestiaProject/Celestia/merges","archive_url":"https://api.github.com/repos/CelestiaProject/Celestia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CelestiaProject/Celestia/downloads","issues_url":"https://api.github.com/repos/CelestiaProject/Celestia/issues{/number}","pulls_url":"https://api.github.com/repos/CelestiaProject/Celestia/pulls{/number}","milestones_url":"https://api.github.com/repos/CelestiaProject/Celestia/milestones{/number}","notifications_url":"https://api.github.com/repos/CelestiaProject/Celestia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CelestiaProject/Celestia/labels{/name}","releases_url":"https://api.github.com/repos/CelestiaProject/Celestia/releases{/id}","deployments_url":"https://api.github.com/repos/CelestiaProject/Celestia/deployments","created_at":"2016-10-26T19:37:31Z","updated_at":"2018-11-12T20:24:40Z","pushed_at":"2018-11-13T17:42:25Z","git_url":"git://github.com/CelestiaProject/Celestia.git","ssh_url":"git@github.com:CelestiaProject/Celestia.git","clone_url":"https://github.com/CelestiaProject/Celestia.git","svn_url":"https://github.com/CelestiaProject/Celestia","homepage":"https://celestia.space/","size":215754,"stargazers_count":216,"watchers_count":216,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":61,"open_issues":19,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102"},"html":{"href":"https://github.com/CelestiaProject/Celestia/pull/102"},"issue":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/issues/102"},"comments":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/CelestiaProject/Celestia/statuses/b23fde50ff5e532720e582d92989ee7c0f7bf201"}},"author_association":"COLLABORATOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":26,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"375gnu"}}