{"action":"created","issue":{"url":"https://api.github.com/repos/IntelVCL/Open3D/issues/298","repository_url":"https://api.github.com/repos/IntelVCL/Open3D","labels_url":"https://api.github.com/repos/IntelVCL/Open3D/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/IntelVCL/Open3D/issues/298/comments","events_url":"https://api.github.com/repos/IntelVCL/Open3D/issues/298/events","html_url":"https://github.com/IntelVCL/Open3D/pull/298","id":313653361,"number":298,"title":"Missing install rules","user":{"login":"Sahloul","id":6416713,"avatar_url":"https://avatars1.githubusercontent.com/u/6416713?v=4","gravatar_id":"","url":"https://api.github.com/users/Sahloul","html_url":"https://github.com/Sahloul","followers_url":"https://api.github.com/users/Sahloul/followers","following_url":"https://api.github.com/users/Sahloul/following{/other_user}","gists_url":"https://api.github.com/users/Sahloul/gists{/gist_id}","starred_url":"https://api.github.com/users/Sahloul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sahloul/subscriptions","organizations_url":"https://api.github.com/users/Sahloul/orgs","repos_url":"https://api.github.com/users/Sahloul/repos","events_url":"https://api.github.com/users/Sahloul/events{/privacy}","received_events_url":"https://api.github.com/users/Sahloul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-04-12T09:48:30Z","updated_at":"2018-04-13T08:33:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/IntelVCL/Open3D/pulls/298","html_url":"https://github.com/IntelVCL/Open3D/pull/298","diff_url":"https://github.com/IntelVCL/Open3D/pull/298.diff","patch_url":"https://github.com/IntelVCL/Open3D/pull/298.patch"},"body":"The current CMake rules does not include a lot of install instruction. While this does not meet [the final requirements](https://github.com/IntelVCL/Open3D/pull/291#issuecomment-380706693), it is a step towards enabling CMake to search for Open3D, and to be included it in other libraries.\r\n\r\nrelated #130\r\n\r\n#### Changes:\r\n- Installs the built experimental binaries in `bin` directory\r\n- Installs the header files in `include` directory in a maintained structure\r\n  - Internal header files are in `include/Open3D`\r\n  - External header files are in `include/External/[LIB_NAME]`\r\n- Installs the built libraries in `lib` directory\r\n- Installs the python library and tutorials in `python` directory\r\n  - The python lib gets into `python/lib` (in addition to the installed version in the site packages)\r\n  - The python tutorials gets into `python/Tutorial` in a maintained structure\r\n- Installs the test binaries and data in `test` directory\r\n  - The test execs are in the `test/bin` direcory\r\n  - The test data are in the `test/TestData` directory\r\n\r\nAdditionally, this PR:\r\n- Reorganized the tests sources into separate folders with each having own CMakeLists\r\n- Updated the `TestData` path in various scripts"},"comment":{"url":"https://api.github.com/repos/IntelVCL/Open3D/issues/comments/381064880","html_url":"https://github.com/IntelVCL/Open3D/pull/298#issuecomment-381064880","issue_url":"https://api.github.com/repos/IntelVCL/Open3D/issues/298","id":381064880,"user":{"login":"takanokage","id":2706828,"avatar_url":"https://avatars1.githubusercontent.com/u/2706828?v=4","gravatar_id":"","url":"https://api.github.com/users/takanokage","html_url":"https://github.com/takanokage","followers_url":"https://api.github.com/users/takanokage/followers","following_url":"https://api.github.com/users/takanokage/following{/other_user}","gists_url":"https://api.github.com/users/takanokage/gists{/gist_id}","starred_url":"https://api.github.com/users/takanokage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takanokage/subscriptions","organizations_url":"https://api.github.com/users/takanokage/orgs","repos_url":"https://api.github.com/users/takanokage/repos","events_url":"https://api.github.com/users/takanokage/events{/privacy}","received_events_url":"https://api.github.com/users/takanokage/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T08:33:00Z","updated_at":"2018-04-13T08:33:00Z","author_association":"CONTRIBUTOR","body":"@sahloul: your version is more advanced for sure, I got stuck trying to fix this issue I mentioned.\r\n\r\nthe path thing could wait until after this PR if we want to change it to `~/.local`."}}
{"actor":{"display_login":"takanokage"}}