{"action":"created","comment":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/242224943","pull_request_review_id":185686912,"id":242224943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjIyNDk0Mw==","diff_hunk":"@@ -113,21 +113,22 @@ wl_status_t ESP8266WiFiSTAClass::begin(const char* ssid, const char *passphrase,\n         return WL_CONNECT_FAILED;\r\n     }\r\n \r\n-    if(passphrase && strlen(passphrase) > 64) {\r\n+    int passphrase_len = passphrase == NULL ? 0 : strlen(passphrase);\r\n+    if(passphrase_len > 64) {\r\n         // fail passphrase too long!\r\n         return WL_CONNECT_FAILED;\r\n     }\r\n \r\n     struct station_config conf;\r\n+    conf.threshold.authmode = passphrase_len == 0 ? AUTH_OPEN : _useInsecureWEP ? AUTH_WEP : AUTH_WPA_PSK;\r","path":"libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp","position":null,"original_position":12,"commit_id":"b37fe5ad9ba5f78978b8fb4d1b3e10666b561c7a","original_commit_id":"18098cbb46c2d3bd28f6a7b1aeb739f0d9a0a24a","user":{"login":"acevest","id":7140471,"node_id":"MDQ6VXNlcjcxNDA0NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7140471?v=4","gravatar_id":"","url":"https://api.github.com/users/acevest","html_url":"https://github.com/acevest","followers_url":"https://api.github.com/users/acevest/followers","following_url":"https://api.github.com/users/acevest/following{/other_user}","gists_url":"https://api.github.com/users/acevest/gists{/gist_id}","starred_url":"https://api.github.com/users/acevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acevest/subscriptions","organizations_url":"https://api.github.com/users/acevest/orgs","repos_url":"https://api.github.com/users/acevest/repos","events_url":"https://api.github.com/users/acevest/events{/privacy}","received_events_url":"https://api.github.com/users/acevest/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-12-17T16:44:37Z","updated_at":"2018-12-17T16:44:38Z","html_url":"https://github.com/esp8266/Arduino/pull/5516#discussion_r242224943","pull_request_url":"https://api.github.com/repos/esp8266/Arduino/pulls/5516","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/242224943"},"html":{"href":"https://github.com/esp8266/Arduino/pull/5516#discussion_r242224943"},"pull_request":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/5516"}},"in_reply_to_id":242206810},"pull_request":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/5516","id":239179772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTc5Nzcy","html_url":"https://github.com/esp8266/Arduino/pull/5516","diff_url":"https://github.com/esp8266/Arduino/pull/5516.diff","patch_url":"https://github.com/esp8266/Arduino/pull/5516.patch","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/5516","number":5516,"state":"open","locked":false,"title":"fix bug. in sta mode, empty passphrase should not use secure auth mode","user":{"login":"acevest","id":7140471,"node_id":"MDQ6VXNlcjcxNDA0NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7140471?v=4","gravatar_id":"","url":"https://api.github.com/users/acevest","html_url":"https://github.com/acevest","followers_url":"https://api.github.com/users/acevest/followers","following_url":"https://api.github.com/users/acevest/following{/other_user}","gists_url":"https://api.github.com/users/acevest/gists{/gist_id}","starred_url":"https://api.github.com/users/acevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acevest/subscriptions","organizations_url":"https://api.github.com/users/acevest/orgs","repos_url":"https://api.github.com/users/acevest/repos","events_url":"https://api.github.com/users/acevest/events{/privacy}","received_events_url":"https://api.github.com/users/acevest/received_events","type":"User","site_admin":false},"body":"if the passphrase is empty, use secure auth mode could not connect to wifi.","created_at":"2018-12-17T15:15:46Z","updated_at":"2018-12-17T16:44:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f5556b1781dab069ce01174747c89ff23ff3465","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/esp8266/Arduino/pulls/5516/commits","review_comments_url":"https://api.github.com/repos/esp8266/Arduino/pulls/5516/comments","review_comment_url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/5516/comments","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/b37fe5ad9ba5f78978b8fb4d1b3e10666b561c7a","head":{"label":"acevest:master","ref":"master","sha":"b37fe5ad9ba5f78978b8fb4d1b3e10666b561c7a","user":{"login":"acevest","id":7140471,"node_id":"MDQ6VXNlcjcxNDA0NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7140471?v=4","gravatar_id":"","url":"https://api.github.com/users/acevest","html_url":"https://github.com/acevest","followers_url":"https://api.github.com/users/acevest/followers","following_url":"https://api.github.com/users/acevest/following{/other_user}","gists_url":"https://api.github.com/users/acevest/gists{/gist_id}","starred_url":"https://api.github.com/users/acevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acevest/subscriptions","organizations_url":"https://api.github.com/users/acevest/orgs","repos_url":"https://api.github.com/users/acevest/repos","events_url":"https://api.github.com/users/acevest/events{/privacy}","received_events_url":"https://api.github.com/users/acevest/received_events","type":"User","site_admin":false},"repo":{"id":162148409,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNDg0MDk=","name":"Arduino","full_name":"acevest/Arduino","private":false,"owner":{"login":"acevest","id":7140471,"node_id":"MDQ6VXNlcjcxNDA0NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/7140471?v=4","gravatar_id":"","url":"https://api.github.com/users/acevest","html_url":"https://github.com/acevest","followers_url":"https://api.github.com/users/acevest/followers","following_url":"https://api.github.com/users/acevest/following{/other_user}","gists_url":"https://api.github.com/users/acevest/gists{/gist_id}","starred_url":"https://api.github.com/users/acevest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acevest/subscriptions","organizations_url":"https://api.github.com/users/acevest/orgs","repos_url":"https://api.github.com/users/acevest/repos","events_url":"https://api.github.com/users/acevest/events{/privacy}","received_events_url":"https://api.github.com/users/acevest/received_events","type":"User","site_admin":false},"html_url":"https://github.com/acevest/Arduino","description":"ESP8266 core for Arduino","fork":true,"url":"https://api.github.com/repos/acevest/Arduino","forks_url":"https://api.github.com/repos/acevest/Arduino/forks","keys_url":"https://api.github.com/repos/acevest/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acevest/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acevest/Arduino/teams","hooks_url":"https://api.github.com/repos/acevest/Arduino/hooks","issue_events_url":"https://api.github.com/repos/acevest/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/acevest/Arduino/events","assignees_url":"https://api.github.com/repos/acevest/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/acevest/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/acevest/Arduino/tags","blobs_url":"https://api.github.com/repos/acevest/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acevest/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acevest/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/acevest/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acevest/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/acevest/Arduino/languages","stargazers_url":"https://api.github.com/repos/acevest/Arduino/stargazers","contributors_url":"https://api.github.com/repos/acevest/Arduino/contributors","subscribers_url":"https://api.github.com/repos/acevest/Arduino/subscribers","subscription_url":"https://api.github.com/repos/acevest/Arduino/subscription","commits_url":"https://api.github.com/repos/acevest/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/acevest/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/acevest/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/acevest/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/acevest/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/acevest/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acevest/Arduino/merges","archive_url":"https://api.github.com/repos/acevest/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acevest/Arduino/downloads","issues_url":"https://api.github.com/repos/acevest/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/acevest/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/acevest/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/acevest/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acevest/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/acevest/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/acevest/Arduino/deployments","created_at":"2018-12-17T15:07:44Z","updated_at":"2018-12-17T16:39:52Z","pushed_at":"2018-12-17T16:39:46Z","git_url":"git://github.com/acevest/Arduino.git","ssh_url":"git@github.com:acevest/Arduino.git","clone_url":"https://github.com/acevest/Arduino.git","svn_url":"https://github.com/acevest/Arduino","homepage":"","size":67604,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esp8266:master","ref":"master","sha":"c88953b7421a916183ca46dd1c7a6e45c71d3e1c","user":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"repo":{"id":32969220,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk2OTIyMA==","name":"Arduino","full_name":"esp8266/Arduino","private":false,"owner":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/esp8266/Arduino","description":"ESP8266 core for Arduino","fork":false,"url":"https://api.github.com/repos/esp8266/Arduino","forks_url":"https://api.github.com/repos/esp8266/Arduino/forks","keys_url":"https://api.github.com/repos/esp8266/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esp8266/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esp8266/Arduino/teams","hooks_url":"https://api.github.com/repos/esp8266/Arduino/hooks","issue_events_url":"https://api.github.com/repos/esp8266/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/esp8266/Arduino/events","assignees_url":"https://api.github.com/repos/esp8266/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/esp8266/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/esp8266/Arduino/tags","blobs_url":"https://api.github.com/repos/esp8266/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esp8266/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esp8266/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/esp8266/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/esp8266/Arduino/languages","stargazers_url":"https://api.github.com/repos/esp8266/Arduino/stargazers","contributors_url":"https://api.github.com/repos/esp8266/Arduino/contributors","subscribers_url":"https://api.github.com/repos/esp8266/Arduino/subscribers","subscription_url":"https://api.github.com/repos/esp8266/Arduino/subscription","commits_url":"https://api.github.com/repos/esp8266/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/esp8266/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/esp8266/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/esp8266/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/esp8266/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/esp8266/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esp8266/Arduino/merges","archive_url":"https://api.github.com/repos/esp8266/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esp8266/Arduino/downloads","issues_url":"https://api.github.com/repos/esp8266/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/esp8266/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/esp8266/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/esp8266/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esp8266/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/esp8266/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/esp8266/Arduino/deployments","created_at":"2015-03-27T05:22:06Z","updated_at":"2018-12-17T15:55:37Z","pushed_at":"2018-12-17T16:39:52Z","git_url":"git://github.com/esp8266/Arduino.git","ssh_url":"git@github.com:esp8266/Arduino.git","clone_url":"https://github.com/esp8266/Arduino.git","svn_url":"https://github.com/esp8266/Arduino","homepage":"","size":67618,"stargazers_count":8467,"watchers_count":8467,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5893,"mirror_url":null,"archived":false,"open_issues_count":468,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":5893,"open_issues":468,"watchers":8467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/5516"},"html":{"href":"https://github.com/esp8266/Arduino/pull/5516"},"issue":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/5516"},"comments":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/5516/comments"},"review_comments":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/5516/comments"},"review_comment":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/5516/commits"},"statuses":{"href":"https://api.github.com/repos/esp8266/Arduino/statuses/b37fe5ad9ba5f78978b8fb4d1b3e10666b561c7a"}},"author_association":"NONE"}}
{"actor":{"display_login":"acevest"}}