{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/179601670","pull_request_review_id":109878332,"id":179601670,"diff_hunk":"@@ -168,6 +170,24 @@ public function testMetadataCacheWithRuntimeConstraint()\n \n         $metadata = $factory->getMetadataFor(self::CLASS_NAME);\n     }\n+\n+    public function testNonClassNameStringValues()\n+    {\n+        $testedValue = 'error@example.com';\n+        $loader = $this->getMockBuilder('Symfony\\Component\\Validator\\Mapping\\Loader\\LoaderInterface')->getMock();\n+        $cache = $this->getMockBuilder('Symfony\\Component\\Validator\\Mapping\\Cache\\CacheInterface')->getMock();\n+        $factory = new LazyLoadingMetadataFactory($loader, $cache);\n+        $cache\n+            ->method('read')\n+            ->with($testedValue)\n+            ->willThrowException(new InvalidArgumentException(sprintf('Cache key \"%s\" contains reserved characters {}()/\\@:', $testedValue)));","path":"src/Symfony/Component/Validator/Tests/Mapping/Factory/LazyLoadingMetadataFactoryTest.php","position":24,"original_position":24,"commit_id":"e5e5a41e9bbbee62d525c5b84326ec4d96b64927","original_commit_id":"e5e5a41e9bbbee62d525c5b84326ec4d96b64927","user":{"login":"dmaicher","id":921145,"avatar_url":"https://avatars3.githubusercontent.com/u/921145?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaicher","html_url":"https://github.com/dmaicher","followers_url":"https://api.github.com/users/dmaicher/followers","following_url":"https://api.github.com/users/dmaicher/following{/other_user}","gists_url":"https://api.github.com/users/dmaicher/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaicher/subscriptions","organizations_url":"https://api.github.com/users/dmaicher/orgs","repos_url":"https://api.github.com/users/dmaicher/repos","events_url":"https://api.github.com/users/dmaicher/events{/privacy}","received_events_url":"https://api.github.com/users/dmaicher/received_events","type":"User","site_admin":false},"body":"just assert that we never actually call the `$cache->read(...)`?","created_at":"2018-04-05T21:09:18Z","updated_at":"2018-04-05T21:10:24Z","html_url":"https://github.com/symfony/symfony/pull/26823#discussion_r179601670","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/26823","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/179601670"},"html":{"href":"https://github.com/symfony/symfony/pull/26823#discussion_r179601670"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26823"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26823","id":179790367,"html_url":"https://github.com/symfony/symfony/pull/26823","diff_url":"https://github.com/symfony/symfony/pull/26823.diff","patch_url":"https://github.com/symfony/symfony/pull/26823.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26823","number":26823,"state":"open","locked":false,"title":"[Validator] Fix LazyLoadingMetadataFactory with PSR6Cache for non cla…","user":{"login":"pmontoya","id":783956,"avatar_url":"https://avatars1.githubusercontent.com/u/783956?v=4","gravatar_id":"","url":"https://api.github.com/users/pmontoya","html_url":"https://github.com/pmontoya","followers_url":"https://api.github.com/users/pmontoya/followers","following_url":"https://api.github.com/users/pmontoya/following{/other_user}","gists_url":"https://api.github.com/users/pmontoya/gists{/gist_id}","starred_url":"https://api.github.com/users/pmontoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmontoya/subscriptions","organizations_url":"https://api.github.com/users/pmontoya/orgs","repos_url":"https://api.github.com/users/pmontoya/repos","events_url":"https://api.github.com/users/pmontoya/events{/privacy}","received_events_url":"https://api.github.com/users/pmontoya/received_events","type":"User","site_admin":false},"body":"…ssname if tested values isn't existing class\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.1\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #26313\r\n| License       | MIT\r\n\r\nIf @Assert\\Valid is applied to a string value, the value is searched in metadata cache and some characters aren't allowed in this cache. This create an unexpected exception.\r\n\r\nClass existence is now tested before cache read.\r\n","created_at":"2018-04-05T20:40:24Z","updated_at":"2018-04-05T21:10:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a31416c927b28454e8fd89ad3ee80b1a7dc3e37a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100079,"url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false},{"id":99599,"url":"https://api.github.com/repos/symfony/symfony/labels/Validator","name":"Validator","color":"DDDDDD","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/26823/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/26823/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26823/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/e5e5a41e9bbbee62d525c5b84326ec4d96b64927","head":{"label":"pmontoya:bug-26313","ref":"bug-26313","sha":"e5e5a41e9bbbee62d525c5b84326ec4d96b64927","user":{"login":"pmontoya","id":783956,"avatar_url":"https://avatars1.githubusercontent.com/u/783956?v=4","gravatar_id":"","url":"https://api.github.com/users/pmontoya","html_url":"https://github.com/pmontoya","followers_url":"https://api.github.com/users/pmontoya/followers","following_url":"https://api.github.com/users/pmontoya/following{/other_user}","gists_url":"https://api.github.com/users/pmontoya/gists{/gist_id}","starred_url":"https://api.github.com/users/pmontoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmontoya/subscriptions","organizations_url":"https://api.github.com/users/pmontoya/orgs","repos_url":"https://api.github.com/users/pmontoya/repos","events_url":"https://api.github.com/users/pmontoya/events{/privacy}","received_events_url":"https://api.github.com/users/pmontoya/received_events","type":"User","site_admin":false},"repo":{"id":128242981,"name":"symfony","full_name":"pmontoya/symfony","owner":{"login":"pmontoya","id":783956,"avatar_url":"https://avatars1.githubusercontent.com/u/783956?v=4","gravatar_id":"","url":"https://api.github.com/users/pmontoya","html_url":"https://github.com/pmontoya","followers_url":"https://api.github.com/users/pmontoya/followers","following_url":"https://api.github.com/users/pmontoya/following{/other_user}","gists_url":"https://api.github.com/users/pmontoya/gists{/gist_id}","starred_url":"https://api.github.com/users/pmontoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmontoya/subscriptions","organizations_url":"https://api.github.com/users/pmontoya/orgs","repos_url":"https://api.github.com/users/pmontoya/repos","events_url":"https://api.github.com/users/pmontoya/events{/privacy}","received_events_url":"https://api.github.com/users/pmontoya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmontoya/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/pmontoya/symfony","forks_url":"https://api.github.com/repos/pmontoya/symfony/forks","keys_url":"https://api.github.com/repos/pmontoya/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmontoya/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmontoya/symfony/teams","hooks_url":"https://api.github.com/repos/pmontoya/symfony/hooks","issue_events_url":"https://api.github.com/repos/pmontoya/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/pmontoya/symfony/events","assignees_url":"https://api.github.com/repos/pmontoya/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/pmontoya/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/pmontoya/symfony/tags","blobs_url":"https://api.github.com/repos/pmontoya/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmontoya/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmontoya/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmontoya/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmontoya/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/pmontoya/symfony/languages","stargazers_url":"https://api.github.com/repos/pmontoya/symfony/stargazers","contributors_url":"https://api.github.com/repos/pmontoya/symfony/contributors","subscribers_url":"https://api.github.com/repos/pmontoya/symfony/subscribers","subscription_url":"https://api.github.com/repos/pmontoya/symfony/subscription","commits_url":"https://api.github.com/repos/pmontoya/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmontoya/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmontoya/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmontoya/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmontoya/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/pmontoya/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmontoya/symfony/merges","archive_url":"https://api.github.com/repos/pmontoya/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmontoya/symfony/downloads","issues_url":"https://api.github.com/repos/pmontoya/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/pmontoya/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/pmontoya/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/pmontoya/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmontoya/symfony/labels{/name}","releases_url":"https://api.github.com/repos/pmontoya/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/pmontoya/symfony/deployments","created_at":"2018-04-05T17:47:44Z","updated_at":"2018-04-05T20:28:10Z","pushed_at":"2018-04-05T20:56:10Z","git_url":"git://github.com/pmontoya/symfony.git","ssh_url":"git@github.com:pmontoya/symfony.git","clone_url":"https://github.com/pmontoya/symfony.git","svn_url":"https://github.com/pmontoya/symfony","homepage":"https://symfony.com","size":110988,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:3.1","ref":"3.1","sha":"96e7dede3ddc9e3b3392f5cc93e26eca77545a89","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-04-05T20:08:01Z","pushed_at":"2018-04-05T20:56:13Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":115544,"stargazers_count":17189,"watchers_count":17189,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6141,"mirror_url":null,"archived":false,"open_issues_count":783,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6141,"open_issues":783,"watchers":17189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26823"},"html":{"href":"https://github.com/symfony/symfony/pull/26823"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/26823"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/26823/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26823/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26823/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/e5e5a41e9bbbee62d525c5b84326ec4d96b64927"}},"author_association":"NONE"}}
{"actor":{"display_login":"dmaicher"}}