{"action":"created","issue":{"url":"https://api.github.com/repos/shaih/HElib/issues/192","repository_url":"https://api.github.com/repos/shaih/HElib","labels_url":"https://api.github.com/repos/shaih/HElib/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/shaih/HElib/issues/192/comments","events_url":"https://api.github.com/repos/shaih/HElib/issues/192/events","html_url":"https://github.com/shaih/HElib/issues/192","id":304063675,"number":192,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-10T11:32:21Z","updated_at":"2018-03-10T16:30:17Z","closed_at":null,"author_association":"NONE","body":"I would like to point out that identifiers like “[`_CModulus_H_`](https://github.com/shaih/HElib/blob/ef0f6b54729d3ec914dcc4b92f18c138f88df777/src/CModulus.h#L12 \"Update candidate\")” and “[`_FHE_H_`](https://github.com/shaih/HElib/blob/23802e37bbfdeeb486d8c375caaffa5200762272/src/FHE.h#L13 \"Another update candidate\")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not declare an identifier which is reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/shaih/HElib/issues/comments/372042763","html_url":"https://github.com/shaih/HElib/issues/192#issuecomment-372042763","issue_url":"https://api.github.com/repos/shaih/HElib/issues/192","id":372042763,"user":{"login":"elfring","id":660477,"avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T16:30:17Z","updated_at":"2018-03-10T16:30:17Z","author_association":"NONE","body":"I suggest to take another look at [the usage of reserved identifiers](http://en.cppreference.com/w/c/language/identifier#Reserved_identifiers \"Rules for the selection of reserved identifiers\")."}}
{"actor":{"display_login":"elfring"}}