{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments/217607784","pull_request_review_id":155355092,"id":217607784,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzYwNzc4NA==","diff_hunk":"@@ -120,4 +139,52 @@ export default class ComparisonStore {\n \n         return selectedColor;\n     }\n+\n+    @action.bound onSymbolChange({ action : symbolAction }) {\n+        if (symbolAction === 'master') {\n+            const { stx } = this.context;\n+            this.comparisonSymbols = [];","path":"src/store/ComparisonStore.js","position":85,"original_position":85,"commit_id":"e278450fcce6057fe4167132dd82a8fac835b67e","original_commit_id":"e278450fcce6057fe4167132dd82a8fac835b67e","user":{"login":"MahboobehMohammadi","id":3080372,"node_id":"MDQ6VXNlcjMwODAzNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3080372?v=4","gravatar_id":"","url":"https://api.github.com/users/MahboobehMohammadi","html_url":"https://github.com/MahboobehMohammadi","followers_url":"https://api.github.com/users/MahboobehMohammadi/followers","following_url":"https://api.github.com/users/MahboobehMohammadi/following{/other_user}","gists_url":"https://api.github.com/users/MahboobehMohammadi/gists{/gist_id}","starred_url":"https://api.github.com/users/MahboobehMohammadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MahboobehMohammadi/subscriptions","organizations_url":"https://api.github.com/users/MahboobehMohammadi/orgs","repos_url":"https://api.github.com/users/MahboobehMohammadi/repos","events_url":"https://api.github.com/users/MahboobehMohammadi/events{/privacy}","received_events_url":"https://api.github.com/users/MahboobehMohammadi/received_events","type":"User","site_admin":false},"body":"@brucebinary If internet stays offline for a wile and the go back online the compariosn list will be cleared because the chart is being refreshed and `onSymbolChange` will be raised, i suppose.","created_at":"2018-09-14T06:00:00Z","updated_at":"2018-09-14T06:00:15Z","html_url":"https://github.com/binary-com/SmartCharts/pull/517#discussion_r217607784","pull_request_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments/217607784"},"html":{"href":"https://github.com/binary-com/SmartCharts/pull/517#discussion_r217607784"},"pull_request":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517","id":214519199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTE5MTk5","html_url":"https://github.com/binary-com/SmartCharts/pull/517","diff_url":"https://github.com/binary-com/SmartCharts/pull/517.diff","patch_url":"https://github.com/binary-com/SmartCharts/pull/517.patch","issue_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/517","number":517,"state":"open","locked":false,"title":"bug fix: delayed feeds and feed on reconnection up down incorrect","user":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"body":"Bug is due to `Feed`: when feed updates, [`quotes[0]` is sent to `EVENT_MASTER_DATA_UPDATE` event instead of the latest quote](https://github.com/binary-com/SmartCharts/pull/517/files#diff-89a32bcd5fee3aaeede35461b969600fL240). Also, `EVENT_COMPARISON_DATA_UPDATE` does not have send out the updated quotes. This PR resolves this by [emitting both the current close and previous close (when available) in the event](https://github.com/binary-com/SmartCharts/pull/517/files#diff-89a32bcd5fee3aaeede35461b969600fR235)\r\n\r\nComparisons refactor:\r\n\r\n - Separation of concerns: comparison operations are now moved from `ChartStore` to `ComparisonStore`\r\n - [Use smaller components](https://mobx.js.org/best/react-performance.html#use-many-small-components): added `< ComparisonListItem />`\r\n ","created_at":"2018-09-11T05:52:31Z","updated_at":"2018-09-14T06:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2d04dc263c320d12f3cdee05290ef3c60cb408e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517/commits","review_comments_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517/comments","review_comment_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/517/comments","statuses_url":"https://api.github.com/repos/binary-com/SmartCharts/statuses/e278450fcce6057fe4167132dd82a8fac835b67e","head":{"label":"brucebinary:quote-update-compare-fix","ref":"quote-update-compare-fix","sha":"e278450fcce6057fe4167132dd82a8fac835b67e","user":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"repo":{"id":127390473,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczOTA0NzM=","name":"SmartCharts","full_name":"brucebinary/SmartCharts","owner":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brucebinary/SmartCharts","description":null,"fork":true,"url":"https://api.github.com/repos/brucebinary/SmartCharts","forks_url":"https://api.github.com/repos/brucebinary/SmartCharts/forks","keys_url":"https://api.github.com/repos/brucebinary/SmartCharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brucebinary/SmartCharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brucebinary/SmartCharts/teams","hooks_url":"https://api.github.com/repos/brucebinary/SmartCharts/hooks","issue_events_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues/events{/number}","events_url":"https://api.github.com/repos/brucebinary/SmartCharts/events","assignees_url":"https://api.github.com/repos/brucebinary/SmartCharts/assignees{/user}","branches_url":"https://api.github.com/repos/brucebinary/SmartCharts/branches{/branch}","tags_url":"https://api.github.com/repos/brucebinary/SmartCharts/tags","blobs_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brucebinary/SmartCharts/statuses/{sha}","languages_url":"https://api.github.com/repos/brucebinary/SmartCharts/languages","stargazers_url":"https://api.github.com/repos/brucebinary/SmartCharts/stargazers","contributors_url":"https://api.github.com/repos/brucebinary/SmartCharts/contributors","subscribers_url":"https://api.github.com/repos/brucebinary/SmartCharts/subscribers","subscription_url":"https://api.github.com/repos/brucebinary/SmartCharts/subscription","commits_url":"https://api.github.com/repos/brucebinary/SmartCharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/brucebinary/SmartCharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/brucebinary/SmartCharts/contents/{+path}","compare_url":"https://api.github.com/repos/brucebinary/SmartCharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brucebinary/SmartCharts/merges","archive_url":"https://api.github.com/repos/brucebinary/SmartCharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brucebinary/SmartCharts/downloads","issues_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues{/number}","pulls_url":"https://api.github.com/repos/brucebinary/SmartCharts/pulls{/number}","milestones_url":"https://api.github.com/repos/brucebinary/SmartCharts/milestones{/number}","notifications_url":"https://api.github.com/repos/brucebinary/SmartCharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brucebinary/SmartCharts/labels{/name}","releases_url":"https://api.github.com/repos/brucebinary/SmartCharts/releases{/id}","deployments_url":"https://api.github.com/repos/brucebinary/SmartCharts/deployments","created_at":"2018-03-30T06:27:21Z","updated_at":"2018-08-06T03:45:09Z","pushed_at":"2018-09-13T10:02:47Z","git_url":"git://github.com/brucebinary/SmartCharts.git","ssh_url":"git@github.com:brucebinary/SmartCharts.git","clone_url":"https://github.com/brucebinary/SmartCharts.git","svn_url":"https://github.com/brucebinary/SmartCharts","homepage":null,"size":41329,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"binary-com:dev","ref":"dev","sha":"1a728331f164033f7626c684d53f0fb16c528885","user":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":115597557,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU1OTc1NTc=","name":"SmartCharts","full_name":"binary-com/SmartCharts","owner":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binary-com/SmartCharts","description":null,"fork":false,"url":"https://api.github.com/repos/binary-com/SmartCharts","forks_url":"https://api.github.com/repos/binary-com/SmartCharts/forks","keys_url":"https://api.github.com/repos/binary-com/SmartCharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/SmartCharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/SmartCharts/teams","hooks_url":"https://api.github.com/repos/binary-com/SmartCharts/hooks","issue_events_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/SmartCharts/events","assignees_url":"https://api.github.com/repos/binary-com/SmartCharts/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/SmartCharts/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/SmartCharts/tags","blobs_url":"https://api.github.com/repos/binary-com/SmartCharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/SmartCharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/SmartCharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/SmartCharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/SmartCharts/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/SmartCharts/languages","stargazers_url":"https://api.github.com/repos/binary-com/SmartCharts/stargazers","contributors_url":"https://api.github.com/repos/binary-com/SmartCharts/contributors","subscribers_url":"https://api.github.com/repos/binary-com/SmartCharts/subscribers","subscription_url":"https://api.github.com/repos/binary-com/SmartCharts/subscription","commits_url":"https://api.github.com/repos/binary-com/SmartCharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/SmartCharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/SmartCharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/SmartCharts/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/SmartCharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/SmartCharts/merges","archive_url":"https://api.github.com/repos/binary-com/SmartCharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/SmartCharts/downloads","issues_url":"https://api.github.com/repos/binary-com/SmartCharts/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/SmartCharts/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/SmartCharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/SmartCharts/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/SmartCharts/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/SmartCharts/deployments","created_at":"2017-12-28T07:28:49Z","updated_at":"2018-09-14T01:22:11Z","pushed_at":"2018-09-14T03:57:14Z","git_url":"git://github.com/binary-com/SmartCharts.git","ssh_url":"git@github.com:binary-com/SmartCharts.git","clone_url":"https://github.com/binary-com/SmartCharts.git","svn_url":"https://github.com/binary-com/SmartCharts","homepage":null,"size":61705,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":10,"open_issues":16,"watchers":6,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517"},"html":{"href":"https://github.com/binary-com/SmartCharts/pull/517"},"issue":{"href":"https://api.github.com/repos/binary-com/SmartCharts/issues/517"},"comments":{"href":"https://api.github.com/repos/binary-com/SmartCharts/issues/517/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/517/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/SmartCharts/statuses/e278450fcce6057fe4167132dd82a8fac835b67e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MahboobehMohammadi"}}