{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70156","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70156/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70156/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70156/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70156","id":373275845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjQzMjU2","number":70156,"title":"Removes PQDNs from conformance tests and places them in their own tests","user":{"login":"nagiesek","id":42627479,"node_id":"MDQ6VXNlcjQyNjI3NDc5","avatar_url":"https://avatars0.githubusercontent.com/u/42627479?v=4","gravatar_id":"","url":"https://api.github.com/users/nagiesek","html_url":"https://github.com/nagiesek","followers_url":"https://api.github.com/users/nagiesek/followers","following_url":"https://api.github.com/users/nagiesek/following{/other_user}","gists_url":"https://api.github.com/users/nagiesek/gists{/gist_id}","starred_url":"https://api.github.com/users/nagiesek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagiesek/subscriptions","organizations_url":"https://api.github.com/users/nagiesek/orgs","repos_url":"https://api.github.com/users/nagiesek/repos","events_url":"https://api.github.com/users/nagiesek/events{/privacy}","received_events_url":"https://api.github.com/users/nagiesek/received_events","type":"User","site_admin":false},"labels":[{"id":717986501,"node_id":"MDU6TGFiZWw3MTc5ODY1MDE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/conformance","name":"area/conformance","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"node_id":"MDU6TGFiZWw2ODAxNTIxMTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":496752468,"node_id":"MDU6TGFiZWw0OTY3NTI0Njg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/failing-test","name":"kind/failing-test","color":"e11d21","default":false},{"id":116712108,"node_id":"MDU6TGFiZWwxMTY3MTIxMDg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/network","name":"sig/network","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":422106010,"node_id":"MDU6TGFiZWw0MjIxMDYwMTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/windows","name":"sig/windows","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-24T02:16:26Z","updated_at":"2018-10-30T21:11:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70156","html_url":"https://github.com/kubernetes/kubernetes/pull/70156","diff_url":"https://github.com/kubernetes/kubernetes/pull/70156.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70156.patch"},"body":"**What type of PR is this?**\r\n\r\n/kind failing-test\r\n\r\n**What this PR does / why we need it**:\r\nWindows assumes any DNS query PQDN with a \".\" in it to be fully qualified. It's possible to fix this, but it is likely that doing so would break expectations of applications on Windows. After consulting with SIG-Network, we came to the conclusion that conformance tests shouldn't break this assumption nor be tied to the behavioral nuances of a DNS resolver of a specific OS. We propose to separate the current DNS conformance tests as follows:\"\r\n- Keep existing test assertions that test PQDN DNS queries not containing \".\".\r\n- Keep existing test assertions that perform FQDN DNS queries.\r\n- For any test assertions that use PQDN DNS queries containing \".\":\r\n  - Replace those test assertions in the conformance test with an equivalent FQDN DNS query.\r\n  - Move those test assertions into a new (non-conformance) test.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n/sig testing\r\n/area conformance\r\n\r\n**Does this PR introduce a user-facing change?**:\r\nNONE"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/434471371","html_url":"https://github.com/kubernetes/kubernetes/pull/70156#issuecomment-434471371","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70156","id":434471371,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQ3MTM3MQ==","user":{"login":"spiffxp","id":49258,"node_id":"MDQ6VXNlcjQ5MjU4","avatar_url":"https://avatars2.githubusercontent.com/u/49258?v=4","gravatar_id":"","url":"https://api.github.com/users/spiffxp","html_url":"https://github.com/spiffxp","followers_url":"https://api.github.com/users/spiffxp/followers","following_url":"https://api.github.com/users/spiffxp/following{/other_user}","gists_url":"https://api.github.com/users/spiffxp/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffxp/subscriptions","organizations_url":"https://api.github.com/users/spiffxp/orgs","repos_url":"https://api.github.com/users/spiffxp/repos","events_url":"https://api.github.com/users/spiffxp/events{/privacy}","received_events_url":"https://api.github.com/users/spiffxp/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T21:11:42Z","updated_at":"2018-10-30T21:11:42Z","author_association":"MEMBER","body":"/retest"}}
{"actor":{"display_login":"spiffxp"}}