{"action":"created","comment":{"url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/comments/185619251","pull_request_review_id":117045236,"id":185619251,"diff_hunk":"@@ -139,9 +118,10 @@ bba_completed(#bba_state{input=Input, result=Result}) ->\n successful_bba_count(Data) ->\n     lists:sum([ 1 || BBA <- maps:values(Data#acs_data.bba), BBA#bba_state.result]).\n \n--spec completed_bba_count(acs_data()) -> non_neg_integer(). %% completed_bba_count cannot be 0\n-completed_bba_count(Data) ->\n-    lists:sum([ 1 || BBA <- maps:values(Data#acs_data.bba), BBA#bba_state.result /= undefined]).\n+%% XXX: Unused function, remove?","path":"src/hbbft_acs.erl","position":null,"original_position":90,"commit_id":"69fd63b52d620c8da30753bdd05804373fe911db","original_commit_id":"6ff2f928ea84582d793ff6fc21e4a86a441fbda1","user":{"login":"vihu","id":3199183,"avatar_url":"https://avatars1.githubusercontent.com/u/3199183?v=4","gravatar_id":"","url":"https://api.github.com/users/vihu","html_url":"https://github.com/vihu","followers_url":"https://api.github.com/users/vihu/followers","following_url":"https://api.github.com/users/vihu/following{/other_user}","gists_url":"https://api.github.com/users/vihu/gists{/gist_id}","starred_url":"https://api.github.com/users/vihu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihu/subscriptions","organizations_url":"https://api.github.com/users/vihu/orgs","repos_url":"https://api.github.com/users/vihu/repos","events_url":"https://api.github.com/users/vihu/events{/privacy}","received_events_url":"https://api.github.com/users/vihu/received_events","type":"User","site_admin":false},"body":"done in 5e5ac01","created_at":"2018-05-02T19:54:09Z","updated_at":"2018-05-02T19:54:09Z","html_url":"https://github.com/helium/erlang-hbbft/pull/10#discussion_r185619251","pull_request_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/comments/185619251"},"html":{"href":"https://github.com/helium/erlang-hbbft/pull/10#discussion_r185619251"},"pull_request":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10"}},"in_reply_to_id":185582534},"pull_request":{"url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10","id":185288360,"html_url":"https://github.com/helium/erlang-hbbft/pull/10","diff_url":"https://github.com/helium/erlang-hbbft/pull/10.diff","patch_url":"https://github.com/helium/erlang-hbbft/pull/10.patch","issue_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/10","number":10,"state":"open","locked":false,"title":"Serialize/Deserialize all states and minor speed optimizations","user":{"login":"vihu","id":3199183,"avatar_url":"https://avatars1.githubusercontent.com/u/3199183?v=4","gravatar_id":"","url":"https://api.github.com/users/vihu","html_url":"https://github.com/vihu","followers_url":"https://api.github.com/users/vihu/followers","following_url":"https://api.github.com/users/vihu/following{/other_user}","gists_url":"https://api.github.com/users/vihu/gists{/gist_id}","starred_url":"https://api.github.com/users/vihu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vihu/subscriptions","organizations_url":"https://api.github.com/users/vihu/orgs","repos_url":"https://api.github.com/users/vihu/repos","events_url":"https://api.github.com/users/vihu/events{/privacy}","received_events_url":"https://api.github.com/users/vihu/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-01T22:03:59Z","updated_at":"2018-05-02T19:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3651ae798e11595771592858dca11c1f119d302","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10/commits","review_comments_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10/comments","review_comment_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/10/comments","statuses_url":"https://api.github.com/repos/helium/erlang-hbbft/statuses/69fd63b52d620c8da30753bdd05804373fe911db","head":{"label":"helium:rg/serialize-states","ref":"rg/serialize-states","sha":"69fd63b52d620c8da30753bdd05804373fe911db","user":{"login":"helium","id":6635330,"avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":128082900,"name":"erlang-hbbft","full_name":"helium/erlang-hbbft","owner":{"login":"helium","id":6635330,"avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/erlang-hbbft","description":"Erlang implementation of HoneyBadgerBFT","fork":false,"url":"https://api.github.com/repos/helium/erlang-hbbft","forks_url":"https://api.github.com/repos/helium/erlang-hbbft/forks","keys_url":"https://api.github.com/repos/helium/erlang-hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/erlang-hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/erlang-hbbft/teams","hooks_url":"https://api.github.com/repos/helium/erlang-hbbft/hooks","issue_events_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/helium/erlang-hbbft/events","assignees_url":"https://api.github.com/repos/helium/erlang-hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/helium/erlang-hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/helium/erlang-hbbft/tags","blobs_url":"https://api.github.com/repos/helium/erlang-hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/erlang-hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/erlang-hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/erlang-hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/erlang-hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/erlang-hbbft/languages","stargazers_url":"https://api.github.com/repos/helium/erlang-hbbft/stargazers","contributors_url":"https://api.github.com/repos/helium/erlang-hbbft/contributors","subscribers_url":"https://api.github.com/repos/helium/erlang-hbbft/subscribers","subscription_url":"https://api.github.com/repos/helium/erlang-hbbft/subscription","commits_url":"https://api.github.com/repos/helium/erlang-hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/erlang-hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/erlang-hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/erlang-hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/helium/erlang-hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/erlang-hbbft/merges","archive_url":"https://api.github.com/repos/helium/erlang-hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/erlang-hbbft/downloads","issues_url":"https://api.github.com/repos/helium/erlang-hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/erlang-hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/erlang-hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/erlang-hbbft/labels{/name}","releases_url":"https://api.github.com/repos/helium/erlang-hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/helium/erlang-hbbft/deployments","created_at":"2018-04-04T15:30:41Z","updated_at":"2018-04-28T00:42:00Z","pushed_at":"2018-05-02T19:52:09Z","git_url":"git://github.com/helium/erlang-hbbft.git","ssh_url":"git@github.com:helium/erlang-hbbft.git","clone_url":"https://github.com/helium/erlang-hbbft.git","svn_url":"https://github.com/helium/erlang-hbbft","homepage":null,"size":886,"stargazers_count":4,"watchers_count":4,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"helium:master","ref":"master","sha":"f68df43eb07df24607701f35d7927decde442a55","user":{"login":"helium","id":6635330,"avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"repo":{"id":128082900,"name":"erlang-hbbft","full_name":"helium/erlang-hbbft","owner":{"login":"helium","id":6635330,"avatar_url":"https://avatars1.githubusercontent.com/u/6635330?v=4","gravatar_id":"","url":"https://api.github.com/users/helium","html_url":"https://github.com/helium","followers_url":"https://api.github.com/users/helium/followers","following_url":"https://api.github.com/users/helium/following{/other_user}","gists_url":"https://api.github.com/users/helium/gists{/gist_id}","starred_url":"https://api.github.com/users/helium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helium/subscriptions","organizations_url":"https://api.github.com/users/helium/orgs","repos_url":"https://api.github.com/users/helium/repos","events_url":"https://api.github.com/users/helium/events{/privacy}","received_events_url":"https://api.github.com/users/helium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helium/erlang-hbbft","description":"Erlang implementation of HoneyBadgerBFT","fork":false,"url":"https://api.github.com/repos/helium/erlang-hbbft","forks_url":"https://api.github.com/repos/helium/erlang-hbbft/forks","keys_url":"https://api.github.com/repos/helium/erlang-hbbft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helium/erlang-hbbft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helium/erlang-hbbft/teams","hooks_url":"https://api.github.com/repos/helium/erlang-hbbft/hooks","issue_events_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/events{/number}","events_url":"https://api.github.com/repos/helium/erlang-hbbft/events","assignees_url":"https://api.github.com/repos/helium/erlang-hbbft/assignees{/user}","branches_url":"https://api.github.com/repos/helium/erlang-hbbft/branches{/branch}","tags_url":"https://api.github.com/repos/helium/erlang-hbbft/tags","blobs_url":"https://api.github.com/repos/helium/erlang-hbbft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helium/erlang-hbbft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helium/erlang-hbbft/git/refs{/sha}","trees_url":"https://api.github.com/repos/helium/erlang-hbbft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helium/erlang-hbbft/statuses/{sha}","languages_url":"https://api.github.com/repos/helium/erlang-hbbft/languages","stargazers_url":"https://api.github.com/repos/helium/erlang-hbbft/stargazers","contributors_url":"https://api.github.com/repos/helium/erlang-hbbft/contributors","subscribers_url":"https://api.github.com/repos/helium/erlang-hbbft/subscribers","subscription_url":"https://api.github.com/repos/helium/erlang-hbbft/subscription","commits_url":"https://api.github.com/repos/helium/erlang-hbbft/commits{/sha}","git_commits_url":"https://api.github.com/repos/helium/erlang-hbbft/git/commits{/sha}","comments_url":"https://api.github.com/repos/helium/erlang-hbbft/comments{/number}","issue_comment_url":"https://api.github.com/repos/helium/erlang-hbbft/issues/comments{/number}","contents_url":"https://api.github.com/repos/helium/erlang-hbbft/contents/{+path}","compare_url":"https://api.github.com/repos/helium/erlang-hbbft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helium/erlang-hbbft/merges","archive_url":"https://api.github.com/repos/helium/erlang-hbbft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helium/erlang-hbbft/downloads","issues_url":"https://api.github.com/repos/helium/erlang-hbbft/issues{/number}","pulls_url":"https://api.github.com/repos/helium/erlang-hbbft/pulls{/number}","milestones_url":"https://api.github.com/repos/helium/erlang-hbbft/milestones{/number}","notifications_url":"https://api.github.com/repos/helium/erlang-hbbft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helium/erlang-hbbft/labels{/name}","releases_url":"https://api.github.com/repos/helium/erlang-hbbft/releases{/id}","deployments_url":"https://api.github.com/repos/helium/erlang-hbbft/deployments","created_at":"2018-04-04T15:30:41Z","updated_at":"2018-04-28T00:42:00Z","pushed_at":"2018-05-02T19:52:09Z","git_url":"git://github.com/helium/erlang-hbbft.git","ssh_url":"git@github.com:helium/erlang-hbbft.git","clone_url":"https://github.com/helium/erlang-hbbft.git","svn_url":"https://github.com/helium/erlang-hbbft","homepage":null,"size":886,"stargazers_count":4,"watchers_count":4,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10"},"html":{"href":"https://github.com/helium/erlang-hbbft/pull/10"},"issue":{"href":"https://api.github.com/repos/helium/erlang-hbbft/issues/10"},"comments":{"href":"https://api.github.com/repos/helium/erlang-hbbft/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helium/erlang-hbbft/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/helium/erlang-hbbft/statuses/69fd63b52d620c8da30753bdd05804373fe911db"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vihu"}}