{"action":"created","comment":{"url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/comments/186905748","pull_request_review_id":118578506,"id":186905748,"diff_hunk":"@@ -83,7 +84,7 @@\n #' @import htmlwidgets\n #' @importFrom jsonlite toJSON\n #' @export\n-jsTree <- function(obj, core=NULL, tooltips=NULL, nodestate=NULL, ... , width = NULL, height = NULL, elementId = NULL) {\n+jsTree <- function(obj, core=NULL, tooltips=NULL, nodestate=NULL, ... , width = NULL, height = NULL, elementId = NULL, sep = '/') {","path":"R/jsTree.R","position":13,"original_position":13,"commit_id":"fb9a923c155c45672180fe699b5f1796e2f24cb8","original_commit_id":"fb9a923c155c45672180fe699b5f1796e2f24cb8","user":{"login":"yonicd","id":1755487,"avatar_url":"https://avatars3.githubusercontent.com/u/1755487?v=4","gravatar_id":"","url":"https://api.github.com/users/yonicd","html_url":"https://github.com/yonicd","followers_url":"https://api.github.com/users/yonicd/followers","following_url":"https://api.github.com/users/yonicd/following{/other_user}","gists_url":"https://api.github.com/users/yonicd/gists{/gist_id}","starred_url":"https://api.github.com/users/yonicd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonicd/subscriptions","organizations_url":"https://api.github.com/users/yonicd/orgs","repos_url":"https://api.github.com/users/yonicd/repos","events_url":"https://api.github.com/users/yonicd/events{/privacy}","received_events_url":"https://api.github.com/users/yonicd/received_events","type":"User","site_admin":false},"body":"the order of the formals should be obj, sep, ....","created_at":"2018-05-09T00:42:39Z","updated_at":"2018-05-09T00:50:11Z","html_url":"https://github.com/metrumresearchgroup/jsTree/pull/8#discussion_r186905748","pull_request_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/comments/186905748"},"html":{"href":"https://github.com/metrumresearchgroup/jsTree/pull/8#discussion_r186905748"},"pull_request":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8","id":186777236,"html_url":"https://github.com/metrumresearchgroup/jsTree/pull/8","diff_url":"https://github.com/metrumresearchgroup/jsTree/pull/8.diff","patch_url":"https://github.com/metrumresearchgroup/jsTree/pull/8.patch","issue_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/8","number":8,"state":"open","locked":false,"title":"let user define sep for file path.","user":{"login":"kohleth","id":11546934,"avatar_url":"https://avatars1.githubusercontent.com/u/11546934?v=4","gravatar_id":"","url":"https://api.github.com/users/kohleth","html_url":"https://github.com/kohleth","followers_url":"https://api.github.com/users/kohleth/followers","following_url":"https://api.github.com/users/kohleth/following{/other_user}","gists_url":"https://api.github.com/users/kohleth/gists{/gist_id}","starred_url":"https://api.github.com/users/kohleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohleth/subscriptions","organizations_url":"https://api.github.com/users/kohleth/orgs","repos_url":"https://api.github.com/users/kohleth/repos","events_url":"https://api.github.com/users/kohleth/events{/privacy}","received_events_url":"https://api.github.com/users/kohleth/received_events","type":"User","site_admin":false},"body":"Thanks for the jsTree package. It is great.\r\nI am using it to explore a hierarchical data structure, which are not file paths. \r\nImagine in the shiny app you have to navigate through country / state / city.\r\nAnd one of these names happen to have the forward slash `/`, which `jsTree` interprets to be the next level of the hierarchy. \r\n\r\nThis PR let user define what the separator should be by supplying a `sep` argument.\r\n","created_at":"2018-05-08T22:54:28Z","updated_at":"2018-05-09T00:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6f2b72ebddb24070df3b8204e9630e10be9b33d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8/commits","review_comments_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8/comments","review_comment_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/8/comments","statuses_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/statuses/fb9a923c155c45672180fe699b5f1796e2f24cb8","head":{"label":"kohleth:master","ref":"master","sha":"fb9a923c155c45672180fe699b5f1796e2f24cb8","user":{"login":"kohleth","id":11546934,"avatar_url":"https://avatars1.githubusercontent.com/u/11546934?v=4","gravatar_id":"","url":"https://api.github.com/users/kohleth","html_url":"https://github.com/kohleth","followers_url":"https://api.github.com/users/kohleth/followers","following_url":"https://api.github.com/users/kohleth/following{/other_user}","gists_url":"https://api.github.com/users/kohleth/gists{/gist_id}","starred_url":"https://api.github.com/users/kohleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohleth/subscriptions","organizations_url":"https://api.github.com/users/kohleth/orgs","repos_url":"https://api.github.com/users/kohleth/repos","events_url":"https://api.github.com/users/kohleth/events{/privacy}","received_events_url":"https://api.github.com/users/kohleth/received_events","type":"User","site_admin":false},"repo":{"id":132670529,"name":"jsTree","full_name":"kohleth/jsTree","owner":{"login":"kohleth","id":11546934,"avatar_url":"https://avatars1.githubusercontent.com/u/11546934?v=4","gravatar_id":"","url":"https://api.github.com/users/kohleth","html_url":"https://github.com/kohleth","followers_url":"https://api.github.com/users/kohleth/followers","following_url":"https://api.github.com/users/kohleth/following{/other_user}","gists_url":"https://api.github.com/users/kohleth/gists{/gist_id}","starred_url":"https://api.github.com/users/kohleth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kohleth/subscriptions","organizations_url":"https://api.github.com/users/kohleth/orgs","repos_url":"https://api.github.com/users/kohleth/repos","events_url":"https://api.github.com/users/kohleth/events{/privacy}","received_events_url":"https://api.github.com/users/kohleth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kohleth/jsTree","description":null,"fork":true,"url":"https://api.github.com/repos/kohleth/jsTree","forks_url":"https://api.github.com/repos/kohleth/jsTree/forks","keys_url":"https://api.github.com/repos/kohleth/jsTree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kohleth/jsTree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kohleth/jsTree/teams","hooks_url":"https://api.github.com/repos/kohleth/jsTree/hooks","issue_events_url":"https://api.github.com/repos/kohleth/jsTree/issues/events{/number}","events_url":"https://api.github.com/repos/kohleth/jsTree/events","assignees_url":"https://api.github.com/repos/kohleth/jsTree/assignees{/user}","branches_url":"https://api.github.com/repos/kohleth/jsTree/branches{/branch}","tags_url":"https://api.github.com/repos/kohleth/jsTree/tags","blobs_url":"https://api.github.com/repos/kohleth/jsTree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kohleth/jsTree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kohleth/jsTree/git/refs{/sha}","trees_url":"https://api.github.com/repos/kohleth/jsTree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kohleth/jsTree/statuses/{sha}","languages_url":"https://api.github.com/repos/kohleth/jsTree/languages","stargazers_url":"https://api.github.com/repos/kohleth/jsTree/stargazers","contributors_url":"https://api.github.com/repos/kohleth/jsTree/contributors","subscribers_url":"https://api.github.com/repos/kohleth/jsTree/subscribers","subscription_url":"https://api.github.com/repos/kohleth/jsTree/subscription","commits_url":"https://api.github.com/repos/kohleth/jsTree/commits{/sha}","git_commits_url":"https://api.github.com/repos/kohleth/jsTree/git/commits{/sha}","comments_url":"https://api.github.com/repos/kohleth/jsTree/comments{/number}","issue_comment_url":"https://api.github.com/repos/kohleth/jsTree/issues/comments{/number}","contents_url":"https://api.github.com/repos/kohleth/jsTree/contents/{+path}","compare_url":"https://api.github.com/repos/kohleth/jsTree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kohleth/jsTree/merges","archive_url":"https://api.github.com/repos/kohleth/jsTree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kohleth/jsTree/downloads","issues_url":"https://api.github.com/repos/kohleth/jsTree/issues{/number}","pulls_url":"https://api.github.com/repos/kohleth/jsTree/pulls{/number}","milestones_url":"https://api.github.com/repos/kohleth/jsTree/milestones{/number}","notifications_url":"https://api.github.com/repos/kohleth/jsTree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kohleth/jsTree/labels{/name}","releases_url":"https://api.github.com/repos/kohleth/jsTree/releases{/id}","deployments_url":"https://api.github.com/repos/kohleth/jsTree/deployments","created_at":"2018-05-08T22:09:32Z","updated_at":"2018-05-08T23:27:28Z","pushed_at":"2018-05-08T23:27:26Z","git_url":"git://github.com/kohleth/jsTree.git","ssh_url":"git@github.com:kohleth/jsTree.git","clone_url":"https://github.com/kohleth/jsTree.git","svn_url":"https://github.com/kohleth/jsTree","homepage":null,"size":49114,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metrumresearchgroup:master","ref":"master","sha":"6ce9184639494ce09229860be29a56f19807529a","user":{"login":"metrumresearchgroup","id":17200462,"avatar_url":"https://avatars3.githubusercontent.com/u/17200462?v=4","gravatar_id":"","url":"https://api.github.com/users/metrumresearchgroup","html_url":"https://github.com/metrumresearchgroup","followers_url":"https://api.github.com/users/metrumresearchgroup/followers","following_url":"https://api.github.com/users/metrumresearchgroup/following{/other_user}","gists_url":"https://api.github.com/users/metrumresearchgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/metrumresearchgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metrumresearchgroup/subscriptions","organizations_url":"https://api.github.com/users/metrumresearchgroup/orgs","repos_url":"https://api.github.com/users/metrumresearchgroup/repos","events_url":"https://api.github.com/users/metrumresearchgroup/events{/privacy}","received_events_url":"https://api.github.com/users/metrumresearchgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":92959201,"name":"jsTree","full_name":"metrumresearchgroup/jsTree","owner":{"login":"metrumresearchgroup","id":17200462,"avatar_url":"https://avatars3.githubusercontent.com/u/17200462?v=4","gravatar_id":"","url":"https://api.github.com/users/metrumresearchgroup","html_url":"https://github.com/metrumresearchgroup","followers_url":"https://api.github.com/users/metrumresearchgroup/followers","following_url":"https://api.github.com/users/metrumresearchgroup/following{/other_user}","gists_url":"https://api.github.com/users/metrumresearchgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/metrumresearchgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metrumresearchgroup/subscriptions","organizations_url":"https://api.github.com/users/metrumresearchgroup/orgs","repos_url":"https://api.github.com/users/metrumresearchgroup/repos","events_url":"https://api.github.com/users/metrumresearchgroup/events{/privacy}","received_events_url":"https://api.github.com/users/metrumresearchgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metrumresearchgroup/jsTree","description":null,"fork":false,"url":"https://api.github.com/repos/metrumresearchgroup/jsTree","forks_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/forks","keys_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/teams","hooks_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/hooks","issue_events_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/events{/number}","events_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/events","assignees_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/assignees{/user}","branches_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/branches{/branch}","tags_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/tags","blobs_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/git/refs{/sha}","trees_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/statuses/{sha}","languages_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/languages","stargazers_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/stargazers","contributors_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/contributors","subscribers_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/subscribers","subscription_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/subscription","commits_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/commits{/sha}","git_commits_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/git/commits{/sha}","comments_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/comments{/number}","issue_comment_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/comments{/number}","contents_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/contents/{+path}","compare_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/merges","archive_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/downloads","issues_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues{/number}","pulls_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls{/number}","milestones_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/milestones{/number}","notifications_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/labels{/name}","releases_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/releases{/id}","deployments_url":"https://api.github.com/repos/metrumresearchgroup/jsTree/deployments","created_at":"2017-05-31T15:12:46Z","updated_at":"2018-04-15T16:37:15Z","pushed_at":"2018-05-08T23:27:27Z","git_url":"git://github.com/metrumresearchgroup/jsTree.git","ssh_url":"git@github.com:metrumresearchgroup/jsTree.git","clone_url":"https://github.com/metrumresearchgroup/jsTree.git","svn_url":"https://github.com/metrumresearchgroup/jsTree","homepage":null,"size":49113,"stargazers_count":11,"watchers_count":11,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":4,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8"},"html":{"href":"https://github.com/metrumresearchgroup/jsTree/pull/8"},"issue":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/8"},"comments":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/metrumresearchgroup/jsTree/statuses/fb9a923c155c45672180fe699b5f1796e2f24cb8"}},"author_association":"NONE"}}
{"actor":{"display_login":"yonicd"}}