{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/203264370","pull_request_review_id":138118116,"id":203264370,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzI2NDM3MA==","diff_hunk":"@@ -1,15 +1,17 @@\n+// +build windows","path":"volume/mounts/windows_parser.go","position":1,"original_position":1,"commit_id":"3abd06b26fd526a7bf4ae9b6933cba8519496ef9","original_commit_id":"3abd06b26fd526a7bf4ae9b6933cba8519496ef9","user":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"body":"See above.","created_at":"2018-07-18T06:33:52Z","updated_at":"2018-07-18T06:33:53Z","html_url":"https://github.com/moby/moby/pull/37474#discussion_r203264370","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/37474","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/203264370"},"html":{"href":"https://github.com/moby/moby/pull/37474#discussion_r203264370"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/37474"}},"in_reply_to_id":203207610},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/37474","id":201733707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzMzNzA3","html_url":"https://github.com/moby/moby/pull/37474","diff_url":"https://github.com/moby/moby/pull/37474.diff","patch_url":"https://github.com/moby/moby/pull/37474.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/37474","number":37474,"state":"open","locked":false,"title":"Support file mounts on Windows 1803 and above","user":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"body":"Windows 1803 introduces the bind filter driver, bindflt.sys, which introduces several mounting improvements over the previous directory symbolic link approach. These improvements include:\r\n\r\n- No longer appear as symbolic links, improving compatibilty.\r\n- Can be mounted on top of existing directories and files.\r\n- Can be files, instead of only directories.\r\n\r\nThis change addresses the last point by allowing non-directory file mounts on Windows 1803 (build 17134) and greater. The first two improvements already work without this, or any other change.\r\n\r\nThis change also rearranges the code such that the Windows and LCOW mount parsers are only built for, and tested on Windows, and the Linux parser is only built for, and tested on Linux. This allows the Windows parser to call system.GetOSVersion, which only exists for Windows.\r\n\r\nSigned-off-by: John Stephens <johnstep@docker.com>","created_at":"2018-07-16T19:17:34Z","updated_at":"2018-07-18T06:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6492a5d242e0fee03cffa4dbf9a4db407ec4448","assignee":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cpuguy83","id":799078,"node_id":"MDQ6VXNlcjc5OTA3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":237472270,"node_id":"MDU6TGFiZWwyMzc0NzIyNzA=","url":"https://api.github.com/repos/moby/moby/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf","default":false},{"id":161101581,"node_id":"MDU6TGFiZWwxNjExMDE1ODE=","url":"https://api.github.com/repos/moby/moby/labels/platform/windows","name":"platform/windows","color":"F6FBFF","default":false},{"id":175375407,"node_id":"MDU6TGFiZWwxNzUzNzU0MDc=","url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/37474/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/37474/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/37474/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/3abd06b26fd526a7bf4ae9b6933cba8519496ef9","head":{"label":"johnstep:support_windows_file_mounts","ref":"support_windows_file_mounts","sha":"3abd06b26fd526a7bf4ae9b6933cba8519496ef9","user":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"repo":{"id":70111097,"node_id":"MDEwOlJlcG9zaXRvcnk3MDExMTA5Nw==","name":"moby-moby","full_name":"johnstep/moby-moby","owner":{"login":"johnstep","id":3768125,"node_id":"MDQ6VXNlcjM3NjgxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3768125?v=4","gravatar_id":"","url":"https://api.github.com/users/johnstep","html_url":"https://github.com/johnstep","followers_url":"https://api.github.com/users/johnstep/followers","following_url":"https://api.github.com/users/johnstep/following{/other_user}","gists_url":"https://api.github.com/users/johnstep/gists{/gist_id}","starred_url":"https://api.github.com/users/johnstep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnstep/subscriptions","organizations_url":"https://api.github.com/users/johnstep/orgs","repos_url":"https://api.github.com/users/johnstep/repos","events_url":"https://api.github.com/users/johnstep/events{/privacy}","received_events_url":"https://api.github.com/users/johnstep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnstep/moby-moby","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/johnstep/moby-moby","forks_url":"https://api.github.com/repos/johnstep/moby-moby/forks","keys_url":"https://api.github.com/repos/johnstep/moby-moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnstep/moby-moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnstep/moby-moby/teams","hooks_url":"https://api.github.com/repos/johnstep/moby-moby/hooks","issue_events_url":"https://api.github.com/repos/johnstep/moby-moby/issues/events{/number}","events_url":"https://api.github.com/repos/johnstep/moby-moby/events","assignees_url":"https://api.github.com/repos/johnstep/moby-moby/assignees{/user}","branches_url":"https://api.github.com/repos/johnstep/moby-moby/branches{/branch}","tags_url":"https://api.github.com/repos/johnstep/moby-moby/tags","blobs_url":"https://api.github.com/repos/johnstep/moby-moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnstep/moby-moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnstep/moby-moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnstep/moby-moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnstep/moby-moby/statuses/{sha}","languages_url":"https://api.github.com/repos/johnstep/moby-moby/languages","stargazers_url":"https://api.github.com/repos/johnstep/moby-moby/stargazers","contributors_url":"https://api.github.com/repos/johnstep/moby-moby/contributors","subscribers_url":"https://api.github.com/repos/johnstep/moby-moby/subscribers","subscription_url":"https://api.github.com/repos/johnstep/moby-moby/subscription","commits_url":"https://api.github.com/repos/johnstep/moby-moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnstep/moby-moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnstep/moby-moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnstep/moby-moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnstep/moby-moby/contents/{+path}","compare_url":"https://api.github.com/repos/johnstep/moby-moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnstep/moby-moby/merges","archive_url":"https://api.github.com/repos/johnstep/moby-moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnstep/moby-moby/downloads","issues_url":"https://api.github.com/repos/johnstep/moby-moby/issues{/number}","pulls_url":"https://api.github.com/repos/johnstep/moby-moby/pulls{/number}","milestones_url":"https://api.github.com/repos/johnstep/moby-moby/milestones{/number}","notifications_url":"https://api.github.com/repos/johnstep/moby-moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnstep/moby-moby/labels{/name}","releases_url":"https://api.github.com/repos/johnstep/moby-moby/releases{/id}","deployments_url":"https://api.github.com/repos/johnstep/moby-moby/deployments","created_at":"2016-10-06T00:43:51Z","updated_at":"2018-07-13T23:36:48Z","pushed_at":"2018-07-16T20:28:35Z","git_url":"git://github.com/johnstep/moby-moby.git","ssh_url":"git@github.com:johnstep/moby-moby.git","clone_url":"https://github.com/johnstep/moby-moby.git","svn_url":"https://github.com/johnstep/moby-moby","homepage":"http://www.docker.com","size":134224,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"a5495f289aafafac8a01c62f2a9cb44856658ece","user":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"node_id":"MDEwOlJlcG9zaXRvcnk3NjkxNjMx","name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjU5MTk3","avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-07-18T03:53:43Z","pushed_at":"2018-07-18T00:44:09Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":136598,"stargazers_count":49593,"watchers_count":49593,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14476,"mirror_url":null,"archived":false,"open_issues_count":3243,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14476,"open_issues":3243,"watchers":49593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/37474"},"html":{"href":"https://github.com/moby/moby/pull/37474"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/37474"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/37474/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/37474/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/37474/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/3abd06b26fd526a7bf4ae9b6933cba8519496ef9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johnstep"}}