{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/3037","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/3037/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/3037/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/3037/events","html_url":"https://github.com/palantir/blueprint/issues/3037","id":370341265,"node_id":"MDU6SXNzdWUzNzAzNDEyNjU=","number":3037,"title":"[select] update inputProps documentation","user":{"login":"tomaszbalsys","id":39491246,"node_id":"MDQ6VXNlcjM5NDkxMjQ2","avatar_url":"https://avatars1.githubusercontent.com/u/39491246?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaszbalsys","html_url":"https://github.com/tomaszbalsys","followers_url":"https://api.github.com/users/tomaszbalsys/followers","following_url":"https://api.github.com/users/tomaszbalsys/following{/other_user}","gists_url":"https://api.github.com/users/tomaszbalsys/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszbalsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszbalsys/subscriptions","organizations_url":"https://api.github.com/users/tomaszbalsys/orgs","repos_url":"https://api.github.com/users/tomaszbalsys/repos","events_url":"https://api.github.com/users/tomaszbalsys/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszbalsys/received_events","type":"User","site_admin":false},"labels":[{"id":478396736,"node_id":"MDU6TGFiZWw0NzgzOTY3MzY=","url":"https://api.github.com/repos/palantir/blueprint/labels/Domain:%20documentation","name":"Domain: documentation","color":"2378ad","default":false},{"id":828059286,"node_id":"MDU6TGFiZWw4MjgwNTkyODY=","url":"https://api.github.com/repos/palantir/blueprint/labels/Package:%20select","name":"Package: select","color":"f5f8fa","default":false},{"id":1012932134,"node_id":"MDU6TGFiZWwxMDEyOTMyMTM0","url":"https://api.github.com/repos/palantir/blueprint/labels/Resolution:%20by%20design","name":"Resolution: by design","color":"300b8e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-15T20:58:42Z","updated_at":"2018-11-16T02:46:00Z","closed_at":null,"author_association":"NONE","body":"Prop `inputProps` in components `Select` and `Suggest` doesn't work.\r\n\r\n#### Environment\r\n\r\n- @blueprintjs/select 3.2.0\r\n- Chromium 69.0.3497.100 (Official Build) Arch Linux (64-bit)\r\n\r\n\r\n#### Steps to reproduce\r\n\r\n```\r\n<Suggest\r\n  items={Films.TOP_100_FILMS}\r\n  itemRenderer={renderFilm}\r\n  inputValueRenderer={film => film.title}\r\n  onItemSelect={this.handleValueChange}\r\n  noResults={<MenuItem disabled text=\"No results.\" />}\r\n  inputProps={{ value: query, onChange: this.handleChange }}\r\n>\r\n  <Button text={buttonText} rightIcon=\"caret-down\" />\r\n</Suggest>\r\n```\r\n\r\n#### Actual behavior\r\n\r\nMethod `this.handleChange` gets never executed.\r\n\r\n#### Expected behavior\r\n\r\nProviding prop `inputProps` should make component controlled.\r\n\r\n#### Possible solution\r\n\r\nIn `suggest.tsx` in method `renderQueryList`:\r\n```\r\n                <InputGroup\r\n                    {...inputProps}\r\n                    placeholder={isOpen && selectedItemText ? selectedItemText : placeholder}\r\n                    inputRef={this.refHandlers.input}\r\n                    onChange={listProps.handleQueryChange}\r\n                    onFocus={this.handleInputFocus}\r\n                    onKeyDown={this.getTargetKeyDownHandler(handleKeyDown)}\r\n                    onKeyUp={this.getTargetKeyUpHandler(handleKeyUp)}\r\n                    value={isOpen ? listProps.query : selectedItemText}\r\n                />\r\n```\r\n`{...inputProps}` should be moved to the end, so that it overrides `value` and `onChange` props."},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/439263552","html_url":"https://github.com/palantir/blueprint/issues/3037#issuecomment-439263552","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/3037","id":439263552,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTI2MzU1Mg==","user":{"login":"EchoZw","id":23427655,"node_id":"MDQ6VXNlcjIzNDI3NjU1","avatar_url":"https://avatars2.githubusercontent.com/u/23427655?v=4","gravatar_id":"","url":"https://api.github.com/users/EchoZw","html_url":"https://github.com/EchoZw","followers_url":"https://api.github.com/users/EchoZw/followers","following_url":"https://api.github.com/users/EchoZw/following{/other_user}","gists_url":"https://api.github.com/users/EchoZw/gists{/gist_id}","starred_url":"https://api.github.com/users/EchoZw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EchoZw/subscriptions","organizations_url":"https://api.github.com/users/EchoZw/orgs","repos_url":"https://api.github.com/users/EchoZw/repos","events_url":"https://api.github.com/users/EchoZw/events{/privacy}","received_events_url":"https://api.github.com/users/EchoZw/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T02:46:00Z","updated_at":"2018-11-16T02:46:00Z","author_association":"NONE","body":"@giladgray Excuse me, when are you going to fix this problem?\r\nand  I think you should add a bug label to this issue."}}
{"actor":{"display_login":"EchoZw"}}