{"action":"created","comment":{"url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/comments/175949088","pull_request_review_id":105567211,"id":175949088,"diff_hunk":"@@ -43,19 +48,33 @@ func (c *client) UpdateInstance(r *UpdateInstanceRequest) (*UpdateInstanceRespon\n \t}\n \tswitch response.StatusCode {\n \tcase http.StatusOK:\n-\t\tif err := c.unmarshalResponse(response, &struct{}{}); err != nil {\n+\t\tresponseBodyObj := &updateInstanceResponseBody{}\n+\t\tif err := c.unmarshalResponse(response, responseBodyObj); err != nil {\n \t\t\treturn nil, HTTPStatusCodeError{StatusCode: response.StatusCode, ResponseError: err}\n \t\t}\n \n-\t\treturn &UpdateInstanceResponse{}, nil\n+\t\tvar opPtr *OperationKey\n+\t\tif responseBodyObj.Operation != nil {\n+\t\t\topStr := *responseBodyObj.Operation\n+\t\t\top := OperationKey(opStr)\n+\t\t\topPtr = &op\n+\t\t}\n+\n+\t\tuserResponse := &UpdateInstanceResponse{\n+\t\t\tAsync:        false,\n+\t\t\tDashboardURL: responseBodyObj.DashboardURL,","path":"v2/update_instance.go","position":32,"original_position":32,"commit_id":"e3cc11fef35ebb9e062e7762743e92c9076aff85","original_commit_id":"e3cc11fef35ebb9e062e7762743e92c9076aff85","user":{"login":"jberkhahn","id":5873242,"avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"body":"If the api is an older version, the response won't contain it so it will be set to nil when we unmarshal the response on line 52. This this will then just be set to nil. Is that insufficient? I can change it to explicitly check.","created_at":"2018-03-20T23:01:23Z","updated_at":"2018-03-20T23:01:23Z","html_url":"https://github.com/pmorie/go-open-service-broker-client/pull/116#discussion_r175949088","pull_request_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/comments/175949088"},"html":{"href":"https://github.com/pmorie/go-open-service-broker-client/pull/116#discussion_r175949088"},"pull_request":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116"}},"in_reply_to_id":175902492},"pull_request":{"url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116","id":175961980,"html_url":"https://github.com/pmorie/go-open-service-broker-client/pull/116","diff_url":"https://github.com/pmorie/go-open-service-broker-client/pull/116.diff","patch_url":"https://github.com/pmorie/go-open-service-broker-client/pull/116.patch","issue_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/116","number":116,"state":"open","locked":false,"title":"Allow dashboard_url in response to update service instance","user":{"login":"jberkhahn","id":5873242,"avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"body":"Validation through implementation of [OSB 437](https://github.com/openservicebrokerapi/servicebroker/pull/437).\r\n\r\nThis is to allow Dashboard URL to be returned in the response body to a PATCH /v2/service_instances/:service_id request.","created_at":"2018-03-19T16:54:29Z","updated_at":"2018-03-20T23:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a755906e43da928c30ccec91a057e591ebde8036","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116/commits","review_comments_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116/comments","review_comment_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/116/comments","statuses_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/statuses/e3cc11fef35ebb9e062e7762743e92c9076aff85","head":{"label":"jberkhahn:update_dashboard","ref":"update_dashboard","sha":"e3cc11fef35ebb9e062e7762743e92c9076aff85","user":{"login":"jberkhahn","id":5873242,"avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"repo":{"id":125579121,"name":"go-open-service-broker-client","full_name":"jberkhahn/go-open-service-broker-client","owner":{"login":"jberkhahn","id":5873242,"avatar_url":"https://avatars0.githubusercontent.com/u/5873242?v=4","gravatar_id":"","url":"https://api.github.com/users/jberkhahn","html_url":"https://github.com/jberkhahn","followers_url":"https://api.github.com/users/jberkhahn/followers","following_url":"https://api.github.com/users/jberkhahn/following{/other_user}","gists_url":"https://api.github.com/users/jberkhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/jberkhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jberkhahn/subscriptions","organizations_url":"https://api.github.com/users/jberkhahn/orgs","repos_url":"https://api.github.com/users/jberkhahn/repos","events_url":"https://api.github.com/users/jberkhahn/events{/privacy}","received_events_url":"https://api.github.com/users/jberkhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jberkhahn/go-open-service-broker-client","description":"A golang client for service brokers implementing the Open Service Broker API","fork":true,"url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client","forks_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/forks","keys_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/teams","hooks_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/hooks","issue_events_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/issues/events{/number}","events_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/events","assignees_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/assignees{/user}","branches_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/branches{/branch}","tags_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/tags","blobs_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/statuses/{sha}","languages_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/languages","stargazers_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/stargazers","contributors_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/contributors","subscribers_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/subscribers","subscription_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/subscription","commits_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/contents/{+path}","compare_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/merges","archive_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/downloads","issues_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/issues{/number}","pulls_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/pulls{/number}","milestones_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/milestones{/number}","notifications_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/labels{/name}","releases_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/releases{/id}","deployments_url":"https://api.github.com/repos/jberkhahn/go-open-service-broker-client/deployments","created_at":"2018-03-16T23:11:57Z","updated_at":"2018-03-16T23:11:59Z","pushed_at":"2018-03-19T18:07:10Z","git_url":"git://github.com/jberkhahn/go-open-service-broker-client.git","ssh_url":"git@github.com:jberkhahn/go-open-service-broker-client.git","clone_url":"https://github.com/jberkhahn/go-open-service-broker-client.git","svn_url":"https://github.com/jberkhahn/go-open-service-broker-client","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmorie:master","ref":"master","sha":"2c5a685a8470e899dd32b9bd5de76ace98ab40bb","user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars2.githubusercontent.com/u/366488?v=4","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"repo":{"id":90553041,"name":"go-open-service-broker-client","full_name":"pmorie/go-open-service-broker-client","owner":{"login":"pmorie","id":366488,"avatar_url":"https://avatars2.githubusercontent.com/u/366488?v=4","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmorie/go-open-service-broker-client","description":"A golang client for service brokers implementing the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/pmorie/go-open-service-broker-client","forks_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/forks","keys_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/teams","hooks_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/hooks","issue_events_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/events{/number}","events_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/events","assignees_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/assignees{/user}","branches_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/branches{/branch}","tags_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/tags","blobs_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/statuses/{sha}","languages_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/languages","stargazers_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/stargazers","contributors_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/contributors","subscribers_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/subscribers","subscription_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/subscription","commits_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/contents/{+path}","compare_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/merges","archive_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/downloads","issues_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues{/number}","pulls_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls{/number}","milestones_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/milestones{/number}","notifications_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/labels{/name}","releases_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/releases{/id}","deployments_url":"https://api.github.com/repos/pmorie/go-open-service-broker-client/deployments","created_at":"2017-05-07T18:28:01Z","updated_at":"2018-03-20T19:52:22Z","pushed_at":"2018-03-20T19:52:20Z","git_url":"git://github.com/pmorie/go-open-service-broker-client.git","ssh_url":"git@github.com:pmorie/go-open-service-broker-client.git","clone_url":"https://github.com/pmorie/go-open-service-broker-client.git","svn_url":"https://github.com/pmorie/go-open-service-broker-client","homepage":null,"size":178,"stargazers_count":28,"watchers_count":28,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":17,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116"},"html":{"href":"https://github.com/pmorie/go-open-service-broker-client/pull/116"},"issue":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/116"},"comments":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/pmorie/go-open-service-broker-client/statuses/e3cc11fef35ebb9e062e7762743e92c9076aff85"}},"author_association":"NONE"}}
{"actor":{"display_login":"jberkhahn"}}