{"action":"opened","number":859,"pull_request":{"url":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859","id":192162801,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTYyODAx","html_url":"https://github.com/RcppCore/Rcpp/pull/859","diff_url":"https://github.com/RcppCore/Rcpp/pull/859.diff","patch_url":"https://github.com/RcppCore/Rcpp/pull/859.patch","issue_url":"https://api.github.com/repos/RcppCore/Rcpp/issues/859","number":859,"state":"open","locked":false,"title":"Fix protect-unwind","user":{"login":"lionel-","id":4465050,"node_id":"MDQ6VXNlcjQ0NjUwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4465050?v=4","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"body":"* Unshield the protect-unwind changes from #789 \r\n\r\n* Don't throw exceptions across the C stack. I believe this is what caused the issues on Windows. Instead we now skip the C frames using a longjump and only then throw the longjump exception across the C++ stack.\r\n\r\n* Add unit tests for generating attributes in packages. One mock package exports a function via `Rcpp::interfaces(cpp)` and the other calls it. The tests check that the C++ stack is properly unwound on longjumps issued from the exported function.\r\n\r\nWin-builder and r-hub don't seem to be reliable for testing these changes. Even with current master the former always gets stuck and the latter randomly hangs when running the tests or rebuilding vignettes. However I have set up a local Windows 10 and Rcpp successfully passes the tests. With #789 I get a `terminate called after throwing an instance of 'Rcpp::LongjumpException'` crash. I don't know if all problems are fixed but hopefully we still have some time before the next release to test this further.","created_at":"2018-06-01T23:17:51Z","updated_at":"2018-06-01T23:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859/commits","review_comments_url":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859/comments","review_comment_url":"https://api.github.com/repos/RcppCore/Rcpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RcppCore/Rcpp/issues/859/comments","statuses_url":"https://api.github.com/repos/RcppCore/Rcpp/statuses/b4cc4ef9ccd5ab8b86f7d56bd31ef6c061fd82d4","head":{"label":"lionel-:restore-unwind","ref":"restore-unwind","sha":"b4cc4ef9ccd5ab8b86f7d56bd31ef6c061fd82d4","user":{"login":"lionel-","id":4465050,"node_id":"MDQ6VXNlcjQ0NjUwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4465050?v=4","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"repo":{"id":31035759,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAzNTc1OQ==","name":"Rcpp","full_name":"lionel-/Rcpp","owner":{"login":"lionel-","id":4465050,"node_id":"MDQ6VXNlcjQ0NjUwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4465050?v=4","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lionel-/Rcpp","description":"Seamless R and C++ Integration","fork":true,"url":"https://api.github.com/repos/lionel-/Rcpp","forks_url":"https://api.github.com/repos/lionel-/Rcpp/forks","keys_url":"https://api.github.com/repos/lionel-/Rcpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lionel-/Rcpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lionel-/Rcpp/teams","hooks_url":"https://api.github.com/repos/lionel-/Rcpp/hooks","issue_events_url":"https://api.github.com/repos/lionel-/Rcpp/issues/events{/number}","events_url":"https://api.github.com/repos/lionel-/Rcpp/events","assignees_url":"https://api.github.com/repos/lionel-/Rcpp/assignees{/user}","branches_url":"https://api.github.com/repos/lionel-/Rcpp/branches{/branch}","tags_url":"https://api.github.com/repos/lionel-/Rcpp/tags","blobs_url":"https://api.github.com/repos/lionel-/Rcpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lionel-/Rcpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lionel-/Rcpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/lionel-/Rcpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lionel-/Rcpp/statuses/{sha}","languages_url":"https://api.github.com/repos/lionel-/Rcpp/languages","stargazers_url":"https://api.github.com/repos/lionel-/Rcpp/stargazers","contributors_url":"https://api.github.com/repos/lionel-/Rcpp/contributors","subscribers_url":"https://api.github.com/repos/lionel-/Rcpp/subscribers","subscription_url":"https://api.github.com/repos/lionel-/Rcpp/subscription","commits_url":"https://api.github.com/repos/lionel-/Rcpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/lionel-/Rcpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/lionel-/Rcpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/lionel-/Rcpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/lionel-/Rcpp/contents/{+path}","compare_url":"https://api.github.com/repos/lionel-/Rcpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lionel-/Rcpp/merges","archive_url":"https://api.github.com/repos/lionel-/Rcpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lionel-/Rcpp/downloads","issues_url":"https://api.github.com/repos/lionel-/Rcpp/issues{/number}","pulls_url":"https://api.github.com/repos/lionel-/Rcpp/pulls{/number}","milestones_url":"https://api.github.com/repos/lionel-/Rcpp/milestones{/number}","notifications_url":"https://api.github.com/repos/lionel-/Rcpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lionel-/Rcpp/labels{/name}","releases_url":"https://api.github.com/repos/lionel-/Rcpp/releases{/id}","deployments_url":"https://api.github.com/repos/lionel-/Rcpp/deployments","created_at":"2015-02-19T20:41:03Z","updated_at":"2015-02-19T20:41:05Z","pushed_at":"2018-06-01T23:15:37Z","git_url":"git://github.com/lionel-/Rcpp.git","ssh_url":"git@github.com:lionel-/Rcpp.git","clone_url":"https://github.com/lionel-/Rcpp.git","svn_url":"https://github.com/lionel-/Rcpp","homepage":"","size":15270,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RcppCore:master","ref":"master","sha":"6886a43ba273c19deb7feaa9c899645d60523a03","user":{"login":"RcppCore","id":5811336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTEzMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5811336?v=4","gravatar_id":"","url":"https://api.github.com/users/RcppCore","html_url":"https://github.com/RcppCore","followers_url":"https://api.github.com/users/RcppCore/followers","following_url":"https://api.github.com/users/RcppCore/following{/other_user}","gists_url":"https://api.github.com/users/RcppCore/gists{/gist_id}","starred_url":"https://api.github.com/users/RcppCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RcppCore/subscriptions","organizations_url":"https://api.github.com/users/RcppCore/orgs","repos_url":"https://api.github.com/users/RcppCore/repos","events_url":"https://api.github.com/users/RcppCore/events{/privacy}","received_events_url":"https://api.github.com/users/RcppCore/received_events","type":"Organization","site_admin":false},"repo":{"id":14005591,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwNTU5MQ==","name":"Rcpp","full_name":"RcppCore/Rcpp","owner":{"login":"RcppCore","id":5811336,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4MTEzMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/5811336?v=4","gravatar_id":"","url":"https://api.github.com/users/RcppCore","html_url":"https://github.com/RcppCore","followers_url":"https://api.github.com/users/RcppCore/followers","following_url":"https://api.github.com/users/RcppCore/following{/other_user}","gists_url":"https://api.github.com/users/RcppCore/gists{/gist_id}","starred_url":"https://api.github.com/users/RcppCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RcppCore/subscriptions","organizations_url":"https://api.github.com/users/RcppCore/orgs","repos_url":"https://api.github.com/users/RcppCore/repos","events_url":"https://api.github.com/users/RcppCore/events{/privacy}","received_events_url":"https://api.github.com/users/RcppCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RcppCore/Rcpp","description":"Seamless R and C++ Integration","fork":false,"url":"https://api.github.com/repos/RcppCore/Rcpp","forks_url":"https://api.github.com/repos/RcppCore/Rcpp/forks","keys_url":"https://api.github.com/repos/RcppCore/Rcpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RcppCore/Rcpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RcppCore/Rcpp/teams","hooks_url":"https://api.github.com/repos/RcppCore/Rcpp/hooks","issue_events_url":"https://api.github.com/repos/RcppCore/Rcpp/issues/events{/number}","events_url":"https://api.github.com/repos/RcppCore/Rcpp/events","assignees_url":"https://api.github.com/repos/RcppCore/Rcpp/assignees{/user}","branches_url":"https://api.github.com/repos/RcppCore/Rcpp/branches{/branch}","tags_url":"https://api.github.com/repos/RcppCore/Rcpp/tags","blobs_url":"https://api.github.com/repos/RcppCore/Rcpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RcppCore/Rcpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RcppCore/Rcpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/RcppCore/Rcpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RcppCore/Rcpp/statuses/{sha}","languages_url":"https://api.github.com/repos/RcppCore/Rcpp/languages","stargazers_url":"https://api.github.com/repos/RcppCore/Rcpp/stargazers","contributors_url":"https://api.github.com/repos/RcppCore/Rcpp/contributors","subscribers_url":"https://api.github.com/repos/RcppCore/Rcpp/subscribers","subscription_url":"https://api.github.com/repos/RcppCore/Rcpp/subscription","commits_url":"https://api.github.com/repos/RcppCore/Rcpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/RcppCore/Rcpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/RcppCore/Rcpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/RcppCore/Rcpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/RcppCore/Rcpp/contents/{+path}","compare_url":"https://api.github.com/repos/RcppCore/Rcpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RcppCore/Rcpp/merges","archive_url":"https://api.github.com/repos/RcppCore/Rcpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RcppCore/Rcpp/downloads","issues_url":"https://api.github.com/repos/RcppCore/Rcpp/issues{/number}","pulls_url":"https://api.github.com/repos/RcppCore/Rcpp/pulls{/number}","milestones_url":"https://api.github.com/repos/RcppCore/Rcpp/milestones{/number}","notifications_url":"https://api.github.com/repos/RcppCore/Rcpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RcppCore/Rcpp/labels{/name}","releases_url":"https://api.github.com/repos/RcppCore/Rcpp/releases{/id}","deployments_url":"https://api.github.com/repos/RcppCore/Rcpp/deployments","created_at":"2013-10-31T02:30:38Z","updated_at":"2018-06-01T18:47:29Z","pushed_at":"2018-06-01T18:47:26Z","git_url":"git://github.com/RcppCore/Rcpp.git","ssh_url":"git@github.com:RcppCore/Rcpp.git","clone_url":"https://github.com/RcppCore/Rcpp.git","svn_url":"https://github.com/RcppCore/Rcpp","homepage":"","size":14533,"stargazers_count":372,"watchers_count":372,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":144,"open_issues":94,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859"},"html":{"href":"https://github.com/RcppCore/Rcpp/pull/859"},"issue":{"href":"https://api.github.com/repos/RcppCore/Rcpp/issues/859"},"comments":{"href":"https://api.github.com/repos/RcppCore/Rcpp/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/RcppCore/Rcpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RcppCore/Rcpp/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/RcppCore/Rcpp/statuses/b4cc4ef9ccd5ab8b86f7d56bd31ef6c061fd82d4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":10,"additions":421,"deletions":125,"changed_files":22}}
{"actor":{"display_login":"lionel-"}}