{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/74","repository_url":"https://api.github.com/repos/NativeScript/nativescript-fresco","labels_url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/74/comments","events_url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/74/events","html_url":"https://github.com/NativeScript/nativescript-fresco/pull/74","id":332937380,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzAxMjA0","number":74,"title":"fix: Fix for #59 and improved typing","user":{"login":"DickSmith","id":6675511,"node_id":"MDQ6VXNlcjY2NzU1MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/6675511?v=4","gravatar_id":"","url":"https://api.github.com/users/DickSmith","html_url":"https://github.com/DickSmith","followers_url":"https://api.github.com/users/DickSmith/followers","following_url":"https://api.github.com/users/DickSmith/following{/other_user}","gists_url":"https://api.github.com/users/DickSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/DickSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickSmith/subscriptions","organizations_url":"https://api.github.com/users/DickSmith/orgs","repos_url":"https://api.github.com/users/DickSmith/repos","events_url":"https://api.github.com/users/DickSmith/events{/privacy}","received_events_url":"https://api.github.com/users/DickSmith/received_events","type":"User","site_admin":false},"labels":[{"id":768960964,"node_id":"MDU6TGFiZWw3Njg5NjA5NjQ=","url":"https://api.github.com/repos/NativeScript/nativescript-fresco/labels/new%20PR","name":"new PR","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-15T23:11:41Z","updated_at":"2018-06-26T08:05:41Z","closed_at":"2018-06-26T08:05:41Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-fresco/pulls/74","html_url":"https://github.com/NativeScript/nativescript-fresco/pull/74","diff_url":"https://github.com/NativeScript/nativescript-fresco/pull/74.diff","patch_url":"https://github.com/NativeScript/nativescript-fresco/pull/74.patch"},"body":"Fix for #59 and improved typing\r\n```\r\nFatal Exception: com.tns.NativeScriptException\r\nCalling js method onCreateView failed Error: com.facebook.imagepipeline.request.ImageRequestBuilder$BuilderException: Invalid request builder: Resource URI must not be empty com.facebook.imagepipeline.request.ImageRequestBuilder.validate(ImageRequestBuilder.java:277) com.facebook.imagepipeline.request.ImageRequestBuilder.build(ImageRequestBuilder.java:253) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1100) com.tns.Runtime.callJSMethodImpl(Runtime.java:982) com.tns.Runtime.callJSMethod(Runtime.java:969) com.tns.Runtime.callJSMethod(Runtime.java:953) com.tns.Runtime.callJSMethod(Runtime.java:945) com.tns.FragmentClass.onCreateView(FragmentClass.java:45) android.app.Fragment.performCreateView(Fragment.java:2220) android.app.FragmentManagerImpl.moveToState(FragmentManager.java:973) android.app.FragmentManagerImpl.moveToState(FragmentManager.java:1148) android.app.BackStackRecord.run(BackStackRecord.java:793) android.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1535) android.app.FragmentManagerImpl$1.run(FragmentManager.java:482) android.os.Handler.handleCallback(Handler.java:739) android.os.Handler.dispatchMessage(Handler.java:95) android.os.Looper.loop(Looper.java:148) android.app.ActivityThread.main(ActivityThread.java:5417) java.lang.reflect.Method.invoke(Native Method) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:742) com.android.internal.os.ZygoteInit.main(ZygoteInit.java:632) File: \"<embedded>, line: 36, column: 1105305 StackTrace: Frame: function:'t.initImage', file:'<embedded>', line: 36, column: 1105306 Frame: function:'t.initDrawee', file:'<embedded>', line: 36, column: 1104279 Frame: function:'t.initNativeView', file:'<embedded>', line: 36, column: 1102653 Frame: function:'t.setNativeView', file:'<embedded>', line: 36, column: 1286625 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286119 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 1464842 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 1464842 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 1464842 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 628054 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 1464842 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'', file:'<embedded>', line: 36, column: 1286374 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 628054 Frame: function:'t.eachChildView', file:'<embedded>', line: 36, column: 1448752 Frame: function:'n.eachChild', file:'<embedded>', line: 36, column: 1273517 Frame: function:'t._setupUI', file:'<embedded>', line: 36, column: 1286350 Frame: function:'t._addViewCore', file:'<embedded>', line: 36, column: 1284245 Frame: function:'t._addView', file:'<embedded>', line: 36, column: 1283968 Frame: function:'e.onCreateView', file:'<embedded>', line: 36, column: 560440 Frame: function:'t.onCreateView', file:'<embedded>', line: 36, column: 1316946\r\ncom.tns.Runtime.callJSMethodNative (Runtime.java)\r\ncom.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1100)\r\ncom.tns.Runtime.callJSMethodImpl (Runtime.java:982)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:969)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:953)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:945)\r\ncom.tns.FragmentClass.onCreateView (FragmentClass.java:45)\r\nandroid.app.Fragment.performCreateView (Fragment.java:2220)\r\nandroid.app.FragmentManagerImpl.moveToState (FragmentManager.java:973)\r\nandroid.app.FragmentManagerImpl.moveToState (FragmentManager.java:1148)\r\nandroid.app.BackStackRecord.run (BackStackRecord.java:793)\r\nandroid.app.FragmentManagerImpl.execPendingActions (FragmentManager.java:1535)\r\nandroid.app.FragmentManagerImpl$1.run (FragmentManager.java:482)\r\nandroid.os.Handler.handleCallback (Handler.java:739)\r\nandroid.os.Handler.dispatchMessage (Handler.java:95)\r\nandroid.os.Looper.loop (Looper.java:148)\r\nandroid.app.ActivityThread.main (ActivityThread.java:5417)\r\njava.lang.reflect.Method.invoke (Method.java)\r\ncom.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:742)\r\ncom.android.internal.os.ZygoteInit.main (ZygoteInit.java:632)\r\n```\r\n\r\n```\r\nCaused by com.facebook.imagepipeline.request.ImageRequestBuilder$BuilderException\r\nInvalid request builder: Resource URI must not be empty\r\ncom.facebook.imagepipeline.request.ImageRequestBuilder.validate (ImageRequestBuilder.java:277)\r\ncom.facebook.imagepipeline.request.ImageRequestBuilder.build (ImageRequestBuilder.java:253)\r\ncom.tns.Runtime.callJSMethodNative (Runtime.java)\r\ncom.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1100)\r\ncom.tns.Runtime.callJSMethodImpl (Runtime.java:982)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:969)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:953)\r\ncom.tns.Runtime.callJSMethod (Runtime.java:945)\r\ncom.tns.FragmentClass.onCreateView (FragmentClass.java:45)\r\nandroid.app.Fragment.performCreateView (Fragment.java:2220)\r\nandroid.app.FragmentManagerImpl.moveToState (FragmentManager.java:973)\r\nandroid.app.FragmentManagerImpl.moveToState (FragmentManager.java:1148)\r\nandroid.app.BackStackRecord.run (BackStackRecord.java:793)\r\nandroid.app.FragmentManagerImpl.execPendingActions (FragmentManager.java:1535)\r\nandroid.app.FragmentManagerImpl$1.run (FragmentManager.java:482)\r\nandroid.os.Handler.handleCallback (Handler.java:739)\r\nandroid.os.Handler.dispatchMessage (Handler.java:95)\r\nandroid.os.Looper.loop (Looper.java:148)\r\nandroid.app.ActivityThread.main (ActivityThread.java:5417)\r\njava.lang.reflect.Method.invoke (Method.java)\r\ncom.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:742)\r\ncom.android.internal.os.ZygoteInit.main (ZygoteInit.java:632)\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/comments/400218505","html_url":"https://github.com/NativeScript/nativescript-fresco/pull/74#issuecomment-400218505","issue_url":"https://api.github.com/repos/NativeScript/nativescript-fresco/issues/74","id":400218505,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIxODUwNQ==","user":{"login":"VladimirAmiorkov","id":4989411,"node_id":"MDQ6VXNlcjQ5ODk0MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/4989411?v=4","gravatar_id":"","url":"https://api.github.com/users/VladimirAmiorkov","html_url":"https://github.com/VladimirAmiorkov","followers_url":"https://api.github.com/users/VladimirAmiorkov/followers","following_url":"https://api.github.com/users/VladimirAmiorkov/following{/other_user}","gists_url":"https://api.github.com/users/VladimirAmiorkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirAmiorkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirAmiorkov/subscriptions","organizations_url":"https://api.github.com/users/VladimirAmiorkov/orgs","repos_url":"https://api.github.com/users/VladimirAmiorkov/repos","events_url":"https://api.github.com/users/VladimirAmiorkov/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirAmiorkov/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:05:40Z","updated_at":"2018-06-26T08:05:40Z","author_association":"MEMBER","body":"Hi @DickSmith ,\r\n\r\nThank you for your PR. As I was in the middle of migrating (#16) the entire plugin to use the latest version of the native Android library I also internally applied your PR changes as it would have made this PR outdated and require it to be rebased. \r\n\r\nI will be closing [this](https://github.com/NativeScript/nativescript-fresco/pull/77) PR you can follow this one to be notified when it is released with your changes."}}
{"actor":{"display_login":"VladimirAmiorkov"}}