{"action":"created","issue":{"url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/47","repository_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1","labels_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/47/comments","events_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/47/events","html_url":"https://github.com/rust-bitcoin/rust-secp256k1/issues/47","id":349836902,"node_id":"MDU6SXNzdWUzNDk4MzY5MDI=","number":47,"title":"Change 'add_assign' to take a byte slice rather than another 'SecretKey'","user":{"login":"omershlo","id":2446179,"node_id":"MDQ6VXNlcjI0NDYxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2446179?v=4","gravatar_id":"","url":"https://api.github.com/users/omershlo","html_url":"https://github.com/omershlo","followers_url":"https://api.github.com/users/omershlo/followers","following_url":"https://api.github.com/users/omershlo/following{/other_user}","gists_url":"https://api.github.com/users/omershlo/gists{/gist_id}","starred_url":"https://api.github.com/users/omershlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omershlo/subscriptions","organizations_url":"https://api.github.com/users/omershlo/orgs","repos_url":"https://api.github.com/users/omershlo/repos","events_url":"https://api.github.com/users/omershlo/events{/privacy}","received_events_url":"https://api.github.com/users/omershlo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-12T19:18:55Z","updated_at":"2018-08-15T17:40:36Z","closed_at":null,"author_association":"NONE","body":"Hi, \r\n\r\n\r\nI encountered this limitation a few times for the use case of threshold and multi signatures. \r\nIn practice tweaks are more likely to be hashes (or zero) than things that are conceptually \"secret keys\". \r\nOther elliptic curve libraries seems to allow this tweak and doing field arithmetic using zero element. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/comments/413276075","html_url":"https://github.com/rust-bitcoin/rust-secp256k1/issues/47#issuecomment-413276075","issue_url":"https://api.github.com/repos/rust-bitcoin/rust-secp256k1/issues/47","id":413276075,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzI3NjA3NQ==","user":{"login":"omershlo","id":2446179,"node_id":"MDQ6VXNlcjI0NDYxNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2446179?v=4","gravatar_id":"","url":"https://api.github.com/users/omershlo","html_url":"https://github.com/omershlo","followers_url":"https://api.github.com/users/omershlo/followers","following_url":"https://api.github.com/users/omershlo/following{/other_user}","gists_url":"https://api.github.com/users/omershlo/gists{/gist_id}","starred_url":"https://api.github.com/users/omershlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omershlo/subscriptions","organizations_url":"https://api.github.com/users/omershlo/orgs","repos_url":"https://api.github.com/users/omershlo/repos","events_url":"https://api.github.com/users/omershlo/events{/privacy}","received_events_url":"https://api.github.com/users/omershlo/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T17:40:36Z","updated_at":"2018-08-15T17:40:36Z","author_association":"NONE","body":"Thanks.\r\nYou are right about the usage of the library. We wrote an abstraction that allows to plug this lib for various cryptosystems more easily (https://github.com/KZen-networks/cryptography-utils/blob/rewrite_ec_abstract/src/elliptic/curves/secp256_k1.rs). That said, for every new construction built using this abstraction (such as threshold/multi sigs) further analysis is required. "}}
{"actor":{"display_login":"omershlo"}}