{"action":"created","comment":{"url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/comments/196735270","pull_request_review_id":130343472,"id":196735270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjczNTI3MA==","diff_hunk":"@@ -0,0 +1,16 @@\n+FROM tomsowerby/php-5.3\n+\n+RUn apt-get update -yqq && apt-get upgrade -yqq\n+\n+RUN apt-get install -yqq git-core\n+\n+RUN pecl install -o -f redis &&  rm -rf /tmp/pear &&  docker-php-ext-enable redis\n+\n+# composer\n+RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer\n+\n+RUN docker-php-ext-install pcntl\n+\n+\n+CMD composer install -v && tail -f /dev/null","path":"docker/app_5_3/Dockerfile","position":15,"original_position":15,"commit_id":"29a5000c8949ce8aeee84e9d95146db30c15c5d1","original_commit_id":"29a5000c8949ce8aeee84e9d95146db30c15c5d1","user":{"login":"scones","id":472339,"node_id":"MDQ6VXNlcjQ3MjMzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/472339?v=4","gravatar_id":"","url":"https://api.github.com/users/scones","html_url":"https://github.com/scones","followers_url":"https://api.github.com/users/scones/followers","following_url":"https://api.github.com/users/scones/following{/other_user}","gists_url":"https://api.github.com/users/scones/gists{/gist_id}","starred_url":"https://api.github.com/users/scones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scones/subscriptions","organizations_url":"https://api.github.com/users/scones/orgs","repos_url":"https://api.github.com/users/scones/repos","events_url":"https://api.github.com/users/scones/events{/privacy}","received_events_url":"https://api.github.com/users/scones/received_events","type":"User","site_admin":false},"body":"`tail -f` attaches itself to a stream and listens. with `/dev/null` as a stream there will be no output, but the stream stays open.\r\n\r\nin combination it keeps the CMD running without producing spam.\r\nThus the docker container won't shut down after it booted up, but stays active.\r\n","created_at":"2018-06-20T11:10:49Z","updated_at":"2018-06-20T11:10:49Z","html_url":"https://github.com/mjphaynes/php-resque/pull/88#discussion_r196735270","pull_request_url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/comments/196735270"},"html":{"href":"https://github.com/mjphaynes/php-resque/pull/88#discussion_r196735270"},"pull_request":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88"}},"in_reply_to_id":196483890},"pull_request":{"url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88","id":194016359,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDE2MzU5","html_url":"https://github.com/mjphaynes/php-resque/pull/88","diff_url":"https://github.com/mjphaynes/php-resque/pull/88.diff","patch_url":"https://github.com/mjphaynes/php-resque/pull/88.patch","issue_url":"https://api.github.com/repos/mjphaynes/php-resque/issues/88","number":88,"state":"open","locked":false,"title":"provide predis native configuration option","user":{"login":"scones","id":472339,"node_id":"MDQ6VXNlcjQ3MjMzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/472339?v=4","gravatar_id":"","url":"https://api.github.com/users/scones","html_url":"https://github.com/scones","followers_url":"https://api.github.com/users/scones/followers","following_url":"https://api.github.com/users/scones/following{/other_user}","gists_url":"https://api.github.com/users/scones/gists{/gist_id}","starred_url":"https://api.github.com/users/scones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scones/subscriptions","organizations_url":"https://api.github.com/users/scones/orgs","repos_url":"https://api.github.com/users/scones/repos","events_url":"https://api.github.com/users/scones/events{/privacy}","received_events_url":"https://api.github.com/users/scones/received_events","type":"User","site_admin":false},"body":"the current wrapper class does not allow for a deviation from \"one redis server\" configuration variant of predis.\r\n\r\nAs Resque in itself is a technology one usually uses in more complex setups, the need for a more complex redis-setup arises.\r\nThe provided predis version does have all these options, but the wrapper is too limited.\r\n\r\nThis patch allows for direct configuration of predis via the predis section in the `config.yml`\r\nit effectively overrides anything configured in the redis section, so one has to chose.\r\n\r\nI provided a sentinel example for that.\r\n\r\nIn addition i added the following things for a brighter future:\r\n- `Dockerfile` file for testing \r\n- `docker-compose.yml` file for testing\r\n- a basic editorconfig\r\n- 2 tests (Redis with legacy initialization, Redis with override initialization)\r\n- a `.gitattributes` file\r\n\r\nif this gets merged i also have the tools to work on the handler thing again (#85 )\r\n\r\n\r\nbest regards,\r\nscones\r\n","created_at":"2018-06-11T15:20:33Z","updated_at":"2018-06-20T11:10:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd51905e047ba78b65d5a81fe9166c64da01eefd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60110203,"node_id":"MDU6TGFiZWw2MDExMDIwMw==","url":"https://api.github.com/repos/mjphaynes/php-resque/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false},{"id":679220099,"node_id":"MDU6TGFiZWw2NzkyMjAwOTk=","url":"https://api.github.com/repos/mjphaynes/php-resque/labels/Waiting%20for%20feedback","name":"Waiting for feedback","color":"fef2c0","default":false},{"id":782703150,"node_id":"MDU6TGFiZWw3ODI3MDMxNTA=","url":"https://api.github.com/repos/mjphaynes/php-resque/labels/Work%20in%20progress","name":"Work in progress","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/mjphaynes/php-resque/milestones/4","html_url":"https://github.com/mjphaynes/php-resque/milestone/4","labels_url":"https://api.github.com/repos/mjphaynes/php-resque/milestones/4/labels","id":2735341,"node_id":"MDk6TWlsZXN0b25lMjczNTM0MQ==","number":4,"title":"2.2","description":"PHP-Resque Release 2.2","creator":{"login":"xelan","id":5080535,"node_id":"MDQ6VXNlcjUwODA1MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5080535?v=4","gravatar_id":"","url":"https://api.github.com/users/xelan","html_url":"https://github.com/xelan","followers_url":"https://api.github.com/users/xelan/followers","following_url":"https://api.github.com/users/xelan/following{/other_user}","gists_url":"https://api.github.com/users/xelan/gists{/gist_id}","starred_url":"https://api.github.com/users/xelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelan/subscriptions","organizations_url":"https://api.github.com/users/xelan/orgs","repos_url":"https://api.github.com/users/xelan/repos","events_url":"https://api.github.com/users/xelan/events{/privacy}","received_events_url":"https://api.github.com/users/xelan/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2017-08-31T08:52:30Z","updated_at":"2018-06-19T15:44:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88/commits","review_comments_url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88/comments","review_comment_url":"https://api.github.com/repos/mjphaynes/php-resque/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjphaynes/php-resque/issues/88/comments","statuses_url":"https://api.github.com/repos/mjphaynes/php-resque/statuses/29a5000c8949ce8aeee84e9d95146db30c15c5d1","head":{"label":"vmpublishing:master","ref":"master","sha":"29a5000c8949ce8aeee84e9d95146db30c15c5d1","user":{"login":"vmpublishing","id":9592148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTIxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9592148?v=4","gravatar_id":"","url":"https://api.github.com/users/vmpublishing","html_url":"https://github.com/vmpublishing","followers_url":"https://api.github.com/users/vmpublishing/followers","following_url":"https://api.github.com/users/vmpublishing/following{/other_user}","gists_url":"https://api.github.com/users/vmpublishing/gists{/gist_id}","starred_url":"https://api.github.com/users/vmpublishing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmpublishing/subscriptions","organizations_url":"https://api.github.com/users/vmpublishing/orgs","repos_url":"https://api.github.com/users/vmpublishing/repos","events_url":"https://api.github.com/users/vmpublishing/events{/privacy}","received_events_url":"https://api.github.com/users/vmpublishing/received_events","type":"Organization","site_admin":false},"repo":{"id":136899418,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4OTk0MTg=","name":"php-resque","full_name":"vmpublishing/php-resque","owner":{"login":"vmpublishing","id":9592148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1OTIxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9592148?v=4","gravatar_id":"","url":"https://api.github.com/users/vmpublishing","html_url":"https://github.com/vmpublishing","followers_url":"https://api.github.com/users/vmpublishing/followers","following_url":"https://api.github.com/users/vmpublishing/following{/other_user}","gists_url":"https://api.github.com/users/vmpublishing/gists{/gist_id}","starred_url":"https://api.github.com/users/vmpublishing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmpublishing/subscriptions","organizations_url":"https://api.github.com/users/vmpublishing/orgs","repos_url":"https://api.github.com/users/vmpublishing/repos","events_url":"https://api.github.com/users/vmpublishing/events{/privacy}","received_events_url":"https://api.github.com/users/vmpublishing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmpublishing/php-resque","description":"php-resque is a Redis-backed PHP library for creating background jobs, placing them on multiple queues, and processing them later.","fork":true,"url":"https://api.github.com/repos/vmpublishing/php-resque","forks_url":"https://api.github.com/repos/vmpublishing/php-resque/forks","keys_url":"https://api.github.com/repos/vmpublishing/php-resque/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmpublishing/php-resque/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmpublishing/php-resque/teams","hooks_url":"https://api.github.com/repos/vmpublishing/php-resque/hooks","issue_events_url":"https://api.github.com/repos/vmpublishing/php-resque/issues/events{/number}","events_url":"https://api.github.com/repos/vmpublishing/php-resque/events","assignees_url":"https://api.github.com/repos/vmpublishing/php-resque/assignees{/user}","branches_url":"https://api.github.com/repos/vmpublishing/php-resque/branches{/branch}","tags_url":"https://api.github.com/repos/vmpublishing/php-resque/tags","blobs_url":"https://api.github.com/repos/vmpublishing/php-resque/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmpublishing/php-resque/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmpublishing/php-resque/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmpublishing/php-resque/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmpublishing/php-resque/statuses/{sha}","languages_url":"https://api.github.com/repos/vmpublishing/php-resque/languages","stargazers_url":"https://api.github.com/repos/vmpublishing/php-resque/stargazers","contributors_url":"https://api.github.com/repos/vmpublishing/php-resque/contributors","subscribers_url":"https://api.github.com/repos/vmpublishing/php-resque/subscribers","subscription_url":"https://api.github.com/repos/vmpublishing/php-resque/subscription","commits_url":"https://api.github.com/repos/vmpublishing/php-resque/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmpublishing/php-resque/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmpublishing/php-resque/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmpublishing/php-resque/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmpublishing/php-resque/contents/{+path}","compare_url":"https://api.github.com/repos/vmpublishing/php-resque/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmpublishing/php-resque/merges","archive_url":"https://api.github.com/repos/vmpublishing/php-resque/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmpublishing/php-resque/downloads","issues_url":"https://api.github.com/repos/vmpublishing/php-resque/issues{/number}","pulls_url":"https://api.github.com/repos/vmpublishing/php-resque/pulls{/number}","milestones_url":"https://api.github.com/repos/vmpublishing/php-resque/milestones{/number}","notifications_url":"https://api.github.com/repos/vmpublishing/php-resque/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmpublishing/php-resque/labels{/name}","releases_url":"https://api.github.com/repos/vmpublishing/php-resque/releases{/id}","deployments_url":"https://api.github.com/repos/vmpublishing/php-resque/deployments","created_at":"2018-06-11T08:50:26Z","updated_at":"2018-06-13T15:18:54Z","pushed_at":"2018-06-13T15:18:52Z","git_url":"git://github.com/vmpublishing/php-resque.git","ssh_url":"git@github.com:vmpublishing/php-resque.git","clone_url":"https://github.com/vmpublishing/php-resque.git","svn_url":"https://github.com/vmpublishing/php-resque","homepage":null,"size":224,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjphaynes:master","ref":"master","sha":"935824e5f13afa8824b980cc47934d37ebdd6e22","user":{"login":"mjphaynes","id":697891,"node_id":"MDQ6VXNlcjY5Nzg5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/697891?v=4","gravatar_id":"","url":"https://api.github.com/users/mjphaynes","html_url":"https://github.com/mjphaynes","followers_url":"https://api.github.com/users/mjphaynes/followers","following_url":"https://api.github.com/users/mjphaynes/following{/other_user}","gists_url":"https://api.github.com/users/mjphaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjphaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjphaynes/subscriptions","organizations_url":"https://api.github.com/users/mjphaynes/orgs","repos_url":"https://api.github.com/users/mjphaynes/repos","events_url":"https://api.github.com/users/mjphaynes/events{/privacy}","received_events_url":"https://api.github.com/users/mjphaynes/received_events","type":"User","site_admin":false},"repo":{"id":13443987,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0Mzk4Nw==","name":"php-resque","full_name":"mjphaynes/php-resque","owner":{"login":"mjphaynes","id":697891,"node_id":"MDQ6VXNlcjY5Nzg5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/697891?v=4","gravatar_id":"","url":"https://api.github.com/users/mjphaynes","html_url":"https://github.com/mjphaynes","followers_url":"https://api.github.com/users/mjphaynes/followers","following_url":"https://api.github.com/users/mjphaynes/following{/other_user}","gists_url":"https://api.github.com/users/mjphaynes/gists{/gist_id}","starred_url":"https://api.github.com/users/mjphaynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjphaynes/subscriptions","organizations_url":"https://api.github.com/users/mjphaynes/orgs","repos_url":"https://api.github.com/users/mjphaynes/repos","events_url":"https://api.github.com/users/mjphaynes/events{/privacy}","received_events_url":"https://api.github.com/users/mjphaynes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjphaynes/php-resque","description":"php-resque is a Redis-backed PHP library for creating background jobs, placing them on multiple queues, and processing them later.","fork":false,"url":"https://api.github.com/repos/mjphaynes/php-resque","forks_url":"https://api.github.com/repos/mjphaynes/php-resque/forks","keys_url":"https://api.github.com/repos/mjphaynes/php-resque/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjphaynes/php-resque/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjphaynes/php-resque/teams","hooks_url":"https://api.github.com/repos/mjphaynes/php-resque/hooks","issue_events_url":"https://api.github.com/repos/mjphaynes/php-resque/issues/events{/number}","events_url":"https://api.github.com/repos/mjphaynes/php-resque/events","assignees_url":"https://api.github.com/repos/mjphaynes/php-resque/assignees{/user}","branches_url":"https://api.github.com/repos/mjphaynes/php-resque/branches{/branch}","tags_url":"https://api.github.com/repos/mjphaynes/php-resque/tags","blobs_url":"https://api.github.com/repos/mjphaynes/php-resque/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjphaynes/php-resque/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjphaynes/php-resque/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjphaynes/php-resque/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjphaynes/php-resque/statuses/{sha}","languages_url":"https://api.github.com/repos/mjphaynes/php-resque/languages","stargazers_url":"https://api.github.com/repos/mjphaynes/php-resque/stargazers","contributors_url":"https://api.github.com/repos/mjphaynes/php-resque/contributors","subscribers_url":"https://api.github.com/repos/mjphaynes/php-resque/subscribers","subscription_url":"https://api.github.com/repos/mjphaynes/php-resque/subscription","commits_url":"https://api.github.com/repos/mjphaynes/php-resque/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjphaynes/php-resque/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjphaynes/php-resque/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjphaynes/php-resque/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjphaynes/php-resque/contents/{+path}","compare_url":"https://api.github.com/repos/mjphaynes/php-resque/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjphaynes/php-resque/merges","archive_url":"https://api.github.com/repos/mjphaynes/php-resque/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjphaynes/php-resque/downloads","issues_url":"https://api.github.com/repos/mjphaynes/php-resque/issues{/number}","pulls_url":"https://api.github.com/repos/mjphaynes/php-resque/pulls{/number}","milestones_url":"https://api.github.com/repos/mjphaynes/php-resque/milestones{/number}","notifications_url":"https://api.github.com/repos/mjphaynes/php-resque/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjphaynes/php-resque/labels{/name}","releases_url":"https://api.github.com/repos/mjphaynes/php-resque/releases{/id}","deployments_url":"https://api.github.com/repos/mjphaynes/php-resque/deployments","created_at":"2013-10-09T14:08:21Z","updated_at":"2018-05-30T22:04:07Z","pushed_at":"2018-06-13T15:18:53Z","git_url":"git://github.com/mjphaynes/php-resque.git","ssh_url":"git@github.com:mjphaynes/php-resque.git","clone_url":"https://github.com/mjphaynes/php-resque.git","svn_url":"https://github.com/mjphaynes/php-resque","homepage":null,"size":208,"stargazers_count":160,"watchers_count":160,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":25,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88"},"html":{"href":"https://github.com/mjphaynes/php-resque/pull/88"},"issue":{"href":"https://api.github.com/repos/mjphaynes/php-resque/issues/88"},"comments":{"href":"https://api.github.com/repos/mjphaynes/php-resque/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjphaynes/php-resque/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/mjphaynes/php-resque/statuses/29a5000c8949ce8aeee84e9d95146db30c15c5d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scones"}}