{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/191004505","pull_request_review_id":123506968,"id":191004505,"diff_hunk":"@@ -5,11 +5,43 @@\n     with_app { generate(\"suspenders:production:email\") }\n \n     expect(\"config/smtp.rb\").to match_contents(%r{SMTP_SETTINGS\\s*=})\n+\n     expect(\"config/environments/production.rb\").to \\\n       match_contents(%r{require.+config/smtp})\n     expect(\"config/environments/production.rb\").to \\\n       match_contents(%r{action_mailer.delivery_method\\s*=\\s*:smtp})\n     expect(\"config/environments/production.rb\").to \\\n       match_contents(%r{action_mailer.smtp_settings\\s*=\\s*SMTP_SETTINGS})\n+\n+    expect(\"app.json\").to contain_json(\n+      env: {\n+        SMTP_ADDRESS: { required: true },\n+        SMTP_DOMAIN: { required: true },\n+        SMTP_PASSWORD: { required: true },\n+        SMTP_USERNAME: { required: true },\n+      },\n+    )\n+  end\n+\n+  it \"destroys the configuration for a production email deployment\" do\n+    with_app { destroy(\"suspenders:production:email\") }\n+\n+    expect(\"config/smtp.rb\").not_to exist_as_a_file\n+\n+    expect(\"config/environments/production.rb\").not_to \\\n+      match_contents(%r{require.+config/smtp})\n+    expect(\"config/environments/production.rb\").not_to \\\n+      match_contents(%r{action_mailer.delivery_method\\s*=\\s*:smtp})\n+    expect(\"config/environments/production.rb\").not_to \\\n+      match_contents(%r{action_mailer.smtp_settings\\s*=\\s*SMTP_SETTINGS})\n+\n+    expect(\"app.json\").not_to contain_json(\n+      env: {\n+        SMTP_ADDRESS: { required: true },\n+        SMTP_DOMAIN: { required: true },\n+        SMTP_PASSWORD: { required: true },\n+        SMTP_USERNAME: { required: true },","path":"spec/features/production/email_spec.rb","position":17,"original_position":39,"commit_id":"6dbb96d8e6b485e3e6e99a5d280dae189113e0ec","original_commit_id":"6dbb96d8e6b485e3e6e99a5d280dae189113e0ec","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.","created_at":"2018-05-25T20:39:16Z","updated_at":"2018-05-25T20:39:16Z","html_url":"https://github.com/thoughtbot/suspenders/pull/908#discussion_r191004505","pull_request_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/191004505"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/908#discussion_r191004505"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908","id":181529324,"html_url":"https://github.com/thoughtbot/suspenders/pull/908","diff_url":"https://github.com/thoughtbot/suspenders/pull/908.diff","patch_url":"https://github.com/thoughtbot/suspenders/pull/908.patch","issue_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/908","number":908,"state":"open","locked":false,"title":"suspenders:production:email can control app.json","user":{"login":"mike-burns","id":4550,"avatar_url":"https://avatars3.githubusercontent.com/u/4550?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-burns","html_url":"https://github.com/mike-burns","followers_url":"https://api.github.com/users/mike-burns/followers","following_url":"https://api.github.com/users/mike-burns/following{/other_user}","gists_url":"https://api.github.com/users/mike-burns/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-burns/subscriptions","organizations_url":"https://api.github.com/users/mike-burns/orgs","repos_url":"https://api.github.com/users/mike-burns/repos","events_url":"https://api.github.com/users/mike-burns/events{/privacy}","received_events_url":"https://api.github.com/users/mike-burns/received_events","type":"User","site_admin":false},"body":"The `SMTP_ADDRESS`, `SMTP_DOMAIN`, `SMTP_PASSWORD`, and `SMTP_USERNAME`\r\nvariables are only required when dealing with emails in production, so\r\nreflect that in our `app.json` and the `suspenders:production:email`\r\ngenerator.\r\n\r\nThis introduces our first test for destroying a generator. It also\r\nintroduces some awesome code for un-merging a Hash from another Hash.\r\n\r\nThe Heroku actions create the `app.json`, so make sure they run before\r\nwe modify it. It makes sense to run all production generators after the\r\nHeroku-specific actions, so make that clumping happen.","created_at":"2018-04-13T15:55:50Z","updated_at":"2018-05-25T20:39:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abff687d9dd2c3bfd833ab81310a58b8a7fb0ea4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/908/comments","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/6dbb96d8e6b485e3e6e99a5d280dae189113e0ec","head":{"label":"thoughtbot:production-email-adds-app.json","ref":"production-email-adds-app.json","sha":"6dbb96d8e6b485e3e6e99a5d280dae189113e0ec","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/suspenders/deployments","created_at":"2010-05-14T14:34:46Z","updated_at":"2018-05-25T19:57:23Z","pushed_at":"2018-05-25T20:38:51Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"https://thoughtbot.com/open-source","size":1378,"stargazers_count":3178,"watchers_count":3178,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":483,"open_issues":20,"watchers":3178,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"bb2c57c8790b619616eb73d30607020442b47cf9","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":666566,"name":"suspenders","full_name":"thoughtbot/suspenders","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars3.githubusercontent.com/u/6183?v=4","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/suspenders","description":"A Rails template with our standard defaults, ready to deploy to Heroku.","fork":false,"url":"https://api.github.com/repos/thoughtbot/suspenders","forks_url":"https://api.github.com/repos/thoughtbot/suspenders/forks","keys_url":"https://api.github.com/repos/thoughtbot/suspenders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/suspenders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/suspenders/teams","hooks_url":"https://api.github.com/repos/thoughtbot/suspenders/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/suspenders/events","assignees_url":"https://api.github.com/repos/thoughtbot/suspenders/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/suspenders/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/suspenders/tags","blobs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/suspenders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/suspenders/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/suspenders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/suspenders/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/suspenders/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/suspenders/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/suspenders/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/suspenders/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/suspenders/subscription","commits_url":"https://api.github.com/repos/thoughtbot/suspenders/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/suspenders/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/suspenders/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/suspenders/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/suspenders/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/suspenders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/suspenders/merges","archive_url":"https://api.github.com/repos/thoughtbot/suspenders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/suspenders/downloads","issues_url":"https://api.github.com/repos/thoughtbot/suspenders/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/suspenders/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/suspenders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/suspenders/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/suspenders/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/suspenders/deployments","created_at":"2010-05-14T14:34:46Z","updated_at":"2018-05-25T19:57:23Z","pushed_at":"2018-05-25T20:38:51Z","git_url":"git://github.com/thoughtbot/suspenders.git","ssh_url":"git@github.com:thoughtbot/suspenders.git","clone_url":"https://github.com/thoughtbot/suspenders.git","svn_url":"https://github.com/thoughtbot/suspenders","homepage":"https://thoughtbot.com/open-source","size":1378,"stargazers_count":3178,"watchers_count":3178,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":483,"open_issues":20,"watchers":3178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/908"},"issue":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/908"},"comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/issues/908/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/908/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/suspenders/statuses/6dbb96d8e6b485e3e6e99a5d280dae189113e0ec"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}