{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/165618821","pull_request_review_id":93566609,"id":165618821,"diff_hunk":"@@ -43,6 +43,21 @@ The outline is not a part of the element's dimensions, we have to use a border a\n \tmax-width: 25%;\n }\n \n+.cke_widget_wrapper_easyimage-alignLeft, :not(.cke_widget_wrapper_easyimage):not(.cke_widget_wrapper_easyimage-alignLeft) > .easyimage-alignLeft {\n+\tfloat: left;\n+\tmax-width: 25%;\n+}\n+\n+.cke_widget_wrapper_easyimage-alignCenter, :not(.cke_widget_wrapper_easyimage):not(.cke_widget_wrapper_easyimage-alignCenter) > .easyimage-alignCenter {\n+\tmargin: 0 auto;\n+\tmax-width: 90%;\n+}\n+\n+.cke_widget_wrapper_easyimage-alignRight, :not(.cke_widget_wrapper_easyimage):not(.cke_widget_wrapper_easyimage-alignRight) > .easyimage-alignRight {","path":"plugins/easyimage/styles/easyimage.css","position":14,"original_position":14,"commit_id":"2145411ab077daba8e0c4d3419bc382d9525d907","original_commit_id":"2145411ab077daba8e0c4d3419bc382d9525d907","user":{"login":"mlewand","id":5353898,"avatar_url":"https://avatars0.githubusercontent.com/u/5353898?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewand","html_url":"https://github.com/mlewand","followers_url":"https://api.github.com/users/mlewand/followers","following_url":"https://api.github.com/users/mlewand/following{/other_user}","gists_url":"https://api.github.com/users/mlewand/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewand/subscriptions","organizations_url":"https://api.github.com/users/mlewand/orgs","repos_url":"https://api.github.com/users/mlewand/repos","events_url":"https://api.github.com/users/mlewand/events{/privacy}","received_events_url":"https://api.github.com/users/mlewand/received_events","type":"User","site_admin":false},"body":"I think this particular selector could be joined to the `.cke_widget_wrapper_easyimage-side, :not(.cke_widget_wrapper_easyimage):not(.cke_widget_wrapper_easyimage-side) > .easyimage-side` selector above.","created_at":"2018-02-02T11:11:57Z","updated_at":"2018-02-02T11:35:05Z","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/1518#discussion_r165618821","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/165618821"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/1518#discussion_r165618821"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518","id":165731278,"html_url":"https://github.com/ckeditor/ckeditor-dev/pull/1518","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/1518.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/1518.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1518","number":1518,"state":"open","locked":false,"title":"Styles system for Easy Image","user":{"login":"Comandeer","id":1078728,"avatar_url":"https://avatars3.githubusercontent.com/u/1078728?v=4","gravatar_id":"","url":"https://api.github.com/users/Comandeer","html_url":"https://github.com/Comandeer","followers_url":"https://api.github.com/users/Comandeer/followers","following_url":"https://api.github.com/users/Comandeer/following{/other_user}","gists_url":"https://api.github.com/users/Comandeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Comandeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comandeer/subscriptions","organizations_url":"https://api.github.com/users/Comandeer/orgs","repos_url":"https://api.github.com/users/Comandeer/repos","events_url":"https://api.github.com/users/Comandeer/events{/privacy}","received_events_url":"https://api.github.com/users/Comandeer/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this pull request?\r\n\r\nNew feature\r\n\r\n## Does your PR contain necessary tests?\r\n\r\nAll patches which change the editor code must include tests. You can always read more\r\non [PR testing](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_contributing_code-section-tests),\r\n[how to set the testing environment](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests) and\r\n[how to create tests](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests-section-creating-your-own-test)\r\nin the official CKEditor documentation.\r\n\r\n### This PR contains\r\n\r\n- [x] Unit tests\r\n- [x] Manual tests\r\n\r\n## What changes did you make?\r\n\r\nRewrite of whole commands system for EI, enabling to add custom styles. Additionaly existing commands (`easyimageFull` and `easyimageSide`) were moved into the new style system.\r\n","created_at":"2018-01-29T15:14:06Z","updated_at":"2018-02-02T11:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f598d7757839f348cabf8d365b72d73463cbc6ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1518/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/2145411ab077daba8e0c4d3419bc382d9525d907","head":{"label":"ckeditor:t/932-3393","ref":"t/932-3393","sha":"2145411ab077daba8e0c4d3419bc382d9525d907","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-02-02T10:14:27Z","pushed_at":"2018-02-02T10:59:47Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":57458,"stargazers_count":3841,"watchers_count":3841,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":485,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1722,"open_issues":485,"watchers":3841,"default_branch":"major"}},"base":{"label":"ckeditor:t/932-2961","ref":"t/932-2961","sha":"d8be930fb5c8dd5b97ab403d3cd78927b696fc44","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-02-02T10:14:27Z","pushed_at":"2018-02-02T10:59:47Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":57458,"stargazers_count":3841,"watchers_count":3841,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":485,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1722,"open_issues":485,"watchers":3841,"default_branch":"major"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/1518"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1518"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/2145411ab077daba8e0c4d3419bc382d9525d907"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mlewand"}}