{"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/comments/240837234","pull_request_review_id":183960198,"id":240837234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgzNzIzNA==","diff_hunk":"@@ -269,43 +264,10 @@ def test_invalid_sort_produces_meaningful_errors(self):\n             yield self.test_daemon.jsonrpc_file_list(sort=sort_options)\n \n     def _get_fake_lbry_files(self):\n-        return [self._get_fake_lbry_file() for _ in range(10)]\n+        return list(map(lambda meta: self._get_fake_lbry_file(meta), FAKED_ATTRIBUTES))","path":"tests/unit/lbrynet_daemon/test_Daemon.py","position":null,"original_position":36,"commit_id":"687909f0d284df3f814130d376a34cbe51a95005","original_commit_id":"fc1d5f551d9feef909269728c5bd68cadf4145d4","user":{"login":"osilkin98","id":16809287,"node_id":"MDQ6VXNlcjE2ODA5Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/16809287?v=4","gravatar_id":"","url":"https://api.github.com/users/osilkin98","html_url":"https://github.com/osilkin98","followers_url":"https://api.github.com/users/osilkin98/followers","following_url":"https://api.github.com/users/osilkin98/following{/other_user}","gists_url":"https://api.github.com/users/osilkin98/gists{/gist_id}","starred_url":"https://api.github.com/users/osilkin98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osilkin98/subscriptions","organizations_url":"https://api.github.com/users/osilkin98/orgs","repos_url":"https://api.github.com/users/osilkin98/repos","events_url":"https://api.github.com/users/osilkin98/events{/privacy}","received_events_url":"https://api.github.com/users/osilkin98/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-12-11T23:55:04Z","updated_at":"2018-12-11T23:55:04Z","html_url":"https://github.com/lbryio/lbry/pull/1687#discussion_r240837234","pull_request_url":"https://api.github.com/repos/lbryio/lbry/pulls/1687","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments/240837234"},"html":{"href":"https://github.com/lbryio/lbry/pull/1687#discussion_r240837234"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1687"}},"in_reply_to_id":240801087},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/1687","id":235155048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTU1MDQ4","html_url":"https://github.com/lbryio/lbry/pull/1687","diff_url":"https://github.com/lbryio/lbry/pull/1687.diff","patch_url":"https://github.com/lbryio/lbry/pull/1687.patch","issue_url":"https://api.github.com/repos/lbryio/lbry/issues/1687","number":1687,"state":"open","locked":false,"title":"Removes Faker from Dependencies","user":{"login":"osilkin98","id":16809287,"node_id":"MDQ6VXNlcjE2ODA5Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/16809287?v=4","gravatar_id":"","url":"https://api.github.com/users/osilkin98","html_url":"https://github.com/osilkin98","followers_url":"https://api.github.com/users/osilkin98/followers","following_url":"https://api.github.com/users/osilkin98/following{/other_user}","gists_url":"https://api.github.com/users/osilkin98/gists{/gist_id}","starred_url":"https://api.github.com/users/osilkin98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osilkin98/subscriptions","organizations_url":"https://api.github.com/users/osilkin98/orgs","repos_url":"https://api.github.com/users/osilkin98/repos","events_url":"https://api.github.com/users/osilkin98/events{/privacy}","received_events_url":"https://api.github.com/users/osilkin98/received_events","type":"User","site_admin":false},"body":"## Fixes issue #1667 \r\n\r\nRemoves the `faker` module from the project's dependencies. The module performs only one generation of test data for `unit.tests.lbrynet_daemon.test_Daemon.py` in the class `TestFileListSorting`. The module was responsible for generating attributes for 10 files of which certain information was known ahead of time.\r\n\r\nAs a result, we can drop it from `setup.py`, and remove the `extras_require` section with it. This reduces the installation command from `pip install -e .[test]` to `pip install -e .`.\r\n\r\n\r\n\r\n<!-- Please check all that apply to this PR using \"x\". -->\r\n\r\n- [ ] Bugfix\r\n- [ ] Feature\r\n- [ ] Breaking changes (bugfix or feature that introduces breaking changes)\r\n- [ ] Code style update (formatting)\r\n- [x] Refactoring (no functional changes)\r\n- [x] Documentation changes\r\n- [] Other - Please describe:\r\n\r\n","created_at":"2018-12-01T00:49:25Z","updated_at":"2018-12-11T23:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24995bc71313bb21577d408cdee6977d4fc16b92","assignee":{"login":"eukreign","id":69960,"node_id":"MDQ6VXNlcjY5OTYw","avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false},"assignees":[{"login":"eukreign","id":69960,"node_id":"MDQ6VXNlcjY5OTYw","avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry/pulls/1687/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry/pulls/1687/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry/issues/1687/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/687909f0d284df3f814130d376a34cbe51a95005","head":{"label":"osilkin98:remove-faker","ref":"remove-faker","sha":"687909f0d284df3f814130d376a34cbe51a95005","user":{"login":"osilkin98","id":16809287,"node_id":"MDQ6VXNlcjE2ODA5Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/16809287?v=4","gravatar_id":"","url":"https://api.github.com/users/osilkin98","html_url":"https://github.com/osilkin98","followers_url":"https://api.github.com/users/osilkin98/followers","following_url":"https://api.github.com/users/osilkin98/following{/other_user}","gists_url":"https://api.github.com/users/osilkin98/gists{/gist_id}","starred_url":"https://api.github.com/users/osilkin98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osilkin98/subscriptions","organizations_url":"https://api.github.com/users/osilkin98/orgs","repos_url":"https://api.github.com/users/osilkin98/repos","events_url":"https://api.github.com/users/osilkin98/events{/privacy}","received_events_url":"https://api.github.com/users/osilkin98/received_events","type":"User","site_admin":false},"repo":{"id":149946326,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk5NDYzMjY=","name":"lbry","full_name":"osilkin98/lbry","private":false,"owner":{"login":"osilkin98","id":16809287,"node_id":"MDQ6VXNlcjE2ODA5Mjg3","avatar_url":"https://avatars3.githubusercontent.com/u/16809287?v=4","gravatar_id":"","url":"https://api.github.com/users/osilkin98","html_url":"https://github.com/osilkin98","followers_url":"https://api.github.com/users/osilkin98/followers","following_url":"https://api.github.com/users/osilkin98/following{/other_user}","gists_url":"https://api.github.com/users/osilkin98/gists{/gist_id}","starred_url":"https://api.github.com/users/osilkin98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osilkin98/subscriptions","organizations_url":"https://api.github.com/users/osilkin98/orgs","repos_url":"https://api.github.com/users/osilkin98/repos","events_url":"https://api.github.com/users/osilkin98/events{/privacy}","received_events_url":"https://api.github.com/users/osilkin98/received_events","type":"User","site_admin":false},"html_url":"https://github.com/osilkin98/lbry","description":"A fully decentralized network for distributing data","fork":true,"url":"https://api.github.com/repos/osilkin98/lbry","forks_url":"https://api.github.com/repos/osilkin98/lbry/forks","keys_url":"https://api.github.com/repos/osilkin98/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osilkin98/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osilkin98/lbry/teams","hooks_url":"https://api.github.com/repos/osilkin98/lbry/hooks","issue_events_url":"https://api.github.com/repos/osilkin98/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/osilkin98/lbry/events","assignees_url":"https://api.github.com/repos/osilkin98/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/osilkin98/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/osilkin98/lbry/tags","blobs_url":"https://api.github.com/repos/osilkin98/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osilkin98/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osilkin98/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/osilkin98/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osilkin98/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/osilkin98/lbry/languages","stargazers_url":"https://api.github.com/repos/osilkin98/lbry/stargazers","contributors_url":"https://api.github.com/repos/osilkin98/lbry/contributors","subscribers_url":"https://api.github.com/repos/osilkin98/lbry/subscribers","subscription_url":"https://api.github.com/repos/osilkin98/lbry/subscription","commits_url":"https://api.github.com/repos/osilkin98/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/osilkin98/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/osilkin98/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/osilkin98/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/osilkin98/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/osilkin98/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osilkin98/lbry/merges","archive_url":"https://api.github.com/repos/osilkin98/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osilkin98/lbry/downloads","issues_url":"https://api.github.com/repos/osilkin98/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/osilkin98/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/osilkin98/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/osilkin98/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osilkin98/lbry/labels{/name}","releases_url":"https://api.github.com/repos/osilkin98/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/osilkin98/lbry/deployments","created_at":"2018-09-23T04:00:26Z","updated_at":"2018-12-11T02:28:56Z","pushed_at":"2018-12-11T23:54:42Z","git_url":"git://github.com/osilkin98/lbry.git","ssh_url":"git@github.com:osilkin98/lbry.git","clone_url":"https://github.com/osilkin98/lbry.git","svn_url":"https://github.com/osilkin98/lbry","homepage":"https://lbry.io","size":10436,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"5fad43ff697f62916208d00a7a5306bb345cb3f2","user":{"login":"lbryio","id":13889222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODg5MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":41103286,"node_id":"MDEwOlJlcG9zaXRvcnk0MTEwMzI4Ng==","name":"lbry","full_name":"lbryio/lbry","private":false,"owner":{"login":"lbryio","id":13889222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODg5MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lbryio/lbry","description":"A fully decentralized network for distributing data","fork":false,"url":"https://api.github.com/repos/lbryio/lbry","forks_url":"https://api.github.com/repos/lbryio/lbry/forks","keys_url":"https://api.github.com/repos/lbryio/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry/events","assignees_url":"https://api.github.com/repos/lbryio/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry/merges","archive_url":"https://api.github.com/repos/lbryio/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry/deployments","created_at":"2015-08-20T15:24:10Z","updated_at":"2018-12-11T21:34:41Z","pushed_at":"2018-12-11T23:54:44Z","git_url":"git://github.com/lbryio/lbry.git","ssh_url":"git@github.com:lbryio/lbry.git","clone_url":"https://github.com/lbryio/lbry.git","svn_url":"https://github.com/lbryio/lbry","homepage":"https://lbry.io","size":10396,"stargazers_count":4107,"watchers_count":4107,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":285,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":285,"open_issues":156,"watchers":4107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1687"},"html":{"href":"https://github.com/lbryio/lbry/pull/1687"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1687"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1687/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1687/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1687/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry/statuses/687909f0d284df3f814130d376a34cbe51a95005"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"osilkin98"}}