{"action":"created","issue":{"url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/155","repository_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework","labels_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/155/comments","events_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/155/events","html_url":"https://github.com/Seneral/Node_Editor_Framework/issues/155","id":293776930,"number":155,"title":"Memory issue in recursive search in Node.cs","user":{"login":"Physicalpariah","id":5343720,"avatar_url":"https://avatars0.githubusercontent.com/u/5343720?v=4","gravatar_id":"","url":"https://api.github.com/users/Physicalpariah","html_url":"https://github.com/Physicalpariah","followers_url":"https://api.github.com/users/Physicalpariah/followers","following_url":"https://api.github.com/users/Physicalpariah/following{/other_user}","gists_url":"https://api.github.com/users/Physicalpariah/gists{/gist_id}","starred_url":"https://api.github.com/users/Physicalpariah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Physicalpariah/subscriptions","organizations_url":"https://api.github.com/users/Physicalpariah/orgs","repos_url":"https://api.github.com/users/Physicalpariah/repos","events_url":"https://api.github.com/users/Physicalpariah/events{/privacy}","received_events_url":"https://api.github.com/users/Physicalpariah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-02T05:24:38Z","updated_at":"2018-02-15T15:47:37Z","closed_at":null,"author_association":"NONE","body":"Foreach loops generate the tiniest amount of memory per loop. When a node graph gets large and a node is connected towards the end or at the end of the graph, it generates gigabytes of garbage for the GC to deal with.\r\n\r\nFyi we're using canvases with 500+ nodes.\r\n\r\nReplacing these with for-loops deals with this issue.\r\n\r\nfor reference the following methods are the culprits:\r\n\r\nNode.isChildOf()\r\nNode.isInLoop()\r\nNode.allowsLoopRecursion()\r\n\r\nHope this helps!"},"comment":{"url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/comments/365968007","html_url":"https://github.com/Seneral/Node_Editor_Framework/issues/155#issuecomment-365968007","issue_url":"https://api.github.com/repos/Seneral/Node_Editor_Framework/issues/155","id":365968007,"user":{"login":"Seneral","id":12800840,"avatar_url":"https://avatars3.githubusercontent.com/u/12800840?v=4","gravatar_id":"","url":"https://api.github.com/users/Seneral","html_url":"https://github.com/Seneral","followers_url":"https://api.github.com/users/Seneral/followers","following_url":"https://api.github.com/users/Seneral/following{/other_user}","gists_url":"https://api.github.com/users/Seneral/gists{/gist_id}","starred_url":"https://api.github.com/users/Seneral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seneral/subscriptions","organizations_url":"https://api.github.com/users/Seneral/orgs","repos_url":"https://api.github.com/users/Seneral/repos","events_url":"https://api.github.com/users/Seneral/events{/privacy}","received_events_url":"https://api.github.com/users/Seneral/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T15:47:37Z","updated_at":"2018-02-15T15:47:37Z","author_association":"OWNER","body":"Implemented in branch [Optimizations](https://github.com/Seneral/Node_Editor_Framework/tree/Optimizations).\r\nThere are still some other minor performance improvements possible though...\r\nAnything else you noticed with such a big canvas? Really interested, have not tested myself with it yet. If there's anything in specific that takes forever I'd like to know:)"}}
{"actor":{"display_login":"Seneral"}}