{"action":"created","comment":{"url":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments/234327173","pull_request_review_id":175907174,"id":234327173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMyNzE3Mw==","diff_hunk":"@@ -278,50 +95,6 @@ impl Handler<GetPeers> for Session {\n     }\n }\n \n-////////////////////////////////////////////////////////////////////////////////////////\n-// ACTOR HELPER FUNCTIONS\n-////////////////////////////////////////////////////////////////////////////////////////\n-/// Function called when Version message is received\n-fn handshake_version(session: &mut Session, sender_address: &Address) -> Vec<WitnetMessage> {\n-    let flags = &mut session.handshake_flags;\n-\n-    if flags.version_rx {\n-        debug!(\"Version message already received\");\n-    }\n-\n-    // Placeholder for version fields verification\n-    session.remote_sender_addr = Some(from_address(sender_address));\n-\n-    // Set version_rx flag, indicating reception of a version message from the peer\n-    flags.version_rx = true;\n-\n-    let mut responses: Vec<WitnetMessage> = vec![];\n-    if !flags.verack_tx {\n-        flags.verack_tx = true;\n-        let verack = WitnetMessage::build_verack();\n-        responses.push(verack);\n-    }\n-    if !flags.version_tx {\n-        flags.version_tx = true;\n-        let version = WitnetMessage::build_version(session.server_addr, session.remote_addr, 0);\n-        responses.push(version);\n-    }\n-\n-    responses\n-}\n-\n-/// Function called when Verack message is received\n-fn handshake_verack(session: &mut Session) {\n-    let flags = &mut session.handshake_flags;\n-\n-    if flags.verack_rx {\n-        debug!(\"Verack message already received\");\n-    }\n-\n-    // Set verack_rx flag\n-    flags.verack_rx = true;\n-}\n-\n /// Function to try to consolidate session if handshake conditions are met\n fn try_consolidate_session(session: &mut Session, ctx: &mut Context<Session>) {\n     // Check if handshake flags are all set to true","path":"core/src/actors/session/handlers.rs","position":287,"original_position":287,"commit_id":"f52d7b3a172b2e1b20d047cde12169b555b83095","original_commit_id":"f52d7b3a172b2e1b20d047cde12169b555b83095","user":{"login":"jrmoreau","id":1614127,"node_id":"MDQ6VXNlcjE2MTQxMjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1614127?v=4","gravatar_id":"","url":"https://api.github.com/users/jrmoreau","html_url":"https://github.com/jrmoreau","followers_url":"https://api.github.com/users/jrmoreau/followers","following_url":"https://api.github.com/users/jrmoreau/following{/other_user}","gists_url":"https://api.github.com/users/jrmoreau/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmoreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmoreau/subscriptions","organizations_url":"https://api.github.com/users/jrmoreau/orgs","repos_url":"https://api.github.com/users/jrmoreau/repos","events_url":"https://api.github.com/users/jrmoreau/events{/privacy}","received_events_url":"https://api.github.com/users/jrmoreau/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    // Check if HandshakeFlags are all set to true\r\n```","created_at":"2018-11-16T19:46:06Z","updated_at":"2018-11-16T19:57:05Z","html_url":"https://github.com/witnet/witnet-rust/pull/147#discussion_r234327173","pull_request_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/147","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments/234327173"},"html":{"href":"https://github.com/witnet/witnet-rust/pull/147#discussion_r234327173"},"pull_request":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/witnet/witnet-rust/pulls/147","id":231509353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTA5MzUz","html_url":"https://github.com/witnet/witnet-rust/pull/147","diff_url":"https://github.com/witnet/witnet-rust/pull/147.diff","patch_url":"https://github.com/witnet/witnet-rust/pull/147.patch","issue_url":"https://api.github.com/repos/witnet/witnet-rust/issues/147","number":147,"state":"open","locked":false,"title":"Refactor(core): split actors in different files","user":{"login":"Tommytrg","id":24905681,"node_id":"MDQ6VXNlcjI0OTA1Njgx","avatar_url":"https://avatars0.githubusercontent.com/u/24905681?v=4","gravatar_id":"","url":"https://api.github.com/users/Tommytrg","html_url":"https://github.com/Tommytrg","followers_url":"https://api.github.com/users/Tommytrg/followers","following_url":"https://api.github.com/users/Tommytrg/following{/other_user}","gists_url":"https://api.github.com/users/Tommytrg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tommytrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tommytrg/subscriptions","organizations_url":"https://api.github.com/users/Tommytrg/orgs","repos_url":"https://api.github.com/users/Tommytrg/repos","events_url":"https://api.github.com/users/Tommytrg/events{/privacy}","received_events_url":"https://api.github.com/users/Tommytrg/received_events","type":"User","site_admin":false},"body":"Close #119 ","created_at":"2018-11-16T12:06:51Z","updated_at":"2018-11-16T19:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bd021d9eb744bd705c2045a5496233713358e3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/147/commits","review_comments_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/147/comments","review_comment_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/issues/147/comments","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/f52d7b3a172b2e1b20d047cde12169b555b83095","head":{"label":"Tommytrg:refactor/119/split-actors","ref":"refactor/119/split-actors","sha":"f52d7b3a172b2e1b20d047cde12169b555b83095","user":{"login":"Tommytrg","id":24905681,"node_id":"MDQ6VXNlcjI0OTA1Njgx","avatar_url":"https://avatars0.githubusercontent.com/u/24905681?v=4","gravatar_id":"","url":"https://api.github.com/users/Tommytrg","html_url":"https://github.com/Tommytrg","followers_url":"https://api.github.com/users/Tommytrg/followers","following_url":"https://api.github.com/users/Tommytrg/following{/other_user}","gists_url":"https://api.github.com/users/Tommytrg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tommytrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tommytrg/subscriptions","organizations_url":"https://api.github.com/users/Tommytrg/orgs","repos_url":"https://api.github.com/users/Tommytrg/repos","events_url":"https://api.github.com/users/Tommytrg/events{/privacy}","received_events_url":"https://api.github.com/users/Tommytrg/received_events","type":"User","site_admin":false},"repo":{"id":149139133,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMzkxMzM=","name":"witnet-rust","full_name":"Tommytrg/witnet-rust","private":false,"owner":{"login":"Tommytrg","id":24905681,"node_id":"MDQ6VXNlcjI0OTA1Njgx","avatar_url":"https://avatars0.githubusercontent.com/u/24905681?v=4","gravatar_id":"","url":"https://api.github.com/users/Tommytrg","html_url":"https://github.com/Tommytrg","followers_url":"https://api.github.com/users/Tommytrg/followers","following_url":"https://api.github.com/users/Tommytrg/following{/other_user}","gists_url":"https://api.github.com/users/Tommytrg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tommytrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tommytrg/subscriptions","organizations_url":"https://api.github.com/users/Tommytrg/orgs","repos_url":"https://api.github.com/users/Tommytrg/repos","events_url":"https://api.github.com/users/Tommytrg/events{/privacy}","received_events_url":"https://api.github.com/users/Tommytrg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tommytrg/witnet-rust","description":"An in-progress open source implementation of the Witnet protocol written in Rust.","fork":true,"url":"https://api.github.com/repos/Tommytrg/witnet-rust","forks_url":"https://api.github.com/repos/Tommytrg/witnet-rust/forks","keys_url":"https://api.github.com/repos/Tommytrg/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tommytrg/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tommytrg/witnet-rust/teams","hooks_url":"https://api.github.com/repos/Tommytrg/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/Tommytrg/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/Tommytrg/witnet-rust/events","assignees_url":"https://api.github.com/repos/Tommytrg/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/Tommytrg/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/Tommytrg/witnet-rust/tags","blobs_url":"https://api.github.com/repos/Tommytrg/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tommytrg/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tommytrg/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tommytrg/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tommytrg/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Tommytrg/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/Tommytrg/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/Tommytrg/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/Tommytrg/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/Tommytrg/witnet-rust/subscription","commits_url":"https://api.github.com/repos/Tommytrg/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tommytrg/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tommytrg/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tommytrg/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tommytrg/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/Tommytrg/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tommytrg/witnet-rust/merges","archive_url":"https://api.github.com/repos/Tommytrg/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tommytrg/witnet-rust/downloads","issues_url":"https://api.github.com/repos/Tommytrg/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/Tommytrg/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Tommytrg/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Tommytrg/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tommytrg/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/Tommytrg/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/Tommytrg/witnet-rust/deployments","created_at":"2018-09-17T14:35:52Z","updated_at":"2018-10-03T13:11:25Z","pushed_at":"2018-11-16T12:05:30Z","git_url":"git://github.com/Tommytrg/witnet-rust.git","ssh_url":"git@github.com:Tommytrg/witnet-rust.git","clone_url":"https://github.com/Tommytrg/witnet-rust.git","svn_url":"https://github.com/Tommytrg/witnet-rust","homepage":"https://witnet.io","size":938,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"witnet:master","ref":"master","sha":"aaeb6ca9e2cd220c621a78f3795bfbe4e61ecad1","user":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"repo":{"id":120209021,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyMDkwMjE=","name":"witnet-rust","full_name":"witnet/witnet-rust","private":false,"owner":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/witnet/witnet-rust","description":"An in-progress open source implementation of the Witnet protocol written in Rust.","fork":false,"url":"https://api.github.com/repos/witnet/witnet-rust","forks_url":"https://api.github.com/repos/witnet/witnet-rust/forks","keys_url":"https://api.github.com/repos/witnet/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witnet/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witnet/witnet-rust/teams","hooks_url":"https://api.github.com/repos/witnet/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/witnet/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/witnet/witnet-rust/events","assignees_url":"https://api.github.com/repos/witnet/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/witnet/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/witnet/witnet-rust/tags","blobs_url":"https://api.github.com/repos/witnet/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witnet/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witnet/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/witnet/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/witnet/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/witnet/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/witnet/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/witnet/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/witnet/witnet-rust/subscription","commits_url":"https://api.github.com/repos/witnet/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/witnet/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/witnet/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/witnet/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/witnet/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witnet/witnet-rust/merges","archive_url":"https://api.github.com/repos/witnet/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witnet/witnet-rust/downloads","issues_url":"https://api.github.com/repos/witnet/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/witnet/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/witnet/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/witnet/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witnet/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/witnet/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/witnet/witnet-rust/deployments","created_at":"2018-02-04T17:59:46Z","updated_at":"2018-11-16T10:33:19Z","pushed_at":"2018-11-16T12:28:16Z","git_url":"git://github.com/witnet/witnet-rust.git","ssh_url":"git@github.com:witnet/witnet-rust.git","clone_url":"https://github.com/witnet/witnet-rust.git","svn_url":"https://github.com/witnet/witnet-rust","homepage":"https://docs.witnet.io","size":1781,"stargazers_count":29,"watchers_count":29,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13,"open_issues":42,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/147"},"html":{"href":"https://github.com/witnet/witnet-rust/pull/147"},"issue":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/147"},"comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/witnet/witnet-rust/statuses/f52d7b3a172b2e1b20d047cde12169b555b83095"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrmoreau"}}