{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/227079459","pull_request_review_id":167039752,"id":227079459,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA3OTQ1OQ==","diff_hunk":"@@ -581,7 +581,8 @@ void main() {\n       )\n     );\n \n-    // Initial WidgetTester locale is new Locale('', '')\n+    // Initial WidgetTester locale is null due to no platform intitializing it.\n+    await tester.binding.setLocale('', '');","path":"packages/flutter_localizations/test/widgets_test.dart","position":15,"original_position":15,"commit_id":"74d4b1a74a8eb7c695db223929c71ae107794eb3","original_commit_id":"74d4b1a74a8eb7c695db223929c71ae107794eb3","user":{"login":"GaryQian","id":1887398,"node_id":"MDQ6VXNlcjE4ODczOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1887398?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryQian","html_url":"https://github.com/GaryQian","followers_url":"https://api.github.com/users/GaryQian/followers","following_url":"https://api.github.com/users/GaryQian/following{/other_user}","gists_url":"https://api.github.com/users/GaryQian/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryQian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryQian/subscriptions","organizations_url":"https://api.github.com/users/GaryQian/orgs","repos_url":"https://api.github.com/users/GaryQian/repos","events_url":"https://api.github.com/users/GaryQian/events{/privacy}","received_events_url":"https://api.github.com/users/GaryQian/received_events","type":"User","site_admin":false},"body":"There should be no more Locale(\"\", \"\") anymore, at least not produced by flutter.","created_at":"2018-10-22T18:15:20Z","updated_at":"2018-10-22T18:15:20Z","html_url":"https://github.com/flutter/flutter/pull/23375#discussion_r227079459","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/23375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/227079459"},"html":{"href":"https://github.com/flutter/flutter/pull/23375#discussion_r227079459"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23375"}},"in_reply_to_id":227076707},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/23375","id":224762344,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzYyMzQ0","html_url":"https://github.com/flutter/flutter/pull/23375","diff_url":"https://github.com/flutter/flutter/pull/23375.diff","patch_url":"https://github.com/flutter/flutter/pull/23375.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/23375","number":23375,"state":"open","locked":false,"title":"Support null locale before locale initialization.","user":{"login":"GaryQian","id":1887398,"node_id":"MDQ6VXNlcjE4ODczOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1887398?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryQian","html_url":"https://github.com/GaryQian","followers_url":"https://api.github.com/users/GaryQian/followers","following_url":"https://api.github.com/users/GaryQian/following{/other_user}","gists_url":"https://api.github.com/users/GaryQian/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryQian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryQian/subscriptions","organizations_url":"https://api.github.com/users/GaryQian/orgs","repos_url":"https://api.github.com/users/GaryQian/repos","events_url":"https://api.github.com/users/GaryQian/events{/privacy}","received_events_url":"https://api.github.com/users/GaryQian/received_events","type":"User","site_admin":false},"body":"The engine will roll a change that makes uninitialized locales null very soon, but this still works without the change.","created_at":"2018-10-22T18:01:40Z","updated_at":"2018-10-22T18:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dadac795ef57ecf35788a3abbf646c61e708501","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yjbanov","id":211513,"node_id":"MDQ6VXNlcjIxMTUxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/23375/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/23375/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/23375/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/74d4b1a74a8eb7c695db223929c71ae107794eb3","head":{"label":"GaryQian:locale","ref":"locale","sha":"74d4b1a74a8eb7c695db223929c71ae107794eb3","user":{"login":"GaryQian","id":1887398,"node_id":"MDQ6VXNlcjE4ODczOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1887398?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryQian","html_url":"https://github.com/GaryQian","followers_url":"https://api.github.com/users/GaryQian/followers","following_url":"https://api.github.com/users/GaryQian/following{/other_user}","gists_url":"https://api.github.com/users/GaryQian/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryQian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryQian/subscriptions","organizations_url":"https://api.github.com/users/GaryQian/orgs","repos_url":"https://api.github.com/users/GaryQian/repos","events_url":"https://api.github.com/users/GaryQian/events{/privacy}","received_events_url":"https://api.github.com/users/GaryQian/received_events","type":"User","site_admin":false},"repo":{"id":144919772,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5MTk3NzI=","name":"flutter","full_name":"GaryQian/flutter","private":false,"owner":{"login":"GaryQian","id":1887398,"node_id":"MDQ6VXNlcjE4ODczOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1887398?v=4","gravatar_id":"","url":"https://api.github.com/users/GaryQian","html_url":"https://github.com/GaryQian","followers_url":"https://api.github.com/users/GaryQian/followers","following_url":"https://api.github.com/users/GaryQian/following{/other_user}","gists_url":"https://api.github.com/users/GaryQian/gists{/gist_id}","starred_url":"https://api.github.com/users/GaryQian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaryQian/subscriptions","organizations_url":"https://api.github.com/users/GaryQian/orgs","repos_url":"https://api.github.com/users/GaryQian/repos","events_url":"https://api.github.com/users/GaryQian/events{/privacy}","received_events_url":"https://api.github.com/users/GaryQian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GaryQian/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/GaryQian/flutter","forks_url":"https://api.github.com/repos/GaryQian/flutter/forks","keys_url":"https://api.github.com/repos/GaryQian/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GaryQian/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GaryQian/flutter/teams","hooks_url":"https://api.github.com/repos/GaryQian/flutter/hooks","issue_events_url":"https://api.github.com/repos/GaryQian/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/GaryQian/flutter/events","assignees_url":"https://api.github.com/repos/GaryQian/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/GaryQian/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/GaryQian/flutter/tags","blobs_url":"https://api.github.com/repos/GaryQian/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GaryQian/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GaryQian/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/GaryQian/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GaryQian/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/GaryQian/flutter/languages","stargazers_url":"https://api.github.com/repos/GaryQian/flutter/stargazers","contributors_url":"https://api.github.com/repos/GaryQian/flutter/contributors","subscribers_url":"https://api.github.com/repos/GaryQian/flutter/subscribers","subscription_url":"https://api.github.com/repos/GaryQian/flutter/subscription","commits_url":"https://api.github.com/repos/GaryQian/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/GaryQian/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/GaryQian/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/GaryQian/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/GaryQian/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/GaryQian/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GaryQian/flutter/merges","archive_url":"https://api.github.com/repos/GaryQian/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GaryQian/flutter/downloads","issues_url":"https://api.github.com/repos/GaryQian/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/GaryQian/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/GaryQian/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/GaryQian/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GaryQian/flutter/labels{/name}","releases_url":"https://api.github.com/repos/GaryQian/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/GaryQian/flutter/deployments","created_at":"2018-08-16T01:15:22Z","updated_at":"2018-10-15T21:08:22Z","pushed_at":"2018-10-22T17:56:03Z","git_url":"git://github.com/GaryQian/flutter.git","ssh_url":"git@github.com:GaryQian/flutter.git","clone_url":"https://github.com/GaryQian/flutter.git","svn_url":"https://github.com/GaryQian/flutter","homepage":"https://flutter.io","size":48997,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"0edbe726a17c33581ec03573c123db4e4fbd6f4a","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-10-22T17:29:14Z","pushed_at":"2018-10-22T18:01:41Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":48988,"stargazers_count":39709,"watchers_count":39709,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3877,"mirror_url":null,"archived":false,"open_issues_count":4170,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3877,"open_issues":4170,"watchers":39709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23375"},"html":{"href":"https://github.com/flutter/flutter/pull/23375"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/23375"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/23375/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23375/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/23375/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/74d4b1a74a8eb7c695db223929c71ae107794eb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GaryQian"}}