{"action":"created","issue":{"url":"https://api.github.com/repos/angular/dgeni-packages/issues/262","repository_url":"https://api.github.com/repos/angular/dgeni-packages","labels_url":"https://api.github.com/repos/angular/dgeni-packages/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/angular/dgeni-packages/issues/262/comments","events_url":"https://api.github.com/repos/angular/dgeni-packages/issues/262/events","html_url":"https://github.com/angular/dgeni-packages/pull/262","id":298702062,"number":262,"title":"fix(api-doc-types): ParameterDoc incorrectly extends ExportDoc","user":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"labels":[{"id":80108360,"url":"https://api.github.com/repos/angular/dgeni-packages/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-20T18:34:05Z","updated_at":"2018-02-20T22:04:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/angular/dgeni-packages/pulls/262","html_url":"https://github.com/angular/dgeni-packages/pull/262","diff_url":"https://github.com/angular/dgeni-packages/pull/262.diff","patch_url":"https://github.com/angular/dgeni-packages/pull/262.patch"},"body":"* Fixes that the `ParameterDoc` class incorrectly extends the `ExportDoc` class. This is a wrong assumption, because parameters are never individually exported. Meaning that a simple `instanceof ExportDoc` check will not work properly.\r\n* Fixes that the text output of the TypeScript package prints with different line-feed kinds. Now it always uses `LF`, which is also being used in the tests (_fixes tests on Windows_, _makes docs output git-diffable within Git_).\r\n* Automatically sorts imports and removes unused imports. Imports that are needed to avoid TS errors (`Return type of public method from exported class has or is using name `) are now used explicitly (code health improvement)\r\n\r\nBREAKING CHANGE: Interface `ApiDoc` is now called `BaseApiDoc`, and there is a new class called `ApiDoc`, which includes the general logic for parsing a TypeScript declaration.\r\n\r\nFixes #261"},"comment":{"url":"https://api.github.com/repos/angular/dgeni-packages/issues/comments/367136338","html_url":"https://github.com/angular/dgeni-packages/pull/262#issuecomment-367136338","issue_url":"https://api.github.com/repos/angular/dgeni-packages/issues/262","id":367136338,"user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars0.githubusercontent.com/u/15655?v=4","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T22:04:18Z","updated_at":"2018-02-20T22:04:18Z","author_association":"MEMBER","body":"Oops, I meant that the interface should stay the same and we should insert a new class `BaseApiDoc` between the interface and the `ExportDoc`. This would also avoid the BC."}}
{"actor":{"display_login":"petebacondarwin"}}