{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/clarity/pulls/comments/176205412","pull_request_review_id":105868356,"id":176205412,"diff_hunk":"@@ -251,16 +264,19 @@ export class Selection {\n          * If at least one item isn't selected, we select every currently displayed item.\n          */\n         if (this.isAllSelected()) {\n-            this.current = this.current.filter(item => {\n-                return this._items.displayed.indexOf(item) < 0;\n+            this._items.displayed.forEach((item, displayIndex) => {\n+                const currentIndex = this.current.indexOf(this._items.trackBy(displayIndex, item));","path":"src/clr-angular/data/datagrid/providers/selection.ts","position":null,"original_position":61,"commit_id":"efa109507ab17b67afe0c915240abefa8ca71135","original_commit_id":"393dc30c7a5737b550c5323c9cf0fc3f554e5373","user":{"login":"mviger","id":13404947,"avatar_url":"https://avatars3.githubusercontent.com/u/13404947?v=4","gravatar_id":"","url":"https://api.github.com/users/mviger","html_url":"https://github.com/mviger","followers_url":"https://api.github.com/users/mviger/followers","following_url":"https://api.github.com/users/mviger/following{/other_user}","gists_url":"https://api.github.com/users/mviger/gists{/gist_id}","starred_url":"https://api.github.com/users/mviger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mviger/subscriptions","organizations_url":"https://api.github.com/users/mviger/orgs","repos_url":"https://api.github.com/users/mviger/repos","events_url":"https://api.github.com/users/mviger/events{/privacy}","received_events_url":"https://api.github.com/users/mviger/received_events","type":"User","site_admin":false},"body":"You are correct.  I've updated the commit accordingly. \r\n\r\nSorry, that was left over from an attempt at getting the index from `this.selected` instead of `this.current`.  That failed one of the other units tests. I realized that when `set current` is called, `selected` does not get updated at that time.\r\n\r\nThat might expose a separate issue, but outside of the current scope I believe.","created_at":"2018-03-21T19:10:00Z","updated_at":"2018-03-21T19:10:01Z","html_url":"https://github.com/vmware/clarity/pull/2102#discussion_r176205412","pull_request_url":"https://api.github.com/repos/vmware/clarity/pulls/2102","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments/176205412"},"html":{"href":"https://github.com/vmware/clarity/pull/2102#discussion_r176205412"},"pull_request":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2102"}},"in_reply_to_id":176192072},"pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/2102","id":176521857,"html_url":"https://github.com/vmware/clarity/pull/2102","diff_url":"https://github.com/vmware/clarity/pull/2102.diff","patch_url":"https://github.com/vmware/clarity/pull/2102.patch","issue_url":"https://api.github.com/repos/vmware/clarity/issues/2102","number":2102,"state":"open","locked":false,"title":"[NG] Fix toggleAll selection tracking","user":{"login":"mviger","id":13404947,"avatar_url":"https://avatars3.githubusercontent.com/u/13404947?v=4","gravatar_id":"","url":"https://api.github.com/users/mviger","html_url":"https://github.com/mviger","followers_url":"https://api.github.com/users/mviger/followers","following_url":"https://api.github.com/users/mviger/following{/other_user}","gists_url":"https://api.github.com/users/mviger/gists{/gist_id}","starred_url":"https://api.github.com/users/mviger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mviger/subscriptions","organizations_url":"https://api.github.com/users/mviger/orgs","repos_url":"https://api.github.com/users/mviger/repos","events_url":"https://api.github.com/users/mviger/events{/privacy}","received_events_url":"https://api.github.com/users/mviger/received_events","type":"User","site_admin":false},"body":"Moved select and deselect into private methods to keep current and\r\nselection in sync.\r\ntoggleAll calls select and deselect when adding or removing items.\r\n\r\ncloses #2083\r\n\r\nSigned-off-by: Marc Viger <mviger@gmail.com>","created_at":"2018-03-21T15:51:44Z","updated_at":"2018-03-21T19:10:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cc4f403dac65c87387f132b7ff481645c3fca19","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adityarb88","id":1426805,"avatar_url":"https://avatars3.githubusercontent.com/u/1426805?v=4","gravatar_id":"","url":"https://api.github.com/users/adityarb88","html_url":"https://github.com/adityarb88","followers_url":"https://api.github.com/users/adityarb88/followers","following_url":"https://api.github.com/users/adityarb88/following{/other_user}","gists_url":"https://api.github.com/users/adityarb88/gists{/gist_id}","starred_url":"https://api.github.com/users/adityarb88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityarb88/subscriptions","organizations_url":"https://api.github.com/users/adityarb88/orgs","repos_url":"https://api.github.com/users/adityarb88/repos","events_url":"https://api.github.com/users/adityarb88/events{/privacy}","received_events_url":"https://api.github.com/users/adityarb88/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/clarity/pulls/2102/commits","review_comments_url":"https://api.github.com/repos/vmware/clarity/pulls/2102/comments","review_comment_url":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/2102/comments","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/efa109507ab17b67afe0c915240abefa8ca71135","head":{"label":"mviger:datagridHeaderMultiselect","ref":"datagridHeaderMultiselect","sha":"efa109507ab17b67afe0c915240abefa8ca71135","user":{"login":"mviger","id":13404947,"avatar_url":"https://avatars3.githubusercontent.com/u/13404947?v=4","gravatar_id":"","url":"https://api.github.com/users/mviger","html_url":"https://github.com/mviger","followers_url":"https://api.github.com/users/mviger/followers","following_url":"https://api.github.com/users/mviger/following{/other_user}","gists_url":"https://api.github.com/users/mviger/gists{/gist_id}","starred_url":"https://api.github.com/users/mviger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mviger/subscriptions","organizations_url":"https://api.github.com/users/mviger/orgs","repos_url":"https://api.github.com/users/mviger/repos","events_url":"https://api.github.com/users/mviger/events{/privacy}","received_events_url":"https://api.github.com/users/mviger/received_events","type":"User","site_admin":false},"repo":{"id":125780780,"name":"clarity","full_name":"mviger/clarity","owner":{"login":"mviger","id":13404947,"avatar_url":"https://avatars3.githubusercontent.com/u/13404947?v=4","gravatar_id":"","url":"https://api.github.com/users/mviger","html_url":"https://github.com/mviger","followers_url":"https://api.github.com/users/mviger/followers","following_url":"https://api.github.com/users/mviger/following{/other_user}","gists_url":"https://api.github.com/users/mviger/gists{/gist_id}","starred_url":"https://api.github.com/users/mviger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mviger/subscriptions","organizations_url":"https://api.github.com/users/mviger/orgs","repos_url":"https://api.github.com/users/mviger/repos","events_url":"https://api.github.com/users/mviger/events{/privacy}","received_events_url":"https://api.github.com/users/mviger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mviger/clarity","description":"UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences","fork":true,"url":"https://api.github.com/repos/mviger/clarity","forks_url":"https://api.github.com/repos/mviger/clarity/forks","keys_url":"https://api.github.com/repos/mviger/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mviger/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mviger/clarity/teams","hooks_url":"https://api.github.com/repos/mviger/clarity/hooks","issue_events_url":"https://api.github.com/repos/mviger/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/mviger/clarity/events","assignees_url":"https://api.github.com/repos/mviger/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/mviger/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/mviger/clarity/tags","blobs_url":"https://api.github.com/repos/mviger/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mviger/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mviger/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/mviger/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mviger/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/mviger/clarity/languages","stargazers_url":"https://api.github.com/repos/mviger/clarity/stargazers","contributors_url":"https://api.github.com/repos/mviger/clarity/contributors","subscribers_url":"https://api.github.com/repos/mviger/clarity/subscribers","subscription_url":"https://api.github.com/repos/mviger/clarity/subscription","commits_url":"https://api.github.com/repos/mviger/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/mviger/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/mviger/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/mviger/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/mviger/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/mviger/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mviger/clarity/merges","archive_url":"https://api.github.com/repos/mviger/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mviger/clarity/downloads","issues_url":"https://api.github.com/repos/mviger/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/mviger/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/mviger/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/mviger/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mviger/clarity/labels{/name}","releases_url":"https://api.github.com/repos/mviger/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/mviger/clarity/deployments","created_at":"2018-03-19T00:28:23Z","updated_at":"2018-03-19T00:28:28Z","pushed_at":"2018-03-21T18:55:10Z","git_url":"git://github.com/mviger/clarity.git","ssh_url":"git@github.com:mviger/clarity.git","clone_url":"https://github.com/mviger/clarity.git","svn_url":"https://github.com/mviger/clarity","homepage":"http://clarity.design","size":220504,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"bfa05302a21d2444c806f4e902c10cdfd10d5aa1","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":69590701,"name":"clarity","full_name":"vmware/clarity","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/clarity","description":"UX guidelines, HTML/CSS framework, and Angular components working together to craft exceptional experiences","fork":false,"url":"https://api.github.com/repos/vmware/clarity","forks_url":"https://api.github.com/repos/vmware/clarity/forks","keys_url":"https://api.github.com/repos/vmware/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/clarity/teams","hooks_url":"https://api.github.com/repos/vmware/clarity/hooks","issue_events_url":"https://api.github.com/repos/vmware/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/clarity/events","assignees_url":"https://api.github.com/repos/vmware/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/clarity/tags","blobs_url":"https://api.github.com/repos/vmware/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/clarity/languages","stargazers_url":"https://api.github.com/repos/vmware/clarity/stargazers","contributors_url":"https://api.github.com/repos/vmware/clarity/contributors","subscribers_url":"https://api.github.com/repos/vmware/clarity/subscribers","subscription_url":"https://api.github.com/repos/vmware/clarity/subscription","commits_url":"https://api.github.com/repos/vmware/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/clarity/merges","archive_url":"https://api.github.com/repos/vmware/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/clarity/downloads","issues_url":"https://api.github.com/repos/vmware/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/clarity/labels{/name}","releases_url":"https://api.github.com/repos/vmware/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/clarity/deployments","created_at":"2016-09-29T17:24:17Z","updated_at":"2018-03-21T18:43:35Z","pushed_at":"2018-03-21T18:55:12Z","git_url":"git://github.com/vmware/clarity.git","ssh_url":"git@github.com:vmware/clarity.git","clone_url":"https://github.com/vmware/clarity.git","svn_url":"https://github.com/vmware/clarity","homepage":"http://clarity.design","size":220503,"stargazers_count":3159,"watchers_count":3159,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":288,"mirror_url":null,"archived":false,"open_issues_count":272,"license":null,"forks":288,"open_issues":272,"watchers":3159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2102"},"html":{"href":"https://github.com/vmware/clarity/pull/2102"},"issue":{"href":"https://api.github.com/repos/vmware/clarity/issues/2102"},"comments":{"href":"https://api.github.com/repos/vmware/clarity/issues/2102/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2102/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/clarity/pulls/2102/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/clarity/statuses/efa109507ab17b67afe0c915240abefa8ca71135"}},"author_association":"NONE"}}
{"actor":{"display_login":"mviger"}}