{"action":"created","issue":{"url":"https://api.github.com/repos/ArkEcosystem/core/issues/1113","repository_url":"https://api.github.com/repos/ArkEcosystem/core","labels_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1113/labels{/name}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1113/comments","events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1113/events","html_url":"https://github.com/ArkEcosystem/core/pull/1113","id":369901238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzE0OTcz","number":1113,"title":"fix: delete blocks on commit","user":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-14T13:14:54Z","updated_at":"2018-10-14T13:19:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1113","html_url":"https://github.com/ArkEcosystem/core/pull/1113","diff_url":"https://github.com/ArkEcosystem/core/pull/1113.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/1113.patch"},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\nThe same issue as in #1054, but for deleting blocks. Additionally, I refactored a bit, since `saveBlockCommit` and `deleteBlockCommit`did exactly the same and worked with the same array. No point in having two  separate functions.\r\n\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [X] Bugfix (non-breaking change which fixes an issue)\r\n- [X] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n- [X] Lint and unit tests pass locally with my changes\r\n<!--\r\n"},"comment":{"url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments/429625875","html_url":"https://github.com/ArkEcosystem/core/pull/1113#issuecomment-429625875","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1113","id":429625875,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTYyNTg3NQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T13:19:22Z","updated_at":"2018-10-14T13:19:22Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=h1) Report\n> Merging [#1113](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=desc) into [develop](https://codecov.io/gh/ArkEcosystem/core/commit/f2fc0538a78e27f0f4e33da341bd488ab2b4164a?src=pr&el=desc) will **increase** coverage by `0.23%`.\n> The diff coverage is `67.74%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ArkEcosystem/core/pull/1113/graphs/tree.svg?width=650&token=GBkLFnDC5w&height=150&src=pr)](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##           develop    #1113      +/-   ##\n===========================================\n+ Coverage    77.74%   77.97%   +0.23%     \n===========================================\n  Files          427      427              \n  Lines         7031     7019      -12     \n  Branches       907      905       -2     \n===========================================\n+ Hits          5466     5473       +7     \n+ Misses        1390     1374      -16     \n+ Partials       175      172       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [packages/core-blockchain/lib/state-machine.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1ibG9ja2NoYWluL2xpYi9zdGF0ZS1tYWNoaW5lLmpz) | `49.68% <0%> (ø)` | :arrow_up: |\n| [packages/core-database/lib/interface.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1kYXRhYmFzZS9saWIvaW50ZXJmYWNlLmpz) | `75.75% <66.66%> (+0.56%)` | :arrow_up: |\n| [packages/core-database-postgres/lib/connection.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1kYXRhYmFzZS1wb3N0Z3Jlcy9saWIvY29ubmVjdGlvbi5qcw==) | `76.19% <70%> (+2.43%)` | :arrow_up: |\n| [packages/core-blockchain/lib/blockchain.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1ibG9ja2NoYWluL2xpYi9ibG9ja2NoYWluLmpz) | `79.68% <83.33%> (ø)` | :arrow_up: |\n| [packages/core-p2p/lib/utils/check-ntp.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1wMnAvbGliL3V0aWxzL2NoZWNrLW50cC5qcw==) | `100% <0%> (+7.14%)` | :arrow_up: |\n| [packages/core-forger/lib/manager.js](https://codecov.io/gh/ArkEcosystem/core/pull/1113/diff?src=pr&el=tree#diff-cGFja2FnZXMvY29yZS1mb3JnZXIvbGliL21hbmFnZXIuanM=) | `81.52% <0%> (+9.78%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=footer). Last update [f2fc053...a26d2ed](https://codecov.io/gh/ArkEcosystem/core/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}