{"action":"created","issue":{"url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/2","repository_url":"https://api.github.com/repos/bigcommerce/puppet-hubot","labels_url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/2/comments","events_url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/2/events","html_url":"https://github.com/bigcommerce/puppet-hubot/pull/2","id":304032146,"number":2,"title":"SRE-2608: fixing puppet run for hubot","user":{"login":"CYPI","id":8475846,"avatar_url":"https://avatars0.githubusercontent.com/u/8475846?v=4","gravatar_id":"","url":"https://api.github.com/users/CYPI","html_url":"https://github.com/CYPI","followers_url":"https://api.github.com/users/CYPI/followers","following_url":"https://api.github.com/users/CYPI/following{/other_user}","gists_url":"https://api.github.com/users/CYPI/gists{/gist_id}","starred_url":"https://api.github.com/users/CYPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CYPI/subscriptions","organizations_url":"https://api.github.com/users/CYPI/orgs","repos_url":"https://api.github.com/users/CYPI/repos","events_url":"https://api.github.com/users/CYPI/events{/privacy}","received_events_url":"https://api.github.com/users/CYPI/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-10T02:09:01Z","updated_at":"2018-03-12T18:48:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bigcommerce/puppet-hubot/pulls/2","html_url":"https://github.com/bigcommerce/puppet-hubot/pull/2","diff_url":"https://github.com/bigcommerce/puppet-hubot/pull/2.diff","patch_url":"https://github.com/bigcommerce/puppet-hubot/pull/2.patch"},"body":"https://github.com/frozenfoxx/puppet-hubot/pull/7\r\n\r\nWhat does this do?\r\n\r\nFix hubot. For \"reasons\", package.json is getting updated every puppet run which cause hubot to reinstall dependencies. I created a fix package.json file instead of a template which is fixing our pb.\r\n\r\nWhy does it do it?\r\nSo puppet doesn't re-install dependencies every puppet run.\r\n\r\nHow was it tested?\r\npuppetenv -b fixing_hubot on admin1 host\r\n\r\n\r\nWhat nodes are affected?\r\nadmin1 server\r\n\r\nProof:\r\n\r\nBefore:\r\n\r\n```\r\n:~# puppetenv -p\r\n>> Running puppet agent -t --environment production\r\nInfo: Retrieving pluginfacts\r\nInfo: Retrieving plugin\r\nNotice: /File[/var/lib/puppet/lib/puppet/provider/gpg_key]/ensure: created\r\nNotice: /File[/var/lib/puppet/lib/puppet/provider/gpg_key/rpm.rb]/ensure: defined content as '{md5}d77112d1247d1f9e52d55a71bb0d08ff'\r\nNotice: /File[/var/lib/puppet/lib/puppet/provider/package/pe_gem.rb]/ensure: defined content as '{md5}d8c1fc9a71d6ec58e4c0612ab74ff6ec'\r\nNotice: /File[/var/lib/puppet/lib/puppet/type/gpg_key.rb]/ensure: defined content as '{md5}467ea9efc9247cc51fda71bc297376e6'\r\nInfo: Loading facts\r\nInfo: Applying configuration version 'bdda5a8 - Fri Mar 9 10:36:36 2018 -0800'\r\nNotice: /Stage[main]/Hubot::Config/File[/opt/hubot/hubot/package.json]/content:\r\n--- /opt/hubot/hubot/package.json\t2018-03-09 18:22:17.056399649 -0600\r\n+++ /tmp/puppet-file20180309-20065-12kljok\t2018-03-09 20:07:34.060789637 -0600\r\n@@ -3,25 +3,28 @@\r\n   \"version\": \"2.8.3\",\r\n   \"private\": true,\r\n   \"author\": \"GitHub Inc.\",\r\n+\r\n   \"keywords\": [\r\n     \"github\",\r\n     \"hubot\",\r\n     \"campfire\",\r\n     \"bot\"\r\n   ],\r\n+\r\n   \"description\": \"A simple helpful robot for your Company\",\r\n-  \"licenses\": [\r\n-    {\r\n-      \"type\": \"MIT\",\r\n-      \"url\": \"https://github.com/github/hubot/raw/master/LICENSE\"\r\n-    }\r\n-  ],\r\n-  \"repository\": {\r\n+\r\n+  \"licenses\": [{\r\n+    \"type\": \"MIT\",\r\n+    \"url\": \"https://github.com/github/hubot/raw/master/LICENSE\"\r\n+  }],\r\n+\r\n+  \"repository\" : {\r\n     \"type\": \"git\",\r\n     \"url\": \"https://github.com/github/hubot.git\"\r\n   },\r\n+\r\n   \"dependencies\": {\r\n-    \"btoa\": \">= 1.1.0 < 2.0.0\",\r\n+        \"btoa\": \">= 1.1.0 < 2.0.0\",\r\n     \"cheerio\": \">= 0.18.0\",\r\n     \"hubot\": \">= 2.6.0 < 3.0.0\",\r\n     \"hubot-auth\": \"2.1.0\",\r\n@@ -53,11 +56,14 @@\r\n     \"underscore\": \">0\",\r\n     \"xml2js\": \"^0.4.6\"\r\n   },\r\n+\r\n   \"engines\": {\r\n     \"node\": \">= 0.8.x\",\r\n-    \"npm\": \">= 1.1.x\"\r\n+    \"npm\":  \">= 1.1.x\"\r\n   },\r\n+\r\n   \"main\": \"./index\",\r\n+\r\n   \"bin\": {\r\n     \"hubot\": \"./bin/hubot\"\r\n   }\r\n\r\nInfo: Computing checksum on file /opt/hubot/hubot/package.json\r\nInfo: FileBucket got a duplicate file {md5}63e5091c431c92d88a8d2d256b97f2ec\r\nInfo: /Stage[main]/Hubot::Config/File[/opt/hubot/hubot/package.json]: Filebucketed /opt/hubot/hubot/package.json to puppet with sum 63e5091c431c92d88a8d2d256b97f2ec\r\nNotice: /Stage[main]/Hubot::Config/File[/opt/hubot/hubot/package.json]/content: content changed '{md5}63e5091c431c92d88a8d2d256b97f2ec' to '{md5}880c524944f8d167aa65cad60f626c63'\r\nInfo: /Stage[main]/Hubot::Config/File[/opt/hubot/hubot/package.json]: Scheduling refresh of Class[Hubot::Service]\r\nInfo: Class[Hubot::Config]: Scheduling refresh of Class[Hubot::Service]\r\nInfo: Class[Hubot::Service]: Scheduling refresh of Service[hubot]\r\nNotice: /Stage[main]/Hubot::Service/Service[hubot]: Triggered 'refresh' from 1 events\r\nNotice: Finished catalog run in 58.43 seconds\r\n```\r\n\r\nafter:\r\n\r\n```\r\n:~# puppetenv -b fixing_hubot\r\n>> Running puppet agent -t --environment fixing_hubot\r\nInfo: Retrieving pluginfacts\r\nInfo: Retrieving plugin\r\nNotice: /File[/var/lib/puppet/lib/puppet/provider/gpg_key]/ensure: removed\r\nNotice: /File[/var/lib/puppet/lib/puppet/provider/package/pe_gem.rb]/ensure: removed\r\nNotice: /File[/var/lib/puppet/lib/puppet/type/gpg_key.rb]/ensure: removed\r\nInfo: Loading facts\r\nInfo: Applying configuration version '3184813 - Fri Mar 9 18:01:51 2018 -0800'\r\nNotice: Finished catalog run in 59.48 seconds\r\n```"},"comment":{"url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/comments/372421938","html_url":"https://github.com/bigcommerce/puppet-hubot/pull/2#issuecomment-372421938","issue_url":"https://api.github.com/repos/bigcommerce/puppet-hubot/issues/2","id":372421938,"user":{"login":"mhagstrand","id":685532,"avatar_url":"https://avatars1.githubusercontent.com/u/685532?v=4","gravatar_id":"","url":"https://api.github.com/users/mhagstrand","html_url":"https://github.com/mhagstrand","followers_url":"https://api.github.com/users/mhagstrand/followers","following_url":"https://api.github.com/users/mhagstrand/following{/other_user}","gists_url":"https://api.github.com/users/mhagstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mhagstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhagstrand/subscriptions","organizations_url":"https://api.github.com/users/mhagstrand/orgs","repos_url":"https://api.github.com/users/mhagstrand/repos","events_url":"https://api.github.com/users/mhagstrand/events{/privacy}","received_events_url":"https://api.github.com/users/mhagstrand/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T18:48:20Z","updated_at":"2018-03-12T18:48:20Z","author_association":"NONE","body":"Any reason you didn't try to update the entire fork rather than hand pick those changes? "}}
{"actor":{"display_login":"mhagstrand"}}