{"action":"closed","number":30956,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/30956","id":200492460,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDkyNDYw","html_url":"https://github.com/dotnet/corefx/pull/30956","diff_url":"https://github.com/dotnet/corefx/pull/30956.diff","patch_url":"https://github.com/dotnet/corefx/pull/30956.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/30956","number":30956,"state":"closed","locked":false,"title":"Remove version increment from Dictionary<K,V>.Remove overloads","user":{"login":"Wraith2","id":13322696,"node_id":"MDQ6VXNlcjEzMzIyNjk2","avatar_url":"https://avatars0.githubusercontent.com/u/13322696?v=4","gravatar_id":"","url":"https://api.github.com/users/Wraith2","html_url":"https://github.com/Wraith2","followers_url":"https://api.github.com/users/Wraith2/followers","following_url":"https://api.github.com/users/Wraith2/following{/other_user}","gists_url":"https://api.github.com/users/Wraith2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wraith2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wraith2/subscriptions","organizations_url":"https://api.github.com/users/Wraith2/orgs","repos_url":"https://api.github.com/users/Wraith2/repos","events_url":"https://api.github.com/users/Wraith2/events{/privacy}","received_events_url":"https://api.github.com/users/Wraith2/received_events","type":"User","site_admin":false},"body":"Changes all collections tests to handle removal of the version increment from Remove operations \r\n\r\nThis set of changes spans multiple collections projects because the shared tests needed to change to be able to deal with some modification operations now being permitted while enumerating. \r\nAdditional netcore specific tests were added for generic dictionary to make sure that the correct behaviour is maintained.\r\n\r\nRequires [coreclr/18854](https://github.com/dotnet/coreclr/pull/18854)\r\nFixes [corefx/29979](https://github.com/dotnet/corefx/issues/29979), [corefx/31112](https://github.com/dotnet/corefx/issues/31112)","created_at":"2018-07-10T18:57:09Z","updated_at":"2018-07-30T20:07:27Z","closed_at":"2018-07-30T20:07:27Z","merged_at":"2018-07-30T20:07:27Z","merge_commit_sha":"55fd6fed4505d65de2870988802ba642fbf3e61d","assignee":{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"assignees":[{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":154923328,"node_id":"MDU6TGFiZWwxNTQ5MjMzMjg=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Collections","name":"area-System.Collections","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/21","html_url":"https://github.com/dotnet/corefx/milestone/21","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/21/labels","id":3242632,"node_id":"MDk6TWlsZXN0b25lMzI0MjYzMg==","number":21,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":197,"closed_issues":1657,"state":"open","created_at":"2018-04-04T16:40:10Z","updated_at":"2018-07-30T20:07:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/30956/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/30956/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/30956/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8747ab0f1bb36955135715e5a254eaf5cbf6b2fe","head":{"label":"Wraith2:dictremove","ref":"dictremove","sha":"8747ab0f1bb36955135715e5a254eaf5cbf6b2fe","user":{"login":"Wraith2","id":13322696,"node_id":"MDQ6VXNlcjEzMzIyNjk2","avatar_url":"https://avatars0.githubusercontent.com/u/13322696?v=4","gravatar_id":"","url":"https://api.github.com/users/Wraith2","html_url":"https://github.com/Wraith2","followers_url":"https://api.github.com/users/Wraith2/followers","following_url":"https://api.github.com/users/Wraith2/following{/other_user}","gists_url":"https://api.github.com/users/Wraith2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wraith2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wraith2/subscriptions","organizations_url":"https://api.github.com/users/Wraith2/orgs","repos_url":"https://api.github.com/users/Wraith2/repos","events_url":"https://api.github.com/users/Wraith2/events{/privacy}","received_events_url":"https://api.github.com/users/Wraith2/received_events","type":"User","site_admin":false},"repo":{"id":137270990,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyNzA5OTA=","name":"corefx","full_name":"Wraith2/corefx","owner":{"login":"Wraith2","id":13322696,"node_id":"MDQ6VXNlcjEzMzIyNjk2","avatar_url":"https://avatars0.githubusercontent.com/u/13322696?v=4","gravatar_id":"","url":"https://api.github.com/users/Wraith2","html_url":"https://github.com/Wraith2","followers_url":"https://api.github.com/users/Wraith2/followers","following_url":"https://api.github.com/users/Wraith2/following{/other_user}","gists_url":"https://api.github.com/users/Wraith2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wraith2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wraith2/subscriptions","organizations_url":"https://api.github.com/users/Wraith2/orgs","repos_url":"https://api.github.com/users/Wraith2/repos","events_url":"https://api.github.com/users/Wraith2/events{/privacy}","received_events_url":"https://api.github.com/users/Wraith2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wraith2/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/Wraith2/corefx","forks_url":"https://api.github.com/repos/Wraith2/corefx/forks","keys_url":"https://api.github.com/repos/Wraith2/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wraith2/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wraith2/corefx/teams","hooks_url":"https://api.github.com/repos/Wraith2/corefx/hooks","issue_events_url":"https://api.github.com/repos/Wraith2/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Wraith2/corefx/events","assignees_url":"https://api.github.com/repos/Wraith2/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Wraith2/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Wraith2/corefx/tags","blobs_url":"https://api.github.com/repos/Wraith2/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wraith2/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wraith2/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wraith2/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wraith2/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Wraith2/corefx/languages","stargazers_url":"https://api.github.com/repos/Wraith2/corefx/stargazers","contributors_url":"https://api.github.com/repos/Wraith2/corefx/contributors","subscribers_url":"https://api.github.com/repos/Wraith2/corefx/subscribers","subscription_url":"https://api.github.com/repos/Wraith2/corefx/subscription","commits_url":"https://api.github.com/repos/Wraith2/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wraith2/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wraith2/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wraith2/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wraith2/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Wraith2/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wraith2/corefx/merges","archive_url":"https://api.github.com/repos/Wraith2/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wraith2/corefx/downloads","issues_url":"https://api.github.com/repos/Wraith2/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Wraith2/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Wraith2/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Wraith2/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wraith2/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Wraith2/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/Wraith2/corefx/deployments","created_at":"2018-06-13T21:06:15Z","updated_at":"2018-07-18T22:52:13Z","pushed_at":"2018-07-23T18:06:02Z","git_url":"git://github.com/Wraith2/corefx.git","ssh_url":"git@github.com:Wraith2/corefx.git","clone_url":"https://github.com/Wraith2/corefx.git","svn_url":"https://github.com/Wraith2/corefx","homepage":"https://github.com/dotnet/core","size":184028,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0c6cb66794c04a29030b2512673e240c2da98a87","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-07-30T19:40:27Z","pushed_at":"2018-07-30T20:07:27Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":184951,"stargazers_count":14479,"watchers_count":14479,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4197,"mirror_url":null,"archived":false,"open_issues_count":2500,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4197,"open_issues":2500,"watchers":14479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30956"},"html":{"href":"https://github.com/dotnet/corefx/pull/30956"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30956"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/30956/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30956/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/30956/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8747ab0f1bb36955135715e5a254eaf5cbf6b2fe"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"comments":15,"review_comments":20,"maintainer_can_modify":false,"commits":14,"additions":442,"deletions":171,"changed_files":38}}
{"actor":{"display_login":"safern"}}