{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/200807984","pull_request_review_id":135199652,"id":200807984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgwNzk4NA==","diff_hunk":"@@ -0,0 +1,17 @@\n+﻿using System;\n+using Xamarin.Forms.PlatformConfiguration;\n+using Xamarin.Forms.PlatformConfiguration.iOSSpecific;\n+\n+namespace Xamarin.Forms.Controls.GalleryPages.PlatformSpecificsGalleries\n+{\n+\tpublic class ModalFormSheetPageiOS : ContentPage","path":"Xamarin.Forms.Controls/GalleryPages/PlatformSpecificsGalleries/ModalFormSheetPageiOS.cs","position":6,"original_position":7,"commit_id":"51187d80774ae04b9f314dc6cad0d379b3e458b2","original_commit_id":"f695fb85330a55915d60fcfc98d7095350de997b","user":{"login":"jfversluis","id":939291,"node_id":"MDQ6VXNlcjkzOTI5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/939291?v=4","gravatar_id":"","url":"https://api.github.com/users/jfversluis","html_url":"https://github.com/jfversluis","followers_url":"https://api.github.com/users/jfversluis/followers","following_url":"https://api.github.com/users/jfversluis/following{/other_user}","gists_url":"https://api.github.com/users/jfversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jfversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfversluis/subscriptions","organizations_url":"https://api.github.com/users/jfversluis/orgs","repos_url":"https://api.github.com/users/jfversluis/repos","events_url":"https://api.github.com/users/jfversluis/events{/privacy}","received_events_url":"https://api.github.com/users/jfversluis/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-07-07T09:49:27Z","updated_at":"2018-07-07T09:49:27Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/3119#discussion_r200807984","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/200807984"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/3119#discussion_r200807984"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119"}},"in_reply_to_id":200772834},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119","id":196688448,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Njg4NDQ4","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/3119","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/3119.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/3119.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/3119","number":3119,"state":"open","locked":false,"title":"[Enhancement][iOS] Support UIModalPresentationStyle.FormSheet","user":{"login":"jfversluis","id":939291,"node_id":"MDQ6VXNlcjkzOTI5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/939291?v=4","gravatar_id":"","url":"https://api.github.com/users/jfversluis","html_url":"https://github.com/jfversluis","followers_url":"https://api.github.com/users/jfversluis/followers","following_url":"https://api.github.com/users/jfversluis/following{/other_user}","gists_url":"https://api.github.com/users/jfversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jfversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfversluis/subscriptions","organizations_url":"https://api.github.com/users/jfversluis/orgs","repos_url":"https://api.github.com/users/jfversluis/repos","events_url":"https://api.github.com/users/jfversluis/events{/privacy}","received_events_url":"https://api.github.com/users/jfversluis/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nAdded an enum and implemented logic in the modal presentation on the iPad. As per #1726 you are now able to show a modal popup as a form sheet on the iPad. By default, it will still show fullscreen, but you now have the possibility of setting it to \"FormSheet\" which causes a smaller sized overlay to show on the iPad.\r\n\r\nHad to hook into the `Platform.PresentModal`, that was the only place where setting the `UIViewController.ModalPresentationStyle` had effect for some reason. Ideally, I would have wanted this in the renderer(?). If anyone sees how to do it there, please let me know.\r\n\r\nNo tests were added since this is a visual change only.\r\n\r\n### Issues Resolved ###\r\n\r\n- Fixes #1726 \r\n\r\n### API Changes ###\r\n\r\nAdded:\r\n - Page.On<iOS>.SetModalPresentationStyle(UIModalPresentationStyle.FormSheet)\r\n\r\n### Platforms Affected ###\r\n\r\n<!-- Please list all platforms affected by these changes -->\r\n\r\n- iOS (iPad only)\r\n\r\n### Behavioral/Visual Changes ###\r\n\r\nWhen upgrading no change should happen, only when the user explicitly sets the modal presentation style.\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has automated tests <!-- (if tests are omitted or manual, state reason in description) -->\r\n- [X] Rebased on top of the target branch at time of PR\r\n- [X] Changes adhere to coding standard\r\n","created_at":"2018-06-22T09:44:14Z","updated_at":"2018-07-07T09:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a3d33b02bfb99397c94b5938ba26d105931697","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":868986974,"node_id":"MDU6TGFiZWw4Njg5ODY5NzQ=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/API-change","name":"API-change","color":"fbca04","default":false},{"id":343860853,"node_id":"MDU6TGFiZWwzNDM4NjA4NTM=","url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/t/enhancement%20%E2%9E%95","name":"t/enhancement ➕","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/3119/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/51187d80774ae04b9f314dc6cad0d379b3e458b2","head":{"label":"jfversluis:feature/issue-1726","ref":"feature/issue-1726","sha":"51187d80774ae04b9f314dc6cad0d379b3e458b2","user":{"login":"jfversluis","id":939291,"node_id":"MDQ6VXNlcjkzOTI5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/939291?v=4","gravatar_id":"","url":"https://api.github.com/users/jfversluis","html_url":"https://github.com/jfversluis","followers_url":"https://api.github.com/users/jfversluis/followers","following_url":"https://api.github.com/users/jfversluis/following{/other_user}","gists_url":"https://api.github.com/users/jfversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jfversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfversluis/subscriptions","organizations_url":"https://api.github.com/users/jfversluis/orgs","repos_url":"https://api.github.com/users/jfversluis/repos","events_url":"https://api.github.com/users/jfversluis/events{/privacy}","received_events_url":"https://api.github.com/users/jfversluis/received_events","type":"User","site_admin":false},"repo":{"id":135403050,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0MDMwNTA=","name":"Xamarin.Forms","full_name":"jfversluis/Xamarin.Forms","owner":{"login":"jfversluis","id":939291,"node_id":"MDQ6VXNlcjkzOTI5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/939291?v=4","gravatar_id":"","url":"https://api.github.com/users/jfversluis","html_url":"https://github.com/jfversluis","followers_url":"https://api.github.com/users/jfversluis/followers","following_url":"https://api.github.com/users/jfversluis/following{/other_user}","gists_url":"https://api.github.com/users/jfversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jfversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfversluis/subscriptions","organizations_url":"https://api.github.com/users/jfversluis/orgs","repos_url":"https://api.github.com/users/jfversluis/repos","events_url":"https://api.github.com/users/jfversluis/events{/privacy}","received_events_url":"https://api.github.com/users/jfversluis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfversluis/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/jfversluis/Xamarin.Forms","forks_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/jfversluis/Xamarin.Forms/deployments","created_at":"2018-05-30T07:11:21Z","updated_at":"2018-06-09T15:42:28Z","pushed_at":"2018-07-07T09:49:10Z","git_url":"git://github.com/jfversluis/Xamarin.Forms.git","ssh_url":"git@github.com:jfversluis/Xamarin.Forms.git","clone_url":"https://github.com/jfversluis/Xamarin.Forms.git","svn_url":"https://github.com/jfversluis/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":44551,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"47fd55130bfa9bd78188d2c55b9ec3abef3cd8ea","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"node_id":"MDEwOlJlcG9zaXRvcnk1NDIxMzQ5MA==","name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2018-07-06T17:51:19Z","pushed_at":"2018-07-07T09:49:13Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":45544,"stargazers_count":2367,"watchers_count":2367,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":992,"mirror_url":null,"archived":false,"open_issues_count":695,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":992,"open_issues":695,"watchers":2367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/3119"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/3119"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/3119/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/3119/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/51187d80774ae04b9f314dc6cad0d379b3e458b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfversluis"}}