{"action":"created","issue":{"url":"https://api.github.com/repos/yankaindustries/mc-components/issues/206","repository_url":"https://api.github.com/repos/yankaindustries/mc-components","labels_url":"https://api.github.com/repos/yankaindustries/mc-components/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/yankaindustries/mc-components/issues/206/comments","events_url":"https://api.github.com/repos/yankaindustries/mc-components/issues/206/events","html_url":"https://github.com/yankaindustries/mc-components/pull/206","id":360036454,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzkyMjcw","number":206,"title":"Updating breakpoints","user":{"login":"stephenp","id":505670,"node_id":"MDQ6VXNlcjUwNTY3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/505670?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenp","html_url":"https://github.com/stephenp","followers_url":"https://api.github.com/users/stephenp/followers","following_url":"https://api.github.com/users/stephenp/following{/other_user}","gists_url":"https://api.github.com/users/stephenp/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenp/subscriptions","organizations_url":"https://api.github.com/users/stephenp/orgs","repos_url":"https://api.github.com/users/stephenp/repos","events_url":"https://api.github.com/users/stephenp/events{/privacy}","received_events_url":"https://api.github.com/users/stephenp/received_events","type":"User","site_admin":false},"labels":[{"id":963885662,"node_id":"MDU6TGFiZWw5NjM4ODU2NjI=","url":"https://api.github.com/repos/yankaindustries/mc-components/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"stephenp","id":505670,"node_id":"MDQ6VXNlcjUwNTY3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/505670?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenp","html_url":"https://github.com/stephenp","followers_url":"https://api.github.com/users/stephenp/followers","following_url":"https://api.github.com/users/stephenp/following{/other_user}","gists_url":"https://api.github.com/users/stephenp/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenp/subscriptions","organizations_url":"https://api.github.com/users/stephenp/orgs","repos_url":"https://api.github.com/users/stephenp/repos","events_url":"https://api.github.com/users/stephenp/events{/privacy}","received_events_url":"https://api.github.com/users/stephenp/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephenp","id":505670,"node_id":"MDQ6VXNlcjUwNTY3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/505670?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenp","html_url":"https://github.com/stephenp","followers_url":"https://api.github.com/users/stephenp/followers","following_url":"https://api.github.com/users/stephenp/following{/other_user}","gists_url":"https://api.github.com/users/stephenp/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenp/subscriptions","organizations_url":"https://api.github.com/users/stephenp/orgs","repos_url":"https://api.github.com/users/stephenp/repos","events_url":"https://api.github.com/users/stephenp/events{/privacy}","received_events_url":"https://api.github.com/users/stephenp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-13T19:36:02Z","updated_at":"2018-09-13T20:09:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/yankaindustries/mc-components/pulls/206","html_url":"https://github.com/yankaindustries/mc-components/pull/206","diff_url":"https://github.com/yankaindustries/mc-components/pull/206.diff","patch_url":"https://github.com/yankaindustries/mc-components/pull/206.patch"},"body":"## Overview\r\nThere was a misalignment of expectations between design and development on how the grid works.  We spoke with Sean and got clarification on how design would like to have the grid implemented and these code changes reflect those discussions.\r\n\r\n## THIS IS A POTENTIALLY BREAKING CHANGE\r\nAny components using the existing grid might have edge cases while hitting breakpoints that could visually break them.  @jstnjns and I will be going through existing components to verify there are no breaking changes as well as the masterclass repo before versioning mc-components.  We would like to get this change in ASAP so any developers building new components will be using the grid now vs later.  There should be a separate PR in the next few days to adjust any existing components to work with the new grid.\r\n\r\n## Risks\r\nMedium - High, lots of potential issues with resizing components with the new grid.  The max widths and breakpoints that we were using before don't necessarily apply.\r\n\r\n## Changes\r\nChanges can be viewed on the grid storybook example.\r\n\r\n## Issue\r\nN/A\r\n"},"comment":{"url":"https://api.github.com/repos/yankaindustries/mc-components/issues/comments/421136525","html_url":"https://github.com/yankaindustries/mc-components/pull/206#issuecomment-421136525","issue_url":"https://api.github.com/repos/yankaindustries/mc-components/issues/206","id":421136525,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTEzNjUyNQ==","user":{"login":"stephenp","id":505670,"node_id":"MDQ6VXNlcjUwNTY3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/505670?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenp","html_url":"https://github.com/stephenp","followers_url":"https://api.github.com/users/stephenp/followers","following_url":"https://api.github.com/users/stephenp/following{/other_user}","gists_url":"https://api.github.com/users/stephenp/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenp/subscriptions","organizations_url":"https://api.github.com/users/stephenp/orgs","repos_url":"https://api.github.com/users/stephenp/repos","events_url":"https://api.github.com/users/stephenp/events{/privacy}","received_events_url":"https://api.github.com/users/stephenp/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T20:09:20Z","updated_at":"2018-09-13T20:09:20Z","author_association":"COLLABORATOR","body":"@bernabe9 There is a max-width when you get a window wider than 1200px, but other than that, the container will be 100% of the window width with padding on the left and right.  Here is the documentation from design that outlines how they want the grid to behave:\r\n\r\n![image](https://user-images.githubusercontent.com/505670/45512865-e52f8500-b755-11e8-81f1-521ef2ee0546.png)\r\n\r\n\"Margins\" are the padding on the left and right of the grid\r\n\"Gutters\" is the amount of padding between each column and the one next to it (implemented in code as 1/2 the \"gutter\" value they define on the inside of each column)\r\n\"Breakpoint\" is the visual width of a box contained within a full 12-column row.  So for the max breakpoint of 1200px, the content is within a container with a max width of 1328 (1200px + 64px margin + 64px margin)"}}
{"actor":{"display_login":"stephenp"}}