{"action":"created","issue":{"url":"https://api.github.com/repos/solid/node-solid-server/issues/887","repository_url":"https://api.github.com/repos/solid/node-solid-server","labels_url":"https://api.github.com/repos/solid/node-solid-server/issues/887/labels{/name}","comments_url":"https://api.github.com/repos/solid/node-solid-server/issues/887/comments","events_url":"https://api.github.com/repos/solid/node-solid-server/issues/887/events","html_url":"https://github.com/solid/node-solid-server/pull/887","id":373550309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDU2MDQy","number":887,"title":"Update SSL Certificate Naming Convention (Issue 876)","user":{"login":"steven-tomlinson","id":8976999,"node_id":"MDQ6VXNlcjg5NzY5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8976999?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-tomlinson","html_url":"https://github.com/steven-tomlinson","followers_url":"https://api.github.com/users/steven-tomlinson/followers","following_url":"https://api.github.com/users/steven-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/steven-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/steven-tomlinson/orgs","repos_url":"https://api.github.com/users/steven-tomlinson/repos","events_url":"https://api.github.com/users/steven-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-tomlinson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-10-24T15:45:25Z","updated_at":"2018-10-25T00:09:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/solid/node-solid-server/pulls/887","html_url":"https://github.com/solid/node-solid-server/pull/887","diff_url":"https://github.com/solid/node-solid-server/pull/887.diff","patch_url":"https://github.com/solid/node-solid-server/pull/887.patch"},"body":"This change addresses Issue #876 'consider renaming localhost.key to privkey.pem'\r\n\r\nEdited README.MD\r\nChanged test environment instructions for generating self-signed SSL certificate to explcitly create a PEM certificate.\r\nAdded tip to eliminate browser warning.\r\n\r\n'./config.json-default' updated\r\nWill now use privkey.pem instead of 'localhost.key' as default SSL private key name in a test environment.\r\n\r\nEdited EXAMPLES.MD to reflect preference for new SSL naming convention.\r\n\r\n'./config.json-default' updated\r\nWill now use fullchain.pem instead of 'localhost.cert' as default SSL Certificate Name in a test environment.\r\n\r\n'./Dockerfile' updated\r\nWill now use fullchain.pem instead of 'localhost.cert' as default SSL Certificate File Name  when generating Certificate Request.\r\n\r\n'./Dockerfile' updated\r\nWill now use privkey.pem instead of 'localhost.key' as default SSL Key File Name when generating Certificate Request.\r\n\r\nThis contribution to Solid is governed by the MIT License."},"comment":{"url":"https://api.github.com/repos/solid/node-solid-server/issues/comments/432869283","html_url":"https://github.com/solid/node-solid-server/pull/887#issuecomment-432869283","issue_url":"https://api.github.com/repos/solid/node-solid-server/issues/887","id":432869283,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjg2OTI4Mw==","user":{"login":"kjetilk","id":154068,"node_id":"MDQ6VXNlcjE1NDA2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/154068?v=4","gravatar_id":"","url":"https://api.github.com/users/kjetilk","html_url":"https://github.com/kjetilk","followers_url":"https://api.github.com/users/kjetilk/followers","following_url":"https://api.github.com/users/kjetilk/following{/other_user}","gists_url":"https://api.github.com/users/kjetilk/gists{/gist_id}","starred_url":"https://api.github.com/users/kjetilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjetilk/subscriptions","organizations_url":"https://api.github.com/users/kjetilk/orgs","repos_url":"https://api.github.com/users/kjetilk/repos","events_url":"https://api.github.com/users/kjetilk/events{/privacy}","received_events_url":"https://api.github.com/users/kjetilk/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T00:09:59Z","updated_at":"2018-10-25T00:09:59Z","author_association":"CONTRIBUTOR","body":"> @kjetilk should I rebase my branch on 'develop' instead of 'master\" as well before initiating a pull request?\r\n\r\nNormally, yes, but I did it for you this time! :-) \r\n\r\nWe need to reconsider which branch is our default, I think."}}
{"actor":{"display_login":"kjetilk"}}