{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/194222123","pull_request_review_id":127360618,"id":194222123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDIyMjEyMw==","diff_hunk":"@@ -235,6 +236,57 @@ public void testEditQuestionAction() throws Exception {\n         assertEquals(\"200\", feedbackEditPage.getConstSumPointsForEachRecipientBox(1));\n     }\n \n+    /**\n+     * Tests Min and Max Points Constraint.\n+     * Element {@code constSumPointsMin} is enabled when Element {@code constSumPointsHasMaxPointsConstraint} is checked.\n+     */\n+    public void testEditConstSumQuestionWithPointsConstraint() {","path":"src/test/java/teammates/test/cases/browsertests/FeedbackConstSumOptionQuestionUiTest.java","position":16,"original_position":16,"commit_id":"2778c7289113c8b99d5a570500962a0e4c8005e5","original_commit_id":"2778c7289113c8b99d5a570500962a0e4c8005e5","user":{"login":"xpdavid","id":13977235,"node_id":"MDQ6VXNlcjEzOTc3MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/13977235?v=4","gravatar_id":"","url":"https://api.github.com/users/xpdavid","html_url":"https://github.com/xpdavid","followers_url":"https://api.github.com/users/xpdavid/followers","following_url":"https://api.github.com/users/xpdavid/following{/other_user}","gists_url":"https://api.github.com/users/xpdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/xpdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpdavid/subscriptions","organizations_url":"https://api.github.com/users/xpdavid/orgs","repos_url":"https://api.github.com/users/xpdavid/repos","events_url":"https://api.github.com/users/xpdavid/events{/privacy}","received_events_url":"https://api.github.com/users/xpdavid/received_events","type":"User","site_admin":false},"body":"Test add new question?\r\nFor end-to-end test, just test one success and failure scenario respectively should be enough as we have put efforts in the integration test. ","created_at":"2018-06-09T10:12:09Z","updated_at":"2018-06-09T10:19:57Z","html_url":"https://github.com/TEAMMATES/teammates/pull/8464#discussion_r194222123","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/194222123"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8464#discussion_r194222123"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464","id":169777178,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY5Nzc3MTc4","html_url":"https://github.com/TEAMMATES/teammates/pull/8464","diff_url":"https://github.com/TEAMMATES/teammates/pull/8464.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8464.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8464","number":8464,"state":"open","locked":false,"title":"Instructor: edit feedback: support min max for distribute points questions #8450","user":{"login":"Crphang","id":4986717,"node_id":"MDQ6VXNlcjQ5ODY3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"body":"Fixes #8450 \r\n\r\nWork in progress\r\n\r\n**Outline of Solution**\r\n\r\n- [X] Add UI changes to support instructor adding min/max points constraint\r\n- [x] Add logic/storage when persisting this information for `FeedbackConstantSumQuestionDetails`\r\n- [x] Add UI and logic to respondent when answering such questions.\r\n- [x] Add test to ensure that a respondent cannot break the min and max constraint.\r\n\r\nCurrent UI changes:\r\n\r\n![image](https://user-images.githubusercontent.com/4986717/36342113-59c30e98-1434-11e8-9fa9-f567f232ff73.png)\r\n\r\n","created_at":"2018-02-17T10:11:18Z","updated_at":"2018-06-09T10:19:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eef1930262e18507a73586311409031c9a3a2ae9","assignee":{"login":"xpdavid","id":13977235,"node_id":"MDQ6VXNlcjEzOTc3MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/13977235?v=4","gravatar_id":"","url":"https://api.github.com/users/xpdavid","html_url":"https://github.com/xpdavid","followers_url":"https://api.github.com/users/xpdavid/followers","following_url":"https://api.github.com/users/xpdavid/following{/other_user}","gists_url":"https://api.github.com/users/xpdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/xpdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpdavid/subscriptions","organizations_url":"https://api.github.com/users/xpdavid/orgs","repos_url":"https://api.github.com/users/xpdavid/repos","events_url":"https://api.github.com/users/xpdavid/events{/privacy}","received_events_url":"https://api.github.com/users/xpdavid/received_events","type":"User","site_admin":false},"assignees":[{"login":"xpdavid","id":13977235,"node_id":"MDQ6VXNlcjEzOTc3MjM1","avatar_url":"https://avatars3.githubusercontent.com/u/13977235?v=4","gravatar_id":"","url":"https://api.github.com/users/xpdavid","html_url":"https://github.com/xpdavid","followers_url":"https://api.github.com/users/xpdavid/followers","following_url":"https://api.github.com/users/xpdavid/following{/other_user}","gists_url":"https://api.github.com/users/xpdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/xpdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpdavid/subscriptions","organizations_url":"https://api.github.com/users/xpdavid/orgs","repos_url":"https://api.github.com/users/xpdavid/repos","events_url":"https://api.github.com/users/xpdavid/events{/privacy}","received_events_url":"https://api.github.com/users/xpdavid/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98049565,"node_id":"MDU6TGFiZWw5ODA0OTU2NQ==","url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.ToReview","name":"s.ToReview","color":"47B74E","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8464/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/2778c7289113c8b99d5a570500962a0e4c8005e5","head":{"label":"Crphang:8450-instructor-distribute-points-min-max","ref":"8450-instructor-distribute-points-min-max","sha":"2778c7289113c8b99d5a570500962a0e4c8005e5","user":{"login":"Crphang","id":4986717,"node_id":"MDQ6VXNlcjQ5ODY3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"repo":{"id":115333322,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUzMzMzMjI=","name":"teammates","full_name":"Crphang/teammates","owner":{"login":"Crphang","id":4986717,"node_id":"MDQ6VXNlcjQ5ODY3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crphang/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/Crphang/teammates","forks_url":"https://api.github.com/repos/Crphang/teammates/forks","keys_url":"https://api.github.com/repos/Crphang/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crphang/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crphang/teammates/teams","hooks_url":"https://api.github.com/repos/Crphang/teammates/hooks","issue_events_url":"https://api.github.com/repos/Crphang/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/Crphang/teammates/events","assignees_url":"https://api.github.com/repos/Crphang/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/Crphang/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/Crphang/teammates/tags","blobs_url":"https://api.github.com/repos/Crphang/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crphang/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crphang/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crphang/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crphang/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/Crphang/teammates/languages","stargazers_url":"https://api.github.com/repos/Crphang/teammates/stargazers","contributors_url":"https://api.github.com/repos/Crphang/teammates/contributors","subscribers_url":"https://api.github.com/repos/Crphang/teammates/subscribers","subscription_url":"https://api.github.com/repos/Crphang/teammates/subscription","commits_url":"https://api.github.com/repos/Crphang/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crphang/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crphang/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crphang/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crphang/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/Crphang/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crphang/teammates/merges","archive_url":"https://api.github.com/repos/Crphang/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crphang/teammates/downloads","issues_url":"https://api.github.com/repos/Crphang/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/Crphang/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/Crphang/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/Crphang/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crphang/teammates/labels{/name}","releases_url":"https://api.github.com/repos/Crphang/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/Crphang/teammates/deployments","created_at":"2017-12-25T11:38:19Z","updated_at":"2017-12-25T11:38:26Z","pushed_at":"2018-05-29T14:30:13Z","git_url":"git://github.com/Crphang/teammates.git","ssh_url":"git@github.com:Crphang/teammates.git","clone_url":"https://github.com/Crphang/teammates.git","svn_url":"https://github.com/Crphang/teammates","homepage":"https://teammatesv4.appspot.com/","size":198190,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"adb0297549725560eef310202da3e27746822666","user":{"login":"TEAMMATES","id":7374810,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNzQ4MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM2OTAzNQ==","name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNzQ4MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2018-06-09T09:08:04Z","pushed_at":"2018-06-09T09:37:43Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":197807,"stargazers_count":614,"watchers_count":614,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1431,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1431,"open_issues":289,"watchers":614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8464"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8464"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8464/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8464/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/2778c7289113c8b99d5a570500962a0e4c8005e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xpdavid"}}