{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/comments/235214474","pull_request_review_id":177029848,"id":235214474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTIxNDQ3NA==","diff_hunk":"@@ -130,4 +126,12 @@ export class ConfirmPrompt extends Prompt<boolean> {\n \n         return result;\n     }\n+\n+    private DetermineCulture(activity: Activity) : string {","path":"libraries/botbuilder-dialogs/src/prompts/confirmPrompt.ts","position":48,"original_position":48,"commit_id":"83190e0b2db81b62debd82dd105cce893971b4da","original_commit_id":"83190e0b2db81b62debd82dd105cce893971b4da","user":{"login":"stevengum","id":14935595,"node_id":"MDQ6VXNlcjE0OTM1NTk1","avatar_url":"https://avatars1.githubusercontent.com/u/14935595?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengum","html_url":"https://github.com/stevengum","followers_url":"https://api.github.com/users/stevengum/followers","following_url":"https://api.github.com/users/stevengum/following{/other_user}","gists_url":"https://api.github.com/users/stevengum/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengum/subscriptions","organizations_url":"https://api.github.com/users/stevengum/orgs","repos_url":"https://api.github.com/users/stevengum/repos","events_url":"https://api.github.com/users/stevengum/events{/privacy}","received_events_url":"https://api.github.com/users/stevengum/received_events","type":"User","site_admin":false},"body":"The method name should be camel cased, and there is an extra space after `)`","created_at":"2018-11-21T00:07:21Z","updated_at":"2018-11-21T00:20:33Z","html_url":"https://github.com/Microsoft/botbuilder-js/pull/654#discussion_r235214474","pull_request_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/comments/235214474"},"html":{"href":"https://github.com/Microsoft/botbuilder-js/pull/654#discussion_r235214474"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654","id":232497805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDk3ODA1","html_url":"https://github.com/Microsoft/botbuilder-js/pull/654","diff_url":"https://github.com/Microsoft/botbuilder-js/pull/654.diff","patch_url":"https://github.com/Microsoft/botbuilder-js/pull/654.patch","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/654","number":654,"state":"open","locked":false,"title":"fix confirm prompt when invalid locale used with number selection","user":{"login":"johnataylor","id":2523898,"node_id":"MDQ6VXNlcjI1MjM4OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2523898?v=4","gravatar_id":"","url":"https://api.github.com/users/johnataylor","html_url":"https://github.com/johnataylor","followers_url":"https://api.github.com/users/johnataylor/followers","following_url":"https://api.github.com/users/johnataylor/following{/other_user}","gists_url":"https://api.github.com/users/johnataylor/gists{/gist_id}","starred_url":"https://api.github.com/users/johnataylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnataylor/subscriptions","organizations_url":"https://api.github.com/users/johnataylor/orgs","repos_url":"https://api.github.com/users/johnataylor/repos","events_url":"https://api.github.com/users/johnataylor/events{/privacy}","received_events_url":"https://api.github.com/users/johnataylor/received_events","type":"User","site_admin":false},"body":"Fixes #648 \r\n\r\n## Description\r\nConfirm prompt had exception when invalid locale used with number selection.\r\n\r\n(I'm also aligning the implementation slightly with the c# - calling the variable culture.)\r\n\r\nNote the defaults tables should be merged - however they are public - they shouldn't be public. We can treat this as a separate issue.\r\n","created_at":"2018-11-21T00:02:31Z","updated_at":"2018-11-21T00:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5d68712165ceb360e1fa7ab8934706d89f6c1e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654/commits","review_comments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654/comments","review_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/654/comments","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-js/statuses/83190e0b2db81b62debd82dd105cce893971b4da","head":{"label":"Microsoft:johtaylo/confirm-fix","ref":"johtaylo/confirm-fix","sha":"83190e0b2db81b62debd82dd105cce893971b4da","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021493,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwMjE0OTM=","name":"botbuilder-js","full_name":"Microsoft/botbuilder-js","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/botbuilder-js","description":"The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-js","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-js/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-js/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-js/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-js/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-js/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-js/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-js/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-js/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-js/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-js/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-js/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-js/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-js/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-js/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-js/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-js/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-js/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/deployments","created_at":"2018-01-10T23:01:21Z","updated_at":"2018-11-20T17:34:45Z","pushed_at":"2018-11-21T00:02:32Z","git_url":"git://github.com/Microsoft/botbuilder-js.git","ssh_url":"git@github.com:Microsoft/botbuilder-js.git","clone_url":"https://github.com/Microsoft/botbuilder-js.git","svn_url":"https://github.com/Microsoft/botbuilder-js","homepage":"http://botframework.com","size":9928,"stargazers_count":141,"watchers_count":141,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":84,"open_issues":55,"watchers":141,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"66dd368e35a64302563afa66d17134e7c833853f","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021493,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwMjE0OTM=","name":"botbuilder-js","full_name":"Microsoft/botbuilder-js","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/botbuilder-js","description":"The Microsoft Bot Framework provides what you need to build and connect intelligent bots that interact naturally wherever your users are talking, from text/sms to Skype, Slack, Office 365 mail and other popular services.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-js","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-js/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-js/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-js/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-js/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-js/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-js/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-js/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-js/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-js/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-js/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-js/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-js/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-js/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-js/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-js/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-js/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-js/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-js/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-js/deployments","created_at":"2018-01-10T23:01:21Z","updated_at":"2018-11-20T17:34:45Z","pushed_at":"2018-11-21T00:02:32Z","git_url":"git://github.com/Microsoft/botbuilder-js.git","ssh_url":"git@github.com:Microsoft/botbuilder-js.git","clone_url":"https://github.com/Microsoft/botbuilder-js.git","svn_url":"https://github.com/Microsoft/botbuilder-js","homepage":"http://botframework.com","size":9928,"stargazers_count":141,"watchers_count":141,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":84,"open_issues":55,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654"},"html":{"href":"https://github.com/Microsoft/botbuilder-js/pull/654"},"issue":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/654"},"comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/botbuilder-js/statuses/83190e0b2db81b62debd82dd105cce893971b4da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stevengum"}}