{"action":"created","issue":{"url":"https://api.github.com/repos/numpy/numpy/issues/11739","repository_url":"https://api.github.com/repos/numpy/numpy","labels_url":"https://api.github.com/repos/numpy/numpy/issues/11739/labels{/name}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/11739/comments","events_url":"https://api.github.com/repos/numpy/numpy/issues/11739/events","html_url":"https://github.com/numpy/numpy/pull/11739","id":350543079,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzY4ODY2","number":11739,"title":"BUG: disallow setting flag to writeable after fromstring, frombuffer","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"labels":[{"id":6359214,"node_id":"MDU6TGFiZWw2MzU5MjE0","url":"https://api.github.com/repos/numpy/numpy/labels/00%20-%20Bug","name":"00 - Bug","color":"fef2c0","default":false},{"id":16917029,"node_id":"MDU6TGFiZWwxNjkxNzAyOQ==","url":"https://api.github.com/repos/numpy/numpy/labels/component:%20numpy.core","name":"component: numpy.core","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-14T18:23:17Z","updated_at":"2018-12-23T10:35:49Z","closed_at":"2018-11-26T23:40:26Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/11739","html_url":"https://github.com/numpy/numpy/pull/11739","diff_url":"https://github.com/numpy/numpy/pull/11739.diff","patch_url":"https://github.com/numpy/numpy/pull/11739.patch"},"body":"Fixes #9440. The comment in the code was incorrect, `array_setstate` used in unpickling does not call `_IsWriteable`. `_IsWriteable` is only used in setting flags.\r\n\r\nNote that new pickling tests use a large buffer to ensure it goes through `PyArray_SetBaseObject` in `array_setstate`, but that the flag is still set to `writeable`."},"comment":{"url":"https://api.github.com/repos/numpy/numpy/issues/comments/449627619","html_url":"https://github.com/numpy/numpy/pull/11739#issuecomment-449627619","issue_url":"https://api.github.com/repos/numpy/numpy/issues/11739","id":449627619,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTYyNzYxOQ==","user":{"login":"mattip","id":823911,"node_id":"MDQ6VXNlcjgyMzkxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/823911?v=4","gravatar_id":"","url":"https://api.github.com/users/mattip","html_url":"https://github.com/mattip","followers_url":"https://api.github.com/users/mattip/followers","following_url":"https://api.github.com/users/mattip/following{/other_user}","gists_url":"https://api.github.com/users/mattip/gists{/gist_id}","starred_url":"https://api.github.com/users/mattip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattip/subscriptions","organizations_url":"https://api.github.com/users/mattip/orgs","repos_url":"https://api.github.com/users/mattip/repos","events_url":"https://api.github.com/users/mattip/events{/privacy}","received_events_url":"https://api.github.com/users/mattip/received_events","type":"User","site_admin":false},"created_at":"2018-12-23T10:35:49Z","updated_at":"2018-12-23T10:35:49Z","author_association":"MEMBER","body":"We currently do not have a way to force the `writable` flag to `True` from python. You could do this in C. We seem to have conflicting goals of `eliminating dangerous behaviour` and `allow advanced users to use dangerous behaviour`"}}
{"actor":{"display_login":"mattip"}}