{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17679","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17679/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17679/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17679/events","html_url":"https://github.com/ManageIQ/manageiq/pull/17679","id":339488516,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTI5NDA1","number":17679,"title":"Remove generic object from all related services before destroy","user":{"login":"pkomanek","id":19405716,"node_id":"MDQ6VXNlcjE5NDA1NzE2","avatar_url":"https://avatars3.githubusercontent.com/u/19405716?v=4","gravatar_id":"","url":"https://api.github.com/users/pkomanek","html_url":"https://github.com/pkomanek","followers_url":"https://api.github.com/users/pkomanek/followers","following_url":"https://api.github.com/users/pkomanek/following{/other_user}","gists_url":"https://api.github.com/users/pkomanek/gists{/gist_id}","starred_url":"https://api.github.com/users/pkomanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkomanek/subscriptions","organizations_url":"https://api.github.com/users/pkomanek/orgs","repos_url":"https://api.github.com/users/pkomanek/repos","events_url":"https://api.github.com/users/pkomanek/events{/privacy}","received_events_url":"https://api.github.com/users/pkomanek/received_events","type":"User","site_admin":false},"labels":[{"id":106615676,"node_id":"MDU6TGFiZWwxMDY2MTU2NzY=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-09T15:04:43Z","updated_at":"2018-07-09T15:15:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17679","html_url":"https://github.com/ManageIQ/manageiq/pull/17679","diff_url":"https://github.com/ManageIQ/manageiq/pull/17679.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17679.patch"},"body":"Calling the `generic_objects` method from the `service` model returns array of GenericObjects and nils(for allready destroyed objects), which makes some UI crashes. So we decided to remove a GO from all related services in the `#before_destroy` callback. This PR is based on the BZ bellow.\r\n\r\nLinks [Optional]\r\n----------------\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1595149\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/403514943","html_url":"https://github.com/ManageIQ/manageiq/pull/17679#issuecomment-403514943","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17679","id":403514943,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzUxNDk0Mw==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T15:15:57Z","updated_at":"2018-07-09T15:15:57Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/pkomanek/manageiq/compare/1301fd02de5832d700959fe2b9ea1f33604149d1~...6750575734370b4a7d6a155d8d284296806b40c4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n2 files checked, 0 offenses detected\nEverything looks fine. :+1:\n"}}
{"actor":{"display_login":"miq-bot"}}