{"action":"created","issue":{"url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/263","repository_url":"https://api.github.com/repos/captivationsoftware/react-sticky","labels_url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/263/comments","events_url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/263/events","html_url":"https://github.com/captivationsoftware/react-sticky/pull/263","id":380807391,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTE5Njc4","number":263,"title":"Support for non static sticky element","user":{"login":"zerubeus","id":6376307,"node_id":"MDQ6VXNlcjYzNzYzMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6376307?v=4","gravatar_id":"","url":"https://api.github.com/users/zerubeus","html_url":"https://github.com/zerubeus","followers_url":"https://api.github.com/users/zerubeus/followers","following_url":"https://api.github.com/users/zerubeus/following{/other_user}","gists_url":"https://api.github.com/users/zerubeus/gists{/gist_id}","starred_url":"https://api.github.com/users/zerubeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerubeus/subscriptions","organizations_url":"https://api.github.com/users/zerubeus/orgs","repos_url":"https://api.github.com/users/zerubeus/repos","events_url":"https://api.github.com/users/zerubeus/events{/privacy}","received_events_url":"https://api.github.com/users/zerubeus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T17:28:47Z","updated_at":"2018-11-16T19:06:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/captivationsoftware/react-sticky/pulls/263","html_url":"https://github.com/captivationsoftware/react-sticky/pull/263","diff_url":"https://github.com/captivationsoftware/react-sticky/pull/263.diff","patch_url":"https://github.com/captivationsoftware/react-sticky/pull/263.patch"},"body":"This is PR to add support for non static element, and adding tests to the CI: \r\n\r\n- It will fix flickering when the sticky element high changes\r\n- Gives the possibility to customize the sticky element depending on the isSticky state\r\n\r\nChanges :\r\n\r\n- Improve the doc\r\n- Refactor legacy context API\r\n- Remove Rafjs\r\n- Refactor legacy refs\r\n- Remove Mocka/Expect\r\n- Update  enzyme\r\n- Add Jest\r\n- Add test Coverage\r\n- Update to React/ReactDOM 16.6\r\n\r\nThis is a non breaking change if the library user support React 16.6"},"comment":{"url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/comments/439494793","html_url":"https://github.com/captivationsoftware/react-sticky/pull/263#issuecomment-439494793","issue_url":"https://api.github.com/repos/captivationsoftware/react-sticky/issues/263","id":439494793,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTQ5NDc5Mw==","user":{"login":"vcarl","id":1551487,"node_id":"MDQ6VXNlcjE1NTE0ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1551487?v=4","gravatar_id":"","url":"https://api.github.com/users/vcarl","html_url":"https://github.com/vcarl","followers_url":"https://api.github.com/users/vcarl/followers","following_url":"https://api.github.com/users/vcarl/following{/other_user}","gists_url":"https://api.github.com/users/vcarl/gists{/gist_id}","starred_url":"https://api.github.com/users/vcarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcarl/subscriptions","organizations_url":"https://api.github.com/users/vcarl/orgs","repos_url":"https://api.github.com/users/vcarl/repos","events_url":"https://api.github.com/users/vcarl/events{/privacy}","received_events_url":"https://api.github.com/users/vcarl/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T19:06:42Z","updated_at":"2018-11-16T19:06:42Z","author_association":"COLLABORATOR","body":"Could you split this up into multiple PRs? This is a LOT of changes to land in one go. Separate PRs for:\r\n\r\n* Doc changes\r\n* Refactor context\r\n* Remove raf.js\r\n* Legacy refs\r\n* Test changes (Mocha/expect, jest, enzyme, new tests)\r\n* Update react version. \r\n\r\nwould make it a lot easier to land some of these while others are discussed. Because the library lists React 15 as a peer-dep, many of these changes are breaking, so they'd have to be released as 7.0.0. I don't want to do that without also talking about other potential API changes to avoid unnecessary churn."}}
{"actor":{"display_login":"vcarl"}}