{"action":"opened","issue":{"url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/644","repository_url":"https://api.github.com/repos/micrometer-metrics/micrometer","labels_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/644/comments","events_url":"https://api.github.com/repos/micrometer-metrics/micrometer/issues/644/events","html_url":"https://github.com/micrometer-metrics/micrometer/issues/644","id":330023698,"node_id":"MDU6SXNzdWUzMzAwMjM2OTg=","number":644,"title":"Sanitise tag values on export","user":{"login":"nhmarujo","id":18704110,"node_id":"MDQ6VXNlcjE4NzA0MTEw","avatar_url":"https://avatars0.githubusercontent.com/u/18704110?v=4","gravatar_id":"","url":"https://api.github.com/users/nhmarujo","html_url":"https://github.com/nhmarujo","followers_url":"https://api.github.com/users/nhmarujo/followers","following_url":"https://api.github.com/users/nhmarujo/following{/other_user}","gists_url":"https://api.github.com/users/nhmarujo/gists{/gist_id}","starred_url":"https://api.github.com/users/nhmarujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhmarujo/subscriptions","organizations_url":"https://api.github.com/users/nhmarujo/orgs","repos_url":"https://api.github.com/users/nhmarujo/repos","events_url":"https://api.github.com/users/nhmarujo/events{/privacy}","received_events_url":"https://api.github.com/users/nhmarujo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-06T20:38:31Z","updated_at":"2018-06-06T20:38:31Z","closed_at":null,"author_association":"NONE","body":"I'm using **Spring Boot 2.0.1** and exporting my metrics to telegraf using **micrometer-registry-statsd**.\r\n\r\nThe pool name that I had configured for Hikari was a bit odd, being something like **poolname=abc::hikari** (some kind of weird hack to make it work as a tag on older metrics, that were exported by scollector).\r\n\r\nHaving special characters inside the tag value (like \"=\" or \":\") makes the telegraf parser raise some errors. Looking at telegraf logs I was able to see errors like, for instance:\r\n> E! Error: splitting '|', Unable to parse metric: hikaricp_connections_acquire,pool=poolName=abc::hikari:0.468846|ms\r\n\r\nRemoving the special characters solved the issue, however, I think it should be enforced that the tag values (and perhaps keys?) are sanitised before exported to telegraf (or whatever the flavor you are using)."}}
{"actor":{"display_login":"nhmarujo"}}