{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/comments/213659577","pull_request_review_id":150540132,"id":213659577,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzY1OTU3Nw==","diff_hunk":"@@ -207,7 +208,7 @@ new_node_joins_network(Cfg) ->\n     inject_spend_txs(old_node1, patron(), 5, 1, 100),\n     inject_spend_txs(old_node2, patron(), 5, 6, 100),\n \n-    wait_for_value({height, Length}, [old_node1, old_node2], Length * ?MINING_TIMEOUT, Cfg),\n+    wait_for_value({height, Length + 1}, [old_node1, old_node2], Length * ?MINING_TIMEOUT, Cfg),","path":"system_test/aest_sync_SUITE.erl","position":13,"original_position":13,"commit_id":"d467e33de9b3dc978b8a016200fae8117fa756d8","original_commit_id":"d467e33de9b3dc978b8a016200fae8117fa756d8","user":{"login":"ThomasArts","id":638015,"node_id":"MDQ6VXNlcjYzODAxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/638015?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasArts","html_url":"https://github.com/ThomasArts","followers_url":"https://api.github.com/users/ThomasArts/followers","following_url":"https://api.github.com/users/ThomasArts/following{/other_user}","gists_url":"https://api.github.com/users/ThomasArts/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasArts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasArts/subscriptions","organizations_url":"https://api.github.com/users/ThomasArts/orgs","repos_url":"https://api.github.com/users/ThomasArts/repos","events_url":"https://api.github.com/users/ThomasArts/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasArts/received_events","type":"User","site_admin":false},"body":"Micro forks. If we stop and check just after the height has been reached, it may well be that a little micro-block is discarded and hence hashes are different. We use this as common trick.\r\n","created_at":"2018-08-29T12:41:55Z","updated_at":"2018-08-29T12:41:55Z","html_url":"https://github.com/aeternity/epoch/pull/1499#discussion_r213659577","pull_request_url":"https://api.github.com/repos/aeternity/epoch/pulls/1499","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments/213659577"},"html":{"href":"https://github.com/aeternity/epoch/pull/1499#discussion_r213659577"},"pull_request":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1499"}},"in_reply_to_id":213658686},"pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/1499","id":211724442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzI0NDQy","html_url":"https://github.com/aeternity/epoch/pull/1499","diff_url":"https://github.com/aeternity/epoch/pull/1499.diff","patch_url":"https://github.com/aeternity/epoch/pull/1499.patch","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/1499","number":1499,"state":"open","locked":false,"title":"Pt 160124549 adapt system tests for api 3","user":{"login":"ThomasArts","id":638015,"node_id":"MDQ6VXNlcjYzODAxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/638015?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasArts","html_url":"https://github.com/ThomasArts","followers_url":"https://api.github.com/users/ThomasArts/followers","following_url":"https://api.github.com/users/ThomasArts/following{/other_user}","gists_url":"https://api.github.com/users/ThomasArts/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasArts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasArts/subscriptions","organizations_url":"https://api.github.com/users/ThomasArts/orgs","repos_url":"https://api.github.com/users/ThomasArts/repos","events_url":"https://api.github.com/users/ThomasArts/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasArts/received_events","type":"User","site_admin":false},"body":"Need to rebase only last commit to master when PR1487 merged","created_at":"2018-08-29T11:48:19Z","updated_at":"2018-08-29T12:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e79636e8397d5e669a81cdc02fb1939285ed2745","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/epoch/pulls/1499/commits","review_comments_url":"https://api.github.com/repos/aeternity/epoch/pulls/1499/comments","review_comment_url":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/1499/comments","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/d467e33de9b3dc978b8a016200fae8117fa756d8","head":{"label":"aeternity:PT-160124549-adapt-system-tests-for-api-3","ref":"PT-160124549-adapt-system-tests-for-api-3","sha":"d467e33de9b3dc978b8a016200fae8117fa756d8","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-08-29T12:19:13Z","pushed_at":"2018-08-29T12:41:03Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":9504,"stargazers_count":644,"watchers_count":644,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":112,"open_issues":16,"watchers":644,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"d347f58b0e0d5180e871456b5ab31ebf5d1935a1","user":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"node_id":"MDEwOlJlcG9zaXRvcnk5OTgwMjAzNg==","name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxOTg5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2018-08-29T12:19:13Z","pushed_at":"2018-08-29T12:41:03Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":9504,"stargazers_count":644,"watchers_count":644,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":112,"open_issues":16,"watchers":644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1499"},"html":{"href":"https://github.com/aeternity/epoch/pull/1499"},"issue":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1499"},"comments":{"href":"https://api.github.com/repos/aeternity/epoch/issues/1499/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1499/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/1499/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/epoch/statuses/d467e33de9b3dc978b8a016200fae8117fa756d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ThomasArts"}}