{"action":"created","issue":{"url":"https://api.github.com/repos/Smithay/client-toolkit/issues/12","repository_url":"https://api.github.com/repos/Smithay/client-toolkit","labels_url":"https://api.github.com/repos/Smithay/client-toolkit/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/Smithay/client-toolkit/issues/12/comments","events_url":"https://api.github.com/repos/Smithay/client-toolkit/issues/12/events","html_url":"https://github.com/Smithay/client-toolkit/pull/12","id":340635128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTk5MDU0","number":12,"title":"Seperate header bar and top border","user":{"login":"trimental","id":40879396,"node_id":"MDQ6VXNlcjQwODc5Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/40879396?v=4","gravatar_id":"","url":"https://api.github.com/users/trimental","html_url":"https://github.com/trimental","followers_url":"https://api.github.com/users/trimental/followers","following_url":"https://api.github.com/users/trimental/following{/other_user}","gists_url":"https://api.github.com/users/trimental/gists{/gist_id}","starred_url":"https://api.github.com/users/trimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trimental/subscriptions","organizations_url":"https://api.github.com/users/trimental/orgs","repos_url":"https://api.github.com/users/trimental/repos","events_url":"https://api.github.com/users/trimental/events{/privacy}","received_events_url":"https://api.github.com/users/trimental/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-12T13:20:53Z","updated_at":"2018-07-12T14:02:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Smithay/client-toolkit/pulls/12","html_url":"https://github.com/Smithay/client-toolkit/pull/12","diff_url":"https://github.com/Smithay/client-toolkit/pull/12.diff","patch_url":"https://github.com/Smithay/client-toolkit/pull/12.patch"},"body":"### Changes\r\n* Added a header bar part to basic frame and made top a border piece above the header bar for resizing\r\n* Change the way the buttons are laid out so that changes to the HEADER_SIZE (DECORATION_TOP_SIZE) or BORDER_SIZE (DECORATION_SIZE) don't effect their layout\r\n* Rename DECORATION_SIZE and DECORATION_TOP_SIZE as they are very similar, long and slightly unclear\r\n* Border size is set to 12 to match the similar distance that gtk has\r\n* I ran a cargo fmt just on basic_frame.rs\r\n\r\n### Effects\r\n* The header bar size and border size can now be any value without unintended effect to the window (they can be set instead of const if wanted)\r\n* The header bar can be better and properly sized from the top at all header bar sizes\r\n\r\nI wasn't sure whether this was changelog worthy so I didn't add it but these changes do slightly change the way the window is resized from the top so I can put in the changelog if you want."},"comment":{"url":"https://api.github.com/repos/Smithay/client-toolkit/issues/comments/404522774","html_url":"https://github.com/Smithay/client-toolkit/pull/12#issuecomment-404522774","issue_url":"https://api.github.com/repos/Smithay/client-toolkit/issues/12","id":404522774,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDUyMjc3NA==","user":{"login":"trimental","id":40879396,"node_id":"MDQ6VXNlcjQwODc5Mzk2","avatar_url":"https://avatars0.githubusercontent.com/u/40879396?v=4","gravatar_id":"","url":"https://api.github.com/users/trimental","html_url":"https://github.com/trimental","followers_url":"https://api.github.com/users/trimental/followers","following_url":"https://api.github.com/users/trimental/following{/other_user}","gists_url":"https://api.github.com/users/trimental/gists{/gist_id}","starred_url":"https://api.github.com/users/trimental/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trimental/subscriptions","organizations_url":"https://api.github.com/users/trimental/orgs","repos_url":"https://api.github.com/users/trimental/repos","events_url":"https://api.github.com/users/trimental/events{/privacy}","received_events_url":"https://api.github.com/users/trimental/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T14:02:03Z","updated_at":"2018-07-12T14:02:03Z","author_association":"CONTRIBUTOR","body":"![screenshot from 2018-07-12 22-00-09](https://user-images.githubusercontent.com/40879396/42638001-16a3497c-861f-11e8-96fd-908824d8e59e.png)\r\n\r\nstrange works for me and a git pull says I'm upto date, does this happen just on image viewer? can you try selection"}}
{"actor":{"display_login":"trimental"}}