{"action":"created","comment":{"url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/comments/233638538","pull_request_review_id":175101495,"id":233638538,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYzODUzOA==","diff_hunk":"@@ -1,21 +1,24 @@\n \n const routes = [\n   {\n-    path: '/',\n+    path: '/'\n+  },\n+  {\n+    path: '/:locale',\n     name: 'home'\n   },\n   {\n-    path: '/login',\n+    path: '/:locale/login',","path":"packages/auth/src/router/routes.js","position":13,"original_position":13,"commit_id":"e0c73360e82c0d09b103675447454d16e7b2d71c","original_commit_id":"e0c73360e82c0d09b103675447454d16e7b2d71c","user":{"login":"gregory-latinier","id":13222767,"node_id":"MDQ6VXNlcjEzMjIyNzY3","avatar_url":"https://avatars3.githubusercontent.com/u/13222767?v=4","gravatar_id":"","url":"https://api.github.com/users/gregory-latinier","html_url":"https://github.com/gregory-latinier","followers_url":"https://api.github.com/users/gregory-latinier/followers","following_url":"https://api.github.com/users/gregory-latinier/following{/other_user}","gists_url":"https://api.github.com/users/gregory-latinier/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory-latinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory-latinier/subscriptions","organizations_url":"https://api.github.com/users/gregory-latinier/orgs","repos_url":"https://api.github.com/users/gregory-latinier/repos","events_url":"https://api.github.com/users/gregory-latinier/events{/privacy}","received_events_url":"https://api.github.com/users/gregory-latinier/received_events","type":"User","site_admin":false},"body":"Move the :locale to the parent. \r\nCheck the develop branch, it's already been done","created_at":"2018-11-14T22:05:11Z","updated_at":"2018-11-14T22:06:29Z","html_url":"https://github.com/utopian-io/v2.utopian.io/pull/145#discussion_r233638538","pull_request_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/comments/233638538"},"html":{"href":"https://github.com/utopian-io/v2.utopian.io/pull/145#discussion_r233638538"},"pull_request":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145","id":230988691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTg4Njkx","html_url":"https://github.com/utopian-io/v2.utopian.io/pull/145","diff_url":"https://github.com/utopian-io/v2.utopian.io/pull/145.diff","patch_url":"https://github.com/utopian-io/v2.utopian.io/pull/145.patch","issue_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/145","number":145,"state":"open","locked":false,"title":"[UT-418] - Auth i18n","user":{"login":"icaroharry","id":6475893,"node_id":"MDQ6VXNlcjY0NzU4OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/6475893?v=4","gravatar_id":"","url":"https://api.github.com/users/icaroharry","html_url":"https://github.com/icaroharry","followers_url":"https://api.github.com/users/icaroharry/followers","following_url":"https://api.github.com/users/icaroharry/following{/other_user}","gists_url":"https://api.github.com/users/icaroharry/gists{/gist_id}","starred_url":"https://api.github.com/users/icaroharry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icaroharry/subscriptions","organizations_url":"https://api.github.com/users/icaroharry/orgs","repos_url":"https://api.github.com/users/icaroharry/repos","events_url":"https://api.github.com/users/icaroharry/events{/privacy}","received_events_url":"https://api.github.com/users/icaroharry/received_events","type":"User","site_admin":false},"body":"### Verify that\r\n- [x] the branch name follows the git flow naming convention (feature/i18n)\r\n- [ ] the UT reference is appended to the branch name if it concerns a Jira Task (feature/i18n/UT-283)\r\n- [x] the design is responsive\r\n- [x] the code doesn't break Server Side Rendering\r\n- [ ] new functions are prefixed with JSDoc information\r\n- [ ] the pull request contains unit tests for new code that passes and has at least 50% coverage\r\n- [x] the code doesn't break the api endpoints contract\r\n- [x] JS Standard code style has been verified with ESLint\r\n---\r\n\r\nThis PR implements the internationalization module in the Auth app.\r\n\r\nThe implementation was based in the client app code.\r\n\r\n### **Test plan**\r\n\r\n* Run the app\r\n* Go to `localhost:8080`\r\n* If you're signed in, sign out and click in 'sign in' again\r\n* Check that you were redirected to `localhost:8081/en/login`\r\n* Check the string label of the sign in button\r\n* Change the value of `auth.login.github` in the `i18n/locales_master/en.json` file and check that it updates the app\r\n* Finish the sign in and check that you were redirected and are logged in the app\r\n* Repeat the steps with German selected and check that the auth app is automatically set to German too.\r\n","created_at":"2018-11-14T21:32:05Z","updated_at":"2018-11-14T22:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2d0b8029ec0b0d4d23a7470a9bf2f69afdcf1b8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nothingismagick","id":35242872,"node_id":"MDQ6VXNlcjM1MjQyODcy","avatar_url":"https://avatars1.githubusercontent.com/u/35242872?v=4","gravatar_id":"","url":"https://api.github.com/users/nothingismagick","html_url":"https://github.com/nothingismagick","followers_url":"https://api.github.com/users/nothingismagick/followers","following_url":"https://api.github.com/users/nothingismagick/following{/other_user}","gists_url":"https://api.github.com/users/nothingismagick/gists{/gist_id}","starred_url":"https://api.github.com/users/nothingismagick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nothingismagick/subscriptions","organizations_url":"https://api.github.com/users/nothingismagick/orgs","repos_url":"https://api.github.com/users/nothingismagick/repos","events_url":"https://api.github.com/users/nothingismagick/events{/privacy}","received_events_url":"https://api.github.com/users/nothingismagick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145/commits","review_comments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145/comments","review_comment_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/145/comments","statuses_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/statuses/e0c73360e82c0d09b103675447454d16e7b2d71c","head":{"label":"utopian-io:feature/auth-i18n","ref":"feature/auth-i18n","sha":"e0c73360e82c0d09b103675447454d16e7b2d71c","user":{"login":"utopian-io","id":18612062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjEyMDYy","avatar_url":"https://avatars2.githubusercontent.com/u/18612062?v=4","gravatar_id":"","url":"https://api.github.com/users/utopian-io","html_url":"https://github.com/utopian-io","followers_url":"https://api.github.com/users/utopian-io/followers","following_url":"https://api.github.com/users/utopian-io/following{/other_user}","gists_url":"https://api.github.com/users/utopian-io/gists{/gist_id}","starred_url":"https://api.github.com/users/utopian-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utopian-io/subscriptions","organizations_url":"https://api.github.com/users/utopian-io/orgs","repos_url":"https://api.github.com/users/utopian-io/repos","events_url":"https://api.github.com/users/utopian-io/events{/privacy}","received_events_url":"https://api.github.com/users/utopian-io/received_events","type":"Organization","site_admin":false},"repo":{"id":136034748,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzQ3NDg=","name":"v2.utopian.io","full_name":"utopian-io/v2.utopian.io","private":false,"owner":{"login":"utopian-io","id":18612062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjEyMDYy","avatar_url":"https://avatars2.githubusercontent.com/u/18612062?v=4","gravatar_id":"","url":"https://api.github.com/users/utopian-io","html_url":"https://github.com/utopian-io","followers_url":"https://api.github.com/users/utopian-io/followers","following_url":"https://api.github.com/users/utopian-io/following{/other_user}","gists_url":"https://api.github.com/users/utopian-io/gists{/gist_id}","starred_url":"https://api.github.com/users/utopian-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utopian-io/subscriptions","organizations_url":"https://api.github.com/users/utopian-io/orgs","repos_url":"https://api.github.com/users/utopian-io/repos","events_url":"https://api.github.com/users/utopian-io/events{/privacy}","received_events_url":"https://api.github.com/users/utopian-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/utopian-io/v2.utopian.io","description":"Version 2 Of Utopian.io made with Vue.js and the Quasar Framework","fork":false,"url":"https://api.github.com/repos/utopian-io/v2.utopian.io","forks_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/forks","keys_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/teams","hooks_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/hooks","issue_events_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/events{/number}","events_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/events","assignees_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/assignees{/user}","branches_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/branches{/branch}","tags_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/tags","blobs_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/statuses/{sha}","languages_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/languages","stargazers_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/stargazers","contributors_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/contributors","subscribers_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/subscribers","subscription_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/subscription","commits_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/contents/{+path}","compare_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/merges","archive_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/downloads","issues_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues{/number}","pulls_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls{/number}","milestones_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/milestones{/number}","notifications_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/labels{/name}","releases_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/releases{/id}","deployments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/deployments","created_at":"2018-06-04T14:09:59Z","updated_at":"2018-11-14T21:56:05Z","pushed_at":"2018-11-14T21:56:05Z","git_url":"git://github.com/utopian-io/v2.utopian.io.git","ssh_url":"git@github.com:utopian-io/v2.utopian.io.git","clone_url":"https://github.com/utopian-io/v2.utopian.io.git","svn_url":"https://github.com/utopian-io/v2.utopian.io","homepage":null,"size":6066,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":6,"watchers":32,"default_branch":"develop"}},"base":{"label":"utopian-io:develop","ref":"develop","sha":"c6f34c7633f96e1cd3f00da67defb3e3b569c5a8","user":{"login":"utopian-io","id":18612062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjEyMDYy","avatar_url":"https://avatars2.githubusercontent.com/u/18612062?v=4","gravatar_id":"","url":"https://api.github.com/users/utopian-io","html_url":"https://github.com/utopian-io","followers_url":"https://api.github.com/users/utopian-io/followers","following_url":"https://api.github.com/users/utopian-io/following{/other_user}","gists_url":"https://api.github.com/users/utopian-io/gists{/gist_id}","starred_url":"https://api.github.com/users/utopian-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utopian-io/subscriptions","organizations_url":"https://api.github.com/users/utopian-io/orgs","repos_url":"https://api.github.com/users/utopian-io/repos","events_url":"https://api.github.com/users/utopian-io/events{/privacy}","received_events_url":"https://api.github.com/users/utopian-io/received_events","type":"Organization","site_admin":false},"repo":{"id":136034748,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzQ3NDg=","name":"v2.utopian.io","full_name":"utopian-io/v2.utopian.io","private":false,"owner":{"login":"utopian-io","id":18612062,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjEyMDYy","avatar_url":"https://avatars2.githubusercontent.com/u/18612062?v=4","gravatar_id":"","url":"https://api.github.com/users/utopian-io","html_url":"https://github.com/utopian-io","followers_url":"https://api.github.com/users/utopian-io/followers","following_url":"https://api.github.com/users/utopian-io/following{/other_user}","gists_url":"https://api.github.com/users/utopian-io/gists{/gist_id}","starred_url":"https://api.github.com/users/utopian-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utopian-io/subscriptions","organizations_url":"https://api.github.com/users/utopian-io/orgs","repos_url":"https://api.github.com/users/utopian-io/repos","events_url":"https://api.github.com/users/utopian-io/events{/privacy}","received_events_url":"https://api.github.com/users/utopian-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/utopian-io/v2.utopian.io","description":"Version 2 Of Utopian.io made with Vue.js and the Quasar Framework","fork":false,"url":"https://api.github.com/repos/utopian-io/v2.utopian.io","forks_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/forks","keys_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/teams","hooks_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/hooks","issue_events_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/events{/number}","events_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/events","assignees_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/assignees{/user}","branches_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/branches{/branch}","tags_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/tags","blobs_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/statuses/{sha}","languages_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/languages","stargazers_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/stargazers","contributors_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/contributors","subscribers_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/subscribers","subscription_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/subscription","commits_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/contents/{+path}","compare_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/merges","archive_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/downloads","issues_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues{/number}","pulls_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls{/number}","milestones_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/milestones{/number}","notifications_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/labels{/name}","releases_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/releases{/id}","deployments_url":"https://api.github.com/repos/utopian-io/v2.utopian.io/deployments","created_at":"2018-06-04T14:09:59Z","updated_at":"2018-11-14T21:56:05Z","pushed_at":"2018-11-14T21:56:05Z","git_url":"git://github.com/utopian-io/v2.utopian.io.git","ssh_url":"git@github.com:utopian-io/v2.utopian.io.git","clone_url":"https://github.com/utopian-io/v2.utopian.io.git","svn_url":"https://github.com/utopian-io/v2.utopian.io","homepage":null,"size":6066,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":6,"watchers":32,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145"},"html":{"href":"https://github.com/utopian-io/v2.utopian.io/pull/145"},"issue":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/145"},"comments":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/utopian-io/v2.utopian.io/statuses/e0c73360e82c0d09b103675447454d16e7b2d71c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gregory-latinier"}}