{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/nteract/pulls/comments/236029495","pull_request_review_id":178037145,"id":236029495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAyOTQ5NQ==","diff_hunk":"@@ -7,7 +6,7 @@ import \"codemirror/mode/python/python\";\n \n CodeMirror.defineMode(","path":"packages/editor/src/mode/ipython.ts","position":7,"original_position":7,"commit_id":"ad7e70cc23a504c2950389d0bdeb55ce80f68cfc","original_commit_id":"ad7e70cc23a504c2950389d0bdeb55ce80f68cfc","user":{"login":"captainsafia","id":1857993,"node_id":"MDQ6VXNlcjE4NTc5OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1857993?v=4","gravatar_id":"","url":"https://api.github.com/users/captainsafia","html_url":"https://github.com/captainsafia","followers_url":"https://api.github.com/users/captainsafia/followers","following_url":"https://api.github.com/users/captainsafia/following{/other_user}","gists_url":"https://api.github.com/users/captainsafia/gists{/gist_id}","starred_url":"https://api.github.com/users/captainsafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainsafia/subscriptions","organizations_url":"https://api.github.com/users/captainsafia/orgs","repos_url":"https://api.github.com/users/captainsafia/repos","events_url":"https://api.github.com/users/captainsafia/events{/privacy}","received_events_url":"https://api.github.com/users/captainsafia/received_events","type":"User","site_admin":false},"body":"The code that we have here doesn't match the definition of `defineMode` in the CodeMirror library. We're passing 3 arguments when this function only expects two.\r\n\r\nAlso, there is no `defineMIME` function in the CodeMirror library.","created_at":"2018-11-24T01:39:42Z","updated_at":"2018-11-24T01:39:43Z","html_url":"https://github.com/nteract/nteract/pull/3691#discussion_r236029495","pull_request_url":"https://api.github.com/repos/nteract/nteract/pulls/3691","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments/236029495"},"html":{"href":"https://github.com/nteract/nteract/pull/3691#discussion_r236029495"},"pull_request":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3691"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/3691","id":233294902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjk0OTAy","html_url":"https://github.com/nteract/nteract/pull/3691","diff_url":"https://github.com/nteract/nteract/pull/3691.diff","patch_url":"https://github.com/nteract/nteract/pull/3691.patch","issue_url":"https://api.github.com/repos/nteract/nteract/issues/3691","number":3691,"state":"open","locked":false,"title":"[WIP] Migrate Editor to TypeScript","user":{"login":"captainsafia","id":1857993,"node_id":"MDQ6VXNlcjE4NTc5OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1857993?v=4","gravatar_id":"","url":"https://api.github.com/users/captainsafia","html_url":"https://github.com/captainsafia","followers_url":"https://api.github.com/users/captainsafia/followers","following_url":"https://api.github.com/users/captainsafia/following{/other_user}","gists_url":"https://api.github.com/users/captainsafia/gists{/gist_id}","starred_url":"https://api.github.com/users/captainsafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captainsafia/subscriptions","organizations_url":"https://api.github.com/users/captainsafia/orgs","repos_url":"https://api.github.com/users/captainsafia/repos","events_url":"https://api.github.com/users/captainsafia/events{/privacy}","received_events_url":"https://api.github.com/users/captainsafia/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-24T01:37:54Z","updated_at":"2018-11-24T01:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dfdd646d1308bddde3675d71ac57d507ae80af1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/nteract/pulls/3691/commits","review_comments_url":"https://api.github.com/repos/nteract/nteract/pulls/3691/comments","review_comment_url":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/3691/comments","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/ad7e70cc23a504c2950389d0bdeb55ce80f68cfc","head":{"label":"nteract:safia/nov/editor-ts","ref":"safia/nov/editor-ts","sha":"ad7e70cc23a504c2950389d0bdeb55ce80f68cfc","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 The interactive computing suite for you!  ✨","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2018-11-23T17:45:51Z","pushed_at":"2018-11-24T01:37:54Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":20347,"stargazers_count":3320,"watchers_count":3320,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":327,"open_issues":387,"watchers":3320,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"8ad0263f22f4801f0517afc443ab0744816ad039","user":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ5NjUyMQ==","name":"nteract","full_name":"nteract/nteract","private":false,"owner":{"login":"nteract","id":12401040,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDAxMDQw","avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nteract/nteract","description":"📘 The interactive computing suite for you!  ✨","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2018-11-23T17:45:51Z","pushed_at":"2018-11-24T01:37:54Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":20347,"stargazers_count":3320,"watchers_count":3320,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":327,"open_issues":387,"watchers":3320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3691"},"html":{"href":"https://github.com/nteract/nteract/pull/3691"},"issue":{"href":"https://api.github.com/repos/nteract/nteract/issues/3691"},"comments":{"href":"https://api.github.com/repos/nteract/nteract/issues/3691/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3691/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/nteract/pulls/3691/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/nteract/statuses/ad7e70cc23a504c2950389d0bdeb55ce80f68cfc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"captainsafia"}}