{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/218637650","pull_request_review_id":156620871,"id":218637650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODYzNzY1MA==","diff_hunk":"@@ -103,12 +103,12 @@ trait OapStrategies extends Logging {\n         limit: Int,\n         order: Seq[SortOrder]): SparkPlan = child match {\n       case PhysicalOperation(projectList, filters,\n-        relation @ LogicalRelation(\n-          file @ HadoopFsRelation(_, _, _, _, _ : OapFileFormat, _), _, table)) =>\n+        relation : LogicalRelation) =>","path":"src/main/scala/org/apache/spark/sql/execution/datasources/oap/OapStrategies.scala","position":6,"original_position":6,"commit_id":"36192abcd8096213a7388d1653070d62ea174f4d","original_commit_id":"b13b04a4755441142e305c1e9765dd7a99fcda31","user":{"login":"zhixingheyi-tian","id":41657774,"node_id":"MDQ6VXNlcjQxNjU3Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/41657774?v=4","gravatar_id":"","url":"https://api.github.com/users/zhixingheyi-tian","html_url":"https://github.com/zhixingheyi-tian","followers_url":"https://api.github.com/users/zhixingheyi-tian/followers","following_url":"https://api.github.com/users/zhixingheyi-tian/following{/other_user}","gists_url":"https://api.github.com/users/zhixingheyi-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/zhixingheyi-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhixingheyi-tian/subscriptions","organizations_url":"https://api.github.com/users/zhixingheyi-tian/orgs","repos_url":"https://api.github.com/users/zhixingheyi-tian/repos","events_url":"https://api.github.com/users/zhixingheyi-tian/events{/privacy}","received_events_url":"https://api.github.com/users/zhixingheyi-tian/received_events","type":"User","site_admin":false},"body":"@carsonwang \r\nHas made changes.\r\nThanks.","created_at":"2018-09-19T00:40:46Z","updated_at":"2018-09-19T00:40:46Z","html_url":"https://github.com/Intel-bigdata/OAP/pull/850#discussion_r218637650","pull_request_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/218637650"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/850#discussion_r218637650"},"pull_request":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850"}},"in_reply_to_id":217937891},"pull_request":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850","id":210429856,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDI5ODU2","html_url":"https://github.com/Intel-bigdata/OAP/pull/850","diff_url":"https://github.com/Intel-bigdata/OAP/pull/850.diff","patch_url":"https://github.com/Intel-bigdata/OAP/pull/850.patch","issue_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/850","number":850,"state":"open","locked":false,"title":"[support spark2.3] All changed code files generated to support \"spark 2.3\"","user":{"login":"zhixingheyi-tian","id":41657774,"node_id":"MDQ6VXNlcjQxNjU3Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/41657774?v=4","gravatar_id":"","url":"https://api.github.com/users/zhixingheyi-tian","html_url":"https://github.com/zhixingheyi-tian","followers_url":"https://api.github.com/users/zhixingheyi-tian/followers","following_url":"https://api.github.com/users/zhixingheyi-tian/following{/other_user}","gists_url":"https://api.github.com/users/zhixingheyi-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/zhixingheyi-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhixingheyi-tian/subscriptions","organizations_url":"https://api.github.com/users/zhixingheyi-tian/orgs","repos_url":"https://api.github.com/users/zhixingheyi-tian/repos","events_url":"https://api.github.com/users/zhixingheyi-tian/events{/privacy}","received_events_url":"https://api.github.com/users/zhixingheyi-tian/received_events","type":"User","site_admin":false},"body":"remaining  codes  to  support spark2.3\r\n\r\n\"Adapter\" classes, which are classes set to fit multiple versions of spark\r\nAbout the \"Adapter\" classes：\r\nNew \"Adapter\" class files:\r\n./src/main/spark2.1/scala/org/apache/spark/sql/oap/adapter/ColumnVectorAdapter.scala\r\n./src/main/spark2.1/scala/org/apache/spark/sql/oap/adapter/TaskContextImplAdapter.scala\r\n./src/main/spark2.1/scala/org/apache/spark/sql/oap/adapter/CapacityAdapter.scala\r\n./src/main/spark2.2/scala/org/apache/spark/sql/oap/adapter/ColumnVectorAdapter.scala\r\n./src/main/spark2.2/scala/org/apache/spark/sql/oap/adapter/TaskContextImplAdapter.scala\r\n./src/main/spark2.2/scala/org/apache/spark/sql/oap/adapter/CapacityAdapter.scala\r\n./src/main/spark2.3/scala/org/apache/spark/sql/oap/adapter/ColumnVectorAdapter.scala\r\n./src/main/spark2.3/scala/org/apache/spark/sql/oap/adapter/TaskContextImplAdapter.scala\r\n./src/main/spark2.3/scala/org/apache/spark/sql/oap/adapter/CapacityAdapter.scala\r\n./src/test/spark2.1/scala/org/apache/spark/sql/execution/datasources/oap/adapter/PropertiesAdapter.scala\r\n./src/test/spark2.1/scala/org/apache/spark/sql/execution/datasources/oap/adapter/WholeStageCodeGenAdapter.scala\r\n./src/test/spark2.2/scala/org/apache/spark/sql/execution/datasources/adapter/PropertiesAdapter.scala\r\n./src/test/spark2.2/scala/org/apache/spark/sql/execution/datasources/adapter/WholeStageCodeGenAdapter.scala\r\n./src/test/spark2.3/scala/org/apache/spark/sql/execution/datasources/oap/adapter/PropertiesAdapter.scala\r\n./src/test/spark2.3/scala/org/apache/spark/sql/execution/datasources/oap/adapter/WholeStageCodeGenAdapter.scala\r\n\r\nchanged \"Adapter\" class files:\r\n./src/main/spark2.1/scala/org/apache/spark/sql/oap/adapter/SqlConfAdapter.scala\r\n./src/main/spark2.2/scala/org/apache/spark/sql/oap/adapter/SqlConfAdapter.scala\r\n./src/main/spark2.3/scala/org/apache/spark/sql/oap/adapter/SqlConfAdapter.scala\r\n./src/main/spark2.3/scala/org/apache/spark/sql/oap/adapter/LogicalPlanAdapter.scala\r\n\r\nOther \"Adapter\" class files in spark2.3 can be ignored during review .This is because they copied directly from the spark 2.2 directory.\r\n\r\n\r\nCode files that produce \"diff\" can be reviewed directly, mostly because of the adaptation of the \"Adapter\" class.\r\n\r\nThe last remaining code can be ignored during review\r\n\r\nmvn test -Pspark-2.1 pass\r\nmvn test -Pspark-2.2 pass\r\nmvn test -Pspark-2.3 pass\r\n\r\nThanks!\r\n","created_at":"2018-08-23T12:24:22Z","updated_at":"2018-09-19T00:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a08b6f259e03db96dcb5d5f10241e94dbccb57dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850/commits","review_comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850/comments","review_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/850/comments","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/36192abcd8096213a7388d1653070d62ea174f4d","head":{"label":"zhixingheyi-tian:spark2.3-support-importCodeChanges","ref":"spark2.3-support-importCodeChanges","sha":"36192abcd8096213a7388d1653070d62ea174f4d","user":{"login":"zhixingheyi-tian","id":41657774,"node_id":"MDQ6VXNlcjQxNjU3Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/41657774?v=4","gravatar_id":"","url":"https://api.github.com/users/zhixingheyi-tian","html_url":"https://github.com/zhixingheyi-tian","followers_url":"https://api.github.com/users/zhixingheyi-tian/followers","following_url":"https://api.github.com/users/zhixingheyi-tian/following{/other_user}","gists_url":"https://api.github.com/users/zhixingheyi-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/zhixingheyi-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhixingheyi-tian/subscriptions","organizations_url":"https://api.github.com/users/zhixingheyi-tian/orgs","repos_url":"https://api.github.com/users/zhixingheyi-tian/repos","events_url":"https://api.github.com/users/zhixingheyi-tian/events{/privacy}","received_events_url":"https://api.github.com/users/zhixingheyi-tian/received_events","type":"User","site_admin":false},"repo":{"id":145079512,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwNzk1MTI=","name":"OAP","full_name":"zhixingheyi-tian/OAP","private":false,"owner":{"login":"zhixingheyi-tian","id":41657774,"node_id":"MDQ6VXNlcjQxNjU3Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/41657774?v=4","gravatar_id":"","url":"https://api.github.com/users/zhixingheyi-tian","html_url":"https://github.com/zhixingheyi-tian","followers_url":"https://api.github.com/users/zhixingheyi-tian/followers","following_url":"https://api.github.com/users/zhixingheyi-tian/following{/other_user}","gists_url":"https://api.github.com/users/zhixingheyi-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/zhixingheyi-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhixingheyi-tian/subscriptions","organizations_url":"https://api.github.com/users/zhixingheyi-tian/orgs","repos_url":"https://api.github.com/users/zhixingheyi-tian/repos","events_url":"https://api.github.com/users/zhixingheyi-tian/events{/privacy}","received_events_url":"https://api.github.com/users/zhixingheyi-tian/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhixingheyi-tian/OAP","description":"Optimized Analytics Package for Spark Platform","fork":true,"url":"https://api.github.com/repos/zhixingheyi-tian/OAP","forks_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/forks","keys_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/teams","hooks_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/hooks","issue_events_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/events","assignees_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/tags","blobs_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/languages","stargazers_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/stargazers","contributors_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/contributors","subscribers_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/subscribers","subscription_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/subscription","commits_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/merges","archive_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/downloads","issues_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/labels{/name}","releases_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/zhixingheyi-tian/OAP/deployments","created_at":"2018-08-17T06:12:33Z","updated_at":"2018-08-17T06:12:37Z","pushed_at":"2018-09-18T07:13:59Z","git_url":"git://github.com/zhixingheyi-tian/OAP.git","ssh_url":"git@github.com:zhixingheyi-tian/OAP.git","clone_url":"https://github.com/zhixingheyi-tian/OAP.git","svn_url":"https://github.com/zhixingheyi-tian/OAP","homepage":"","size":137488,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-bigdata:master","ref":"master","sha":"b56f4241259379e40ea51514d4dc3ab46fb6f9ec","user":{"login":"Intel-bigdata","id":8433081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzMwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"repo":{"id":54008218,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAwODIxOA==","name":"OAP","full_name":"Intel-bigdata/OAP","private":false,"owner":{"login":"Intel-bigdata","id":8433081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzMwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Intel-bigdata/OAP","description":"Optimized Analytics Package for Spark Platform","fork":false,"url":"https://api.github.com/repos/Intel-bigdata/OAP","forks_url":"https://api.github.com/repos/Intel-bigdata/OAP/forks","keys_url":"https://api.github.com/repos/Intel-bigdata/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-bigdata/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-bigdata/OAP/teams","hooks_url":"https://api.github.com/repos/Intel-bigdata/OAP/hooks","issue_events_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-bigdata/OAP/events","assignees_url":"https://api.github.com/repos/Intel-bigdata/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-bigdata/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/tags","blobs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-bigdata/OAP/languages","stargazers_url":"https://api.github.com/repos/Intel-bigdata/OAP/stargazers","contributors_url":"https://api.github.com/repos/Intel-bigdata/OAP/contributors","subscribers_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscribers","subscription_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscription","commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-bigdata/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-bigdata/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-bigdata/OAP/merges","archive_url":"https://api.github.com/repos/Intel-bigdata/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-bigdata/OAP/downloads","issues_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-bigdata/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-bigdata/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-bigdata/OAP/labels{/name}","releases_url":"https://api.github.com/repos/Intel-bigdata/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-bigdata/OAP/deployments","created_at":"2016-03-16T06:56:47Z","updated_at":"2018-09-18T07:27:10Z","pushed_at":"2018-09-18T07:19:45Z","git_url":"git://github.com/Intel-bigdata/OAP.git","ssh_url":"git@github.com:Intel-bigdata/OAP.git","clone_url":"https://github.com/Intel-bigdata/OAP.git","svn_url":"https://github.com/Intel-bigdata/OAP","homepage":"","size":137370,"stargazers_count":146,"watchers_count":146,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":102,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/850"},"issue":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/850"},"comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/36192abcd8096213a7388d1653070d62ea174f4d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zhixingheyi-tian"}}