{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-client/java/issues/412","repository_url":"https://api.github.com/repos/kubernetes-client/java","labels_url":"https://api.github.com/repos/kubernetes-client/java/issues/412/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-client/java/issues/412/comments","events_url":"https://api.github.com/repos/kubernetes-client/java/issues/412/events","html_url":"https://github.com/kubernetes-client/java/pull/412","id":376827995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTUwNTk3","number":412,"title":"Add merge in ProtoClient","user":{"login":"TwinProduction","id":15699766,"node_id":"MDQ6VXNlcjE1Njk5NzY2","avatar_url":"https://avatars1.githubusercontent.com/u/15699766?v=4","gravatar_id":"","url":"https://api.github.com/users/TwinProduction","html_url":"https://github.com/TwinProduction","followers_url":"https://api.github.com/users/TwinProduction/followers","following_url":"https://api.github.com/users/TwinProduction/following{/other_user}","gists_url":"https://api.github.com/users/TwinProduction/gists{/gist_id}","starred_url":"https://api.github.com/users/TwinProduction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwinProduction/subscriptions","organizations_url":"https://api.github.com/users/TwinProduction/orgs","repos_url":"https://api.github.com/users/TwinProduction/repos","events_url":"https://api.github.com/users/TwinProduction/events{/privacy}","received_events_url":"https://api.github.com/users/TwinProduction/received_events","type":"User","site_admin":false},"labels":[{"id":969049085,"node_id":"MDU6TGFiZWw5NjkwNDkwODU=","url":"https://api.github.com/repos/kubernetes-client/java/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":971528370,"node_id":"MDU6TGFiZWw5NzE1MjgzNzA=","url":"https://api.github.com/repos/kubernetes-client/java/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-02T14:16:50Z","updated_at":"2018-11-05T04:37:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes-client/java/pulls/412","html_url":"https://github.com/kubernetes-client/java/pull/412","diff_url":"https://github.com/kubernetes-client/java/pull/412.diff","patch_url":"https://github.com/kubernetes-client/java/pull/412.patch"},"body":"`ProtoClient.update(...)` uses PUT, but really, it replaces the existing resource with the given name by the resource passed as parameter `obj`. It shouldn't have been named `update`, but instead, it should have been named `replace` for clarity. \r\n\r\n[reference](https://kubernetes.io/docs/reference/federation/v1/operations/#_replace_the_specified_service)\r\n\r\nI didn't rename it regardless, because it would be a breaking change, but I did add the `merge(...)` method which uses `PATCH`, as I think it would be better to avoid using the `request(...)` method as much as possible for clarity."},"comment":{"url":"https://api.github.com/repos/kubernetes-client/java/issues/comments/435752980","html_url":"https://github.com/kubernetes-client/java/pull/412#issuecomment-435752980","issue_url":"https://api.github.com/repos/kubernetes-client/java/issues/412","id":435752980,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTc1Mjk4MA==","user":{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T04:37:20Z","updated_at":"2018-11-05T04:37:20Z","author_association":"COLLABORATOR","body":"/lgtm\r\n/approve"}}
{"actor":{"display_login":"brendandburns"}}