{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/185905129","pull_request_review_id":117390235,"id":185905129,"diff_hunk":"@@ -1253,31 +1261,77 @@ paths:\n         - ppm\n       parameters:\n         - in: query\n-          name: planned_move_date\n+          name: plannedMoveDate","path":"swagger/internal.yaml","position":22,"original_position":22,"commit_id":"99ace59b834fd9864406507d8ee557a731951d3e","original_commit_id":"99ace59b834fd9864406507d8ee557a731951d3e","user":{"login":"kilbergr","id":7401870,"avatar_url":"https://avatars3.githubusercontent.com/u/7401870?v=4","gravatar_id":"","url":"https://api.github.com/users/kilbergr","html_url":"https://github.com/kilbergr","followers_url":"https://api.github.com/users/kilbergr/followers","following_url":"https://api.github.com/users/kilbergr/following{/other_user}","gists_url":"https://api.github.com/users/kilbergr/gists{/gist_id}","starred_url":"https://api.github.com/users/kilbergr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilbergr/subscriptions","organizations_url":"https://api.github.com/users/kilbergr/orgs","repos_url":"https://api.github.com/users/kilbergr/repos","events_url":"https://api.github.com/users/kilbergr/events{/privacy}","received_events_url":"https://api.github.com/users/kilbergr/received_events","type":"User","site_admin":false},"body":"@ntwyman MacRae has confirmed the above.","created_at":"2018-05-03T19:01:13Z","updated_at":"2018-05-03T19:01:13Z","html_url":"https://github.com/transcom/mymove/pull/453#discussion_r185905129","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/453","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/185905129"},"html":{"href":"https://github.com/transcom/mymove/pull/453#discussion_r185905129"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/453"}},"in_reply_to_id":185842906},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/453","id":185587168,"html_url":"https://github.com/transcom/mymove/pull/453","diff_url":"https://github.com/transcom/mymove/pull/453.diff","patch_url":"https://github.com/transcom/mymove/pull/453.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/453","number":453,"state":"open","locked":false,"title":"Rek sit estimate backend","user":{"login":"kilbergr","id":7401870,"avatar_url":"https://avatars3.githubusercontent.com/u/7401870?v=4","gravatar_id":"","url":"https://api.github.com/users/kilbergr","html_url":"https://github.com/kilbergr","followers_url":"https://api.github.com/users/kilbergr/followers","following_url":"https://api.github.com/users/kilbergr/following{/other_user}","gists_url":"https://api.github.com/users/kilbergr/gists{/gist_id}","starred_url":"https://api.github.com/users/kilbergr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilbergr/subscriptions","organizations_url":"https://api.github.com/users/kilbergr/orgs","repos_url":"https://api.github.com/users/kilbergr/repos","events_url":"https://api.github.com/users/kilbergr/events{/privacy}","received_events_url":"https://api.github.com/users/kilbergr/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR includes : \r\n* Swagger definition for SIT estimation\r\n   * `GET` HTTP method\r\n   * URL is `/internal/estimates/ppm_sit` as specified by Pivotal\r\n* SIT PPM Estimation Handler, which:\r\n   * wraps `sitCharge()` and gets return value\r\n   *  Looks up SIT discount rate \r\n   * Applies inverse of SIT discount rate to sitCharge\r\n* Includes test for SIT PPM Estimation handler\r\n\r\nIt also:\r\n* addresses some discrepancies between PpmEstimate and PpmSitEstimate in swagger.\r\n* Applies a fix in nonlinehaul.go func sitCharge\r\n* Makes sitCharge an exported func\r\n* Makes zip5ToZip3 an exported func\r\n* Adds helper func `timeFromDateTime` to handle conversion of strfmt.DateTime to time.Time\r\n\r\n## Reviewer Notes\r\n\r\nIs there anything you would like reviewers to give additional scrutiny?\r\n\r\n## Code Review Verification Steps\r\n\r\n* [ ] All tests pass.\r\n* [ ] Code follows the guidelines for [Logging](https://github.com/transcom/mymove/blob/master/docs/backend.md#logging)\r\n* [ ] Request review from a member of a different team.\r\n* [ ] (TRIAL) Have the Pivotal acceptance criteria been met for this change?\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/157201059) for this change\r\n","created_at":"2018-05-02T23:32:26Z","updated_at":"2018-05-03T19:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a37fa5b126cecd052b00b8166f6c2196697e6474","assignee":null,"assignees":[],"requested_reviewers":[{"login":"macrael","id":55759,"avatar_url":"https://avatars1.githubusercontent.com/u/55759?v=4","gravatar_id":"","url":"https://api.github.com/users/macrael","html_url":"https://github.com/macrael","followers_url":"https://api.github.com/users/macrael/followers","following_url":"https://api.github.com/users/macrael/following{/other_user}","gists_url":"https://api.github.com/users/macrael/gists{/gist_id}","starred_url":"https://api.github.com/users/macrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macrael/subscriptions","organizations_url":"https://api.github.com/users/macrael/orgs","repos_url":"https://api.github.com/users/macrael/repos","events_url":"https://api.github.com/users/macrael/events{/privacy}","received_events_url":"https://api.github.com/users/macrael/received_events","type":"User","site_admin":false},{"login":"akostibas","id":859429,"avatar_url":"https://avatars2.githubusercontent.com/u/859429?v=4","gravatar_id":"","url":"https://api.github.com/users/akostibas","html_url":"https://github.com/akostibas","followers_url":"https://api.github.com/users/akostibas/followers","following_url":"https://api.github.com/users/akostibas/following{/other_user}","gists_url":"https://api.github.com/users/akostibas/gists{/gist_id}","starred_url":"https://api.github.com/users/akostibas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akostibas/subscriptions","organizations_url":"https://api.github.com/users/akostibas/orgs","repos_url":"https://api.github.com/users/akostibas/repos","events_url":"https://api.github.com/users/akostibas/events{/privacy}","received_events_url":"https://api.github.com/users/akostibas/received_events","type":"User","site_admin":false},{"login":"stangah","id":5151804,"avatar_url":"https://avatars1.githubusercontent.com/u/5151804?v=4","gravatar_id":"","url":"https://api.github.com/users/stangah","html_url":"https://github.com/stangah","followers_url":"https://api.github.com/users/stangah/followers","following_url":"https://api.github.com/users/stangah/following{/other_user}","gists_url":"https://api.github.com/users/stangah/gists{/gist_id}","starred_url":"https://api.github.com/users/stangah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stangah/subscriptions","organizations_url":"https://api.github.com/users/stangah/orgs","repos_url":"https://api.github.com/users/stangah/repos","events_url":"https://api.github.com/users/stangah/events{/privacy}","received_events_url":"https://api.github.com/users/stangah/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/453/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/453/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/453/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/99ace59b834fd9864406507d8ee557a731951d3e","head":{"label":"transcom:rek_sit-estimate-backend","ref":"rek_sit-estimate-backend","sha":"99ace59b834fd9864406507d8ee557a731951d3e","user":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-05-03T14:27:47Z","pushed_at":"2018-05-03T16:51:08Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":11526,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":9,"watchers":10,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"a0f831f49ab1b7abe5eee6751983fc5499dffbad","user":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-05-03T14:27:47Z","pushed_at":"2018-05-03T16:51:08Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":11526,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/453"},"html":{"href":"https://github.com/transcom/mymove/pull/453"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/453"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/99ace59b834fd9864406507d8ee557a731951d3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kilbergr"}}