{"action":"created","comment":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments/186891844","pull_request_review_id":118562528,"id":186891844,"diff_hunk":"@@ -83,7 +83,26 @@ var menu = document.querySelector('.menu');\n menu.label = 'Sortieren';\n ```\n \n-*NOTE: Undocumented attributes are assumed to be HTML and will be applied to the root element of the custom tag.*\n+#### Pass-Through Attributes\n+\n+HTML attributes can be used on any component, and they will be passed through to the most prominent tag of the component. The most prominent tag is usually the root, but individual components will note if it varies for specific cases.\n+\n+Example of static usage:\n+```marko\n+<ebay-button id=\"my-button\"/>\n+```\n+\n+For using pass-through attributes dynamically, they should be sent through the `htmlAttributes` attribute:\n+```marko\n+<!-- data.htmlAttributes = {id: 'my-button'} -->\n+<ebay-button htmlAttributes=data.htmlAttributes/>\n+```\n+\n+Static and dynamic pass-through attributes can be used simulatenously (htmlAttributes takes precedence in conflicts):\n+```marko\n+<!-- data.htmlAttributes = {id: 'my-button'} -->\n+<ebay-button htmlAttributes=data.htmlAttributes type=\"submit\"/>","path":"README.md","position":23,"original_position":23,"commit_id":"fdde7e10e5aa2a1beff2b76c7f3605ecf6309310","original_commit_id":"fdde7e10e5aa2a1beff2b76c7f3605ecf6309310","user":{"login":"yomed","id":3595986,"avatar_url":"https://avatars3.githubusercontent.com/u/3595986?v=4","gravatar_id":"","url":"https://api.github.com/users/yomed","html_url":"https://github.com/yomed","followers_url":"https://api.github.com/users/yomed/followers","following_url":"https://api.github.com/users/yomed/following{/other_user}","gists_url":"https://api.github.com/users/yomed/gists{/gist_id}","starred_url":"https://api.github.com/users/yomed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomed/subscriptions","organizations_url":"https://api.github.com/users/yomed/orgs","repos_url":"https://api.github.com/users/yomed/repos","events_url":"https://api.github.com/users/yomed/events{/privacy}","received_events_url":"https://api.github.com/users/yomed/received_events","type":"User","site_admin":false},"body":"This is an example of using both static and dynamic, not of having conflicts. Do you think another example is needed for conflicts?","created_at":"2018-05-08T23:00:15Z","updated_at":"2018-05-08T23:00:15Z","html_url":"https://github.com/eBay/ebayui-core/pull/154#discussion_r186891844","pull_request_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/154","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments/186891844"},"html":{"href":"https://github.com/eBay/ebayui-core/pull/154#discussion_r186891844"},"pull_request":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/154"}},"in_reply_to_id":186890045},"pull_request":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/154","id":186769372,"html_url":"https://github.com/eBay/ebayui-core/pull/154","diff_url":"https://github.com/eBay/ebayui-core/pull/154.diff","patch_url":"https://github.com/eBay/ebayui-core/pull/154.patch","issue_url":"https://api.github.com/repos/eBay/ebayui-core/issues/154","number":154,"state":"open","locked":false,"title":"Support dynamic pass-through attributes","user":{"login":"yomed","id":3595986,"avatar_url":"https://avatars3.githubusercontent.com/u/3595986?v=4","gravatar_id":"","url":"https://api.github.com/users/yomed","html_url":"https://github.com/yomed","followers_url":"https://api.github.com/users/yomed/followers","following_url":"https://api.github.com/users/yomed/following{/other_user}","gists_url":"https://api.github.com/users/yomed/gists{/gist_id}","starred_url":"https://api.github.com/users/yomed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomed/subscriptions","organizations_url":"https://api.github.com/users/yomed/orgs","repos_url":"https://api.github.com/users/yomed/repos","events_url":"https://api.github.com/users/yomed/events{/privacy}","received_events_url":"https://api.github.com/users/yomed/received_events","type":"User","site_admin":false},"body":"## Description\r\n- update `processHtmlAttributes` to accept `htmlAttributes` object\r\n- add `htmlAttributes` to all components in `marko.json`\r\n- minor reordering in `marko.json`\r\n- update main `README`\r\n- update tests\r\n\r\n## Context\r\nWe typically differentiate pass-through attributes easily because they come under `input['*']`. However, when passing these attributes dynamically, they appear as regular attributes instead of under the wildcard. To get around this, I added an `htmlAttributes` attribute on every component that can be used with (or instead of) the wildcard.\r\n\r\n## References\r\nFixes #130 \r\n","created_at":"2018-05-08T22:09:21Z","updated_at":"2018-05-08T23:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb7791d6587f412280c29df48235ff4dcfdca379","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ianmcburnie","id":38065,"avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},{"login":"DylanPiercey","id":4985201,"avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/154/commits","review_comments_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/154/comments","review_comment_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/issues/154/comments","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/fdde7e10e5aa2a1beff2b76c7f3605ecf6309310","head":{"label":"eBay:130-dynamic-html-attributes","ref":"130-dynamic-html-attributes","sha":"fdde7e10e5aa2a1beff2b76c7f3605ecf6309310","user":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"name":"ebayui-core","full_name":"eBay/ebayui-core","owner":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2018-05-04T00:15:37Z","pushed_at":"2018-05-08T22:09:21Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":null,"size":399,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":42,"watchers":33,"default_branch":"master"}},"base":{"label":"eBay:0.4.0","ref":"0.4.0","sha":"d99d553085a34d7867228f84b2aee224514123fd","user":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"name":"ebayui-core","full_name":"eBay/ebayui-core","owner":{"login":"eBay","id":3639281,"avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2018-05-04T00:15:37Z","pushed_at":"2018-05-08T22:09:21Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":null,"size":399,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":42,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/154"},"html":{"href":"https://github.com/eBay/ebayui-core/pull/154"},"issue":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/154"},"comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/eBay/ebayui-core/statuses/fdde7e10e5aa2a1beff2b76c7f3605ecf6309310"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yomed"}}