{"action":"closed","issue":{"url":"https://api.github.com/repos/apollographql/apollo-server/issues/1225","repository_url":"https://api.github.com/repos/apollographql/apollo-server","labels_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1225/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1225/comments","events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1225/events","html_url":"https://github.com/apollographql/apollo-server/issues/1225","id":334851378,"node_id":"MDU6SXNzdWUzMzQ4NTEzNzg=","number":1225,"title":"Apollo Server 2: Is graphql dependency needed in integrations?","user":{"login":"olistic","id":5600126,"node_id":"MDQ6VXNlcjU2MDAxMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/5600126?v=4","gravatar_id":"","url":"https://api.github.com/users/olistic","html_url":"https://github.com/olistic","followers_url":"https://api.github.com/users/olistic/followers","following_url":"https://api.github.com/users/olistic/following{/other_user}","gists_url":"https://api.github.com/users/olistic/gists{/gist_id}","starred_url":"https://api.github.com/users/olistic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olistic/subscriptions","organizations_url":"https://api.github.com/users/olistic/orgs","repos_url":"https://api.github.com/users/olistic/repos","events_url":"https://api.github.com/users/olistic/events{/privacy}","received_events_url":"https://api.github.com/users/olistic/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-22T11:54:20Z","updated_at":"2018-06-26T00:12:43Z","closed_at":"2018-06-26T00:12:43Z","author_association":"NONE","body":"After installing `apollo-server-lambda`, I saw warnings about a missing peer dependency: `graphql`. I haven’t seen anywhere in the `apollo-server-lambda` docs that `graphql` needs to be installed along with it, so I took a look at the code. **I see that `apollo-server-core` has `graphql` In its [peer dependencies](https://github.com/apollographql/apollo-server/blob/ebacd8fcda15c10bc4b950e894ad1815577fc072/packages/apollo-server-core/package.json#L65), but none of the apollo server variants that depend on the core (express, hapi, lambda, etc.) install `graphql` along with it. Should `graphql` be a dependency of `apollo-server-<variant>`? Or should it be installed by the end user, along with `apollo-server-<variant>`?** (If it’s the latter, then maybe `graphql` should be a peer dependency of the variant packages, as it's the case for `apollo-server`).\r\n\r\nThanks, and please accept my apologies if I missed something!"}}
{"actor":{"display_login":"evans"}}