{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/225856054","pull_request_review_id":165543930,"id":225856054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTg1NjA1NA==","diff_hunk":"@@ -405,7 +405,7 @@ struct Tridiagonal{T,V<:AbstractVector{T}} <: AbstractMatrix{T}\n     dl::V    # sub-diagonal\n     d::V     # diagonal\n     du::V    # sup-diagonal\n-    du2::V   # supsup-diagonal for pivoting in LU\n+    du2::Union{Nothing, V}   # supsup-diagonal for pivoting in LU","path":"stdlib/LinearAlgebra/src/tridiag.jl","position":5,"original_position":5,"commit_id":"11c492dfc75e8d3442628beacb7a233be80b2e53","original_commit_id":"11c492dfc75e8d3442628beacb7a233be80b2e53","user":{"login":"andreasnoack","id":505001,"node_id":"MDQ6VXNlcjUwNTAwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/505001?v=4","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"body":"Right. You can only to the with `StepRangeLen` (the float default) but not for `UnitRange`.","created_at":"2018-10-17T09:50:44Z","updated_at":"2018-10-17T09:50:44Z","html_url":"https://github.com/JuliaLang/julia/pull/29599#discussion_r225856054","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/29599","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/225856054"},"html":{"href":"https://github.com/JuliaLang/julia/pull/29599#discussion_r225856054"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/29599"}},"in_reply_to_id":224686332},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/29599","id":222149003,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTQ5MDAz","html_url":"https://github.com/JuliaLang/julia/pull/29599","diff_url":"https://github.com/JuliaLang/julia/pull/29599.diff","patch_url":"https://github.com/JuliaLang/julia/pull/29599.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/29599","number":29599,"state":"open","locked":false,"title":"[RFC] constructors for similar structured matrices with different containers","user":{"login":"mcognetta","id":6856636,"node_id":"MDQ6VXNlcjY4NTY2MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6856636?v=4","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"body":"Adding constructors to convert between similar structured matrices with different container types. This fixes  #29054 \r\n```\r\njulia> convert(Diagonal{Int,Vector{Int}}, Diagonal(1:4))\r\n4×4 Diagonal{Int64,Array{Int64,1}}:\r\n 1  ⋅  ⋅  ⋅\r\n ⋅  2  ⋅  ⋅\r\n ⋅  ⋅  3  ⋅\r\n ⋅  ⋅  ⋅  4\r\n```\r\n\r\nThis also adds similar support for `Bidiagonal`, `Tridiagonal`, and `SymTridiagonal`. \r\nThere is an error in it when using ranges for `Tridiagonal` only where `du2` is never given but is undefined after initialization. This causes an `OutOfMemoryError` when it is converted.\r\n\r\n```\r\njulia> Trange = Tridiagonal(1:2, 1:3, 1:2)\r\n3×3 Tridiagonal{Int64,UnitRange{Int64}}:\r\n 1  1  ⋅\r\n 1  2  2\r\n ⋅  2  3\r\n\r\njulia> Trange.du2\r\n0:140275788100048\r\n\r\njulia> Tnorm = Tridiagonal(rand(2), rand(3), rand(2))\r\n3×3 Tridiagonal{Float64,Array{Float64,1}}:\r\n 0.574761  0.765595   ⋅       \r\n 0.125415  0.804884  0.395248 \r\n  ⋅        0.115691  0.0521253\r\n\r\njulia> Tnorm.du2\r\nERROR: UndefRefError: access to undefined reference\r\nStacktrace:\r\n [1] getproperty(::Any, ::Symbol) at ./sysimg.jl:18\r\n```\r\n\r\nI cannot pin down the cause of this but it seems like just uninitialized ranges. For example\r\n```\r\njulia> Vector{UnitRange{Int64}}(undef, 2)\r\n2-element Array{UnitRange{Int64},1}:\r\n 140275945593040:140275798608064\r\n 140275798608128:0\r\n```\r\n\r\nComments are appreciated.","created_at":"2018-10-11T13:58:49Z","updated_at":"2018-10-17T09:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6845f8329c6ffe10270651e348797e46e108e298","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/29599/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/29599/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/29599/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/11c492dfc75e8d3442628beacb7a233be80b2e53","head":{"label":"mcognetta:fix_29054","ref":"fix_29054","sha":"11c492dfc75e8d3442628beacb7a233be80b2e53","user":{"login":"mcognetta","id":6856636,"node_id":"MDQ6VXNlcjY4NTY2MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6856636?v=4","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"repo":{"id":68284276,"node_id":"MDEwOlJlcG9zaXRvcnk2ODI4NDI3Ng==","name":"julia","full_name":"mcognetta/julia","private":false,"owner":{"login":"mcognetta","id":6856636,"node_id":"MDQ6VXNlcjY4NTY2MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6856636?v=4","gravatar_id":"","url":"https://api.github.com/users/mcognetta","html_url":"https://github.com/mcognetta","followers_url":"https://api.github.com/users/mcognetta/followers","following_url":"https://api.github.com/users/mcognetta/following{/other_user}","gists_url":"https://api.github.com/users/mcognetta/gists{/gist_id}","starred_url":"https://api.github.com/users/mcognetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcognetta/subscriptions","organizations_url":"https://api.github.com/users/mcognetta/orgs","repos_url":"https://api.github.com/users/mcognetta/repos","events_url":"https://api.github.com/users/mcognetta/events{/privacy}","received_events_url":"https://api.github.com/users/mcognetta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcognetta/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/mcognetta/julia","forks_url":"https://api.github.com/repos/mcognetta/julia/forks","keys_url":"https://api.github.com/repos/mcognetta/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcognetta/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcognetta/julia/teams","hooks_url":"https://api.github.com/repos/mcognetta/julia/hooks","issue_events_url":"https://api.github.com/repos/mcognetta/julia/issues/events{/number}","events_url":"https://api.github.com/repos/mcognetta/julia/events","assignees_url":"https://api.github.com/repos/mcognetta/julia/assignees{/user}","branches_url":"https://api.github.com/repos/mcognetta/julia/branches{/branch}","tags_url":"https://api.github.com/repos/mcognetta/julia/tags","blobs_url":"https://api.github.com/repos/mcognetta/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcognetta/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcognetta/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcognetta/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcognetta/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/mcognetta/julia/languages","stargazers_url":"https://api.github.com/repos/mcognetta/julia/stargazers","contributors_url":"https://api.github.com/repos/mcognetta/julia/contributors","subscribers_url":"https://api.github.com/repos/mcognetta/julia/subscribers","subscription_url":"https://api.github.com/repos/mcognetta/julia/subscription","commits_url":"https://api.github.com/repos/mcognetta/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcognetta/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcognetta/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcognetta/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcognetta/julia/contents/{+path}","compare_url":"https://api.github.com/repos/mcognetta/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcognetta/julia/merges","archive_url":"https://api.github.com/repos/mcognetta/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcognetta/julia/downloads","issues_url":"https://api.github.com/repos/mcognetta/julia/issues{/number}","pulls_url":"https://api.github.com/repos/mcognetta/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/mcognetta/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/mcognetta/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcognetta/julia/labels{/name}","releases_url":"https://api.github.com/repos/mcognetta/julia/releases{/id}","deployments_url":"https://api.github.com/repos/mcognetta/julia/deployments","created_at":"2016-09-15T10:13:57Z","updated_at":"2018-10-17T04:52:48Z","pushed_at":"2018-10-17T04:52:46Z","git_url":"git://github.com/mcognetta/julia.git","ssh_url":"git@github.com:mcognetta/julia.git","clone_url":"https://github.com/mcognetta/julia.git","svn_url":"https://github.com/mcognetta/julia","homepage":"http://julialang.org/","size":156177,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"e20d1ee68683be888af5eb1cc5d3c9bdc18bd1c0","user":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQ0MTk2","name":"julia","full_name":"JuliaLang/julia","private":false,"owner":{"login":"JuliaLang","id":743164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzE2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2018-10-17T09:30:57Z","pushed_at":"2018-10-17T09:29:09Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":468217,"stargazers_count":18096,"watchers_count":18096,"language":"Julia","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3019,"mirror_url":null,"archived":false,"open_issues_count":2928,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3019,"open_issues":2928,"watchers":18096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/29599"},"html":{"href":"https://github.com/JuliaLang/julia/pull/29599"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/29599"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/29599/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/29599/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/29599/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/11c492dfc75e8d3442628beacb7a233be80b2e53"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andreasnoack"}}