{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/173663826","pull_request_review_id":102890852,"id":173663826,"diff_hunk":"@@ -471,6 +471,7 @@ def test_if_rctemplate_would_be_valid(tmpdir):\n     with open(fname, \"w\") as f:\n         f.writelines(newlines)\n     with pytest.warns(None) as record:\n+        print(fname)","path":"lib/matplotlib/tests/test_rcparams.py","position":4,"original_position":4,"commit_id":"4ca96a4a6d4daa51ca1d6b86f840d32551834981","original_commit_id":"4ca96a4a6d4daa51ca1d6b86f840d32551834981","user":{"login":"timhoffm","id":2836374,"avatar_url":"https://avatars1.githubusercontent.com/u/2836374?v=4","gravatar_id":"","url":"https://api.github.com/users/timhoffm","html_url":"https://github.com/timhoffm","followers_url":"https://api.github.com/users/timhoffm/followers","following_url":"https://api.github.com/users/timhoffm/following{/other_user}","gists_url":"https://api.github.com/users/timhoffm/gists{/gist_id}","starred_url":"https://api.github.com/users/timhoffm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhoffm/subscriptions","organizations_url":"https://api.github.com/users/timhoffm/orgs","repos_url":"https://api.github.com/users/timhoffm/repos","events_url":"https://api.github.com/users/timhoffm/events{/privacy}","received_events_url":"https://api.github.com/users/timhoffm/received_events","type":"User","site_admin":false},"body":"Is this print intended?","created_at":"2018-03-11T18:16:12Z","updated_at":"2018-03-11T18:16:12Z","html_url":"https://github.com/matplotlib/matplotlib/pull/10715#discussion_r173663826","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/173663826"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10715#discussion_r173663826"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715","id":173644666,"html_url":"https://github.com/matplotlib/matplotlib/pull/10715","diff_url":"https://github.com/matplotlib/matplotlib/pull/10715.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/10715.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10715","number":10715,"state":"open","locked":false,"title":"ENH: add title_fontsize to legend","user":{"login":"jklymak","id":1562854,"avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\ncloses #8699   \r\n\r\nIn master, a legend will have the fontsize of the title, set by the default axes fontsize, and will ignore the `fontsize` kwarg for legend:\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nimport matplotlib as mpl\r\n\r\nfig, ax = plt.subplots(figsize=(8, 3))\r\nax.plot([1, 2], label='Boo')\r\nax.legend(title=\"Legend Title\", fontsize=6)\r\nplt.show()\r\n```\r\n\r\n![fig1](https://user-images.githubusercontent.com/1562854/37133449-4a2121b0-2248-11e8-9387-cfcb210e41af.png)\r\n\r\nHere we implement the `title_fontsize` kwarg:\r\n\r\n```python\r\nax.legend(title=\"Legend Title\", fontsize=6, title_fontsize=6)\r\n```\r\n\r\n![fig2](https://user-images.githubusercontent.com/1562854/37133485-7d440bfc-2248-11e8-87b9-ad18d3712417.png)\r\n\r\nand the `:rc:legend.title_fontsize` rcParam:\r\n\r\n```python\r\nmpl.rcParams['title_fontsize']=6\r\nax.legend(title=\"Legend Title\", fontsize=6)\r\n```\r\n\r\n\r\n## PR Checklist\r\n\r\n- [x] Has Pytest style unit tests\r\n- [x] Code is PEP 8 compliant\r\n- [x] Documentation is sphinx and numpydoc compliant\r\n- [x] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n\r\n<!--\r\nThank you so much for your PR!  To help us review your contribution, please\r\nconsider the following points:\r\n\r\n- A development guide is available at https://matplotlib.org/devdocs/devel/index.html.\r\n\r\n- Help with git and github is available at\r\n  https://matplotlib.org/devel/gitwash/development_workflow.html.\r\n\r\n- Do not create the PR out of master, but out of a separate branch.\r\n\r\n- The PR title should summarize the changes, for example \"Raise ValueError on\r\n  non-numeric input to set_xlim\".  Avoid non-descriptive titles such as\r\n  \"Addresses issue #8576\".\r\n\r\n- The summary should provide at least 1-2 sentences describing the pull request\r\n  in detail (Why is this change required?  What problem does it solve?) and\r\n  link to any relevant issues.\r\n\r\n- If you are contributing fixes to docstrings, please pay attention to\r\n  http://matplotlib.org/devel/documenting_mpl.html#formatting.  In particular,\r\n  note the difference between using single backquotes, double backquotes, and\r\n  asterisks in the markup.\r\n\r\nWe understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or\r\nthe recommended next step seems overly demanding, if you would like help in\r\naddressing a reviewer's comments, or if you have been waiting too long to hear\r\nback on your PR.\r\n-->","created_at":"2018-03-08T04:47:08Z","updated_at":"2018-03-11T18:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51d383a2ad43cece98531398356b92a70e7aef87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23","html_url":"https://github.com/matplotlib/matplotlib/milestone/23","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23/labels","id":1542657,"number":23,"title":"v3.0","description":"Big ticket items:\r\n\r\n - drop support for python 2","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":162,"closed_issues":79,"state":"open","created_at":"2016-01-25T21:06:49Z","updated_at":"2018-03-11T18:08:25Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10715/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/4ca96a4a6d4daa51ca1d6b86f840d32551834981","head":{"label":"jklymak:enh-rc-legend-title-fontsize","ref":"enh-rc-legend-title-fontsize","sha":"4ca96a4a6d4daa51ca1d6b86f840d32551834981","user":{"login":"jklymak","id":1562854,"avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"repo":{"id":93901119,"name":"matplotlib","full_name":"jklymak/matplotlib","owner":{"login":"jklymak","id":1562854,"avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklymak/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/jklymak/matplotlib","forks_url":"https://api.github.com/repos/jklymak/matplotlib/forks","keys_url":"https://api.github.com/repos/jklymak/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklymak/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklymak/matplotlib/teams","hooks_url":"https://api.github.com/repos/jklymak/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/jklymak/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/jklymak/matplotlib/events","assignees_url":"https://api.github.com/repos/jklymak/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/jklymak/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/jklymak/matplotlib/tags","blobs_url":"https://api.github.com/repos/jklymak/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklymak/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklymak/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklymak/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklymak/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/jklymak/matplotlib/languages","stargazers_url":"https://api.github.com/repos/jklymak/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/jklymak/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/jklymak/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/jklymak/matplotlib/subscription","commits_url":"https://api.github.com/repos/jklymak/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklymak/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklymak/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklymak/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklymak/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/jklymak/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklymak/matplotlib/merges","archive_url":"https://api.github.com/repos/jklymak/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklymak/matplotlib/downloads","issues_url":"https://api.github.com/repos/jklymak/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/jklymak/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/jklymak/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/jklymak/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklymak/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/jklymak/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/jklymak/matplotlib/deployments","created_at":"2017-06-09T22:24:38Z","updated_at":"2017-06-10T22:48:17Z","pushed_at":"2018-03-11T17:43:09Z","git_url":"git://github.com/jklymak/matplotlib.git","ssh_url":"git@github.com:jklymak/matplotlib.git","clone_url":"https://github.com/jklymak/matplotlib.git","svn_url":"https://github.com/jklymak/matplotlib","homepage":"http://matplotlib.org/","size":327777,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"matplotlib:master","ref":"master","sha":"ef5d01a4888e8726be66450d494fa1dc14eca843","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-03-11T16:07:15Z","pushed_at":"2018-03-11T18:08:25Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":324192,"stargazers_count":6881,"watchers_count":6881,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3243,"mirror_url":null,"archived":false,"open_issues_count":1368,"license":null,"forks":3243,"open_issues":1368,"watchers":6881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10715"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10715"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10715/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10715/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/4ca96a4a6d4daa51ca1d6b86f840d32551834981"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timhoffm"}}