{"action":"created","issue":{"url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/143","repository_url":"https://api.github.com/repos/QuantumBFS/Yao.jl","labels_url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/143/comments","events_url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/143/events","html_url":"https://github.com/QuantumBFS/Yao.jl/pull/143","id":366923982,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDgxNDYx","number":143,"title":"WIP: [Code Polish] Phase 1","user":{"login":"Roger-luo","id":8445510,"node_id":"MDQ6VXNlcjg0NDU1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8445510?v=4","gravatar_id":"","url":"https://api.github.com/users/Roger-luo","html_url":"https://github.com/Roger-luo","followers_url":"https://api.github.com/users/Roger-luo/followers","following_url":"https://api.github.com/users/Roger-luo/following{/other_user}","gists_url":"https://api.github.com/users/Roger-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/Roger-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roger-luo/subscriptions","organizations_url":"https://api.github.com/users/Roger-luo/orgs","repos_url":"https://api.github.com/users/Roger-luo/repos","events_url":"https://api.github.com/users/Roger-luo/events{/privacy}","received_events_url":"https://api.github.com/users/Roger-luo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-04T18:53:43Z","updated_at":"2018-10-24T05:56:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/QuantumBFS/Yao.jl/pulls/143","html_url":"https://github.com/QuantumBFS/Yao.jl/pull/143","diff_url":"https://github.com/QuantumBFS/Yao.jl/pull/143.diff","patch_url":"https://github.com/QuantumBFS/Yao.jl/pull/143.patch"},"body":"- [x] drop `v0.6` completely\r\n- [x] add assertions to `bit_str`\r\n- [x] rename `QuBitStr` to `BitStr`\r\n\r\n- [x] rename assertions: remove prefix `_` for functions and delete the macros\r\n- [ ] re-organize some file\r\n- [ ] refactor some workarounds\r\n\r\nQuestion: do we need a release version (a version without any bounds check and assertions) of the lib? If we do, I will move the assertions back to macro and add `Expr(:boundscheck)` while generating the expression."},"comment":{"url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/comments/432522748","html_url":"https://github.com/QuantumBFS/Yao.jl/pull/143#issuecomment-432522748","issue_url":"https://api.github.com/repos/QuantumBFS/Yao.jl/issues/143","id":432522748,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjUyMjc0OA==","user":{"login":"Roger-luo","id":8445510,"node_id":"MDQ6VXNlcjg0NDU1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8445510?v=4","gravatar_id":"","url":"https://api.github.com/users/Roger-luo","html_url":"https://github.com/Roger-luo","followers_url":"https://api.github.com/users/Roger-luo/followers","following_url":"https://api.github.com/users/Roger-luo/following{/other_user}","gists_url":"https://api.github.com/users/Roger-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/Roger-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roger-luo/subscriptions","organizations_url":"https://api.github.com/users/Roger-luo/orgs","repos_url":"https://api.github.com/users/Roger-luo/repos","events_url":"https://api.github.com/users/Roger-luo/events{/privacy}","received_events_url":"https://api.github.com/users/Roger-luo/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T05:56:39Z","updated_at":"2018-10-24T05:56:39Z","author_association":"MEMBER","body":"That is for PkgBenchmark.jl, it's not tagged yet."}}
{"actor":{"display_login":"Roger-luo"}}