{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/flight_review/pulls/comments/206023701","pull_request_review_id":141402405,"id":206023701,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjAyMzcwMQ==","diff_hunk":"@@ -573,12 +573,12 @@ def generate_plots(ulog, px4_ulog, db_data, vehicle_data, link_to_3d_page):\n                          'Battery Current [A]', 'Discharged Amount [mAh / 100]',\n                          'Battery remaining [0=empty, 10=full]'])\n     data_plot.change_dataset('system_power')\n-    if data_plot.dataset and 'voltage5V_v' in data_plot.dataset.data:\n-        if np.amax(data_plot.dataset.data['voltage5V_v']) > 0.0001:\n-            data_plot.add_graph(['voltage5V_v'], colors8[7:8], ['5 V'])\n+    if data_plot.dataset and 'voltage5v_v' in data_plot.dataset.data:","path":"plot_app/configured_plots.py","position":7,"original_position":7,"commit_id":"109a28e96b440621cc428f60b66671bc70765c0d","original_commit_id":"109a28e96b440621cc428f60b66671bc70765c0d","user":{"login":"bkueng","id":281593,"node_id":"MDQ6VXNlcjI4MTU5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/281593?v=4","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false},"body":"Yes, please add the checks to https://github.com/PX4/flight_review/blob/master/plot_app/configured_plots.py#L36, to check if it's using the old name. If so, rename the field into the new format, so that the new format is used throughout the code.","created_at":"2018-07-30T06:17:00Z","updated_at":"2018-07-30T06:17:00Z","html_url":"https://github.com/PX4/flight_review/pull/123#discussion_r206023701","pull_request_url":"https://api.github.com/repos/PX4/flight_review/pulls/123","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/comments/206023701"},"html":{"href":"https://github.com/PX4/flight_review/pull/123#discussion_r206023701"},"pull_request":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/123"}},"in_reply_to_id":205988973},"pull_request":{"url":"https://api.github.com/repos/PX4/flight_review/pulls/123","id":204663108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjYzMTA4","html_url":"https://github.com/PX4/flight_review/pull/123","diff_url":"https://github.com/PX4/flight_review/pull/123.diff","patch_url":"https://github.com/PX4/flight_review/pull/123.patch","issue_url":"https://api.github.com/repos/PX4/flight_review/issues/123","number":123,"state":"open","locked":false,"title":"configure_plots: update system_power fields naming","user":{"login":"TSC21","id":5048656,"node_id":"MDQ6VXNlcjUwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5048656?v=4","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"body":"This PR syncs with and addresses the changes done in https://github.com/PX4/Firmware/pull/10077. @bkueng can you please validate it? Thanks","created_at":"2018-07-29T21:48:48Z","updated_at":"2018-07-30T06:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c52948f4cd3a34b081648eb2a5140939e83a3491","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/flight_review/pulls/123/commits","review_comments_url":"https://api.github.com/repos/PX4/flight_review/pulls/123/comments","review_comment_url":"https://api.github.com/repos/PX4/flight_review/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/flight_review/issues/123/comments","statuses_url":"https://api.github.com/repos/PX4/flight_review/statuses/109a28e96b440621cc428f60b66671bc70765c0d","head":{"label":"TSC21:pr-camelCase_to_snake_case_msg","ref":"pr-camelCase_to_snake_case_msg","sha":"109a28e96b440621cc428f60b66671bc70765c0d","user":{"login":"TSC21","id":5048656,"node_id":"MDQ6VXNlcjUwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5048656?v=4","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"repo":{"id":133560592,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NjA1OTI=","name":"flight_review","full_name":"TSC21/flight_review","owner":{"login":"TSC21","id":5048656,"node_id":"MDQ6VXNlcjUwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5048656?v=4","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TSC21/flight_review","description":"web application for flight log analysis & review","fork":true,"url":"https://api.github.com/repos/TSC21/flight_review","forks_url":"https://api.github.com/repos/TSC21/flight_review/forks","keys_url":"https://api.github.com/repos/TSC21/flight_review/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TSC21/flight_review/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TSC21/flight_review/teams","hooks_url":"https://api.github.com/repos/TSC21/flight_review/hooks","issue_events_url":"https://api.github.com/repos/TSC21/flight_review/issues/events{/number}","events_url":"https://api.github.com/repos/TSC21/flight_review/events","assignees_url":"https://api.github.com/repos/TSC21/flight_review/assignees{/user}","branches_url":"https://api.github.com/repos/TSC21/flight_review/branches{/branch}","tags_url":"https://api.github.com/repos/TSC21/flight_review/tags","blobs_url":"https://api.github.com/repos/TSC21/flight_review/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TSC21/flight_review/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TSC21/flight_review/git/refs{/sha}","trees_url":"https://api.github.com/repos/TSC21/flight_review/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TSC21/flight_review/statuses/{sha}","languages_url":"https://api.github.com/repos/TSC21/flight_review/languages","stargazers_url":"https://api.github.com/repos/TSC21/flight_review/stargazers","contributors_url":"https://api.github.com/repos/TSC21/flight_review/contributors","subscribers_url":"https://api.github.com/repos/TSC21/flight_review/subscribers","subscription_url":"https://api.github.com/repos/TSC21/flight_review/subscription","commits_url":"https://api.github.com/repos/TSC21/flight_review/commits{/sha}","git_commits_url":"https://api.github.com/repos/TSC21/flight_review/git/commits{/sha}","comments_url":"https://api.github.com/repos/TSC21/flight_review/comments{/number}","issue_comment_url":"https://api.github.com/repos/TSC21/flight_review/issues/comments{/number}","contents_url":"https://api.github.com/repos/TSC21/flight_review/contents/{+path}","compare_url":"https://api.github.com/repos/TSC21/flight_review/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TSC21/flight_review/merges","archive_url":"https://api.github.com/repos/TSC21/flight_review/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TSC21/flight_review/downloads","issues_url":"https://api.github.com/repos/TSC21/flight_review/issues{/number}","pulls_url":"https://api.github.com/repos/TSC21/flight_review/pulls{/number}","milestones_url":"https://api.github.com/repos/TSC21/flight_review/milestones{/number}","notifications_url":"https://api.github.com/repos/TSC21/flight_review/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TSC21/flight_review/labels{/name}","releases_url":"https://api.github.com/repos/TSC21/flight_review/releases{/id}","deployments_url":"https://api.github.com/repos/TSC21/flight_review/deployments","created_at":"2018-05-15T19:00:15Z","updated_at":"2018-05-15T19:00:18Z","pushed_at":"2018-07-29T21:47:47Z","git_url":"git://github.com/TSC21/flight_review.git","ssh_url":"git@github.com:TSC21/flight_review.git","clone_url":"https://github.com/TSC21/flight_review.git","svn_url":"https://github.com/TSC21/flight_review","homepage":null,"size":18499,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"828f8191527e1025462f6118428ea24dccd3b2a6","user":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":71870777,"node_id":"MDEwOlJlcG9zaXRvcnk3MTg3MDc3Nw==","name":"flight_review","full_name":"PX4/flight_review","owner":{"login":"PX4","id":2096014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTYwMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/flight_review","description":"web application for flight log analysis & review","fork":false,"url":"https://api.github.com/repos/PX4/flight_review","forks_url":"https://api.github.com/repos/PX4/flight_review/forks","keys_url":"https://api.github.com/repos/PX4/flight_review/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/flight_review/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/flight_review/teams","hooks_url":"https://api.github.com/repos/PX4/flight_review/hooks","issue_events_url":"https://api.github.com/repos/PX4/flight_review/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/flight_review/events","assignees_url":"https://api.github.com/repos/PX4/flight_review/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/flight_review/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/flight_review/tags","blobs_url":"https://api.github.com/repos/PX4/flight_review/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/flight_review/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/flight_review/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/flight_review/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/flight_review/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/flight_review/languages","stargazers_url":"https://api.github.com/repos/PX4/flight_review/stargazers","contributors_url":"https://api.github.com/repos/PX4/flight_review/contributors","subscribers_url":"https://api.github.com/repos/PX4/flight_review/subscribers","subscription_url":"https://api.github.com/repos/PX4/flight_review/subscription","commits_url":"https://api.github.com/repos/PX4/flight_review/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/flight_review/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/flight_review/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/flight_review/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/flight_review/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/flight_review/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/flight_review/merges","archive_url":"https://api.github.com/repos/PX4/flight_review/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/flight_review/downloads","issues_url":"https://api.github.com/repos/PX4/flight_review/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/flight_review/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/flight_review/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/flight_review/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/flight_review/labels{/name}","releases_url":"https://api.github.com/repos/PX4/flight_review/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/flight_review/deployments","created_at":"2016-10-25T07:27:46Z","updated_at":"2018-07-17T14:48:15Z","pushed_at":"2018-07-29T21:48:48Z","git_url":"git://github.com/PX4/flight_review.git","ssh_url":"git@github.com:PX4/flight_review.git","clone_url":"https://github.com/PX4/flight_review.git","svn_url":"https://github.com/PX4/flight_review","homepage":null,"size":18499,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":41,"open_issues":13,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/123"},"html":{"href":"https://github.com/PX4/flight_review/pull/123"},"issue":{"href":"https://api.github.com/repos/PX4/flight_review/issues/123"},"comments":{"href":"https://api.github.com/repos/PX4/flight_review/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/flight_review/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/flight_review/statuses/109a28e96b440621cc428f60b66671bc70765c0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bkueng"}}