{"action":"opened","issue":{"url":"https://api.github.com/repos/dotnet/machinelearning/issues/1942","repository_url":"https://api.github.com/repos/dotnet/machinelearning","labels_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1942/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1942/comments","events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1942/events","html_url":"https://github.com/dotnet/machinelearning/issues/1942","id":393175239,"node_id":"MDU6SXNzdWUzOTMxNzUyMzk=","number":1942,"title":"Reconcile the check for Probability in the BinaryClassifierEvaluator with the logic in the calibrators","user":{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-20T19:09:57Z","updated_at":"2018-12-20T19:09:57Z","closed_at":null,"author_association":"MEMBER","body":"Fitting an IDataView that contains a score column(produced by a binary classifier scorer), currently will append a column with the name probability to the IDataView . \r\n\r\nIf one column with the name \"Probability\" exists, another one will be added. (Maybe if the user wants to try out different calibrators?). The calibrators don't complain about its existence. \r\n\r\nCurrently the [BinaryClassifierEvaluator](https://github.com/dotnet/machinelearning/blob/3188f1a3a176fe80902491b08024b10dd6cc2a25/src/Microsoft.ML.Data/Evaluators/BinaryClassifierEvaluator.cs#L145) checks that there are no more than one probability columns. \r\n\r\nReconcile the behavior/expectations, or is this ok, and we can leave the user cleanup if more than one Probability columns. \r\n\r\ncc @yaeldekel @TomFinley "}}
{"actor":{"display_login":"sfilipi"}}