{"action":"created","issue":{"url":"https://api.github.com/repos/user-cont/conu/issues/263","repository_url":"https://api.github.com/repos/user-cont/conu","labels_url":"https://api.github.com/repos/user-cont/conu/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/user-cont/conu/issues/263/comments","events_url":"https://api.github.com/repos/user-cont/conu/issues/263/events","html_url":"https://github.com/user-cont/conu/pull/263","id":350487966,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzI3NzE4","number":263,"title":"Use Popen in run_cmd and pipe outputs to logger","user":{"login":"SkullTech","id":16862545,"node_id":"MDQ6VXNlcjE2ODYyNTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/16862545?v=4","gravatar_id":"","url":"https://api.github.com/users/SkullTech","html_url":"https://github.com/SkullTech","followers_url":"https://api.github.com/users/SkullTech/followers","following_url":"https://api.github.com/users/SkullTech/following{/other_user}","gists_url":"https://api.github.com/users/SkullTech/gists{/gist_id}","starred_url":"https://api.github.com/users/SkullTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkullTech/subscriptions","organizations_url":"https://api.github.com/users/SkullTech/orgs","repos_url":"https://api.github.com/users/SkullTech/repos","events_url":"https://api.github.com/users/SkullTech/events{/privacy}","received_events_url":"https://api.github.com/users/SkullTech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-14T15:47:02Z","updated_at":"2018-08-16T08:03:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/user-cont/conu/pulls/263","html_url":"https://github.com/user-cont/conu/pull/263","diff_url":"https://github.com/user-cont/conu/pull/263.diff","patch_url":"https://github.com/user-cont/conu/pull/263.patch"},"body":"Fixes #211 \r\n\r\n_Old behaviour_\r\n\r\n```\r\n>>> from conu.utils import run_cmd\r\n>>> ret = run_cmd(['ls'])\r\nCHANGELOG.md\t  docs\t\t\tpytest.ini\t   setup.cfg\r\nCONTRIBUTING.md   examples\t\tREADME.md\t   setup.py\r\nconu\t\t  LICENSE\t\trelease-conf.yaml  test-requirements.sh\r\nconu.spec\t  Makefile\t\trequirements.in    tests\r\nDockerfile\t  MANIFEST.in\t\trequirements.sh    Vagrantfile\r\nDockerfile.tests  pytest-container.ini\trequirements.txt\r\n>>> ret\r\n>>> ret = run_cmd(['ls'], return_output=True)\r\n>>> ret\r\n'CHANGELOG.md\\nCONTRIBUTING.md\\nconu\\nconu.spec\\nDockerfile\\nDockerfile.tests\\ndocs\\nexamples\\nLICENSE\\nMakefile\\nMANIFEST.in\\npytest-container.ini\\npytest.ini\\nREADME.md\\nrelease-conf.yaml\\nrequirements.in\\nrequirements.sh\\nrequirements.txt\\nsetup.cfg\\nsetup.py\\ntest-requirements.sh\\ntests\\nVagrantfile\\n'\r\n```\r\n\r\n_New behaviour_\r\n\r\n```\r\n>>> from conu.utils import run_cmd\r\n>>> ret = run_cmd(['ls'])\r\n>>> ret\r\n>>> ret = run_cmd(['ls'], return_output=True)\r\n>>> ret\r\n'CHANGELOG.md\\nCONTRIBUTING.md\\nconu\\nconu.spec\\nDockerfile\\nDockerfile.tests\\ndocs\\nexamples\\nLICENSE\\nMakefile\\nMANIFEST.in\\npytest-container.ini\\npytest.ini\\nREADME.md\\nrelease-conf.yaml\\nrequirements.in\\nrequirements.sh\\nrequirements.txt\\nsetup.cfg\\nsetup.py\\ntest-requirements.sh\\ntests\\nVagrantfile\\n'\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/user-cont/conu/issues/comments/413460879","html_url":"https://github.com/user-cont/conu/pull/263#issuecomment-413460879","issue_url":"https://api.github.com/repos/user-cont/conu/issues/263","id":413460879,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzQ2MDg3OQ==","user":{"login":"TomasTomecek","id":1662493,"node_id":"MDQ6VXNlcjE2NjI0OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1662493?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasTomecek","html_url":"https://github.com/TomasTomecek","followers_url":"https://api.github.com/users/TomasTomecek/followers","following_url":"https://api.github.com/users/TomasTomecek/following{/other_user}","gists_url":"https://api.github.com/users/TomasTomecek/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasTomecek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasTomecek/subscriptions","organizations_url":"https://api.github.com/users/TomasTomecek/orgs","repos_url":"https://api.github.com/users/TomasTomecek/repos","events_url":"https://api.github.com/users/TomasTomecek/events{/privacy}","received_events_url":"https://api.github.com/users/TomasTomecek/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T08:03:41Z","updated_at":"2018-08-16T08:03:41Z","author_association":"MEMBER","body":"[test]"}}
{"actor":{"display_login":"TomasTomecek"}}