{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/174436027","pull_request_review_id":103788851,"id":174436027,"diff_hunk":"@@ -3320,7 +3320,7 @@ struct r_bin_pe_section_t* PE_(r_bin_pe_get_sections)(struct PE_(r_bin_pe_obj_t)\n \t\t\t}\n \t\t} else {\n \t\t\tmemcpy (sections[j].name, shdr[i].Name, PE_IMAGE_SIZEOF_SHORT_NAME);\n-\t\t\tsections[j].name[PE_IMAGE_SIZEOF_SHORT_NAME - 1] = '\\0';\n+\t\t\tsections[j].name[PE_IMAGE_SIZEOF_SHORT_NAME] = '\\0';","path":"libr/bin/format/pe/pe.c","position":5,"original_position":5,"commit_id":"d8a32623e20f7766ab0f9172627c285214a9eb02","original_commit_id":"d8a32623e20f7766ab0f9172627c285214a9eb02","user":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"body":"this causes an oobwrite error. ... err wtf who the hell did `        ut8 name[PE_IMAGE_SIZEOF_SHORT_NAME * 3];` in the .h??","created_at":"2018-03-14T12:03:01Z","updated_at":"2018-03-14T12:03:02Z","html_url":"https://github.com/radare/radare2/pull/9689#discussion_r174436027","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/9689","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/174436027"},"html":{"href":"https://github.com/radare/radare2/pull/9689#discussion_r174436027"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/9689"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/9689","id":174919274,"html_url":"https://github.com/radare/radare2/pull/9689","diff_url":"https://github.com/radare/radare2/pull/9689.diff","patch_url":"https://github.com/radare/radare2/pull/9689.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/9689","number":9689,"state":"open","locked":false,"title":"Bin fixes","user":{"login":"Hyask","id":7489759,"avatar_url":"https://avatars1.githubusercontent.com/u/7489759?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyask","html_url":"https://github.com/Hyask","followers_url":"https://api.github.com/users/Hyask/followers","following_url":"https://api.github.com/users/Hyask/following{/other_user}","gists_url":"https://api.github.com/users/Hyask/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyask/subscriptions","organizations_url":"https://api.github.com/users/Hyask/orgs","repos_url":"https://api.github.com/users/Hyask/repos","events_url":"https://api.github.com/users/Hyask/events{/privacy}","received_events_url":"https://api.github.com/users/Hyask/received_events","type":"User","site_admin":false},"body":"My colleague has recently made a few fix in the PE and PDB parsing. Here are the patches.\r\nI did not author them, but if there are any questions, I'll be happy to help.","created_at":"2018-03-14T11:00:17Z","updated_at":"2018-03-14T12:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d9f161236b85d0fd08a074faa938fed96288767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/9689/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/9689/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/9689/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/d8a32623e20f7766ab0f9172627c285214a9eb02","head":{"label":"Hyask:bin_fixes","ref":"bin_fixes","sha":"d8a32623e20f7766ab0f9172627c285214a9eb02","user":{"login":"Hyask","id":7489759,"avatar_url":"https://avatars1.githubusercontent.com/u/7489759?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyask","html_url":"https://github.com/Hyask","followers_url":"https://api.github.com/users/Hyask/followers","following_url":"https://api.github.com/users/Hyask/following{/other_user}","gists_url":"https://api.github.com/users/Hyask/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyask/subscriptions","organizations_url":"https://api.github.com/users/Hyask/orgs","repos_url":"https://api.github.com/users/Hyask/repos","events_url":"https://api.github.com/users/Hyask/events{/privacy}","received_events_url":"https://api.github.com/users/Hyask/received_events","type":"User","site_admin":false},"repo":{"id":19554909,"name":"radare2","full_name":"Hyask/radare2","owner":{"login":"Hyask","id":7489759,"avatar_url":"https://avatars1.githubusercontent.com/u/7489759?v=4","gravatar_id":"","url":"https://api.github.com/users/Hyask","html_url":"https://github.com/Hyask","followers_url":"https://api.github.com/users/Hyask/followers","following_url":"https://api.github.com/users/Hyask/following{/other_user}","gists_url":"https://api.github.com/users/Hyask/gists{/gist_id}","starred_url":"https://api.github.com/users/Hyask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hyask/subscriptions","organizations_url":"https://api.github.com/users/Hyask/orgs","repos_url":"https://api.github.com/users/Hyask/repos","events_url":"https://api.github.com/users/Hyask/events{/privacy}","received_events_url":"https://api.github.com/users/Hyask/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hyask/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/Hyask/radare2","forks_url":"https://api.github.com/repos/Hyask/radare2/forks","keys_url":"https://api.github.com/repos/Hyask/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hyask/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hyask/radare2/teams","hooks_url":"https://api.github.com/repos/Hyask/radare2/hooks","issue_events_url":"https://api.github.com/repos/Hyask/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/Hyask/radare2/events","assignees_url":"https://api.github.com/repos/Hyask/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/Hyask/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/Hyask/radare2/tags","blobs_url":"https://api.github.com/repos/Hyask/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hyask/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hyask/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hyask/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hyask/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/Hyask/radare2/languages","stargazers_url":"https://api.github.com/repos/Hyask/radare2/stargazers","contributors_url":"https://api.github.com/repos/Hyask/radare2/contributors","subscribers_url":"https://api.github.com/repos/Hyask/radare2/subscribers","subscription_url":"https://api.github.com/repos/Hyask/radare2/subscription","commits_url":"https://api.github.com/repos/Hyask/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hyask/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hyask/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hyask/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hyask/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/Hyask/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hyask/radare2/merges","archive_url":"https://api.github.com/repos/Hyask/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hyask/radare2/downloads","issues_url":"https://api.github.com/repos/Hyask/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/Hyask/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/Hyask/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/Hyask/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hyask/radare2/labels{/name}","releases_url":"https://api.github.com/repos/Hyask/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/Hyask/radare2/deployments","created_at":"2014-05-08T00:17:07Z","updated_at":"2016-02-08T10:37:24Z","pushed_at":"2018-03-14T10:57:48Z","git_url":"git://github.com/Hyask/radare2.git","ssh_url":"git@github.com:Hyask/radare2.git","clone_url":"https://github.com/Hyask/radare2.git","svn_url":"https://github.com/Hyask/radare2","homepage":"http://www.radare.org/","size":81750,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"cd5f69b094441a664bfb38d913cb1ff599e15435","user":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-03-14T11:58:25Z","pushed_at":"2018-03-14T11:58:20Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":81909,"stargazers_count":6912,"watchers_count":6912,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1403,"mirror_url":null,"archived":false,"open_issues_count":853,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":1403,"open_issues":853,"watchers":6912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/9689"},"html":{"href":"https://github.com/radare/radare2/pull/9689"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/9689"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/9689/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/9689/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/9689/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/d8a32623e20f7766ab0f9172627c285214a9eb02"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"radare"}}