{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/201855871","pull_request_review_id":136441316,"id":201855871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg1NTg3MQ==","diff_hunk":"@@ -2586,6 +2587,7 @@ def maybe_convert_indices(indices, n):\n     IndexError : one of the converted indices either exceeded the number\n         of elements (specified by `n`) OR was still negative.\n     \"\"\"\n+    indices = deepcopy(indices)","path":"pandas/core/indexing.py","position":10,"original_position":10,"commit_id":"8c6161cc43efeebcd4cf22de2b0c0aa89e2ab802","original_commit_id":"8c6161cc43efeebcd4cf22de2b0c0aa89e2ab802","user":{"login":"ydovzhenko","id":25446341,"node_id":"MDQ6VXNlcjI1NDQ2MzQx","avatar_url":"https://avatars3.githubusercontent.com/u/25446341?v=4","gravatar_id":"","url":"https://api.github.com/users/ydovzhenko","html_url":"https://github.com/ydovzhenko","followers_url":"https://api.github.com/users/ydovzhenko/followers","following_url":"https://api.github.com/users/ydovzhenko/following{/other_user}","gists_url":"https://api.github.com/users/ydovzhenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ydovzhenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydovzhenko/subscriptions","organizations_url":"https://api.github.com/users/ydovzhenko/orgs","repos_url":"https://api.github.com/users/ydovzhenko/repos","events_url":"https://api.github.com/users/ydovzhenko/events{/privacy}","received_events_url":"https://api.github.com/users/ydovzhenko/received_events","type":"User","site_admin":false},"body":"Ok moving deepcopy to 2601 makes sense; will do. Can't see a way to avoid copying altogether.","created_at":"2018-07-11T22:10:52Z","updated_at":"2018-07-11T22:10:52Z","html_url":"https://github.com/pandas-dev/pandas/pull/21867#discussion_r201855871","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/201855871"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21867#discussion_r201855871"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867"}},"in_reply_to_id":201854183},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867","id":200836525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODM2NTI1","html_url":"https://github.com/pandas-dev/pandas/pull/21867","diff_url":"https://github.com/pandas-dev/pandas/pull/21867.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21867.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21867","number":21867,"state":"open","locked":false,"title":"BUG: np array indexer modifed in iloc","user":{"login":"ydovzhenko","id":25446341,"node_id":"MDQ6VXNlcjI1NDQ2MzQx","avatar_url":"https://avatars3.githubusercontent.com/u/25446341?v=4","gravatar_id":"","url":"https://api.github.com/users/ydovzhenko","html_url":"https://github.com/ydovzhenko","followers_url":"https://api.github.com/users/ydovzhenko/followers","following_url":"https://api.github.com/users/ydovzhenko/following{/other_user}","gists_url":"https://api.github.com/users/ydovzhenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ydovzhenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydovzhenko/subscriptions","organizations_url":"https://api.github.com/users/ydovzhenko/orgs","repos_url":"https://api.github.com/users/ydovzhenko/repos","events_url":"https://api.github.com/users/ydovzhenko/events{/privacy}","received_events_url":"https://api.github.com/users/ydovzhenko/received_events","type":"User","site_admin":false},"body":"- [ x ] closes #20852 \r\n- [ x ] tests passed\r\n- [ x ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`","created_at":"2018-07-11T21:55:39Z","updated_at":"2018-07-11T22:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c702d28d7ef5db52870bf05501693e07f4169c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21867/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/8c6161cc43efeebcd4cf22de2b0c0aa89e2ab802","head":{"label":"ydovzhenko:array-modification-on-iloc","ref":"array-modification-on-iloc","sha":"8c6161cc43efeebcd4cf22de2b0c0aa89e2ab802","user":{"login":"ydovzhenko","id":25446341,"node_id":"MDQ6VXNlcjI1NDQ2MzQx","avatar_url":"https://avatars3.githubusercontent.com/u/25446341?v=4","gravatar_id":"","url":"https://api.github.com/users/ydovzhenko","html_url":"https://github.com/ydovzhenko","followers_url":"https://api.github.com/users/ydovzhenko/followers","following_url":"https://api.github.com/users/ydovzhenko/following{/other_user}","gists_url":"https://api.github.com/users/ydovzhenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ydovzhenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydovzhenko/subscriptions","organizations_url":"https://api.github.com/users/ydovzhenko/orgs","repos_url":"https://api.github.com/users/ydovzhenko/repos","events_url":"https://api.github.com/users/ydovzhenko/events{/privacy}","received_events_url":"https://api.github.com/users/ydovzhenko/received_events","type":"User","site_admin":false},"repo":{"id":140492095,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0OTIwOTU=","name":"pandas","full_name":"ydovzhenko/pandas","owner":{"login":"ydovzhenko","id":25446341,"node_id":"MDQ6VXNlcjI1NDQ2MzQx","avatar_url":"https://avatars3.githubusercontent.com/u/25446341?v=4","gravatar_id":"","url":"https://api.github.com/users/ydovzhenko","html_url":"https://github.com/ydovzhenko","followers_url":"https://api.github.com/users/ydovzhenko/followers","following_url":"https://api.github.com/users/ydovzhenko/following{/other_user}","gists_url":"https://api.github.com/users/ydovzhenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ydovzhenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydovzhenko/subscriptions","organizations_url":"https://api.github.com/users/ydovzhenko/orgs","repos_url":"https://api.github.com/users/ydovzhenko/repos","events_url":"https://api.github.com/users/ydovzhenko/events{/privacy}","received_events_url":"https://api.github.com/users/ydovzhenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ydovzhenko/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/ydovzhenko/pandas","forks_url":"https://api.github.com/repos/ydovzhenko/pandas/forks","keys_url":"https://api.github.com/repos/ydovzhenko/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ydovzhenko/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ydovzhenko/pandas/teams","hooks_url":"https://api.github.com/repos/ydovzhenko/pandas/hooks","issue_events_url":"https://api.github.com/repos/ydovzhenko/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/ydovzhenko/pandas/events","assignees_url":"https://api.github.com/repos/ydovzhenko/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/ydovzhenko/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/ydovzhenko/pandas/tags","blobs_url":"https://api.github.com/repos/ydovzhenko/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ydovzhenko/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ydovzhenko/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ydovzhenko/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ydovzhenko/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/ydovzhenko/pandas/languages","stargazers_url":"https://api.github.com/repos/ydovzhenko/pandas/stargazers","contributors_url":"https://api.github.com/repos/ydovzhenko/pandas/contributors","subscribers_url":"https://api.github.com/repos/ydovzhenko/pandas/subscribers","subscription_url":"https://api.github.com/repos/ydovzhenko/pandas/subscription","commits_url":"https://api.github.com/repos/ydovzhenko/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ydovzhenko/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ydovzhenko/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ydovzhenko/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ydovzhenko/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/ydovzhenko/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ydovzhenko/pandas/merges","archive_url":"https://api.github.com/repos/ydovzhenko/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ydovzhenko/pandas/downloads","issues_url":"https://api.github.com/repos/ydovzhenko/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/ydovzhenko/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/ydovzhenko/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/ydovzhenko/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ydovzhenko/pandas/labels{/name}","releases_url":"https://api.github.com/repos/ydovzhenko/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/ydovzhenko/pandas/deployments","created_at":"2018-07-10T22:08:52Z","updated_at":"2018-07-10T22:08:59Z","pushed_at":"2018-07-11T21:52:43Z","git_url":"git://github.com/ydovzhenko/pandas.git","ssh_url":"git@github.com:ydovzhenko/pandas.git","clone_url":"https://github.com/ydovzhenko/pandas.git","svn_url":"https://github.com/ydovzhenko/pandas","homepage":"http://pandas.pydata.org","size":126717,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"5d0daa0522730a6f999ceaf328f63f03dd62d0b4","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-07-11T21:48:02Z","pushed_at":"2018-07-11T21:55:40Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":126644,"stargazers_count":15034,"watchers_count":15034,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6047,"mirror_url":null,"archived":false,"open_issues_count":2606,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6047,"open_issues":2606,"watchers":15034,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21867"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21867"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21867/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21867/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/8c6161cc43efeebcd4cf22de2b0c0aa89e2ab802"}},"author_association":"NONE"}}
{"actor":{"display_login":"ydovzhenko"}}