{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/171269300","pull_request_review_id":100091502,"id":171269300,"diff_hunk":"@@ -267,13 +267,10 @@ subprojects { subproject ->\n project('spring-integration-test-support') {\n \tdescription = 'Spring Integration Test Support - **No SI Dependencies Allowed**'\n \tdependencies {\n-\t\tcompile (\"junit:junit:$junitVersion\") {\n-\t\t\texclude group: 'org.hamcrest', module: 'hamcrest-core'\n-\t\t}\n-\t\tcompile \"org.hamcrest:hamcrest-all:$hamcrestVersion\"\n-\t\tcompile (\"org.mockito:mockito-core:$mockitoVersion\") {\n-\t\t\texclude group: 'org.hamcrest', module: 'hamcrest-core'\n-\t\t}\n+\t\tcompile \"org.hamcrest:hamcrest-core:$hamcrestVersion\"\n+\t\tcompile \"org.hamcrest:hamcrest-library:$hamcrestVersion\"\n+\t\tcompile \"junit:junit:$junitVersion\"\n+\t\tcompile \"org.mockito:mockito-core:$mockitoVersion\"","path":"build.gradle","position":14,"original_position":14,"commit_id":"454f8bd4a5df733bd70e6e29ed2cd639a8617513","original_commit_id":"454f8bd4a5df733bd70e6e29ed2cd639a8617513","user":{"login":"drewtul","id":963775,"avatar_url":"https://avatars2.githubusercontent.com/u/963775?v=4","gravatar_id":"","url":"https://api.github.com/users/drewtul","html_url":"https://github.com/drewtul","followers_url":"https://api.github.com/users/drewtul/followers","following_url":"https://api.github.com/users/drewtul/following{/other_user}","gists_url":"https://api.github.com/users/drewtul/gists{/gist_id}","starred_url":"https://api.github.com/users/drewtul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewtul/subscriptions","organizations_url":"https://api.github.com/users/drewtul/orgs","repos_url":"https://api.github.com/users/drewtul/repos","events_url":"https://api.github.com/users/drewtul/events{/privacy}","received_events_url":"https://api.github.com/users/drewtul/received_events","type":"User","site_admin":false},"body":"@artembilan I think I was primarily bumping into it from here:\r\nhttps://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-starters/spring-boot-starter-test/pom.xml#L47\r\n\r\nAnd via third party deps of restassured that spring boot included.\r\n\r\nI'm really just looking for the most compatible way locally I can import multiple spring project BOM's without ending up with multiple JARs containing the same classes.\r\n\r\nI'm not sure if this is the perfect balance either, as there's no one clear right answer for this dependency.\r\n\r\nI can work around this locally by effectively dropping the BOM POM's deps into our project and adding exclusions for this.","created_at":"2018-02-28T14:52:36Z","updated_at":"2018-02-28T14:52:37Z","html_url":"https://github.com/spring-projects/spring-integration/pull/2380#discussion_r171269300","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/171269300"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/2380#discussion_r171269300"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380"}},"in_reply_to_id":171263591},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380","id":171966601,"html_url":"https://github.com/spring-projects/spring-integration/pull/2380","diff_url":"https://github.com/spring-projects/spring-integration/pull/2380.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/2380.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/2380","number":2380,"state":"open","locked":false,"title":"[INT-4402] spring-integration-test-support hamcrest-all dependency","user":{"login":"drewtul","id":963775,"avatar_url":"https://avatars2.githubusercontent.com/u/963775?v=4","gravatar_id":"","url":"https://api.github.com/users/drewtul","html_url":"https://github.com/drewtul","followers_url":"https://api.github.com/users/drewtul/followers","following_url":"https://api.github.com/users/drewtul/following{/other_user}","gists_url":"https://api.github.com/users/drewtul/gists{/gist_id}","starred_url":"https://api.github.com/users/drewtul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewtul/subscriptions","organizations_url":"https://api.github.com/users/drewtul/orgs","repos_url":"https://api.github.com/users/drewtul/repos","events_url":"https://api.github.com/users/drewtul/events{/privacy}","received_events_url":"https://api.github.com/users/drewtul/received_events","type":"User","site_admin":false},"body":"Use hamcrest-core and hamcrest-library in place of hamcrest-all to match behaviour of other spring projects and avoid multiple JARs containing the same classes.\r\n\r\n<!--\r\nThanks for contributing to Spring Integration. Please provide a brief description of your pull-request and reference any related issue numbers (prefix references with #).\r\n\r\nSee the [Contributor Guidelines for more information](https://github.com/spring-projects/spring-integration/blob/master/CONTRIBUTING.adoc).\r\n-->\r\n","created_at":"2018-02-28T14:21:17Z","updated_at":"2018-02-28T14:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1194314bd36c065a47a9ec9c4271087be25225f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/2380/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/454f8bd4a5df733bd70e6e29ed2cd639a8617513","head":{"label":"drewtul:INT-4420","ref":"INT-4420","sha":"454f8bd4a5df733bd70e6e29ed2cd639a8617513","user":{"login":"drewtul","id":963775,"avatar_url":"https://avatars2.githubusercontent.com/u/963775?v=4","gravatar_id":"","url":"https://api.github.com/users/drewtul","html_url":"https://github.com/drewtul","followers_url":"https://api.github.com/users/drewtul/followers","following_url":"https://api.github.com/users/drewtul/following{/other_user}","gists_url":"https://api.github.com/users/drewtul/gists{/gist_id}","starred_url":"https://api.github.com/users/drewtul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewtul/subscriptions","organizations_url":"https://api.github.com/users/drewtul/orgs","repos_url":"https://api.github.com/users/drewtul/repos","events_url":"https://api.github.com/users/drewtul/events{/privacy}","received_events_url":"https://api.github.com/users/drewtul/received_events","type":"User","site_admin":false},"repo":{"id":123293230,"name":"spring-integration","full_name":"drewtul/spring-integration","owner":{"login":"drewtul","id":963775,"avatar_url":"https://avatars2.githubusercontent.com/u/963775?v=4","gravatar_id":"","url":"https://api.github.com/users/drewtul","html_url":"https://github.com/drewtul","followers_url":"https://api.github.com/users/drewtul/followers","following_url":"https://api.github.com/users/drewtul/following{/other_user}","gists_url":"https://api.github.com/users/drewtul/gists{/gist_id}","starred_url":"https://api.github.com/users/drewtul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewtul/subscriptions","organizations_url":"https://api.github.com/users/drewtul/orgs","repos_url":"https://api.github.com/users/drewtul/repos","events_url":"https://api.github.com/users/drewtul/events{/privacy}","received_events_url":"https://api.github.com/users/drewtul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drewtul/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":true,"url":"https://api.github.com/repos/drewtul/spring-integration","forks_url":"https://api.github.com/repos/drewtul/spring-integration/forks","keys_url":"https://api.github.com/repos/drewtul/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewtul/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewtul/spring-integration/teams","hooks_url":"https://api.github.com/repos/drewtul/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/drewtul/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/drewtul/spring-integration/events","assignees_url":"https://api.github.com/repos/drewtul/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/drewtul/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/drewtul/spring-integration/tags","blobs_url":"https://api.github.com/repos/drewtul/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewtul/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewtul/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewtul/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewtul/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/drewtul/spring-integration/languages","stargazers_url":"https://api.github.com/repos/drewtul/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/drewtul/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/drewtul/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/drewtul/spring-integration/subscription","commits_url":"https://api.github.com/repos/drewtul/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewtul/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewtul/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewtul/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewtul/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/drewtul/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewtul/spring-integration/merges","archive_url":"https://api.github.com/repos/drewtul/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewtul/spring-integration/downloads","issues_url":"https://api.github.com/repos/drewtul/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/drewtul/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/drewtul/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/drewtul/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewtul/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/drewtul/spring-integration/releases{/id}","deployments_url":"https://api.github.com/repos/drewtul/spring-integration/deployments","created_at":"2018-02-28T14:04:09Z","updated_at":"2018-02-28T14:04:23Z","pushed_at":"2018-02-28T14:19:49Z","git_url":"git://github.com/drewtul/spring-integration.git","ssh_url":"git@github.com:drewtul/spring-integration.git","clone_url":"https://github.com/drewtul/spring-integration.git","svn_url":"https://github.com/drewtul/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":45581,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"792b8fe6d11327b1616201f87d4d68b4192545ba","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-integration/deployments","created_at":"2011-07-22T21:47:27Z","updated_at":"2018-02-25T15:00:33Z","pushed_at":"2018-02-28T14:32:32Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":45581,"stargazers_count":686,"watchers_count":686,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":596,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":596,"open_issues":7,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/2380"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/2380"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/2380/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2380/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/454f8bd4a5df733bd70e6e29ed2cd639a8617513"}},"author_association":"NONE"}}
{"actor":{"display_login":"drewtul"}}