{"action":"created","comment":{"url":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments/207816078","pull_request_review_id":143502203,"id":207816078,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgxNjA3OA==","diff_hunk":"@@ -48,15 +48,19 @@ struct mpi_traits<T> {  \\\n     constexpr static bool is_mpi_native_type() { return true; } \\\n };\n \n-MAKE_TRAITS(double, MPI_DOUBLE)\n-MAKE_TRAITS(float,  MPI_FLOAT)\n-MAKE_TRAITS(int,    MPI_INT)\n-MAKE_TRAITS(long int, MPI_LONG)\n-MAKE_TRAITS(char,   MPI_CHAR)\n-MAKE_TRAITS(unsigned int, MPI_UNSIGNED)\n-MAKE_TRAITS(size_t, MPI_UNSIGNED_LONG)\n-static_assert(sizeof(size_t)==sizeof(unsigned long),\n-              \"size_t and unsigned long are not equivalent\");\n+MAKE_TRAITS(float,              MPI_FLOAT)\n+MAKE_TRAITS(double,             MPI_DOUBLE)\n+MAKE_TRAITS(char,               MPI_CHAR)\n+MAKE_TRAITS(int,                MPI_INT)","path":"arbor/communication/mpi.hpp","position":16,"original_position":16,"commit_id":"6d5e4dbc82b320fef3d50b0c4c72955f4b09c5fe","original_commit_id":"6d5e4dbc82b320fef3d50b0c4c72955f4b09c5fe","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"I think it is safe to assume that people with the fingers in the code at this point won't need the signedness of int to be made explicit — indeed, I think adding in signed just here would make the less confident coder wonder if there is something they are missing elsewhere, and thus increase confusion.\r\n\r\nWe already had traits for types that don't have an interface in `distributed_context`, but I think that's okay. Having the traits for the basic numeric scalar types is fine IMO. I wouldn't object if `short` and `unsigned short` were added too, for example.","created_at":"2018-08-06T08:49:43Z","updated_at":"2018-08-06T08:49:43Z","html_url":"https://github.com/eth-cscs/arbor/pull/563#discussion_r207816078","pull_request_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/563","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments/207816078"},"html":{"href":"https://github.com/eth-cscs/arbor/pull/563#discussion_r207816078"},"pull_request":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/563"}},"in_reply_to_id":207793052},"pull_request":{"url":"https://api.github.com/repos/eth-cscs/arbor/pulls/563","id":206048828,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDQ4ODI4","html_url":"https://github.com/eth-cscs/arbor/pull/563","diff_url":"https://github.com/eth-cscs/arbor/pull/563.diff","patch_url":"https://github.com/eth-cscs/arbor/pull/563.patch","issue_url":"https://api.github.com/repos/eth-cscs/arbor/issues/563","number":563,"state":"open","locked":false,"title":"Bugfix/build osx macports","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"Two MacPorts/gcc7 issues:\r\n1. `std::uint64_t` is `unsigned long long` on OS X, breaking an assumption about `size_t` in the `distributed_context` interface.\r\n2. Problems with missing errno defines in the standard library headers.\r\n\r\nWith MacPorts gcc7, the installed `c++config.h` defines `_GLIBCXX_HAVE_EOWNERDEAD` and `_GLIBCXX_HAVE_ENOTRECOVERABLE`, but the corresponding errno defines are not provided by\r\n`sys/errno.h` unless `__DARWIN_C_SOURCE`, which takes its value from `_POSIX_C_SOURCE` if defined, is greater than or equal to 200809L. Technically a MacPorts configuration bug? but easily worked around.\r\n\r\n* Use basic integral types for communication collectives interfaces.\r\n* Define `_POSIX_C_SOURCE` to be 200809L for `glob.cpp`.\r\n\r\nFixes #562.","created_at":"2018-08-03T14:33:18Z","updated_at":"2018-08-06T08:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512bbdd3d4f00f49271e8b0aa7812f782f058dbe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"noraabiakar","id":18661075,"node_id":"MDQ6VXNlcjE4NjYxMDc1","avatar_url":"https://avatars1.githubusercontent.com/u/18661075?v=4","gravatar_id":"","url":"https://api.github.com/users/noraabiakar","html_url":"https://github.com/noraabiakar","followers_url":"https://api.github.com/users/noraabiakar/followers","following_url":"https://api.github.com/users/noraabiakar/following{/other_user}","gists_url":"https://api.github.com/users/noraabiakar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraabiakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraabiakar/subscriptions","organizations_url":"https://api.github.com/users/noraabiakar/orgs","repos_url":"https://api.github.com/users/noraabiakar/repos","events_url":"https://api.github.com/users/noraabiakar/events{/privacy}","received_events_url":"https://api.github.com/users/noraabiakar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/563/commits","review_comments_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/563/comments","review_comment_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eth-cscs/arbor/issues/563/comments","statuses_url":"https://api.github.com/repos/eth-cscs/arbor/statuses/6d5e4dbc82b320fef3d50b0c4c72955f4b09c5fe","head":{"label":"halfflat:bugfix/build-osx-macports","ref":"bugfix/build-osx-macports","sha":"6d5e4dbc82b320fef3d50b0c4c72955f4b09c5fe","user":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"repo":{"id":70549033,"node_id":"MDEwOlJlcG9zaXRvcnk3MDU0OTAzMw==","name":"arbor","full_name":"halfflat/arbor","owner":{"login":"halfflat","id":556816,"node_id":"MDQ6VXNlcjU1NjgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halfflat/arbor","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":true,"url":"https://api.github.com/repos/halfflat/arbor","forks_url":"https://api.github.com/repos/halfflat/arbor/forks","keys_url":"https://api.github.com/repos/halfflat/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halfflat/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halfflat/arbor/teams","hooks_url":"https://api.github.com/repos/halfflat/arbor/hooks","issue_events_url":"https://api.github.com/repos/halfflat/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/halfflat/arbor/events","assignees_url":"https://api.github.com/repos/halfflat/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/halfflat/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/halfflat/arbor/tags","blobs_url":"https://api.github.com/repos/halfflat/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halfflat/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halfflat/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/halfflat/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halfflat/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/halfflat/arbor/languages","stargazers_url":"https://api.github.com/repos/halfflat/arbor/stargazers","contributors_url":"https://api.github.com/repos/halfflat/arbor/contributors","subscribers_url":"https://api.github.com/repos/halfflat/arbor/subscribers","subscription_url":"https://api.github.com/repos/halfflat/arbor/subscription","commits_url":"https://api.github.com/repos/halfflat/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/halfflat/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/halfflat/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/halfflat/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/halfflat/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/halfflat/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halfflat/arbor/merges","archive_url":"https://api.github.com/repos/halfflat/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halfflat/arbor/downloads","issues_url":"https://api.github.com/repos/halfflat/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/halfflat/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/halfflat/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/halfflat/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halfflat/arbor/labels{/name}","releases_url":"https://api.github.com/repos/halfflat/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/halfflat/arbor/deployments","created_at":"2016-10-11T02:43:08Z","updated_at":"2018-07-31T12:44:22Z","pushed_at":"2018-08-03T14:28:02Z","git_url":"git://github.com/halfflat/arbor.git","ssh_url":"git@github.com:halfflat/arbor.git","clone_url":"https://github.com/halfflat/arbor.git","svn_url":"https://github.com/halfflat/arbor","homepage":"https://eth-cscs.github.io/nestmc/","size":4158,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eth-cscs:master","ref":"master","sha":"ac581c6b5c38331e05e20d00e994b959286c63b1","user":{"login":"eth-cscs","id":5744410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NDQ0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5744410?v=4","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2MzA3NA==","name":"arbor","full_name":"eth-cscs/arbor","owner":{"login":"eth-cscs","id":5744410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NDQ0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5744410?v=4","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eth-cscs/arbor","description":"The Arbor multi-compartment neural network simulation library.","fork":false,"url":"https://api.github.com/repos/eth-cscs/arbor","forks_url":"https://api.github.com/repos/eth-cscs/arbor/forks","keys_url":"https://api.github.com/repos/eth-cscs/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eth-cscs/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eth-cscs/arbor/teams","hooks_url":"https://api.github.com/repos/eth-cscs/arbor/hooks","issue_events_url":"https://api.github.com/repos/eth-cscs/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/eth-cscs/arbor/events","assignees_url":"https://api.github.com/repos/eth-cscs/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/eth-cscs/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/eth-cscs/arbor/tags","blobs_url":"https://api.github.com/repos/eth-cscs/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eth-cscs/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eth-cscs/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/eth-cscs/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eth-cscs/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/eth-cscs/arbor/languages","stargazers_url":"https://api.github.com/repos/eth-cscs/arbor/stargazers","contributors_url":"https://api.github.com/repos/eth-cscs/arbor/contributors","subscribers_url":"https://api.github.com/repos/eth-cscs/arbor/subscribers","subscription_url":"https://api.github.com/repos/eth-cscs/arbor/subscription","commits_url":"https://api.github.com/repos/eth-cscs/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/eth-cscs/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/eth-cscs/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/eth-cscs/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/eth-cscs/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/eth-cscs/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eth-cscs/arbor/merges","archive_url":"https://api.github.com/repos/eth-cscs/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eth-cscs/arbor/downloads","issues_url":"https://api.github.com/repos/eth-cscs/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/eth-cscs/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/eth-cscs/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/eth-cscs/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eth-cscs/arbor/labels{/name}","releases_url":"https://api.github.com/repos/eth-cscs/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/eth-cscs/arbor/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2018-07-31T11:00:16Z","pushed_at":"2018-08-03T14:33:18Z","git_url":"git://github.com/eth-cscs/arbor.git","ssh_url":"git@github.com:eth-cscs/arbor.git","clone_url":"https://github.com/eth-cscs/arbor.git","svn_url":"https://github.com/eth-cscs/arbor","homepage":"","size":3783,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":73,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/563"},"html":{"href":"https://github.com/eth-cscs/arbor/pull/563"},"issue":{"href":"https://api.github.com/repos/eth-cscs/arbor/issues/563"},"comments":{"href":"https://api.github.com/repos/eth-cscs/arbor/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/eth-cscs/arbor/statuses/6d5e4dbc82b320fef3d50b0c4c72955f4b09c5fe"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"halfflat"}}