{"action":"created","comment":{"url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/comments/216421271","pull_request_review_id":153897936,"id":216421271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQyMTI3MQ==","diff_hunk":"@@ -21,6 +21,20 @@ describe('Verify EventEmitter', function() {\n \n             thing.run(n)\n         })\n+\n+        it('should remove listeners for the test event', function(done) {\n+            let thing = new bindings.EmitterThing()\n+            thing.on('test1', function(ev) { })\n+            thing.on('test2', function(ev) { })\n+\n+            expect(thing.eventNames()).to.be.equal(['test2', 'test1'])\n+            thing.removeAllListeners('test1')\n+            expect(thing.eventNames()).to.be.equal(['test2'])\n+            thing.on('test1', function(ev) { })\n+            thing.removeAllListeners()","path":"test/js/eventemitter.js","position":14,"original_position":14,"commit_id":"928cf0ab8a2a12a9358aa43eee98fd67b9d077e5","original_commit_id":"928cf0ab8a2a12a9358aa43eee98fd67b9d077e5","user":{"login":"eladidan","id":5042281,"node_id":"MDQ6VXNlcjUwNDIyODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5042281?v=4","gravatar_id":"","url":"https://api.github.com/users/eladidan","html_url":"https://github.com/eladidan","followers_url":"https://api.github.com/users/eladidan/followers","following_url":"https://api.github.com/users/eladidan/following{/other_user}","gists_url":"https://api.github.com/users/eladidan/gists{/gist_id}","starred_url":"https://api.github.com/users/eladidan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladidan/subscriptions","organizations_url":"https://api.github.com/users/eladidan/orgs","repos_url":"https://api.github.com/users/eladidan/repos","events_url":"https://api.github.com/users/eladidan/events{/privacy}","received_events_url":"https://api.github.com/users/eladidan/received_events","type":"User","site_admin":false},"body":"I generally prefer 2 different behaviors to be split to 2 different tests, with state generation to be explicitly individual to each test","created_at":"2018-09-10T18:10:42Z","updated_at":"2018-09-10T18:10:42Z","html_url":"https://github.com/TakeScoop/cpp-eventemitter/pull/16#discussion_r216421271","pull_request_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/comments/216421271"},"html":{"href":"https://github.com/TakeScoop/cpp-eventemitter/pull/16#discussion_r216421271"},"pull_request":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16","id":210278158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjc4MTU4","html_url":"https://github.com/TakeScoop/cpp-eventemitter/pull/16","diff_url":"https://github.com/TakeScoop/cpp-eventemitter/pull/16.diff","patch_url":"https://github.com/TakeScoop/cpp-eventemitter/pull/16.patch","issue_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/16","number":16,"state":"open","locked":false,"title":"add removeAllListeners API","user":{"login":"jbeverly","id":768934,"node_id":"MDQ6VXNlcjc2ODkzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/768934?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeverly","html_url":"https://github.com/jbeverly","followers_url":"https://api.github.com/users/jbeverly/followers","following_url":"https://api.github.com/users/jbeverly/following{/other_user}","gists_url":"https://api.github.com/users/jbeverly/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeverly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeverly/subscriptions","organizations_url":"https://api.github.com/users/jbeverly/orgs","repos_url":"https://api.github.com/users/jbeverly/repos","events_url":"https://api.github.com/users/jbeverly/events{/privacy}","received_events_url":"https://api.github.com/users/jbeverly/received_events","type":"User","site_admin":false},"body":"This adds some additional methods to get slightly closer to the API described in https://nodejs.org/api/events.html \r\n\r\nSpecifically, this introduces:\r\n- https://nodejs.org/api/events.html#events_emitter_eventnames\r\n- https://nodejs.org/api/events.html#events_emitter_removealllisteners_eventname","created_at":"2018-08-22T22:04:36Z","updated_at":"2018-09-10T18:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"105480d6cf927474b4d761417934d3c4e2a8758a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16/commits","review_comments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16/comments","review_comment_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/16/comments","statuses_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/statuses/928cf0ab8a2a12a9358aa43eee98fd67b9d077e5","head":{"label":"TakeScoop:jamie/add_removeAllListeners_api","ref":"jamie/add_removeAllListeners_api","sha":"928cf0ab8a2a12a9358aa43eee98fd67b9d077e5","user":{"login":"TakeScoop","id":11507053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA3MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11507053?v=4","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"repo":{"id":95057721,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA1NzcyMQ==","name":"cpp-eventemitter","full_name":"TakeScoop/cpp-eventemitter","owner":{"login":"TakeScoop","id":11507053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA3MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11507053?v=4","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TakeScoop/cpp-eventemitter","description":"Node.js native EventEmitter. Allows you to implement Native C++ code that behaves like an EventEmitter","fork":false,"url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter","forks_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/forks","keys_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/teams","hooks_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/hooks","issue_events_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/events{/number}","events_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/events","assignees_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/assignees{/user}","branches_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/branches{/branch}","tags_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/tags","blobs_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/statuses/{sha}","languages_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/languages","stargazers_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/stargazers","contributors_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/contributors","subscribers_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/subscribers","subscription_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/subscription","commits_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/contents/{+path}","compare_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/merges","archive_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/downloads","issues_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues{/number}","pulls_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls{/number}","milestones_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/milestones{/number}","notifications_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/labels{/name}","releases_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/releases{/id}","deployments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/deployments","created_at":"2017-06-22T00:22:02Z","updated_at":"2018-08-20T19:39:17Z","pushed_at":"2018-08-23T00:55:47Z","git_url":"git://github.com/TakeScoop/cpp-eventemitter.git","ssh_url":"git@github.com:TakeScoop/cpp-eventemitter.git","clone_url":"https://github.com/TakeScoop/cpp-eventemitter.git","svn_url":"https://github.com/TakeScoop/cpp-eventemitter","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"TakeScoop:master","ref":"master","sha":"68ef2cb083ae9ea924cf1223e1ec1a3480619ec7","user":{"login":"TakeScoop","id":11507053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA3MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11507053?v=4","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"repo":{"id":95057721,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA1NzcyMQ==","name":"cpp-eventemitter","full_name":"TakeScoop/cpp-eventemitter","owner":{"login":"TakeScoop","id":11507053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA3MDUz","avatar_url":"https://avatars1.githubusercontent.com/u/11507053?v=4","gravatar_id":"","url":"https://api.github.com/users/TakeScoop","html_url":"https://github.com/TakeScoop","followers_url":"https://api.github.com/users/TakeScoop/followers","following_url":"https://api.github.com/users/TakeScoop/following{/other_user}","gists_url":"https://api.github.com/users/TakeScoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TakeScoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TakeScoop/subscriptions","organizations_url":"https://api.github.com/users/TakeScoop/orgs","repos_url":"https://api.github.com/users/TakeScoop/repos","events_url":"https://api.github.com/users/TakeScoop/events{/privacy}","received_events_url":"https://api.github.com/users/TakeScoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TakeScoop/cpp-eventemitter","description":"Node.js native EventEmitter. Allows you to implement Native C++ code that behaves like an EventEmitter","fork":false,"url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter","forks_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/forks","keys_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/teams","hooks_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/hooks","issue_events_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/events{/number}","events_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/events","assignees_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/assignees{/user}","branches_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/branches{/branch}","tags_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/tags","blobs_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/statuses/{sha}","languages_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/languages","stargazers_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/stargazers","contributors_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/contributors","subscribers_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/subscribers","subscription_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/subscription","commits_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/contents/{+path}","compare_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/merges","archive_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/downloads","issues_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues{/number}","pulls_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls{/number}","milestones_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/milestones{/number}","notifications_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/labels{/name}","releases_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/releases{/id}","deployments_url":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/deployments","created_at":"2017-06-22T00:22:02Z","updated_at":"2018-08-20T19:39:17Z","pushed_at":"2018-08-23T00:55:47Z","git_url":"git://github.com/TakeScoop/cpp-eventemitter.git","ssh_url":"git@github.com:TakeScoop/cpp-eventemitter.git","clone_url":"https://github.com/TakeScoop/cpp-eventemitter.git","svn_url":"https://github.com/TakeScoop/cpp-eventemitter","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16"},"html":{"href":"https://github.com/TakeScoop/cpp-eventemitter/pull/16"},"issue":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/16"},"comments":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/TakeScoop/cpp-eventemitter/statuses/928cf0ab8a2a12a9358aa43eee98fd67b9d077e5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"eladidan"}}