{"action":"created","comment":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/comments/210477625","pull_request_review_id":146699870,"id":210477625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQ3NzYyNQ==","diff_hunk":"@@ -246,18 +246,20 @@ function provideDeclarationFilesToWebpack(\n     }\n \n     const outputFiles = getEmitOutput(instance, filePath);\n-    const declarationFile = outputFiles\n-      .filter(outputFile => outputFile.name.match(constants.dtsDtsxRegex))\n-      .pop();\n-    if (declarationFile !== undefined) {\n-      const assetPath = path.relative(\n-        compilation.compiler.context,\n-        declarationFile.name\n-      );\n-      compilation.assets[assetPath] = {\n-        source: () => declarationFile.text,\n-        size: () => declarationFile.text.length\n-      };\n+    const declarationFiles: typescript.OutputFile[] = outputFiles\n+      .filter((outputFile: typescript.OutputFile) => outputFile.name.match(constants.dtsDtsxRegex));","path":"src/after-compile.ts","position":null,"original_position":24,"commit_id":"994b81b1d84ed7dfa835a8198671cefdf56f6901","original_commit_id":"58ee369921efd8d833ffd87edd1f72ebd023480a","user":{"login":"JonWallsten","id":5993909,"node_id":"MDQ6VXNlcjU5OTM5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5993909?v=4","gravatar_id":"","url":"https://api.github.com/users/JonWallsten","html_url":"https://github.com/JonWallsten","followers_url":"https://api.github.com/users/JonWallsten/followers","following_url":"https://api.github.com/users/JonWallsten/following{/other_user}","gists_url":"https://api.github.com/users/JonWallsten/gists{/gist_id}","starred_url":"https://api.github.com/users/JonWallsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonWallsten/subscriptions","organizations_url":"https://api.github.com/users/JonWallsten/orgs","repos_url":"https://api.github.com/users/JonWallsten/repos","events_url":"https://api.github.com/users/JonWallsten/events{/privacy}","received_events_url":"https://api.github.com/users/JonWallsten/received_events","type":"User","site_admin":false},"body":"Yeah, you are correct. I reinstalled VS Code, and it works now. I'm removing these.","created_at":"2018-08-16T05:05:44Z","updated_at":"2018-08-16T05:05:44Z","html_url":"https://github.com/TypeStrong/ts-loader/pull/821#discussion_r210477625","pull_request_url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/comments/210477625"},"html":{"href":"https://github.com/TypeStrong/ts-loader/pull/821#discussion_r210477625"},"pull_request":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821"}},"in_reply_to_id":210303488},"pull_request":{"url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821","id":208494434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDk0NDM0","html_url":"https://github.com/TypeStrong/ts-loader/pull/821","diff_url":"https://github.com/TypeStrong/ts-loader/pull/821.diff","patch_url":"https://github.com/TypeStrong/ts-loader/pull/821.patch","issue_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/821","number":821,"state":"open","locked":false,"title":"Added support for TypeScript declaration map","user":{"login":"JonWallsten","id":5993909,"node_id":"MDQ6VXNlcjU5OTM5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5993909?v=4","gravatar_id":"","url":"https://api.github.com/users/JonWallsten","html_url":"https://github.com/JonWallsten","followers_url":"https://api.github.com/users/JonWallsten/followers","following_url":"https://api.github.com/users/JonWallsten/following{/other_user}","gists_url":"https://api.github.com/users/JonWallsten/gists{/gist_id}","starred_url":"https://api.github.com/users/JonWallsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonWallsten/subscriptions","organizations_url":"https://api.github.com/users/JonWallsten/orgs","repos_url":"https://api.github.com/users/JonWallsten/repos","events_url":"https://api.github.com/users/JonWallsten/events{/privacy}","received_events_url":"https://api.github.com/users/JonWallsten/received_events","type":"User","site_admin":false},"body":"@johnnyreilly: Please check this out and let me know if you want any changes or if I did something wrong creating the tests.\r\n\r\nFix for https://github.com/TypeStrong/ts-loader/issues/820","created_at":"2018-08-15T07:48:10Z","updated_at":"2018-08-16T05:05:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abf7fcf385cba3de566c5bd0a6ad0cd620ce8cdd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821/commits","review_comments_url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821/comments","review_comment_url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/821/comments","statuses_url":"https://api.github.com/repos/TypeStrong/ts-loader/statuses/994b81b1d84ed7dfa835a8198671cefdf56f6901","head":{"label":"JonWallsten:support-for-declaration-map","ref":"support-for-declaration-map","sha":"994b81b1d84ed7dfa835a8198671cefdf56f6901","user":{"login":"JonWallsten","id":5993909,"node_id":"MDQ6VXNlcjU5OTM5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5993909?v=4","gravatar_id":"","url":"https://api.github.com/users/JonWallsten","html_url":"https://github.com/JonWallsten","followers_url":"https://api.github.com/users/JonWallsten/followers","following_url":"https://api.github.com/users/JonWallsten/following{/other_user}","gists_url":"https://api.github.com/users/JonWallsten/gists{/gist_id}","starred_url":"https://api.github.com/users/JonWallsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonWallsten/subscriptions","organizations_url":"https://api.github.com/users/JonWallsten/orgs","repos_url":"https://api.github.com/users/JonWallsten/repos","events_url":"https://api.github.com/users/JonWallsten/events{/privacy}","received_events_url":"https://api.github.com/users/JonWallsten/received_events","type":"User","site_admin":false},"repo":{"id":144820584,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MjA1ODQ=","name":"ts-loader","full_name":"JonWallsten/ts-loader","owner":{"login":"JonWallsten","id":5993909,"node_id":"MDQ6VXNlcjU5OTM5MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5993909?v=4","gravatar_id":"","url":"https://api.github.com/users/JonWallsten","html_url":"https://github.com/JonWallsten","followers_url":"https://api.github.com/users/JonWallsten/followers","following_url":"https://api.github.com/users/JonWallsten/following{/other_user}","gists_url":"https://api.github.com/users/JonWallsten/gists{/gist_id}","starred_url":"https://api.github.com/users/JonWallsten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonWallsten/subscriptions","organizations_url":"https://api.github.com/users/JonWallsten/orgs","repos_url":"https://api.github.com/users/JonWallsten/repos","events_url":"https://api.github.com/users/JonWallsten/events{/privacy}","received_events_url":"https://api.github.com/users/JonWallsten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonWallsten/ts-loader","description":"TypeScript loader for webpack","fork":true,"url":"https://api.github.com/repos/JonWallsten/ts-loader","forks_url":"https://api.github.com/repos/JonWallsten/ts-loader/forks","keys_url":"https://api.github.com/repos/JonWallsten/ts-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonWallsten/ts-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonWallsten/ts-loader/teams","hooks_url":"https://api.github.com/repos/JonWallsten/ts-loader/hooks","issue_events_url":"https://api.github.com/repos/JonWallsten/ts-loader/issues/events{/number}","events_url":"https://api.github.com/repos/JonWallsten/ts-loader/events","assignees_url":"https://api.github.com/repos/JonWallsten/ts-loader/assignees{/user}","branches_url":"https://api.github.com/repos/JonWallsten/ts-loader/branches{/branch}","tags_url":"https://api.github.com/repos/JonWallsten/ts-loader/tags","blobs_url":"https://api.github.com/repos/JonWallsten/ts-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonWallsten/ts-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonWallsten/ts-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonWallsten/ts-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonWallsten/ts-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/JonWallsten/ts-loader/languages","stargazers_url":"https://api.github.com/repos/JonWallsten/ts-loader/stargazers","contributors_url":"https://api.github.com/repos/JonWallsten/ts-loader/contributors","subscribers_url":"https://api.github.com/repos/JonWallsten/ts-loader/subscribers","subscription_url":"https://api.github.com/repos/JonWallsten/ts-loader/subscription","commits_url":"https://api.github.com/repos/JonWallsten/ts-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonWallsten/ts-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonWallsten/ts-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonWallsten/ts-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonWallsten/ts-loader/contents/{+path}","compare_url":"https://api.github.com/repos/JonWallsten/ts-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonWallsten/ts-loader/merges","archive_url":"https://api.github.com/repos/JonWallsten/ts-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonWallsten/ts-loader/downloads","issues_url":"https://api.github.com/repos/JonWallsten/ts-loader/issues{/number}","pulls_url":"https://api.github.com/repos/JonWallsten/ts-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/JonWallsten/ts-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/JonWallsten/ts-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonWallsten/ts-loader/labels{/name}","releases_url":"https://api.github.com/repos/JonWallsten/ts-loader/releases{/id}","deployments_url":"https://api.github.com/repos/JonWallsten/ts-loader/deployments","created_at":"2018-08-15T07:30:21Z","updated_at":"2018-08-15T07:30:26Z","pushed_at":"2018-08-16T04:52:49Z","git_url":"git://github.com/JonWallsten/ts-loader.git","ssh_url":"git@github.com:JonWallsten/ts-loader.git","clone_url":"https://github.com/JonWallsten/ts-loader.git","svn_url":"https://github.com/JonWallsten/ts-loader","homepage":"https://blog.johnnyreilly.com/2018/02/ts-loader-400-fork-ts-checker-webpack.html","size":2567,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TypeStrong:master","ref":"master","sha":"2c661e0bd72aa927ef7529e997a51ae509f4ff3f","user":{"login":"TypeStrong","id":6759814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTk4MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"repo":{"id":29561893,"node_id":"MDEwOlJlcG9zaXRvcnkyOTU2MTg5Mw==","name":"ts-loader","full_name":"TypeStrong/ts-loader","owner":{"login":"TypeStrong","id":6759814,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTk4MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6759814?v=4","gravatar_id":"","url":"https://api.github.com/users/TypeStrong","html_url":"https://github.com/TypeStrong","followers_url":"https://api.github.com/users/TypeStrong/followers","following_url":"https://api.github.com/users/TypeStrong/following{/other_user}","gists_url":"https://api.github.com/users/TypeStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/TypeStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TypeStrong/subscriptions","organizations_url":"https://api.github.com/users/TypeStrong/orgs","repos_url":"https://api.github.com/users/TypeStrong/repos","events_url":"https://api.github.com/users/TypeStrong/events{/privacy}","received_events_url":"https://api.github.com/users/TypeStrong/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TypeStrong/ts-loader","description":"TypeScript loader for webpack","fork":false,"url":"https://api.github.com/repos/TypeStrong/ts-loader","forks_url":"https://api.github.com/repos/TypeStrong/ts-loader/forks","keys_url":"https://api.github.com/repos/TypeStrong/ts-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TypeStrong/ts-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TypeStrong/ts-loader/teams","hooks_url":"https://api.github.com/repos/TypeStrong/ts-loader/hooks","issue_events_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/events{/number}","events_url":"https://api.github.com/repos/TypeStrong/ts-loader/events","assignees_url":"https://api.github.com/repos/TypeStrong/ts-loader/assignees{/user}","branches_url":"https://api.github.com/repos/TypeStrong/ts-loader/branches{/branch}","tags_url":"https://api.github.com/repos/TypeStrong/ts-loader/tags","blobs_url":"https://api.github.com/repos/TypeStrong/ts-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TypeStrong/ts-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TypeStrong/ts-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/TypeStrong/ts-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TypeStrong/ts-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/TypeStrong/ts-loader/languages","stargazers_url":"https://api.github.com/repos/TypeStrong/ts-loader/stargazers","contributors_url":"https://api.github.com/repos/TypeStrong/ts-loader/contributors","subscribers_url":"https://api.github.com/repos/TypeStrong/ts-loader/subscribers","subscription_url":"https://api.github.com/repos/TypeStrong/ts-loader/subscription","commits_url":"https://api.github.com/repos/TypeStrong/ts-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/TypeStrong/ts-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/TypeStrong/ts-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/TypeStrong/ts-loader/contents/{+path}","compare_url":"https://api.github.com/repos/TypeStrong/ts-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TypeStrong/ts-loader/merges","archive_url":"https://api.github.com/repos/TypeStrong/ts-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TypeStrong/ts-loader/downloads","issues_url":"https://api.github.com/repos/TypeStrong/ts-loader/issues{/number}","pulls_url":"https://api.github.com/repos/TypeStrong/ts-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/TypeStrong/ts-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/TypeStrong/ts-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TypeStrong/ts-loader/labels{/name}","releases_url":"https://api.github.com/repos/TypeStrong/ts-loader/releases{/id}","deployments_url":"https://api.github.com/repos/TypeStrong/ts-loader/deployments","created_at":"2015-01-21T00:00:16Z","updated_at":"2018-08-15T19:14:09Z","pushed_at":"2018-08-16T04:52:50Z","git_url":"git://github.com/TypeStrong/ts-loader.git","ssh_url":"git@github.com:TypeStrong/ts-loader.git","clone_url":"https://github.com/TypeStrong/ts-loader.git","svn_url":"https://github.com/TypeStrong/ts-loader","homepage":"https://blog.johnnyreilly.com/2018/02/ts-loader-400-fork-ts-checker-webpack.html","size":2565,"stargazers_count":1510,"watchers_count":1510,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":209,"open_issues":124,"watchers":1510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821"},"html":{"href":"https://github.com/TypeStrong/ts-loader/pull/821"},"issue":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/issues/821"},"comments":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/TypeStrong/ts-loader/statuses/994b81b1d84ed7dfa835a8198671cefdf56f6901"}},"author_association":"NONE"}}
{"actor":{"display_login":"JonWallsten"}}