{"action":"created","comment":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/comments/184246972","pull_request_review_id":115403365,"id":184246972,"diff_hunk":"@@ -0,0 +1,25 @@\n+#!/bin/sh\n+#\n+# Copyright (C) 2016 LEDE\n+#\n+\n+[ -e /etc/config/ubootenv ] && exit 0\n+\n+touch /etc/config/ubootenv\n+\n+. /lib/uboot-envtools.sh\n+. /lib/functions.sh\n+\n+board=$(board_name)\n+\n+case \"$board\" in\n+\ttraverse,ls1043v | \\\n+\ttraverse,ls1043s)\n+\t\tubootenv_add_uci_config \"/dev/mtd1\" \"0x40000\" \"0x2000\"  \"0x20000\"\n+\t;;","path":"package/boot/uboot-envtools/files/layerscape","position":19,"original_position":19,"commit_id":"5572614f5b702af688c8a1aa5be76e095f8a6cbd","original_commit_id":"5572614f5b702af688c8a1aa5be76e095f8a6cbd","user":{"login":"mcbridematt","id":26113015,"avatar_url":"https://avatars3.githubusercontent.com/u/26113015?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbridematt","html_url":"https://github.com/mcbridematt","followers_url":"https://api.github.com/users/mcbridematt/followers","following_url":"https://api.github.com/users/mcbridematt/following{/other_user}","gists_url":"https://api.github.com/users/mcbridematt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbridematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbridematt/subscriptions","organizations_url":"https://api.github.com/users/mcbridematt/orgs","repos_url":"https://api.github.com/users/mcbridematt/repos","events_url":"https://api.github.com/users/mcbridematt/events{/privacy}","received_events_url":"https://api.github.com/users/mcbridematt/received_events","type":"User","site_admin":false},"body":"Good question, the structure here is exactly the same as the other archs in uboot-envtools/files/\r\n\r\nI think the intention was that a config for an unknown board in UCI will be retained (by \"config_foreach ubootenv_add_app_config ubootenv\" underneath), that said, I'm not sure why you would inject it elsewhere. \r\n\r\nProbably warrants a investigation of the uboot-envtools package itself.","created_at":"2018-04-26T01:06:58Z","updated_at":"2018-04-26T01:06:58Z","html_url":"https://github.com/openwrt/openwrt/pull/895#discussion_r184246972","pull_request_url":"https://api.github.com/repos/openwrt/openwrt/pulls/895","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/comments/184246972"},"html":{"href":"https://github.com/openwrt/openwrt/pull/895#discussion_r184246972"},"pull_request":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/895"}},"in_reply_to_id":184124863},"pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/895","id":183924298,"html_url":"https://github.com/openwrt/openwrt/pull/895","diff_url":"https://github.com/openwrt/openwrt/pull/895.diff","patch_url":"https://github.com/openwrt/openwrt/pull/895.patch","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/895","number":895,"state":"open","locked":false,"title":"layerscape: add Traverse LS1043-S board","user":{"login":"mcbridematt","id":26113015,"avatar_url":"https://avatars3.githubusercontent.com/u/26113015?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbridematt","html_url":"https://github.com/mcbridematt","followers_url":"https://api.github.com/users/mcbridematt/followers","following_url":"https://api.github.com/users/mcbridematt/following{/other_user}","gists_url":"https://api.github.com/users/mcbridematt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbridematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbridematt/subscriptions","organizations_url":"https://api.github.com/users/mcbridematt/orgs","repos_url":"https://api.github.com/users/mcbridematt/repos","events_url":"https://api.github.com/users/mcbridematt/events{/privacy}","received_events_url":"https://api.github.com/users/mcbridematt/received_events","type":"User","site_admin":false},"body":"The Traverse LS1043-S board is a router board based on NXP/Freescale's LS1043 SoC, with 4x1GBase-T, 1 SFP and 1 SFP+, as well as 2xminiPCIe (for dual band WiFi), M.2/B LTE and M.2/M SATA (via USB bridge).\r\n\r\nUnlike the Layerscape reference boards, the LS1043S board has NAND flash and uses the mainline U-Boot.\r\n\r\nThis patchset implements support for the LS1043-S board, as well as the earlier LS1043-V board (which was sampled, but not produced). The FIT image generated is a multi-configuration image\r\nthat has DTBs embedded for both boards.\r\n\r\nThe target name is set to 'traverse-five64' as that product will become the 'flagship' for this range.\r\nIt is our intention that all boards in this family (LS1043-S and later, Five64) will boot the same binary.\r\n\r\nNot included in this patch are the hwmon drivers not in the kernel (emc1704,pac1934), bootloader or \"rescue\" SD card creation, which will be added at a later date, pending upstream.\r\n\r\nWe also have a version of the layerscape target with kernel 4.14 operational, but I can't vouch for other Layerscape platforms (LS1012,1046,LS1088 etc.)\r\n\r\nProduct Page: https://traverse.com.au/products/ls1043s-router-board/\r\nManual: https://traverse.com.au/docs/ls1043s/\r\nOur repositories: https://gitlab.com/traversetech\r\n\r\nSigned-off-by: Mathew McBride <matt@traverse.com.au>","created_at":"2018-04-25T04:51:27Z","updated_at":"2018-04-26T01:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7241c2553d848700e30261ffc36a88686f9f52e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":793818619,"url":"https://api.github.com/repos/openwrt/openwrt/labels/layerscape","name":"layerscape","color":"0043e4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openwrt/openwrt/pulls/895/commits","review_comments_url":"https://api.github.com/repos/openwrt/openwrt/pulls/895/comments","review_comment_url":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/895/comments","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/5572614f5b702af688c8a1aa5be76e095f8a6cbd","head":{"label":"mcbridematt:add_traverse_ls1043s_board","ref":"add_traverse_ls1043s_board","sha":"5572614f5b702af688c8a1aa5be76e095f8a6cbd","user":{"login":"mcbridematt","id":26113015,"avatar_url":"https://avatars3.githubusercontent.com/u/26113015?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbridematt","html_url":"https://github.com/mcbridematt","followers_url":"https://api.github.com/users/mcbridematt/followers","following_url":"https://api.github.com/users/mcbridematt/following{/other_user}","gists_url":"https://api.github.com/users/mcbridematt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbridematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbridematt/subscriptions","organizations_url":"https://api.github.com/users/mcbridematt/orgs","repos_url":"https://api.github.com/users/mcbridematt/repos","events_url":"https://api.github.com/users/mcbridematt/events{/privacy}","received_events_url":"https://api.github.com/users/mcbridematt/received_events","type":"User","site_admin":false},"repo":{"id":118285595,"name":"openwrt","full_name":"mcbridematt/openwrt","owner":{"login":"mcbridematt","id":26113015,"avatar_url":"https://avatars3.githubusercontent.com/u/26113015?v=4","gravatar_id":"","url":"https://api.github.com/users/mcbridematt","html_url":"https://github.com/mcbridematt","followers_url":"https://api.github.com/users/mcbridematt/followers","following_url":"https://api.github.com/users/mcbridematt/following{/other_user}","gists_url":"https://api.github.com/users/mcbridematt/gists{/gist_id}","starred_url":"https://api.github.com/users/mcbridematt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcbridematt/subscriptions","organizations_url":"https://api.github.com/users/mcbridematt/orgs","repos_url":"https://api.github.com/users/mcbridematt/repos","events_url":"https://api.github.com/users/mcbridematt/events{/privacy}","received_events_url":"https://api.github.com/users/mcbridematt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcbridematt/openwrt","description":"This repository is a mirror of https://git.openwrt.org/openwrt/openwrt.git It is for reference only and is not active for check-ins or for reporting issues.  We will continue to accept Pull Requests here. They will be merged via staging trees then into openwrt.git. All issues should be reported at: https://bugs.openwrt.org","fork":true,"url":"https://api.github.com/repos/mcbridematt/openwrt","forks_url":"https://api.github.com/repos/mcbridematt/openwrt/forks","keys_url":"https://api.github.com/repos/mcbridematt/openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcbridematt/openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcbridematt/openwrt/teams","hooks_url":"https://api.github.com/repos/mcbridematt/openwrt/hooks","issue_events_url":"https://api.github.com/repos/mcbridematt/openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/mcbridematt/openwrt/events","assignees_url":"https://api.github.com/repos/mcbridematt/openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/mcbridematt/openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/mcbridematt/openwrt/tags","blobs_url":"https://api.github.com/repos/mcbridematt/openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcbridematt/openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcbridematt/openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcbridematt/openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcbridematt/openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/mcbridematt/openwrt/languages","stargazers_url":"https://api.github.com/repos/mcbridematt/openwrt/stargazers","contributors_url":"https://api.github.com/repos/mcbridematt/openwrt/contributors","subscribers_url":"https://api.github.com/repos/mcbridematt/openwrt/subscribers","subscription_url":"https://api.github.com/repos/mcbridematt/openwrt/subscription","commits_url":"https://api.github.com/repos/mcbridematt/openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcbridematt/openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcbridematt/openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcbridematt/openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcbridematt/openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/mcbridematt/openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcbridematt/openwrt/merges","archive_url":"https://api.github.com/repos/mcbridematt/openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcbridematt/openwrt/downloads","issues_url":"https://api.github.com/repos/mcbridematt/openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/mcbridematt/openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/mcbridematt/openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/mcbridematt/openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcbridematt/openwrt/labels{/name}","releases_url":"https://api.github.com/repos/mcbridematt/openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/mcbridematt/openwrt/deployments","created_at":"2018-01-20T22:23:48Z","updated_at":"2018-01-20T22:24:06Z","pushed_at":"2018-04-25T04:48:05Z","git_url":"git://github.com/mcbridematt/openwrt.git","ssh_url":"git@github.com:mcbridematt/openwrt.git","clone_url":"https://github.com/mcbridematt/openwrt.git","svn_url":"https://github.com/mcbridematt/openwrt","homepage":"","size":150546,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openwrt:master","ref":"master","sha":"d089a5d7734d3a22213105b2af054a86b1af59ab","user":{"login":"openwrt","id":2528830,"avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"repo":{"id":45821540,"name":"openwrt","full_name":"openwrt/openwrt","owner":{"login":"openwrt","id":2528830,"avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openwrt/openwrt","description":"This repository is a mirror of https://git.openwrt.org/openwrt/openwrt.git It is for reference only and is not active for check-ins or for reporting issues.  We will continue to accept Pull Requests here. They will be merged via staging trees then into openwrt.git. All issues should be reported at: https://bugs.openwrt.org","fork":false,"url":"https://api.github.com/repos/openwrt/openwrt","forks_url":"https://api.github.com/repos/openwrt/openwrt/forks","keys_url":"https://api.github.com/repos/openwrt/openwrt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwrt/openwrt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwrt/openwrt/teams","hooks_url":"https://api.github.com/repos/openwrt/openwrt/hooks","issue_events_url":"https://api.github.com/repos/openwrt/openwrt/issues/events{/number}","events_url":"https://api.github.com/repos/openwrt/openwrt/events","assignees_url":"https://api.github.com/repos/openwrt/openwrt/assignees{/user}","branches_url":"https://api.github.com/repos/openwrt/openwrt/branches{/branch}","tags_url":"https://api.github.com/repos/openwrt/openwrt/tags","blobs_url":"https://api.github.com/repos/openwrt/openwrt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwrt/openwrt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwrt/openwrt/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwrt/openwrt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwrt/openwrt/statuses/{sha}","languages_url":"https://api.github.com/repos/openwrt/openwrt/languages","stargazers_url":"https://api.github.com/repos/openwrt/openwrt/stargazers","contributors_url":"https://api.github.com/repos/openwrt/openwrt/contributors","subscribers_url":"https://api.github.com/repos/openwrt/openwrt/subscribers","subscription_url":"https://api.github.com/repos/openwrt/openwrt/subscription","commits_url":"https://api.github.com/repos/openwrt/openwrt/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwrt/openwrt/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwrt/openwrt/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwrt/openwrt/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwrt/openwrt/contents/{+path}","compare_url":"https://api.github.com/repos/openwrt/openwrt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwrt/openwrt/merges","archive_url":"https://api.github.com/repos/openwrt/openwrt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwrt/openwrt/downloads","issues_url":"https://api.github.com/repos/openwrt/openwrt/issues{/number}","pulls_url":"https://api.github.com/repos/openwrt/openwrt/pulls{/number}","milestones_url":"https://api.github.com/repos/openwrt/openwrt/milestones{/number}","notifications_url":"https://api.github.com/repos/openwrt/openwrt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwrt/openwrt/labels{/name}","releases_url":"https://api.github.com/repos/openwrt/openwrt/releases{/id}","deployments_url":"https://api.github.com/repos/openwrt/openwrt/deployments","created_at":"2015-11-09T07:13:55Z","updated_at":"2018-04-25T18:14:34Z","pushed_at":"2018-04-25T23:39:40Z","git_url":"git://github.com/openwrt/openwrt.git","ssh_url":"git@github.com:openwrt/openwrt.git","clone_url":"https://github.com/openwrt/openwrt.git","svn_url":"https://github.com/openwrt/openwrt","homepage":"","size":150236,"stargazers_count":2370,"watchers_count":2370,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1387,"mirror_url":null,"archived":false,"open_issues_count":280,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1387,"open_issues":280,"watchers":2370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/895"},"html":{"href":"https://github.com/openwrt/openwrt/pull/895"},"issue":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/895"},"comments":{"href":"https://api.github.com/repos/openwrt/openwrt/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwrt/openwrt/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/openwrt/openwrt/statuses/5572614f5b702af688c8a1aa5be76e095f8a6cbd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcbridematt"}}