{"action":"closed","number":1845,"pull_request":{"url":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845","id":217462392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDYyMzky","html_url":"https://github.com/fireice-uk/xmr-stak/pull/1845","diff_url":"https://github.com/fireice-uk/xmr-stak/pull/1845.diff","patch_url":"https://github.com/fireice-uk/xmr-stak/pull/1845.patch","issue_url":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/1845","number":1845,"state":"closed","locked":false,"title":"telemetry: Add mutex to avoid push during recalc and other races","user":{"login":"Spudz76","id":2391234,"node_id":"MDQ6VXNlcjIzOTEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2391234?v=4","gravatar_id":"","url":"https://api.github.com/users/Spudz76","html_url":"https://github.com/Spudz76","followers_url":"https://api.github.com/users/Spudz76/followers","following_url":"https://api.github.com/users/Spudz76/following{/other_user}","gists_url":"https://api.github.com/users/Spudz76/gists{/gist_id}","starred_url":"https://api.github.com/users/Spudz76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spudz76/subscriptions","organizations_url":"https://api.github.com/users/Spudz76/orgs","repos_url":"https://api.github.com/users/Spudz76/repos","events_url":"https://api.github.com/users/Spudz76/events{/privacy}","received_events_url":"https://api.github.com/users/Spudz76/received_events","type":"User","site_admin":false},"body":"Add simple locking to telemetry class, since both push and calc methods modify the data buckets and pointers,  this avoids race conditions and bucket corruption.\r\n\r\nHoping this solves occasional \"missing stats\" or inaccuracy that could not be tracked down to anything but \"thread timing mystery\".  It does seem to standardize my hashrates as shown which I take to mean it's more accurate.\r\n\r\nRegardless it doesn't seem to hurt.","created_at":"2018-09-22T15:21:00Z","updated_at":"2018-09-30T21:06:36Z","closed_at":"2018-09-30T21:06:36Z","merged_at":"2018-09-30T21:06:36Z","merge_commit_sha":"952d2446e220c792634006a2ff7af57d16649daf","assignee":{"login":"psychocrypt","id":25899446,"node_id":"MDQ6VXNlcjI1ODk5NDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/25899446?v=4","gravatar_id":"","url":"https://api.github.com/users/psychocrypt","html_url":"https://github.com/psychocrypt","followers_url":"https://api.github.com/users/psychocrypt/followers","following_url":"https://api.github.com/users/psychocrypt/following{/other_user}","gists_url":"https://api.github.com/users/psychocrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocrypt/subscriptions","organizations_url":"https://api.github.com/users/psychocrypt/orgs","repos_url":"https://api.github.com/users/psychocrypt/repos","events_url":"https://api.github.com/users/psychocrypt/events{/privacy}","received_events_url":"https://api.github.com/users/psychocrypt/received_events","type":"User","site_admin":false},"assignees":[{"login":"psychocrypt","id":25899446,"node_id":"MDQ6VXNlcjI1ODk5NDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/25899446?v=4","gravatar_id":"","url":"https://api.github.com/users/psychocrypt","html_url":"https://github.com/psychocrypt","followers_url":"https://api.github.com/users/psychocrypt/followers","following_url":"https://api.github.com/users/psychocrypt/following{/other_user}","gists_url":"https://api.github.com/users/psychocrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocrypt/subscriptions","organizations_url":"https://api.github.com/users/psychocrypt/orgs","repos_url":"https://api.github.com/users/psychocrypt/repos","events_url":"https://api.github.com/users/psychocrypt/events{/privacy}","received_events_url":"https://api.github.com/users/psychocrypt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":709876827,"node_id":"MDU6TGFiZWw3MDk4NzY4Mjc=","url":"https://api.github.com/repos/fireice-uk/xmr-stak/labels/WIP","name":"WIP","color":"EAFF00","default":false},{"id":709849813,"node_id":"MDU6TGFiZWw3MDk4NDk4MTM=","url":"https://api.github.com/repos/fireice-uk/xmr-stak/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845/commits","review_comments_url":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845/comments","review_comment_url":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/1845/comments","statuses_url":"https://api.github.com/repos/fireice-uk/xmr-stak/statuses/f03319c33429376d333510058579b7ead6241aec","head":{"label":"Spudz76:dev-telemetry","ref":"dev-telemetry","sha":"f03319c33429376d333510058579b7ead6241aec","user":{"login":"Spudz76","id":2391234,"node_id":"MDQ6VXNlcjIzOTEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2391234?v=4","gravatar_id":"","url":"https://api.github.com/users/Spudz76","html_url":"https://github.com/Spudz76","followers_url":"https://api.github.com/users/Spudz76/followers","following_url":"https://api.github.com/users/Spudz76/following{/other_user}","gists_url":"https://api.github.com/users/Spudz76/gists{/gist_id}","starred_url":"https://api.github.com/users/Spudz76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spudz76/subscriptions","organizations_url":"https://api.github.com/users/Spudz76/orgs","repos_url":"https://api.github.com/users/Spudz76/repos","events_url":"https://api.github.com/users/Spudz76/events{/privacy}","received_events_url":"https://api.github.com/users/Spudz76/received_events","type":"User","site_admin":false},"repo":{"id":130182143,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxODIxNDM=","name":"xmr-stak","full_name":"Spudz76/xmr-stak","private":false,"owner":{"login":"Spudz76","id":2391234,"node_id":"MDQ6VXNlcjIzOTEyMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2391234?v=4","gravatar_id":"","url":"https://api.github.com/users/Spudz76","html_url":"https://github.com/Spudz76","followers_url":"https://api.github.com/users/Spudz76/followers","following_url":"https://api.github.com/users/Spudz76/following{/other_user}","gists_url":"https://api.github.com/users/Spudz76/gists{/gist_id}","starred_url":"https://api.github.com/users/Spudz76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spudz76/subscriptions","organizations_url":"https://api.github.com/users/Spudz76/orgs","repos_url":"https://api.github.com/users/Spudz76/repos","events_url":"https://api.github.com/users/Spudz76/events{/privacy}","received_events_url":"https://api.github.com/users/Spudz76/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Spudz76/xmr-stak","description":"Unified All-in-one Monero miner","fork":true,"url":"https://api.github.com/repos/Spudz76/xmr-stak","forks_url":"https://api.github.com/repos/Spudz76/xmr-stak/forks","keys_url":"https://api.github.com/repos/Spudz76/xmr-stak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spudz76/xmr-stak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spudz76/xmr-stak/teams","hooks_url":"https://api.github.com/repos/Spudz76/xmr-stak/hooks","issue_events_url":"https://api.github.com/repos/Spudz76/xmr-stak/issues/events{/number}","events_url":"https://api.github.com/repos/Spudz76/xmr-stak/events","assignees_url":"https://api.github.com/repos/Spudz76/xmr-stak/assignees{/user}","branches_url":"https://api.github.com/repos/Spudz76/xmr-stak/branches{/branch}","tags_url":"https://api.github.com/repos/Spudz76/xmr-stak/tags","blobs_url":"https://api.github.com/repos/Spudz76/xmr-stak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spudz76/xmr-stak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spudz76/xmr-stak/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spudz76/xmr-stak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spudz76/xmr-stak/statuses/{sha}","languages_url":"https://api.github.com/repos/Spudz76/xmr-stak/languages","stargazers_url":"https://api.github.com/repos/Spudz76/xmr-stak/stargazers","contributors_url":"https://api.github.com/repos/Spudz76/xmr-stak/contributors","subscribers_url":"https://api.github.com/repos/Spudz76/xmr-stak/subscribers","subscription_url":"https://api.github.com/repos/Spudz76/xmr-stak/subscription","commits_url":"https://api.github.com/repos/Spudz76/xmr-stak/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spudz76/xmr-stak/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spudz76/xmr-stak/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spudz76/xmr-stak/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spudz76/xmr-stak/contents/{+path}","compare_url":"https://api.github.com/repos/Spudz76/xmr-stak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spudz76/xmr-stak/merges","archive_url":"https://api.github.com/repos/Spudz76/xmr-stak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spudz76/xmr-stak/downloads","issues_url":"https://api.github.com/repos/Spudz76/xmr-stak/issues{/number}","pulls_url":"https://api.github.com/repos/Spudz76/xmr-stak/pulls{/number}","milestones_url":"https://api.github.com/repos/Spudz76/xmr-stak/milestones{/number}","notifications_url":"https://api.github.com/repos/Spudz76/xmr-stak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spudz76/xmr-stak/labels{/name}","releases_url":"https://api.github.com/repos/Spudz76/xmr-stak/releases{/id}","deployments_url":"https://api.github.com/repos/Spudz76/xmr-stak/deployments","created_at":"2018-04-19T08:14:54Z","updated_at":"2018-08-29T19:12:53Z","pushed_at":"2018-09-30T20:47:13Z","git_url":"git://github.com/Spudz76/xmr-stak.git","ssh_url":"git@github.com:Spudz76/xmr-stak.git","clone_url":"https://github.com/Spudz76/xmr-stak.git","svn_url":"https://github.com/Spudz76/xmr-stak","homepage":null,"size":1765,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fireice-uk:dev","ref":"dev","sha":"dfcb774b6a68e913537d889567672ce18953337c","user":{"login":"fireice-uk","id":5392418,"node_id":"MDQ6VXNlcjUzOTI0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5392418?v=4","gravatar_id":"","url":"https://api.github.com/users/fireice-uk","html_url":"https://github.com/fireice-uk","followers_url":"https://api.github.com/users/fireice-uk/followers","following_url":"https://api.github.com/users/fireice-uk/following{/other_user}","gists_url":"https://api.github.com/users/fireice-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/fireice-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireice-uk/subscriptions","organizations_url":"https://api.github.com/users/fireice-uk/orgs","repos_url":"https://api.github.com/users/fireice-uk/repos","events_url":"https://api.github.com/users/fireice-uk/events{/privacy}","received_events_url":"https://api.github.com/users/fireice-uk/received_events","type":"User","site_admin":false},"repo":{"id":105697152,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2OTcxNTI=","name":"xmr-stak","full_name":"fireice-uk/xmr-stak","private":false,"owner":{"login":"fireice-uk","id":5392418,"node_id":"MDQ6VXNlcjUzOTI0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5392418?v=4","gravatar_id":"","url":"https://api.github.com/users/fireice-uk","html_url":"https://github.com/fireice-uk","followers_url":"https://api.github.com/users/fireice-uk/followers","following_url":"https://api.github.com/users/fireice-uk/following{/other_user}","gists_url":"https://api.github.com/users/fireice-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/fireice-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireice-uk/subscriptions","organizations_url":"https://api.github.com/users/fireice-uk/orgs","repos_url":"https://api.github.com/users/fireice-uk/repos","events_url":"https://api.github.com/users/fireice-uk/events{/privacy}","received_events_url":"https://api.github.com/users/fireice-uk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fireice-uk/xmr-stak","description":"Unified All-in-one Monero miner","fork":false,"url":"https://api.github.com/repos/fireice-uk/xmr-stak","forks_url":"https://api.github.com/repos/fireice-uk/xmr-stak/forks","keys_url":"https://api.github.com/repos/fireice-uk/xmr-stak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireice-uk/xmr-stak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireice-uk/xmr-stak/teams","hooks_url":"https://api.github.com/repos/fireice-uk/xmr-stak/hooks","issue_events_url":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/events{/number}","events_url":"https://api.github.com/repos/fireice-uk/xmr-stak/events","assignees_url":"https://api.github.com/repos/fireice-uk/xmr-stak/assignees{/user}","branches_url":"https://api.github.com/repos/fireice-uk/xmr-stak/branches{/branch}","tags_url":"https://api.github.com/repos/fireice-uk/xmr-stak/tags","blobs_url":"https://api.github.com/repos/fireice-uk/xmr-stak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireice-uk/xmr-stak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireice-uk/xmr-stak/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireice-uk/xmr-stak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireice-uk/xmr-stak/statuses/{sha}","languages_url":"https://api.github.com/repos/fireice-uk/xmr-stak/languages","stargazers_url":"https://api.github.com/repos/fireice-uk/xmr-stak/stargazers","contributors_url":"https://api.github.com/repos/fireice-uk/xmr-stak/contributors","subscribers_url":"https://api.github.com/repos/fireice-uk/xmr-stak/subscribers","subscription_url":"https://api.github.com/repos/fireice-uk/xmr-stak/subscription","commits_url":"https://api.github.com/repos/fireice-uk/xmr-stak/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireice-uk/xmr-stak/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireice-uk/xmr-stak/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireice-uk/xmr-stak/contents/{+path}","compare_url":"https://api.github.com/repos/fireice-uk/xmr-stak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireice-uk/xmr-stak/merges","archive_url":"https://api.github.com/repos/fireice-uk/xmr-stak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireice-uk/xmr-stak/downloads","issues_url":"https://api.github.com/repos/fireice-uk/xmr-stak/issues{/number}","pulls_url":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls{/number}","milestones_url":"https://api.github.com/repos/fireice-uk/xmr-stak/milestones{/number}","notifications_url":"https://api.github.com/repos/fireice-uk/xmr-stak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireice-uk/xmr-stak/labels{/name}","releases_url":"https://api.github.com/repos/fireice-uk/xmr-stak/releases{/id}","deployments_url":"https://api.github.com/repos/fireice-uk/xmr-stak/deployments","created_at":"2017-10-03T20:01:59Z","updated_at":"2018-09-30T13:12:45Z","pushed_at":"2018-09-30T21:06:36Z","git_url":"git://github.com/fireice-uk/xmr-stak.git","ssh_url":"git@github.com:fireice-uk/xmr-stak.git","clone_url":"https://github.com/fireice-uk/xmr-stak.git","svn_url":"https://github.com/fireice-uk/xmr-stak","homepage":null,"size":1697,"stargazers_count":2779,"watchers_count":2779,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1393,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1393,"open_issues":221,"watchers":2779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845"},"html":{"href":"https://github.com/fireice-uk/xmr-stak/pull/1845"},"issue":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/1845"},"comments":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/issues/1845/comments"},"review_comments":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845/comments"},"review_comment":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/pulls/1845/commits"},"statuses":{"href":"https://api.github.com/repos/fireice-uk/xmr-stak/statuses/f03319c33429376d333510058579b7ead6241aec"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"psychocrypt","id":25899446,"node_id":"MDQ6VXNlcjI1ODk5NDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/25899446?v=4","gravatar_id":"","url":"https://api.github.com/users/psychocrypt","html_url":"https://github.com/psychocrypt","followers_url":"https://api.github.com/users/psychocrypt/followers","following_url":"https://api.github.com/users/psychocrypt/following{/other_user}","gists_url":"https://api.github.com/users/psychocrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocrypt/subscriptions","organizations_url":"https://api.github.com/users/psychocrypt/orgs","repos_url":"https://api.github.com/users/psychocrypt/repos","events_url":"https://api.github.com/users/psychocrypt/events{/privacy}","received_events_url":"https://api.github.com/users/psychocrypt/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"psychocrypt"}}