{"action":"created","comment":{"url":"https://api.github.com/repos/Valve/mxmnd/pulls/comments/232327311","pull_request_review_id":173506151,"id":232327311,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMyNzMxMQ==","diff_hunk":"@@ -1,7 +1,64 @@\n-require \"spec_helper\"\n+require 'spec_helper'\n \n describe Mxmnd do\n   it 'raises BadRequest on missing IP address' do\n-    expect { Mxmnd::city(nil) }.to raise_error Mxmnd::BadRequest\n+    expect { Mxmnd.city(nil) }.to raise_error Mxmnd::BadRequest\n+  end\n+end\n+\n+describe 'Mxmnd.city response' do\n+  before {\n+  \turl = 'https://geoip.maxmind.com/geoip/v2.1/city/45.17.22.11'\n+    path = './spec/features/mxmnd_res.txt'\n+    ruby_headers = {","path":"spec/mxmnd_spec.rb","position":15,"original_position":15,"commit_id":"3b85405dae2d4733081add6b757641e9fe220150","original_commit_id":"3b85405dae2d4733081add6b757641e9fe220150","user":{"login":"Valve","id":27387,"node_id":"MDQ6VXNlcjI3Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/27387?v=4","gravatar_id":"","url":"https://api.github.com/users/Valve","html_url":"https://github.com/Valve","followers_url":"https://api.github.com/users/Valve/followers","following_url":"https://api.github.com/users/Valve/following{/other_user}","gists_url":"https://api.github.com/users/Valve/gists{/gist_id}","starred_url":"https://api.github.com/users/Valve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valve/subscriptions","organizations_url":"https://api.github.com/users/Valve/orgs","repos_url":"https://api.github.com/users/Valve/repos","events_url":"https://api.github.com/users/Valve/events{/privacy}","received_events_url":"https://api.github.com/users/Valve/received_events","type":"User","site_admin":false},"body":"these headers are not ruby-specific, so better just call them `headers` or `request headers`","created_at":"2018-11-09T17:12:17Z","updated_at":"2018-11-09T17:17:46Z","html_url":"https://github.com/Valve/mxmnd/pull/3#discussion_r232327311","pull_request_url":"https://api.github.com/repos/Valve/mxmnd/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/comments/232327311"},"html":{"href":"https://github.com/Valve/mxmnd/pull/3#discussion_r232327311"},"pull_request":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Valve/mxmnd/pulls/3","id":228276499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mjc2NDk5","html_url":"https://github.com/Valve/mxmnd/pull/3","diff_url":"https://github.com/Valve/mxmnd/pull/3.diff","patch_url":"https://github.com/Valve/mxmnd/pull/3.patch","issue_url":"https://api.github.com/repos/Valve/mxmnd/issues/3","number":3,"state":"open","locked":false,"title":"corrected errors","user":{"login":"timur-rimsky","id":43128342,"node_id":"MDQ6VXNlcjQzMTI4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/43128342?v=4","gravatar_id":"","url":"https://api.github.com/users/timur-rimsky","html_url":"https://github.com/timur-rimsky","followers_url":"https://api.github.com/users/timur-rimsky/followers","following_url":"https://api.github.com/users/timur-rimsky/following{/other_user}","gists_url":"https://api.github.com/users/timur-rimsky/gists{/gist_id}","starred_url":"https://api.github.com/users/timur-rimsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timur-rimsky/subscriptions","organizations_url":"https://api.github.com/users/timur-rimsky/orgs","repos_url":"https://api.github.com/users/timur-rimsky/repos","events_url":"https://api.github.com/users/timur-rimsky/events{/privacy}","received_events_url":"https://api.github.com/users/timur-rimsky/received_events","type":"User","site_admin":false},"body":"I've corrected errors\r\nmade some changes in gem file\r\nso specs pass","created_at":"2018-11-05T08:42:16Z","updated_at":"2018-11-09T17:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccbb8e8c9f80c7ef22c8924e118d19dbd874e2e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Valve/mxmnd/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Valve/mxmnd/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Valve/mxmnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valve/mxmnd/issues/3/comments","statuses_url":"https://api.github.com/repos/Valve/mxmnd/statuses/3b85405dae2d4733081add6b757641e9fe220150","head":{"label":"timur-rimsky:master","ref":"master","sha":"3b85405dae2d4733081add6b757641e9fe220150","user":{"login":"timur-rimsky","id":43128342,"node_id":"MDQ6VXNlcjQzMTI4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/43128342?v=4","gravatar_id":"","url":"https://api.github.com/users/timur-rimsky","html_url":"https://github.com/timur-rimsky","followers_url":"https://api.github.com/users/timur-rimsky/followers","following_url":"https://api.github.com/users/timur-rimsky/following{/other_user}","gists_url":"https://api.github.com/users/timur-rimsky/gists{/gist_id}","starred_url":"https://api.github.com/users/timur-rimsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timur-rimsky/subscriptions","organizations_url":"https://api.github.com/users/timur-rimsky/orgs","repos_url":"https://api.github.com/users/timur-rimsky/repos","events_url":"https://api.github.com/users/timur-rimsky/events{/privacy}","received_events_url":"https://api.github.com/users/timur-rimsky/received_events","type":"User","site_admin":false},"repo":{"id":152963595,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5NjM1OTU=","name":"mxmnd","full_name":"timur-rimsky/mxmnd","private":false,"owner":{"login":"timur-rimsky","id":43128342,"node_id":"MDQ6VXNlcjQzMTI4MzQy","avatar_url":"https://avatars0.githubusercontent.com/u/43128342?v=4","gravatar_id":"","url":"https://api.github.com/users/timur-rimsky","html_url":"https://github.com/timur-rimsky","followers_url":"https://api.github.com/users/timur-rimsky/followers","following_url":"https://api.github.com/users/timur-rimsky/following{/other_user}","gists_url":"https://api.github.com/users/timur-rimsky/gists{/gist_id}","starred_url":"https://api.github.com/users/timur-rimsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timur-rimsky/subscriptions","organizations_url":"https://api.github.com/users/timur-rimsky/orgs","repos_url":"https://api.github.com/users/timur-rimsky/repos","events_url":"https://api.github.com/users/timur-rimsky/events{/privacy}","received_events_url":"https://api.github.com/users/timur-rimsky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/timur-rimsky/mxmnd","description":"Minimal MaxMind API wrapper for Ruby","fork":true,"url":"https://api.github.com/repos/timur-rimsky/mxmnd","forks_url":"https://api.github.com/repos/timur-rimsky/mxmnd/forks","keys_url":"https://api.github.com/repos/timur-rimsky/mxmnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timur-rimsky/mxmnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timur-rimsky/mxmnd/teams","hooks_url":"https://api.github.com/repos/timur-rimsky/mxmnd/hooks","issue_events_url":"https://api.github.com/repos/timur-rimsky/mxmnd/issues/events{/number}","events_url":"https://api.github.com/repos/timur-rimsky/mxmnd/events","assignees_url":"https://api.github.com/repos/timur-rimsky/mxmnd/assignees{/user}","branches_url":"https://api.github.com/repos/timur-rimsky/mxmnd/branches{/branch}","tags_url":"https://api.github.com/repos/timur-rimsky/mxmnd/tags","blobs_url":"https://api.github.com/repos/timur-rimsky/mxmnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timur-rimsky/mxmnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timur-rimsky/mxmnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/timur-rimsky/mxmnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timur-rimsky/mxmnd/statuses/{sha}","languages_url":"https://api.github.com/repos/timur-rimsky/mxmnd/languages","stargazers_url":"https://api.github.com/repos/timur-rimsky/mxmnd/stargazers","contributors_url":"https://api.github.com/repos/timur-rimsky/mxmnd/contributors","subscribers_url":"https://api.github.com/repos/timur-rimsky/mxmnd/subscribers","subscription_url":"https://api.github.com/repos/timur-rimsky/mxmnd/subscription","commits_url":"https://api.github.com/repos/timur-rimsky/mxmnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/timur-rimsky/mxmnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/timur-rimsky/mxmnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/timur-rimsky/mxmnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/timur-rimsky/mxmnd/contents/{+path}","compare_url":"https://api.github.com/repos/timur-rimsky/mxmnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timur-rimsky/mxmnd/merges","archive_url":"https://api.github.com/repos/timur-rimsky/mxmnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timur-rimsky/mxmnd/downloads","issues_url":"https://api.github.com/repos/timur-rimsky/mxmnd/issues{/number}","pulls_url":"https://api.github.com/repos/timur-rimsky/mxmnd/pulls{/number}","milestones_url":"https://api.github.com/repos/timur-rimsky/mxmnd/milestones{/number}","notifications_url":"https://api.github.com/repos/timur-rimsky/mxmnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timur-rimsky/mxmnd/labels{/name}","releases_url":"https://api.github.com/repos/timur-rimsky/mxmnd/releases{/id}","deployments_url":"https://api.github.com/repos/timur-rimsky/mxmnd/deployments","created_at":"2018-10-14T10:42:00Z","updated_at":"2018-11-05T08:14:27Z","pushed_at":"2018-11-05T08:14:25Z","git_url":"git://github.com/timur-rimsky/mxmnd.git","ssh_url":"git@github.com:timur-rimsky/mxmnd.git","clone_url":"https://github.com/timur-rimsky/mxmnd.git","svn_url":"https://github.com/timur-rimsky/mxmnd","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Valve:master","ref":"master","sha":"fc583346f3b4cbbdd9c6f5ce0dc7c8f2114b2fb9","user":{"login":"Valve","id":27387,"node_id":"MDQ6VXNlcjI3Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/27387?v=4","gravatar_id":"","url":"https://api.github.com/users/Valve","html_url":"https://github.com/Valve","followers_url":"https://api.github.com/users/Valve/followers","following_url":"https://api.github.com/users/Valve/following{/other_user}","gists_url":"https://api.github.com/users/Valve/gists{/gist_id}","starred_url":"https://api.github.com/users/Valve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valve/subscriptions","organizations_url":"https://api.github.com/users/Valve/orgs","repos_url":"https://api.github.com/users/Valve/repos","events_url":"https://api.github.com/users/Valve/events{/privacy}","received_events_url":"https://api.github.com/users/Valve/received_events","type":"User","site_admin":false},"repo":{"id":71607180,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYwNzE4MA==","name":"mxmnd","full_name":"Valve/mxmnd","private":false,"owner":{"login":"Valve","id":27387,"node_id":"MDQ6VXNlcjI3Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/27387?v=4","gravatar_id":"","url":"https://api.github.com/users/Valve","html_url":"https://github.com/Valve","followers_url":"https://api.github.com/users/Valve/followers","following_url":"https://api.github.com/users/Valve/following{/other_user}","gists_url":"https://api.github.com/users/Valve/gists{/gist_id}","starred_url":"https://api.github.com/users/Valve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valve/subscriptions","organizations_url":"https://api.github.com/users/Valve/orgs","repos_url":"https://api.github.com/users/Valve/repos","events_url":"https://api.github.com/users/Valve/events{/privacy}","received_events_url":"https://api.github.com/users/Valve/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Valve/mxmnd","description":"Minimal MaxMind API wrapper for Ruby","fork":false,"url":"https://api.github.com/repos/Valve/mxmnd","forks_url":"https://api.github.com/repos/Valve/mxmnd/forks","keys_url":"https://api.github.com/repos/Valve/mxmnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valve/mxmnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valve/mxmnd/teams","hooks_url":"https://api.github.com/repos/Valve/mxmnd/hooks","issue_events_url":"https://api.github.com/repos/Valve/mxmnd/issues/events{/number}","events_url":"https://api.github.com/repos/Valve/mxmnd/events","assignees_url":"https://api.github.com/repos/Valve/mxmnd/assignees{/user}","branches_url":"https://api.github.com/repos/Valve/mxmnd/branches{/branch}","tags_url":"https://api.github.com/repos/Valve/mxmnd/tags","blobs_url":"https://api.github.com/repos/Valve/mxmnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valve/mxmnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valve/mxmnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valve/mxmnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valve/mxmnd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valve/mxmnd/languages","stargazers_url":"https://api.github.com/repos/Valve/mxmnd/stargazers","contributors_url":"https://api.github.com/repos/Valve/mxmnd/contributors","subscribers_url":"https://api.github.com/repos/Valve/mxmnd/subscribers","subscription_url":"https://api.github.com/repos/Valve/mxmnd/subscription","commits_url":"https://api.github.com/repos/Valve/mxmnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valve/mxmnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valve/mxmnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valve/mxmnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valve/mxmnd/contents/{+path}","compare_url":"https://api.github.com/repos/Valve/mxmnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valve/mxmnd/merges","archive_url":"https://api.github.com/repos/Valve/mxmnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valve/mxmnd/downloads","issues_url":"https://api.github.com/repos/Valve/mxmnd/issues{/number}","pulls_url":"https://api.github.com/repos/Valve/mxmnd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valve/mxmnd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valve/mxmnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valve/mxmnd/labels{/name}","releases_url":"https://api.github.com/repos/Valve/mxmnd/releases{/id}","deployments_url":"https://api.github.com/repos/Valve/mxmnd/deployments","created_at":"2016-10-22T00:35:34Z","updated_at":"2018-10-04T16:51:22Z","pushed_at":"2018-11-05T08:42:17Z","git_url":"git://github.com/Valve/mxmnd.git","ssh_url":"git@github.com:Valve/mxmnd.git","clone_url":"https://github.com/Valve/mxmnd.git","svn_url":"https://github.com/Valve/mxmnd","homepage":null,"size":10,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/3"},"html":{"href":"https://github.com/Valve/mxmnd/pull/3"},"issue":{"href":"https://api.github.com/repos/Valve/mxmnd/issues/3"},"comments":{"href":"https://api.github.com/repos/Valve/mxmnd/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valve/mxmnd/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Valve/mxmnd/statuses/3b85405dae2d4733081add6b757641e9fe220150"}},"author_association":"NONE"}}
{"actor":{"display_login":"Valve"}}