{"action":"created","comment":{"url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/comments/197999588","pull_request_review_id":131850209,"id":197999588,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk5OTU4OA==","diff_hunk":"@@ -845,7 +845,7 @@ export default class Emitter\n \t\tif (this._emit)\n \t\t{\n \t\t\t//decrease spawn timer\n-\t\t\tthis._spawnTimer -= delta;\n+\t\t\tthis._spawnTimer -=  Math.max(delta, 0);","path":"src/Emitter.ts","position":null,"original_position":5,"commit_id":"f2dc6c7f313a121dc6aa96520e586395ed848237","original_commit_id":"d4e371a92f4d78fc02b7ba1b4ad05aa767892d8d","user":{"login":"andrewstart","id":1816311,"node_id":"MDQ6VXNlcjE4MTYzMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1816311?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewstart","html_url":"https://github.com/andrewstart","followers_url":"https://api.github.com/users/andrewstart/followers","following_url":"https://api.github.com/users/andrewstart/following{/other_user}","gists_url":"https://api.github.com/users/andrewstart/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewstart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewstart/subscriptions","organizations_url":"https://api.github.com/users/andrewstart/orgs","repos_url":"https://api.github.com/users/andrewstart/repos","events_url":"https://api.github.com/users/andrewstart/events{/privacy}","received_events_url":"https://api.github.com/users/andrewstart/received_events","type":"User","site_admin":false},"body":"I'm the type of person who is quite happy to use `x != x` all over the place instead of `isNaN(x)`.","created_at":"2018-06-26T02:55:37Z","updated_at":"2018-06-26T02:55:37Z","html_url":"https://github.com/pixijs/pixi-particles/pull/85#discussion_r197999588","pull_request_url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/comments/197999588"},"html":{"href":"https://github.com/pixijs/pixi-particles/pull/85#discussion_r197999588"},"pull_request":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85"}},"in_reply_to_id":197778550},"pull_request":{"url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85","id":197001821,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDAxODIx","html_url":"https://github.com/pixijs/pixi-particles/pull/85","diff_url":"https://github.com/pixijs/pixi-particles/pull/85.diff","patch_url":"https://github.com/pixijs/pixi-particles/pull/85.patch","issue_url":"https://api.github.com/repos/pixijs/pixi-particles/issues/85","number":85,"state":"open","locked":false,"title":"Negative deltas will no longer effect the spawn duration","user":{"login":"st3v0","id":2800093,"node_id":"MDQ6VXNlcjI4MDAwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2800093?v=4","gravatar_id":"","url":"https://api.github.com/users/st3v0","html_url":"https://github.com/st3v0","followers_url":"https://api.github.com/users/st3v0/followers","following_url":"https://api.github.com/users/st3v0/following{/other_user}","gists_url":"https://api.github.com/users/st3v0/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v0/subscriptions","organizations_url":"https://api.github.com/users/st3v0/orgs","repos_url":"https://api.github.com/users/st3v0/repos","events_url":"https://api.github.com/users/st3v0/events{/privacy}","received_events_url":"https://api.github.com/users/st3v0/received_events","type":"User","site_admin":false},"body":"The reversal of time increases the amount of time of the next particle spawn. This means if you reverse time for 2 minutes and then play it forward, it will take 2 minutes before the next particle is spawned. This change means that will no longer be the case. you can reverse time until all particles are killed off and then play forward immediately with no ill effects.","created_at":"2018-06-25T04:57:42Z","updated_at":"2018-06-26T02:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7189f62d6112e1ad3e6142228a6d45f309b39356","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85/commits","review_comments_url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85/comments","review_comment_url":"https://api.github.com/repos/pixijs/pixi-particles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixijs/pixi-particles/issues/85/comments","statuses_url":"https://api.github.com/repos/pixijs/pixi-particles/statuses/f2dc6c7f313a121dc6aa96520e586395ed848237","head":{"label":"st3v0:master","ref":"master","sha":"f2dc6c7f313a121dc6aa96520e586395ed848237","user":{"login":"st3v0","id":2800093,"node_id":"MDQ6VXNlcjI4MDAwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2800093?v=4","gravatar_id":"","url":"https://api.github.com/users/st3v0","html_url":"https://github.com/st3v0","followers_url":"https://api.github.com/users/st3v0/followers","following_url":"https://api.github.com/users/st3v0/following{/other_user}","gists_url":"https://api.github.com/users/st3v0/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v0/subscriptions","organizations_url":"https://api.github.com/users/st3v0/orgs","repos_url":"https://api.github.com/users/st3v0/repos","events_url":"https://api.github.com/users/st3v0/events{/privacy}","received_events_url":"https://api.github.com/users/st3v0/received_events","type":"User","site_admin":false},"repo":{"id":138519155,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MTkxNTU=","name":"pixi-particles","full_name":"st3v0/pixi-particles","owner":{"login":"st3v0","id":2800093,"node_id":"MDQ6VXNlcjI4MDAwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2800093?v=4","gravatar_id":"","url":"https://api.github.com/users/st3v0","html_url":"https://github.com/st3v0","followers_url":"https://api.github.com/users/st3v0/followers","following_url":"https://api.github.com/users/st3v0/following{/other_user}","gists_url":"https://api.github.com/users/st3v0/gists{/gist_id}","starred_url":"https://api.github.com/users/st3v0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st3v0/subscriptions","organizations_url":"https://api.github.com/users/st3v0/orgs","repos_url":"https://api.github.com/users/st3v0/repos","events_url":"https://api.github.com/users/st3v0/events{/privacy}","received_events_url":"https://api.github.com/users/st3v0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/st3v0/pixi-particles","description":"A particle system for PixiJS","fork":true,"url":"https://api.github.com/repos/st3v0/pixi-particles","forks_url":"https://api.github.com/repos/st3v0/pixi-particles/forks","keys_url":"https://api.github.com/repos/st3v0/pixi-particles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/st3v0/pixi-particles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/st3v0/pixi-particles/teams","hooks_url":"https://api.github.com/repos/st3v0/pixi-particles/hooks","issue_events_url":"https://api.github.com/repos/st3v0/pixi-particles/issues/events{/number}","events_url":"https://api.github.com/repos/st3v0/pixi-particles/events","assignees_url":"https://api.github.com/repos/st3v0/pixi-particles/assignees{/user}","branches_url":"https://api.github.com/repos/st3v0/pixi-particles/branches{/branch}","tags_url":"https://api.github.com/repos/st3v0/pixi-particles/tags","blobs_url":"https://api.github.com/repos/st3v0/pixi-particles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/st3v0/pixi-particles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/st3v0/pixi-particles/git/refs{/sha}","trees_url":"https://api.github.com/repos/st3v0/pixi-particles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/st3v0/pixi-particles/statuses/{sha}","languages_url":"https://api.github.com/repos/st3v0/pixi-particles/languages","stargazers_url":"https://api.github.com/repos/st3v0/pixi-particles/stargazers","contributors_url":"https://api.github.com/repos/st3v0/pixi-particles/contributors","subscribers_url":"https://api.github.com/repos/st3v0/pixi-particles/subscribers","subscription_url":"https://api.github.com/repos/st3v0/pixi-particles/subscription","commits_url":"https://api.github.com/repos/st3v0/pixi-particles/commits{/sha}","git_commits_url":"https://api.github.com/repos/st3v0/pixi-particles/git/commits{/sha}","comments_url":"https://api.github.com/repos/st3v0/pixi-particles/comments{/number}","issue_comment_url":"https://api.github.com/repos/st3v0/pixi-particles/issues/comments{/number}","contents_url":"https://api.github.com/repos/st3v0/pixi-particles/contents/{+path}","compare_url":"https://api.github.com/repos/st3v0/pixi-particles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/st3v0/pixi-particles/merges","archive_url":"https://api.github.com/repos/st3v0/pixi-particles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/st3v0/pixi-particles/downloads","issues_url":"https://api.github.com/repos/st3v0/pixi-particles/issues{/number}","pulls_url":"https://api.github.com/repos/st3v0/pixi-particles/pulls{/number}","milestones_url":"https://api.github.com/repos/st3v0/pixi-particles/milestones{/number}","notifications_url":"https://api.github.com/repos/st3v0/pixi-particles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/st3v0/pixi-particles/labels{/name}","releases_url":"https://api.github.com/repos/st3v0/pixi-particles/releases{/id}","deployments_url":"https://api.github.com/repos/st3v0/pixi-particles/deployments","created_at":"2018-06-24T22:16:43Z","updated_at":"2018-06-25T22:54:34Z","pushed_at":"2018-06-25T22:54:32Z","git_url":"git://github.com/st3v0/pixi-particles.git","ssh_url":"git@github.com:st3v0/pixi-particles.git","clone_url":"https://github.com/st3v0/pixi-particles.git","svn_url":"https://github.com/st3v0/pixi-particles","homepage":"http://pixijs.github.io/pixi-particles/docs","size":5749,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pixijs:master","ref":"master","sha":"f06db791cab689448c55ad1ad2a176177aec899f","user":{"login":"pixijs","id":5406849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDY4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5406849?v=4","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"repo":{"id":23367911,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM2NzkxMQ==","name":"pixi-particles","full_name":"pixijs/pixi-particles","owner":{"login":"pixijs","id":5406849,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MDY4NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5406849?v=4","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixijs/pixi-particles","description":"A particle system for PixiJS","fork":false,"url":"https://api.github.com/repos/pixijs/pixi-particles","forks_url":"https://api.github.com/repos/pixijs/pixi-particles/forks","keys_url":"https://api.github.com/repos/pixijs/pixi-particles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixijs/pixi-particles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixijs/pixi-particles/teams","hooks_url":"https://api.github.com/repos/pixijs/pixi-particles/hooks","issue_events_url":"https://api.github.com/repos/pixijs/pixi-particles/issues/events{/number}","events_url":"https://api.github.com/repos/pixijs/pixi-particles/events","assignees_url":"https://api.github.com/repos/pixijs/pixi-particles/assignees{/user}","branches_url":"https://api.github.com/repos/pixijs/pixi-particles/branches{/branch}","tags_url":"https://api.github.com/repos/pixijs/pixi-particles/tags","blobs_url":"https://api.github.com/repos/pixijs/pixi-particles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixijs/pixi-particles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixijs/pixi-particles/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixijs/pixi-particles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixijs/pixi-particles/statuses/{sha}","languages_url":"https://api.github.com/repos/pixijs/pixi-particles/languages","stargazers_url":"https://api.github.com/repos/pixijs/pixi-particles/stargazers","contributors_url":"https://api.github.com/repos/pixijs/pixi-particles/contributors","subscribers_url":"https://api.github.com/repos/pixijs/pixi-particles/subscribers","subscription_url":"https://api.github.com/repos/pixijs/pixi-particles/subscription","commits_url":"https://api.github.com/repos/pixijs/pixi-particles/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixijs/pixi-particles/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixijs/pixi-particles/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixijs/pixi-particles/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixijs/pixi-particles/contents/{+path}","compare_url":"https://api.github.com/repos/pixijs/pixi-particles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixijs/pixi-particles/merges","archive_url":"https://api.github.com/repos/pixijs/pixi-particles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixijs/pixi-particles/downloads","issues_url":"https://api.github.com/repos/pixijs/pixi-particles/issues{/number}","pulls_url":"https://api.github.com/repos/pixijs/pixi-particles/pulls{/number}","milestones_url":"https://api.github.com/repos/pixijs/pixi-particles/milestones{/number}","notifications_url":"https://api.github.com/repos/pixijs/pixi-particles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixijs/pixi-particles/labels{/name}","releases_url":"https://api.github.com/repos/pixijs/pixi-particles/releases{/id}","deployments_url":"https://api.github.com/repos/pixijs/pixi-particles/deployments","created_at":"2014-08-26T21:47:10Z","updated_at":"2018-06-25T02:51:25Z","pushed_at":"2018-06-25T22:54:33Z","git_url":"git://github.com/pixijs/pixi-particles.git","ssh_url":"git@github.com:pixijs/pixi-particles.git","clone_url":"https://github.com/pixijs/pixi-particles.git","svn_url":"https://github.com/pixijs/pixi-particles","homepage":"http://pixijs.github.io/pixi-particles/docs","size":5738,"stargazers_count":319,"watchers_count":319,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":6,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85"},"html":{"href":"https://github.com/pixijs/pixi-particles/pull/85"},"issue":{"href":"https://api.github.com/repos/pixijs/pixi-particles/issues/85"},"comments":{"href":"https://api.github.com/repos/pixijs/pixi-particles/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixijs/pixi-particles/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/pixijs/pixi-particles/statuses/f2dc6c7f313a121dc6aa96520e586395ed848237"}},"author_association":"NONE"}}
{"actor":{"display_login":"andrewstart"}}