{"action":"created","issue":{"url":"https://api.github.com/repos/axa-ch/patterns-library/issues/585","repository_url":"https://api.github.com/repos/axa-ch/patterns-library","labels_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/585/labels{/name}","comments_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/585/comments","events_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/585/events","html_url":"https://github.com/axa-ch/patterns-library/pull/585","id":366311096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDE1MjIx","number":585,"title":"Feature/add prop types","user":{"login":"AndyOGo","id":914443,"node_id":"MDQ6VXNlcjkxNDQ0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/914443?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyOGo","html_url":"https://github.com/AndyOGo","followers_url":"https://api.github.com/users/AndyOGo/followers","following_url":"https://api.github.com/users/AndyOGo/following{/other_user}","gists_url":"https://api.github.com/users/AndyOGo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyOGo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyOGo/subscriptions","organizations_url":"https://api.github.com/users/AndyOGo/orgs","repos_url":"https://api.github.com/users/AndyOGo/repos","events_url":"https://api.github.com/users/AndyOGo/events{/privacy}","received_events_url":"https://api.github.com/users/AndyOGo/received_events","type":"User","site_admin":false},"labels":[{"id":765364091,"node_id":"MDU6TGFiZWw3NjUzNjQwOTE=","url":"https://api.github.com/repos/axa-ch/patterns-library/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":772088306,"node_id":"MDU6TGFiZWw3NzIwODgzMDY=","url":"https://api.github.com/repos/axa-ch/patterns-library/labels/high-prio","name":"high-prio","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"AndyOGo","id":914443,"node_id":"MDQ6VXNlcjkxNDQ0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/914443?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyOGo","html_url":"https://github.com/AndyOGo","followers_url":"https://api.github.com/users/AndyOGo/followers","following_url":"https://api.github.com/users/AndyOGo/following{/other_user}","gists_url":"https://api.github.com/users/AndyOGo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyOGo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyOGo/subscriptions","organizations_url":"https://api.github.com/users/AndyOGo/orgs","repos_url":"https://api.github.com/users/AndyOGo/repos","events_url":"https://api.github.com/users/AndyOGo/events{/privacy}","received_events_url":"https://api.github.com/users/AndyOGo/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndyOGo","id":914443,"node_id":"MDQ6VXNlcjkxNDQ0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/914443?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyOGo","html_url":"https://github.com/AndyOGo","followers_url":"https://api.github.com/users/AndyOGo/followers","following_url":"https://api.github.com/users/AndyOGo/following{/other_user}","gists_url":"https://api.github.com/users/AndyOGo/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyOGo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyOGo/subscriptions","organizations_url":"https://api.github.com/users/AndyOGo/orgs","repos_url":"https://api.github.com/users/AndyOGo/repos","events_url":"https://api.github.com/users/AndyOGo/events{/privacy}","received_events_url":"https://api.github.com/users/AndyOGo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-03T12:17:11Z","updated_at":"2018-10-05T07:50:01Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/axa-ch/patterns-library/pulls/585","html_url":"https://github.com/axa-ch/patterns-library/pull/585","diff_url":"https://github.com/axa-ch/patterns-library/pull/585.diff","patch_url":"https://github.com/axa-ch/patterns-library/pull/585.patch"},"body":"Fixes #495 \r\n\r\nChanges proposed in this pull request:\r\n\r\n - npm installed `prop-types`\r\n - added propTypes to each custom element\r\n - automatically check props on update\r\n - fixes broken boolean attributes on `attributeChangedCallback`\r\n - fixes col attribute validation for modifiers\r\n - derives `observedAttributes` from `propTypes` automatically 💪 \r\n - adds custom `url-prop-type`, `locale-prop-type`\r\n - installs `url-polyfill` for `URL` constructor\r\n\r\n## Type of change\r\n\r\n<!-- Please delete options that are not relevant. -->\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [x] This change requires a documentation update\r\n \r\n # How Has This Been Tested?\r\n \r\n <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. -->\r\n \r\n # Checklist:\r\n \r\n - [x] My code follows the style guidelines of this project\r\n - [x] I have performed a self-review of my own code\r\n - [x] I have commented my code, particularly in hard-to-understand areas\r\n - [x] I have made corresponding changes to the documentation\r\n - [x] My changes generate no new warnings\r\n - [ ] I have added tests that prove my fix is effective or that my feature works\r\n - [ ] New and existing unit tests pass locally with my changes\r\n - [ ] Any dependent changes have been merged and published in downstream modules\r\n"},"comment":{"url":"https://api.github.com/repos/axa-ch/patterns-library/issues/comments/427276995","html_url":"https://github.com/axa-ch/patterns-library/pull/585#issuecomment-427276995","issue_url":"https://api.github.com/repos/axa-ch/patterns-library/issues/585","id":427276995,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzI3Njk5NQ==","user":{"login":"LucaMele","id":275235,"node_id":"MDQ6VXNlcjI3NTIzNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/275235?v=4","gravatar_id":"","url":"https://api.github.com/users/LucaMele","html_url":"https://github.com/LucaMele","followers_url":"https://api.github.com/users/LucaMele/followers","following_url":"https://api.github.com/users/LucaMele/following{/other_user}","gists_url":"https://api.github.com/users/LucaMele/gists{/gist_id}","starred_url":"https://api.github.com/users/LucaMele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucaMele/subscriptions","organizations_url":"https://api.github.com/users/LucaMele/orgs","repos_url":"https://api.github.com/users/LucaMele/repos","events_url":"https://api.github.com/users/LucaMele/events{/privacy}","received_events_url":"https://api.github.com/users/LucaMele/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T07:50:01Z","updated_at":"2018-10-05T07:50:01Z","author_association":"MEMBER","body":"LGTM. I didnt test it thought. "}}
{"actor":{"display_login":"LucaMele"}}