{"action":"created","comment":{"url":"https://api.github.com/repos/halide/Halide/pulls/comments/233178608","pull_request_review_id":174532302,"id":233178608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE3ODYwOA==","diff_hunk":"@@ -274,8 +275,16 @@ bool can_prove(Expr e, const Scope<Interval> &bounds) {\n     };\n     e = RemoveLikelies().mutate(e);\n \n+    e = common_subexpression_elimination(e);\n+\n+    Expr orig = e;\n+\n     e = simplify(e, true, bounds);\n \n+    // When terms cancel, the simplifier doesn't always successfully\n+    // kill the dead lets.\n+    while (const Let *l = e.as<Let>()) e = l->body;","path":"src/Simplify.cpp","position":20,"original_position":20,"commit_id":"1cd4387f4edfbab0d54a6d1b3f48453ea305a17f","original_commit_id":"1cd4387f4edfbab0d54a6d1b3f48453ea305a17f","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"body":"Loops without { curly braces } make me nervous, even trivial ones like this. Don't we (generally) prefer all loopy structures to be embraced?","created_at":"2018-11-13T18:57:29Z","updated_at":"2018-11-13T18:58:24Z","html_url":"https://github.com/halide/Halide/pull/3431#discussion_r233178608","pull_request_url":"https://api.github.com/repos/halide/Halide/pulls/3431","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments/233178608"},"html":{"href":"https://github.com/halide/Halide/pull/3431#discussion_r233178608"},"pull_request":{"href":"https://api.github.com/repos/halide/Halide/pulls/3431"}}},"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/3431","id":229796806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzk2ODA2","html_url":"https://github.com/halide/Halide/pull/3431","diff_url":"https://github.com/halide/Halide/pull/3431.diff","patch_url":"https://github.com/halide/Halide/pull/3431.patch","issue_url":"https://api.github.com/repos/halide/Halide/issues/3431","number":3431,"state":"open","locked":false,"title":"Make can_prove use CSE and trim dead lets","user":{"login":"abadams","id":515398,"node_id":"MDQ6VXNlcjUxNTM5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/515398?v=4","gravatar_id":"","url":"https://api.github.com/users/abadams","html_url":"https://github.com/abadams","followers_url":"https://api.github.com/users/abadams/followers","following_url":"https://api.github.com/users/abadams/following{/other_user}","gists_url":"https://api.github.com/users/abadams/gists{/gist_id}","starred_url":"https://api.github.com/users/abadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadams/subscriptions","organizations_url":"https://api.github.com/users/abadams/orgs","repos_url":"https://api.github.com/users/abadams/repos","events_url":"https://api.github.com/users/abadams/events{/privacy}","received_events_url":"https://api.github.com/users/abadams/received_events","type":"User","site_admin":false},"body":"This makes it slightly more powerful. \r\n\r\nAlso report the original unsimplified expression too when a proof fails so we know what original state got the simplifier stuck in a local minimum.","created_at":"2018-11-09T19:32:56Z","updated_at":"2018-11-13T18:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85e555824d92286b165020bf414729cf619b7fbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/halide/Halide/pulls/3431/commits","review_comments_url":"https://api.github.com/repos/halide/Halide/pulls/3431/comments","review_comment_url":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halide/Halide/issues/3431/comments","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/1cd4387f4edfbab0d54a6d1b3f48453ea305a17f","head":{"label":"halide:can_prove_does_cse","ref":"can_prove_does_cse","sha":"1cd4387f4edfbab0d54a6d1b3f48453ea305a17f","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-11-13T07:08:15Z","pushed_at":"2018-11-13T18:41:45Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":253649,"stargazers_count":2618,"watchers_count":2618,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"open_issues_count":516,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":543,"open_issues":516,"watchers":2618,"default_branch":"master"}},"base":{"label":"halide:master","ref":"master","sha":"7a375f17f703076ea85e63c59c7f26d05142a265","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-11-13T07:08:15Z","pushed_at":"2018-11-13T18:41:45Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":253649,"stargazers_count":2618,"watchers_count":2618,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"open_issues_count":516,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":543,"open_issues":516,"watchers":2618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/3431"},"html":{"href":"https://github.com/halide/Halide/pull/3431"},"issue":{"href":"https://api.github.com/repos/halide/Halide/issues/3431"},"comments":{"href":"https://api.github.com/repos/halide/Halide/issues/3431/comments"},"review_comments":{"href":"https://api.github.com/repos/halide/Halide/pulls/3431/comments"},"review_comment":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halide/Halide/pulls/3431/commits"},"statuses":{"href":"https://api.github.com/repos/halide/Halide/statuses/1cd4387f4edfbab0d54a6d1b3f48453ea305a17f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"steven-johnson"}}