{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/208520140","pull_request_review_id":144343323,"id":208520140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODUyMDE0MA==","diff_hunk":"@@ -1,15 +1,39 @@\n /* global FluentSyntax */\n var fluentParser = new FluentSyntax.FluentParser({ withSpans: false });\n+var fluentParserOriginal = new FluentSyntax.FluentParser({ withSpans: false });","path":"pontoon/base/static/js/fluent_interface.js","position":3,"original_position":3,"commit_id":"d206ae3940fe22b4cbdb3f493da05284e8c82c61","original_commit_id":"d206ae3940fe22b4cbdb3f493da05284e8c82c61","user":{"login":"mathjazz","id":626716,"node_id":"MDQ6VXNlcjYyNjcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"body":"I was thinking about that initially, but then I changed my mind, because it's a temporary workaround and eventually we'd need to replace `parseEntry()` with `fluentParser.parseEntry()` again. Do you think I should still do it?","created_at":"2018-08-08T09:45:36Z","updated_at":"2018-08-08T09:45:36Z","html_url":"https://github.com/mozilla/pontoon/pull/1026#discussion_r208520140","pull_request_url":"https://api.github.com/repos/mozilla/pontoon/pulls/1026","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments/208520140"},"html":{"href":"https://github.com/mozilla/pontoon/pull/1026#discussion_r208520140"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1026"}},"in_reply_to_id":208505369},"pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/1026","id":204076707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDc2NzA3","html_url":"https://github.com/mozilla/pontoon/pull/1026","diff_url":"https://github.com/mozilla/pontoon/pull/1026.diff","patch_url":"https://github.com/mozilla/pontoon/pull/1026.patch","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/1026","number":1026,"state":"open","locked":false,"title":"Fix bug 1465121: Update to Fluent Syntax 0.6","user":{"login":"mathjazz","id":626716,"node_id":"MDQ6VXNlcjYyNjcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"body":"For testing I suggest setting up the [Pontoon FTL](https://github.com/mozilla-l10n/pontoon-ftl) project locally and comparing the behaviour of the `demo.ftl` file (which tries to capture all syntax details) to [stage](https://mozilla-pontoon-staging.herokuapp.com/sl/fluent/demo.ftl/?string=180475) (which still uses the old libraries).\r\n\r\nI enabled 2 locales:\r\n* `sl`: to see how existing translations look\r\n* `af`: to test empty editor and submitting translations\r\n\r\nNote that `VariantLists` are not supported yet.","created_at":"2018-07-26T09:13:52Z","updated_at":"2018-08-08T09:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f80e12aa666efa224825b69b4498e4cc2bb767dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pontoon/pulls/1026/commits","review_comments_url":"https://api.github.com/repos/mozilla/pontoon/pulls/1026/comments","review_comment_url":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/1026/comments","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/d206ae3940fe22b4cbdb3f493da05284e8c82c61","head":{"label":"mathjazz:bug-1465121-fluent-06","ref":"bug-1465121-fluent-06","sha":"d206ae3940fe22b4cbdb3f493da05284e8c82c61","user":{"login":"mathjazz","id":626716,"node_id":"MDQ6VXNlcjYyNjcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"repo":{"id":35116849,"node_id":"MDEwOlJlcG9zaXRvcnkzNTExNjg0OQ==","name":"pontoon","full_name":"mathjazz/pontoon","owner":{"login":"mathjazz","id":626716,"node_id":"MDQ6VXNlcjYyNjcxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/626716?v=4","gravatar_id":"","url":"https://api.github.com/users/mathjazz","html_url":"https://github.com/mathjazz","followers_url":"https://api.github.com/users/mathjazz/followers","following_url":"https://api.github.com/users/mathjazz/following{/other_user}","gists_url":"https://api.github.com/users/mathjazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mathjazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathjazz/subscriptions","organizations_url":"https://api.github.com/users/mathjazz/orgs","repos_url":"https://api.github.com/users/mathjazz/repos","events_url":"https://api.github.com/users/mathjazz/events{/privacy}","received_events_url":"https://api.github.com/users/mathjazz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathjazz/pontoon","description":"In-place localization tool","fork":true,"url":"https://api.github.com/repos/mathjazz/pontoon","forks_url":"https://api.github.com/repos/mathjazz/pontoon/forks","keys_url":"https://api.github.com/repos/mathjazz/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathjazz/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathjazz/pontoon/teams","hooks_url":"https://api.github.com/repos/mathjazz/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mathjazz/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mathjazz/pontoon/events","assignees_url":"https://api.github.com/repos/mathjazz/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mathjazz/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mathjazz/pontoon/tags","blobs_url":"https://api.github.com/repos/mathjazz/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathjazz/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathjazz/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathjazz/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathjazz/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mathjazz/pontoon/languages","stargazers_url":"https://api.github.com/repos/mathjazz/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mathjazz/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mathjazz/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mathjazz/pontoon/subscription","commits_url":"https://api.github.com/repos/mathjazz/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathjazz/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathjazz/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathjazz/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathjazz/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mathjazz/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathjazz/pontoon/merges","archive_url":"https://api.github.com/repos/mathjazz/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathjazz/pontoon/downloads","issues_url":"https://api.github.com/repos/mathjazz/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mathjazz/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mathjazz/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mathjazz/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathjazz/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mathjazz/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mathjazz/pontoon/deployments","created_at":"2015-05-05T18:28:58Z","updated_at":"2018-08-08T09:04:26Z","pushed_at":"2018-08-08T09:04:24Z","git_url":"git://github.com/mathjazz/pontoon.git","ssh_url":"git@github.com:mathjazz/pontoon.git","clone_url":"https://github.com/mathjazz/pontoon.git","svn_url":"https://github.com/mathjazz/pontoon","homepage":"https://pontoon.mozilla.org/","size":24367,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"838a916c4b6c1742875b2f2c3ec9ddfe8e9d2203","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1385890,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1ODkw","name":"pontoon","full_name":"mozilla/pontoon","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pontoon","description":"Mozilla's Localization Platform","fork":false,"url":"https://api.github.com/repos/mozilla/pontoon","forks_url":"https://api.github.com/repos/mozilla/pontoon/forks","keys_url":"https://api.github.com/repos/mozilla/pontoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pontoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pontoon/teams","hooks_url":"https://api.github.com/repos/mozilla/pontoon/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pontoon/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pontoon/events","assignees_url":"https://api.github.com/repos/mozilla/pontoon/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pontoon/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pontoon/tags","blobs_url":"https://api.github.com/repos/mozilla/pontoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pontoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pontoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pontoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pontoon/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pontoon/languages","stargazers_url":"https://api.github.com/repos/mozilla/pontoon/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pontoon/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pontoon/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pontoon/subscription","commits_url":"https://api.github.com/repos/mozilla/pontoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pontoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pontoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pontoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pontoon/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pontoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pontoon/merges","archive_url":"https://api.github.com/repos/mozilla/pontoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pontoon/downloads","issues_url":"https://api.github.com/repos/mozilla/pontoon/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pontoon/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pontoon/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pontoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pontoon/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pontoon/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pontoon/deployments","created_at":"2011-02-19T11:25:51Z","updated_at":"2018-08-08T07:51:30Z","pushed_at":"2018-08-08T07:51:27Z","git_url":"git://github.com/mozilla/pontoon.git","ssh_url":"git@github.com:mozilla/pontoon.git","clone_url":"https://github.com/mozilla/pontoon.git","svn_url":"https://github.com/mozilla/pontoon","homepage":"https://pontoon.mozilla.org/","size":24401,"stargazers_count":424,"watchers_count":424,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":123,"open_issues":5,"watchers":424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1026"},"html":{"href":"https://github.com/mozilla/pontoon/pull/1026"},"issue":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/1026"},"comments":{"href":"https://api.github.com/repos/mozilla/pontoon/issues/1026/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1026/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pontoon/pulls/1026/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pontoon/statuses/d206ae3940fe22b4cbdb3f493da05284e8c82c61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mathjazz"}}