{"action":"opened","number":873,"pull_request":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/873","id":237632350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjMyMzUw","html_url":"https://github.com/yast/yast-yast2/pull/873","diff_url":"https://github.com/yast/yast-yast2/pull/873.diff","patch_url":"https://github.com/yast/yast-yast2/pull/873.patch","issue_url":"https://api.github.com/repos/yast/yast-yast2/issues/873","number":873,"state":"open","locked":false,"title":"WIP: Security Audit Fixes: Removed unused functions with potential security issues","user":{"login":"shundhammer","id":11538225,"node_id":"MDQ6VXNlcjExNTM4MjI1","avatar_url":"https://avatars1.githubusercontent.com/u/11538225?v=4","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"body":"This is part of the YaST security audit by @jsegitz.\r\n\r\nFrom the audit:\r\n\r\n> yast2/yast2-4.1.6/library/general/src/modules/Misc.rb:233\r\n> \r\n>  RunCommandWithTimeout should be reworked to receive an absolute path and arguments that then can be quoted/escaped\r\n\r\nThat function is only used once in all of YaST, and that's in another function _RunDumbTimeout()_ that is also not used.\r\n\r\nRemoving both of them to get rid of potential security hazards _and_ of dead code.","created_at":"2018-12-11T10:51:34Z","updated_at":"2018-12-11T10:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-yast2/pulls/873/commits","review_comments_url":"https://api.github.com/repos/yast/yast-yast2/pulls/873/comments","review_comment_url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-yast2/issues/873/comments","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/23c7fcf21042c23753d063229b5462f99930f299","head":{"label":"shundhammer:huha-security-audit-fixes","ref":"huha-security-audit-fixes","sha":"23c7fcf21042c23753d063229b5462f99930f299","user":{"login":"shundhammer","id":11538225,"node_id":"MDQ6VXNlcjExNTM4MjI1","avatar_url":"https://avatars1.githubusercontent.com/u/11538225?v=4","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"repo":{"id":38038947,"node_id":"MDEwOlJlcG9zaXRvcnkzODAzODk0Nw==","name":"yast-yast2","full_name":"shundhammer/yast-yast2","private":false,"owner":{"login":"shundhammer","id":11538225,"node_id":"MDQ6VXNlcjExNTM4MjI1","avatar_url":"https://avatars1.githubusercontent.com/u/11538225?v=4","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shundhammer/yast-yast2","description":"YaST module yast2","fork":true,"url":"https://api.github.com/repos/shundhammer/yast-yast2","forks_url":"https://api.github.com/repos/shundhammer/yast-yast2/forks","keys_url":"https://api.github.com/repos/shundhammer/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shundhammer/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shundhammer/yast-yast2/teams","hooks_url":"https://api.github.com/repos/shundhammer/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/shundhammer/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/shundhammer/yast-yast2/events","assignees_url":"https://api.github.com/repos/shundhammer/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/shundhammer/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/shundhammer/yast-yast2/tags","blobs_url":"https://api.github.com/repos/shundhammer/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shundhammer/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shundhammer/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/shundhammer/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shundhammer/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/shundhammer/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/shundhammer/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/shundhammer/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/shundhammer/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/shundhammer/yast-yast2/subscription","commits_url":"https://api.github.com/repos/shundhammer/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/shundhammer/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/shundhammer/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/shundhammer/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/shundhammer/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/shundhammer/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shundhammer/yast-yast2/merges","archive_url":"https://api.github.com/repos/shundhammer/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shundhammer/yast-yast2/downloads","issues_url":"https://api.github.com/repos/shundhammer/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/shundhammer/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/shundhammer/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/shundhammer/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shundhammer/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/shundhammer/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/shundhammer/yast-yast2/deployments","created_at":"2015-06-25T08:57:19Z","updated_at":"2018-12-11T10:21:06Z","pushed_at":"2018-12-11T10:38:27Z","git_url":"git://github.com/shundhammer/yast-yast2.git","ssh_url":"git@github.com:shundhammer/yast-yast2.git","clone_url":"https://github.com/shundhammer/yast-yast2.git","svn_url":"https://github.com/shundhammer/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":26404,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"d6e15f4a3aaa298988b560b37cef2cefda4ac878","user":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"node_id":"MDEwOlJlcG9zaXRvcnk0MzY4MjQ0","name":"yast-yast2","full_name":"yast/yast-yast2","private":false,"owner":{"login":"yast","id":909990,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTk5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-yast2/deployments","created_at":"2012-05-18T10:27:22Z","updated_at":"2018-12-07T07:38:11Z","pushed_at":"2018-12-11T08:04:26Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":26886,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":34,"open_issues":18,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/873"},"html":{"href":"https://github.com/yast/yast-yast2/pull/873"},"issue":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/873"},"comments":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/873/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/873/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/873/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-yast2/statuses/23c7fcf21042c23753d063229b5462f99930f299"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":0,"deletions":129,"changed_files":1}}
{"actor":{"display_login":"shundhammer"}}