{"action":"created","issue":{"url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/490","repository_url":"https://api.github.com/repos/osmlab/editor-layer-index","labels_url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/490/labels{/name}","comments_url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/490/comments","events_url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/490/events","html_url":"https://github.com/osmlab/editor-layer-index/pull/490","id":323088917,"number":490,"title":"Use JavaScript for everything, split sources into features and resources","user":{"login":"bhousel","id":38784,"avatar_url":"https://avatars1.githubusercontent.com/u/38784?v=4","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2018-05-15T06:56:09Z","updated_at":"2018-05-26T15:15:35Z","closed_at":"2018-05-26T15:15:35Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/osmlab/editor-layer-index/pulls/490","html_url":"https://github.com/osmlab/editor-layer-index/pull/490","diff_url":"https://github.com/osmlab/editor-layer-index/pull/490.diff","patch_url":"https://github.com/osmlab/editor-layer-index/pull/490.patch"},"body":"Much of this approach is copied from https://github.com/osmlab/osm-community-index\r\ncloses #168 #211 #214 #216 #217 (maybe #179 with the polygon deduplication)\r\n\r\nThere's a lot going on here, but I'll try to list out what has changed:\r\n\r\n### What's done:\r\n\r\n**Everything that was Python/Make is now JavaScript**  \r\nThis makes it much easier to setup your development environment and manage dependencies.  The only prerequisite now is Node.\r\n- `npm install` to install the dependencies\r\n- `npm run build` to build the index\r\n- `npm run test` to test it\r\n- `package.json` contains all the dependencies and commands you can run\r\n\r\n**The files originally under `sources/` have been split up:**\r\n-  `features/` (.geojson files for the polygons)\r\n-  `resources/`  (.json files for the imagery information - original files were `git mv` here, to preserve history)\r\n  This lets us reuse polygons..\r\n\r\n**~~License is changed to ISC~~**\r\n- ~~it's just simpler~~\r\nWe decided against this, to allow continued sync with JOSM\r\n\r\n**More goodies:**\r\n  - .geojson files are automatically [rewound correctly](https://github.com/mapbox/geojson-rewind)\r\n  - coordinates are truncated to [5 decimal places](https://github.com/jczaplew/geojson-precision)\r\n  - feature and resource files are all [prettified](https://github.com/lydell/json-stringify-pretty-compact) in a format that is easier to read and diffs better\r\n  - `npm run stats` will show you what files are taking up the most space in the index\r\n  - `RELEASE.md` contains instructions on how to prepare a release, publish to `release` branch, tag (github release) and `npm publish`\r\n  - Translation file `i18n/en.yaml` is done\r\n\r\n### Still to do:\r\n- [ ] restore some of the tests that the old code did (checking for valid urls, etc)\r\n- [ ] restore a backwards compatible output for `imagery.json` / `imagery.geojson`\r\n- [ ] restore the `imagery.xml` output\r\n- [x] actually go through and dedupe the polygons (right now I just copied them from source)\r\n- [x] convert some features to \"true\" MultiPolygons (this is #217)\r\n- [ ] fix the preview map\r\n- [ ] update `CONTRIBUTING` and `README` instructions\r\n\r\nI also recommend:\r\n- [ ] switch the main branch from `gh-pages` to `master`\r\n- [ ] get rid of the Robot Fairhurst integration\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/comments/392267772","html_url":"https://github.com/osmlab/editor-layer-index/pull/490#issuecomment-392267772","issue_url":"https://api.github.com/repos/osmlab/editor-layer-index/issues/490","id":392267772,"user":{"login":"bhousel","id":38784,"avatar_url":"https://avatars1.githubusercontent.com/u/38784?v=4","gravatar_id":"","url":"https://api.github.com/users/bhousel","html_url":"https://github.com/bhousel","followers_url":"https://api.github.com/users/bhousel/followers","following_url":"https://api.github.com/users/bhousel/following{/other_user}","gists_url":"https://api.github.com/users/bhousel/gists{/gist_id}","starred_url":"https://api.github.com/users/bhousel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhousel/subscriptions","organizations_url":"https://api.github.com/users/bhousel/orgs","repos_url":"https://api.github.com/users/bhousel/repos","events_url":"https://api.github.com/users/bhousel/events{/privacy}","received_events_url":"https://api.github.com/users/bhousel/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T15:15:35Z","updated_at":"2018-05-26T15:15:35Z","author_association":"MEMBER","body":"> As I said on IRC a few days ago, I'm still not sure I see the business case for the rewrite. It has an organisational cost to the project, and we should be sure that it's worth that cost and that there are no easier alternatives before we spend the energy on it.\r\n\r\nOk, let's leave things as-is then.."}}
{"actor":{"display_login":"bhousel"}}