{"action":"closed","number":242,"pull_request":{"url":"https://api.github.com/repos/Semmle/ql/pulls/242","id":218618332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjE4MzMy","html_url":"https://github.com/Semmle/ql/pull/242","diff_url":"https://github.com/Semmle/ql/pull/242.diff","patch_url":"https://github.com/Semmle/ql/pull/242.patch","issue_url":"https://api.github.com/repos/Semmle/ql/issues/242","number":242,"state":"closed","locked":false,"title":"C++: Make unresolve dispatch on `result`","user":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"body":"This change means that there are no results for `unresolveElement(t)` where `t` is a \"junk type\" -- a class definition that is not in the image of `resolveClass`. These \"junk types\" still exist as `Element`s, but they will never be returned by any predicate that goes through `unresolveElement` to query the db.\r\n\r\nWe get a small reduction in DIL size and a significant speed improvement. The DIL for `NewArrayDeleteMismatch.ql` is reduced from 27,630 lines to 27,507 lines, and the total analysis time for the LGTM suite on jdk8u is reduced from 1158s to 984s. This makes it faster than 1.17.2 on jdk8u, even when disregarding the one query where 1.17.2 has a serious performance problem.\r\n\r\nThis change is in quite similar to #215. The main difference is that the inlined type check is (effectively) `t instanceof @usertype` instead of `isClass(t)`, and the former is much easier for the optimiser to eliminate statically.","created_at":"2018-09-27T11:33:03Z","updated_at":"2018-09-27T13:59:35Z","closed_at":"2018-09-27T13:59:35Z","merged_at":"2018-09-27T13:59:35Z","merge_commit_sha":"077ce6a4be598a9c6f4f498c6c98bc64717b70e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pavgust","id":1101487,"node_id":"MDQ6VXNlcjExMDE0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1101487?v=4","gravatar_id":"","url":"https://api.github.com/users/pavgust","html_url":"https://github.com/pavgust","followers_url":"https://api.github.com/users/pavgust/followers","following_url":"https://api.github.com/users/pavgust/following{/other_user}","gists_url":"https://api.github.com/users/pavgust/gists{/gist_id}","starred_url":"https://api.github.com/users/pavgust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavgust/subscriptions","organizations_url":"https://api.github.com/users/pavgust/orgs","repos_url":"https://api.github.com/users/pavgust/repos","events_url":"https://api.github.com/users/pavgust/events{/privacy}","received_events_url":"https://api.github.com/users/pavgust/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1013984560,"node_id":"MDU6TGFiZWwxMDEzOTg0NTYw","url":"https://api.github.com/repos/Semmle/ql/labels/C++","name":"C++","color":"6add92","default":false}],"milestone":{"url":"https://api.github.com/repos/Semmle/ql/milestones/1","html_url":"https://github.com/Semmle/ql/milestone/1","labels_url":"https://api.github.com/repos/Semmle/ql/milestones/1/labels","id":3606683,"node_id":"MDk6TWlsZXN0b25lMzYwNjY4Mw==","number":1,"title":"1.18","description":null,"creator":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":37,"state":"open","created_at":"2018-08-29T12:14:09Z","updated_at":"2018-09-27T13:59:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Semmle/ql/pulls/242/commits","review_comments_url":"https://api.github.com/repos/Semmle/ql/pulls/242/comments","review_comment_url":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Semmle/ql/issues/242/comments","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/0da452d59a1c0b7efad199dd321a31031b3fd45c","head":{"label":"jbj:unresolveCheckResult","ref":"unresolveCheckResult","sha":"0da452d59a1c0b7efad199dd321a31031b3fd45c","user":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"repo":{"id":143869365,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4NjkzNjU=","name":"ql","full_name":"jbj/ql","private":false,"owner":{"login":"jbj","id":308293,"node_id":"MDQ6VXNlcjMwODI5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/308293?v=4","gravatar_id":"","url":"https://api.github.com/users/jbj","html_url":"https://github.com/jbj","followers_url":"https://api.github.com/users/jbj/followers","following_url":"https://api.github.com/users/jbj/following{/other_user}","gists_url":"https://api.github.com/users/jbj/gists{/gist_id}","starred_url":"https://api.github.com/users/jbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbj/subscriptions","organizations_url":"https://api.github.com/users/jbj/orgs","repos_url":"https://api.github.com/users/jbj/repos","events_url":"https://api.github.com/users/jbj/events{/privacy}","received_events_url":"https://api.github.com/users/jbj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbj/ql","description":null,"fork":true,"url":"https://api.github.com/repos/jbj/ql","forks_url":"https://api.github.com/repos/jbj/ql/forks","keys_url":"https://api.github.com/repos/jbj/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbj/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbj/ql/teams","hooks_url":"https://api.github.com/repos/jbj/ql/hooks","issue_events_url":"https://api.github.com/repos/jbj/ql/issues/events{/number}","events_url":"https://api.github.com/repos/jbj/ql/events","assignees_url":"https://api.github.com/repos/jbj/ql/assignees{/user}","branches_url":"https://api.github.com/repos/jbj/ql/branches{/branch}","tags_url":"https://api.github.com/repos/jbj/ql/tags","blobs_url":"https://api.github.com/repos/jbj/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbj/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbj/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbj/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbj/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/jbj/ql/languages","stargazers_url":"https://api.github.com/repos/jbj/ql/stargazers","contributors_url":"https://api.github.com/repos/jbj/ql/contributors","subscribers_url":"https://api.github.com/repos/jbj/ql/subscribers","subscription_url":"https://api.github.com/repos/jbj/ql/subscription","commits_url":"https://api.github.com/repos/jbj/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbj/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbj/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbj/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbj/ql/contents/{+path}","compare_url":"https://api.github.com/repos/jbj/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbj/ql/merges","archive_url":"https://api.github.com/repos/jbj/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbj/ql/downloads","issues_url":"https://api.github.com/repos/jbj/ql/issues{/number}","pulls_url":"https://api.github.com/repos/jbj/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/jbj/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/jbj/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbj/ql/labels{/name}","releases_url":"https://api.github.com/repos/jbj/ql/releases{/id}","deployments_url":"https://api.github.com/repos/jbj/ql/deployments","created_at":"2018-08-07T12:21:39Z","updated_at":"2018-09-26T13:26:33Z","pushed_at":"2018-09-27T12:12:49Z","git_url":"git://github.com/jbj/ql.git","ssh_url":"git@github.com:jbj/ql.git","clone_url":"https://github.com/jbj/ql.git","svn_url":"https://github.com/jbj/ql","homepage":null,"size":7892,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Semmle:rc/1.18","ref":"rc/1.18","sha":"4767d85a96d2ff81c1a6b9047c5205f06e06006b","user":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"repo":{"id":143040428,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDA0Mjg=","name":"ql","full_name":"Semmle/ql","private":false,"owner":{"login":"Semmle","id":1101495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1101495?v=4","gravatar_id":"","url":"https://api.github.com/users/Semmle","html_url":"https://github.com/Semmle","followers_url":"https://api.github.com/users/Semmle/followers","following_url":"https://api.github.com/users/Semmle/following{/other_user}","gists_url":"https://api.github.com/users/Semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/Semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semmle/subscriptions","organizations_url":"https://api.github.com/users/Semmle/orgs","repos_url":"https://api.github.com/users/Semmle/repos","events_url":"https://api.github.com/users/Semmle/events{/privacy}","received_events_url":"https://api.github.com/users/Semmle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Semmle/ql","description":"The standard QL libraries and queries that power LGTM.com and other Semmle Products","fork":false,"url":"https://api.github.com/repos/Semmle/ql","forks_url":"https://api.github.com/repos/Semmle/ql/forks","keys_url":"https://api.github.com/repos/Semmle/ql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semmle/ql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semmle/ql/teams","hooks_url":"https://api.github.com/repos/Semmle/ql/hooks","issue_events_url":"https://api.github.com/repos/Semmle/ql/issues/events{/number}","events_url":"https://api.github.com/repos/Semmle/ql/events","assignees_url":"https://api.github.com/repos/Semmle/ql/assignees{/user}","branches_url":"https://api.github.com/repos/Semmle/ql/branches{/branch}","tags_url":"https://api.github.com/repos/Semmle/ql/tags","blobs_url":"https://api.github.com/repos/Semmle/ql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semmle/ql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semmle/ql/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semmle/ql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semmle/ql/statuses/{sha}","languages_url":"https://api.github.com/repos/Semmle/ql/languages","stargazers_url":"https://api.github.com/repos/Semmle/ql/stargazers","contributors_url":"https://api.github.com/repos/Semmle/ql/contributors","subscribers_url":"https://api.github.com/repos/Semmle/ql/subscribers","subscription_url":"https://api.github.com/repos/Semmle/ql/subscription","commits_url":"https://api.github.com/repos/Semmle/ql/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semmle/ql/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semmle/ql/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semmle/ql/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semmle/ql/contents/{+path}","compare_url":"https://api.github.com/repos/Semmle/ql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semmle/ql/merges","archive_url":"https://api.github.com/repos/Semmle/ql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semmle/ql/downloads","issues_url":"https://api.github.com/repos/Semmle/ql/issues{/number}","pulls_url":"https://api.github.com/repos/Semmle/ql/pulls{/number}","milestones_url":"https://api.github.com/repos/Semmle/ql/milestones{/number}","notifications_url":"https://api.github.com/repos/Semmle/ql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semmle/ql/labels{/name}","releases_url":"https://api.github.com/repos/Semmle/ql/releases{/id}","deployments_url":"https://api.github.com/repos/Semmle/ql/deployments","created_at":"2018-07-31T16:35:51Z","updated_at":"2018-09-27T10:59:04Z","pushed_at":"2018-09-27T13:59:35Z","git_url":"git://github.com/Semmle/ql.git","ssh_url":"git@github.com:Semmle/ql.git","clone_url":"https://github.com/Semmle/ql.git","svn_url":"https://github.com/Semmle/ql","homepage":"https://semmle.com/ql","size":7903,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":24,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Semmle/ql/pulls/242"},"html":{"href":"https://github.com/Semmle/ql/pull/242"},"issue":{"href":"https://api.github.com/repos/Semmle/ql/issues/242"},"comments":{"href":"https://api.github.com/repos/Semmle/ql/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/Semmle/ql/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/Semmle/ql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Semmle/ql/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/Semmle/ql/statuses/0da452d59a1c0b7efad199dd321a31031b3fd45c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ian-semmle","id":22643163,"node_id":"MDQ6VXNlcjIyNjQzMTYz","avatar_url":"https://avatars3.githubusercontent.com/u/22643163?v=4","gravatar_id":"","url":"https://api.github.com/users/ian-semmle","html_url":"https://github.com/ian-semmle","followers_url":"https://api.github.com/users/ian-semmle/followers","following_url":"https://api.github.com/users/ian-semmle/following{/other_user}","gists_url":"https://api.github.com/users/ian-semmle/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-semmle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-semmle/subscriptions","organizations_url":"https://api.github.com/users/ian-semmle/orgs","repos_url":"https://api.github.com/users/ian-semmle/repos","events_url":"https://api.github.com/users/ian-semmle/events{/privacy}","received_events_url":"https://api.github.com/users/ian-semmle/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":32,"changed_files":4}}
{"actor":{"display_login":"ian-semmle"}}