{"action":"created","comment":{"url":"https://api.github.com/repos/floored/blocks/pulls/comments/203435119","pull_request_review_id":138323927,"id":203435119,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQzNTExOQ==","diff_hunk":"@@ -37,7 +37,11 @@ class Dropdown extends React.Component {\n     return (\n       <div className=\"dropdown-wrapper\">\n         <div className=\"dropdown\">\n-          <p className=\"dropdown-description\">{this.props.description}</p>\n+          {this.props.description && (\n+            <div>\n+              <label className=\"dropdown-description is-inline-block\">{this.props.description}</label>","path":"react/dropdowns/Dropdown.jsx","position":7,"original_position":7,"commit_id":"5f4e1baaf95c8828160e7174050e91ac7d0a2f7c","original_commit_id":"5f4e1baaf95c8828160e7174050e91ac7d0a2f7c","user":{"login":"MagdalenaHenke","id":6024274,"node_id":"MDQ6VXNlcjYwMjQyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6024274?v=4","gravatar_id":"","url":"https://api.github.com/users/MagdalenaHenke","html_url":"https://github.com/MagdalenaHenke","followers_url":"https://api.github.com/users/MagdalenaHenke/followers","following_url":"https://api.github.com/users/MagdalenaHenke/following{/other_user}","gists_url":"https://api.github.com/users/MagdalenaHenke/gists{/gist_id}","starred_url":"https://api.github.com/users/MagdalenaHenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagdalenaHenke/subscriptions","organizations_url":"https://api.github.com/users/MagdalenaHenke/orgs","repos_url":"https://api.github.com/users/MagdalenaHenke/repos","events_url":"https://api.github.com/users/MagdalenaHenke/events{/privacy}","received_events_url":"https://api.github.com/users/MagdalenaHenke/received_events","type":"User","site_admin":false},"body":"oooh good call. That's what I get for doing in spacer first. ","created_at":"2018-07-18T15:57:09Z","updated_at":"2018-07-18T15:57:09Z","html_url":"https://github.com/floored/blocks/pull/19#discussion_r203435119","pull_request_url":"https://api.github.com/repos/floored/blocks/pulls/19","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/floored/blocks/pulls/comments/203435119"},"html":{"href":"https://github.com/floored/blocks/pull/19#discussion_r203435119"},"pull_request":{"href":"https://api.github.com/repos/floored/blocks/pulls/19"}},"in_reply_to_id":203428209},"pull_request":{"url":"https://api.github.com/repos/floored/blocks/pulls/19","id":202255188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjU1MTg4","html_url":"https://github.com/floored/blocks/pull/19","diff_url":"https://github.com/floored/blocks/pull/19.diff","patch_url":"https://github.com/floored/blocks/pull/19.patch","issue_url":"https://api.github.com/repos/floored/blocks/issues/19","number":19,"state":"open","locked":false,"title":"Align labelless inputs","user":{"login":"MagdalenaHenke","id":6024274,"node_id":"MDQ6VXNlcjYwMjQyNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6024274?v=4","gravatar_id":"","url":"https://api.github.com/users/MagdalenaHenke","html_url":"https://github.com/MagdalenaHenke","followers_url":"https://api.github.com/users/MagdalenaHenke/followers","following_url":"https://api.github.com/users/MagdalenaHenke/following{/other_user}","gists_url":"https://api.github.com/users/MagdalenaHenke/gists{/gist_id}","starred_url":"https://api.github.com/users/MagdalenaHenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagdalenaHenke/subscriptions","organizations_url":"https://api.github.com/users/MagdalenaHenke/orgs","repos_url":"https://api.github.com/users/MagdalenaHenke/repos","events_url":"https://api.github.com/users/MagdalenaHenke/events{/privacy}","received_events_url":"https://api.github.com/users/MagdalenaHenke/received_events","type":"User","site_admin":false},"body":"@emma-floored @hwigmore \r\n\r\nCurrently, if you have two text inputs or a text input and a dropdown next to each other, and one has a label, and the other one doesn't, they are not lined up, which shows in some of our forms. They right now look like this:\r\n<img width=\"300\" alt=\"screen shot 2018-07-17 at 4 54 10 pm\" src=\"https://user-images.githubusercontent.com/6024274/42844803-1f518e8c-89e2-11e8-8a4b-593942293904.png\">\r\n<img width=\"300\" alt=\"screen shot 2018-07-17 at 4 54 06 pm\" src=\"https://user-images.githubusercontent.com/6024274/42844804-1f5b3fcc-89e2-11e8-97c6-90a21b9d9279.png\">\r\n\r\nI thought it's best that if there is no label, there continues to be no space held for a label. But I thought if one _wants to force alignment_, one could pass in a *whitespace label* (like ' '), which now pushes everything into alignment, like this:\r\n\r\n<img width=\"300\" alt=\"screen shot 2018-07-17 at 4 54 38 pm\" src=\"https://user-images.githubusercontent.com/6024274/42844801-1f3da67e-89e2-11e8-836f-542a61103f8d.png\">\r\n<img width=\"300\" alt=\"screen shot 2018-07-17 at 4 54 33 pm\" src=\"https://user-images.githubusercontent.com/6024274/42844802-1f47f354-89e2-11e8-961f-7fc37f84969c.png\">\r\n\r\nI know it's a taaad hacky, but how do you feel about it?","created_at":"2018-07-18T13:34:36Z","updated_at":"2018-07-18T15:57:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15b1c4d0e8dfc1605e60fa832a52624cce574f90","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hwigmore","id":5186744,"node_id":"MDQ6VXNlcjUxODY3NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5186744?v=4","gravatar_id":"","url":"https://api.github.com/users/hwigmore","html_url":"https://github.com/hwigmore","followers_url":"https://api.github.com/users/hwigmore/followers","following_url":"https://api.github.com/users/hwigmore/following{/other_user}","gists_url":"https://api.github.com/users/hwigmore/gists{/gist_id}","starred_url":"https://api.github.com/users/hwigmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwigmore/subscriptions","organizations_url":"https://api.github.com/users/hwigmore/orgs","repos_url":"https://api.github.com/users/hwigmore/repos","events_url":"https://api.github.com/users/hwigmore/events{/privacy}","received_events_url":"https://api.github.com/users/hwigmore/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/floored/blocks/pulls/19/commits","review_comments_url":"https://api.github.com/repos/floored/blocks/pulls/19/comments","review_comment_url":"https://api.github.com/repos/floored/blocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/floored/blocks/issues/19/comments","statuses_url":"https://api.github.com/repos/floored/blocks/statuses/5f4e1baaf95c8828160e7174050e91ac7d0a2f7c","head":{"label":"floored:alignLabellessInputs","ref":"alignLabellessInputs","sha":"5f4e1baaf95c8828160e7174050e91ac7d0a2f7c","user":{"login":"floored","id":1977344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1977344?v=4","gravatar_id":"","url":"https://api.github.com/users/floored","html_url":"https://github.com/floored","followers_url":"https://api.github.com/users/floored/followers","following_url":"https://api.github.com/users/floored/following{/other_user}","gists_url":"https://api.github.com/users/floored/gists{/gist_id}","starred_url":"https://api.github.com/users/floored/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floored/subscriptions","organizations_url":"https://api.github.com/users/floored/orgs","repos_url":"https://api.github.com/users/floored/repos","events_url":"https://api.github.com/users/floored/events{/privacy}","received_events_url":"https://api.github.com/users/floored/received_events","type":"Organization","site_admin":false},"repo":{"id":129149450,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNDk0NTA=","name":"blocks","full_name":"floored/blocks","owner":{"login":"floored","id":1977344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1977344?v=4","gravatar_id":"","url":"https://api.github.com/users/floored","html_url":"https://github.com/floored","followers_url":"https://api.github.com/users/floored/followers","following_url":"https://api.github.com/users/floored/following{/other_user}","gists_url":"https://api.github.com/users/floored/gists{/gist_id}","starred_url":"https://api.github.com/users/floored/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floored/subscriptions","organizations_url":"https://api.github.com/users/floored/orgs","repos_url":"https://api.github.com/users/floored/repos","events_url":"https://api.github.com/users/floored/events{/privacy}","received_events_url":"https://api.github.com/users/floored/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/floored/blocks","description":null,"fork":false,"url":"https://api.github.com/repos/floored/blocks","forks_url":"https://api.github.com/repos/floored/blocks/forks","keys_url":"https://api.github.com/repos/floored/blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floored/blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floored/blocks/teams","hooks_url":"https://api.github.com/repos/floored/blocks/hooks","issue_events_url":"https://api.github.com/repos/floored/blocks/issues/events{/number}","events_url":"https://api.github.com/repos/floored/blocks/events","assignees_url":"https://api.github.com/repos/floored/blocks/assignees{/user}","branches_url":"https://api.github.com/repos/floored/blocks/branches{/branch}","tags_url":"https://api.github.com/repos/floored/blocks/tags","blobs_url":"https://api.github.com/repos/floored/blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floored/blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floored/blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/floored/blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floored/blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/floored/blocks/languages","stargazers_url":"https://api.github.com/repos/floored/blocks/stargazers","contributors_url":"https://api.github.com/repos/floored/blocks/contributors","subscribers_url":"https://api.github.com/repos/floored/blocks/subscribers","subscription_url":"https://api.github.com/repos/floored/blocks/subscription","commits_url":"https://api.github.com/repos/floored/blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/floored/blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/floored/blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/floored/blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/floored/blocks/contents/{+path}","compare_url":"https://api.github.com/repos/floored/blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floored/blocks/merges","archive_url":"https://api.github.com/repos/floored/blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floored/blocks/downloads","issues_url":"https://api.github.com/repos/floored/blocks/issues{/number}","pulls_url":"https://api.github.com/repos/floored/blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/floored/blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/floored/blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floored/blocks/labels{/name}","releases_url":"https://api.github.com/repos/floored/blocks/releases{/id}","deployments_url":"https://api.github.com/repos/floored/blocks/deployments","created_at":"2018-04-11T20:20:46Z","updated_at":"2018-07-18T15:45:22Z","pushed_at":"2018-07-18T15:45:25Z","git_url":"git://github.com/floored/blocks.git","ssh_url":"git@github.com:floored/blocks.git","clone_url":"https://github.com/floored/blocks.git","svn_url":"https://github.com/floored/blocks","homepage":null,"size":4674,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"floored:master","ref":"master","sha":"c4b400d061bb8d6505bb55684efee0b60171ded1","user":{"login":"floored","id":1977344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1977344?v=4","gravatar_id":"","url":"https://api.github.com/users/floored","html_url":"https://github.com/floored","followers_url":"https://api.github.com/users/floored/followers","following_url":"https://api.github.com/users/floored/following{/other_user}","gists_url":"https://api.github.com/users/floored/gists{/gist_id}","starred_url":"https://api.github.com/users/floored/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floored/subscriptions","organizations_url":"https://api.github.com/users/floored/orgs","repos_url":"https://api.github.com/users/floored/repos","events_url":"https://api.github.com/users/floored/events{/privacy}","received_events_url":"https://api.github.com/users/floored/received_events","type":"Organization","site_admin":false},"repo":{"id":129149450,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNDk0NTA=","name":"blocks","full_name":"floored/blocks","owner":{"login":"floored","id":1977344,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NzczNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1977344?v=4","gravatar_id":"","url":"https://api.github.com/users/floored","html_url":"https://github.com/floored","followers_url":"https://api.github.com/users/floored/followers","following_url":"https://api.github.com/users/floored/following{/other_user}","gists_url":"https://api.github.com/users/floored/gists{/gist_id}","starred_url":"https://api.github.com/users/floored/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floored/subscriptions","organizations_url":"https://api.github.com/users/floored/orgs","repos_url":"https://api.github.com/users/floored/repos","events_url":"https://api.github.com/users/floored/events{/privacy}","received_events_url":"https://api.github.com/users/floored/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/floored/blocks","description":null,"fork":false,"url":"https://api.github.com/repos/floored/blocks","forks_url":"https://api.github.com/repos/floored/blocks/forks","keys_url":"https://api.github.com/repos/floored/blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floored/blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floored/blocks/teams","hooks_url":"https://api.github.com/repos/floored/blocks/hooks","issue_events_url":"https://api.github.com/repos/floored/blocks/issues/events{/number}","events_url":"https://api.github.com/repos/floored/blocks/events","assignees_url":"https://api.github.com/repos/floored/blocks/assignees{/user}","branches_url":"https://api.github.com/repos/floored/blocks/branches{/branch}","tags_url":"https://api.github.com/repos/floored/blocks/tags","blobs_url":"https://api.github.com/repos/floored/blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floored/blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floored/blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/floored/blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floored/blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/floored/blocks/languages","stargazers_url":"https://api.github.com/repos/floored/blocks/stargazers","contributors_url":"https://api.github.com/repos/floored/blocks/contributors","subscribers_url":"https://api.github.com/repos/floored/blocks/subscribers","subscription_url":"https://api.github.com/repos/floored/blocks/subscription","commits_url":"https://api.github.com/repos/floored/blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/floored/blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/floored/blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/floored/blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/floored/blocks/contents/{+path}","compare_url":"https://api.github.com/repos/floored/blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floored/blocks/merges","archive_url":"https://api.github.com/repos/floored/blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floored/blocks/downloads","issues_url":"https://api.github.com/repos/floored/blocks/issues{/number}","pulls_url":"https://api.github.com/repos/floored/blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/floored/blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/floored/blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floored/blocks/labels{/name}","releases_url":"https://api.github.com/repos/floored/blocks/releases{/id}","deployments_url":"https://api.github.com/repos/floored/blocks/deployments","created_at":"2018-04-11T20:20:46Z","updated_at":"2018-07-18T15:45:22Z","pushed_at":"2018-07-18T15:45:25Z","git_url":"git://github.com/floored/blocks.git","ssh_url":"git@github.com:floored/blocks.git","clone_url":"https://github.com/floored/blocks.git","svn_url":"https://github.com/floored/blocks","homepage":null,"size":4674,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/floored/blocks/pulls/19"},"html":{"href":"https://github.com/floored/blocks/pull/19"},"issue":{"href":"https://api.github.com/repos/floored/blocks/issues/19"},"comments":{"href":"https://api.github.com/repos/floored/blocks/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/floored/blocks/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/floored/blocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/floored/blocks/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/floored/blocks/statuses/5f4e1baaf95c8828160e7174050e91ac7d0a2f7c"}},"author_association":"NONE"}}
{"actor":{"display_login":"MagdalenaHenke"}}