{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67","id":228929526,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTI5NTI2","html_url":"https://github.com/tzaeschke/ode4j/pull/67","diff_url":"https://github.com/tzaeschke/ode4j/pull/67.diff","patch_url":"https://github.com/tzaeschke/ode4j/pull/67.patch","issue_url":"https://api.github.com/repos/tzaeschke/ode4j/issues/67","number":67,"state":"closed","locked":false,"title":"Fix ray vs convex collisions","user":{"login":"ppiastucki","id":9357697,"node_id":"MDQ6VXNlcjkzNTc2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/9357697?v=4","gravatar_id":"","url":"https://api.github.com/users/ppiastucki","html_url":"https://github.com/ppiastucki","followers_url":"https://api.github.com/users/ppiastucki/followers","following_url":"https://api.github.com/users/ppiastucki/following{/other_user}","gists_url":"https://api.github.com/users/ppiastucki/gists{/gist_id}","starred_url":"https://api.github.com/users/ppiastucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppiastucki/subscriptions","organizations_url":"https://api.github.com/users/ppiastucki/orgs","repos_url":"https://api.github.com/users/ppiastucki/repos","events_url":"https://api.github.com/users/ppiastucki/events{/privacy}","received_events_url":"https://api.github.com/users/ppiastucki/received_events","type":"User","site_admin":false},"body":"The following PR fixes a few issues in ray vs convex collider.\r\n\r\nIt includes a port of an upstream fix for ray vs convex collider not considering\r\nthe position of the convex geometry from upstream, for more details please see https://bitbucket.org/odedevs/ode/commits/abe81189b2038427b116458c961b491ecc836e2f?at=default\r\nA few methods have been changed in OdeMath to make them consistent with the upstream implementation and make the port work properly. More methods in OdeMath should be probably updated in the future too.\r\n\r\nAdditionally the patch also fixes two ode4j-specific issues:\r\nhttps://github.com/tzaeschke/ode4j/compare/master...ppiastucki:ray_convex_collision?expand=1#diff-d369b0cd579e4afb081d17439811acbaR2010\r\nhttps://github.com/tzaeschke/ode4j/compare/master...ppiastucki:ray_convex_collision?expand=1#diff-d369b0cd579e4afb081d17439811acbaL2034\r\n\r\n","created_at":"2018-11-07T06:28:18Z","updated_at":"2018-11-10T19:36:58Z","closed_at":"2018-11-10T19:36:58Z","merged_at":"2018-11-10T19:36:58Z","merge_commit_sha":"361e570a3d187e62a2704841a637c4aeb9650239","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67/commits","review_comments_url":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67/comments","review_comment_url":"https://api.github.com/repos/tzaeschke/ode4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tzaeschke/ode4j/issues/67/comments","statuses_url":"https://api.github.com/repos/tzaeschke/ode4j/statuses/0f8d40477eda9908089a35bdaed62889fbe0a903","head":{"label":"ppiastucki:ray_convex_collision","ref":"ray_convex_collision","sha":"0f8d40477eda9908089a35bdaed62889fbe0a903","user":{"login":"ppiastucki","id":9357697,"node_id":"MDQ6VXNlcjkzNTc2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/9357697?v=4","gravatar_id":"","url":"https://api.github.com/users/ppiastucki","html_url":"https://github.com/ppiastucki","followers_url":"https://api.github.com/users/ppiastucki/followers","following_url":"https://api.github.com/users/ppiastucki/following{/other_user}","gists_url":"https://api.github.com/users/ppiastucki/gists{/gist_id}","starred_url":"https://api.github.com/users/ppiastucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppiastucki/subscriptions","organizations_url":"https://api.github.com/users/ppiastucki/orgs","repos_url":"https://api.github.com/users/ppiastucki/repos","events_url":"https://api.github.com/users/ppiastucki/events{/privacy}","received_events_url":"https://api.github.com/users/ppiastucki/received_events","type":"User","site_admin":false},"repo":{"id":105997037,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5OTcwMzc=","name":"ode4j","full_name":"ppiastucki/ode4j","private":false,"owner":{"login":"ppiastucki","id":9357697,"node_id":"MDQ6VXNlcjkzNTc2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/9357697?v=4","gravatar_id":"","url":"https://api.github.com/users/ppiastucki","html_url":"https://github.com/ppiastucki","followers_url":"https://api.github.com/users/ppiastucki/followers","following_url":"https://api.github.com/users/ppiastucki/following{/other_user}","gists_url":"https://api.github.com/users/ppiastucki/gists{/gist_id}","starred_url":"https://api.github.com/users/ppiastucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppiastucki/subscriptions","organizations_url":"https://api.github.com/users/ppiastucki/orgs","repos_url":"https://api.github.com/users/ppiastucki/repos","events_url":"https://api.github.com/users/ppiastucki/events{/privacy}","received_events_url":"https://api.github.com/users/ppiastucki/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ppiastucki/ode4j","description":"Java 3D Physics Engine & Library","fork":true,"url":"https://api.github.com/repos/ppiastucki/ode4j","forks_url":"https://api.github.com/repos/ppiastucki/ode4j/forks","keys_url":"https://api.github.com/repos/ppiastucki/ode4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppiastucki/ode4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppiastucki/ode4j/teams","hooks_url":"https://api.github.com/repos/ppiastucki/ode4j/hooks","issue_events_url":"https://api.github.com/repos/ppiastucki/ode4j/issues/events{/number}","events_url":"https://api.github.com/repos/ppiastucki/ode4j/events","assignees_url":"https://api.github.com/repos/ppiastucki/ode4j/assignees{/user}","branches_url":"https://api.github.com/repos/ppiastucki/ode4j/branches{/branch}","tags_url":"https://api.github.com/repos/ppiastucki/ode4j/tags","blobs_url":"https://api.github.com/repos/ppiastucki/ode4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppiastucki/ode4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppiastucki/ode4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppiastucki/ode4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppiastucki/ode4j/statuses/{sha}","languages_url":"https://api.github.com/repos/ppiastucki/ode4j/languages","stargazers_url":"https://api.github.com/repos/ppiastucki/ode4j/stargazers","contributors_url":"https://api.github.com/repos/ppiastucki/ode4j/contributors","subscribers_url":"https://api.github.com/repos/ppiastucki/ode4j/subscribers","subscription_url":"https://api.github.com/repos/ppiastucki/ode4j/subscription","commits_url":"https://api.github.com/repos/ppiastucki/ode4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppiastucki/ode4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppiastucki/ode4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppiastucki/ode4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppiastucki/ode4j/contents/{+path}","compare_url":"https://api.github.com/repos/ppiastucki/ode4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppiastucki/ode4j/merges","archive_url":"https://api.github.com/repos/ppiastucki/ode4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppiastucki/ode4j/downloads","issues_url":"https://api.github.com/repos/ppiastucki/ode4j/issues{/number}","pulls_url":"https://api.github.com/repos/ppiastucki/ode4j/pulls{/number}","milestones_url":"https://api.github.com/repos/ppiastucki/ode4j/milestones{/number}","notifications_url":"https://api.github.com/repos/ppiastucki/ode4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppiastucki/ode4j/labels{/name}","releases_url":"https://api.github.com/repos/ppiastucki/ode4j/releases{/id}","deployments_url":"https://api.github.com/repos/ppiastucki/ode4j/deployments","created_at":"2017-10-06T11:26:51Z","updated_at":"2018-11-06T14:42:55Z","pushed_at":"2018-11-10T19:00:12Z","git_url":"git://github.com/ppiastucki/ode4j.git","ssh_url":"git@github.com:ppiastucki/ode4j.git","clone_url":"https://github.com/ppiastucki/ode4j.git","svn_url":"https://github.com/ppiastucki/ode4j","homepage":null,"size":12838,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tzaeschke:master","ref":"master","sha":"7bf670d7f0c79aa91efbda6e960e1ee709b28f09","user":{"login":"tzaeschke","id":1595847,"node_id":"MDQ6VXNlcjE1OTU4NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1595847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzaeschke","html_url":"https://github.com/tzaeschke","followers_url":"https://api.github.com/users/tzaeschke/followers","following_url":"https://api.github.com/users/tzaeschke/following{/other_user}","gists_url":"https://api.github.com/users/tzaeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/tzaeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzaeschke/subscriptions","organizations_url":"https://api.github.com/users/tzaeschke/orgs","repos_url":"https://api.github.com/users/tzaeschke/repos","events_url":"https://api.github.com/users/tzaeschke/events{/privacy}","received_events_url":"https://api.github.com/users/tzaeschke/received_events","type":"User","site_admin":false},"repo":{"id":11073707,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA3MzcwNw==","name":"ode4j","full_name":"tzaeschke/ode4j","private":false,"owner":{"login":"tzaeschke","id":1595847,"node_id":"MDQ6VXNlcjE1OTU4NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1595847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzaeschke","html_url":"https://github.com/tzaeschke","followers_url":"https://api.github.com/users/tzaeschke/followers","following_url":"https://api.github.com/users/tzaeschke/following{/other_user}","gists_url":"https://api.github.com/users/tzaeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/tzaeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzaeschke/subscriptions","organizations_url":"https://api.github.com/users/tzaeschke/orgs","repos_url":"https://api.github.com/users/tzaeschke/repos","events_url":"https://api.github.com/users/tzaeschke/events{/privacy}","received_events_url":"https://api.github.com/users/tzaeschke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tzaeschke/ode4j","description":"Java 3D Physics Engine & Library","fork":false,"url":"https://api.github.com/repos/tzaeschke/ode4j","forks_url":"https://api.github.com/repos/tzaeschke/ode4j/forks","keys_url":"https://api.github.com/repos/tzaeschke/ode4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzaeschke/ode4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzaeschke/ode4j/teams","hooks_url":"https://api.github.com/repos/tzaeschke/ode4j/hooks","issue_events_url":"https://api.github.com/repos/tzaeschke/ode4j/issues/events{/number}","events_url":"https://api.github.com/repos/tzaeschke/ode4j/events","assignees_url":"https://api.github.com/repos/tzaeschke/ode4j/assignees{/user}","branches_url":"https://api.github.com/repos/tzaeschke/ode4j/branches{/branch}","tags_url":"https://api.github.com/repos/tzaeschke/ode4j/tags","blobs_url":"https://api.github.com/repos/tzaeschke/ode4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzaeschke/ode4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzaeschke/ode4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzaeschke/ode4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzaeschke/ode4j/statuses/{sha}","languages_url":"https://api.github.com/repos/tzaeschke/ode4j/languages","stargazers_url":"https://api.github.com/repos/tzaeschke/ode4j/stargazers","contributors_url":"https://api.github.com/repos/tzaeschke/ode4j/contributors","subscribers_url":"https://api.github.com/repos/tzaeschke/ode4j/subscribers","subscription_url":"https://api.github.com/repos/tzaeschke/ode4j/subscription","commits_url":"https://api.github.com/repos/tzaeschke/ode4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzaeschke/ode4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzaeschke/ode4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzaeschke/ode4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzaeschke/ode4j/contents/{+path}","compare_url":"https://api.github.com/repos/tzaeschke/ode4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzaeschke/ode4j/merges","archive_url":"https://api.github.com/repos/tzaeschke/ode4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzaeschke/ode4j/downloads","issues_url":"https://api.github.com/repos/tzaeschke/ode4j/issues{/number}","pulls_url":"https://api.github.com/repos/tzaeschke/ode4j/pulls{/number}","milestones_url":"https://api.github.com/repos/tzaeschke/ode4j/milestones{/number}","notifications_url":"https://api.github.com/repos/tzaeschke/ode4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzaeschke/ode4j/labels{/name}","releases_url":"https://api.github.com/repos/tzaeschke/ode4j/releases{/id}","deployments_url":"https://api.github.com/repos/tzaeschke/ode4j/deployments","created_at":"2013-06-30T16:39:45Z","updated_at":"2018-10-26T09:15:04Z","pushed_at":"2018-11-10T19:36:58Z","git_url":"git://github.com/tzaeschke/ode4j.git","ssh_url":"git@github.com:tzaeschke/ode4j.git","clone_url":"https://github.com/tzaeschke/ode4j.git","svn_url":"https://github.com/tzaeschke/ode4j","homepage":null,"size":12773,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":20,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67"},"html":{"href":"https://github.com/tzaeschke/ode4j/pull/67"},"issue":{"href":"https://api.github.com/repos/tzaeschke/ode4j/issues/67"},"comments":{"href":"https://api.github.com/repos/tzaeschke/ode4j/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/tzaeschke/ode4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tzaeschke/ode4j/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/tzaeschke/ode4j/statuses/0f8d40477eda9908089a35bdaed62889fbe0a903"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tzaeschke","id":1595847,"node_id":"MDQ6VXNlcjE1OTU4NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1595847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzaeschke","html_url":"https://github.com/tzaeschke","followers_url":"https://api.github.com/users/tzaeschke/followers","following_url":"https://api.github.com/users/tzaeschke/following{/other_user}","gists_url":"https://api.github.com/users/tzaeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/tzaeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzaeschke/subscriptions","organizations_url":"https://api.github.com/users/tzaeschke/orgs","repos_url":"https://api.github.com/users/tzaeschke/repos","events_url":"https://api.github.com/users/tzaeschke/events{/privacy}","received_events_url":"https://api.github.com/users/tzaeschke/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":144,"deletions":73,"changed_files":3}}
{"actor":{"display_login":"tzaeschke"}}