{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/235104014","pull_request_review_id":176893669,"id":235104014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTEwNDAxNA==","diff_hunk":"@@ -25,25 +25,23 @@\n \n import java.util.ArrayList;\n import java.util.Collections;\n+import java.util.LinkedHashSet;\n import java.util.List;\n import java.util.Optional;\n+import java.util.Set;\n \n /**\n  * @author Marko A. Rodriguez (http://markorodriguez.com)\n  */\n public class DefaultTraversalStrategies implements TraversalStrategies {\n \n-    protected List<TraversalStrategy<?>> traversalStrategies = new ArrayList<>();\n+    protected Set<TraversalStrategy<?>> traversalStrategies = new LinkedHashSet<>();\n \n     @Override\n     @SuppressWarnings({\"unchecked\", \"varargs\"})\n     public TraversalStrategies addStrategies(final TraversalStrategy<?>... strategies) {\n-        final List<TraversalStrategy<?>> concurrent = new ArrayList<>(this.traversalStrategies);\n         for (final TraversalStrategy<?> addStrategy : strategies) {\n-            for (final TraversalStrategy<?> currentStrategy : concurrent) {\n-                if (addStrategy.getClass().equals(currentStrategy.getClass()))\n-                    this.traversalStrategies.remove(currentStrategy);\n-            }\n+            this.traversalStrategies.remove(addStrategy);","path":"gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalStrategies.java","position":26,"original_position":26,"commit_id":"a16f16e5668b6424fbb8a4c46ca313ddf7bc5d6a","original_commit_id":"a16f16e5668b6424fbb8a4c46ca313ddf7bc5d6a","user":{"login":"dkuppitz","id":572377,"node_id":"MDQ6VXNlcjU3MjM3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/572377?v=4","gravatar_id":"","url":"https://api.github.com/users/dkuppitz","html_url":"https://github.com/dkuppitz","followers_url":"https://api.github.com/users/dkuppitz/followers","following_url":"https://api.github.com/users/dkuppitz/following{/other_user}","gists_url":"https://api.github.com/users/dkuppitz/gists{/gist_id}","starred_url":"https://api.github.com/users/dkuppitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkuppitz/subscriptions","organizations_url":"https://api.github.com/users/dkuppitz/orgs","repos_url":"https://api.github.com/users/dkuppitz/repos","events_url":"https://api.github.com/users/dkuppitz/events{/privacy}","received_events_url":"https://api.github.com/users/dkuppitz/received_events","type":"User","site_admin":false},"body":"Yea, I just tried to get rid of the loop, but that doesn't work because at some point we rely on a replacement behavior.","created_at":"2018-11-20T17:43:37Z","updated_at":"2018-11-20T17:43:37Z","html_url":"https://github.com/apache/tinkerpop/pull/999#discussion_r235104014","pull_request_url":"https://api.github.com/repos/apache/tinkerpop/pulls/999","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/235104014"},"html":{"href":"https://github.com/apache/tinkerpop/pull/999#discussion_r235104014"},"pull_request":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/999"}},"in_reply_to_id":235041777},"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/999","id":231943874,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTQzODc0","html_url":"https://github.com/apache/tinkerpop/pull/999","diff_url":"https://github.com/apache/tinkerpop/pull/999.diff","patch_url":"https://github.com/apache/tinkerpop/pull/999.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/999","number":999,"state":"open","locked":false,"title":"some improvements","user":{"login":"nastra","id":271029,"node_id":"MDQ6VXNlcjI3MTAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/271029?v=4","gravatar_id":"","url":"https://api.github.com/users/nastra","html_url":"https://github.com/nastra","followers_url":"https://api.github.com/users/nastra/followers","following_url":"https://api.github.com/users/nastra/following{/other_user}","gists_url":"https://api.github.com/users/nastra/gists{/gist_id}","starred_url":"https://api.github.com/users/nastra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastra/subscriptions","organizations_url":"https://api.github.com/users/nastra/orgs","repos_url":"https://api.github.com/users/nastra/repos","events_url":"https://api.github.com/users/nastra/events{/privacy}","received_events_url":"https://api.github.com/users/nastra/received_events","type":"User","site_admin":false},"body":"tested locally with `mvn clean install`","created_at":"2018-11-19T11:44:17Z","updated_at":"2018-11-20T17:43:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"358f0b379ee55b8eb9fef309586a13d069044c68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/999/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/999/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/999/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/a16f16e5668b6424fbb8a4c46ca313ddf7bc5d6a","head":{"label":"nastra:tp33-some-improvements","ref":"tp33-some-improvements","sha":"a16f16e5668b6424fbb8a4c46ca313ddf7bc5d6a","user":{"login":"nastra","id":271029,"node_id":"MDQ6VXNlcjI3MTAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/271029?v=4","gravatar_id":"","url":"https://api.github.com/users/nastra","html_url":"https://github.com/nastra","followers_url":"https://api.github.com/users/nastra/followers","following_url":"https://api.github.com/users/nastra/following{/other_user}","gists_url":"https://api.github.com/users/nastra/gists{/gist_id}","starred_url":"https://api.github.com/users/nastra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastra/subscriptions","organizations_url":"https://api.github.com/users/nastra/orgs","repos_url":"https://api.github.com/users/nastra/repos","events_url":"https://api.github.com/users/nastra/events{/privacy}","received_events_url":"https://api.github.com/users/nastra/received_events","type":"User","site_admin":false},"repo":{"id":158186654,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxODY2NTQ=","name":"tinkerpop","full_name":"nastra/tinkerpop","private":false,"owner":{"login":"nastra","id":271029,"node_id":"MDQ6VXNlcjI3MTAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/271029?v=4","gravatar_id":"","url":"https://api.github.com/users/nastra","html_url":"https://github.com/nastra","followers_url":"https://api.github.com/users/nastra/followers","following_url":"https://api.github.com/users/nastra/following{/other_user}","gists_url":"https://api.github.com/users/nastra/gists{/gist_id}","starred_url":"https://api.github.com/users/nastra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastra/subscriptions","organizations_url":"https://api.github.com/users/nastra/orgs","repos_url":"https://api.github.com/users/nastra/repos","events_url":"https://api.github.com/users/nastra/events{/privacy}","received_events_url":"https://api.github.com/users/nastra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nastra/tinkerpop","description":"Mirror of Apache TinkerPop","fork":true,"url":"https://api.github.com/repos/nastra/tinkerpop","forks_url":"https://api.github.com/repos/nastra/tinkerpop/forks","keys_url":"https://api.github.com/repos/nastra/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nastra/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nastra/tinkerpop/teams","hooks_url":"https://api.github.com/repos/nastra/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/nastra/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/nastra/tinkerpop/events","assignees_url":"https://api.github.com/repos/nastra/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/nastra/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/nastra/tinkerpop/tags","blobs_url":"https://api.github.com/repos/nastra/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nastra/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nastra/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/nastra/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nastra/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/nastra/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/nastra/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/nastra/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/nastra/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/nastra/tinkerpop/subscription","commits_url":"https://api.github.com/repos/nastra/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/nastra/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/nastra/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/nastra/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/nastra/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/nastra/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nastra/tinkerpop/merges","archive_url":"https://api.github.com/repos/nastra/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nastra/tinkerpop/downloads","issues_url":"https://api.github.com/repos/nastra/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/nastra/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/nastra/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/nastra/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nastra/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/nastra/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/nastra/tinkerpop/deployments","created_at":"2018-11-19T08:26:27Z","updated_at":"2018-11-19T08:26:39Z","pushed_at":"2018-11-19T11:43:45Z","git_url":"git://github.com/nastra/tinkerpop.git","ssh_url":"git@github.com:nastra/tinkerpop.git","clone_url":"https://github.com/nastra/tinkerpop.git","svn_url":"https://github.com/nastra/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":150629,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:tp33","ref":"tp33","sha":"2eda64164268d18cf80b243956e0e1a4642f15f4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"node_id":"MDEwOlJlcG9zaXRvcnkzMDQ0OTQ4MQ==","name":"tinkerpop","full_name":"apache/tinkerpop","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2018-11-20T17:24:58Z","pushed_at":"2018-11-20T17:25:01Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":150631,"stargazers_count":702,"watchers_count":702,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":386,"open_issues":9,"watchers":702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/999"},"html":{"href":"https://github.com/apache/tinkerpop/pull/999"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/999"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/999/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/999/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/999/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/a16f16e5668b6424fbb8a4c46ca313ddf7bc5d6a"}},"author_association":"NONE"}}
{"actor":{"display_login":"dkuppitz"}}