{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/187154237","pull_request_review_id":118877720,"id":187154237,"diff_hunk":"@@ -0,0 +1,31 @@\n+# Copyright 2014 CoreOS, Inc.\n+# Distributed under the terms of the GNU General Public License v2\n+\n+# @ECLASS: coreos-sec-policy.eclass\n+# @BLURB: Container Linux sec-policy ebuild routines.\n+\n+\n+# When updating the sec-policy ebuilds BASEPOL needs to be updated to match\n+# the ${PVR} version string of the upstream selinux policy packages.\n+# BASEPOL must corespond to a published gentoo policy patchbundle.\n+export BASEPOL=\"2.20170805-r3\"\n+\n+# Setting these variables allows the sec-policy makefiles to work with\n+# Container Linux.\n+export BINDIR=\"/usr/bin\"\n+export SHAREDIR=\"${EROOT:-/}usr/share/selinux\"\n+\n+# For build debugging.\n+export QUIET=\"n\"\n+\n+coreos-sec-policy_pkg_postinst() {\n+\tdebug-print-function ${FUNCNAME} \"$@\"\n+\n+\t# For board builds Container Linux installs policy modules to the OS\n+\t# image in the SDK build_image script.\n+\t[[ \"${CBUILD}\" == \"${CHOST}\" ]] || return\n+\n+\tselinux-policy-2_pkg_postinst","path":"eclass/coreos-sec-policy.eclass","position":28,"original_position":28,"commit_id":"8535b94895b0d1bd796a9a2dab879ce51f9b8649","original_commit_id":"72cbc2ffbf8cab44e07b4d7439687577eb71bd12","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars2.githubusercontent.com/u/10858804?v=4","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"It seems the above is no longer true.  It may have been a condition of older packages.  Things seem to work OK with a simple `inherit selinux-policy-2` in coreos-sec-policy.eclass.","created_at":"2018-05-09T19:44:07Z","updated_at":"2018-05-09T19:44:08Z","html_url":"https://github.com/coreos/coreos-overlay/pull/3155#discussion_r187154237","pull_request_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/187154237"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/3155#discussion_r187154237"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155"}},"in_reply_to_id":186172041},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155","id":178461767,"html_url":"https://github.com/coreos/coreos-overlay/pull/3155","diff_url":"https://github.com/coreos/coreos-overlay/pull/3155.diff","patch_url":"https://github.com/coreos/coreos-overlay/pull/3155.patch","issue_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/3155","number":3155,"state":"open","locked":false,"title":"Update selinux support","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars2.githubusercontent.com/u/10858804?v=4","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"Depends on:\r\n    https://github.com/coreos/coreos-overlay/pull/3100 (Update packages needed by SELinux) \r\n    https://github.com/coreos/coreos/bootengine#143 (initrd-setup-root: Add SELinux labels to files)\r\n    https://github.com/coreos/portage-stable/pull/654 (Update selinux support)","created_at":"2018-03-29T23:00:48Z","updated_at":"2018-05-09T19:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19d112d6703d2fe04cd51683ddab6f1efccba30e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/3155/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/8535b94895b0d1bd796a9a2dab879ce51f9b8649","head":{"label":"glevand:for-merge-selinux","ref":"for-merge-selinux","sha":"8535b94895b0d1bd796a9a2dab879ce51f9b8649","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars2.githubusercontent.com/u/10858804?v=4","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"repo":{"id":32751511,"name":"coreos--coreos-overlay","full_name":"glevand/coreos--coreos-overlay","owner":{"login":"glevand","id":10858804,"avatar_url":"https://avatars2.githubusercontent.com/u/10858804?v=4","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glevand/coreos--coreos-overlay","description":"CoreOS arm64 port","fork":true,"url":"https://api.github.com/repos/glevand/coreos--coreos-overlay","forks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/forks","keys_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/teams","hooks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/events","assignees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/tags","blobs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscription","commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/merges","archive_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/downloads","issues_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/deployments","created_at":"2015-03-23T18:39:29Z","updated_at":"2018-05-08T00:10:33Z","pushed_at":"2018-05-08T00:21:58Z","git_url":"git://github.com/glevand/coreos--coreos-overlay.git","ssh_url":"git@github.com:glevand/coreos--coreos-overlay.git","clone_url":"https://github.com/glevand/coreos--coreos-overlay.git","svn_url":"https://github.com/glevand/coreos--coreos-overlay","homepage":"","size":13847,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"ff55f7d9b4792c5a6323cc90bb75891a6c540653","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488820,"name":"coreos-overlay","full_name":"coreos/coreos-overlay","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-overlay","description":"Custom ebuilds for Container Linux","fork":false,"url":"https://api.github.com/repos/coreos/coreos-overlay","forks_url":"https://api.github.com/repos/coreos/coreos-overlay/forks","keys_url":"https://api.github.com/repos/coreos/coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-overlay/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-overlay/events","assignees_url":"https://api.github.com/repos/coreos/coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-overlay/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-overlay/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-overlay/merges","archive_url":"https://api.github.com/repos/coreos/coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-overlay/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-overlay/deployments","created_at":"2013-02-28T21:43:07Z","updated_at":"2018-05-08T23:18:12Z","pushed_at":"2018-05-08T23:18:08Z","git_url":"git://github.com/coreos/coreos-overlay.git","ssh_url":"git@github.com:coreos/coreos-overlay.git","clone_url":"https://github.com/coreos/coreos-overlay.git","svn_url":"https://github.com/coreos/coreos-overlay","homepage":"http://coreos.com/docs/sdk/","size":14632,"stargazers_count":231,"watchers_count":231,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":225,"open_issues":47,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/3155"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/3155"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/3155/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/3155/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-overlay/statuses/8535b94895b0d1bd796a9a2dab879ce51f9b8649"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"glevand"}}