{"action":"closed","issue":{"url":"https://api.github.com/repos/r-murphy/babel-plugin-transform-modules-ui5/issues/3","repository_url":"https://api.github.com/repos/r-murphy/babel-plugin-transform-modules-ui5","labels_url":"https://api.github.com/repos/r-murphy/babel-plugin-transform-modules-ui5/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/r-murphy/babel-plugin-transform-modules-ui5/issues/3/comments","events_url":"https://api.github.com/repos/r-murphy/babel-plugin-transform-modules-ui5/issues/3/events","html_url":"https://github.com/r-murphy/babel-plugin-transform-modules-ui5/issues/3","id":291243050,"number":3,"title":"Class method conversion can cause conflicts and infinite callstack","user":{"login":"r-murphy","id":658922,"avatar_url":"https://avatars2.githubusercontent.com/u/658922?v=4","gravatar_id":"","url":"https://api.github.com/users/r-murphy","html_url":"https://github.com/r-murphy","followers_url":"https://api.github.com/users/r-murphy/followers","following_url":"https://api.github.com/users/r-murphy/following{/other_user}","gists_url":"https://api.github.com/users/r-murphy/gists{/gist_id}","starred_url":"https://api.github.com/users/r-murphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-murphy/subscriptions","organizations_url":"https://api.github.com/users/r-murphy/orgs","repos_url":"https://api.github.com/users/r-murphy/repos","events_url":"https://api.github.com/users/r-murphy/events{/privacy}","received_events_url":"https://api.github.com/users/r-murphy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-24T15:09:58Z","updated_at":"2018-02-06T16:33:43Z","closed_at":"2018-02-06T16:33:43Z","author_association":"OWNER","body":"The following class converts in a way that causes the method to call itself rather than the external function.\r\n\r\n```js\r\nclass MyClass extends UI5Class {\r\n  doSomething() {\r\n    doSomething(); // call a standalone function with the same name\r\n  }\r\n}\r\n\r\n// Called by MyClass method\r\nfunction doSomething() {\r\n // something\r\n}\r\n```\r\n\r\nConverts to:\r\n\r\n```js\r\nconst MyClass = UI5Class.extend(\"MyClass\", {\r\n   doSomething: function doSomething() {\r\n     doSomething(); // calls the named function assigned to the object prop, rather than the external function\r\n  }\r\n});\r\n\r\n// Never called!\r\nfunction doSomething() {\r\n // something\r\n}\r\n```\r\n\r\nThe functions assigned to the props don't actually need named, but they can be useful for stack traces. So I'll use the babel functionality to generate a unique id from a given id.\r\n"}}
{"actor":{"display_login":"r-murphy"}}