{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/6864","repository_url":"https://api.github.com/repos/concrete5/concrete5","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/6864/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/6864/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/6864/events","html_url":"https://github.com/concrete5/concrete5/pull/6864","id":339420565,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDc3NTI4","number":6864,"title":"Let CookieJar work with Request cookies and new cookies","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-09T12:01:37Z","updated_at":"2018-07-11T19:21:44Z","closed_at":"2018-07-11T19:21:44Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/6864","html_url":"https://github.com/concrete5/concrete5/pull/6864","diff_url":"https://github.com/concrete5/concrete5/pull/6864.diff","patch_url":"https://github.com/concrete5/concrete5/pull/6864.patch"},"body":"Currently `CookieJar` has the following limitations:\r\n\r\n- it's not possible to list all the cookies (the ones from request and the newly added ones): the `getCookies` method only returns the newly added cookies\r\n- if we call the the `clear` method to \"remove\" a cookie, `has` still returns true, and `get` still returns the original cookie\r\n- if we add a new cookie, `has` returns false and `get` returns `null`\r\n- if we override a request cookie with a new cookie, `get` still returns the value of the original request cookie\r\n- newly added cookies can't be removed with the `clear` method\r\n- we don't have tests\r\n\r\nLet's fix all these issues."},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/404282002","html_url":"https://github.com/concrete5/concrete5/pull/6864#issuecomment-404282002","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/6864","id":404282002,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDI4MjAwMg==","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T19:21:44Z","updated_at":"2018-07-11T19:21:44Z","author_association":"COLLABORATOR","body":"Switching to another class will imply that we still have to take care of the values set on the CookieJar (currently developers use it to delete and add cookies).\r\nFurthermore I do prefer a single class to deal with cookies. But I see your points, so I'm closing this PR (I just hope that someone else will fix the issues we currently have with cookies)."}}
{"actor":{"display_login":"mlocati"}}