{"action":"closed","number":24364,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/24364","id":183290346,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzMjkwMzQ2","html_url":"https://github.com/odoo/odoo/pull/24364","diff_url":"https://github.com/odoo/odoo/pull/24364.diff","patch_url":"https://github.com/odoo/odoo/pull/24364.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/24364","number":24364,"state":"closed","locked":false,"title":"[10.0][FIX] point_of_sale, round_globally problem with two equal tax in same order.","user":{"login":"mbaena","id":8525591,"node_id":"MDQ6VXNlcjg1MjU1OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525591?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaena","html_url":"https://github.com/mbaena","followers_url":"https://api.github.com/users/mbaena/followers","following_url":"https://api.github.com/users/mbaena/following{/other_user}","gists_url":"https://api.github.com/users/mbaena/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaena/subscriptions","organizations_url":"https://api.github.com/users/mbaena/orgs","repos_url":"https://api.github.com/users/mbaena/repos","events_url":"https://api.github.com/users/mbaena/events{/privacy}","received_events_url":"https://api.github.com/users/mbaena/received_events","type":"User","site_admin":false},"body":"Description of the issue/feature this PR addresses:\r\nPosOrder._create_account_move_line: round_globally problem with two equal tax in same order.\r\n\r\nCurrent behavior before PR:\r\nRounding=0.01; line1 10% tax= 0.014; line2 10% tax=0.011 =>  total rounded to 0.02. \r\n\r\nDesired behavior after PR is merged:\r\nBut 0.014+0.011 = 0.025 => total rounded to 0.03\r\nA simple solution is to add a new line with the difference.\r\n\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2018-04-22T19:41:26Z","updated_at":"2018-10-19T08:14:28Z","closed_at":"2018-10-19T08:14:28Z","merged_at":null,"merge_commit_sha":"f2846e28e7b0114ae28d757dc3d7868de993edc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":843911009,"node_id":"MDU6TGFiZWw4NDM5MTEwMDk=","url":"https://api.github.com/repos/odoo/odoo/labels/Point%20of%20Sale","name":"Point of Sale","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/24364/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/24364/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/24364/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/9907ee561eae0ec78924e94195f127351ce3d4bb","head":{"label":"mbaena:pos_rounding","ref":"pos_rounding","sha":"9907ee561eae0ec78924e94195f127351ce3d4bb","user":{"login":"mbaena","id":8525591,"node_id":"MDQ6VXNlcjg1MjU1OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525591?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaena","html_url":"https://github.com/mbaena","followers_url":"https://api.github.com/users/mbaena/followers","following_url":"https://api.github.com/users/mbaena/following{/other_user}","gists_url":"https://api.github.com/users/mbaena/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaena/subscriptions","organizations_url":"https://api.github.com/users/mbaena/orgs","repos_url":"https://api.github.com/users/mbaena/repos","events_url":"https://api.github.com/users/mbaena/events{/privacy}","received_events_url":"https://api.github.com/users/mbaena/received_events","type":"User","site_admin":false},"repo":{"id":23331096,"node_id":"MDEwOlJlcG9zaXRvcnkyMzMzMTA5Ng==","name":"odoo","full_name":"mbaena/odoo","private":false,"owner":{"login":"mbaena","id":8525591,"node_id":"MDQ6VXNlcjg1MjU1OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/8525591?v=4","gravatar_id":"","url":"https://api.github.com/users/mbaena","html_url":"https://github.com/mbaena","followers_url":"https://api.github.com/users/mbaena/followers","following_url":"https://api.github.com/users/mbaena/following{/other_user}","gists_url":"https://api.github.com/users/mbaena/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaena/subscriptions","organizations_url":"https://api.github.com/users/mbaena/orgs","repos_url":"https://api.github.com/users/mbaena/repos","events_url":"https://api.github.com/users/mbaena/events{/privacy}","received_events_url":"https://api.github.com/users/mbaena/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mbaena/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":true,"url":"https://api.github.com/repos/mbaena/odoo","forks_url":"https://api.github.com/repos/mbaena/odoo/forks","keys_url":"https://api.github.com/repos/mbaena/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbaena/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbaena/odoo/teams","hooks_url":"https://api.github.com/repos/mbaena/odoo/hooks","issue_events_url":"https://api.github.com/repos/mbaena/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/mbaena/odoo/events","assignees_url":"https://api.github.com/repos/mbaena/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/mbaena/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/mbaena/odoo/tags","blobs_url":"https://api.github.com/repos/mbaena/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbaena/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbaena/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbaena/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbaena/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/mbaena/odoo/languages","stargazers_url":"https://api.github.com/repos/mbaena/odoo/stargazers","contributors_url":"https://api.github.com/repos/mbaena/odoo/contributors","subscribers_url":"https://api.github.com/repos/mbaena/odoo/subscribers","subscription_url":"https://api.github.com/repos/mbaena/odoo/subscription","commits_url":"https://api.github.com/repos/mbaena/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbaena/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbaena/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbaena/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbaena/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/mbaena/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbaena/odoo/merges","archive_url":"https://api.github.com/repos/mbaena/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbaena/odoo/downloads","issues_url":"https://api.github.com/repos/mbaena/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/mbaena/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/mbaena/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/mbaena/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbaena/odoo/labels{/name}","releases_url":"https://api.github.com/repos/mbaena/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/mbaena/odoo/deployments","created_at":"2014-08-25T22:37:54Z","updated_at":"2014-08-25T19:37:52Z","pushed_at":"2018-04-25T15:21:03Z","git_url":"git://github.com/mbaena/odoo.git","ssh_url":"git@github.com:mbaena/odoo.git","clone_url":"https://github.com/mbaena/odoo.git","svn_url":"https://github.com/mbaena/odoo","homepage":"https://www.odoo.com","size":1759412,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"odoo:10.0","ref":"10.0","sha":"45e2ee0a9b4657e88489ba946aaed40c04b5270b","user":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0NTAwNA==","name":"odoo","full_name":"odoo/odoo","private":false,"owner":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-10-19T08:03:14Z","pushed_at":"2018-10-19T08:08:42Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2326393,"stargazers_count":11442,"watchers_count":11442,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8970,"mirror_url":null,"archived":false,"open_issues_count":1902,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8970,"open_issues":1902,"watchers":11442,"default_branch":"12.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24364"},"html":{"href":"https://github.com/odoo/odoo/pull/24364"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/24364"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/24364/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24364/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/24364/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/9907ee561eae0ec78924e94195f127351ce3d4bb"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":16,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"switch87"}}