{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/comments/199760336","pull_request_review_id":133939937,"id":199760336,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTc2MDMzNg==","diff_hunk":"@@ -23,10 +25,8 @@ spec:\n           labels:\n             app: {{ template \"cronjob.name\" . }}\n             release: {{ .Release.Name }}\n-            {{- if eq .Values.isOnDemand }}\n+            {{- if .Values.runOnDemandOnly }}","path":"charts/cronjob/templates/cronjob.yaml","position":null,"original_position":16,"commit_id":"623f8808cbd2f24f03b7fbb07ba9d44c15ea7ac4","original_commit_id":"3c5f47e4f2a1fa7dffade8c5304a3647faa92d66","user":{"login":"junajan","id":1090382,"node_id":"MDQ6VXNlcjEwOTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1090382?v=4","gravatar_id":"","url":"https://api.github.com/users/junajan","html_url":"https://github.com/junajan","followers_url":"https://api.github.com/users/junajan/followers","following_url":"https://api.github.com/users/junajan/following{/other_user}","gists_url":"https://api.github.com/users/junajan/gists{/gist_id}","starred_url":"https://api.github.com/users/junajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junajan/subscriptions","organizations_url":"https://api.github.com/users/junajan/orgs","repos_url":"https://api.github.com/users/junajan/repos","events_url":"https://api.github.com/users/junajan/events{/privacy}","received_events_url":"https://api.github.com/users/junajan/received_events","type":"User","site_admin":false},"body":"In case we want to just suspend the job we can use that option `suspend` which will add `suspended=true`.\r\n\r\nAlso, if we name the label `isSuspended` instead of `runOnDemandOnly`, how would you differentiate between suspended cronjobs and on-demand jobs?","created_at":"2018-07-03T10:35:32Z","updated_at":"2018-07-03T10:35:33Z","html_url":"https://github.com/commercetools/k8s-charts/pull/25#discussion_r199760336","pull_request_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/comments/199760336"},"html":{"href":"https://github.com/commercetools/k8s-charts/pull/25#discussion_r199760336"},"pull_request":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25"}},"in_reply_to_id":196452765},"pull_request":{"url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25","id":195759319,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzU5MzE5","html_url":"https://github.com/commercetools/k8s-charts/pull/25","diff_url":"https://github.com/commercetools/k8s-charts/pull/25.diff","patch_url":"https://github.com/commercetools/k8s-charts/pull/25.patch","issue_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/25","number":25,"state":"closed","locked":false,"title":"Add isOnDemand variable for ondemand jobs","user":{"login":"junajan","id":1090382,"node_id":"MDQ6VXNlcjEwOTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1090382?v=4","gravatar_id":"","url":"https://api.github.com/users/junajan","html_url":"https://github.com/junajan","followers_url":"https://api.github.com/users/junajan/followers","following_url":"https://api.github.com/users/junajan/following{/other_user}","gists_url":"https://api.github.com/users/junajan/gists{/gist_id}","starred_url":"https://api.github.com/users/junajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junajan/subscriptions","organizations_url":"https://api.github.com/users/junajan/orgs","repos_url":"https://api.github.com/users/junajan/repos","events_url":"https://api.github.com/users/junajan/events{/privacy}","received_events_url":"https://api.github.com/users/junajan/received_events","type":"User","site_admin":false},"body":"This PR adds a `isOnDemand` variable which in case it is set to `true` label job with `ondemand:\"true\"` label and suspend it at the start","created_at":"2018-06-19T09:11:47Z","updated_at":"2018-07-03T10:35:33Z","closed_at":"2018-06-20T10:40:42Z","merged_at":"2018-06-20T10:40:42Z","merge_commit_sha":"9f64359b66c17454c09c4cecdd506bc668f3d3f2","assignee":{"login":"junajan","id":1090382,"node_id":"MDQ6VXNlcjEwOTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1090382?v=4","gravatar_id":"","url":"https://api.github.com/users/junajan","html_url":"https://github.com/junajan","followers_url":"https://api.github.com/users/junajan/followers","following_url":"https://api.github.com/users/junajan/following{/other_user}","gists_url":"https://api.github.com/users/junajan/gists{/gist_id}","starred_url":"https://api.github.com/users/junajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junajan/subscriptions","organizations_url":"https://api.github.com/users/junajan/orgs","repos_url":"https://api.github.com/users/junajan/repos","events_url":"https://api.github.com/users/junajan/events{/privacy}","received_events_url":"https://api.github.com/users/junajan/received_events","type":"User","site_admin":false},"assignees":[{"login":"junajan","id":1090382,"node_id":"MDQ6VXNlcjEwOTAzODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1090382?v=4","gravatar_id":"","url":"https://api.github.com/users/junajan","html_url":"https://github.com/junajan","followers_url":"https://api.github.com/users/junajan/followers","following_url":"https://api.github.com/users/junajan/following{/other_user}","gists_url":"https://api.github.com/users/junajan/gists{/gist_id}","starred_url":"https://api.github.com/users/junajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junajan/subscriptions","organizations_url":"https://api.github.com/users/junajan/orgs","repos_url":"https://api.github.com/users/junajan/repos","events_url":"https://api.github.com/users/junajan/events{/privacy}","received_events_url":"https://api.github.com/users/junajan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"LEQADA","id":9251453,"node_id":"MDQ6VXNlcjkyNTE0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9251453?v=4","gravatar_id":"","url":"https://api.github.com/users/LEQADA","html_url":"https://github.com/LEQADA","followers_url":"https://api.github.com/users/LEQADA/followers","following_url":"https://api.github.com/users/LEQADA/following{/other_user}","gists_url":"https://api.github.com/users/LEQADA/gists{/gist_id}","starred_url":"https://api.github.com/users/LEQADA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEQADA/subscriptions","organizations_url":"https://api.github.com/users/LEQADA/orgs","repos_url":"https://api.github.com/users/LEQADA/repos","events_url":"https://api.github.com/users/LEQADA/events{/privacy}","received_events_url":"https://api.github.com/users/LEQADA/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25/commits","review_comments_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25/comments","review_comment_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/25/comments","statuses_url":"https://api.github.com/repos/commercetools/k8s-charts/statuses/623f8808cbd2f24f03b7fbb07ba9d44c15ea7ac4","head":{"label":"commercetools:ondemand-jobs","ref":"ondemand-jobs","sha":"623f8808cbd2f24f03b7fbb07ba9d44c15ea7ac4","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":130880909,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4ODA5MDk=","name":"k8s-charts","full_name":"commercetools/k8s-charts","owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/k8s-charts","description":"commercetools applications for Kubernetes ","fork":false,"url":"https://api.github.com/repos/commercetools/k8s-charts","forks_url":"https://api.github.com/repos/commercetools/k8s-charts/forks","keys_url":"https://api.github.com/repos/commercetools/k8s-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/k8s-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/k8s-charts/teams","hooks_url":"https://api.github.com/repos/commercetools/k8s-charts/hooks","issue_events_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/k8s-charts/events","assignees_url":"https://api.github.com/repos/commercetools/k8s-charts/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/k8s-charts/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/k8s-charts/tags","blobs_url":"https://api.github.com/repos/commercetools/k8s-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/k8s-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/k8s-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/k8s-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/k8s-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/k8s-charts/languages","stargazers_url":"https://api.github.com/repos/commercetools/k8s-charts/stargazers","contributors_url":"https://api.github.com/repos/commercetools/k8s-charts/contributors","subscribers_url":"https://api.github.com/repos/commercetools/k8s-charts/subscribers","subscription_url":"https://api.github.com/repos/commercetools/k8s-charts/subscription","commits_url":"https://api.github.com/repos/commercetools/k8s-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/k8s-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/k8s-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/k8s-charts/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/k8s-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/k8s-charts/merges","archive_url":"https://api.github.com/repos/commercetools/k8s-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/k8s-charts/downloads","issues_url":"https://api.github.com/repos/commercetools/k8s-charts/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/k8s-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/k8s-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/k8s-charts/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/k8s-charts/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/k8s-charts/deployments","created_at":"2018-04-24T16:06:58Z","updated_at":"2018-06-26T08:34:27Z","pushed_at":"2018-06-26T21:35:09Z","git_url":"git://github.com/commercetools/k8s-charts.git","ssh_url":"git@github.com:commercetools/k8s-charts.git","clone_url":"https://github.com/commercetools/k8s-charts.git","svn_url":"https://github.com/commercetools/k8s-charts","homepage":null,"size":159,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"1fbecdb3078a8f3d51fe0a357607a689799705b0","user":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":130880909,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4ODA5MDk=","name":"k8s-charts","full_name":"commercetools/k8s-charts","owner":{"login":"commercetools","id":1084585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODQ1ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/1084585?v=4","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/k8s-charts","description":"commercetools applications for Kubernetes ","fork":false,"url":"https://api.github.com/repos/commercetools/k8s-charts","forks_url":"https://api.github.com/repos/commercetools/k8s-charts/forks","keys_url":"https://api.github.com/repos/commercetools/k8s-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/k8s-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/k8s-charts/teams","hooks_url":"https://api.github.com/repos/commercetools/k8s-charts/hooks","issue_events_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/k8s-charts/events","assignees_url":"https://api.github.com/repos/commercetools/k8s-charts/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/k8s-charts/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/k8s-charts/tags","blobs_url":"https://api.github.com/repos/commercetools/k8s-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/k8s-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/k8s-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/k8s-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/k8s-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/k8s-charts/languages","stargazers_url":"https://api.github.com/repos/commercetools/k8s-charts/stargazers","contributors_url":"https://api.github.com/repos/commercetools/k8s-charts/contributors","subscribers_url":"https://api.github.com/repos/commercetools/k8s-charts/subscribers","subscription_url":"https://api.github.com/repos/commercetools/k8s-charts/subscription","commits_url":"https://api.github.com/repos/commercetools/k8s-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/k8s-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/k8s-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/k8s-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/k8s-charts/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/k8s-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/k8s-charts/merges","archive_url":"https://api.github.com/repos/commercetools/k8s-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/k8s-charts/downloads","issues_url":"https://api.github.com/repos/commercetools/k8s-charts/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/k8s-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/k8s-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/k8s-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/k8s-charts/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/k8s-charts/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/k8s-charts/deployments","created_at":"2018-04-24T16:06:58Z","updated_at":"2018-06-26T08:34:27Z","pushed_at":"2018-06-26T21:35:09Z","git_url":"git://github.com/commercetools/k8s-charts.git","ssh_url":"git@github.com:commercetools/k8s-charts.git","clone_url":"https://github.com/commercetools/k8s-charts.git","svn_url":"https://github.com/commercetools/k8s-charts","homepage":null,"size":159,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25"},"html":{"href":"https://github.com/commercetools/k8s-charts/pull/25"},"issue":{"href":"https://api.github.com/repos/commercetools/k8s-charts/issues/25"},"comments":{"href":"https://api.github.com/repos/commercetools/k8s-charts/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/k8s-charts/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/k8s-charts/statuses/623f8808cbd2f24f03b7fbb07ba9d44c15ea7ac4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"junajan"}}