{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/angular-react/pulls/comments/238474188","pull_request_review_id":181024953,"id":238474188,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ3NDE4OA==","diff_hunk":"@@ -16,6 +16,6 @@ type KnownKeysOfOptions = KnownKeys<Options>; // 'key' | 'title';\n \n  * Taken from https://stackoverflow.com/questions/51465182/typescript-remove-index-signature-using-mapped-types\n  */\n-type KnownKeys<T> = {\n+export type KnownKeys<T> = {","path":"libs/core/src/lib/declarations/known-keys.d.ts","position":5,"original_position":5,"commit_id":"59c588c2e6d122b56f62a1dd4ccf4833b3c792ae","original_commit_id":"59c588c2e6d122b56f62a1dd4ccf4833b3c792ae","user":{"login":"bengry","id":260431,"node_id":"MDQ6VXNlcjI2MDQzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260431?v=4","gravatar_id":"","url":"https://api.github.com/users/bengry","html_url":"https://github.com/bengry","followers_url":"https://api.github.com/users/bengry/followers","following_url":"https://api.github.com/users/bengry/following{/other_user}","gists_url":"https://api.github.com/users/bengry/gists{/gist_id}","starred_url":"https://api.github.com/users/bengry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengry/subscriptions","organizations_url":"https://api.github.com/users/bengry/orgs","repos_url":"https://api.github.com/users/bengry/repos","events_url":"https://api.github.com/users/bengry/events{/privacy}","received_events_url":"https://api.github.com/users/bengry/received_events","type":"User","site_admin":false},"body":"Was this giving you issues?\r\nI've been meaning to fix this - all of these declarations files should really be changed to just `.ts` files (and not `.d.ts`), and `export` from there.\r\n\r\nDoing it as declaration files was an oversight of mine.","created_at":"2018-12-03T23:08:27Z","updated_at":"2018-12-03T23:08:27Z","html_url":"https://github.com/Microsoft/angular-react/pull/45#discussion_r238474188","pull_request_url":"https://api.github.com/repos/Microsoft/angular-react/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/comments/238474188"},"html":{"href":"https://github.com/Microsoft/angular-react/pull/45#discussion_r238474188"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/angular-react/pulls/45","id":235618704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjE4NzA0","html_url":"https://github.com/Microsoft/angular-react/pull/45","diff_url":"https://github.com/Microsoft/angular-react/pull/45.diff","patch_url":"https://github.com/Microsoft/angular-react/pull/45.patch","issue_url":"https://api.github.com/repos/Microsoft/angular-react/issues/45","number":45,"state":"open","locked":false,"title":"Upgrade to Angular 7.0, Fabric 6.110.0; Fix build errors","user":{"login":"xjerwa","id":41396986,"node_id":"MDQ6VXNlcjQxMzk2OTg2","avatar_url":"https://avatars2.githubusercontent.com/u/41396986?v=4","gravatar_id":"","url":"https://api.github.com/users/xjerwa","html_url":"https://github.com/xjerwa","followers_url":"https://api.github.com/users/xjerwa/followers","following_url":"https://api.github.com/users/xjerwa/following{/other_user}","gists_url":"https://api.github.com/users/xjerwa/gists{/gist_id}","starred_url":"https://api.github.com/users/xjerwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjerwa/subscriptions","organizations_url":"https://api.github.com/users/xjerwa/orgs","repos_url":"https://api.github.com/users/xjerwa/repos","events_url":"https://api.github.com/users/xjerwa/events{/privacy}","received_events_url":"https://api.github.com/users/xjerwa/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T22:44:51Z","updated_at":"2018-12-03T23:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7951f83f9543ce01788724150fa081666053147","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/angular-react/pulls/45/commits","review_comments_url":"https://api.github.com/repos/Microsoft/angular-react/pulls/45/comments","review_comment_url":"https://api.github.com/repos/Microsoft/angular-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/angular-react/issues/45/comments","statuses_url":"https://api.github.com/repos/Microsoft/angular-react/statuses/59c588c2e6d122b56f62a1dd4ccf4833b3c792ae","head":{"label":"Microsoft:pr/45","ref":"pr/45","sha":"59c588c2e6d122b56f62a1dd4ccf4833b3c792ae","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":144321557,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzMjE1NTc=","name":"angular-react","full_name":"Microsoft/angular-react","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/angular-react","description":"Use React components inside Angular","fork":false,"url":"https://api.github.com/repos/Microsoft/angular-react","forks_url":"https://api.github.com/repos/Microsoft/angular-react/forks","keys_url":"https://api.github.com/repos/Microsoft/angular-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/angular-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/angular-react/teams","hooks_url":"https://api.github.com/repos/Microsoft/angular-react/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/angular-react/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/angular-react/events","assignees_url":"https://api.github.com/repos/Microsoft/angular-react/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/angular-react/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/angular-react/tags","blobs_url":"https://api.github.com/repos/Microsoft/angular-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/angular-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/angular-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/angular-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/angular-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/angular-react/languages","stargazers_url":"https://api.github.com/repos/Microsoft/angular-react/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/angular-react/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/angular-react/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/angular-react/subscription","commits_url":"https://api.github.com/repos/Microsoft/angular-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/angular-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/angular-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/angular-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/angular-react/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/angular-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/angular-react/merges","archive_url":"https://api.github.com/repos/Microsoft/angular-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/angular-react/downloads","issues_url":"https://api.github.com/repos/Microsoft/angular-react/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/angular-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/angular-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/angular-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/angular-react/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/angular-react/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/angular-react/deployments","created_at":"2018-08-10T18:48:01Z","updated_at":"2018-12-03T22:15:54Z","pushed_at":"2018-12-03T22:44:52Z","git_url":"git://github.com/Microsoft/angular-react.git","ssh_url":"git@github.com:Microsoft/angular-react.git","clone_url":"https://github.com/Microsoft/angular-react.git","svn_url":"https://github.com/Microsoft/angular-react","homepage":"https://microsoft.github.io/angular-react/","size":4205,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":27,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5408b238c2e3903a7417b6a2fd2e8c82bd94b0f1","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":144321557,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzMjE1NTc=","name":"angular-react","full_name":"Microsoft/angular-react","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/angular-react","description":"Use React components inside Angular","fork":false,"url":"https://api.github.com/repos/Microsoft/angular-react","forks_url":"https://api.github.com/repos/Microsoft/angular-react/forks","keys_url":"https://api.github.com/repos/Microsoft/angular-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/angular-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/angular-react/teams","hooks_url":"https://api.github.com/repos/Microsoft/angular-react/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/angular-react/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/angular-react/events","assignees_url":"https://api.github.com/repos/Microsoft/angular-react/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/angular-react/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/angular-react/tags","blobs_url":"https://api.github.com/repos/Microsoft/angular-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/angular-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/angular-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/angular-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/angular-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/angular-react/languages","stargazers_url":"https://api.github.com/repos/Microsoft/angular-react/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/angular-react/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/angular-react/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/angular-react/subscription","commits_url":"https://api.github.com/repos/Microsoft/angular-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/angular-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/angular-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/angular-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/angular-react/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/angular-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/angular-react/merges","archive_url":"https://api.github.com/repos/Microsoft/angular-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/angular-react/downloads","issues_url":"https://api.github.com/repos/Microsoft/angular-react/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/angular-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/angular-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/angular-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/angular-react/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/angular-react/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/angular-react/deployments","created_at":"2018-08-10T18:48:01Z","updated_at":"2018-12-03T22:15:54Z","pushed_at":"2018-12-03T22:44:52Z","git_url":"git://github.com/Microsoft/angular-react.git","ssh_url":"git@github.com:Microsoft/angular-react.git","clone_url":"https://github.com/Microsoft/angular-react.git","svn_url":"https://github.com/Microsoft/angular-react","homepage":"https://microsoft.github.io/angular-react/","size":4205,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/45"},"html":{"href":"https://github.com/Microsoft/angular-react/pull/45"},"issue":{"href":"https://api.github.com/repos/Microsoft/angular-react/issues/45"},"comments":{"href":"https://api.github.com/repos/Microsoft/angular-react/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/angular-react/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/angular-react/statuses/59c588c2e6d122b56f62a1dd4ccf4833b3c792ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bengry"}}