{"action":"created","comment":{"url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/comments/180434272","pull_request_review_id":110852041,"id":180434272,"diff_hunk":"@@ -4,14 +4,16 @@\n \theight: 100%;\n \tdisplay: flex;\n \talign-items: center;\n+\tjustify-content: center;\n \tmargin-top: -(@toolbar-height);\n \t@media(max-width: @screen-sm-max) {\n \t\tmargin-top: -(@mobile-toolbar-height);\n \t}\n-\tbackground-position: center;\n-\tbackground-repeat: no-repeat;\n-\tbackground-size: 130px 128px;\n-\tbackground-image: url('data:image/svg+xml;utf8,<svg xmlns=\"http://www.w3.org/2000/svg\"><path fill=\"#e7e7e7\" d=\"M.002 59.15v-3.545q0-2.724 1.226-4.974 1.226-2.247 3.27-3.747L58.735 9.546q1.363-1.088 2.93-1.566 1.567-.476 3.202-.476 1.77 0 3.339.476 1.567.478 2.793 1.566l54.235 37.338q2.045 1.5 3.27 3.749 1.227 2.248 1.227 4.974v3.95l-23.167 16.216V52.472q0-1.498-1.157-2.59-1.158-1.088-2.658-1.088h-75.63q-1.635 0-2.724 1.089-1.09 1.09-1.09 2.589v22.894L.002 59.15zm73.038 47.83q-1.772 1.362-3.883 1.977-2.113.611-4.293.611t-4.293-.613q-2.111-.613-4.019-2.11L0 67.596v52.055q0 3.408 2.383 5.86 2.386 2.454 5.929 2.454h113.104q3.543 0 6.063-2.454 2.521-2.452 2.521-5.86V68.143L73.04 106.98zM48.922 76.591q0 7.63 4.7 12.4 4.703 4.77 12.607 4.77 6.678 0 10.288-2.658 3.611-2.657 3.611-4.837 0-2.18-1.704-2.793t-1.84-.478q-1.362 2.045-3.679 3.749-2.317 1.703-6.678 1.703-4.632 0-7.697-2.794-3.067-2.793-3.476-7.427h24.12q1.09 0 1.499-.478.409-.475.409-1.566v-.545q0-7.36-4.293-11.923-4.293-4.565-11.379-4.565-7.085.137-11.786 5.041-4.702 4.906-4.702 12.401zm6.267-2.996q.684-4.09 3.476-6.679 2.793-2.589 6.882-2.589 4.088 0 6.542 2.52 2.452 2.521 2.724 6.746H55.189z\"/></svg>');","path":"src/components/viewer-placeholder/style.less","position":12,"original_position":12,"commit_id":"9a51610c53c516607d4e3d9c7b48e2ea307d3edc","original_commit_id":"9a51610c53c516607d4e3d9c7b48e2ea307d3edc","user":{"login":"pl12133","id":12724311,"avatar_url":"https://avatars3.githubusercontent.com/u/12724311?v=4","gravatar_id":"","url":"https://api.github.com/users/pl12133","html_url":"https://github.com/pl12133","followers_url":"https://api.github.com/users/pl12133/followers","following_url":"https://api.github.com/users/pl12133/following{/other_user}","gists_url":"https://api.github.com/users/pl12133/gists{/gist_id}","starred_url":"https://api.github.com/users/pl12133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pl12133/subscriptions","organizations_url":"https://api.github.com/users/pl12133/orgs","repos_url":"https://api.github.com/users/pl12133/repos","events_url":"https://api.github.com/users/pl12133/events{/privacy}","received_events_url":"https://api.github.com/users/pl12133/received_events","type":"User","site_admin":false},"body":"The two strategies seem nearly equivalent to me; I think we will eventually get more client specific icons so it would be worthwhile to keep those around.","created_at":"2018-04-10T14:08:01Z","updated_at":"2018-04-10T14:08:01Z","html_url":"https://github.com/Zimbra/zm-x-web/pull/14#discussion_r180434272","pull_request_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/comments/180434272"},"html":{"href":"https://github.com/Zimbra/zm-x-web/pull/14#discussion_r180434272"},"pull_request":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14"}},"in_reply_to_id":179547020},"pull_request":{"url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14","id":179716637,"html_url":"https://github.com/Zimbra/zm-x-web/pull/14","diff_url":"https://github.com/Zimbra/zm-x-web/pull/14.diff","patch_url":"https://github.com/Zimbra/zm-x-web/pull/14.patch","issue_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/14","number":14,"state":"open","locked":false,"title":"PREAPPS-511: Small UI changes: Background image and logo height","user":{"login":"pl12133","id":12724311,"avatar_url":"https://avatars3.githubusercontent.com/u/12724311?v=4","gravatar_id":"","url":"https://api.github.com/users/pl12133","html_url":"https://github.com/pl12133","followers_url":"https://api.github.com/users/pl12133/followers","following_url":"https://api.github.com/users/pl12133/following{/other_user}","gists_url":"https://api.github.com/users/pl12133/gists{/gist_id}","starred_url":"https://api.github.com/users/pl12133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pl12133/subscriptions","organizations_url":"https://api.github.com/users/pl12133/orgs","repos_url":"https://api.github.com/users/pl12133/repos","events_url":"https://api.github.com/users/pl12133/events{/privacy}","received_events_url":"https://api.github.com/users/pl12133/received_events","type":"User","site_admin":false},"body":"> Change out svg background:\r\n> 1. Change out svg background asset to standard envelope icon\r\n>   -- It would be better if this background image was made an asset in the client file.\r\n> 2. Change header logo max-height of 30px\r\n\r\nImplemented `<ClientIcon>` for @tstegner who was asking about how to achieve client specific Icons. We can now use client specific icons from the `config/CLIENT/assets/icons/` folder by rendering `<Icon name=\"client:envelope\" />`, which will render `config/CLIENT/assets/icons/envelope.svg`.","created_at":"2018-04-05T15:40:36Z","updated_at":"2018-04-10T14:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da4709891638d258ae7143b07fd359c61243be41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/14/comments","statuses_url":"https://api.github.com/repos/Zimbra/zm-x-web/statuses/9a51610c53c516607d4e3d9c7b48e2ea307d3edc","head":{"label":"Zimbra:PREAPPS-511","ref":"PREAPPS-511","sha":"9a51610c53c516607d4e3d9c7b48e2ea307d3edc","user":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars2.githubusercontent.com/u/8135764?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"repo":{"id":126518968,"name":"zm-x-web","full_name":"Zimbra/zm-x-web","owner":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars2.githubusercontent.com/u/8135764?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zimbra/zm-x-web","description":"Zimbra X Web Client","fork":false,"url":"https://api.github.com/repos/Zimbra/zm-x-web","forks_url":"https://api.github.com/repos/Zimbra/zm-x-web/forks","keys_url":"https://api.github.com/repos/Zimbra/zm-x-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zimbra/zm-x-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zimbra/zm-x-web/teams","hooks_url":"https://api.github.com/repos/Zimbra/zm-x-web/hooks","issue_events_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/events{/number}","events_url":"https://api.github.com/repos/Zimbra/zm-x-web/events","assignees_url":"https://api.github.com/repos/Zimbra/zm-x-web/assignees{/user}","branches_url":"https://api.github.com/repos/Zimbra/zm-x-web/branches{/branch}","tags_url":"https://api.github.com/repos/Zimbra/zm-x-web/tags","blobs_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zimbra/zm-x-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Zimbra/zm-x-web/languages","stargazers_url":"https://api.github.com/repos/Zimbra/zm-x-web/stargazers","contributors_url":"https://api.github.com/repos/Zimbra/zm-x-web/contributors","subscribers_url":"https://api.github.com/repos/Zimbra/zm-x-web/subscribers","subscription_url":"https://api.github.com/repos/Zimbra/zm-x-web/subscription","commits_url":"https://api.github.com/repos/Zimbra/zm-x-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zimbra/zm-x-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zimbra/zm-x-web/contents/{+path}","compare_url":"https://api.github.com/repos/Zimbra/zm-x-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zimbra/zm-x-web/merges","archive_url":"https://api.github.com/repos/Zimbra/zm-x-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zimbra/zm-x-web/downloads","issues_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues{/number}","pulls_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Zimbra/zm-x-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Zimbra/zm-x-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zimbra/zm-x-web/labels{/name}","releases_url":"https://api.github.com/repos/Zimbra/zm-x-web/releases{/id}","deployments_url":"https://api.github.com/repos/Zimbra/zm-x-web/deployments","created_at":"2018-03-23T17:39:12Z","updated_at":"2018-04-09T20:23:47Z","pushed_at":"2018-04-10T09:10:15Z","git_url":"git://github.com/Zimbra/zm-x-web.git","ssh_url":"git@github.com:Zimbra/zm-x-web.git","clone_url":"https://github.com/Zimbra/zm-x-web.git","svn_url":"https://github.com/Zimbra/zm-x-web","homepage":"https://beta.lonni.me","size":2618,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"Zimbra:master","ref":"master","sha":"d871f8dacf2d64d6771ecb51fa4e3d93bb0075f8","user":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars2.githubusercontent.com/u/8135764?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"repo":{"id":126518968,"name":"zm-x-web","full_name":"Zimbra/zm-x-web","owner":{"login":"Zimbra","id":8135764,"avatar_url":"https://avatars2.githubusercontent.com/u/8135764?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimbra","html_url":"https://github.com/Zimbra","followers_url":"https://api.github.com/users/Zimbra/followers","following_url":"https://api.github.com/users/Zimbra/following{/other_user}","gists_url":"https://api.github.com/users/Zimbra/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimbra/subscriptions","organizations_url":"https://api.github.com/users/Zimbra/orgs","repos_url":"https://api.github.com/users/Zimbra/repos","events_url":"https://api.github.com/users/Zimbra/events{/privacy}","received_events_url":"https://api.github.com/users/Zimbra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zimbra/zm-x-web","description":"Zimbra X Web Client","fork":false,"url":"https://api.github.com/repos/Zimbra/zm-x-web","forks_url":"https://api.github.com/repos/Zimbra/zm-x-web/forks","keys_url":"https://api.github.com/repos/Zimbra/zm-x-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zimbra/zm-x-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zimbra/zm-x-web/teams","hooks_url":"https://api.github.com/repos/Zimbra/zm-x-web/hooks","issue_events_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/events{/number}","events_url":"https://api.github.com/repos/Zimbra/zm-x-web/events","assignees_url":"https://api.github.com/repos/Zimbra/zm-x-web/assignees{/user}","branches_url":"https://api.github.com/repos/Zimbra/zm-x-web/branches{/branch}","tags_url":"https://api.github.com/repos/Zimbra/zm-x-web/tags","blobs_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zimbra/zm-x-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Zimbra/zm-x-web/languages","stargazers_url":"https://api.github.com/repos/Zimbra/zm-x-web/stargazers","contributors_url":"https://api.github.com/repos/Zimbra/zm-x-web/contributors","subscribers_url":"https://api.github.com/repos/Zimbra/zm-x-web/subscribers","subscription_url":"https://api.github.com/repos/Zimbra/zm-x-web/subscription","commits_url":"https://api.github.com/repos/Zimbra/zm-x-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zimbra/zm-x-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zimbra/zm-x-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zimbra/zm-x-web/contents/{+path}","compare_url":"https://api.github.com/repos/Zimbra/zm-x-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zimbra/zm-x-web/merges","archive_url":"https://api.github.com/repos/Zimbra/zm-x-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zimbra/zm-x-web/downloads","issues_url":"https://api.github.com/repos/Zimbra/zm-x-web/issues{/number}","pulls_url":"https://api.github.com/repos/Zimbra/zm-x-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Zimbra/zm-x-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Zimbra/zm-x-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zimbra/zm-x-web/labels{/name}","releases_url":"https://api.github.com/repos/Zimbra/zm-x-web/releases{/id}","deployments_url":"https://api.github.com/repos/Zimbra/zm-x-web/deployments","created_at":"2018-03-23T17:39:12Z","updated_at":"2018-04-09T20:23:47Z","pushed_at":"2018-04-10T09:10:15Z","git_url":"git://github.com/Zimbra/zm-x-web.git","ssh_url":"git@github.com:Zimbra/zm-x-web.git","clone_url":"https://github.com/Zimbra/zm-x-web.git","svn_url":"https://github.com/Zimbra/zm-x-web","homepage":"https://beta.lonni.me","size":2618,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14"},"html":{"href":"https://github.com/Zimbra/zm-x-web/pull/14"},"issue":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/issues/14"},"comments":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Zimbra/zm-x-web/statuses/9a51610c53c516607d4e3d9c7b48e2ea307d3edc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pl12133"}}