{"action":"created","issue":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/64","repository_url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet","labels_url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/64/comments","events_url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/64/events","html_url":"https://github.com/ethereumjs/ethereumjs-wallet/issues/64","id":345568374,"node_id":"MDU6SXNzdWUzNDU1NjgzNzQ=","number":64,"title":"dist/hdkey.js (Maintainer Update: Critical bug in v0.6.1, now fixed with v0.6.2, please update!)","user":{"login":"michaelsbradleyjr","id":194260,"node_id":"MDQ6VXNlcjE5NDI2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/194260?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelsbradleyjr","html_url":"https://github.com/michaelsbradleyjr","followers_url":"https://api.github.com/users/michaelsbradleyjr/followers","following_url":"https://api.github.com/users/michaelsbradleyjr/following{/other_user}","gists_url":"https://api.github.com/users/michaelsbradleyjr/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsbradleyjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsbradleyjr/subscriptions","organizations_url":"https://api.github.com/users/michaelsbradleyjr/orgs","repos_url":"https://api.github.com/users/michaelsbradleyjr/repos","events_url":"https://api.github.com/users/michaelsbradleyjr/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsbradleyjr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-07-29T22:31:36Z","updated_at":"2018-08-10T01:13:40Z","closed_at":null,"author_association":"NONE","body":"With the new 0.6.1 release, this:\r\n\r\n```\r\nconst hdkey = require('ethereumjs-wallet/hdkey');\r\n```\r\n\r\nMust be changed to:\r\n\r\n```\r\nconst hdkey = require('ethereumjs-wallet/dist/hdkey');\r\n```\r\n\r\nMaybe that's not what you intended?  Even though your pkg.json main points at `dist/`, a module reference like `'ethereumjs-wallet/hdkey'` only works if `hdkey.js` is at the top-level of the package.\r\n\r\nIn the published package, you could include an `hdkey.js` that's a one-liner:\r\n\r\n```\r\nmodule.exports = require('./dist/hdkey.js');\r\n```\r\n\r\nHowever, you would need to reorg the sources that get transpiled by babel under `src/` and update the `build:dist` script accordingly."},"comment":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/comments/411945368","html_url":"https://github.com/ethereumjs/ethereumjs-wallet/issues/64#issuecomment-411945368","issue_url":"https://api.github.com/repos/ethereumjs/ethereumjs-wallet/issues/64","id":411945368,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTk0NTM2OA==","user":{"login":"sohkai","id":4166642,"node_id":"MDQ6VXNlcjQxNjY2NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T01:13:40Z","updated_at":"2018-08-10T01:13:40Z","author_association":"NONE","body":"@holgerd77 Can confirm that this works, assuming no lock files have cached the 0.6.1 version."}}
{"actor":{"display_login":"sohkai"}}