{"action":"opened","number":364,"pull_request":{"url":"https://api.github.com/repos/nats-io/go-nats/pulls/364","id":187107559,"html_url":"https://github.com/nats-io/go-nats/pull/364","diff_url":"https://github.com/nats-io/go-nats/pull/364.diff","patch_url":"https://github.com/nats-io/go-nats/pull/364.patch","issue_url":"https://api.github.com/repos/nats-io/go-nats/issues/364","number":364,"state":"open","locked":false,"title":"run the mcb hook in parallel, instead of running one by one","user":{"login":"asxalex","id":1144608,"avatar_url":"https://avatars0.githubusercontent.com/u/1144608?v=4","gravatar_id":"","url":"https://api.github.com/users/asxalex","html_url":"https://github.com/asxalex","followers_url":"https://api.github.com/users/asxalex/followers","following_url":"https://api.github.com/users/asxalex/following{/other_user}","gists_url":"https://api.github.com/users/asxalex/gists{/gist_id}","starred_url":"https://api.github.com/users/asxalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asxalex/subscriptions","organizations_url":"https://api.github.com/users/asxalex/orgs","repos_url":"https://api.github.com/users/asxalex/repos","events_url":"https://api.github.com/users/asxalex/events{/privacy}","received_events_url":"https://api.github.com/users/asxalex/received_events","type":"User","site_admin":false},"body":"from my point of view, the subscription handler should be run in parallel, like an http server, every time the 'api'(a publication in nats) is called, the handler should be called, instead of waiting for the last one to finish. Making the running of \"mcb\" as a golang coroutine satisfies this need. please make me informed if the change spoils something or it would cause some disaster :)","created_at":"2018-05-10T05:56:17Z","updated_at":"2018-05-10T05:56:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nats-io/go-nats/pulls/364/commits","review_comments_url":"https://api.github.com/repos/nats-io/go-nats/pulls/364/comments","review_comment_url":"https://api.github.com/repos/nats-io/go-nats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nats-io/go-nats/issues/364/comments","statuses_url":"https://api.github.com/repos/nats-io/go-nats/statuses/dc8cd12898868dce8e3fdf961e361ac6fd1b7758","head":{"label":"asxalex:master","ref":"master","sha":"dc8cd12898868dce8e3fdf961e361ac6fd1b7758","user":{"login":"asxalex","id":1144608,"avatar_url":"https://avatars0.githubusercontent.com/u/1144608?v=4","gravatar_id":"","url":"https://api.github.com/users/asxalex","html_url":"https://github.com/asxalex","followers_url":"https://api.github.com/users/asxalex/followers","following_url":"https://api.github.com/users/asxalex/following{/other_user}","gists_url":"https://api.github.com/users/asxalex/gists{/gist_id}","starred_url":"https://api.github.com/users/asxalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asxalex/subscriptions","organizations_url":"https://api.github.com/users/asxalex/orgs","repos_url":"https://api.github.com/users/asxalex/repos","events_url":"https://api.github.com/users/asxalex/events{/privacy}","received_events_url":"https://api.github.com/users/asxalex/received_events","type":"User","site_admin":false},"repo":{"id":132748882,"name":"go-nats","full_name":"asxalex/go-nats","owner":{"login":"asxalex","id":1144608,"avatar_url":"https://avatars0.githubusercontent.com/u/1144608?v=4","gravatar_id":"","url":"https://api.github.com/users/asxalex","html_url":"https://github.com/asxalex","followers_url":"https://api.github.com/users/asxalex/followers","following_url":"https://api.github.com/users/asxalex/following{/other_user}","gists_url":"https://api.github.com/users/asxalex/gists{/gist_id}","starred_url":"https://api.github.com/users/asxalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asxalex/subscriptions","organizations_url":"https://api.github.com/users/asxalex/orgs","repos_url":"https://api.github.com/users/asxalex/repos","events_url":"https://api.github.com/users/asxalex/events{/privacy}","received_events_url":"https://api.github.com/users/asxalex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asxalex/go-nats","description":"Golang client for NATS, the cloud native messaging system.","fork":true,"url":"https://api.github.com/repos/asxalex/go-nats","forks_url":"https://api.github.com/repos/asxalex/go-nats/forks","keys_url":"https://api.github.com/repos/asxalex/go-nats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asxalex/go-nats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asxalex/go-nats/teams","hooks_url":"https://api.github.com/repos/asxalex/go-nats/hooks","issue_events_url":"https://api.github.com/repos/asxalex/go-nats/issues/events{/number}","events_url":"https://api.github.com/repos/asxalex/go-nats/events","assignees_url":"https://api.github.com/repos/asxalex/go-nats/assignees{/user}","branches_url":"https://api.github.com/repos/asxalex/go-nats/branches{/branch}","tags_url":"https://api.github.com/repos/asxalex/go-nats/tags","blobs_url":"https://api.github.com/repos/asxalex/go-nats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asxalex/go-nats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asxalex/go-nats/git/refs{/sha}","trees_url":"https://api.github.com/repos/asxalex/go-nats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asxalex/go-nats/statuses/{sha}","languages_url":"https://api.github.com/repos/asxalex/go-nats/languages","stargazers_url":"https://api.github.com/repos/asxalex/go-nats/stargazers","contributors_url":"https://api.github.com/repos/asxalex/go-nats/contributors","subscribers_url":"https://api.github.com/repos/asxalex/go-nats/subscribers","subscription_url":"https://api.github.com/repos/asxalex/go-nats/subscription","commits_url":"https://api.github.com/repos/asxalex/go-nats/commits{/sha}","git_commits_url":"https://api.github.com/repos/asxalex/go-nats/git/commits{/sha}","comments_url":"https://api.github.com/repos/asxalex/go-nats/comments{/number}","issue_comment_url":"https://api.github.com/repos/asxalex/go-nats/issues/comments{/number}","contents_url":"https://api.github.com/repos/asxalex/go-nats/contents/{+path}","compare_url":"https://api.github.com/repos/asxalex/go-nats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asxalex/go-nats/merges","archive_url":"https://api.github.com/repos/asxalex/go-nats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asxalex/go-nats/downloads","issues_url":"https://api.github.com/repos/asxalex/go-nats/issues{/number}","pulls_url":"https://api.github.com/repos/asxalex/go-nats/pulls{/number}","milestones_url":"https://api.github.com/repos/asxalex/go-nats/milestones{/number}","notifications_url":"https://api.github.com/repos/asxalex/go-nats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asxalex/go-nats/labels{/name}","releases_url":"https://api.github.com/repos/asxalex/go-nats/releases{/id}","deployments_url":"https://api.github.com/repos/asxalex/go-nats/deployments","created_at":"2018-05-09T11:46:14Z","updated_at":"2018-05-09T11:56:15Z","pushed_at":"2018-05-09T11:56:13Z","git_url":"git://github.com/asxalex/go-nats.git","ssh_url":"git@github.com:asxalex/go-nats.git","clone_url":"https://github.com/asxalex/go-nats.git","svn_url":"https://github.com/asxalex/go-nats","homepage":"https://nats.io","size":940,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nats-io:master","ref":"master","sha":"247b2a84d8d0ff15cbc6faafc77ef15ea4317011","user":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":5425992,"name":"go-nats","full_name":"nats-io/go-nats","owner":{"login":"nats-io","id":10203055,"avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nats-io/go-nats","description":"Golang client for NATS, the cloud native messaging system.","fork":false,"url":"https://api.github.com/repos/nats-io/go-nats","forks_url":"https://api.github.com/repos/nats-io/go-nats/forks","keys_url":"https://api.github.com/repos/nats-io/go-nats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/go-nats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/go-nats/teams","hooks_url":"https://api.github.com/repos/nats-io/go-nats/hooks","issue_events_url":"https://api.github.com/repos/nats-io/go-nats/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/go-nats/events","assignees_url":"https://api.github.com/repos/nats-io/go-nats/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/go-nats/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/go-nats/tags","blobs_url":"https://api.github.com/repos/nats-io/go-nats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/go-nats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/go-nats/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/go-nats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/go-nats/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/go-nats/languages","stargazers_url":"https://api.github.com/repos/nats-io/go-nats/stargazers","contributors_url":"https://api.github.com/repos/nats-io/go-nats/contributors","subscribers_url":"https://api.github.com/repos/nats-io/go-nats/subscribers","subscription_url":"https://api.github.com/repos/nats-io/go-nats/subscription","commits_url":"https://api.github.com/repos/nats-io/go-nats/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/go-nats/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/go-nats/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/go-nats/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/go-nats/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/go-nats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/go-nats/merges","archive_url":"https://api.github.com/repos/nats-io/go-nats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/go-nats/downloads","issues_url":"https://api.github.com/repos/nats-io/go-nats/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/go-nats/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/go-nats/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/go-nats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/go-nats/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/go-nats/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/go-nats/deployments","created_at":"2012-08-15T12:54:59Z","updated_at":"2018-05-10T02:59:33Z","pushed_at":"2018-05-02T18:01:58Z","git_url":"git://github.com/nats-io/go-nats.git","ssh_url":"git@github.com:nats-io/go-nats.git","clone_url":"https://github.com/nats-io/go-nats.git","svn_url":"https://github.com/nats-io/go-nats","homepage":"https://nats.io","size":939,"stargazers_count":1637,"watchers_count":1637,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":222,"open_issues":11,"watchers":1637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/364"},"html":{"href":"https://github.com/nats-io/go-nats/pull/364"},"issue":{"href":"https://api.github.com/repos/nats-io/go-nats/issues/364"},"comments":{"href":"https://api.github.com/repos/nats-io/go-nats/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nats-io/go-nats/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/nats-io/go-nats/statuses/dc8cd12898868dce8e3fdf961e361ac6fd1b7758"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"asxalex"}}