{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/mkosi/pulls/comments/235235850","pull_request_review_id":177055904,"id":235235850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTIzNTg1MA==","diff_hunk":"@@ -85,6 +85,8 @@ class CommandLineArguments(argparse.Namespace):\n \n     swap_partno = None  # type: Optional[int]\n     esp_partno = None  # type: Optional[int]\n+    with_network = None  # type: Optional[bool]\n+    with_docs = None  # type: Optional[bool]","path":"mkosi","position":5,"original_position":5,"commit_id":"d6ca5b11f0d7a37d3427a715f6808c7668438045","original_commit_id":"d6ca5b11f0d7a37d3427a715f6808c7668438045","user":{"login":"lucasdemarchi","id":31864,"node_id":"MDQ6VXNlcjMxODY0","avatar_url":"https://avatars3.githubusercontent.com/u/31864?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"body":"@keszybz is this the preferred way to fix? Or should we just pass `default=None` to the option?","created_at":"2018-11-21T02:30:45Z","updated_at":"2018-11-21T02:30:45Z","html_url":"https://github.com/systemd/mkosi/pull/291#discussion_r235235850","pull_request_url":"https://api.github.com/repos/systemd/mkosi/pulls/291","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/comments/235235850"},"html":{"href":"https://github.com/systemd/mkosi/pull/291#discussion_r235235850"},"pull_request":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/mkosi/pulls/291","id":232315483,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzE1NDgz","html_url":"https://github.com/systemd/mkosi/pull/291","diff_url":"https://github.com/systemd/mkosi/pull/291.diff","patch_url":"https://github.com/systemd/mkosi/pull/291.patch","issue_url":"https://api.github.com/repos/systemd/mkosi/issues/291","number":291,"state":"open","locked":false,"title":"set correct defaults for optional args","user":{"login":"foxxx0","id":3109156,"node_id":"MDQ6VXNlcjMxMDkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3109156?v=4","gravatar_id":"","url":"https://api.github.com/users/foxxx0","html_url":"https://github.com/foxxx0","followers_url":"https://api.github.com/users/foxxx0/followers","following_url":"https://api.github.com/users/foxxx0/following{/other_user}","gists_url":"https://api.github.com/users/foxxx0/gists{/gist_id}","starred_url":"https://api.github.com/users/foxxx0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxxx0/subscriptions","organizations_url":"https://api.github.com/users/foxxx0/orgs","repos_url":"https://api.github.com/users/foxxx0/repos","events_url":"https://api.github.com/users/foxxx0/events{/privacy}","received_events_url":"https://api.github.com/users/foxxx0/received_events","type":"User","site_admin":false},"body":"args.with_network and args.with_docs were always initialized to `False`\r\nthus ignoring any setting in a config file (WithNetwork/WithDocs).\r\n\r\nThis breaks the config parser (load_defaults) because it checks if the\r\ncurrent value of `key` is None before assigning the value from the\r\nconfig file.\r\n\r\nSigned-off-by: Thore Bödecker <me@foxxx0.de>","created_at":"2018-11-20T13:23:54Z","updated_at":"2018-11-21T02:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8778e37ab21cb48ef4661b21a97078a7f84a886a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/mkosi/pulls/291/commits","review_comments_url":"https://api.github.com/repos/systemd/mkosi/pulls/291/comments","review_comment_url":"https://api.github.com/repos/systemd/mkosi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/mkosi/issues/291/comments","statuses_url":"https://api.github.com/repos/systemd/mkosi/statuses/d6ca5b11f0d7a37d3427a715f6808c7668438045","head":{"label":"foxxx0:fix-cmdline-config-parse","ref":"fix-cmdline-config-parse","sha":"d6ca5b11f0d7a37d3427a715f6808c7668438045","user":{"login":"foxxx0","id":3109156,"node_id":"MDQ6VXNlcjMxMDkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3109156?v=4","gravatar_id":"","url":"https://api.github.com/users/foxxx0","html_url":"https://github.com/foxxx0","followers_url":"https://api.github.com/users/foxxx0/followers","following_url":"https://api.github.com/users/foxxx0/following{/other_user}","gists_url":"https://api.github.com/users/foxxx0/gists{/gist_id}","starred_url":"https://api.github.com/users/foxxx0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxxx0/subscriptions","organizations_url":"https://api.github.com/users/foxxx0/orgs","repos_url":"https://api.github.com/users/foxxx0/repos","events_url":"https://api.github.com/users/foxxx0/events{/privacy}","received_events_url":"https://api.github.com/users/foxxx0/received_events","type":"User","site_admin":false},"repo":{"id":157381165,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczODExNjU=","name":"mkosi","full_name":"foxxx0/mkosi","private":false,"owner":{"login":"foxxx0","id":3109156,"node_id":"MDQ6VXNlcjMxMDkxNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3109156?v=4","gravatar_id":"","url":"https://api.github.com/users/foxxx0","html_url":"https://github.com/foxxx0","followers_url":"https://api.github.com/users/foxxx0/followers","following_url":"https://api.github.com/users/foxxx0/following{/other_user}","gists_url":"https://api.github.com/users/foxxx0/gists{/gist_id}","starred_url":"https://api.github.com/users/foxxx0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxxx0/subscriptions","organizations_url":"https://api.github.com/users/foxxx0/orgs","repos_url":"https://api.github.com/users/foxxx0/repos","events_url":"https://api.github.com/users/foxxx0/events{/privacy}","received_events_url":"https://api.github.com/users/foxxx0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/foxxx0/mkosi","description":"Build Legacy-Free OS Images","fork":true,"url":"https://api.github.com/repos/foxxx0/mkosi","forks_url":"https://api.github.com/repos/foxxx0/mkosi/forks","keys_url":"https://api.github.com/repos/foxxx0/mkosi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foxxx0/mkosi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foxxx0/mkosi/teams","hooks_url":"https://api.github.com/repos/foxxx0/mkosi/hooks","issue_events_url":"https://api.github.com/repos/foxxx0/mkosi/issues/events{/number}","events_url":"https://api.github.com/repos/foxxx0/mkosi/events","assignees_url":"https://api.github.com/repos/foxxx0/mkosi/assignees{/user}","branches_url":"https://api.github.com/repos/foxxx0/mkosi/branches{/branch}","tags_url":"https://api.github.com/repos/foxxx0/mkosi/tags","blobs_url":"https://api.github.com/repos/foxxx0/mkosi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foxxx0/mkosi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foxxx0/mkosi/git/refs{/sha}","trees_url":"https://api.github.com/repos/foxxx0/mkosi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foxxx0/mkosi/statuses/{sha}","languages_url":"https://api.github.com/repos/foxxx0/mkosi/languages","stargazers_url":"https://api.github.com/repos/foxxx0/mkosi/stargazers","contributors_url":"https://api.github.com/repos/foxxx0/mkosi/contributors","subscribers_url":"https://api.github.com/repos/foxxx0/mkosi/subscribers","subscription_url":"https://api.github.com/repos/foxxx0/mkosi/subscription","commits_url":"https://api.github.com/repos/foxxx0/mkosi/commits{/sha}","git_commits_url":"https://api.github.com/repos/foxxx0/mkosi/git/commits{/sha}","comments_url":"https://api.github.com/repos/foxxx0/mkosi/comments{/number}","issue_comment_url":"https://api.github.com/repos/foxxx0/mkosi/issues/comments{/number}","contents_url":"https://api.github.com/repos/foxxx0/mkosi/contents/{+path}","compare_url":"https://api.github.com/repos/foxxx0/mkosi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foxxx0/mkosi/merges","archive_url":"https://api.github.com/repos/foxxx0/mkosi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foxxx0/mkosi/downloads","issues_url":"https://api.github.com/repos/foxxx0/mkosi/issues{/number}","pulls_url":"https://api.github.com/repos/foxxx0/mkosi/pulls{/number}","milestones_url":"https://api.github.com/repos/foxxx0/mkosi/milestones{/number}","notifications_url":"https://api.github.com/repos/foxxx0/mkosi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foxxx0/mkosi/labels{/name}","releases_url":"https://api.github.com/repos/foxxx0/mkosi/releases{/id}","deployments_url":"https://api.github.com/repos/foxxx0/mkosi/deployments","created_at":"2018-11-13T13:02:27Z","updated_at":"2018-11-13T13:02:30Z","pushed_at":"2018-11-20T13:23:41Z","git_url":"git://github.com/foxxx0/mkosi.git","ssh_url":"git@github.com:foxxx0/mkosi.git","clone_url":"https://github.com/foxxx0/mkosi.git","svn_url":"https://github.com/foxxx0/mkosi","homepage":null,"size":626,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"31d9bd0f544e04d65c107530f467d37947705673","user":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":63237385,"node_id":"MDEwOlJlcG9zaXRvcnk2MzIzNzM4NQ==","name":"mkosi","full_name":"systemd/mkosi","private":false,"owner":{"login":"systemd","id":1918868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTg4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/systemd/mkosi","description":"Build Legacy-Free OS Images","fork":false,"url":"https://api.github.com/repos/systemd/mkosi","forks_url":"https://api.github.com/repos/systemd/mkosi/forks","keys_url":"https://api.github.com/repos/systemd/mkosi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/mkosi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/mkosi/teams","hooks_url":"https://api.github.com/repos/systemd/mkosi/hooks","issue_events_url":"https://api.github.com/repos/systemd/mkosi/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/mkosi/events","assignees_url":"https://api.github.com/repos/systemd/mkosi/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/mkosi/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/mkosi/tags","blobs_url":"https://api.github.com/repos/systemd/mkosi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/mkosi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/mkosi/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/mkosi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/mkosi/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/mkosi/languages","stargazers_url":"https://api.github.com/repos/systemd/mkosi/stargazers","contributors_url":"https://api.github.com/repos/systemd/mkosi/contributors","subscribers_url":"https://api.github.com/repos/systemd/mkosi/subscribers","subscription_url":"https://api.github.com/repos/systemd/mkosi/subscription","commits_url":"https://api.github.com/repos/systemd/mkosi/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/mkosi/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/mkosi/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/mkosi/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/mkosi/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/mkosi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/mkosi/merges","archive_url":"https://api.github.com/repos/systemd/mkosi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/mkosi/downloads","issues_url":"https://api.github.com/repos/systemd/mkosi/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/mkosi/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/mkosi/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/mkosi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/mkosi/labels{/name}","releases_url":"https://api.github.com/repos/systemd/mkosi/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/mkosi/deployments","created_at":"2016-07-13T10:31:19Z","updated_at":"2018-11-20T02:12:33Z","pushed_at":"2018-11-21T02:17:21Z","git_url":"git://github.com/systemd/mkosi.git","ssh_url":"git@github.com:systemd/mkosi.git","clone_url":"https://github.com/systemd/mkosi.git","svn_url":"https://github.com/systemd/mkosi","homepage":null,"size":705,"stargazers_count":332,"watchers_count":332,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":98,"open_issues":37,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/291"},"html":{"href":"https://github.com/systemd/mkosi/pull/291"},"issue":{"href":"https://api.github.com/repos/systemd/mkosi/issues/291"},"comments":{"href":"https://api.github.com/repos/systemd/mkosi/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/mkosi/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/mkosi/statuses/d6ca5b11f0d7a37d3427a715f6808c7668438045"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucasdemarchi"}}