{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments/176493211","pull_request_review_id":106207086,"id":176493211,"diff_hunk":"@@ -3,7 +3,17 @@\n     {% for category, message in messages %}\n       {% if category == 'track-page-view' %}\n         <div data-analytics=\"trackPageView\" data-url=\"{{ message }}\"></div>\n-      {% elif category != 'must_login' and category != 'flag' %}  {# skip showing Flask's \"Please log in\" message; also skip \"flag\" messages intended for Google Analytics etc. #}\n+      {% elif category == 'flag' %}\n+        {# these were originally messages with a function similar to the above \"track-page-view\" ones (analytics) but #}\n+        {# they did not know about their actual virtual page view url, expecting the receiving page to know the       #}\n+        {# corresponding url for a particular symbolic \"message\".                                                     #}\n+        {# TODO these can be got rid of as soon as the app generating each flag flash message is converted to using   #}\n+        {# new \"track-page-view\" mechanism                                                                            #}\n+        {% if message == \"account-created\" %}\n+          <div data-analytics=\"trackPageView\" data-url=\"/suppliers?account-created=true\"></div>","path":"toolkit/templates/flash_messages.html","position":12,"original_position":12,"commit_id":"0e9e84df2fae3f1b8ea1e48dc36ed9d640f1ae1b","original_commit_id":"0e9e84df2fae3f1b8ea1e48dc36ed9d640f1ae1b","user":{"login":"risicle","id":807447,"avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"Well that's interesting. I didn't know the unified `flash_messages.html` could peacefully coexist with additional flash message handling - I assumed after the first `get_flashed_messages` call the messages were \"consumed\" and then wouldn't be seen in subsequent calls (which I *think* is the way things worked in django-land).\r\n\r\nAnyway, :hankey: \r\n\r\nI'll have to fall back (*back*) to plan A and copypasta the modified `flash_messages.html` into the supplier frontend for the meantime.","created_at":"2018-03-22T16:49:54Z","updated_at":"2018-03-22T16:49:54Z","html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425#discussion_r176493211","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments/176493211"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425#discussion_r176493211"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425"}},"in_reply_to_id":176488606},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425","id":176759597,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425","diff_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/425","number":425,"state":"open","locked":false,"title":"flash messages template: add stopgap handling of old \"flag\" message category","user":{"login":"risicle","id":807447,"avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},"body":"Related to ticket https://trello.com/c/H7upcsyQ/303-flash-messages-suppliers-app\r\n\r\nI think I've explained this enough in the included inline comment. Should be able to remove the handling of `account-created` once the user frontend no longer emits it.","created_at":"2018-03-22T12:15:40Z","updated_at":"2018-03-22T16:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4838c696deeba39744638c15bcacb1800d7064f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"galund","id":190828,"avatar_url":"https://avatars3.githubusercontent.com/u/190828?v=4","gravatar_id":"","url":"https://api.github.com/users/galund","html_url":"https://github.com/galund","followers_url":"https://api.github.com/users/galund/followers","following_url":"https://api.github.com/users/galund/following{/other_user}","gists_url":"https://api.github.com/users/galund/gists{/gist_id}","starred_url":"https://api.github.com/users/galund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galund/subscriptions","organizations_url":"https://api.github.com/users/galund/orgs","repos_url":"https://api.github.com/users/galund/repos","events_url":"https://api.github.com/users/galund/events{/privacy}","received_events_url":"https://api.github.com/users/galund/received_events","type":"User","site_admin":false},{"login":"DilwoarH","id":4599889,"avatar_url":"https://avatars2.githubusercontent.com/u/4599889?v=4","gravatar_id":"","url":"https://api.github.com/users/DilwoarH","html_url":"https://github.com/DilwoarH","followers_url":"https://api.github.com/users/DilwoarH/followers","following_url":"https://api.github.com/users/DilwoarH/following{/other_user}","gists_url":"https://api.github.com/users/DilwoarH/gists{/gist_id}","starred_url":"https://api.github.com/users/DilwoarH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DilwoarH/subscriptions","organizations_url":"https://api.github.com/users/DilwoarH/orgs","repos_url":"https://api.github.com/users/DilwoarH/repos","events_url":"https://api.github.com/users/DilwoarH/events{/privacy}","received_events_url":"https://api.github.com/users/DilwoarH/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/425/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/0e9e84df2fae3f1b8ea1e48dc36ed9d640f1ae1b","head":{"label":"alphagov:ris-flash-messages-flag","ref":"ris-flash-messages-flag","sha":"0e9e84df2fae3f1b8ea1e48dc36ed9d640f1ae1b","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":28664922,"name":"digitalmarketplace-frontend-toolkit","full_name":"alphagov/digitalmarketplace-frontend-toolkit","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","description":"Front end toolkit for the Digital Marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/deployments","created_at":"2014-12-31T11:56:55Z","updated_at":"2018-03-20T15:06:50Z","pushed_at":"2018-03-22T12:17:11Z","git_url":"git://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-frontend-toolkit.git","clone_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","svn_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","homepage":"http://alphagov.github.io/digitalmarketplace-frontend-toolkit/","size":3687,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f7fa5abe9c4d7c3025c8f2b91995304e0610a168","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":28664922,"name":"digitalmarketplace-frontend-toolkit","full_name":"alphagov/digitalmarketplace-frontend-toolkit","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","description":"Front end toolkit for the Digital Marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/deployments","created_at":"2014-12-31T11:56:55Z","updated_at":"2018-03-20T15:06:50Z","pushed_at":"2018-03-22T12:17:11Z","git_url":"git://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-frontend-toolkit.git","clone_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","svn_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","homepage":"http://alphagov.github.io/digitalmarketplace-frontend-toolkit/","size":3687,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/425"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/425"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/0e9e84df2fae3f1b8ea1e48dc36ed9d640f1ae1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"risicle"}}