{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/242602532","pull_request_review_id":186153091,"id":242602532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjYwMjUzMg==","diff_hunk":"@@ -30,6 +30,27 @@ At minimum you must define the data pin your LED strip is connected to, and the\n \n Then you should be able to use the keycodes below to change the RGB lighting to your liking.\n \n+### Support on STM32\n+\n+STM32 chips support driving WS2812B LEDs using their SPI bus. You may want to do this to support both RGB Matrix and Underglow independently, at the same time. Driving via SPI also frees up 2 timers that are used in the alternative implemenetaion.\n+\n+If you want to use this feature, you have to turn it on specifically, as well as use specific pins and provide some extra information. SPI driven WS2812B LEDs require use of an SPI MOSI pin on your STM32 chip. \n+\n+To enable the feature, at a minimum, you must define:\n+\n+|Define                |Description                                                                |\n+|----------------------|---------------------------------------------------------------------------|\n+|`RGB_DI_PIN`          |The pin connected to the data pin of the LEDs - this must be a SPI MOSI pin|\n+|`RGBLED_NUM`          |The number of LEDs connected                                               |\n+|`RGBLIGHT_STM32_SPI`  |Enables the SPI DMA based RGB underglow feature                            |","path":"docs/feature_rgblight.md","position":25,"original_position":25,"commit_id":"b131faad76eafd7e01604f4e05bf052b6255287f","original_commit_id":"b131faad76eafd7e01604f4e05bf052b6255287f","user":{"login":"drashna","id":2584963,"node_id":"MDQ6VXNlcjI1ODQ5NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2584963?v=4","gravatar_id":"","url":"https://api.github.com/users/drashna","html_url":"https://github.com/drashna","followers_url":"https://api.github.com/users/drashna/followers","following_url":"https://api.github.com/users/drashna/following{/other_user}","gists_url":"https://api.github.com/users/drashna/gists{/gist_id}","starred_url":"https://api.github.com/users/drashna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drashna/subscriptions","organizations_url":"https://api.github.com/users/drashna/orgs","repos_url":"https://api.github.com/users/drashna/repos","events_url":"https://api.github.com/users/drashna/events{/privacy}","received_events_url":"https://api.github.com/users/drashna/received_events","type":"User","site_admin":false},"body":"I would prefer that this was hardware agnostic.  Eg just:\r\n```suggestion\r\n |`RGBLIGHT_SPI`  |Enables the SPI DMA based RGB underglow feature                            |\r\n```","created_at":"2018-12-18T16:15:20Z","updated_at":"2018-12-18T16:20:56Z","html_url":"https://github.com/qmk/qmk_firmware/pull/4670#discussion_r242602532","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/242602532"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4670#discussion_r242602532"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670"}}},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670","id":238975109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTc1MTA5","html_url":"https://github.com/qmk/qmk_firmware/pull/4670","diff_url":"https://github.com/qmk/qmk_firmware/pull/4670.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4670.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4670","number":4670,"state":"open","locked":false,"title":"SPI DMA based RGB Underglow for STM32","user":{"login":"awkannan1","id":25588015,"node_id":"MDQ6VXNlcjI1NTg4MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/25588015?v=4","gravatar_id":"","url":"https://api.github.com/users/awkannan1","html_url":"https://github.com/awkannan1","followers_url":"https://api.github.com/users/awkannan1/followers","following_url":"https://api.github.com/users/awkannan1/following{/other_user}","gists_url":"https://api.github.com/users/awkannan1/gists{/gist_id}","starred_url":"https://api.github.com/users/awkannan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awkannan1/subscriptions","organizations_url":"https://api.github.com/users/awkannan1/orgs","repos_url":"https://api.github.com/users/awkannan1/repos","events_url":"https://api.github.com/users/awkannan1/events{/privacy}","received_events_url":"https://api.github.com/users/awkannan1/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n<!--- This template is entirely option and can be removed, but is here to help both you and us. -->\r\n<!--- This text and anything on lines wrapped like this one will not show up in the final text. This text is to help us and you. -->\r\n\r\n## Description\r\nIntegrate SPI + DMA based RGB underglow for STM32 into Core QMK.\r\n\r\nThis PR was started on master (as opposed based on Jack's branch), and still leaves a spot for Jack's changes to integrate in ws2812.c\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Core\r\n- [ ] Bugfix\r\n- [X] New Feature\r\n- [ ] Enhancement/Optimization\r\n- [ ] Keyboard (addition or update)\r\n- [ ] Keymap/Layout/Userspace (addition or update)\r\n- [X] Documentation\r\n\r\n\r\n## Issues Fixed or Closed by this PR\r\n\r\n* No RGB underglow on stm32 based boards\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project.\r\n- [X] My change requires a change to the documentation.\r\n- [X] I have updated the documentation accordingly.\r\n- [X] I have read the **CONTRIBUTING** document. (https://docs.qmk.fm/#/contributing)\r\n- [ ] I have added tests to cover my changes.\r\n- [X] I have tested the changes and verified that they work and don't break anything (as well as I can manage).\r\n","created_at":"2018-12-16T16:10:41Z","updated_at":"2018-12-18T16:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00b76969c30c404b642ad62ec21f80a0f9bae9c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jackhumbert","id":141431,"node_id":"MDQ6VXNlcjE0MTQzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/141431?v=4","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},{"login":"ezuk","id":1092548,"node_id":"MDQ6VXNlcjEwOTI1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1092548?v=4","gravatar_id":"","url":"https://api.github.com/users/ezuk","html_url":"https://github.com/ezuk","followers_url":"https://api.github.com/users/ezuk/followers","following_url":"https://api.github.com/users/ezuk/following{/other_user}","gists_url":"https://api.github.com/users/ezuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ezuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezuk/subscriptions","organizations_url":"https://api.github.com/users/ezuk/orgs","repos_url":"https://api.github.com/users/ezuk/repos","events_url":"https://api.github.com/users/ezuk/events{/privacy}","received_events_url":"https://api.github.com/users/ezuk/received_events","type":"User","site_admin":false},{"login":"skullydazed","id":9553982,"node_id":"MDQ6VXNlcjk1NTM5ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9553982?v=4","gravatar_id":"","url":"https://api.github.com/users/skullydazed","html_url":"https://github.com/skullydazed","followers_url":"https://api.github.com/users/skullydazed/followers","following_url":"https://api.github.com/users/skullydazed/following{/other_user}","gists_url":"https://api.github.com/users/skullydazed/gists{/gist_id}","starred_url":"https://api.github.com/users/skullydazed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skullydazed/subscriptions","organizations_url":"https://api.github.com/users/skullydazed/orgs","repos_url":"https://api.github.com/users/skullydazed/repos","events_url":"https://api.github.com/users/skullydazed/events{/privacy}","received_events_url":"https://api.github.com/users/skullydazed/received_events","type":"User","site_admin":false},{"login":"fredizzimo","id":9946255,"node_id":"MDQ6VXNlcjk5NDYyNTU=","avatar_url":"https://avatars1.githubusercontent.com/u/9946255?v=4","gravatar_id":"","url":"https://api.github.com/users/fredizzimo","html_url":"https://github.com/fredizzimo","followers_url":"https://api.github.com/users/fredizzimo/followers","following_url":"https://api.github.com/users/fredizzimo/following{/other_user}","gists_url":"https://api.github.com/users/fredizzimo/gists{/gist_id}","starred_url":"https://api.github.com/users/fredizzimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredizzimo/subscriptions","organizations_url":"https://api.github.com/users/fredizzimo/orgs","repos_url":"https://api.github.com/users/fredizzimo/repos","events_url":"https://api.github.com/users/fredizzimo/events{/privacy}","received_events_url":"https://api.github.com/users/fredizzimo/received_events","type":"User","site_admin":false},{"login":"mechmerlin","id":30334081,"node_id":"MDQ6VXNlcjMwMzM0MDgx","avatar_url":"https://avatars1.githubusercontent.com/u/30334081?v=4","gravatar_id":"","url":"https://api.github.com/users/mechmerlin","html_url":"https://github.com/mechmerlin","followers_url":"https://api.github.com/users/mechmerlin/followers","following_url":"https://api.github.com/users/mechmerlin/following{/other_user}","gists_url":"https://api.github.com/users/mechmerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/mechmerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mechmerlin/subscriptions","organizations_url":"https://api.github.com/users/mechmerlin/orgs","repos_url":"https://api.github.com/users/mechmerlin/repos","events_url":"https://api.github.com/users/mechmerlin/events{/privacy}","received_events_url":"https://api.github.com/users/mechmerlin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":720613800,"node_id":"MDU6TGFiZWw3MjA2MTM4MDA=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/core","name":"core","color":"f92925","default":false},{"id":155557982,"node_id":"MDU6TGFiZWwxNTU1NTc5ODI=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/enhancement","name":"enhancement","color":"c5def5","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4670/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/b131faad76eafd7e01604f4e05bf052b6255287f","head":{"label":"awkannan1:201812_stm32_pwm_led_spi_dma_rgb_underglow","ref":"201812_stm32_pwm_led_spi_dma_rgb_underglow","sha":"b131faad76eafd7e01604f4e05bf052b6255287f","user":{"login":"awkannan1","id":25588015,"node_id":"MDQ6VXNlcjI1NTg4MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/25588015?v=4","gravatar_id":"","url":"https://api.github.com/users/awkannan1","html_url":"https://github.com/awkannan1","followers_url":"https://api.github.com/users/awkannan1/followers","following_url":"https://api.github.com/users/awkannan1/following{/other_user}","gists_url":"https://api.github.com/users/awkannan1/gists{/gist_id}","starred_url":"https://api.github.com/users/awkannan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awkannan1/subscriptions","organizations_url":"https://api.github.com/users/awkannan1/orgs","repos_url":"https://api.github.com/users/awkannan1/repos","events_url":"https://api.github.com/users/awkannan1/events{/privacy}","received_events_url":"https://api.github.com/users/awkannan1/received_events","type":"User","site_admin":false},"repo":{"id":150921566,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA5MjE1NjY=","name":"qmk_firmware","full_name":"awkannan1/qmk_firmware","private":false,"owner":{"login":"awkannan1","id":25588015,"node_id":"MDQ6VXNlcjI1NTg4MDE1","avatar_url":"https://avatars1.githubusercontent.com/u/25588015?v=4","gravatar_id":"","url":"https://api.github.com/users/awkannan1","html_url":"https://github.com/awkannan1","followers_url":"https://api.github.com/users/awkannan1/followers","following_url":"https://api.github.com/users/awkannan1/following{/other_user}","gists_url":"https://api.github.com/users/awkannan1/gists{/gist_id}","starred_url":"https://api.github.com/users/awkannan1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awkannan1/subscriptions","organizations_url":"https://api.github.com/users/awkannan1/orgs","repos_url":"https://api.github.com/users/awkannan1/repos","events_url":"https://api.github.com/users/awkannan1/events{/privacy}","received_events_url":"https://api.github.com/users/awkannan1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/awkannan1/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":true,"url":"https://api.github.com/repos/awkannan1/qmk_firmware","forks_url":"https://api.github.com/repos/awkannan1/qmk_firmware/forks","keys_url":"https://api.github.com/repos/awkannan1/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awkannan1/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awkannan1/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/awkannan1/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/awkannan1/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/awkannan1/qmk_firmware/events","assignees_url":"https://api.github.com/repos/awkannan1/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/awkannan1/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/awkannan1/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/awkannan1/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awkannan1/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awkannan1/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/awkannan1/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awkannan1/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/awkannan1/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/awkannan1/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/awkannan1/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/awkannan1/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/awkannan1/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/awkannan1/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/awkannan1/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/awkannan1/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/awkannan1/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/awkannan1/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/awkannan1/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awkannan1/qmk_firmware/merges","archive_url":"https://api.github.com/repos/awkannan1/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awkannan1/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/awkannan1/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/awkannan1/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/awkannan1/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/awkannan1/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awkannan1/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/awkannan1/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/awkannan1/qmk_firmware/deployments","created_at":"2018-09-30T02:23:34Z","updated_at":"2018-12-15T22:20:10Z","pushed_at":"2018-12-18T00:57:54Z","git_url":"git://github.com/awkannan1/qmk_firmware.git","ssh_url":"git@github.com:awkannan1/qmk_firmware.git","clone_url":"https://github.com/awkannan1/qmk_firmware.git","svn_url":"https://github.com/awkannan1/qmk_firmware","homepage":"http://qmk.fm","size":107258,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"398204b2a03bdac68fccb6f7592ed3ea52741ce5","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","private":false,"owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-12-18T04:42:38Z","pushed_at":"2018-12-18T12:36:33Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":121577,"stargazers_count":3358,"watchers_count":3358,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6391,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6391,"open_issues":329,"watchers":3358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4670"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4670"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4670/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4670/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/b131faad76eafd7e01604f4e05bf052b6255287f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drashna"}}