{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/518","repository_url":"https://api.github.com/repos/aws/aws-sdk-java-v2","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/518/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/518/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/518/events","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/518","id":328697734,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTcwMTAw","number":518,"title":"Fix changelog sorting issue with preview versions","user":{"login":"varunnvs92","id":17261531,"node_id":"MDQ6VXNlcjE3MjYxNTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17261531?v=4","gravatar_id":"","url":"https://api.github.com/users/varunnvs92","html_url":"https://github.com/varunnvs92","followers_url":"https://api.github.com/users/varunnvs92/followers","following_url":"https://api.github.com/users/varunnvs92/following{/other_user}","gists_url":"https://api.github.com/users/varunnvs92/gists{/gist_id}","starred_url":"https://api.github.com/users/varunnvs92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varunnvs92/subscriptions","organizations_url":"https://api.github.com/users/varunnvs92/orgs","repos_url":"https://api.github.com/users/varunnvs92/repos","events_url":"https://api.github.com/users/varunnvs92/events{/privacy}","received_events_url":"https://api.github.com/users/varunnvs92/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-02T00:46:29Z","updated_at":"2018-06-04T17:36:56Z","closed_at":"2018-06-02T01:14:03Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/518","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/518","diff_url":"https://github.com/aws/aws-sdk-java-v2/pull/518.diff","patch_url":"https://github.com/aws/aws-sdk-java-v2/pull/518.patch"},"body":"Issue was comparing preview version strings \r\n\r\nIn old code,\r\npreview-2 > preview-10 as cmp() functions checks one character at a time. So checks 2 > 1 and decides preview-2 is greater. This PR fixes it by parsing the \"preview-\" string and comparing the integer values\r\n\r\n## License\r\n<!--- The SDK is released under the Apache 2.0 license (http://aws.amazon.com/apache2.0/), so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a Contributor License Agreement (http://en.wikipedia.org/wiki/Contributor_License_Agreement) -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [x] I confirm that this pull request can be released under the Apache 2 license\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments/394437125","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/518#issuecomment-394437125","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/518","id":394437125,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDQzNzEyNQ==","user":{"login":"varunnvs92","id":17261531,"node_id":"MDQ6VXNlcjE3MjYxNTMx","avatar_url":"https://avatars0.githubusercontent.com/u/17261531?v=4","gravatar_id":"","url":"https://api.github.com/users/varunnvs92","html_url":"https://github.com/varunnvs92","followers_url":"https://api.github.com/users/varunnvs92/followers","following_url":"https://api.github.com/users/varunnvs92/following{/other_user}","gists_url":"https://api.github.com/users/varunnvs92/gists{/gist_id}","starred_url":"https://api.github.com/users/varunnvs92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varunnvs92/subscriptions","organizations_url":"https://api.github.com/users/varunnvs92/orgs","repos_url":"https://api.github.com/users/varunnvs92/repos","events_url":"https://api.github.com/users/varunnvs92/events{/privacy}","received_events_url":"https://api.github.com/users/varunnvs92/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T17:36:56Z","updated_at":"2018-06-04T17:36:56Z","author_association":"CONTRIBUTOR","body":"I tried reproducing the issue locally on my machine by running the same commands at the commit before preview-10 release. But I could not repo the issue. All the files were deleted everytime and added to the 2.0.0-preview-10.json file."}}
{"actor":{"display_login":"varunnvs92"}}