{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments/233161652","pull_request_review_id":174511251,"id":233161652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE2MTY1Mg==","diff_hunk":"@@ -892,7 +892,7 @@ public static BlobListOption fields(BlobField... fields) {\n     private final Object value;\n \n     enum Option {\n-      HTTP_METHOD, CONTENT_TYPE, MD5, EXT_HEADERS, SERVICE_ACCOUNT_CRED\n+      HTTP_METHOD, CONTENT_TYPE, MD5, EXT_HEADERS, SERVICE_ACCOUNT_CRED,SERVICE_ENDPOINT","path":"google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java","position":5,"original_position":5,"commit_id":"13cdaf317c9fd25e5b54a4efceade38d8858ed4d","original_commit_id":"13cdaf317c9fd25e5b54a4efceade38d8858ed4d","user":{"login":"frankyn","id":1907648,"node_id":"MDQ6VXNlcjE5MDc2NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1907648?v=4","gravatar_id":"","url":"https://api.github.com/users/frankyn","html_url":"https://github.com/frankyn","followers_url":"https://api.github.com/users/frankyn/followers","following_url":"https://api.github.com/users/frankyn/following{/other_user}","gists_url":"https://api.github.com/users/frankyn/gists{/gist_id}","starred_url":"https://api.github.com/users/frankyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankyn/subscriptions","organizations_url":"https://api.github.com/users/frankyn/orgs","repos_url":"https://api.github.com/users/frankyn/repos","events_url":"https://api.github.com/users/frankyn/events{/privacy}","received_events_url":"https://api.github.com/users/frankyn/received_events","type":"User","site_admin":false},"body":"Let's keep the Enum `SignUrlOption.Option.SERVICE_ENDPOINT` and `SignUrlOption.withHostName()` consistent. Change `SERVICE_ENDPOINT` to `HOST_NAME`.","created_at":"2018-11-13T18:10:07Z","updated_at":"2018-11-13T18:15:02Z","html_url":"https://github.com/googleapis/google-cloud-java/pull/3910#discussion_r233161652","pull_request_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments/233161652"},"html":{"href":"https://github.com/googleapis/google-cloud-java/pull/3910#discussion_r233161652"},"pull_request":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910"}},"in_reply_to_id":233152542},"pull_request":{"url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910","id":228690763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NjkwNzYz","html_url":"https://github.com/googleapis/google-cloud-java/pull/3910","diff_url":"https://github.com/googleapis/google-cloud-java/pull/3910.diff","patch_url":"https://github.com/googleapis/google-cloud-java/pull/3910.patch","issue_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3910","number":3910,"state":"open","locked":false,"title":"Storage: Added feature to change host name of signed url","user":{"login":"pmakani","id":44407134,"node_id":"MDQ6VXNlcjQ0NDA3MTM0","avatar_url":"https://avatars0.githubusercontent.com/u/44407134?v=4","gravatar_id":"","url":"https://api.github.com/users/pmakani","html_url":"https://github.com/pmakani","followers_url":"https://api.github.com/users/pmakani/followers","following_url":"https://api.github.com/users/pmakani/following{/other_user}","gists_url":"https://api.github.com/users/pmakani/gists{/gist_id}","starred_url":"https://api.github.com/users/pmakani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmakani/subscriptions","organizations_url":"https://api.github.com/users/pmakani/orgs","repos_url":"https://api.github.com/users/pmakani/repos","events_url":"https://api.github.com/users/pmakani/events{/privacy}","received_events_url":"https://api.github.com/users/pmakani/received_events","type":"User","site_admin":false},"body":"Fixes Issue #3140 - Add feature to change host name of generated url for storage.","created_at":"2018-11-06T13:26:49Z","updated_at":"2018-11-13T18:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d08e08d33881b8a5c61996016f27c27265cd76","assignee":{"login":"chingor13","id":32483,"node_id":"MDQ6VXNlcjMyNDgz","avatar_url":"https://avatars0.githubusercontent.com/u/32483?v=4","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false},"assignees":[{"login":"chingor13","id":32483,"node_id":"MDQ6VXNlcjMyNDgz","avatar_url":"https://avatars0.githubusercontent.com/u/32483?v=4","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":175662348,"node_id":"MDU6TGFiZWwxNzU2NjIzNDg=","url":"https://api.github.com/repos/googleapis/google-cloud-java/labels/api:%20storage","name":"api: storage","color":"f8f8f8","default":false},{"id":175662188,"node_id":"MDU6TGFiZWwxNzU2NjIxODg=","url":"https://api.github.com/repos/googleapis/google-cloud-java/labels/cla:%20yes","name":"cla: yes","color":"0B7601","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910/commits","review_comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910/comments","review_comment_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3910/comments","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/13cdaf317c9fd25e5b54a4efceade38d8858ed4d","head":{"label":"pmakani:storage-feature-request-3140","ref":"storage-feature-request-3140","sha":"13cdaf317c9fd25e5b54a4efceade38d8858ed4d","user":{"login":"pmakani","id":44407134,"node_id":"MDQ6VXNlcjQ0NDA3MTM0","avatar_url":"https://avatars0.githubusercontent.com/u/44407134?v=4","gravatar_id":"","url":"https://api.github.com/users/pmakani","html_url":"https://github.com/pmakani","followers_url":"https://api.github.com/users/pmakani/followers","following_url":"https://api.github.com/users/pmakani/following{/other_user}","gists_url":"https://api.github.com/users/pmakani/gists{/gist_id}","starred_url":"https://api.github.com/users/pmakani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmakani/subscriptions","organizations_url":"https://api.github.com/users/pmakani/orgs","repos_url":"https://api.github.com/users/pmakani/repos","events_url":"https://api.github.com/users/pmakani/events{/privacy}","received_events_url":"https://api.github.com/users/pmakani/received_events","type":"User","site_admin":false},"repo":{"id":154444154,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0NDQxNTQ=","name":"google-cloud-java","full_name":"pmakani/google-cloud-java","private":false,"owner":{"login":"pmakani","id":44407134,"node_id":"MDQ6VXNlcjQ0NDA3MTM0","avatar_url":"https://avatars0.githubusercontent.com/u/44407134?v=4","gravatar_id":"","url":"https://api.github.com/users/pmakani","html_url":"https://github.com/pmakani","followers_url":"https://api.github.com/users/pmakani/followers","following_url":"https://api.github.com/users/pmakani/following{/other_user}","gists_url":"https://api.github.com/users/pmakani/gists{/gist_id}","starred_url":"https://api.github.com/users/pmakani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmakani/subscriptions","organizations_url":"https://api.github.com/users/pmakani/orgs","repos_url":"https://api.github.com/users/pmakani/repos","events_url":"https://api.github.com/users/pmakani/events{/privacy}","received_events_url":"https://api.github.com/users/pmakani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmakani/google-cloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/pmakani/google-cloud-java","forks_url":"https://api.github.com/repos/pmakani/google-cloud-java/forks","keys_url":"https://api.github.com/repos/pmakani/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmakani/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmakani/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/pmakani/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/pmakani/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/pmakani/google-cloud-java/events","assignees_url":"https://api.github.com/repos/pmakani/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/pmakani/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/pmakani/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/pmakani/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmakani/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmakani/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmakani/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmakani/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/pmakani/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/pmakani/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/pmakani/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/pmakani/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/pmakani/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/pmakani/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmakani/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmakani/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmakani/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmakani/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/pmakani/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmakani/google-cloud-java/merges","archive_url":"https://api.github.com/repos/pmakani/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmakani/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/pmakani/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/pmakani/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/pmakani/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/pmakani/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmakani/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/pmakani/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/pmakani/google-cloud-java/deployments","created_at":"2018-10-24T05:30:16Z","updated_at":"2018-11-13T08:58:50Z","pushed_at":"2018-11-13T09:08:55Z","git_url":"git://github.com/pmakani/google-cloud-java.git","ssh_url":"git@github.com:pmakani/google-cloud-java.git","clone_url":"https://github.com/pmakani/google-cloud-java.git","svn_url":"https://github.com/pmakani/google-cloud-java","homepage":"https://googleapis.github.io/google-cloud-java/","size":521511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"5fa529e7427ac63b1a532a2c4817f3cb8fe7cb43","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"node_id":"MDEwOlJlcG9zaXRvcnkyNjE4MTI3OA==","name":"google-cloud-java","full_name":"googleapis/google-cloud-java","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/google-cloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/googleapis/google-cloud-java","forks_url":"https://api.github.com/repos/googleapis/google-cloud-java/forks","keys_url":"https://api.github.com/repos/googleapis/google-cloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/google-cloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/google-cloud-java/teams","hooks_url":"https://api.github.com/repos/googleapis/google-cloud-java/hooks","issue_events_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/google-cloud-java/events","assignees_url":"https://api.github.com/repos/googleapis/google-cloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/google-cloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/google-cloud-java/tags","blobs_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/google-cloud-java/languages","stargazers_url":"https://api.github.com/repos/googleapis/google-cloud-java/stargazers","contributors_url":"https://api.github.com/repos/googleapis/google-cloud-java/contributors","subscribers_url":"https://api.github.com/repos/googleapis/google-cloud-java/subscribers","subscription_url":"https://api.github.com/repos/googleapis/google-cloud-java/subscription","commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/google-cloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/google-cloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/google-cloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/google-cloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/google-cloud-java/merges","archive_url":"https://api.github.com/repos/googleapis/google-cloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/google-cloud-java/downloads","issues_url":"https://api.github.com/repos/googleapis/google-cloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/google-cloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/google-cloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/google-cloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/google-cloud-java/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/google-cloud-java/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/google-cloud-java/deployments","created_at":"2014-11-04T17:57:16Z","updated_at":"2018-11-13T14:35:23Z","pushed_at":"2018-11-13T18:07:25Z","git_url":"git://github.com/googleapis/google-cloud-java.git","ssh_url":"git@github.com:googleapis/google-cloud-java.git","clone_url":"https://github.com/googleapis/google-cloud-java.git","svn_url":"https://github.com/googleapis/google-cloud-java","homepage":"https://googleapis.github.io/google-cloud-java/","size":590084,"stargazers_count":953,"watchers_count":953,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":581,"mirror_url":null,"archived":false,"open_issues_count":204,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":581,"open_issues":204,"watchers":953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910"},"html":{"href":"https://github.com/googleapis/google-cloud-java/pull/3910"},"issue":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3910"},"comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/issues/3910/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/pulls/3910/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/google-cloud-java/statuses/13cdaf317c9fd25e5b54a4efceade38d8858ed4d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"frankyn"}}