{"action":"created","comment":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/comments/226489779","pull_request_review_id":166324958,"id":226489779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ4OTc3OQ==","diff_hunk":"@@ -12,15 +12,37 @@\n from starfish.imagestack.imagestack import ImageStack\n from starfish.munge import relabel\n from starfish.stats import label_to_regions\n-from starfish.types import Indices\n+from starfish.types import Indices, Number\n from ._base import SegmentationAlgorithmBase\n \n \n class Watershed(SegmentationAlgorithmBase):\n-    \"\"\"\n-    Implements watershed segmentation.  TODO: (dganguli) FILL IN DETAILS HERE PLS.\n-    \"\"\"\n-    def __init__(self, dapi_threshold, input_threshold, min_distance, **kwargs) -> None:\n+\n+    def __init__(\n+        self,\n+        dapi_threshold: Number,\n+        input_threshold: Number,\n+        min_distance: int,\n+        **kwargs\n+    ) -> None:\n+        \"\"\"Implements watershed segmentation of cells seeded from a DAPI image the the point clouds\n+\n+        Watershed segmentation proceeds by constructing basins that extend from the DAPI image\n+        and the point cloud constructed from a maximum projection across rounds and channels. It\n+        constructs a mask that extends from the basins to prevent non-cellular regions from being\n+        included.\n+","path":"starfish/image/_segmentation/watershed.py","position":28,"original_position":28,"commit_id":"f5ea0ca24aecd6e15157bb6a62f59ea24c156f6c","original_commit_id":"f5ea0ca24aecd6e15157bb6a62f59ea24c156f6c","user":{"login":"dganguli","id":2704460,"node_id":"MDQ6VXNlcjI3MDQ0NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2704460?v=4","gravatar_id":"","url":"https://api.github.com/users/dganguli","html_url":"https://github.com/dganguli","followers_url":"https://api.github.com/users/dganguli/followers","following_url":"https://api.github.com/users/dganguli/following{/other_user}","gists_url":"https://api.github.com/users/dganguli/gists{/gist_id}","starred_url":"https://api.github.com/users/dganguli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dganguli/subscriptions","organizations_url":"https://api.github.com/users/dganguli/orgs","repos_url":"https://api.github.com/users/dganguli/repos","events_url":"https://api.github.com/users/dganguli/events{/privacy}","received_events_url":"https://api.github.com/users/dganguli/received_events","type":"User","site_admin":false},"body":"add: this simply wraps skimage. blah blah blah dot watershed and link to that functions documentation as well?","created_at":"2018-10-18T22:48:59Z","updated_at":"2018-10-18T22:49:09Z","html_url":"https://github.com/spacetx/starfish/pull/710#discussion_r226489779","pull_request_url":"https://api.github.com/repos/spacetx/starfish/pulls/710","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments/226489779"},"html":{"href":"https://github.com/spacetx/starfish/pull/710#discussion_r226489779"},"pull_request":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/710"}}},"pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/710","id":222929544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTI5NTQ0","html_url":"https://github.com/spacetx/starfish/pull/710","diff_url":"https://github.com/spacetx/starfish/pull/710.diff","patch_url":"https://github.com/spacetx/starfish/pull/710.patch","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/710","number":710,"state":"open","locked":false,"title":"[1/2] Add watershed documentation","user":{"login":"ambrosejcarr","id":5239152,"node_id":"MDQ6VXNlcjUyMzkxNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5239152?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrosejcarr","html_url":"https://github.com/ambrosejcarr","followers_url":"https://api.github.com/users/ambrosejcarr/followers","following_url":"https://api.github.com/users/ambrosejcarr/following{/other_user}","gists_url":"https://api.github.com/users/ambrosejcarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrosejcarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrosejcarr/subscriptions","organizations_url":"https://api.github.com/users/ambrosejcarr/orgs","repos_url":"https://api.github.com/users/ambrosejcarr/repos","events_url":"https://api.github.com/users/ambrosejcarr/events{/privacy}","received_events_url":"https://api.github.com/users/ambrosejcarr/received_events","type":"User","site_admin":false},"body":"This PR adds documentation but does not significantly modify the watershed code. \r\n\r\n@dganguli can you take a look at the comments and verify that what I've written represents what this code should be doing? ","created_at":"2018-10-15T14:36:01Z","updated_at":"2018-10-18T22:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48e980d70e08addce2cfbc282c74395b30c9cb85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetx/starfish/pulls/710/commits","review_comments_url":"https://api.github.com/repos/spacetx/starfish/pulls/710/comments","review_comment_url":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/710/comments","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/f5ea0ca24aecd6e15157bb6a62f59ea24c156f6c","head":{"label":"spacetx:ajc-segmentation-modernization","ref":"ajc-segmentation-modernization","sha":"f5ea0ca24aecd6e15157bb6a62f59ea24c156f6c","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-10-18T19:30:33Z","pushed_at":"2018-10-18T20:23:28Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":69259,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":106,"watchers":51,"default_branch":"master"}},"base":{"label":"spacetx:master","ref":"master","sha":"d526680ccd023fa6662b82f030cbbadeb184f3f7","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"*fish -- a standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-10-18T19:30:33Z","pushed_at":"2018-10-18T20:23:28Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"git@github.com:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":69259,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":106,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/710"},"html":{"href":"https://github.com/spacetx/starfish/pull/710"},"issue":{"href":"https://api.github.com/repos/spacetx/starfish/issues/710"},"comments":{"href":"https://api.github.com/repos/spacetx/starfish/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/spacetx/starfish/statuses/f5ea0ca24aecd6e15157bb6a62f59ea24c156f6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dganguli"}}