{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/1969","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/1969/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/1969/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/1969/events","html_url":"https://github.com/coredns/coredns/pull/1969","id":340670561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDI2NTE5","number":1969,"title":"plugin/metrics - fails to follow metric directive after 2 restarts","user":{"login":"fturib","id":19315664,"node_id":"MDQ6VXNlcjE5MzE1NjY0","avatar_url":"https://avatars1.githubusercontent.com/u/19315664?v=4","gravatar_id":"","url":"https://api.github.com/users/fturib","html_url":"https://github.com/fturib","followers_url":"https://api.github.com/users/fturib/followers","following_url":"https://api.github.com/users/fturib/following{/other_user}","gists_url":"https://api.github.com/users/fturib/gists{/gist_id}","starred_url":"https://api.github.com/users/fturib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fturib/subscriptions","organizations_url":"https://api.github.com/users/fturib/orgs","repos_url":"https://api.github.com/users/fturib/repos","events_url":"https://api.github.com/users/fturib/events{/privacy}","received_events_url":"https://api.github.com/users/fturib/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-12T14:46:49Z","updated_at":"2018-07-19T22:52:04Z","closed_at":"2018-07-19T22:52:04Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/1969","html_url":"https://github.com/coredns/coredns/pull/1969","diff_url":"https://github.com/coredns/coredns/pull/1969.diff","patch_url":"https://github.com/coredns/coredns/pull/1969.patch"},"body":"<!--\r\nThank you for contributing to CoreDNS!\r\nPlease provide the following information to help us make the most of your pull request:\r\n-->\r\n\r\n### 1. Why is this pull request needed and what does it do?\r\nInitial problem is:\r\nPlugin metrics fail to follow metric directive after 2 restarts\r\n\r\nis fixed by modifying the interaction with uniqAddr = Unset the usage of Addr when shutdown the listener. It ensures the new metrics setup will initialize - if needed - a new uniqAddr *with its own OnStart function*\r\n\r\nNOTE: In order to show the failing point, I created a test in \"test_reload\". \r\nHowever I found that the service metrics was still running after listener is down (???), unless we stop the HTTP Server with Shutdown instead of Close.\r\nI added this change in the code to have a proper closing.\r\n\r\n### 2. Which issues (if any) are related?\r\n#1982\r\n\r\n\r\n### 3. Which documentation changes (if any) need to be made?\r\nI do not think it needs. only fix or tuning."},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/406438232","html_url":"https://github.com/coredns/coredns/pull/1969#issuecomment-406438232","issue_url":"https://api.github.com/repos/coredns/coredns/issues/1969","id":406438232,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjQzODIzMg==","user":{"login":"fturib","id":19315664,"node_id":"MDQ6VXNlcjE5MzE1NjY0","avatar_url":"https://avatars1.githubusercontent.com/u/19315664?v=4","gravatar_id":"","url":"https://api.github.com/users/fturib","html_url":"https://github.com/fturib","followers_url":"https://api.github.com/users/fturib/followers","following_url":"https://api.github.com/users/fturib/following{/other_user}","gists_url":"https://api.github.com/users/fturib/gists{/gist_id}","starred_url":"https://api.github.com/users/fturib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fturib/subscriptions","organizations_url":"https://api.github.com/users/fturib/orgs","repos_url":"https://api.github.com/users/fturib/repos","events_url":"https://api.github.com/users/fturib/events{/privacy}","received_events_url":"https://api.github.com/users/fturib/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T22:52:04Z","updated_at":"2018-07-19T22:52:04Z","author_association":"MEMBER","body":"The active part of this PR is superseded by #1983.\r\nThis one become useless."}}
{"actor":{"display_login":"fturib"}}