{"action":"created","comment":{"url":"https://api.github.com/repos/secdev/scapy/pulls/comments/189357107","pull_request_review_id":121527530,"id":189357107,"diff_hunk":"@@ -67,8 +75,8 @@ def getmacbyip(ip, chainCC=0):\n     tmp = [orb(e) for e in inet_aton(ip)]\n     if (tmp[0] & 0xf0) == 0xe0:  # mcast @\n         return \"01:00:5e:%.2x:%.2x:%.2x\" % (tmp[1] & 0x7f, tmp[2], tmp[3])\n-    iff, a, gw = conf.route.route(ip)\n-    if ((iff == scapy.consts.LOOPBACK_INTERFACE) or (ip == conf.route.get_if_bcast(iff))):\n+    iff, _, gw = conf.route.route(ip)\n+    if ((iff == LOOPBACK_INTERFACE) or (ip == conf.route.get_if_bcast(iff))):","path":"scapy/layers/l2.py","position":46,"original_position":46,"commit_id":"1c4063899c1fa801d64d5c280f056a2c62b8fefc","original_commit_id":"1c4063899c1fa801d64d5c280f056a2c62b8fefc","user":{"login":"p-l-","id":5064814,"avatar_url":"https://avatars3.githubusercontent.com/u/5064814?v=4","gravatar_id":"","url":"https://api.github.com/users/p-l-","html_url":"https://github.com/p-l-","followers_url":"https://api.github.com/users/p-l-/followers","following_url":"https://api.github.com/users/p-l-/following{/other_user}","gists_url":"https://api.github.com/users/p-l-/gists{/gist_id}","starred_url":"https://api.github.com/users/p-l-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-l-/subscriptions","organizations_url":"https://api.github.com/users/p-l-/orgs","repos_url":"https://api.github.com/users/p-l-/repos","events_url":"https://api.github.com/users/p-l-/events{/privacy}","received_events_url":"https://api.github.com/users/p-l-/received_events","type":"User","site_admin":false},"body":"OK, thanks for this.","created_at":"2018-05-18T18:31:56Z","updated_at":"2018-05-18T18:31:56Z","html_url":"https://github.com/secdev/scapy/pull/1438#discussion_r189357107","pull_request_url":"https://api.github.com/repos/secdev/scapy/pulls/1438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments/189357107"},"html":{"href":"https://github.com/secdev/scapy/pull/1438#discussion_r189357107"},"pull_request":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1438"}},"in_reply_to_id":189348188},"pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/1438","id":189019264,"html_url":"https://github.com/secdev/scapy/pull/1438","diff_url":"https://github.com/secdev/scapy/pull/1438.diff","patch_url":"https://github.com/secdev/scapy/pull/1438.patch","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1438","number":1438,"state":"open","locked":false,"title":"Add arpleak() to test ARP leak flaws","user":{"login":"p-l-","id":5064814,"avatar_url":"https://avatars3.githubusercontent.com/u/5064814?v=4","gravatar_id":"","url":"https://api.github.com/users/p-l-","html_url":"https://github.com/p-l-","followers_url":"https://api.github.com/users/p-l-/followers","following_url":"https://api.github.com/users/p-l-/following{/other_user}","gists_url":"https://api.github.com/users/p-l-/gists{/gist_id}","starred_url":"https://api.github.com/users/p-l-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-l-/subscriptions","organizations_url":"https://api.github.com/users/p-l-/orgs","repos_url":"https://api.github.com/users/p-l-/repos","events_url":"https://api.github.com/users/p-l-/events{/privacy}","received_events_url":"https://api.github.com/users/p-l-/received_events","type":"User","site_admin":false},"body":"This PR also cleans `ARP.answers()`, and uses `ARP.hashret()` to improve the performances.\r\n\r\nThe tests for `arpleak()` are mocked, using a basic `struct`-based implementation of the ARP protocol, independent from the `ARP` class.\r\n\r\n`arpleak()` has been successfully tested with a VM running the NetBSD 7.0.2 installation ISO.\r\n\r\nAgain, some imports had to be fixed...","created_at":"2018-05-18T13:01:55Z","updated_at":"2018-05-18T18:31:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9ff7e0901a0bd75fff82fe94e1e92a6f2a4c1c","assignee":{"login":"guedou","id":11683796,"avatar_url":"https://avatars1.githubusercontent.com/u/11683796?v=4","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false},"assignees":[{"login":"guedou","id":11683796,"avatar_url":"https://avatars1.githubusercontent.com/u/11683796?v=4","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":267691054,"url":"https://api.github.com/repos/secdev/scapy/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/secdev/scapy/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/secdev/scapy/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1438/comments","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/1c4063899c1fa801d64d5c280f056a2c62b8fefc","head":{"label":"p-l-:arpleak","ref":"arpleak","sha":"1c4063899c1fa801d64d5c280f056a2c62b8fefc","user":{"login":"p-l-","id":5064814,"avatar_url":"https://avatars3.githubusercontent.com/u/5064814?v=4","gravatar_id":"","url":"https://api.github.com/users/p-l-","html_url":"https://github.com/p-l-","followers_url":"https://api.github.com/users/p-l-/followers","following_url":"https://api.github.com/users/p-l-/following{/other_user}","gists_url":"https://api.github.com/users/p-l-/gists{/gist_id}","starred_url":"https://api.github.com/users/p-l-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-l-/subscriptions","organizations_url":"https://api.github.com/users/p-l-/orgs","repos_url":"https://api.github.com/users/p-l-/repos","events_url":"https://api.github.com/users/p-l-/events{/privacy}","received_events_url":"https://api.github.com/users/p-l-/received_events","type":"User","site_admin":false},"repo":{"id":49491409,"name":"scapy","full_name":"p-l-/scapy","owner":{"login":"p-l-","id":5064814,"avatar_url":"https://avatars3.githubusercontent.com/u/5064814?v=4","gravatar_id":"","url":"https://api.github.com/users/p-l-","html_url":"https://github.com/p-l-","followers_url":"https://api.github.com/users/p-l-/followers","following_url":"https://api.github.com/users/p-l-/following{/other_user}","gists_url":"https://api.github.com/users/p-l-/gists{/gist_id}","starred_url":"https://api.github.com/users/p-l-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-l-/subscriptions","organizations_url":"https://api.github.com/users/p-l-/orgs","repos_url":"https://api.github.com/users/p-l-/repos","events_url":"https://api.github.com/users/p-l-/events{/privacy}","received_events_url":"https://api.github.com/users/p-l-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/p-l-/scapy","description":"Python-based interactive packet manipulation program & library","fork":true,"url":"https://api.github.com/repos/p-l-/scapy","forks_url":"https://api.github.com/repos/p-l-/scapy/forks","keys_url":"https://api.github.com/repos/p-l-/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p-l-/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p-l-/scapy/teams","hooks_url":"https://api.github.com/repos/p-l-/scapy/hooks","issue_events_url":"https://api.github.com/repos/p-l-/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/p-l-/scapy/events","assignees_url":"https://api.github.com/repos/p-l-/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/p-l-/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/p-l-/scapy/tags","blobs_url":"https://api.github.com/repos/p-l-/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p-l-/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p-l-/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/p-l-/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p-l-/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/p-l-/scapy/languages","stargazers_url":"https://api.github.com/repos/p-l-/scapy/stargazers","contributors_url":"https://api.github.com/repos/p-l-/scapy/contributors","subscribers_url":"https://api.github.com/repos/p-l-/scapy/subscribers","subscription_url":"https://api.github.com/repos/p-l-/scapy/subscription","commits_url":"https://api.github.com/repos/p-l-/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/p-l-/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/p-l-/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/p-l-/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/p-l-/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/p-l-/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p-l-/scapy/merges","archive_url":"https://api.github.com/repos/p-l-/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p-l-/scapy/downloads","issues_url":"https://api.github.com/repos/p-l-/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/p-l-/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/p-l-/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/p-l-/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p-l-/scapy/labels{/name}","releases_url":"https://api.github.com/repos/p-l-/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/p-l-/scapy/deployments","created_at":"2016-01-12T10:03:31Z","updated_at":"2016-11-16T15:21:33Z","pushed_at":"2018-05-18T12:42:29Z","git_url":"git://github.com/p-l-/scapy.git","ssh_url":"git@github.com:p-l-/scapy.git","clone_url":"https://github.com/p-l-/scapy.git","svn_url":"https://github.com/p-l-/scapy","homepage":"http://www.secdev.org/projects/scapy/","size":71444,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"secdev:master","ref":"master","sha":"187455171fd2fa21d164bacb8d16af56736b5c07","user":{"login":"secdev","id":14927208,"avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"repo":{"id":43509302,"name":"scapy","full_name":"secdev/scapy","owner":{"login":"secdev","id":14927208,"avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/secdev/scapy","description":"Scapy: the Python-based interactive packet manipulation program & library. Supports Python 2 & Python 3.","fork":false,"url":"https://api.github.com/repos/secdev/scapy","forks_url":"https://api.github.com/repos/secdev/scapy/forks","keys_url":"https://api.github.com/repos/secdev/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/secdev/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/secdev/scapy/teams","hooks_url":"https://api.github.com/repos/secdev/scapy/hooks","issue_events_url":"https://api.github.com/repos/secdev/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/secdev/scapy/events","assignees_url":"https://api.github.com/repos/secdev/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/secdev/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/secdev/scapy/tags","blobs_url":"https://api.github.com/repos/secdev/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/secdev/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/secdev/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/secdev/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/secdev/scapy/languages","stargazers_url":"https://api.github.com/repos/secdev/scapy/stargazers","contributors_url":"https://api.github.com/repos/secdev/scapy/contributors","subscribers_url":"https://api.github.com/repos/secdev/scapy/subscribers","subscription_url":"https://api.github.com/repos/secdev/scapy/subscription","commits_url":"https://api.github.com/repos/secdev/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/secdev/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/secdev/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/secdev/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/secdev/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/secdev/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/secdev/scapy/merges","archive_url":"https://api.github.com/repos/secdev/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/secdev/scapy/downloads","issues_url":"https://api.github.com/repos/secdev/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/secdev/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/secdev/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/secdev/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/secdev/scapy/labels{/name}","releases_url":"https://api.github.com/repos/secdev/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/secdev/scapy/deployments","created_at":"2015-10-01T17:06:46Z","updated_at":"2018-05-18T17:33:04Z","pushed_at":"2018-05-18T17:33:00Z","git_url":"git://github.com/secdev/scapy.git","ssh_url":"git@github.com:secdev/scapy.git","clone_url":"https://github.com/secdev/scapy.git","svn_url":"https://github.com/secdev/scapy","homepage":"https://scapy.net","size":71484,"stargazers_count":2518,"watchers_count":2518,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":589,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":589,"open_issues":40,"watchers":2518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1438"},"html":{"href":"https://github.com/secdev/scapy/pull/1438"},"issue":{"href":"https://api.github.com/repos/secdev/scapy/issues/1438"},"comments":{"href":"https://api.github.com/repos/secdev/scapy/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/secdev/scapy/statuses/1c4063899c1fa801d64d5c280f056a2c62b8fefc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"p-l-"}}