{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/ditto/issues/197","repository_url":"https://api.github.com/repos/NREL/ditto","labels_url":"https://api.github.com/repos/NREL/ditto/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/NREL/ditto/issues/197/comments","events_url":"https://api.github.com/repos/NREL/ditto/issues/197/events","html_url":"https://github.com/NREL/ditto/pull/197","id":369854879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjg0OTc5","number":197,"title":"Synergi reader length unit parser","user":{"login":"etimberg","id":6757853,"node_id":"MDQ6VXNlcjY3NTc4NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6757853?v=4","gravatar_id":"","url":"https://api.github.com/users/etimberg","html_url":"https://github.com/etimberg","followers_url":"https://api.github.com/users/etimberg/followers","following_url":"https://api.github.com/users/etimberg/following{/other_user}","gists_url":"https://api.github.com/users/etimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/etimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etimberg/subscriptions","organizations_url":"https://api.github.com/users/etimberg/orgs","repos_url":"https://api.github.com/users/etimberg/repos","events_url":"https://api.github.com/users/etimberg/events{/privacy}","received_events_url":"https://api.github.com/users/etimberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-14T00:33:45Z","updated_at":"2018-10-14T00:43:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NREL/ditto/pulls/197","html_url":"https://github.com/NREL/ditto/pull/197","diff_url":"https://github.com/NREL/ditto/pull/197.diff","patch_url":"https://github.com/NREL/ditto/pull/197.patch"},"body":"This was an idea I had based on the discussion in #158 regarding units. I created a separate function that handles unit conversions for Synergi values based on the type (short unit, medium unit, long unit, and per long unit) and the length units from the Synergi DB (`'English2'`, `'English1'`, and `'Metric'`).\r\n\r\nI added some tests to cover this convert function. For English1, since the units of SUL and MUL are unknown, I assumed they were the same as English2.\r\n\r\nI also converted the Synergi reader to use this new convert function which removes some of the hard coded constants that assumed `'English2'` units. I would wait to merge this until after the Synergi reader has some tests to be more confident in how it works. "},"comment":{"url":"https://api.github.com/repos/NREL/ditto/issues/comments/429586939","html_url":"https://github.com/NREL/ditto/pull/197#issuecomment-429586939","issue_url":"https://api.github.com/repos/NREL/ditto/issues/197","id":429586939,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTU4NjkzOQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T00:43:12Z","updated_at":"2018-10-14T00:43:12Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=h1) Report\n> Merging [#197](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=desc) into [master](https://codecov.io/gh/NREL/ditto/commit/55cde8a894ebe94c1bf0692ca710ab00ab5682fe?src=pr&el=desc) will **increase** coverage by `0.31%`.\n> The diff coverage is `45.94%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/NREL/ditto/pull/197/graphs/tree.svg?width=650&token=ylEtQqCP1n&height=150&src=pr)](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #197      +/-   ##\n==========================================\n+ Coverage   43.26%   43.58%   +0.31%     \n==========================================\n  Files          74       75       +1     \n  Lines       17027    17038      +11     \n==========================================\n+ Hits         7367     7426      +59     \n+ Misses       9660     9612      -48\n```\n\n\n| [Impacted Files](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [ditto/readers/synergi/length\\_units.py](https://codecov.io/gh/NREL/ditto/pull/197/diff?src=pr&el=tree#diff-ZGl0dG8vcmVhZGVycy9zeW5lcmdpL2xlbmd0aF91bml0cy5weQ==) | `100% <100%> (ø)` | |\n| [ditto/readers/synergi/read.py](https://codecov.io/gh/NREL/ditto/pull/197/diff?src=pr&el=tree#diff-ZGl0dG8vcmVhZGVycy9zeW5lcmdpL3JlYWQucHk=) | `4.88% <4.76%> (+4.88%)` | :arrow_up: |\n| [ditto/readers/synergi/db\\_parser.py](https://codecov.io/gh/NREL/ditto/pull/197/diff?src=pr&el=tree#diff-ZGl0dG8vcmVhZGVycy9zeW5lcmdpL2RiX3BhcnNlci5weQ==) | `26.08% <0%> (+26.08%)` | :arrow_up: |\n| [ditto/readers/synergi/\\_\\_init\\_\\_.py](https://codecov.io/gh/NREL/ditto/pull/197/diff?src=pr&el=tree#diff-ZGl0dG8vcmVhZGVycy9zeW5lcmdpL19faW5pdF9fLnB5) | `100% <0%> (+100%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=footer). Last update [55cde8a...deace6e](https://codecov.io/gh/NREL/ditto/pull/197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}