{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/180273820","pull_request_review_id":110666244,"id":180273820,"diff_hunk":"@@ -16,7 +16,7 @@ import {\n     DOMAttributes, DOMElement, ReactNode, ReactPortal\n } from 'react';\n \n-export function findDOMNode(instance: ReactInstance): Element;\n+export function findDOMNode(instance: ReactInstance): Element | null | Text;","path":"types/react-dom/index.d.ts","position":5,"original_position":5,"commit_id":"9189726c13f02dc27ccdfb91cf2d0d34252cfd58","original_commit_id":"9189726c13f02dc27ccdfb91cf2d0d34252cfd58","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars1.githubusercontent.com/u/73085?v=4","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"body":"Scratch all of the above; that's just the codesandbox console not printing the `@@toStringTag` or constructor name for instances. That's no ordinary object, it's an instance of the `Text` DOM constructor.","created_at":"2018-04-10T01:16:51Z","updated_at":"2018-04-10T01:16:51Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211#discussion_r180273820","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/180273820"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211#discussion_r180273820"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211"}},"in_reply_to_id":180189088},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211","id":174183814,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24211","number":24211,"state":"open","locked":false,"title":"[react-dom] fix signature of findDOMNode","user":{"login":"Pajn","id":817422,"avatar_url":"https://avatars1.githubusercontent.com/u/817422?v=4","gravatar_id":"","url":"https://api.github.com/users/Pajn","html_url":"https://github.com/Pajn","followers_url":"https://api.github.com/users/Pajn/followers","following_url":"https://api.github.com/users/Pajn/following{/other_user}","gists_url":"https://api.github.com/users/Pajn/gists{/gist_id}","starred_url":"https://api.github.com/users/Pajn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pajn/subscriptions","organizations_url":"https://api.github.com/users/Pajn/orgs","repos_url":"https://api.github.com/users/Pajn/repos","events_url":"https://api.github.com/users/Pajn/events{/privacy}","received_events_url":"https://api.github.com/users/Pajn/received_events","type":"User","site_admin":false},"body":"fixes #24167\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/24167\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-03-10T18:49:09Z","updated_at":"2018-04-10T01:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5355c8a958a27f5c45fdf089887489444b7fff6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johnnyreilly","id":1010525,"avatar_url":"https://avatars0.githubusercontent.com/u/1010525?v=4","gravatar_id":"","url":"https://api.github.com/users/johnnyreilly","html_url":"https://github.com/johnnyreilly","followers_url":"https://api.github.com/users/johnnyreilly/followers","following_url":"https://api.github.com/users/johnnyreilly/following{/other_user}","gists_url":"https://api.github.com/users/johnnyreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnyreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnyreilly/subscriptions","organizations_url":"https://api.github.com/users/johnnyreilly/orgs","repos_url":"https://api.github.com/users/johnnyreilly/repos","events_url":"https://api.github.com/users/johnnyreilly/events{/privacy}","received_events_url":"https://api.github.com/users/johnnyreilly/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":684321576,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24211/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/9189726c13f02dc27ccdfb91cf2d0d34252cfd58","head":{"label":"Pajn:findDOMNode","ref":"findDOMNode","sha":"9189726c13f02dc27ccdfb91cf2d0d34252cfd58","user":{"login":"Pajn","id":817422,"avatar_url":"https://avatars1.githubusercontent.com/u/817422?v=4","gravatar_id":"","url":"https://api.github.com/users/Pajn","html_url":"https://github.com/Pajn","followers_url":"https://api.github.com/users/Pajn/followers","following_url":"https://api.github.com/users/Pajn/following{/other_user}","gists_url":"https://api.github.com/users/Pajn/gists{/gist_id}","starred_url":"https://api.github.com/users/Pajn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pajn/subscriptions","organizations_url":"https://api.github.com/users/Pajn/orgs","repos_url":"https://api.github.com/users/Pajn/repos","events_url":"https://api.github.com/users/Pajn/events{/privacy}","received_events_url":"https://api.github.com/users/Pajn/received_events","type":"User","site_admin":false},"repo":{"id":96409903,"name":"DefinitelyTyped","full_name":"Pajn/DefinitelyTyped","owner":{"login":"Pajn","id":817422,"avatar_url":"https://avatars1.githubusercontent.com/u/817422?v=4","gravatar_id":"","url":"https://api.github.com/users/Pajn","html_url":"https://github.com/Pajn","followers_url":"https://api.github.com/users/Pajn/followers","following_url":"https://api.github.com/users/Pajn/following{/other_user}","gists_url":"https://api.github.com/users/Pajn/gists{/gist_id}","starred_url":"https://api.github.com/users/Pajn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pajn/subscriptions","organizations_url":"https://api.github.com/users/Pajn/orgs","repos_url":"https://api.github.com/users/Pajn/repos","events_url":"https://api.github.com/users/Pajn/events{/privacy}","received_events_url":"https://api.github.com/users/Pajn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pajn/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/Pajn/DefinitelyTyped","forks_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/Pajn/DefinitelyTyped/deployments","created_at":"2017-07-06T08:57:43Z","updated_at":"2017-07-06T08:58:01Z","pushed_at":"2018-04-06T14:53:11Z","git_url":"git://github.com/Pajn/DefinitelyTyped.git","ssh_url":"git@github.com:Pajn/DefinitelyTyped.git","clone_url":"https://github.com/Pajn/DefinitelyTyped.git","svn_url":"https://github.com/Pajn/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":310325,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"420decfd831852b29962dba1db848a2166b64230","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-04-09T23:32:04Z","pushed_at":"2018-04-09T23:40:23Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":311487,"stargazers_count":15018,"watchers_count":15018,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12491,"mirror_url":null,"archived":false,"open_issues_count":2030,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12491,"open_issues":2030,"watchers":15018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24211"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24211"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24211/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24211/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/9189726c13f02dc27ccdfb91cf2d0d34252cfd58"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Kovensky"}}