{"push_id":2550423650,"size":20,"distinct_size":20,"ref":"refs/heads/master","head":"911c2e7953f062769a273865634f97ceeca72378","before":"eabe471ce896ac80e87cb176241c4e927aa03961","commits":[{"sha":"c93b56034d5c580df6699b602d9fbc440bbebf3d","author":{"name":"Nadav Har'El","email":"625169824b719df98706d88646d0aae6f368ae4d@scylladb.com"},"message":"tests: improve usability of cql_assertions.hh error messages\n\nThe functions in cql_assertions.hh are very convenient, but have one\nfrustrating drawback: When you have many of those assertions in one\ntest, it's very hard to know *which* of the similar assertions failed.\n\nThe problem is that an error often looks like this:\n\nunknown location(0): fatal error: in \"test_many_columns\":\nstd::runtime_error: Expected 2 row(s) but got 0\ntests/cql_assertions.cc(131): last checkpoint\n\nWhich of the many similar checks in \"test_many_columns\" failed? Note the\nunhelpful \"unknown location\" and also the \"last checkpoint\" points to code\nin cql_assertions.cc, not in the actual test, so it is useless.\n\nThe root cause of these problems is that the Boost macros use the C\npreprocessor __FILE__ and __LINE__, which in actual C++ functions like\nis_rows() remembers its location, instead of the caller. Fixing this will\nnot be simple. But this patch has a much simpler solution - fixing the\n\"last checkpoint\". What ruins the last checkpoint is the use of BOOST_REQUIRE\ninside the cql_assertions.cc is_rows() - when that succeeds, it records\nthe location inside cql_assertions.cc (!) as the last success.\n\nIf we just replace BOOST_REQUIRE by our own test (just like in the rest of\nthe cql_assertions.cc code), this code will not override the last checkpoint.\nThe user can see the last real successful BOOST_REQUIRE, or use\nBOOST_TEST_PASSPOINT() to set his own checkpoints between different parts of\nthe same test.\n\nAfter this patch, and with adding BOOST_TEST_PASSPOINT() calls between\ndifferent parts of my test, the failure above now looks like:\n\nunknown location(0): fatal error: in \"test_many_columns\":\nstd::runtime_error: Expected 2 row(s) but got 0\ntests/secondary_index_test.cc(299): last checkpoint\n\nThe \"last checkpoint\" now shows me exactly where my failing check was.\n\nSigned-off-by: Nadav Har'El <nyh@scylladb.com>\nMessage-Id: <20180501152638.26238-1-nyh@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/c93b56034d5c580df6699b602d9fbc440bbebf3d"},{"sha":"2be75bdfc91d74e4f18ef015c2814471fa702194","author":{"name":"Duarte Nunes","email":"a60e8b7496f7715d71354fe4c06dd24017025bf1@scylladb.com"},"message":"db/timeout_clock: Properly scope type names\n\nSigned-off-by: Duarte Nunes <duarte@scylladb.com>\nMessage-Id: <20180426134457.21290-1-duarte@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/2be75bdfc91d74e4f18ef015c2814471fa702194"},{"sha":"4b3562c3f5f5963b79148e5711fa45cc8ddf8cb7","author":{"name":"Duarte Nunes","email":"a60e8b7496f7715d71354fe4c06dd24017025bf1@scylladb.com"},"message":"db/view: Limit number of pending view updates\n\nThis patch adds a simple and naive mechanism to ensure a base replica\ndoesn't overwhelm a potentially overloaded view replica by sending too\nmany concurrent view updates. We add a semaphore to limit to 100 the\nnumber of outstanding view updates. We limit globally per shard, and\nnot per destination view replica. We also limit statically.\n\nRefs #2538\n\nSigned-off-by: Duarte Nunes <duarte@scylladb.com>\nMessage-Id: <20180426134457.21290-2-duarte@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/4b3562c3f5f5963b79148e5711fa45cc8ddf8cb7"},{"sha":"368e15a8e29532fb1045a7609bb88b5b5092a1a5","author":{"name":"Avi Kivity","email":"8f920f22884d6fea9df883843c4a8095a2e5ac6f@scylladb.com"},"message":"Update scylla-ami submodule\n\n* dist/ami/files/scylla-ami 8a6e4dd...e0b35dc (1):\n  > change default roles for EBS / ephemeral","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/368e15a8e29532fb1045a7609bb88b5b5092a1a5"},{"sha":"113294074dd89d2b9c239f4e13c8ebad4f5c2bee","author":{"name":"Duarte Nunes","email":"a60e8b7496f7715d71354fe4c06dd24017025bf1@scylladb.com"},"message":"Merge seastar upstream\n\n* seastar ac02df7...840002c (20):\n  > dpdk: protect against missing statistics\n  > alien: make visible in documentation\n  > Merge \"rewrite iotune to conform to the new ioscheduler\" from Glauber\n  > app_template: Correct outdated comment\n  > apps, tests: Catch polymorphic exceptions by reference\n  > configure.py: Enhance detection for gcc -fvisibility=hidden bug\n  > reactor: add rudimentary task histogram reporting\n  > Revert \"Merge \"rewrite iotune to conform to the new ioscheduler\" from Glauber\"\n  > Merge \"rewrite iotune to conform to the new ioscheduler\" from Glauber\n  > build: Use the same warning name for Clang and GCC\n  > core/rwlock: Add support for timeouts\n  > fs qualification: protect against EINTR\n  > Docker: Fix failing build due to missing GNU make\n  > reactor: move optional to experimental so we compile with c++14\n  > future: remove allocation from future::get() thread context switch\n  > Merge \"rpc streaming\" from Gleb\n  > reactor: put mountpoint_params in seastar namespace\n  > Tutorial: in PDF version of tutorial, better backtick typesetting\n  > tutorial: support, and start using, links to other sections\n  > tutorial: improve second half of semaphores section\n\nSigned-off-by: Duarte Nunes <duarte@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/113294074dd89d2b9c239f4e13c8ebad4f5c2bee"},{"sha":"c053275a480d0c6a5038ae73c16c32dace1042a1","author":{"name":"Duarte Nunes","email":"a60e8b7496f7715d71354fe4c06dd24017025bf1@scylladb.com"},"message":"db/view/row_locking: Add timeout when waiting for the lock\n\nThis ensures we respect the write timeout set by the client when\napplying base writes, in case a writes takes too long to acquire the\nrow lock for the read-before-write phase of a materialized view\nupdate.\n\nSigned-off-by: Duarte Nunes <duarte@scylladb.com>\nMessage-Id: <20180507132755.8751-1-duarte@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/c053275a480d0c6a5038ae73c16c32dace1042a1"},{"sha":"6f7d919470bb163ab895c09b9ee722b37c9e64a5","author":{"name":"Botond Dénes","email":"a584fa4d75a0a85d721f44fb6e06315a2853b0b6@scylladb.com"},"message":"database: when dropping a table evict all relevant queriers\n\nQueriers shouldn't outlive the table they read from as that could lead\nto use-after-free problems when they are destroyed.\n\nFixes: #3414\n\nSigned-off-by: Botond Dénes <bdenes@scylladb.com>\nMessage-Id: <3d7172cef79bb52b7097596e1d4ebba3a6ff757e.1525716986.git.bdenes@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/6f7d919470bb163ab895c09b9ee722b37c9e64a5"},{"sha":"5463b58faa6788cd48372eee2df651d4db039d86","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints::manager: rework end_point_hints_manager::stop() to use seastar::async()\n\nThis simplifies the code reading and extending.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/5463b58faa6788cd48372eee2df651d4db039d86"},{"sha":"8aedbf9d189a28ed04da5d1449323c0941c97707","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints: manager.hh: cleanup: fix the comments\n\nFix the comments that went out of sync with the current implementation.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/8aedbf9d189a28ed04da5d1449323c0941c97707"},{"sha":"94da744f37dc6268d125523cb34c1614adf9d76a","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints::manager::end_point_hints_manager::stop(): log the last exception instead of forwarding it\n\nReturning a future with an exception from end_point_manager::stop()\nis practically useless because the best the caller can do is to log\nit and continue as if it didn't happen because it has other things\nto shut down.\n\nTherefore in order to simplify the caller we will log the exception\nif it happens and will always return a non-exceptional future.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/94da744f37dc6268d125523cb34c1614adf9d76a"},{"sha":"6ede32156fce46ea29e86149f4cb883a5f424d49","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints::manager::end_point_hints_manager::sender: add set_stopping()/stopping() methods\n\nIt's nicer to have access methods instead of working directly with enum_set methods and values.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/6ede32156fce46ea29e86149f4cb883a5f424d49"},{"sha":"ec76f8a27ded8d0d95ea0cc495f1cbec65ac0a6f","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints::manager: add a few more trace messages\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/ec76f8a27ded8d0d95ea0cc495f1cbec65ac0a6f"},{"sha":"48c96d09d640482f47301f30c633c1c45313be83","author":{"name":"Vlad Zolotarov","email":"976c0f8d0852ed6439ad273880b400a75a7c41d0@scylladb.com"},"message":"db::hints::manager: drain hints when the node is decommissioned/removed\n\nWhen node is decommissioned/removed it will drain all its hints and all\nremote nodes that have hints to it will drain their hints to this node.\n\nWhat \"drain\" means? - The node that \"drains\" hints to a specific\ndestination will ignore failures and will continue sending hints till the end\nof the current segment, erase it and move to the next one till there are\nno more segments left.\n\nAfter all hints are drained the corresponding hints directory is removed.\n\nSigned-off-by: Vlad Zolotarov <vladz@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/48c96d09d640482f47301f30c633c1c45313be83"},{"sha":"b2b1a1f7e1b75afb135b3bcacd4be33ce10d57c4","author":{"name":"Calle Wilund","email":"8f9f97eb45ed102f8faf72e01bebf7b2c1679978@scylladb.com"},"message":"database: Fix assert in truncate\n\nFixes crash in cql_tests.StorageProxyCQLTester.table_test\n\"avoid race condition when deleting sstable on behalf...\" changed\ndiscard_sstables behaviour to only return rp:s for sstables owned\nand submitted for deletion (not all matching time stamp),\nwhich can in some cases cause zero rp returned.\nMessage-Id: <20180508070003.1110-1-calle@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/b2b1a1f7e1b75afb135b3bcacd4be33ce10d57c4"},{"sha":"fe2358e8bd7b1d066d0710222e4ddbba32a75b5a","author":{"name":"Vladimir Krivopalov","email":"dc9186a06078733915a6fcbab34e59120be2b484@scylladb.com"},"message":"Remove unused overload of i_filter::get_filter().\n\nSigned-off-by: Vladimir Krivopalov <vladimir@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/fe2358e8bd7b1d066d0710222e4ddbba32a75b5a"},{"sha":"0f37c0e6848d624b96c3548d176c11b0bdbff3e7","author":{"name":"Vladimir Krivopalov","email":"dc9186a06078733915a6fcbab34e59120be2b484@scylladb.com"},"message":"Support Bloom filter format used in SSTables 3.0.\n\nThe two hash values, base and increment, used to produce indices for\nsetting bits in the filter, have been swapped in SSTables 3.0.\nSee CASSANDRA-8413 for details.\n\nSigned-off-by: Vladimir Krivopalov <vladimir@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/0f37c0e6848d624b96c3548d176c11b0bdbff3e7"},{"sha":"e739bb3280f2505a524bcb5184bbfbff620d3944","author":{"name":"Vladimir Krivopalov","email":"dc9186a06078733915a6fcbab34e59120be2b484@scylladb.com"},"message":"Check Filter.db in SSTables 3.x write tests.\n\nSigned-off-by: Vladimir Krivopalov <vladimir@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/e739bb3280f2505a524bcb5184bbfbff620d3944"},{"sha":"b59549cd161b4addebaaeb304148894d874b29fa","author":{"name":"Vladimir Krivopalov","email":"dc9186a06078733915a6fcbab34e59120be2b484@scylladb.com"},"message":"Fix mistakes and typos in comments (minor clean-up)\n\nSigned-off-by: Vladimir Krivopalov <vladimir@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/b59549cd161b4addebaaeb304148894d874b29fa"},{"sha":"51c8ea74d69cfaffa3f1eaadaf65a024ddcf4a5d","author":{"name":"Vladimir Krivopalov","email":"dc9186a06078733915a6fcbab34e59120be2b484@scylladb.com"},"message":"sstables: generate non-empty summaries for m format\n\nAdd summary entries as needed. Also removes the duplicate line that\nassigned summary byte cost.\n\nSigned-off-by: Vladimir Krivopalov <vladimir@scylladb.com>\nMessage-Id: <0d387c68523bae0c121cb15ad1e651ee9a8e4b4a.1525732404.git.vladimir@scylladb.com>","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/51c8ea74d69cfaffa3f1eaadaf65a024ddcf4a5d"},{"sha":"911c2e7953f062769a273865634f97ceeca72378","author":{"name":"Avi Kivity","email":"8f920f22884d6fea9df883843c4a8095a2e5ac6f@scylladb.com"},"message":"Merge \"Support Bloom filter format for SSTables 3.x.\" from Vladimir\n\n\"\nIn SSTables 3.0, the base and increment fields have been swapped in\nBloom filters to reduce collisions (see CASSANDRA-8413). This affects\nthe resulting values written to Filter.db.\n\nThis patchset adds support for reading/writing Filter.db in the format\ncorresponding to the version of SSTables.\n\nTests: unit {release}\n\nFilter.db files have been generated using Cassandra 3.11 with same data\nas in unit tests and are validated to match those generated by Scylla.\n\"\n\n* 'projects/sstables-30/write-filter/v1-2' of https://github.com/argenet/scylla:\n  Fix mistakes and typos in comments (minor clean-up)\n  Check Filter.db in SSTables 3.x write tests.\n  Support Bloom filter format used in SSTables 3.0.\n  Remove unused overload of i_filter::get_filter().","distinct":true,"url":"https://api.github.com/repos/hakuch/scylla/commits/911c2e7953f062769a273865634f97ceeca72378"}]}
{"actor":{"display_login":"hakuch"}}