{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/omi/issues/519","repository_url":"https://api.github.com/repos/Microsoft/omi","labels_url":"https://api.github.com/repos/Microsoft/omi/issues/519/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/omi/issues/519/comments","events_url":"https://api.github.com/repos/Microsoft/omi/issues/519/events","html_url":"https://github.com/Microsoft/omi/pull/519","id":321445157,"number":519,"title":"Bugfix: 'NoTLSv1_1' and 'NoTLSv1_2' don't work in omiserver.conf file…","user":{"login":"BingyuLiu","id":19498851,"avatar_url":"https://avatars2.githubusercontent.com/u/19498851?v=4","gravatar_id":"","url":"https://api.github.com/users/BingyuLiu","html_url":"https://github.com/BingyuLiu","followers_url":"https://api.github.com/users/BingyuLiu/followers","following_url":"https://api.github.com/users/BingyuLiu/following{/other_user}","gists_url":"https://api.github.com/users/BingyuLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/BingyuLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BingyuLiu/subscriptions","organizations_url":"https://api.github.com/users/BingyuLiu/orgs","repos_url":"https://api.github.com/users/BingyuLiu/repos","events_url":"https://api.github.com/users/BingyuLiu/events{/privacy}","received_events_url":"https://api.github.com/users/BingyuLiu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-09T06:23:23Z","updated_at":"2018-05-09T21:54:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/omi/pulls/519","html_url":"https://github.com/Microsoft/omi/pull/519","diff_url":"https://github.com/Microsoft/omi/pull/519.diff","patch_url":"https://github.com/Microsoft/omi/pull/519.patch"},"body":"- Bugfix: 'NoTLSv1_1' and 'NoTLSv1_2' don't work in omiserver.conf file \r\n- rename improper variables"},"comment":{"url":"https://api.github.com/repos/Microsoft/omi/issues/comments/387887466","html_url":"https://github.com/Microsoft/omi/pull/519#issuecomment-387887466","issue_url":"https://api.github.com/repos/Microsoft/omi/issues/519","id":387887466,"user":{"login":"BingyuLiu","id":19498851,"avatar_url":"https://avatars2.githubusercontent.com/u/19498851?v=4","gravatar_id":"","url":"https://api.github.com/users/BingyuLiu","html_url":"https://github.com/BingyuLiu","followers_url":"https://api.github.com/users/BingyuLiu/followers","following_url":"https://api.github.com/users/BingyuLiu/following{/other_user}","gists_url":"https://api.github.com/users/BingyuLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/BingyuLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BingyuLiu/subscriptions","organizations_url":"https://api.github.com/users/BingyuLiu/orgs","repos_url":"https://api.github.com/users/BingyuLiu/repos","events_url":"https://api.github.com/users/BingyuLiu/events{/privacy}","received_events_url":"https://api.github.com/users/BingyuLiu/received_events","type":"User","site_admin":false},"created_at":"2018-05-09T21:54:55Z","updated_at":"2018-05-09T21:54:55Z","author_association":"MEMBER","body":"@johnkord @palladia \r\nI have tested the code change in Ubuntu16 platform. It works fine.\r\nlike following steps:\r\n\r\n- run \"openssl s_client -tls1_1 -connect localhost:1270\"\r\n- add \"NoTLSv1_1=true\" to omiserver.conf\r\n- restart omiserver\r\n- run \"openssl s_client -tls1_1 -connect localhost:1270\"\r\n\r\n- run \"openssl s_client -tls1_2 -connect localhost:1270\"\r\n- add \"NoTLSv1_2=true\" to omiserver.conf\r\n- restart omiserver\r\n- run \"openssl s_client -tls1_2 -connect localhost:1270\"\r\n\r\nI will ask CTI team to test this code change on other platforms tonight."}}
{"actor":{"display_login":"BingyuLiu"}}