{"action":"created","comment":{"url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/comments/239988142","pull_request_review_id":182926136,"id":239988142,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk4ODE0Mg==","diff_hunk":"@@ -88,4 +86,14 @@ Jessie deliberately does not include:\n * all objects made by literal expressions (object literals, array literals, function literals, etc) must be tamper-proofed with `def` before they can be aliased or escape from their static context of origin\n * no top level mutability\n * restrict index access to number-names, require `+` as a prefix in indices.\n+* disallow naked statements in switch cases\n+\n+## Changelog\n+\n+11-20-2018 \n+* added better error messages\n+* added basic tests for all rules\n+* added a config-tester utility\n+* removed 'strict' as a rule because it does not enforce the strict rules as expected\n+* recognized that 'curly' does not enforce curly braces within switch statements, which Jessie requires. A test for this is commented out. ","path":"README.md","position":26,"original_position":26,"commit_id":"536e49466762d38f7183823ea8e2da3c8634ca97","original_commit_id":"536e49466762d38f7183823ea8e2da3c8634ca97","user":{"login":"erights","id":273868,"node_id":"MDQ6VXNlcjI3Mzg2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/273868?v=4","gravatar_id":"","url":"https://api.github.com/users/erights","html_url":"https://github.com/erights","followers_url":"https://api.github.com/users/erights/followers","following_url":"https://api.github.com/users/erights/following{/other_user}","gists_url":"https://api.github.com/users/erights/gists{/gist_id}","starred_url":"https://api.github.com/users/erights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erights/subscriptions","organizations_url":"https://api.github.com/users/erights/orgs","repos_url":"https://api.github.com/users/erights/repos","events_url":"https://api.github.com/users/erights/events{/privacy}","received_events_url":"https://api.github.com/users/erights/received_events","type":"User","site_admin":false},"body":"line too wide","created_at":"2018-12-08T01:42:26Z","updated_at":"2018-12-08T01:47:40Z","html_url":"https://github.com/Agoric/eslint-config-jessie/pull/4#discussion_r239988142","pull_request_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/comments/239988142"},"html":{"href":"https://github.com/Agoric/eslint-config-jessie/pull/4#discussion_r239988142"},"pull_request":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4","id":233689717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjg5NzE3","html_url":"https://github.com/Agoric/eslint-config-jessie/pull/4","diff_url":"https://github.com/Agoric/eslint-config-jessie/pull/4.diff","patch_url":"https://github.com/Agoric/eslint-config-jessie/pull/4.patch","issue_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/4","number":4,"state":"open","locked":false,"title":"Adds tests for the basic configuration rules","user":{"login":"katelynsills","id":2441069,"node_id":"MDQ6VXNlcjI0NDEwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2441069?v=4","gravatar_id":"","url":"https://api.github.com/users/katelynsills","html_url":"https://github.com/katelynsills","followers_url":"https://api.github.com/users/katelynsills/followers","following_url":"https://api.github.com/users/katelynsills/following{/other_user}","gists_url":"https://api.github.com/users/katelynsills/gists{/gist_id}","starred_url":"https://api.github.com/users/katelynsills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katelynsills/subscriptions","organizations_url":"https://api.github.com/users/katelynsills/orgs","repos_url":"https://api.github.com/users/katelynsills/repos","events_url":"https://api.github.com/users/katelynsills/events{/privacy}","received_events_url":"https://api.github.com/users/katelynsills/received_events","type":"User","site_admin":false},"body":"Changes:\r\n* added better error messages\r\n* added basic tests for all rules\r\n* added a configTester utility (pulled out into another package, called eslint-config-rule-tester)\r\n* removed 'strict' as a rule because it does not enforce the strict rules as expected\r\n* recognized that 'curly' does not enforce curly braces within switch statements, which Jessie requires. A test for this is commented out. ","created_at":"2018-11-26T20:40:51Z","updated_at":"2018-12-08T01:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0cb11e04b94bb52d7c7886adb370e2138214565","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/4/comments","statuses_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/statuses/536e49466762d38f7183823ea8e2da3c8634ca97","head":{"label":"Agoric:add-tests","ref":"add-tests","sha":"536e49466762d38f7183823ea8e2da3c8634ca97","user":{"login":"Agoric","id":26842028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/26842028?v=4","gravatar_id":"","url":"https://api.github.com/users/Agoric","html_url":"https://github.com/Agoric","followers_url":"https://api.github.com/users/Agoric/followers","following_url":"https://api.github.com/users/Agoric/following{/other_user}","gists_url":"https://api.github.com/users/Agoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Agoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agoric/subscriptions","organizations_url":"https://api.github.com/users/Agoric/orgs","repos_url":"https://api.github.com/users/Agoric/repos","events_url":"https://api.github.com/users/Agoric/events{/privacy}","received_events_url":"https://api.github.com/users/Agoric/received_events","type":"Organization","site_admin":false},"repo":{"id":155905950,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MDU5NTA=","name":"eslint-config-jessie","full_name":"Agoric/eslint-config-jessie","private":false,"owner":{"login":"Agoric","id":26842028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/26842028?v=4","gravatar_id":"","url":"https://api.github.com/users/Agoric","html_url":"https://github.com/Agoric","followers_url":"https://api.github.com/users/Agoric/followers","following_url":"https://api.github.com/users/Agoric/following{/other_user}","gists_url":"https://api.github.com/users/Agoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Agoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agoric/subscriptions","organizations_url":"https://api.github.com/users/Agoric/orgs","repos_url":"https://api.github.com/users/Agoric/repos","events_url":"https://api.github.com/users/Agoric/events{/privacy}","received_events_url":"https://api.github.com/users/Agoric/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Agoric/eslint-config-jessie","description":"A shareable config for the Jessie subset of JavaScript","fork":false,"url":"https://api.github.com/repos/Agoric/eslint-config-jessie","forks_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/forks","keys_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/teams","hooks_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/hooks","issue_events_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/events{/number}","events_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/events","assignees_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/assignees{/user}","branches_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/branches{/branch}","tags_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/tags","blobs_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/statuses/{sha}","languages_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/languages","stargazers_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/stargazers","contributors_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/contributors","subscribers_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/subscribers","subscription_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/subscription","commits_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/contents/{+path}","compare_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/merges","archive_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/downloads","issues_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues{/number}","pulls_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls{/number}","milestones_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/milestones{/number}","notifications_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/labels{/name}","releases_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/releases{/id}","deployments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/deployments","created_at":"2018-11-02T18:22:38Z","updated_at":"2018-12-08T01:32:37Z","pushed_at":"2018-12-08T01:32:35Z","git_url":"git://github.com/Agoric/eslint-config-jessie.git","ssh_url":"git@github.com:Agoric/eslint-config-jessie.git","clone_url":"https://github.com/Agoric/eslint-config-jessie.git","svn_url":"https://github.com/Agoric/eslint-config-jessie","homepage":null,"size":34,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"Agoric:master","ref":"master","sha":"533b100b613b504094e8d61e970b3218e1bf9dd8","user":{"login":"Agoric","id":26842028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/26842028?v=4","gravatar_id":"","url":"https://api.github.com/users/Agoric","html_url":"https://github.com/Agoric","followers_url":"https://api.github.com/users/Agoric/followers","following_url":"https://api.github.com/users/Agoric/following{/other_user}","gists_url":"https://api.github.com/users/Agoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Agoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agoric/subscriptions","organizations_url":"https://api.github.com/users/Agoric/orgs","repos_url":"https://api.github.com/users/Agoric/repos","events_url":"https://api.github.com/users/Agoric/events{/privacy}","received_events_url":"https://api.github.com/users/Agoric/received_events","type":"Organization","site_admin":false},"repo":{"id":155905950,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MDU5NTA=","name":"eslint-config-jessie","full_name":"Agoric/eslint-config-jessie","private":false,"owner":{"login":"Agoric","id":26842028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODQyMDI4","avatar_url":"https://avatars3.githubusercontent.com/u/26842028?v=4","gravatar_id":"","url":"https://api.github.com/users/Agoric","html_url":"https://github.com/Agoric","followers_url":"https://api.github.com/users/Agoric/followers","following_url":"https://api.github.com/users/Agoric/following{/other_user}","gists_url":"https://api.github.com/users/Agoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Agoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agoric/subscriptions","organizations_url":"https://api.github.com/users/Agoric/orgs","repos_url":"https://api.github.com/users/Agoric/repos","events_url":"https://api.github.com/users/Agoric/events{/privacy}","received_events_url":"https://api.github.com/users/Agoric/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Agoric/eslint-config-jessie","description":"A shareable config for the Jessie subset of JavaScript","fork":false,"url":"https://api.github.com/repos/Agoric/eslint-config-jessie","forks_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/forks","keys_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/teams","hooks_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/hooks","issue_events_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/events{/number}","events_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/events","assignees_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/assignees{/user}","branches_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/branches{/branch}","tags_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/tags","blobs_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/statuses/{sha}","languages_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/languages","stargazers_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/stargazers","contributors_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/contributors","subscribers_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/subscribers","subscription_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/subscription","commits_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/contents/{+path}","compare_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/merges","archive_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/downloads","issues_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues{/number}","pulls_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls{/number}","milestones_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/milestones{/number}","notifications_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/labels{/name}","releases_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/releases{/id}","deployments_url":"https://api.github.com/repos/Agoric/eslint-config-jessie/deployments","created_at":"2018-11-02T18:22:38Z","updated_at":"2018-12-08T01:32:37Z","pushed_at":"2018-12-08T01:32:35Z","git_url":"git://github.com/Agoric/eslint-config-jessie.git","ssh_url":"git@github.com:Agoric/eslint-config-jessie.git","clone_url":"https://github.com/Agoric/eslint-config-jessie.git","svn_url":"https://github.com/Agoric/eslint-config-jessie","homepage":null,"size":34,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4"},"html":{"href":"https://github.com/Agoric/eslint-config-jessie/pull/4"},"issue":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/4"},"comments":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Agoric/eslint-config-jessie/statuses/536e49466762d38f7183823ea8e2da3c8634ca97"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"erights"}}