{"push_id":2324710569,"size":5,"distinct_size":1,"ref":"refs/heads/openssl_ciphers_s","head":"068cd6f2f9604cb3093fc5b9089d473e2e5ee25b","before":"9bf30177dfe454975668363e2f637aeb80334c5a","commits":[{"sha":"f4918c8fd369403b02d96d1004e72c2283e317d4","author":{"name":"Dirk","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"further address #986\n\nError codes now done until run_server_defaults(). Previous\nsections modified so that execution errors are added.\n\nModified in compare_server_name_to_cert() ret --> subret.\nFrom the code perspective a clear distinction between\npassing an error code and a functional return code\nwould be great. Still has to be determined whether it\nmaybe better to rename ret into something different.\n\nRemoved a stale code line in run_server_preference() for STARTTLS.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/f4918c8fd369403b02d96d1004e72c2283e317d4"},{"sha":"5862a9031943ceecff94c7ab8610ba00b7292be2","author":{"name":"Dirk","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"mind certificate_info() result from previous commit","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/5862a9031943ceecff94c7ab8610ba00b7292be2"},{"sha":"619dabdb38b431c7611165e0edbe978b7fb4c108","author":{"name":"Dirk","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"fix borken case statement, ((ret++) doesn't seem to work","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/619dabdb38b431c7611165e0edbe978b7fb4c108"},{"sha":"fb844e851067ee76feccaf9f9603ec82675a051e","author":{"name":"Dirk","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"address #986 for do_header() + some code housekeeping","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/fb844e851067ee76feccaf9f9603ec82675a051e"},{"sha":"068cd6f2f9604cb3093fc5b9089d473e2e5ee25b","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Use -s option with OpenSSL ciphers\n\nWith OpenSSL 1.1.0 (and maybe other versions), the `ciphers` function lists many cipher suites that are not actually supported by the `s_client` option. This PR fixes that by using the `-s` option whenever `$OPENSSL ciphers` is used to obtain a list of cipher suites supported by OpenSSL. According to https://www.openssl.org/docs/manmaster/man1/ciphers.html:\r\n```\r\n-s\r\n\r\n    Only list supported ciphers: those consistent with the security level, and minimum and\r\n    maximum protocol version. This is closer to the actual cipher list an application will\r\n    support.\r\n```\r\nWhen the `-s` option is used along with `-tls1`, OpenSSL 1.1.0 will not list any ciphers that only work with TLSv1.2. So, `prepare_debug()` needed to be changed to correctly populate `ossl_supported_tls`, which is supposed to be a list of all non-SSLv2 ciphers supported by the server.\r\n\r\nLibreSSL issues an \"unknown option\" error if the `-s` option is provided, so the `-s` option is only included in the command line if `$OPENSSL` has been determined to support it.\r\n\r\nThis PR is needed so that `prepare_debug()` can correctly determine which cipher suites are or are not supported by `$OPENSSL`.","distinct":true,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/068cd6f2f9604cb3093fc5b9089d473e2e5ee25b"}]}
{"actor":{"display_login":"dcooper16"}}