{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/234724803","pull_request_review_id":176427817,"id":234724803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDcyNDgwMw==","diff_hunk":"@@ -14,24 +14,35 @@ class TabItem extends React.Component {\n     document.removeEventListener('keydown', this.tabShortcut);\n   }\n \n+  // Grab the current URL, trim the leading '/', and return activeTabPath\n+  trimCurrentUrl() {","path":"src/applications/claims-status/components/TabItem.jsx","position":null,"original_position":5,"commit_id":"dec1eba8d8d1b17906d0d316483f8dfb0db3cd6f","original_commit_id":"310b5719d59f9c53f5ce8d1848773e65d046e3bc","user":{"login":"1Copenut","id":934879,"node_id":"MDQ6VXNlcjkzNDg3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/934879?v=4","gravatar_id":"","url":"https://api.github.com/users/1Copenut","html_url":"https://github.com/1Copenut","followers_url":"https://api.github.com/users/1Copenut/followers","following_url":"https://api.github.com/users/1Copenut/following{/other_user}","gists_url":"https://api.github.com/users/1Copenut/gists{/gist_id}","starred_url":"https://api.github.com/users/1Copenut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1Copenut/subscriptions","organizations_url":"https://api.github.com/users/1Copenut/orgs","repos_url":"https://api.github.com/users/1Copenut/repos","events_url":"https://api.github.com/users/1Copenut/events{/privacy}","received_events_url":"https://api.github.com/users/1Copenut/received_events","type":"User","site_admin":false},"body":"@markgreenburg I updated this as `trimCurrentUrl = () => { ... }`. Passes the tests, and worked locally.","created_at":"2018-11-19T18:08:32Z","updated_at":"2018-11-19T18:08:32Z","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000#discussion_r234724803","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments/234724803"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000#discussion_r234724803"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000"}},"in_reply_to_id":234346975},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000","id":228049175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQ5MTc1","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/9000","number":9000,"state":"open","locked":false,"title":"[WIP] 14454-appeals-tab-aria","user":{"login":"1Copenut","id":934879,"node_id":"MDQ6VXNlcjkzNDg3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/934879?v=4","gravatar_id":"","url":"https://api.github.com/users/1Copenut","html_url":"https://github.com/1Copenut","followers_url":"https://api.github.com/users/1Copenut/followers","following_url":"https://api.github.com/users/1Copenut/following{/other_user}","gists_url":"https://api.github.com/users/1Copenut/gists{/gist_id}","starred_url":"https://api.github.com/users/1Copenut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1Copenut/subscriptions","organizations_url":"https://api.github.com/users/1Copenut/orgs","repos_url":"https://api.github.com/users/1Copenut/repos","events_url":"https://api.github.com/users/1Copenut/events{/privacy}","received_events_url":"https://api.github.com/users/1Copenut/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThe Track Claims and Appeals tabs for the Appeals section were missing some of the controls present on the Claims tabs, and this was causing both automated errors, and manual usability issues for screen readers.\r\n\r\nRelated Issue: https://github.com/department-of-veterans-affairs/vets.gov-team/issues/14454\r\n\r\n\r\n## Testing done\r\n* Tested locally with axe-core to ensure there were no markup or automated error regressions\r\n* Tested locally with MacOS + Safari + VoiceOver\r\n* Will continue testing in Staging for JAWS and NVDA (can't test these locally because I can't log in a separate machine from the one running the website and API)\r\n\r\n\r\n## Acceptance criteria\r\n- [ ] Automated errors are no longer appearing for `aria-controls` attribute referencing a non-present ID\r\n\r\n## Definition of done\r\n- [ ] Events are logged appropriately\r\n- [ ] Documentation has been updated, if applicable\r\n- [x] A link has been provided to the originating GitHub issue (or connected to it via ZenHub)\r\n- [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs\r\n","created_at":"2018-11-02T20:21:23Z","updated_at":"2018-11-19T18:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf7f0026813c620e8c4ea3d963aa8c4846546c55","assignee":{"login":"1Copenut","id":934879,"node_id":"MDQ6VXNlcjkzNDg3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/934879?v=4","gravatar_id":"","url":"https://api.github.com/users/1Copenut","html_url":"https://github.com/1Copenut","followers_url":"https://api.github.com/users/1Copenut/followers","following_url":"https://api.github.com/users/1Copenut/following{/other_user}","gists_url":"https://api.github.com/users/1Copenut/gists{/gist_id}","starred_url":"https://api.github.com/users/1Copenut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1Copenut/subscriptions","organizations_url":"https://api.github.com/users/1Copenut/orgs","repos_url":"https://api.github.com/users/1Copenut/repos","events_url":"https://api.github.com/users/1Copenut/events{/privacy}","received_events_url":"https://api.github.com/users/1Copenut/received_events","type":"User","site_admin":false},"assignees":[{"login":"1Copenut","id":934879,"node_id":"MDQ6VXNlcjkzNDg3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/934879?v=4","gravatar_id":"","url":"https://api.github.com/users/1Copenut","html_url":"https://github.com/1Copenut","followers_url":"https://api.github.com/users/1Copenut/followers","following_url":"https://api.github.com/users/1Copenut/following{/other_user}","gists_url":"https://api.github.com/users/1Copenut/gists{/gist_id}","starred_url":"https://api.github.com/users/1Copenut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1Copenut/subscriptions","organizations_url":"https://api.github.com/users/1Copenut/orgs","repos_url":"https://api.github.com/users/1Copenut/repos","events_url":"https://api.github.com/users/1Copenut/events{/privacy}","received_events_url":"https://api.github.com/users/1Copenut/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/9000/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/dec1eba8d8d1b17906d0d316483f8dfb0db3cd6f","head":{"label":"department-of-veterans-affairs:14454-appeals-tab-aria","ref":"14454-appeals-tab-aria","sha":"dec1eba8d8d1b17906d0d316483f8dfb0db3cd6f","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIwMjY2Nw==","name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Frontend for Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2018-11-19T16:34:38Z","pushed_at":"2018-11-19T18:07:09Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":164064,"stargazers_count":124,"watchers_count":124,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":66,"open_issues":68,"watchers":124,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"8189cc356ccfeb3170a5cb42c39866b042bd51e0","user":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":33202667,"node_id":"MDEwOlJlcG9zaXRvcnkzMzIwMjY2Nw==","name":"vets-website","full_name":"department-of-veterans-affairs/vets-website","private":false,"owner":{"login":"department-of-veterans-affairs","id":5421563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjE1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/department-of-veterans-affairs/vets-website","description":"Frontend for Vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/deployments","created_at":"2015-03-31T18:34:05Z","updated_at":"2018-11-19T16:34:38Z","pushed_at":"2018-11-19T18:07:09Z","git_url":"git://github.com/department-of-veterans-affairs/vets-website.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-website.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-website.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-website","homepage":"","size":164064,"stargazers_count":124,"watchers_count":124,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":66,"open_issues":68,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-website/pull/9000"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/9000"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/9000/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/9000/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/statuses/dec1eba8d8d1b17906d0d316483f8dfb0db3cd6f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"1Copenut"}}