{"action":"created","comment":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/comments/236262728","pull_request_review_id":178298712,"id":236262728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI2MjcyOA==","diff_hunk":"@@ -775,14 +775,19 @@ module.exports = function($window) {\n \t\t) && key in vnode.dom\n \t}\n \n+\tvar matchUpperCase = /[A-Z]/g\n+\tfunction prependDashAndLowerCase(string){\n+\t\treturn \"-\" + string.toLowerCase()\n+\t}\n+\n \t//style\n \tfunction updateStyle(element, old, input) {\n \t\tif(typeof input === \"object\") {\n \t\t\tvar style = {}\n \t\t\tfor(var key in input) {\n-\t\t\t\tstyle[key] = String(input[key]).replace(/[A-Z]/g, function(capital){\n-\t\t\t\t\treturn \"-\" + capital.toLowerCase()\n-\t\t\t\t})\n+\t\t\t\tstyle[key] = key[0] === \"-\" && key[1] === \"-\"","path":"render/render.js","position":17,"original_position":17,"commit_id":"c4825ace8f30c8af01a822dd007045769d013591","original_commit_id":"c4825ace8f30c8af01a822dd007045769d013591","user":{"login":"porsager","id":1288405,"node_id":"MDQ6VXNlcjEyODg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1288405?v=4","gravatar_id":"","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"body":"Lol.. that was actually there from before, I just didn't spot it either 🤣\r\n\r\nI think there's something fundamentally wrong here.. why are we kebab-casing the style properties?","created_at":"2018-11-26T13:55:44Z","updated_at":"2018-11-26T13:55:45Z","html_url":"https://github.com/MithrilJS/mithril.js/pull/2311#discussion_r236262728","pull_request_url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/comments/236262728"},"html":{"href":"https://github.com/MithrilJS/mithril.js/pull/2311#discussion_r236262728"},"pull_request":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311"}},"in_reply_to_id":236259064},"pull_request":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311","id":233518510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTE4NTEw","html_url":"https://github.com/MithrilJS/mithril.js/pull/2311","diff_url":"https://github.com/MithrilJS/mithril.js/pull/2311.diff","patch_url":"https://github.com/MithrilJS/mithril.js/pull/2311.patch","issue_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2311","number":2311,"state":"open","locked":false,"title":"Allow css vars with uppercase characters","user":{"login":"porsager","id":1288405,"node_id":"MDQ6VXNlcjEyODg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1288405?v=4","gravatar_id":"","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"body":"Just noticed the fix for css vars https://github.com/MithrilJS/mithril.js/pull/2308 wouldn't support uppercase characters. This fixes it.","created_at":"2018-11-26T11:08:13Z","updated_at":"2018-11-26T13:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbf9e5db9ce02856bf47c3233f9d65949c8971eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pygy","id":54515,"node_id":"MDQ6VXNlcjU0NTE1","avatar_url":"https://avatars1.githubusercontent.com/u/54515?v=4","gravatar_id":"","url":"https://api.github.com/users/pygy","html_url":"https://github.com/pygy","followers_url":"https://api.github.com/users/pygy/followers","following_url":"https://api.github.com/users/pygy/following{/other_user}","gists_url":"https://api.github.com/users/pygy/gists{/gist_id}","starred_url":"https://api.github.com/users/pygy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pygy/subscriptions","organizations_url":"https://api.github.com/users/pygy/orgs","repos_url":"https://api.github.com/users/pygy/repos","events_url":"https://api.github.com/users/pygy/events{/privacy}","received_events_url":"https://api.github.com/users/pygy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311/commits","review_comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311/comments","review_comment_url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2311/comments","statuses_url":"https://api.github.com/repos/MithrilJS/mithril.js/statuses/c4825ace8f30c8af01a822dd007045769d013591","head":{"label":"porsager:fix-uppercase-css-vars","ref":"fix-uppercase-css-vars","sha":"c4825ace8f30c8af01a822dd007045769d013591","user":{"login":"porsager","id":1288405,"node_id":"MDQ6VXNlcjEyODg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1288405?v=4","gravatar_id":"","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"repo":{"id":141844666,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4NDQ2NjY=","name":"mithril.js","full_name":"porsager/mithril.js","private":false,"owner":{"login":"porsager","id":1288405,"node_id":"MDQ6VXNlcjEyODg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1288405?v=4","gravatar_id":"","url":"https://api.github.com/users/porsager","html_url":"https://github.com/porsager","followers_url":"https://api.github.com/users/porsager/followers","following_url":"https://api.github.com/users/porsager/following{/other_user}","gists_url":"https://api.github.com/users/porsager/gists{/gist_id}","starred_url":"https://api.github.com/users/porsager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porsager/subscriptions","organizations_url":"https://api.github.com/users/porsager/orgs","repos_url":"https://api.github.com/users/porsager/repos","events_url":"https://api.github.com/users/porsager/events{/privacy}","received_events_url":"https://api.github.com/users/porsager/received_events","type":"User","site_admin":false},"html_url":"https://github.com/porsager/mithril.js","description":"A Javascript Framework for Building Brilliant Applications","fork":true,"url":"https://api.github.com/repos/porsager/mithril.js","forks_url":"https://api.github.com/repos/porsager/mithril.js/forks","keys_url":"https://api.github.com/repos/porsager/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/porsager/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/porsager/mithril.js/teams","hooks_url":"https://api.github.com/repos/porsager/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/porsager/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/porsager/mithril.js/events","assignees_url":"https://api.github.com/repos/porsager/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/porsager/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/porsager/mithril.js/tags","blobs_url":"https://api.github.com/repos/porsager/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/porsager/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/porsager/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/porsager/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/porsager/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/porsager/mithril.js/languages","stargazers_url":"https://api.github.com/repos/porsager/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/porsager/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/porsager/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/porsager/mithril.js/subscription","commits_url":"https://api.github.com/repos/porsager/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/porsager/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/porsager/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/porsager/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/porsager/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/porsager/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/porsager/mithril.js/merges","archive_url":"https://api.github.com/repos/porsager/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/porsager/mithril.js/downloads","issues_url":"https://api.github.com/repos/porsager/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/porsager/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/porsager/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/porsager/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/porsager/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/porsager/mithril.js/releases{/id}","deployments_url":"https://api.github.com/repos/porsager/mithril.js/deployments","created_at":"2018-07-21T20:42:22Z","updated_at":"2018-07-21T20:42:25Z","pushed_at":"2018-11-26T13:10:56Z","git_url":"git://github.com/porsager/mithril.js.git","ssh_url":"git@github.com:porsager/mithril.js.git","clone_url":"https://github.com/porsager/mithril.js.git","svn_url":"https://github.com/porsager/mithril.js","homepage":"http://mithril.js.org","size":9525,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"MithrilJS:next","ref":"next","sha":"87033bf1e0309aff7f7d118ee2ae460bd978ef4c","user":{"login":"MithrilJS","id":19475707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc1NzA3","avatar_url":"https://avatars3.githubusercontent.com/u/19475707?v=4","gravatar_id":"","url":"https://api.github.com/users/MithrilJS","html_url":"https://github.com/MithrilJS","followers_url":"https://api.github.com/users/MithrilJS/followers","following_url":"https://api.github.com/users/MithrilJS/following{/other_user}","gists_url":"https://api.github.com/users/MithrilJS/gists{/gist_id}","starred_url":"https://api.github.com/users/MithrilJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MithrilJS/subscriptions","organizations_url":"https://api.github.com/users/MithrilJS/orgs","repos_url":"https://api.github.com/users/MithrilJS/repos","events_url":"https://api.github.com/users/MithrilJS/events{/privacy}","received_events_url":"https://api.github.com/users/MithrilJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17814354,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgxNDM1NA==","name":"mithril.js","full_name":"MithrilJS/mithril.js","private":false,"owner":{"login":"MithrilJS","id":19475707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc1NzA3","avatar_url":"https://avatars3.githubusercontent.com/u/19475707?v=4","gravatar_id":"","url":"https://api.github.com/users/MithrilJS","html_url":"https://github.com/MithrilJS","followers_url":"https://api.github.com/users/MithrilJS/followers","following_url":"https://api.github.com/users/MithrilJS/following{/other_user}","gists_url":"https://api.github.com/users/MithrilJS/gists{/gist_id}","starred_url":"https://api.github.com/users/MithrilJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MithrilJS/subscriptions","organizations_url":"https://api.github.com/users/MithrilJS/orgs","repos_url":"https://api.github.com/users/MithrilJS/repos","events_url":"https://api.github.com/users/MithrilJS/events{/privacy}","received_events_url":"https://api.github.com/users/MithrilJS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MithrilJS/mithril.js","description":"A Javascript Framework for Building Brilliant Applications","fork":false,"url":"https://api.github.com/repos/MithrilJS/mithril.js","forks_url":"https://api.github.com/repos/MithrilJS/mithril.js/forks","keys_url":"https://api.github.com/repos/MithrilJS/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MithrilJS/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MithrilJS/mithril.js/teams","hooks_url":"https://api.github.com/repos/MithrilJS/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/MithrilJS/mithril.js/events","assignees_url":"https://api.github.com/repos/MithrilJS/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/MithrilJS/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/MithrilJS/mithril.js/tags","blobs_url":"https://api.github.com/repos/MithrilJS/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MithrilJS/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MithrilJS/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/MithrilJS/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MithrilJS/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/MithrilJS/mithril.js/languages","stargazers_url":"https://api.github.com/repos/MithrilJS/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/MithrilJS/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/MithrilJS/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/MithrilJS/mithril.js/subscription","commits_url":"https://api.github.com/repos/MithrilJS/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/MithrilJS/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/MithrilJS/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/MithrilJS/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MithrilJS/mithril.js/merges","archive_url":"https://api.github.com/repos/MithrilJS/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MithrilJS/mithril.js/downloads","issues_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/MithrilJS/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/MithrilJS/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MithrilJS/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/MithrilJS/mithril.js/releases{/id}","deployments_url":"https://api.github.com/repos/MithrilJS/mithril.js/deployments","created_at":"2014-03-17T01:59:39Z","updated_at":"2018-11-26T12:50:27Z","pushed_at":"2018-11-26T13:10:57Z","git_url":"git://github.com/MithrilJS/mithril.js.git","ssh_url":"git@github.com:MithrilJS/mithril.js.git","clone_url":"https://github.com/MithrilJS/mithril.js.git","svn_url":"https://github.com/MithrilJS/mithril.js","homepage":"http://mithril.js.org","size":9590,"stargazers_count":10154,"watchers_count":10154,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":759,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":759,"open_issues":143,"watchers":10154,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311"},"html":{"href":"https://github.com/MithrilJS/mithril.js/pull/2311"},"issue":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2311"},"comments":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/issues/2311/comments"},"review_comments":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311/comments"},"review_comment":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/2311/commits"},"statuses":{"href":"https://api.github.com/repos/MithrilJS/mithril.js/statuses/c4825ace8f30c8af01a822dd007045769d013591"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"porsager"}}