{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/686","repository_url":"https://api.github.com/repos/dotnet/dotnet-api-docs","labels_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/686/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/686/comments","events_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/686/events","html_url":"https://github.com/dotnet/dotnet-api-docs/pull/686","id":375725603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTA2MzMz","number":686,"title":"Remove regular expression as validation method","user":{"login":"KyleMit","id":4307307,"node_id":"MDQ6VXNlcjQzMDczMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/4307307?v=4","gravatar_id":"","url":"https://api.github.com/users/KyleMit","html_url":"https://github.com/KyleMit","followers_url":"https://api.github.com/users/KyleMit/followers","following_url":"https://api.github.com/users/KyleMit/following{/other_user}","gists_url":"https://api.github.com/users/KyleMit/gists{/gist_id}","starred_url":"https://api.github.com/users/KyleMit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KyleMit/subscriptions","organizations_url":"https://api.github.com/users/KyleMit/orgs","repos_url":"https://api.github.com/users/KyleMit/repos","events_url":"https://api.github.com/users/KyleMit/events{/privacy}","received_events_url":"https://api.github.com/users/KyleMit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-30T22:47:40Z","updated_at":"2018-10-31T17:43:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/686","html_url":"https://github.com/dotnet/dotnet-api-docs/pull/686","diff_url":"https://github.com/dotnet/dotnet-api-docs/pull/686.diff","patch_url":"https://github.com/dotnet/dotnet-api-docs/pull/686.patch"},"body":"Using regular expressions for Phone Validation was deprecated as of .Net Framework 4.7.2 and not in any version of .Net Core\r\n\r\nHere's the compatability post on removing regex and the default validator in `[Phone]`:\r\n\r\nhttps://github.com/Microsoft/dotnet/blob/master/Documentation/compatibility/aspnet-472-compat-doc.md\r\n\r\nAnd .NET Core no longer users regular expressions to determine phone number format validity at all ([Presumably because of the best practices on Regex and injection/security concerns](https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices))\r\n\r\nHere's the source code for core without a Regex in sight:\r\n\r\nhttps://github.com/dotnet/corefx/blob/v2.1.5/src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/PhoneAttribute.cs\r\n\r\n\r\nNot sure if the description can be forked by API version / framework, but it looks like this single file is serving as the doc for both .NET Framework and .NET Core, and seems easier to just remove the regular expression bit as it's certainly incorrect in the case of Core, but if there's a way to version the comments, then let me know in the PR and I can update the commit to seperate by version."},"comment":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/comments/434782508","html_url":"https://github.com/dotnet/dotnet-api-docs/pull/686#issuecomment-434782508","issue_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/686","id":434782508,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDc4MjUwOA==","user":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T17:43:05Z","updated_at":"2018-10-31T17:43:05Z","author_association":"MEMBER","body":"Sorry about that. I meant to ping @divega as owner for `System.ComponentModel.DataAnnotations`\r\n"}}
{"actor":{"display_login":"BillWagner"}}