{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/comments/190821881","pull_request_review_id":123280831,"id":190821881,"diff_hunk":"@@ -59,4 +59,5 @@ def get_avocado_libexec_dir():\n           packages=['aexpect',\n                     'aexpect.utils'],\n           scripts=['scripts/aexpect-helper'],\n-          use_2to3=True)\n+          use_2to3=True,\n+          install_requires=['subprocess32>=3.2.6;python_version<\"3\"'])","path":"setup.py","position":6,"original_position":6,"commit_id":"18a7249d34e889073aed0dbf80d545f4c0d70498","original_commit_id":"e6636d88876a6eaa914fb5de15ddbab107cbd80b","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"yep, looks good to me and we can \"blacklist\" py3.1 when someone complains...","created_at":"2018-05-25T08:19:38Z","updated_at":"2018-05-25T08:19:38Z","html_url":"https://github.com/avocado-framework/aexpect/pull/34#discussion_r190821881","pull_request_url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/comments/190821881"},"html":{"href":"https://github.com/avocado-framework/aexpect/pull/34#discussion_r190821881"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34","id":189938724,"html_url":"https://github.com/avocado-framework/aexpect/pull/34","diff_url":"https://github.com/avocado-framework/aexpect/pull/34.diff","patch_url":"https://github.com/avocado-framework/aexpect/pull/34.patch","issue_url":"https://api.github.com/repos/avocado-framework/aexpect/issues/34","number":34,"state":"open","locked":false,"title":"To support fd passing [v3]","user":{"login":"luckyh","id":7801589,"avatar_url":"https://avatars1.githubusercontent.com/u/7801589?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyh","html_url":"https://github.com/luckyh","followers_url":"https://api.github.com/users/luckyh/followers","following_url":"https://api.github.com/users/luckyh/following{/other_user}","gists_url":"https://api.github.com/users/luckyh/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyh/subscriptions","organizations_url":"https://api.github.com/users/luckyh/orgs","repos_url":"https://api.github.com/users/luckyh/repos","events_url":"https://api.github.com/users/luckyh/events{/privacy}","received_events_url":"https://api.github.com/users/luckyh/received_events","type":"User","site_admin":false},"body":"aexpect.client: To support fd passing\r\n\r\nAdd new argument `pass_fds` for `Spawn`/`Tail`/`Expect`/`ShellSession`\r\nand their related wrappers to support fd passing.\r\n\r\nIn python 2, the above utilities do support (implicit) fd passing, but\r\nthese would not work in python 3 for some reasons. By applying this\r\npatch, now users can pass fds to the target process explicitly, and\r\nimplicit fd passing is not allowed.\r\n\r\nSigned-off-by: Xu Han xuhan@redhat.com\r\n\r\n----\r\nChanges:\r\n```\r\nv2:  replace subprocess with subprocess32\r\nv3:  install denpendence via setup.py\r\n```","created_at":"2018-05-23T11:13:06Z","updated_at":"2018-05-25T08:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e4162a286cb721fce995426d0dd5bbcefbff98","assignee":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"assignees":[{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars3.githubusercontent.com/u/1074021?v=4","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/aexpect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/aexpect/issues/34/comments","statuses_url":"https://api.github.com/repos/avocado-framework/aexpect/statuses/18a7249d34e889073aed0dbf80d545f4c0d70498","head":{"label":"luckyh:passfds-v3","ref":"passfds-v3","sha":"18a7249d34e889073aed0dbf80d545f4c0d70498","user":{"login":"luckyh","id":7801589,"avatar_url":"https://avatars1.githubusercontent.com/u/7801589?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyh","html_url":"https://github.com/luckyh","followers_url":"https://api.github.com/users/luckyh/followers","following_url":"https://api.github.com/users/luckyh/following{/other_user}","gists_url":"https://api.github.com/users/luckyh/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyh/subscriptions","organizations_url":"https://api.github.com/users/luckyh/orgs","repos_url":"https://api.github.com/users/luckyh/repos","events_url":"https://api.github.com/users/luckyh/events{/privacy}","received_events_url":"https://api.github.com/users/luckyh/received_events","type":"User","site_admin":false},"repo":{"id":132696582,"name":"aexpect","full_name":"luckyh/aexpect","owner":{"login":"luckyh","id":7801589,"avatar_url":"https://avatars1.githubusercontent.com/u/7801589?v=4","gravatar_id":"","url":"https://api.github.com/users/luckyh","html_url":"https://github.com/luckyh","followers_url":"https://api.github.com/users/luckyh/followers","following_url":"https://api.github.com/users/luckyh/following{/other_user}","gists_url":"https://api.github.com/users/luckyh/gists{/gist_id}","starred_url":"https://api.github.com/users/luckyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckyh/subscriptions","organizations_url":"https://api.github.com/users/luckyh/orgs","repos_url":"https://api.github.com/users/luckyh/repos","events_url":"https://api.github.com/users/luckyh/events{/privacy}","received_events_url":"https://api.github.com/users/luckyh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luckyh/aexpect","description":"Python library used to control interactive programs","fork":true,"url":"https://api.github.com/repos/luckyh/aexpect","forks_url":"https://api.github.com/repos/luckyh/aexpect/forks","keys_url":"https://api.github.com/repos/luckyh/aexpect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckyh/aexpect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckyh/aexpect/teams","hooks_url":"https://api.github.com/repos/luckyh/aexpect/hooks","issue_events_url":"https://api.github.com/repos/luckyh/aexpect/issues/events{/number}","events_url":"https://api.github.com/repos/luckyh/aexpect/events","assignees_url":"https://api.github.com/repos/luckyh/aexpect/assignees{/user}","branches_url":"https://api.github.com/repos/luckyh/aexpect/branches{/branch}","tags_url":"https://api.github.com/repos/luckyh/aexpect/tags","blobs_url":"https://api.github.com/repos/luckyh/aexpect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckyh/aexpect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckyh/aexpect/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckyh/aexpect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckyh/aexpect/statuses/{sha}","languages_url":"https://api.github.com/repos/luckyh/aexpect/languages","stargazers_url":"https://api.github.com/repos/luckyh/aexpect/stargazers","contributors_url":"https://api.github.com/repos/luckyh/aexpect/contributors","subscribers_url":"https://api.github.com/repos/luckyh/aexpect/subscribers","subscription_url":"https://api.github.com/repos/luckyh/aexpect/subscription","commits_url":"https://api.github.com/repos/luckyh/aexpect/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckyh/aexpect/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckyh/aexpect/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckyh/aexpect/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckyh/aexpect/contents/{+path}","compare_url":"https://api.github.com/repos/luckyh/aexpect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckyh/aexpect/merges","archive_url":"https://api.github.com/repos/luckyh/aexpect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckyh/aexpect/downloads","issues_url":"https://api.github.com/repos/luckyh/aexpect/issues{/number}","pulls_url":"https://api.github.com/repos/luckyh/aexpect/pulls{/number}","milestones_url":"https://api.github.com/repos/luckyh/aexpect/milestones{/number}","notifications_url":"https://api.github.com/repos/luckyh/aexpect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckyh/aexpect/labels{/name}","releases_url":"https://api.github.com/repos/luckyh/aexpect/releases{/id}","deployments_url":"https://api.github.com/repos/luckyh/aexpect/deployments","created_at":"2018-05-09T03:26:07Z","updated_at":"2018-05-09T03:26:09Z","pushed_at":"2018-05-24T03:26:23Z","git_url":"git://github.com/luckyh/aexpect.git","ssh_url":"git@github.com:luckyh/aexpect.git","clone_url":"https://github.com/luckyh/aexpect.git","svn_url":"https://github.com/luckyh/aexpect","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"7a52e96eb82650b38f5ca2e01e9accaa94c2bfc4","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":34433344,"name":"aexpect","full_name":"avocado-framework/aexpect","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/aexpect","description":"Python library used to control interactive programs","fork":false,"url":"https://api.github.com/repos/avocado-framework/aexpect","forks_url":"https://api.github.com/repos/avocado-framework/aexpect/forks","keys_url":"https://api.github.com/repos/avocado-framework/aexpect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/aexpect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/aexpect/teams","hooks_url":"https://api.github.com/repos/avocado-framework/aexpect/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/aexpect/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/aexpect/events","assignees_url":"https://api.github.com/repos/avocado-framework/aexpect/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/aexpect/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/aexpect/tags","blobs_url":"https://api.github.com/repos/avocado-framework/aexpect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/aexpect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/aexpect/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/aexpect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/aexpect/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/aexpect/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/aexpect/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/aexpect/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/aexpect/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/aexpect/subscription","commits_url":"https://api.github.com/repos/avocado-framework/aexpect/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/aexpect/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/aexpect/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/aexpect/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/aexpect/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/aexpect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/aexpect/merges","archive_url":"https://api.github.com/repos/avocado-framework/aexpect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/aexpect/downloads","issues_url":"https://api.github.com/repos/avocado-framework/aexpect/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/aexpect/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/aexpect/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/aexpect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/aexpect/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/aexpect/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/aexpect/deployments","created_at":"2015-04-23T04:20:19Z","updated_at":"2018-04-19T14:25:28Z","pushed_at":"2018-05-24T03:24:55Z","git_url":"git://github.com/avocado-framework/aexpect.git","ssh_url":"git@github.com:avocado-framework/aexpect.git","clone_url":"https://github.com/avocado-framework/aexpect.git","svn_url":"https://github.com/avocado-framework/aexpect","homepage":null,"size":92,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":16,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34"},"html":{"href":"https://github.com/avocado-framework/aexpect/pull/34"},"issue":{"href":"https://api.github.com/repos/avocado-framework/aexpect/issues/34"},"comments":{"href":"https://api.github.com/repos/avocado-framework/aexpect/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/aexpect/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/aexpect/statuses/18a7249d34e889073aed0dbf80d545f4c0d70498"}},"author_association":"NONE"}}
{"actor":{"display_login":"ldoktor"}}