{"push_id":2700704992,"size":4,"distinct_size":4,"ref":"refs/heads/fix-large-sets","head":"80d27f63d4cf51cfdeaff034f9d82ef17bcd6c19","before":"f01171a9e27c479b3028582892cd04711750e6c0","commits":[{"sha":"9177474f1fc070f36001f5ed3682544bdd8fdf5b","author":{"name":"Connor Wakamo","email":"281982782b2c37e7917ee9574290b242f1a3b1a1@apple.com"},"message":"Better handle some cases where PlaygroundLogger previously failed to encode empty images.\n\nIf a `NSView`, `NSImage`, or `UIImage` was zero-sized (e.g. 0x0), PlaygroundLogger would fail to encode this because it couldn't get a bitmap representation for the image.\nInstead, handle this case specially, and instead of failing, send zero bytes of PNG data. Xcode renders this as an empty image, which is the expectation for this case.\nThis commit includes tests that empty views and images on all platforms generate image representations which can be encoded without throwing any errors.\n\nThis is an improvement over the legacy PlaygroundLogger implementation, which would render these plus empty `UIView` instances as if they were the string \"empty image\".\n\nThis addresses <rdar://problem/40207604>.","distinct":true,"url":"https://api.github.com/repos/cwakamo/swift-xcode-playground-support/commits/9177474f1fc070f36001f5ed3682544bdd8fdf5b"},{"sha":"5f820dd48ad1961d4c4bfb53073b886f473bd9d7","author":{"name":"Connor Wakamo","email":"281982782b2c37e7917ee9574290b242f1a3b1a1@me.com"},"message":"Merge pull request #27 from cwakamo/fix-empty-views-and-images\n\n[PlaygroundLogger] Better handle encoding of empty images and views.","distinct":true,"url":"https://api.github.com/repos/cwakamo/swift-xcode-playground-support/commits/5f820dd48ad1961d4c4bfb53073b886f473bd9d7"},{"sha":"91efe3db0c269c141d4160c0cfe659a786cb27ed","author":{"name":"Connor Wakamo","email":"281982782b2c37e7917ee9574290b242f1a3b1a1@apple.com"},"message":"Use `prefix` and `suffix` when getting the first and last n children.\n\nOffsetting indices only works for collections which implement `BidirectionalCollection`, while `suffix(_:)` is available for all collections.\nThis prevent crashes when e.g. generating a `LogEntry` for instances of `Set`.\n\nThis addresses <rdar://problem/39791397>.","distinct":true,"url":"https://api.github.com/repos/cwakamo/swift-xcode-playground-support/commits/91efe3db0c269c141d4160c0cfe659a786cb27ed"},{"sha":"80d27f63d4cf51cfdeaff034f9d82ef17bcd6c19","author":{"name":"Connor Wakamo","email":"281982782b2c37e7917ee9574290b242f1a3b1a1@apple.com"},"message":"Added some comments to testLargeSet() to explain some assertions.","distinct":true,"url":"https://api.github.com/repos/cwakamo/swift-xcode-playground-support/commits/80d27f63d4cf51cfdeaff034f9d82ef17bcd6c19"}]}
{"actor":{"display_login":"cwakamo"}}