{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/50466","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/50466/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/50466/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/50466/events","html_url":"https://github.com/saltstack/salt/pull/50466","id":379547826,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTY4MTg0","number":50466,"title":"add ext_pillar_cache","user":{"login":"rongzeng54","id":1867865,"node_id":"MDQ6VXNlcjE4Njc4NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1867865?v=4","gravatar_id":"","url":"https://api.github.com/users/rongzeng54","html_url":"https://github.com/rongzeng54","followers_url":"https://api.github.com/users/rongzeng54/followers","following_url":"https://api.github.com/users/rongzeng54/following{/other_user}","gists_url":"https://api.github.com/users/rongzeng54/gists{/gist_id}","starred_url":"https://api.github.com/users/rongzeng54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongzeng54/subscriptions","organizations_url":"https://api.github.com/users/rongzeng54/orgs","repos_url":"https://api.github.com/users/rongzeng54/repos","events_url":"https://api.github.com/users/rongzeng54/events{/privacy}","received_events_url":"https://api.github.com/users/rongzeng54/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-11T18:12:15Z","updated_at":"2018-11-27T13:39:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/50466","html_url":"https://github.com/saltstack/salt/pull/50466","diff_url":"https://github.com/saltstack/salt/pull/50466.diff","patch_url":"https://github.com/saltstack/salt/pull/50466.patch"},"body":"### What does this PR do?\r\nAdd ext_pillar_cache for cacheing pillar data rendered from external pillar sources.\r\nAt the same time, pillar_cache only for cacheing pillar data rendered from pillar_roots and pillar_opts.\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/saltstack/salt/issues/50104\r\n\r\n### Previous Behavior\r\npillar_cache cacheing all pillar data\r\n\r\n### New Behavior\r\npillar_cache cacheing pillar data rendered from pillar_roots and pillar_opts.\r\next_pillar_cache cacheing pillar data rendered from external pillar sources.\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Commits signed with GPG?\r\nNo"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/442061091","html_url":"https://github.com/saltstack/salt/pull/50466#issuecomment-442061091","issue_url":"https://api.github.com/repos/saltstack/salt/issues/50466","id":442061091,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjA2MTA5MQ==","user":{"login":"isbm","id":1073714,"node_id":"MDQ6VXNlcjEwNzM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073714?v=4","gravatar_id":"","url":"https://api.github.com/users/isbm","html_url":"https://github.com/isbm","followers_url":"https://api.github.com/users/isbm/followers","following_url":"https://api.github.com/users/isbm/following{/other_user}","gists_url":"https://api.github.com/users/isbm/gists{/gist_id}","starred_url":"https://api.github.com/users/isbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isbm/subscriptions","organizations_url":"https://api.github.com/users/isbm/orgs","repos_url":"https://api.github.com/users/isbm/repos","events_url":"https://api.github.com/users/isbm/events{/privacy}","received_events_url":"https://api.github.com/users/isbm/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T13:39:39Z","updated_at":"2018-11-27T13:39:39Z","author_association":"CONTRIBUTOR","body":"> While I'm open to the idea of an RFC, given that this models the existing implementation for pillar caches, this seems more like an enhancement to me than a full-blown new feature. Thoughts?\r\n\r\nWell, I know. :wink: I am all for RFC, because while I am **not against** the improvements, I want it through through. E.g. time-based is not entirely nice. How to invalidate the cache? How to protect it from swapping the minion? — etc. I also not sure the configuration is nice as well. If we are configuring pillar cache, then likely we want it nested and grouped, instead of 10 more long options at the root of the config."}}
{"actor":{"display_login":"isbm"}}