{"action":"created","issue":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/21","repository_url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/21/comments","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/21/events","html_url":"https://github.com/PolymathNetwork/polymath-issuer/issues/21","id":315592074,"number":21,"title":"Can't get rid of ES-lint errors that state : JSX props should not use arrow functions  react/jsx-no-bind","user":{"login":"davekaj","id":22417382,"avatar_url":"https://avatars2.githubusercontent.com/u/22417382?v=4","gravatar_id":"","url":"https://api.github.com/users/davekaj","html_url":"https://github.com/davekaj","followers_url":"https://api.github.com/users/davekaj/followers","following_url":"https://api.github.com/users/davekaj/following{/other_user}","gists_url":"https://api.github.com/users/davekaj/gists{/gist_id}","starred_url":"https://api.github.com/users/davekaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davekaj/subscriptions","organizations_url":"https://api.github.com/users/davekaj/orgs","repos_url":"https://api.github.com/users/davekaj/repos","events_url":"https://api.github.com/users/davekaj/events{/privacy}","received_events_url":"https://api.github.com/users/davekaj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-18T18:27:17Z","updated_at":"2018-04-20T06:34:53Z","closed_at":null,"author_association":"MEMBER","body":"Can't seem to get rid of this error no matter what I do, I tried to write /* eslint-disable jsx-no-bind */\r\n at the top of the page, but it didnt work (I tried multiple different syntaxes).\r\n\r\nMy theory, and I might be wrong, is that it is not part of the main eslint package, and therefore doesnt get picked up by eslint-disable. it is part of this plugin: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md\r\n\r\nAs a solution, I recommend updating this line to read `true` https://github.com/PolymathNetwork/eslint-plugin-polymath-react/blob/0cd34e915433f8009cbba938446f586046e86997/config.js#L62\r\n\r\nI think we could do without the rule , as I am just trying to disable it anyways.\r\n\r\n@bshevchenko  let me know if we can update the linting rule to true "},"comment":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/comments/382994560","html_url":"https://github.com/PolymathNetwork/polymath-issuer/issues/21#issuecomment-382994560","issue_url":"https://api.github.com/repos/PolymathNetwork/polymath-issuer/issues/21","id":382994560,"user":{"login":"bshevchenko","id":1531049,"avatar_url":"https://avatars3.githubusercontent.com/u/1531049?v=4","gravatar_id":"","url":"https://api.github.com/users/bshevchenko","html_url":"https://github.com/bshevchenko","followers_url":"https://api.github.com/users/bshevchenko/followers","following_url":"https://api.github.com/users/bshevchenko/following{/other_user}","gists_url":"https://api.github.com/users/bshevchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/bshevchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bshevchenko/subscriptions","organizations_url":"https://api.github.com/users/bshevchenko/orgs","repos_url":"https://api.github.com/users/bshevchenko/repos","events_url":"https://api.github.com/users/bshevchenko/events{/privacy}","received_events_url":"https://api.github.com/users/bshevchenko/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T06:34:53Z","updated_at":"2018-04-20T06:34:53Z","author_association":"MEMBER","body":"From https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md\r\n> A bind call or arrow function in a JSX prop will create a brand new function on every single render. This is bad for performance, as it will result in the garbage collector being invoked way more than is necessary. It may also cause unnecessary re-renders if a brand new function is passed as a prop to a component that uses reference equality check on the prop to determine if it should update.\r\n\r\nSo please don't try to deceive eslint, it won't solve the problem.\r\nBut since we need new function on every single render here (to pass new selectedRows value) `/* eslint-disable react/jsx-no-bind */` will be ok."}}
{"actor":{"display_login":"bshevchenko"}}