{"action":"created","comment":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/199328636","pull_request_review_id":133432506,"id":199328636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMyODYzNg==","diff_hunk":"@@ -1750,7 +1750,10 @@ private static string EvaluationString(string fun, params object[] args)\n \n             string SerializeArgument(object arg)\n             {\n-                if (arg == null) return \"undefined\";\n+                if (arg == null)","path":"lib/PuppeteerSharp/Page.cs","position":36,"original_position":36,"commit_id":"46070a60181c5cc336e83dd861f5bc3a269eb2c8","original_commit_id":"46070a60181c5cc336e83dd861f5bc3a269eb2c8","user":{"login":"Meir017","id":9786571,"node_id":"MDQ6VXNlcjk3ODY1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9786571?v=4","gravatar_id":"","url":"https://api.github.com/users/Meir017","html_url":"https://github.com/Meir017","followers_url":"https://api.github.com/users/Meir017/followers","following_url":"https://api.github.com/users/Meir017/following{/other_user}","gists_url":"https://api.github.com/users/Meir017/gists{/gist_id}","starred_url":"https://api.github.com/users/Meir017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meir017/subscriptions","organizations_url":"https://api.github.com/users/Meir017/orgs","repos_url":"https://api.github.com/users/Meir017/repos","events_url":"https://api.github.com/users/Meir017/events{/privacy}","received_events_url":"https://api.github.com/users/Meir017/received_events","type":"User","site_admin":false},"body":"maybe use a conditional expression here?\r\n```cs\r\nreturn arg == null ? \"undefind\" : JsonConvert.SerializeObject(arg);\r\n```","created_at":"2018-06-30T18:01:32Z","updated_at":"2018-06-30T18:01:39Z","html_url":"https://github.com/kblok/puppeteer-sharp/pull/369#discussion_r199328636","pull_request_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/199328636"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/369#discussion_r199328636"},"pull_request":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369"}}},"pull_request":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369","id":198447384,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDQ3Mzg0","html_url":"https://github.com/kblok/puppeteer-sharp/pull/369","diff_url":"https://github.com/kblok/puppeteer-sharp/pull/369.diff","patch_url":"https://github.com/kblok/puppeteer-sharp/pull/369.patch","issue_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/369","number":369,"state":"open","locked":false,"title":"Wait for the page to close in the browser in page.close","user":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"body":"closes #349 ","created_at":"2018-06-29T23:53:51Z","updated_at":"2018-06-30T18:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e193f9152b1ff67255b3958624f26f88a9121ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369/commits","review_comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369/comments","review_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/369/comments","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/46070a60181c5cc336e83dd861f5bc3a269eb2c8","head":{"label":"kblok:features/wait-for-close","ref":"features/wait-for-close","sha":"46070a60181c5cc336e83dd861f5bc3a269eb2c8","user":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"repo":{"id":105399035,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzOTkwMzU=","name":"puppeteer-sharp","full_name":"kblok/puppeteer-sharp","owner":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kblok/puppeteer-sharp","description":"Headless Chrome .NET API","fork":false,"url":"https://api.github.com/repos/kblok/puppeteer-sharp","forks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/kblok/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kblok/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kblok/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/kblok/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/kblok/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/kblok/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kblok/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/kblok/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kblok/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/kblok/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/kblok/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kblok/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/kblok/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/deployments","created_at":"2017-09-30T20:32:25Z","updated_at":"2018-06-29T21:27:50Z","pushed_at":"2018-06-30T17:57:33Z","git_url":"git://github.com/kblok/puppeteer-sharp.git","ssh_url":"git@github.com:kblok/puppeteer-sharp.git","clone_url":"https://github.com/kblok/puppeteer-sharp.git","svn_url":"https://github.com/kblok/puppeteer-sharp","homepage":"https://www.puppeteersharp.com","size":1551,"stargazers_count":128,"watchers_count":128,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":32,"watchers":128,"default_branch":"master"}},"base":{"label":"kblok:master","ref":"master","sha":"ca6e427bd064c0a72047cd91355c476d5f106656","user":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"repo":{"id":105399035,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzOTkwMzU=","name":"puppeteer-sharp","full_name":"kblok/puppeteer-sharp","owner":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kblok/puppeteer-sharp","description":"Headless Chrome .NET API","fork":false,"url":"https://api.github.com/repos/kblok/puppeteer-sharp","forks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/kblok/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kblok/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kblok/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/kblok/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/kblok/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/kblok/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kblok/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/kblok/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kblok/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/kblok/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/kblok/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kblok/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/kblok/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/deployments","created_at":"2017-09-30T20:32:25Z","updated_at":"2018-06-29T21:27:50Z","pushed_at":"2018-06-30T17:57:33Z","git_url":"git://github.com/kblok/puppeteer-sharp.git","ssh_url":"git@github.com:kblok/puppeteer-sharp.git","clone_url":"https://github.com/kblok/puppeteer-sharp.git","svn_url":"https://github.com/kblok/puppeteer-sharp","homepage":"https://www.puppeteersharp.com","size":1551,"stargazers_count":128,"watchers_count":128,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":32,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/369"},"issue":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/369"},"comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/46070a60181c5cc336e83dd861f5bc3a269eb2c8"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Meir017"}}