{"action":"closed","issue":{"url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1141","repository_url":"https://api.github.com/repos/zenphoto/zenphoto","labels_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1141/labels{/name}","comments_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1141/comments","events_url":"https://api.github.com/repos/zenphoto/zenphoto/issues/1141/events","html_url":"https://github.com/zenphoto/zenphoto/issues/1141","id":302076233,"number":1141,"title":"cacheManager plugin does not generate uncropped thumbnails","user":{"login":"JatB","id":10157440,"avatar_url":"https://avatars2.githubusercontent.com/u/10157440?v=4","gravatar_id":"","url":"https://api.github.com/users/JatB","html_url":"https://github.com/JatB","followers_url":"https://api.github.com/users/JatB/followers","following_url":"https://api.github.com/users/JatB/following{/other_user}","gists_url":"https://api.github.com/users/JatB/gists{/gist_id}","starred_url":"https://api.github.com/users/JatB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JatB/subscriptions","organizations_url":"https://api.github.com/users/JatB/orgs","repos_url":"https://api.github.com/users/JatB/repos","events_url":"https://api.github.com/users/JatB/events{/privacy}","received_events_url":"https://api.github.com/users/JatB/received_events","type":"User","site_admin":false},"labels":[{"id":16912116,"url":"https://api.github.com/repos/zenphoto/zenphoto/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-04T10:58:04Z","updated_at":"2018-05-21T19:06:42Z","closed_at":"2018-05-21T19:06:42Z","author_association":"NONE","body":"The cacheManager plugin does not recognize the crop setting for thumbnails. It will only generate cropped thumbnails even if cropping is turned off in Options - Theme.\r\n\r\nSo for the Basic theme, if you run the Cache manager with everything set to default you get 100x100 pixel thumbs and 595 pixel images-\r\n\r\n> Refreshing cache for Gallery\r\n> \r\n> Apply 100_cw100_ch100_thumb\r\n> Apply 595\r\n> \r\n> 2 cache sizes to apply.\r\n\r\n\r\nTurning cropping off for thumbnails, but leaving everything else at default, you will still get the same cropped sizes when you run Cache manager (after doing a Purge Image cache)-\r\n\r\n> Refreshing cache for Gallery\r\n> \r\n> Apply 100_cw100_ch100_thumb\r\n> Apply 595\r\n> \r\n> 2 cache sizes to apply.\r\n\r\n\r\nLeaving cropped off for thumbnails, but changing the thumb size to 200 pixels gets you 200x200 cropped thumbnails-\r\n\r\n> Refreshing cache for Gallery\r\n> \r\n> Apply 200_cw200_ch200_thumb\r\n> Apply 595\r\n> \r\n> 2 cache sizes to apply.\r\n\r\n\r\nIf you change the image size, say to 895, that will get generated. So the only problem is when cropping is turned off for thumbnails.\r\n\r\nIt looks like the issue is on line 38 of themeoptions.php in the theme folder, where it is coded to get the cropped width and height for the thumbnail instead of seeing if cropped is turned on or off (of course, I could be wrong)-\r\n\r\n`cacheManager::addThemeCacheSize($me, getThemeOption('thumb_size'), NULL, NULL, getThemeOption('thumb_crop_width'), getThemeOption('thumb_crop_height'), NULL, NULL, true, NULL, NULL, NULL);`\r\n\r\n\r\nThanks, as always, for your time.\r\n"}}
{"actor":{"display_login":"acrylian"}}