{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/comments/199094552","pull_request_review_id":133146077,"id":199094552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA5NDU1Mg==","diff_hunk":"@@ -589,10 +597,9 @@ private void joinAndEnd(boolean waitForRecovery, boolean close, String path, Str\n             lraClient.cancelLRA(lra);\n \n         if (waitForRecovery) {\n-            String recoveryPath = System.getProperty(LRA_RECOVERY_PATH_KEY, \"lra-recovery-coordinator\");\n             // trigger a recovery scan which trigger a replay attempt on any participants\n             // that have responded to complete/compensate requests with Response.Status.ACCEPTED\n-            resourcePath = recoveryTarget.path(recoveryPath).path(\"recovery\");\n+            resourcePath = recoveryTarget.path(\"recovery\");","path":"tck/src/main/java/org/eclipse/microprofile/lra/tck/TckTests.java","position":62,"original_position":62,"commit_id":"444890e972e81c1f213d0258291f9f169491eef3","original_commit_id":"444890e972e81c1f213d0258291f9f169491eef3","user":{"login":"tomjenkinson","id":317340,"node_id":"MDQ6VXNlcjMxNzM0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/317340?v=4","gravatar_id":"","url":"https://api.github.com/users/tomjenkinson","html_url":"https://github.com/tomjenkinson","followers_url":"https://api.github.com/users/tomjenkinson/followers","following_url":"https://api.github.com/users/tomjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tomjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tomjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tomjenkinson/orgs","repos_url":"https://api.github.com/users/tomjenkinson/repos","events_url":"https://api.github.com/users/tomjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tomjenkinson/received_events","type":"User","site_admin":false},"body":"A lot of the other \"paths\" in the test use \"static final String\"","created_at":"2018-06-29T08:49:08Z","updated_at":"2018-06-29T08:49:08Z","html_url":"https://github.com/eclipse/microprofile-lra/pull/10#discussion_r199094552","pull_request_url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/comments/199094552"},"html":{"href":"https://github.com/eclipse/microprofile-lra/pull/10#discussion_r199094552"},"pull_request":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10","id":196904422,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTA0NDIy","html_url":"https://github.com/eclipse/microprofile-lra/pull/10","diff_url":"https://github.com/eclipse/microprofile-lra/pull/10.diff","patch_url":"https://github.com/eclipse/microprofile-lra/pull/10.patch","issue_url":"https://api.github.com/repos/eclipse/microprofile-lra/issues/10","number":10,"state":"open","locked":false,"title":"issue7 Context propagation across non-LRA aware services","user":{"login":"mmusgrov","id":493492,"node_id":"MDQ6VXNlcjQ5MzQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/493492?v=4","gravatar_id":"","url":"https://api.github.com/users/mmusgrov","html_url":"https://github.com/mmusgrov","followers_url":"https://api.github.com/users/mmusgrov/followers","following_url":"https://api.github.com/users/mmusgrov/following{/other_user}","gists_url":"https://api.github.com/users/mmusgrov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusgrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusgrov/subscriptions","organizations_url":"https://api.github.com/users/mmusgrov/orgs","repos_url":"https://api.github.com/users/mmusgrov/repos","events_url":"https://api.github.com/users/mmusgrov/events{/privacy}","received_events_url":"https://api.github.com/users/mmusgrov/received_events","type":"User","site_admin":false},"body":"https://github.com/eclipse/microprofile-lra/issues/7\r\n\r\nThis PR adds javadoc text to the LRA annotation that specifies that an LRA context is propagated across non-LRA aware services (ie one that does not specify any LRA behaviour).\r\n\r\nThe PR also adds a TCK test to verify this behaviour.","created_at":"2018-06-23T14:21:23Z","updated_at":"2018-06-29T08:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0154de7eb023b9cc9f460ce49f2e005ccdc69b39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10/commits","review_comments_url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10/comments","review_comment_url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/microprofile-lra/issues/10/comments","statuses_url":"https://api.github.com/repos/eclipse/microprofile-lra/statuses/444890e972e81c1f213d0258291f9f169491eef3","head":{"label":"mmusgrov:issue7","ref":"issue7","sha":"444890e972e81c1f213d0258291f9f169491eef3","user":{"login":"mmusgrov","id":493492,"node_id":"MDQ6VXNlcjQ5MzQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/493492?v=4","gravatar_id":"","url":"https://api.github.com/users/mmusgrov","html_url":"https://github.com/mmusgrov","followers_url":"https://api.github.com/users/mmusgrov/followers","following_url":"https://api.github.com/users/mmusgrov/following{/other_user}","gists_url":"https://api.github.com/users/mmusgrov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusgrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusgrov/subscriptions","organizations_url":"https://api.github.com/users/mmusgrov/orgs","repos_url":"https://api.github.com/users/mmusgrov/repos","events_url":"https://api.github.com/users/mmusgrov/events{/privacy}","received_events_url":"https://api.github.com/users/mmusgrov/received_events","type":"User","site_admin":false},"repo":{"id":133961052,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NjEwNTI=","name":"microprofile-lra","full_name":"mmusgrov/microprofile-lra","owner":{"login":"mmusgrov","id":493492,"node_id":"MDQ6VXNlcjQ5MzQ5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/493492?v=4","gravatar_id":"","url":"https://api.github.com/users/mmusgrov","html_url":"https://github.com/mmusgrov","followers_url":"https://api.github.com/users/mmusgrov/followers","following_url":"https://api.github.com/users/mmusgrov/following{/other_user}","gists_url":"https://api.github.com/users/mmusgrov/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusgrov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusgrov/subscriptions","organizations_url":"https://api.github.com/users/mmusgrov/orgs","repos_url":"https://api.github.com/users/mmusgrov/repos","events_url":"https://api.github.com/users/mmusgrov/events{/privacy}","received_events_url":"https://api.github.com/users/mmusgrov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmusgrov/microprofile-lra","description":"microprofile-lra","fork":true,"url":"https://api.github.com/repos/mmusgrov/microprofile-lra","forks_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/forks","keys_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/teams","hooks_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/hooks","issue_events_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/issues/events{/number}","events_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/events","assignees_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/assignees{/user}","branches_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/branches{/branch}","tags_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/tags","blobs_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/statuses/{sha}","languages_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/languages","stargazers_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/stargazers","contributors_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/contributors","subscribers_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/subscribers","subscription_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/subscription","commits_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/contents/{+path}","compare_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/merges","archive_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/downloads","issues_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/issues{/number}","pulls_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/pulls{/number}","milestones_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/milestones{/number}","notifications_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/labels{/name}","releases_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/releases{/id}","deployments_url":"https://api.github.com/repos/mmusgrov/microprofile-lra/deployments","created_at":"2018-05-18T13:54:40Z","updated_at":"2018-06-18T12:53:53Z","pushed_at":"2018-06-23T14:15:03Z","git_url":"git://github.com/mmusgrov/microprofile-lra.git","ssh_url":"git@github.com:mmusgrov/microprofile-lra.git","clone_url":"https://github.com/mmusgrov/microprofile-lra.git","svn_url":"https://github.com/mmusgrov/microprofile-lra","homepage":null,"size":518,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"microprofile-lra-v2"}},"base":{"label":"eclipse:master","ref":"master","sha":"91c6cfd394f2f794994810ecb580f28f5dbc3cf5","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":126884472,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODQ0NzI=","name":"microprofile-lra","full_name":"eclipse/microprofile-lra","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/microprofile-lra","description":"microprofile-lra","fork":false,"url":"https://api.github.com/repos/eclipse/microprofile-lra","forks_url":"https://api.github.com/repos/eclipse/microprofile-lra/forks","keys_url":"https://api.github.com/repos/eclipse/microprofile-lra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/microprofile-lra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/microprofile-lra/teams","hooks_url":"https://api.github.com/repos/eclipse/microprofile-lra/hooks","issue_events_url":"https://api.github.com/repos/eclipse/microprofile-lra/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/microprofile-lra/events","assignees_url":"https://api.github.com/repos/eclipse/microprofile-lra/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/microprofile-lra/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/microprofile-lra/tags","blobs_url":"https://api.github.com/repos/eclipse/microprofile-lra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/microprofile-lra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/microprofile-lra/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/microprofile-lra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/microprofile-lra/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/microprofile-lra/languages","stargazers_url":"https://api.github.com/repos/eclipse/microprofile-lra/stargazers","contributors_url":"https://api.github.com/repos/eclipse/microprofile-lra/contributors","subscribers_url":"https://api.github.com/repos/eclipse/microprofile-lra/subscribers","subscription_url":"https://api.github.com/repos/eclipse/microprofile-lra/subscription","commits_url":"https://api.github.com/repos/eclipse/microprofile-lra/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/microprofile-lra/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/microprofile-lra/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/microprofile-lra/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/microprofile-lra/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/microprofile-lra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/microprofile-lra/merges","archive_url":"https://api.github.com/repos/eclipse/microprofile-lra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/microprofile-lra/downloads","issues_url":"https://api.github.com/repos/eclipse/microprofile-lra/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/microprofile-lra/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/microprofile-lra/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/microprofile-lra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/microprofile-lra/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/microprofile-lra/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/microprofile-lra/deployments","created_at":"2018-03-26T20:12:49Z","updated_at":"2018-06-28T21:27:15Z","pushed_at":"2018-06-28T21:27:13Z","git_url":"git://github.com/eclipse/microprofile-lra.git","ssh_url":"git@github.com:eclipse/microprofile-lra.git","clone_url":"https://github.com/eclipse/microprofile-lra.git","svn_url":"https://github.com/eclipse/microprofile-lra","homepage":null,"size":474,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10"},"html":{"href":"https://github.com/eclipse/microprofile-lra/pull/10"},"issue":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/issues/10"},"comments":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/microprofile-lra/statuses/444890e972e81c1f213d0258291f9f169491eef3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tomjenkinson"}}