{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/13383","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/13383/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13383/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/13383/events","html_url":"https://github.com/highfidelity/hifi/pull/13383","id":332611489,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDUzNzIy","number":13383,"title":"Fix auto lasering locked web entities & only auto laser tablet and web overlays","user":{"login":"dback2","id":31390055,"node_id":"MDQ6VXNlcjMxMzkwMDU1","avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"labels":[{"id":743411186,"node_id":"MDU6TGFiZWw3NDM0MTExODY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":314155368,"node_id":"MDU6TGFiZWwzMTQxNTUzNjg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":461634431,"node_id":"MDU6TGFiZWw0NjE2MzQ0MzE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/HMD%20required","name":"HMD required","color":"d4c5f9","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/30","html_url":"https://github.com/highfidelity/hifi/milestone/30","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/30/labels","id":3290828,"node_id":"MDk6TWlsZXN0b25lMzI5MDgyOA==","number":30,"title":"RC70","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":30,"state":"open","created_at":"2018-04-23T19:27:01Z","updated_at":"2018-06-21T00:21:52Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2018-06-15T00:51:51Z","updated_at":"2018-06-21T15:40:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13383","html_url":"https://github.com/highfidelity/hifi/pull/13383","diff_url":"https://github.com/highfidelity/hifi/pull/13383.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13383.patch"},"body":"Prevent automatically showing the laser when pointing at a web entity that is locked since it can't be interacted with anyway.\r\n\r\nAlso only automatically show the laser when pointing at tablet or web overlays (as opposed to all overlays with ignoreRayIntersection=false before).\r\n\r\nAddresses: https://highfidelity.fogbugz.com/f/cases/15630/\r\n\r\nTest Plan:\r\n-Enter Interface in HMD.\r\n-Open tablet and point right hand at tablet verify the laser automatically shows without holding down the trigger.\r\n-Point right hand away from tablet and point left hand at tablet to verify the same behavior.\r\n-Open Create and create a Web entity.\r\n-Exit Create and point right hand and left hand individually at the Web entity to verify the laser automatically shows and pressing the trigger allows interacting with the web page.\r\n-Open Create and select the Web entity created above and lock it.\r\n-Point right hand and left hand individually at the Web entity to verify the laser does NOT automatically show since it is locked.\r\n-Go to 0,0,0 in your sandbox and enter the following in Developer menu -> Console:\r\n\r\nOverlays.addOverlay(\"sphere\", {\r\n                        color: { \"blue\": 0, \"green\": 0, \"red\": 255 },\r\n                        position: { x:0, y:0, z:0 },\r\n                        dimensions: { x:1, y: 1, z:1 },\r\n                        ignoreRayIntersection: false,\r\n                        solid: true\r\n                    });\r\n\r\nas well as the following:\r\n\r\nOverlays.addOverlay(\"web3d\", {\r\n            url: \"https://www.google.com\",\r\n            position: {x: 0, y:1, z:0},\r\n            dimensions: {x: .8, y: .45, z: 0.1},\r\n        });\r\n\r\n-In HMD verify when pointing either hand at the red sphere overlay created above that the laser is not automatically shown.\r\n-Also verify when pointing either hand at the google.com Web overlay created above that the laser does automatically show and pressing the trigger allows interacting with the web page."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/399148555","html_url":"https://github.com/highfidelity/hifi/pull/13383#issuecomment-399148555","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13383","id":399148555,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTE0ODU1NQ==","user":{"login":"qlimnavarro","id":36635278,"node_id":"MDQ6VXNlcjM2NjM1Mjc4","avatar_url":"https://avatars1.githubusercontent.com/u/36635278?v=4","gravatar_id":"","url":"https://api.github.com/users/qlimnavarro","html_url":"https://github.com/qlimnavarro","followers_url":"https://api.github.com/users/qlimnavarro/followers","following_url":"https://api.github.com/users/qlimnavarro/following{/other_user}","gists_url":"https://api.github.com/users/qlimnavarro/gists{/gist_id}","starred_url":"https://api.github.com/users/qlimnavarro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlimnavarro/subscriptions","organizations_url":"https://api.github.com/users/qlimnavarro/orgs","repos_url":"https://api.github.com/users/qlimnavarro/repos","events_url":"https://api.github.com/users/qlimnavarro/events{/privacy}","received_events_url":"https://api.github.com/users/qlimnavarro/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T15:40:44Z","updated_at":"2018-06-21T15:40:44Z","author_association":"NONE","body":"Pass @conklin94122 \r\nlasers and web entities look good."}}
{"actor":{"display_login":"qlimnavarro"}}