{"action":"created","comment":{"url":"https://api.github.com/repos/ParabolInc/action/pulls/comments/173364761","pull_request_review_id":102543984,"id":173364761,"diff_hunk":"@@ -58,10 +61,14 @@ if (!PROD) {\n   app.use(require('webpack-hot-middleware')(compiler)); // eslint-disable-line import/no-extraneous-dependencies\n   /* eslint-enable global-require */\n }\n-\n+Raven.config(process.env.SENTRY_DSN, {\n+  release: version,\n+  environment: process.env.NODE_ENV,\n+  parseUser: jwtFields","path":"src/server/server.js","position":28,"original_position":28,"commit_id":"3abfd7f857085b1494ae4181b780b5051f52ca1a","original_commit_id":"3abfd7f857085b1494ae4181b780b5051f52ca1a","user":{"login":"jordanh","id":103000,"avatar_url":"https://avatars2.githubusercontent.com/u/103000?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanh","html_url":"https://github.com/jordanh","followers_url":"https://api.github.com/users/jordanh/followers","following_url":"https://api.github.com/users/jordanh/following{/other_user}","gists_url":"https://api.github.com/users/jordanh/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanh/subscriptions","organizations_url":"https://api.github.com/users/jordanh/orgs","repos_url":"https://api.github.com/users/jordanh/repos","events_url":"https://api.github.com/users/jordanh/events{/privacy}","received_events_url":"https://api.github.com/users/jordanh/received_events","type":"User","site_admin":false},"body":"Awesome.","created_at":"2018-03-09T04:47:37Z","updated_at":"2018-03-09T04:52:37Z","html_url":"https://github.com/ParabolInc/action/pull/1865#discussion_r173364761","pull_request_url":"https://api.github.com/repos/ParabolInc/action/pulls/1865","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/comments/173364761"},"html":{"href":"https://github.com/ParabolInc/action/pull/1865#discussion_r173364761"},"pull_request":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/1865"}}},"pull_request":{"url":"https://api.github.com/repos/ParabolInc/action/pulls/1865","id":173889005,"html_url":"https://github.com/ParabolInc/action/pull/1865","diff_url":"https://github.com/ParabolInc/action/pull/1865.diff","patch_url":"https://github.com/ParabolInc/action/pull/1865.patch","issue_url":"https://api.github.com/repos/ParabolInc/action/issues/1865","number":1865,"state":"open","locked":false,"title":"Stop the bork - gracefully handle server errors","user":{"login":"mattkrick","id":5514175,"avatar_url":"https://avatars0.githubusercontent.com/u/5514175?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkrick","html_url":"https://github.com/mattkrick","followers_url":"https://api.github.com/users/mattkrick/followers","following_url":"https://api.github.com/users/mattkrick/following{/other_user}","gists_url":"https://api.github.com/users/mattkrick/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkrick/subscriptions","organizations_url":"https://api.github.com/users/mattkrick/orgs","repos_url":"https://api.github.com/users/mattkrick/repos","events_url":"https://api.github.com/users/mattkrick/events{/privacy}","received_events_url":"https://api.github.com/users/mattkrick/received_events","type":"User","site_admin":false},"body":"Recently, we've been fighting too many fires.\r\nWe goof up, and instead of that goof up gracefully landing in sentry, the customer's screen goes white & there are no errors in the console.\r\nThis fixes that. Fixes #1774\r\n\r\nThere were a few things going wrong:\r\n- The dataloader would throw an error if there was a missing foreign key. Albeit if a foreign key doesn't exist, it is 100% our fault, but the penalty for failure was too severe (blank screen of death). Now, we log it and send down the null value to the client. It's then up to the client to handle it gracefully\r\n- The client was not handling errors gracefully for HTTP requests. This was my fault. I now pass whatever values, good or bad, into relay & then we can handle it with onError callbacks if need be.\r\n- The client was not handling errors gracefully for websocket requests. This was Apollo's fault. When GraphQL encounters an error, it sends the data that it _could_ fetch, plus the error that it encountered. _Apollo ignores all that beautiful 99% correct data_. I can't fix this without rewriting the client, so for now, I trick it by having the server tell it it's not an error. \r\n- We weren't sending any errors to sentry from the server. Now we do, so we no longer have to `dokku logs web`. yay! \r\n\r\nTEST\r\n- [ ] Create 2 users, as user A, assign a task to user B so they get a \"TASK_INVOLVES\" notification, exit the browser for user A.\r\n- [ ] go into the database (localhost:8080) find that notification & change the type to \"X\"\r\n- [ ] Refresh the page, notice it doesn't white screen.\r\n- [ ] look at the server log (locally), notice it shows an error\r\n- [ ] run `yarn bs` & use the SENTRY_DNS key that's on the staging server environment, or just run this on the dev server. Repeat the steps. Instead of seeing an error in the server console, you see nothing, but an error does show up in sentry (example: https://sentry.io/parabol/action-staging/issues/484351180/)\r\n- [ ] go into the database & revert the type back to TASK_INVOLVES but now set the notification's taskId to 'X'.\r\n- [ ] Refresh & notice there isn't a blank white page\r\n- [ ] Get a similar message sent to sentry (example: https://sentry.io/parabol/action-staging/issues/484298502/events/15455592846/)","created_at":"2018-03-09T00:27:19Z","updated_at":"2018-03-09T04:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f79667c6c3acacdf4a0a5f8246a5e7ce5e8de7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParabolInc/action/pulls/1865/commits","review_comments_url":"https://api.github.com/repos/ParabolInc/action/pulls/1865/comments","review_comment_url":"https://api.github.com/repos/ParabolInc/action/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParabolInc/action/issues/1865/comments","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/3abfd7f857085b1494ae4181b780b5051f52ca1a","head":{"label":"ParabolInc:fix-dataloader-exceptions","ref":"fix-dataloader-exceptions","sha":"3abfd7f857085b1494ae4181b780b5051f52ca1a","user":{"login":"ParabolInc","id":14169569,"avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48384473,"name":"action","full_name":"ParabolInc/action","owner":{"login":"ParabolInc","id":14169569,"avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParabolInc/action","description":"A multiplayer web application for building smarter, more agile teams.","fork":false,"url":"https://api.github.com/repos/ParabolInc/action","forks_url":"https://api.github.com/repos/ParabolInc/action/forks","keys_url":"https://api.github.com/repos/ParabolInc/action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParabolInc/action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParabolInc/action/teams","hooks_url":"https://api.github.com/repos/ParabolInc/action/hooks","issue_events_url":"https://api.github.com/repos/ParabolInc/action/issues/events{/number}","events_url":"https://api.github.com/repos/ParabolInc/action/events","assignees_url":"https://api.github.com/repos/ParabolInc/action/assignees{/user}","branches_url":"https://api.github.com/repos/ParabolInc/action/branches{/branch}","tags_url":"https://api.github.com/repos/ParabolInc/action/tags","blobs_url":"https://api.github.com/repos/ParabolInc/action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParabolInc/action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParabolInc/action/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParabolInc/action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/{sha}","languages_url":"https://api.github.com/repos/ParabolInc/action/languages","stargazers_url":"https://api.github.com/repos/ParabolInc/action/stargazers","contributors_url":"https://api.github.com/repos/ParabolInc/action/contributors","subscribers_url":"https://api.github.com/repos/ParabolInc/action/subscribers","subscription_url":"https://api.github.com/repos/ParabolInc/action/subscription","commits_url":"https://api.github.com/repos/ParabolInc/action/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParabolInc/action/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParabolInc/action/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParabolInc/action/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParabolInc/action/contents/{+path}","compare_url":"https://api.github.com/repos/ParabolInc/action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParabolInc/action/merges","archive_url":"https://api.github.com/repos/ParabolInc/action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParabolInc/action/downloads","issues_url":"https://api.github.com/repos/ParabolInc/action/issues{/number}","pulls_url":"https://api.github.com/repos/ParabolInc/action/pulls{/number}","milestones_url":"https://api.github.com/repos/ParabolInc/action/milestones{/number}","notifications_url":"https://api.github.com/repos/ParabolInc/action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParabolInc/action/labels{/name}","releases_url":"https://api.github.com/repos/ParabolInc/action/releases{/id}","deployments_url":"https://api.github.com/repos/ParabolInc/action/deployments","created_at":"2015-12-21T17:16:49Z","updated_at":"2018-03-09T02:59:38Z","pushed_at":"2018-03-09T00:27:20Z","git_url":"git://github.com/ParabolInc/action.git","ssh_url":"git@github.com:ParabolInc/action.git","clone_url":"https://github.com/ParabolInc/action.git","svn_url":"https://github.com/ParabolInc/action","homepage":"http://parabol.co/","size":31395,"stargazers_count":461,"watchers_count":461,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":305,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":81,"open_issues":305,"watchers":461,"default_branch":"master"}},"base":{"label":"ParabolInc:master","ref":"master","sha":"5ebafaba04bbbd3ee72470c8c271f41fe5e1f773","user":{"login":"ParabolInc","id":14169569,"avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48384473,"name":"action","full_name":"ParabolInc/action","owner":{"login":"ParabolInc","id":14169569,"avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParabolInc/action","description":"A multiplayer web application for building smarter, more agile teams.","fork":false,"url":"https://api.github.com/repos/ParabolInc/action","forks_url":"https://api.github.com/repos/ParabolInc/action/forks","keys_url":"https://api.github.com/repos/ParabolInc/action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParabolInc/action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParabolInc/action/teams","hooks_url":"https://api.github.com/repos/ParabolInc/action/hooks","issue_events_url":"https://api.github.com/repos/ParabolInc/action/issues/events{/number}","events_url":"https://api.github.com/repos/ParabolInc/action/events","assignees_url":"https://api.github.com/repos/ParabolInc/action/assignees{/user}","branches_url":"https://api.github.com/repos/ParabolInc/action/branches{/branch}","tags_url":"https://api.github.com/repos/ParabolInc/action/tags","blobs_url":"https://api.github.com/repos/ParabolInc/action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParabolInc/action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParabolInc/action/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParabolInc/action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/{sha}","languages_url":"https://api.github.com/repos/ParabolInc/action/languages","stargazers_url":"https://api.github.com/repos/ParabolInc/action/stargazers","contributors_url":"https://api.github.com/repos/ParabolInc/action/contributors","subscribers_url":"https://api.github.com/repos/ParabolInc/action/subscribers","subscription_url":"https://api.github.com/repos/ParabolInc/action/subscription","commits_url":"https://api.github.com/repos/ParabolInc/action/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParabolInc/action/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParabolInc/action/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParabolInc/action/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParabolInc/action/contents/{+path}","compare_url":"https://api.github.com/repos/ParabolInc/action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParabolInc/action/merges","archive_url":"https://api.github.com/repos/ParabolInc/action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParabolInc/action/downloads","issues_url":"https://api.github.com/repos/ParabolInc/action/issues{/number}","pulls_url":"https://api.github.com/repos/ParabolInc/action/pulls{/number}","milestones_url":"https://api.github.com/repos/ParabolInc/action/milestones{/number}","notifications_url":"https://api.github.com/repos/ParabolInc/action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParabolInc/action/labels{/name}","releases_url":"https://api.github.com/repos/ParabolInc/action/releases{/id}","deployments_url":"https://api.github.com/repos/ParabolInc/action/deployments","created_at":"2015-12-21T17:16:49Z","updated_at":"2018-03-09T02:59:38Z","pushed_at":"2018-03-09T00:27:20Z","git_url":"git://github.com/ParabolInc/action.git","ssh_url":"git@github.com:ParabolInc/action.git","clone_url":"https://github.com/ParabolInc/action.git","svn_url":"https://github.com/ParabolInc/action","homepage":"http://parabol.co/","size":31395,"stargazers_count":461,"watchers_count":461,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":305,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":81,"open_issues":305,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/1865"},"html":{"href":"https://github.com/ParabolInc/action/pull/1865"},"issue":{"href":"https://api.github.com/repos/ParabolInc/action/issues/1865"},"comments":{"href":"https://api.github.com/repos/ParabolInc/action/issues/1865/comments"},"review_comments":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/1865/comments"},"review_comment":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/1865/commits"},"statuses":{"href":"https://api.github.com/repos/ParabolInc/action/statuses/3abfd7f857085b1494ae4181b780b5051f52ca1a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jordanh"}}