{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/14232","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/14232/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14232/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/14232/events","html_url":"https://github.com/sympy/sympy/pull/14232","id":297723635,"number":14232,"title":"improved solveset for improper symbols","user":{"login":"Yathartha22","id":14955840,"avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-16T09:27:30Z","updated_at":"2018-02-17T04:40:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14232","html_url":"https://github.com/sympy/sympy/pull/14232","diff_url":"https://github.com/sympy/sympy/pull/14232.diff","patch_url":"https://github.com/sympy/sympy/pull/14232.patch"},"body":"It seems that #13415 got some issues:\r\n\r\nSuppose\r\n```\r\n>>> solveset(x+1, S.Reals)\r\nEmptySet()\r\n```\r\nHere it sees `S.Reals` as a symbol and `S.Complexes` as the domain (which is not quite the users intention), therefore it should raise a `ValueError`.\r\n\r\nAlso, the discussions in #12217 concludes that solveset should not be made to give result for unknown symbols instead a `ValueError` should be raised.\r\n\r\nAs @Shekharrajak quoted:\r\n\r\n> solveset 2nd arg should be symbol not any expression. So solveset should not return that ans, it is not made for solving expression. (There must be ValueError in this case)\r\n\r\nping @asmeurer @smichr @Shekharrajak "},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/366416214","html_url":"https://github.com/sympy/sympy/pull/14232#issuecomment-366416214","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14232","id":366416214,"user":{"login":"Yathartha22","id":14955840,"avatar_url":"https://avatars1.githubusercontent.com/u/14955840?v=4","gravatar_id":"","url":"https://api.github.com/users/Yathartha22","html_url":"https://github.com/Yathartha22","followers_url":"https://api.github.com/users/Yathartha22/followers","following_url":"https://api.github.com/users/Yathartha22/following{/other_user}","gists_url":"https://api.github.com/users/Yathartha22/gists{/gist_id}","starred_url":"https://api.github.com/users/Yathartha22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yathartha22/subscriptions","organizations_url":"https://api.github.com/users/Yathartha22/orgs","repos_url":"https://api.github.com/users/Yathartha22/repos","events_url":"https://api.github.com/users/Yathartha22/events{/privacy}","received_events_url":"https://api.github.com/users/Yathartha22/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T04:40:47Z","updated_at":"2018-02-17T04:40:47Z","author_association":"CONTRIBUTOR","body":"What about this discrepancy:\r\n\r\n```\r\n>>> solveset(x+1, S.Reals)\r\nEmptySet()\r\n```"}}
{"actor":{"display_login":"Yathartha22"}}