{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/1576","repository_url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler","labels_url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/1576/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/1576/comments","events_url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/1576/events","html_url":"https://github.com/strongloop/loopback-datasource-juggler/pull/1576","id":318653966,"number":1576,"title":"Fix #1519","user":{"login":"Yaty","id":11981803,"avatar_url":"https://avatars0.githubusercontent.com/u/11981803?v=4","gravatar_id":"","url":"https://api.github.com/users/Yaty","html_url":"https://github.com/Yaty","followers_url":"https://api.github.com/users/Yaty/followers","following_url":"https://api.github.com/users/Yaty/following{/other_user}","gists_url":"https://api.github.com/users/Yaty/gists{/gist_id}","starred_url":"https://api.github.com/users/Yaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yaty/subscriptions","organizations_url":"https://api.github.com/users/Yaty/orgs","repos_url":"https://api.github.com/users/Yaty/repos","events_url":"https://api.github.com/users/Yaty/events{/privacy}","received_events_url":"https://api.github.com/users/Yaty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-28T17:21:43Z","updated_at":"2018-05-24T00:36:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/pulls/1576","html_url":"https://github.com/strongloop/loopback-datasource-juggler/pull/1576","diff_url":"https://github.com/strongloop/loopback-datasource-juggler/pull/1576.diff","patch_url":"https://github.com/strongloop/loopback-datasource-juggler/pull/1576.patch"},"body":"Status : WIP\r\n\r\n### Description\r\n\r\nAdd allowBlank and allowNull opions to validatesAbsenceOf\r\nMake allowBlank and allowNull to false when forceId if set to true\r\n\r\nMy test are passing but I broke other tests like this one : https://github.com/strongloop/loopback-datasource-juggler/blob/1ef38a6929ae100c73030b720097ba5c4b90a7b3/test/optional-validation.test.js#L117\r\nIt seems that the validation is made before the ID is generated so it breaks.\r\nThis is the first time I'm working on this codebase, any tips where I should look :) ?\r\n\r\n#### Related issues\r\n\r\n#1519\r\n\r\n### Checklist\r\n\r\n- [x] New tests added or existing tests modified to cover all changes\r\n- [x] Code conforms with the [style\r\n  guide](http://loopback.io/doc/en/contrib/style-guide.html)\r\n"},"comment":{"url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/comments/391547013","html_url":"https://github.com/strongloop/loopback-datasource-juggler/pull/1576#issuecomment-391547013","issue_url":"https://api.github.com/repos/strongloop/loopback-datasource-juggler/issues/1576","id":391547013,"user":{"login":"nitro404","id":716716,"avatar_url":"https://avatars1.githubusercontent.com/u/716716?v=4","gravatar_id":"","url":"https://api.github.com/users/nitro404","html_url":"https://github.com/nitro404","followers_url":"https://api.github.com/users/nitro404/followers","following_url":"https://api.github.com/users/nitro404/following{/other_user}","gists_url":"https://api.github.com/users/nitro404/gists{/gist_id}","starred_url":"https://api.github.com/users/nitro404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitro404/subscriptions","organizations_url":"https://api.github.com/users/nitro404/orgs","repos_url":"https://api.github.com/users/nitro404/repos","events_url":"https://api.github.com/users/nitro404/events{/privacy}","received_events_url":"https://api.github.com/users/nitro404/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T00:36:55Z","updated_at":"2018-05-24T00:36:55Z","author_association":"CONTRIBUTOR","body":"It would probably be beneficial to squash or amend these commits together as they both seem to have the same message, and is a bit confusing, unless there is some reason to keep them separate."}}
{"actor":{"display_login":"nitro404"}}