{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments/237272345","pull_request_review_id":179531229,"id":237272345,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI3MjM0NQ==","diff_hunk":"@@ -659,6 +660,117 @@ object ResourceTypeHandlerTest {\n     defaultHandler.deletionTimestamp(configuration) shouldMatch equalTo(plus2Days)\n   }\n \n+  @Test\n+  fun `update delete timestamp should work`() {\n+    val timestamp10days = clock.millis().plus(TimeUnit.DAYS.toMillis(10))\n+    val timestamp1hour = clock.millis().plus(TimeUnit.HOURS.toMillis(1))\n+    val resource1 = TestResource(","path":"swabbie-core/src/test/kotlin/com/netflix/spinnaker/swabbie/ResourceTypeHandlerTest.kt","position":16,"original_position":16,"commit_id":"5bb6493158159a6579295385b1bc0c345e1d647a","original_commit_id":"dc666deadfc97006b6597bed573964482a4757a7","user":{"login":"ajordens","id":388652,"node_id":"MDQ6VXNlcjM4ODY1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/388652?v=4","gravatar_id":"","url":"https://api.github.com/users/ajordens","html_url":"https://github.com/ajordens","followers_url":"https://api.github.com/users/ajordens/followers","following_url":"https://api.github.com/users/ajordens/following{/other_user}","gists_url":"https://api.github.com/users/ajordens/gists{/gist_id}","starred_url":"https://api.github.com/users/ajordens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajordens/subscriptions","organizations_url":"https://api.github.com/users/ajordens/orgs","repos_url":"https://api.github.com/users/ajordens/repos","events_url":"https://api.github.com/users/ajordens/events{/privacy}","received_events_url":"https://api.github.com/users/ajordens/received_events","type":"User","site_admin":false},"body":"👍 \r\n","created_at":"2018-11-28T21:42:31Z","updated_at":"2018-11-28T21:42:31Z","html_url":"https://github.com/spinnaker/swabbie/pull/167#discussion_r237272345","pull_request_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/167","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments/237272345"},"html":{"href":"https://github.com/spinnaker/swabbie/pull/167#discussion_r237272345"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/167"}},"in_reply_to_id":237261156},"pull_request":{"url":"https://api.github.com/repos/spinnaker/swabbie/pulls/167","id":234414573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDE0NTcz","html_url":"https://github.com/spinnaker/swabbie/pull/167","diff_url":"https://github.com/spinnaker/swabbie/pull/167.diff","patch_url":"https://github.com/spinnaker/swabbie/pull/167.patch","issue_url":"https://api.github.com/repos/spinnaker/swabbie/issues/167","number":167,"state":"open","locked":false,"title":"feat(deleteTime): recalculate time for some resources","user":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"body":"We may want to update the deletion time of a bunch of resources, like if we want to speed up or slow down deletion of resources.\r\n\r\nThis admin endpoint lets you update the deletion time for the oldest `numResources` resources to a value of `retentionS` seconds from now. It operates in a single namespace.","created_at":"2018-11-28T20:32:17Z","updated_at":"2018-11-28T21:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb4c1ec43579cedb8504a62cc9e7a708eda10dba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asher","id":59994,"node_id":"MDQ6VXNlcjU5OTk0","avatar_url":"https://avatars1.githubusercontent.com/u/59994?v=4","gravatar_id":"","url":"https://api.github.com/users/asher","html_url":"https://github.com/asher","followers_url":"https://api.github.com/users/asher/followers","following_url":"https://api.github.com/users/asher/following{/other_user}","gists_url":"https://api.github.com/users/asher/gists{/gist_id}","starred_url":"https://api.github.com/users/asher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asher/subscriptions","organizations_url":"https://api.github.com/users/asher/orgs","repos_url":"https://api.github.com/users/asher/repos","events_url":"https://api.github.com/users/asher/events{/privacy}","received_events_url":"https://api.github.com/users/asher/received_events","type":"User","site_admin":false},{"login":"robzienert","id":108741,"node_id":"MDQ6VXNlcjEwODc0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/108741?v=4","gravatar_id":"","url":"https://api.github.com/users/robzienert","html_url":"https://github.com/robzienert","followers_url":"https://api.github.com/users/robzienert/followers","following_url":"https://api.github.com/users/robzienert/following{/other_user}","gists_url":"https://api.github.com/users/robzienert/gists{/gist_id}","starred_url":"https://api.github.com/users/robzienert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robzienert/subscriptions","organizations_url":"https://api.github.com/users/robzienert/orgs","repos_url":"https://api.github.com/users/robzienert/repos","events_url":"https://api.github.com/users/robzienert/events{/privacy}","received_events_url":"https://api.github.com/users/robzienert/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/167/commits","review_comments_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/167/comments","review_comment_url":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/swabbie/issues/167/comments","statuses_url":"https://api.github.com/repos/spinnaker/swabbie/statuses/5bb6493158159a6579295385b1bc0c345e1d647a","head":{"label":"emjburns:recalculate-delete-time","ref":"recalculate-delete-time","sha":"5bb6493158159a6579295385b1bc0c345e1d647a","user":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"repo":{"id":139478690,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0Nzg2OTA=","name":"swabbie","full_name":"emjburns/swabbie","private":false,"owner":{"login":"emjburns","id":8454927,"node_id":"MDQ6VXNlcjg0NTQ5Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/8454927?v=4","gravatar_id":"","url":"https://api.github.com/users/emjburns","html_url":"https://github.com/emjburns","followers_url":"https://api.github.com/users/emjburns/followers","following_url":"https://api.github.com/users/emjburns/following{/other_user}","gists_url":"https://api.github.com/users/emjburns/gists{/gist_id}","starred_url":"https://api.github.com/users/emjburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emjburns/subscriptions","organizations_url":"https://api.github.com/users/emjburns/orgs","repos_url":"https://api.github.com/users/emjburns/repos","events_url":"https://api.github.com/users/emjburns/events{/privacy}","received_events_url":"https://api.github.com/users/emjburns/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emjburns/swabbie","description":"Spinnaker's janitor service","fork":true,"url":"https://api.github.com/repos/emjburns/swabbie","forks_url":"https://api.github.com/repos/emjburns/swabbie/forks","keys_url":"https://api.github.com/repos/emjburns/swabbie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emjburns/swabbie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emjburns/swabbie/teams","hooks_url":"https://api.github.com/repos/emjburns/swabbie/hooks","issue_events_url":"https://api.github.com/repos/emjburns/swabbie/issues/events{/number}","events_url":"https://api.github.com/repos/emjburns/swabbie/events","assignees_url":"https://api.github.com/repos/emjburns/swabbie/assignees{/user}","branches_url":"https://api.github.com/repos/emjburns/swabbie/branches{/branch}","tags_url":"https://api.github.com/repos/emjburns/swabbie/tags","blobs_url":"https://api.github.com/repos/emjburns/swabbie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emjburns/swabbie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emjburns/swabbie/git/refs{/sha}","trees_url":"https://api.github.com/repos/emjburns/swabbie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emjburns/swabbie/statuses/{sha}","languages_url":"https://api.github.com/repos/emjburns/swabbie/languages","stargazers_url":"https://api.github.com/repos/emjburns/swabbie/stargazers","contributors_url":"https://api.github.com/repos/emjburns/swabbie/contributors","subscribers_url":"https://api.github.com/repos/emjburns/swabbie/subscribers","subscription_url":"https://api.github.com/repos/emjburns/swabbie/subscription","commits_url":"https://api.github.com/repos/emjburns/swabbie/commits{/sha}","git_commits_url":"https://api.github.com/repos/emjburns/swabbie/git/commits{/sha}","comments_url":"https://api.github.com/repos/emjburns/swabbie/comments{/number}","issue_comment_url":"https://api.github.com/repos/emjburns/swabbie/issues/comments{/number}","contents_url":"https://api.github.com/repos/emjburns/swabbie/contents/{+path}","compare_url":"https://api.github.com/repos/emjburns/swabbie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emjburns/swabbie/merges","archive_url":"https://api.github.com/repos/emjburns/swabbie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emjburns/swabbie/downloads","issues_url":"https://api.github.com/repos/emjburns/swabbie/issues{/number}","pulls_url":"https://api.github.com/repos/emjburns/swabbie/pulls{/number}","milestones_url":"https://api.github.com/repos/emjburns/swabbie/milestones{/number}","notifications_url":"https://api.github.com/repos/emjburns/swabbie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emjburns/swabbie/labels{/name}","releases_url":"https://api.github.com/repos/emjburns/swabbie/releases{/id}","deployments_url":"https://api.github.com/repos/emjburns/swabbie/deployments","created_at":"2018-07-02T18:17:28Z","updated_at":"2018-11-21T21:00:46Z","pushed_at":"2018-11-28T21:39:33Z","git_url":"git://github.com/emjburns/swabbie.git","ssh_url":"git@github.com:emjburns/swabbie.git","clone_url":"https://github.com/emjburns/swabbie.git","svn_url":"https://github.com/emjburns/swabbie","homepage":"","size":1031,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"7a6bbd56c69536eaaaf348580e28176c1a1887f8","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":90665799,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY2NTc5OQ==","name":"swabbie","full_name":"spinnaker/swabbie","private":false,"owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spinnaker/swabbie","description":"Spinnaker's clean up service","fork":false,"url":"https://api.github.com/repos/spinnaker/swabbie","forks_url":"https://api.github.com/repos/spinnaker/swabbie/forks","keys_url":"https://api.github.com/repos/spinnaker/swabbie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/swabbie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/swabbie/teams","hooks_url":"https://api.github.com/repos/spinnaker/swabbie/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/swabbie/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/swabbie/events","assignees_url":"https://api.github.com/repos/spinnaker/swabbie/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/swabbie/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/swabbie/tags","blobs_url":"https://api.github.com/repos/spinnaker/swabbie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/swabbie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/swabbie/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/swabbie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/swabbie/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/swabbie/languages","stargazers_url":"https://api.github.com/repos/spinnaker/swabbie/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/swabbie/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/swabbie/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/swabbie/subscription","commits_url":"https://api.github.com/repos/spinnaker/swabbie/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/swabbie/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/swabbie/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/swabbie/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/swabbie/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/swabbie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/swabbie/merges","archive_url":"https://api.github.com/repos/spinnaker/swabbie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/swabbie/downloads","issues_url":"https://api.github.com/repos/spinnaker/swabbie/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/swabbie/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/swabbie/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/swabbie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/swabbie/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/swabbie/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/swabbie/deployments","created_at":"2017-05-08T19:39:33Z","updated_at":"2018-11-28T16:38:33Z","pushed_at":"2018-11-28T21:39:35Z","git_url":"git://github.com/spinnaker/swabbie.git","ssh_url":"git@github.com:spinnaker/swabbie.git","clone_url":"https://github.com/spinnaker/swabbie.git","svn_url":"https://github.com/spinnaker/swabbie","homepage":"","size":972,"stargazers_count":52,"watchers_count":52,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":12,"open_issues":6,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/167"},"html":{"href":"https://github.com/spinnaker/swabbie/pull/167"},"issue":{"href":"https://api.github.com/repos/spinnaker/swabbie/issues/167"},"comments":{"href":"https://api.github.com/repos/spinnaker/swabbie/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/swabbie/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/swabbie/statuses/5bb6493158159a6579295385b1bc0c345e1d647a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajordens"}}