{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/reaction/issues/1462","repository_url":"https://api.github.com/repos/artsy/reaction","labels_url":"https://api.github.com/repos/artsy/reaction/issues/1462/labels{/name}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/1462/comments","events_url":"https://api.github.com/repos/artsy/reaction/issues/1462/events","html_url":"https://github.com/artsy/reaction/pull/1462","id":374234551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTgyMTE0","number":1462,"title":"[Tests] Fix RelayStubProvider errors in Jest","user":{"login":"damassi","id":236943,"node_id":"MDQ6VXNlcjIzNjk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/236943?v=4","gravatar_id":"","url":"https://api.github.com/users/damassi","html_url":"https://github.com/damassi","followers_url":"https://api.github.com/users/damassi/followers","following_url":"https://api.github.com/users/damassi/following{/other_user}","gists_url":"https://api.github.com/users/damassi/gists{/gist_id}","starred_url":"https://api.github.com/users/damassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damassi/subscriptions","organizations_url":"https://api.github.com/users/damassi/orgs","repos_url":"https://api.github.com/users/damassi/repos","events_url":"https://api.github.com/users/damassi/events{/privacy}","received_events_url":"https://api.github.com/users/damassi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-10-26T05:42:31Z","updated_at":"2018-10-26T17:20:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/1462","html_url":"https://github.com/artsy/reaction/pull/1462","diff_url":"https://github.com/artsy/reaction/pull/1462.diff","patch_url":"https://github.com/artsy/reaction/pull/1462.patch"},"body":"Some background context is in this [Slack thread](https://artsy.slack.com/archives/CAZG82X4G/p1540517734000100) but in short I found myself continuously fighting with the mock network layer and realized that if we could make it so that `<RelayStubProvider>` (which we use in Storybooks and elsewhere) doesn't error out in the test environment then that's likely all that we'll need for most general tests since it provides for a way of passing in data without needing mocks. It renders exactly the same as if we were going through the full  GraphQL resolution flow, but without the setup complexity.\r\n\r\n@alloy, @mzikherman, @sweir27 - thoughts? \r\n\r\nI've posted some comments inline. "},"comment":{"url":"https://api.github.com/repos/artsy/reaction/issues/comments/433481348","html_url":"https://github.com/artsy/reaction/pull/1462#issuecomment-433481348","issue_url":"https://api.github.com/repos/artsy/reaction/issues/1462","id":433481348,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ4MTM0OA==","user":{"login":"damassi","id":236943,"node_id":"MDQ6VXNlcjIzNjk0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/236943?v=4","gravatar_id":"","url":"https://api.github.com/users/damassi","html_url":"https://github.com/damassi","followers_url":"https://api.github.com/users/damassi/followers","following_url":"https://api.github.com/users/damassi/following{/other_user}","gists_url":"https://api.github.com/users/damassi/gists{/gist_id}","starred_url":"https://api.github.com/users/damassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damassi/subscriptions","organizations_url":"https://api.github.com/users/damassi/orgs","repos_url":"https://api.github.com/users/damassi/repos","events_url":"https://api.github.com/users/damassi/events{/privacy}","received_events_url":"https://api.github.com/users/damassi/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T17:20:06Z","updated_at":"2018-10-26T17:20:06Z","author_association":"MEMBER","body":"> Could you do me a solid and leave a failing example in of the issues with connections you had?\r\n\r\nYup! I'll add a repo PR. (And looking over other stuff now.)"}}
{"actor":{"display_login":"damassi"}}