{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/evmc/pulls/comments/196604029","pull_request_review_id":130189592,"id":196604029,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjYwNDAyOQ==","diff_hunk":"@@ -687,6 +687,66 @@ typedef struct evmc_result (*evmc_execute_fn)(struct evmc_instance* instance,\n                                               size_t code_size);\n \n \n+/** The opaque type representing a Client-side tracer object. */\n+struct evmc_tracer_context;\n+\n+/**\n+ * The callback to trace instructions execution in an EVM.\n+ *\n+ * This function informs the Client what instruction has been executed in the EVM implementation\n+ * and what are the results of the execution this particular instruction.\n+ * The message level information (like call depth, destination address, etc.) are not provided here.\n+ * This piece of information can be acquired by inspecting messages being sent to the EVM in\n+ * ::evmc_execute_fn and the results of the messages execution.\n+ *\n+ * @param context                The pointer to the Client-side tracing context. This allows to\n+ *                               implement the tracer in OOP manner.\n+ * @param step                   The instruction counter: number of instructions executed.\n+ *                               This counter starts from 0 for every message passed to\n+ *                               ::evmc_execute_fn.\n+ * @param code_offset            The current instruction position in the code.\n+ * @param status_code            The status code of the instruction execution.\n+ * @param gas_left               The amount of the gas left after the instruction execution.\n+ * @param stack_num_items        The current EVM stack height after the instruction execution.\n+ * @param pushed_stack_item      The top EVM stack item pushed as the result of the instruction","path":"include/evmc/evmc.h","position":34,"original_position":34,"commit_id":"f8ffc2caa7610df63995134ea70fc8df16eac032","original_commit_id":"f8ffc2caa7610df63995134ea70fc8df16eac032","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"So based on these two the client needs to apply the stack changes?","created_at":"2018-06-19T22:56:48Z","updated_at":"2018-06-19T22:56:48Z","html_url":"https://github.com/ethereum/evmc/pull/32#discussion_r196604029","pull_request_url":"https://api.github.com/repos/ethereum/evmc/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/comments/196604029"},"html":{"href":"https://github.com/ethereum/evmc/pull/32#discussion_r196604029"},"pull_request":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/evmc/pulls/32","id":187455897,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NDU1ODk3","html_url":"https://github.com/ethereum/evmc/pull/32","diff_url":"https://github.com/ethereum/evmc/pull/32.diff","patch_url":"https://github.com/ethereum/evmc/pull/32.patch","issue_url":"https://api.github.com/repos/ethereum/evmc/issues/32","number":32,"state":"open","locked":false,"title":"Tracing API","user":{"login":"chfast","id":573380,"node_id":"MDQ6VXNlcjU3MzM4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"Fixes #22.","created_at":"2018-05-11T12:54:34Z","updated_at":"2018-06-19T22:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d450e30c0db479522b86a879267682c9a440d0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/evmc/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ethereum/evmc/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ethereum/evmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/evmc/issues/32/comments","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/f8ffc2caa7610df63995134ea70fc8df16eac032","head":{"label":"ethereum:tracing","ref":"tracing","sha":"f8ffc2caa7610df63995134ea70fc8df16eac032","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":66214407,"node_id":"MDEwOlJlcG9zaXRvcnk2NjIxNDQwNw==","name":"evmc","full_name":"ethereum/evmc","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/evmc","description":"EVMC – Ethereum Client-VM Connector API","fork":false,"url":"https://api.github.com/repos/ethereum/evmc","forks_url":"https://api.github.com/repos/ethereum/evmc/forks","keys_url":"https://api.github.com/repos/ethereum/evmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmc/teams","hooks_url":"https://api.github.com/repos/ethereum/evmc/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmc/events","assignees_url":"https://api.github.com/repos/ethereum/evmc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmc/tags","blobs_url":"https://api.github.com/repos/ethereum/evmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmc/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmc/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmc/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmc/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmc/subscription","commits_url":"https://api.github.com/repos/ethereum/evmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmc/merges","archive_url":"https://api.github.com/repos/ethereum/evmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmc/downloads","issues_url":"https://api.github.com/repos/ethereum/evmc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmc/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmc/deployments","created_at":"2016-08-21T18:35:02Z","updated_at":"2018-06-18T16:57:48Z","pushed_at":"2018-06-19T20:31:08Z","git_url":"git://github.com/ethereum/evmc.git","ssh_url":"git@github.com:ethereum/evmc.git","clone_url":"https://github.com/ethereum/evmc.git","svn_url":"https://github.com/ethereum/evmc","homepage":"https://ethereum.github.io/evmc","size":450,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":14,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"cb2288b49d460d388831e45ba310e43ad2e3bf06","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":66214407,"node_id":"MDEwOlJlcG9zaXRvcnk2NjIxNDQwNw==","name":"evmc","full_name":"ethereum/evmc","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/evmc","description":"EVMC – Ethereum Client-VM Connector API","fork":false,"url":"https://api.github.com/repos/ethereum/evmc","forks_url":"https://api.github.com/repos/ethereum/evmc/forks","keys_url":"https://api.github.com/repos/ethereum/evmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmc/teams","hooks_url":"https://api.github.com/repos/ethereum/evmc/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmc/events","assignees_url":"https://api.github.com/repos/ethereum/evmc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmc/tags","blobs_url":"https://api.github.com/repos/ethereum/evmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmc/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmc/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmc/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmc/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmc/subscription","commits_url":"https://api.github.com/repos/ethereum/evmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmc/merges","archive_url":"https://api.github.com/repos/ethereum/evmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmc/downloads","issues_url":"https://api.github.com/repos/ethereum/evmc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmc/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmc/deployments","created_at":"2016-08-21T18:35:02Z","updated_at":"2018-06-18T16:57:48Z","pushed_at":"2018-06-19T20:31:08Z","git_url":"git://github.com/ethereum/evmc.git","ssh_url":"git@github.com:ethereum/evmc.git","clone_url":"https://github.com/ethereum/evmc.git","svn_url":"https://github.com/ethereum/evmc","homepage":"https://ethereum.github.io/evmc","size":450,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/32"},"html":{"href":"https://github.com/ethereum/evmc/pull/32"},"issue":{"href":"https://api.github.com/repos/ethereum/evmc/issues/32"},"comments":{"href":"https://api.github.com/repos/ethereum/evmc/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/evmc/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/evmc/statuses/f8ffc2caa7610df63995134ea70fc8df16eac032"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"axic"}}