{"action":"created","issue":{"url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/43","repository_url":"https://api.github.com/repos/zenorogue/hyperrogue","labels_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/43/comments","events_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/43/events","html_url":"https://github.com/zenorogue/hyperrogue/pull/43","id":335804717,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDExMzkw","number":43,"title":"Add Travis CI support","user":{"login":"AMDmi3","id":474217,"node_id":"MDQ6VXNlcjQ3NDIxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/474217?v=4","gravatar_id":"","url":"https://api.github.com/users/AMDmi3","html_url":"https://github.com/AMDmi3","followers_url":"https://api.github.com/users/AMDmi3/followers","following_url":"https://api.github.com/users/AMDmi3/following{/other_user}","gists_url":"https://api.github.com/users/AMDmi3/gists{/gist_id}","starred_url":"https://api.github.com/users/AMDmi3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMDmi3/subscriptions","organizations_url":"https://api.github.com/users/AMDmi3/orgs","repos_url":"https://api.github.com/users/AMDmi3/repos","events_url":"https://api.github.com/users/AMDmi3/events{/privacy}","received_events_url":"https://api.github.com/users/AMDmi3/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-26T12:52:04Z","updated_at":"2018-06-28T18:37:37Z","closed_at":"2018-06-28T13:24:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zenorogue/hyperrogue/pulls/43","html_url":"https://github.com/zenorogue/hyperrogue/pull/43","diff_url":"https://github.com/zenorogue/hyperrogue/pull/43.diff","patch_url":"https://github.com/zenorogue/hyperrogue/pull/43.patch"},"body":"Also set C++11 standard for landgen, which fixes build on Travis (likely because it uses older compiler which doesn't enable c++11 by default).\r\n\r\nBuild results: https://travis-ci.org/AMDmi3/hyperrogue"},"comment":{"url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/comments/401132575","html_url":"https://github.com/zenorogue/hyperrogue/pull/43#issuecomment-401132575","issue_url":"https://api.github.com/repos/zenorogue/hyperrogue/issues/43","id":401132575,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTEzMjU3NQ==","user":{"login":"Quuxplusone","id":702021,"node_id":"MDQ6VXNlcjcwMjAyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/702021?v=4","gravatar_id":"","url":"https://api.github.com/users/Quuxplusone","html_url":"https://github.com/Quuxplusone","followers_url":"https://api.github.com/users/Quuxplusone/followers","following_url":"https://api.github.com/users/Quuxplusone/following{/other_user}","gists_url":"https://api.github.com/users/Quuxplusone/gists{/gist_id}","starred_url":"https://api.github.com/users/Quuxplusone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quuxplusone/subscriptions","organizations_url":"https://api.github.com/users/Quuxplusone/orgs","repos_url":"https://api.github.com/users/Quuxplusone/repos","events_url":"https://api.github.com/users/Quuxplusone/events{/privacy}","received_events_url":"https://api.github.com/users/Quuxplusone/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T18:37:37Z","updated_at":"2018-06-28T18:37:37Z","author_association":"CONTRIBUTOR","body":"> Why didn't you merge other things from Quuxplusone's travis-ci branch like Makefile.simple?\r\n\r\n@Danfun64: I can answer that one: because I didn't pull-request my branch. ;) I'll get around to it soon. At the moment it's still a little bit in flux.\r\n\r\nI think the right order to merge things is probably \"add badge to README.md\", then \"further source-code cleanups\" and \"additional travis-ci targets\", and only *then* optionally \"replace Makefile.{mac,mgw} with Makefile.simple\", and then even more controversially \"replace Makefile.{am,simple} with a Makefile\".\r\n@AMDmi3 seems really enthusiastic about keeping autotools (configure.ac, Makefile.am) working on Linux; I don't know if that would/should block my idea above to replace all the makefiles/autotools/autogen.sh/embuild.sh with a single \"Makefile\".\r\nAlso I am constantly aware that @zenorogue is the only one in the driver's seat here; the most important consideration is that they doesn't merge anything that breaks their *actual* build/release process, which I don't know what it is, but I assume at least `embuild.sh` must be related. :)"}}
{"actor":{"display_login":"Quuxplusone"}}