{"action":"created","comment":{"url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/comments/237630058","pull_request_review_id":179977455,"id":237630058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzYzMDA1OA==","diff_hunk":"@@ -12,32 +12,36 @@ import lectures.functions.SQLAPI\n   * * * * уберите знаки вопроса и раскомментируйте execute(sql)\n   * * * * допишите тело функций в соответсвии с комментарием в каждом методе\n   * После этого допишите инициализацию usefulService в Application так, чтобы:\n-  *   в тестовой среде использовался TestServiceImpl\n-  *   в боевой - ProductionServiceImpl\n+  * в тестовой среде использовался TestServiceImpl\n+  * в боевой - ProductionServiceImpl\n   *\n   * Допишите тесты в ApplicationTest\n   *\n   */\n trait UsefulService {\n+  this: SQLAPI =>\n+\n   def doSomeService(): Int\n }\n \n-trait TestServiceImpl extends UsefulService {\n+class TestServiceImpl(resource: String) extends SQLAPI(resource) with UsefulService {","path":"src/main/scala/lectures/oop/Application.scala","position":19,"original_position":19,"commit_id":"7790f44316b565f449439e689a717c6b25c87c7a","original_commit_id":"7790f44316b565f449439e689a717c6b25c87c7a","user":{"login":"aliksz","id":5522718,"node_id":"MDQ6VXNlcjU1MjI3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/5522718?v=4","gravatar_id":"","url":"https://api.github.com/users/aliksz","html_url":"https://github.com/aliksz","followers_url":"https://api.github.com/users/aliksz/followers","following_url":"https://api.github.com/users/aliksz/following{/other_user}","gists_url":"https://api.github.com/users/aliksz/gists{/gist_id}","starred_url":"https://api.github.com/users/aliksz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliksz/subscriptions","organizations_url":"https://api.github.com/users/aliksz/orgs","repos_url":"https://api.github.com/users/aliksz/repos","events_url":"https://api.github.com/users/aliksz/events{/privacy}","received_events_url":"https://api.github.com/users/aliksz/received_events","type":"User","site_admin":false},"body":"еще есть вариант \r\n```self: SQLAPI =>```\r\nи примешивать на месте\r\n```\r\n new SQLAPI(\"test db Resource\") with TestServiceImpl\r\n```\r\n","created_at":"2018-11-29T19:37:05Z","updated_at":"2018-11-29T19:37:05Z","html_url":"https://github.com/k-bespalov/Scala-complete-course/pull/9#discussion_r237630058","pull_request_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/comments/237630058"},"html":{"href":"https://github.com/k-bespalov/Scala-complete-course/pull/9#discussion_r237630058"},"pull_request":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9","id":234415994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NDE1OTk0","html_url":"https://github.com/k-bespalov/Scala-complete-course/pull/9","diff_url":"https://github.com/k-bespalov/Scala-complete-course/pull/9.diff","patch_url":"https://github.com/k-bespalov/Scala-complete-course/pull/9.patch","issue_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/9","number":9,"state":"open","locked":false,"title":"Homework 8","user":{"login":"k-bespalov","id":26004736,"node_id":"MDQ6VXNlcjI2MDA0NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/26004736?v=4","gravatar_id":"","url":"https://api.github.com/users/k-bespalov","html_url":"https://github.com/k-bespalov","followers_url":"https://api.github.com/users/k-bespalov/followers","following_url":"https://api.github.com/users/k-bespalov/following{/other_user}","gists_url":"https://api.github.com/users/k-bespalov/gists{/gist_id}","starred_url":"https://api.github.com/users/k-bespalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-bespalov/subscriptions","organizations_url":"https://api.github.com/users/k-bespalov/orgs","repos_url":"https://api.github.com/users/k-bespalov/repos","events_url":"https://api.github.com/users/k-bespalov/events{/privacy}","received_events_url":"https://api.github.com/users/k-bespalov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T20:37:36Z","updated_at":"2018-11-29T19:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd75c75900fda84d3426dbf813df7ef40629a5f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9/commits","review_comments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9/comments","review_comment_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/comments{/number}","comments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/9/comments","statuses_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/statuses/7790f44316b565f449439e689a717c6b25c87c7a","head":{"label":"k-bespalov:homework_8","ref":"homework_8","sha":"7790f44316b565f449439e689a717c6b25c87c7a","user":{"login":"k-bespalov","id":26004736,"node_id":"MDQ6VXNlcjI2MDA0NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/26004736?v=4","gravatar_id":"","url":"https://api.github.com/users/k-bespalov","html_url":"https://github.com/k-bespalov","followers_url":"https://api.github.com/users/k-bespalov/followers","following_url":"https://api.github.com/users/k-bespalov/following{/other_user}","gists_url":"https://api.github.com/users/k-bespalov/gists{/gist_id}","starred_url":"https://api.github.com/users/k-bespalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-bespalov/subscriptions","organizations_url":"https://api.github.com/users/k-bespalov/orgs","repos_url":"https://api.github.com/users/k-bespalov/repos","events_url":"https://api.github.com/users/k-bespalov/events{/privacy}","received_events_url":"https://api.github.com/users/k-bespalov/received_events","type":"User","site_admin":false},"repo":{"id":147571699,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NzE2OTk=","name":"Scala-complete-course","full_name":"k-bespalov/Scala-complete-course","private":false,"owner":{"login":"k-bespalov","id":26004736,"node_id":"MDQ6VXNlcjI2MDA0NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/26004736?v=4","gravatar_id":"","url":"https://api.github.com/users/k-bespalov","html_url":"https://github.com/k-bespalov","followers_url":"https://api.github.com/users/k-bespalov/followers","following_url":"https://api.github.com/users/k-bespalov/following{/other_user}","gists_url":"https://api.github.com/users/k-bespalov/gists{/gist_id}","starred_url":"https://api.github.com/users/k-bespalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-bespalov/subscriptions","organizations_url":"https://api.github.com/users/k-bespalov/orgs","repos_url":"https://api.github.com/users/k-bespalov/repos","events_url":"https://api.github.com/users/k-bespalov/events{/privacy}","received_events_url":"https://api.github.com/users/k-bespalov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/k-bespalov/Scala-complete-course","description":"Full scala 1.5 year scala course ","fork":true,"url":"https://api.github.com/repos/k-bespalov/Scala-complete-course","forks_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/forks","keys_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/teams","hooks_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/hooks","issue_events_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/events{/number}","events_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/events","assignees_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/assignees{/user}","branches_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/branches{/branch}","tags_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/tags","blobs_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/statuses/{sha}","languages_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/languages","stargazers_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/stargazers","contributors_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/contributors","subscribers_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/subscribers","subscription_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/subscription","commits_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/contents/{+path}","compare_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/merges","archive_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/downloads","issues_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues{/number}","pulls_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls{/number}","milestones_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/milestones{/number}","notifications_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/labels{/name}","releases_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/releases{/id}","deployments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/deployments","created_at":"2018-09-05T19:50:21Z","updated_at":"2018-10-14T19:28:44Z","pushed_at":"2018-11-28T20:37:36Z","git_url":"git://github.com/k-bespalov/Scala-complete-course.git","ssh_url":"git@github.com:k-bespalov/Scala-complete-course.git","clone_url":"https://github.com/k-bespalov/Scala-complete-course.git","svn_url":"https://github.com/k-bespalov/Scala-complete-course","homepage":null,"size":42800,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"k-bespalov:master","ref":"master","sha":"fb6370e2bc223089c119a27ba506a30873a6c875","user":{"login":"k-bespalov","id":26004736,"node_id":"MDQ6VXNlcjI2MDA0NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/26004736?v=4","gravatar_id":"","url":"https://api.github.com/users/k-bespalov","html_url":"https://github.com/k-bespalov","followers_url":"https://api.github.com/users/k-bespalov/followers","following_url":"https://api.github.com/users/k-bespalov/following{/other_user}","gists_url":"https://api.github.com/users/k-bespalov/gists{/gist_id}","starred_url":"https://api.github.com/users/k-bespalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-bespalov/subscriptions","organizations_url":"https://api.github.com/users/k-bespalov/orgs","repos_url":"https://api.github.com/users/k-bespalov/repos","events_url":"https://api.github.com/users/k-bespalov/events{/privacy}","received_events_url":"https://api.github.com/users/k-bespalov/received_events","type":"User","site_admin":false},"repo":{"id":147571699,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NzE2OTk=","name":"Scala-complete-course","full_name":"k-bespalov/Scala-complete-course","private":false,"owner":{"login":"k-bespalov","id":26004736,"node_id":"MDQ6VXNlcjI2MDA0NzM2","avatar_url":"https://avatars2.githubusercontent.com/u/26004736?v=4","gravatar_id":"","url":"https://api.github.com/users/k-bespalov","html_url":"https://github.com/k-bespalov","followers_url":"https://api.github.com/users/k-bespalov/followers","following_url":"https://api.github.com/users/k-bespalov/following{/other_user}","gists_url":"https://api.github.com/users/k-bespalov/gists{/gist_id}","starred_url":"https://api.github.com/users/k-bespalov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-bespalov/subscriptions","organizations_url":"https://api.github.com/users/k-bespalov/orgs","repos_url":"https://api.github.com/users/k-bespalov/repos","events_url":"https://api.github.com/users/k-bespalov/events{/privacy}","received_events_url":"https://api.github.com/users/k-bespalov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/k-bespalov/Scala-complete-course","description":"Full scala 1.5 year scala course ","fork":true,"url":"https://api.github.com/repos/k-bespalov/Scala-complete-course","forks_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/forks","keys_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/teams","hooks_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/hooks","issue_events_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/events{/number}","events_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/events","assignees_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/assignees{/user}","branches_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/branches{/branch}","tags_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/tags","blobs_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/refs{/sha}","trees_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/statuses/{sha}","languages_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/languages","stargazers_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/stargazers","contributors_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/contributors","subscribers_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/subscribers","subscription_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/subscription","commits_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/commits{/sha}","git_commits_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/git/commits{/sha}","comments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/comments{/number}","issue_comment_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/comments{/number}","contents_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/contents/{+path}","compare_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/merges","archive_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/downloads","issues_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues{/number}","pulls_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls{/number}","milestones_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/milestones{/number}","notifications_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/labels{/name}","releases_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/releases{/id}","deployments_url":"https://api.github.com/repos/k-bespalov/Scala-complete-course/deployments","created_at":"2018-09-05T19:50:21Z","updated_at":"2018-10-14T19:28:44Z","pushed_at":"2018-11-28T20:37:36Z","git_url":"git://github.com/k-bespalov/Scala-complete-course.git","ssh_url":"git@github.com:k-bespalov/Scala-complete-course.git","clone_url":"https://github.com/k-bespalov/Scala-complete-course.git","svn_url":"https://github.com/k-bespalov/Scala-complete-course","homepage":null,"size":42800,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9"},"html":{"href":"https://github.com/k-bespalov/Scala-complete-course/pull/9"},"issue":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/9"},"comments":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/k-bespalov/Scala-complete-course/statuses/7790f44316b565f449439e689a717c6b25c87c7a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"aliksz"}}