{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41","id":170761415,"html_url":"https://github.com/test-editor/test-editor-web/pull/41","diff_url":"https://github.com/test-editor/test-editor-web/pull/41.diff","patch_url":"https://github.com/test-editor/test-editor-web/pull/41.patch","issue_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/41","number":41,"state":"closed","locked":false,"title":"Refactor/update dependencies angular5","user":{"login":"jjelschen","id":2879473,"avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"body":"Note: web-workspace-navigator still uses glyphicons in some places, even though its dependency on bootstrap was updated to >=4.0.0 (as of web-workspace-navigator 0.18.0), which does not include these icons anymore. The corresponding icons used to still show up, because test-editor-web was still depending on an older bootstrap version. With this PR, bootstrap was updated to the latest major version, along with all the other updates, meaning glyphicons no longer work. The way I see it, this is not an issue with test-editor-web, but with web-workspace-navigator, which has to either explicitly include glyphicons, or replace all usages with an alternative like font-awesome.\r\n**Edit**: just noticed that this was fixed with https://github.com/test-editor/web-workspace-navigator/commit/9f0e6b50473a494ba8326204f50bffdc3db0e7fa; when updating to 0.19.0, this issue will be gone again.\r\n\r\nNote2: there is also a much more recent version of `angular-auth-oidc-client`, but it introduced some breaking changes. I looked into it a bit, but then decided to postpone that update for now, as I couldn't immediately figure out what all that auth stuff meant, and how I would have to adapt it.","created_at":"2018-02-22T14:14:24Z","updated_at":"2018-02-26T14:34:36Z","closed_at":"2018-02-26T14:34:36Z","merged_at":"2018-02-26T14:34:36Z","merge_commit_sha":"4956f4fb7a5d7cb713b760a7861076ea13eeb1ab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gunther-bachmann","id":12764214,"avatar_url":"https://avatars3.githubusercontent.com/u/12764214?v=4","gravatar_id":"","url":"https://api.github.com/users/gunther-bachmann","html_url":"https://github.com/gunther-bachmann","followers_url":"https://api.github.com/users/gunther-bachmann/followers","following_url":"https://api.github.com/users/gunther-bachmann/following{/other_user}","gists_url":"https://api.github.com/users/gunther-bachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gunther-bachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunther-bachmann/subscriptions","organizations_url":"https://api.github.com/users/gunther-bachmann/orgs","repos_url":"https://api.github.com/users/gunther-bachmann/repos","events_url":"https://api.github.com/users/gunther-bachmann/events{/privacy}","received_events_url":"https://api.github.com/users/gunther-bachmann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41/commits","review_comments_url":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41/comments","review_comment_url":"https://api.github.com/repos/test-editor/test-editor-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/41/comments","statuses_url":"https://api.github.com/repos/test-editor/test-editor-web/statuses/f9b847864231930da2369b1a772299460660014c","head":{"label":"test-editor:refactor/update-dependencies-angular5","ref":"refactor/update-dependencies-angular5","sha":"f9b847864231930da2369b1a772299460660014c","user":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":96108166,"name":"test-editor-web","full_name":"test-editor/test-editor-web","owner":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-editor/test-editor-web","description":"Test editor web frontend","fork":false,"url":"https://api.github.com/repos/test-editor/test-editor-web","forks_url":"https://api.github.com/repos/test-editor/test-editor-web/forks","keys_url":"https://api.github.com/repos/test-editor/test-editor-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/test-editor-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/test-editor-web/teams","hooks_url":"https://api.github.com/repos/test-editor/test-editor-web/hooks","issue_events_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/test-editor-web/events","assignees_url":"https://api.github.com/repos/test-editor/test-editor-web/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/test-editor-web/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/test-editor-web/tags","blobs_url":"https://api.github.com/repos/test-editor/test-editor-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/test-editor-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/test-editor-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/test-editor-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/test-editor-web/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/test-editor-web/languages","stargazers_url":"https://api.github.com/repos/test-editor/test-editor-web/stargazers","contributors_url":"https://api.github.com/repos/test-editor/test-editor-web/contributors","subscribers_url":"https://api.github.com/repos/test-editor/test-editor-web/subscribers","subscription_url":"https://api.github.com/repos/test-editor/test-editor-web/subscription","commits_url":"https://api.github.com/repos/test-editor/test-editor-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/test-editor-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/test-editor-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/test-editor-web/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/test-editor-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/test-editor-web/merges","archive_url":"https://api.github.com/repos/test-editor/test-editor-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/test-editor-web/downloads","issues_url":"https://api.github.com/repos/test-editor/test-editor-web/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/test-editor-web/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/test-editor-web/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/test-editor-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/test-editor-web/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/test-editor-web/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/test-editor-web/deployments","created_at":"2017-07-03T12:24:53Z","updated_at":"2018-01-06T21:00:13Z","pushed_at":"2018-02-26T14:34:36Z","git_url":"git://github.com/test-editor/test-editor-web.git","ssh_url":"git@github.com:test-editor/test-editor-web.git","clone_url":"https://github.com/test-editor/test-editor-web.git","svn_url":"https://github.com/test-editor/test-editor-web","homepage":null,"size":513,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"test-editor:develop","ref":"develop","sha":"944a04d56044e592f0f03acbbd3e0039c76301eb","user":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":96108166,"name":"test-editor-web","full_name":"test-editor/test-editor-web","owner":{"login":"test-editor","id":7946408,"avatar_url":"https://avatars3.githubusercontent.com/u/7946408?v=4","gravatar_id":"","url":"https://api.github.com/users/test-editor","html_url":"https://github.com/test-editor","followers_url":"https://api.github.com/users/test-editor/followers","following_url":"https://api.github.com/users/test-editor/following{/other_user}","gists_url":"https://api.github.com/users/test-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/test-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/test-editor/subscriptions","organizations_url":"https://api.github.com/users/test-editor/orgs","repos_url":"https://api.github.com/users/test-editor/repos","events_url":"https://api.github.com/users/test-editor/events{/privacy}","received_events_url":"https://api.github.com/users/test-editor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/test-editor/test-editor-web","description":"Test editor web frontend","fork":false,"url":"https://api.github.com/repos/test-editor/test-editor-web","forks_url":"https://api.github.com/repos/test-editor/test-editor-web/forks","keys_url":"https://api.github.com/repos/test-editor/test-editor-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/test-editor/test-editor-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/test-editor/test-editor-web/teams","hooks_url":"https://api.github.com/repos/test-editor/test-editor-web/hooks","issue_events_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/events{/number}","events_url":"https://api.github.com/repos/test-editor/test-editor-web/events","assignees_url":"https://api.github.com/repos/test-editor/test-editor-web/assignees{/user}","branches_url":"https://api.github.com/repos/test-editor/test-editor-web/branches{/branch}","tags_url":"https://api.github.com/repos/test-editor/test-editor-web/tags","blobs_url":"https://api.github.com/repos/test-editor/test-editor-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/test-editor/test-editor-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/test-editor/test-editor-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/test-editor/test-editor-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/test-editor/test-editor-web/statuses/{sha}","languages_url":"https://api.github.com/repos/test-editor/test-editor-web/languages","stargazers_url":"https://api.github.com/repos/test-editor/test-editor-web/stargazers","contributors_url":"https://api.github.com/repos/test-editor/test-editor-web/contributors","subscribers_url":"https://api.github.com/repos/test-editor/test-editor-web/subscribers","subscription_url":"https://api.github.com/repos/test-editor/test-editor-web/subscription","commits_url":"https://api.github.com/repos/test-editor/test-editor-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/test-editor/test-editor-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/test-editor/test-editor-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/test-editor/test-editor-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/test-editor/test-editor-web/contents/{+path}","compare_url":"https://api.github.com/repos/test-editor/test-editor-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/test-editor/test-editor-web/merges","archive_url":"https://api.github.com/repos/test-editor/test-editor-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/test-editor/test-editor-web/downloads","issues_url":"https://api.github.com/repos/test-editor/test-editor-web/issues{/number}","pulls_url":"https://api.github.com/repos/test-editor/test-editor-web/pulls{/number}","milestones_url":"https://api.github.com/repos/test-editor/test-editor-web/milestones{/number}","notifications_url":"https://api.github.com/repos/test-editor/test-editor-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/test-editor/test-editor-web/labels{/name}","releases_url":"https://api.github.com/repos/test-editor/test-editor-web/releases{/id}","deployments_url":"https://api.github.com/repos/test-editor/test-editor-web/deployments","created_at":"2017-07-03T12:24:53Z","updated_at":"2018-01-06T21:00:13Z","pushed_at":"2018-02-26T14:34:36Z","git_url":"git://github.com/test-editor/test-editor-web.git","ssh_url":"git@github.com:test-editor/test-editor-web.git","clone_url":"https://github.com/test-editor/test-editor-web.git","svn_url":"https://github.com/test-editor/test-editor-web","homepage":null,"size":513,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41"},"html":{"href":"https://github.com/test-editor/test-editor-web/pull/41"},"issue":{"href":"https://api.github.com/repos/test-editor/test-editor-web/issues/41"},"comments":{"href":"https://api.github.com/repos/test-editor/test-editor-web/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/test-editor/test-editor-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/test-editor/test-editor-web/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/test-editor/test-editor-web/statuses/f9b847864231930da2369b1a772299460660014c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gunther-bachmann","id":12764214,"avatar_url":"https://avatars3.githubusercontent.com/u/12764214?v=4","gravatar_id":"","url":"https://api.github.com/users/gunther-bachmann","html_url":"https://github.com/gunther-bachmann","followers_url":"https://api.github.com/users/gunther-bachmann/followers","following_url":"https://api.github.com/users/gunther-bachmann/following{/other_user}","gists_url":"https://api.github.com/users/gunther-bachmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gunther-bachmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunther-bachmann/subscriptions","organizations_url":"https://api.github.com/users/gunther-bachmann/orgs","repos_url":"https://api.github.com/users/gunther-bachmann/repos","events_url":"https://api.github.com/users/gunther-bachmann/events{/privacy}","received_events_url":"https://api.github.com/users/gunther-bachmann/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":2630,"deletions":1674,"changed_files":3}}
{"actor":{"display_login":"gunther-bachmann"}}