{"action":"created","issue":{"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/36","repository_url":"https://api.github.com/repos/cms-gem-daq-project/xhal","labels_url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/36/comments","events_url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/36/events","html_url":"https://github.com/cms-gem-daq-project/xhal/pull/36","id":293472519,"number":36,"title":"Modifying the parsers to handle xi:include","user":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"labels":[{"id":671531172,"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/labels/Priority:%20High","name":"Priority: High","color":"ff8000","default":false},{"id":671531174,"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/labels/Status:%20Review%20Needed","name":"Status: Review Needed","color":"ff8000","default":false},{"id":671531177,"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"evka85","id":8192542,"avatar_url":"https://avatars3.githubusercontent.com/u/8192542?v=4","gravatar_id":"","url":"https://api.github.com/users/evka85","html_url":"https://github.com/evka85","followers_url":"https://api.github.com/users/evka85/followers","following_url":"https://api.github.com/users/evka85/following{/other_user}","gists_url":"https://api.github.com/users/evka85/gists{/gist_id}","starred_url":"https://api.github.com/users/evka85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evka85/subscriptions","organizations_url":"https://api.github.com/users/evka85/orgs","repos_url":"https://api.github.com/users/evka85/repos","events_url":"https://api.github.com/users/evka85/events{/privacy}","received_events_url":"https://api.github.com/users/evka85/received_events","type":"User","site_admin":false},"assignees":[{"login":"evka85","id":8192542,"avatar_url":"https://avatars3.githubusercontent.com/u/8192542?v=4","gravatar_id":"","url":"https://api.github.com/users/evka85","html_url":"https://github.com/evka85","followers_url":"https://api.github.com/users/evka85/followers","following_url":"https://api.github.com/users/evka85/following{/other_user}","gists_url":"https://api.github.com/users/evka85/gists{/gist_id}","starred_url":"https://api.github.com/users/evka85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evka85/subscriptions","organizations_url":"https://api.github.com/users/evka85/orgs","repos_url":"https://api.github.com/users/evka85/repos","events_url":"https://api.github.com/users/evka85/events{/privacy}","received_events_url":"https://api.github.com/users/evka85/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-02-01T10:12:01Z","updated_at":"2018-02-01T11:33:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/pulls/36","html_url":"https://github.com/cms-gem-daq-project/xhal/pull/36","diff_url":"https://github.com/cms-gem-daq-project/xhal/pull/36.diff","patch_url":"https://github.com/cms-gem-daq-project/xhal/pull/36.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nBoth python and C++ XML parsers are updated to handle the xi:include to link optohybrid_registers.xml address table. Python parser changed to lxml, C++ is changed to DOMLSParser.\r\nNow in order to include the optohybrid nodes into the gem_amc_top.xml one need to:\r\n\r\n- modify the `<node id=\"top\">` node to be like: \r\n`<node id=\"top\" xmlns:xi=\"http://www.w3.org/2001/XInclude\">`\r\n\r\n-  insert a following line in the `OH${OH_IDX}` node just before the `GEB` node:\r\n`<xi:include href=\"optohybrid_registers.xml\"/>`\r\n\r\nThe resulting part of xml should look like this:\r\n```\r\n     <node id=\"OH${OH_IDX}\"  address=\"0x0\"\r\n            description=\"Optohybrid ${OH_IDX}\"\r\n            generate=\"true\" generate_size=\"2\" generate_address_step=\"0x00010000\" generate_idx_var=\"OH_IDX\">\r\n\r\n        <!--Insert here the OH FPGA module -->\r\n        <xi:include href=\"optohybrid_registers.xml\"/>\r\n\r\n        <node id=\"GEB\"  address=\"0x100000\"\r\n              description=\"VFAT3 registers\">\r\n```\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue(s) here. -->\r\nFixes https://github.com/cms-gem-daq-project/xhal/issues/34\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nTested with `reg_interface` and C++ unit tests\r\n### Screenshots (if appropriate):\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n<!--- Template thanks to https://www.talater.com/open-source-templates/#/page/99 -->\r\n"},"comment":{"url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/comments/362239407","html_url":"https://github.com/cms-gem-daq-project/xhal/pull/36#issuecomment-362239407","issue_url":"https://api.github.com/repos/cms-gem-daq-project/xhal/issues/36","id":362239407,"user":{"login":"mexanick","id":7428758,"avatar_url":"https://avatars1.githubusercontent.com/u/7428758?v=4","gravatar_id":"","url":"https://api.github.com/users/mexanick","html_url":"https://github.com/mexanick","followers_url":"https://api.github.com/users/mexanick/followers","following_url":"https://api.github.com/users/mexanick/following{/other_user}","gists_url":"https://api.github.com/users/mexanick/gists{/gist_id}","starred_url":"https://api.github.com/users/mexanick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mexanick/subscriptions","organizations_url":"https://api.github.com/users/mexanick/orgs","repos_url":"https://api.github.com/users/mexanick/repos","events_url":"https://api.github.com/users/mexanick/events{/privacy}","received_events_url":"https://api.github.com/users/mexanick/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T11:33:53Z","updated_at":"2018-02-01T11:33:53Z","author_association":"COLLABORATOR","body":"The XML maintenance should be provided by @evka85 I believe =)\r\nConsidering and example of my XML - see [here](https://drive.google.com/drive/folders/1Q0E4zvxkNbhPf7GqSo-XUMEsE0ezAnfY?usp=sharing)\r\n"}}
{"actor":{"display_login":"mexanick"}}