{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/199821705","pull_request_review_id":134009915,"id":199821705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTgyMTcwNQ==","diff_hunk":"@@ -0,0 +1,85 @@\n+{ stdenv, fetchurl, fetchFromGitHub, pkgconfig\n+, libX11, libXext, python3, libXrandr, libXrender, libpulseaudio, libXcomposite\n+, enableGlfw ? false, glfw }:\n+\n+let\n+  inherit (stdenv.lib) optional;\n+\n+  version = \"1.4.5\";\n+  gladVersion = \"0.1.24\";\n+  # glad\n+  # https://github.com/wacossusca34/glava/issues/46#issuecomment-397816520\n+  glad = fetchFromGitHub {\n+    owner = \"Dav1dde\";\n+    repo = \"glad\";\n+    rev = \"v${gladVersion}\";\n+    sha256 = \"0s2c9w064kqa5i07w8zmvgpg1pa3wj86l1nhgw7w56cjhq7cf8h8\";\n+  };\n+  # gl.xml\n+  gl = fetchurl {\n+    url = https://raw.githubusercontent.com/KhronosGroup/OpenGL-Registry/a24f3f7a4c924fdbc666024f99c70e5b8e34c819/xml/gl.xml;\n+    sha256 = \"1mskxjmhb35m8qv255pibf633d8sn1w9rdsf0lj75bhlgy0zi5c7\";\n+  };\n+  # EGL 1.5\n+  egl = fetchurl {\n+    url = https://www.khronos.org/registry/EGL/api/KHR/khrplatform.h;\n+    sha256 = \"0p0vs4siiya05cvbqq7cw3ci2zvvlfh8kycgm9k9cwvmrkj08349\";\n+  };\n+in\n+  stdenv.mkDerivation rec {\n+    name = \"glava-${version}\";\n+\n+    src = fetchFromGitHub {\n+      owner = \"wacossusca34\";\n+      repo = \"glava\";\n+      rev = \"v${version}\";\n+      sha256 = \"1zfw8samrzxxbny709rcdz1z77cw1cd46wlfnf7my02kipmqn0nr\";\n+    };\n+\n+    buildInputs = [\n+      libX11\n+      libXext\n+      python3","path":"pkgs/applications/misc/glava/default.nix","position":42,"original_position":42,"commit_id":"5540be99fc85066b1879e3832f112b40be9bcf99","original_commit_id":"5540be99fc85066b1879e3832f112b40be9bcf99","user":{"login":"Infinisil","id":20525370,"node_id":"MDQ6VXNlcjIwNTI1Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/20525370?v=4","gravatar_id":"","url":"https://api.github.com/users/Infinisil","html_url":"https://github.com/Infinisil","followers_url":"https://api.github.com/users/Infinisil/followers","following_url":"https://api.github.com/users/Infinisil/following{/other_user}","gists_url":"https://api.github.com/users/Infinisil/gists{/gist_id}","starred_url":"https://api.github.com/users/Infinisil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infinisil/subscriptions","organizations_url":"https://api.github.com/users/Infinisil/orgs","repos_url":"https://api.github.com/users/Infinisil/repos","events_url":"https://api.github.com/users/Infinisil/events{/privacy}","received_events_url":"https://api.github.com/users/Infinisil/received_events","type":"User","site_admin":false},"body":"python should be in `nativeBuildInputs` (it's only used during the build afaik)","created_at":"2018-07-03T14:11:06Z","updated_at":"2018-07-03T14:11:47Z","html_url":"https://github.com/NixOS/nixpkgs/pull/42103#discussion_r199821705","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/199821705"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/42103#discussion_r199821705"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103","id":195337310,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzM3MzEw","html_url":"https://github.com/NixOS/nixpkgs/pull/42103","diff_url":"https://github.com/NixOS/nixpkgs/pull/42103.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/42103.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42103","number":42103,"state":"open","locked":false,"title":"glava: init at v1.4.5","user":{"login":"eadwu","id":22758444,"node_id":"MDQ6VXNlcjIyNzU4NDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/22758444?v=4","gravatar_id":"","url":"https://api.github.com/users/eadwu","html_url":"https://github.com/eadwu","followers_url":"https://api.github.com/users/eadwu/followers","following_url":"https://api.github.com/users/eadwu/following{/other_user}","gists_url":"https://api.github.com/users/eadwu/gists{/gist_id}","starred_url":"https://api.github.com/users/eadwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadwu/subscriptions","organizations_url":"https://api.github.com/users/eadwu/orgs","repos_url":"https://api.github.com/users/eadwu/repos","events_url":"https://api.github.com/users/eadwu/events{/privacy}","received_events_url":"https://api.github.com/users/eadwu/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-06-16T15:43:09Z","updated_at":"2018-07-03T14:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f29541fb83d7366a37b8e2407d672c68b4b7b31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42103/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5540be99fc85066b1879e3832f112b40be9bcf99","head":{"label":"eadwu:init/glava","ref":"init/glava","sha":"5540be99fc85066b1879e3832f112b40be9bcf99","user":{"login":"eadwu","id":22758444,"node_id":"MDQ6VXNlcjIyNzU4NDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/22758444?v=4","gravatar_id":"","url":"https://api.github.com/users/eadwu","html_url":"https://github.com/eadwu","followers_url":"https://api.github.com/users/eadwu/followers","following_url":"https://api.github.com/users/eadwu/following{/other_user}","gists_url":"https://api.github.com/users/eadwu/gists{/gist_id}","starred_url":"https://api.github.com/users/eadwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadwu/subscriptions","organizations_url":"https://api.github.com/users/eadwu/orgs","repos_url":"https://api.github.com/users/eadwu/repos","events_url":"https://api.github.com/users/eadwu/events{/privacy}","received_events_url":"https://api.github.com/users/eadwu/received_events","type":"User","site_admin":false},"repo":{"id":136187339,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxODczMzk=","name":"nixpkgs","full_name":"eadwu/nixpkgs","owner":{"login":"eadwu","id":22758444,"node_id":"MDQ6VXNlcjIyNzU4NDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/22758444?v=4","gravatar_id":"","url":"https://api.github.com/users/eadwu","html_url":"https://github.com/eadwu","followers_url":"https://api.github.com/users/eadwu/followers","following_url":"https://api.github.com/users/eadwu/following{/other_user}","gists_url":"https://api.github.com/users/eadwu/gists{/gist_id}","starred_url":"https://api.github.com/users/eadwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eadwu/subscriptions","organizations_url":"https://api.github.com/users/eadwu/orgs","repos_url":"https://api.github.com/users/eadwu/repos","events_url":"https://api.github.com/users/eadwu/events{/privacy}","received_events_url":"https://api.github.com/users/eadwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eadwu/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/eadwu/nixpkgs","forks_url":"https://api.github.com/repos/eadwu/nixpkgs/forks","keys_url":"https://api.github.com/repos/eadwu/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eadwu/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eadwu/nixpkgs/teams","hooks_url":"https://api.github.com/repos/eadwu/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/eadwu/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/eadwu/nixpkgs/events","assignees_url":"https://api.github.com/repos/eadwu/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/eadwu/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/eadwu/nixpkgs/tags","blobs_url":"https://api.github.com/repos/eadwu/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eadwu/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eadwu/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/eadwu/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eadwu/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/eadwu/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/eadwu/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/eadwu/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/eadwu/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/eadwu/nixpkgs/subscription","commits_url":"https://api.github.com/repos/eadwu/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/eadwu/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/eadwu/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/eadwu/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/eadwu/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/eadwu/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eadwu/nixpkgs/merges","archive_url":"https://api.github.com/repos/eadwu/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eadwu/nixpkgs/downloads","issues_url":"https://api.github.com/repos/eadwu/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/eadwu/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/eadwu/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/eadwu/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eadwu/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/eadwu/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/eadwu/nixpkgs/deployments","created_at":"2018-06-05T14:11:05Z","updated_at":"2018-07-03T13:51:41Z","pushed_at":"2018-07-03T13:51:39Z","git_url":"git://github.com/eadwu/nixpkgs.git","ssh_url":"git@github.com:eadwu/nixpkgs.git","clone_url":"https://github.com/eadwu/nixpkgs.git","svn_url":"https://github.com/eadwu/nixpkgs","homepage":null,"size":803450,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"142a2289ff72af59220d6a47a85c6fae81848984","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-07-03T13:36:27Z","pushed_at":"2018-07-03T14:10:48Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":814058,"stargazers_count":2540,"watchers_count":2540,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2848,"mirror_url":null,"archived":false,"open_issues_count":2977,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2848,"open_issues":2977,"watchers":2540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/42103"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42103"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/42103/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42103/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/5540be99fc85066b1879e3832f112b40be9bcf99"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Infinisil"}}