{"action":"created","comment":{"url":"https://api.github.com/repos/fiaas/skipper/pulls/comments/193411257","pull_request_review_id":126376726,"id":193411257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQxMTI1Nw==","diff_hunk":"@@ -40,9 +40,12 @@ def deploy(self, namespaces=None):\n             if namespaces and deployment_config.namespace not in namespaces:\n                 continue\n             channel = self._release_channel_factory(deployment_config.name, deployment_config.tag)\n-            self._deploy(deployment_config, channel)\n-            if requires_bootstrap(deployment_config):\n-                self._bootstrap(deployment_config, channel, self._spec_config)\n+            try:","path":"fiaas_skipper/deploy/deploy.py","position":7,"original_position":7,"commit_id":"8548e589305e652223a1057477eeee814bb4c0b8","original_commit_id":"8548e589305e652223a1057477eeee814bb4c0b8","user":{"login":"mortenlj","id":746078,"node_id":"MDQ6VXNlcjc0NjA3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/746078?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenlj","html_url":"https://github.com/mortenlj","followers_url":"https://api.github.com/users/mortenlj/followers","following_url":"https://api.github.com/users/mortenlj/following{/other_user}","gists_url":"https://api.github.com/users/mortenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenlj/subscriptions","organizations_url":"https://api.github.com/users/mortenlj/orgs","repos_url":"https://api.github.com/users/mortenlj/repos","events_url":"https://api.github.com/users/mortenlj/events{/privacy}","received_events_url":"https://api.github.com/users/mortenlj/received_events","type":"User","site_admin":false},"body":"Two different concerns. This deals with handling errors for each namespace, so that we can continue with the next one in the list. You are talking about a catch-all at the top level, so that we can log exceptions before the thread dies. Ideally we would like both, but this PR solves the problem of continuing with the next namespace after a failure.\r\n\r\nOn the other hand, we should probably include the channel factory code, since that also does a remote call. I'll write new PRs for each issue.","created_at":"2018-06-06T13:35:06Z","updated_at":"2018-06-06T13:35:06Z","html_url":"https://github.com/fiaas/skipper/pull/32#discussion_r193411257","pull_request_url":"https://api.github.com/repos/fiaas/skipper/pulls/32","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/comments/193411257"},"html":{"href":"https://github.com/fiaas/skipper/pull/32#discussion_r193411257"},"pull_request":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/32"}},"in_reply_to_id":193378494},"pull_request":{"url":"https://api.github.com/repos/fiaas/skipper/pulls/32","id":192811584,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODExNTg0","html_url":"https://github.com/fiaas/skipper/pull/32","diff_url":"https://github.com/fiaas/skipper/pull/32.diff","patch_url":"https://github.com/fiaas/skipper/pull/32.patch","issue_url":"https://api.github.com/repos/fiaas/skipper/issues/32","number":32,"state":"closed","locked":false,"title":"Handle deployment error","user":{"login":"mortenlj","id":746078,"node_id":"MDQ6VXNlcjc0NjA3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/746078?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenlj","html_url":"https://github.com/mortenlj","followers_url":"https://api.github.com/users/mortenlj/followers","following_url":"https://api.github.com/users/mortenlj/following{/other_user}","gists_url":"https://api.github.com/users/mortenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenlj/subscriptions","organizations_url":"https://api.github.com/users/mortenlj/orgs","repos_url":"https://api.github.com/users/mortenlj/repos","events_url":"https://api.github.com/users/mortenlj/events{/privacy}","received_events_url":"https://api.github.com/users/mortenlj/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-05T19:26:10Z","updated_at":"2018-06-06T13:35:06Z","closed_at":"2018-06-06T11:32:19Z","merged_at":"2018-06-06T11:32:19Z","merge_commit_sha":"8b899a05517ca8f90a72450985409944e2d30e69","assignee":{"login":"mortenlj","id":746078,"node_id":"MDQ6VXNlcjc0NjA3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/746078?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenlj","html_url":"https://github.com/mortenlj","followers_url":"https://api.github.com/users/mortenlj/followers","following_url":"https://api.github.com/users/mortenlj/following{/other_user}","gists_url":"https://api.github.com/users/mortenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenlj/subscriptions","organizations_url":"https://api.github.com/users/mortenlj/orgs","repos_url":"https://api.github.com/users/mortenlj/repos","events_url":"https://api.github.com/users/mortenlj/events{/privacy}","received_events_url":"https://api.github.com/users/mortenlj/received_events","type":"User","site_admin":false},"assignees":[{"login":"mortenlj","id":746078,"node_id":"MDQ6VXNlcjc0NjA3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/746078?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenlj","html_url":"https://github.com/mortenlj","followers_url":"https://api.github.com/users/mortenlj/followers","following_url":"https://api.github.com/users/mortenlj/following{/other_user}","gists_url":"https://api.github.com/users/mortenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenlj/subscriptions","organizations_url":"https://api.github.com/users/mortenlj/orgs","repos_url":"https://api.github.com/users/mortenlj/repos","events_url":"https://api.github.com/users/mortenlj/events{/privacy}","received_events_url":"https://api.github.com/users/mortenlj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fiaas/skipper/pulls/32/commits","review_comments_url":"https://api.github.com/repos/fiaas/skipper/pulls/32/comments","review_comment_url":"https://api.github.com/repos/fiaas/skipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fiaas/skipper/issues/32/comments","statuses_url":"https://api.github.com/repos/fiaas/skipper/statuses/8548e589305e652223a1057477eeee814bb4c0b8","head":{"label":"fiaas:better-error-handling","ref":"better-error-handling","sha":"8548e589305e652223a1057477eeee814bb4c0b8","user":{"login":"fiaas","id":29093763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDkzNzYz","avatar_url":"https://avatars1.githubusercontent.com/u/29093763?v=4","gravatar_id":"","url":"https://api.github.com/users/fiaas","html_url":"https://github.com/fiaas","followers_url":"https://api.github.com/users/fiaas/followers","following_url":"https://api.github.com/users/fiaas/following{/other_user}","gists_url":"https://api.github.com/users/fiaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fiaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiaas/subscriptions","organizations_url":"https://api.github.com/users/fiaas/orgs","repos_url":"https://api.github.com/users/fiaas/repos","events_url":"https://api.github.com/users/fiaas/events{/privacy}","received_events_url":"https://api.github.com/users/fiaas/received_events","type":"Organization","site_admin":false},"repo":{"id":121757778,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NTc3Nzg=","name":"skipper","full_name":"fiaas/skipper","owner":{"login":"fiaas","id":29093763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDkzNzYz","avatar_url":"https://avatars1.githubusercontent.com/u/29093763?v=4","gravatar_id":"","url":"https://api.github.com/users/fiaas","html_url":"https://github.com/fiaas","followers_url":"https://api.github.com/users/fiaas/followers","following_url":"https://api.github.com/users/fiaas/following{/other_user}","gists_url":"https://api.github.com/users/fiaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fiaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiaas/subscriptions","organizations_url":"https://api.github.com/users/fiaas/orgs","repos_url":"https://api.github.com/users/fiaas/repos","events_url":"https://api.github.com/users/fiaas/events{/privacy}","received_events_url":"https://api.github.com/users/fiaas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fiaas/skipper","description":"Skipper controls deployment and updates of FIAAS components","fork":false,"url":"https://api.github.com/repos/fiaas/skipper","forks_url":"https://api.github.com/repos/fiaas/skipper/forks","keys_url":"https://api.github.com/repos/fiaas/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiaas/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiaas/skipper/teams","hooks_url":"https://api.github.com/repos/fiaas/skipper/hooks","issue_events_url":"https://api.github.com/repos/fiaas/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/fiaas/skipper/events","assignees_url":"https://api.github.com/repos/fiaas/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/fiaas/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/fiaas/skipper/tags","blobs_url":"https://api.github.com/repos/fiaas/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiaas/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiaas/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiaas/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiaas/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/fiaas/skipper/languages","stargazers_url":"https://api.github.com/repos/fiaas/skipper/stargazers","contributors_url":"https://api.github.com/repos/fiaas/skipper/contributors","subscribers_url":"https://api.github.com/repos/fiaas/skipper/subscribers","subscription_url":"https://api.github.com/repos/fiaas/skipper/subscription","commits_url":"https://api.github.com/repos/fiaas/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiaas/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiaas/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiaas/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/fiaas/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/fiaas/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiaas/skipper/merges","archive_url":"https://api.github.com/repos/fiaas/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiaas/skipper/downloads","issues_url":"https://api.github.com/repos/fiaas/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/fiaas/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/fiaas/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/fiaas/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiaas/skipper/labels{/name}","releases_url":"https://api.github.com/repos/fiaas/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/fiaas/skipper/deployments","created_at":"2018-02-16T14:08:12Z","updated_at":"2018-06-06T11:32:21Z","pushed_at":"2018-06-06T11:32:25Z","git_url":"git://github.com/fiaas/skipper.git","ssh_url":"git@github.com:fiaas/skipper.git","clone_url":"https://github.com/fiaas/skipper.git","svn_url":"https://github.com/fiaas/skipper","homepage":"","size":136,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"fiaas:master","ref":"master","sha":"bedf287cd703b14ad4977957d400127e99f013fe","user":{"login":"fiaas","id":29093763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDkzNzYz","avatar_url":"https://avatars1.githubusercontent.com/u/29093763?v=4","gravatar_id":"","url":"https://api.github.com/users/fiaas","html_url":"https://github.com/fiaas","followers_url":"https://api.github.com/users/fiaas/followers","following_url":"https://api.github.com/users/fiaas/following{/other_user}","gists_url":"https://api.github.com/users/fiaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fiaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiaas/subscriptions","organizations_url":"https://api.github.com/users/fiaas/orgs","repos_url":"https://api.github.com/users/fiaas/repos","events_url":"https://api.github.com/users/fiaas/events{/privacy}","received_events_url":"https://api.github.com/users/fiaas/received_events","type":"Organization","site_admin":false},"repo":{"id":121757778,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NTc3Nzg=","name":"skipper","full_name":"fiaas/skipper","owner":{"login":"fiaas","id":29093763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MDkzNzYz","avatar_url":"https://avatars1.githubusercontent.com/u/29093763?v=4","gravatar_id":"","url":"https://api.github.com/users/fiaas","html_url":"https://github.com/fiaas","followers_url":"https://api.github.com/users/fiaas/followers","following_url":"https://api.github.com/users/fiaas/following{/other_user}","gists_url":"https://api.github.com/users/fiaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fiaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiaas/subscriptions","organizations_url":"https://api.github.com/users/fiaas/orgs","repos_url":"https://api.github.com/users/fiaas/repos","events_url":"https://api.github.com/users/fiaas/events{/privacy}","received_events_url":"https://api.github.com/users/fiaas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fiaas/skipper","description":"Skipper controls deployment and updates of FIAAS components","fork":false,"url":"https://api.github.com/repos/fiaas/skipper","forks_url":"https://api.github.com/repos/fiaas/skipper/forks","keys_url":"https://api.github.com/repos/fiaas/skipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiaas/skipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiaas/skipper/teams","hooks_url":"https://api.github.com/repos/fiaas/skipper/hooks","issue_events_url":"https://api.github.com/repos/fiaas/skipper/issues/events{/number}","events_url":"https://api.github.com/repos/fiaas/skipper/events","assignees_url":"https://api.github.com/repos/fiaas/skipper/assignees{/user}","branches_url":"https://api.github.com/repos/fiaas/skipper/branches{/branch}","tags_url":"https://api.github.com/repos/fiaas/skipper/tags","blobs_url":"https://api.github.com/repos/fiaas/skipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiaas/skipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiaas/skipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiaas/skipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiaas/skipper/statuses/{sha}","languages_url":"https://api.github.com/repos/fiaas/skipper/languages","stargazers_url":"https://api.github.com/repos/fiaas/skipper/stargazers","contributors_url":"https://api.github.com/repos/fiaas/skipper/contributors","subscribers_url":"https://api.github.com/repos/fiaas/skipper/subscribers","subscription_url":"https://api.github.com/repos/fiaas/skipper/subscription","commits_url":"https://api.github.com/repos/fiaas/skipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiaas/skipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiaas/skipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiaas/skipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/fiaas/skipper/contents/{+path}","compare_url":"https://api.github.com/repos/fiaas/skipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiaas/skipper/merges","archive_url":"https://api.github.com/repos/fiaas/skipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiaas/skipper/downloads","issues_url":"https://api.github.com/repos/fiaas/skipper/issues{/number}","pulls_url":"https://api.github.com/repos/fiaas/skipper/pulls{/number}","milestones_url":"https://api.github.com/repos/fiaas/skipper/milestones{/number}","notifications_url":"https://api.github.com/repos/fiaas/skipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiaas/skipper/labels{/name}","releases_url":"https://api.github.com/repos/fiaas/skipper/releases{/id}","deployments_url":"https://api.github.com/repos/fiaas/skipper/deployments","created_at":"2018-02-16T14:08:12Z","updated_at":"2018-06-06T11:32:21Z","pushed_at":"2018-06-06T11:32:25Z","git_url":"git://github.com/fiaas/skipper.git","ssh_url":"git@github.com:fiaas/skipper.git","clone_url":"https://github.com/fiaas/skipper.git","svn_url":"https://github.com/fiaas/skipper","homepage":"","size":136,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/32"},"html":{"href":"https://github.com/fiaas/skipper/pull/32"},"issue":{"href":"https://api.github.com/repos/fiaas/skipper/issues/32"},"comments":{"href":"https://api.github.com/repos/fiaas/skipper/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fiaas/skipper/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/fiaas/skipper/statuses/8548e589305e652223a1057477eeee814bb4c0b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mortenlj"}}