{"action":"opened","number":1703,"pull_request":{"url":"https://api.github.com/repos/SEED-platform/seed/pulls/1703","id":212442366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDQyMzY2","html_url":"https://github.com/SEED-platform/seed/pull/1703","diff_url":"https://github.com/SEED-platform/seed/pull/1703.diff","patch_url":"https://github.com/SEED-platform/seed/pull/1703.patch","issue_url":"https://api.github.com/repos/SEED-platform/seed/issues/1703","number":1703,"state":"open","locked":false,"title":"Strip spaces around value before typecasting","user":{"login":"nllong","id":1907354,"node_id":"MDQ6VXNlcjE5MDczNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1907354?v=4","gravatar_id":"","url":"https://api.github.com/users/nllong","html_url":"https://github.com/nllong","followers_url":"https://api.github.com/users/nllong/followers","following_url":"https://api.github.com/users/nllong/following{/other_user}","gists_url":"https://api.github.com/users/nllong/gists{/gist_id}","starred_url":"https://api.github.com/users/nllong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nllong/subscriptions","organizations_url":"https://api.github.com/users/nllong/orgs","repos_url":"https://api.github.com/users/nllong/repos","events_url":"https://api.github.com/users/nllong/events{/privacy}","received_events_url":"https://api.github.com/users/nllong/received_events","type":"User","site_admin":false},"body":"#### Any background context you want to provide?\r\nData quality checks that looked for required numbers did not work if the empty field was a string with a space (e.g. \" \"). \r\n\r\n#### What's this PR do?\r\n* Fix the typecasting to strip leading and trailing spaces before attempting to typecast.\r\n* Scope the rules and data types under the Rule class\r\n* Add unit tests to typecasting\r\n\r\n#### How should this be manually tested?\r\nFollow instructions in #1408 \r\n\r\n#### What are the relevant tickets?\r\n#1408 \r\n\r\n#### Screenshots (if appropriate)\r\nN/A\r\n\r\n#### Definition of Done:\r\n- [ ] Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)\r\n- [ ] Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)\r\n- [ ] Does this PR require a regression test? All fixes require a regression test.\r\n- [ ] Does this add new dependencies? If so, does PIP, npm, bower requirements need to be updated?","created_at":"2018-08-31T17:02:00Z","updated_at":"2018-08-31T17:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SEED-platform/seed/pulls/1703/commits","review_comments_url":"https://api.github.com/repos/SEED-platform/seed/pulls/1703/comments","review_comment_url":"https://api.github.com/repos/SEED-platform/seed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SEED-platform/seed/issues/1703/comments","statuses_url":"https://api.github.com/repos/SEED-platform/seed/statuses/3d1e6152a296df23d12d65491d16071380180311","head":{"label":"SEED-platform:1408-dq-error-case","ref":"1408-dq-error-case","sha":"3d1e6152a296df23d12d65491d16071380180311","user":{"login":"SEED-platform","id":7445100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDUxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7445100?v=4","gravatar_id":"","url":"https://api.github.com/users/SEED-platform","html_url":"https://github.com/SEED-platform","followers_url":"https://api.github.com/users/SEED-platform/followers","following_url":"https://api.github.com/users/SEED-platform/following{/other_user}","gists_url":"https://api.github.com/users/SEED-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/SEED-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEED-platform/subscriptions","organizations_url":"https://api.github.com/users/SEED-platform/orgs","repos_url":"https://api.github.com/users/SEED-platform/repos","events_url":"https://api.github.com/users/SEED-platform/events{/privacy}","received_events_url":"https://api.github.com/users/SEED-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":25450714,"node_id":"MDEwOlJlcG9zaXRvcnkyNTQ1MDcxNA==","name":"seed","full_name":"SEED-platform/seed","owner":{"login":"SEED-platform","id":7445100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDUxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7445100?v=4","gravatar_id":"","url":"https://api.github.com/users/SEED-platform","html_url":"https://github.com/SEED-platform","followers_url":"https://api.github.com/users/SEED-platform/followers","following_url":"https://api.github.com/users/SEED-platform/following{/other_user}","gists_url":"https://api.github.com/users/SEED-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/SEED-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEED-platform/subscriptions","organizations_url":"https://api.github.com/users/SEED-platform/orgs","repos_url":"https://api.github.com/users/SEED-platform/repos","events_url":"https://api.github.com/users/SEED-platform/events{/privacy}","received_events_url":"https://api.github.com/users/SEED-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SEED-platform/seed","description":"Standard Energy Efficiency Data (SEED) Platform™","fork":false,"url":"https://api.github.com/repos/SEED-platform/seed","forks_url":"https://api.github.com/repos/SEED-platform/seed/forks","keys_url":"https://api.github.com/repos/SEED-platform/seed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SEED-platform/seed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SEED-platform/seed/teams","hooks_url":"https://api.github.com/repos/SEED-platform/seed/hooks","issue_events_url":"https://api.github.com/repos/SEED-platform/seed/issues/events{/number}","events_url":"https://api.github.com/repos/SEED-platform/seed/events","assignees_url":"https://api.github.com/repos/SEED-platform/seed/assignees{/user}","branches_url":"https://api.github.com/repos/SEED-platform/seed/branches{/branch}","tags_url":"https://api.github.com/repos/SEED-platform/seed/tags","blobs_url":"https://api.github.com/repos/SEED-platform/seed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SEED-platform/seed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SEED-platform/seed/git/refs{/sha}","trees_url":"https://api.github.com/repos/SEED-platform/seed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SEED-platform/seed/statuses/{sha}","languages_url":"https://api.github.com/repos/SEED-platform/seed/languages","stargazers_url":"https://api.github.com/repos/SEED-platform/seed/stargazers","contributors_url":"https://api.github.com/repos/SEED-platform/seed/contributors","subscribers_url":"https://api.github.com/repos/SEED-platform/seed/subscribers","subscription_url":"https://api.github.com/repos/SEED-platform/seed/subscription","commits_url":"https://api.github.com/repos/SEED-platform/seed/commits{/sha}","git_commits_url":"https://api.github.com/repos/SEED-platform/seed/git/commits{/sha}","comments_url":"https://api.github.com/repos/SEED-platform/seed/comments{/number}","issue_comment_url":"https://api.github.com/repos/SEED-platform/seed/issues/comments{/number}","contents_url":"https://api.github.com/repos/SEED-platform/seed/contents/{+path}","compare_url":"https://api.github.com/repos/SEED-platform/seed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SEED-platform/seed/merges","archive_url":"https://api.github.com/repos/SEED-platform/seed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SEED-platform/seed/downloads","issues_url":"https://api.github.com/repos/SEED-platform/seed/issues{/number}","pulls_url":"https://api.github.com/repos/SEED-platform/seed/pulls{/number}","milestones_url":"https://api.github.com/repos/SEED-platform/seed/milestones{/number}","notifications_url":"https://api.github.com/repos/SEED-platform/seed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SEED-platform/seed/labels{/name}","releases_url":"https://api.github.com/repos/SEED-platform/seed/releases{/id}","deployments_url":"https://api.github.com/repos/SEED-platform/seed/deployments","created_at":"2014-10-20T04:26:53Z","updated_at":"2018-08-30T14:55:12Z","pushed_at":"2018-08-31T17:01:46Z","git_url":"git://github.com/SEED-platform/seed.git","ssh_url":"git@github.com:SEED-platform/seed.git","clone_url":"https://github.com/SEED-platform/seed.git","svn_url":"https://github.com/SEED-platform/seed","homepage":"","size":37881,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":39,"open_issues":219,"watchers":54,"default_branch":"develop"}},"base":{"label":"SEED-platform:develop","ref":"develop","sha":"c46abd6aec002c1358e83eb1761edf9a5a4f81d3","user":{"login":"SEED-platform","id":7445100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDUxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7445100?v=4","gravatar_id":"","url":"https://api.github.com/users/SEED-platform","html_url":"https://github.com/SEED-platform","followers_url":"https://api.github.com/users/SEED-platform/followers","following_url":"https://api.github.com/users/SEED-platform/following{/other_user}","gists_url":"https://api.github.com/users/SEED-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/SEED-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEED-platform/subscriptions","organizations_url":"https://api.github.com/users/SEED-platform/orgs","repos_url":"https://api.github.com/users/SEED-platform/repos","events_url":"https://api.github.com/users/SEED-platform/events{/privacy}","received_events_url":"https://api.github.com/users/SEED-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":25450714,"node_id":"MDEwOlJlcG9zaXRvcnkyNTQ1MDcxNA==","name":"seed","full_name":"SEED-platform/seed","owner":{"login":"SEED-platform","id":7445100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDUxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7445100?v=4","gravatar_id":"","url":"https://api.github.com/users/SEED-platform","html_url":"https://github.com/SEED-platform","followers_url":"https://api.github.com/users/SEED-platform/followers","following_url":"https://api.github.com/users/SEED-platform/following{/other_user}","gists_url":"https://api.github.com/users/SEED-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/SEED-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEED-platform/subscriptions","organizations_url":"https://api.github.com/users/SEED-platform/orgs","repos_url":"https://api.github.com/users/SEED-platform/repos","events_url":"https://api.github.com/users/SEED-platform/events{/privacy}","received_events_url":"https://api.github.com/users/SEED-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SEED-platform/seed","description":"Standard Energy Efficiency Data (SEED) Platform™","fork":false,"url":"https://api.github.com/repos/SEED-platform/seed","forks_url":"https://api.github.com/repos/SEED-platform/seed/forks","keys_url":"https://api.github.com/repos/SEED-platform/seed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SEED-platform/seed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SEED-platform/seed/teams","hooks_url":"https://api.github.com/repos/SEED-platform/seed/hooks","issue_events_url":"https://api.github.com/repos/SEED-platform/seed/issues/events{/number}","events_url":"https://api.github.com/repos/SEED-platform/seed/events","assignees_url":"https://api.github.com/repos/SEED-platform/seed/assignees{/user}","branches_url":"https://api.github.com/repos/SEED-platform/seed/branches{/branch}","tags_url":"https://api.github.com/repos/SEED-platform/seed/tags","blobs_url":"https://api.github.com/repos/SEED-platform/seed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SEED-platform/seed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SEED-platform/seed/git/refs{/sha}","trees_url":"https://api.github.com/repos/SEED-platform/seed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SEED-platform/seed/statuses/{sha}","languages_url":"https://api.github.com/repos/SEED-platform/seed/languages","stargazers_url":"https://api.github.com/repos/SEED-platform/seed/stargazers","contributors_url":"https://api.github.com/repos/SEED-platform/seed/contributors","subscribers_url":"https://api.github.com/repos/SEED-platform/seed/subscribers","subscription_url":"https://api.github.com/repos/SEED-platform/seed/subscription","commits_url":"https://api.github.com/repos/SEED-platform/seed/commits{/sha}","git_commits_url":"https://api.github.com/repos/SEED-platform/seed/git/commits{/sha}","comments_url":"https://api.github.com/repos/SEED-platform/seed/comments{/number}","issue_comment_url":"https://api.github.com/repos/SEED-platform/seed/issues/comments{/number}","contents_url":"https://api.github.com/repos/SEED-platform/seed/contents/{+path}","compare_url":"https://api.github.com/repos/SEED-platform/seed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SEED-platform/seed/merges","archive_url":"https://api.github.com/repos/SEED-platform/seed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SEED-platform/seed/downloads","issues_url":"https://api.github.com/repos/SEED-platform/seed/issues{/number}","pulls_url":"https://api.github.com/repos/SEED-platform/seed/pulls{/number}","milestones_url":"https://api.github.com/repos/SEED-platform/seed/milestones{/number}","notifications_url":"https://api.github.com/repos/SEED-platform/seed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SEED-platform/seed/labels{/name}","releases_url":"https://api.github.com/repos/SEED-platform/seed/releases{/id}","deployments_url":"https://api.github.com/repos/SEED-platform/seed/deployments","created_at":"2014-10-20T04:26:53Z","updated_at":"2018-08-30T14:55:12Z","pushed_at":"2018-08-31T17:01:46Z","git_url":"git://github.com/SEED-platform/seed.git","ssh_url":"git@github.com:SEED-platform/seed.git","clone_url":"https://github.com/SEED-platform/seed.git","svn_url":"https://github.com/SEED-platform/seed","homepage":"","size":37881,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":39,"open_issues":219,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SEED-platform/seed/pulls/1703"},"html":{"href":"https://github.com/SEED-platform/seed/pull/1703"},"issue":{"href":"https://api.github.com/repos/SEED-platform/seed/issues/1703"},"comments":{"href":"https://api.github.com/repos/SEED-platform/seed/issues/1703/comments"},"review_comments":{"href":"https://api.github.com/repos/SEED-platform/seed/pulls/1703/comments"},"review_comment":{"href":"https://api.github.com/repos/SEED-platform/seed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SEED-platform/seed/pulls/1703/commits"},"statuses":{"href":"https://api.github.com/repos/SEED-platform/seed/statuses/3d1e6152a296df23d12d65491d16071380180311"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":287,"deletions":263,"changed_files":4}}
{"actor":{"display_login":"nllong"}}