{"action":"created","issue":{"url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/261","repository_url":"https://api.github.com/repos/MyOnlineStore/bricks","labels_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/261/comments","events_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/261/events","html_url":"https://github.com/MyOnlineStore/bricks/issues/261","id":382579070,"node_id":"MDU6SXNzdWUzODI1NzkwNzA=","number":261,"title":"Turn RadioButtonGroup into a general Separated component","user":{"login":"CarloPalinckx","id":6347900,"node_id":"MDQ6VXNlcjYzNDc5MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6347900?v=4","gravatar_id":"","url":"https://api.github.com/users/CarloPalinckx","html_url":"https://github.com/CarloPalinckx","followers_url":"https://api.github.com/users/CarloPalinckx/followers","following_url":"https://api.github.com/users/CarloPalinckx/following{/other_user}","gists_url":"https://api.github.com/users/CarloPalinckx/gists{/gist_id}","starred_url":"https://api.github.com/users/CarloPalinckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarloPalinckx/subscriptions","organizations_url":"https://api.github.com/users/CarloPalinckx/orgs","repos_url":"https://api.github.com/users/CarloPalinckx/repos","events_url":"https://api.github.com/users/CarloPalinckx/events{/privacy}","received_events_url":"https://api.github.com/users/CarloPalinckx/received_events","type":"User","site_admin":false},"labels":[{"id":892500783,"node_id":"MDU6TGFiZWw4OTI1MDA3ODM=","url":"https://api.github.com/repos/MyOnlineStore/bricks/labels/RFC%20%F0%9F%8E%A9","name":"RFC 🎩","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-11-20T09:46:36Z","updated_at":"2018-11-20T10:35:24Z","closed_at":null,"author_association":"MEMBER","body":"### Is your feature request related to a problem? Please describe ⚡️\r\nWe are currently starting to see patterns in grouping behavior. We support the `RadioButonGroup` at the moment which actually has nothing to do with the `RadioButton` apart from naming 😄  it just maps children in a `Box` and applies padding.\r\n\r\n### Describe the solution you'd like ✨\r\nI suggest we turn the` RadioButtonGroup` into a component named `Separated`. This component could provide a general way of visually \"grouping\" any element. The current RadioButtonGroup only supports margin as saperator. We could later add a visual divider to this. This could also make the MessageStream obsolete (which is nice) and it could possibly solve some issues we are having when using a Checkbox(group) in a FormRow. \r\n\r\nWe could optionally allow for a prop to be set that enables/disables the leading separator (be it margin or a divider). We could also look into requiring children to be added (If that is even possible in a sane way). This would prevent people from abusing it to position things instead of using a `Box`\r\n\r\n```ts\r\ntype PropsType = {\r\n    leading?: boolean;\r\n    children: ReactElement<any>;\r\n}\r\n```\r\n\r\nWould like some ideas for the prop name. I'm not really sure if it the proper name for what it does.\r\n\r\n### Describe alternatives you've considered 🎡\r\nWe could alternatively double export RadioButtonGroup as CheckBoxGroup\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/comments/440225220","html_url":"https://github.com/MyOnlineStore/bricks/issues/261#issuecomment-440225220","issue_url":"https://api.github.com/repos/MyOnlineStore/bricks/issues/261","id":440225220,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDIyNTIyMA==","user":{"login":"hborghols","id":23050817,"node_id":"MDQ6VXNlcjIzMDUwODE3","avatar_url":"https://avatars3.githubusercontent.com/u/23050817?v=4","gravatar_id":"","url":"https://api.github.com/users/hborghols","html_url":"https://github.com/hborghols","followers_url":"https://api.github.com/users/hborghols/followers","following_url":"https://api.github.com/users/hborghols/following{/other_user}","gists_url":"https://api.github.com/users/hborghols/gists{/gist_id}","starred_url":"https://api.github.com/users/hborghols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hborghols/subscriptions","organizations_url":"https://api.github.com/users/hborghols/orgs","repos_url":"https://api.github.com/users/hborghols/repos","events_url":"https://api.github.com/users/hborghols/events{/privacy}","received_events_url":"https://api.github.com/users/hborghols/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T10:35:24Z","updated_at":"2018-11-20T10:35:24Z","author_association":"COLLABORATOR","body":"😄 nope"}}
{"actor":{"display_login":"hborghols"}}