{"action":"created","comment":{"url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/comments/181803939","pull_request_review_id":112491989,"id":181803939,"diff_hunk":"@@ -39,3 +40,19 @@ data ProducePartition =\n     SpecifiedPartition {-# UNPACK #-} !Int  -- the partition number of the topic\n   | UnassignedPartition\n   deriving (Show, Eq, Ord, Typeable)\n+\n+-- | Represents the report of a successfully delivered message.\n+data ProducerSuccess = ProducerSuccess\n+  { psTopic     :: !TopicName    -- ^ Kafka topic this message was received from\n+  , psPartition :: !PartitionId  -- ^ Kafka partition this message was received from\n+  , psOffset    :: !Offset       -- ^ Offset within the 'crPartition' Kafka partition\n+  , psKey       :: !(Maybe BS.ByteString)\n+  , psValue     :: !(Maybe BS.ByteString)\n+  }\n+  deriving (Eq, Show, Read, Typeable)\n+\n+-- | Represents the failure to deliver a message.\n+data ProducerError = ProducerError","path":"src/Kafka/Producer/Types.hs","position":24,"original_position":24,"commit_id":"6780a9bd57e9ae93595b918b274fed8dc88d46bd","original_commit_id":"6780a9bd57e9ae93595b918b274fed8dc88d46bd","user":{"login":"jameshaydon","id":692690,"avatar_url":"https://avatars0.githubusercontent.com/u/692690?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshaydon","html_url":"https://github.com/jameshaydon","followers_url":"https://api.github.com/users/jameshaydon/followers","following_url":"https://api.github.com/users/jameshaydon/following{/other_user}","gists_url":"https://api.github.com/users/jameshaydon/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshaydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshaydon/subscriptions","organizations_url":"https://api.github.com/users/jameshaydon/orgs","repos_url":"https://api.github.com/users/jameshaydon/repos","events_url":"https://api.github.com/users/jameshaydon/events{/privacy}","received_events_url":"https://api.github.com/users/jameshaydon/received_events","type":"User","site_admin":false},"body":"Hm, I see what you mean, but in the successful case there is more data that one wants. So you have already added `Offset`, but one would also want the `PartitionId` (_not_ the `ProducePartition`).\r\n\r\nOtherwise yes I agree let's go with this plan.","created_at":"2018-04-16T16:30:28Z","updated_at":"2018-04-16T16:30:28Z","html_url":"https://github.com/haskell-works/hw-kafka-client/pull/63#discussion_r181803939","pull_request_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/comments/181803939"},"html":{"href":"https://github.com/haskell-works/hw-kafka-client/pull/63#discussion_r181803939"},"pull_request":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63"}},"in_reply_to_id":181700023},"pull_request":{"url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63","id":181814030,"html_url":"https://github.com/haskell-works/hw-kafka-client/pull/63","diff_url":"https://github.com/haskell-works/hw-kafka-client/pull/63.diff","patch_url":"https://github.com/haskell-works/hw-kafka-client/pull/63.patch","issue_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/63","number":63,"state":"open","locked":false,"title":"Producer callback also signals success","user":{"login":"jameshaydon","id":692690,"avatar_url":"https://avatars0.githubusercontent.com/u/692690?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshaydon","html_url":"https://github.com/jameshaydon","followers_url":"https://api.github.com/users/jameshaydon/followers","following_url":"https://api.github.com/users/jameshaydon/following{/other_user}","gists_url":"https://api.github.com/users/jameshaydon/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshaydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshaydon/subscriptions","organizations_url":"https://api.github.com/users/jameshaydon/orgs","repos_url":"https://api.github.com/users/jameshaydon/repos","events_url":"https://api.github.com/users/jameshaydon/events{/privacy}","received_events_url":"https://api.github.com/users/jameshaydon/received_events","type":"User","site_admin":false},"body":"I have patched for my needs but I see what you mean about `ConsumerRecord` now. I've created a very similar type for the producer. I've moved some of the code into `Shared`. Maybe there should be a generic `Message` in `Kafka.Types` (which replaces `ConsumerRecord`)?\r\n\r\nFeel free to request changes.","created_at":"2018-04-16T10:18:25Z","updated_at":"2018-04-16T16:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e133996d839386de059241108fc5ea404b8ee46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63/commits","review_comments_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63/comments","review_comment_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/63/comments","statuses_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/statuses/6780a9bd57e9ae93595b918b274fed8dc88d46bd","head":{"label":"jameshaydon:master","ref":"master","sha":"6780a9bd57e9ae93595b918b274fed8dc88d46bd","user":{"login":"jameshaydon","id":692690,"avatar_url":"https://avatars0.githubusercontent.com/u/692690?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshaydon","html_url":"https://github.com/jameshaydon","followers_url":"https://api.github.com/users/jameshaydon/followers","following_url":"https://api.github.com/users/jameshaydon/following{/other_user}","gists_url":"https://api.github.com/users/jameshaydon/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshaydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshaydon/subscriptions","organizations_url":"https://api.github.com/users/jameshaydon/orgs","repos_url":"https://api.github.com/users/jameshaydon/repos","events_url":"https://api.github.com/users/jameshaydon/events{/privacy}","received_events_url":"https://api.github.com/users/jameshaydon/received_events","type":"User","site_admin":false},"repo":{"id":129723474,"name":"hw-kafka-client","full_name":"jameshaydon/hw-kafka-client","owner":{"login":"jameshaydon","id":692690,"avatar_url":"https://avatars0.githubusercontent.com/u/692690?v=4","gravatar_id":"","url":"https://api.github.com/users/jameshaydon","html_url":"https://github.com/jameshaydon","followers_url":"https://api.github.com/users/jameshaydon/followers","following_url":"https://api.github.com/users/jameshaydon/following{/other_user}","gists_url":"https://api.github.com/users/jameshaydon/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshaydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshaydon/subscriptions","organizations_url":"https://api.github.com/users/jameshaydon/orgs","repos_url":"https://api.github.com/users/jameshaydon/repos","events_url":"https://api.github.com/users/jameshaydon/events{/privacy}","received_events_url":"https://api.github.com/users/jameshaydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jameshaydon/hw-kafka-client","description":"Kafka client for Haskell, including auto-rebalancing consumers","fork":true,"url":"https://api.github.com/repos/jameshaydon/hw-kafka-client","forks_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/forks","keys_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/teams","hooks_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/hooks","issue_events_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/issues/events{/number}","events_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/events","assignees_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/assignees{/user}","branches_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/branches{/branch}","tags_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/tags","blobs_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/statuses/{sha}","languages_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/languages","stargazers_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/stargazers","contributors_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/contributors","subscribers_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/subscribers","subscription_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/subscription","commits_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/contents/{+path}","compare_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/merges","archive_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/downloads","issues_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/issues{/number}","pulls_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/pulls{/number}","milestones_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/milestones{/number}","notifications_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/labels{/name}","releases_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/releases{/id}","deployments_url":"https://api.github.com/repos/jameshaydon/hw-kafka-client/deployments","created_at":"2018-04-16T10:07:53Z","updated_at":"2018-04-16T10:10:45Z","pushed_at":"2018-04-16T10:10:43Z","git_url":"git://github.com/jameshaydon/hw-kafka-client.git","ssh_url":"git@github.com:jameshaydon/hw-kafka-client.git","clone_url":"https://github.com/jameshaydon/hw-kafka-client.git","svn_url":"https://github.com/jameshaydon/hw-kafka-client","homepage":null,"size":288,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell-works:master","ref":"master","sha":"071262be0b22dc960515f734e15461843a3ae1e8","user":{"login":"haskell-works","id":16098649,"avatar_url":"https://avatars3.githubusercontent.com/u/16098649?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-works","html_url":"https://github.com/haskell-works","followers_url":"https://api.github.com/users/haskell-works/followers","following_url":"https://api.github.com/users/haskell-works/following{/other_user}","gists_url":"https://api.github.com/users/haskell-works/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-works/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-works/subscriptions","organizations_url":"https://api.github.com/users/haskell-works/orgs","repos_url":"https://api.github.com/users/haskell-works/repos","events_url":"https://api.github.com/users/haskell-works/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-works/received_events","type":"Organization","site_admin":false},"repo":{"id":55292593,"name":"hw-kafka-client","full_name":"haskell-works/hw-kafka-client","owner":{"login":"haskell-works","id":16098649,"avatar_url":"https://avatars3.githubusercontent.com/u/16098649?v=4","gravatar_id":"","url":"https://api.github.com/users/haskell-works","html_url":"https://github.com/haskell-works","followers_url":"https://api.github.com/users/haskell-works/followers","following_url":"https://api.github.com/users/haskell-works/following{/other_user}","gists_url":"https://api.github.com/users/haskell-works/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-works/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-works/subscriptions","organizations_url":"https://api.github.com/users/haskell-works/orgs","repos_url":"https://api.github.com/users/haskell-works/repos","events_url":"https://api.github.com/users/haskell-works/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-works/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-works/hw-kafka-client","description":"Kafka client for Haskell, including auto-rebalancing consumers","fork":false,"url":"https://api.github.com/repos/haskell-works/hw-kafka-client","forks_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/forks","keys_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/teams","hooks_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/hooks","issue_events_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/events","assignees_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/tags","blobs_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/languages","stargazers_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/stargazers","contributors_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/contributors","subscribers_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/subscribers","subscription_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/subscription","commits_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/merges","archive_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/downloads","issues_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/labels{/name}","releases_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/releases{/id}","deployments_url":"https://api.github.com/repos/haskell-works/hw-kafka-client/deployments","created_at":"2016-04-02T12:09:01Z","updated_at":"2018-04-16T14:23:18Z","pushed_at":"2018-04-16T14:23:50Z","git_url":"git://github.com/haskell-works/hw-kafka-client.git","ssh_url":"git@github.com:haskell-works/hw-kafka-client.git","clone_url":"https://github.com/haskell-works/hw-kafka-client.git","svn_url":"https://github.com/haskell-works/hw-kafka-client","homepage":null,"size":289,"stargazers_count":31,"watchers_count":31,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":6,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63"},"html":{"href":"https://github.com/haskell-works/hw-kafka-client/pull/63"},"issue":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/63"},"comments":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-works/hw-kafka-client/statuses/6780a9bd57e9ae93595b918b274fed8dc88d46bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"jameshaydon"}}