{"action":"created","comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/210247165","pull_request_review_id":146419077,"id":210247165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI0NzE2NQ==","diff_hunk":"@@ -26,6 +27,15 @@ export default function Sidebar( { settings, store, theme } ) {\n \treturn (\n \t\t<Fragment>\n \t\t\t<Fill name=\"YoastSidebar\">\n+\t\t\t\t{ <SidebarItem renderPriority={ 5 }>\n+\t\t\t\t\t<ThemeProvider theme={ theme }>\n+\t\t\t\t\t\t<StoreProvider store={ store }>\n+\t\t\t\t\t\t\t<div>","path":"js/src/components/Sidebar.js","position":23,"original_position":23,"commit_id":"9719ddf85a0ba7a64d61a7620b974ae0d0be172d","original_commit_id":"9719ddf85a0ba7a64d61a7620b974ae0d0be172d","user":{"login":"IreneStr","id":17744553,"node_id":"MDQ6VXNlcjE3NzQ0NTUz","avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"body":"Why this div?","created_at":"2018-08-15T12:06:26Z","updated_at":"2018-08-15T12:15:27Z","html_url":"https://github.com/Yoast/wordpress-seo/pull/10636#discussion_r210247165","pull_request_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments/210247165"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/10636#discussion_r210247165"},"pull_request":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636"}}},"pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636","id":208426644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDI2NjQ0","html_url":"https://github.com/Yoast/wordpress-seo/pull/10636","diff_url":"https://github.com/Yoast/wordpress-seo/pull/10636.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/10636.patch","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10636","number":10636,"state":"open","locked":false,"title":"Added Snippet editor to modal, added item in sidebar for access","user":{"login":"Dieterrr","id":16388834,"node_id":"MDQ6VXNlcjE2Mzg4ODM0","avatar_url":"https://avatars3.githubusercontent.com/u/16388834?v=4","gravatar_id":"","url":"https://api.github.com/users/Dieterrr","html_url":"https://github.com/Dieterrr","followers_url":"https://api.github.com/users/Dieterrr/followers","following_url":"https://api.github.com/users/Dieterrr/following{/other_user}","gists_url":"https://api.github.com/users/Dieterrr/gists{/gist_id}","starred_url":"https://api.github.com/users/Dieterrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dieterrr/subscriptions","organizations_url":"https://api.github.com/users/Dieterrr/orgs","repos_url":"https://api.github.com/users/Dieterrr/repos","events_url":"https://api.github.com/users/Dieterrr/events{/privacy}","received_events_url":"https://api.github.com/users/Dieterrr/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* Implements the Snippet Preview Editor in the sidebar, accessible through a modal. \r\n\r\n## Relevant technical choices:\r\n\r\n* Added an extra component 'ButtonSection.js' (in Yoast Components) to the sidebar, based on the standard collapsible: showing a header and an icon. Clicking the component should open the modal. I say should because this part does not function correctly yet. I've added a `<p>` below the element to show the modal and onClick event work fine. Just for some reason not on the component. \r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Check out this branch (same name) both in Yoast components and in Wordpress-seo. Run `yarn link` in the yoast components folder.\r\n* In your wordpress-seo folder run `yarn link yoast-components` and build all the files. Run `yarn start` if you're running a dev envirionment. \r\n* Edit a post, on the right in the sidebar you should see a new component: \"Snippet Preview\". Clicking this should open a modal. This does not work so click the text \"Snippet Preview Editor\" below it. This should open a modal with the full Snippet Preview editor in it. The difference with the one in the metabox should be that it's always expanded and has no option to collapse it. It has two buttons to close it, both should work. \r\n\r\n## Quality assurance\r\n\r\n* [x] I have tested this code to the best of my abilities\r\n* [ ] I have added unittests to verify the code works as intended\r\n\r\nFixes #[707](https://github.com/Yoast/yoast-components/issues/707)\r\nRequires #[712](https://github.com/Yoast/yoast-components/pull/712)\r\n","created_at":"2018-08-14T22:19:59Z","updated_at":"2018-08-15T12:15:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636/commits","review_comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636/comments","review_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10636/comments","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/9719ddf85a0ba7a64d61a7620b974ae0d0be172d","head":{"label":"Yoast:707-snippet-editor-in-modal","ref":"707-snippet-editor-in-modal","sha":"9719ddf85a0ba7a64d61a7620b974ae0d0be172d","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2018-08-15T11:56:46Z","pushed_at":"2018-08-15T12:00:27Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":499234,"stargazers_count":950,"watchers_count":950,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":1062,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":549,"open_issues":1062,"watchers":950,"default_branch":"trunk"}},"base":{"label":"Yoast:trunk","ref":"trunk","sha":"2527254ffeb39c1a73b2dc9362f136bb460701ff","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":6723399,"node_id":"MDEwOlJlcG9zaXRvcnk2NzIzMzk5","name":"wordpress-seo","full_name":"Yoast/wordpress-seo","owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/wordpress-seo","description":"Yoast SEO for WordPress","fork":false,"url":"https://api.github.com/repos/Yoast/wordpress-seo","forks_url":"https://api.github.com/repos/Yoast/wordpress-seo/forks","keys_url":"https://api.github.com/repos/Yoast/wordpress-seo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/wordpress-seo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/wordpress-seo/teams","hooks_url":"https://api.github.com/repos/Yoast/wordpress-seo/hooks","issue_events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/events","assignees_url":"https://api.github.com/repos/Yoast/wordpress-seo/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/wordpress-seo/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/tags","blobs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/wordpress-seo/languages","stargazers_url":"https://api.github.com/repos/Yoast/wordpress-seo/stargazers","contributors_url":"https://api.github.com/repos/Yoast/wordpress-seo/contributors","subscribers_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscribers","subscription_url":"https://api.github.com/repos/Yoast/wordpress-seo/subscription","commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/wordpress-seo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/wordpress-seo/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/wordpress-seo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/wordpress-seo/merges","archive_url":"https://api.github.com/repos/Yoast/wordpress-seo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/wordpress-seo/downloads","issues_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/wordpress-seo/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/wordpress-seo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/wordpress-seo/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/wordpress-seo/deployments","created_at":"2012-11-16T15:16:29Z","updated_at":"2018-08-15T11:56:46Z","pushed_at":"2018-08-15T12:00:27Z","git_url":"git://github.com/Yoast/wordpress-seo.git","ssh_url":"git@github.com:Yoast/wordpress-seo.git","clone_url":"https://github.com/Yoast/wordpress-seo.git","svn_url":"https://github.com/Yoast/wordpress-seo","homepage":"http://yoast.com/wordpress/seo/","size":499234,"stargazers_count":950,"watchers_count":950,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":1062,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":549,"open_issues":1062,"watchers":950,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636"},"html":{"href":"https://github.com/Yoast/wordpress-seo/pull/10636"},"issue":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10636"},"comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/issues/10636/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/10636/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/wordpress-seo/statuses/9719ddf85a0ba7a64d61a7620b974ae0d0be172d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"IreneStr"}}