{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/165541150","pull_request_review_id":93499743,"id":165541150,"diff_hunk":"@@ -488,14 +488,24 @@ private void checkClassAccess(Class<?> targetClass) throws IllegalAccessExceptio\n \t\t\t\t}\n \t\t\t\t\n \t\t\t\tint modifiers = targetClass.getModifiers();\n-\t\t\t\tif (Modifier.isPublic(modifiers)) {\n-\t\t\t\t\t/* Already determined that we have more than \"no access\" (public access) */\n-\t\t\t\t\treturn;\n-\t\t\t\t} else if (Modifier.isProtected(modifiers)) {\n-\t\t\t\t\t/* Already determined that we have more than \"no access\" (public access) for a protected nested class */\n+\t\t\t\t\n+\t\t\t\t/* A protected class (must be a member class) is compiled to a public class as\n+\t\t\t\t * the protected flag of this class doesn't exist on the VM level (there is no \n+\t\t\t\t * access flag in the binary form representing 'protected')\n+\t\t\t\t */\n+\t\t\t\tif (Modifier.isProtected(modifiers)) {\n+\t\t\t\t\t/* Oracle Security-in-Depth Fix 8037326:","path":"jcl/src/java.base/share/classes/java/lang/invoke/MethodHandles.java","position":null,"original_position":15,"commit_id":"047615875231d3c0215e10c2e3fad6b78d005674","original_commit_id":"6df55c54a06a6231cefd3e2c6558f767dda99dc0","user":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"body":"Already removed.","created_at":"2018-02-02T01:54:48Z","updated_at":"2018-02-02T01:54:48Z","html_url":"https://github.com/eclipse/openj9/pull/692#discussion_r165541150","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/692","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/165541150"},"html":{"href":"https://github.com/eclipse/openj9/pull/692#discussion_r165541150"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/692"}},"in_reply_to_id":165517348},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/692","id":154923288,"html_url":"https://github.com/eclipse/openj9/pull/692","diff_url":"https://github.com/eclipse/openj9/pull/692.diff","patch_url":"https://github.com/eclipse/openj9/pull/692.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/692","number":692,"state":"open","locked":false,"title":"Refactoring the access check for class/member","user":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"body":"The changes to ensure the check for class is completed\r\nvia checkClassAccess while the check for class members\r\n(including the member classes) is completed via\r\ncheckMemberAccess.\r\n\r\nFix: #636\r\n\r\nSigned-off-by: CHENGJin <jincheng@ca.ibm.com>","created_at":"2017-11-27T21:39:33Z","updated_at":"2018-02-02T01:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"816c36f5d0443bd7e983273824cc92a57e18e6b8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/692/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/692/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/692/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/047615875231d3c0215e10c2e3fad6b78d005674","head":{"label":"ChengJin01:MH_checkAccess","ref":"MH_checkAccess","sha":"047615875231d3c0215e10c2e3fad6b78d005674","user":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"repo":{"id":103943978,"name":"openj9","full_name":"ChengJin01/openj9","owner":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChengJin01/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/ChengJin01/openj9","forks_url":"https://api.github.com/repos/ChengJin01/openj9/forks","keys_url":"https://api.github.com/repos/ChengJin01/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChengJin01/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChengJin01/openj9/teams","hooks_url":"https://api.github.com/repos/ChengJin01/openj9/hooks","issue_events_url":"https://api.github.com/repos/ChengJin01/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/ChengJin01/openj9/events","assignees_url":"https://api.github.com/repos/ChengJin01/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/ChengJin01/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/ChengJin01/openj9/tags","blobs_url":"https://api.github.com/repos/ChengJin01/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChengJin01/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChengJin01/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChengJin01/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChengJin01/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/ChengJin01/openj9/languages","stargazers_url":"https://api.github.com/repos/ChengJin01/openj9/stargazers","contributors_url":"https://api.github.com/repos/ChengJin01/openj9/contributors","subscribers_url":"https://api.github.com/repos/ChengJin01/openj9/subscribers","subscription_url":"https://api.github.com/repos/ChengJin01/openj9/subscription","commits_url":"https://api.github.com/repos/ChengJin01/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChengJin01/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChengJin01/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChengJin01/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChengJin01/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/ChengJin01/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChengJin01/openj9/merges","archive_url":"https://api.github.com/repos/ChengJin01/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChengJin01/openj9/downloads","issues_url":"https://api.github.com/repos/ChengJin01/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/ChengJin01/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/ChengJin01/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/ChengJin01/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChengJin01/openj9/labels{/name}","releases_url":"https://api.github.com/repos/ChengJin01/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/ChengJin01/openj9/deployments","created_at":"2017-09-18T13:40:00Z","updated_at":"2017-09-18T13:40:28Z","pushed_at":"2018-02-02T01:53:08Z","git_url":"git://github.com/ChengJin01/openj9.git","ssh_url":"git@github.com:ChengJin01/openj9.git","clone_url":"https://github.com/ChengJin01/openj9.git","svn_url":"https://github.com/ChengJin01/openj9","homepage":null,"size":25997,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"99d501e91e721b66a98f788ea888d0ac775685fa","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-01-31T16:47:15Z","pushed_at":"2018-02-02T01:53:10Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":25961,"stargazers_count":1165,"watchers_count":1165,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":220,"open_issues":220,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/692"},"html":{"href":"https://github.com/eclipse/openj9/pull/692"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/692"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/047615875231d3c0215e10c2e3fad6b78d005674"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChengJin01"}}