{"action":"created","comment":{"url":"https://api.github.com/repos/devopsfaith/krakend/pulls/comments/169418725","pull_request_review_id":97942146,"id":169418725,"diff_hunk":"@@ -110,7 +125,13 @@ func setup(timeout time.Duration, p proxy.Proxy) (string, *http.Response, error)\n func startGinServer(handlerFunc gin.HandlerFunc) *gin.Engine {\n \tgin.SetMode(gin.TestMode)\n \trouter := gin.New()\n-\trouter.GET(\"/_gin_endpoint/:param\", handlerFunc)\n+\trouter.GET(\"/_gin_endpoint/:param\", ctxMiddleware, handlerFunc)","path":"router/gin/endpoint_test.go","position":36,"original_position":36,"commit_id":"f5210ec3d501a36a0c583228163d3f0db76728f2","original_commit_id":"f5210ec3d501a36a0c583228163d3f0db76728f2","user":{"login":"joaoqalves","id":843454,"avatar_url":"https://avatars0.githubusercontent.com/u/843454?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoqalves","html_url":"https://github.com/joaoqalves","followers_url":"https://api.github.com/users/joaoqalves/followers","following_url":"https://api.github.com/users/joaoqalves/following{/other_user}","gists_url":"https://api.github.com/users/joaoqalves/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoqalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoqalves/subscriptions","organizations_url":"https://api.github.com/users/joaoqalves/orgs","repos_url":"https://api.github.com/users/joaoqalves/repos","events_url":"https://api.github.com/users/joaoqalves/events{/privacy}","received_events_url":"https://api.github.com/users/joaoqalves/received_events","type":"User","site_admin":false},"body":"Not related to the PR itself, but:\r\n\r\n> At Google, we require that Go programmers pass **a Context parameter as the first argument** to every function on the call path between incoming and outgoing requests. This allows Go code developed by many different teams to interoperate well. It provides simple control over timeouts and cancelation and ensures that critical values like security credentials transit Go programs properly.\r\n\r\nDo you think it makes sense to open a PR and to set this standard in Krakend as well?\r\n","created_at":"2018-02-20T18:42:52Z","updated_at":"2018-02-20T18:42:53Z","html_url":"https://github.com/devopsfaith/krakend/pull/91#discussion_r169418725","pull_request_url":"https://api.github.com/repos/devopsfaith/krakend/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/comments/169418725"},"html":{"href":"https://github.com/devopsfaith/krakend/pull/91#discussion_r169418725"},"pull_request":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/devopsfaith/krakend/pulls/91","id":170274365,"html_url":"https://github.com/devopsfaith/krakend/pull/91","diff_url":"https://github.com/devopsfaith/krakend/pull/91.diff","patch_url":"https://github.com/devopsfaith/krakend/pull/91.patch","issue_url":"https://api.github.com/repos/devopsfaith/krakend/issues/91","number":91,"state":"open","locked":false,"title":"Pass context from the router to the proxy","user":{"login":"kpacha","id":1307694,"avatar_url":"https://avatars3.githubusercontent.com/u/1307694?v=4","gravatar_id":"","url":"https://api.github.com/users/kpacha","html_url":"https://github.com/kpacha","followers_url":"https://api.github.com/users/kpacha/followers","following_url":"https://api.github.com/users/kpacha/following{/other_user}","gists_url":"https://api.github.com/users/kpacha/gists{/gist_id}","starred_url":"https://api.github.com/users/kpacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpacha/subscriptions","organizations_url":"https://api.github.com/users/kpacha/orgs","repos_url":"https://api.github.com/users/kpacha/repos","events_url":"https://api.github.com/users/kpacha/events{/privacy}","received_events_url":"https://api.github.com/users/kpacha/received_events","type":"User","site_admin":false},"body":"test the context values are passed from the router to the proxy layer. closes #90","created_at":"2018-02-20T18:36:42Z","updated_at":"2018-02-20T18:42:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9cceff40026aa1bae694c3175bfe39b4452cd82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devopsfaith/krakend/pulls/91/commits","review_comments_url":"https://api.github.com/repos/devopsfaith/krakend/pulls/91/comments","review_comment_url":"https://api.github.com/repos/devopsfaith/krakend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devopsfaith/krakend/issues/91/comments","statuses_url":"https://api.github.com/repos/devopsfaith/krakend/statuses/f5210ec3d501a36a0c583228163d3f0db76728f2","head":{"label":"devopsfaith:propagate_context","ref":"propagate_context","sha":"f5210ec3d501a36a0c583228163d3f0db76728f2","user":{"login":"devopsfaith","id":23139751,"avatar_url":"https://avatars3.githubusercontent.com/u/23139751?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsfaith","html_url":"https://github.com/devopsfaith","followers_url":"https://api.github.com/users/devopsfaith/followers","following_url":"https://api.github.com/users/devopsfaith/following{/other_user}","gists_url":"https://api.github.com/users/devopsfaith/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsfaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsfaith/subscriptions","organizations_url":"https://api.github.com/users/devopsfaith/orgs","repos_url":"https://api.github.com/users/devopsfaith/repos","events_url":"https://api.github.com/users/devopsfaith/events{/privacy}","received_events_url":"https://api.github.com/users/devopsfaith/received_events","type":"Organization","site_admin":false},"repo":{"id":72875399,"name":"krakend","full_name":"devopsfaith/krakend","owner":{"login":"devopsfaith","id":23139751,"avatar_url":"https://avatars3.githubusercontent.com/u/23139751?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsfaith","html_url":"https://github.com/devopsfaith","followers_url":"https://api.github.com/users/devopsfaith/followers","following_url":"https://api.github.com/users/devopsfaith/following{/other_user}","gists_url":"https://api.github.com/users/devopsfaith/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsfaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsfaith/subscriptions","organizations_url":"https://api.github.com/users/devopsfaith/orgs","repos_url":"https://api.github.com/users/devopsfaith/repos","events_url":"https://api.github.com/users/devopsfaith/events{/privacy}","received_events_url":"https://api.github.com/users/devopsfaith/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devopsfaith/krakend","description":"Ultra performant API Gateway with middlewares","fork":false,"url":"https://api.github.com/repos/devopsfaith/krakend","forks_url":"https://api.github.com/repos/devopsfaith/krakend/forks","keys_url":"https://api.github.com/repos/devopsfaith/krakend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devopsfaith/krakend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devopsfaith/krakend/teams","hooks_url":"https://api.github.com/repos/devopsfaith/krakend/hooks","issue_events_url":"https://api.github.com/repos/devopsfaith/krakend/issues/events{/number}","events_url":"https://api.github.com/repos/devopsfaith/krakend/events","assignees_url":"https://api.github.com/repos/devopsfaith/krakend/assignees{/user}","branches_url":"https://api.github.com/repos/devopsfaith/krakend/branches{/branch}","tags_url":"https://api.github.com/repos/devopsfaith/krakend/tags","blobs_url":"https://api.github.com/repos/devopsfaith/krakend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devopsfaith/krakend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devopsfaith/krakend/git/refs{/sha}","trees_url":"https://api.github.com/repos/devopsfaith/krakend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devopsfaith/krakend/statuses/{sha}","languages_url":"https://api.github.com/repos/devopsfaith/krakend/languages","stargazers_url":"https://api.github.com/repos/devopsfaith/krakend/stargazers","contributors_url":"https://api.github.com/repos/devopsfaith/krakend/contributors","subscribers_url":"https://api.github.com/repos/devopsfaith/krakend/subscribers","subscription_url":"https://api.github.com/repos/devopsfaith/krakend/subscription","commits_url":"https://api.github.com/repos/devopsfaith/krakend/commits{/sha}","git_commits_url":"https://api.github.com/repos/devopsfaith/krakend/git/commits{/sha}","comments_url":"https://api.github.com/repos/devopsfaith/krakend/comments{/number}","issue_comment_url":"https://api.github.com/repos/devopsfaith/krakend/issues/comments{/number}","contents_url":"https://api.github.com/repos/devopsfaith/krakend/contents/{+path}","compare_url":"https://api.github.com/repos/devopsfaith/krakend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devopsfaith/krakend/merges","archive_url":"https://api.github.com/repos/devopsfaith/krakend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devopsfaith/krakend/downloads","issues_url":"https://api.github.com/repos/devopsfaith/krakend/issues{/number}","pulls_url":"https://api.github.com/repos/devopsfaith/krakend/pulls{/number}","milestones_url":"https://api.github.com/repos/devopsfaith/krakend/milestones{/number}","notifications_url":"https://api.github.com/repos/devopsfaith/krakend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devopsfaith/krakend/labels{/name}","releases_url":"https://api.github.com/repos/devopsfaith/krakend/releases{/id}","deployments_url":"https://api.github.com/repos/devopsfaith/krakend/deployments","created_at":"2016-11-04T18:37:13Z","updated_at":"2018-02-20T16:17:24Z","pushed_at":"2018-02-20T18:36:42Z","git_url":"git://github.com/devopsfaith/krakend.git","ssh_url":"git@github.com:devopsfaith/krakend.git","clone_url":"https://github.com/devopsfaith/krakend.git","svn_url":"https://github.com/devopsfaith/krakend","homepage":"http://www.krakend.io","size":483,"stargazers_count":309,"watchers_count":309,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":40,"open_issues":9,"watchers":309,"default_branch":"master"}},"base":{"label":"devopsfaith:master","ref":"master","sha":"e310098a3004e054fc7e0b04fdaea1b6783cb62a","user":{"login":"devopsfaith","id":23139751,"avatar_url":"https://avatars3.githubusercontent.com/u/23139751?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsfaith","html_url":"https://github.com/devopsfaith","followers_url":"https://api.github.com/users/devopsfaith/followers","following_url":"https://api.github.com/users/devopsfaith/following{/other_user}","gists_url":"https://api.github.com/users/devopsfaith/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsfaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsfaith/subscriptions","organizations_url":"https://api.github.com/users/devopsfaith/orgs","repos_url":"https://api.github.com/users/devopsfaith/repos","events_url":"https://api.github.com/users/devopsfaith/events{/privacy}","received_events_url":"https://api.github.com/users/devopsfaith/received_events","type":"Organization","site_admin":false},"repo":{"id":72875399,"name":"krakend","full_name":"devopsfaith/krakend","owner":{"login":"devopsfaith","id":23139751,"avatar_url":"https://avatars3.githubusercontent.com/u/23139751?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsfaith","html_url":"https://github.com/devopsfaith","followers_url":"https://api.github.com/users/devopsfaith/followers","following_url":"https://api.github.com/users/devopsfaith/following{/other_user}","gists_url":"https://api.github.com/users/devopsfaith/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsfaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsfaith/subscriptions","organizations_url":"https://api.github.com/users/devopsfaith/orgs","repos_url":"https://api.github.com/users/devopsfaith/repos","events_url":"https://api.github.com/users/devopsfaith/events{/privacy}","received_events_url":"https://api.github.com/users/devopsfaith/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devopsfaith/krakend","description":"Ultra performant API Gateway with middlewares","fork":false,"url":"https://api.github.com/repos/devopsfaith/krakend","forks_url":"https://api.github.com/repos/devopsfaith/krakend/forks","keys_url":"https://api.github.com/repos/devopsfaith/krakend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devopsfaith/krakend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devopsfaith/krakend/teams","hooks_url":"https://api.github.com/repos/devopsfaith/krakend/hooks","issue_events_url":"https://api.github.com/repos/devopsfaith/krakend/issues/events{/number}","events_url":"https://api.github.com/repos/devopsfaith/krakend/events","assignees_url":"https://api.github.com/repos/devopsfaith/krakend/assignees{/user}","branches_url":"https://api.github.com/repos/devopsfaith/krakend/branches{/branch}","tags_url":"https://api.github.com/repos/devopsfaith/krakend/tags","blobs_url":"https://api.github.com/repos/devopsfaith/krakend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devopsfaith/krakend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devopsfaith/krakend/git/refs{/sha}","trees_url":"https://api.github.com/repos/devopsfaith/krakend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devopsfaith/krakend/statuses/{sha}","languages_url":"https://api.github.com/repos/devopsfaith/krakend/languages","stargazers_url":"https://api.github.com/repos/devopsfaith/krakend/stargazers","contributors_url":"https://api.github.com/repos/devopsfaith/krakend/contributors","subscribers_url":"https://api.github.com/repos/devopsfaith/krakend/subscribers","subscription_url":"https://api.github.com/repos/devopsfaith/krakend/subscription","commits_url":"https://api.github.com/repos/devopsfaith/krakend/commits{/sha}","git_commits_url":"https://api.github.com/repos/devopsfaith/krakend/git/commits{/sha}","comments_url":"https://api.github.com/repos/devopsfaith/krakend/comments{/number}","issue_comment_url":"https://api.github.com/repos/devopsfaith/krakend/issues/comments{/number}","contents_url":"https://api.github.com/repos/devopsfaith/krakend/contents/{+path}","compare_url":"https://api.github.com/repos/devopsfaith/krakend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devopsfaith/krakend/merges","archive_url":"https://api.github.com/repos/devopsfaith/krakend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devopsfaith/krakend/downloads","issues_url":"https://api.github.com/repos/devopsfaith/krakend/issues{/number}","pulls_url":"https://api.github.com/repos/devopsfaith/krakend/pulls{/number}","milestones_url":"https://api.github.com/repos/devopsfaith/krakend/milestones{/number}","notifications_url":"https://api.github.com/repos/devopsfaith/krakend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devopsfaith/krakend/labels{/name}","releases_url":"https://api.github.com/repos/devopsfaith/krakend/releases{/id}","deployments_url":"https://api.github.com/repos/devopsfaith/krakend/deployments","created_at":"2016-11-04T18:37:13Z","updated_at":"2018-02-20T16:17:24Z","pushed_at":"2018-02-20T18:36:42Z","git_url":"git://github.com/devopsfaith/krakend.git","ssh_url":"git@github.com:devopsfaith/krakend.git","clone_url":"https://github.com/devopsfaith/krakend.git","svn_url":"https://github.com/devopsfaith/krakend","homepage":"http://www.krakend.io","size":483,"stargazers_count":309,"watchers_count":309,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":40,"open_issues":9,"watchers":309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/91"},"html":{"href":"https://github.com/devopsfaith/krakend/pull/91"},"issue":{"href":"https://api.github.com/repos/devopsfaith/krakend/issues/91"},"comments":{"href":"https://api.github.com/repos/devopsfaith/krakend/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devopsfaith/krakend/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/devopsfaith/krakend/statuses/f5210ec3d501a36a0c583228163d3f0db76728f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joaoqalves"}}