{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/232380873","pull_request_review_id":173572760,"id":232380873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM4MDg3Mw==","diff_hunk":"@@ -62,9 +63,26 @@\n        [react/view {:style styles/timestamp}\n         [chat-item/message-timestamp (:timestamp last-message)]]])))\n \n-(defn chat-list-item [[chat-id chat]]\n-  [react/touchable-highlight {:on-press #(re-frame/dispatch [:chat.ui/navigate-to-chat chat-id])}\n-   [chat-list-item-inner-view (assoc chat :chat-id chat-id)]])\n+(defn chat-list-item [[chat-id\n+                       {:keys [group-chat public? public-key] :as chat}]]\n+  [popup-menu/wrap-with-menu\n+   [chat-list-item-inner-view (assoc chat :chat-id chat-id)]\n+   (remove nil?","path":"src/status_im/ui/screens/desktop/main/tabs/home/views.cljs","position":19,"original_position":19,"commit_id":"6420acf5d14fc5cefe252fd2deee54933e2e3ad7","original_commit_id":"6420acf5d14fc5cefe252fd2deee54933e2e3ad7","user":{"login":"rcullito","id":909156,"node_id":"MDQ6VXNlcjkwOTE1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/909156?v=4","gravatar_id":"","url":"https://api.github.com/users/rcullito","html_url":"https://github.com/rcullito","followers_url":"https://api.github.com/users/rcullito/followers","following_url":"https://api.github.com/users/rcullito/following{/other_user}","gists_url":"https://api.github.com/users/rcullito/gists{/gist_id}","starred_url":"https://api.github.com/users/rcullito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcullito/subscriptions","organizations_url":"https://api.github.com/users/rcullito/orgs","repos_url":"https://api.github.com/users/rcullito/repos","events_url":"https://api.github.com/users/rcullito/events{/privacy}","received_events_url":"https://api.github.com/users/rcullito/received_events","type":"User","site_admin":false},"body":"which set of chats are expected to not be removed here? just private, or are we up to additional categories? :eye: ","created_at":"2018-11-09T20:15:45Z","updated_at":"2018-11-09T20:16:51Z","html_url":"https://github.com/status-im/status-react/pull/6671#discussion_r232380873","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/6671","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/232380873"},"html":{"href":"https://github.com/status-im/status-react/pull/6671#discussion_r232380873"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6671"}}},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/6671","id":229670597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjcwNTk3","html_url":"https://github.com/status-im/status-react/pull/6671","diff_url":"https://github.com/status-im/status-react/pull/6671.diff","patch_url":"https://github.com/status-im/status-react/pull/6671.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/6671","number":6671,"state":"open","locked":false,"title":"Add popup menu support for chat header and chat list","user":{"login":"siphiuel","id":1019573,"node_id":"MDQ6VXNlcjEwMTk1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1019573?v=4","gravatar_id":"","url":"https://api.github.com/users/siphiuel","html_url":"https://github.com/siphiuel","followers_url":"https://api.github.com/users/siphiuel/followers","following_url":"https://api.github.com/users/siphiuel/following{/other_user}","gists_url":"https://api.github.com/users/siphiuel/gists{/gist_id}","starred_url":"https://api.github.com/users/siphiuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siphiuel/subscriptions","organizations_url":"https://api.github.com/users/siphiuel/orgs","repos_url":"https://api.github.com/users/siphiuel/repos","events_url":"https://api.github.com/users/siphiuel/events{/privacy}","received_events_url":"https://api.github.com/users/siphiuel/received_events","type":"User","site_admin":false},"body":"New fn `status-im.ui.components.popup-menu.views/wrap-with-menu` is added. It creates a popup menu and a touchable highlight around the target component that support left-click and right-click actions. These actions can either be fns to be invoked, `:menu` in case when we want the menu to appear, or `nil` in case of no-op.\r\n\r\n**Todo:** Menu positioning right now does not follow the mouse, and styling needs improvement.","created_at":"2018-11-09T11:50:31Z","updated_at":"2018-11-09T20:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"672cd3ab2dc7a0c4c7f1f6153708cab4170804c8","assignee":{"login":"siphiuel","id":1019573,"node_id":"MDQ6VXNlcjEwMTk1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1019573?v=4","gravatar_id":"","url":"https://api.github.com/users/siphiuel","html_url":"https://github.com/siphiuel","followers_url":"https://api.github.com/users/siphiuel/followers","following_url":"https://api.github.com/users/siphiuel/following{/other_user}","gists_url":"https://api.github.com/users/siphiuel/gists{/gist_id}","starred_url":"https://api.github.com/users/siphiuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siphiuel/subscriptions","organizations_url":"https://api.github.com/users/siphiuel/orgs","repos_url":"https://api.github.com/users/siphiuel/repos","events_url":"https://api.github.com/users/siphiuel/events{/privacy}","received_events_url":"https://api.github.com/users/siphiuel/received_events","type":"User","site_admin":false},"assignees":[{"login":"siphiuel","id":1019573,"node_id":"MDQ6VXNlcjEwMTk1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1019573?v=4","gravatar_id":"","url":"https://api.github.com/users/siphiuel","html_url":"https://github.com/siphiuel","followers_url":"https://api.github.com/users/siphiuel/followers","following_url":"https://api.github.com/users/siphiuel/following{/other_user}","gists_url":"https://api.github.com/users/siphiuel/gists{/gist_id}","starred_url":"https://api.github.com/users/siphiuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siphiuel/subscriptions","organizations_url":"https://api.github.com/users/siphiuel/orgs","repos_url":"https://api.github.com/users/siphiuel/repos","events_url":"https://api.github.com/users/siphiuel/events{/privacy}","received_events_url":"https://api.github.com/users/siphiuel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yenda","id":1181225,"node_id":"MDQ6VXNlcjExODEyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1181225?v=4","gravatar_id":"","url":"https://api.github.com/users/yenda","html_url":"https://github.com/yenda","followers_url":"https://api.github.com/users/yenda/followers","following_url":"https://api.github.com/users/yenda/following{/other_user}","gists_url":"https://api.github.com/users/yenda/gists{/gist_id}","starred_url":"https://api.github.com/users/yenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenda/subscriptions","organizations_url":"https://api.github.com/users/yenda/orgs","repos_url":"https://api.github.com/users/yenda/repos","events_url":"https://api.github.com/users/yenda/events{/privacy}","received_events_url":"https://api.github.com/users/yenda/received_events","type":"User","site_admin":false},{"login":"MaxRis","id":1928902,"node_id":"MDQ6VXNlcjE5Mjg5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1928902?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxRis","html_url":"https://github.com/MaxRis","followers_url":"https://api.github.com/users/MaxRis/followers","following_url":"https://api.github.com/users/MaxRis/following{/other_user}","gists_url":"https://api.github.com/users/MaxRis/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxRis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxRis/subscriptions","organizations_url":"https://api.github.com/users/MaxRis/orgs","repos_url":"https://api.github.com/users/MaxRis/repos","events_url":"https://api.github.com/users/MaxRis/events{/privacy}","received_events_url":"https://api.github.com/users/MaxRis/received_events","type":"User","site_admin":false},{"login":"vkjr","id":5786310,"node_id":"MDQ6VXNlcjU3ODYzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5786310?v=4","gravatar_id":"","url":"https://api.github.com/users/vkjr","html_url":"https://github.com/vkjr","followers_url":"https://api.github.com/users/vkjr/followers","following_url":"https://api.github.com/users/vkjr/following{/other_user}","gists_url":"https://api.github.com/users/vkjr/gists{/gist_id}","starred_url":"https://api.github.com/users/vkjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkjr/subscriptions","organizations_url":"https://api.github.com/users/vkjr/orgs","repos_url":"https://api.github.com/users/vkjr/repos","events_url":"https://api.github.com/users/vkjr/events{/privacy}","received_events_url":"https://api.github.com/users/vkjr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":782926578,"node_id":"MDU6TGFiZWw3ODI5MjY1Nzg=","url":"https://api.github.com/repos/status-im/status-react/labels/desktop","name":"desktop","color":"fcb099","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/6671/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/6671/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/6671/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/6420acf5d14fc5cefe252fd2deee54933e2e3ad7","head":{"label":"status-im:feature/add-popup-menu","ref":"feature/add-popup-menu","sha":"6420acf5d14fc5cefe252fd2deee54933e2e3ad7","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-11-09T16:56:15Z","pushed_at":"2018-11-09T19:59:24Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":75003,"stargazers_count":2476,"watchers_count":2476,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":602,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":602,"open_issues":584,"watchers":2476,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"5e2c192524e8b2cf2f9fe74df96a90efbe873fd3","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","private":false,"owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-11-09T16:56:15Z","pushed_at":"2018-11-09T19:59:24Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":75003,"stargazers_count":2476,"watchers_count":2476,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":602,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":602,"open_issues":584,"watchers":2476,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6671"},"html":{"href":"https://github.com/status-im/status-react/pull/6671"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/6671"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/6671/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6671/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/6671/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/6420acf5d14fc5cefe252fd2deee54933e2e3ad7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rcullito"}}