{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/212907662","pull_request_review_id":149630156,"id":212907662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjkwNzY2Mg==","diff_hunk":"@@ -292,7 +293,8 @@ func floatStrToIntStr(validFloat string) (string, error) {\n \t\textraZeroCount := intCnt - len(digits)\n \t\tif extraZeroCount > 20 {\n \t\t\t// Return overflow to avoid allocating too much memory.","path":"types/convert.go","position":29,"original_position":29,"commit_id":"4995e151463bc71f874c03ef2d54c44b6ed7b340","original_commit_id":"4995e151463bc71f874c03ef2d54c44b6ed7b340","user":{"login":"jackysp","id":4352397,"node_id":"MDQ6VXNlcjQzNTIzOTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4352397?v=4","gravatar_id":"","url":"https://api.github.com/users/jackysp","html_url":"https://github.com/jackysp","followers_url":"https://api.github.com/users/jackysp/followers","following_url":"https://api.github.com/users/jackysp/following{/other_user}","gists_url":"https://api.github.com/users/jackysp/gists{/gist_id}","starred_url":"https://api.github.com/users/jackysp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackysp/subscriptions","organizations_url":"https://api.github.com/users/jackysp/orgs","repos_url":"https://api.github.com/users/jackysp/repos","events_url":"https://api.github.com/users/jackysp/events{/privacy}","received_events_url":"https://api.github.com/users/jackysp/received_events","type":"User","site_admin":false},"body":"Should we update this comment?","created_at":"2018-08-27T08:50:08Z","updated_at":"2018-08-27T08:50:08Z","html_url":"https://github.com/pingcap/tidb/pull/7483#discussion_r212907662","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/7483","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/212907662"},"html":{"href":"https://github.com/pingcap/tidb/pull/7483#discussion_r212907662"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7483"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7483","id":210682159,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjgyMTU5","html_url":"https://github.com/pingcap/tidb/pull/7483","diff_url":"https://github.com/pingcap/tidb/pull/7483.diff","patch_url":"https://github.com/pingcap/tidb/pull/7483.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7483","number":7483,"state":"open","locked":false,"title":"fix compatibility bug with convert string to int return wrong result","user":{"login":"CodeRushing","id":3175223,"node_id":"MDQ6VXNlcjMxNzUyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3175223?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeRushing","html_url":"https://github.com/CodeRushing","followers_url":"https://api.github.com/users/CodeRushing/followers","following_url":"https://api.github.com/users/CodeRushing/following{/other_user}","gists_url":"https://api.github.com/users/CodeRushing/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeRushing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeRushing/subscriptions","organizations_url":"https://api.github.com/users/CodeRushing/orgs","repos_url":"https://api.github.com/users/CodeRushing/repos","events_url":"https://api.github.com/users/CodeRushing/events{/privacy}","received_events_url":"https://api.github.com/users/CodeRushing/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nfix the [issue#7398](https://github.com/pingcap/tidb/issues/7398)\r\n\r\n### What is changed and how it works?\r\n\r\nIn types.floatStrToIntStr function, when extraZeroCount or intCnt overflows, just AppendWarning and return nil error\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n ","created_at":"2018-08-24T09:08:58Z","updated_at":"2018-08-27T08:50:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d9eb5e719a5d4a67bd962450110abefa6c4acb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7483/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7483/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7483/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/4995e151463bc71f874c03ef2d54c44b6ed7b340","head":{"label":"CodeRushing:my","ref":"my","sha":"4995e151463bc71f874c03ef2d54c44b6ed7b340","user":{"login":"CodeRushing","id":3175223,"node_id":"MDQ6VXNlcjMxNzUyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3175223?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeRushing","html_url":"https://github.com/CodeRushing","followers_url":"https://api.github.com/users/CodeRushing/followers","following_url":"https://api.github.com/users/CodeRushing/following{/other_user}","gists_url":"https://api.github.com/users/CodeRushing/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeRushing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeRushing/subscriptions","organizations_url":"https://api.github.com/users/CodeRushing/orgs","repos_url":"https://api.github.com/users/CodeRushing/repos","events_url":"https://api.github.com/users/CodeRushing/events{/privacy}","received_events_url":"https://api.github.com/users/CodeRushing/received_events","type":"User","site_admin":false},"repo":{"id":97787203,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc4NzIwMw==","name":"tidb","full_name":"CodeRushing/tidb","owner":{"login":"CodeRushing","id":3175223,"node_id":"MDQ6VXNlcjMxNzUyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3175223?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeRushing","html_url":"https://github.com/CodeRushing","followers_url":"https://api.github.com/users/CodeRushing/followers","following_url":"https://api.github.com/users/CodeRushing/following{/other_user}","gists_url":"https://api.github.com/users/CodeRushing/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeRushing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeRushing/subscriptions","organizations_url":"https://api.github.com/users/CodeRushing/orgs","repos_url":"https://api.github.com/users/CodeRushing/repos","events_url":"https://api.github.com/users/CodeRushing/events{/privacy}","received_events_url":"https://api.github.com/users/CodeRushing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CodeRushing/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/CodeRushing/tidb","forks_url":"https://api.github.com/repos/CodeRushing/tidb/forks","keys_url":"https://api.github.com/repos/CodeRushing/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeRushing/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeRushing/tidb/teams","hooks_url":"https://api.github.com/repos/CodeRushing/tidb/hooks","issue_events_url":"https://api.github.com/repos/CodeRushing/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/CodeRushing/tidb/events","assignees_url":"https://api.github.com/repos/CodeRushing/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/CodeRushing/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/CodeRushing/tidb/tags","blobs_url":"https://api.github.com/repos/CodeRushing/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeRushing/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeRushing/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeRushing/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeRushing/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeRushing/tidb/languages","stargazers_url":"https://api.github.com/repos/CodeRushing/tidb/stargazers","contributors_url":"https://api.github.com/repos/CodeRushing/tidb/contributors","subscribers_url":"https://api.github.com/repos/CodeRushing/tidb/subscribers","subscription_url":"https://api.github.com/repos/CodeRushing/tidb/subscription","commits_url":"https://api.github.com/repos/CodeRushing/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeRushing/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeRushing/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeRushing/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeRushing/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/CodeRushing/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeRushing/tidb/merges","archive_url":"https://api.github.com/repos/CodeRushing/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeRushing/tidb/downloads","issues_url":"https://api.github.com/repos/CodeRushing/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/CodeRushing/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeRushing/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeRushing/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeRushing/tidb/labels{/name}","releases_url":"https://api.github.com/repos/CodeRushing/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/CodeRushing/tidb/deployments","created_at":"2017-07-20T03:36:33Z","updated_at":"2018-08-24T07:16:06Z","pushed_at":"2018-08-27T05:45:37Z","git_url":"git://github.com/CodeRushing/tidb.git","ssh_url":"git@github.com:CodeRushing/tidb.git","clone_url":"https://github.com/CodeRushing/tidb.git","svn_url":"https://github.com/CodeRushing/tidb","homepage":"https://pingcap.com","size":56115,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"d9f7ffe539fef04b516c9326bbff0d850191eba2","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-08-27T08:39:51Z","pushed_at":"2018-08-27T08:39:44Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":80524,"stargazers_count":14569,"watchers_count":14569,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2031,"mirror_url":null,"archived":false,"open_issues_count":507,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2031,"open_issues":507,"watchers":14569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7483"},"html":{"href":"https://github.com/pingcap/tidb/pull/7483"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7483"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7483/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7483/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7483/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/4995e151463bc71f874c03ef2d54c44b6ed7b340"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackysp"}}