{"action":"created","issue":{"url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960","repository_url":"https://api.github.com/repos/Samsung/TizenRT","labels_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960/labels{/name}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960/comments","events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960/events","html_url":"https://github.com/Samsung/TizenRT/pull/1960","id":343714999,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjgyMDEx","number":1960,"title":"Add stream buffer and listener for DataSource","user":{"login":"zhouxinhe","id":38490562,"node_id":"MDQ6VXNlcjM4NDkwNTYy","avatar_url":"https://avatars2.githubusercontent.com/u/38490562?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouxinhe","html_url":"https://github.com/zhouxinhe","followers_url":"https://api.github.com/users/zhouxinhe/followers","following_url":"https://api.github.com/users/zhouxinhe/following{/other_user}","gists_url":"https://api.github.com/users/zhouxinhe/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouxinhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouxinhe/subscriptions","organizations_url":"https://api.github.com/users/zhouxinhe/orgs","repos_url":"https://api.github.com/users/zhouxinhe/repos","events_url":"https://api.github.com/users/zhouxinhe/events{/privacy}","received_events_url":"https://api.github.com/users/zhouxinhe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2018-07-23T16:57:11Z","updated_at":"2018-08-03T07:11:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1960","html_url":"https://github.com/Samsung/TizenRT/pull/1960","diff_url":"https://github.com/Samsung/TizenRT/pull/1960.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/1960.patch"},"body":"@Taejun-Kwon \r\n- Add a API `rb_reset()` to reset ring-buffer.\r\n- Add StreamBuffer and StreamBufferReader/Writer for stream buffer reading/writing.\r\n- Modify Input/OutputDataSource to hold a stream buffer for each DataSource.\r\n- Add API `getId()` for both mediaplayer & mediarecorder to get ID. (May be changed in future.)\r\n- Add a non-virtual method in MediaRecorderObserverInterface for BufferOutputDataSource.\r\n- More listeners for mediaplayer/mediarecorder will be add in future.\r\n- Update media UTC: utc_media_MediaRecorder_pause_p. @junmin-kim "},"comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments/410165957","html_url":"https://github.com/Samsung/TizenRT/pull/1960#issuecomment-410165957","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1960","id":410165957,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDE2NTk1Nw==","user":{"login":"junmin-kim","id":25811851,"node_id":"MDQ6VXNlcjI1ODExODUx","avatar_url":"https://avatars0.githubusercontent.com/u/25811851?v=4","gravatar_id":"","url":"https://api.github.com/users/junmin-kim","html_url":"https://github.com/junmin-kim","followers_url":"https://api.github.com/users/junmin-kim/followers","following_url":"https://api.github.com/users/junmin-kim/following{/other_user}","gists_url":"https://api.github.com/users/junmin-kim/gists{/gist_id}","starred_url":"https://api.github.com/users/junmin-kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmin-kim/subscriptions","organizations_url":"https://api.github.com/users/junmin-kim/orgs","repos_url":"https://api.github.com/users/junmin-kim/repos","events_url":"https://api.github.com/users/junmin-kim/events{/privacy}","received_events_url":"https://api.github.com/users/junmin-kim/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T07:11:13Z","updated_at":"2018-08-03T07:11:13Z","author_association":"CONTRIBUTOR","body":"I think StreamBuffer is strongly coupled.\r\nStreamBuffer don't have to know StreamBufferReader and StreamBufferWriter because reader, writer have reference of it.\r\nThere are some available options.\r\n- InputDataSource creates StreamBuffer, reader, writer and handles them.\r\n- Make a manager of stream buffer. It is responsible for creating and handling.\r\n- StreamBuffer controls reader and writer. InputDataSource has only reference of StreamBuffer.\r\n- Any solution that weaken coupling.\r\n\r\nWould you consider this view?"}}
{"actor":{"display_login":"junmin-kim"}}