{"action":"closed","issue":{"url":"https://api.github.com/repos/drud/ddev/issues/809","repository_url":"https://api.github.com/repos/drud/ddev","labels_url":"https://api.github.com/repos/drud/ddev/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/drud/ddev/issues/809/comments","events_url":"https://api.github.com/repos/drud/ddev/issues/809/events","html_url":"https://github.com/drud/ddev/issues/809","id":317386014,"number":809,"title":"Patches defined by Composer don't always apply in container","user":{"login":"ultimike","id":1727889,"avatar_url":"https://avatars2.githubusercontent.com/u/1727889?v=4","gravatar_id":"","url":"https://api.github.com/users/ultimike","html_url":"https://github.com/ultimike","followers_url":"https://api.github.com/users/ultimike/followers","following_url":"https://api.github.com/users/ultimike/following{/other_user}","gists_url":"https://api.github.com/users/ultimike/gists{/gist_id}","starred_url":"https://api.github.com/users/ultimike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultimike/subscriptions","organizations_url":"https://api.github.com/users/ultimike/orgs","repos_url":"https://api.github.com/users/ultimike/repos","events_url":"https://api.github.com/users/ultimike/events{/privacy}","received_events_url":"https://api.github.com/users/ultimike/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-24T20:38:21Z","updated_at":"2018-04-24T20:52:28Z","closed_at":"2018-04-24T20:52:28Z","author_association":"NONE","body":"## What happened (or feature request):\r\nI have a composer.json file with a patch for a Drupal contributed module defined in the “extras” section.\r\n\r\nWhen I run `composer update drupal/project_name --with-dependencies` using my host OS Composer, all is fine.\r\n\r\nWhen I run the same command after `ddev ssh`ing into the container, the patch does not apply.\r\nThe error message is not super-helpful, `Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/...`\r\n\r\nIn chatting on the #ddev channel, @cweagans suggested that it could be an issue with the version of Git or Patch in the container. In my case, Git is 2.15.0 on host (Mac) OS, 2.1.4 in container and Patch is 2.5.8 on host (Mac) OS, not present in container. @cweagans said that \"the plugin uses `git` if it's present, for sure. Having `patch` might be a good fallback, but if it doesn't apply with `git`, it usually won't apply with `patch` either.\"\r\n\r\n## What you expected to happen:\r\nThe patch to apply.\r\n\r\n## How to reproduce this:\r\nI have a Drupal 8 site based on https://github.com/drupal-composer/drupal-project/, with the alpha4 version of Views Data Export module. I'm trying to apply this patch: https://www.drupal.org/files/issues/2018-04-20/views_data_export_format_path-2957085-19.patch \r\n\r\n## Version: Please include the output of `ddev version`, `docker version` and the project's .ddev/config.yaml.\r\n0.17.0\r\n\r\n## Anything else do we need to know:\r\n@rfay had me install Patch in the container with `docker exec -it -u 0 ddev-<project>-web bash` and `apt-get update -y && apt-get install patch` to see if that resolved the issue. Which it did! Woot. @rfay indicated he'll have a pull request to fix this moving forward. (thank you!)\r\n\r\n## Related source links or issues:\r\n\r\n\r\n## Please use a complexity rating of 1-5 (5 is high) for a feature request. (High complexity implies more PR planning)\r\n"}}
{"actor":{"display_login":"rfay"}}