{"push_id":2360216189,"size":107,"distinct_size":2,"ref":"refs/heads/180104-FixStatisticsNotices","head":"1e19d1c5453836b5e8ca85aaa7c7040dc8c58e66","before":"dd0f727b07cd83bc183bb46a44dd0e6cec562f73","commits":[{"sha":"2f9826e33d680c52090bcc71b61338dd8de17acc","author":{"name":"ridz1208","email":"af22ff845c23131a1d6c09937f66e4d346b35e36@users.noreply.github.com"},"message":"[Candidate] Functions moved to candidate class (#3023)\n\nThis moves 2 static functions from the candidate_parameters class to the candidate class since they're used across different modules.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/2f9826e33d680c52090bcc71b61338dd8de17acc"},{"sha":"d9c89212b4147e4fc571eadf3602660e95d5274e","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Merge remote-tracking branch 'aces/minor' into major","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/d9c89212b4147e4fc571eadf3602660e95d5274e"},{"sha":"193b85b17a21a32b3d113531f1141aa003e734d8","author":{"name":"Shen","email":"7e5495d683f9b28f7a2ffe51f02d335fbb36e0b7@users.noreply.github.com"},"message":"[candidate_list] fix merge conflict #3230\n\nFix merge conflict which was not correctly resolved in branch merge.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/193b85b17a21a32b3d113531f1141aa003e734d8"},{"sha":"32c23449c3cb1458a8c7786a513731ee3cbcf140","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Remove unused variable declarations and fix problems identified by PHPMD (#3175)\n\nThis adds the unused code ruleset of PHPMD to Travis, and fixes any errors\r\nthat were identified.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/32c23449c3cb1458a8c7786a513731ee3cbcf140"},{"sha":"ee38dfef68b99f5457f656a858482a074669358a","author":{"name":"Shen","email":"7e5495d683f9b28f7a2ffe51f02d335fbb36e0b7@users.noreply.github.com"},"message":"[Mri_Violations]  Convert module to modern module  (#3217)\n\nCreated namespace, and and added module class for Mri_Violations module.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/ee38dfef68b99f5457f656a858482a074669358a"},{"sha":"d99701d599c1d6a149f756c348a61714d1729c53","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Merge remote-tracking branch 'aces/minor' into HEAD","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/d99701d599c1d6a149f756c348a61714d1729c53"},{"sha":"a20e2c6d61f7cc4d5cb7a6d5568b60d2108a778d","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Remove support for ancient module format, deprecate old one (#3174)\n\nRemove support for modules of the format php/libraries/NDB_Menu_Filter_$modulename\r\nwhere all the modules were jumbled together in php/libraries.\r\n\r\nDeprecate support for modules/$modulename modules that are missing a Module\r\nclass.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/a20e2c6d61f7cc4d5cb7a6d5568b60d2108a778d"},{"sha":"dba3ea60d4194b9bf916c2c51eb61336ddc27282","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Fix the major branch (#3276)\n\nThis fixes the build on the major branch after an incorrectly resolved conflict.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/dba3ea60d4194b9bf916c2c51eb61336ddc27282"},{"sha":"988e2b6d7783df99b96eadbfe7e481466221503f","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Merge remote-tracking branch 'aces/minor' into HEAD","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/988e2b6d7783df99b96eadbfe7e481466221503f"},{"sha":"7e7556c2044713676739baa67c41eeb1fde41cf3","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"[Core] Remove _setupPage function (#3280)\n\nThe modularization of LORIS modules had an unfortunate side-effect of re-ordering some of the setup logic, since most modules overrode the _setupPage() function to ensure that LorisForm was instantiated before setting template variables (which may get overridden after _setupPage is called if they did it another way). This also had the annoying side-effect or requiring all 5 parameters just to pass to the parent call.\r\n\r\nSince the _setupPage function in the base NDB_Page class was used as a pseudo-constructor, this moves it to a real constructor. The result is that setup() can be called directly and _setupPage can be removed.\r\n\r\nThis makes it possible to ensure that hasAccess is checked before the setup() function call (some of the hasAccess functions require the identifier attribute which was previously set in the base setupPage, which is now in the constructor.) and prevent the possibility of leaking any data on the \"You do not have access page\" if setupPage did something which generated a warning, since it's now never called at all if the user doesn't have access.\r\n\r\nIt also removes the ambiguity of the difference between setup and setupPage.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/7e7556c2044713676739baa67c41eeb1fde41cf3"},{"sha":"5cdf4b1b75ad941803fb7dba833fbfbcdfe14ad7","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Publicly accessible module support (#2608)\n\nThis adds the ability to create modules which are accessible to the public, and converts the login/password-reset/request-account/etc features into a \"login\" module, both as an example and because there needs to be a default module to use when not logged in.\r\n\r\nModules must have a Module class in the module namespace, and can be converted to be publicly accessible by overriding the \"isPublicModule\" function to return true. This causes hasAccess to be bypassed, but modules are otherwise written as before.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/5cdf4b1b75ad941803fb7dba833fbfbcdfe14ad7"},{"sha":"3f3b34f96c9067afe0c71b6a673d0aa224668489","author":{"name":"Xavier Lecours","email":"ec8315cc18c893d8abc672b81378b24f0b682c01@mcgill.ca"},"message":"[Login] Password reset fix #3298\n\nFix a namespacing issue with the Email class in login module.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/3f3b34f96c9067afe0c71b6a673d0aa224668489"},{"sha":"0b01b8d679940565cd37c1ce266c95ec9e4acd85","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Merge remote-tracking branch 'aces/minor' into HEAD","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/0b01b8d679940565cd37c1ce266c95ec9e4acd85"},{"sha":"f62f35bdca342d1515942fb2e97b54321e3dcc3f","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Merge remote-tracking branch 'aces/minor' into HEAD","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/f62f35bdca342d1515942fb2e97b54321e3dcc3f"},{"sha":"b4b77a57a9486610b589ebdd9d17f0dff0b68ccd","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Remove unused variable in main.php (#3303)\n\n* Remove unused variable in main.php\r\n\r\n* Fix PHPMD error","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/b4b77a57a9486610b589ebdd9d17f0dff0b68ccd"},{"sha":"9a2e6a9cabd1d58a07870fda5efd1c7c2307c7f0","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"Fix router errors in Travis (#3321)\n\nFix a bug where Travis is not able to find the htdocs/router.php file,\r\nbecause it's looking for htdocs/htdocs/router.php. I'm not sure how or\r\nwhy this started breaking consistently across all versions of PHP being\r\nrun by Travis, but it seems to be the case. This takes out the htdocs/\r\nportion of the path used as a router since it seems to be duplicated by\r\nthe -t (docroot) of the PHP built in web server.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/9a2e6a9cabd1d58a07870fda5efd1c7c2307c7f0"},{"sha":"67d784b0fa3dd1736dc6440dcc6ea5842ab40466","author":{"name":"ridz1208","email":"af22ff845c23131a1d6c09937f66e4d346b35e36@users.noreply.github.com"},"message":"[Dashboard] fixing count of \"pending\" users (#3332)\n\nThis Fixes the query displaying the number of pending requests. The LEFT JOIN on user_psc_rel was creating user duplication.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/67d784b0fa3dd1736dc6440dcc6ea5842ab40466"},{"sha":"8b01fa34ce6e349f92af79972da7e1965acc1ce7","author":{"name":"cmadjar","email":"d865670b84b2b36ae821a7e61f568c2bc8d6d03d@gmail.com"},"message":"[create_timepoint] Clarification of the create_timepoint test plan  (#3312)\n\nThe site drop down for the visit creation should appear only when users belong to more than one site.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/8b01fa34ce6e349f92af79972da7e1965acc1ce7"},{"sha":"61e1e6c0b3039c31ec5b178fdea14b6c19d5abd8","author":{"name":"Dave MacFarlane","email":"75e7d63eadf164e83bc0b429ebc3248e471e5248@gmail.com"},"message":"[Login] Replace incorrect placeholder on login page (#3336)\n\nThe login page was prompting for \"Email\" when it was, in fact, expecting a username.\r\n\r\nThis updates the prompt to be correct.\r\n\r\nFixes Redmine #13586","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/61e1e6c0b3039c31ec5b178fdea14b6c19d5abd8"},{"sha":"6a31341f81ea835a14da555a6c5e43de8b6a0f01","author":{"name":"Xavier Lecours","email":"ec8315cc18c893d8abc672b81378b24f0b682c01@mcgill.ca"},"message":"[SQL Schema] psc table hard limit increase (#3074)\n\nThis increases the number of possible site to 4294967295 from 100. It changes the CenterID column definition in the `psc` table and all foreign key constraints that reference it.","distinct":false,"url":"https://api.github.com/repos/ZainVirani/Loris/commits/6a31341f81ea835a14da555a6c5e43de8b6a0f01"}]}
{"actor":{"display_login":"ZainVirani"}}