{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/aurelia/issues/271","repository_url":"https://api.github.com/repos/aurelia/aurelia","labels_url":"https://api.github.com/repos/aurelia/aurelia/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/aurelia/issues/271/comments","events_url":"https://api.github.com/repos/aurelia/aurelia/issues/271/events","html_url":"https://github.com/aurelia/aurelia/pull/271","id":379742981,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTA4Njkw","number":271,"title":"test(runtime): fix error in arePureLiterals during tests (for now)","user":{"login":"BBosman","id":5115488,"node_id":"MDQ6VXNlcjUxMTU0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5115488?v=4","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-12T11:52:29Z","updated_at":"2018-11-12T21:18:17Z","closed_at":"2018-11-12T21:18:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aurelia/aurelia/pulls/271","html_url":"https://github.com/aurelia/aurelia/pull/271","diff_url":"https://github.com/aurelia/aurelia/pull/271.diff","patch_url":"https://github.com/aurelia/aurelia/pull/271.patch"},"body":"# Pull Request\r\n\r\n## 📖 Description\r\n\r\nCurrently on `master` the tests fail with the error:\r\n```\r\n\tTypeError: Cannot read property 'length' of undefined\r\n\t    at length (packages/runtime/test/webpack:/src/binding/ast.ts:96:21)\r\n\t    at Object.arePureLiterals [as isPureLiteral] (packages/runtime/test/webpack:/src/binding/ast.ts:111:24)\r\n\t    at Context.it (packages/runtime/test/webpack:/test/unit/binding/ast.spec.ts:2830:12)\r\n```\r\n\r\nThis PR partially reverts the change discussed in https://github.com/aurelia/aurelia/pull/262#discussion_r231972721 to fix this problem.\r\n\r\nI also don't understand why this didn't surface when running `npm run test` while working on #262 😞.\r\n\r\n### 🎫 Issues\r\n\r\nRelated to #262.\r\n\r\n## 👩‍💻 Reviewer Notes\r\n\r\nAdded back the (in theory unneeded) type check for `undefined`. This gets `master` back in a working state and we can go from there.\r\n\r\n## 📑 Test Plan\r\n\r\nRan:\r\n- `npm run build` without errors.\r\n- `npm run test` without test failures.\r\n\r\n## ⏭ Next Steps\r\n\r\nFigure out why the type check is (un)needed."},"comment":{"url":"https://api.github.com/repos/aurelia/aurelia/issues/comments/438031913","html_url":"https://github.com/aurelia/aurelia/pull/271#issuecomment-438031913","issue_url":"https://api.github.com/repos/aurelia/aurelia/issues/271","id":438031913,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAzMTkxMw==","user":{"login":"BBosman","id":5115488,"node_id":"MDQ6VXNlcjUxMTU0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5115488?v=4","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T21:18:17Z","updated_at":"2018-11-12T21:18:17Z","author_association":"CONTRIBUTOR","body":"Fixed in #250."}}
{"actor":{"display_login":"BBosman"}}