{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/202517140","pull_request_review_id":137240296,"id":202517140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUxNzE0MA==","diff_hunk":"@@ -19,7 +19,18 @@ khint64_t PANDAS_INLINE asint64(double key) {\n   memcpy(&val, &key, sizeof(double));\n   return val;\n }\n-#define kh_float64_hash_func(key) (khint32_t)((asint64(key))>>33^(asint64(key))^(asint64(key))<<11)\n+\n+// correct for all inputs but not -0.0 and NaNs\n+#define kh_float64_hash_func_0_NAN(key) (khint32_t)((asint64(key))>>33^(asint64(key))^(asint64(key))<<11)","path":"pandas/_libs/src/klib/khash_python.h","position":7,"original_position":7,"commit_id":"94b7087f9f45d1fe18956a03056b2abf997798b7","original_commit_id":"94b7087f9f45d1fe18956a03056b2abf997798b7","user":{"login":"jreback","id":953992,"node_id":"MDQ6VXNlcjk1Mzk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"can you add a blank between cases","created_at":"2018-07-14T14:58:19Z","updated_at":"2018-07-14T14:58:19Z","html_url":"https://github.com/pandas-dev/pandas/pull/21904#discussion_r202517140","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/202517140"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21904#discussion_r202517140"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904","id":201411281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDExMjgx","html_url":"https://github.com/pandas-dev/pandas/pull/21904","diff_url":"https://github.com/pandas-dev/pandas/pull/21904.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/21904.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21904","number":21904,"state":"open","locked":false,"title":"BUG: issues with hash-function for Float64HashTable (GH21866)","user":{"login":"realead","id":17513912,"node_id":"MDQ6VXNlcjE3NTEzOTEy","avatar_url":"https://avatars2.githubusercontent.com/u/17513912?v=4","gravatar_id":"","url":"https://api.github.com/users/realead","html_url":"https://github.com/realead","followers_url":"https://api.github.com/users/realead/followers","following_url":"https://api.github.com/users/realead/following{/other_user}","gists_url":"https://api.github.com/users/realead/gists{/gist_id}","starred_url":"https://api.github.com/users/realead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realead/subscriptions","organizations_url":"https://api.github.com/users/realead/orgs","repos_url":"https://api.github.com/users/realead/repos","events_url":"https://api.github.com/users/realead/events{/privacy}","received_events_url":"https://api.github.com/users/realead/received_events","type":"User","site_admin":false},"body":"The following issues\r\n\r\n   1)  hash(0.0) != hash(-0.0)\r\n   2)  hash(x) != hash(y) for different x,y which are nans\r\n\r\nare solved by setting:\r\n\r\n   1) hash(-0.0):=hash(0.0)\r\n   2) hash(x):=hash(np.nan) for every x which is nan\r\n\r\n- [x] closes #21866\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2018-07-13T22:09:40Z","updated_at":"2018-07-14T14:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48ba27d9de577f01adb64669a0694650591a4715","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":57296398,"node_id":"MDU6TGFiZWw1NzI5NjM5OA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Algos","name":"Algos","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/21904/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/94b7087f9f45d1fe18956a03056b2abf997798b7","head":{"label":"realead:hash_for_float64_GH21866","ref":"hash_for_float64_GH21866","sha":"94b7087f9f45d1fe18956a03056b2abf997798b7","user":{"login":"realead","id":17513912,"node_id":"MDQ6VXNlcjE3NTEzOTEy","avatar_url":"https://avatars2.githubusercontent.com/u/17513912?v=4","gravatar_id":"","url":"https://api.github.com/users/realead","html_url":"https://github.com/realead","followers_url":"https://api.github.com/users/realead/followers","following_url":"https://api.github.com/users/realead/following{/other_user}","gists_url":"https://api.github.com/users/realead/gists{/gist_id}","starred_url":"https://api.github.com/users/realead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realead/subscriptions","organizations_url":"https://api.github.com/users/realead/orgs","repos_url":"https://api.github.com/users/realead/repos","events_url":"https://api.github.com/users/realead/events{/privacy}","received_events_url":"https://api.github.com/users/realead/received_events","type":"User","site_admin":false},"repo":{"id":140796019,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3OTYwMTk=","name":"pandas","full_name":"realead/pandas","owner":{"login":"realead","id":17513912,"node_id":"MDQ6VXNlcjE3NTEzOTEy","avatar_url":"https://avatars2.githubusercontent.com/u/17513912?v=4","gravatar_id":"","url":"https://api.github.com/users/realead","html_url":"https://github.com/realead","followers_url":"https://api.github.com/users/realead/followers","following_url":"https://api.github.com/users/realead/following{/other_user}","gists_url":"https://api.github.com/users/realead/gists{/gist_id}","starred_url":"https://api.github.com/users/realead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realead/subscriptions","organizations_url":"https://api.github.com/users/realead/orgs","repos_url":"https://api.github.com/users/realead/repos","events_url":"https://api.github.com/users/realead/events{/privacy}","received_events_url":"https://api.github.com/users/realead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/realead/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/realead/pandas","forks_url":"https://api.github.com/repos/realead/pandas/forks","keys_url":"https://api.github.com/repos/realead/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realead/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realead/pandas/teams","hooks_url":"https://api.github.com/repos/realead/pandas/hooks","issue_events_url":"https://api.github.com/repos/realead/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/realead/pandas/events","assignees_url":"https://api.github.com/repos/realead/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/realead/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/realead/pandas/tags","blobs_url":"https://api.github.com/repos/realead/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realead/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realead/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/realead/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realead/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/realead/pandas/languages","stargazers_url":"https://api.github.com/repos/realead/pandas/stargazers","contributors_url":"https://api.github.com/repos/realead/pandas/contributors","subscribers_url":"https://api.github.com/repos/realead/pandas/subscribers","subscription_url":"https://api.github.com/repos/realead/pandas/subscription","commits_url":"https://api.github.com/repos/realead/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/realead/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/realead/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/realead/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/realead/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/realead/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realead/pandas/merges","archive_url":"https://api.github.com/repos/realead/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realead/pandas/downloads","issues_url":"https://api.github.com/repos/realead/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/realead/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/realead/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/realead/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realead/pandas/labels{/name}","releases_url":"https://api.github.com/repos/realead/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/realead/pandas/deployments","created_at":"2018-07-13T04:15:32Z","updated_at":"2018-07-13T04:15:39Z","pushed_at":"2018-07-14T13:41:33Z","git_url":"git://github.com/realead/pandas.git","ssh_url":"git@github.com:realead/pandas.git","clone_url":"https://github.com/realead/pandas.git","svn_url":"https://github.com/realead/pandas","homepage":"http://pandas.pydata.org","size":126728,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"610a19a333c40ff67b8feb5f96c29cfae8495a3e","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-07-14T14:56:53Z","pushed_at":"2018-07-14T14:54:31Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":126895,"stargazers_count":15079,"watchers_count":15079,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6054,"mirror_url":null,"archived":false,"open_issues_count":2614,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6054,"open_issues":2614,"watchers":15079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/21904"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21904"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/21904/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/21904/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/94b7087f9f45d1fe18956a03056b2abf997798b7"}},"author_association":"NONE"}}
{"actor":{"display_login":"jreback"}}