{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/287","repository_url":"https://api.github.com/repos/Microsoft/mssql-docker","labels_url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/287/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/287/comments","events_url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/287/events","html_url":"https://github.com/Microsoft/mssql-docker/issues/287","id":311428376,"node_id":"MDU6SXNzdWUzMTE0MjgzNzY=","number":287,"title":"Fatal errors due to being \"out of memory\"","user":{"login":"gitfool","id":750121,"node_id":"MDQ6VXNlcjc1MDEyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/750121?v=4","gravatar_id":"","url":"https://api.github.com/users/gitfool","html_url":"https://github.com/gitfool","followers_url":"https://api.github.com/users/gitfool/followers","following_url":"https://api.github.com/users/gitfool/following{/other_user}","gists_url":"https://api.github.com/users/gitfool/gists{/gist_id}","starred_url":"https://api.github.com/users/gitfool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitfool/subscriptions","organizations_url":"https://api.github.com/users/gitfool/orgs","repos_url":"https://api.github.com/users/gitfool/repos","events_url":"https://api.github.com/users/gitfool/events{/privacy}","received_events_url":"https://api.github.com/users/gitfool/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2018-04-04T23:46:09Z","updated_at":"2018-06-26T01:54:34Z","closed_at":null,"author_association":"NONE","body":"I recently experienced a crash using version 2017-CU5 with following in `crash.txt`:\r\n```\r\nThis program has encountered a fatal error and cannot continue running.\r\nThe following diagnostic information is available:\r\n\r\n       Reason: 0x00000008\r\n      Process: 6 - sqlservr\r\n       Thread: 92 (application thread 0x1148)\r\n  Instance Id: 9d91e341-a069-49e6-8b9c-01fa8805581d\r\n     Crash Id: 50e4e15d-c82e-411b-b0fd-4a3a56e91398\r\n  Build stamp: 63bf243a7ac4f3fba09b69a82cb9adccf96f59f1dcb431d679e103f1c850c076\r\n```\r\nIs there somewhere I can lookup the reason code?"},"comment":{"url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/comments/400151612","html_url":"https://github.com/Microsoft/mssql-docker/issues/287#issuecomment-400151612","issue_url":"https://api.github.com/repos/Microsoft/mssql-docker/issues/287","id":400151612,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDE1MTYxMg==","user":{"login":"twright-msft","id":14988070,"node_id":"MDQ6VXNlcjE0OTg4MDcw","avatar_url":"https://avatars2.githubusercontent.com/u/14988070?v=4","gravatar_id":"","url":"https://api.github.com/users/twright-msft","html_url":"https://github.com/twright-msft","followers_url":"https://api.github.com/users/twright-msft/followers","following_url":"https://api.github.com/users/twright-msft/following{/other_user}","gists_url":"https://api.github.com/users/twright-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/twright-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twright-msft/subscriptions","organizations_url":"https://api.github.com/users/twright-msft/orgs","repos_url":"https://api.github.com/users/twright-msft/repos","events_url":"https://api.github.com/users/twright-msft/events{/privacy}","received_events_url":"https://api.github.com/users/twright-msft/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T01:54:34Z","updated_at":"2018-06-26T01:54:34Z","author_association":"COLLABORATOR","body":"I reread the case notes tonight including the ones posted the same day as my comment (maybe those weren't there when I was reading them).  I can see that you disabled THP and set max server memory to 80% and that you reported that seems to be working for you.  It's certainly worth trying, but I don't think I would recommend that to everyone yet.  THP is enabled by default typically in Linux and our performance team recommends having it enabled.  \r\nhttps://docs.microsoft.com/en-us/sql/linux/sql-server-linux-performance-best-practices?view=sql-server-linux-2017\r\n\r\nIt may be that in systems with a relatively smaller amount of RAM and high demand on the memory, that disabling THP eliminates this problem.  \r\n\r\nI think the reason that setting max server memory to 80% seems to work is because you are basically just telling SQL Server to use 80% of 80% (MSSQL_MEMORY_LIMIT) of the system memory.  When you squeeze it down that far it's that less likely to have memory problems.  Whereas MSSQL_MEMORY_LIMIT is more of a target usage that allows for actual usage to vary above the limit, max system memory is more of a hard limit, but it also doesn't apply to _all_ types of memory allocation by SQL Server.\r\n\r\nSo, at least for now, until our engineers have had a chance to look at this further, it seems for now that disabling THP and setting max server memory may be good options for some situations and can be tried to eliminate this problem, but it shouldn't be a general best practice.\r\n"}}
{"actor":{"display_login":"twright-msft"}}