{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/134","repository_url":"https://api.github.com/repos/Shopify/statsd-instrument","labels_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/134/comments","events_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/134/events","html_url":"https://github.com/Shopify/statsd-instrument/pull/134","id":346226896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTQyODQy","number":134,"title":"Collect measure and distribution metrics even on return or exception","user":{"login":"Bringer128","id":1164344,"node_id":"MDQ6VXNlcjExNjQzNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1164344?v=4","gravatar_id":"","url":"https://api.github.com/users/Bringer128","html_url":"https://github.com/Bringer128","followers_url":"https://api.github.com/users/Bringer128/followers","following_url":"https://api.github.com/users/Bringer128/following{/other_user}","gists_url":"https://api.github.com/users/Bringer128/gists{/gist_id}","starred_url":"https://api.github.com/users/Bringer128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bringer128/subscriptions","organizations_url":"https://api.github.com/users/Bringer128/orgs","repos_url":"https://api.github.com/users/Bringer128/repos","events_url":"https://api.github.com/users/Bringer128/events{/privacy}","received_events_url":"https://api.github.com/users/Bringer128/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-31T14:58:47Z","updated_at":"2018-08-07T12:39:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/pulls/134","html_url":"https://github.com/Shopify/statsd-instrument/pull/134","diff_url":"https://github.com/Shopify/statsd-instrument/pull/134.diff","patch_url":"https://github.com/Shopify/statsd-instrument/pull/134.patch"},"body":"Duplicate of https://github.com/Shopify/statsd-instrument/pull/111 (except no conflicts) and fixes https://github.com/Shopify/statsd-instrument/issues/133\r\n\r\nThis is a fix for when doing a return inside a `StatsD.measure` or `StatsD.distribution` call, where the metrics would not be collected.\r\n\r\nNote that as discussed in https://github.com/Shopify/statsd-instrument/pull/111 if exceptions happen you will likely get a different distribution of performance. At the very least we should consider documenting this behaviour.\r\n\r\nKeen to get this merged as I lost a day to this problem (existing code using a return, and I added a block to measure performance)."},"comment":{"url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/comments/411041700","html_url":"https://github.com/Shopify/statsd-instrument/pull/134#issuecomment-411041700","issue_url":"https://api.github.com/repos/Shopify/statsd-instrument/issues/134","id":411041700,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTA0MTcwMA==","user":{"login":"pallan","id":27247,"node_id":"MDQ6VXNlcjI3MjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/27247?v=4","gravatar_id":"","url":"https://api.github.com/users/pallan","html_url":"https://github.com/pallan","followers_url":"https://api.github.com/users/pallan/followers","following_url":"https://api.github.com/users/pallan/following{/other_user}","gists_url":"https://api.github.com/users/pallan/gists{/gist_id}","starred_url":"https://api.github.com/users/pallan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallan/subscriptions","organizations_url":"https://api.github.com/users/pallan/orgs","repos_url":"https://api.github.com/users/pallan/repos","events_url":"https://api.github.com/users/pallan/events{/privacy}","received_events_url":"https://api.github.com/users/pallan/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T12:39:38Z","updated_at":"2018-08-07T12:39:38Z","author_association":"CONTRIBUTOR","body":"cc @tjoyal @wvanbergen "}}
{"actor":{"display_login":"pallan"}}