{"action":"created","issue":{"url":"https://api.github.com/repos/apache/pulsar/issues/2756","repository_url":"https://api.github.com/repos/apache/pulsar","labels_url":"https://api.github.com/repos/apache/pulsar/issues/2756/labels{/name}","comments_url":"https://api.github.com/repos/apache/pulsar/issues/2756/comments","events_url":"https://api.github.com/repos/apache/pulsar/issues/2756/events","html_url":"https://github.com/apache/pulsar/pull/2756","id":368448816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjI1Nzgz","number":2756,"title":"Do not create any producer if the output type of a function is void","user":{"login":"srkukarni","id":2530234,"node_id":"MDQ6VXNlcjI1MzAyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2530234?v=4","gravatar_id":"","url":"https://api.github.com/users/srkukarni","html_url":"https://github.com/srkukarni","followers_url":"https://api.github.com/users/srkukarni/followers","following_url":"https://api.github.com/users/srkukarni/following{/other_user}","gists_url":"https://api.github.com/users/srkukarni/gists{/gist_id}","starred_url":"https://api.github.com/users/srkukarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkukarni/subscriptions","organizations_url":"https://api.github.com/users/srkukarni/orgs","repos_url":"https://api.github.com/users/srkukarni/repos","events_url":"https://api.github.com/users/srkukarni/events{/privacy}","received_events_url":"https://api.github.com/users/srkukarni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-10T00:28:38Z","updated_at":"2018-10-10T00:49:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/pulsar/pulls/2756","html_url":"https://github.com/apache/pulsar/pull/2756","diff_url":"https://github.com/apache/pulsar/pull/2756.diff","patch_url":"https://github.com/apache/pulsar/pull/2756.patch"},"body":"### Motivation\r\n\r\nIf the function output type is void and an output topic is specified, currently we create a producer thats wasteful(since nothing is going to be produced anyways). This pr avoids the creation in that scenario\r\n\r\n### Modifications\r\n\r\nDescribe the modifications you've done.\r\n\r\n### Result\r\n\r\nAfter your change, what will change.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/pulsar/issues/comments/428400572","html_url":"https://github.com/apache/pulsar/pull/2756#issuecomment-428400572","issue_url":"https://api.github.com/repos/apache/pulsar/issues/2756","id":428400572,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODQwMDU3Mg==","user":{"login":"jerrypeng","id":3613359,"node_id":"MDQ6VXNlcjM2MTMzNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/3613359?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrypeng","html_url":"https://github.com/jerrypeng","followers_url":"https://api.github.com/users/jerrypeng/followers","following_url":"https://api.github.com/users/jerrypeng/following{/other_user}","gists_url":"https://api.github.com/users/jerrypeng/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrypeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrypeng/subscriptions","organizations_url":"https://api.github.com/users/jerrypeng/orgs","repos_url":"https://api.github.com/users/jerrypeng/repos","events_url":"https://api.github.com/users/jerrypeng/events{/privacy}","received_events_url":"https://api.github.com/users/jerrypeng/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T00:49:14Z","updated_at":"2018-10-10T00:49:14Z","author_association":"CONTRIBUTOR","body":"@srkukarni I think you also need to check if the function result is null, don't call write on the sink"}}
{"actor":{"display_login":"jerrypeng"}}