{"action":"created","comment":{"url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/comments/203682746","pull_request_review_id":138618412,"id":203682746,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY4Mjc0Ng==","diff_hunk":"@@ -7,8 +7,60 @@ mod velocity;\n mod velocity_system;\n mod mass;\n mod gravity_system;\n+mod physics_system;\n+mod collider;\n+mod rigid_body;\n \n pub use self::velocity::Velocity;\n pub use self::velocity_system::VelocitySystem;\n pub use self::mass::Mass;\n pub use self::gravity_system::GravitySystem;\n+pub use self::physics_system::PhysicsSystem;\n+pub use self::collider::Collider;\n+pub use self::rigid_body::RigidBody;\n+\n+use std::collections::vec_deque::VecDeque;\n+use nphysics3d::world::World;\n+use nphysics3d::object::{BodyHandle, ColliderHandle};\n+\n+use types::*;\n+\n+/// `World`-global resource for nphysics `World`.\n+pub struct WorldResource {\n+    pub world: World<Real>,\n+}\n+\n+impl Default for WorldResource {\n+    fn default() -> WorldResource {\n+        WorldResource {\n+            // TODO: remove the ground? I don't think we want it,\n+            // and it appears to be created by default.\n+            // Or... there are no colliders by default, so maybe\n+            // the ground just exists as a \"root\" object?\n+            world: World::new(),\n+        }\n+    }\n+}\n+\n+// Work-around for not being able to access removed components","path":"planetkit/src/physics/mod.rs","position":39,"original_position":39,"commit_id":"5367bf036ed23175aab1f47ccf45f487f51bec85","original_commit_id":"5367bf036ed23175aab1f47ccf45f487f51bec85","user":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"body":"Link to https://github.com/slide-rs/specs/issues/361","created_at":"2018-07-19T10:50:34Z","updated_at":"2018-07-19T10:50:34Z","html_url":"https://github.com/jeffparsons/planetkit/pull/17#discussion_r203682746","pull_request_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/comments/203682746"},"html":{"href":"https://github.com/jeffparsons/planetkit/pull/17#discussion_r203682746"},"pull_request":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17","id":202516242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTE2MjQy","html_url":"https://github.com/jeffparsons/planetkit/pull/17","diff_url":"https://github.com/jeffparsons/planetkit/pull/17.diff","patch_url":"https://github.com/jeffparsons/planetkit/pull/17.patch","issue_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/17","number":17,"state":"open","locked":false,"title":"Use nphysics for grenade/terrain interactions","user":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"body":"Creates colliders for grenades and chunks, and removes them\nwhen their corresponding Specs components are removed.\n\nAt the moment the \"physics mesh\" for terrain is the same as\nthe visual mesh. This is just to get up and running. I intend\nto rework the way chunk views get created and destroyed,\nand more broadly the relationship between chunks and their views.\n(It's too fiddly and error-prone at the moment.)","created_at":"2018-07-19T10:35:33Z","updated_at":"2018-07-19T10:50:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeb23389d5489ed84b7ed36c9ecabfa19f0ad209","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17/commits","review_comments_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17/comments","review_comment_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/17/comments","statuses_url":"https://api.github.com/repos/jeffparsons/planetkit/statuses/5367bf036ed23175aab1f47ccf45f487f51bec85","head":{"label":"jeffparsons:use_nphysics","ref":"use_nphysics","sha":"5367bf036ed23175aab1f47ccf45f487f51bec85","user":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"repo":{"id":69864420,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2NDQyMA==","name":"planetkit","full_name":"jeffparsons/planetkit","owner":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffparsons/planetkit","description":"Colorful blobs that might one day resemble planets","fork":false,"url":"https://api.github.com/repos/jeffparsons/planetkit","forks_url":"https://api.github.com/repos/jeffparsons/planetkit/forks","keys_url":"https://api.github.com/repos/jeffparsons/planetkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffparsons/planetkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffparsons/planetkit/teams","hooks_url":"https://api.github.com/repos/jeffparsons/planetkit/hooks","issue_events_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/events{/number}","events_url":"https://api.github.com/repos/jeffparsons/planetkit/events","assignees_url":"https://api.github.com/repos/jeffparsons/planetkit/assignees{/user}","branches_url":"https://api.github.com/repos/jeffparsons/planetkit/branches{/branch}","tags_url":"https://api.github.com/repos/jeffparsons/planetkit/tags","blobs_url":"https://api.github.com/repos/jeffparsons/planetkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffparsons/planetkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffparsons/planetkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffparsons/planetkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffparsons/planetkit/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffparsons/planetkit/languages","stargazers_url":"https://api.github.com/repos/jeffparsons/planetkit/stargazers","contributors_url":"https://api.github.com/repos/jeffparsons/planetkit/contributors","subscribers_url":"https://api.github.com/repos/jeffparsons/planetkit/subscribers","subscription_url":"https://api.github.com/repos/jeffparsons/planetkit/subscription","commits_url":"https://api.github.com/repos/jeffparsons/planetkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffparsons/planetkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffparsons/planetkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffparsons/planetkit/contents/{+path}","compare_url":"https://api.github.com/repos/jeffparsons/planetkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffparsons/planetkit/merges","archive_url":"https://api.github.com/repos/jeffparsons/planetkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffparsons/planetkit/downloads","issues_url":"https://api.github.com/repos/jeffparsons/planetkit/issues{/number}","pulls_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffparsons/planetkit/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffparsons/planetkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffparsons/planetkit/labels{/name}","releases_url":"https://api.github.com/repos/jeffparsons/planetkit/releases{/id}","deployments_url":"https://api.github.com/repos/jeffparsons/planetkit/deployments","created_at":"2016-10-03T11:24:51Z","updated_at":"2018-07-01T07:08:43Z","pushed_at":"2018-07-19T10:35:34Z","git_url":"git://github.com/jeffparsons/planetkit.git","ssh_url":"git@github.com:jeffparsons/planetkit.git","clone_url":"https://github.com/jeffparsons/planetkit.git","svn_url":"https://github.com/jeffparsons/planetkit","homepage":"https://jeff.parsons.io/blog/","size":1743,"stargazers_count":58,"watchers_count":58,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":8,"watchers":58,"default_branch":"master"}},"base":{"label":"jeffparsons:master","ref":"master","sha":"02a06fd99b7c45e3361c1d9e023bc904c4192e82","user":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"repo":{"id":69864420,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2NDQyMA==","name":"planetkit","full_name":"jeffparsons/planetkit","owner":{"login":"jeffparsons","id":321861,"node_id":"MDQ6VXNlcjMyMTg2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/321861?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffparsons","html_url":"https://github.com/jeffparsons","followers_url":"https://api.github.com/users/jeffparsons/followers","following_url":"https://api.github.com/users/jeffparsons/following{/other_user}","gists_url":"https://api.github.com/users/jeffparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffparsons/subscriptions","organizations_url":"https://api.github.com/users/jeffparsons/orgs","repos_url":"https://api.github.com/users/jeffparsons/repos","events_url":"https://api.github.com/users/jeffparsons/events{/privacy}","received_events_url":"https://api.github.com/users/jeffparsons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffparsons/planetkit","description":"Colorful blobs that might one day resemble planets","fork":false,"url":"https://api.github.com/repos/jeffparsons/planetkit","forks_url":"https://api.github.com/repos/jeffparsons/planetkit/forks","keys_url":"https://api.github.com/repos/jeffparsons/planetkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffparsons/planetkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffparsons/planetkit/teams","hooks_url":"https://api.github.com/repos/jeffparsons/planetkit/hooks","issue_events_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/events{/number}","events_url":"https://api.github.com/repos/jeffparsons/planetkit/events","assignees_url":"https://api.github.com/repos/jeffparsons/planetkit/assignees{/user}","branches_url":"https://api.github.com/repos/jeffparsons/planetkit/branches{/branch}","tags_url":"https://api.github.com/repos/jeffparsons/planetkit/tags","blobs_url":"https://api.github.com/repos/jeffparsons/planetkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffparsons/planetkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffparsons/planetkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffparsons/planetkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffparsons/planetkit/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffparsons/planetkit/languages","stargazers_url":"https://api.github.com/repos/jeffparsons/planetkit/stargazers","contributors_url":"https://api.github.com/repos/jeffparsons/planetkit/contributors","subscribers_url":"https://api.github.com/repos/jeffparsons/planetkit/subscribers","subscription_url":"https://api.github.com/repos/jeffparsons/planetkit/subscription","commits_url":"https://api.github.com/repos/jeffparsons/planetkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffparsons/planetkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffparsons/planetkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffparsons/planetkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffparsons/planetkit/contents/{+path}","compare_url":"https://api.github.com/repos/jeffparsons/planetkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffparsons/planetkit/merges","archive_url":"https://api.github.com/repos/jeffparsons/planetkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffparsons/planetkit/downloads","issues_url":"https://api.github.com/repos/jeffparsons/planetkit/issues{/number}","pulls_url":"https://api.github.com/repos/jeffparsons/planetkit/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffparsons/planetkit/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffparsons/planetkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffparsons/planetkit/labels{/name}","releases_url":"https://api.github.com/repos/jeffparsons/planetkit/releases{/id}","deployments_url":"https://api.github.com/repos/jeffparsons/planetkit/deployments","created_at":"2016-10-03T11:24:51Z","updated_at":"2018-07-01T07:08:43Z","pushed_at":"2018-07-19T10:35:34Z","git_url":"git://github.com/jeffparsons/planetkit.git","ssh_url":"git@github.com:jeffparsons/planetkit.git","clone_url":"https://github.com/jeffparsons/planetkit.git","svn_url":"https://github.com/jeffparsons/planetkit","homepage":"https://jeff.parsons.io/blog/","size":1743,"stargazers_count":58,"watchers_count":58,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":8,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17"},"html":{"href":"https://github.com/jeffparsons/planetkit/pull/17"},"issue":{"href":"https://api.github.com/repos/jeffparsons/planetkit/issues/17"},"comments":{"href":"https://api.github.com/repos/jeffparsons/planetkit/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeffparsons/planetkit/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/jeffparsons/planetkit/statuses/5367bf036ed23175aab1f47ccf45f487f51bec85"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jeffparsons"}}