{"action":"opened","number":90,"pull_request":{"url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90","id":169374434,"html_url":"https://github.com/novoda/gradle-static-analysis-plugin/pull/90","diff_url":"https://github.com/novoda/gradle-static-analysis-plugin/pull/90.diff","patch_url":"https://github.com/novoda/gradle-static-analysis-plugin/pull/90.patch","issue_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/90","number":90,"state":"open","locked":false,"title":"Verify detekt config","user":{"login":"tasomaniac","id":763339,"avatar_url":"https://avatars1.githubusercontent.com/u/763339?v=4","gravatar_id":"","url":"https://api.github.com/users/tasomaniac","html_url":"https://github.com/tasomaniac","followers_url":"https://api.github.com/users/tasomaniac/followers","following_url":"https://api.github.com/users/tasomaniac/following{/other_user}","gists_url":"https://api.github.com/users/tasomaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/tasomaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasomaniac/subscriptions","organizations_url":"https://api.github.com/users/tasomaniac/orgs","repos_url":"https://api.github.com/users/tasomaniac/repos","events_url":"https://api.github.com/users/tasomaniac/events{/privacy}","received_events_url":"https://api.github.com/users/tasomaniac/received_events","type":"User","site_admin":false},"body":"Fixes #70 \r\n\r\n# Problem\r\n\r\nWe don't verify the tools configurations but maybe we should in some cases. In this particular case, `output` is optional in detekt and in such case, it just prints to console and skips generating file reports. \r\n\r\nWhen this happens, our plugin fails with an exception while running with not so clear error message. \r\n\r\n# Solution\r\n\r\nCheck if the `output` is defined. \r\n\r\n# Tests\r\n\r\n- Added a test case around the issue. \r\n- Moved configuration related tests together. \r\n- Little more boy-scouting in the test. ","created_at":"2018-02-15T13:43:01Z","updated_at":"2018-02-15T13:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90/commits","review_comments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90/comments","review_comment_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/90/comments","statuses_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/statuses/2ffae014e06bdd1cb09b31301c908488547a7181","head":{"label":"novoda:70/verify-detekt-config","ref":"70/verify-detekt-config","sha":"2ffae014e06bdd1cb09b31301c908488547a7181","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars2.githubusercontent.com/u/74874?v=4","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":73275282,"name":"gradle-static-analysis-plugin","full_name":"novoda/gradle-static-analysis-plugin","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars2.githubusercontent.com/u/74874?v=4","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/gradle-static-analysis-plugin","description":"Easy setup of static analysis tools for Android and Java projects.","fork":false,"url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin","forks_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/forks","keys_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/teams","hooks_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/hooks","issue_events_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/events","assignees_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/tags","blobs_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/languages","stargazers_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/stargazers","contributors_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/contributors","subscribers_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/subscribers","subscription_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/subscription","commits_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/merges","archive_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/downloads","issues_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/labels{/name}","releases_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/deployments","created_at":"2016-11-09T10:46:59Z","updated_at":"2018-02-15T11:13:47Z","pushed_at":"2018-02-15T13:42:17Z","git_url":"git://github.com/novoda/gradle-static-analysis-plugin.git","ssh_url":"git@github.com:novoda/gradle-static-analysis-plugin.git","clone_url":"https://github.com/novoda/gradle-static-analysis-plugin.git","svn_url":"https://github.com/novoda/gradle-static-analysis-plugin","homepage":"","size":843,"stargazers_count":62,"watchers_count":62,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":18,"watchers":62,"default_branch":"master"}},"base":{"label":"novoda:develop","ref":"develop","sha":"b47ab7a65821223eecaee108d010f1132f4bca0e","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars2.githubusercontent.com/u/74874?v=4","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":73275282,"name":"gradle-static-analysis-plugin","full_name":"novoda/gradle-static-analysis-plugin","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars2.githubusercontent.com/u/74874?v=4","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/gradle-static-analysis-plugin","description":"Easy setup of static analysis tools for Android and Java projects.","fork":false,"url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin","forks_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/forks","keys_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/teams","hooks_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/hooks","issue_events_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/events","assignees_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/tags","blobs_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/languages","stargazers_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/stargazers","contributors_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/contributors","subscribers_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/subscribers","subscription_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/subscription","commits_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/merges","archive_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/downloads","issues_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/labels{/name}","releases_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/deployments","created_at":"2016-11-09T10:46:59Z","updated_at":"2018-02-15T11:13:47Z","pushed_at":"2018-02-15T13:42:17Z","git_url":"git://github.com/novoda/gradle-static-analysis-plugin.git","ssh_url":"git@github.com:novoda/gradle-static-analysis-plugin.git","clone_url":"https://github.com/novoda/gradle-static-analysis-plugin.git","svn_url":"https://github.com/novoda/gradle-static-analysis-plugin","homepage":"","size":843,"stargazers_count":62,"watchers_count":62,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":18,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90"},"html":{"href":"https://github.com/novoda/gradle-static-analysis-plugin/pull/90"},"issue":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/90"},"comments":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/gradle-static-analysis-plugin/statuses/2ffae014e06bdd1cb09b31301c908488547a7181"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":63,"deletions":54,"changed_files":3}}
{"actor":{"display_login":"tasomaniac"}}