{"action":"closed","issue":{"url":"https://api.github.com/repos/KhaosT/HAP-NodeJS/issues/570","repository_url":"https://api.github.com/repos/KhaosT/HAP-NodeJS","labels_url":"https://api.github.com/repos/KhaosT/HAP-NodeJS/issues/570/labels{/name}","comments_url":"https://api.github.com/repos/KhaosT/HAP-NodeJS/issues/570/comments","events_url":"https://api.github.com/repos/KhaosT/HAP-NodeJS/issues/570/events","html_url":"https://github.com/KhaosT/HAP-NodeJS/issues/570","id":308382064,"number":570,"title":"TargetTemperature Range Problem?","user":{"login":"jvmahon","id":15061942,"avatar_url":"https://avatars0.githubusercontent.com/u/15061942?v=4","gravatar_id":"","url":"https://api.github.com/users/jvmahon","html_url":"https://github.com/jvmahon","followers_url":"https://api.github.com/users/jvmahon/followers","following_url":"https://api.github.com/users/jvmahon/following{/other_user}","gists_url":"https://api.github.com/users/jvmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/jvmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvmahon/subscriptions","organizations_url":"https://api.github.com/users/jvmahon/orgs","repos_url":"https://api.github.com/users/jvmahon/repos","events_url":"https://api.github.com/users/jvmahon/events{/privacy}","received_events_url":"https://api.github.com/users/jvmahon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-25T20:20:51Z","updated_at":"2018-03-25T23:18:16Z","closed_at":"2018-03-25T23:18:16Z","author_association":"NONE","body":"I think there's an Error in bounds checking/setting for the TargetTemperature Characteristic Slider. More specifically, there appears to be an error in the behavior of the slider used to set TargetTemperature when operating in the “AUTO” TargetHeatingCoolingState\" mode (value = 3).\r\n\r\nIn that mode, the slider is used to set both the cooling temperature and the heating temperature values.\r\n\r\nThe permitted values in the current implementation are between the values of CoolingThresholdTemperature.props.minValue and HeatingThresholdTemperature.props.maxValue.\r\nI believe the correct bounds should allow temperatures between:   HeatingThresholdTemperature.props.minValue and CoolingThresholdTemperature.props.maxValue.\r\n\r\nAnd more ideally, in AUTO mode, the bounds should constrain the Heating temperature to between: HeatingThresholdTemperature.props.minValue and HeatingThresholdTemperature.props.maxValue, and the cooling portion between and CoolingThresholdTemperature.props.minValue. and CoolingThresholdTemperature.props.maxValue.\r\n \r\nAs an illustration,  for the Characteristic Properties shown below:\r\n\r\nIn Cooling mode, I would expect to be able to select values from 10-35, and this is how the slider does respond.\r\n\r\nIn Heating mode, I would expect to be able to select values from 0-25, and this is how the slider does respond.\r\n\r\nIn AUTO mode, however, I would expect the slider to allow values over the entire range of 0-35. That is, you should still be able to lower the heat to the lowest value 0 and raise the cooling to the maximum value 35.    However, in AUTO mode, the slider constrains the values to between 10 and 25. That is, only the union of the CoolingThresholdTemperature and HeatingThresholdTemperature is permitted, while it seems it should be the entire range.\r\nI can’t figure out where the error is (assuming it is an error and not an intentional behavior) – is this range limitation imposed by HAP-NodeJS, or is there something in the Apple Home App that is doing this? Any thoughts on this?\r\n\r\n---------------------------------\r\ngetCharacteristic(Characteristic.CoolingThresholdTemperature).props.minValue = 10\r\ngetCharacteristic(Characteristic.CoolingThresholdTemperature).props.maxValue = 35\r\ngetCharacteristic(Characteristic.HeatingThresholdTemperature).props.minValue = 0\r\ngetCharacteristic(Characteristic.HeatingThresholdTemperature).props.maxValue = 25\r\ngetCharacteristic(Characteristic.TargetTemperature).props.minValue = 0\r\ngetCharacteristic(Characteristic.TargetTemperature).props.maxValue = 38\r\n\r\n"}}
{"actor":{"display_login":"jvmahon"}}