{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/191001463","pull_request_review_id":123503164,"id":191001463,"diff_hunk":"@@ -1077,8 +1073,14 @@ case class MatrixGroupColsByKey(child: MatrixIR, aggIR: IR) extends MatrixIR {\n       rvb.addAnnotation(oldColsType, oldColValuesBc.value)\n       val partitionWideColumnsOffset = rvb.end()\n \n-      rvb.start(columnMapType)\n-      rvb.addAnnotation(columnMapType, columnMap)\n+      rvb.start(newColumnIndicesType)\n+      rvb.startArray(newColumnIndices.length)\n+      var i = 0\n+      while (i < newColumnIndices.length){\n+        rvb.addAnnotation(TInt32(), newColumnIndices(i))","path":"src/main/scala/is/hail/expr/Relational.scala","position":78,"original_position":78,"commit_id":"d2edc6c9753119afbe7fa4014e5a64bd23756c82","original_commit_id":"d2edc6c9753119afbe7fa4014e5a64bd23756c82","user":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"rvb.addInt","created_at":"2018-05-25T20:23:55Z","updated_at":"2018-05-25T20:52:19Z","html_url":"https://github.com/hail-is/hail/pull/3665#discussion_r191001463","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/3665","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/191001463"},"html":{"href":"https://github.com/hail-is/hail/pull/3665#discussion_r191001463"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3665"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/3665","id":190685789,"html_url":"https://github.com/hail-is/hail/pull/3665","diff_url":"https://github.com/hail-is/hail/pull/3665.diff","patch_url":"https://github.com/hail-is/hail/pull/3665.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/3665","number":3665,"state":"open","locked":false,"title":"use array map instead of dict in groupColsBy","user":{"login":"maccum","id":35241112,"avatar_url":"https://avatars0.githubusercontent.com/u/35241112?v=4","gravatar_id":"","url":"https://api.github.com/users/maccum","html_url":"https://github.com/maccum","followers_url":"https://api.github.com/users/maccum/followers","following_url":"https://api.github.com/users/maccum/following{/other_user}","gists_url":"https://api.github.com/users/maccum/gists{/gist_id}","starred_url":"https://api.github.com/users/maccum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccum/subscriptions","organizations_url":"https://api.github.com/users/maccum/orgs","repos_url":"https://api.github.com/users/maccum/repos","events_url":"https://api.github.com/users/maccum/events{/privacy}","received_events_url":"https://api.github.com/users/maccum/received_events","type":"User","site_admin":false},"body":"address #3664","created_at":"2018-05-25T20:20:12Z","updated_at":"2018-05-25T20:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aef360d639607fb83f8cd9bb7d68e3cefbc3ba10","assignee":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"assignees":[{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/3665/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/3665/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/3665/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/d2edc6c9753119afbe7fa4014e5a64bd23756c82","head":{"label":"maccum:improveGroupColsBy","ref":"improveGroupColsBy","sha":"d2edc6c9753119afbe7fa4014e5a64bd23756c82","user":{"login":"maccum","id":35241112,"avatar_url":"https://avatars0.githubusercontent.com/u/35241112?v=4","gravatar_id":"","url":"https://api.github.com/users/maccum","html_url":"https://github.com/maccum","followers_url":"https://api.github.com/users/maccum/followers","following_url":"https://api.github.com/users/maccum/following{/other_user}","gists_url":"https://api.github.com/users/maccum/gists{/gist_id}","starred_url":"https://api.github.com/users/maccum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccum/subscriptions","organizations_url":"https://api.github.com/users/maccum/orgs","repos_url":"https://api.github.com/users/maccum/repos","events_url":"https://api.github.com/users/maccum/events{/privacy}","received_events_url":"https://api.github.com/users/maccum/received_events","type":"User","site_admin":false},"repo":{"id":116870819,"name":"hail","full_name":"maccum/hail","owner":{"login":"maccum","id":35241112,"avatar_url":"https://avatars0.githubusercontent.com/u/35241112?v=4","gravatar_id":"","url":"https://api.github.com/users/maccum","html_url":"https://github.com/maccum","followers_url":"https://api.github.com/users/maccum/followers","following_url":"https://api.github.com/users/maccum/following{/other_user}","gists_url":"https://api.github.com/users/maccum/gists{/gist_id}","starred_url":"https://api.github.com/users/maccum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maccum/subscriptions","organizations_url":"https://api.github.com/users/maccum/orgs","repos_url":"https://api.github.com/users/maccum/repos","events_url":"https://api.github.com/users/maccum/events{/privacy}","received_events_url":"https://api.github.com/users/maccum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maccum/hail","description":"Scalable genomic data analysis.","fork":true,"url":"https://api.github.com/repos/maccum/hail","forks_url":"https://api.github.com/repos/maccum/hail/forks","keys_url":"https://api.github.com/repos/maccum/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maccum/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maccum/hail/teams","hooks_url":"https://api.github.com/repos/maccum/hail/hooks","issue_events_url":"https://api.github.com/repos/maccum/hail/issues/events{/number}","events_url":"https://api.github.com/repos/maccum/hail/events","assignees_url":"https://api.github.com/repos/maccum/hail/assignees{/user}","branches_url":"https://api.github.com/repos/maccum/hail/branches{/branch}","tags_url":"https://api.github.com/repos/maccum/hail/tags","blobs_url":"https://api.github.com/repos/maccum/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maccum/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maccum/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/maccum/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maccum/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/maccum/hail/languages","stargazers_url":"https://api.github.com/repos/maccum/hail/stargazers","contributors_url":"https://api.github.com/repos/maccum/hail/contributors","subscribers_url":"https://api.github.com/repos/maccum/hail/subscribers","subscription_url":"https://api.github.com/repos/maccum/hail/subscription","commits_url":"https://api.github.com/repos/maccum/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/maccum/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/maccum/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/maccum/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/maccum/hail/contents/{+path}","compare_url":"https://api.github.com/repos/maccum/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maccum/hail/merges","archive_url":"https://api.github.com/repos/maccum/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maccum/hail/downloads","issues_url":"https://api.github.com/repos/maccum/hail/issues{/number}","pulls_url":"https://api.github.com/repos/maccum/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/maccum/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/maccum/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maccum/hail/labels{/name}","releases_url":"https://api.github.com/repos/maccum/hail/releases{/id}","deployments_url":"https://api.github.com/repos/maccum/hail/deployments","created_at":"2018-01-09T21:06:59Z","updated_at":"2018-05-25T20:18:28Z","pushed_at":"2018-05-25T20:18:53Z","git_url":"git://github.com/maccum/hail.git","ssh_url":"git@github.com:maccum/hail.git","clone_url":"https://github.com/maccum/hail.git","svn_url":"https://github.com/maccum/hail","homepage":"https://hail.is","size":36109,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"2618383089ae9d40c0bf1510c9bcfa899012f22b","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-05-25T20:42:57Z","pushed_at":"2018-05-25T20:44:14Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":36047,"stargazers_count":328,"watchers_count":328,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":99,"open_issues":144,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3665"},"html":{"href":"https://github.com/hail-is/hail/pull/3665"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/3665"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/3665/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3665/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3665/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/d2edc6c9753119afbe7fa4014e5a64bd23756c82"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tpoterba"}}