{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/comments/183964452","pull_request_review_id":115062772,"id":183964452,"diff_hunk":"@@ -306,11 +306,11 @@ def transaction_options(source, options, submit_for_settlement = false)\n         params[:payment_method_nonce] = source.nonce\n       end\n \n-      if source.paypal?\n+      if source.paypal? && options[:billing_address].present?","path":"app/models/solidus_paypal_braintree/gateway.rb","position":5,"original_position":5,"commit_id":"504b3ccbe22abc7e36a55ad9bf8a823d90e7b65c","original_commit_id":"504b3ccbe22abc7e36a55ad9bf8a823d90e7b65c","user":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars0.githubusercontent.com/u/42868?v=4","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"body":"Shouldn't this be \r\n\r\n```rb\r\noptions[:shipping_address].present?\r\n```","created_at":"2018-04-25T07:37:12Z","updated_at":"2018-04-25T07:39:23Z","html_url":"https://github.com/solidusio/solidus_paypal_braintree/pull/120#discussion_r183964452","pull_request_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/comments/183964452"},"html":{"href":"https://github.com/solidusio/solidus_paypal_braintree/pull/120#discussion_r183964452"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120","id":138328331,"html_url":"https://github.com/solidusio/solidus_paypal_braintree/pull/120","diff_url":"https://github.com/solidusio/solidus_paypal_braintree/pull/120.diff","patch_url":"https://github.com/solidusio/solidus_paypal_braintree/pull/120.patch","issue_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/120","number":120,"state":"open","locked":false,"title":"Don't try and add billing address if there is no billing address atta…","user":{"login":"joeljackson","id":181170,"avatar_url":"https://avatars3.githubusercontent.com/u/181170?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljackson","html_url":"https://github.com/joeljackson","followers_url":"https://api.github.com/users/joeljackson/followers","following_url":"https://api.github.com/users/joeljackson/following{/other_user}","gists_url":"https://api.github.com/users/joeljackson/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljackson/subscriptions","organizations_url":"https://api.github.com/users/joeljackson/orgs","repos_url":"https://api.github.com/users/joeljackson/repos","events_url":"https://api.github.com/users/joeljackson/events{/privacy}","received_events_url":"https://api.github.com/users/joeljackson/received_events","type":"User","site_admin":false},"body":"…ched to credit card","created_at":"2017-08-30T03:15:07Z","updated_at":"2018-04-25T07:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"213606a05a4f94c34f1194c8c2b212060e24d8be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/120/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/statuses/504b3ccbe22abc7e36a55ad9bf8a823d90e7b65c","head":{"label":"joeljackson:master","ref":"master","sha":"504b3ccbe22abc7e36a55ad9bf8a823d90e7b65c","user":{"login":"joeljackson","id":181170,"avatar_url":"https://avatars3.githubusercontent.com/u/181170?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljackson","html_url":"https://github.com/joeljackson","followers_url":"https://api.github.com/users/joeljackson/followers","following_url":"https://api.github.com/users/joeljackson/following{/other_user}","gists_url":"https://api.github.com/users/joeljackson/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljackson/subscriptions","organizations_url":"https://api.github.com/users/joeljackson/orgs","repos_url":"https://api.github.com/users/joeljackson/repos","events_url":"https://api.github.com/users/joeljackson/events{/privacy}","received_events_url":"https://api.github.com/users/joeljackson/received_events","type":"User","site_admin":false},"repo":{"id":101830918,"name":"solidus_paypal_braintree","full_name":"joeljackson/solidus_paypal_braintree","owner":{"login":"joeljackson","id":181170,"avatar_url":"https://avatars3.githubusercontent.com/u/181170?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljackson","html_url":"https://github.com/joeljackson","followers_url":"https://api.github.com/users/joeljackson/followers","following_url":"https://api.github.com/users/joeljackson/following{/other_user}","gists_url":"https://api.github.com/users/joeljackson/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljackson/subscriptions","organizations_url":"https://api.github.com/users/joeljackson/orgs","repos_url":"https://api.github.com/users/joeljackson/repos","events_url":"https://api.github.com/users/joeljackson/events{/privacy}","received_events_url":"https://api.github.com/users/joeljackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joeljackson/solidus_paypal_braintree","description":"Soon-to-be officially supported braintree plugin","fork":true,"url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree","forks_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/forks","keys_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/teams","hooks_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/hooks","issue_events_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/issues/events{/number}","events_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/events","assignees_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/assignees{/user}","branches_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/branches{/branch}","tags_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/tags","blobs_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/statuses/{sha}","languages_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/languages","stargazers_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/stargazers","contributors_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/contributors","subscribers_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/subscribers","subscription_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/subscription","commits_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/issues/comments{/number}","contents_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/contents/{+path}","compare_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/merges","archive_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/downloads","issues_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/issues{/number}","pulls_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/pulls{/number}","milestones_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/milestones{/number}","notifications_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/labels{/name}","releases_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/releases{/id}","deployments_url":"https://api.github.com/repos/joeljackson/solidus_paypal_braintree/deployments","created_at":"2017-08-30T02:58:49Z","updated_at":"2018-04-21T14:52:46Z","pushed_at":"2018-04-21T17:26:21Z","git_url":"git://github.com/joeljackson/solidus_paypal_braintree.git","ssh_url":"git@github.com:joeljackson/solidus_paypal_braintree.git","clone_url":"https://github.com/joeljackson/solidus_paypal_braintree.git","svn_url":"https://github.com/joeljackson/solidus_paypal_braintree","homepage":null,"size":1586,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"4c36da70368a51c992a141bcae8d9a91a6ab08ec","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":67078580,"name":"solidus_paypal_braintree","full_name":"solidusio/solidus_paypal_braintree","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars1.githubusercontent.com/u/11045486?v=4","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus_paypal_braintree","description":"Soon-to-be officially supported braintree plugin","fork":false,"url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree","forks_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/forks","keys_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/events","assignees_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/merges","archive_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/deployments","created_at":"2016-08-31T22:39:27Z","updated_at":"2018-04-09T08:22:56Z","pushed_at":"2018-04-21T17:27:27Z","git_url":"git://github.com/solidusio/solidus_paypal_braintree.git","ssh_url":"git@github.com:solidusio/solidus_paypal_braintree.git","clone_url":"https://github.com/solidusio/solidus_paypal_braintree.git","svn_url":"https://github.com/solidusio/solidus_paypal_braintree","homepage":null,"size":1574,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":26,"open_issues":31,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120"},"html":{"href":"https://github.com/solidusio/solidus_paypal_braintree/pull/120"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/120"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus_paypal_braintree/statuses/504b3ccbe22abc7e36a55ad9bf8a823d90e7b65c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tvdeyen"}}