{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/639","repository_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize","labels_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/639/labels{/name}","comments_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/639/comments","events_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/639/events","html_url":"https://github.com/scikit-optimize/scikit-optimize/pull/639","id":298407747,"number":639,"title":"[MRG+1] Deal with matplotlib being broken on some OSX systems.","user":{"login":"betatim","id":1448859,"avatar_url":"https://avatars1.githubusercontent.com/u/1448859?v=4","gravatar_id":"","url":"https://api.github.com/users/betatim","html_url":"https://github.com/betatim","followers_url":"https://api.github.com/users/betatim/followers","following_url":"https://api.github.com/users/betatim/following{/other_user}","gists_url":"https://api.github.com/users/betatim/gists{/gist_id}","starred_url":"https://api.github.com/users/betatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betatim/subscriptions","organizations_url":"https://api.github.com/users/betatim/orgs","repos_url":"https://api.github.com/users/betatim/repos","events_url":"https://api.github.com/users/betatim/events{/privacy}","received_events_url":"https://api.github.com/users/betatim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-19T21:38:35Z","updated_at":"2018-03-05T06:34:41Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/pulls/639","html_url":"https://github.com/scikit-optimize/scikit-optimize/pull/639","diff_url":"https://github.com/scikit-optimize/scikit-optimize/pull/639.diff","patch_url":"https://github.com/scikit-optimize/scikit-optimize/pull/639.patch"},"body":"Fixes #637 \r\n\r\nI am not sure what I think of this. On the one hand it feels like it is the user's problem if they can't setup `matplotlib` properly, on the other hand there are plenty of use-cases for skopt without plotting.\r\n\r\nGenerally we should try and find out how other libraries deal with this."},"comment":{"url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/comments/370323139","html_url":"https://github.com/scikit-optimize/scikit-optimize/pull/639#issuecomment-370323139","issue_url":"https://api.github.com/repos/scikit-optimize/scikit-optimize/issues/639","id":370323139,"user":{"login":"betatim","id":1448859,"avatar_url":"https://avatars1.githubusercontent.com/u/1448859?v=4","gravatar_id":"","url":"https://api.github.com/users/betatim","html_url":"https://github.com/betatim","followers_url":"https://api.github.com/users/betatim/followers","following_url":"https://api.github.com/users/betatim/following{/other_user}","gists_url":"https://api.github.com/users/betatim/gists{/gist_id}","starred_url":"https://api.github.com/users/betatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betatim/subscriptions","organizations_url":"https://api.github.com/users/betatim/orgs","repos_url":"https://api.github.com/users/betatim/repos","events_url":"https://api.github.com/users/betatim/events{/privacy}","received_events_url":"https://api.github.com/users/betatim/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T06:34:41Z","updated_at":"2018-03-05T06:34:41Z","author_association":"OWNER","body":"I think this would still lead the an exception if you tried to run skopt on a machine without matplotlib. If we want to support `matpltlib` as a optional dependency we should do something else.\r\n\r\nThere are a few tools that do \"delayed\" imports but they all appear like hacks and would require us to add a new dependency.\r\n\r\nThe only alternative I can think of is that `skopt.plots` isn't imported in `__init__.py` and you only get it by explicitly importing it.\r\n\r\nIn pandas the imports are done inside a plotting class that the data frame only instantiates when needed. Not sure that maps well to our free standing functions."}}
{"actor":{"display_login":"betatim"}}