{"action":"created","issue":{"url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/221","repository_url":"https://api.github.com/repos/kelaberetiv/TagUI","labels_url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/221/comments","events_url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/221/events","html_url":"https://github.com/kelaberetiv/TagUI/issues/221","id":333512097,"node_id":"MDU6SXNzdWUzMzM1MTIwOTc=","number":221,"title":"Harmonizing object repository and datatable","user":{"login":"kensoh","id":10379601,"node_id":"MDQ6VXNlcjEwMzc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/10379601?v=4","gravatar_id":"","url":"https://api.github.com/users/kensoh","html_url":"https://github.com/kensoh","followers_url":"https://api.github.com/users/kensoh/followers","following_url":"https://api.github.com/users/kensoh/following{/other_user}","gists_url":"https://api.github.com/users/kensoh/gists{/gist_id}","starred_url":"https://api.github.com/users/kensoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensoh/subscriptions","organizations_url":"https://api.github.com/users/kensoh/orgs","repos_url":"https://api.github.com/users/kensoh/repos","events_url":"https://api.github.com/users/kensoh/events{/privacy}","received_events_url":"https://api.github.com/users/kensoh/received_events","type":"User","site_admin":false},"labels":[{"id":495273737,"node_id":"MDU6TGFiZWw0OTUyNzM3Mzc=","url":"https://api.github.com/repos/kelaberetiv/TagUI/labels/query","name":"query","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"lohvht","id":13414637,"node_id":"MDQ6VXNlcjEzNDE0NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/13414637?v=4","gravatar_id":"","url":"https://api.github.com/users/lohvht","html_url":"https://github.com/lohvht","followers_url":"https://api.github.com/users/lohvht/followers","following_url":"https://api.github.com/users/lohvht/following{/other_user}","gists_url":"https://api.github.com/users/lohvht/gists{/gist_id}","starred_url":"https://api.github.com/users/lohvht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lohvht/subscriptions","organizations_url":"https://api.github.com/users/lohvht/orgs","repos_url":"https://api.github.com/users/lohvht/repos","events_url":"https://api.github.com/users/lohvht/events{/privacy}","received_events_url":"https://api.github.com/users/lohvht/received_events","type":"User","site_admin":false},"assignees":[{"login":"lohvht","id":13414637,"node_id":"MDQ6VXNlcjEzNDE0NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/13414637?v=4","gravatar_id":"","url":"https://api.github.com/users/lohvht","html_url":"https://github.com/lohvht","followers_url":"https://api.github.com/users/lohvht/followers","following_url":"https://api.github.com/users/lohvht/following{/other_user}","gists_url":"https://api.github.com/users/lohvht/gists{/gist_id}","starred_url":"https://api.github.com/users/lohvht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lohvht/subscriptions","organizations_url":"https://api.github.com/users/lohvht/orgs","repos_url":"https://api.github.com/users/lohvht/repos","events_url":"https://api.github.com/users/lohvht/events{/privacy}","received_events_url":"https://api.github.com/users/lohvht/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-19T04:05:05Z","updated_at":"2018-06-20T03:49:09Z","closed_at":"2018-06-20T03:49:09Z","author_association":"MEMBER","body":"With https://github.com/kelaberetiv/TagUI/issues/175 now it is possible for users to specify a custom datatable to be use for their automation. However, there is likely an issue out of this. If object repository is used and datatable is used, due to the inherent difference in the number of columns, object definitions will probably not be available at iterations beyond the 1st iteration.\r\n\r\nThis issue is to check if this assumption is true and how to mitigate (auto-padding the empty columns to let object definitions work for all iterations), plus explore if there is a way to harmonize the use of object repository and datatable at the same time (for eg having object repository always being named as flow_name.csv, or other ideas).\r\n\r\nAm ok to break backward compatibility for the upcoming release v4.0. Better to break dependencies that need to be broken all at one go, than introducing small breaking changes piece-wise and make it hard for users to keep testing with each upgrade."},"comment":{"url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/comments/398615711","html_url":"https://github.com/kelaberetiv/TagUI/issues/221#issuecomment-398615711","issue_url":"https://api.github.com/repos/kelaberetiv/TagUI/issues/221","id":398615711,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODYxNTcxMQ==","user":{"login":"kensoh","id":10379601,"node_id":"MDQ6VXNlcjEwMzc5NjAx","avatar_url":"https://avatars0.githubusercontent.com/u/10379601?v=4","gravatar_id":"","url":"https://api.github.com/users/kensoh","html_url":"https://github.com/kensoh","followers_url":"https://api.github.com/users/kensoh/followers","following_url":"https://api.github.com/users/kensoh/following{/other_user}","gists_url":"https://api.github.com/users/kensoh/gists{/gist_id}","starred_url":"https://api.github.com/users/kensoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kensoh/subscriptions","organizations_url":"https://api.github.com/users/kensoh/orgs","repos_url":"https://api.github.com/users/kensoh/repos","events_url":"https://api.github.com/users/kensoh/events{/privacy}","received_events_url":"https://api.github.com/users/kensoh/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T03:49:09Z","updated_at":"2018-06-20T03:49:09Z","author_association":"MEMBER","body":"Ooops just realised that this 'padding' stuff is already handled by below code in tagui_parse.php. Added it previously for future proofing but forgot about it. closing the issue now, cc @Aussiroth \r\n\r\n```php\r\nif (count($repo_data[$repo_count]) != 1) // pad the empty columns when local repository is used with datatable\r\n{$repo_data[$repo_count] = array_pad($repo_data[$repo_count], count($repo_data[0]), $repo_data[$repo_count][1]);}\r\n```\r\n\r\nTested to work with sample flow 5_repositories by renaming 5_repositories.csv to tagui_local.csv and then creating another abc.csv file that is a datatable of 5 iterations. flow able to run for 5 iterations using variables defined in both the datatable abc.csv and tagui_local.csv."}}
{"actor":{"display_login":"kensoh"}}