{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments/185702245","pull_request_review_id":117143138,"id":185702245,"diff_hunk":"@@ -0,0 +1,22 @@\n+Eigvals\t3\n+0.26252020959180306\t0.09043197375300857\t0.07177687511060699\n+\n+Proportion explained\t3\n+0.6180886481996106\t0.2129168512318794\t0.16899450056851006","path":"skbio/stats/ordination/tests/data/PCoA_sample_data_3_fsvd_3d_ref","position":5,"original_position":5,"commit_id":"6c9194cea4a6eaec12a7b94871fda89e8ea13f42","original_commit_id":"33b4b289271ba687ad2d00d57c357ef2cdcb30ac","user":{"login":"HannesHolste","id":4384130,"avatar_url":"https://avatars2.githubusercontent.com/u/4384130?v=4","gravatar_id":"","url":"https://api.github.com/users/HannesHolste","html_url":"https://github.com/HannesHolste","followers_url":"https://api.github.com/users/HannesHolste/followers","following_url":"https://api.github.com/users/HannesHolste/following{/other_user}","gists_url":"https://api.github.com/users/HannesHolste/gists{/gist_id}","starred_url":"https://api.github.com/users/HannesHolste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannesHolste/subscriptions","organizations_url":"https://api.github.com/users/HannesHolste/orgs","repos_url":"https://api.github.com/users/HannesHolste/repos","events_url":"https://api.github.com/users/HannesHolste/events{/privacy}","received_events_url":"https://api.github.com/users/HannesHolste/received_events","type":"User","site_admin":false},"body":"fsvd to 3 dimensions:\r\neigh produces the following proportions on the same dataset, which all sum to 1:\r\n`0.47397595644762963\t0.2781864326674703\t0.24783761088490003`","created_at":"2018-05-03T06:02:18Z","updated_at":"2018-05-03T06:02:19Z","html_url":"https://github.com/biocore/scikit-bio/pull/1569#discussion_r185702245","pull_request_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments/185702245"},"html":{"href":"https://github.com/biocore/scikit-bio/pull/1569#discussion_r185702245"},"pull_request":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569"}},"in_reply_to_id":185650788},"pull_request":{"url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569","id":185300086,"html_url":"https://github.com/biocore/scikit-bio/pull/1569","diff_url":"https://github.com/biocore/scikit-bio/pull/1569.diff","patch_url":"https://github.com/biocore/scikit-bio/pull/1569.patch","issue_url":"https://api.github.com/repos/biocore/scikit-bio/issues/1569","number":1569,"state":"open","locked":false,"title":"Fast heuristic PCoA (FSVD)","user":{"login":"HannesHolste","id":4384130,"avatar_url":"https://avatars2.githubusercontent.com/u/4384130?v=4","gravatar_id":"","url":"https://api.github.com/users/HannesHolste","html_url":"https://github.com/HannesHolste","followers_url":"https://api.github.com/users/HannesHolste/followers","following_url":"https://api.github.com/users/HannesHolste/following{/other_user}","gists_url":"https://api.github.com/users/HannesHolste/gists{/gist_id}","starred_url":"https://api.github.com/users/HannesHolste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannesHolste/subscriptions","organizations_url":"https://api.github.com/users/HannesHolste/orgs","repos_url":"https://api.github.com/users/HannesHolste/repos","events_url":"https://api.github.com/users/HannesHolste/events{/privacy}","received_events_url":"https://api.github.com/users/HannesHolste/received_events","type":"User","site_admin":false},"body":"Requesting reviews from @antgonza and @wasade, who are briefed on this research project.\r\n\r\nPlease complete the following checklist:\r\n\r\n* [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/biocore/scikit-bio/blob/master/CONTRIBUTING.md).\r\n\r\n* [x] I have documented all public-facing changes in [CHANGELOG.md](https://github.com/biocore/scikit-bio/blob/master/CHANGELOG.md).\r\n\r\n* [x] **This pull request includes code, documentation, or other content derived from external source(s).** If this is the case, ensure the external source's license is compatible with scikit-bio's [license](https://github.com/biocore/scikit-bio/blob/master/COPYING.txt). Include the license in the `licenses` directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied. **It is your responsibility to disclose code, documentation, or other content derived from external source(s).** If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.\r\n\r\n-> Contains code from our other, internal biocore repository [https://github.com/biocore/mds-approximations](https://github.com/biocore/mds-approximations)\r\n\r\n* [ ] **This pull request does not include code, documentation, or other content derived from external source(s).**\r\n\r\n**Note:** [REVIEWING.md](https://github.com/biocore/scikit-bio/blob/master/REVIEWING.md) may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.\r\n\r\nOverview:\r\nWe faced a severe PCoA bottleneck, which mds-approximations project sought to understand and overcome. This PR implements FSVD, which was decided to be the candidate for fast, approximate eigendecomposition. FSVD was implemented based on research outlined by Halko et al (2011) in a paper mentioned in the documentation of the pcoa class in this PR.\r\n\r\nComments about PR:\r\n* Added fsvd as an optional method to the pcoa class. But by default, the old eigh is used, which computes \"exact\" eigenvectors and eigenvalues. No backwards-incompatible changes made.\r\n* Wrote unit tests for newly introduced functions.","created_at":"2018-05-01T23:20:15Z","updated_at":"2018-05-03T06:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8c0fd3b332f93e1000f1efb97f67aff8625b83c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569/commits","review_comments_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569/comments","review_comment_url":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biocore/scikit-bio/issues/1569/comments","statuses_url":"https://api.github.com/repos/biocore/scikit-bio/statuses/6c9194cea4a6eaec12a7b94871fda89e8ea13f42","head":{"label":"HannesHolste:fsvd","ref":"fsvd","sha":"6c9194cea4a6eaec12a7b94871fda89e8ea13f42","user":{"login":"HannesHolste","id":4384130,"avatar_url":"https://avatars2.githubusercontent.com/u/4384130?v=4","gravatar_id":"","url":"https://api.github.com/users/HannesHolste","html_url":"https://github.com/HannesHolste","followers_url":"https://api.github.com/users/HannesHolste/followers","following_url":"https://api.github.com/users/HannesHolste/following{/other_user}","gists_url":"https://api.github.com/users/HannesHolste/gists{/gist_id}","starred_url":"https://api.github.com/users/HannesHolste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannesHolste/subscriptions","organizations_url":"https://api.github.com/users/HannesHolste/orgs","repos_url":"https://api.github.com/users/HannesHolste/repos","events_url":"https://api.github.com/users/HannesHolste/events{/privacy}","received_events_url":"https://api.github.com/users/HannesHolste/received_events","type":"User","site_admin":false},"repo":{"id":131222307,"name":"scikit-bio","full_name":"HannesHolste/scikit-bio","owner":{"login":"HannesHolste","id":4384130,"avatar_url":"https://avatars2.githubusercontent.com/u/4384130?v=4","gravatar_id":"","url":"https://api.github.com/users/HannesHolste","html_url":"https://github.com/HannesHolste","followers_url":"https://api.github.com/users/HannesHolste/followers","following_url":"https://api.github.com/users/HannesHolste/following{/other_user}","gists_url":"https://api.github.com/users/HannesHolste/gists{/gist_id}","starred_url":"https://api.github.com/users/HannesHolste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HannesHolste/subscriptions","organizations_url":"https://api.github.com/users/HannesHolste/orgs","repos_url":"https://api.github.com/users/HannesHolste/repos","events_url":"https://api.github.com/users/HannesHolste/events{/privacy}","received_events_url":"https://api.github.com/users/HannesHolste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HannesHolste/scikit-bio","description":"scikit-bio is an open-source, BSD-licensed, Python package providing data structures, algorithms, and educational resources for bioinformatics.","fork":true,"url":"https://api.github.com/repos/HannesHolste/scikit-bio","forks_url":"https://api.github.com/repos/HannesHolste/scikit-bio/forks","keys_url":"https://api.github.com/repos/HannesHolste/scikit-bio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HannesHolste/scikit-bio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HannesHolste/scikit-bio/teams","hooks_url":"https://api.github.com/repos/HannesHolste/scikit-bio/hooks","issue_events_url":"https://api.github.com/repos/HannesHolste/scikit-bio/issues/events{/number}","events_url":"https://api.github.com/repos/HannesHolste/scikit-bio/events","assignees_url":"https://api.github.com/repos/HannesHolste/scikit-bio/assignees{/user}","branches_url":"https://api.github.com/repos/HannesHolste/scikit-bio/branches{/branch}","tags_url":"https://api.github.com/repos/HannesHolste/scikit-bio/tags","blobs_url":"https://api.github.com/repos/HannesHolste/scikit-bio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HannesHolste/scikit-bio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HannesHolste/scikit-bio/git/refs{/sha}","trees_url":"https://api.github.com/repos/HannesHolste/scikit-bio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HannesHolste/scikit-bio/statuses/{sha}","languages_url":"https://api.github.com/repos/HannesHolste/scikit-bio/languages","stargazers_url":"https://api.github.com/repos/HannesHolste/scikit-bio/stargazers","contributors_url":"https://api.github.com/repos/HannesHolste/scikit-bio/contributors","subscribers_url":"https://api.github.com/repos/HannesHolste/scikit-bio/subscribers","subscription_url":"https://api.github.com/repos/HannesHolste/scikit-bio/subscription","commits_url":"https://api.github.com/repos/HannesHolste/scikit-bio/commits{/sha}","git_commits_url":"https://api.github.com/repos/HannesHolste/scikit-bio/git/commits{/sha}","comments_url":"https://api.github.com/repos/HannesHolste/scikit-bio/comments{/number}","issue_comment_url":"https://api.github.com/repos/HannesHolste/scikit-bio/issues/comments{/number}","contents_url":"https://api.github.com/repos/HannesHolste/scikit-bio/contents/{+path}","compare_url":"https://api.github.com/repos/HannesHolste/scikit-bio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HannesHolste/scikit-bio/merges","archive_url":"https://api.github.com/repos/HannesHolste/scikit-bio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HannesHolste/scikit-bio/downloads","issues_url":"https://api.github.com/repos/HannesHolste/scikit-bio/issues{/number}","pulls_url":"https://api.github.com/repos/HannesHolste/scikit-bio/pulls{/number}","milestones_url":"https://api.github.com/repos/HannesHolste/scikit-bio/milestones{/number}","notifications_url":"https://api.github.com/repos/HannesHolste/scikit-bio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HannesHolste/scikit-bio/labels{/name}","releases_url":"https://api.github.com/repos/HannesHolste/scikit-bio/releases{/id}","deployments_url":"https://api.github.com/repos/HannesHolste/scikit-bio/deployments","created_at":"2018-04-26T23:50:58Z","updated_at":"2018-04-26T23:51:02Z","pushed_at":"2018-05-03T05:46:28Z","git_url":"git://github.com/HannesHolste/scikit-bio.git","ssh_url":"git@github.com:HannesHolste/scikit-bio.git","clone_url":"https://github.com/HannesHolste/scikit-bio.git","svn_url":"https://github.com/HannesHolste/scikit-bio","homepage":"http://scikit-bio.org","size":44403,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:master","ref":"master","sha":"202abbd265cb09277f71d2b74c9a9df3d60ec29c","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars3.githubusercontent.com/u/6241857?v=4","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":15168264,"name":"scikit-bio","full_name":"biocore/scikit-bio","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars3.githubusercontent.com/u/6241857?v=4","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/scikit-bio","description":"scikit-bio is an open-source, BSD-licensed, Python package providing data structures, algorithms, and educational resources for bioinformatics.","fork":false,"url":"https://api.github.com/repos/biocore/scikit-bio","forks_url":"https://api.github.com/repos/biocore/scikit-bio/forks","keys_url":"https://api.github.com/repos/biocore/scikit-bio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/scikit-bio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/scikit-bio/teams","hooks_url":"https://api.github.com/repos/biocore/scikit-bio/hooks","issue_events_url":"https://api.github.com/repos/biocore/scikit-bio/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/scikit-bio/events","assignees_url":"https://api.github.com/repos/biocore/scikit-bio/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/scikit-bio/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/scikit-bio/tags","blobs_url":"https://api.github.com/repos/biocore/scikit-bio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/scikit-bio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/scikit-bio/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/scikit-bio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/scikit-bio/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/scikit-bio/languages","stargazers_url":"https://api.github.com/repos/biocore/scikit-bio/stargazers","contributors_url":"https://api.github.com/repos/biocore/scikit-bio/contributors","subscribers_url":"https://api.github.com/repos/biocore/scikit-bio/subscribers","subscription_url":"https://api.github.com/repos/biocore/scikit-bio/subscription","commits_url":"https://api.github.com/repos/biocore/scikit-bio/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/scikit-bio/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/scikit-bio/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/scikit-bio/issues/comments{/number}","contents_url":"https://api.github.com/repos/biocore/scikit-bio/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/scikit-bio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/scikit-bio/merges","archive_url":"https://api.github.com/repos/biocore/scikit-bio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/scikit-bio/downloads","issues_url":"https://api.github.com/repos/biocore/scikit-bio/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/scikit-bio/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/scikit-bio/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/scikit-bio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/scikit-bio/labels{/name}","releases_url":"https://api.github.com/repos/biocore/scikit-bio/releases{/id}","deployments_url":"https://api.github.com/repos/biocore/scikit-bio/deployments","created_at":"2013-12-13T16:24:41Z","updated_at":"2018-05-02T16:10:18Z","pushed_at":"2018-05-03T05:46:30Z","git_url":"git://github.com/biocore/scikit-bio.git","ssh_url":"git@github.com:biocore/scikit-bio.git","clone_url":"https://github.com/biocore/scikit-bio.git","svn_url":"https://github.com/biocore/scikit-bio","homepage":"http://scikit-bio.org","size":44369,"stargazers_count":369,"watchers_count":369,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":166,"open_issues":197,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569"},"html":{"href":"https://github.com/biocore/scikit-bio/pull/1569"},"issue":{"href":"https://api.github.com/repos/biocore/scikit-bio/issues/1569"},"comments":{"href":"https://api.github.com/repos/biocore/scikit-bio/issues/1569/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biocore/scikit-bio/pulls/1569/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/scikit-bio/statuses/6c9194cea4a6eaec12a7b94871fda89e8ea13f42"}},"author_association":"NONE"}}
{"actor":{"display_login":"HannesHolste"}}