{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67650","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67650/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67650/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67650/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67650","id":352473802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Nzc1MDgx","number":67650,"title":"Generate staging/src/client-go for all APIs in k8s/api","user":{"login":"jsafrane","id":1745006,"node_id":"MDQ6VXNlcjE3NDUwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-21T10:12:44Z","updated_at":"2018-08-21T10:53:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67650","html_url":"https://github.com/kubernetes/kubernetes/pull/67650","diff_url":"https://github.com/kubernetes/kubernetes/pull/67650.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67650.patch"},"body":"**What this PR does / why we need it**:\r\nInformers and listers are generated for all `types.go` in staging/src/k8s/api: https://github.com/kubernetes/kubernetes/blob/54dbbc41dfe93ce09c166f26f7621d88242cc3d5/hack/update-codegen.sh#L90\r\n\r\nGenerated client (client-gen) is generated from `KUBE_AVAILABLE_GROUP_VERSIONS` instead. This seems inconsistent, as there is generated lister for `imagepolicy/v1alpha1`, but there is no client for it.\r\n\r\nThis PR runs client-gen in the same way as informer-gen and lister-gen.\r\n\r\nAs result, new clients for `admission/v1beta1` and `imagepolicy/v1alpha1` are generated. Some code in the generated code is reordered, I am not sure it has any impact on anything.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\nThis is related to #67602. We *may* need generated external clients for APIs not in `KUBE_AVAILABLE_GROUP_VERSIONS`, as this API is going to be provided by CRD and not pkg/apis. If this is a good idea or not is currently open.\r\n\r\n/sig api-machinery\r\ncc: @sttts "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/414634142","html_url":"https://github.com/kubernetes/kubernetes/pull/67650#issuecomment-414634142","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67650","id":414634142,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDYzNDE0Mg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T10:53:05Z","updated_at":"2018-08-21T10:53:05Z","author_association":"NONE","body":"@jsafrane: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-bazel-build/54679/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-gce-device-plugin-gpu | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-e2e-gce-device-plugin-gpu/44457/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-gce | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-e2e-gce/49172/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-bazel-test | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-bazel-test/57212/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-e2e-kops-aws/102364/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce-100-performance | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-e2e-gce-100-performance/17120/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-verify | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-verify/103299/) | `/test pull-kubernetes-verify`\npull-kubernetes-kubemark-e2e-gce-big | 877ee83793d59f13733a7c39dba2ca7fc5086716 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67650/pull-kubernetes-kubemark-e2e-gce-big/18943/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/67650). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/jsafrane). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}