{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/folio-org/ui-developer/pulls/21","id":214355595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzU1NTk1","html_url":"https://github.com/folio-org/ui-developer/pull/21","diff_url":"https://github.com/folio-org/ui-developer/pull/21.diff","patch_url":"https://github.com/folio-org/ui-developer/pull/21.patch","issue_url":"https://api.github.com/repos/folio-org/ui-developer/issues/21","number":21,"state":"closed","locked":false,"title":"Clean up dependencies","user":{"login":"cherewaty","id":230597,"node_id":"MDQ6VXNlcjIzMDU5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/230597?v=4","gravatar_id":"","url":"https://api.github.com/users/cherewaty","html_url":"https://github.com/cherewaty","followers_url":"https://api.github.com/users/cherewaty/followers","following_url":"https://api.github.com/users/cherewaty/following{/other_user}","gists_url":"https://api.github.com/users/cherewaty/gists{/gist_id}","starred_url":"https://api.github.com/users/cherewaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherewaty/subscriptions","organizations_url":"https://api.github.com/users/cherewaty/orgs","repos_url":"https://api.github.com/users/cherewaty/repos","events_url":"https://api.github.com/users/cherewaty/events{/privacy}","received_events_url":"https://api.github.com/users/cherewaty/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nRemoves unnecessary `babel` packages and upgrades `eslint-config-stripes`.\r\n\r\n## Approach\r\nA section of output from `yarn install`:\r\n```\r\n[4/5] 🔗  Linking dependencies...\r\nwarning \" > @folio/stripes-components@3.0.10000507\" has unmet peer dependency \"@folio/stripes-core@^2.7.0\".\r\nwarning \"@folio/stripes-components > @folio/stripes-connect@3.2.100049\" has unmet peer dependency \"react@*\".\r\nwarning \"@folio/stripes-components > @folio/stripes-connect@3.2.100049\" has unmet peer dependency \"react-dom@*\".\r\nwarning \"@folio/stripes-components > downshift@2.2.2\" has unmet peer dependency \"react@>=0.14.9\".\r\nwarning \"@folio/stripes-components > prop-types-extra@1.1.0\" has unmet peer dependency \"react@>=0.14.0\".\r\nwarning \"@folio/stripes-components > @folio/stripes-react-hotkeys@1.0.10002\" has unmet peer dependency \"react@*\".\r\nwarning \"@folio/stripes-components > @folio/stripes-react-hotkeys@1.0.10002\" has unmet peer dependency \"react-dom@*\".\r\nwarning \"@folio/stripes-components > react-highlighter@0.4.3\" has unmet peer dependency \"react@^0.14.0 || ^15.0.0 || ^16.0.0\".\r\nwarning \"@folio/stripes-components > react-intl@2.4.0\" has unmet peer dependency \"react@^0.14.9 || ^15.0.0 || ^16.0.0\".\r\n```\r\n\r\nTo pick an example out of there, NPM identified `react@^16.3.0` from `stripes-core`, and resolves it to `16.5.0` (the latest as of Sep. 11, 2018). NPM also identified that `react-intl` has a peer dependency on `react@^0.14.9 || ^15.0.0 || ^16.0.0`. When running `npm start` (`stripes serve`) in this repo, `react` will use the version `stripes-core` requested, `^16.3.0`, which resolves to `16.5.0`. NPM then warns you that \"hey, I see you have a direct dependency on `react-intl`, but you didn't tell me explicitly what version of `react` to use here.\" NPM is very assertively trying to guide you away from dependency anti-patterns.\r\n\r\n[Dependencies Done Right](https://yarnpkg.com/blog/2018/04/18/dependencies-done-right/)\r\n[Common npm mistakes](https://medium.com/@jacob.h.page/common-npm-mistakes-51bf8989079f)\r\n[The NPM change that discusses this behavior](https://github.com/npm/npm/issues/6565)\r\n\r\n### But doesn't this upgrade React?\r\nNo. This only adds `react` as a dev dependency to remove the NPM warnings. It does not change how `stripes` platforms consume `ui-developer`.\r\n\r\nBecause this repo doesn't have a lockfile, a `npm install` inside of it would've resolved to the same `react@16.5.0` both before and after this change.  This repo's stated peer dependency on React is `*`, which specifies that it should work on any version of React (that's probably an incorrect statement, but we can adjust the peer dependency statements later to use `>=` and `||` instead). A `stripes` platform that includes `ui-developer` but has React locked into `16.3.0` would run `ui-developer` on `16.3.0`. A fresh `stripes` platform without a lockfile would run `ui-developer` on React `16.5.0`, since that's what the `stripes-core` `react@^16.3.0` would resolve to.\r\n","created_at":"2018-09-10T15:31:46Z","updated_at":"2018-09-12T17:15:47Z","closed_at":"2018-09-12T17:15:47Z","merged_at":"2018-09-12T17:15:47Z","merge_commit_sha":"25d2e6d5865c3a21b10bd0ed62495ddb66827d66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/ui-developer/pulls/21/commits","review_comments_url":"https://api.github.com/repos/folio-org/ui-developer/pulls/21/comments","review_comment_url":"https://api.github.com/repos/folio-org/ui-developer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/ui-developer/issues/21/comments","statuses_url":"https://api.github.com/repos/folio-org/ui-developer/statuses/96d09db94afe47b9740a5da8e881ca39a3856466","head":{"label":"frontside-folio:jc/dependency-cleanup","ref":"jc/dependency-cleanup","sha":"96d09db94afe47b9740a5da8e881ca39a3856466","user":{"login":"frontside-folio","id":43039268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDM5MjY4","avatar_url":"https://avatars1.githubusercontent.com/u/43039268?v=4","gravatar_id":"","url":"https://api.github.com/users/frontside-folio","html_url":"https://github.com/frontside-folio","followers_url":"https://api.github.com/users/frontside-folio/followers","following_url":"https://api.github.com/users/frontside-folio/following{/other_user}","gists_url":"https://api.github.com/users/frontside-folio/gists{/gist_id}","starred_url":"https://api.github.com/users/frontside-folio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frontside-folio/subscriptions","organizations_url":"https://api.github.com/users/frontside-folio/orgs","repos_url":"https://api.github.com/users/frontside-folio/repos","events_url":"https://api.github.com/users/frontside-folio/events{/privacy}","received_events_url":"https://api.github.com/users/frontside-folio/received_events","type":"Organization","site_admin":false},"repo":{"id":148172709,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxNzI3MDk=","name":"ui-developer","full_name":"frontside-folio/ui-developer","owner":{"login":"frontside-folio","id":43039268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMDM5MjY4","avatar_url":"https://avatars1.githubusercontent.com/u/43039268?v=4","gravatar_id":"","url":"https://api.github.com/users/frontside-folio","html_url":"https://github.com/frontside-folio","followers_url":"https://api.github.com/users/frontside-folio/followers","following_url":"https://api.github.com/users/frontside-folio/following{/other_user}","gists_url":"https://api.github.com/users/frontside-folio/gists{/gist_id}","starred_url":"https://api.github.com/users/frontside-folio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frontside-folio/subscriptions","organizations_url":"https://api.github.com/users/frontside-folio/orgs","repos_url":"https://api.github.com/users/frontside-folio/repos","events_url":"https://api.github.com/users/frontside-folio/events{/privacy}","received_events_url":"https://api.github.com/users/frontside-folio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frontside-folio/ui-developer","description":"Stripes UI module: developer facilities","fork":true,"url":"https://api.github.com/repos/frontside-folio/ui-developer","forks_url":"https://api.github.com/repos/frontside-folio/ui-developer/forks","keys_url":"https://api.github.com/repos/frontside-folio/ui-developer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frontside-folio/ui-developer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frontside-folio/ui-developer/teams","hooks_url":"https://api.github.com/repos/frontside-folio/ui-developer/hooks","issue_events_url":"https://api.github.com/repos/frontside-folio/ui-developer/issues/events{/number}","events_url":"https://api.github.com/repos/frontside-folio/ui-developer/events","assignees_url":"https://api.github.com/repos/frontside-folio/ui-developer/assignees{/user}","branches_url":"https://api.github.com/repos/frontside-folio/ui-developer/branches{/branch}","tags_url":"https://api.github.com/repos/frontside-folio/ui-developer/tags","blobs_url":"https://api.github.com/repos/frontside-folio/ui-developer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frontside-folio/ui-developer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frontside-folio/ui-developer/git/refs{/sha}","trees_url":"https://api.github.com/repos/frontside-folio/ui-developer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frontside-folio/ui-developer/statuses/{sha}","languages_url":"https://api.github.com/repos/frontside-folio/ui-developer/languages","stargazers_url":"https://api.github.com/repos/frontside-folio/ui-developer/stargazers","contributors_url":"https://api.github.com/repos/frontside-folio/ui-developer/contributors","subscribers_url":"https://api.github.com/repos/frontside-folio/ui-developer/subscribers","subscription_url":"https://api.github.com/repos/frontside-folio/ui-developer/subscription","commits_url":"https://api.github.com/repos/frontside-folio/ui-developer/commits{/sha}","git_commits_url":"https://api.github.com/repos/frontside-folio/ui-developer/git/commits{/sha}","comments_url":"https://api.github.com/repos/frontside-folio/ui-developer/comments{/number}","issue_comment_url":"https://api.github.com/repos/frontside-folio/ui-developer/issues/comments{/number}","contents_url":"https://api.github.com/repos/frontside-folio/ui-developer/contents/{+path}","compare_url":"https://api.github.com/repos/frontside-folio/ui-developer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frontside-folio/ui-developer/merges","archive_url":"https://api.github.com/repos/frontside-folio/ui-developer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frontside-folio/ui-developer/downloads","issues_url":"https://api.github.com/repos/frontside-folio/ui-developer/issues{/number}","pulls_url":"https://api.github.com/repos/frontside-folio/ui-developer/pulls{/number}","milestones_url":"https://api.github.com/repos/frontside-folio/ui-developer/milestones{/number}","notifications_url":"https://api.github.com/repos/frontside-folio/ui-developer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frontside-folio/ui-developer/labels{/name}","releases_url":"https://api.github.com/repos/frontside-folio/ui-developer/releases{/id}","deployments_url":"https://api.github.com/repos/frontside-folio/ui-developer/deployments","created_at":"2018-09-10T14:59:10Z","updated_at":"2018-09-10T14:59:12Z","pushed_at":"2018-09-12T15:58:03Z","git_url":"git://github.com/frontside-folio/ui-developer.git","ssh_url":"git@github.com:frontside-folio/ui-developer.git","clone_url":"https://github.com/frontside-folio/ui-developer.git","svn_url":"https://github.com/frontside-folio/ui-developer","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"5301070575cd7806e21a76b17b399172049c3519","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":92083281,"node_id":"MDEwOlJlcG9zaXRvcnk5MjA4MzI4MQ==","name":"ui-developer","full_name":"folio-org/ui-developer","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/ui-developer","description":"Stripes UI module: developer facilities","fork":false,"url":"https://api.github.com/repos/folio-org/ui-developer","forks_url":"https://api.github.com/repos/folio-org/ui-developer/forks","keys_url":"https://api.github.com/repos/folio-org/ui-developer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/ui-developer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/ui-developer/teams","hooks_url":"https://api.github.com/repos/folio-org/ui-developer/hooks","issue_events_url":"https://api.github.com/repos/folio-org/ui-developer/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/ui-developer/events","assignees_url":"https://api.github.com/repos/folio-org/ui-developer/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/ui-developer/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/ui-developer/tags","blobs_url":"https://api.github.com/repos/folio-org/ui-developer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/ui-developer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/ui-developer/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/ui-developer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/ui-developer/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/ui-developer/languages","stargazers_url":"https://api.github.com/repos/folio-org/ui-developer/stargazers","contributors_url":"https://api.github.com/repos/folio-org/ui-developer/contributors","subscribers_url":"https://api.github.com/repos/folio-org/ui-developer/subscribers","subscription_url":"https://api.github.com/repos/folio-org/ui-developer/subscription","commits_url":"https://api.github.com/repos/folio-org/ui-developer/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/ui-developer/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/ui-developer/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/ui-developer/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/ui-developer/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/ui-developer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/ui-developer/merges","archive_url":"https://api.github.com/repos/folio-org/ui-developer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/ui-developer/downloads","issues_url":"https://api.github.com/repos/folio-org/ui-developer/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/ui-developer/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/ui-developer/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/ui-developer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/ui-developer/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/ui-developer/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/ui-developer/deployments","created_at":"2017-05-22T17:59:27Z","updated_at":"2018-09-04T08:09:40Z","pushed_at":"2018-09-12T17:15:47Z","git_url":"git://github.com/folio-org/ui-developer.git","ssh_url":"git@github.com:folio-org/ui-developer.git","clone_url":"https://github.com/folio-org/ui-developer.git","svn_url":"https://github.com/folio-org/ui-developer","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/ui-developer/pulls/21"},"html":{"href":"https://github.com/folio-org/ui-developer/pull/21"},"issue":{"href":"https://api.github.com/repos/folio-org/ui-developer/issues/21"},"comments":{"href":"https://api.github.com/repos/folio-org/ui-developer/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/ui-developer/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/ui-developer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/ui-developer/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/ui-developer/statuses/96d09db94afe47b9740a5da8e881ca39a3856466"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cherewaty","id":230597,"node_id":"MDQ6VXNlcjIzMDU5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/230597?v=4","gravatar_id":"","url":"https://api.github.com/users/cherewaty","html_url":"https://github.com/cherewaty","followers_url":"https://api.github.com/users/cherewaty/followers","following_url":"https://api.github.com/users/cherewaty/following{/other_user}","gists_url":"https://api.github.com/users/cherewaty/gists{/gist_id}","starred_url":"https://api.github.com/users/cherewaty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherewaty/subscriptions","organizations_url":"https://api.github.com/users/cherewaty/orgs","repos_url":"https://api.github.com/users/cherewaty/repos","events_url":"https://api.github.com/users/cherewaty/events{/privacy}","received_events_url":"https://api.github.com/users/cherewaty/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":39,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"cherewaty"}}