{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/comments/240870512","pull_request_review_id":183998747,"id":240870512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDg3MDUxMg==","diff_hunk":"@@ -25,52 +25,60 @@ import (\n \n \t\"github.com/golang/glog\"\n \t\"k8s.io/api/core/v1\"\n-\t\"k8s.io/kubernetes/pkg/cloudprovider\"\n \n \t\"k8s.io/cloud-provider-baiducloud/pkg/sdk/blb\"\n \t\"k8s.io/cloud-provider-baiducloud/pkg/sdk/eip\"\n \t\"k8s.io/cloud-provider-baiducloud/pkg/sdk/util\"\n \t\"k8s.io/cloud-provider-baiducloud/pkg/sdk/vpc\"\n )\n \n-const ServiceAnnotationLoadBalancerInternalVPC = \"service.beta.kubernetes.io/cce-load-balancer-internal-vpc\"\n+type AnnotationRequest struct {\n+\tLoadBalancerId          string\n+\tLoadBalancerInternalVpc string","path":"pkg/cloud-provider/load_balancer.go","position":15,"original_position":15,"commit_id":"00a91e4e2361c8effb079306b8a63d8c490bd22b","original_commit_id":"00a91e4e2361c8effb079306b8a63d8c490bd22b","user":{"login":"hello2mao","id":8265961,"node_id":"MDQ6VXNlcjgyNjU5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8265961?v=4","gravatar_id":"","url":"https://api.github.com/users/hello2mao","html_url":"https://github.com/hello2mao","followers_url":"https://api.github.com/users/hello2mao/followers","following_url":"https://api.github.com/users/hello2mao/following{/other_user}","gists_url":"https://api.github.com/users/hello2mao/gists{/gist_id}","starred_url":"https://api.github.com/users/hello2mao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hello2mao/subscriptions","organizations_url":"https://api.github.com/users/hello2mao/orgs","repos_url":"https://api.github.com/users/hello2mao/repos","events_url":"https://api.github.com/users/hello2mao/events{/privacy}","received_events_url":"https://api.github.com/users/hello2mao/received_events","type":"User","site_admin":false},"body":"Not support bool.\r\nSee: https://github.com/kubernetes/ingress-nginx/issues/1990","created_at":"2018-12-12T03:16:04Z","updated_at":"2018-12-12T03:16:05Z","html_url":"https://github.com/baidu/cloud-provider-baiducloud/pull/16#discussion_r240870512","pull_request_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/comments/240870512"},"html":{"href":"https://github.com/baidu/cloud-provider-baiducloud/pull/16#discussion_r240870512"},"pull_request":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16"}},"in_reply_to_id":240864990},"pull_request":{"url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16","id":237675523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3Njc1NTIz","html_url":"https://github.com/baidu/cloud-provider-baiducloud/pull/16","diff_url":"https://github.com/baidu/cloud-provider-baiducloud/pull/16.diff","patch_url":"https://github.com/baidu/cloud-provider-baiducloud/pull/16.patch","issue_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/16","number":16,"state":"open","locked":false,"title":"support change blb name in console","user":{"login":"hello2mao","id":8265961,"node_id":"MDQ6VXNlcjgyNjU5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8265961?v=4","gravatar_id":"","url":"https://api.github.com/users/hello2mao","html_url":"https://github.com/hello2mao","followers_url":"https://api.github.com/users/hello2mao/followers","following_url":"https://api.github.com/users/hello2mao/following{/other_user}","gists_url":"https://api.github.com/users/hello2mao/gists{/gist_id}","starred_url":"https://api.github.com/users/hello2mao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hello2mao/subscriptions","organizations_url":"https://api.github.com/users/hello2mao/orgs","repos_url":"https://api.github.com/users/hello2mao/repos","events_url":"https://api.github.com/users/hello2mao/events{/privacy}","received_events_url":"https://api.github.com/users/hello2mao/received_events","type":"User","site_admin":false},"body":"This pr:\r\n(1)support change blb name in console\r\n(2)add blb id to Service annotation","created_at":"2018-12-11T13:17:26Z","updated_at":"2018-12-12T03:16:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db2efafaf16535ae3951e360a01b5447a1e2af43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16/commits","review_comments_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16/comments","review_comment_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/16/comments","statuses_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/statuses/00a91e4e2361c8effb079306b8a63d8c490bd22b","head":{"label":"hello2mao:support-blb-change-name","ref":"support-blb-change-name","sha":"00a91e4e2361c8effb079306b8a63d8c490bd22b","user":{"login":"hello2mao","id":8265961,"node_id":"MDQ6VXNlcjgyNjU5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8265961?v=4","gravatar_id":"","url":"https://api.github.com/users/hello2mao","html_url":"https://github.com/hello2mao","followers_url":"https://api.github.com/users/hello2mao/followers","following_url":"https://api.github.com/users/hello2mao/following{/other_user}","gists_url":"https://api.github.com/users/hello2mao/gists{/gist_id}","starred_url":"https://api.github.com/users/hello2mao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hello2mao/subscriptions","organizations_url":"https://api.github.com/users/hello2mao/orgs","repos_url":"https://api.github.com/users/hello2mao/repos","events_url":"https://api.github.com/users/hello2mao/events{/privacy}","received_events_url":"https://api.github.com/users/hello2mao/received_events","type":"User","site_admin":false},"repo":{"id":148082416,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgwODI0MTY=","name":"cloud-provider-baiducloud","full_name":"hello2mao/cloud-provider-baiducloud","private":false,"owner":{"login":"hello2mao","id":8265961,"node_id":"MDQ6VXNlcjgyNjU5NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8265961?v=4","gravatar_id":"","url":"https://api.github.com/users/hello2mao","html_url":"https://github.com/hello2mao","followers_url":"https://api.github.com/users/hello2mao/followers","following_url":"https://api.github.com/users/hello2mao/following{/other_user}","gists_url":"https://api.github.com/users/hello2mao/gists{/gist_id}","starred_url":"https://api.github.com/users/hello2mao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hello2mao/subscriptions","organizations_url":"https://api.github.com/users/hello2mao/orgs","repos_url":"https://api.github.com/users/hello2mao/repos","events_url":"https://api.github.com/users/hello2mao/events{/privacy}","received_events_url":"https://api.github.com/users/hello2mao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hello2mao/cloud-provider-baiducloud","description":"Baidu Cloud Container Engine on Kubernetes","fork":true,"url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud","forks_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/forks","keys_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/teams","hooks_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/hooks","issue_events_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/issues/events{/number}","events_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/events","assignees_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/assignees{/user}","branches_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/branches{/branch}","tags_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/tags","blobs_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/statuses/{sha}","languages_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/languages","stargazers_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/stargazers","contributors_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/contributors","subscribers_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/subscribers","subscription_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/subscription","commits_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/contents/{+path}","compare_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/merges","archive_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/downloads","issues_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/issues{/number}","pulls_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/pulls{/number}","milestones_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/milestones{/number}","notifications_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/labels{/name}","releases_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/releases{/id}","deployments_url":"https://api.github.com/repos/hello2mao/cloud-provider-baiducloud/deployments","created_at":"2018-09-10T01:28:34Z","updated_at":"2018-12-11T05:22:11Z","pushed_at":"2018-12-12T01:33:11Z","git_url":"git://github.com/hello2mao/cloud-provider-baiducloud.git","ssh_url":"git@github.com:hello2mao/cloud-provider-baiducloud.git","clone_url":"https://github.com/hello2mao/cloud-provider-baiducloud.git","svn_url":"https://github.com/hello2mao/cloud-provider-baiducloud","homepage":"https://cloud.baidu.com/product/cce.html","size":8552,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"e52b6347c8b2051c4aefe709490dd9f1e4b968c0","user":{"login":"baidu","id":13245940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQ1OTQw","avatar_url":"https://avatars2.githubusercontent.com/u/13245940?v=4","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":140250001,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyNTAwMDE=","name":"cloud-provider-baiducloud","full_name":"baidu/cloud-provider-baiducloud","private":false,"owner":{"login":"baidu","id":13245940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQ1OTQw","avatar_url":"https://avatars2.githubusercontent.com/u/13245940?v=4","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/baidu/cloud-provider-baiducloud","description":"Baidu Cloud Container Engine on Kubernetes","fork":false,"url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud","forks_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/forks","keys_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/teams","hooks_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/hooks","issue_events_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/events","assignees_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/tags","blobs_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/languages","stargazers_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/stargazers","contributors_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/contributors","subscribers_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/subscribers","subscription_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/subscription","commits_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/merges","archive_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/downloads","issues_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/labels{/name}","releases_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/deployments","created_at":"2018-07-09T07:51:02Z","updated_at":"2018-12-12T02:41:06Z","pushed_at":"2018-12-12T02:41:04Z","git_url":"git://github.com/baidu/cloud-provider-baiducloud.git","ssh_url":"git@github.com:baidu/cloud-provider-baiducloud.git","clone_url":"https://github.com/baidu/cloud-provider-baiducloud.git","svn_url":"https://github.com/baidu/cloud-provider-baiducloud","homepage":"https://cloud.baidu.com/product/cce.html","size":8553,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16"},"html":{"href":"https://github.com/baidu/cloud-provider-baiducloud/pull/16"},"issue":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/16"},"comments":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/cloud-provider-baiducloud/statuses/00a91e4e2361c8effb079306b8a63d8c490bd22b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hello2mao"}}