{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/dispatch/issues/696","repository_url":"https://api.github.com/repos/vmware/dispatch","labels_url":"https://api.github.com/repos/vmware/dispatch/issues/696/labels{/name}","comments_url":"https://api.github.com/repos/vmware/dispatch/issues/696/comments","events_url":"https://api.github.com/repos/vmware/dispatch/issues/696/events","html_url":"https://github.com/vmware/dispatch/issues/696","id":374064596,"node_id":"MDU6SXNzdWUzNzQwNjQ1OTY=","number":696,"title":"Merge solo and master","user":{"login":"berndtj","id":78191,"node_id":"MDQ6VXNlcjc4MTkx","avatar_url":"https://avatars2.githubusercontent.com/u/78191?v=4","gravatar_id":"","url":"https://api.github.com/users/berndtj","html_url":"https://github.com/berndtj","followers_url":"https://api.github.com/users/berndtj/followers","following_url":"https://api.github.com/users/berndtj/following{/other_user}","gists_url":"https://api.github.com/users/berndtj/gists{/gist_id}","starred_url":"https://api.github.com/users/berndtj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndtj/subscriptions","organizations_url":"https://api.github.com/users/berndtj/orgs","repos_url":"https://api.github.com/users/berndtj/repos","events_url":"https://api.github.com/users/berndtj/events{/privacy}","received_events_url":"https://api.github.com/users/berndtj/received_events","type":"User","site_admin":false},"labels":[{"id":1080902263,"node_id":"MDU6TGFiZWwxMDgwOTAyMjYz","url":"https://api.github.com/repos/vmware/dispatch/labels/Solo","name":"Solo","color":"6de8cb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-10-25T18:02:08Z","updated_at":"2018-10-29T18:08:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Feature Request\r\n\r\n### Detailed Description\r\n<!--- Provide a detailed description of the change or addition you are proposing -->\r\nThe two repositories have as of yet not diverged much.  Is there any downside to merge solo into master and delete the solo branch?  We could cut a v0.1.x branch to preserve master as-is, but I'm not sure we need to yet.  The downside is that we may break compatibility with current (master) dispatch in the near future as we add features and align with Knative.  However, right now, we should be pointing folks towards dispatch-solo as it's a good way to get started.\r\n\r\nThe second question is if we should remove k8s support from solo then?  Or if that support should change?  This is debatable as it largely depends on the maturity of Knative and the dispatch-Knative branch.\r\n\r\n### Context\r\n<!--- Why is this change important to you? How would you use it? -->\r\n<!--- How can it benefit other users? -->\r\n\r\n### Possible Implementation\r\n<!--- Not obligatory, but suggest an idea for implementing addition or change -->\r\n\r\n### Complexity\r\n<!--- An estimate on the complexity of the implementation -->\r\n- [ ] Low - Simple enhancement or bug fix, no architectural changes or refactoring\r\n- [ ] Medium - Change requires some thought, but is relatively isolated\r\n- [ ] High - Significant architectural change or large refactor\r\n"},"comment":{"url":"https://api.github.com/repos/vmware/dispatch/issues/comments/434018792","html_url":"https://github.com/vmware/dispatch/issues/696#issuecomment-434018792","issue_url":"https://api.github.com/repos/vmware/dispatch/issues/696","id":434018792,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDAxODc5Mg==","user":{"login":"tenczar","id":3571797,"node_id":"MDQ6VXNlcjM1NzE3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3571797?v=4","gravatar_id":"","url":"https://api.github.com/users/tenczar","html_url":"https://github.com/tenczar","followers_url":"https://api.github.com/users/tenczar/followers","following_url":"https://api.github.com/users/tenczar/following{/other_user}","gists_url":"https://api.github.com/users/tenczar/gists{/gist_id}","starred_url":"https://api.github.com/users/tenczar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenczar/subscriptions","organizations_url":"https://api.github.com/users/tenczar/orgs","repos_url":"https://api.github.com/users/tenczar/repos","events_url":"https://api.github.com/users/tenczar/events{/privacy}","received_events_url":"https://api.github.com/users/tenczar/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T18:08:41Z","updated_at":"2018-10-29T18:08:41Z","author_association":"CONTRIBUTOR","body":"I also like the idea of knative as master and removing k8s from solo. My only concern is making sure that changes to the cli don't break e2e tests in the knative or solo repos. "}}
{"actor":{"display_login":"tenczar"}}