{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/186462762","pull_request_review_id":118044888,"id":186462762,"diff_hunk":"@@ -16,9 +16,9 @@ you'll be able to access the UI at <http://localhost:8080>.\n Our UI is compiled using a collection of tools that depends on\n [Node.js](https://nodejs.org/) and are managed with\n [Yarn](https://yarnpkg.com), a package manager that offers more deterministic\n-package installation than NPM. NodeJS 6.x and Yarn 0.22.0 are known to work.\n-[Chrome](https://www.google.com/chrome/), Google's internet browser. Unit tests\n-are run using Chrome's \"Headless\" mode.\n+package installation than NPM. NodeJS 8.4.x and Yarn 1.3.x are known to work.","path":"pkg/ui/README.md","position":7,"original_position":7,"commit_id":"d0f8c7f4ef9423759ce45503d0e0eb8866ebebf1","original_commit_id":"d0f8c7f4ef9423759ce45503d0e0eb8866ebebf1","user":{"login":"couchand","id":793969,"avatar_url":"https://avatars1.githubusercontent.com/u/793969?v=4","gravatar_id":"","url":"https://api.github.com/users/couchand","html_url":"https://github.com/couchand","followers_url":"https://api.github.com/users/couchand/followers","following_url":"https://api.github.com/users/couchand/following{/other_user}","gists_url":"https://api.github.com/users/couchand/gists{/gist_id}","starred_url":"https://api.github.com/users/couchand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchand/subscriptions","organizations_url":"https://api.github.com/users/couchand/orgs","repos_url":"https://api.github.com/users/couchand/repos","events_url":"https://api.github.com/users/couchand/events{/privacy}","received_events_url":"https://api.github.com/users/couchand/received_events","type":"User","site_admin":false},"body":"Unlike internal dep bumps, I don't think we want to push required versions on externally-installed build tools unless we've got a compelling reason for the change.  Also we don't want to change the builder image until we bump the required version, otherwise there's a good chance we'll accidentally push the required version later without noticing it (consider the accidental upgrade to go 1.10 as an example).\r\n\r\nThere may be a reasonable argument for `yarn` even if not for `node`.\r\n\r\nIn any case, we'll want to send an alert to the mailing list to make sure people are warned ahead of a build change requiring a manual upgrade.","created_at":"2018-05-07T15:42:53Z","updated_at":"2018-05-07T15:42:53Z","html_url":"https://github.com/cockroachdb/cockroach/pull/25288#discussion_r186462762","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/186462762"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/25288#discussion_r186462762"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288"}},"in_reply_to_id":185897889},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288","id":185800927,"html_url":"https://github.com/cockroachdb/cockroach/pull/25288","diff_url":"https://github.com/cockroachdb/cockroach/pull/25288.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/25288.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25288","number":25288,"state":"open","locked":false,"title":"ui: readme: update known-to-work yarn and node versions","user":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-03T18:31:36Z","updated_at":"2018-05-07T15:42:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68dfbcc83d15dbc52d3148d9bb98253515e48335","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"admin-ui-prs","id":2437989,"slug":"admin-ui-prs","description":"Join this team for notifications about Admin UI PRs","privacy":"closed","url":"https://api.github.com/teams/2437989","members_url":"https://api.github.com/teams/2437989/members{/member}","repositories_url":"https://api.github.com/teams/2437989/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/25288/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d0f8c7f4ef9423759ce45503d0e0eb8866ebebf1","head":{"label":"vilterp:update-known-ui-versions","ref":"update-known-ui-versions","sha":"d0f8c7f4ef9423759ce45503d0e0eb8866ebebf1","user":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"repo":{"id":102527042,"name":"cockroach","full_name":"vilterp/cockroach","owner":{"login":"vilterp","id":7341,"avatar_url":"https://avatars3.githubusercontent.com/u/7341?v=4","gravatar_id":"","url":"https://api.github.com/users/vilterp","html_url":"https://github.com/vilterp","followers_url":"https://api.github.com/users/vilterp/followers","following_url":"https://api.github.com/users/vilterp/following{/other_user}","gists_url":"https://api.github.com/users/vilterp/gists{/gist_id}","starred_url":"https://api.github.com/users/vilterp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilterp/subscriptions","organizations_url":"https://api.github.com/users/vilterp/orgs","repos_url":"https://api.github.com/users/vilterp/repos","events_url":"https://api.github.com/users/vilterp/events{/privacy}","received_events_url":"https://api.github.com/users/vilterp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilterp/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/vilterp/cockroach","forks_url":"https://api.github.com/repos/vilterp/cockroach/forks","keys_url":"https://api.github.com/repos/vilterp/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilterp/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilterp/cockroach/teams","hooks_url":"https://api.github.com/repos/vilterp/cockroach/hooks","issue_events_url":"https://api.github.com/repos/vilterp/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/vilterp/cockroach/events","assignees_url":"https://api.github.com/repos/vilterp/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/vilterp/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/vilterp/cockroach/tags","blobs_url":"https://api.github.com/repos/vilterp/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilterp/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilterp/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilterp/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilterp/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/vilterp/cockroach/languages","stargazers_url":"https://api.github.com/repos/vilterp/cockroach/stargazers","contributors_url":"https://api.github.com/repos/vilterp/cockroach/contributors","subscribers_url":"https://api.github.com/repos/vilterp/cockroach/subscribers","subscription_url":"https://api.github.com/repos/vilterp/cockroach/subscription","commits_url":"https://api.github.com/repos/vilterp/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilterp/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilterp/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilterp/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/vilterp/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/vilterp/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilterp/cockroach/merges","archive_url":"https://api.github.com/repos/vilterp/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilterp/cockroach/downloads","issues_url":"https://api.github.com/repos/vilterp/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/vilterp/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/vilterp/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/vilterp/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilterp/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/vilterp/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/vilterp/cockroach/deployments","created_at":"2017-09-05T20:31:48Z","updated_at":"2017-09-05T20:31:58Z","pushed_at":"2018-05-04T23:23:56Z","git_url":"git://github.com/vilterp/cockroach.git","ssh_url":"git@github.com:vilterp/cockroach.git","clone_url":"https://github.com/vilterp/cockroach.git","svn_url":"https://github.com/vilterp/cockroach","homepage":"https://www.cockroachlabs.com","size":515343,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"4a36c2b111254c3bd14ff4b737258f6a3a0ae3bd","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-05-07T14:43:05Z","pushed_at":"2018-05-07T15:41:24Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":983157,"stargazers_count":13352,"watchers_count":13352,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1375,"mirror_url":null,"archived":false,"open_issues_count":1676,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1375,"open_issues":1676,"watchers":13352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/25288"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/25288"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/25288/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/25288/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d0f8c7f4ef9423759ce45503d0e0eb8866ebebf1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"couchand"}}