{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/234727327","pull_request_review_id":176429694,"id":234727327,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDcyNzMyNw==","diff_hunk":"@@ -0,0 +1,78 @@\n+// Copyright 2018 The Go Cloud Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     https://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+// Package retry provides retry logic.\n+package retry\n+\n+import (\n+\t\"context\"\n+\t\"fmt\"\n+\t\"time\"\n+\n+\tgax \"github.com/googleapis/gax-go\"\n+)\n+\n+// Call calls the supplied function f repeatedly, using the isRetryable function and\n+// the provided backoff parameters to control the repetition.\n+//\n+// When f returns nil, Call immediately returns nil.\n+//\n+// When f returns an error for which isRetryable returns false, Call immediately\n+// returns that error.\n+//\n+// When f returns an error for which isRetryable returns true, Call sleeps for the\n+// duration provided by isRetryable, or the provided backoff value if that duration\n+// is zero, and invokes f again.\n+//\n+// When the provided context is done, Retry returns with an error that\n+// includes both ctx.Error() and the last error returned by f, if any.\n+func Call(ctx context.Context, bo gax.Backoff, isRetryable func(error) (bool, time.Duration), f func() error) error {","path":"internal/retry/retry.go","position":40,"original_position":40,"commit_id":"2bba2f4cbca02359277ae92e4f570d12a30afc11","original_commit_id":"2bba2f4cbca02359277ae92e4f570d12a30afc11","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"body":"Are there multiple options for gax.Backoff? (i.e., is it necessary to expose this, or could it be created internally?)","created_at":"2018-11-19T18:17:07Z","updated_at":"2018-11-19T18:19:50Z","html_url":"https://github.com/google/go-cloud/pull/751#discussion_r234727327","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/751","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/234727327"},"html":{"href":"https://github.com/google/go-cloud/pull/751#discussion_r234727327"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/751"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/751","id":231740544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzQwNTQ0","html_url":"https://github.com/google/go-cloud/pull/751","diff_url":"https://github.com/google/go-cloud/pull/751.diff","patch_url":"https://github.com/google/go-cloud/pull/751.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/751","number":751,"state":"closed","locked":false,"title":"internal/retry: a package for retrying calls","user":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"body":"Fixes #730.","created_at":"2018-11-17T17:38:13Z","updated_at":"2018-11-19T18:19:50Z","closed_at":"2018-11-19T17:00:10Z","merged_at":"2018-11-19T17:00:10Z","merge_commit_sha":"0061891a35ee3bd2e9f184bfa5c589a7999c1588","assignee":{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ijt","id":15530,"node_id":"MDQ6VXNlcjE1NTMw","avatar_url":"https://avatars0.githubusercontent.com/u/15530?v=4","gravatar_id":"","url":"https://api.github.com/users/ijt","html_url":"https://github.com/ijt","followers_url":"https://api.github.com/users/ijt/followers","following_url":"https://api.github.com/users/ijt/following{/other_user}","gists_url":"https://api.github.com/users/ijt/gists{/gist_id}","starred_url":"https://api.github.com/users/ijt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijt/subscriptions","organizations_url":"https://api.github.com/users/ijt/orgs","repos_url":"https://api.github.com/users/ijt/repos","events_url":"https://api.github.com/users/ijt/events{/privacy}","received_events_url":"https://api.github.com/users/ijt/received_events","type":"User","site_admin":false},{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/751/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/751/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/751/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/2bba2f4cbca02359277ae92e4f570d12a30afc11","head":{"label":"jba:retry","ref":"retry","sha":"2bba2f4cbca02359277ae92e4f570d12a30afc11","user":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"repo":{"id":154330358,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzMzAzNTg=","name":"go-cloud","full_name":"jba/go-cloud","private":false,"owner":{"login":"jba","id":18483045,"node_id":"MDQ6VXNlcjE4NDgzMDQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18483045?v=4","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jba/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/jba/go-cloud","forks_url":"https://api.github.com/repos/jba/go-cloud/forks","keys_url":"https://api.github.com/repos/jba/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jba/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jba/go-cloud/teams","hooks_url":"https://api.github.com/repos/jba/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/jba/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/jba/go-cloud/events","assignees_url":"https://api.github.com/repos/jba/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/jba/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/jba/go-cloud/tags","blobs_url":"https://api.github.com/repos/jba/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jba/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jba/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/jba/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jba/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/jba/go-cloud/languages","stargazers_url":"https://api.github.com/repos/jba/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/jba/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/jba/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/jba/go-cloud/subscription","commits_url":"https://api.github.com/repos/jba/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/jba/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/jba/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/jba/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/jba/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/jba/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jba/go-cloud/merges","archive_url":"https://api.github.com/repos/jba/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jba/go-cloud/downloads","issues_url":"https://api.github.com/repos/jba/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/jba/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/jba/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/jba/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jba/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/jba/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/jba/go-cloud/deployments","created_at":"2018-10-23T13:12:21Z","updated_at":"2018-10-23T13:12:24Z","pushed_at":"2018-11-19T16:42:54Z","git_url":"git://github.com/jba/go-cloud.git","ssh_url":"git@github.com:jba/go-cloud.git","clone_url":"https://github.com/jba/go-cloud.git","svn_url":"https://github.com/jba/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18694,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"752f53caf6a49658f4fcbad2a9d08e0583a136fb","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2018-11-19T17:00:13Z","pushed_at":"2018-11-19T17:00:11Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18673,"stargazers_count":4986,"watchers_count":4986,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":271,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":271,"open_issues":101,"watchers":4986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/751"},"html":{"href":"https://github.com/google/go-cloud/pull/751"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/751"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/751/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/751/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/751/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/2bba2f4cbca02359277ae92e4f570d12a30afc11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vangent"}}