{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/224556877","pull_request_review_id":163954786,"id":224556877,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU1Njg3Nw==","diff_hunk":"@@ -443,15 +443,95 @@ public void testUnassignedWithNoTServers() {\n     for (TServerInstance r : removals) {\n       current.remove(r);\n     }\n-    this.getAssignments(Collections.unmodifiableSortedMap(allTabletServers),\n+    this.getAssignments(Collections.unmodifiableSortedMap(current),","path":"server/base/src/test/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancerTest.java","position":5,"original_position":5,"commit_id":"62f0c1295f71b63e0cbd806f5ebff8131436f542","original_commit_id":"62f0c1295f71b63e0cbd806f5ebff8131436f542","user":{"login":"adamjshook","id":1372828,"node_id":"MDQ6VXNlcjEzNzI4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1372828?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjshook","html_url":"https://github.com/adamjshook","followers_url":"https://api.github.com/users/adamjshook/followers","following_url":"https://api.github.com/users/adamjshook/following{/other_user}","gists_url":"https://api.github.com/users/adamjshook/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjshook/subscriptions","organizations_url":"https://api.github.com/users/adamjshook/orgs","repos_url":"https://api.github.com/users/adamjshook/repos","events_url":"https://api.github.com/users/adamjshook/events{/privacy}","received_events_url":"https://api.github.com/users/adamjshook/received_events","type":"User","site_admin":false},"body":"I think this is an issue with the existing test?  My understanding is we want to pass in a partial set of the TServers.","created_at":"2018-10-11T18:30:39Z","updated_at":"2018-10-11T18:30:40Z","html_url":"https://github.com/apache/accumulo/pull/691#discussion_r224556877","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/691","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/224556877"},"html":{"href":"https://github.com/apache/accumulo/pull/691#discussion_r224556877"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/691"}}},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/691","id":222234199,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjM0MTk5","html_url":"https://github.com/apache/accumulo/pull/691","diff_url":"https://github.com/apache/accumulo/pull/691.diff","patch_url":"https://github.com/apache/accumulo/pull/691.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/691","number":691,"state":"open","locked":false,"title":"Assign tablets to random pool if no default","user":{"login":"adamjshook","id":1372828,"node_id":"MDQ6VXNlcjEzNzI4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1372828?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjshook","html_url":"https://github.com/adamjshook","followers_url":"https://api.github.com/users/adamjshook/followers","following_url":"https://api.github.com/users/adamjshook/following{/other_user}","gists_url":"https://api.github.com/users/adamjshook/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjshook/subscriptions","organizations_url":"https://api.github.com/users/adamjshook/orgs","repos_url":"https://api.github.com/users/adamjshook/repos","events_url":"https://api.github.com/users/adamjshook/events{/privacy}","received_events_url":"https://api.github.com/users/adamjshook/received_events","type":"User","site_admin":false},"body":"This addresses an issue when using the `HostRegexTableLoadBalancer` when the default pool is empty.  The load balancer will not assign the tablets at all.  Here, we select a random pool to assign the tablets to.  This behavior is on by default but can be disabled via property.","created_at":"2018-10-11T18:23:06Z","updated_at":"2018-10-11T18:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7963833717cfd647fb443cc65960a248ac594610","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ctubbsii","id":1280725,"node_id":"MDQ6VXNlcjEyODA3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1280725?v=4","gravatar_id":"","url":"https://api.github.com/users/ctubbsii","html_url":"https://github.com/ctubbsii","followers_url":"https://api.github.com/users/ctubbsii/followers","following_url":"https://api.github.com/users/ctubbsii/following{/other_user}","gists_url":"https://api.github.com/users/ctubbsii/gists{/gist_id}","starred_url":"https://api.github.com/users/ctubbsii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctubbsii/subscriptions","organizations_url":"https://api.github.com/users/ctubbsii/orgs","repos_url":"https://api.github.com/users/ctubbsii/repos","events_url":"https://api.github.com/users/ctubbsii/events{/privacy}","received_events_url":"https://api.github.com/users/ctubbsii/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/691/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/691/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/691/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/62f0c1295f71b63e0cbd806f5ebff8131436f542","head":{"label":"adamjshook:regex","ref":"regex","sha":"62f0c1295f71b63e0cbd806f5ebff8131436f542","user":{"login":"adamjshook","id":1372828,"node_id":"MDQ6VXNlcjEzNzI4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1372828?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjshook","html_url":"https://github.com/adamjshook","followers_url":"https://api.github.com/users/adamjshook/followers","following_url":"https://api.github.com/users/adamjshook/following{/other_user}","gists_url":"https://api.github.com/users/adamjshook/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjshook/subscriptions","organizations_url":"https://api.github.com/users/adamjshook/orgs","repos_url":"https://api.github.com/users/adamjshook/repos","events_url":"https://api.github.com/users/adamjshook/events{/privacy}","received_events_url":"https://api.github.com/users/adamjshook/received_events","type":"User","site_admin":false},"repo":{"id":48753835,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc1MzgzNQ==","name":"accumulo","full_name":"adamjshook/accumulo","private":false,"owner":{"login":"adamjshook","id":1372828,"node_id":"MDQ6VXNlcjEzNzI4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1372828?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjshook","html_url":"https://github.com/adamjshook","followers_url":"https://api.github.com/users/adamjshook/followers","following_url":"https://api.github.com/users/adamjshook/following{/other_user}","gists_url":"https://api.github.com/users/adamjshook/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjshook/subscriptions","organizations_url":"https://api.github.com/users/adamjshook/orgs","repos_url":"https://api.github.com/users/adamjshook/repos","events_url":"https://api.github.com/users/adamjshook/events{/privacy}","received_events_url":"https://api.github.com/users/adamjshook/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adamjshook/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/adamjshook/accumulo","forks_url":"https://api.github.com/repos/adamjshook/accumulo/forks","keys_url":"https://api.github.com/repos/adamjshook/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamjshook/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamjshook/accumulo/teams","hooks_url":"https://api.github.com/repos/adamjshook/accumulo/hooks","issue_events_url":"https://api.github.com/repos/adamjshook/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/adamjshook/accumulo/events","assignees_url":"https://api.github.com/repos/adamjshook/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/adamjshook/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/adamjshook/accumulo/tags","blobs_url":"https://api.github.com/repos/adamjshook/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamjshook/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamjshook/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamjshook/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamjshook/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/adamjshook/accumulo/languages","stargazers_url":"https://api.github.com/repos/adamjshook/accumulo/stargazers","contributors_url":"https://api.github.com/repos/adamjshook/accumulo/contributors","subscribers_url":"https://api.github.com/repos/adamjshook/accumulo/subscribers","subscription_url":"https://api.github.com/repos/adamjshook/accumulo/subscription","commits_url":"https://api.github.com/repos/adamjshook/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamjshook/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamjshook/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamjshook/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamjshook/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/adamjshook/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamjshook/accumulo/merges","archive_url":"https://api.github.com/repos/adamjshook/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamjshook/accumulo/downloads","issues_url":"https://api.github.com/repos/adamjshook/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/adamjshook/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/adamjshook/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/adamjshook/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamjshook/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/adamjshook/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/adamjshook/accumulo/deployments","created_at":"2015-12-29T15:30:17Z","updated_at":"2016-08-29T14:36:28Z","pushed_at":"2018-10-11T18:12:48Z","git_url":"git://github.com/adamjshook/accumulo.git","ssh_url":"git@github.com:adamjshook/accumulo.git","clone_url":"https://github.com/adamjshook/accumulo.git","svn_url":"https://github.com/adamjshook/accumulo","homepage":"","size":61789,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"11e26d481b7885e46ce439e1345f0bf9bdd5dfb2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"node_id":"MDEwOlJlcG9zaXRvcnkyNTI0NDg4","name":"accumulo","full_name":"apache/accumulo","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/accumulo","description":"Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2018-10-11T11:25:00Z","pushed_at":"2018-10-11T18:23:07Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"https://accumulo.apache.org","size":64471,"stargazers_count":405,"watchers_count":405,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":220,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":220,"open_issues":57,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/691"},"html":{"href":"https://github.com/apache/accumulo/pull/691"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/691"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/691/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/691/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/691/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/62f0c1295f71b63e0cbd806f5ebff8131436f542"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adamjshook"}}