{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60898","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60898/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60898/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60898/events","html_url":"https://github.com/kubernetes/kubernetes/pull/60898","id":303256340,"number":60898,"title":"Add ranges field to PSP group Validate error details","user":{"login":"lnsp","id":3391295,"avatar_url":"https://avatars1.githubusercontent.com/u/3391295?v=4","gravatar_id":"","url":"https://api.github.com/users/lnsp","html_url":"https://github.com/lnsp","followers_url":"https://api.github.com/users/lnsp/followers","following_url":"https://api.github.com/users/lnsp/following{/other_user}","gists_url":"https://api.github.com/users/lnsp/gists{/gist_id}","starred_url":"https://api.github.com/users/lnsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnsp/subscriptions","organizations_url":"https://api.github.com/users/lnsp/orgs","repos_url":"https://api.github.com/users/lnsp/repos","events_url":"https://api.github.com/users/lnsp/events{/privacy}","received_events_url":"https://api.github.com/users/lnsp/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-07T20:56:59Z","updated_at":"2018-03-08T11:00:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60898","html_url":"https://github.com/kubernetes/kubernetes/pull/60898","diff_url":"https://github.com/kubernetes/kubernetes/pull/60898.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60898.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: When the PodSecurityPolicy provider validation of a `fsGroup` fails, it throws a very non-descriptive error that redundantly announces that the group ID is not allowed. Since the group ID is already contained in the error stack, this is not required. This PR fixes it by storing the allowed ranges in the error details and therefore improves the debugging experience.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #60847 \r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/371454753","html_url":"https://github.com/kubernetes/kubernetes/pull/60898#issuecomment-371454753","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60898","id":371454753,"user":{"login":"lnsp","id":3391295,"avatar_url":"https://avatars1.githubusercontent.com/u/3391295?v=4","gravatar_id":"","url":"https://api.github.com/users/lnsp","html_url":"https://github.com/lnsp","followers_url":"https://api.github.com/users/lnsp/followers","following_url":"https://api.github.com/users/lnsp/following{/other_user}","gists_url":"https://api.github.com/users/lnsp/gists{/gist_id}","starred_url":"https://api.github.com/users/lnsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnsp/subscriptions","organizations_url":"https://api.github.com/users/lnsp/orgs","repos_url":"https://api.github.com/users/lnsp/repos","events_url":"https://api.github.com/users/lnsp/events{/privacy}","received_events_url":"https://api.github.com/users/lnsp/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T11:00:15Z","updated_at":"2018-03-08T11:00:15Z","author_association":"NONE","body":"@php-coder I've added a field to the test table to verify the error output and extended the existing cases, should I add additional test cases for multiple invalid groups?"}}
{"actor":{"display_login":"lnsp"}}