{"action":"created","comment":{"url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/comments/179590985","pull_request_review_id":109865378,"id":179590985,"diff_hunk":"@@ -112,19 +112,21 @@ public function lookUpByEmail(string $email) {\n      */\n     public function findLatestContributions(User $user, int $limit = 25) {\n         $sql = <<<EOSQL\n-SELECT JSON_AGG(id) AS ids, type FROM (\n-        SELECT id, timestamp, 'comment'::TEXT AS type FROM comments WHERE user_id = :user_id\n+SELECT JSON_AGG(id) AS ids, entry_type FROM (\n+        SELECT c.id, c.timestamp, 'comment'::TEXT AS entry_type FROM comments c\n+            INNER JOIN submissions s on c.submission_id = s.id\n+        WHERE c.user_id = :user_id and s.mod_thread = false\n     UNION ALL\n-        SELECT id, timestamp, 'submission'::TEXT AS type FROM submissions WHERE user_id = :user_id\n+        SELECT id, timestamp, 'submission'::TEXT AS entry_type FROM submissions WHERE user_id = :user_id AND mod_thread = false\n     ORDER BY timestamp DESC","path":"src/Repository/UserRepository.php","position":13,"original_position":13,"commit_id":"47154ec56bfb299b3b9af3ec54a4b36b3de2decd","original_commit_id":"47154ec56bfb299b3b9af3ec54a4b36b3de2decd","user":{"login":"NathanDeckinga","id":5420612,"avatar_url":"https://avatars2.githubusercontent.com/u/5420612?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanDeckinga","html_url":"https://github.com/NathanDeckinga","followers_url":"https://api.github.com/users/NathanDeckinga/followers","following_url":"https://api.github.com/users/NathanDeckinga/following{/other_user}","gists_url":"https://api.github.com/users/NathanDeckinga/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanDeckinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanDeckinga/subscriptions","organizations_url":"https://api.github.com/users/NathanDeckinga/orgs","repos_url":"https://api.github.com/users/NathanDeckinga/repos","events_url":"https://api.github.com/users/NathanDeckinga/events{/privacy}","received_events_url":"https://api.github.com/users/NathanDeckinga/received_events","type":"User","site_admin":false},"body":"I missed that earlier - you are absolutely correct that it is.  Ignore my earlier comment about it not using the limit as well, I didn't make it down to this part of the union statement.  I think you are completely good then.","created_at":"2018-04-05T20:28:30Z","updated_at":"2018-04-05T20:28:30Z","html_url":"https://github.com/TheRealGD/therealgd/pull/166#discussion_r179590985","pull_request_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/comments/179590985"},"html":{"href":"https://github.com/TheRealGD/therealgd/pull/166#discussion_r179590985"},"pull_request":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166"}},"in_reply_to_id":179590143},"pull_request":{"url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166","id":179759241,"html_url":"https://github.com/TheRealGD/therealgd/pull/166","diff_url":"https://github.com/TheRealGD/therealgd/pull/166.diff","patch_url":"https://github.com/TheRealGD/therealgd/pull/166.patch","issue_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/166","number":166,"state":"open","locked":false,"title":"small fixes on mod forum feature","user":{"login":"nationwide13","id":22083142,"avatar_url":"https://avatars3.githubusercontent.com/u/22083142?v=4","gravatar_id":"","url":"https://api.github.com/users/nationwide13","html_url":"https://github.com/nationwide13","followers_url":"https://api.github.com/users/nationwide13/followers","following_url":"https://api.github.com/users/nationwide13/following{/other_user}","gists_url":"https://api.github.com/users/nationwide13/gists{/gist_id}","starred_url":"https://api.github.com/users/nationwide13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nationwide13/subscriptions","organizations_url":"https://api.github.com/users/nationwide13/orgs","repos_url":"https://api.github.com/users/nationwide13/repos","events_url":"https://api.github.com/users/nationwide13/events{/privacy}","received_events_url":"https://api.github.com/users/nationwide13/received_events","type":"User","site_admin":false},"body":"Finally got around to fixing this controller after @TKsM151 blew it up on me.\r\n\r\nAlso some other small fixes. Will inline other comments","created_at":"2018-04-05T18:28:54Z","updated_at":"2018-04-05T20:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db297ec3ff521eacb06542db3f30d231ab0aceb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166/commits","review_comments_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166/comments","review_comment_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/166/comments","statuses_url":"https://api.github.com/repos/TheRealGD/therealgd/statuses/47154ec56bfb299b3b9af3ec54a4b36b3de2decd","head":{"label":"TheRealGD:modforum_fixes","ref":"modforum_fixes","sha":"47154ec56bfb299b3b9af3ec54a4b36b3de2decd","user":{"login":"TheRealGD","id":37675487,"avatar_url":"https://avatars3.githubusercontent.com/u/37675487?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealGD","html_url":"https://github.com/TheRealGD","followers_url":"https://api.github.com/users/TheRealGD/followers","following_url":"https://api.github.com/users/TheRealGD/following{/other_user}","gists_url":"https://api.github.com/users/TheRealGD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealGD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealGD/subscriptions","organizations_url":"https://api.github.com/users/TheRealGD/orgs","repos_url":"https://api.github.com/users/TheRealGD/repos","events_url":"https://api.github.com/users/TheRealGD/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealGD/received_events","type":"Organization","site_admin":false},"repo":{"id":126415281,"name":"therealgd","full_name":"TheRealGD/therealgd","owner":{"login":"TheRealGD","id":37675487,"avatar_url":"https://avatars3.githubusercontent.com/u/37675487?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealGD","html_url":"https://github.com/TheRealGD","followers_url":"https://api.github.com/users/TheRealGD/followers","following_url":"https://api.github.com/users/TheRealGD/following{/other_user}","gists_url":"https://api.github.com/users/TheRealGD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealGD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealGD/subscriptions","organizations_url":"https://api.github.com/users/TheRealGD/orgs","repos_url":"https://api.github.com/users/TheRealGD/repos","events_url":"https://api.github.com/users/TheRealGD/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealGD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheRealGD/therealgd","description":null,"fork":false,"url":"https://api.github.com/repos/TheRealGD/therealgd","forks_url":"https://api.github.com/repos/TheRealGD/therealgd/forks","keys_url":"https://api.github.com/repos/TheRealGD/therealgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheRealGD/therealgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheRealGD/therealgd/teams","hooks_url":"https://api.github.com/repos/TheRealGD/therealgd/hooks","issue_events_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/events{/number}","events_url":"https://api.github.com/repos/TheRealGD/therealgd/events","assignees_url":"https://api.github.com/repos/TheRealGD/therealgd/assignees{/user}","branches_url":"https://api.github.com/repos/TheRealGD/therealgd/branches{/branch}","tags_url":"https://api.github.com/repos/TheRealGD/therealgd/tags","blobs_url":"https://api.github.com/repos/TheRealGD/therealgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheRealGD/therealgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheRealGD/therealgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheRealGD/therealgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheRealGD/therealgd/statuses/{sha}","languages_url":"https://api.github.com/repos/TheRealGD/therealgd/languages","stargazers_url":"https://api.github.com/repos/TheRealGD/therealgd/stargazers","contributors_url":"https://api.github.com/repos/TheRealGD/therealgd/contributors","subscribers_url":"https://api.github.com/repos/TheRealGD/therealgd/subscribers","subscription_url":"https://api.github.com/repos/TheRealGD/therealgd/subscription","commits_url":"https://api.github.com/repos/TheRealGD/therealgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheRealGD/therealgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheRealGD/therealgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheRealGD/therealgd/contents/{+path}","compare_url":"https://api.github.com/repos/TheRealGD/therealgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheRealGD/therealgd/merges","archive_url":"https://api.github.com/repos/TheRealGD/therealgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheRealGD/therealgd/downloads","issues_url":"https://api.github.com/repos/TheRealGD/therealgd/issues{/number}","pulls_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls{/number}","milestones_url":"https://api.github.com/repos/TheRealGD/therealgd/milestones{/number}","notifications_url":"https://api.github.com/repos/TheRealGD/therealgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheRealGD/therealgd/labels{/name}","releases_url":"https://api.github.com/repos/TheRealGD/therealgd/releases{/id}","deployments_url":"https://api.github.com/repos/TheRealGD/therealgd/deployments","created_at":"2018-03-23T01:23:39Z","updated_at":"2018-04-05T06:36:08Z","pushed_at":"2018-04-05T19:46:29Z","git_url":"git://github.com/TheRealGD/therealgd.git","ssh_url":"git@github.com:TheRealGD/therealgd.git","clone_url":"https://github.com/TheRealGD/therealgd.git","svn_url":"https://github.com/TheRealGD/therealgd","homepage":null,"size":2229,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib"},"forks":7,"open_issues":49,"watchers":7,"default_branch":"develop"}},"base":{"label":"TheRealGD:develop","ref":"develop","sha":"f8f897f836d6d6cb74b401a68aa8eb27ca0aff9e","user":{"login":"TheRealGD","id":37675487,"avatar_url":"https://avatars3.githubusercontent.com/u/37675487?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealGD","html_url":"https://github.com/TheRealGD","followers_url":"https://api.github.com/users/TheRealGD/followers","following_url":"https://api.github.com/users/TheRealGD/following{/other_user}","gists_url":"https://api.github.com/users/TheRealGD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealGD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealGD/subscriptions","organizations_url":"https://api.github.com/users/TheRealGD/orgs","repos_url":"https://api.github.com/users/TheRealGD/repos","events_url":"https://api.github.com/users/TheRealGD/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealGD/received_events","type":"Organization","site_admin":false},"repo":{"id":126415281,"name":"therealgd","full_name":"TheRealGD/therealgd","owner":{"login":"TheRealGD","id":37675487,"avatar_url":"https://avatars3.githubusercontent.com/u/37675487?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealGD","html_url":"https://github.com/TheRealGD","followers_url":"https://api.github.com/users/TheRealGD/followers","following_url":"https://api.github.com/users/TheRealGD/following{/other_user}","gists_url":"https://api.github.com/users/TheRealGD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealGD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealGD/subscriptions","organizations_url":"https://api.github.com/users/TheRealGD/orgs","repos_url":"https://api.github.com/users/TheRealGD/repos","events_url":"https://api.github.com/users/TheRealGD/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealGD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheRealGD/therealgd","description":null,"fork":false,"url":"https://api.github.com/repos/TheRealGD/therealgd","forks_url":"https://api.github.com/repos/TheRealGD/therealgd/forks","keys_url":"https://api.github.com/repos/TheRealGD/therealgd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheRealGD/therealgd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheRealGD/therealgd/teams","hooks_url":"https://api.github.com/repos/TheRealGD/therealgd/hooks","issue_events_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/events{/number}","events_url":"https://api.github.com/repos/TheRealGD/therealgd/events","assignees_url":"https://api.github.com/repos/TheRealGD/therealgd/assignees{/user}","branches_url":"https://api.github.com/repos/TheRealGD/therealgd/branches{/branch}","tags_url":"https://api.github.com/repos/TheRealGD/therealgd/tags","blobs_url":"https://api.github.com/repos/TheRealGD/therealgd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheRealGD/therealgd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheRealGD/therealgd/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheRealGD/therealgd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheRealGD/therealgd/statuses/{sha}","languages_url":"https://api.github.com/repos/TheRealGD/therealgd/languages","stargazers_url":"https://api.github.com/repos/TheRealGD/therealgd/stargazers","contributors_url":"https://api.github.com/repos/TheRealGD/therealgd/contributors","subscribers_url":"https://api.github.com/repos/TheRealGD/therealgd/subscribers","subscription_url":"https://api.github.com/repos/TheRealGD/therealgd/subscription","commits_url":"https://api.github.com/repos/TheRealGD/therealgd/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheRealGD/therealgd/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheRealGD/therealgd/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheRealGD/therealgd/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheRealGD/therealgd/contents/{+path}","compare_url":"https://api.github.com/repos/TheRealGD/therealgd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheRealGD/therealgd/merges","archive_url":"https://api.github.com/repos/TheRealGD/therealgd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheRealGD/therealgd/downloads","issues_url":"https://api.github.com/repos/TheRealGD/therealgd/issues{/number}","pulls_url":"https://api.github.com/repos/TheRealGD/therealgd/pulls{/number}","milestones_url":"https://api.github.com/repos/TheRealGD/therealgd/milestones{/number}","notifications_url":"https://api.github.com/repos/TheRealGD/therealgd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheRealGD/therealgd/labels{/name}","releases_url":"https://api.github.com/repos/TheRealGD/therealgd/releases{/id}","deployments_url":"https://api.github.com/repos/TheRealGD/therealgd/deployments","created_at":"2018-03-23T01:23:39Z","updated_at":"2018-04-05T06:36:08Z","pushed_at":"2018-04-05T19:46:29Z","git_url":"git://github.com/TheRealGD/therealgd.git","ssh_url":"git@github.com:TheRealGD/therealgd.git","clone_url":"https://github.com/TheRealGD/therealgd.git","svn_url":"https://github.com/TheRealGD/therealgd","homepage":null,"size":2229,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib"},"forks":7,"open_issues":49,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166"},"html":{"href":"https://github.com/TheRealGD/therealgd/pull/166"},"issue":{"href":"https://api.github.com/repos/TheRealGD/therealgd/issues/166"},"comments":{"href":"https://api.github.com/repos/TheRealGD/therealgd/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheRealGD/therealgd/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/TheRealGD/therealgd/statuses/47154ec56bfb299b3b9af3ec54a4b36b3de2decd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"NathanDeckinga"}}