{"action":"opened","number":2070,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070","id":171953464,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2070","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2070.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2070.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2070","number":2070,"state":"open","locked":false,"title":"Implement global app props for tasks","user":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars1.githubusercontent.com/u/50398?v=4","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"body":"- It turned out that CommonApplicationProperties only\r\n  have key for streams while documentation gives example\r\n  for tasks as well.\r\n- Add space for tasks and modify all needed tests.\r\n- DefaultTaskServiceTests have modified test showing global\r\n  pring.cloud.dataflow.applicationProperties.task.app.composed-task-runner.globalkey=globalvalue\r\n  added to context.\r\n- DefaultTaskService.extractAppProperties() now gets entries from global space as well\r\n  and same filtering per task app name which is same logic as how stream apps use.\r\n- i.e. --spring.cloud.dataflow.applicationProperties.task.app.timestamp.format=yyyy\r\n  would work with timestamp task.\r\n- Fixes #1531","created_at":"2018-02-28T13:30:44Z","updated_at":"2018-02-28T13:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2070/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f790030fcef1a6eb1445a6c5dc019d27aa5aa5fd","head":{"label":"jvalkeal:gh1531","ref":"gh1531","sha":"f790030fcef1a6eb1445a6c5dc019d27aa5aa5fd","user":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars1.githubusercontent.com/u/50398?v=4","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"repo":{"id":40263722,"name":"spring-cloud-dataflow","full_name":"jvalkeal/spring-cloud-dataflow","owner":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars1.githubusercontent.com/u/50398?v=4","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvalkeal/spring-cloud-dataflow","description":null,"fork":true,"url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/deployments","created_at":"2015-08-05T19:03:25Z","updated_at":"2016-11-03T12:49:49Z","pushed_at":"2018-02-28T13:30:34Z","git_url":"git://github.com/jvalkeal/spring-cloud-dataflow.git","ssh_url":"git@github.com:jvalkeal/spring-cloud-dataflow.git","clone_url":"https://github.com/jvalkeal/spring-cloud-dataflow.git","svn_url":"https://github.com/jvalkeal/spring-cloud-dataflow","homepage":null,"size":24241,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"625252feeb28cc6240554066cbb482b95b4bfc8c","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow is a toolkit for building data integration and real-time data processing pipelines.","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/deployments","created_at":"2015-07-21T20:56:11Z","updated_at":"2018-02-27T01:33:37Z","pushed_at":"2018-02-28T10:11:46Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":27064,"stargazers_count":276,"watchers_count":276,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":185,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":194,"open_issues":185,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2070"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2070"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2070/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2070/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f790030fcef1a6eb1445a6c5dc019d27aa5aa5fd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":75,"deletions":29,"changed_files":11}}
{"actor":{"display_login":"jvalkeal"}}