{"action":"created","comment":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/185697444","pull_request_review_id":117137535,"id":185697444,"diff_hunk":"@@ -130,6 +130,13 @@ exports.formatNamedParameters = formatNamedParameters;\n function cloneDeep(obj) {\n   obj = obj || {};\n   return _.cloneDeepWith(obj, elem => {\n+    // Special handling for the inclusive array property (for range types)\n+    if (Array.isArray(elem) && elem.hasOwnProperty('inclusive')) {","path":"lib/utils.js","position":5,"original_position":5,"commit_id":"0d9a387ef3a7fa237e8d91e9b0e68664eac30474","original_commit_id":"0d9a387ef3a7fa237e8d91e9b0e68664eac30474","user":{"login":"sushantdhiman","id":9989487,"avatar_url":"https://avatars1.githubusercontent.com/u/9989487?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"body":"As we are under v5 beta process I would prefer just do one time switch to proper format, which will solve both [clone](https://github.com/sequelize/sequelize/issues/8176) and [stringify](https://github.com/sequelize/sequelize/issues/8471) issues\r\n\r\n```js\r\n[{  \r\n  value: 10,\r\n  inclusive: true\r\n}, {\r\n  value: 10,\r\n  inclusive: true\r\n}]\r\n```","created_at":"2018-05-03T05:01:06Z","updated_at":"2018-05-03T05:01:06Z","html_url":"https://github.com/sequelize/sequelize/pull/9364#discussion_r185697444","pull_request_url":"https://api.github.com/repos/sequelize/sequelize/pulls/9364","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments/185697444"},"html":{"href":"https://github.com/sequelize/sequelize/pull/9364#discussion_r185697444"},"pull_request":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9364"}},"in_reply_to_id":185539517},"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/9364","id":184548466,"html_url":"https://github.com/sequelize/sequelize/pull/9364","diff_url":"https://github.com/sequelize/sequelize/pull/9364.diff","patch_url":"https://github.com/sequelize/sequelize/pull/9364.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/9364","number":9364,"state":"open","locked":false,"title":"fix(range-bounds): observe inclusive range bounds","user":{"login":"mjy78","id":3598804,"avatar_url":"https://avatars3.githubusercontent.com/u/3598804?v=4","gravatar_id":"","url":"https://api.github.com/users/mjy78","html_url":"https://github.com/mjy78","followers_url":"https://api.github.com/users/mjy78/followers","following_url":"https://api.github.com/users/mjy78/following{/other_user}","gists_url":"https://api.github.com/users/mjy78/gists{/gist_id}","starred_url":"https://api.github.com/users/mjy78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjy78/subscriptions","organizations_url":"https://api.github.com/users/mjy78/orgs","repos_url":"https://api.github.com/users/mjy78/repos","events_url":"https://api.github.com/users/mjy78/events{/privacy}","received_events_url":"https://api.github.com/users/mjy78/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [X] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [X] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [X] Have you added new tests to prevent regressions?\r\n- [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [X] Did you follow the commit message conventions explained in [CONTRIBUTING.md](../CONTRIBUTING.md)?\r\n\r\n### Description of change\r\n\r\nEnsure the 'inclusive' property on range bounds is not lost when querying.\r\n\r\nCloses #8176 \r\n","created_at":"2018-04-27T07:49:52Z","updated_at":"2018-05-03T05:01:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52942fb17f53d0d8e6b5ac7653e43a99d02e07ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/9364/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/9364/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/9364/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/0d9a387ef3a7fa237e8d91e9b0e68664eac30474","head":{"label":"mjy78:master","ref":"master","sha":"0d9a387ef3a7fa237e8d91e9b0e68664eac30474","user":{"login":"mjy78","id":3598804,"avatar_url":"https://avatars3.githubusercontent.com/u/3598804?v=4","gravatar_id":"","url":"https://api.github.com/users/mjy78","html_url":"https://github.com/mjy78","followers_url":"https://api.github.com/users/mjy78/followers","following_url":"https://api.github.com/users/mjy78/following{/other_user}","gists_url":"https://api.github.com/users/mjy78/gists{/gist_id}","starred_url":"https://api.github.com/users/mjy78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjy78/subscriptions","organizations_url":"https://api.github.com/users/mjy78/orgs","repos_url":"https://api.github.com/users/mjy78/repos","events_url":"https://api.github.com/users/mjy78/events{/privacy}","received_events_url":"https://api.github.com/users/mjy78/received_events","type":"User","site_admin":false},"repo":{"id":131259240,"name":"sequelize","full_name":"mjy78/sequelize","owner":{"login":"mjy78","id":3598804,"avatar_url":"https://avatars3.githubusercontent.com/u/3598804?v=4","gravatar_id":"","url":"https://api.github.com/users/mjy78","html_url":"https://github.com/mjy78","followers_url":"https://api.github.com/users/mjy78/followers","following_url":"https://api.github.com/users/mjy78/following{/other_user}","gists_url":"https://api.github.com/users/mjy78/gists{/gist_id}","starred_url":"https://api.github.com/users/mjy78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjy78/subscriptions","organizations_url":"https://api.github.com/users/mjy78/orgs","repos_url":"https://api.github.com/users/mjy78/repos","events_url":"https://api.github.com/users/mjy78/events{/privacy}","received_events_url":"https://api.github.com/users/mjy78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjy78/sequelize","description":"An easy-to-use multi SQL dialect ORM for Node.js","fork":true,"url":"https://api.github.com/repos/mjy78/sequelize","forks_url":"https://api.github.com/repos/mjy78/sequelize/forks","keys_url":"https://api.github.com/repos/mjy78/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjy78/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjy78/sequelize/teams","hooks_url":"https://api.github.com/repos/mjy78/sequelize/hooks","issue_events_url":"https://api.github.com/repos/mjy78/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/mjy78/sequelize/events","assignees_url":"https://api.github.com/repos/mjy78/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/mjy78/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/mjy78/sequelize/tags","blobs_url":"https://api.github.com/repos/mjy78/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjy78/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjy78/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjy78/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjy78/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/mjy78/sequelize/languages","stargazers_url":"https://api.github.com/repos/mjy78/sequelize/stargazers","contributors_url":"https://api.github.com/repos/mjy78/sequelize/contributors","subscribers_url":"https://api.github.com/repos/mjy78/sequelize/subscribers","subscription_url":"https://api.github.com/repos/mjy78/sequelize/subscription","commits_url":"https://api.github.com/repos/mjy78/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjy78/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjy78/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjy78/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjy78/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/mjy78/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjy78/sequelize/merges","archive_url":"https://api.github.com/repos/mjy78/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjy78/sequelize/downloads","issues_url":"https://api.github.com/repos/mjy78/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/mjy78/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/mjy78/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/mjy78/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjy78/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/mjy78/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/mjy78/sequelize/deployments","created_at":"2018-04-27T07:06:59Z","updated_at":"2018-05-02T08:58:05Z","pushed_at":"2018-05-02T08:58:04Z","git_url":"git://github.com/mjy78/sequelize.git","ssh_url":"git@github.com:mjy78/sequelize.git","clone_url":"https://github.com/mjy78/sequelize.git","svn_url":"https://github.com/mjy78/sequelize","homepage":"http://docs.sequelizejs.com","size":22271,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"7b163084bc40349563e2b758d1c1b385e97bba2b","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars0.githubusercontent.com/u/3591786?v=4","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars0.githubusercontent.com/u/3591786?v=4","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"An easy-to-use multi SQL dialect ORM for Node.js","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2018-05-03T03:30:27Z","pushed_at":"2018-05-03T04:53:38Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://docs.sequelizejs.com","size":22318,"stargazers_count":14157,"watchers_count":14157,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2435,"mirror_url":null,"archived":false,"open_issues_count":331,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2435,"open_issues":331,"watchers":14157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9364"},"html":{"href":"https://github.com/sequelize/sequelize/pull/9364"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/9364"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/9364/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9364/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9364/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/0d9a387ef3a7fa237e8d91e9b0e68664eac30474"}},"author_association":"NONE"}}
{"actor":{"display_login":"sushantdhiman"}}