{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/224794333","pull_request_review_id":163888738,"id":224794333,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc5NDMzMw==","diff_hunk":"@@ -572,7 +572,9 @@ func (m *CephManifestsMaster) GetBlockPoolStorageClass(namespace string, poolNam\n \treturn concatYaml(m.GetBlockPoolDef(poolName, namespace, \"1\"), m.GetBlockStorageClassDef(poolName, storageClassName, reclaimPolicy, namespace, false))\n }\n \n-func (m *CephManifestsMaster) GetFilesystem(namespace, name string) string {\n+// GetFilesystem returns the manifest to create a Rook filesystem resource with the given config.\n+func (m *CephManifestsMaster) GetFilesystem(namespace, name string, activeCount int32) string {\n+\tac := fmt.Sprintf(\"%d\", activeCount)","path":"tests/framework/installer/ceph_manifests.go","position":16,"original_position":16,"commit_id":"bf24dca89a15496fd0381dd086e16d1d18a9875c","original_commit_id":"bf24dca89a15496fd0381dd086e16d1d18a9875c","user":{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"For the int conversion you could use `strconv.Itoa(activeCount)`. Including it inline below works well too in these yamls.","created_at":"2018-10-12T14:01:41Z","updated_at":"2018-10-12T14:04:44Z","html_url":"https://github.com/rook/rook/pull/2210#discussion_r224794333","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/2210","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/224794333"},"html":{"href":"https://github.com/rook/rook/pull/2210#discussion_r224794333"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/2210"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2210","id":221956695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTU2Njk1","html_url":"https://github.com/rook/rook/pull/2210","diff_url":"https://github.com/rook/rook/pull/2210.diff","patch_url":"https://github.com/rook/rook/pull/2210.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/2210","number":2210,"state":"open","locked":false,"title":"WIP: ceph mds: allow mds deployment scale-down","user":{"login":"BlaineEXE","id":3989526,"node_id":"MDQ6VXNlcjM5ODk1MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/3989526?v=4","gravatar_id":"","url":"https://api.github.com/users/BlaineEXE","html_url":"https://github.com/BlaineEXE","followers_url":"https://api.github.com/users/BlaineEXE/followers","following_url":"https://api.github.com/users/BlaineEXE/following{/other_user}","gists_url":"https://api.github.com/users/BlaineEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/BlaineEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlaineEXE/subscriptions","organizations_url":"https://api.github.com/users/BlaineEXE/orgs","repos_url":"https://api.github.com/users/BlaineEXE/repos","events_url":"https://api.github.com/users/BlaineEXE/events{/privacy}","received_events_url":"https://api.github.com/users/BlaineEXE/received_events","type":"User","site_admin":false},"body":"fix #2193\r\n\r\nFix regression introduced by PR allowing MDS config creation in init\r\ncontainer. This allows the new deployment-based mds clusters to scale\r\ndown where currently they can only remain constant or scale up.\r\n\r\nSigned-off-by: Blaine Gardner <blaine.gardner@suse.com>\r\n\r\n<!-- Please take a look at our [Contributing](https://rook.io/docs/rook/master/development-flow.html)\r\ndocumentation before submitting a Pull Request!\r\nThank you for contributing to Rook! -->\r\n\r\n**Description of your changes:**\r\n\r\n**Which issue is resolved by this Pull Request:**\r\nResolves #\r\n\r\n**Checklist:**\r\n- [x] Documentation has been updated, if necessary.\r\n- [x] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [x] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [x] Comments have been added or updated based on the standards set in [CONTRIBUTING.md](../blob/master/CONTRIBUTING.md#comments)\r\n","created_at":"2018-10-10T22:47:55Z","updated_at":"2018-10-12T14:04:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd15698d533f6314a896e439d2eee2f5cbf71ce6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"galexrt","id":3718398,"node_id":"MDQ6VXNlcjM3MTgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/2210/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/2210/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/2210/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/bf24dca89a15496fd0381dd086e16d1d18a9875c","head":{"label":"SUSE:ceph-mds-enable-downsizing","ref":"ceph-mds-enable-downsizing","sha":"bf24dca89a15496fd0381dd086e16d1d18a9875c","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":116781773,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3ODE3NzM=","name":"rook","full_name":"SUSE/rook","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/SUSE/rook","forks_url":"https://api.github.com/repos/SUSE/rook/forks","keys_url":"https://api.github.com/repos/SUSE/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/rook/teams","hooks_url":"https://api.github.com/repos/SUSE/rook/hooks","issue_events_url":"https://api.github.com/repos/SUSE/rook/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/rook/events","assignees_url":"https://api.github.com/repos/SUSE/rook/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/rook/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/rook/tags","blobs_url":"https://api.github.com/repos/SUSE/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/rook/languages","stargazers_url":"https://api.github.com/repos/SUSE/rook/stargazers","contributors_url":"https://api.github.com/repos/SUSE/rook/contributors","subscribers_url":"https://api.github.com/repos/SUSE/rook/subscribers","subscription_url":"https://api.github.com/repos/SUSE/rook/subscription","commits_url":"https://api.github.com/repos/SUSE/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/rook/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/rook/merges","archive_url":"https://api.github.com/repos/SUSE/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/rook/downloads","issues_url":"https://api.github.com/repos/SUSE/rook/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/rook/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/rook/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/rook/deployments","created_at":"2018-01-09T07:30:45Z","updated_at":"2018-10-10T22:08:31Z","pushed_at":"2018-10-12T13:31:14Z","git_url":"git://github.com/SUSE/rook.git","ssh_url":"git@github.com:SUSE/rook.git","clone_url":"https://github.com/SUSE/rook.git","svn_url":"https://github.com/SUSE/rook","homepage":"https://rook.io","size":6523,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"0f229c72a630f4b38662c7b753dea38f69942fa6","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-10-12T11:22:53Z","pushed_at":"2018-10-12T13:32:06Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":6535,"stargazers_count":3558,"watchers_count":3558,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":454,"mirror_url":null,"archived":false,"open_issues_count":234,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":454,"open_issues":234,"watchers":3558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/2210"},"html":{"href":"https://github.com/rook/rook/pull/2210"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/2210"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/2210/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/2210/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/2210/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/bf24dca89a15496fd0381dd086e16d1d18a9875c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"travisn"}}