{"action":"closed","number":79,"pull_request":{"url":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79","id":220713127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzEzMTI3","html_url":"https://github.com/UBC-Thunderbots/Software/pull/79","diff_url":"https://github.com/UBC-Thunderbots/Software/pull/79.diff","patch_url":"https://github.com/UBC-Thunderbots/Software/pull/79.patch","issue_url":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/79","number":79,"state":"closed","locked":false,"title":"Removed `clang-format` as a dependency in setup_software.sh","user":{"login":"garethellis0","id":9075711,"node_id":"MDQ6VXNlcjkwNzU3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9075711?v=4","gravatar_id":"","url":"https://api.github.com/users/garethellis0","html_url":"https://github.com/garethellis0","followers_url":"https://api.github.com/users/garethellis0/followers","following_url":"https://api.github.com/users/garethellis0/following{/other_user}","gists_url":"https://api.github.com/users/garethellis0/gists{/gist_id}","starred_url":"https://api.github.com/users/garethellis0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethellis0/subscriptions","organizations_url":"https://api.github.com/users/garethellis0/orgs","repos_url":"https://api.github.com/users/garethellis0/repos","events_url":"https://api.github.com/users/garethellis0/events{/privacy}","received_events_url":"https://api.github.com/users/garethellis0/received_events","type":"User","site_admin":false},"body":"<!---\r\nThis file outlines a list of common things that should be addressed when opening a PR. It's built from previous issues we've seen in a lot of pull requests. If you notice something that's being noted in a lot of PR's, it should probably be added here to help save people time in the future.\r\n-->\r\n\r\n## Please fill out the following before requesting review on this PR\r\n\r\n### Description\r\nWe actually commit in the clang format executable (in `clang_format`)\r\nfor the sake of consistency, so we don't need to install it on the host\r\nsystem.\r\n\r\n\r\n### Testing Done\r\nJust need to check that CI passes.\r\n\r\n### Resolved Issues\r\nNope\r\n\r\n### Review Checklist\r\n*(Please check every item to indicate your code complies with it (by changing `[ ]`->`[x]`). This will hopefully save both you and the reviewer(s) a lot of time!)*\r\n***It is the reviewers responsibility to also make sure every item here has been covered***\r\n- [x] **Start of document comments**: each `.cpp` and `.h` file should have a comment at the start of it. See files in the `thunderbots/software/geom` folder for examples.\r\n- [x] **Function comments**: All function definitions (usually in the `.h` file) should have a javadoc style comment at the start of them. For examples, see the classes defined in `thunderbots/software/geom` \r\n- [x] **Remove all commented out code**\r\n- [x] **Remove extra print statements**: for example, those just used for testing\r\n- [x] **Resolve all TODO's**: All `TODO` (or similar) statements should either be completed or associated with a github issue\r\n\r\n***Feel free to make additions of things that we should be checking to this file if you think there's something missing!!!!***\r\n\r\n\r\n","created_at":"2018-10-05T14:03:35Z","updated_at":"2018-10-06T18:14:50Z","closed_at":"2018-10-06T18:14:50Z","merged_at":"2018-10-06T18:14:50Z","merge_commit_sha":"3046ee2d6aa5f27011ab7f0aa895bf25982eafd7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"EvanMorcom","id":25271038,"node_id":"MDQ6VXNlcjI1MjcxMDM4","avatar_url":"https://avatars0.githubusercontent.com/u/25271038?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanMorcom","html_url":"https://github.com/EvanMorcom","followers_url":"https://api.github.com/users/EvanMorcom/followers","following_url":"https://api.github.com/users/EvanMorcom/following{/other_user}","gists_url":"https://api.github.com/users/EvanMorcom/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanMorcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanMorcom/subscriptions","organizations_url":"https://api.github.com/users/EvanMorcom/orgs","repos_url":"https://api.github.com/users/EvanMorcom/repos","events_url":"https://api.github.com/users/EvanMorcom/events{/privacy}","received_events_url":"https://api.github.com/users/EvanMorcom/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79/commits","review_comments_url":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79/comments","review_comment_url":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/79/comments","statuses_url":"https://api.github.com/repos/UBC-Thunderbots/Software/statuses/59588b347e200eba9a7a695f431c8464820fba55","head":{"label":"garethellis0:gareth/remove-clang-format-dependency","ref":"gareth/remove-clang-format-dependency","sha":"59588b347e200eba9a7a695f431c8464820fba55","user":{"login":"garethellis0","id":9075711,"node_id":"MDQ6VXNlcjkwNzU3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9075711?v=4","gravatar_id":"","url":"https://api.github.com/users/garethellis0","html_url":"https://github.com/garethellis0","followers_url":"https://api.github.com/users/garethellis0/followers","following_url":"https://api.github.com/users/garethellis0/following{/other_user}","gists_url":"https://api.github.com/users/garethellis0/gists{/gist_id}","starred_url":"https://api.github.com/users/garethellis0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethellis0/subscriptions","organizations_url":"https://api.github.com/users/garethellis0/orgs","repos_url":"https://api.github.com/users/garethellis0/repos","events_url":"https://api.github.com/users/garethellis0/events{/privacy}","received_events_url":"https://api.github.com/users/garethellis0/received_events","type":"User","site_admin":false},"repo":{"id":149467150,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0NjcxNTA=","name":"Software","full_name":"garethellis0/Software","private":false,"owner":{"login":"garethellis0","id":9075711,"node_id":"MDQ6VXNlcjkwNzU3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9075711?v=4","gravatar_id":"","url":"https://api.github.com/users/garethellis0","html_url":"https://github.com/garethellis0","followers_url":"https://api.github.com/users/garethellis0/followers","following_url":"https://api.github.com/users/garethellis0/following{/other_user}","gists_url":"https://api.github.com/users/garethellis0/gists{/gist_id}","starred_url":"https://api.github.com/users/garethellis0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethellis0/subscriptions","organizations_url":"https://api.github.com/users/garethellis0/orgs","repos_url":"https://api.github.com/users/garethellis0/repos","events_url":"https://api.github.com/users/garethellis0/events{/privacy}","received_events_url":"https://api.github.com/users/garethellis0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/garethellis0/Software","description":null,"fork":true,"url":"https://api.github.com/repos/garethellis0/Software","forks_url":"https://api.github.com/repos/garethellis0/Software/forks","keys_url":"https://api.github.com/repos/garethellis0/Software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethellis0/Software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethellis0/Software/teams","hooks_url":"https://api.github.com/repos/garethellis0/Software/hooks","issue_events_url":"https://api.github.com/repos/garethellis0/Software/issues/events{/number}","events_url":"https://api.github.com/repos/garethellis0/Software/events","assignees_url":"https://api.github.com/repos/garethellis0/Software/assignees{/user}","branches_url":"https://api.github.com/repos/garethellis0/Software/branches{/branch}","tags_url":"https://api.github.com/repos/garethellis0/Software/tags","blobs_url":"https://api.github.com/repos/garethellis0/Software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethellis0/Software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethellis0/Software/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethellis0/Software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethellis0/Software/statuses/{sha}","languages_url":"https://api.github.com/repos/garethellis0/Software/languages","stargazers_url":"https://api.github.com/repos/garethellis0/Software/stargazers","contributors_url":"https://api.github.com/repos/garethellis0/Software/contributors","subscribers_url":"https://api.github.com/repos/garethellis0/Software/subscribers","subscription_url":"https://api.github.com/repos/garethellis0/Software/subscription","commits_url":"https://api.github.com/repos/garethellis0/Software/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethellis0/Software/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethellis0/Software/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethellis0/Software/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethellis0/Software/contents/{+path}","compare_url":"https://api.github.com/repos/garethellis0/Software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethellis0/Software/merges","archive_url":"https://api.github.com/repos/garethellis0/Software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethellis0/Software/downloads","issues_url":"https://api.github.com/repos/garethellis0/Software/issues{/number}","pulls_url":"https://api.github.com/repos/garethellis0/Software/pulls{/number}","milestones_url":"https://api.github.com/repos/garethellis0/Software/milestones{/number}","notifications_url":"https://api.github.com/repos/garethellis0/Software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethellis0/Software/labels{/name}","releases_url":"https://api.github.com/repos/garethellis0/Software/releases{/id}","deployments_url":"https://api.github.com/repos/garethellis0/Software/deployments","created_at":"2018-09-19T14:52:22Z","updated_at":"2018-10-05T14:01:45Z","pushed_at":"2018-10-05T21:51:42Z","git_url":"git://github.com/garethellis0/Software.git","ssh_url":"git@github.com:garethellis0/Software.git","clone_url":"https://github.com/garethellis0/Software.git","svn_url":"https://github.com/garethellis0/Software","homepage":null,"size":1817,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UBC-Thunderbots:master","ref":"master","sha":"d641c98b7620ec3d9882a2742bcce10cb1f5a2bb","user":{"login":"UBC-Thunderbots","id":27097762,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDk3NzYy","avatar_url":"https://avatars1.githubusercontent.com/u/27097762?v=4","gravatar_id":"","url":"https://api.github.com/users/UBC-Thunderbots","html_url":"https://github.com/UBC-Thunderbots","followers_url":"https://api.github.com/users/UBC-Thunderbots/followers","following_url":"https://api.github.com/users/UBC-Thunderbots/following{/other_user}","gists_url":"https://api.github.com/users/UBC-Thunderbots/gists{/gist_id}","starred_url":"https://api.github.com/users/UBC-Thunderbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UBC-Thunderbots/subscriptions","organizations_url":"https://api.github.com/users/UBC-Thunderbots/orgs","repos_url":"https://api.github.com/users/UBC-Thunderbots/repos","events_url":"https://api.github.com/users/UBC-Thunderbots/events{/privacy}","received_events_url":"https://api.github.com/users/UBC-Thunderbots/received_events","type":"Organization","site_admin":false},"repo":{"id":141040516,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwNDA1MTY=","name":"Software","full_name":"UBC-Thunderbots/Software","private":false,"owner":{"login":"UBC-Thunderbots","id":27097762,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MDk3NzYy","avatar_url":"https://avatars1.githubusercontent.com/u/27097762?v=4","gravatar_id":"","url":"https://api.github.com/users/UBC-Thunderbots","html_url":"https://github.com/UBC-Thunderbots","followers_url":"https://api.github.com/users/UBC-Thunderbots/followers","following_url":"https://api.github.com/users/UBC-Thunderbots/following{/other_user}","gists_url":"https://api.github.com/users/UBC-Thunderbots/gists{/gist_id}","starred_url":"https://api.github.com/users/UBC-Thunderbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UBC-Thunderbots/subscriptions","organizations_url":"https://api.github.com/users/UBC-Thunderbots/orgs","repos_url":"https://api.github.com/users/UBC-Thunderbots/repos","events_url":"https://api.github.com/users/UBC-Thunderbots/events{/privacy}","received_events_url":"https://api.github.com/users/UBC-Thunderbots/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/UBC-Thunderbots/Software","description":null,"fork":false,"url":"https://api.github.com/repos/UBC-Thunderbots/Software","forks_url":"https://api.github.com/repos/UBC-Thunderbots/Software/forks","keys_url":"https://api.github.com/repos/UBC-Thunderbots/Software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UBC-Thunderbots/Software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UBC-Thunderbots/Software/teams","hooks_url":"https://api.github.com/repos/UBC-Thunderbots/Software/hooks","issue_events_url":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/events{/number}","events_url":"https://api.github.com/repos/UBC-Thunderbots/Software/events","assignees_url":"https://api.github.com/repos/UBC-Thunderbots/Software/assignees{/user}","branches_url":"https://api.github.com/repos/UBC-Thunderbots/Software/branches{/branch}","tags_url":"https://api.github.com/repos/UBC-Thunderbots/Software/tags","blobs_url":"https://api.github.com/repos/UBC-Thunderbots/Software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UBC-Thunderbots/Software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UBC-Thunderbots/Software/git/refs{/sha}","trees_url":"https://api.github.com/repos/UBC-Thunderbots/Software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UBC-Thunderbots/Software/statuses/{sha}","languages_url":"https://api.github.com/repos/UBC-Thunderbots/Software/languages","stargazers_url":"https://api.github.com/repos/UBC-Thunderbots/Software/stargazers","contributors_url":"https://api.github.com/repos/UBC-Thunderbots/Software/contributors","subscribers_url":"https://api.github.com/repos/UBC-Thunderbots/Software/subscribers","subscription_url":"https://api.github.com/repos/UBC-Thunderbots/Software/subscription","commits_url":"https://api.github.com/repos/UBC-Thunderbots/Software/commits{/sha}","git_commits_url":"https://api.github.com/repos/UBC-Thunderbots/Software/git/commits{/sha}","comments_url":"https://api.github.com/repos/UBC-Thunderbots/Software/comments{/number}","issue_comment_url":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/comments{/number}","contents_url":"https://api.github.com/repos/UBC-Thunderbots/Software/contents/{+path}","compare_url":"https://api.github.com/repos/UBC-Thunderbots/Software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UBC-Thunderbots/Software/merges","archive_url":"https://api.github.com/repos/UBC-Thunderbots/Software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UBC-Thunderbots/Software/downloads","issues_url":"https://api.github.com/repos/UBC-Thunderbots/Software/issues{/number}","pulls_url":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls{/number}","milestones_url":"https://api.github.com/repos/UBC-Thunderbots/Software/milestones{/number}","notifications_url":"https://api.github.com/repos/UBC-Thunderbots/Software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UBC-Thunderbots/Software/labels{/name}","releases_url":"https://api.github.com/repos/UBC-Thunderbots/Software/releases{/id}","deployments_url":"https://api.github.com/repos/UBC-Thunderbots/Software/deployments","created_at":"2018-07-15T16:06:15Z","updated_at":"2018-10-05T03:20:38Z","pushed_at":"2018-10-06T18:14:50Z","git_url":"git://github.com/UBC-Thunderbots/Software.git","ssh_url":"git@github.com:UBC-Thunderbots/Software.git","clone_url":"https://github.com/UBC-Thunderbots/Software.git","svn_url":"https://github.com/UBC-Thunderbots/Software","homepage":null,"size":1797,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":26,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79"},"html":{"href":"https://github.com/UBC-Thunderbots/Software/pull/79"},"issue":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/79"},"comments":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/UBC-Thunderbots/Software/statuses/59588b347e200eba9a7a695f431c8464820fba55"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"garethellis0","id":9075711,"node_id":"MDQ6VXNlcjkwNzU3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9075711?v=4","gravatar_id":"","url":"https://api.github.com/users/garethellis0","html_url":"https://github.com/garethellis0","followers_url":"https://api.github.com/users/garethellis0/followers","following_url":"https://api.github.com/users/garethellis0/following{/other_user}","gists_url":"https://api.github.com/users/garethellis0/gists{/gist_id}","starred_url":"https://api.github.com/users/garethellis0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethellis0/subscriptions","organizations_url":"https://api.github.com/users/garethellis0/orgs","repos_url":"https://api.github.com/users/garethellis0/repos","events_url":"https://api.github.com/users/garethellis0/events{/privacy}","received_events_url":"https://api.github.com/users/garethellis0/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"garethellis0"}}