{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/776","repository_url":"https://api.github.com/repos/mozilla-l10n/langchecker","labels_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/776/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/776/comments","events_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/776/events","html_url":"https://github.com/mozilla-l10n/langchecker/pull/776","id":301866118,"number":776,"title":"Email review mode","user":{"login":"TheoChevalier","id":1294206,"avatar_url":"https://avatars2.githubusercontent.com/u/1294206?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoChevalier","html_url":"https://github.com/TheoChevalier","followers_url":"https://api.github.com/users/TheoChevalier/followers","following_url":"https://api.github.com/users/TheoChevalier/following{/other_user}","gists_url":"https://api.github.com/users/TheoChevalier/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoChevalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoChevalier/subscriptions","organizations_url":"https://api.github.com/users/TheoChevalier/orgs","repos_url":"https://api.github.com/users/TheoChevalier/repos","events_url":"https://api.github.com/users/TheoChevalier/events{/privacy}","received_events_url":"https://api.github.com/users/TheoChevalier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-03-02T18:45:53Z","updated_at":"2018-03-05T18:10:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla-l10n/langchecker/pulls/776","html_url":"https://github.com/mozilla-l10n/langchecker/pull/776","diff_url":"https://github.com/mozilla-l10n/langchecker/pull/776.diff","patch_url":"https://github.com/mozilla-l10n/langchecker/pull/776.patch"},"body":"Goal: Provide something [similar to this](https://labs.cynthiapereira.com/l10n/email-donor_update_feb.html) to localizers for reviewing emails. So that they don’t have to generate it manually. It should help catch typos before reviewing the test send.\r\n\r\nSome notes:\r\n- No need to review this today (even, shouldn’t :) )\r\n\r\n- I haven’t added extra logic to exclude other .lang files, because the view still looks good for other files, even if it’s designed with emails in mind.\r\nFor the sake of testing, I’m adding tags to the next email (emails/2018/en-US/donor_survey_march.lang), which will likely get exposed tonight.\r\n\r\n- The 45 first lines of reviewstrings.php are duplicated from translatestrings.php. Before moving code around, I wanted to check with you on where you would prefer to store this code. New shared controller file?\r\n\r\n- I’m using `|raw` in the template to get something close to a real email, I hope there’s no security concerns.\r\n\r\n- One side effect is that tags are displayed next to strings in the translate view, that’s a positive side effect, at least when it comes to copy/pasting emails. I might even add extra tags that are not used in the review view, for the sake of identifying some strings more easily.\r\n\r\nLet me know what you think about this approach when you have a moment! Hope it’s not too awful"},"comment":{"url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/comments/370510332","html_url":"https://github.com/mozilla-l10n/langchecker/pull/776#issuecomment-370510332","issue_url":"https://api.github.com/repos/mozilla-l10n/langchecker/issues/776","id":370510332,"user":{"login":"TheoChevalier","id":1294206,"avatar_url":"https://avatars2.githubusercontent.com/u/1294206?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoChevalier","html_url":"https://github.com/TheoChevalier","followers_url":"https://api.github.com/users/TheoChevalier/followers","following_url":"https://api.github.com/users/TheoChevalier/following{/other_user}","gists_url":"https://api.github.com/users/TheoChevalier/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoChevalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoChevalier/subscriptions","organizations_url":"https://api.github.com/users/TheoChevalier/orgs","repos_url":"https://api.github.com/users/TheoChevalier/repos","events_url":"https://api.github.com/users/TheoChevalier/events{/privacy}","received_events_url":"https://api.github.com/users/TheoChevalier/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T18:10:37Z","updated_at":"2018-03-05T18:10:37Z","author_association":"MEMBER","body":"Also not sure where you wanted my to name the array `errorchecks_exclusions`, but if it was in websites.inc.php, it would have made things more complicated(?)"}}
{"actor":{"display_login":"TheoChevalier"}}