{"action":"created","comment":{"url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/comments/226269556","pull_request_review_id":166047712,"id":226269556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI2OTU1Ng==","diff_hunk":"@@ -60,4 +61,27 @@ function write(dest, code) {\n }\n function logError(e) {\n   console.log(e)\n+}\n+\n+function copyHooks() {","path":"build/build.js","position":14,"original_position":14,"commit_id":"ee277effdb2ccee9b690ccb0196e251d9c18eb20","original_commit_id":"ee277effdb2ccee9b690ccb0196e251d9c18eb20","user":{"login":"Fatme","id":760518,"node_id":"MDQ6VXNlcjc2MDUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/760518?v=4","gravatar_id":"","url":"https://api.github.com/users/Fatme","html_url":"https://github.com/Fatme","followers_url":"https://api.github.com/users/Fatme/followers","following_url":"https://api.github.com/users/Fatme/following{/other_user}","gists_url":"https://api.github.com/users/Fatme/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatme/subscriptions","organizations_url":"https://api.github.com/users/Fatme/orgs","repos_url":"https://api.github.com/users/Fatme/repos","events_url":"https://api.github.com/users/Fatme/events{/privacy}","received_events_url":"https://api.github.com/users/Fatme/received_events","type":"User","site_admin":false},"body":"I added this function in order to ensure the hooks directory will be copied to `dist` folder on build step. And this way we'll ensure the hooks directory will be included in built package.\r\nBut I am not sure what is exactly the approach you use to pack/bundle the plugin's code.\r\n\r\nWe need this code in case when we want to have all the code that will be bundled inside `dist` folder.\r\nIf you think this is unneeded, this function can be removed. If we decide to remove it, this line should be changed https://github.com/nativescript-vue/nativescript-vue/pull/361/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R9.","created_at":"2018-10-18T11:34:46Z","updated_at":"2018-10-18T11:34:46Z","html_url":"https://github.com/nativescript-vue/nativescript-vue/pull/361#discussion_r226269556","pull_request_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/comments/226269556"},"html":{"href":"https://github.com/nativescript-vue/nativescript-vue/pull/361#discussion_r226269556"},"pull_request":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361"}}},"pull_request":{"url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361","id":223914168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTE0MTY4","html_url":"https://github.com/nativescript-vue/nativescript-vue/pull/361","diff_url":"https://github.com/nativescript-vue/nativescript-vue/pull/361.diff","patch_url":"https://github.com/nativescript-vue/nativescript-vue/pull/361.patch","issue_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/361","number":361,"state":"open","locked":false,"title":"feat: show error when --bundle option is not provided when executing some commands from {N} CLI","user":{"login":"Fatme","id":760518,"node_id":"MDQ6VXNlcjc2MDUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/760518?v=4","gravatar_id":"","url":"https://api.github.com/users/Fatme","html_url":"https://github.com/Fatme","followers_url":"https://api.github.com/users/Fatme/followers","following_url":"https://api.github.com/users/Fatme/following{/other_user}","gists_url":"https://api.github.com/users/Fatme/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatme/subscriptions","organizations_url":"https://api.github.com/users/Fatme/orgs","repos_url":"https://api.github.com/users/Fatme/repos","events_url":"https://api.github.com/users/Fatme/events{/privacy}","received_events_url":"https://api.github.com/users/Fatme/received_events","type":"User","site_admin":false},"body":"Currently it is not possible to use vue template without bundle option. So we need to show an error in case when the user executes some command without bundle option.\r\nThis PR adds 2 hooks - before-checkForChanges and before-watch. This hooks will be triggered automatically by {N} CLI when the command is executed.","created_at":"2018-10-18T11:05:24Z","updated_at":"2018-10-18T11:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30661ebfd819785f34cc3fe7a654b5b40d3273f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361/commits","review_comments_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361/comments","review_comment_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/361/comments","statuses_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/statuses/ee277effdb2ccee9b690ccb0196e251d9c18eb20","head":{"label":"Fatme:fatme/no-bundle-error","ref":"fatme/no-bundle-error","sha":"ee277effdb2ccee9b690ccb0196e251d9c18eb20","user":{"login":"Fatme","id":760518,"node_id":"MDQ6VXNlcjc2MDUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/760518?v=4","gravatar_id":"","url":"https://api.github.com/users/Fatme","html_url":"https://github.com/Fatme","followers_url":"https://api.github.com/users/Fatme/followers","following_url":"https://api.github.com/users/Fatme/following{/other_user}","gists_url":"https://api.github.com/users/Fatme/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatme/subscriptions","organizations_url":"https://api.github.com/users/Fatme/orgs","repos_url":"https://api.github.com/users/Fatme/repos","events_url":"https://api.github.com/users/Fatme/events{/privacy}","received_events_url":"https://api.github.com/users/Fatme/received_events","type":"User","site_admin":false},"repo":{"id":153609203,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MDkyMDM=","name":"nativescript-vue","full_name":"Fatme/nativescript-vue","private":false,"owner":{"login":"Fatme","id":760518,"node_id":"MDQ6VXNlcjc2MDUxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/760518?v=4","gravatar_id":"","url":"https://api.github.com/users/Fatme","html_url":"https://github.com/Fatme","followers_url":"https://api.github.com/users/Fatme/followers","following_url":"https://api.github.com/users/Fatme/following{/other_user}","gists_url":"https://api.github.com/users/Fatme/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatme/subscriptions","organizations_url":"https://api.github.com/users/Fatme/orgs","repos_url":"https://api.github.com/users/Fatme/repos","events_url":"https://api.github.com/users/Fatme/events{/privacy}","received_events_url":"https://api.github.com/users/Fatme/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fatme/nativescript-vue","description":"Native mobile applications with NativeScript and Vue","fork":true,"url":"https://api.github.com/repos/Fatme/nativescript-vue","forks_url":"https://api.github.com/repos/Fatme/nativescript-vue/forks","keys_url":"https://api.github.com/repos/Fatme/nativescript-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fatme/nativescript-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fatme/nativescript-vue/teams","hooks_url":"https://api.github.com/repos/Fatme/nativescript-vue/hooks","issue_events_url":"https://api.github.com/repos/Fatme/nativescript-vue/issues/events{/number}","events_url":"https://api.github.com/repos/Fatme/nativescript-vue/events","assignees_url":"https://api.github.com/repos/Fatme/nativescript-vue/assignees{/user}","branches_url":"https://api.github.com/repos/Fatme/nativescript-vue/branches{/branch}","tags_url":"https://api.github.com/repos/Fatme/nativescript-vue/tags","blobs_url":"https://api.github.com/repos/Fatme/nativescript-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fatme/nativescript-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fatme/nativescript-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fatme/nativescript-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fatme/nativescript-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/Fatme/nativescript-vue/languages","stargazers_url":"https://api.github.com/repos/Fatme/nativescript-vue/stargazers","contributors_url":"https://api.github.com/repos/Fatme/nativescript-vue/contributors","subscribers_url":"https://api.github.com/repos/Fatme/nativescript-vue/subscribers","subscription_url":"https://api.github.com/repos/Fatme/nativescript-vue/subscription","commits_url":"https://api.github.com/repos/Fatme/nativescript-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fatme/nativescript-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fatme/nativescript-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fatme/nativescript-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fatme/nativescript-vue/contents/{+path}","compare_url":"https://api.github.com/repos/Fatme/nativescript-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fatme/nativescript-vue/merges","archive_url":"https://api.github.com/repos/Fatme/nativescript-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fatme/nativescript-vue/downloads","issues_url":"https://api.github.com/repos/Fatme/nativescript-vue/issues{/number}","pulls_url":"https://api.github.com/repos/Fatme/nativescript-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/Fatme/nativescript-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/Fatme/nativescript-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fatme/nativescript-vue/labels{/name}","releases_url":"https://api.github.com/repos/Fatme/nativescript-vue/releases{/id}","deployments_url":"https://api.github.com/repos/Fatme/nativescript-vue/deployments","created_at":"2018-10-18T10:56:03Z","updated_at":"2018-10-18T10:56:05Z","pushed_at":"2018-10-18T11:00:28Z","git_url":"git://github.com/Fatme/nativescript-vue.git","ssh_url":"git@github.com:Fatme/nativescript-vue.git","clone_url":"https://github.com/Fatme/nativescript-vue.git","svn_url":"https://github.com/Fatme/nativescript-vue","homepage":"https://nativescript-vue.org/","size":4317,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nativescript-vue:master","ref":"master","sha":"cfbf83d619805108de2b0bbc46fec9b8a721fa82","user":{"login":"nativescript-vue","id":32681046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjgxMDQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32681046?v=4","gravatar_id":"","url":"https://api.github.com/users/nativescript-vue","html_url":"https://github.com/nativescript-vue","followers_url":"https://api.github.com/users/nativescript-vue/followers","following_url":"https://api.github.com/users/nativescript-vue/following{/other_user}","gists_url":"https://api.github.com/users/nativescript-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/nativescript-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nativescript-vue/subscriptions","organizations_url":"https://api.github.com/users/nativescript-vue/orgs","repos_url":"https://api.github.com/users/nativescript-vue/repos","events_url":"https://api.github.com/users/nativescript-vue/events{/privacy}","received_events_url":"https://api.github.com/users/nativescript-vue/received_events","type":"Organization","site_admin":false},"repo":{"id":88561103,"node_id":"MDEwOlJlcG9zaXRvcnk4ODU2MTEwMw==","name":"nativescript-vue","full_name":"nativescript-vue/nativescript-vue","private":false,"owner":{"login":"nativescript-vue","id":32681046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjgxMDQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32681046?v=4","gravatar_id":"","url":"https://api.github.com/users/nativescript-vue","html_url":"https://github.com/nativescript-vue","followers_url":"https://api.github.com/users/nativescript-vue/followers","following_url":"https://api.github.com/users/nativescript-vue/following{/other_user}","gists_url":"https://api.github.com/users/nativescript-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/nativescript-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nativescript-vue/subscriptions","organizations_url":"https://api.github.com/users/nativescript-vue/orgs","repos_url":"https://api.github.com/users/nativescript-vue/repos","events_url":"https://api.github.com/users/nativescript-vue/events{/privacy}","received_events_url":"https://api.github.com/users/nativescript-vue/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nativescript-vue/nativescript-vue","description":"Native mobile applications with NativeScript and Vue","fork":false,"url":"https://api.github.com/repos/nativescript-vue/nativescript-vue","forks_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/forks","keys_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/teams","hooks_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/hooks","issue_events_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/events{/number}","events_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/events","assignees_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/assignees{/user}","branches_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/branches{/branch}","tags_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/tags","blobs_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/languages","stargazers_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/stargazers","contributors_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/contributors","subscribers_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/subscribers","subscription_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/subscription","commits_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/contents/{+path}","compare_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/merges","archive_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/downloads","issues_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues{/number}","pulls_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/labels{/name}","releases_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/releases{/id}","deployments_url":"https://api.github.com/repos/nativescript-vue/nativescript-vue/deployments","created_at":"2017-04-17T23:49:17Z","updated_at":"2018-10-18T06:36:28Z","pushed_at":"2018-10-18T11:05:25Z","git_url":"git://github.com/nativescript-vue/nativescript-vue.git","ssh_url":"git@github.com:nativescript-vue/nativescript-vue.git","clone_url":"https://github.com/nativescript-vue/nativescript-vue.git","svn_url":"https://github.com/nativescript-vue/nativescript-vue","homepage":"https://nativescript-vue.org/","size":4317,"stargazers_count":3445,"watchers_count":3445,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":156,"open_issues":30,"watchers":3445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361"},"html":{"href":"https://github.com/nativescript-vue/nativescript-vue/pull/361"},"issue":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/361"},"comments":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/nativescript-vue/nativescript-vue/statuses/ee277effdb2ccee9b690ccb0196e251d9c18eb20"}},"author_association":"NONE"}}
{"actor":{"display_login":"Fatme"}}