{"action":"closed","number":704,"pull_request":{"url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704","id":197914072,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTE0MDcy","html_url":"https://github.com/kubeflow/tf-operator/pull/704","diff_url":"https://github.com/kubeflow/tf-operator/pull/704.diff","patch_url":"https://github.com/kubeflow/tf-operator/pull/704.patch","issue_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/704","number":704,"state":"closed","locked":false,"title":"Fix sub domain issue","user":{"login":"ScorpioCPH","id":5319646,"node_id":"MDQ6VXNlcjUzMTk2NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5319646?v=4","gravatar_id":"","url":"https://api.github.com/users/ScorpioCPH","html_url":"https://github.com/ScorpioCPH","followers_url":"https://api.github.com/users/ScorpioCPH/followers","following_url":"https://api.github.com/users/ScorpioCPH/following{/other_user}","gists_url":"https://api.github.com/users/ScorpioCPH/gists{/gist_id}","starred_url":"https://api.github.com/users/ScorpioCPH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScorpioCPH/subscriptions","organizations_url":"https://api.github.com/users/ScorpioCPH/orgs","repos_url":"https://api.github.com/users/ScorpioCPH/repos","events_url":"https://api.github.com/users/ScorpioCPH/events{/privacy}","received_events_url":"https://api.github.com/users/ScorpioCPH/received_events","type":"User","site_admin":false},"body":"Hi, this PR fix https://github.com/kubeflow/tf-operator/issues/703 when we change to headless service.\r\n\r\n@gaocegege PTAL.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/tf-operator/704)\n<!-- Reviewable:end -->\n","created_at":"2018-06-28T04:26:04Z","updated_at":"2018-06-28T05:34:19Z","closed_at":"2018-06-28T05:34:19Z","merged_at":"2018-06-28T05:34:19Z","merge_commit_sha":"a5a5f49f2a9f3a783301c0df38727b938c3bbc3c","assignee":{"login":"gaocegege","id":5100735,"node_id":"MDQ6VXNlcjUxMDA3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"assignees":[{"login":"gaocegege","id":5100735,"node_id":"MDQ6VXNlcjUxMDA3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mitake","id":1173955,"node_id":"MDQ6VXNlcjExNzM5NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1173955?v=4","gravatar_id":"","url":"https://api.github.com/users/mitake","html_url":"https://github.com/mitake","followers_url":"https://api.github.com/users/mitake/followers","following_url":"https://api.github.com/users/mitake/following{/other_user}","gists_url":"https://api.github.com/users/mitake/gists{/gist_id}","starred_url":"https://api.github.com/users/mitake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitake/subscriptions","organizations_url":"https://api.github.com/users/mitake/orgs","repos_url":"https://api.github.com/users/mitake/repos","events_url":"https://api.github.com/users/mitake/events{/privacy}","received_events_url":"https://api.github.com/users/mitake/received_events","type":"User","site_admin":false},{"login":"ddysher","id":2191361,"node_id":"MDQ6VXNlcjIxOTEzNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2191361?v=4","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":850672456,"node_id":"MDU6TGFiZWw4NTA2NzI0NTY=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/approved","name":"approved","color":"03db12","default":false},{"id":850672326,"node_id":"MDU6TGFiZWw4NTA2NzIzMjY=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/lgtm","name":"lgtm","color":"2efca4","default":false},{"id":835722463,"node_id":"MDU6TGFiZWw4MzU3MjI0NjM=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/size/S","name":"size/S","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704/commits","review_comments_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704/comments","review_comment_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/704/comments","statuses_url":"https://api.github.com/repos/kubeflow/tf-operator/statuses/02c81c88da73e1e483a96462ea4448f37ce2003f","head":{"label":"ScorpioCPH:master","ref":"master","sha":"02c81c88da73e1e483a96462ea4448f37ce2003f","user":{"login":"ScorpioCPH","id":5319646,"node_id":"MDQ6VXNlcjUzMTk2NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5319646?v=4","gravatar_id":"","url":"https://api.github.com/users/ScorpioCPH","html_url":"https://github.com/ScorpioCPH","followers_url":"https://api.github.com/users/ScorpioCPH/followers","following_url":"https://api.github.com/users/ScorpioCPH/following{/other_user}","gists_url":"https://api.github.com/users/ScorpioCPH/gists{/gist_id}","starred_url":"https://api.github.com/users/ScorpioCPH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScorpioCPH/subscriptions","organizations_url":"https://api.github.com/users/ScorpioCPH/orgs","repos_url":"https://api.github.com/users/ScorpioCPH/repos","events_url":"https://api.github.com/users/ScorpioCPH/events{/privacy}","received_events_url":"https://api.github.com/users/ScorpioCPH/received_events","type":"User","site_admin":false},"repo":{"id":110104111,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxMDQxMTE=","name":"tf-operator","full_name":"ScorpioCPH/tf-operator","owner":{"login":"ScorpioCPH","id":5319646,"node_id":"MDQ6VXNlcjUzMTk2NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5319646?v=4","gravatar_id":"","url":"https://api.github.com/users/ScorpioCPH","html_url":"https://github.com/ScorpioCPH","followers_url":"https://api.github.com/users/ScorpioCPH/followers","following_url":"https://api.github.com/users/ScorpioCPH/following{/other_user}","gists_url":"https://api.github.com/users/ScorpioCPH/gists{/gist_id}","starred_url":"https://api.github.com/users/ScorpioCPH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScorpioCPH/subscriptions","organizations_url":"https://api.github.com/users/ScorpioCPH/orgs","repos_url":"https://api.github.com/users/ScorpioCPH/repos","events_url":"https://api.github.com/users/ScorpioCPH/events{/privacy}","received_events_url":"https://api.github.com/users/ScorpioCPH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ScorpioCPH/tf-operator","description":"Tools for ML/Tensorflow on Kubernetes.","fork":true,"url":"https://api.github.com/repos/ScorpioCPH/tf-operator","forks_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/forks","keys_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/teams","hooks_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/hooks","issue_events_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/issues/events{/number}","events_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/events","assignees_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/assignees{/user}","branches_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/branches{/branch}","tags_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/tags","blobs_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/languages","stargazers_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/stargazers","contributors_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/contributors","subscribers_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/subscribers","subscription_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/subscription","commits_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/contents/{+path}","compare_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/merges","archive_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/downloads","issues_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/issues{/number}","pulls_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/labels{/name}","releases_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/releases{/id}","deployments_url":"https://api.github.com/repos/ScorpioCPH/tf-operator/deployments","created_at":"2017-11-09T10:58:21Z","updated_at":"2018-06-28T05:08:06Z","pushed_at":"2018-06-28T05:08:04Z","git_url":"git://github.com/ScorpioCPH/tf-operator.git","ssh_url":"git@github.com:ScorpioCPH/tf-operator.git","clone_url":"https://github.com/ScorpioCPH/tf-operator.git","svn_url":"https://github.com/ScorpioCPH/tf-operator","homepage":null,"size":38232,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"936061472b0937462c7720fb0c3c7359091fc07e","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":95700338,"node_id":"MDEwOlJlcG9zaXRvcnk5NTcwMDMzOA==","name":"tf-operator","full_name":"kubeflow/tf-operator","owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/tf-operator","description":"Tools for ML/Tensorflow on Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubeflow/tf-operator","forks_url":"https://api.github.com/repos/kubeflow/tf-operator/forks","keys_url":"https://api.github.com/repos/kubeflow/tf-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/tf-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/tf-operator/teams","hooks_url":"https://api.github.com/repos/kubeflow/tf-operator/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/tf-operator/events","assignees_url":"https://api.github.com/repos/kubeflow/tf-operator/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/tf-operator/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/tf-operator/tags","blobs_url":"https://api.github.com/repos/kubeflow/tf-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/tf-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/tf-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/tf-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/tf-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/tf-operator/languages","stargazers_url":"https://api.github.com/repos/kubeflow/tf-operator/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/tf-operator/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/tf-operator/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/tf-operator/subscription","commits_url":"https://api.github.com/repos/kubeflow/tf-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/tf-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/tf-operator/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/tf-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/tf-operator/merges","archive_url":"https://api.github.com/repos/kubeflow/tf-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/tf-operator/downloads","issues_url":"https://api.github.com/repos/kubeflow/tf-operator/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/tf-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/tf-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/tf-operator/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/tf-operator/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/tf-operator/deployments","created_at":"2017-06-28T18:38:14Z","updated_at":"2018-06-27T11:10:39Z","pushed_at":"2018-06-28T05:34:19Z","git_url":"git://github.com/kubeflow/tf-operator.git","ssh_url":"git@github.com:kubeflow/tf-operator.git","clone_url":"https://github.com/kubeflow/tf-operator.git","svn_url":"https://github.com/kubeflow/tf-operator","homepage":null,"size":57274,"stargazers_count":474,"watchers_count":474,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":139,"open_issues":63,"watchers":474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704"},"html":{"href":"https://github.com/kubeflow/tf-operator/pull/704"},"issue":{"href":"https://api.github.com/repos/kubeflow/tf-operator/issues/704"},"comments":{"href":"https://api.github.com/repos/kubeflow/tf-operator/issues/704/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/704/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/tf-operator/statuses/02c81c88da73e1e483a96462ea4448f37ce2003f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"k8s-ci-robot"}}