{"action":"created","issue":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/3793","repository_url":"https://api.github.com/repos/sqlcollaborative/dbatools","labels_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/3793/labels{/name}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/3793/comments","events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/3793/events","html_url":"https://github.com/sqlcollaborative/dbatools/pull/3793","id":340928361,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjIxMjkx","number":3793,"title":"Fixed Test-DbaWindowsLogin so it copes with Computer accounts","user":{"login":"Stuart-Moore","id":5613670,"node_id":"MDQ6VXNlcjU2MTM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5613670?v=4","gravatar_id":"","url":"https://api.github.com/users/Stuart-Moore","html_url":"https://github.com/Stuart-Moore","followers_url":"https://api.github.com/users/Stuart-Moore/followers","following_url":"https://api.github.com/users/Stuart-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Stuart-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Stuart-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stuart-Moore/subscriptions","organizations_url":"https://api.github.com/users/Stuart-Moore/orgs","repos_url":"https://api.github.com/users/Stuart-Moore/repos","events_url":"https://api.github.com/users/Stuart-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Stuart-Moore/received_events","type":"User","site_admin":false},"labels":[{"id":173004249,"node_id":"MDU6TGFiZWwxNzMwMDQyNDk=","url":"https://api.github.com/repos/sqlcollaborative/dbatools/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"closed","locked":false,"assignee":{"login":"Stuart-Moore","id":5613670,"node_id":"MDQ6VXNlcjU2MTM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5613670?v=4","gravatar_id":"","url":"https://api.github.com/users/Stuart-Moore","html_url":"https://github.com/Stuart-Moore","followers_url":"https://api.github.com/users/Stuart-Moore/followers","following_url":"https://api.github.com/users/Stuart-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Stuart-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Stuart-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stuart-Moore/subscriptions","organizations_url":"https://api.github.com/users/Stuart-Moore/orgs","repos_url":"https://api.github.com/users/Stuart-Moore/repos","events_url":"https://api.github.com/users/Stuart-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Stuart-Moore/received_events","type":"User","site_admin":false},"assignees":[{"login":"Stuart-Moore","id":5613670,"node_id":"MDQ6VXNlcjU2MTM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5613670?v=4","gravatar_id":"","url":"https://api.github.com/users/Stuart-Moore","html_url":"https://github.com/Stuart-Moore","followers_url":"https://api.github.com/users/Stuart-Moore/followers","following_url":"https://api.github.com/users/Stuart-Moore/following{/other_user}","gists_url":"https://api.github.com/users/Stuart-Moore/gists{/gist_id}","starred_url":"https://api.github.com/users/Stuart-Moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stuart-Moore/subscriptions","organizations_url":"https://api.github.com/users/Stuart-Moore/orgs","repos_url":"https://api.github.com/users/Stuart-Moore/repos","events_url":"https://api.github.com/users/Stuart-Moore/events{/privacy}","received_events_url":"https://api.github.com/users/Stuart-Moore/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-07-13T08:28:59Z","updated_at":"2018-07-15T15:51:05Z","closed_at":"2018-07-15T15:50:57Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/3793","html_url":"https://github.com/sqlcollaborative/dbatools/pull/3793","diff_url":"https://github.com/sqlcollaborative/dbatools/pull/3793.diff","patch_url":"https://github.com/sqlcollaborative/dbatools/pull/3793.patch"},"body":"<!-- Below information IS REQUIRED with every PR -->\r\n## Type of Change\r\n<!-- What type of change does your code introduce -->\r\n - [x] Bug fix (non-breaking change, fixes #3792 )\r\n - [x] New feature (non-breaking change, adds functionality)\r\n - [ ] Breaking change (effects multiple commands or functionality)\r\n - [x] Ran manual Pester test and has passed (`.\\tests\\manual.pester.ps1)\r\n - [ ] Adding code coverage to existing functionality\r\n - [ ] Pester test is included\r\n - [ ] Nunit test is included\r\n - [ ] Documentation\r\n - [ ] Build system\r\n \r\n<!-- Below this line you can erase anything that is not applicable -->\r\n### Purpose\r\nImplements fix for #3792\r\n\r\nLots of apps use the AD computer account to connect (SCCM, CRM, etc) and Test-DbaWindowsLogin doesn't parse them properly\r\n\r\n### Approach\r\nIf the account isn't matched as user, check if it's in computer name format ',*`$' and then lookup as a computer\r\n\r\n\r\n### Screenshots\r\nBefore/After:\r\n![image](https://user-images.githubusercontent.com/5613670/42680903-35a889cc-867e-11e8-863a-7097b24d6914.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/comments/405100375","html_url":"https://github.com/sqlcollaborative/dbatools/pull/3793#issuecomment-405100375","issue_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/3793","id":405100375,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEwMDM3NQ==","user":{"login":"potatoqualitee","id":8278033,"node_id":"MDQ6VXNlcjgyNzgwMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8278033?v=4","gravatar_id":"","url":"https://api.github.com/users/potatoqualitee","html_url":"https://github.com/potatoqualitee","followers_url":"https://api.github.com/users/potatoqualitee/followers","following_url":"https://api.github.com/users/potatoqualitee/following{/other_user}","gists_url":"https://api.github.com/users/potatoqualitee/gists{/gist_id}","starred_url":"https://api.github.com/users/potatoqualitee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatoqualitee/subscriptions","organizations_url":"https://api.github.com/users/potatoqualitee/orgs","repos_url":"https://api.github.com/users/potatoqualitee/repos","events_url":"https://api.github.com/users/potatoqualitee/events{/privacy}","received_events_url":"https://api.github.com/users/potatoqualitee/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T15:51:05Z","updated_at":"2018-07-15T15:51:05Z","author_association":"MEMBER","body":"thank you all!"}}
{"actor":{"display_login":"potatoqualitee"}}