{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4374","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4374/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4374/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4374/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4374","id":345377573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTQ4NzQ1","number":4374,"title":"Use dialog-user component for more custom button object types","user":{"login":"eclarizio","id":164557,"node_id":"MDQ6VXNlcjE2NDU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/164557?v=4","gravatar_id":"","url":"https://api.github.com/users/eclarizio","html_url":"https://github.com/eclarizio","followers_url":"https://api.github.com/users/eclarizio/followers","following_url":"https://api.github.com/users/eclarizio/following{/other_user}","gists_url":"https://api.github.com/users/eclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/eclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclarizio/subscriptions","organizations_url":"https://api.github.com/users/eclarizio/orgs","repos_url":"https://api.github.com/users/eclarizio/repos","events_url":"https://api.github.com/users/eclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/eclarizio/received_events","type":"User","site_admin":false},"labels":[{"id":534299194,"node_id":"MDU6TGFiZWw1MzQyOTkxOTQ=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/automation/automate","name":"automation/automate","color":"5319e7","default":false},{"id":505074431,"node_id":"MDU6TGFiZWw1MDUwNzQ0MzE=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"h-kataria","id":3450808,"node_id":"MDQ6VXNlcjM0NTA4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-kataria","id":3450808,"node_id":"MDQ6VXNlcjM0NTA4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3450808?v=4","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-27T21:55:46Z","updated_at":"2018-08-01T18:03:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4374","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4374","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4374.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4374.patch"},"body":"Related to https://github.com/ManageIQ/manageiq-ui-classic/pull/3439\r\n\r\nThis PR adds support with the dialog-user component for the following custom button object types:\r\n`AvailabilityZone`\r\n`ContainerGroup`\r\n`ContainerImage`\r\n`ContainerProject`\r\n`ContainerTemplate`\r\n`ContainerVolume`\r\n`LoadBalancer`\r\n`NetworkRouter`\r\n`OrchestrationStack`\r\n`SecurityGroup`\r\n`Switch`\r\n\r\nI also refactored the case statement a bit, since a lot of these new objects were simple, so basically now unless something needs special handling, it will fall through to the `else` part of the case statement and default to changing something like `AvailabilityZone` into `availability_zones` for the API collection name and `\"/availability_zone\"` for the UI cancel endpoint.\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1597914\r\n\r\n/cc @gmcculloug\r\n@d-m-u Can you review, please?\r\n@tinaafitz Do you think you can help set up something with QE so we can test all of these new object types with custom buttons? I was able to test a few of them locally but the others I don't have the data for and not sure how to set them up properly.\r\n\r\n@miq-bot assign @h-kataria\r\n@miq-bot add_label enhancement, automation/automate"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/409666932","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4374#issuecomment-409666932","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4374","id":409666932,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTY2NjkzMg==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T18:03:14Z","updated_at":"2018-08-01T18:03:14Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/eclarizio/manageiq-ui-classic/compare/dfb7ed2137b882c09f5cc228b0255b87e2e3d572~...8ac805aaaa1ca6592785f7dcb95b45ee396e4557 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n2 files checked, 1 offense detected\n\n**spec/services/dialog_local_service_spec.rb**\n- [ ] :exclamation: - [Line 46](https://github.com/eclarizio/manageiq-ui-classic/blob/8ac805aaaa1ca6592785f7dcb95b45ee396e4557/spec/services/dialog_local_service_spec.rb#L46), Col 7 - [Layout/MultilineBlockLayout](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Layout/MultilineBlockLayout) - Block argument expression is not on the same line as the block start.\n"}}
{"actor":{"display_login":"miq-bot"}}