{"push_id":2753015947,"size":5,"distinct_size":5,"ref":"refs/heads/master","head":"a27db4a5ecc8dc63f202a4d949a3a7de83ce4275","before":"165e5c190056b8d9b168b0ebad0f2a4fdd06d92b","commits":[{"sha":"e30800ae4a616c0e3fc040c57a7fd20aa7b3f7c1","author":{"name":"Maajid","email":"ab0f9e52c216ca37fa56549ef9cb81463c0f60b8@chromium.org"},"message":"Record to UMA when an ARC app window is focused.\n\nBug: 866757\nTest: chrome://histograms\nChange-Id: I232a2869cae577c0fe9ca61f95cf43eb0f8b0416\nReviewed-on: https://chromium-review.googlesource.com/1144904\nReviewed-by: Sadrul Chowdhury <sadrul@chromium.org>\nReviewed-by: Yusuke Sato <yusukes@chromium.org>\nReviewed-by: Luis Hector Chavez <lhchavez@chromium.org>\nCommit-Queue: Maajid <maajid@chromium.org>\nCr-Commit-Position: refs/heads/master@{#578651}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/e30800ae4a616c0e3fc040c57a7fd20aa7b3f7c1"},{"sha":"c03a192a88c2514a21121251fe6ea0300d0d2353","author":{"name":"Scott Violet","email":"5737ef08a3ec16a337ac79a1d719fb91acba20a4@chromium.org"},"message":"Revert \"Fix invalid handle errors found with App Verifier\"\n\nThis reverts commit c31de3260f48a6c197d698f8f2e295cd9f04d49b.\n\nReason for revert: Findit thinks this is the cause for SingleClientAppsSyncTest.StartWithSomePlatformApps is Flaky becoming flaky. Debug output from the bot shows CHECK in process_handle_win:\n\n[5744:6016:0727/011726.878:FATAL:process_handle_win.cc(29)] Check failed: result != 0 || GetLastError() != ERROR_INVALID_HANDLE. process handle = 00000FB4\nBacktrace:\n\tbase::debug::StackTrace::StackTrace [0x73D7A1D6+102]\n\tbase::debug::StackTrace::StackTrace [0x73D7927B+27]\n\tlogging::LogMessage::~LogMessage [0x73DDEFA4+148]\n\tbase::GetProcId [0x73EC8E8E+254]\n\tcontent::ChildConnection::IOThreadContext::SetProcessHandleOnIOThread [0x617A7C58+232]\n\tbase::internal::FunctorTraits<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),void>::Invoke<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A8001+81]\n\tbase::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A7F0C+124]\n\tbase::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunImpl<void (__thiscall content::ChildConnectio [0x617A7E3F+111]\n\tbase::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunOnce [0x617A7CE4+84]\n\tbase::OnceCallback<void __cdecl(void)>::Run [0x73D1CA90+80]\n\tbase::debug::TaskAnnotator::RunTask [0x73D7E9F3+1075]\n\tbase::MessageLoop::RunTask [0x73E19A64+884]\n\tbase::MessageLoop::DeferOrRunPendingTask [0x73E1A249+73]\n\tbase::MessageLoop::DoWork [0x73E1A5BA+442]\n\tbase::MessagePumpForIO::DoRunLoop [0x73E2775C+28]\n\tbase::MessagePumpWin::Run [0x73E25CA7+119]\n\tbase::MessageLoop::Run [0x73E19366+486]\n\tbase::RunLoop::Run [0x73EDF518+488]\n\tbase::Thread::Run [0x73FF8EF7+375]\n\tcontent::BrowserProcessSubThread::IOThreadRun [0x61B456A0+48]\n\tcontent::BrowserProcessSubThread::Run [0x61B45589+313]\n\tbase::Thread::ThreadMain [0x73FF97BA+1402]\n\tbase::PlatformThread::GetCurrentThreadPriority [0x73FEBC76+934]\n\tBaseThreadInitThunk [0x74AD336A+18]\n\tRtlInitializeExceptionChain [0x771F9902+99]\n\tRtlInitializeExceptionChain [0x771F98D5+54]\n\nOriginal change's description:\n> Fix invalid handle errors found with App Verifier\n> \n> ChildProcessData was holding a raw ProcessHandle which meant that there\n> was no guarantee that the handle would be valid when it was used. This\n> change switches to a ScopedHandle on Windows, with the associated\n> duplication of the handle, so that it is guaranteed to be valid. This\n> fixes a frequently encountered use of an invalid handle that was\n> detected by Application Verifier. This change also adds a CHECK to\n> base::GetProcId to check for use of invalid handles even when not using\n> Application Verifier.\n> \n> ChildProcessData::handle is now a private member so all references to\n> it were updated to use accessors.\n> \n> When ChildProcessData::SetHandle is called the handle is duplicated.\n> When a ChildProcessData object needs to be copied an explicit\n> Duplicate function is called.\n> \n> An IsHandleValid helper function was added.\n> \n> An invalid test was removed because it was triggering the CHECK in\n> base::GetProcId.\n> \n> Bug: 417532,821453,865805\n> Change-Id: I7e38140335c0140536919341f011f144f150c88f\n> Reviewed-on: https://chromium-review.googlesource.com/1145767\n> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>\n> Reviewed-by: Jochen Eisinger <jochen@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#578419}\n\nTBR=brucedawson@chromium.org,jochen@chromium.org\n\nChange-Id: I8569cb32ec0cd9cbd99ecf6d5bba7feb672a88cd\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 417532, 821453, 865805, 868384\nReviewed-on: https://chromium-review.googlesource.com/1152374\nReviewed-by: Scott Violet <sky@chromium.org>\nCommit-Queue: Scott Violet <sky@chromium.org>\nCr-Commit-Position: refs/heads/master@{#578652}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/c03a192a88c2514a21121251fe6ea0300d0d2353"},{"sha":"c36aa32695fe893d721015ee2566b79ba65d3d1d","author":{"name":"catapult-chromium-autoroll","email":"a28e27486f8aa99efb69243f7eeb8912b64bdf0c@skia-buildbots.google.com.iam.gserviceaccount.com"},"message":"Roll src/third_party/catapult 787a378926fb..6a67dd77dfc3 (1 commits)\n\nhttps://chromium.googlesource.com/catapult.git/+log/787a378926fb..6a67dd77dfc3\n\n\ngit log 787a378926fb..6a67dd77dfc3 --date=short --no-merges --format='%ad %ae %s'\n2018-07-27 mattcary@chromium.org Tracing: Fix native library stats for pre-N devices.\n\n\nCreated with:\n  gclient setdep -r src/third_party/catapult@6a67dd77dfc3\n\nThe AutoRoll server is located here: https://catapult-roll.skia.org\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+/master/autoroll/README.md\n\nIf the roll is causing failures, please contact the current sheriff, who should\nbe CC'd on the roll, and stop the roller if necessary.\n\nCQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel\n\nBUG=chromium:758566\nTBR=sullivan@chromium.org\n\nChange-Id: I21b7d9a9d8d414220c338583ca44b04263a5c27f\nReviewed-on: https://chromium-review.googlesource.com/1152618\nReviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>\nCommit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>\nCr-Commit-Position: refs/heads/master@{#578653}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/c36aa32695fe893d721015ee2566b79ba65d3d1d"},{"sha":"b2542bdc1868d86fb2b405bf160e31c55e61fdaf","author":{"name":"Jose Dapena Paz","email":"b5088db3fada4757e1f7efee9638369134c6a04c@lge.com"},"message":"GCC: fix regressions after declaring constexpr many geometry types methods.\n\nCommit 19105bf introduced using constexpr for lots of methods. It introduced\ntwo kinds of regressions building with GCC:\n- Some depended on FloatSize::IsZero, which is not only non constexpr, but\n  it cannot be constexpr either, as it depends on fabs, that is not constexpr.\n- Some depended on methods that were not constexpr (but we could fix them to\n  be, as FloatQuat::P1() or FloatSize::SetWidth().\n\nThose do not break in clang as it is a less picky in the scenario of\ndefining a constexpr method that depends on non-constexpr methods.\n\nThis patch fixes usage of constexpr in both cases adding constexpr\nimplementations when needed. In particular it replaces fabs calls that are\nnot constexpr at least in libc++ with a constexpr replacement, fixing\nGCC build and adding some extra constexpr that were missing.\n\nBug: 819294\nChange-Id: Ia1143ad4be1067bb8a918f0224b657523599ea97\nReviewed-on: https://chromium-review.googlesource.com/1150529\nCommit-Queue: José Dapena Paz <jose.dapena@lge.com>\nReviewed-by: Florin Malita <fmalita@chromium.org>\nCr-Commit-Position: refs/heads/master@{#578654}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/b2542bdc1868d86fb2b405bf160e31c55e61fdaf"},{"sha":"a27db4a5ecc8dc63f202a4d949a3a7de83ce4275","author":{"name":"Ioana Pandele","email":"c9d464a72319e340e411da43defcae6540e46d40@chromium.org"},"message":"Remove link from password generation dialog string\n\nThe string explaining that generated passwords are saved by the Chrome\nhas changed and does not include a link anymore. This CL removes the\nlink logic from the modal dialog.\n\nBug:867572,835234\n\nChange-Id: Id984e5cebbf6bf7fc6e98006ca06b997cdf2575d\nReviewed-on: https://chromium-review.googlesource.com/1151204\nCommit-Queue: Ioana Pandele <ioanap@chromium.org>\nReviewed-by: Ted Choc <tedchoc@chromium.org>\nReviewed-by: Vasilii Sukhanov <vasilii@chromium.org>\nCr-Commit-Position: refs/heads/master@{#578655}","distinct":true,"url":"https://api.github.com/repos/chromium/chromium/commits/a27db4a5ecc8dc63f202a4d949a3a7de83ce4275"}]}
{"actor":{"display_login":"aarongable"}}