{"action":"created","comment":{"url":"https://api.github.com/repos/GQCG/ci/pulls/comments/171925620","pull_request_review_id":100869032,"id":171925620,"diff_hunk":"@@ -8,14 +8,15 @@ doci::SparseHamiltonian::SparseHamiltonian(size_t nbf) {\n }\n \n void doci::SparseHamiltonian::solve() {\n-\tsize_t iteration = std::sqrt(nbf); //TODO: figure out what the iteration amount should be\n+\tsize_t num_eigenvalues = 1;\n+\tsize_t max_iterations = std::max<size_t>(std::sqrt(nbf),num_eigenvalues+1); //TODO: figure out what the iteration amount should be\n \n \t// Diagonalize the Hamiltonian matrix\n \t// Construct matrix operation object using the wrapper class SparseGenMatProd\n \tSpectra::SparseSymMatProd<double> op (hamiltonian);\n \n \t// Construct eigen solver object, requesting the largest (in magnitude) x eigenvalues in y iterations.\n-\tSpectra::SymEigsSolver< double, Spectra::SMALLEST_ALGE, Spectra::SparseSymMatProd<double> > eigs(&op, 1, iteration);\n+\tSpectra::SymEigsSolver< double, Spectra::SMALLEST_ALGE, Spectra::SparseSymMatProd<double> > eigs(&op, num_eigenvalues, max_iterations);","path":"src/SparseHamiltonian.cpp","position":null,"original_position":14,"commit_id":"bcc2011923e79906db621c4b34b74732a7f97a66","original_commit_id":"bcc2011923e79906db621c4b34b74732a7f97a66","user":{"login":"lelemmen","id":23526798,"avatar_url":"https://avatars0.githubusercontent.com/u/23526798?v=4","gravatar_id":"","url":"https://api.github.com/users/lelemmen","html_url":"https://github.com/lelemmen","followers_url":"https://api.github.com/users/lelemmen/followers","following_url":"https://api.github.com/users/lelemmen/following{/other_user}","gists_url":"https://api.github.com/users/lelemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/lelemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelemmen/subscriptions","organizations_url":"https://api.github.com/users/lelemmen/orgs","repos_url":"https://api.github.com/users/lelemmen/repos","events_url":"https://api.github.com/users/lelemmen/events{/privacy}","received_events_url":"https://api.github.com/users/lelemmen/received_events","type":"User","site_admin":false},"body":"Looks better, indeed.","created_at":"2018-03-02T18:30:02Z","updated_at":"2018-03-02T18:30:02Z","html_url":"https://github.com/GQCG/ci/pull/10#discussion_r171925620","pull_request_url":"https://api.github.com/repos/GQCG/ci/pulls/10","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/GQCG/ci/pulls/comments/171925620"},"html":{"href":"https://github.com/GQCG/ci/pull/10#discussion_r171925620"},"pull_request":{"href":"https://api.github.com/repos/GQCG/ci/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/GQCG/ci/pulls/10","id":172372860,"html_url":"https://github.com/GQCG/ci/pull/10","diff_url":"https://github.com/GQCG/ci/pull/10.diff","patch_url":"https://github.com/GQCG/ci/pull/10.patch","issue_url":"https://api.github.com/repos/GQCG/ci/issues/10","number":10,"state":"open","locked":false,"title":"Feature/sparse","user":{"login":"lelemmen","id":23526798,"avatar_url":"https://avatars0.githubusercontent.com/u/23526798?v=4","gravatar_id":"","url":"https://api.github.com/users/lelemmen","html_url":"https://github.com/lelemmen","followers_url":"https://api.github.com/users/lelemmen/followers","following_url":"https://api.github.com/users/lelemmen/following{/other_user}","gists_url":"https://api.github.com/users/lelemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/lelemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelemmen/subscriptions","organizations_url":"https://api.github.com/users/lelemmen/orgs","repos_url":"https://api.github.com/users/lelemmen/repos","events_url":"https://api.github.com/users/lelemmen/events{/privacy}","received_events_url":"https://api.github.com/users/lelemmen/received_events","type":"User","site_admin":false},"body":"@tmhuysen's Sparse algorithm.","created_at":"2018-03-01T22:31:41Z","updated_at":"2018-03-02T18:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2f68e2904dcf314deea561cdae09a946177614a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GQCG/ci/pulls/10/commits","review_comments_url":"https://api.github.com/repos/GQCG/ci/pulls/10/comments","review_comment_url":"https://api.github.com/repos/GQCG/ci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GQCG/ci/issues/10/comments","statuses_url":"https://api.github.com/repos/GQCG/ci/statuses/bcc2011923e79906db621c4b34b74732a7f97a66","head":{"label":"GQCG:feature/sparse","ref":"feature/sparse","sha":"bcc2011923e79906db621c4b34b74732a7f97a66","user":{"login":"GQCG","id":35603937,"avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"repo":{"id":118141464,"name":"ci","full_name":"GQCG/ci","owner":{"login":"GQCG","id":35603937,"avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GQCG/ci","description":"A C++ library for performing CI calculations","fork":false,"url":"https://api.github.com/repos/GQCG/ci","forks_url":"https://api.github.com/repos/GQCG/ci/forks","keys_url":"https://api.github.com/repos/GQCG/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GQCG/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GQCG/ci/teams","hooks_url":"https://api.github.com/repos/GQCG/ci/hooks","issue_events_url":"https://api.github.com/repos/GQCG/ci/issues/events{/number}","events_url":"https://api.github.com/repos/GQCG/ci/events","assignees_url":"https://api.github.com/repos/GQCG/ci/assignees{/user}","branches_url":"https://api.github.com/repos/GQCG/ci/branches{/branch}","tags_url":"https://api.github.com/repos/GQCG/ci/tags","blobs_url":"https://api.github.com/repos/GQCG/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GQCG/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GQCG/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/GQCG/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GQCG/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/GQCG/ci/languages","stargazers_url":"https://api.github.com/repos/GQCG/ci/stargazers","contributors_url":"https://api.github.com/repos/GQCG/ci/contributors","subscribers_url":"https://api.github.com/repos/GQCG/ci/subscribers","subscription_url":"https://api.github.com/repos/GQCG/ci/subscription","commits_url":"https://api.github.com/repos/GQCG/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/GQCG/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/GQCG/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/GQCG/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/GQCG/ci/contents/{+path}","compare_url":"https://api.github.com/repos/GQCG/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GQCG/ci/merges","archive_url":"https://api.github.com/repos/GQCG/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GQCG/ci/downloads","issues_url":"https://api.github.com/repos/GQCG/ci/issues{/number}","pulls_url":"https://api.github.com/repos/GQCG/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/GQCG/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/GQCG/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GQCG/ci/labels{/name}","releases_url":"https://api.github.com/repos/GQCG/ci/releases{/id}","deployments_url":"https://api.github.com/repos/GQCG/ci/deployments","created_at":"2018-01-19T15:21:17Z","updated_at":"2018-03-01T16:46:35Z","pushed_at":"2018-03-02T18:12:30Z","git_url":"git://github.com/GQCG/ci.git","ssh_url":"git@github.com:GQCG/ci.git","clone_url":"https://github.com/GQCG/ci.git","svn_url":"https://github.com/GQCG/ci","homepage":"","size":5247,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"GQCG:develop","ref":"develop","sha":"f93afa80660ca7e0df40e6aa6a0e8556f0776942","user":{"login":"GQCG","id":35603937,"avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"repo":{"id":118141464,"name":"ci","full_name":"GQCG/ci","owner":{"login":"GQCG","id":35603937,"avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GQCG/ci","description":"A C++ library for performing CI calculations","fork":false,"url":"https://api.github.com/repos/GQCG/ci","forks_url":"https://api.github.com/repos/GQCG/ci/forks","keys_url":"https://api.github.com/repos/GQCG/ci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GQCG/ci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GQCG/ci/teams","hooks_url":"https://api.github.com/repos/GQCG/ci/hooks","issue_events_url":"https://api.github.com/repos/GQCG/ci/issues/events{/number}","events_url":"https://api.github.com/repos/GQCG/ci/events","assignees_url":"https://api.github.com/repos/GQCG/ci/assignees{/user}","branches_url":"https://api.github.com/repos/GQCG/ci/branches{/branch}","tags_url":"https://api.github.com/repos/GQCG/ci/tags","blobs_url":"https://api.github.com/repos/GQCG/ci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GQCG/ci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GQCG/ci/git/refs{/sha}","trees_url":"https://api.github.com/repos/GQCG/ci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GQCG/ci/statuses/{sha}","languages_url":"https://api.github.com/repos/GQCG/ci/languages","stargazers_url":"https://api.github.com/repos/GQCG/ci/stargazers","contributors_url":"https://api.github.com/repos/GQCG/ci/contributors","subscribers_url":"https://api.github.com/repos/GQCG/ci/subscribers","subscription_url":"https://api.github.com/repos/GQCG/ci/subscription","commits_url":"https://api.github.com/repos/GQCG/ci/commits{/sha}","git_commits_url":"https://api.github.com/repos/GQCG/ci/git/commits{/sha}","comments_url":"https://api.github.com/repos/GQCG/ci/comments{/number}","issue_comment_url":"https://api.github.com/repos/GQCG/ci/issues/comments{/number}","contents_url":"https://api.github.com/repos/GQCG/ci/contents/{+path}","compare_url":"https://api.github.com/repos/GQCG/ci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GQCG/ci/merges","archive_url":"https://api.github.com/repos/GQCG/ci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GQCG/ci/downloads","issues_url":"https://api.github.com/repos/GQCG/ci/issues{/number}","pulls_url":"https://api.github.com/repos/GQCG/ci/pulls{/number}","milestones_url":"https://api.github.com/repos/GQCG/ci/milestones{/number}","notifications_url":"https://api.github.com/repos/GQCG/ci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GQCG/ci/labels{/name}","releases_url":"https://api.github.com/repos/GQCG/ci/releases{/id}","deployments_url":"https://api.github.com/repos/GQCG/ci/deployments","created_at":"2018-01-19T15:21:17Z","updated_at":"2018-03-01T16:46:35Z","pushed_at":"2018-03-02T18:12:30Z","git_url":"git://github.com/GQCG/ci.git","ssh_url":"git@github.com:GQCG/ci.git","clone_url":"https://github.com/GQCG/ci.git","svn_url":"https://github.com/GQCG/ci","homepage":"","size":5247,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/GQCG/ci/pulls/10"},"html":{"href":"https://github.com/GQCG/ci/pull/10"},"issue":{"href":"https://api.github.com/repos/GQCG/ci/issues/10"},"comments":{"href":"https://api.github.com/repos/GQCG/ci/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/GQCG/ci/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/GQCG/ci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GQCG/ci/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/GQCG/ci/statuses/bcc2011923e79906db621c4b34b74732a7f97a66"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lelemmen"}}