{"action":"created","comment":{"url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/comments/169643235","pull_request_review_id":98200997,"id":169643235,"diff_hunk":"@@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/)\n The format is based on [Keep a Changelog](http://keepachangelog.com/).\n \n ## [Unreleased]\n+### Added\n+- `vars/Fedora.yml`, `tasks/Fedora/main.yml`: Add Fedora as a client OS. Tested on Fedora 25, but should work on newer releases as well.","path":"CHANGELOG.md","position":5,"original_position":5,"commit_id":"ef1cedc02be4fe5949aed67cf8fa15289736fc65","original_commit_id":"ef1cedc02be4fe5949aed67cf8fa15289736fc65","user":{"login":"jaredledvina","id":15491304,"avatar_url":"https://avatars3.githubusercontent.com/u/15491304?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredledvina","html_url":"https://github.com/jaredledvina","followers_url":"https://api.github.com/users/jaredledvina/followers","following_url":"https://api.github.com/users/jaredledvina/following{/other_user}","gists_url":"https://api.github.com/users/jaredledvina/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredledvina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredledvina/subscriptions","organizations_url":"https://api.github.com/users/jaredledvina/orgs","repos_url":"https://api.github.com/users/jaredledvina/repos","events_url":"https://api.github.com/users/jaredledvina/events{/privacy}","received_events_url":"https://api.github.com/users/jaredledvina/received_events","type":"User","site_admin":false},"body":"I would actually re-word this a bit to say tested on fedora27 since you were able to get the build to pass (which is excellent btw!). ","created_at":"2018-02-21T13:57:45Z","updated_at":"2018-02-21T13:57:46Z","html_url":"https://github.com/sensu/sensu-ansible/pull/143#discussion_r169643235","pull_request_url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/comments/169643235"},"html":{"href":"https://github.com/sensu/sensu-ansible/pull/143#discussion_r169643235"},"pull_request":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143","id":170425030,"html_url":"https://github.com/sensu/sensu-ansible/pull/143","diff_url":"https://github.com/sensu/sensu-ansible/pull/143.diff","patch_url":"https://github.com/sensu/sensu-ansible/pull/143.patch","issue_url":"https://api.github.com/repos/sensu/sensu-ansible/issues/143","number":143,"state":"open","locked":false,"title":"Add fedora as OS","user":{"login":"danragnar","id":31411941,"avatar_url":"https://avatars2.githubusercontent.com/u/31411941?v=4","gravatar_id":"","url":"https://api.github.com/users/danragnar","html_url":"https://github.com/danragnar","followers_url":"https://api.github.com/users/danragnar/followers","following_url":"https://api.github.com/users/danragnar/following{/other_user}","gists_url":"https://api.github.com/users/danragnar/gists{/gist_id}","starred_url":"https://api.github.com/users/danragnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danragnar/subscriptions","organizations_url":"https://api.github.com/users/danragnar/orgs","repos_url":"https://api.github.com/users/danragnar/repos","events_url":"https://api.github.com/users/danragnar/events{/privacy}","received_events_url":"https://api.github.com/users/danragnar/received_events","type":"User","site_admin":false},"body":"This PR allows Fedora to be used in Sensu. At first I only added it as a client OS, but since testing only for client parts seems inconvenient, I added it as a \"master\" candidate as well as well as a distro in the travis file. I have only tested it here as a client OS, and that's on Fedora 25, so lets see if the tests go through... ","created_at":"2018-02-21T10:11:31Z","updated_at":"2018-02-21T13:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b12f61742ae995c20bf26c95e6547b979d4718","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143/commits","review_comments_url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143/comments","review_comment_url":"https://api.github.com/repos/sensu/sensu-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensu/sensu-ansible/issues/143/comments","statuses_url":"https://api.github.com/repos/sensu/sensu-ansible/statuses/ef1cedc02be4fe5949aed67cf8fa15289736fc65","head":{"label":"danragnar:fix/fedora","ref":"fix/fedora","sha":"ef1cedc02be4fe5949aed67cf8fa15289736fc65","user":{"login":"danragnar","id":31411941,"avatar_url":"https://avatars2.githubusercontent.com/u/31411941?v=4","gravatar_id":"","url":"https://api.github.com/users/danragnar","html_url":"https://github.com/danragnar","followers_url":"https://api.github.com/users/danragnar/followers","following_url":"https://api.github.com/users/danragnar/following{/other_user}","gists_url":"https://api.github.com/users/danragnar/gists{/gist_id}","starred_url":"https://api.github.com/users/danragnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danragnar/subscriptions","organizations_url":"https://api.github.com/users/danragnar/orgs","repos_url":"https://api.github.com/users/danragnar/repos","events_url":"https://api.github.com/users/danragnar/events{/privacy}","received_events_url":"https://api.github.com/users/danragnar/received_events","type":"User","site_admin":false},"repo":{"id":120823512,"name":"sensu-ansible","full_name":"danragnar/sensu-ansible","owner":{"login":"danragnar","id":31411941,"avatar_url":"https://avatars2.githubusercontent.com/u/31411941?v=4","gravatar_id":"","url":"https://api.github.com/users/danragnar","html_url":"https://github.com/danragnar","followers_url":"https://api.github.com/users/danragnar/followers","following_url":"https://api.github.com/users/danragnar/following{/other_user}","gists_url":"https://api.github.com/users/danragnar/gists{/gist_id}","starred_url":"https://api.github.com/users/danragnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danragnar/subscriptions","organizations_url":"https://api.github.com/users/danragnar/orgs","repos_url":"https://api.github.com/users/danragnar/repos","events_url":"https://api.github.com/users/danragnar/events{/privacy}","received_events_url":"https://api.github.com/users/danragnar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danragnar/sensu-ansible","description":"An Ansible role to deploy a fully dynamic Sensu stack!","fork":true,"url":"https://api.github.com/repos/danragnar/sensu-ansible","forks_url":"https://api.github.com/repos/danragnar/sensu-ansible/forks","keys_url":"https://api.github.com/repos/danragnar/sensu-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danragnar/sensu-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danragnar/sensu-ansible/teams","hooks_url":"https://api.github.com/repos/danragnar/sensu-ansible/hooks","issue_events_url":"https://api.github.com/repos/danragnar/sensu-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/danragnar/sensu-ansible/events","assignees_url":"https://api.github.com/repos/danragnar/sensu-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/danragnar/sensu-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/danragnar/sensu-ansible/tags","blobs_url":"https://api.github.com/repos/danragnar/sensu-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danragnar/sensu-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danragnar/sensu-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/danragnar/sensu-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danragnar/sensu-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/danragnar/sensu-ansible/languages","stargazers_url":"https://api.github.com/repos/danragnar/sensu-ansible/stargazers","contributors_url":"https://api.github.com/repos/danragnar/sensu-ansible/contributors","subscribers_url":"https://api.github.com/repos/danragnar/sensu-ansible/subscribers","subscription_url":"https://api.github.com/repos/danragnar/sensu-ansible/subscription","commits_url":"https://api.github.com/repos/danragnar/sensu-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/danragnar/sensu-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/danragnar/sensu-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/danragnar/sensu-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/danragnar/sensu-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/danragnar/sensu-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danragnar/sensu-ansible/merges","archive_url":"https://api.github.com/repos/danragnar/sensu-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danragnar/sensu-ansible/downloads","issues_url":"https://api.github.com/repos/danragnar/sensu-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/danragnar/sensu-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/danragnar/sensu-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/danragnar/sensu-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danragnar/sensu-ansible/labels{/name}","releases_url":"https://api.github.com/repos/danragnar/sensu-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/danragnar/sensu-ansible/deployments","created_at":"2018-02-08T22:03:35Z","updated_at":"2018-02-08T22:03:36Z","pushed_at":"2018-02-21T12:10:28Z","git_url":"git://github.com/danragnar/sensu-ansible.git","ssh_url":"git@github.com:danragnar/sensu-ansible.git","clone_url":"https://github.com/danragnar/sensu-ansible.git","svn_url":"https://github.com/danragnar/sensu-ansible","homepage":"https://ansible-sensu.readthedocs.io","size":264,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sensu:master","ref":"master","sha":"68f42ed082daabe803e704b4bc6817e540cdd5fe","user":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":35729277,"name":"sensu-ansible","full_name":"sensu/sensu-ansible","owner":{"login":"sensu","id":1648901,"avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-ansible","description":"An Ansible role to deploy a fully dynamic Sensu stack!","fork":false,"url":"https://api.github.com/repos/sensu/sensu-ansible","forks_url":"https://api.github.com/repos/sensu/sensu-ansible/forks","keys_url":"https://api.github.com/repos/sensu/sensu-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-ansible/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-ansible/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-ansible/events","assignees_url":"https://api.github.com/repos/sensu/sensu-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-ansible/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-ansible/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-ansible/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-ansible/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-ansible/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-ansible/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-ansible/merges","archive_url":"https://api.github.com/repos/sensu/sensu-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-ansible/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-ansible/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-ansible/deployments","created_at":"2015-05-16T15:37:45Z","updated_at":"2018-02-21T01:20:12Z","pushed_at":"2018-02-21T12:10:29Z","git_url":"git://github.com/sensu/sensu-ansible.git","ssh_url":"git@github.com:sensu/sensu-ansible.git","clone_url":"https://github.com/sensu/sensu-ansible.git","svn_url":"https://github.com/sensu/sensu-ansible","homepage":"https://ansible-sensu.readthedocs.io","size":255,"stargazers_count":100,"watchers_count":100,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":79,"open_issues":10,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143"},"html":{"href":"https://github.com/sensu/sensu-ansible/pull/143"},"issue":{"href":"https://api.github.com/repos/sensu/sensu-ansible/issues/143"},"comments":{"href":"https://api.github.com/repos/sensu/sensu-ansible/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensu/sensu-ansible/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/sensu/sensu-ansible/statuses/ef1cedc02be4fe5949aed67cf8fa15289736fc65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaredledvina"}}