{"action":"created","comment":{"url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/comments/189085503","pull_request_review_id":121195703,"id":189085503,"diff_hunk":"@@ -1017,6 +1019,22 @@ private TResult ExecuteWriteOperation<TResult>(IClientSessionHandle session, IWr\n             }\n         }\n \n+        private ReadPreference GetReadPreference(IClientSession session)","path":"src/MongoDB.Driver/MongoCollectionImpl.cs","position":24,"original_position":24,"commit_id":"56ac72cad9223702c87bd84dada72b5a735baebf","original_commit_id":"56ac72cad9223702c87bd84dada72b5a735baebf","user":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"body":"The logic is already at the ExecuteReadOperation level.\r\n\r\nThis is a helper method that is called from ExecuteReadOperation and ExecuteReadOperationAsync. It is factored into a helper method to avoid code duplication.\r\n\r\nWould renaming the method help? GetReadPreferenceForReadOperation?","created_at":"2018-05-17T20:10:19Z","updated_at":"2018-05-17T20:11:25Z","html_url":"https://github.com/rstam/mongo-csharp-driver/pull/22#discussion_r189085503","pull_request_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/comments/189085503"},"html":{"href":"https://github.com/rstam/mongo-csharp-driver/pull/22#discussion_r189085503"},"pull_request":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22"}},"in_reply_to_id":188643175},"pull_request":{"url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22","id":187385429,"html_url":"https://github.com/rstam/mongo-csharp-driver/pull/22","diff_url":"https://github.com/rstam/mongo-csharp-driver/pull/22.diff","patch_url":"https://github.com/rstam/mongo-csharp-driver/pull/22.patch","issue_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/22","number":22,"state":"open","locked":false,"title":"CSHARP-2221: Add ReadPreference to TransactionOptions and update JSON driven transaction tests","user":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"body":"\r\n\r\nEvergreen patch build:\r\n\r\nhttps://evergreen.mongodb.com/version/5af5433cc9ec4463a9755b94\r\n","created_at":"2018-05-11T07:17:12Z","updated_at":"2018-05-17T20:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d41eeea7b0b896d79459c04c8a81fd80cbbfa4a6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vincentkam","id":33040432,"avatar_url":"https://avatars0.githubusercontent.com/u/33040432?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentkam","html_url":"https://github.com/vincentkam","followers_url":"https://api.github.com/users/vincentkam/followers","following_url":"https://api.github.com/users/vincentkam/following{/other_user}","gists_url":"https://api.github.com/users/vincentkam/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentkam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentkam/subscriptions","organizations_url":"https://api.github.com/users/vincentkam/orgs","repos_url":"https://api.github.com/users/vincentkam/repos","events_url":"https://api.github.com/users/vincentkam/events{/privacy}","received_events_url":"https://api.github.com/users/vincentkam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22/commits","review_comments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22/comments","review_comment_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/22/comments","statuses_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/statuses/56ac72cad9223702c87bd84dada72b5a735baebf","head":{"label":"rstam:csharp2221b","ref":"csharp2221b","sha":"56ac72cad9223702c87bd84dada72b5a735baebf","user":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"repo":{"id":4120199,"name":"mongo-csharp-driver","full_name":"rstam/mongo-csharp-driver","owner":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rstam/mongo-csharp-driver","description":null,"fork":true,"url":"https://api.github.com/repos/rstam/mongo-csharp-driver","forks_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/forks","keys_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/teams","hooks_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/hooks","issue_events_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/events{/number}","events_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/events","assignees_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/assignees{/user}","branches_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/branches{/branch}","tags_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/tags","blobs_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/languages","stargazers_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/stargazers","contributors_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/contributors","subscribers_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/subscribers","subscription_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/subscription","commits_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/contents/{+path}","compare_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/merges","archive_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/downloads","issues_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues{/number}","pulls_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/labels{/name}","releases_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/releases{/id}","deployments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/deployments","created_at":"2012-04-24T02:11:46Z","updated_at":"2018-05-17T19:57:50Z","pushed_at":"2018-05-17T19:57:48Z","git_url":"git://github.com/rstam/mongo-csharp-driver.git","ssh_url":"git@github.com:rstam/mongo-csharp-driver.git","clone_url":"https://github.com/rstam/mongo-csharp-driver.git","svn_url":"https://github.com/rstam/mongo-csharp-driver","homepage":"","size":105048,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"rstam:master","ref":"master","sha":"4aef32262eccdbc39b17283723d16a2b3403d0c2","user":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"repo":{"id":4120199,"name":"mongo-csharp-driver","full_name":"rstam/mongo-csharp-driver","owner":{"login":"rstam","id":275022,"avatar_url":"https://avatars0.githubusercontent.com/u/275022?v=4","gravatar_id":"","url":"https://api.github.com/users/rstam","html_url":"https://github.com/rstam","followers_url":"https://api.github.com/users/rstam/followers","following_url":"https://api.github.com/users/rstam/following{/other_user}","gists_url":"https://api.github.com/users/rstam/gists{/gist_id}","starred_url":"https://api.github.com/users/rstam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstam/subscriptions","organizations_url":"https://api.github.com/users/rstam/orgs","repos_url":"https://api.github.com/users/rstam/repos","events_url":"https://api.github.com/users/rstam/events{/privacy}","received_events_url":"https://api.github.com/users/rstam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rstam/mongo-csharp-driver","description":null,"fork":true,"url":"https://api.github.com/repos/rstam/mongo-csharp-driver","forks_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/forks","keys_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/teams","hooks_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/hooks","issue_events_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/events{/number}","events_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/events","assignees_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/assignees{/user}","branches_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/branches{/branch}","tags_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/tags","blobs_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/languages","stargazers_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/stargazers","contributors_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/contributors","subscribers_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/subscribers","subscription_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/subscription","commits_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/contents/{+path}","compare_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/merges","archive_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/downloads","issues_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues{/number}","pulls_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/labels{/name}","releases_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/releases{/id}","deployments_url":"https://api.github.com/repos/rstam/mongo-csharp-driver/deployments","created_at":"2012-04-24T02:11:46Z","updated_at":"2018-05-17T19:57:50Z","pushed_at":"2018-05-17T19:57:48Z","git_url":"git://github.com/rstam/mongo-csharp-driver.git","ssh_url":"git@github.com:rstam/mongo-csharp-driver.git","clone_url":"https://github.com/rstam/mongo-csharp-driver.git","svn_url":"https://github.com/rstam/mongo-csharp-driver","homepage":"","size":105048,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22"},"html":{"href":"https://github.com/rstam/mongo-csharp-driver/pull/22"},"issue":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/22"},"comments":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/rstam/mongo-csharp-driver/statuses/56ac72cad9223702c87bd84dada72b5a735baebf"}},"author_association":"OWNER"}}
{"actor":{"display_login":"rstam"}}