{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21","id":166630710,"html_url":"https://github.com/apache/jackrabbit-filevault/pull/21","diff_url":"https://github.com/apache/jackrabbit-filevault/pull/21.diff","patch_url":"https://github.com/apache/jackrabbit-filevault/pull/21.patch","issue_url":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/21","number":21,"state":"closed","locked":false,"title":"Add rudimentary support for controlling the line separator","user":{"login":"beaudet","id":77699,"avatar_url":"https://avatars1.githubusercontent.com/u/77699?v=4","gravatar_id":"","url":"https://api.github.com/users/beaudet","html_url":"https://github.com/beaudet","followers_url":"https://api.github.com/users/beaudet/followers","following_url":"https://api.github.com/users/beaudet/following{/other_user}","gists_url":"https://api.github.com/users/beaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/beaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaudet/subscriptions","organizations_url":"https://api.github.com/users/beaudet/orgs","repos_url":"https://api.github.com/users/beaudet/repos","events_url":"https://api.github.com/users/beaudet/events{/privacy}","received_events_url":"https://api.github.com/users/beaudet/received_events","type":"User","site_admin":false},"body":"Requiring SVN settings to change in order to adapt to vlt's inability to control the line separator being used, combined with the surprising (fact?) that it's impossible to create a working windows batch file that passes chr(10) on the command line to -Dline.separator and the fact that it's a bit tricky to do with bash, led me to creating this patch that allows a custom vlt.line.separator system property to be set to a text value of either LF or CRLF which is then read in main() and set accordingly.  I realize that this approach would probably need to be adapted to conform with vlt's settings (or at least to accept a new command line option) but I didn't have the time to investigate that route.  I'm hoping the existence of this pull request and the utility it provides in giving teams control over the line separator so that the JCR, version control systems, and vlt can work harmoniously together regardless of which operating system is used.  For example, since vlt on Mac presumably defaults to LF, a team comprised of developers using Windows and Macs cannot all use vlt since they would be creating files that are detected by their version control system as being different due to the line separator differences that vlt creates across those systems.","created_at":"2018-02-01T19:32:58Z","updated_at":"2018-04-03T00:47:19Z","closed_at":"2018-04-03T00:47:19Z","merged_at":null,"merge_commit_sha":"035fe9219e70c83b33dbb7f30196dc7b505d4b12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21/commits","review_comments_url":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21/comments","review_comment_url":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/21/comments","statuses_url":"https://api.github.com/repos/apache/jackrabbit-filevault/statuses/8a4a29238890424b050c5e9b1e8f5a31a8dbfe58","head":{"label":"beaudet:trunk","ref":"trunk","sha":"8a4a29238890424b050c5e9b1e8f5a31a8dbfe58","user":{"login":"beaudet","id":77699,"avatar_url":"https://avatars1.githubusercontent.com/u/77699?v=4","gravatar_id":"","url":"https://api.github.com/users/beaudet","html_url":"https://github.com/beaudet","followers_url":"https://api.github.com/users/beaudet/followers","following_url":"https://api.github.com/users/beaudet/following{/other_user}","gists_url":"https://api.github.com/users/beaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/beaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaudet/subscriptions","organizations_url":"https://api.github.com/users/beaudet/orgs","repos_url":"https://api.github.com/users/beaudet/repos","events_url":"https://api.github.com/users/beaudet/events{/privacy}","received_events_url":"https://api.github.com/users/beaudet/received_events","type":"User","site_admin":false},"repo":{"id":119686250,"name":"jackrabbit-filevault","full_name":"beaudet/jackrabbit-filevault","owner":{"login":"beaudet","id":77699,"avatar_url":"https://avatars1.githubusercontent.com/u/77699?v=4","gravatar_id":"","url":"https://api.github.com/users/beaudet","html_url":"https://github.com/beaudet","followers_url":"https://api.github.com/users/beaudet/followers","following_url":"https://api.github.com/users/beaudet/following{/other_user}","gists_url":"https://api.github.com/users/beaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/beaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaudet/subscriptions","organizations_url":"https://api.github.com/users/beaudet/orgs","repos_url":"https://api.github.com/users/beaudet/repos","events_url":"https://api.github.com/users/beaudet/events{/privacy}","received_events_url":"https://api.github.com/users/beaudet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beaudet/jackrabbit-filevault","description":"Mirror of Apache Jackrabbit FileVault","fork":true,"url":"https://api.github.com/repos/beaudet/jackrabbit-filevault","forks_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/forks","keys_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/teams","hooks_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/hooks","issue_events_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/issues/events{/number}","events_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/events","assignees_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/assignees{/user}","branches_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/branches{/branch}","tags_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/tags","blobs_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/git/refs{/sha}","trees_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/statuses/{sha}","languages_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/languages","stargazers_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/stargazers","contributors_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/contributors","subscribers_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/subscribers","subscription_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/subscription","commits_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/commits{/sha}","git_commits_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/git/commits{/sha}","comments_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/comments{/number}","issue_comment_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/issues/comments{/number}","contents_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/contents/{+path}","compare_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/merges","archive_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/downloads","issues_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/issues{/number}","pulls_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/pulls{/number}","milestones_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/milestones{/number}","notifications_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/labels{/name}","releases_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/releases{/id}","deployments_url":"https://api.github.com/repos/beaudet/jackrabbit-filevault/deployments","created_at":"2018-01-31T12:47:29Z","updated_at":"2018-01-31T12:47:32Z","pushed_at":"2018-02-01T19:26:34Z","git_url":"git://github.com/beaudet/jackrabbit-filevault.git","ssh_url":"git@github.com:beaudet/jackrabbit-filevault.git","clone_url":"https://github.com/beaudet/jackrabbit-filevault.git","svn_url":"https://github.com/beaudet/jackrabbit-filevault","homepage":null,"size":2332,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"e77d5400606a16f07c6aa788513ef91d312c765a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":16021499,"name":"jackrabbit-filevault","full_name":"apache/jackrabbit-filevault","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/jackrabbit-filevault","description":"Mirror of Apache Jackrabbit FileVault","fork":false,"url":"https://api.github.com/repos/apache/jackrabbit-filevault","forks_url":"https://api.github.com/repos/apache/jackrabbit-filevault/forks","keys_url":"https://api.github.com/repos/apache/jackrabbit-filevault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/jackrabbit-filevault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/jackrabbit-filevault/teams","hooks_url":"https://api.github.com/repos/apache/jackrabbit-filevault/hooks","issue_events_url":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/events{/number}","events_url":"https://api.github.com/repos/apache/jackrabbit-filevault/events","assignees_url":"https://api.github.com/repos/apache/jackrabbit-filevault/assignees{/user}","branches_url":"https://api.github.com/repos/apache/jackrabbit-filevault/branches{/branch}","tags_url":"https://api.github.com/repos/apache/jackrabbit-filevault/tags","blobs_url":"https://api.github.com/repos/apache/jackrabbit-filevault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/jackrabbit-filevault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/jackrabbit-filevault/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/jackrabbit-filevault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/jackrabbit-filevault/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/jackrabbit-filevault/languages","stargazers_url":"https://api.github.com/repos/apache/jackrabbit-filevault/stargazers","contributors_url":"https://api.github.com/repos/apache/jackrabbit-filevault/contributors","subscribers_url":"https://api.github.com/repos/apache/jackrabbit-filevault/subscribers","subscription_url":"https://api.github.com/repos/apache/jackrabbit-filevault/subscription","commits_url":"https://api.github.com/repos/apache/jackrabbit-filevault/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/jackrabbit-filevault/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/jackrabbit-filevault/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/jackrabbit-filevault/contents/{+path}","compare_url":"https://api.github.com/repos/apache/jackrabbit-filevault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/jackrabbit-filevault/merges","archive_url":"https://api.github.com/repos/apache/jackrabbit-filevault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/jackrabbit-filevault/downloads","issues_url":"https://api.github.com/repos/apache/jackrabbit-filevault/issues{/number}","pulls_url":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/jackrabbit-filevault/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/jackrabbit-filevault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/jackrabbit-filevault/labels{/name}","releases_url":"https://api.github.com/repos/apache/jackrabbit-filevault/releases{/id}","deployments_url":"https://api.github.com/repos/apache/jackrabbit-filevault/deployments","created_at":"2014-01-18T08:00:07Z","updated_at":"2018-03-27T05:47:26Z","pushed_at":"2018-04-03T00:47:17Z","git_url":"git://github.com/apache/jackrabbit-filevault.git","ssh_url":"git@github.com:apache/jackrabbit-filevault.git","clone_url":"https://github.com/apache/jackrabbit-filevault.git","svn_url":"https://github.com/apache/jackrabbit-filevault","homepage":null,"size":2383,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":8,"watchers":18,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21"},"html":{"href":"https://github.com/apache/jackrabbit-filevault/pull/21"},"issue":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/21"},"comments":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/apache/jackrabbit-filevault/statuses/8a4a29238890424b050c5e9b1e8f5a31a8dbfe58"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":33,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"asfgit"}}