{"action":"created","comment":{"url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/comments/174125778","pull_request_review_id":103424029,"id":174125778,"diff_hunk":"@@ -141,18 +146,42 @@ def get(self, username):\n         return render_template(\"user/profile.html\", user=user)\n \n \n-register_view(user, routes=['/settings/email'], view_func=ChangeEmail.as_view('change_email'))\n-register_view(user, routes=['/settings/general'], view_func=UserSettings.as_view('settings'))\n-register_view(\n-    user, routes=['/settings/password'], view_func=ChangePassword.as_view('change_password')\n-)\n-register_view(\n-    user,\n-    routes=[\"/settings/user-details\"],\n-    view_func=ChangeUserDetails.as_view('change_user_details')\n-)\n-register_view(user, routes=['/<username>/posts'], view_func=AllUserPosts.as_view('view_all_posts'))\n-register_view(\n-    user, routes=['/<username>/topics'], view_func=AllUserTopics.as_view('view_all_topics')\n-)\n-register_view(user, routes=['/<username>'], view_func=UserProfile.as_view('profile'))\n+@impl","path":"flaskbb/user/views.py","position":85,"original_position":85,"commit_id":"4ba9dda633f024097a2fc5ea4999ad8a45d9992c","original_commit_id":"4ba9dda633f024097a2fc5ea4999ad8a45d9992c","user":{"login":"justanr","id":4221605,"avatar_url":"https://avatars2.githubusercontent.com/u/4221605?v=4","gravatar_id":"","url":"https://api.github.com/users/justanr","html_url":"https://github.com/justanr","followers_url":"https://api.github.com/users/justanr/followers","following_url":"https://api.github.com/users/justanr/following{/other_user}","gists_url":"https://api.github.com/users/justanr/gists{/gist_id}","starred_url":"https://api.github.com/users/justanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanr/subscriptions","organizations_url":"https://api.github.com/users/justanr/orgs","repos_url":"https://api.github.com/users/justanr/repos","events_url":"https://api.github.com/users/justanr/events{/privacy}","received_events_url":"https://api.github.com/users/justanr/received_events","type":"User","site_admin":false},"body":"Do we care what order blueprints are registered in though? ","created_at":"2018-03-13T13:23:50Z","updated_at":"2018-03-13T13:23:50Z","html_url":"https://github.com/sh4nks/flaskbb/pull/419#discussion_r174125778","pull_request_url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/comments/174125778"},"html":{"href":"https://github.com/sh4nks/flaskbb/pull/419#discussion_r174125778"},"pull_request":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419"}},"in_reply_to_id":174039384},"pull_request":{"url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419","id":174249739,"html_url":"https://github.com/sh4nks/flaskbb/pull/419","diff_url":"https://github.com/sh4nks/flaskbb/pull/419.diff","patch_url":"https://github.com/sh4nks/flaskbb/pull/419.patch","issue_url":"https://api.github.com/repos/sh4nks/flaskbb/issues/419","number":419,"state":"open","locked":false,"title":"Load internal blueprints via hooks","user":{"login":"justanr","id":4221605,"avatar_url":"https://avatars2.githubusercontent.com/u/4221605?v=4","gravatar_id":"","url":"https://api.github.com/users/justanr","html_url":"https://github.com/justanr","followers_url":"https://api.github.com/users/justanr/followers","following_url":"https://api.github.com/users/justanr/following{/other_user}","gists_url":"https://api.github.com/users/justanr/gists{/gist_id}","starred_url":"https://api.github.com/users/justanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanr/subscriptions","organizations_url":"https://api.github.com/users/justanr/orgs","repos_url":"https://api.github.com/users/justanr/repos","events_url":"https://api.github.com/users/justanr/events{/privacy}","received_events_url":"https://api.github.com/users/justanr/received_events","type":"User","site_admin":false},"body":"Trying to move our own architecture to make use of the plugin/hook system. Right now, just loading blueprints via the hooks. I originally wanted to import the views into their modules' `__init__` but this triggered some circular imports that we will eventually need to address (specifically it was between forum and user).\r\n\r\nThere's a lot of formatting changes and that's from running yapf+isort on the modules out of habit. I'll revert if desired.","created_at":"2018-03-11T23:41:37Z","updated_at":"2018-03-13T13:23:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d37b65ed50b8a904ee94e0cc9a09fc165ae0645a","assignee":{"login":"sh4nks","id":1510708,"avatar_url":"https://avatars3.githubusercontent.com/u/1510708?v=4","gravatar_id":"","url":"https://api.github.com/users/sh4nks","html_url":"https://github.com/sh4nks","followers_url":"https://api.github.com/users/sh4nks/followers","following_url":"https://api.github.com/users/sh4nks/following{/other_user}","gists_url":"https://api.github.com/users/sh4nks/gists{/gist_id}","starred_url":"https://api.github.com/users/sh4nks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh4nks/subscriptions","organizations_url":"https://api.github.com/users/sh4nks/orgs","repos_url":"https://api.github.com/users/sh4nks/repos","events_url":"https://api.github.com/users/sh4nks/events{/privacy}","received_events_url":"https://api.github.com/users/sh4nks/received_events","type":"User","site_admin":false},"assignees":[{"login":"sh4nks","id":1510708,"avatar_url":"https://avatars3.githubusercontent.com/u/1510708?v=4","gravatar_id":"","url":"https://api.github.com/users/sh4nks","html_url":"https://github.com/sh4nks","followers_url":"https://api.github.com/users/sh4nks/followers","following_url":"https://api.github.com/users/sh4nks/following{/other_user}","gists_url":"https://api.github.com/users/sh4nks/gists{/gist_id}","starred_url":"https://api.github.com/users/sh4nks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh4nks/subscriptions","organizations_url":"https://api.github.com/users/sh4nks/orgs","repos_url":"https://api.github.com/users/sh4nks/repos","events_url":"https://api.github.com/users/sh4nks/events{/privacy}","received_events_url":"https://api.github.com/users/sh4nks/received_events","type":"User","site_admin":false},{"login":"justanr","id":4221605,"avatar_url":"https://avatars2.githubusercontent.com/u/4221605?v=4","gravatar_id":"","url":"https://api.github.com/users/justanr","html_url":"https://github.com/justanr","followers_url":"https://api.github.com/users/justanr/followers","following_url":"https://api.github.com/users/justanr/following{/other_user}","gists_url":"https://api.github.com/users/justanr/gists{/gist_id}","starred_url":"https://api.github.com/users/justanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanr/subscriptions","organizations_url":"https://api.github.com/users/justanr/orgs","repos_url":"https://api.github.com/users/justanr/repos","events_url":"https://api.github.com/users/justanr/events{/privacy}","received_events_url":"https://api.github.com/users/justanr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":55923832,"url":"https://api.github.com/repos/sh4nks/flaskbb/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":783213541,"url":"https://api.github.com/repos/sh4nks/flaskbb/labels/hook","name":"hook","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419/commits","review_comments_url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419/comments","review_comment_url":"https://api.github.com/repos/sh4nks/flaskbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sh4nks/flaskbb/issues/419/comments","statuses_url":"https://api.github.com/repos/sh4nks/flaskbb/statuses/4ba9dda633f024097a2fc5ea4999ad8a45d9992c","head":{"label":"justanr:load-blueprints-via-hooks","ref":"load-blueprints-via-hooks","sha":"4ba9dda633f024097a2fc5ea4999ad8a45d9992c","user":{"login":"justanr","id":4221605,"avatar_url":"https://avatars2.githubusercontent.com/u/4221605?v=4","gravatar_id":"","url":"https://api.github.com/users/justanr","html_url":"https://github.com/justanr","followers_url":"https://api.github.com/users/justanr/followers","following_url":"https://api.github.com/users/justanr/following{/other_user}","gists_url":"https://api.github.com/users/justanr/gists{/gist_id}","starred_url":"https://api.github.com/users/justanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanr/subscriptions","organizations_url":"https://api.github.com/users/justanr/orgs","repos_url":"https://api.github.com/users/justanr/repos","events_url":"https://api.github.com/users/justanr/events{/privacy}","received_events_url":"https://api.github.com/users/justanr/received_events","type":"User","site_admin":false},"repo":{"id":37654041,"name":"flaskbb","full_name":"justanr/flaskbb","owner":{"login":"justanr","id":4221605,"avatar_url":"https://avatars2.githubusercontent.com/u/4221605?v=4","gravatar_id":"","url":"https://api.github.com/users/justanr","html_url":"https://github.com/justanr","followers_url":"https://api.github.com/users/justanr/followers","following_url":"https://api.github.com/users/justanr/following{/other_user}","gists_url":"https://api.github.com/users/justanr/gists{/gist_id}","starred_url":"https://api.github.com/users/justanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanr/subscriptions","organizations_url":"https://api.github.com/users/justanr/orgs","repos_url":"https://api.github.com/users/justanr/repos","events_url":"https://api.github.com/users/justanr/events{/privacy}","received_events_url":"https://api.github.com/users/justanr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justanr/flaskbb","description":"A forum software written in flask","fork":true,"url":"https://api.github.com/repos/justanr/flaskbb","forks_url":"https://api.github.com/repos/justanr/flaskbb/forks","keys_url":"https://api.github.com/repos/justanr/flaskbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justanr/flaskbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justanr/flaskbb/teams","hooks_url":"https://api.github.com/repos/justanr/flaskbb/hooks","issue_events_url":"https://api.github.com/repos/justanr/flaskbb/issues/events{/number}","events_url":"https://api.github.com/repos/justanr/flaskbb/events","assignees_url":"https://api.github.com/repos/justanr/flaskbb/assignees{/user}","branches_url":"https://api.github.com/repos/justanr/flaskbb/branches{/branch}","tags_url":"https://api.github.com/repos/justanr/flaskbb/tags","blobs_url":"https://api.github.com/repos/justanr/flaskbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justanr/flaskbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justanr/flaskbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/justanr/flaskbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justanr/flaskbb/statuses/{sha}","languages_url":"https://api.github.com/repos/justanr/flaskbb/languages","stargazers_url":"https://api.github.com/repos/justanr/flaskbb/stargazers","contributors_url":"https://api.github.com/repos/justanr/flaskbb/contributors","subscribers_url":"https://api.github.com/repos/justanr/flaskbb/subscribers","subscription_url":"https://api.github.com/repos/justanr/flaskbb/subscription","commits_url":"https://api.github.com/repos/justanr/flaskbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/justanr/flaskbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/justanr/flaskbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/justanr/flaskbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/justanr/flaskbb/contents/{+path}","compare_url":"https://api.github.com/repos/justanr/flaskbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justanr/flaskbb/merges","archive_url":"https://api.github.com/repos/justanr/flaskbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justanr/flaskbb/downloads","issues_url":"https://api.github.com/repos/justanr/flaskbb/issues{/number}","pulls_url":"https://api.github.com/repos/justanr/flaskbb/pulls{/number}","milestones_url":"https://api.github.com/repos/justanr/flaskbb/milestones{/number}","notifications_url":"https://api.github.com/repos/justanr/flaskbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justanr/flaskbb/labels{/name}","releases_url":"https://api.github.com/repos/justanr/flaskbb/releases{/id}","deployments_url":"https://api.github.com/repos/justanr/flaskbb/deployments","created_at":"2015-06-18T10:51:35Z","updated_at":"2017-12-04T20:48:07Z","pushed_at":"2018-03-13T03:39:41Z","git_url":"git://github.com/justanr/flaskbb.git","ssh_url":"git@github.com:justanr/flaskbb.git","clone_url":"https://github.com/justanr/flaskbb.git","svn_url":"https://github.com/justanr/flaskbb","homepage":"flaskbb.org","size":5933,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"sh4nks:master","ref":"master","sha":"07c7aecd5877df177d4433ca8d6031c5581cd8f7","user":{"login":"sh4nks","id":1510708,"avatar_url":"https://avatars3.githubusercontent.com/u/1510708?v=4","gravatar_id":"","url":"https://api.github.com/users/sh4nks","html_url":"https://github.com/sh4nks","followers_url":"https://api.github.com/users/sh4nks/followers","following_url":"https://api.github.com/users/sh4nks/following{/other_user}","gists_url":"https://api.github.com/users/sh4nks/gists{/gist_id}","starred_url":"https://api.github.com/users/sh4nks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh4nks/subscriptions","organizations_url":"https://api.github.com/users/sh4nks/orgs","repos_url":"https://api.github.com/users/sh4nks/repos","events_url":"https://api.github.com/users/sh4nks/events{/privacy}","received_events_url":"https://api.github.com/users/sh4nks/received_events","type":"User","site_admin":false},"repo":{"id":12751570,"name":"flaskbb","full_name":"sh4nks/flaskbb","owner":{"login":"sh4nks","id":1510708,"avatar_url":"https://avatars3.githubusercontent.com/u/1510708?v=4","gravatar_id":"","url":"https://api.github.com/users/sh4nks","html_url":"https://github.com/sh4nks","followers_url":"https://api.github.com/users/sh4nks/followers","following_url":"https://api.github.com/users/sh4nks/following{/other_user}","gists_url":"https://api.github.com/users/sh4nks/gists{/gist_id}","starred_url":"https://api.github.com/users/sh4nks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh4nks/subscriptions","organizations_url":"https://api.github.com/users/sh4nks/orgs","repos_url":"https://api.github.com/users/sh4nks/repos","events_url":"https://api.github.com/users/sh4nks/events{/privacy}","received_events_url":"https://api.github.com/users/sh4nks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sh4nks/flaskbb","description":"A classic Forum Software in Python using Flask.","fork":false,"url":"https://api.github.com/repos/sh4nks/flaskbb","forks_url":"https://api.github.com/repos/sh4nks/flaskbb/forks","keys_url":"https://api.github.com/repos/sh4nks/flaskbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sh4nks/flaskbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sh4nks/flaskbb/teams","hooks_url":"https://api.github.com/repos/sh4nks/flaskbb/hooks","issue_events_url":"https://api.github.com/repos/sh4nks/flaskbb/issues/events{/number}","events_url":"https://api.github.com/repos/sh4nks/flaskbb/events","assignees_url":"https://api.github.com/repos/sh4nks/flaskbb/assignees{/user}","branches_url":"https://api.github.com/repos/sh4nks/flaskbb/branches{/branch}","tags_url":"https://api.github.com/repos/sh4nks/flaskbb/tags","blobs_url":"https://api.github.com/repos/sh4nks/flaskbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sh4nks/flaskbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sh4nks/flaskbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/sh4nks/flaskbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sh4nks/flaskbb/statuses/{sha}","languages_url":"https://api.github.com/repos/sh4nks/flaskbb/languages","stargazers_url":"https://api.github.com/repos/sh4nks/flaskbb/stargazers","contributors_url":"https://api.github.com/repos/sh4nks/flaskbb/contributors","subscribers_url":"https://api.github.com/repos/sh4nks/flaskbb/subscribers","subscription_url":"https://api.github.com/repos/sh4nks/flaskbb/subscription","commits_url":"https://api.github.com/repos/sh4nks/flaskbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/sh4nks/flaskbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/sh4nks/flaskbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/sh4nks/flaskbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/sh4nks/flaskbb/contents/{+path}","compare_url":"https://api.github.com/repos/sh4nks/flaskbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sh4nks/flaskbb/merges","archive_url":"https://api.github.com/repos/sh4nks/flaskbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sh4nks/flaskbb/downloads","issues_url":"https://api.github.com/repos/sh4nks/flaskbb/issues{/number}","pulls_url":"https://api.github.com/repos/sh4nks/flaskbb/pulls{/number}","milestones_url":"https://api.github.com/repos/sh4nks/flaskbb/milestones{/number}","notifications_url":"https://api.github.com/repos/sh4nks/flaskbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sh4nks/flaskbb/labels{/name}","releases_url":"https://api.github.com/repos/sh4nks/flaskbb/releases{/id}","deployments_url":"https://api.github.com/repos/sh4nks/flaskbb/deployments","created_at":"2013-09-11T08:39:17Z","updated_at":"2018-03-13T11:16:00Z","pushed_at":"2018-03-11T23:41:38Z","git_url":"git://github.com/sh4nks/flaskbb.git","ssh_url":"git@github.com:sh4nks/flaskbb.git","clone_url":"https://github.com/sh4nks/flaskbb.git","svn_url":"https://github.com/sh4nks/flaskbb","homepage":"https://flaskbb.org","size":5836,"stargazers_count":1207,"watchers_count":1207,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":327,"open_issues":23,"watchers":1207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419"},"html":{"href":"https://github.com/sh4nks/flaskbb/pull/419"},"issue":{"href":"https://api.github.com/repos/sh4nks/flaskbb/issues/419"},"comments":{"href":"https://api.github.com/repos/sh4nks/flaskbb/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sh4nks/flaskbb/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/sh4nks/flaskbb/statuses/4ba9dda633f024097a2fc5ea4999ad8a45d9992c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"justanr"}}