{"comment":{"url":"https://api.github.com/repos/mamedev/mame/comments/28961630","html_url":"https://github.com/mamedev/mame/commit/5b316c6d231e8ed95ea23317a897042930e1791e#commitcomment-28961630","id":28961630,"user":{"login":"cuavas","id":9678431,"avatar_url":"https://avatars0.githubusercontent.com/u/9678431?v=4","gravatar_id":"","url":"https://api.github.com/users/cuavas","html_url":"https://github.com/cuavas","followers_url":"https://api.github.com/users/cuavas/followers","following_url":"https://api.github.com/users/cuavas/following{/other_user}","gists_url":"https://api.github.com/users/cuavas/gists{/gist_id}","starred_url":"https://api.github.com/users/cuavas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuavas/subscriptions","organizations_url":"https://api.github.com/users/cuavas/orgs","repos_url":"https://api.github.com/users/cuavas/repos","events_url":"https://api.github.com/users/cuavas/events{/privacy}","received_events_url":"https://api.github.com/users/cuavas/received_events","type":"User","site_admin":false},"position":15,"line":417,"path":"src/devices/bus/nes/nes_slot.h","commit_id":"5b316c6d231e8ed95ea23317a897042930e1791e","created_at":"2018-05-14T05:53:36Z","updated_at":"2018-05-14T05:53:36Z","author_association":"OWNER","body":"Overloaded constructors are a well-established part of the standard.  We're aiming to get rid of all the device-specific MCFG_foo_ADD macros, and ultimately eliminate MCFG_DEVICE_ADD itself.\r\n\r\nThe magic `device` variable from the prologue and all the macros with dynamic casts are not good form.  They're legacy from C where there wasn't really a better alternative, but all they're doing now is making it harder than necessary to write devices.  You shouldn't need to write half a page of macros to make a device class usable, and you shouldn't need to go looking for a device-specific `ADD` macro that isn't even necessarily named the same way as its corresponding `device_type` (in this case it wasn't)."}}
{"actor":{"display_login":"cuavas"}}