{"action":"closed","number":206,"pull_request":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206","id":189853529,"html_url":"https://github.com/OriginProtocol/origin-js/pull/206","diff_url":"https://github.com/OriginProtocol/origin-js/pull/206.diff","patch_url":"https://github.com/OriginProtocol/origin-js/pull/206.patch","issue_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206","number":206,"state":"closed","locked":false,"title":"update npmignore file","user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"body":"Solves #199 \r\n\r\n### Checklist:\r\n\r\n- [x] Code contains relevant tests for the problem you are solving\r\n- [x] Ensure all new and existing tests pass\r\n- [x] Update any relevant READMEs and [docs](https://github.com/OriginProtocol/docs)\r\n- [x] Submit to the `develop` branch instead of `master`\r\n\r\n### Description:\r\n\r\nThis PR updates the `.npmignore` files to exclude unnecessary files from the package\r\n\r\n### Testing Steps\r\n\r\n1. Start a local npm registry with verdaccio\r\n\r\n```\r\nnpm install -g verdaccio\r\nverdaccio\r\n```\r\n\r\n2. On a separate shell window \r\n```\r\nnpm adduser --registry  http://localhost:4873 \r\ncd origin-js\r\nnpm publish --registry http://localhost:4873 \r\n```\r\n<img width=\"1868\" alt=\"origin-package\" src=\"https://user-images.githubusercontent.com/391270/40403395-f76704dc-5e0e-11e8-8903-293dbd065df2.png\">\r\n\r\n3. Test the installation\r\n```\r\nmkdir testing-npm-install-origin\r\ncd testing-npm-install-origin\r\nnpm i -S origin\r\ntree -L 2 node_modules/origin\r\n```\r\n<img width=\"822\" alt=\"origin-package-2\" src=\"https://user-images.githubusercontent.com/391270/40403397-fae809f8-5e0e-11e8-881f-2afbe8cb87bd.png\">\r\n\r\nref https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package","created_at":"2018-05-23T04:26:14Z","updated_at":"2018-05-23T04:53:03Z","closed_at":"2018-05-23T04:53:02Z","merged_at":null,"merge_commit_sha":"53a08ae0fcf0eeb6e16965eb446f931bc3c1aabe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206/commits","review_comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206/comments","review_comment_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206/comments","statuses_url":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/2b7941a81423e66d5f97fced446eebd6a0ba656c","head":{"label":"gaboesquivel:npmignore","ref":"npmignore","sha":"2b7941a81423e66d5f97fced446eebd6a0ba656c","user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"repo":{"id":132945756,"name":"origin-js","full_name":"gaboesquivel/origin-js","owner":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaboesquivel/origin-js","description":"Origin.js library for interfacing with Origin standards. Our smart contracts currently live here too.","fork":true,"url":"https://api.github.com/repos/gaboesquivel/origin-js","forks_url":"https://api.github.com/repos/gaboesquivel/origin-js/forks","keys_url":"https://api.github.com/repos/gaboesquivel/origin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaboesquivel/origin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaboesquivel/origin-js/teams","hooks_url":"https://api.github.com/repos/gaboesquivel/origin-js/hooks","issue_events_url":"https://api.github.com/repos/gaboesquivel/origin-js/issues/events{/number}","events_url":"https://api.github.com/repos/gaboesquivel/origin-js/events","assignees_url":"https://api.github.com/repos/gaboesquivel/origin-js/assignees{/user}","branches_url":"https://api.github.com/repos/gaboesquivel/origin-js/branches{/branch}","tags_url":"https://api.github.com/repos/gaboesquivel/origin-js/tags","blobs_url":"https://api.github.com/repos/gaboesquivel/origin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaboesquivel/origin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaboesquivel/origin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaboesquivel/origin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaboesquivel/origin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gaboesquivel/origin-js/languages","stargazers_url":"https://api.github.com/repos/gaboesquivel/origin-js/stargazers","contributors_url":"https://api.github.com/repos/gaboesquivel/origin-js/contributors","subscribers_url":"https://api.github.com/repos/gaboesquivel/origin-js/subscribers","subscription_url":"https://api.github.com/repos/gaboesquivel/origin-js/subscription","commits_url":"https://api.github.com/repos/gaboesquivel/origin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaboesquivel/origin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaboesquivel/origin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaboesquivel/origin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaboesquivel/origin-js/contents/{+path}","compare_url":"https://api.github.com/repos/gaboesquivel/origin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaboesquivel/origin-js/merges","archive_url":"https://api.github.com/repos/gaboesquivel/origin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaboesquivel/origin-js/downloads","issues_url":"https://api.github.com/repos/gaboesquivel/origin-js/issues{/number}","pulls_url":"https://api.github.com/repos/gaboesquivel/origin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gaboesquivel/origin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gaboesquivel/origin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaboesquivel/origin-js/labels{/name}","releases_url":"https://api.github.com/repos/gaboesquivel/origin-js/releases{/id}","deployments_url":"https://api.github.com/repos/gaboesquivel/origin-js/deployments","created_at":"2018-05-10T19:32:02Z","updated_at":"2018-05-10T19:32:04Z","pushed_at":"2018-05-23T04:01:42Z","git_url":"git://github.com/gaboesquivel/origin-js.git","ssh_url":"git@github.com:gaboesquivel/origin-js.git","clone_url":"https://github.com/gaboesquivel/origin-js.git","svn_url":"https://github.com/gaboesquivel/origin-js","homepage":"","size":6578,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OriginProtocol:develop","ref":"develop","sha":"cf21fe33679feb1c5f645c18a6ad68ce7c59f1c2","user":{"login":"OriginProtocol","id":30638653,"avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112376515,"name":"origin-js","full_name":"OriginProtocol/origin-js","owner":{"login":"OriginProtocol","id":30638653,"avatar_url":"https://avatars2.githubusercontent.com/u/30638653?v=4","gravatar_id":"","url":"https://api.github.com/users/OriginProtocol","html_url":"https://github.com/OriginProtocol","followers_url":"https://api.github.com/users/OriginProtocol/followers","following_url":"https://api.github.com/users/OriginProtocol/following{/other_user}","gists_url":"https://api.github.com/users/OriginProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/OriginProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OriginProtocol/subscriptions","organizations_url":"https://api.github.com/users/OriginProtocol/orgs","repos_url":"https://api.github.com/users/OriginProtocol/repos","events_url":"https://api.github.com/users/OriginProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/OriginProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OriginProtocol/origin-js","description":"Origin.js library for interfacing with Origin standards. Our smart contracts currently live here too.","fork":false,"url":"https://api.github.com/repos/OriginProtocol/origin-js","forks_url":"https://api.github.com/repos/OriginProtocol/origin-js/forks","keys_url":"https://api.github.com/repos/OriginProtocol/origin-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OriginProtocol/origin-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OriginProtocol/origin-js/teams","hooks_url":"https://api.github.com/repos/OriginProtocol/origin-js/hooks","issue_events_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/events{/number}","events_url":"https://api.github.com/repos/OriginProtocol/origin-js/events","assignees_url":"https://api.github.com/repos/OriginProtocol/origin-js/assignees{/user}","branches_url":"https://api.github.com/repos/OriginProtocol/origin-js/branches{/branch}","tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/tags","blobs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/{sha}","languages_url":"https://api.github.com/repos/OriginProtocol/origin-js/languages","stargazers_url":"https://api.github.com/repos/OriginProtocol/origin-js/stargazers","contributors_url":"https://api.github.com/repos/OriginProtocol/origin-js/contributors","subscribers_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscribers","subscription_url":"https://api.github.com/repos/OriginProtocol/origin-js/subscription","commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/OriginProtocol/origin-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/OriginProtocol/origin-js/contents/{+path}","compare_url":"https://api.github.com/repos/OriginProtocol/origin-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OriginProtocol/origin-js/merges","archive_url":"https://api.github.com/repos/OriginProtocol/origin-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OriginProtocol/origin-js/downloads","issues_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues{/number}","pulls_url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls{/number}","milestones_url":"https://api.github.com/repos/OriginProtocol/origin-js/milestones{/number}","notifications_url":"https://api.github.com/repos/OriginProtocol/origin-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OriginProtocol/origin-js/labels{/name}","releases_url":"https://api.github.com/repos/OriginProtocol/origin-js/releases{/id}","deployments_url":"https://api.github.com/repos/OriginProtocol/origin-js/deployments","created_at":"2017-11-28T19:00:15Z","updated_at":"2018-05-22T22:27:37Z","pushed_at":"2018-05-23T04:26:14Z","git_url":"git://github.com/OriginProtocol/origin-js.git","ssh_url":"git@github.com:OriginProtocol/origin-js.git","clone_url":"https://github.com/OriginProtocol/origin-js.git","svn_url":"https://github.com/OriginProtocol/origin-js","homepage":"","size":6709,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":47,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206"},"html":{"href":"https://github.com/OriginProtocol/origin-js/pull/206"},"issue":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206"},"comments":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/OriginProtocol/origin-js/statuses/2b7941a81423e66d5f97fced446eebd6a0ba656c"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"gaboesquivel"}}