{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/216463547","pull_request_review_id":153951632,"id":216463547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ2MzU0Nw==","diff_hunk":"@@ -74,6 +74,9 @@ def ace_get\n       remark = Regexp.new('(?<seqno>\\d+) remark (?<remark>.*)').match(str)\n       return remark unless remark.nil?\n \n+      # for icmp things are different","path":"lib/cisco_node_utils/ace.rb","position":4,"original_position":4,"commit_id":"b4fce8345b0dc245472850ffb89db21f76f2b150","original_commit_id":"b4fce8345b0dc245472850ffb89db21f76f2b150","user":{"login":"mikewiebe","id":12445795,"node_id":"MDQ6VXNlcjEyNDQ1Nzk1","avatar_url":"https://avatars2.githubusercontent.com/u/12445795?v=4","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"body":"*nit* `Specialized icmp protocal handling`","created_at":"2018-09-10T20:36:00Z","updated_at":"2018-09-10T20:36:00Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/596#discussion_r216463547","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/216463547"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/596#discussion_r216463547"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596","id":214047740,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQ3NzQw","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/596","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/596.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/596.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/596","number":596,"state":"open","locked":false,"title":"Fix for Cisco-73","user":{"login":"saichint","id":15788941,"node_id":"MDQ6VXNlcjE1Nzg4OTQx","avatar_url":"https://avatars0.githubusercontent.com/u/15788941?v=4","gravatar_id":"","url":"https://api.github.com/users/saichint","html_url":"https://github.com/saichint","followers_url":"https://api.github.com/users/saichint/followers","following_url":"https://api.github.com/users/saichint/following{/other_user}","gists_url":"https://api.github.com/users/saichint/gists{/gist_id}","starred_url":"https://api.github.com/users/saichint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saichint/subscriptions","organizations_url":"https://api.github.com/users/saichint/orgs","repos_url":"https://api.github.com/users/saichint/repos","events_url":"https://api.github.com/users/saichint/events{/privacy}","received_events_url":"https://api.github.com/users/saichint/received_events","type":"User","site_admin":false},"body":"This PR is for fixing issue cisco-73\r\nhttps://tickets.puppetlabs.com/browse/CISCO-73\r\n\r\nBasically the current ace provider implementation does not take care of icmp properly.\r\nHowever, upon further inspection of CLIs, it is found that the CLIs differ between different versions of software and also between platforms.\r\n* ```redirect``` can be just a keyword or it can be used with interfaces or they could both be used simultaneously.\r\n* the position of ```redirect``` changes on the show run based on the software version.\r\n* ```fragments``` is put a different location than other options even though the behavior is similar to other options.\r\n* ```set_erspan_gre_proto``` and ```set_erspan_dscp``` positions change based on the software versions.\r\n\r\nDue to all these weird quirks, the code checks some of the parameters on 2nd pass due to hit and miss regex patterns for the ```show run aclmgr``` output.\r\n\r\n* For all the single word icmp parameter options, the name ```proto_option``` (instead of icmp...something) is given because this can be used to other protocols going forward and also because for setting the configuration the same pattern is used for all protocols (unlike get regex where it is different for icmp). \r\n* However, only ```icmp``` supports the ```proto_option``` in the near term.\r\n\r\nTested on n7k, n3k and n9k.\r\n","created_at":"2018-09-07T21:50:03Z","updated_at":"2018-09-10T20:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13dd2ef0e58ad802a542f0aa90a2e3edaaa5e83d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shermdog","id":3383063,"node_id":"MDQ6VXNlcjMzODMwNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3383063?v=4","gravatar_id":"","url":"https://api.github.com/users/shermdog","html_url":"https://github.com/shermdog","followers_url":"https://api.github.com/users/shermdog/followers","following_url":"https://api.github.com/users/shermdog/following{/other_user}","gists_url":"https://api.github.com/users/shermdog/gists{/gist_id}","starred_url":"https://api.github.com/users/shermdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shermdog/subscriptions","organizations_url":"https://api.github.com/users/shermdog/orgs","repos_url":"https://api.github.com/users/shermdog/repos","events_url":"https://api.github.com/users/shermdog/events{/privacy}","received_events_url":"https://api.github.com/users/shermdog/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/596/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/b4fce8345b0dc245472850ffb89db21f76f2b150","head":{"label":"cisco:cisco-73","ref":"cisco-73","sha":"b4fce8345b0dc245472850ffb89db21f76f2b150","user":{"login":"cisco","id":1376999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzY5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1376999?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"node_id":"MDEwOlJlcG9zaXRvcnkzOTU2NTE5Ng==","name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzY5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1376999?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":null,"fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/deployments","created_at":"2015-07-23T12:07:39Z","updated_at":"2018-09-06T13:07:19Z","pushed_at":"2018-09-07T23:19:49Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":4520,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":3,"watchers":21,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"105d5379c9806b736c52b8defb4ebf9ee508d9a7","user":{"login":"cisco","id":1376999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzY5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1376999?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"node_id":"MDEwOlJlcG9zaXRvcnkzOTU2NTE5Ng==","name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzY5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1376999?v=4","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":null,"fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/deployments","created_at":"2015-07-23T12:07:39Z","updated_at":"2018-09-06T13:07:19Z","pushed_at":"2018-09-07T23:19:49Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":4520,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":3,"watchers":21,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/596"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/596"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/b4fce8345b0dc245472850ffb89db21f76f2b150"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikewiebe"}}