{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/frappe/pulls/comments/213253239","pull_request_review_id":150049109,"id":213253239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI1MzIzOQ==","diff_hunk":"@@ -202,7 +202,7 @@ def get_queue(queue, is_async=True):\n \t'''Returns a Queue object tied to a redis connection'''\n \tvalidate_queue(queue)\n \n-\treturn Queue(queue, connection=get_redis_conn(), async=is_async)\n+\treturn Queue(queue, connection=get_redis_conn(), is_async=is_async)","path":"frappe/utils/background_jobs.py","position":5,"original_position":5,"commit_id":"2b0a37a9b983aa5b8be14fb497cb22cf8c278848","original_commit_id":"2b0a37a9b983aa5b8be14fb497cb22cf8c278848","user":{"login":"rmehta","id":140076,"node_id":"MDQ6VXNlcjE0MDA3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/140076?v=4","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"body":"this is pythonrq, we can't change named parameters","created_at":"2018-08-28T10:00:27Z","updated_at":"2018-08-28T10:00:27Z","html_url":"https://github.com/frappe/frappe/pull/6015#discussion_r213253239","pull_request_url":"https://api.github.com/repos/frappe/frappe/pulls/6015","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments/213253239"},"html":{"href":"https://github.com/frappe/frappe/pull/6015#discussion_r213253239"},"pull_request":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6015"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/6015","id":211087623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDg3NjIz","html_url":"https://github.com/frappe/frappe/pull/6015","diff_url":"https://github.com/frappe/frappe/pull/6015.diff","patch_url":"https://github.com/frappe/frappe/pull/6015.patch","issue_url":"https://api.github.com/repos/frappe/frappe/issues/6015","number":6015,"state":"open","locked":false,"title":"frappe: refactor async to realtime","user":{"login":"adityahase","id":8528887,"node_id":"MDQ6VXNlcjg1Mjg4ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8528887?v=4","gravatar_id":"","url":"https://api.github.com/users/adityahase","html_url":"https://github.com/adityahase","followers_url":"https://api.github.com/users/adityahase/followers","following_url":"https://api.github.com/users/adityahase/following{/other_user}","gists_url":"https://api.github.com/users/adityahase/gists{/gist_id}","starred_url":"https://api.github.com/users/adityahase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityahase/subscriptions","organizations_url":"https://api.github.com/users/adityahase/orgs","repos_url":"https://api.github.com/users/adityahase/repos","events_url":"https://api.github.com/users/adityahase/events{/privacy}","received_events_url":"https://api.github.com/users/adityahase/received_events","type":"User","site_admin":false},"body":"Renamed `async.py` to `realtime.py`, Changed imports, removed where unnecessary.","created_at":"2018-08-27T11:58:29Z","updated_at":"2018-08-28T10:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88e00bf0545bbb3ef57ce033781a6ea279cee64a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/frappe/pulls/6015/commits","review_comments_url":"https://api.github.com/repos/frappe/frappe/pulls/6015/comments","review_comment_url":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/6015/comments","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/2b0a37a9b983aa5b8be14fb497cb22cf8c278848","head":{"label":"adityahase:develop","ref":"develop","sha":"2b0a37a9b983aa5b8be14fb497cb22cf8c278848","user":{"login":"adityahase","id":8528887,"node_id":"MDQ6VXNlcjg1Mjg4ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8528887?v=4","gravatar_id":"","url":"https://api.github.com/users/adityahase","html_url":"https://github.com/adityahase","followers_url":"https://api.github.com/users/adityahase/followers","following_url":"https://api.github.com/users/adityahase/following{/other_user}","gists_url":"https://api.github.com/users/adityahase/gists{/gist_id}","starred_url":"https://api.github.com/users/adityahase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityahase/subscriptions","organizations_url":"https://api.github.com/users/adityahase/orgs","repos_url":"https://api.github.com/users/adityahase/repos","events_url":"https://api.github.com/users/adityahase/events{/privacy}","received_events_url":"https://api.github.com/users/adityahase/received_events","type":"User","site_admin":false},"repo":{"id":139784757,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3ODQ3NTc=","name":"frappe","full_name":"adityahase/frappe","owner":{"login":"adityahase","id":8528887,"node_id":"MDQ6VXNlcjg1Mjg4ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8528887?v=4","gravatar_id":"","url":"https://api.github.com/users/adityahase","html_url":"https://github.com/adityahase","followers_url":"https://api.github.com/users/adityahase/followers","following_url":"https://api.github.com/users/adityahase/following{/other_user}","gists_url":"https://api.github.com/users/adityahase/gists{/gist_id}","starred_url":"https://api.github.com/users/adityahase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityahase/subscriptions","organizations_url":"https://api.github.com/users/adityahase/orgs","repos_url":"https://api.github.com/users/adityahase/repos","events_url":"https://api.github.com/users/adityahase/events{/privacy}","received_events_url":"https://api.github.com/users/adityahase/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adityahase/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":true,"url":"https://api.github.com/repos/adityahase/frappe","forks_url":"https://api.github.com/repos/adityahase/frappe/forks","keys_url":"https://api.github.com/repos/adityahase/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityahase/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityahase/frappe/teams","hooks_url":"https://api.github.com/repos/adityahase/frappe/hooks","issue_events_url":"https://api.github.com/repos/adityahase/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/adityahase/frappe/events","assignees_url":"https://api.github.com/repos/adityahase/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/adityahase/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/adityahase/frappe/tags","blobs_url":"https://api.github.com/repos/adityahase/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityahase/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityahase/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityahase/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityahase/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/adityahase/frappe/languages","stargazers_url":"https://api.github.com/repos/adityahase/frappe/stargazers","contributors_url":"https://api.github.com/repos/adityahase/frappe/contributors","subscribers_url":"https://api.github.com/repos/adityahase/frappe/subscribers","subscription_url":"https://api.github.com/repos/adityahase/frappe/subscription","commits_url":"https://api.github.com/repos/adityahase/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityahase/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityahase/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityahase/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityahase/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/adityahase/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityahase/frappe/merges","archive_url":"https://api.github.com/repos/adityahase/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityahase/frappe/downloads","issues_url":"https://api.github.com/repos/adityahase/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/adityahase/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/adityahase/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/adityahase/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityahase/frappe/labels{/name}","releases_url":"https://api.github.com/repos/adityahase/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/adityahase/frappe/deployments","created_at":"2018-07-05T02:23:18Z","updated_at":"2018-08-27T13:56:38Z","pushed_at":"2018-08-27T13:56:36Z","git_url":"git://github.com/adityahase/frappe.git","ssh_url":"git@github.com:adityahase/frappe.git","clone_url":"https://github.com/adityahase/frappe.git","svn_url":"https://github.com/adityahase/frappe","homepage":"http://frappe.io","size":167092,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"b8923b0c08a44596208cc9f1bd21f326072237e7","user":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864194,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MTk0","name":"frappe","full_name":"frappe/frappe","owner":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":false,"url":"https://api.github.com/repos/frappe/frappe","forks_url":"https://api.github.com/repos/frappe/frappe/forks","keys_url":"https://api.github.com/repos/frappe/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/frappe/teams","hooks_url":"https://api.github.com/repos/frappe/frappe/hooks","issue_events_url":"https://api.github.com/repos/frappe/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/frappe/events","assignees_url":"https://api.github.com/repos/frappe/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/frappe/tags","blobs_url":"https://api.github.com/repos/frappe/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/frappe/languages","stargazers_url":"https://api.github.com/repos/frappe/frappe/stargazers","contributors_url":"https://api.github.com/repos/frappe/frappe/contributors","subscribers_url":"https://api.github.com/repos/frappe/frappe/subscribers","subscription_url":"https://api.github.com/repos/frappe/frappe/subscription","commits_url":"https://api.github.com/repos/frappe/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/frappe/merges","archive_url":"https://api.github.com/repos/frappe/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/frappe/downloads","issues_url":"https://api.github.com/repos/frappe/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/frappe/labels{/name}","releases_url":"https://api.github.com/repos/frappe/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/frappe/deployments","created_at":"2011-06-08T08:14:16Z","updated_at":"2018-08-28T09:59:31Z","pushed_at":"2018-08-28T09:59:28Z","git_url":"git://github.com/frappe/frappe.git","ssh_url":"git@github.com:frappe/frappe.git","clone_url":"https://github.com/frappe/frappe.git","svn_url":"https://github.com/frappe/frappe","homepage":"http://frappe.io","size":167053,"stargazers_count":958,"watchers_count":958,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":761,"open_issues":308,"watchers":958,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6015"},"html":{"href":"https://github.com/frappe/frappe/pull/6015"},"issue":{"href":"https://api.github.com/repos/frappe/frappe/issues/6015"},"comments":{"href":"https://api.github.com/repos/frappe/frappe/issues/6015/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6015/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6015/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/frappe/statuses/2b0a37a9b983aa5b8be14fb497cb22cf8c278848"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rmehta"}}