{"action":"opened","number":28,"pull_request":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28","id":234687259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Njg3MjU5","html_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/28","diff_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/28.diff","patch_url":"https://github.com/firecracker-microvm/firecracker-containerd/pull/28.patch","issue_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/28","number":28,"state":"open","locked":false,"title":"Add mkfs to force option","user":{"login":"kontotto","id":17213836,"node_id":"MDQ6VXNlcjE3MjEzODM2","avatar_url":"https://avatars0.githubusercontent.com/u/17213836?v=4","gravatar_id":"","url":"https://api.github.com/users/kontotto","html_url":"https://github.com/kontotto","followers_url":"https://api.github.com/users/kontotto/followers","following_url":"https://api.github.com/users/kontotto/following{/other_user}","gists_url":"https://api.github.com/users/kontotto/gists{/gist_id}","starred_url":"https://api.github.com/users/kontotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontotto/subscriptions","organizations_url":"https://api.github.com/users/kontotto/orgs","repos_url":"https://api.github.com/users/kontotto/repos","events_url":"https://api.github.com/users/kontotto/events{/privacy}","received_events_url":"https://api.github.com/users/kontotto/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n\r\nWhen I run `go test` in snapshotter directory, executing `mkfs -t ext4 <file>` failed.\r\n\r\n```\r\n$ sudo -E env \"PATH=$PATH\" go test\r\n~~\r\nINFO[0000] building file system                          image=/tmp/snapshot-suite-Snapshotter-233656583/root/images/1\r\n--- FAIL: TestSnapshotterSuite (0.00s)\r\n    --- FAIL: TestSnapshotterSuite/Basic (0.01s)\r\n        testsuite.go:142: failure reason: exit status 1\r\n            exec failed: mkfs -t ext4 /tmp/snapshot-suite-Snapshotter-453147216/root/images/1\r\n            github.com/firecracker-microvm/firecracker-containerd/snapshotter.run\r\n                /home/centos/firecracker-containerd/snapshotter/firecracker.go:430\r\n            github.com/firecracker-microvm/firecracker-containerd/snapshotter.(*Snapshotter).createImage\r\n                /home/centos/firecracker-containerd/snapshotter/firecracker.go:346\r\n            github.com/firecracker-microvm/firecracker-containerd/snapshotter.(*Snapshotter).createSnapshot\r\n                /home/centos/firecracker-containerd/snapshotter/firecracker.go:282\r\n            github.com/firecracker-microvm/firecracker-containerd/snapshotter.(*Snapshotter).Prepare\r\n                /home/centos/firecracker-containerd/snapshotter/firecracker.go:143\r\n            github.com/containerd/containerd/snapshots/testsuite.checkSnapshotterBasic\r\n                /home/centos/go/pkg/mod/github.com/containerd/containerd@v1.2.0/snapshots/testsuite/testsuite.go:140\r\n            github.com/containerd/containerd/snapshots/testsuite.makeTest.func1\r\n                /home/centos/go/pkg/mod/github.com/containerd/containerd@v1.2.0/snapshots/testsuite/testsuite.go:111\r\n            testing.tRunner\r\n                /usr/local/go/src/testing/testing.go:827\r\n            runtime.goexit\r\n                /usr/local/go/src/runtime/asm_amd64.s:1333\r\n~~\r\n```\r\n\r\nIf mkfs receives a file that is not a block special device, it processes interactively, so it waits for input and fails.\r\n\r\n```\r\n$ mkfs -t ext4 hoge\r\nmke2fs 1.42.9 (28-Dec-2013)\r\nhoge is not a block special device.\r\nProceed anyway? (y,n)\r\n```\r\n\r\n*Description of changes:*\r\n\r\nAdding the -F flag, Set the answer to the question to yes.\r\nAfter the change, the test was successful.\r\n\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-29T15:47:30Z","updated_at":"2018-11-29T15:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28/commits","review_comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28/comments","review_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/28/comments","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/f0bff7c06330ba8033eca4c9bb1f4fa962ff87bf","head":{"label":"kontotto:mkfs_force","ref":"mkfs_force","sha":"f0bff7c06330ba8033eca4c9bb1f4fa962ff87bf","user":{"login":"kontotto","id":17213836,"node_id":"MDQ6VXNlcjE3MjEzODM2","avatar_url":"https://avatars0.githubusercontent.com/u/17213836?v=4","gravatar_id":"","url":"https://api.github.com/users/kontotto","html_url":"https://github.com/kontotto","followers_url":"https://api.github.com/users/kontotto/followers","following_url":"https://api.github.com/users/kontotto/following{/other_user}","gists_url":"https://api.github.com/users/kontotto/gists{/gist_id}","starred_url":"https://api.github.com/users/kontotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontotto/subscriptions","organizations_url":"https://api.github.com/users/kontotto/orgs","repos_url":"https://api.github.com/users/kontotto/repos","events_url":"https://api.github.com/users/kontotto/events{/privacy}","received_events_url":"https://api.github.com/users/kontotto/received_events","type":"User","site_admin":false},"repo":{"id":159686271,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk2ODYyNzE=","name":"firecracker-containerd","full_name":"kontotto/firecracker-containerd","private":false,"owner":{"login":"kontotto","id":17213836,"node_id":"MDQ6VXNlcjE3MjEzODM2","avatar_url":"https://avatars0.githubusercontent.com/u/17213836?v=4","gravatar_id":"","url":"https://api.github.com/users/kontotto","html_url":"https://github.com/kontotto","followers_url":"https://api.github.com/users/kontotto/followers","following_url":"https://api.github.com/users/kontotto/following{/other_user}","gists_url":"https://api.github.com/users/kontotto/gists{/gist_id}","starred_url":"https://api.github.com/users/kontotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontotto/subscriptions","organizations_url":"https://api.github.com/users/kontotto/orgs","repos_url":"https://api.github.com/users/kontotto/repos","events_url":"https://api.github.com/users/kontotto/events{/privacy}","received_events_url":"https://api.github.com/users/kontotto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kontotto/firecracker-containerd","description":"firecracker-containerd enables containerd to manage containers as Firecracker microVMs","fork":true,"url":"https://api.github.com/repos/kontotto/firecracker-containerd","forks_url":"https://api.github.com/repos/kontotto/firecracker-containerd/forks","keys_url":"https://api.github.com/repos/kontotto/firecracker-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontotto/firecracker-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontotto/firecracker-containerd/teams","hooks_url":"https://api.github.com/repos/kontotto/firecracker-containerd/hooks","issue_events_url":"https://api.github.com/repos/kontotto/firecracker-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/kontotto/firecracker-containerd/events","assignees_url":"https://api.github.com/repos/kontotto/firecracker-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/kontotto/firecracker-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/kontotto/firecracker-containerd/tags","blobs_url":"https://api.github.com/repos/kontotto/firecracker-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontotto/firecracker-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontotto/firecracker-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontotto/firecracker-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontotto/firecracker-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/kontotto/firecracker-containerd/languages","stargazers_url":"https://api.github.com/repos/kontotto/firecracker-containerd/stargazers","contributors_url":"https://api.github.com/repos/kontotto/firecracker-containerd/contributors","subscribers_url":"https://api.github.com/repos/kontotto/firecracker-containerd/subscribers","subscription_url":"https://api.github.com/repos/kontotto/firecracker-containerd/subscription","commits_url":"https://api.github.com/repos/kontotto/firecracker-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontotto/firecracker-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontotto/firecracker-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontotto/firecracker-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontotto/firecracker-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/kontotto/firecracker-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontotto/firecracker-containerd/merges","archive_url":"https://api.github.com/repos/kontotto/firecracker-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontotto/firecracker-containerd/downloads","issues_url":"https://api.github.com/repos/kontotto/firecracker-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/kontotto/firecracker-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/kontotto/firecracker-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/kontotto/firecracker-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontotto/firecracker-containerd/labels{/name}","releases_url":"https://api.github.com/repos/kontotto/firecracker-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/kontotto/firecracker-containerd/deployments","created_at":"2018-11-29T15:20:30Z","updated_at":"2018-11-29T15:20:32Z","pushed_at":"2018-11-29T15:32:26Z","git_url":"git://github.com/kontotto/firecracker-containerd.git","ssh_url":"git@github.com:kontotto/firecracker-containerd.git","clone_url":"https://github.com/kontotto/firecracker-containerd.git","svn_url":"https://github.com/kontotto/firecracker-containerd","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firecracker-microvm:master","ref":"master","sha":"fe91fa499b64534aefa99dbee04c99238a9da208","user":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"repo":{"id":157781317,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3ODEzMTc=","name":"firecracker-containerd","full_name":"firecracker-microvm/firecracker-containerd","private":false,"owner":{"login":"firecracker-microvm","id":44477506,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDc3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/44477506?v=4","gravatar_id":"","url":"https://api.github.com/users/firecracker-microvm","html_url":"https://github.com/firecracker-microvm","followers_url":"https://api.github.com/users/firecracker-microvm/followers","following_url":"https://api.github.com/users/firecracker-microvm/following{/other_user}","gists_url":"https://api.github.com/users/firecracker-microvm/gists{/gist_id}","starred_url":"https://api.github.com/users/firecracker-microvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firecracker-microvm/subscriptions","organizations_url":"https://api.github.com/users/firecracker-microvm/orgs","repos_url":"https://api.github.com/users/firecracker-microvm/repos","events_url":"https://api.github.com/users/firecracker-microvm/events{/privacy}","received_events_url":"https://api.github.com/users/firecracker-microvm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firecracker-microvm/firecracker-containerd","description":"firecracker-containerd enables containerd to manage containers as Firecracker microVMs","fork":false,"url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd","forks_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/forks","keys_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/teams","hooks_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/hooks","issue_events_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/events","assignees_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/tags","blobs_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/languages","stargazers_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/stargazers","contributors_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/contributors","subscribers_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/subscribers","subscription_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/subscription","commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/merges","archive_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/downloads","issues_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/labels{/name}","releases_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/deployments","created_at":"2018-11-15T22:36:30Z","updated_at":"2018-11-29T15:45:09Z","pushed_at":"2018-11-29T01:12:03Z","git_url":"git://github.com/firecracker-microvm/firecracker-containerd.git","ssh_url":"git@github.com:firecracker-microvm/firecracker-containerd.git","clone_url":"https://github.com/firecracker-microvm/firecracker-containerd.git","svn_url":"https://github.com/firecracker-microvm/firecracker-containerd","homepage":null,"size":128,"stargazers_count":216,"watchers_count":216,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":9,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28"},"html":{"href":"https://github.com/firecracker-microvm/firecracker-containerd/pull/28"},"issue":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/28"},"comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/firecracker-microvm/firecracker-containerd/statuses/f0bff7c06330ba8033eca4c9bb1f4fa962ff87bf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"kontotto"}}