{"action":"created","issue":{"url":"https://api.github.com/repos/gojuno/composer/issues/147","repository_url":"https://api.github.com/repos/gojuno/composer","labels_url":"https://api.github.com/repos/gojuno/composer/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/gojuno/composer/issues/147/comments","events_url":"https://api.github.com/repos/gojuno/composer/issues/147/events","html_url":"https://github.com/gojuno/composer/pull/147","id":328847152,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjU4NTg0","number":147,"title":"Add search bar and filters for logcat output","user":{"login":"tokou","id":517070,"node_id":"MDQ6VXNlcjUxNzA3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/517070?v=4","gravatar_id":"","url":"https://api.github.com/users/tokou","html_url":"https://github.com/tokou","followers_url":"https://api.github.com/users/tokou/followers","following_url":"https://api.github.com/users/tokou/following{/other_user}","gists_url":"https://api.github.com/users/tokou/gists{/gist_id}","starred_url":"https://api.github.com/users/tokou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokou/subscriptions","organizations_url":"https://api.github.com/users/tokou/orgs","repos_url":"https://api.github.com/users/tokou/repos","events_url":"https://api.github.com/users/tokou/events{/privacy}","received_events_url":"https://api.github.com/users/tokou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-03T17:39:38Z","updated_at":"2018-06-08T12:38:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gojuno/composer/pulls/147","html_url":"https://github.com/gojuno/composer/pull/147","diff_url":"https://github.com/gojuno/composer/pull/147.diff","patch_url":"https://github.com/gojuno/composer/pull/147.patch"},"body":"There are many ways to approach this.\r\nI decided against adding to the `window.test` object as logcat output can be very large.\r\n\r\nI kept the static html generated by the Jar. I just added an id `static_logs` in order to remove it once we load the logs in js.\r\n\r\nI made a `LogContainer` component that shows the filters, the search bar and the logs once they are loaded from the file (it replaces the static logs).\r\n\r\nI extracted the `SearchBar` component and made it generic and used by `LogFilter` and `SuiteFilter`\r\n\r\nI tested this with a 10k lines logcat output file. Loading is seamless thanks to the html. Search is kinda laggy but acceptable. Maybe there's a React trick out there to make it faster."},"comment":{"url":"https://api.github.com/repos/gojuno/composer/issues/comments/395747970","html_url":"https://github.com/gojuno/composer/pull/147#issuecomment-395747970","issue_url":"https://api.github.com/repos/gojuno/composer/issues/147","id":395747970,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTc0Nzk3MA==","user":{"login":"tokou","id":517070,"node_id":"MDQ6VXNlcjUxNzA3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/517070?v=4","gravatar_id":"","url":"https://api.github.com/users/tokou","html_url":"https://github.com/tokou","followers_url":"https://api.github.com/users/tokou/followers","following_url":"https://api.github.com/users/tokou/following{/other_user}","gists_url":"https://api.github.com/users/tokou/gists{/gist_id}","starred_url":"https://api.github.com/users/tokou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokou/subscriptions","organizations_url":"https://api.github.com/users/tokou/orgs","repos_url":"https://api.github.com/users/tokou/repos","events_url":"https://api.github.com/users/tokou/events{/privacy}","received_events_url":"https://api.github.com/users/tokou/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T12:38:03Z","updated_at":"2018-06-08T12:38:03Z","author_association":"NONE","body":"I made an update to get the logs from the DOM tree instead of reading the logcat file.\r\nIt works without a web server now."}}
{"actor":{"display_login":"tokou"}}