{"action":"created","issue":{"url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/1","repository_url":"https://api.github.com/repos/jamietre/react-typescript-optional-props","labels_url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/1/comments","events_url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/1/events","html_url":"https://github.com/jamietre/react-typescript-optional-props/pull/1","id":296936799,"number":1,"title":"A little type renaming","user":{"login":"njgraf512","id":22208823,"avatar_url":"https://avatars2.githubusercontent.com/u/22208823?v=4","gravatar_id":"","url":"https://api.github.com/users/njgraf512","html_url":"https://github.com/njgraf512","followers_url":"https://api.github.com/users/njgraf512/followers","following_url":"https://api.github.com/users/njgraf512/following{/other_user}","gists_url":"https://api.github.com/users/njgraf512/gists{/gist_id}","starred_url":"https://api.github.com/users/njgraf512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgraf512/subscriptions","organizations_url":"https://api.github.com/users/njgraf512/orgs","repos_url":"https://api.github.com/users/njgraf512/repos","events_url":"https://api.github.com/users/njgraf512/events{/privacy}","received_events_url":"https://api.github.com/users/njgraf512/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-14T00:35:24Z","updated_at":"2018-02-14T00:53:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/pulls/1","html_url":"https://github.com/jamietre/react-typescript-optional-props/pull/1","diff_url":"https://github.com/jamietre/react-typescript-optional-props/pull/1.diff","patch_url":"https://github.com/jamietre/react-typescript-optional-props/pull/1.patch"},"body":"So, no need to actually merge this. I took a minute to look at this a bit more today, and I'm definitely onboard with the pattern you have here. All I did here was a little renaming of types, which of course is just semantics, but if we want to add this to the wiki, I think these names might help to grasp what's going on just a bit faster. Opening the PR just as a means to share the name changes I would make. But I think it looks good.\r\n\r\nI'm keeping an eye on [https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11640](https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11640) to see if something \"official\" comes out, but this seems like it will serve us well.\r\n\r\ncc: @jarneson"},"comment":{"url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/comments/365458238","html_url":"https://github.com/jamietre/react-typescript-optional-props/pull/1#issuecomment-365458238","issue_url":"https://api.github.com/repos/jamietre/react-typescript-optional-props/issues/1","id":365458238,"user":{"login":"jamietre","id":573056,"avatar_url":"https://avatars2.githubusercontent.com/u/573056?v=4","gravatar_id":"","url":"https://api.github.com/users/jamietre","html_url":"https://github.com/jamietre","followers_url":"https://api.github.com/users/jamietre/followers","following_url":"https://api.github.com/users/jamietre/following{/other_user}","gists_url":"https://api.github.com/users/jamietre/gists{/gist_id}","starred_url":"https://api.github.com/users/jamietre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamietre/subscriptions","organizations_url":"https://api.github.com/users/jamietre/orgs","repos_url":"https://api.github.com/users/jamietre/repos","events_url":"https://api.github.com/users/jamietre/events{/privacy}","received_events_url":"https://api.github.com/users/jamietre/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T00:53:02Z","updated_at":"2018-02-14T00:53:02Z","author_association":"OWNER","body":"Ha, I didn't even find that thread when I was googling this but it looks\nlike one of the last comments came up with a similar pattern. Glad you are\non board, I am going to catch up on docs tomorrow and also deprecate\nphacility wiki.\n\n\nOn Feb 13, 2018 7:35 PM, \"Nate Graf\" <notifications@github.com> wrote:\n\n> So, no need to actually merge this. I took a minute to look at this a bit\n> more today, and I'm definitely onboard with the pattern you have here. All\n> I did here was a little renaming of types, which of course is just\n> semantics, but if we want to add this to the wiki, I think these names\n> might help to grasp what's going on just a bit faster. Opening the PR just\n> as a means to share the name changes I would make. But I think it looks\n> good.\n>\n> I'm keeping an eye on DefinitelyTyped/DefinitelyTyped#11640\n> <https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11640> to see\n> if something \"official\" comes out, but this seems like it will serve us\n> well.\n>\n> cc: @jarneson <https://github.com/jarneson>\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/jamietre/react-typescript-optional-props/pull/1\n> Commit Summary\n>\n>    - A little type renaming\n>\n> File Changes\n>\n>    - *M* src/greeting.tsx\n>    <https://github.com/jamietre/react-typescript-optional-props/pull/1/files#diff-0>\n>    (14)\n>\n> Patch Links:\n>\n>    - https://github.com/jamietre/react-typescript-optional-\n>    props/pull/1.patch\n>    - https://github.com/jamietre/react-typescript-optional-\n>    props/pull/1.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jamietre/react-typescript-optional-props/pull/1>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAi-gLMolwNGvdHPOANsqkmVEtWDNuJqks5tUipMgaJpZM4SEn_n>\n> .\n>\n"}}
{"actor":{"display_login":"jamietre"}}