{"action":"closed","number":15289,"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/15289","id":212522588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTIyNTg4","html_url":"https://github.com/frappe/erpnext/pull/15289","diff_url":"https://github.com/frappe/erpnext/pull/15289.diff","patch_url":"https://github.com/frappe/erpnext/pull/15289.patch","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/15289","number":15289,"state":"closed","locked":false,"title":"[fix] email digest date range problem","user":{"login":"RicardoJohann","id":14797383,"node_id":"MDQ6VXNlcjE0Nzk3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14797383?v=4","gravatar_id":"","url":"https://api.github.com/users/RicardoJohann","html_url":"https://github.com/RicardoJohann","followers_url":"https://api.github.com/users/RicardoJohann/followers","following_url":"https://api.github.com/users/RicardoJohann/following{/other_user}","gists_url":"https://api.github.com/users/RicardoJohann/gists{/gist_id}","starred_url":"https://api.github.com/users/RicardoJohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RicardoJohann/subscriptions","organizations_url":"https://api.github.com/users/RicardoJohann/orgs","repos_url":"https://api.github.com/users/RicardoJohann/repos","events_url":"https://api.github.com/users/RicardoJohann/events{/privacy}","received_events_url":"https://api.github.com/users/RicardoJohann/received_events","type":"User","site_admin":false},"body":"**Email Digest tested on Monthly, Weekly and Daily summary across Fiscal Years**\r\n\r\nTo test it I have used current fiscal year 01-07-2018 to 30-06-2019 and I made one sales invoice of tests on June-18 and one sales invoice in July 2018 (same invoice amounts, but one for last fiscal year and one for current fiscal year).\r\n\r\nThe example make was Monthly Summary values were expected only from July 2018, but then I got the wrong results for “New Income” like the amount of July 2018 subtracting everything in the past fiscal year (June 2018). So, the result was zero:\r\n\r\n![image](https://user-images.githubusercontent.com/14797383/44962437-b95f0480-aef6-11e8-8dc3-01a8b6d3ce9a.png)\r\n\r\n**AFTER FIX:**\r\n\r\nAfter fix it shows correctly just amounts for this financial year, in this case only the invoice I made in July 2018 is showing. For Weekly and Daily Summaries occurs the same error.\r\n\r\n![image](https://user-images.githubusercontent.com/14797383/44962439-c54ac680-aef6-11e8-8dad-4e62df8ecd18.png)\r\n\r\n\r\n","created_at":"2018-09-01T01:55:02Z","updated_at":"2018-09-05T07:52:05Z","closed_at":"2018-09-05T07:52:05Z","merged_at":null,"merge_commit_sha":"6e9410472f8db10093b17c0faa62f3c1a7c44e56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/erpnext/pulls/15289/commits","review_comments_url":"https://api.github.com/repos/frappe/erpnext/pulls/15289/comments","review_comment_url":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/15289/comments","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/d0d79992c865f6134dcf1bdad2e7c8af17b8f505","head":{"label":"RicardoJohann:date_range_email_digest_problem","ref":"date_range_email_digest_problem","sha":"d0d79992c865f6134dcf1bdad2e7c8af17b8f505","user":{"login":"RicardoJohann","id":14797383,"node_id":"MDQ6VXNlcjE0Nzk3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14797383?v=4","gravatar_id":"","url":"https://api.github.com/users/RicardoJohann","html_url":"https://github.com/RicardoJohann","followers_url":"https://api.github.com/users/RicardoJohann/followers","following_url":"https://api.github.com/users/RicardoJohann/following{/other_user}","gists_url":"https://api.github.com/users/RicardoJohann/gists{/gist_id}","starred_url":"https://api.github.com/users/RicardoJohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RicardoJohann/subscriptions","organizations_url":"https://api.github.com/users/RicardoJohann/orgs","repos_url":"https://api.github.com/users/RicardoJohann/repos","events_url":"https://api.github.com/users/RicardoJohann/events{/privacy}","received_events_url":"https://api.github.com/users/RicardoJohann/received_events","type":"User","site_admin":false},"repo":{"id":49472990,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQ3Mjk5MA==","name":"erpnext","full_name":"RicardoJohann/erpnext","owner":{"login":"RicardoJohann","id":14797383,"node_id":"MDQ6VXNlcjE0Nzk3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14797383?v=4","gravatar_id":"","url":"https://api.github.com/users/RicardoJohann","html_url":"https://github.com/RicardoJohann","followers_url":"https://api.github.com/users/RicardoJohann/followers","following_url":"https://api.github.com/users/RicardoJohann/following{/other_user}","gists_url":"https://api.github.com/users/RicardoJohann/gists{/gist_id}","starred_url":"https://api.github.com/users/RicardoJohann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RicardoJohann/subscriptions","organizations_url":"https://api.github.com/users/RicardoJohann/orgs","repos_url":"https://api.github.com/users/RicardoJohann/repos","events_url":"https://api.github.com/users/RicardoJohann/events{/privacy}","received_events_url":"https://api.github.com/users/RicardoJohann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RicardoJohann/erpnext","description":"Open Source ERP built for the Web. Uses Python, MariaDB.","fork":true,"url":"https://api.github.com/repos/RicardoJohann/erpnext","forks_url":"https://api.github.com/repos/RicardoJohann/erpnext/forks","keys_url":"https://api.github.com/repos/RicardoJohann/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RicardoJohann/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RicardoJohann/erpnext/teams","hooks_url":"https://api.github.com/repos/RicardoJohann/erpnext/hooks","issue_events_url":"https://api.github.com/repos/RicardoJohann/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/RicardoJohann/erpnext/events","assignees_url":"https://api.github.com/repos/RicardoJohann/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/RicardoJohann/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/RicardoJohann/erpnext/tags","blobs_url":"https://api.github.com/repos/RicardoJohann/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RicardoJohann/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RicardoJohann/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/RicardoJohann/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RicardoJohann/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/RicardoJohann/erpnext/languages","stargazers_url":"https://api.github.com/repos/RicardoJohann/erpnext/stargazers","contributors_url":"https://api.github.com/repos/RicardoJohann/erpnext/contributors","subscribers_url":"https://api.github.com/repos/RicardoJohann/erpnext/subscribers","subscription_url":"https://api.github.com/repos/RicardoJohann/erpnext/subscription","commits_url":"https://api.github.com/repos/RicardoJohann/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/RicardoJohann/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/RicardoJohann/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/RicardoJohann/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/RicardoJohann/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/RicardoJohann/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RicardoJohann/erpnext/merges","archive_url":"https://api.github.com/repos/RicardoJohann/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RicardoJohann/erpnext/downloads","issues_url":"https://api.github.com/repos/RicardoJohann/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/RicardoJohann/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/RicardoJohann/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/RicardoJohann/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RicardoJohann/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/RicardoJohann/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/RicardoJohann/erpnext/deployments","created_at":"2016-01-12T03:41:51Z","updated_at":"2018-07-30T01:35:43Z","pushed_at":"2018-09-05T01:50:44Z","git_url":"git://github.com/RicardoJohann/erpnext.git","ssh_url":"git@github.com:RicardoJohann/erpnext.git","clone_url":"https://github.com/RicardoJohann/erpnext.git","svn_url":"https://github.com/RicardoJohann/erpnext","homepage":"http://erpnext.com","size":611814,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"3588486e5b5ddf017221504dc7872eb98f432d87","user":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864233,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MjMz","name":"erpnext","full_name":"frappe/erpnext","owner":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/erpnext","description":"Open Source ERP built for the web","fork":false,"url":"https://api.github.com/repos/frappe/erpnext","forks_url":"https://api.github.com/repos/frappe/erpnext/forks","keys_url":"https://api.github.com/repos/frappe/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/erpnext/teams","hooks_url":"https://api.github.com/repos/frappe/erpnext/hooks","issue_events_url":"https://api.github.com/repos/frappe/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/erpnext/events","assignees_url":"https://api.github.com/repos/frappe/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/erpnext/tags","blobs_url":"https://api.github.com/repos/frappe/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/erpnext/languages","stargazers_url":"https://api.github.com/repos/frappe/erpnext/stargazers","contributors_url":"https://api.github.com/repos/frappe/erpnext/contributors","subscribers_url":"https://api.github.com/repos/frappe/erpnext/subscribers","subscription_url":"https://api.github.com/repos/frappe/erpnext/subscription","commits_url":"https://api.github.com/repos/frappe/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/erpnext/merges","archive_url":"https://api.github.com/repos/frappe/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/erpnext/downloads","issues_url":"https://api.github.com/repos/frappe/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/frappe/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/erpnext/deployments","created_at":"2011-06-08T08:20:56Z","updated_at":"2018-09-05T06:17:56Z","pushed_at":"2018-09-05T07:51:16Z","git_url":"git://github.com/frappe/erpnext.git","ssh_url":"git@github.com:frappe/erpnext.git","clone_url":"https://github.com/frappe/erpnext.git","svn_url":"https://github.com/frappe/erpnext","homepage":"http://erpnext.com","size":637764,"stargazers_count":3700,"watchers_count":3700,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1736,"mirror_url":null,"archived":false,"open_issues_count":1637,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1736,"open_issues":1637,"watchers":3700,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/15289"},"html":{"href":"https://github.com/frappe/erpnext/pull/15289"},"issue":{"href":"https://api.github.com/repos/frappe/erpnext/issues/15289"},"comments":{"href":"https://api.github.com/repos/frappe/erpnext/issues/15289/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/15289/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/15289/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/erpnext/statuses/d0d79992c865f6134dcf1bdad2e7c8af17b8f505"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"nabinhait"}}