{"action":"created","comment":{"url":"https://api.github.com/repos/imsweb/django-seeker/pulls/comments/229438626","pull_request_review_id":169940175,"id":229438626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQzODYyNg==","diff_hunk":"@@ -77,15 +82,15 @@ def __init__(self, mapping, query=None, filters=None, facets=None, highlight=Non\n         self.highlight = highlight or {}\n         if isinstance(self.highlight, (list, tuple)):\n             self.highlight = {'fields': {f: {'number_of_fragments': 0} for f in self.highlight}}\n-        elif isinstance(self.highlight, basestring):\n+        elif isinstance(self.highlight, str):","path":"seeker/query.py","position":53,"original_position":53,"commit_id":"0795f3645352d7bade6501f79deb4cfe6ddd73d7","original_commit_id":"0795f3645352d7bade6501f79deb4cfe6ddd73d7","user":{"login":"dcwatson","id":293445,"node_id":"MDQ6VXNlcjI5MzQ0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/293445?v=4","gravatar_id":"","url":"https://api.github.com/users/dcwatson","html_url":"https://github.com/dcwatson","followers_url":"https://api.github.com/users/dcwatson/followers","following_url":"https://api.github.com/users/dcwatson/following{/other_user}","gists_url":"https://api.github.com/users/dcwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/dcwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcwatson/subscriptions","organizations_url":"https://api.github.com/users/dcwatson/orgs","repos_url":"https://api.github.com/users/dcwatson/repos","events_url":"https://api.github.com/users/dcwatson/events{/privacy}","received_events_url":"https://api.github.com/users/dcwatson/received_events","type":"User","site_admin":false},"body":"There a reason not to use `six.string_types` here (and below) as well?","created_at":"2018-10-30T18:44:40Z","updated_at":"2018-10-30T18:49:53Z","html_url":"https://github.com/imsweb/django-seeker/pull/68#discussion_r229438626","pull_request_url":"https://api.github.com/repos/imsweb/django-seeker/pulls/68","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/comments/229438626"},"html":{"href":"https://github.com/imsweb/django-seeker/pull/68#discussion_r229438626"},"pull_request":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/imsweb/django-seeker/pulls/68","id":223627553,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjI3NTUz","html_url":"https://github.com/imsweb/django-seeker/pull/68","diff_url":"https://github.com/imsweb/django-seeker/pull/68.diff","patch_url":"https://github.com/imsweb/django-seeker/pull/68.patch","issue_url":"https://api.github.com/repos/imsweb/django-seeker/issues/68","number":68,"state":"open","locked":false,"title":"1.2 python3","user":{"login":"cmazzullo","id":6260723,"node_id":"MDQ6VXNlcjYyNjA3MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6260723?v=4","gravatar_id":"","url":"https://api.github.com/users/cmazzullo","html_url":"https://github.com/cmazzullo","followers_url":"https://api.github.com/users/cmazzullo/followers","following_url":"https://api.github.com/users/cmazzullo/following{/other_user}","gists_url":"https://api.github.com/users/cmazzullo/gists{/gist_id}","starred_url":"https://api.github.com/users/cmazzullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmazzullo/subscriptions","organizations_url":"https://api.github.com/users/cmazzullo/orgs","repos_url":"https://api.github.com/users/cmazzullo/repos","events_url":"https://api.github.com/users/cmazzullo/events{/privacy}","received_events_url":"https://api.github.com/users/cmazzullo/received_events","type":"User","site_admin":false},"body":"Seeker 1.2, updated to work on Python3\r\n\r\n- Ran 2to3 on the project, then munged the tests and settings a bit to get everything working (so far). \r\n- Changed the test settings to make it easier to get tests running and updated the docs to reflect this.","created_at":"2018-10-17T14:29:51Z","updated_at":"2018-10-30T18:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"809495760e2a9399b7b4f1aa5f3049c842d914dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/imsweb/django-seeker/pulls/68/commits","review_comments_url":"https://api.github.com/repos/imsweb/django-seeker/pulls/68/comments","review_comment_url":"https://api.github.com/repos/imsweb/django-seeker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imsweb/django-seeker/issues/68/comments","statuses_url":"https://api.github.com/repos/imsweb/django-seeker/statuses/0795f3645352d7bade6501f79deb4cfe6ddd73d7","head":{"label":"cmazzullo:1.2-python3","ref":"1.2-python3","sha":"0795f3645352d7bade6501f79deb4cfe6ddd73d7","user":{"login":"cmazzullo","id":6260723,"node_id":"MDQ6VXNlcjYyNjA3MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6260723?v=4","gravatar_id":"","url":"https://api.github.com/users/cmazzullo","html_url":"https://github.com/cmazzullo","followers_url":"https://api.github.com/users/cmazzullo/followers","following_url":"https://api.github.com/users/cmazzullo/following{/other_user}","gists_url":"https://api.github.com/users/cmazzullo/gists{/gist_id}","starred_url":"https://api.github.com/users/cmazzullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmazzullo/subscriptions","organizations_url":"https://api.github.com/users/cmazzullo/orgs","repos_url":"https://api.github.com/users/cmazzullo/repos","events_url":"https://api.github.com/users/cmazzullo/events{/privacy}","received_events_url":"https://api.github.com/users/cmazzullo/received_events","type":"User","site_admin":false},"repo":{"id":153469967,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0Njk5Njc=","name":"django-seeker","full_name":"cmazzullo/django-seeker","private":false,"owner":{"login":"cmazzullo","id":6260723,"node_id":"MDQ6VXNlcjYyNjA3MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6260723?v=4","gravatar_id":"","url":"https://api.github.com/users/cmazzullo","html_url":"https://github.com/cmazzullo","followers_url":"https://api.github.com/users/cmazzullo/followers","following_url":"https://api.github.com/users/cmazzullo/following{/other_user}","gists_url":"https://api.github.com/users/cmazzullo/gists{/gist_id}","starred_url":"https://api.github.com/users/cmazzullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmazzullo/subscriptions","organizations_url":"https://api.github.com/users/cmazzullo/orgs","repos_url":"https://api.github.com/users/cmazzullo/repos","events_url":"https://api.github.com/users/cmazzullo/events{/privacy}","received_events_url":"https://api.github.com/users/cmazzullo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmazzullo/django-seeker","description":"A python package for indexing, mapping, and querying/faceting Django models in Elasticsearch","fork":true,"url":"https://api.github.com/repos/cmazzullo/django-seeker","forks_url":"https://api.github.com/repos/cmazzullo/django-seeker/forks","keys_url":"https://api.github.com/repos/cmazzullo/django-seeker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmazzullo/django-seeker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmazzullo/django-seeker/teams","hooks_url":"https://api.github.com/repos/cmazzullo/django-seeker/hooks","issue_events_url":"https://api.github.com/repos/cmazzullo/django-seeker/issues/events{/number}","events_url":"https://api.github.com/repos/cmazzullo/django-seeker/events","assignees_url":"https://api.github.com/repos/cmazzullo/django-seeker/assignees{/user}","branches_url":"https://api.github.com/repos/cmazzullo/django-seeker/branches{/branch}","tags_url":"https://api.github.com/repos/cmazzullo/django-seeker/tags","blobs_url":"https://api.github.com/repos/cmazzullo/django-seeker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmazzullo/django-seeker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmazzullo/django-seeker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmazzullo/django-seeker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmazzullo/django-seeker/statuses/{sha}","languages_url":"https://api.github.com/repos/cmazzullo/django-seeker/languages","stargazers_url":"https://api.github.com/repos/cmazzullo/django-seeker/stargazers","contributors_url":"https://api.github.com/repos/cmazzullo/django-seeker/contributors","subscribers_url":"https://api.github.com/repos/cmazzullo/django-seeker/subscribers","subscription_url":"https://api.github.com/repos/cmazzullo/django-seeker/subscription","commits_url":"https://api.github.com/repos/cmazzullo/django-seeker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmazzullo/django-seeker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmazzullo/django-seeker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmazzullo/django-seeker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmazzullo/django-seeker/contents/{+path}","compare_url":"https://api.github.com/repos/cmazzullo/django-seeker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmazzullo/django-seeker/merges","archive_url":"https://api.github.com/repos/cmazzullo/django-seeker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmazzullo/django-seeker/downloads","issues_url":"https://api.github.com/repos/cmazzullo/django-seeker/issues{/number}","pulls_url":"https://api.github.com/repos/cmazzullo/django-seeker/pulls{/number}","milestones_url":"https://api.github.com/repos/cmazzullo/django-seeker/milestones{/number}","notifications_url":"https://api.github.com/repos/cmazzullo/django-seeker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmazzullo/django-seeker/labels{/name}","releases_url":"https://api.github.com/repos/cmazzullo/django-seeker/releases{/id}","deployments_url":"https://api.github.com/repos/cmazzullo/django-seeker/deployments","created_at":"2018-10-17T14:21:32Z","updated_at":"2018-10-17T14:21:36Z","pushed_at":"2018-10-30T18:29:46Z","git_url":"git://github.com/cmazzullo/django-seeker.git","ssh_url":"git@github.com:cmazzullo/django-seeker.git","clone_url":"https://github.com/cmazzullo/django-seeker.git","svn_url":"https://github.com/cmazzullo/django-seeker","homepage":null,"size":503,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"imsweb:1.2","ref":"1.2","sha":"4b49ea696d9f9ddb0c965a1d5b0a82457793a54f","user":{"login":"imsweb","id":3653271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTMyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3653271?v=4","gravatar_id":"","url":"https://api.github.com/users/imsweb","html_url":"https://github.com/imsweb","followers_url":"https://api.github.com/users/imsweb/followers","following_url":"https://api.github.com/users/imsweb/following{/other_user}","gists_url":"https://api.github.com/users/imsweb/gists{/gist_id}","starred_url":"https://api.github.com/users/imsweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsweb/subscriptions","organizations_url":"https://api.github.com/users/imsweb/orgs","repos_url":"https://api.github.com/users/imsweb/repos","events_url":"https://api.github.com/users/imsweb/events{/privacy}","received_events_url":"https://api.github.com/users/imsweb/received_events","type":"Organization","site_admin":false},"repo":{"id":23965009,"node_id":"MDEwOlJlcG9zaXRvcnkyMzk2NTAwOQ==","name":"django-seeker","full_name":"imsweb/django-seeker","private":false,"owner":{"login":"imsweb","id":3653271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTMyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3653271?v=4","gravatar_id":"","url":"https://api.github.com/users/imsweb","html_url":"https://github.com/imsweb","followers_url":"https://api.github.com/users/imsweb/followers","following_url":"https://api.github.com/users/imsweb/following{/other_user}","gists_url":"https://api.github.com/users/imsweb/gists{/gist_id}","starred_url":"https://api.github.com/users/imsweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsweb/subscriptions","organizations_url":"https://api.github.com/users/imsweb/orgs","repos_url":"https://api.github.com/users/imsweb/repos","events_url":"https://api.github.com/users/imsweb/events{/privacy}","received_events_url":"https://api.github.com/users/imsweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/imsweb/django-seeker","description":"A python package for indexing, mapping, and querying/faceting Django models in Elasticsearch","fork":false,"url":"https://api.github.com/repos/imsweb/django-seeker","forks_url":"https://api.github.com/repos/imsweb/django-seeker/forks","keys_url":"https://api.github.com/repos/imsweb/django-seeker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imsweb/django-seeker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imsweb/django-seeker/teams","hooks_url":"https://api.github.com/repos/imsweb/django-seeker/hooks","issue_events_url":"https://api.github.com/repos/imsweb/django-seeker/issues/events{/number}","events_url":"https://api.github.com/repos/imsweb/django-seeker/events","assignees_url":"https://api.github.com/repos/imsweb/django-seeker/assignees{/user}","branches_url":"https://api.github.com/repos/imsweb/django-seeker/branches{/branch}","tags_url":"https://api.github.com/repos/imsweb/django-seeker/tags","blobs_url":"https://api.github.com/repos/imsweb/django-seeker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imsweb/django-seeker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imsweb/django-seeker/git/refs{/sha}","trees_url":"https://api.github.com/repos/imsweb/django-seeker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imsweb/django-seeker/statuses/{sha}","languages_url":"https://api.github.com/repos/imsweb/django-seeker/languages","stargazers_url":"https://api.github.com/repos/imsweb/django-seeker/stargazers","contributors_url":"https://api.github.com/repos/imsweb/django-seeker/contributors","subscribers_url":"https://api.github.com/repos/imsweb/django-seeker/subscribers","subscription_url":"https://api.github.com/repos/imsweb/django-seeker/subscription","commits_url":"https://api.github.com/repos/imsweb/django-seeker/commits{/sha}","git_commits_url":"https://api.github.com/repos/imsweb/django-seeker/git/commits{/sha}","comments_url":"https://api.github.com/repos/imsweb/django-seeker/comments{/number}","issue_comment_url":"https://api.github.com/repos/imsweb/django-seeker/issues/comments{/number}","contents_url":"https://api.github.com/repos/imsweb/django-seeker/contents/{+path}","compare_url":"https://api.github.com/repos/imsweb/django-seeker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imsweb/django-seeker/merges","archive_url":"https://api.github.com/repos/imsweb/django-seeker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imsweb/django-seeker/downloads","issues_url":"https://api.github.com/repos/imsweb/django-seeker/issues{/number}","pulls_url":"https://api.github.com/repos/imsweb/django-seeker/pulls{/number}","milestones_url":"https://api.github.com/repos/imsweb/django-seeker/milestones{/number}","notifications_url":"https://api.github.com/repos/imsweb/django-seeker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imsweb/django-seeker/labels{/name}","releases_url":"https://api.github.com/repos/imsweb/django-seeker/releases{/id}","deployments_url":"https://api.github.com/repos/imsweb/django-seeker/deployments","created_at":"2014-09-12T15:03:56Z","updated_at":"2018-08-24T14:02:03Z","pushed_at":"2018-10-30T18:29:48Z","git_url":"git://github.com/imsweb/django-seeker.git","ssh_url":"git@github.com:imsweb/django-seeker.git","clone_url":"https://github.com/imsweb/django-seeker.git","svn_url":"https://github.com/imsweb/django-seeker","homepage":null,"size":523,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":16,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/68"},"html":{"href":"https://github.com/imsweb/django-seeker/pull/68"},"issue":{"href":"https://api.github.com/repos/imsweb/django-seeker/issues/68"},"comments":{"href":"https://api.github.com/repos/imsweb/django-seeker/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imsweb/django-seeker/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/imsweb/django-seeker/statuses/0795f3645352d7bade6501f79deb4cfe6ddd73d7"}},"author_association":"NONE"}}
{"actor":{"display_login":"dcwatson"}}