{"action":"created","comment":{"url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/comments/209284526","pull_request_review_id":145272848,"id":209284526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI4NDUyNg==","diff_hunk":"@@ -545,11 +546,18 @@ appendGoR =\n     Modify.appendGoR\n \n \n-{-| Append a list to the right.\n+{-| Append a list to the front of the left.\n -}\n-appendList : List a -> Pivot a\n-appendList =\n-    Modify.appendList\n+appendListL : List a -> Pivot a -> Pivot a\n+appendListL =\n+    Modify.appendListL\n+\n+\n+{-| Append a list to the back of the right.","path":"src/Pivot.elm","position":451,"original_position":37,"commit_id":"4a5e17934f397ab0548396a19d8ac35776eb2c38","original_commit_id":"27b3675a34fb0c9d7325cab7b923d59b4b94f72a","user":{"login":"toastal","id":561087,"node_id":"MDQ6VXNlcjU2MTA4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/561087?v=4","gravatar_id":"","url":"https://api.github.com/users/toastal","html_url":"https://github.com/toastal","followers_url":"https://api.github.com/users/toastal/followers","following_url":"https://api.github.com/users/toastal/following{/other_user}","gists_url":"https://api.github.com/users/toastal/gists{/gist_id}","starred_url":"https://api.github.com/users/toastal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toastal/subscriptions","organizations_url":"https://api.github.com/users/toastal/orgs","repos_url":"https://api.github.com/users/toastal/repos","events_url":"https://api.github.com/users/toastal/events{/privacy}","received_events_url":"https://api.github.com/users/toastal/received_events","type":"User","site_admin":false},"body":"Right. I know why it's reversed, I'm just not having a good day for thinking. Haha. This implementation would also make some sense, but is probably more confusing.\r\n\r\n```elm\r\nappendListL [6,7]  pivot == Pivot 3 ( [ 2, 1, 7, 6 ], [ 4, 5 ] )\r\nappendListL [6,7]  pivot |> getA == [ 7, 6, 1, 2, 3, 4, 5 ]\r\n```","created_at":"2018-08-10T14:47:33Z","updated_at":"2018-08-10T14:47:33Z","html_url":"https://github.com/yotamDvir/elm-pivot/pull/9#discussion_r209284526","pull_request_url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/comments/209284526"},"html":{"href":"https://github.com/yotamDvir/elm-pivot/pull/9#discussion_r209284526"},"pull_request":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9"}},"in_reply_to_id":209218023},"pull_request":{"url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9","id":207203206,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjAzMjA2","html_url":"https://github.com/yotamDvir/elm-pivot/pull/9","diff_url":"https://github.com/yotamDvir/elm-pivot/pull/9.diff","patch_url":"https://github.com/yotamDvir/elm-pivot/pull/9.patch","issue_url":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/9","number":9,"state":"open","locked":false,"title":"Upgrading to Elm v0.19","user":{"login":"toastal","id":561087,"node_id":"MDQ6VXNlcjU2MTA4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/561087?v=4","gravatar_id":"","url":"https://api.github.com/users/toastal","html_url":"https://github.com/toastal","followers_url":"https://api.github.com/users/toastal/followers","following_url":"https://api.github.com/users/toastal/following{/other_user}","gists_url":"https://api.github.com/users/toastal/gists{/gist_id}","starred_url":"https://api.github.com/users/toastal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toastal/subscriptions","organizations_url":"https://api.github.com/users/toastal/orgs","repos_url":"https://api.github.com/users/toastal/repos","events_url":"https://api.github.com/users/toastal/events{/privacy}","received_events_url":"https://api.github.com/users/toastal/received_events","type":"User","site_admin":false},"body":"I ran the upgrade script, but also\r\n\r\n- cases on lists and maybe test the empty first which is more efficient that unwrapping\r\n- add functions are now called append\r\n- appendList can append a list (should there be a appendListL/R?)\r\n\r\n**TODO**: \r\n\r\n- run Elm's version bump\r\n- tests ... I didn't even try\r\n\r\nfixes #7","created_at":"2018-08-09T05:18:20Z","updated_at":"2018-08-10T14:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc1abed437a1bb011a0714b81990eec3cd15c589","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9/commits","review_comments_url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9/comments","review_comment_url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/9/comments","statuses_url":"https://api.github.com/repos/yotamDvir/elm-pivot/statuses/4a5e17934f397ab0548396a19d8ac35776eb2c38","head":{"label":"toastal:master","ref":"master","sha":"4a5e17934f397ab0548396a19d8ac35776eb2c38","user":{"login":"toastal","id":561087,"node_id":"MDQ6VXNlcjU2MTA4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/561087?v=4","gravatar_id":"","url":"https://api.github.com/users/toastal","html_url":"https://github.com/toastal","followers_url":"https://api.github.com/users/toastal/followers","following_url":"https://api.github.com/users/toastal/following{/other_user}","gists_url":"https://api.github.com/users/toastal/gists{/gist_id}","starred_url":"https://api.github.com/users/toastal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toastal/subscriptions","organizations_url":"https://api.github.com/users/toastal/orgs","repos_url":"https://api.github.com/users/toastal/repos","events_url":"https://api.github.com/users/toastal/events{/privacy}","received_events_url":"https://api.github.com/users/toastal/received_events","type":"User","site_admin":false},"repo":{"id":75113864,"node_id":"MDEwOlJlcG9zaXRvcnk3NTExMzg2NA==","name":"elm-pivot","full_name":"toastal/elm-pivot","owner":{"login":"toastal","id":561087,"node_id":"MDQ6VXNlcjU2MTA4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/561087?v=4","gravatar_id":"","url":"https://api.github.com/users/toastal","html_url":"https://github.com/toastal","followers_url":"https://api.github.com/users/toastal/followers","following_url":"https://api.github.com/users/toastal/following{/other_user}","gists_url":"https://api.github.com/users/toastal/gists{/gist_id}","starred_url":"https://api.github.com/users/toastal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toastal/subscriptions","organizations_url":"https://api.github.com/users/toastal/orgs","repos_url":"https://api.github.com/users/toastal/repos","events_url":"https://api.github.com/users/toastal/events{/privacy}","received_events_url":"https://api.github.com/users/toastal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toastal/elm-pivot","description":"Pivot: a list with a cursor pointing at the center, like a zipper.","fork":true,"url":"https://api.github.com/repos/toastal/elm-pivot","forks_url":"https://api.github.com/repos/toastal/elm-pivot/forks","keys_url":"https://api.github.com/repos/toastal/elm-pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toastal/elm-pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toastal/elm-pivot/teams","hooks_url":"https://api.github.com/repos/toastal/elm-pivot/hooks","issue_events_url":"https://api.github.com/repos/toastal/elm-pivot/issues/events{/number}","events_url":"https://api.github.com/repos/toastal/elm-pivot/events","assignees_url":"https://api.github.com/repos/toastal/elm-pivot/assignees{/user}","branches_url":"https://api.github.com/repos/toastal/elm-pivot/branches{/branch}","tags_url":"https://api.github.com/repos/toastal/elm-pivot/tags","blobs_url":"https://api.github.com/repos/toastal/elm-pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toastal/elm-pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toastal/elm-pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/toastal/elm-pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toastal/elm-pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/toastal/elm-pivot/languages","stargazers_url":"https://api.github.com/repos/toastal/elm-pivot/stargazers","contributors_url":"https://api.github.com/repos/toastal/elm-pivot/contributors","subscribers_url":"https://api.github.com/repos/toastal/elm-pivot/subscribers","subscription_url":"https://api.github.com/repos/toastal/elm-pivot/subscription","commits_url":"https://api.github.com/repos/toastal/elm-pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/toastal/elm-pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/toastal/elm-pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/toastal/elm-pivot/issues/comments{/number}","contents_url":"https://api.github.com/repos/toastal/elm-pivot/contents/{+path}","compare_url":"https://api.github.com/repos/toastal/elm-pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toastal/elm-pivot/merges","archive_url":"https://api.github.com/repos/toastal/elm-pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toastal/elm-pivot/downloads","issues_url":"https://api.github.com/repos/toastal/elm-pivot/issues{/number}","pulls_url":"https://api.github.com/repos/toastal/elm-pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/toastal/elm-pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/toastal/elm-pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toastal/elm-pivot/labels{/name}","releases_url":"https://api.github.com/repos/toastal/elm-pivot/releases{/id}","deployments_url":"https://api.github.com/repos/toastal/elm-pivot/deployments","created_at":"2016-11-29T19:19:32Z","updated_at":"2018-08-10T06:50:48Z","pushed_at":"2018-08-10T06:50:46Z","git_url":"git://github.com/toastal/elm-pivot.git","ssh_url":"git@github.com:toastal/elm-pivot.git","clone_url":"https://github.com/toastal/elm-pivot.git","svn_url":"https://github.com/toastal/elm-pivot","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Elm","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yotamDvir:master","ref":"master","sha":"cee1b982a22a525758ab7f738c682b364132756b","user":{"login":"yotamDvir","id":14016623,"node_id":"MDQ6VXNlcjE0MDE2NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/14016623?v=4","gravatar_id":"","url":"https://api.github.com/users/yotamDvir","html_url":"https://github.com/yotamDvir","followers_url":"https://api.github.com/users/yotamDvir/followers","following_url":"https://api.github.com/users/yotamDvir/following{/other_user}","gists_url":"https://api.github.com/users/yotamDvir/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamDvir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamDvir/subscriptions","organizations_url":"https://api.github.com/users/yotamDvir/orgs","repos_url":"https://api.github.com/users/yotamDvir/repos","events_url":"https://api.github.com/users/yotamDvir/events{/privacy}","received_events_url":"https://api.github.com/users/yotamDvir/received_events","type":"User","site_admin":false},"repo":{"id":66660531,"node_id":"MDEwOlJlcG9zaXRvcnk2NjY2MDUzMQ==","name":"elm-pivot","full_name":"yotamDvir/elm-pivot","owner":{"login":"yotamDvir","id":14016623,"node_id":"MDQ6VXNlcjE0MDE2NjIz","avatar_url":"https://avatars0.githubusercontent.com/u/14016623?v=4","gravatar_id":"","url":"https://api.github.com/users/yotamDvir","html_url":"https://github.com/yotamDvir","followers_url":"https://api.github.com/users/yotamDvir/followers","following_url":"https://api.github.com/users/yotamDvir/following{/other_user}","gists_url":"https://api.github.com/users/yotamDvir/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamDvir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamDvir/subscriptions","organizations_url":"https://api.github.com/users/yotamDvir/orgs","repos_url":"https://api.github.com/users/yotamDvir/repos","events_url":"https://api.github.com/users/yotamDvir/events{/privacy}","received_events_url":"https://api.github.com/users/yotamDvir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yotamDvir/elm-pivot","description":"Pivot: a list with a cursor pointing at the center, like a zipper.","fork":false,"url":"https://api.github.com/repos/yotamDvir/elm-pivot","forks_url":"https://api.github.com/repos/yotamDvir/elm-pivot/forks","keys_url":"https://api.github.com/repos/yotamDvir/elm-pivot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yotamDvir/elm-pivot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yotamDvir/elm-pivot/teams","hooks_url":"https://api.github.com/repos/yotamDvir/elm-pivot/hooks","issue_events_url":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/events{/number}","events_url":"https://api.github.com/repos/yotamDvir/elm-pivot/events","assignees_url":"https://api.github.com/repos/yotamDvir/elm-pivot/assignees{/user}","branches_url":"https://api.github.com/repos/yotamDvir/elm-pivot/branches{/branch}","tags_url":"https://api.github.com/repos/yotamDvir/elm-pivot/tags","blobs_url":"https://api.github.com/repos/yotamDvir/elm-pivot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yotamDvir/elm-pivot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yotamDvir/elm-pivot/git/refs{/sha}","trees_url":"https://api.github.com/repos/yotamDvir/elm-pivot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yotamDvir/elm-pivot/statuses/{sha}","languages_url":"https://api.github.com/repos/yotamDvir/elm-pivot/languages","stargazers_url":"https://api.github.com/repos/yotamDvir/elm-pivot/stargazers","contributors_url":"https://api.github.com/repos/yotamDvir/elm-pivot/contributors","subscribers_url":"https://api.github.com/repos/yotamDvir/elm-pivot/subscribers","subscription_url":"https://api.github.com/repos/yotamDvir/elm-pivot/subscription","commits_url":"https://api.github.com/repos/yotamDvir/elm-pivot/commits{/sha}","git_commits_url":"https://api.github.com/repos/yotamDvir/elm-pivot/git/commits{/sha}","comments_url":"https://api.github.com/repos/yotamDvir/elm-pivot/comments{/number}","issue_comment_url":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/comments{/number}","contents_url":"https://api.github.com/repos/yotamDvir/elm-pivot/contents/{+path}","compare_url":"https://api.github.com/repos/yotamDvir/elm-pivot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yotamDvir/elm-pivot/merges","archive_url":"https://api.github.com/repos/yotamDvir/elm-pivot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yotamDvir/elm-pivot/downloads","issues_url":"https://api.github.com/repos/yotamDvir/elm-pivot/issues{/number}","pulls_url":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls{/number}","milestones_url":"https://api.github.com/repos/yotamDvir/elm-pivot/milestones{/number}","notifications_url":"https://api.github.com/repos/yotamDvir/elm-pivot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yotamDvir/elm-pivot/labels{/name}","releases_url":"https://api.github.com/repos/yotamDvir/elm-pivot/releases{/id}","deployments_url":"https://api.github.com/repos/yotamDvir/elm-pivot/deployments","created_at":"2016-08-26T15:54:29Z","updated_at":"2017-10-22T06:14:06Z","pushed_at":"2018-08-10T06:50:47Z","git_url":"git://github.com/yotamDvir/elm-pivot.git","ssh_url":"git@github.com:yotamDvir/elm-pivot.git","clone_url":"https://github.com/yotamDvir/elm-pivot.git","svn_url":"https://github.com/yotamDvir/elm-pivot","homepage":null,"size":30,"stargazers_count":7,"watchers_count":7,"language":"Elm","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":4,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9"},"html":{"href":"https://github.com/yotamDvir/elm-pivot/pull/9"},"issue":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/9"},"comments":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/yotamDvir/elm-pivot/statuses/4a5e17934f397ab0548396a19d8ac35776eb2c38"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"toastal"}}