{"action":"created","comment":{"url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments/180652625","pull_request_review_id":111107274,"id":180652625,"diff_hunk":"@@ -17,53 +17,96 @@\n \n package com.toshi.manager\n \n+import android.content.Context\n+import com.toshi.crypto.HDWallet\n import com.toshi.manager.network.DirectoryInterface\n import com.toshi.manager.network.DirectoryService\n import com.toshi.model.network.dapp.DappResult\n import com.toshi.model.network.dapp.DappSearchResult\n import com.toshi.model.network.dapp.DappSections\n+import com.toshi.util.dappUtil.CoinbaseDappVerifier\n+import com.toshi.view.BaseApplication\n import rx.Scheduler\n import rx.Single\n import rx.schedulers.Schedulers\n+import java.util.concurrent.TimeUnit\n \n class DappManager(\n         private val directoryService: DirectoryInterface = DirectoryService.get(),\n+        private val context: Context = BaseApplication.get(),\n+        private val coinbaseDappVerifier: CoinbaseDappVerifier = CoinbaseDappVerifier(context),","path":"app/src/main/java/com/toshi/manager/DappManager.kt","position":21,"original_position":21,"commit_id":"36b9febc6496a82aed06c62fd7307b72eab802ba","original_commit_id":"8eb6c78c8f954145164f66fff4457276e74b38b3","user":{"login":"martintoften","id":10745215,"avatar_url":"https://avatars2.githubusercontent.com/u/10745215?v=4","gravatar_id":"","url":"https://api.github.com/users/martintoften","html_url":"https://github.com/martintoften","followers_url":"https://api.github.com/users/martintoften/followers","following_url":"https://api.github.com/users/martintoften/following{/other_user}","gists_url":"https://api.github.com/users/martintoften/gists{/gist_id}","starred_url":"https://api.github.com/users/martintoften/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martintoften/subscriptions","organizations_url":"https://api.github.com/users/martintoften/orgs","repos_url":"https://api.github.com/users/martintoften/repos","events_url":"https://api.github.com/users/martintoften/events{/privacy}","received_events_url":"https://api.github.com/users/martintoften/received_events","type":"User","site_admin":false},"body":"No, DappManager should know which strings CoinbaseVerifier uses,","created_at":"2018-04-11T07:02:17Z","updated_at":"2018-04-11T07:02:17Z","html_url":"https://github.com/toshiapp/toshi-android-client/pull/985#discussion_r180652625","pull_request_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments/180652625"},"html":{"href":"https://github.com/toshiapp/toshi-android-client/pull/985#discussion_r180652625"},"pull_request":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985"}},"in_reply_to_id":180648127},"pull_request":{"url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985","id":180659303,"html_url":"https://github.com/toshiapp/toshi-android-client/pull/985","diff_url":"https://github.com/toshiapp/toshi-android-client/pull/985.diff","patch_url":"https://github.com/toshiapp/toshi-android-client/pull/985.patch","issue_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/985","number":985,"state":"open","locked":false,"title":"Coinbase dapp","user":{"login":"martintoften","id":10745215,"avatar_url":"https://avatars2.githubusercontent.com/u/10745215?v=4","gravatar_id":"","url":"https://api.github.com/users/martintoften","html_url":"https://github.com/martintoften","followers_url":"https://api.github.com/users/martintoften/followers","following_url":"https://api.github.com/users/martintoften/following{/other_user}","gists_url":"https://api.github.com/users/martintoften/gists{/gist_id}","starred_url":"https://api.github.com/users/martintoften/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martintoften/subscriptions","organizations_url":"https://api.github.com/users/martintoften/orgs","repos_url":"https://api.github.com/users/martintoften/repos","events_url":"https://api.github.com/users/martintoften/events{/privacy}","received_events_url":"https://api.github.com/users/martintoften/received_events","type":"User","site_admin":false},"body":"Coinbase dapp\r\n\r\n![coinbase-dapp](https://user-images.githubusercontent.com/10745215/38569671-2e012002-3cec-11e8-8a9d-95d0f8045d2f.gif)\r\n","created_at":"2018-04-10T16:27:42Z","updated_at":"2018-04-11T07:02:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3e98adb00723b7a021eea2e472e3253b9eec239","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tristan","id":1412,"avatar_url":"https://avatars1.githubusercontent.com/u/1412?v=4","gravatar_id":"","url":"https://api.github.com/users/tristan","html_url":"https://github.com/tristan","followers_url":"https://api.github.com/users/tristan/followers","following_url":"https://api.github.com/users/tristan/following{/other_user}","gists_url":"https://api.github.com/users/tristan/gists{/gist_id}","starred_url":"https://api.github.com/users/tristan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristan/subscriptions","organizations_url":"https://api.github.com/users/tristan/orgs","repos_url":"https://api.github.com/users/tristan/repos","events_url":"https://api.github.com/users/tristan/events{/privacy}","received_events_url":"https://api.github.com/users/tristan/received_events","type":"User","site_admin":false},{"login":"faymontage","id":7949897,"avatar_url":"https://avatars2.githubusercontent.com/u/7949897?v=4","gravatar_id":"","url":"https://api.github.com/users/faymontage","html_url":"https://github.com/faymontage","followers_url":"https://api.github.com/users/faymontage/followers","following_url":"https://api.github.com/users/faymontage/following{/other_user}","gists_url":"https://api.github.com/users/faymontage/gists{/gist_id}","starred_url":"https://api.github.com/users/faymontage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faymontage/subscriptions","organizations_url":"https://api.github.com/users/faymontage/orgs","repos_url":"https://api.github.com/users/faymontage/repos","events_url":"https://api.github.com/users/faymontage/events{/privacy}","received_events_url":"https://api.github.com/users/faymontage/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985/commits","review_comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985/comments","review_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/985/comments","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/36b9febc6496a82aed06c62fd7307b72eab802ba","head":{"label":"toshiapp:coinbase-dapp","ref":"coinbase-dapp","sha":"36b9febc6496a82aed06c62fd7307b72eab802ba","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":75301435,"name":"toshi-android-client","full_name":"toshiapp/toshi-android-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-android-client","description":"Android client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-android-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-android-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-android-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-android-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-android-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-android-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-android-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-android-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-android-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-android-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-android-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-android-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-android-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-android-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/deployments","created_at":"2016-12-01T14:41:46Z","updated_at":"2018-04-11T06:17:13Z","pushed_at":"2018-04-11T07:00:54Z","git_url":"git://github.com/toshiapp/toshi-android-client.git","ssh_url":"git@github.com:toshiapp/toshi-android-client.git","clone_url":"https://github.com/toshiapp/toshi-android-client.git","svn_url":"https://github.com/toshiapp/toshi-android-client","homepage":"","size":9691,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":45,"open_issues":10,"watchers":99,"default_branch":"master"}},"base":{"label":"toshiapp:master","ref":"master","sha":"0f8961c54d0f85bbb2dcd0e9a666c047fcf6d027","user":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"repo":{"id":75301435,"name":"toshi-android-client","full_name":"toshiapp/toshi-android-client","owner":{"login":"toshiapp","id":18060234,"avatar_url":"https://avatars3.githubusercontent.com/u/18060234?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiapp","html_url":"https://github.com/toshiapp","followers_url":"https://api.github.com/users/toshiapp/followers","following_url":"https://api.github.com/users/toshiapp/following{/other_user}","gists_url":"https://api.github.com/users/toshiapp/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiapp/subscriptions","organizations_url":"https://api.github.com/users/toshiapp/orgs","repos_url":"https://api.github.com/users/toshiapp/repos","events_url":"https://api.github.com/users/toshiapp/events{/privacy}","received_events_url":"https://api.github.com/users/toshiapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toshiapp/toshi-android-client","description":"Android client for Toshi","fork":false,"url":"https://api.github.com/repos/toshiapp/toshi-android-client","forks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/forks","keys_url":"https://api.github.com/repos/toshiapp/toshi-android-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiapp/toshi-android-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiapp/toshi-android-client/teams","hooks_url":"https://api.github.com/repos/toshiapp/toshi-android-client/hooks","issue_events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/events{/number}","events_url":"https://api.github.com/repos/toshiapp/toshi-android-client/events","assignees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/assignees{/user}","branches_url":"https://api.github.com/repos/toshiapp/toshi-android-client/branches{/branch}","tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/tags","blobs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiapp/toshi-android-client/languages","stargazers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/stargazers","contributors_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contributors","subscribers_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscribers","subscription_url":"https://api.github.com/repos/toshiapp/toshi-android-client/subscription","commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiapp/toshi-android-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiapp/toshi-android-client/contents/{+path}","compare_url":"https://api.github.com/repos/toshiapp/toshi-android-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiapp/toshi-android-client/merges","archive_url":"https://api.github.com/repos/toshiapp/toshi-android-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiapp/toshi-android-client/downloads","issues_url":"https://api.github.com/repos/toshiapp/toshi-android-client/issues{/number}","pulls_url":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiapp/toshi-android-client/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiapp/toshi-android-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiapp/toshi-android-client/labels{/name}","releases_url":"https://api.github.com/repos/toshiapp/toshi-android-client/releases{/id}","deployments_url":"https://api.github.com/repos/toshiapp/toshi-android-client/deployments","created_at":"2016-12-01T14:41:46Z","updated_at":"2018-04-11T06:17:13Z","pushed_at":"2018-04-11T07:00:54Z","git_url":"git://github.com/toshiapp/toshi-android-client.git","ssh_url":"git@github.com:toshiapp/toshi-android-client.git","clone_url":"https://github.com/toshiapp/toshi-android-client.git","svn_url":"https://github.com/toshiapp/toshi-android-client","homepage":"","size":9691,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":45,"open_issues":10,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985"},"html":{"href":"https://github.com/toshiapp/toshi-android-client/pull/985"},"issue":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/985"},"comments":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/issues/985/comments"},"review_comments":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985/comments"},"review_comment":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/pulls/985/commits"},"statuses":{"href":"https://api.github.com/repos/toshiapp/toshi-android-client/statuses/36b9febc6496a82aed06c62fd7307b72eab802ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martintoften"}}