{"action":"created","comment":{"url":"https://api.github.com/repos/emersion/mako/pulls/comments/192162178","pull_request_review_id":124884278,"id":192162178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjE2MjE3OA==","diff_hunk":"@@ -18,6 +18,13 @@ enum mako_button_binding {\n \tMAKO_BUTTON_BINDING_INVOKE_DEFAULT_ACTION,\n };\n \n+enum mako_sort_criteria {\n+\tMAKO_SORT_CRITERIA_TIME = 1,\n+\tMAKO_SORT_CRITERIA_URGENCY = 2,\n+\tMAKO_SORT_ASC_TIME = 1,","path":"include/config.h","position":7,"original_position":7,"commit_id":"78bdf75de8ffceabad96d4004e11d64b8a8795ac","original_commit_id":"78bdf75de8ffceabad96d4004e11d64b8a8795ac","user":{"login":"emersion","id":506932,"node_id":"MDQ6VXNlcjUwNjkzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"body":"It's pretty weird to have multiple enum items with the same value. I think the last two can be removed.","created_at":"2018-05-31T16:37:36Z","updated_at":"2018-05-31T16:37:36Z","html_url":"https://github.com/emersion/mako/pull/40#discussion_r192162178","pull_request_url":"https://api.github.com/repos/emersion/mako/pulls/40","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/emersion/mako/pulls/comments/192162178"},"html":{"href":"https://github.com/emersion/mako/pull/40#discussion_r192162178"},"pull_request":{"href":"https://api.github.com/repos/emersion/mako/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/emersion/mako/pulls/40","id":190973952,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTczOTUy","html_url":"https://github.com/emersion/mako/pull/40","diff_url":"https://github.com/emersion/mako/pull/40.diff","patch_url":"https://github.com/emersion/mako/pull/40.patch","issue_url":"https://api.github.com/repos/emersion/mako/issues/40","number":40,"state":"open","locked":false,"title":"Added priority sort options ","user":{"login":"adrubesh","id":33096067,"node_id":"MDQ6VXNlcjMzMDk2MDY3","avatar_url":"https://avatars0.githubusercontent.com/u/33096067?v=4","gravatar_id":"","url":"https://api.github.com/users/adrubesh","html_url":"https://github.com/adrubesh","followers_url":"https://api.github.com/users/adrubesh/followers","following_url":"https://api.github.com/users/adrubesh/following{/other_user}","gists_url":"https://api.github.com/users/adrubesh/gists{/gist_id}","starred_url":"https://api.github.com/users/adrubesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrubesh/subscriptions","organizations_url":"https://api.github.com/users/adrubesh/orgs","repos_url":"https://api.github.com/users/adrubesh/repos","events_url":"https://api.github.com/users/adrubesh/events{/privacy}","received_events_url":"https://api.github.com/users/adrubesh/received_events","type":"User","site_admin":false},"body":"Test it out with: \r\n```\r\n./build/mako --max-visible 11 --sort +time --sort -priority\r\n```\r\n\r\nthen to test, you can run the following and see how they get inserted: \r\n```\r\n for i in {1..10}; do  \\\r\n  URGENCY=\"\";         \\\r\n  if [ $((i % 3)) -eq 0 ]; then \\\r\n    URGENCY=\"CRITICAL\"; \\\r\n  elif [ $((i % 2)) -eq 0 ]; then \\\r\n    URGENCY=\"NORMAL\";  \\\r\n  else \\\r\n    URGENCY=\"LOW\"; \\\r\n  fi; \\\r\n  eval \"notify-send -u $URGENCY -a \\\"test\\\" \\\"$URGENCY - $i\\\"\"; \\\r\n  sleep 0.5; \\\r\ndone\r\n```","created_at":"2018-05-28T17:35:27Z","updated_at":"2018-05-31T16:37:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f16c5b8d04ca00b69e8618ce20a9e22a0172ded6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emersion/mako/pulls/40/commits","review_comments_url":"https://api.github.com/repos/emersion/mako/pulls/40/comments","review_comment_url":"https://api.github.com/repos/emersion/mako/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emersion/mako/issues/40/comments","statuses_url":"https://api.github.com/repos/emersion/mako/statuses/78bdf75de8ffceabad96d4004e11d64b8a8795ac","head":{"label":"adrubesh:notification-priority-sort","ref":"notification-priority-sort","sha":"78bdf75de8ffceabad96d4004e11d64b8a8795ac","user":{"login":"adrubesh","id":33096067,"node_id":"MDQ6VXNlcjMzMDk2MDY3","avatar_url":"https://avatars0.githubusercontent.com/u/33096067?v=4","gravatar_id":"","url":"https://api.github.com/users/adrubesh","html_url":"https://github.com/adrubesh","followers_url":"https://api.github.com/users/adrubesh/followers","following_url":"https://api.github.com/users/adrubesh/following{/other_user}","gists_url":"https://api.github.com/users/adrubesh/gists{/gist_id}","starred_url":"https://api.github.com/users/adrubesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrubesh/subscriptions","organizations_url":"https://api.github.com/users/adrubesh/orgs","repos_url":"https://api.github.com/users/adrubesh/repos","events_url":"https://api.github.com/users/adrubesh/events{/privacy}","received_events_url":"https://api.github.com/users/adrubesh/received_events","type":"User","site_admin":false},"repo":{"id":133585794,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1ODU3OTQ=","name":"mako","full_name":"adrubesh/mako","owner":{"login":"adrubesh","id":33096067,"node_id":"MDQ6VXNlcjMzMDk2MDY3","avatar_url":"https://avatars0.githubusercontent.com/u/33096067?v=4","gravatar_id":"","url":"https://api.github.com/users/adrubesh","html_url":"https://github.com/adrubesh","followers_url":"https://api.github.com/users/adrubesh/followers","following_url":"https://api.github.com/users/adrubesh/following{/other_user}","gists_url":"https://api.github.com/users/adrubesh/gists{/gist_id}","starred_url":"https://api.github.com/users/adrubesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrubesh/subscriptions","organizations_url":"https://api.github.com/users/adrubesh/orgs","repos_url":"https://api.github.com/users/adrubesh/repos","events_url":"https://api.github.com/users/adrubesh/events{/privacy}","received_events_url":"https://api.github.com/users/adrubesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrubesh/mako","description":"A lightweight Wayland notification daemon","fork":true,"url":"https://api.github.com/repos/adrubesh/mako","forks_url":"https://api.github.com/repos/adrubesh/mako/forks","keys_url":"https://api.github.com/repos/adrubesh/mako/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrubesh/mako/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrubesh/mako/teams","hooks_url":"https://api.github.com/repos/adrubesh/mako/hooks","issue_events_url":"https://api.github.com/repos/adrubesh/mako/issues/events{/number}","events_url":"https://api.github.com/repos/adrubesh/mako/events","assignees_url":"https://api.github.com/repos/adrubesh/mako/assignees{/user}","branches_url":"https://api.github.com/repos/adrubesh/mako/branches{/branch}","tags_url":"https://api.github.com/repos/adrubesh/mako/tags","blobs_url":"https://api.github.com/repos/adrubesh/mako/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrubesh/mako/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrubesh/mako/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrubesh/mako/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrubesh/mako/statuses/{sha}","languages_url":"https://api.github.com/repos/adrubesh/mako/languages","stargazers_url":"https://api.github.com/repos/adrubesh/mako/stargazers","contributors_url":"https://api.github.com/repos/adrubesh/mako/contributors","subscribers_url":"https://api.github.com/repos/adrubesh/mako/subscribers","subscription_url":"https://api.github.com/repos/adrubesh/mako/subscription","commits_url":"https://api.github.com/repos/adrubesh/mako/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrubesh/mako/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrubesh/mako/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrubesh/mako/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrubesh/mako/contents/{+path}","compare_url":"https://api.github.com/repos/adrubesh/mako/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrubesh/mako/merges","archive_url":"https://api.github.com/repos/adrubesh/mako/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrubesh/mako/downloads","issues_url":"https://api.github.com/repos/adrubesh/mako/issues{/number}","pulls_url":"https://api.github.com/repos/adrubesh/mako/pulls{/number}","milestones_url":"https://api.github.com/repos/adrubesh/mako/milestones{/number}","notifications_url":"https://api.github.com/repos/adrubesh/mako/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrubesh/mako/labels{/name}","releases_url":"https://api.github.com/repos/adrubesh/mako/releases{/id}","deployments_url":"https://api.github.com/repos/adrubesh/mako/deployments","created_at":"2018-05-15T23:55:15Z","updated_at":"2018-05-31T12:24:05Z","pushed_at":"2018-05-31T12:24:01Z","git_url":"git://github.com/adrubesh/mako.git","ssh_url":"git@github.com:adrubesh/mako.git","clone_url":"https://github.com/adrubesh/mako.git","svn_url":"https://github.com/adrubesh/mako","homepage":"https://mako-project.org/","size":241,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emersion:master","ref":"master","sha":"6c0a8cb8d18821177af2ec5d2b469ad02ec71a03","user":{"login":"emersion","id":506932,"node_id":"MDQ6VXNlcjUwNjkzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"repo":{"id":130588871,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1ODg4NzE=","name":"mako","full_name":"emersion/mako","owner":{"login":"emersion","id":506932,"node_id":"MDQ6VXNlcjUwNjkzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/506932?v=4","gravatar_id":"","url":"https://api.github.com/users/emersion","html_url":"https://github.com/emersion","followers_url":"https://api.github.com/users/emersion/followers","following_url":"https://api.github.com/users/emersion/following{/other_user}","gists_url":"https://api.github.com/users/emersion/gists{/gist_id}","starred_url":"https://api.github.com/users/emersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emersion/subscriptions","organizations_url":"https://api.github.com/users/emersion/orgs","repos_url":"https://api.github.com/users/emersion/repos","events_url":"https://api.github.com/users/emersion/events{/privacy}","received_events_url":"https://api.github.com/users/emersion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emersion/mako","description":"A lightweight Wayland notification daemon","fork":false,"url":"https://api.github.com/repos/emersion/mako","forks_url":"https://api.github.com/repos/emersion/mako/forks","keys_url":"https://api.github.com/repos/emersion/mako/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emersion/mako/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emersion/mako/teams","hooks_url":"https://api.github.com/repos/emersion/mako/hooks","issue_events_url":"https://api.github.com/repos/emersion/mako/issues/events{/number}","events_url":"https://api.github.com/repos/emersion/mako/events","assignees_url":"https://api.github.com/repos/emersion/mako/assignees{/user}","branches_url":"https://api.github.com/repos/emersion/mako/branches{/branch}","tags_url":"https://api.github.com/repos/emersion/mako/tags","blobs_url":"https://api.github.com/repos/emersion/mako/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emersion/mako/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emersion/mako/git/refs{/sha}","trees_url":"https://api.github.com/repos/emersion/mako/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emersion/mako/statuses/{sha}","languages_url":"https://api.github.com/repos/emersion/mako/languages","stargazers_url":"https://api.github.com/repos/emersion/mako/stargazers","contributors_url":"https://api.github.com/repos/emersion/mako/contributors","subscribers_url":"https://api.github.com/repos/emersion/mako/subscribers","subscription_url":"https://api.github.com/repos/emersion/mako/subscription","commits_url":"https://api.github.com/repos/emersion/mako/commits{/sha}","git_commits_url":"https://api.github.com/repos/emersion/mako/git/commits{/sha}","comments_url":"https://api.github.com/repos/emersion/mako/comments{/number}","issue_comment_url":"https://api.github.com/repos/emersion/mako/issues/comments{/number}","contents_url":"https://api.github.com/repos/emersion/mako/contents/{+path}","compare_url":"https://api.github.com/repos/emersion/mako/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emersion/mako/merges","archive_url":"https://api.github.com/repos/emersion/mako/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emersion/mako/downloads","issues_url":"https://api.github.com/repos/emersion/mako/issues{/number}","pulls_url":"https://api.github.com/repos/emersion/mako/pulls{/number}","milestones_url":"https://api.github.com/repos/emersion/mako/milestones{/number}","notifications_url":"https://api.github.com/repos/emersion/mako/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emersion/mako/labels{/name}","releases_url":"https://api.github.com/repos/emersion/mako/releases{/id}","deployments_url":"https://api.github.com/repos/emersion/mako/deployments","created_at":"2018-04-22T17:05:22Z","updated_at":"2018-05-27T21:42:21Z","pushed_at":"2018-05-31T11:55:29Z","git_url":"git://github.com/emersion/mako.git","ssh_url":"git@github.com:emersion/mako.git","clone_url":"https://github.com/emersion/mako.git","svn_url":"https://github.com/emersion/mako","homepage":"https://mako-project.org/","size":229,"stargazers_count":45,"watchers_count":45,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":8,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emersion/mako/pulls/40"},"html":{"href":"https://github.com/emersion/mako/pull/40"},"issue":{"href":"https://api.github.com/repos/emersion/mako/issues/40"},"comments":{"href":"https://api.github.com/repos/emersion/mako/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/emersion/mako/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/emersion/mako/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emersion/mako/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/emersion/mako/statuses/78bdf75de8ffceabad96d4004e11d64b8a8795ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emersion"}}