{"action":"created","comment":{"url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments/241579138","pull_request_review_id":184891037,"id":241579138,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU3OTEzOA==","diff_hunk":"@@ -61,6 +61,14 @@ function init (cwd, state) {\n     windows.main.send('DC_EVENT_IMEX_PROGRESS', progress)\n   })\n \n+  dc.on('DC_EVENT_ERROR', (error) => {\n+    windows.main.send('error', error.toString())\n+  })\n+\n+  dc.on('DC_EVENT_NETWORK_ERROR', (error) => {\n+    windows.main.send('error', error.toString())\n+  })","path":"src/main/ipc.js","position":10,"original_position":10,"commit_id":"e66d17b0449d646ad2da43496d00b888a8ceb7dd","original_commit_id":"e66d17b0449d646ad2da43496d00b888a8ceb7dd","user":{"login":"ralphtheninja","id":308049,"node_id":"MDQ6VXNlcjMwODA0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/308049?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphtheninja","html_url":"https://github.com/ralphtheninja","followers_url":"https://api.github.com/users/ralphtheninja/followers","following_url":"https://api.github.com/users/ralphtheninja/following{/other_user}","gists_url":"https://api.github.com/users/ralphtheninja/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphtheninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphtheninja/subscriptions","organizations_url":"https://api.github.com/users/ralphtheninja/orgs","repos_url":"https://api.github.com/users/ralphtheninja/repos","events_url":"https://api.github.com/users/ralphtheninja/events{/privacy}","received_events_url":"https://api.github.com/users/ralphtheninja/received_events","type":"User","site_admin":false},"body":"We could merge these ones if the delta chat controller emitted the same event.","created_at":"2018-12-13T22:06:46Z","updated_at":"2018-12-13T22:06:47Z","html_url":"https://github.com/deltachat/deltachat-desktop/pull/438#discussion_r241579138","pull_request_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments/241579138"},"html":{"href":"https://github.com/deltachat/deltachat-desktop/pull/438#discussion_r241579138"},"pull_request":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438","id":238545052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTQ1MDUy","html_url":"https://github.com/deltachat/deltachat-desktop/pull/438","diff_url":"https://github.com/deltachat/deltachat-desktop/pull/438.diff","patch_url":"https://github.com/deltachat/deltachat-desktop/pull/438.patch","issue_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/438","number":438,"state":"open","locked":false,"title":"handle and show errors, including DC_EVENT_ERROR_NETWORK","user":{"login":"karissa","id":633012,"node_id":"MDQ6VXNlcjYzMzAxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/633012?v=4","gravatar_id":"","url":"https://api.github.com/users/karissa","html_url":"https://github.com/karissa","followers_url":"https://api.github.com/users/karissa/followers","following_url":"https://api.github.com/users/karissa/following{/other_user}","gists_url":"https://api.github.com/users/karissa/gists{/gist_id}","starred_url":"https://api.github.com/users/karissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karissa/subscriptions","organizations_url":"https://api.github.com/users/karissa/orgs","repos_url":"https://api.github.com/users/karissa/repos","events_url":"https://api.github.com/users/karissa/events{/privacy}","received_events_url":"https://api.github.com/users/karissa/received_events","type":"User","site_admin":false},"body":"this handles network errors and shows them raw (as we get them from core) in the user interface. Do we need to do any translation for this? @r10s \r\n\r\nfixes #302 ","created_at":"2018-12-13T21:55:22Z","updated_at":"2018-12-13T22:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20b5c56b02e4e00227d1191dbb47ba9269c60b62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"r10s","id":9800740,"node_id":"MDQ6VXNlcjk4MDA3NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800740?v=4","gravatar_id":"","url":"https://api.github.com/users/r10s","html_url":"https://github.com/r10s","followers_url":"https://api.github.com/users/r10s/followers","following_url":"https://api.github.com/users/r10s/following{/other_user}","gists_url":"https://api.github.com/users/r10s/gists{/gist_id}","starred_url":"https://api.github.com/users/r10s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r10s/subscriptions","organizations_url":"https://api.github.com/users/r10s/orgs","repos_url":"https://api.github.com/users/r10s/repos","events_url":"https://api.github.com/users/r10s/events{/privacy}","received_events_url":"https://api.github.com/users/r10s/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438/commits","review_comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438/comments","review_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/438/comments","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/e66d17b0449d646ad2da43496d00b888a8ceb7dd","head":{"label":"deltachat:handle-network-errors","ref":"handle-network-errors","sha":"e66d17b0449d646ad2da43496d00b888a8ceb7dd","user":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"repo":{"id":145452984,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NTI5ODQ=","name":"deltachat-desktop","full_name":"deltachat/deltachat-desktop","private":false,"owner":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deltachat/deltachat-desktop","description":"Desktop Application for https://delta.chat","fork":false,"url":"https://api.github.com/repos/deltachat/deltachat-desktop","forks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/forks","keys_url":"https://api.github.com/repos/deltachat/deltachat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deltachat/deltachat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deltachat/deltachat-desktop/teams","hooks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/hooks","issue_events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/events","assignees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/deltachat/deltachat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/tags","blobs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/deltachat/deltachat-desktop/languages","stargazers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/stargazers","contributors_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contributors","subscribers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscribers","subscription_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscription","commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/deltachat/deltachat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deltachat/deltachat-desktop/merges","archive_url":"https://api.github.com/repos/deltachat/deltachat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deltachat/deltachat-desktop/downloads","issues_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/deltachat/deltachat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/deltachat/deltachat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deltachat/deltachat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/deltachat/deltachat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/deployments","created_at":"2018-08-20T18:02:34Z","updated_at":"2018-12-13T20:41:54Z","pushed_at":"2018-12-13T21:55:23Z","git_url":"git://github.com/deltachat/deltachat-desktop.git","ssh_url":"git@github.com:deltachat/deltachat-desktop.git","clone_url":"https://github.com/deltachat/deltachat-desktop.git","svn_url":"https://github.com/deltachat/deltachat-desktop","homepage":"","size":2665,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":51,"watchers":47,"default_branch":"master"}},"base":{"label":"deltachat:master","ref":"master","sha":"114722a1b89b5f977994a3d0ef32870130f70353","user":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"repo":{"id":145452984,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NTI5ODQ=","name":"deltachat-desktop","full_name":"deltachat/deltachat-desktop","private":false,"owner":{"login":"deltachat","id":29453316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDUzMzE2","avatar_url":"https://avatars0.githubusercontent.com/u/29453316?v=4","gravatar_id":"","url":"https://api.github.com/users/deltachat","html_url":"https://github.com/deltachat","followers_url":"https://api.github.com/users/deltachat/followers","following_url":"https://api.github.com/users/deltachat/following{/other_user}","gists_url":"https://api.github.com/users/deltachat/gists{/gist_id}","starred_url":"https://api.github.com/users/deltachat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltachat/subscriptions","organizations_url":"https://api.github.com/users/deltachat/orgs","repos_url":"https://api.github.com/users/deltachat/repos","events_url":"https://api.github.com/users/deltachat/events{/privacy}","received_events_url":"https://api.github.com/users/deltachat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/deltachat/deltachat-desktop","description":"Desktop Application for https://delta.chat","fork":false,"url":"https://api.github.com/repos/deltachat/deltachat-desktop","forks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/forks","keys_url":"https://api.github.com/repos/deltachat/deltachat-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deltachat/deltachat-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deltachat/deltachat-desktop/teams","hooks_url":"https://api.github.com/repos/deltachat/deltachat-desktop/hooks","issue_events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/deltachat/deltachat-desktop/events","assignees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/deltachat/deltachat-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/tags","blobs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/deltachat/deltachat-desktop/languages","stargazers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/stargazers","contributors_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contributors","subscribers_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscribers","subscription_url":"https://api.github.com/repos/deltachat/deltachat-desktop/subscription","commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/deltachat/deltachat-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/deltachat/deltachat-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/deltachat/deltachat-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deltachat/deltachat-desktop/merges","archive_url":"https://api.github.com/repos/deltachat/deltachat-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deltachat/deltachat-desktop/downloads","issues_url":"https://api.github.com/repos/deltachat/deltachat-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/deltachat/deltachat-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/deltachat/deltachat-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deltachat/deltachat-desktop/labels{/name}","releases_url":"https://api.github.com/repos/deltachat/deltachat-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/deltachat/deltachat-desktop/deployments","created_at":"2018-08-20T18:02:34Z","updated_at":"2018-12-13T20:41:54Z","pushed_at":"2018-12-13T21:55:23Z","git_url":"git://github.com/deltachat/deltachat-desktop.git","ssh_url":"git@github.com:deltachat/deltachat-desktop.git","clone_url":"https://github.com/deltachat/deltachat-desktop.git","svn_url":"https://github.com/deltachat/deltachat-desktop","homepage":"","size":2665,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":51,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438"},"html":{"href":"https://github.com/deltachat/deltachat-desktop/pull/438"},"issue":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/438"},"comments":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/deltachat/deltachat-desktop/statuses/e66d17b0449d646ad2da43496d00b888a8ceb7dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ralphtheninja"}}