{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/comments/243447763","pull_request_review_id":187222535,"id":243447763,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ0Nzc2Mw==","diff_hunk":"@@ -1,33 +1,108 @@\n import React, { Component } from 'react';\n import PropTypes from 'prop-types';\n import axios from 'axios';\n-\n import './Board.css';\n import Card from './Card';\n import NewCardForm from './NewCardForm';\n-import CARD_DATA from '../data/card-data.json';\n+// import CARD_DATA from '../data/card-data.json';\n \n class Board extends Component {\n-  constructor() {\n-    super();\n+  constructor(props) {\n+    super(props);\n \n     this.state = {\n       cards: [],\n+      url: this.props.url,\n+      boardName: this.props.boardName,","path":"src/components/Board.js","position":20,"original_position":20,"commit_id":"c92e5bc13d64eeac9b387dffda22e033f7e94e3e","original_commit_id":"c92e5bc13d64eeac9b387dffda22e033f7e94e3e","user":{"login":"droberts-ada","id":21064499,"node_id":"MDQ6VXNlcjIxMDY0NDk5","avatar_url":"https://avatars1.githubusercontent.com/u/21064499?v=4","gravatar_id":"","url":"https://api.github.com/users/droberts-ada","html_url":"https://github.com/droberts-ada","followers_url":"https://api.github.com/users/droberts-ada/followers","following_url":"https://api.github.com/users/droberts-ada/following{/other_user}","gists_url":"https://api.github.com/users/droberts-ada/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts-ada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts-ada/subscriptions","organizations_url":"https://api.github.com/users/droberts-ada/orgs","repos_url":"https://api.github.com/users/droberts-ada/repos","events_url":"https://api.github.com/users/droberts-ada/events{/privacy}","received_events_url":"https://api.github.com/users/droberts-ada/received_events","type":"User","site_admin":false},"body":"You should only include things in `state` if they're going to change as your application runs. As far as I can tell `url` and `boardName` don't change, which means it would be clearer to leave them in `props`","created_at":"2018-12-20T23:16:16Z","updated_at":"2018-12-20T23:18:40Z","html_url":"https://github.com/Ada-C10/inspiration-board/pull/36#discussion_r243447763","pull_request_url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/comments/243447763"},"html":{"href":"https://github.com/Ada-C10/inspiration-board/pull/36#discussion_r243447763"},"pull_request":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36","id":239221701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjIxNzAx","html_url":"https://github.com/Ada-C10/inspiration-board/pull/36","diff_url":"https://github.com/Ada-C10/inspiration-board/pull/36.diff","patch_url":"https://github.com/Ada-C10/inspiration-board/pull/36.patch","issue_url":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/36","number":36,"state":"open","locked":false,"title":"Chantelle | Edges | Inspiration Board ","user":{"login":"BASIC-Belic","id":25443258,"node_id":"MDQ6VXNlcjI1NDQzMjU4","avatar_url":"https://avatars3.githubusercontent.com/u/25443258?v=4","gravatar_id":"","url":"https://api.github.com/users/BASIC-Belic","html_url":"https://github.com/BASIC-Belic","followers_url":"https://api.github.com/users/BASIC-Belic/followers","following_url":"https://api.github.com/users/BASIC-Belic/following{/other_user}","gists_url":"https://api.github.com/users/BASIC-Belic/gists{/gist_id}","starred_url":"https://api.github.com/users/BASIC-Belic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BASIC-Belic/subscriptions","organizations_url":"https://api.github.com/users/BASIC-Belic/orgs","repos_url":"https://api.github.com/users/BASIC-Belic/repos","events_url":"https://api.github.com/users/BASIC-Belic/events{/privacy}","received_events_url":"https://api.github.com/users/BASIC-Belic/received_events","type":"User","site_admin":false},"body":"# Inspiration Board\r\nCongratulations! You're submitting your assignment!\r\n\r\n## Comprehension Questions\r\nQuestion | Answer\r\n:------------- | :-------------\r\nExplain the steps in creating a new Card from the form. | I put state of the card attributes in newcard form, had a listener that would listen for a change in each of these attributes/fields. Once submitted, this would pass the current state into Board, using callback function passed in as a prop, and Board is responsible for speaking to card and passing on props from this obj it got from from. \r\nHow did you learn how to use the API? | A combo of postman, console.log to see data/response, and reading the docs. \r\nWhat function did you use to place the GET request from the API to get the list of cards?  Why use that function? |  We placed it in componentDidMount because Axios is asynchronous, and we want the data to render on after the component has successfully mounted. It also only gets called once (not on a re-render), so for our purposes, where we don't want the data to be constantly up to date (our App is the source of truth, not the API), we don't want this to change when different components are re-rendered. \r\nSnapshot tests? What are they good for? Absolutely... | They lock in the behavior and whatever you want your components to look like (after you're done changing them), so when someone else (or you) go back and change it, they can identify whether they want to keep or disregard those changes, whether the changes were intentional, or insights into how it might affect UI-- what changes might need to be made to prevent this. \r\nWhat purpose does Enzyme serve in testing a React app? | It allows us to mount and traverse the React virtual DOM tree. \r\n","created_at":"2018-12-17T17:16:02Z","updated_at":"2018-12-20T23:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/36/comments","statuses_url":"https://api.github.com/repos/Ada-C10/inspiration-board/statuses/c92e5bc13d64eeac9b387dffda22e033f7e94e3e","head":{"label":"BASIC-Belic:master","ref":"master","sha":"c92e5bc13d64eeac9b387dffda22e033f7e94e3e","user":{"login":"BASIC-Belic","id":25443258,"node_id":"MDQ6VXNlcjI1NDQzMjU4","avatar_url":"https://avatars3.githubusercontent.com/u/25443258?v=4","gravatar_id":"","url":"https://api.github.com/users/BASIC-Belic","html_url":"https://github.com/BASIC-Belic","followers_url":"https://api.github.com/users/BASIC-Belic/followers","following_url":"https://api.github.com/users/BASIC-Belic/following{/other_user}","gists_url":"https://api.github.com/users/BASIC-Belic/gists{/gist_id}","starred_url":"https://api.github.com/users/BASIC-Belic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BASIC-Belic/subscriptions","organizations_url":"https://api.github.com/users/BASIC-Belic/orgs","repos_url":"https://api.github.com/users/BASIC-Belic/repos","events_url":"https://api.github.com/users/BASIC-Belic/events{/privacy}","received_events_url":"https://api.github.com/users/BASIC-Belic/received_events","type":"User","site_admin":false},"repo":{"id":161677415,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2Nzc0MTU=","name":"inspiration-board","full_name":"BASIC-Belic/inspiration-board","private":false,"owner":{"login":"BASIC-Belic","id":25443258,"node_id":"MDQ6VXNlcjI1NDQzMjU4","avatar_url":"https://avatars3.githubusercontent.com/u/25443258?v=4","gravatar_id":"","url":"https://api.github.com/users/BASIC-Belic","html_url":"https://github.com/BASIC-Belic","followers_url":"https://api.github.com/users/BASIC-Belic/followers","following_url":"https://api.github.com/users/BASIC-Belic/following{/other_user}","gists_url":"https://api.github.com/users/BASIC-Belic/gists{/gist_id}","starred_url":"https://api.github.com/users/BASIC-Belic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BASIC-Belic/subscriptions","organizations_url":"https://api.github.com/users/BASIC-Belic/orgs","repos_url":"https://api.github.com/users/BASIC-Belic/repos","events_url":"https://api.github.com/users/BASIC-Belic/events{/privacy}","received_events_url":"https://api.github.com/users/BASIC-Belic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BASIC-Belic/inspiration-board","description":"A react project covering API calls using Axios, testing and controlled forms.","fork":true,"url":"https://api.github.com/repos/BASIC-Belic/inspiration-board","forks_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/forks","keys_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/teams","hooks_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/hooks","issue_events_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/issues/events{/number}","events_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/events","assignees_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/assignees{/user}","branches_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/branches{/branch}","tags_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/tags","blobs_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/git/refs{/sha}","trees_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/statuses/{sha}","languages_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/languages","stargazers_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/stargazers","contributors_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/contributors","subscribers_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/subscribers","subscription_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/subscription","commits_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/commits{/sha}","git_commits_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/git/commits{/sha}","comments_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/comments{/number}","issue_comment_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/issues/comments{/number}","contents_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/contents/{+path}","compare_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/merges","archive_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/downloads","issues_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/issues{/number}","pulls_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/pulls{/number}","milestones_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/milestones{/number}","notifications_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/labels{/name}","releases_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/releases{/id}","deployments_url":"https://api.github.com/repos/BASIC-Belic/inspiration-board/deployments","created_at":"2018-12-13T18:10:04Z","updated_at":"2018-12-17T15:23:34Z","pushed_at":"2018-12-17T15:23:33Z","git_url":"git://github.com/BASIC-Belic/inspiration-board.git","ssh_url":"git@github.com:BASIC-Belic/inspiration-board.git","clone_url":"https://github.com/BASIC-Belic/inspiration-board.git","svn_url":"https://github.com/BASIC-Belic/inspiration-board","homepage":null,"size":1073,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C10:master","ref":"master","sha":"9a20fc26a6cf3881c065ac23216fc04cc8129530","user":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"repo":{"id":161362867,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEzNjI4Njc=","name":"inspiration-board","full_name":"Ada-C10/inspiration-board","private":false,"owner":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ada-C10/inspiration-board","description":"A react project covering API calls using Axios, testing and controlled forms.","fork":true,"url":"https://api.github.com/repos/Ada-C10/inspiration-board","forks_url":"https://api.github.com/repos/Ada-C10/inspiration-board/forks","keys_url":"https://api.github.com/repos/Ada-C10/inspiration-board/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C10/inspiration-board/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C10/inspiration-board/teams","hooks_url":"https://api.github.com/repos/Ada-C10/inspiration-board/hooks","issue_events_url":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C10/inspiration-board/events","assignees_url":"https://api.github.com/repos/Ada-C10/inspiration-board/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C10/inspiration-board/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C10/inspiration-board/tags","blobs_url":"https://api.github.com/repos/Ada-C10/inspiration-board/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C10/inspiration-board/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C10/inspiration-board/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C10/inspiration-board/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C10/inspiration-board/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C10/inspiration-board/languages","stargazers_url":"https://api.github.com/repos/Ada-C10/inspiration-board/stargazers","contributors_url":"https://api.github.com/repos/Ada-C10/inspiration-board/contributors","subscribers_url":"https://api.github.com/repos/Ada-C10/inspiration-board/subscribers","subscription_url":"https://api.github.com/repos/Ada-C10/inspiration-board/subscription","commits_url":"https://api.github.com/repos/Ada-C10/inspiration-board/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C10/inspiration-board/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C10/inspiration-board/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C10/inspiration-board/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C10/inspiration-board/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C10/inspiration-board/merges","archive_url":"https://api.github.com/repos/Ada-C10/inspiration-board/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C10/inspiration-board/downloads","issues_url":"https://api.github.com/repos/Ada-C10/inspiration-board/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C10/inspiration-board/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C10/inspiration-board/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C10/inspiration-board/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C10/inspiration-board/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C10/inspiration-board/deployments","created_at":"2018-12-11T16:31:08Z","updated_at":"2018-12-13T18:32:55Z","pushed_at":"2018-12-20T18:34:56Z","git_url":"git://github.com/Ada-C10/inspiration-board.git","ssh_url":"git@github.com:Ada-C10/inspiration-board.git","clone_url":"https://github.com/Ada-C10/inspiration-board.git","svn_url":"https://github.com/Ada-C10/inspiration-board","homepage":null,"size":1303,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":43,"license":null,"forks":46,"open_issues":43,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36"},"html":{"href":"https://github.com/Ada-C10/inspiration-board/pull/36"},"issue":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/36"},"comments":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C10/inspiration-board/statuses/c92e5bc13d64eeac9b387dffda22e033f7e94e3e"}},"author_association":"NONE"}}
{"actor":{"display_login":"droberts-ada"}}