{"action":"created","issue":{"url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/9","repository_url":"https://api.github.com/repos/atomist/sdm-smoke-test","labels_url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/9/comments","events_url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/9/events","html_url":"https://github.com/atomist/sdm-smoke-test/issues/9","id":327090838,"number":9,"title":"fix new repo topic creation and reenable topic asserts","user":{"login":"claymccoy","id":2743,"avatar_url":"https://avatars0.githubusercontent.com/u/2743?v=4","gravatar_id":"","url":"https://api.github.com/users/claymccoy","html_url":"https://github.com/claymccoy","followers_url":"https://api.github.com/users/claymccoy/followers","following_url":"https://api.github.com/users/claymccoy/following{/other_user}","gists_url":"https://api.github.com/users/claymccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/claymccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claymccoy/subscriptions","organizations_url":"https://api.github.com/users/claymccoy/orgs","repos_url":"https://api.github.com/users/claymccoy/repos","events_url":"https://api.github.com/users/claymccoy/events{/privacy}","received_events_url":"https://api.github.com/users/claymccoy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-28T18:09:58Z","updated_at":"2018-05-28T18:18:13Z","closed_at":null,"author_association":"CONTRIBUTOR","body":""},"comment":{"url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/comments/392581719","html_url":"https://github.com/atomist/sdm-smoke-test/issues/9#issuecomment-392581719","issue_url":"https://api.github.com/repos/atomist/sdm-smoke-test/issues/9","id":392581719,"user":{"login":"claymccoy","id":2743,"avatar_url":"https://avatars0.githubusercontent.com/u/2743?v=4","gravatar_id":"","url":"https://api.github.com/users/claymccoy","html_url":"https://github.com/claymccoy","followers_url":"https://api.github.com/users/claymccoy/followers","following_url":"https://api.github.com/users/claymccoy/following{/other_user}","gists_url":"https://api.github.com/users/claymccoy/gists{/gist_id}","starred_url":"https://api.github.com/users/claymccoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claymccoy/subscriptions","organizations_url":"https://api.github.com/users/claymccoy/orgs","repos_url":"https://api.github.com/users/claymccoy/repos","events_url":"https://api.github.com/users/claymccoy/events{/privacy}","received_events_url":"https://api.github.com/users/claymccoy/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T18:18:13Z","updated_at":"2018-05-28T18:18:13Z","author_association":"CONTRIBUTOR","body":"The problem is that OnFirstPushToRepo fires after the new repo is created, and it has actions to add the topics to the new repos, but there is no \"screenName\" in the event.\r\nhttps://github.com/atomist/sdm/blob/2dc5ef52b627f477258a777fbcb9db671d60daf5/src/handlers/events/repo/OnFirstPushToRepo.ts#L53\r\n```\r\n \"after\": {\r\n          \"committer\": {\r\n            \"login\": \"atomist-bot\",\r\n            \"person\": null\r\n          },\r\n```\r\nSo the handler just warns that it can't find the screen name and returns success. I'll investigate why there is no person data for the event, but requiring a screen name in order to invoke actions like adding topics seems error prone. I am missing some intent here, but perhaps this should be divided into two types of actions, ones that require screennames, and channels, and ones that don't that will get executed anyway. Or perhaps we just send empty addressChannels and let the actions do whatever they can."}}
{"actor":{"display_login":"claymccoy"}}