{"action":"created","comment":{"url":"https://api.github.com/repos/scality/backbeat/pulls/comments/206699786","pull_request_review_id":142165365,"id":206699786,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY5OTc4Ng==","diff_hunk":"@@ -478,6 +488,13 @@ class LifecycleTask extends BackbeatTask {\n             }\n             return store;\n         }, {});\n+        // if EODM was not explicitly set and current account is LC account\n+        // enable EODM rule by default\n+        if (isLCUser && filteredRules.Expiration &&\n+        filteredRules.Expiration.ExpiredObjectDeleteMarker !== false) {","path":"extensions/lifecycle/tasks/LifecycleTask.js","position":57,"original_position":57,"commit_id":"0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9","original_commit_id":"0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9","user":{"login":"philipyoo","id":11511641,"node_id":"MDQ6VXNlcjExNTExNjQx","avatar_url":"https://avatars2.githubusercontent.com/u/11511641?v=4","gravatar_id":"","url":"https://api.github.com/users/philipyoo","html_url":"https://github.com/philipyoo","followers_url":"https://api.github.com/users/philipyoo/followers","following_url":"https://api.github.com/users/philipyoo/following{/other_user}","gists_url":"https://api.github.com/users/philipyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/philipyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipyoo/subscriptions","organizations_url":"https://api.github.com/users/philipyoo/orgs","repos_url":"https://api.github.com/users/philipyoo/repos","events_url":"https://api.github.com/users/philipyoo/events{/privacy}","received_events_url":"https://api.github.com/users/philipyoo/received_events","type":"User","site_admin":false},"body":"I'll look into refactoring this. I think it'll be an easy refactor, but will not go into this release, but probably the next.\r\nAll relevant data is available in the function that sends the expiration object entries. But will need to edit the logic in the function that handles eodm versions","created_at":"2018-07-31T22:10:12Z","updated_at":"2018-07-31T22:10:12Z","html_url":"https://github.com/scality/backbeat/pull/398#discussion_r206699786","pull_request_url":"https://api.github.com/repos/scality/backbeat/pulls/398","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scality/backbeat/pulls/comments/206699786"},"html":{"href":"https://github.com/scality/backbeat/pull/398#discussion_r206699786"},"pull_request":{"href":"https://api.github.com/repos/scality/backbeat/pulls/398"}},"in_reply_to_id":206641685},"pull_request":{"url":"https://api.github.com/repos/scality/backbeat/pulls/398","id":205021107,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDIxMTA3","html_url":"https://github.com/scality/backbeat/pull/398","diff_url":"https://github.com/scality/backbeat/pull/398.diff","patch_url":"https://github.com/scality/backbeat/pull/398.patch","issue_url":"https://api.github.com/repos/scality/backbeat/issues/398","number":398,"state":"closed","locked":false,"title":"bf: ZENKO-644 auto apply EODM for lifecycle service account","user":{"login":"philipyoo","id":11511641,"node_id":"MDQ6VXNlcjExNTExNjQx","avatar_url":"https://avatars2.githubusercontent.com/u/11511641?v=4","gravatar_id":"","url":"https://api.github.com/users/philipyoo","html_url":"https://github.com/philipyoo","followers_url":"https://api.github.com/users/philipyoo/followers","following_url":"https://api.github.com/users/philipyoo/following{/other_user}","gists_url":"https://api.github.com/users/philipyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/philipyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipyoo/subscriptions","organizations_url":"https://api.github.com/users/philipyoo/orgs","repos_url":"https://api.github.com/users/philipyoo/repos","events_url":"https://api.github.com/users/philipyoo/events{/privacy}","received_events_url":"https://api.github.com/users/philipyoo/received_events","type":"User","site_admin":false},"body":"When a valid Expiration rule exists and the current owner\r\nis the lifecycle service account, automatically consider\r\nthe ExpiredObjectDeleteMarker rule if it hasn't already\r\nbeen explicitly declared from another lifecycle rule.","created_at":"2018-07-31T07:34:05Z","updated_at":"2018-07-31T22:10:12Z","closed_at":"2018-07-31T21:18:00Z","merged_at":"2018-07-31T21:18:00Z","merge_commit_sha":"0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/backbeat/pulls/398/commits","review_comments_url":"https://api.github.com/repos/scality/backbeat/pulls/398/comments","review_comment_url":"https://api.github.com/repos/scality/backbeat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/backbeat/issues/398/comments","statuses_url":"https://api.github.com/repos/scality/backbeat/statuses/0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9","head":{"label":"scality:bugfix/ZENKO-644-autoApplyEODM","ref":"bugfix/ZENKO-644-autoApplyEODM","sha":"0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":81391071,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM5MTA3MQ==","name":"backbeat","full_name":"scality/backbeat","owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/backbeat","description":"Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.","fork":false,"url":"https://api.github.com/repos/scality/backbeat","forks_url":"https://api.github.com/repos/scality/backbeat/forks","keys_url":"https://api.github.com/repos/scality/backbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/backbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/backbeat/teams","hooks_url":"https://api.github.com/repos/scality/backbeat/hooks","issue_events_url":"https://api.github.com/repos/scality/backbeat/issues/events{/number}","events_url":"https://api.github.com/repos/scality/backbeat/events","assignees_url":"https://api.github.com/repos/scality/backbeat/assignees{/user}","branches_url":"https://api.github.com/repos/scality/backbeat/branches{/branch}","tags_url":"https://api.github.com/repos/scality/backbeat/tags","blobs_url":"https://api.github.com/repos/scality/backbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/backbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/backbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/backbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/backbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/backbeat/languages","stargazers_url":"https://api.github.com/repos/scality/backbeat/stargazers","contributors_url":"https://api.github.com/repos/scality/backbeat/contributors","subscribers_url":"https://api.github.com/repos/scality/backbeat/subscribers","subscription_url":"https://api.github.com/repos/scality/backbeat/subscription","commits_url":"https://api.github.com/repos/scality/backbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/backbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/backbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/backbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/backbeat/contents/{+path}","compare_url":"https://api.github.com/repos/scality/backbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/backbeat/merges","archive_url":"https://api.github.com/repos/scality/backbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/backbeat/downloads","issues_url":"https://api.github.com/repos/scality/backbeat/issues{/number}","pulls_url":"https://api.github.com/repos/scality/backbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/backbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/backbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/backbeat/labels{/name}","releases_url":"https://api.github.com/repos/scality/backbeat/releases{/id}","deployments_url":"https://api.github.com/repos/scality/backbeat/deployments","created_at":"2017-02-09T00:31:22Z","updated_at":"2018-07-31T21:18:02Z","pushed_at":"2018-07-31T21:31:25Z","git_url":"git://github.com/scality/backbeat.git","ssh_url":"git@github.com:scality/backbeat.git","clone_url":"https://github.com/scality/backbeat.git","svn_url":"https://github.com/scality/backbeat","homepage":"https://www.zenko.io","size":2724,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":15,"watchers":17,"default_branch":"development/8.0"}},"base":{"label":"scality:development/8.0","ref":"development/8.0","sha":"da44b1b512b2ac76cac217f611cee25a58832e99","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":81391071,"node_id":"MDEwOlJlcG9zaXRvcnk4MTM5MTA3MQ==","name":"backbeat","full_name":"scality/backbeat","owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/backbeat","description":"Zenko Backbeat is the core engine for asynchronous replication, optimized for queuing metadata updates and dispatching work to long-running tasks in the background.","fork":false,"url":"https://api.github.com/repos/scality/backbeat","forks_url":"https://api.github.com/repos/scality/backbeat/forks","keys_url":"https://api.github.com/repos/scality/backbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/backbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/backbeat/teams","hooks_url":"https://api.github.com/repos/scality/backbeat/hooks","issue_events_url":"https://api.github.com/repos/scality/backbeat/issues/events{/number}","events_url":"https://api.github.com/repos/scality/backbeat/events","assignees_url":"https://api.github.com/repos/scality/backbeat/assignees{/user}","branches_url":"https://api.github.com/repos/scality/backbeat/branches{/branch}","tags_url":"https://api.github.com/repos/scality/backbeat/tags","blobs_url":"https://api.github.com/repos/scality/backbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/backbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/backbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/backbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/backbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/backbeat/languages","stargazers_url":"https://api.github.com/repos/scality/backbeat/stargazers","contributors_url":"https://api.github.com/repos/scality/backbeat/contributors","subscribers_url":"https://api.github.com/repos/scality/backbeat/subscribers","subscription_url":"https://api.github.com/repos/scality/backbeat/subscription","commits_url":"https://api.github.com/repos/scality/backbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/backbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/backbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/backbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/backbeat/contents/{+path}","compare_url":"https://api.github.com/repos/scality/backbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/backbeat/merges","archive_url":"https://api.github.com/repos/scality/backbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/backbeat/downloads","issues_url":"https://api.github.com/repos/scality/backbeat/issues{/number}","pulls_url":"https://api.github.com/repos/scality/backbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/backbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/backbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/backbeat/labels{/name}","releases_url":"https://api.github.com/repos/scality/backbeat/releases{/id}","deployments_url":"https://api.github.com/repos/scality/backbeat/deployments","created_at":"2017-02-09T00:31:22Z","updated_at":"2018-07-31T21:18:02Z","pushed_at":"2018-07-31T21:31:25Z","git_url":"git://github.com/scality/backbeat.git","ssh_url":"git@github.com:scality/backbeat.git","clone_url":"https://github.com/scality/backbeat.git","svn_url":"https://github.com/scality/backbeat","homepage":"https://www.zenko.io","size":2724,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":15,"watchers":17,"default_branch":"development/8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/backbeat/pulls/398"},"html":{"href":"https://github.com/scality/backbeat/pull/398"},"issue":{"href":"https://api.github.com/repos/scality/backbeat/issues/398"},"comments":{"href":"https://api.github.com/repos/scality/backbeat/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/backbeat/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/backbeat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/backbeat/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/scality/backbeat/statuses/0b5e0b5c827ffc112749b2c685a2eeebda1bc1d9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"philipyoo"}}