{"action":"opened","number":666,"pull_request":{"url":"https://api.github.com/repos/openfaas/faas/pulls/666","id":183915094,"html_url":"https://github.com/openfaas/faas/pull/666","diff_url":"https://github.com/openfaas/faas/pull/666.diff","patch_url":"https://github.com/openfaas/faas/pull/666.patch","issue_url":"https://api.github.com/repos/openfaas/faas/issues/666","number":666,"state":"open","locked":false,"title":"UI: add a blankslate component with more information - updated","user":{"login":"ovation22","id":7606265,"avatar_url":"https://avatars0.githubusercontent.com/u/7606265?v=4","gravatar_id":"","url":"https://api.github.com/users/ovation22","html_url":"https://github.com/ovation22","followers_url":"https://api.github.com/users/ovation22/followers","following_url":"https://api.github.com/users/ovation22/following{/other_user}","gists_url":"https://api.github.com/users/ovation22/gists{/gist_id}","starred_url":"https://api.github.com/users/ovation22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovation22/subscriptions","organizations_url":"https://api.github.com/users/ovation22/orgs","repos_url":"https://api.github.com/users/ovation22/repos","events_url":"https://api.github.com/users/ovation22/events{/privacy}","received_events_url":"https://api.github.com/users/ovation22/received_events","type":"User","site_admin":false},"body":"Completing the work started by @jrevillas to provide a blankslate UI landing page when no functions are available or selected.\r\n\r\n## Description\r\nThis is presented as a set of fixes and improvements to the UI.\r\n\r\n- [x] Display a blankslate component when there are no functions in the cluster.\r\n- [x] Display a blankslate component when no function is selected.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nThis is completion of the work that was started by @jrevillas in PR #512 \r\n- [ ] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nThese changes have been tested following instructions from contrib/HACK.md using play-with-docker. I have tested with empty state, non-selected functions, zero functions, removing functions, etc. Blankslate hugs the top of the screen and side-nav has a min height of 100vh (viewport height).\r\n\r\n- [x] Tested in IE 11\r\n- [x] Tested in Edge\r\n- [x] Tested in Brave\r\n- [x] Tested in Chrome\r\n- [x] Tested in Firefox\r\n- [ ] Tested in Safari\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2018-04-25T03:12:13Z","updated_at":"2018-04-25T03:12:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfaas/faas/pulls/666/commits","review_comments_url":"https://api.github.com/repos/openfaas/faas/pulls/666/comments","review_comment_url":"https://api.github.com/repos/openfaas/faas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfaas/faas/issues/666/comments","statuses_url":"https://api.github.com/repos/openfaas/faas/statuses/994bcbfc0e82cf1a27ab1257fca0b04243810549","head":{"label":"ovation22:blankslate","ref":"blankslate","sha":"994bcbfc0e82cf1a27ab1257fca0b04243810549","user":{"login":"ovation22","id":7606265,"avatar_url":"https://avatars0.githubusercontent.com/u/7606265?v=4","gravatar_id":"","url":"https://api.github.com/users/ovation22","html_url":"https://github.com/ovation22","followers_url":"https://api.github.com/users/ovation22/followers","following_url":"https://api.github.com/users/ovation22/following{/other_user}","gists_url":"https://api.github.com/users/ovation22/gists{/gist_id}","starred_url":"https://api.github.com/users/ovation22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovation22/subscriptions","organizations_url":"https://api.github.com/users/ovation22/orgs","repos_url":"https://api.github.com/users/ovation22/repos","events_url":"https://api.github.com/users/ovation22/events{/privacy}","received_events_url":"https://api.github.com/users/ovation22/received_events","type":"User","site_admin":false},"repo":{"id":130925959,"name":"faas","full_name":"ovation22/faas","owner":{"login":"ovation22","id":7606265,"avatar_url":"https://avatars0.githubusercontent.com/u/7606265?v=4","gravatar_id":"","url":"https://api.github.com/users/ovation22","html_url":"https://github.com/ovation22","followers_url":"https://api.github.com/users/ovation22/followers","following_url":"https://api.github.com/users/ovation22/following{/other_user}","gists_url":"https://api.github.com/users/ovation22/gists{/gist_id}","starred_url":"https://api.github.com/users/ovation22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovation22/subscriptions","organizations_url":"https://api.github.com/users/ovation22/orgs","repos_url":"https://api.github.com/users/ovation22/repos","events_url":"https://api.github.com/users/ovation22/events{/privacy}","received_events_url":"https://api.github.com/users/ovation22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ovation22/faas","description":"OpenFaaS - Serverless Functions Made Simple for Docker & Kubernetes","fork":true,"url":"https://api.github.com/repos/ovation22/faas","forks_url":"https://api.github.com/repos/ovation22/faas/forks","keys_url":"https://api.github.com/repos/ovation22/faas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovation22/faas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovation22/faas/teams","hooks_url":"https://api.github.com/repos/ovation22/faas/hooks","issue_events_url":"https://api.github.com/repos/ovation22/faas/issues/events{/number}","events_url":"https://api.github.com/repos/ovation22/faas/events","assignees_url":"https://api.github.com/repos/ovation22/faas/assignees{/user}","branches_url":"https://api.github.com/repos/ovation22/faas/branches{/branch}","tags_url":"https://api.github.com/repos/ovation22/faas/tags","blobs_url":"https://api.github.com/repos/ovation22/faas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovation22/faas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovation22/faas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovation22/faas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovation22/faas/statuses/{sha}","languages_url":"https://api.github.com/repos/ovation22/faas/languages","stargazers_url":"https://api.github.com/repos/ovation22/faas/stargazers","contributors_url":"https://api.github.com/repos/ovation22/faas/contributors","subscribers_url":"https://api.github.com/repos/ovation22/faas/subscribers","subscription_url":"https://api.github.com/repos/ovation22/faas/subscription","commits_url":"https://api.github.com/repos/ovation22/faas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovation22/faas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovation22/faas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovation22/faas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovation22/faas/contents/{+path}","compare_url":"https://api.github.com/repos/ovation22/faas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovation22/faas/merges","archive_url":"https://api.github.com/repos/ovation22/faas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovation22/faas/downloads","issues_url":"https://api.github.com/repos/ovation22/faas/issues{/number}","pulls_url":"https://api.github.com/repos/ovation22/faas/pulls{/number}","milestones_url":"https://api.github.com/repos/ovation22/faas/milestones{/number}","notifications_url":"https://api.github.com/repos/ovation22/faas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovation22/faas/labels{/name}","releases_url":"https://api.github.com/repos/ovation22/faas/releases{/id}","deployments_url":"https://api.github.com/repos/ovation22/faas/deployments","created_at":"2018-04-24T23:46:44Z","updated_at":"2018-04-24T23:46:47Z","pushed_at":"2018-04-25T02:52:12Z","git_url":"git://github.com/ovation22/faas.git","ssh_url":"git@github.com:ovation22/faas.git","clone_url":"https://github.com/ovation22/faas.git","svn_url":"https://github.com/ovation22/faas","homepage":"https://blog.alexellis.io/introducing-functions-as-a-service/","size":22036,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfaas:master","ref":"master","sha":"bfe239de4d1a01cc309de9fecc732d7678b950ed","user":{"login":"openfaas","id":27013154,"avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"repo":{"id":77144337,"name":"faas","full_name":"openfaas/faas","owner":{"login":"openfaas","id":27013154,"avatar_url":"https://avatars3.githubusercontent.com/u/27013154?v=4","gravatar_id":"","url":"https://api.github.com/users/openfaas","html_url":"https://github.com/openfaas","followers_url":"https://api.github.com/users/openfaas/followers","following_url":"https://api.github.com/users/openfaas/following{/other_user}","gists_url":"https://api.github.com/users/openfaas/gists{/gist_id}","starred_url":"https://api.github.com/users/openfaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfaas/subscriptions","organizations_url":"https://api.github.com/users/openfaas/orgs","repos_url":"https://api.github.com/users/openfaas/repos","events_url":"https://api.github.com/users/openfaas/events{/privacy}","received_events_url":"https://api.github.com/users/openfaas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openfaas/faas","description":"OpenFaaS - Serverless Functions Made Simple for Docker & Kubernetes","fork":false,"url":"https://api.github.com/repos/openfaas/faas","forks_url":"https://api.github.com/repos/openfaas/faas/forks","keys_url":"https://api.github.com/repos/openfaas/faas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfaas/faas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfaas/faas/teams","hooks_url":"https://api.github.com/repos/openfaas/faas/hooks","issue_events_url":"https://api.github.com/repos/openfaas/faas/issues/events{/number}","events_url":"https://api.github.com/repos/openfaas/faas/events","assignees_url":"https://api.github.com/repos/openfaas/faas/assignees{/user}","branches_url":"https://api.github.com/repos/openfaas/faas/branches{/branch}","tags_url":"https://api.github.com/repos/openfaas/faas/tags","blobs_url":"https://api.github.com/repos/openfaas/faas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfaas/faas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfaas/faas/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfaas/faas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfaas/faas/statuses/{sha}","languages_url":"https://api.github.com/repos/openfaas/faas/languages","stargazers_url":"https://api.github.com/repos/openfaas/faas/stargazers","contributors_url":"https://api.github.com/repos/openfaas/faas/contributors","subscribers_url":"https://api.github.com/repos/openfaas/faas/subscribers","subscription_url":"https://api.github.com/repos/openfaas/faas/subscription","commits_url":"https://api.github.com/repos/openfaas/faas/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfaas/faas/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfaas/faas/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfaas/faas/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfaas/faas/contents/{+path}","compare_url":"https://api.github.com/repos/openfaas/faas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfaas/faas/merges","archive_url":"https://api.github.com/repos/openfaas/faas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfaas/faas/downloads","issues_url":"https://api.github.com/repos/openfaas/faas/issues{/number}","pulls_url":"https://api.github.com/repos/openfaas/faas/pulls{/number}","milestones_url":"https://api.github.com/repos/openfaas/faas/milestones{/number}","notifications_url":"https://api.github.com/repos/openfaas/faas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfaas/faas/labels{/name}","releases_url":"https://api.github.com/repos/openfaas/faas/releases{/id}","deployments_url":"https://api.github.com/repos/openfaas/faas/deployments","created_at":"2016-12-22T12:51:39Z","updated_at":"2018-04-25T02:35:23Z","pushed_at":"2018-04-25T01:58:11Z","git_url":"git://github.com/openfaas/faas.git","ssh_url":"git@github.com:openfaas/faas.git","clone_url":"https://github.com/openfaas/faas.git","svn_url":"https://github.com/openfaas/faas","homepage":"https://blog.alexellis.io/introducing-functions-as-a-service/","size":22013,"stargazers_count":9842,"watchers_count":9842,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":678,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":678,"open_issues":93,"watchers":9842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfaas/faas/pulls/666"},"html":{"href":"https://github.com/openfaas/faas/pull/666"},"issue":{"href":"https://api.github.com/repos/openfaas/faas/issues/666"},"comments":{"href":"https://api.github.com/repos/openfaas/faas/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/openfaas/faas/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/openfaas/faas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfaas/faas/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/openfaas/faas/statuses/994bcbfc0e82cf1a27ab1257fca0b04243810549"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":11,"additions":44,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"ovation22"}}