{"action":"opened","number":664,"pull_request":{"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664","id":195963502,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTYzNTAy","html_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/664","diff_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/664.diff","patch_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/664.patch","issue_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/664","number":664,"state":"open","locked":false,"title":"Array support","user":{"login":"RFSH","id":2129750,"node_id":"MDQ6VXNlcjIxMjk3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2129750?v=4","gravatar_id":"","url":"https://api.github.com/users/RFSH","html_url":"https://github.com/RFSH","followers_url":"https://api.github.com/users/RFSH/followers","following_url":"https://api.github.com/users/RFSH/following{/other_user}","gists_url":"https://api.github.com/users/RFSH/gists{/gist_id}","starred_url":"https://api.github.com/users/RFSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RFSH/subscriptions","organizations_url":"https://api.github.com/users/RFSH/orgs","repos_url":"https://api.github.com/users/RFSH/repos","events_url":"https://api.github.com/users/RFSH/events{/privacy}","received_events_url":"https://api.github.com/users/RFSH/received_events","type":"User","site_admin":false},"body":"With this change, we can support presentation of array column types. This only includes primitive types (number, date types, and text). It does not include `json`, or `markdown` or any other custom domain types.\r\n\r\nThe following are a summary of changes in this PR:\r\n\r\n- Made sure facet is ignoring column array types (we're not supporting faceting for arrays).\r\n\r\n- Changed the `formatvalue` implementation to support arrays. This function in case of arrays, will return an array of formatted values. I had to do this, because we wanted to change the value of `null` to `*No Value*` and `\"\"` (empty string) to `*Empty*`. `formatvalue` has no notion of markdown. It's the caller's responsibility to go over the returned values and process markdown appropriately.\r\n\r\n- Changed `formatPresentation` function to accept the raw values of table instead of formatted value of the column.\r\n\r\n**Currently I am adding more comments to the implementation of `values` to explain how exactly these formatPresentation and formatvalue are used together. I think having them in code is better than here**\r\n\r\nIssue: #629","created_at":"2018-06-19T21:29:19Z","updated_at":"2018-06-19T21:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"RFSH","id":2129750,"node_id":"MDQ6VXNlcjIxMjk3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2129750?v=4","gravatar_id":"","url":"https://api.github.com/users/RFSH","html_url":"https://github.com/RFSH","followers_url":"https://api.github.com/users/RFSH/followers","following_url":"https://api.github.com/users/RFSH/following{/other_user}","gists_url":"https://api.github.com/users/RFSH/gists{/gist_id}","starred_url":"https://api.github.com/users/RFSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RFSH/subscriptions","organizations_url":"https://api.github.com/users/RFSH/orgs","repos_url":"https://api.github.com/users/RFSH/repos","events_url":"https://api.github.com/users/RFSH/events{/privacy}","received_events_url":"https://api.github.com/users/RFSH/received_events","type":"User","site_admin":false},"assignees":[{"login":"RFSH","id":2129750,"node_id":"MDQ6VXNlcjIxMjk3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2129750?v=4","gravatar_id":"","url":"https://api.github.com/users/RFSH","html_url":"https://github.com/RFSH","followers_url":"https://api.github.com/users/RFSH/followers","following_url":"https://api.github.com/users/RFSH/following{/other_user}","gists_url":"https://api.github.com/users/RFSH/gists{/gist_id}","starred_url":"https://api.github.com/users/RFSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RFSH/subscriptions","organizations_url":"https://api.github.com/users/RFSH/orgs","repos_url":"https://api.github.com/users/RFSH/repos","events_url":"https://api.github.com/users/RFSH/events{/privacy}","received_events_url":"https://api.github.com/users/RFSH/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":242020707,"node_id":"MDU6TGFiZWwyNDIwMjA3MDc=","url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664/commits","review_comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664/comments","review_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/664/comments","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/40a077a9902960c3cbd6214218f627d06224fb65","head":{"label":"informatics-isi-edu:array-support","ref":"array-support","sha":"40a077a9902960c3cbd6214218f627d06224fb65","user":{"login":"informatics-isi-edu","id":9324294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9324294?v=4","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":39903075,"node_id":"MDEwOlJlcG9zaXRvcnkzOTkwMzA3NQ==","name":"ermrestjs","full_name":"informatics-isi-edu/ermrestjs","owner":{"login":"informatics-isi-edu","id":9324294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9324294?v=4","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/informatics-isi-edu/ermrestjs","description":"ERMrest client library in JavaScript","fork":false,"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs","forks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/forks","keys_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/teams","hooks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/hooks","issue_events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/events{/number}","events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/events","assignees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/assignees{/user}","branches_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/branches{/branch}","tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/tags","blobs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/{sha}","languages_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/languages","stargazers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/stargazers","contributors_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contributors","subscribers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscribers","subscription_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscription","commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contents/{+path}","compare_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/merges","archive_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/downloads","issues_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues{/number}","pulls_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls{/number}","milestones_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/milestones{/number}","notifications_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/labels{/name}","releases_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/releases{/id}","deployments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/deployments","created_at":"2015-07-29T16:06:49Z","updated_at":"2018-06-19T01:50:42Z","pushed_at":"2018-06-19T21:19:46Z","git_url":"git://github.com/informatics-isi-edu/ermrestjs.git","ssh_url":"git@github.com:informatics-isi-edu/ermrestjs.git","clone_url":"https://github.com/informatics-isi-edu/ermrestjs.git","svn_url":"https://github.com/informatics-isi-edu/ermrestjs","homepage":null,"size":3543,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":52,"watchers":3,"default_branch":"master"}},"base":{"label":"informatics-isi-edu:master","ref":"master","sha":"8aa6a65c89abd9951e3fae9cc44940163519ad8a","user":{"login":"informatics-isi-edu","id":9324294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9324294?v=4","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":39903075,"node_id":"MDEwOlJlcG9zaXRvcnkzOTkwMzA3NQ==","name":"ermrestjs","full_name":"informatics-isi-edu/ermrestjs","owner":{"login":"informatics-isi-edu","id":9324294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzMjQyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9324294?v=4","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/informatics-isi-edu/ermrestjs","description":"ERMrest client library in JavaScript","fork":false,"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs","forks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/forks","keys_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/teams","hooks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/hooks","issue_events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/events{/number}","events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/events","assignees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/assignees{/user}","branches_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/branches{/branch}","tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/tags","blobs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/{sha}","languages_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/languages","stargazers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/stargazers","contributors_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contributors","subscribers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscribers","subscription_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscription","commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contents/{+path}","compare_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/merges","archive_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/downloads","issues_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues{/number}","pulls_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls{/number}","milestones_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/milestones{/number}","notifications_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/labels{/name}","releases_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/releases{/id}","deployments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/deployments","created_at":"2015-07-29T16:06:49Z","updated_at":"2018-06-19T01:50:42Z","pushed_at":"2018-06-19T21:19:46Z","git_url":"git://github.com/informatics-isi-edu/ermrestjs.git","ssh_url":"git@github.com:informatics-isi-edu/ermrestjs.git","clone_url":"https://github.com/informatics-isi-edu/ermrestjs.git","svn_url":"https://github.com/informatics-isi-edu/ermrestjs","homepage":null,"size":3543,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":52,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664"},"html":{"href":"https://github.com/informatics-isi-edu/ermrestjs/pull/664"},"issue":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/664"},"comments":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/664/comments"},"review_comments":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664/comments"},"review_comment":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/664/commits"},"statuses":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/40a077a9902960c3cbd6214218f627d06224fb65"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":1096,"deletions":211,"changed_files":19}}
{"actor":{"display_login":"RFSH"}}