{"action":"created","comment":{"url":"https://api.github.com/repos/spiffe/spire/pulls/comments/175449041","pull_request_review_id":104978246,"id":175449041,"diff_hunk":"@@ -112,6 +123,41 @@ func (a *Agent) shutdown() {\n \t}\n }\n \n+func (a *Agent) setupProfiling() {\n+\tif a.c.ProfilingEnabled {\n+\t\tif runtime.MemProfileRate == 0 {\n+\t\t\ta.c.Log.Warn(\"Memory profiles are disabled\")\n+\t\t}\n+\t\tif a.c.ProfilingPort > 0 {\n+\t\t\tgrpc.EnableTracing = true\n+\t\t\tgo func() {\n+\t\t\t\tport := strconv.Itoa(a.c.ProfilingPort)","path":"pkg/agent/agent.go","position":42,"original_position":42,"commit_id":"e77f177ebca5f61503aa88afc350b349f6371b14","original_commit_id":"e77f177ebca5f61503aa88afc350b349f6371b14","user":{"login":"martincapello","id":5520828,"avatar_url":"https://avatars2.githubusercontent.com/u/5520828?v=4","gravatar_id":"","url":"https://api.github.com/users/martincapello","html_url":"https://github.com/martincapello","followers_url":"https://api.github.com/users/martincapello/followers","following_url":"https://api.github.com/users/martincapello/following{/other_user}","gists_url":"https://api.github.com/users/martincapello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincapello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincapello/subscriptions","organizations_url":"https://api.github.com/users/martincapello/orgs","repos_url":"https://api.github.com/users/martincapello/repos","events_url":"https://api.github.com/users/martincapello/events{/privacy}","received_events_url":"https://api.github.com/users/martincapello/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2018-03-19T14:15:39Z","updated_at":"2018-03-19T14:15:39Z","html_url":"https://github.com/spiffe/spire/pull/389#discussion_r175449041","pull_request_url":"https://api.github.com/repos/spiffe/spire/pulls/389","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spiffe/spire/pulls/comments/175449041"},"html":{"href":"https://github.com/spiffe/spire/pull/389#discussion_r175449041"},"pull_request":{"href":"https://api.github.com/repos/spiffe/spire/pulls/389"}},"in_reply_to_id":175221992},"pull_request":{"url":"https://api.github.com/repos/spiffe/spire/pulls/389","id":175651408,"html_url":"https://github.com/spiffe/spire/pull/389","diff_url":"https://github.com/spiffe/spire/pull/389.diff","patch_url":"https://github.com/spiffe/spire/pull/389.patch","issue_url":"https://api.github.com/repos/spiffe/spire/issues/389","number":389,"state":"open","locked":false,"title":"Add profiling capabilities.","user":{"login":"martincapello","id":5520828,"avatar_url":"https://avatars2.githubusercontent.com/u/5520828?v=4","gravatar_id":"","url":"https://api.github.com/users/martincapello","html_url":"https://github.com/martincapello","followers_url":"https://api.github.com/users/martincapello/followers","following_url":"https://api.github.com/users/martincapello/following{/other_user}","gists_url":"https://api.github.com/users/martincapello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincapello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincapello/subscriptions","organizations_url":"https://api.github.com/users/martincapello/orgs","repos_url":"https://api.github.com/users/martincapello/repos","events_url":"https://api.github.com/users/martincapello/events{/privacy}","received_events_url":"https://api.github.com/users/martincapello/received_events","type":"User","site_admin":false},"body":"Adds configuration parameters to enable pprof web server.\r\nAdds a profiling component to collect profiling data at some specified frequency.\r\nStill have to add some configuration parameters, like which profiles we want to persist.","created_at":"2018-03-16T21:34:16Z","updated_at":"2018-03-19T14:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"405c19f383753d4e7b65d8a70d06b159da412b89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MarcosDY","id":3899789,"avatar_url":"https://avatars0.githubusercontent.com/u/3899789?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcosDY","html_url":"https://github.com/MarcosDY","followers_url":"https://api.github.com/users/MarcosDY/followers","following_url":"https://api.github.com/users/MarcosDY/following{/other_user}","gists_url":"https://api.github.com/users/MarcosDY/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcosDY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcosDY/subscriptions","organizations_url":"https://api.github.com/users/MarcosDY/orgs","repos_url":"https://api.github.com/users/MarcosDY/repos","events_url":"https://api.github.com/users/MarcosDY/events{/privacy}","received_events_url":"https://api.github.com/users/MarcosDY/received_events","type":"User","site_admin":false},{"login":"walmav","id":23508970,"avatar_url":"https://avatars0.githubusercontent.com/u/23508970?v=4","gravatar_id":"","url":"https://api.github.com/users/walmav","html_url":"https://github.com/walmav","followers_url":"https://api.github.com/users/walmav/followers","following_url":"https://api.github.com/users/walmav/following{/other_user}","gists_url":"https://api.github.com/users/walmav/gists{/gist_id}","starred_url":"https://api.github.com/users/walmav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walmav/subscriptions","organizations_url":"https://api.github.com/users/walmav/orgs","repos_url":"https://api.github.com/users/walmav/repos","events_url":"https://api.github.com/users/walmav/events{/privacy}","received_events_url":"https://api.github.com/users/walmav/received_events","type":"User","site_admin":false},{"login":"amartinezfayo","id":26970586,"avatar_url":"https://avatars1.githubusercontent.com/u/26970586?v=4","gravatar_id":"","url":"https://api.github.com/users/amartinezfayo","html_url":"https://github.com/amartinezfayo","followers_url":"https://api.github.com/users/amartinezfayo/followers","following_url":"https://api.github.com/users/amartinezfayo/following{/other_user}","gists_url":"https://api.github.com/users/amartinezfayo/gists{/gist_id}","starred_url":"https://api.github.com/users/amartinezfayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amartinezfayo/subscriptions","organizations_url":"https://api.github.com/users/amartinezfayo/orgs","repos_url":"https://api.github.com/users/amartinezfayo/repos","events_url":"https://api.github.com/users/amartinezfayo/events{/privacy}","received_events_url":"https://api.github.com/users/amartinezfayo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":668743382,"url":"https://api.github.com/repos/spiffe/spire/labels/CLA","name":"CLA","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spiffe/spire/pulls/389/commits","review_comments_url":"https://api.github.com/repos/spiffe/spire/pulls/389/comments","review_comment_url":"https://api.github.com/repos/spiffe/spire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spiffe/spire/issues/389/comments","statuses_url":"https://api.github.com/repos/spiffe/spire/statuses/e77f177ebca5f61503aa88afc350b349f6371b14","head":{"label":"martincapello:pprof-experiment","ref":"pprof-experiment","sha":"e77f177ebca5f61503aa88afc350b349f6371b14","user":{"login":"martincapello","id":5520828,"avatar_url":"https://avatars2.githubusercontent.com/u/5520828?v=4","gravatar_id":"","url":"https://api.github.com/users/martincapello","html_url":"https://github.com/martincapello","followers_url":"https://api.github.com/users/martincapello/followers","following_url":"https://api.github.com/users/martincapello/following{/other_user}","gists_url":"https://api.github.com/users/martincapello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincapello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincapello/subscriptions","organizations_url":"https://api.github.com/users/martincapello/orgs","repos_url":"https://api.github.com/users/martincapello/repos","events_url":"https://api.github.com/users/martincapello/events{/privacy}","received_events_url":"https://api.github.com/users/martincapello/received_events","type":"User","site_admin":false},"repo":{"id":121263738,"name":"spire","full_name":"martincapello/spire","owner":{"login":"martincapello","id":5520828,"avatar_url":"https://avatars2.githubusercontent.com/u/5520828?v=4","gravatar_id":"","url":"https://api.github.com/users/martincapello","html_url":"https://github.com/martincapello","followers_url":"https://api.github.com/users/martincapello/followers","following_url":"https://api.github.com/users/martincapello/following{/other_user}","gists_url":"https://api.github.com/users/martincapello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincapello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincapello/subscriptions","organizations_url":"https://api.github.com/users/martincapello/orgs","repos_url":"https://api.github.com/users/martincapello/repos","events_url":"https://api.github.com/users/martincapello/events{/privacy}","received_events_url":"https://api.github.com/users/martincapello/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martincapello/spire","description":"The SPIFFE Runtime Environment","fork":true,"url":"https://api.github.com/repos/martincapello/spire","forks_url":"https://api.github.com/repos/martincapello/spire/forks","keys_url":"https://api.github.com/repos/martincapello/spire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martincapello/spire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martincapello/spire/teams","hooks_url":"https://api.github.com/repos/martincapello/spire/hooks","issue_events_url":"https://api.github.com/repos/martincapello/spire/issues/events{/number}","events_url":"https://api.github.com/repos/martincapello/spire/events","assignees_url":"https://api.github.com/repos/martincapello/spire/assignees{/user}","branches_url":"https://api.github.com/repos/martincapello/spire/branches{/branch}","tags_url":"https://api.github.com/repos/martincapello/spire/tags","blobs_url":"https://api.github.com/repos/martincapello/spire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martincapello/spire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martincapello/spire/git/refs{/sha}","trees_url":"https://api.github.com/repos/martincapello/spire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martincapello/spire/statuses/{sha}","languages_url":"https://api.github.com/repos/martincapello/spire/languages","stargazers_url":"https://api.github.com/repos/martincapello/spire/stargazers","contributors_url":"https://api.github.com/repos/martincapello/spire/contributors","subscribers_url":"https://api.github.com/repos/martincapello/spire/subscribers","subscription_url":"https://api.github.com/repos/martincapello/spire/subscription","commits_url":"https://api.github.com/repos/martincapello/spire/commits{/sha}","git_commits_url":"https://api.github.com/repos/martincapello/spire/git/commits{/sha}","comments_url":"https://api.github.com/repos/martincapello/spire/comments{/number}","issue_comment_url":"https://api.github.com/repos/martincapello/spire/issues/comments{/number}","contents_url":"https://api.github.com/repos/martincapello/spire/contents/{+path}","compare_url":"https://api.github.com/repos/martincapello/spire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martincapello/spire/merges","archive_url":"https://api.github.com/repos/martincapello/spire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martincapello/spire/downloads","issues_url":"https://api.github.com/repos/martincapello/spire/issues{/number}","pulls_url":"https://api.github.com/repos/martincapello/spire/pulls{/number}","milestones_url":"https://api.github.com/repos/martincapello/spire/milestones{/number}","notifications_url":"https://api.github.com/repos/martincapello/spire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martincapello/spire/labels{/name}","releases_url":"https://api.github.com/repos/martincapello/spire/releases{/id}","deployments_url":"https://api.github.com/repos/martincapello/spire/deployments","created_at":"2018-02-12T15:26:54Z","updated_at":"2018-02-12T15:26:56Z","pushed_at":"2018-03-16T21:27:27Z","git_url":"git://github.com/martincapello/spire.git","ssh_url":"git@github.com:martincapello/spire.git","clone_url":"https://github.com/martincapello/spire.git","svn_url":"https://github.com/martincapello/spire","homepage":"https://spiffe.io","size":2595,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spiffe:master","ref":"master","sha":"c1e30d02ce3b76a80d1eae72bb64e0b7aaf6172b","user":{"login":"spiffe","id":19497462,"avatar_url":"https://avatars0.githubusercontent.com/u/19497462?v=4","gravatar_id":"","url":"https://api.github.com/users/spiffe","html_url":"https://github.com/spiffe","followers_url":"https://api.github.com/users/spiffe/followers","following_url":"https://api.github.com/users/spiffe/following{/other_user}","gists_url":"https://api.github.com/users/spiffe/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffe/subscriptions","organizations_url":"https://api.github.com/users/spiffe/orgs","repos_url":"https://api.github.com/users/spiffe/repos","events_url":"https://api.github.com/users/spiffe/events{/privacy}","received_events_url":"https://api.github.com/users/spiffe/received_events","type":"Organization","site_admin":false},"repo":{"id":100061496,"name":"spire","full_name":"spiffe/spire","owner":{"login":"spiffe","id":19497462,"avatar_url":"https://avatars0.githubusercontent.com/u/19497462?v=4","gravatar_id":"","url":"https://api.github.com/users/spiffe","html_url":"https://github.com/spiffe","followers_url":"https://api.github.com/users/spiffe/followers","following_url":"https://api.github.com/users/spiffe/following{/other_user}","gists_url":"https://api.github.com/users/spiffe/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffe/subscriptions","organizations_url":"https://api.github.com/users/spiffe/orgs","repos_url":"https://api.github.com/users/spiffe/repos","events_url":"https://api.github.com/users/spiffe/events{/privacy}","received_events_url":"https://api.github.com/users/spiffe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spiffe/spire","description":"The SPIFFE Runtime Environment","fork":false,"url":"https://api.github.com/repos/spiffe/spire","forks_url":"https://api.github.com/repos/spiffe/spire/forks","keys_url":"https://api.github.com/repos/spiffe/spire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiffe/spire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiffe/spire/teams","hooks_url":"https://api.github.com/repos/spiffe/spire/hooks","issue_events_url":"https://api.github.com/repos/spiffe/spire/issues/events{/number}","events_url":"https://api.github.com/repos/spiffe/spire/events","assignees_url":"https://api.github.com/repos/spiffe/spire/assignees{/user}","branches_url":"https://api.github.com/repos/spiffe/spire/branches{/branch}","tags_url":"https://api.github.com/repos/spiffe/spire/tags","blobs_url":"https://api.github.com/repos/spiffe/spire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiffe/spire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiffe/spire/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiffe/spire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiffe/spire/statuses/{sha}","languages_url":"https://api.github.com/repos/spiffe/spire/languages","stargazers_url":"https://api.github.com/repos/spiffe/spire/stargazers","contributors_url":"https://api.github.com/repos/spiffe/spire/contributors","subscribers_url":"https://api.github.com/repos/spiffe/spire/subscribers","subscription_url":"https://api.github.com/repos/spiffe/spire/subscription","commits_url":"https://api.github.com/repos/spiffe/spire/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiffe/spire/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiffe/spire/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiffe/spire/issues/comments{/number}","contents_url":"https://api.github.com/repos/spiffe/spire/contents/{+path}","compare_url":"https://api.github.com/repos/spiffe/spire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiffe/spire/merges","archive_url":"https://api.github.com/repos/spiffe/spire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiffe/spire/downloads","issues_url":"https://api.github.com/repos/spiffe/spire/issues{/number}","pulls_url":"https://api.github.com/repos/spiffe/spire/pulls{/number}","milestones_url":"https://api.github.com/repos/spiffe/spire/milestones{/number}","notifications_url":"https://api.github.com/repos/spiffe/spire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiffe/spire/labels{/name}","releases_url":"https://api.github.com/repos/spiffe/spire/releases{/id}","deployments_url":"https://api.github.com/repos/spiffe/spire/deployments","created_at":"2017-08-11T18:46:51Z","updated_at":"2018-03-15T18:00:00Z","pushed_at":"2018-03-16T22:00:53Z","git_url":"git://github.com/spiffe/spire.git","ssh_url":"git@github.com:spiffe/spire.git","clone_url":"https://github.com/spiffe/spire.git","svn_url":"https://github.com/spiffe/spire","homepage":"https://spiffe.io","size":2477,"stargazers_count":148,"watchers_count":148,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":73,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spiffe/spire/pulls/389"},"html":{"href":"https://github.com/spiffe/spire/pull/389"},"issue":{"href":"https://api.github.com/repos/spiffe/spire/issues/389"},"comments":{"href":"https://api.github.com/repos/spiffe/spire/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/spiffe/spire/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/spiffe/spire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spiffe/spire/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/spiffe/spire/statuses/e77f177ebca5f61503aa88afc350b349f6371b14"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"martincapello"}}