{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13875","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13875/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13875/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13875/events","html_url":"https://github.com/bitcoin/bitcoin/pull/13875","id":347624985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTk2MDAw","number":13875,"title":"[doc] nChainTx needs to become a 64-bit earlier due to SegWit","user":{"login":"Sjors","id":10217,"node_id":"MDQ6VXNlcjEwMjE3","avatar_url":"https://avatars1.githubusercontent.com/u/10217?v=4","gravatar_id":"","url":"https://api.github.com/users/Sjors","html_url":"https://github.com/Sjors","followers_url":"https://api.github.com/users/Sjors/followers","following_url":"https://api.github.com/users/Sjors/following{/other_user}","gists_url":"https://api.github.com/users/Sjors/gists{/gist_id}","starred_url":"https://api.github.com/users/Sjors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sjors/subscriptions","organizations_url":"https://api.github.com/users/Sjors/orgs","repos_url":"https://api.github.com/users/Sjors/repos","events_url":"https://api.github.com/users/Sjors/events{/privacy}","received_events_url":"https://api.github.com/users/Sjors/received_events","type":"User","site_admin":false},"labels":[{"id":148216,"node_id":"MDU6TGFiZWwxNDgyMTY=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs","name":"Docs","color":"02d7e1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-04T14:58:30Z","updated_at":"2018-08-04T16:18:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13875","html_url":"https://github.com/bitcoin/bitcoin/pull/13875","diff_url":"https://github.com/bitcoin/bitcoin/pull/13875.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13875.patch"},"body":"As of block 534292 txcount is 331,282,217 (see #13794), while `uint32` can handle up to 4,294,967,296. \r\n\r\nPre segwit the [minimum transaction size](https://en.bitcoin.it/wiki/Maximum_transaction_rate) was 166 bytes, so the worst case number of transactions per block was ~6000. As the original source comment for `unsigned int  nChainTx` says, that should last until the year 2030.\r\n \r\nWith SegWit the [worst case number](https://bitcoin.stackexchange.com/a/59501), of transactions per block is ~12195 so we might have to deal with this as early as 2024.\r\n\r\nGiven that it's a memory-only thing and we want to allow users many years to upgrade, I would suggest fixing this in v0.18 and back-porting it."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/410460341","html_url":"https://github.com/bitcoin/bitcoin/pull/13875#issuecomment-410460341","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13875","id":410460341,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ2MDM0MQ==","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"created_at":"2018-08-04T16:18:22Z","updated_at":"2018-08-04T16:18:22Z","author_association":"MEMBER","body":"Could also rename both to `m_num_tx` according to release notes? (That would also help with review, since each usage of the member would have to be checked anyway)"}}
{"actor":{"display_login":"MarcoFalke"}}