{"action":"closed","number":981,"pull_request":{"url":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981","id":209194795,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTk0Nzk1","html_url":"https://github.com/CanonicalLtd/maas-docs/pull/981","diff_url":"https://github.com/CanonicalLtd/maas-docs/pull/981.diff","patch_url":"https://github.com/CanonicalLtd/maas-docs/pull/981.patch","issue_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/981","number":981,"state":"closed","locked":false,"title":"Convert Flask app to nginx","user":{"login":"WillMoggridge","id":322693,"node_id":"MDQ6VXNlcjMyMjY5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false},"body":"## Summary\r\nThis removes the Fask app with app.py and adds nginx configuration.\r\nThe run script, docker files, and package.json have been updated in line with this.\r\n\r\nThis is inline with\r\nhttps://github.com/canonical-docs/ubuntu-core-docs/pull/79\r\nhttps://github.com/canonical-docs/phone-docs/pull/17\r\n\r\n## QA\r\n\r\n**Test the run script**\r\n\r\n``` bash\r\n./run clean\r\n./run\r\n```\r\n\r\nBrowse to http://localhost:8203, and check the docs work.\r\nCheck redirects-maps work, such as http://localhost:8203/2.2/en/installconfig-add-nodes to `/2.2/en/nodes-add`;\r\n\r\n\r\n**Test the Dockerfile**\r\n\r\n(You must have done `./run` or `./run build` first - which is why this is the second QA step)\r\n\r\n``` bash\r\ndocker build --tag maas-docs --build-arg COMMIT_ID=`git rev-parse --short HEAD` .\r\ndocker run --rm -p 80:80 maas-docs  # NB: Check nothing else is running on 80, e.g. microk8s\r\n```\r\n\r\nGo to http://localhost check it works similarly.","created_at":"2018-08-17T16:15:20Z","updated_at":"2018-08-20T09:54:41Z","closed_at":"2018-08-20T09:54:41Z","merged_at":"2018-08-20T09:54:41Z","merge_commit_sha":"03afdb3e8668dbbcae9a9ed085961da5dda8e6b1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981/commits","review_comments_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981/comments","review_comment_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/981/comments","statuses_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/statuses/0483ced3d348288e32511a45ecf024e8ceed9679","head":{"label":"WillMoggridge:nginx","ref":"nginx","sha":"0483ced3d348288e32511a45ecf024e8ceed9679","user":{"login":"WillMoggridge","id":322693,"node_id":"MDQ6VXNlcjMyMjY5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false},"repo":{"id":119666707,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2NjY3MDc=","name":"maas-docs","full_name":"WillMoggridge/maas-docs","owner":{"login":"WillMoggridge","id":322693,"node_id":"MDQ6VXNlcjMyMjY5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/322693?v=4","gravatar_id":"","url":"https://api.github.com/users/WillMoggridge","html_url":"https://github.com/WillMoggridge","followers_url":"https://api.github.com/users/WillMoggridge/followers","following_url":"https://api.github.com/users/WillMoggridge/following{/other_user}","gists_url":"https://api.github.com/users/WillMoggridge/gists{/gist_id}","starred_url":"https://api.github.com/users/WillMoggridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillMoggridge/subscriptions","organizations_url":"https://api.github.com/users/WillMoggridge/orgs","repos_url":"https://api.github.com/users/WillMoggridge/repos","events_url":"https://api.github.com/users/WillMoggridge/events{/privacy}","received_events_url":"https://api.github.com/users/WillMoggridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WillMoggridge/maas-docs","description":"Documentation for MAAS http://maas.io","fork":true,"url":"https://api.github.com/repos/WillMoggridge/maas-docs","forks_url":"https://api.github.com/repos/WillMoggridge/maas-docs/forks","keys_url":"https://api.github.com/repos/WillMoggridge/maas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WillMoggridge/maas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WillMoggridge/maas-docs/teams","hooks_url":"https://api.github.com/repos/WillMoggridge/maas-docs/hooks","issue_events_url":"https://api.github.com/repos/WillMoggridge/maas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/WillMoggridge/maas-docs/events","assignees_url":"https://api.github.com/repos/WillMoggridge/maas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/WillMoggridge/maas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/WillMoggridge/maas-docs/tags","blobs_url":"https://api.github.com/repos/WillMoggridge/maas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WillMoggridge/maas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WillMoggridge/maas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/WillMoggridge/maas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WillMoggridge/maas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/WillMoggridge/maas-docs/languages","stargazers_url":"https://api.github.com/repos/WillMoggridge/maas-docs/stargazers","contributors_url":"https://api.github.com/repos/WillMoggridge/maas-docs/contributors","subscribers_url":"https://api.github.com/repos/WillMoggridge/maas-docs/subscribers","subscription_url":"https://api.github.com/repos/WillMoggridge/maas-docs/subscription","commits_url":"https://api.github.com/repos/WillMoggridge/maas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/WillMoggridge/maas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/WillMoggridge/maas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/WillMoggridge/maas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/WillMoggridge/maas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/WillMoggridge/maas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WillMoggridge/maas-docs/merges","archive_url":"https://api.github.com/repos/WillMoggridge/maas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WillMoggridge/maas-docs/downloads","issues_url":"https://api.github.com/repos/WillMoggridge/maas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/WillMoggridge/maas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/WillMoggridge/maas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/WillMoggridge/maas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WillMoggridge/maas-docs/labels{/name}","releases_url":"https://api.github.com/repos/WillMoggridge/maas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/WillMoggridge/maas-docs/deployments","created_at":"2018-01-31T09:40:30Z","updated_at":"2017-11-01T20:09:39Z","pushed_at":"2018-08-20T09:02:19Z","git_url":"git://github.com/WillMoggridge/maas-docs.git","ssh_url":"git@github.com:WillMoggridge/maas-docs.git","clone_url":"https://github.com/WillMoggridge/maas-docs.git","svn_url":"https://github.com/WillMoggridge/maas-docs","homepage":null,"size":16694,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0","node_id":"MDc6TGljZW5zZTI2"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanonicalLtd:master","ref":"master","sha":"74f49f913fdabe87f52b8f6edf2850bbdcfb7acc","user":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":56876730,"node_id":"MDEwOlJlcG9zaXRvcnk1Njg3NjczMA==","name":"maas-docs","full_name":"CanonicalLtd/maas-docs","owner":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanonicalLtd/maas-docs","description":"Documentation for MAAS http://maas.io","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/maas-docs","forks_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/maas-docs/deployments","created_at":"2016-04-22T18:24:22Z","updated_at":"2018-08-10T09:28:08Z","pushed_at":"2018-08-20T09:54:41Z","git_url":"git://github.com/CanonicalLtd/maas-docs.git","ssh_url":"git@github.com:CanonicalLtd/maas-docs.git","clone_url":"https://github.com/CanonicalLtd/maas-docs.git","svn_url":"https://github.com/CanonicalLtd/maas-docs","homepage":null,"size":16978,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0","node_id":"MDc6TGljZW5zZTI2"},"forks":27,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981"},"html":{"href":"https://github.com/CanonicalLtd/maas-docs/pull/981"},"issue":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/981"},"comments":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/issues/981/comments"},"review_comments":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981/comments"},"review_comment":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/pulls/981/commits"},"statuses":{"href":"https://api.github.com/repos/CanonicalLtd/maas-docs/statuses/0483ced3d348288e32511a45ecf024e8ceed9679"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nottrobin","id":519935,"node_id":"MDQ6VXNlcjUxOTkzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/519935?v=4","gravatar_id":"","url":"https://api.github.com/users/nottrobin","html_url":"https://github.com/nottrobin","followers_url":"https://api.github.com/users/nottrobin/followers","following_url":"https://api.github.com/users/nottrobin/following{/other_user}","gists_url":"https://api.github.com/users/nottrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/nottrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nottrobin/subscriptions","organizations_url":"https://api.github.com/users/nottrobin/orgs","repos_url":"https://api.github.com/users/nottrobin/repos","events_url":"https://api.github.com/users/nottrobin/events{/privacy}","received_events_url":"https://api.github.com/users/nottrobin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":92,"deletions":417,"changed_files":11}}
{"actor":{"display_login":"nottrobin"}}