{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/200204020","pull_request_review_id":134473780,"id":200204020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIwNDAyMA==","diff_hunk":"@@ -1448,6 +1451,45 @@ extern (C++) final class ConditionalStatement : Statement\n     }\n }\n \n+/**\n+Marks all occurring ThrowStatements as as internalThrows.\n+This is intended to be called from a DebugStatement as it allows\n+to mark all its nodes as nothrow.\n+\n+Params:\n+    s = AST Node to traverse\n+*/\n+private void debugThrowWalker(Statement s)\n+{\n+\n+    extern(C++) final class DebugWalker : SemanticTimeTransitiveVisitor\n+    {\n+        alias visit = SemanticTimeTransitiveVisitor.visit;\n+    public:\n+\n+        override void visit(ThrowStatement s)\n+        {\n+            s.internalThrow = true;\n+        }\n+\n+        override void visit(TryCatchStatement s)\n+        {\n+            foreach (c; *s.catches)","path":"src/dmd/statement.d","position":38,"original_position":38,"commit_id":"64091285fa30880232264f6c68f3337376a3861f","original_commit_id":"64091285fa30880232264f6c68f3337376a3861f","user":{"login":"RazvanN7","id":22907766,"node_id":"MDQ6VXNlcjIyOTA3NzY2","avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"body":"uncovered","created_at":"2018-07-04T21:45:08Z","updated_at":"2018-07-04T21:45:09Z","html_url":"https://github.com/dlang/dmd/pull/8449#discussion_r200204020","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/8449","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/200204020"},"html":{"href":"https://github.com/dlang/dmd/pull/8449#discussion_r200204020"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8449"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8449","id":199106428,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTA2NDI4","html_url":"https://github.com/dlang/dmd/pull/8449","diff_url":"https://github.com/dlang/dmd/pull/8449.diff","patch_url":"https://github.com/dlang/dmd/pull/8449.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8449","number":8449,"state":"open","locked":false,"title":"Issue 18407 - debug should escape nothrow","user":{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"References:\n- https://issues.dlang.org/show_bug.cgi?id=18407\n- https://github.com/dlang/dmd/pull/7882\n- https://github.com/dlang/dlang.org/pull/2209\n\nI wasn't entirely sure on the best way to do this.\nThe problem is that `blockexit` checker runs so late in semantic3 that the DebugStatements are already flattened out.\n\nI'm not proud of the current solution, so I'm more than open to better suggestions.","created_at":"2018-07-03T23:29:02Z","updated_at":"2018-07-04T21:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865a73870a36d8032145a60f26c58f322017bbb6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/8449/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/8449/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8449/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/64091285fa30880232264f6c68f3337376a3861f","head":{"label":"wilzbach:fix-18407","ref":"fix-18407","sha":"64091285fa30880232264f6c68f3337376a3861f","user":{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"repo":{"id":55034525,"node_id":"MDEwOlJlcG9zaXRvcnk1NTAzNDUyNQ==","name":"dmd","full_name":"wilzbach/dmd","owner":{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilzbach/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/wilzbach/dmd","forks_url":"https://api.github.com/repos/wilzbach/dmd/forks","keys_url":"https://api.github.com/repos/wilzbach/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilzbach/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilzbach/dmd/teams","hooks_url":"https://api.github.com/repos/wilzbach/dmd/hooks","issue_events_url":"https://api.github.com/repos/wilzbach/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/wilzbach/dmd/events","assignees_url":"https://api.github.com/repos/wilzbach/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/wilzbach/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/wilzbach/dmd/tags","blobs_url":"https://api.github.com/repos/wilzbach/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilzbach/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilzbach/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilzbach/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilzbach/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/wilzbach/dmd/languages","stargazers_url":"https://api.github.com/repos/wilzbach/dmd/stargazers","contributors_url":"https://api.github.com/repos/wilzbach/dmd/contributors","subscribers_url":"https://api.github.com/repos/wilzbach/dmd/subscribers","subscription_url":"https://api.github.com/repos/wilzbach/dmd/subscription","commits_url":"https://api.github.com/repos/wilzbach/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilzbach/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilzbach/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilzbach/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilzbach/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/wilzbach/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilzbach/dmd/merges","archive_url":"https://api.github.com/repos/wilzbach/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilzbach/dmd/downloads","issues_url":"https://api.github.com/repos/wilzbach/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/wilzbach/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/wilzbach/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/wilzbach/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilzbach/dmd/labels{/name}","releases_url":"https://api.github.com/repos/wilzbach/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/wilzbach/dmd/deployments","created_at":"2016-03-30T05:15:54Z","updated_at":"2018-07-03T23:53:19Z","pushed_at":"2018-07-04T16:40:10Z","git_url":"git://github.com/wilzbach/dmd.git","ssh_url":"git@github.com:wilzbach/dmd.git","clone_url":"https://github.com/wilzbach/dmd.git","svn_url":"https://github.com/wilzbach/dmd","homepage":"dlang.org","size":90342,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"0ed6065c6565e69aa9291887b89daf568db230de","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-07-04T16:33:04Z","pushed_at":"2018-07-04T21:04:17Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":91299,"stargazers_count":1812,"watchers_count":1812,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":453,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":453,"open_issues":128,"watchers":1812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8449"},"html":{"href":"https://github.com/dlang/dmd/pull/8449"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/8449"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/8449/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8449/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8449/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/64091285fa30880232264f6c68f3337376a3861f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RazvanN7"}}