{"action":"created","comment":{"url":"https://api.github.com/repos/storytouch/ep_comments/pulls/comments/165489097","pull_request_review_id":93439349,"id":165489097,"diff_hunk":"@@ -100,24 +100,24 @@ var addListenersToCommentIcons = function(ace) {\n   });\n }\n \n-exports.showSMHiddenIfCommentIsOnIt = function(commentId) {\n-  var commentIsOnSceneMarkHidden = isCommentOnSceneMarkHidden(commentId);\n+exports.showSMHiddenIfTextMarkIsOnIt = function(textMarkId) {\n+  var textMarkIsOnSceneMarkHidden = isTextMarkAppliedOnlyOnASMHidden(textMarkId);\n \n-  if (commentIsOnSceneMarkHidden) {\n+  if (textMarkIsOnSceneMarkHidden) {\n     var rep = this.rep;\n     var editorInfo = this.editorInfo;\n     var attributeManager = this.documentAttributeManager;\n-    var firstLineWhereCommentIsApplied = getFirstLineWhereCommentIsApplied(commentId, rep);\n-    sceneMarkVisibility.showSceneMarksAroundLine(firstLineWhereCommentIsApplied, editorInfo, attributeManager);\n+    var firstLineWhereTextMarkIsApplied = getFirstLineWhereTextMarkIsApplied(textMarkId, rep);\n+    sceneMarkVisibility.showSceneMarksAroundLine(firstLineWhereTextMarkIsApplied, editorInfo, attributeManager);\n   }\n }\n \n-var isCommentOnSceneMarkHidden = function(commentId) {\n-  var $linesWhereCommentIsApplied = utils.getPadInner().find('div').has('.' + commentId);\n-  var commmentIsAppliedOnlyOnSceneMark = _.every($linesWhereCommentIsApplied, function(line){\n+var isTextMarkAppliedOnlyOnASMHidden = function(textMarkId) {\n+  var $linesWhereTextMarkIsApplied = utils.getPadInner().find('div').has('.' + textMarkId);","path":"static/js/commentIcons.js","position":34,"original_position":34,"commit_id":"bd4841483a4b27a6b8fb28ded39a6fedaa6f5b9d","original_commit_id":"bd4841483a4b27a6b8fb28ded39a6fedaa6f5b9d","user":{"login":"lpagliari","id":836386,"avatar_url":"https://avatars1.githubusercontent.com/u/836386?v=4","gravatar_id":"","url":"https://api.github.com/users/lpagliari","html_url":"https://github.com/lpagliari","followers_url":"https://api.github.com/users/lpagliari/followers","following_url":"https://api.github.com/users/lpagliari/following{/other_user}","gists_url":"https://api.github.com/users/lpagliari/gists{/gist_id}","starred_url":"https://api.github.com/users/lpagliari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpagliari/subscriptions","organizations_url":"https://api.github.com/users/lpagliari/orgs","repos_url":"https://api.github.com/users/lpagliari/repos","events_url":"https://api.github.com/users/lpagliari/events{/privacy}","received_events_url":"https://api.github.com/users/lpagliari/received_events","type":"User","site_admin":false},"body":"Estamos assumindo que sempre a text mark será aplicada como uma classe dentro do `div`, mas isso restringe bastante o uso deste módulo. Uma sugestão -- que não precisa ser feita agora, mas que se vc quiser aproveitar que está mexendo no código para implementar -- é passar um seletor ao invés do `textMarkId`. Nos casos atuais, isso significa chamar `showSMHiddenIfCommentIsOnIt('div:has(.' + commentId + ')')` ao invés de `showSMHiddenIfCommentIsOnIt(commentId)`","created_at":"2018-02-01T21:13:14Z","updated_at":"2018-02-01T21:14:12Z","html_url":"https://github.com/storytouch/ep_comments/pull/20#discussion_r165489097","pull_request_url":"https://api.github.com/repos/storytouch/ep_comments/pulls/20","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/comments/165489097"},"html":{"href":"https://github.com/storytouch/ep_comments/pull/20#discussion_r165489097"},"pull_request":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/storytouch/ep_comments/pulls/20","id":166558010,"html_url":"https://github.com/storytouch/ep_comments/pull/20","diff_url":"https://github.com/storytouch/ep_comments/pull/20.diff","patch_url":"https://github.com/storytouch/ep_comments/pull/20.patch","issue_url":"https://api.github.com/repos/storytouch/ep_comments/issues/20","number":20,"state":"open","locked":false,"title":"[refactor] Rename function","user":{"login":"joassouza","id":4945372,"avatar_url":"https://avatars2.githubusercontent.com/u/4945372?v=4","gravatar_id":"","url":"https://api.github.com/users/joassouza","html_url":"https://github.com/joassouza","followers_url":"https://api.github.com/users/joassouza/followers","following_url":"https://api.github.com/users/joassouza/following{/other_user}","gists_url":"https://api.github.com/users/joassouza/gists{/gist_id}","starred_url":"https://api.github.com/users/joassouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joassouza/subscriptions","organizations_url":"https://api.github.com/users/joassouza/orgs","repos_url":"https://api.github.com/users/joassouza/repos","events_url":"https://api.github.com/users/joassouza/events{/privacy}","received_events_url":"https://api.github.com/users/joassouza/received_events","type":"User","site_admin":false},"body":"Como a gente vai usar a lógica igualzinha no `ep_script_touches`, resolvi renomear para ficar mais claro quando usar esta função no `ep_script_touches`.","created_at":"2018-02-01T14:50:55Z","updated_at":"2018-02-01T21:14:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28da8b8b51a5f9452ca6926f44e2ea0ad72ba4be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/storytouch/ep_comments/pulls/20/commits","review_comments_url":"https://api.github.com/repos/storytouch/ep_comments/pulls/20/comments","review_comment_url":"https://api.github.com/repos/storytouch/ep_comments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storytouch/ep_comments/issues/20/comments","statuses_url":"https://api.github.com/repos/storytouch/ep_comments/statuses/bd4841483a4b27a6b8fb28ded39a6fedaa6f5b9d","head":{"label":"storytouch:refactor/rename-function","ref":"refactor/rename-function","sha":"bd4841483a4b27a6b8fb28ded39a6fedaa6f5b9d","user":{"login":"storytouch","id":6464228,"avatar_url":"https://avatars1.githubusercontent.com/u/6464228?v=4","gravatar_id":"","url":"https://api.github.com/users/storytouch","html_url":"https://github.com/storytouch","followers_url":"https://api.github.com/users/storytouch/followers","following_url":"https://api.github.com/users/storytouch/following{/other_user}","gists_url":"https://api.github.com/users/storytouch/gists{/gist_id}","starred_url":"https://api.github.com/users/storytouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storytouch/subscriptions","organizations_url":"https://api.github.com/users/storytouch/orgs","repos_url":"https://api.github.com/users/storytouch/repos","events_url":"https://api.github.com/users/storytouch/events{/privacy}","received_events_url":"https://api.github.com/users/storytouch/received_events","type":"Organization","site_admin":false},"repo":{"id":37080348,"name":"ep_comments","full_name":"storytouch/ep_comments","owner":{"login":"storytouch","id":6464228,"avatar_url":"https://avatars1.githubusercontent.com/u/6464228?v=4","gravatar_id":"","url":"https://api.github.com/users/storytouch","html_url":"https://github.com/storytouch","followers_url":"https://api.github.com/users/storytouch/followers","following_url":"https://api.github.com/users/storytouch/following{/other_user}","gists_url":"https://api.github.com/users/storytouch/gists{/gist_id}","starred_url":"https://api.github.com/users/storytouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storytouch/subscriptions","organizations_url":"https://api.github.com/users/storytouch/orgs","repos_url":"https://api.github.com/users/storytouch/repos","events_url":"https://api.github.com/users/storytouch/events{/privacy}","received_events_url":"https://api.github.com/users/storytouch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storytouch/ep_comments","description":"Comments in Etherpad - No Longer Highly Experimental, now highly awesome!","fork":true,"url":"https://api.github.com/repos/storytouch/ep_comments","forks_url":"https://api.github.com/repos/storytouch/ep_comments/forks","keys_url":"https://api.github.com/repos/storytouch/ep_comments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storytouch/ep_comments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storytouch/ep_comments/teams","hooks_url":"https://api.github.com/repos/storytouch/ep_comments/hooks","issue_events_url":"https://api.github.com/repos/storytouch/ep_comments/issues/events{/number}","events_url":"https://api.github.com/repos/storytouch/ep_comments/events","assignees_url":"https://api.github.com/repos/storytouch/ep_comments/assignees{/user}","branches_url":"https://api.github.com/repos/storytouch/ep_comments/branches{/branch}","tags_url":"https://api.github.com/repos/storytouch/ep_comments/tags","blobs_url":"https://api.github.com/repos/storytouch/ep_comments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storytouch/ep_comments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storytouch/ep_comments/git/refs{/sha}","trees_url":"https://api.github.com/repos/storytouch/ep_comments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storytouch/ep_comments/statuses/{sha}","languages_url":"https://api.github.com/repos/storytouch/ep_comments/languages","stargazers_url":"https://api.github.com/repos/storytouch/ep_comments/stargazers","contributors_url":"https://api.github.com/repos/storytouch/ep_comments/contributors","subscribers_url":"https://api.github.com/repos/storytouch/ep_comments/subscribers","subscription_url":"https://api.github.com/repos/storytouch/ep_comments/subscription","commits_url":"https://api.github.com/repos/storytouch/ep_comments/commits{/sha}","git_commits_url":"https://api.github.com/repos/storytouch/ep_comments/git/commits{/sha}","comments_url":"https://api.github.com/repos/storytouch/ep_comments/comments{/number}","issue_comment_url":"https://api.github.com/repos/storytouch/ep_comments/issues/comments{/number}","contents_url":"https://api.github.com/repos/storytouch/ep_comments/contents/{+path}","compare_url":"https://api.github.com/repos/storytouch/ep_comments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storytouch/ep_comments/merges","archive_url":"https://api.github.com/repos/storytouch/ep_comments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storytouch/ep_comments/downloads","issues_url":"https://api.github.com/repos/storytouch/ep_comments/issues{/number}","pulls_url":"https://api.github.com/repos/storytouch/ep_comments/pulls{/number}","milestones_url":"https://api.github.com/repos/storytouch/ep_comments/milestones{/number}","notifications_url":"https://api.github.com/repos/storytouch/ep_comments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storytouch/ep_comments/labels{/name}","releases_url":"https://api.github.com/repos/storytouch/ep_comments/releases{/id}","deployments_url":"https://api.github.com/repos/storytouch/ep_comments/deployments","created_at":"2015-06-08T16:58:52Z","updated_at":"2016-01-11T13:16:24Z","pushed_at":"2018-02-01T14:50:55Z","git_url":"git://github.com/storytouch/ep_comments.git","ssh_url":"git@github.com:storytouch/ep_comments.git","clone_url":"https://github.com/storytouch/ep_comments.git","svn_url":"https://github.com/storytouch/ep_comments","homepage":"","size":609,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master-tk"}},"base":{"label":"storytouch:master-tk","ref":"master-tk","sha":"0d895a215b90e7d396fc05d7f374efb51ec6d5b9","user":{"login":"storytouch","id":6464228,"avatar_url":"https://avatars1.githubusercontent.com/u/6464228?v=4","gravatar_id":"","url":"https://api.github.com/users/storytouch","html_url":"https://github.com/storytouch","followers_url":"https://api.github.com/users/storytouch/followers","following_url":"https://api.github.com/users/storytouch/following{/other_user}","gists_url":"https://api.github.com/users/storytouch/gists{/gist_id}","starred_url":"https://api.github.com/users/storytouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storytouch/subscriptions","organizations_url":"https://api.github.com/users/storytouch/orgs","repos_url":"https://api.github.com/users/storytouch/repos","events_url":"https://api.github.com/users/storytouch/events{/privacy}","received_events_url":"https://api.github.com/users/storytouch/received_events","type":"Organization","site_admin":false},"repo":{"id":37080348,"name":"ep_comments","full_name":"storytouch/ep_comments","owner":{"login":"storytouch","id":6464228,"avatar_url":"https://avatars1.githubusercontent.com/u/6464228?v=4","gravatar_id":"","url":"https://api.github.com/users/storytouch","html_url":"https://github.com/storytouch","followers_url":"https://api.github.com/users/storytouch/followers","following_url":"https://api.github.com/users/storytouch/following{/other_user}","gists_url":"https://api.github.com/users/storytouch/gists{/gist_id}","starred_url":"https://api.github.com/users/storytouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storytouch/subscriptions","organizations_url":"https://api.github.com/users/storytouch/orgs","repos_url":"https://api.github.com/users/storytouch/repos","events_url":"https://api.github.com/users/storytouch/events{/privacy}","received_events_url":"https://api.github.com/users/storytouch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storytouch/ep_comments","description":"Comments in Etherpad - No Longer Highly Experimental, now highly awesome!","fork":true,"url":"https://api.github.com/repos/storytouch/ep_comments","forks_url":"https://api.github.com/repos/storytouch/ep_comments/forks","keys_url":"https://api.github.com/repos/storytouch/ep_comments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storytouch/ep_comments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storytouch/ep_comments/teams","hooks_url":"https://api.github.com/repos/storytouch/ep_comments/hooks","issue_events_url":"https://api.github.com/repos/storytouch/ep_comments/issues/events{/number}","events_url":"https://api.github.com/repos/storytouch/ep_comments/events","assignees_url":"https://api.github.com/repos/storytouch/ep_comments/assignees{/user}","branches_url":"https://api.github.com/repos/storytouch/ep_comments/branches{/branch}","tags_url":"https://api.github.com/repos/storytouch/ep_comments/tags","blobs_url":"https://api.github.com/repos/storytouch/ep_comments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storytouch/ep_comments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storytouch/ep_comments/git/refs{/sha}","trees_url":"https://api.github.com/repos/storytouch/ep_comments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storytouch/ep_comments/statuses/{sha}","languages_url":"https://api.github.com/repos/storytouch/ep_comments/languages","stargazers_url":"https://api.github.com/repos/storytouch/ep_comments/stargazers","contributors_url":"https://api.github.com/repos/storytouch/ep_comments/contributors","subscribers_url":"https://api.github.com/repos/storytouch/ep_comments/subscribers","subscription_url":"https://api.github.com/repos/storytouch/ep_comments/subscription","commits_url":"https://api.github.com/repos/storytouch/ep_comments/commits{/sha}","git_commits_url":"https://api.github.com/repos/storytouch/ep_comments/git/commits{/sha}","comments_url":"https://api.github.com/repos/storytouch/ep_comments/comments{/number}","issue_comment_url":"https://api.github.com/repos/storytouch/ep_comments/issues/comments{/number}","contents_url":"https://api.github.com/repos/storytouch/ep_comments/contents/{+path}","compare_url":"https://api.github.com/repos/storytouch/ep_comments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storytouch/ep_comments/merges","archive_url":"https://api.github.com/repos/storytouch/ep_comments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storytouch/ep_comments/downloads","issues_url":"https://api.github.com/repos/storytouch/ep_comments/issues{/number}","pulls_url":"https://api.github.com/repos/storytouch/ep_comments/pulls{/number}","milestones_url":"https://api.github.com/repos/storytouch/ep_comments/milestones{/number}","notifications_url":"https://api.github.com/repos/storytouch/ep_comments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storytouch/ep_comments/labels{/name}","releases_url":"https://api.github.com/repos/storytouch/ep_comments/releases{/id}","deployments_url":"https://api.github.com/repos/storytouch/ep_comments/deployments","created_at":"2015-06-08T16:58:52Z","updated_at":"2016-01-11T13:16:24Z","pushed_at":"2018-02-01T14:50:55Z","git_url":"git://github.com/storytouch/ep_comments.git","ssh_url":"git@github.com:storytouch/ep_comments.git","clone_url":"https://github.com/storytouch/ep_comments.git","svn_url":"https://github.com/storytouch/ep_comments","homepage":"","size":609,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master-tk"}},"_links":{"self":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/20"},"html":{"href":"https://github.com/storytouch/ep_comments/pull/20"},"issue":{"href":"https://api.github.com/repos/storytouch/ep_comments/issues/20"},"comments":{"href":"https://api.github.com/repos/storytouch/ep_comments/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storytouch/ep_comments/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/storytouch/ep_comments/statuses/bd4841483a4b27a6b8fb28ded39a6fedaa6f5b9d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lpagliari"}}