{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/204190220","pull_request_review_id":139235352,"id":204190220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE5MDIyMA==","diff_hunk":"@@ -475,95 +487,73 @@ void NodeManager::ProcessClientMessage(\n     SubmitTask(task, Lineage());\n   } break;\n   case protocol::MessageType::ReconstructObjects: {\n-    // TODO(hme): handle multiple object ids.\n     auto message = flatbuffers::GetRoot<protocol::ReconstructObjects>(message_data);\n+    std::vector<ObjectID> required_object_ids;\n     for (size_t i = 0; i < message->object_ids()->size(); ++i) {\n       ObjectID object_id = from_flatbuf(*message->object_ids()->Get(i));\n-      RAY_LOG(DEBUG) << \"reconstructing object \" << object_id;\n       if (!task_dependency_manager_.CheckObjectLocal(object_id)) {\n-        // TODO(swang): Instead of calling Pull on the object directly, record the\n-        // fact that the blocked task is dependent on this object_id in the task\n-        // dependency manager.\n-        RAY_CHECK_OK(object_manager_.Pull(object_id));\n+        if (message->fetch_only()) {\n+          RAY_CHECK_OK(object_manager_.Pull(object_id));\n+        } else {\n+          // Add any missing objects to the list to subscribe to in the task\n+          // dependency manager.","path":"src/ray/raylet/node_manager.cc","position":79,"original_position":79,"commit_id":"407032c123c69c1812b9a75c080dea24edb3e89c","original_commit_id":"407032c123c69c1812b9a75c080dea24edb3e89c","user":{"login":"robertnishihara","id":249517,"node_id":"MDQ6VXNlcjI0OTUxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/249517?v=4","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"I think this `else` might be applied to the wrong `if` statement.","created_at":"2018-07-20T23:26:00Z","updated_at":"2018-07-20T23:35:31Z","html_url":"https://github.com/ray-project/ray/pull/2362#discussion_r204190220","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/2362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/204190220"},"html":{"href":"https://github.com/ray-project/ray/pull/2362#discussion_r204190220"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2362"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2362","id":199862074,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODYyMDc0","html_url":"https://github.com/ray-project/ray/pull/2362","diff_url":"https://github.com/ray-project/ray/pull/2362.diff","patch_url":"https://github.com/ray-project/ray/pull/2362.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2362","number":2362,"state":"open","locked":false,"title":"[xray] Track `ray.get` calls as task dependencies","user":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\nThe task dependency manager is used to make any dependencies required by a task available, either by fetching it from a remote node, or eventually, by reconstructing it. This was previously used for scheduling submitted tasks with object arguments, but the logic needed for a task that calls `ray.get` is similar. This PR directs that logic through the task dependency manager as well. This also includes some cleanup in the `SchedulingQueue` code.","created_at":"2018-07-06T22:46:19Z","updated_at":"2018-07-20T23:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"061d1158ba233f92729532c7fe23505326359e7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pcmoritz","id":113316,"node_id":"MDQ6VXNlcjExMzMxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/113316?v=4","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2362/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2362/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2362/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/407032c123c69c1812b9a75c080dea24edb3e89c","head":{"label":"stephanie-wang:track-get-dependencies","ref":"track-get-dependencies","sha":"407032c123c69c1812b9a75c080dea24edb3e89c","user":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"repo":{"id":77302388,"node_id":"MDEwOlJlcG9zaXRvcnk3NzMwMjM4OA==","name":"ray","full_name":"stephanie-wang/ray","owner":{"login":"stephanie-wang","id":2560516,"node_id":"MDQ6VXNlcjI1NjA1MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephanie-wang/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/stephanie-wang/ray","forks_url":"https://api.github.com/repos/stephanie-wang/ray/forks","keys_url":"https://api.github.com/repos/stephanie-wang/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephanie-wang/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephanie-wang/ray/teams","hooks_url":"https://api.github.com/repos/stephanie-wang/ray/hooks","issue_events_url":"https://api.github.com/repos/stephanie-wang/ray/issues/events{/number}","events_url":"https://api.github.com/repos/stephanie-wang/ray/events","assignees_url":"https://api.github.com/repos/stephanie-wang/ray/assignees{/user}","branches_url":"https://api.github.com/repos/stephanie-wang/ray/branches{/branch}","tags_url":"https://api.github.com/repos/stephanie-wang/ray/tags","blobs_url":"https://api.github.com/repos/stephanie-wang/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephanie-wang/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephanie-wang/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephanie-wang/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephanie-wang/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/stephanie-wang/ray/languages","stargazers_url":"https://api.github.com/repos/stephanie-wang/ray/stargazers","contributors_url":"https://api.github.com/repos/stephanie-wang/ray/contributors","subscribers_url":"https://api.github.com/repos/stephanie-wang/ray/subscribers","subscription_url":"https://api.github.com/repos/stephanie-wang/ray/subscription","commits_url":"https://api.github.com/repos/stephanie-wang/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephanie-wang/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephanie-wang/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephanie-wang/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephanie-wang/ray/contents/{+path}","compare_url":"https://api.github.com/repos/stephanie-wang/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephanie-wang/ray/merges","archive_url":"https://api.github.com/repos/stephanie-wang/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephanie-wang/ray/downloads","issues_url":"https://api.github.com/repos/stephanie-wang/ray/issues{/number}","pulls_url":"https://api.github.com/repos/stephanie-wang/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/stephanie-wang/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/stephanie-wang/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephanie-wang/ray/labels{/name}","releases_url":"https://api.github.com/repos/stephanie-wang/ray/releases{/id}","deployments_url":"https://api.github.com/repos/stephanie-wang/ray/deployments","created_at":"2016-12-24T22:37:23Z","updated_at":"2018-04-24T01:06:35Z","pushed_at":"2018-07-20T23:07:11Z","git_url":"git://github.com/stephanie-wang/ray.git","ssh_url":"git@github.com:stephanie-wang/ray.git","clone_url":"https://github.com/stephanie-wang/ray.git","svn_url":"https://github.com/stephanie-wang/ray","homepage":"","size":16471,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"05f485e274e588c0635d4d3fe0e3ff2666dd5cda","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-07-20T22:39:08Z","pushed_at":"2018-07-20T23:07:13Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":13138,"stargazers_count":3732,"watchers_count":3732,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":499,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":499,"open_issues":339,"watchers":3732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2362"},"html":{"href":"https://github.com/ray-project/ray/pull/2362"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2362"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2362/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2362/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2362/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/407032c123c69c1812b9a75c080dea24edb3e89c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertnishihara"}}