{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/210315923","pull_request_review_id":146504414,"id":210315923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDMxNTkyMw==","diff_hunk":"@@ -43,7 +44,10 @@ def initialize(environment, for_agent)\n     #\n     @puppet_system_loader = create_puppet_system_loader()\n \n-    # 2. Environment loader - i.e. what is bound across the environment, may change for each setup\n+    # 2. Cache loader - ie what puppet stores on disk via pluginsync.\n+    @puppet_cache_loader = create_puppet_cache_loader()","path":"lib/puppet/pops/loaders.rb","position":14,"original_position":14,"commit_id":"8e6d965aa48a1401716081e3d8f6c6c5185759e4","original_commit_id":"8e6d965aa48a1401716081e3d8f6c6c5185759e4","user":{"login":"joshcooper","id":737664,"node_id":"MDQ6VXNlcjczNzY2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/737664?v=4","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"In a multi-master scenario, the agent running on the compile master will pluginsync from the mom (master of masters), and some people rely on that to distribute server-side extensions like hiera backends. In Puppet 4 we changed puppetserver to exclude the agent's libdir, so the default is:\r\n\r\n```hocon\r\n    ruby-load-path: [/opt/puppetlabs/puppet/lib/ruby/vendor_ruby]\r\n```\r\n\r\nThat broke some people (https://tickets.puppetlabs.com/browse/SERVER-571), and the current workaround is to add the agent's libdir back to `ruby-load-path`, with the understanding that it will break environment isolation (since any types/providers that the compile master's agent pluginsync will be visible across all environments when the compile master compiles catalogs for other agents).","created_at":"2018-08-15T15:51:59Z","updated_at":"2018-08-15T15:51:59Z","html_url":"https://github.com/puppetlabs/puppet/pull/6963#discussion_r210315923","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/210315923"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6963#discussion_r210315923"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963"}},"in_reply_to_id":210131299},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963","id":205579427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTc5NDI3","html_url":"https://github.com/puppetlabs/puppet/pull/6963","diff_url":"https://github.com/puppetlabs/puppet/pull/6963.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/6963.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6963","number":6963,"state":"open","locked":false,"title":"(WIP) (DO NOT MERGE) (PUP-9035) Load files saved via pluginsync","user":{"login":"tvpartytonight","id":5789610,"node_id":"MDQ6VXNlcjU3ODk2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5789610?v=4","gravatar_id":"","url":"https://api.github.com/users/tvpartytonight","html_url":"https://github.com/tvpartytonight","followers_url":"https://api.github.com/users/tvpartytonight/followers","following_url":"https://api.github.com/users/tvpartytonight/following{/other_user}","gists_url":"https://api.github.com/users/tvpartytonight/gists{/gist_id}","starred_url":"https://api.github.com/users/tvpartytonight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvpartytonight/subscriptions","organizations_url":"https://api.github.com/users/tvpartytonight/orgs","repos_url":"https://api.github.com/users/tvpartytonight/repos","events_url":"https://api.github.com/users/tvpartytonight/events{/privacy}","received_events_url":"https://api.github.com/users/tvpartytonight/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-01T23:18:44Z","updated_at":"2018-08-15T15:51:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a8a0957f39c60c2c7fdf6b69c13c3309e0ddf62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thallgren","id":209495,"node_id":"MDQ6VXNlcjIwOTQ5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/209495?v=4","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/6963/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/8e6d965aa48a1401716081e3d8f6c6c5185759e4","head":{"label":"tvpartytonight:PUP-9035","ref":"PUP-9035","sha":"8e6d965aa48a1401716081e3d8f6c6c5185759e4","user":{"login":"tvpartytonight","id":5789610,"node_id":"MDQ6VXNlcjU3ODk2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5789610?v=4","gravatar_id":"","url":"https://api.github.com/users/tvpartytonight","html_url":"https://github.com/tvpartytonight","followers_url":"https://api.github.com/users/tvpartytonight/followers","following_url":"https://api.github.com/users/tvpartytonight/following{/other_user}","gists_url":"https://api.github.com/users/tvpartytonight/gists{/gist_id}","starred_url":"https://api.github.com/users/tvpartytonight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvpartytonight/subscriptions","organizations_url":"https://api.github.com/users/tvpartytonight/orgs","repos_url":"https://api.github.com/users/tvpartytonight/repos","events_url":"https://api.github.com/users/tvpartytonight/events{/privacy}","received_events_url":"https://api.github.com/users/tvpartytonight/received_events","type":"User","site_admin":false},"repo":{"id":21358090,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM1ODA5MA==","name":"puppet","full_name":"tvpartytonight/puppet","owner":{"login":"tvpartytonight","id":5789610,"node_id":"MDQ6VXNlcjU3ODk2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5789610?v=4","gravatar_id":"","url":"https://api.github.com/users/tvpartytonight","html_url":"https://github.com/tvpartytonight","followers_url":"https://api.github.com/users/tvpartytonight/followers","following_url":"https://api.github.com/users/tvpartytonight/following{/other_user}","gists_url":"https://api.github.com/users/tvpartytonight/gists{/gist_id}","starred_url":"https://api.github.com/users/tvpartytonight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvpartytonight/subscriptions","organizations_url":"https://api.github.com/users/tvpartytonight/orgs","repos_url":"https://api.github.com/users/tvpartytonight/repos","events_url":"https://api.github.com/users/tvpartytonight/events{/privacy}","received_events_url":"https://api.github.com/users/tvpartytonight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvpartytonight/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/tvpartytonight/puppet","forks_url":"https://api.github.com/repos/tvpartytonight/puppet/forks","keys_url":"https://api.github.com/repos/tvpartytonight/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvpartytonight/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvpartytonight/puppet/teams","hooks_url":"https://api.github.com/repos/tvpartytonight/puppet/hooks","issue_events_url":"https://api.github.com/repos/tvpartytonight/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/tvpartytonight/puppet/events","assignees_url":"https://api.github.com/repos/tvpartytonight/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/tvpartytonight/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/tvpartytonight/puppet/tags","blobs_url":"https://api.github.com/repos/tvpartytonight/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvpartytonight/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvpartytonight/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvpartytonight/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvpartytonight/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/tvpartytonight/puppet/languages","stargazers_url":"https://api.github.com/repos/tvpartytonight/puppet/stargazers","contributors_url":"https://api.github.com/repos/tvpartytonight/puppet/contributors","subscribers_url":"https://api.github.com/repos/tvpartytonight/puppet/subscribers","subscription_url":"https://api.github.com/repos/tvpartytonight/puppet/subscription","commits_url":"https://api.github.com/repos/tvpartytonight/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvpartytonight/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvpartytonight/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvpartytonight/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvpartytonight/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/tvpartytonight/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvpartytonight/puppet/merges","archive_url":"https://api.github.com/repos/tvpartytonight/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvpartytonight/puppet/downloads","issues_url":"https://api.github.com/repos/tvpartytonight/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/tvpartytonight/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/tvpartytonight/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/tvpartytonight/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvpartytonight/puppet/labels{/name}","releases_url":"https://api.github.com/repos/tvpartytonight/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/tvpartytonight/puppet/deployments","created_at":"2014-06-30T16:32:40Z","updated_at":"2014-06-30T16:22:10Z","pushed_at":"2018-08-14T22:41:50Z","git_url":"git://github.com/tvpartytonight/puppet.git","ssh_url":"git@github.com:tvpartytonight/puppet.git","clone_url":"https://github.com/tvpartytonight/puppet.git","svn_url":"https://github.com/tvpartytonight/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":67698,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"89c62122da9488abca3a4df9ddeaa0fdac061f21","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NDQ=","name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2018-08-15T11:13:19Z","pushed_at":"2018-08-15T15:39:58Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":67659,"stargazers_count":5053,"watchers_count":5053,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2029,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2029,"open_issues":56,"watchers":5053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/6963"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6963"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/6963/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/6963/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/8e6d965aa48a1401716081e3d8f6c6c5185759e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joshcooper"}}