{"action":"created","comment":{"url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/comments/187761565","pull_request_review_id":119613887,"id":187761565,"diff_hunk":"@@ -1007,3 +1011,9 @@ def visit_raw(self, node):\n         if 'confluence' in node.get('format', '').split():\n             self.add_text(node.astext())\n         raise nodes.SkipNode\n+\n+    def visit_todo_node(self, node):","path":"sphinxcontrib/confluencebuilder/translator/wiki.py","position":36,"original_position":36,"commit_id":"c20eb8b3914c9ed5dff310ab16cfb27ac1579ed1","original_commit_id":"c20eb8b3914c9ed5dff310ab16cfb27ac1579ed1","user":{"login":"jdknight","id":1834509,"avatar_url":"https://avatars2.githubusercontent.com/u/1834509?v=4","gravatar_id":"","url":"https://api.github.com/users/jdknight","html_url":"https://github.com/jdknight","followers_url":"https://api.github.com/users/jdknight/followers","following_url":"https://api.github.com/users/jdknight/following{/other_user}","gists_url":"https://api.github.com/users/jdknight/gists{/gist_id}","starred_url":"https://api.github.com/users/jdknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdknight/subscriptions","organizations_url":"https://api.github.com/users/jdknight/orgs","repos_url":"https://api.github.com/users/jdknight/repos","events_url":"https://api.github.com/users/jdknight/events{/privacy}","received_events_url":"https://api.github.com/users/jdknight/received_events","type":"User","site_admin":false},"body":"Since both `visit_todo_node` and `depart_todo_node` follow a non-wiki-specific pattern, these could instead be added into `translator/shared.py` instead. It may be nice to also include a comment that this is a `sphinx.ext.todo` hook instead of a standard hook.","created_at":"2018-05-12T02:08:51Z","updated_at":"2018-05-12T02:16:07Z","html_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114#discussion_r187761565","pull_request_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/comments/187761565"},"html":{"href":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114#discussion_r187761565"},"pull_request":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114","id":187452841,"html_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114","diff_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114.diff","patch_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114.patch","issue_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/114","number":114,"state":"open","locked":false,"title":"Improvements to ToDo support.","user":{"login":"papadeltasierra","id":18214079,"avatar_url":"https://avatars3.githubusercontent.com/u/18214079?v=4","gravatar_id":"","url":"https://api.github.com/users/papadeltasierra","html_url":"https://github.com/papadeltasierra","followers_url":"https://api.github.com/users/papadeltasierra/followers","following_url":"https://api.github.com/users/papadeltasierra/following{/other_user}","gists_url":"https://api.github.com/users/papadeltasierra/gists{/gist_id}","starred_url":"https://api.github.com/users/papadeltasierra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papadeltasierra/subscriptions","organizations_url":"https://api.github.com/users/papadeltasierra/orgs","repos_url":"https://api.github.com/users/papadeltasierra/repos","events_url":"https://api.github.com/users/papadeltasierra/events{/privacy}","received_events_url":"https://api.github.com/users/papadeltasierra/received_events","type":"User","site_admin":false},"body":"This fixes what appear to be some minor omissions/bugs in the ToDo support.  I am a little concerned about the Doctitle fix which seems to be needed but feels like someone should have spotted this earlier or there is something I'm missing.","created_at":"2018-05-11T12:40:55Z","updated_at":"2018-05-12T02:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"858ebc638544f0530e9e404e72ce9d70a39eb1c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114/commits","review_comments_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114/comments","review_comment_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/114/comments","statuses_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/statuses/c20eb8b3914c9ed5dff310ab16cfb27ac1579ed1","head":{"label":"papadeltasierra:pds/todo","ref":"pds/todo","sha":"c20eb8b3914c9ed5dff310ab16cfb27ac1579ed1","user":{"login":"papadeltasierra","id":18214079,"avatar_url":"https://avatars3.githubusercontent.com/u/18214079?v=4","gravatar_id":"","url":"https://api.github.com/users/papadeltasierra","html_url":"https://github.com/papadeltasierra","followers_url":"https://api.github.com/users/papadeltasierra/followers","following_url":"https://api.github.com/users/papadeltasierra/following{/other_user}","gists_url":"https://api.github.com/users/papadeltasierra/gists{/gist_id}","starred_url":"https://api.github.com/users/papadeltasierra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papadeltasierra/subscriptions","organizations_url":"https://api.github.com/users/papadeltasierra/orgs","repos_url":"https://api.github.com/users/papadeltasierra/repos","events_url":"https://api.github.com/users/papadeltasierra/events{/privacy}","received_events_url":"https://api.github.com/users/papadeltasierra/received_events","type":"User","site_admin":false},"repo":{"id":131046832,"name":"sphinxcontrib-confluencebuilder","full_name":"papadeltasierra/sphinxcontrib-confluencebuilder","owner":{"login":"papadeltasierra","id":18214079,"avatar_url":"https://avatars3.githubusercontent.com/u/18214079?v=4","gravatar_id":"","url":"https://api.github.com/users/papadeltasierra","html_url":"https://github.com/papadeltasierra","followers_url":"https://api.github.com/users/papadeltasierra/followers","following_url":"https://api.github.com/users/papadeltasierra/following{/other_user}","gists_url":"https://api.github.com/users/papadeltasierra/gists{/gist_id}","starred_url":"https://api.github.com/users/papadeltasierra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papadeltasierra/subscriptions","organizations_url":"https://api.github.com/users/papadeltasierra/orgs","repos_url":"https://api.github.com/users/papadeltasierra/repos","events_url":"https://api.github.com/users/papadeltasierra/events{/privacy}","received_events_url":"https://api.github.com/users/papadeltasierra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/papadeltasierra/sphinxcontrib-confluencebuilder","description":"A confluence wiki markup builder plugin for Sphinx","fork":true,"url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder","forks_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/forks","keys_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/teams","hooks_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/hooks","issue_events_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/events","assignees_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/tags","blobs_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/languages","stargazers_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/stargazers","contributors_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/contributors","subscribers_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/subscribers","subscription_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/subscription","commits_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/merges","archive_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/downloads","issues_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/labels{/name}","releases_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/papadeltasierra/sphinxcontrib-confluencebuilder/deployments","created_at":"2018-04-25T18:19:31Z","updated_at":"2018-04-25T18:19:33Z","pushed_at":"2018-05-11T12:36:02Z","git_url":"git://github.com/papadeltasierra/sphinxcontrib-confluencebuilder.git","ssh_url":"git@github.com:papadeltasierra/sphinxcontrib-confluencebuilder.git","clone_url":"https://github.com/papadeltasierra/sphinxcontrib-confluencebuilder.git","svn_url":"https://github.com/papadeltasierra/sphinxcontrib-confluencebuilder","homepage":null,"size":812,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tonybaloney:next","ref":"next","sha":"25d28a6ecf535e67e2d023a5a56de4427017375f","user":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars1.githubusercontent.com/u/1532417?v=4","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"repo":{"id":62764493,"name":"sphinxcontrib-confluencebuilder","full_name":"tonybaloney/sphinxcontrib-confluencebuilder","owner":{"login":"tonybaloney","id":1532417,"avatar_url":"https://avatars1.githubusercontent.com/u/1532417?v=4","gravatar_id":"","url":"https://api.github.com/users/tonybaloney","html_url":"https://github.com/tonybaloney","followers_url":"https://api.github.com/users/tonybaloney/followers","following_url":"https://api.github.com/users/tonybaloney/following{/other_user}","gists_url":"https://api.github.com/users/tonybaloney/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaloney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaloney/subscriptions","organizations_url":"https://api.github.com/users/tonybaloney/orgs","repos_url":"https://api.github.com/users/tonybaloney/repos","events_url":"https://api.github.com/users/tonybaloney/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaloney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder","description":"A confluence wiki markup builder plugin for Sphinx","fork":false,"url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder","forks_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/forks","keys_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/teams","hooks_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/hooks","issue_events_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/events","assignees_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/tags","blobs_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/languages","stargazers_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/stargazers","contributors_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/contributors","subscribers_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/subscribers","subscription_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/subscription","commits_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/merges","archive_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/downloads","issues_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/labels{/name}","releases_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/deployments","created_at":"2016-07-07T01:20:41Z","updated_at":"2018-04-22T14:54:46Z","pushed_at":"2018-05-11T12:40:55Z","git_url":"git://github.com/tonybaloney/sphinxcontrib-confluencebuilder.git","ssh_url":"git@github.com:tonybaloney/sphinxcontrib-confluencebuilder.git","clone_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder.git","svn_url":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder","homepage":null,"size":795,"stargazers_count":48,"watchers_count":48,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":19,"open_issues":9,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114"},"html":{"href":"https://github.com/tonybaloney/sphinxcontrib-confluencebuilder/pull/114"},"issue":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/114"},"comments":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/tonybaloney/sphinxcontrib-confluencebuilder/statuses/c20eb8b3914c9ed5dff310ab16cfb27ac1579ed1"}},"author_association":"NONE"}}
{"actor":{"display_login":"jdknight"}}