{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/comments/230794412","pull_request_review_id":171611682,"id":230794412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc5NDQxMg==","diff_hunk":"@@ -69,6 +72,7 @@ func (r *renderOpts) AddFlags(fs *pflag.FlagSet) {\n \tfs.StringVar(&r.lockHostPath, \"manifest-lock-host-path\", r.lockHostPath, \"A host path mounted into the apiserver pods to hold lock.\")\n \tfs.StringArrayVar(&r.etcdServerURLs, \"manifest-etcd-server-urls\", r.etcdServerURLs, \"The etcd server URL, comma separated.\")\n \tfs.StringVar(&r.etcdServingCA, \"manifest-etcd-serving-ca\", r.etcdServingCA, \"The etcd serving CA.\")\n+\tfs.StringVar(&r.configFile, \"config-file\", r.configFile, \"ClusterConfig ConfigMap file.\")","path":"cmd/cluster-kube-apiserver-operator/render/render.go","position":28,"original_position":28,"commit_id":"92d099207848f0e76f8267bc580a83b365bea9c9","original_commit_id":"92d099207848f0e76f8267bc580a83b365bea9c9","user":{"login":"sttts","id":730123,"node_id":"MDQ6VXNlcjczMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"how about `--cluster-config-file` ?","created_at":"2018-11-05T15:33:38Z","updated_at":"2018-11-05T15:33:38Z","html_url":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105#discussion_r230794412","pull_request_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/comments/230794412"},"html":{"href":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105#discussion_r230794412"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105","id":228387765,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mzg3NzY1","html_url":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105","diff_url":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105.diff","patch_url":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105.patch","issue_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/105","number":105,"state":"open","locked":false,"title":"[WIP] Render RestrictedCIDRs during bootstrapping phase","user":{"login":"damemi","id":1839101,"node_id":"MDQ6VXNlcjE4MzkxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839101?v=4","gravatar_id":"","url":"https://api.github.com/users/damemi","html_url":"https://github.com/damemi","followers_url":"https://api.github.com/users/damemi/followers","following_url":"https://api.github.com/users/damemi/following{/other_user}","gists_url":"https://api.github.com/users/damemi/gists{/gist_id}","starred_url":"https://api.github.com/users/damemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damemi/subscriptions","organizations_url":"https://api.github.com/users/damemi/orgs","repos_url":"https://api.github.com/users/damemi/repos","events_url":"https://api.github.com/users/damemi/events{/privacy}","received_events_url":"https://api.github.com/users/damemi/received_events","type":"User","site_admin":false},"body":"WIP - depends on https://github.com/openshift/library-go/pull/77 to add helpers to library-go\r\n\r\nReads `cluster-config.yaml` cluster configmap file to parse out the `PodCIDR` and `ServiceCIDR` and writes them to the config overrides for phase 1\r\n\r\nFixes https://github.com/openshift/cluster-kube-apiserver-operator/issues/83","created_at":"2018-11-05T15:20:21Z","updated_at":"2018-11-05T15:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f14d0de1bcb7a033ad65f1f09bbf1af8ccb16381","assignee":null,"assignees":[],"requested_reviewers":[{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1030587830,"node_id":"MDU6TGFiZWwxMDMwNTg3ODMw","url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":1030585803,"node_id":"MDU6TGFiZWwxMDMwNTg1ODAz","url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/105/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/statuses/92d099207848f0e76f8267bc580a83b365bea9c9","head":{"label":"damemi:render-restrictedcidrs-bootstrap","ref":"render-restrictedcidrs-bootstrap","sha":"92d099207848f0e76f8267bc580a83b365bea9c9","user":{"login":"damemi","id":1839101,"node_id":"MDQ6VXNlcjE4MzkxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839101?v=4","gravatar_id":"","url":"https://api.github.com/users/damemi","html_url":"https://github.com/damemi","followers_url":"https://api.github.com/users/damemi/followers","following_url":"https://api.github.com/users/damemi/following{/other_user}","gists_url":"https://api.github.com/users/damemi/gists{/gist_id}","starred_url":"https://api.github.com/users/damemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damemi/subscriptions","organizations_url":"https://api.github.com/users/damemi/orgs","repos_url":"https://api.github.com/users/damemi/repos","events_url":"https://api.github.com/users/damemi/events{/privacy}","received_events_url":"https://api.github.com/users/damemi/received_events","type":"User","site_admin":false},"repo":{"id":153636810,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2MzY4MTA=","name":"cluster-kube-apiserver-operator","full_name":"damemi/cluster-kube-apiserver-operator","private":false,"owner":{"login":"damemi","id":1839101,"node_id":"MDQ6VXNlcjE4MzkxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1839101?v=4","gravatar_id":"","url":"https://api.github.com/users/damemi","html_url":"https://github.com/damemi","followers_url":"https://api.github.com/users/damemi/followers","following_url":"https://api.github.com/users/damemi/following{/other_user}","gists_url":"https://api.github.com/users/damemi/gists{/gist_id}","starred_url":"https://api.github.com/users/damemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damemi/subscriptions","organizations_url":"https://api.github.com/users/damemi/orgs","repos_url":"https://api.github.com/users/damemi/repos","events_url":"https://api.github.com/users/damemi/events{/privacy}","received_events_url":"https://api.github.com/users/damemi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/damemi/cluster-kube-apiserver-operator","description":"The kube-apiserver operator installs and maintains the kube-apiserver on a cluster","fork":true,"url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator","forks_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/forks","keys_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/teams","hooks_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/hooks","issue_events_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/issues/events{/number}","events_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/events","assignees_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/assignees{/user}","branches_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/branches{/branch}","tags_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/tags","blobs_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/languages","stargazers_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/stargazers","contributors_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/contributors","subscribers_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/subscribers","subscription_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/subscription","commits_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/contents/{+path}","compare_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/merges","archive_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/downloads","issues_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/issues{/number}","pulls_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/labels{/name}","releases_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/releases{/id}","deployments_url":"https://api.github.com/repos/damemi/cluster-kube-apiserver-operator/deployments","created_at":"2018-10-18T14:23:18Z","updated_at":"2018-11-02T14:22:45Z","pushed_at":"2018-11-05T15:13:54Z","git_url":"git://github.com/damemi/cluster-kube-apiserver-operator.git","ssh_url":"git@github.com:damemi/cluster-kube-apiserver-operator.git","clone_url":"https://github.com/damemi/cluster-kube-apiserver-operator.git","svn_url":"https://github.com/damemi/cluster-kube-apiserver-operator","homepage":null,"size":15636,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"bf4d1bec5cbeef7c213ff99c31431d436448390c","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":145459709,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0NTk3MDk=","name":"cluster-kube-apiserver-operator","full_name":"openshift/cluster-kube-apiserver-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-kube-apiserver-operator","description":"The kube-apiserver operator installs and maintains the kube-apiserver on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator","forks_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/deployments","created_at":"2018-08-20T19:09:11Z","updated_at":"2018-11-05T15:31:20Z","pushed_at":"2018-11-05T15:31:17Z","git_url":"git://github.com/openshift/cluster-kube-apiserver-operator.git","ssh_url":"git@github.com:openshift/cluster-kube-apiserver-operator.git","clone_url":"https://github.com/openshift/cluster-kube-apiserver-operator.git","svn_url":"https://github.com/openshift/cluster-kube-apiserver-operator","homepage":null,"size":15653,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105"},"html":{"href":"https://github.com/openshift/cluster-kube-apiserver-operator/pull/105"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/105"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-kube-apiserver-operator/statuses/92d099207848f0e76f8267bc580a83b365bea9c9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sttts"}}