{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/167942610","pull_request_review_id":96232531,"id":167942610,"diff_hunk":"@@ -41,6 +41,12 @@ options:\n     default: \"\"\n     description: |\n       Password to be used for admin user (leave empty for random password).\n+  grafana-www-root:\n+    type: string\n+    default: \"/api/v1/proxy/namespaces/kube-system/services/monitoring-grafana/\"\n+    description: |\n+      Set this to \"/\" if you plan to expose the grafana used for cluster monitoring.\n+      The default value is for accessing the service through kubectl proxy.","path":"cluster/juju/layers/kubernetes-master/config.yaml","position":9,"original_position":9,"commit_id":"3777d9bc00e00f6819e68ddeb95e113522ea8395","original_commit_id":"3777d9bc00e00f6819e68ddeb95e113522ea8395","user":{"login":"Cynerva","id":2251600,"avatar_url":"https://avatars0.githubusercontent.com/u/2251600?v=4","gravatar_id":"","url":"https://api.github.com/users/Cynerva","html_url":"https://github.com/Cynerva","followers_url":"https://api.github.com/users/Cynerva/followers","following_url":"https://api.github.com/users/Cynerva/following{/other_user}","gists_url":"https://api.github.com/users/Cynerva/gists{/gist_id}","starred_url":"https://api.github.com/users/Cynerva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cynerva/subscriptions","organizations_url":"https://api.github.com/users/Cynerva/orgs","repos_url":"https://api.github.com/users/Cynerva/repos","events_url":"https://api.github.com/users/Cynerva/events{/privacy}","received_events_url":"https://api.github.com/users/Cynerva/received_events","type":"User","site_admin":false},"body":"Do we need this? I'm worried about accumulating a lot of configuration options that we can't keep up with.\r\n\r\nWe want to empower users to set things up however they like, but I'm not sure this particular config is worth the maintenance burden, considering they have another option: set `enable-dashboard-addons=false` and deploy their own Grafana.\r\n\r\nIf we can, I would rather say that the Grafana shipped with CDK is only available via the apiserver at `/api/v1/proxy/namespaces/kube-system/services/monitoring-grafana/`.","created_at":"2018-02-13T17:36:56Z","updated_at":"2018-02-13T17:36:57Z","html_url":"https://github.com/kubernetes/kubernetes/pull/59810#discussion_r167942610","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/167942610"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59810#discussion_r167942610"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810","id":168887996,"html_url":"https://github.com/kubernetes/kubernetes/pull/59810","diff_url":"https://github.com/kubernetes/kubernetes/pull/59810.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59810.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59810","number":59810,"state":"open","locked":false,"title":"Make grafana root url configurable in Juju deployments","user":{"login":"ktsakalozos","id":11489452,"avatar_url":"https://avatars2.githubusercontent.com/u/11489452?v=4","gravatar_id":"","url":"https://api.github.com/users/ktsakalozos","html_url":"https://github.com/ktsakalozos","followers_url":"https://api.github.com/users/ktsakalozos/followers","following_url":"https://api.github.com/users/ktsakalozos/following{/other_user}","gists_url":"https://api.github.com/users/ktsakalozos/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsakalozos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsakalozos/subscriptions","organizations_url":"https://api.github.com/users/ktsakalozos/orgs","repos_url":"https://api.github.com/users/ktsakalozos/repos","events_url":"https://api.github.com/users/ktsakalozos/events{/privacy}","received_events_url":"https://api.github.com/users/ktsakalozos/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: With this patch we are able to point grafana resources to wherever we need grafana to be available from. \r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**: This PR has to be merged along with https://github.com/juju-solutions/cdk-addons/pull/26\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-02-13T16:13:32Z","updated_at":"2018-02-13T17:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efc4633062ca16fb82a11de8ef92d134bbc92941","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59810/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3777d9bc00e00f6819e68ddeb95e113522ea8395","head":{"label":"juju-solutions:feature/grafana-www","ref":"feature/grafana-www","sha":"3777d9bc00e00f6819e68ddeb95e113522ea8395","user":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars1.githubusercontent.com/u/8684561?v=4","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":66970811,"name":"kubernetes","full_name":"juju-solutions/kubernetes","owner":{"login":"juju-solutions","id":8684561,"avatar_url":"https://avatars1.githubusercontent.com/u/8684561?v=4","gravatar_id":"","url":"https://api.github.com/users/juju-solutions","html_url":"https://github.com/juju-solutions","followers_url":"https://api.github.com/users/juju-solutions/followers","following_url":"https://api.github.com/users/juju-solutions/following{/other_user}","gists_url":"https://api.github.com/users/juju-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/juju-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju-solutions/subscriptions","organizations_url":"https://api.github.com/users/juju-solutions/orgs","repos_url":"https://api.github.com/users/juju-solutions/repos","events_url":"https://api.github.com/users/juju-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/juju-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju-solutions/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/juju-solutions/kubernetes","forks_url":"https://api.github.com/repos/juju-solutions/kubernetes/forks","keys_url":"https://api.github.com/repos/juju-solutions/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju-solutions/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju-solutions/kubernetes/teams","hooks_url":"https://api.github.com/repos/juju-solutions/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/juju-solutions/kubernetes/events","assignees_url":"https://api.github.com/repos/juju-solutions/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/juju-solutions/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/juju-solutions/kubernetes/tags","blobs_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju-solutions/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/juju-solutions/kubernetes/languages","stargazers_url":"https://api.github.com/repos/juju-solutions/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/juju-solutions/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/juju-solutions/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/juju-solutions/kubernetes/subscription","commits_url":"https://api.github.com/repos/juju-solutions/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju-solutions/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju-solutions/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju-solutions/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/juju-solutions/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju-solutions/kubernetes/merges","archive_url":"https://api.github.com/repos/juju-solutions/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju-solutions/kubernetes/downloads","issues_url":"https://api.github.com/repos/juju-solutions/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/juju-solutions/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/juju-solutions/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/juju-solutions/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju-solutions/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/juju-solutions/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/juju-solutions/kubernetes/deployments","created_at":"2016-08-30T19:24:00Z","updated_at":"2016-08-30T19:24:34Z","pushed_at":"2018-02-13T16:11:47Z","git_url":"git://github.com/juju-solutions/kubernetes.git","ssh_url":"git@github.com:juju-solutions/kubernetes.git","clone_url":"https://github.com/juju-solutions/kubernetes.git","svn_url":"https://github.com/juju-solutions/kubernetes","homepage":"http://kubernetes.io","size":528690,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"01bd3c4b743137f62b00d21ecd6f1559470de92f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-13T17:26:35Z","pushed_at":"2018-02-13T17:30:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":752728,"stargazers_count":32515,"watchers_count":32515,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11486,"mirror_url":null,"archived":false,"open_issues_count":5155,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11486,"open_issues":5155,"watchers":32515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59810"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59810"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59810/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59810/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3777d9bc00e00f6819e68ddeb95e113522ea8395"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Cynerva"}}