{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/615","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/615/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/615/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/615/events","html_url":"https://github.com/openjournals/joss-reviews/issues/615","id":304423314,"number":615,"title":"[REVIEW]: Optim: An optimization package for Julia","user":{"login":"whedon","id":18508068,"avatar_url":"https://avatars3.githubusercontent.com/u/18508068?v=4","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"id":330465313,"url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"labarba","id":4800109,"avatar_url":"https://avatars0.githubusercontent.com/u/4800109?v=4","gravatar_id":"","url":"https://api.github.com/users/labarba","html_url":"https://github.com/labarba","followers_url":"https://api.github.com/users/labarba/followers","following_url":"https://api.github.com/users/labarba/following{/other_user}","gists_url":"https://api.github.com/users/labarba/gists{/gist_id}","starred_url":"https://api.github.com/users/labarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labarba/subscriptions","organizations_url":"https://api.github.com/users/labarba/orgs","repos_url":"https://api.github.com/users/labarba/repos","events_url":"https://api.github.com/users/labarba/events{/privacy}","received_events_url":"https://api.github.com/users/labarba/received_events","type":"User","site_admin":false},"assignees":[{"login":"labarba","id":4800109,"avatar_url":"https://avatars0.githubusercontent.com/u/4800109?v=4","gravatar_id":"","url":"https://api.github.com/users/labarba","html_url":"https://github.com/labarba","followers_url":"https://api.github.com/users/labarba/followers","following_url":"https://api.github.com/users/labarba/following{/other_user}","gists_url":"https://api.github.com/users/labarba/gists{/gist_id}","starred_url":"https://api.github.com/users/labarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labarba/subscriptions","organizations_url":"https://api.github.com/users/labarba/orgs","repos_url":"https://api.github.com/users/labarba/repos","events_url":"https://api.github.com/users/labarba/events{/privacy}","received_events_url":"https://api.github.com/users/labarba/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2018-03-12T15:35:57Z","updated_at":"2018-03-19T19:47:15Z","closed_at":null,"author_association":"COLLABORATOR","body":"**Submitting author:** @anriseth (<a href=\"http://orcid.org/0000-0002-5861-7885\">Asbjørn Nilsen Riseth</a>)\r\n**Repository:** <a href=\"https://github.com/JuliaNLSolvers/Optim.jl\" target =\"_blank\">https://github.com/JuliaNLSolvers/Optim.jl</a>\r\n**Version:** v0.14.0\r\n**Editor:** @labarba\r\n**Reviewer:** @ahwillia\r\n**Archive:** Pending\r\n\r\n## Status\r\n\r\n[![status](http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2/status.svg)](http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2\"><img src=\"http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2/status.svg\"></a>\r\nMarkdown: [![status](http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2/status.svg)](http://joss.theoj.org/papers/ccd4ac7b58bbb2c577866594733968f2)\r\n```\r\n**Reviewers and authors**:\r\n\r\nPlease avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the <a href=\"https://github.com/JuliaNLSolvers/Optim.jl\" target=\"_blank\">target repository</a> and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)\r\n\r\n## Reviewer instructions & questions\r\n\r\n@ahwillia, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:\r\n1. Make sure you're logged in to your GitHub account\r\n2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations\r\n\r\nThe reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @labarba know.\r\n\r\n  ### Conflict of interest\r\n\r\n- [x] As the reviewer I confirm that I have read the [JOSS conflict of interest policy](https://github.com/openjournals/joss/blob/master/COI.md) and that there are no conflicts of interest for me to review this work.\r\n\r\n### Code of Conduct\r\n\r\n- [x] I confirm that I read and will adhere to the [JOSS code of conduct](https://joss.theoj.org/about#code_of_conduct).\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/JuliaNLSolvers/Optim.jl\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v0.14.0)?\r\n- [x] **Authorship:** Has the submitting author (@anriseth) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [x] **Performance:** If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **References:** Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/374346077","html_url":"https://github.com/openjournals/joss-reviews/issues/615#issuecomment-374346077","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/615","id":374346077,"user":{"login":"ahwillia","id":636625,"avatar_url":"https://avatars3.githubusercontent.com/u/636625?v=4","gravatar_id":"","url":"https://api.github.com/users/ahwillia","html_url":"https://github.com/ahwillia","followers_url":"https://api.github.com/users/ahwillia/followers","following_url":"https://api.github.com/users/ahwillia/following{/other_user}","gists_url":"https://api.github.com/users/ahwillia/gists{/gist_id}","starred_url":"https://api.github.com/users/ahwillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahwillia/subscriptions","organizations_url":"https://api.github.com/users/ahwillia/orgs","repos_url":"https://api.github.com/users/ahwillia/repos","events_url":"https://api.github.com/users/ahwillia/events{/privacy}","received_events_url":"https://api.github.com/users/ahwillia/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T19:47:14Z","updated_at":"2018-03-19T19:47:14Z","author_association":"COLLABORATOR","body":"Yes I recommend acceptance.\n\nOn Mar 19, 2018 12:39 PM, \"Lorena A. Barba\" <notifications@github.com>\nwrote:\n\nI see that both reviewers have checked off all items in the review\nchecklist.\n\nCan I have confirmation that the reviewers recommend acceptance?\n@abelsiqueira <https://github.com/abelsiqueira> @ahwillia\n<https://github.com/ahwillia> ?\n\nAlso, can I have confirmation from the authors that they've finished\nworking on it?\n@anriseth <https://github.com/anriseth>\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub\n<https://github.com/openjournals/joss-reviews/issues/615#issuecomment-374342839>,\nor mute the thread\n<https://github.com/notifications/unsubscribe-auth/AAm20UaRny6sX_6jQKkoo03WG8Xqg0TIks5tgAlVgaJpZM4Sm3fC>\n.\n"}}
{"actor":{"display_login":"ahwillia"}}