{"action":"opened","number":1005,"pull_request":{"url":"https://api.github.com/repos/angular/universal/pulls/1005","id":192220150,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjIwMTUw","html_url":"https://github.com/angular/universal/pull/1005","diff_url":"https://github.com/angular/universal/pull/1005.diff","patch_url":"https://github.com/angular/universal/pull/1005.patch","issue_url":"https://api.github.com/repos/angular/universal/issues/1005","number":1005,"state":"open","locked":false,"title":"feat(common): TransferHttpCache now respects url params","user":{"login":"Toxicable","id":13490925,"node_id":"MDQ6VXNlcjEzNDkwOTI1","avatar_url":"https://avatars3.githubusercontent.com/u/13490925?v=4","gravatar_id":"","url":"https://api.github.com/users/Toxicable","html_url":"https://github.com/Toxicable","followers_url":"https://api.github.com/users/Toxicable/followers","following_url":"https://api.github.com/users/Toxicable/following{/other_user}","gists_url":"https://api.github.com/users/Toxicable/gists{/gist_id}","starred_url":"https://api.github.com/users/Toxicable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toxicable/subscriptions","organizations_url":"https://api.github.com/users/Toxicable/orgs","repos_url":"https://api.github.com/users/Toxicable/repos","events_url":"https://api.github.com/users/Toxicable/events{/privacy}","received_events_url":"https://api.github.com/users/Toxicable/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Feature\r\n```\r\n\r\n## What is the current behavior?\r\nTransferHttpCache does not respect url params  \r\nIssue Number: https://github.com/angular/universal/issues/927\r\n\r\n\r\n## What is the new behavior?\r\nNow respects params \r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[x] Yes\r\n[ ] No\r\n```\r\n\r\n## Other information\r\nTechnically this is a breaking change since \r\nbefore:\r\n/my/url?key=value\r\n/my/url\r\nBoth of these would override each others values in the cache\r\nBut now they'd have their own cache\r\n","created_at":"2018-06-02T22:11:33Z","updated_at":"2018-06-02T22:11:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/universal/pulls/1005/commits","review_comments_url":"https://api.github.com/repos/angular/universal/pulls/1005/comments","review_comment_url":"https://api.github.com/repos/angular/universal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/universal/issues/1005/comments","statuses_url":"https://api.github.com/repos/angular/universal/statuses/19228eabc80905a8364d28ee0715449255f26945","head":{"label":"angular:fabian/cache-params","ref":"fabian/cache-params","sha":"19228eabc80905a8364d28ee0715449255f26945","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":37953959,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk1Mzk1OQ==","name":"universal","full_name":"angular/universal","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/universal","description":"Universal javascript support for Angular","fork":false,"url":"https://api.github.com/repos/angular/universal","forks_url":"https://api.github.com/repos/angular/universal/forks","keys_url":"https://api.github.com/repos/angular/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/universal/teams","hooks_url":"https://api.github.com/repos/angular/universal/hooks","issue_events_url":"https://api.github.com/repos/angular/universal/issues/events{/number}","events_url":"https://api.github.com/repos/angular/universal/events","assignees_url":"https://api.github.com/repos/angular/universal/assignees{/user}","branches_url":"https://api.github.com/repos/angular/universal/branches{/branch}","tags_url":"https://api.github.com/repos/angular/universal/tags","blobs_url":"https://api.github.com/repos/angular/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/universal/languages","stargazers_url":"https://api.github.com/repos/angular/universal/stargazers","contributors_url":"https://api.github.com/repos/angular/universal/contributors","subscribers_url":"https://api.github.com/repos/angular/universal/subscribers","subscription_url":"https://api.github.com/repos/angular/universal/subscription","commits_url":"https://api.github.com/repos/angular/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/universal/contents/{+path}","compare_url":"https://api.github.com/repos/angular/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/universal/merges","archive_url":"https://api.github.com/repos/angular/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/universal/downloads","issues_url":"https://api.github.com/repos/angular/universal/issues{/number}","pulls_url":"https://api.github.com/repos/angular/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/universal/labels{/name}","releases_url":"https://api.github.com/repos/angular/universal/releases{/id}","deployments_url":"https://api.github.com/repos/angular/universal/deployments","created_at":"2015-06-24T01:07:44Z","updated_at":"2018-06-01T21:14:23Z","pushed_at":"2018-06-02T22:08:45Z","git_url":"git://github.com/angular/universal.git","ssh_url":"git@github.com:angular/universal.git","clone_url":"https://github.com/angular/universal.git","svn_url":"https://github.com/angular/universal","homepage":"","size":4474,"stargazers_count":3000,"watchers_count":3000,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":362,"open_issues":41,"watchers":3000,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"4dd9ac34d349f81027872991d2bac34cba7c8f7d","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":37953959,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk1Mzk1OQ==","name":"universal","full_name":"angular/universal","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/universal","description":"Universal javascript support for Angular","fork":false,"url":"https://api.github.com/repos/angular/universal","forks_url":"https://api.github.com/repos/angular/universal/forks","keys_url":"https://api.github.com/repos/angular/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/universal/teams","hooks_url":"https://api.github.com/repos/angular/universal/hooks","issue_events_url":"https://api.github.com/repos/angular/universal/issues/events{/number}","events_url":"https://api.github.com/repos/angular/universal/events","assignees_url":"https://api.github.com/repos/angular/universal/assignees{/user}","branches_url":"https://api.github.com/repos/angular/universal/branches{/branch}","tags_url":"https://api.github.com/repos/angular/universal/tags","blobs_url":"https://api.github.com/repos/angular/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/universal/languages","stargazers_url":"https://api.github.com/repos/angular/universal/stargazers","contributors_url":"https://api.github.com/repos/angular/universal/contributors","subscribers_url":"https://api.github.com/repos/angular/universal/subscribers","subscription_url":"https://api.github.com/repos/angular/universal/subscription","commits_url":"https://api.github.com/repos/angular/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/universal/contents/{+path}","compare_url":"https://api.github.com/repos/angular/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/universal/merges","archive_url":"https://api.github.com/repos/angular/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/universal/downloads","issues_url":"https://api.github.com/repos/angular/universal/issues{/number}","pulls_url":"https://api.github.com/repos/angular/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/universal/labels{/name}","releases_url":"https://api.github.com/repos/angular/universal/releases{/id}","deployments_url":"https://api.github.com/repos/angular/universal/deployments","created_at":"2015-06-24T01:07:44Z","updated_at":"2018-06-01T21:14:23Z","pushed_at":"2018-06-02T22:08:45Z","git_url":"git://github.com/angular/universal.git","ssh_url":"git@github.com:angular/universal.git","clone_url":"https://github.com/angular/universal.git","svn_url":"https://github.com/angular/universal","homepage":"","size":4474,"stargazers_count":3000,"watchers_count":3000,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":362,"open_issues":41,"watchers":3000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/universal/pulls/1005"},"html":{"href":"https://github.com/angular/universal/pull/1005"},"issue":{"href":"https://api.github.com/repos/angular/universal/issues/1005"},"comments":{"href":"https://api.github.com/repos/angular/universal/issues/1005/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/universal/pulls/1005/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/universal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/universal/pulls/1005/commits"},"statuses":{"href":"https://api.github.com/repos/angular/universal/statuses/19228eabc80905a8364d28ee0715449255f26945"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"Toxicable"}}