{"action":"created","issue":{"url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/11","repository_url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL","labels_url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/11/comments","events_url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/11/events","html_url":"https://github.com/Small-Bodies-Node/PDS4-IDL/issues/11","id":349110139,"node_id":"MDU6SXNzdWUzNDkxMTAxMzk=","number":11,"title":"Problem reading PDS4 file with skipped byte in record line","user":{"login":"kalosma","id":17494757,"node_id":"MDQ6VXNlcjE3NDk0NzU3","avatar_url":"https://avatars2.githubusercontent.com/u/17494757?v=4","gravatar_id":"","url":"https://api.github.com/users/kalosma","html_url":"https://github.com/kalosma","followers_url":"https://api.github.com/users/kalosma/followers","following_url":"https://api.github.com/users/kalosma/following{/other_user}","gists_url":"https://api.github.com/users/kalosma/gists{/gist_id}","starred_url":"https://api.github.com/users/kalosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalosma/subscriptions","organizations_url":"https://api.github.com/users/kalosma/orgs","repos_url":"https://api.github.com/users/kalosma/repos","events_url":"https://api.github.com/users/kalosma/events{/privacy}","received_events_url":"https://api.github.com/users/kalosma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T12:40:22Z","updated_at":"2018-08-22T17:33:09Z","closed_at":null,"author_association":"NONE","body":"We are using the PDS4-IDL code for reading some PDS4 files we are creating.\r\nWe have been able to read those products in the past, but then we had to make a change to a DateTime field because it had a bad format, it had a space in the middle between date and time (e.g. 2011-04-10 00:31:05.694), so we splitted it into two fields, one for the DATE and one for the TIME. The date field \"ends\" before the space while the time field starts after the space (e.g. time field finishes @byte 65574 while date field starts @byte 65576).\r\n\r\n```\r\n[...]\r\n<Field_Binary>\r\n                    <name>UTC_MIDPOINT_MET_DATE</name>\r\n                    <field_number>11</field_number>\r\n                    <field_location unit=\"byte\">65565</field_location>\r\n                    <data_type>ASCII_Date_YMD</data_type>\r\n                    <field_length unit=\"byte\">10</field_length>                \r\n                    <description>MIDPOINT_MET converted to UTC Date, stored as\r\n                        yyyy-mm-dd</description>\r\n</Field_Binary>\r\n<Field_Binary>\r\n                    <name>UTC_MIDPOINT_MET_TIME</name>\r\n                    <field_number>12</field_number>\r\n                    <field_location unit=\"byte\">65576</field_location>\r\n                    <data_type>ASCII_Time</data_type>\r\n                    <field_length unit=\"byte\">12</field_length>                \r\n                    <description>MIDPOINT_MET converted to UTC Time, stored as\r\n                        hh:mm:ss.sss</description>\r\n</Field_Binary>\r\n[...]\r\n```\r\n\r\nThere is a byte in the middle between Date and Time that is skippied because not needed. That is causing issues with the pds_read IDL code. \r\n\r\nPlease can you fix this issue?\r\n\r\nHere is a sample product.\r\n[sample.zip](https://github.com/Small-Bodies-Node/PDS4-IDL/files/2274158/sample.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/comments/415114502","html_url":"https://github.com/Small-Bodies-Node/PDS4-IDL/issues/11#issuecomment-415114502","issue_url":"https://api.github.com/repos/Small-Bodies-Node/PDS4-IDL/issues/11","id":415114502,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTExNDUwMg==","user":{"login":"eshaya","id":12628590,"node_id":"MDQ6VXNlcjEyNjI4NTkw","avatar_url":"https://avatars1.githubusercontent.com/u/12628590?v=4","gravatar_id":"","url":"https://api.github.com/users/eshaya","html_url":"https://github.com/eshaya","followers_url":"https://api.github.com/users/eshaya/followers","following_url":"https://api.github.com/users/eshaya/following{/other_user}","gists_url":"https://api.github.com/users/eshaya/gists{/gist_id}","starred_url":"https://api.github.com/users/eshaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshaya/subscriptions","organizations_url":"https://api.github.com/users/eshaya/orgs","repos_url":"https://api.github.com/users/eshaya/repos","events_url":"https://api.github.com/users/eshaya/events{/privacy}","received_events_url":"https://api.github.com/users/eshaya/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T17:33:09Z","updated_at":"2018-08-22T17:33:09Z","author_association":"CONTRIBUTOR","body":"Yes,  I plan on looking at this and fixing it.  I have been putting out \nseveral other fires lately, but I may get to it today.\n\nEd\n\n\n\nOn 8/22/2018 11:45 AM, Michael Kelley wrote:\n>\n> Thanks, @LevN0 <https://github.com/LevN0> .\n>\n> I checked with our standards expert, having dead bytes in the file is \n> allowed but not recommended. But because it is allowed, we should \n> still address the issue.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/Small-Bodies-Node/PDS4-IDL/issues/11#issuecomment-415079394>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/AMCybpz4iWbeIpVFnMrXQSJutpGzMmS9ks5uTXydgaJpZM4V1nlD>.\n>\n\n"}}
{"actor":{"display_login":"eshaya"}}