{"action":"created","comment":{"url":"https://api.github.com/repos/tophernuts/rails/pulls/comments/205915945","pull_request_review_id":141288730,"id":205915945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkxNTk0NQ==","diff_hunk":"@@ -136,55 +223,122 @@ def self.const_missing(const_name)\n     #   class Person < ActiveRecord::Base\n     #   end\n     #\n-    #   params = ActionController::Parameters.new(name: 'Francesco')\n+    #   params = ActionController::Parameters.new(name: \"Francesco\")\n     #   params.permitted?  # => false\n     #   Person.new(params) # => ActiveModel::ForbiddenAttributesError\n     #\n     #   ActionController::Parameters.permit_all_parameters = true\n     #\n-    #   params = ActionController::Parameters.new(name: 'Francesco')\n+    #   params = ActionController::Parameters.new(name: \"Francesco\")\n     #   params.permitted?  # => true\n     #   Person.new(params) # => #<Person id: nil, name: \"Francesco\">\n-    def initialize(attributes = nil)\n-      super(attributes)\n-      @permitted = self.class.permit_all_parameters\n+    def initialize(parameters = {})\n+      @parameters = parameters.with_indifferent_access\n+      # @permitted = self.class.permit_all_parameters\n+      @permitted = true","path":"actionpack/lib/action_controller/metal/strong_parameters.rb","position":257,"original_position":257,"commit_id":"b5de331557e31761b0405d82ca23bbe4146be318","original_commit_id":"b5de331557e31761b0405d82ca23bbe4146be318","user":{"login":"seanhealy","id":131327,"node_id":"MDQ6VXNlcjEzMTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/131327?v=4","gravatar_id":"","url":"https://api.github.com/users/seanhealy","html_url":"https://github.com/seanhealy","followers_url":"https://api.github.com/users/seanhealy/followers","following_url":"https://api.github.com/users/seanhealy/following{/other_user}","gists_url":"https://api.github.com/users/seanhealy/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhealy/subscriptions","organizations_url":"https://api.github.com/users/seanhealy/orgs","repos_url":"https://api.github.com/users/seanhealy/repos","events_url":"https://api.github.com/users/seanhealy/events{/privacy}","received_events_url":"https://api.github.com/users/seanhealy/received_events","type":"User","site_admin":false},"body":"EVERYTHING IS PERMITTED NOW!","created_at":"2018-07-27T22:42:28Z","updated_at":"2018-07-27T22:42:28Z","html_url":"https://github.com/tophernuts/rails/pull/2#discussion_r205915945","pull_request_url":"https://api.github.com/repos/tophernuts/rails/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/comments/205915945"},"html":{"href":"https://github.com/tophernuts/rails/pull/2#discussion_r205915945"},"pull_request":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/tophernuts/rails/pulls/2","id":204547070,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTQ3MDcw","html_url":"https://github.com/tophernuts/rails/pull/2","diff_url":"https://github.com/tophernuts/rails/pull/2.diff","patch_url":"https://github.com/tophernuts/rails/pull/2.patch","issue_url":"https://api.github.com/repos/tophernuts/rails/issues/2","number":2,"state":"open","locked":false,"title":"use-new-strong_params","user":{"login":"seanhealy","id":131327,"node_id":"MDQ6VXNlcjEzMTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/131327?v=4","gravatar_id":"","url":"https://api.github.com/users/seanhealy","html_url":"https://github.com/seanhealy","followers_url":"https://api.github.com/users/seanhealy/followers","following_url":"https://api.github.com/users/seanhealy/following{/other_user}","gists_url":"https://api.github.com/users/seanhealy/gists{/gist_id}","starred_url":"https://api.github.com/users/seanhealy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanhealy/subscriptions","organizations_url":"https://api.github.com/users/seanhealy/orgs","repos_url":"https://api.github.com/users/seanhealy/repos","events_url":"https://api.github.com/users/seanhealy/events{/privacy}","received_events_url":"https://api.github.com/users/seanhealy/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nLets try moving this to use the whole new `actionpack/lib/action_controller/metal/strong_parameters.rb`.","created_at":"2018-07-27T21:45:42Z","updated_at":"2018-07-27T22:42:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ea02e3f280ca083cc82ce51717dec8e79c2d5bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tophernuts/rails/pulls/2/commits","review_comments_url":"https://api.github.com/repos/tophernuts/rails/pulls/2/comments","review_comment_url":"https://api.github.com/repos/tophernuts/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tophernuts/rails/issues/2/comments","statuses_url":"https://api.github.com/repos/tophernuts/rails/statuses/b5de331557e31761b0405d82ca23bbe4146be318","head":{"label":"tophernuts:use-new-strong_params","ref":"use-new-strong_params","sha":"b5de331557e31761b0405d82ca23bbe4146be318","user":{"login":"tophernuts","id":4359781,"node_id":"MDQ6VXNlcjQzNTk3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/4359781?v=4","gravatar_id":"","url":"https://api.github.com/users/tophernuts","html_url":"https://github.com/tophernuts","followers_url":"https://api.github.com/users/tophernuts/followers","following_url":"https://api.github.com/users/tophernuts/following{/other_user}","gists_url":"https://api.github.com/users/tophernuts/gists{/gist_id}","starred_url":"https://api.github.com/users/tophernuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophernuts/subscriptions","organizations_url":"https://api.github.com/users/tophernuts/orgs","repos_url":"https://api.github.com/users/tophernuts/repos","events_url":"https://api.github.com/users/tophernuts/events{/privacy}","received_events_url":"https://api.github.com/users/tophernuts/received_events","type":"User","site_admin":false},"repo":{"id":142616552,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MTY1NTI=","name":"rails","full_name":"tophernuts/rails","owner":{"login":"tophernuts","id":4359781,"node_id":"MDQ6VXNlcjQzNTk3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/4359781?v=4","gravatar_id":"","url":"https://api.github.com/users/tophernuts","html_url":"https://github.com/tophernuts","followers_url":"https://api.github.com/users/tophernuts/followers","following_url":"https://api.github.com/users/tophernuts/following{/other_user}","gists_url":"https://api.github.com/users/tophernuts/gists{/gist_id}","starred_url":"https://api.github.com/users/tophernuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophernuts/subscriptions","organizations_url":"https://api.github.com/users/tophernuts/orgs","repos_url":"https://api.github.com/users/tophernuts/repos","events_url":"https://api.github.com/users/tophernuts/events{/privacy}","received_events_url":"https://api.github.com/users/tophernuts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tophernuts/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/tophernuts/rails","forks_url":"https://api.github.com/repos/tophernuts/rails/forks","keys_url":"https://api.github.com/repos/tophernuts/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tophernuts/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tophernuts/rails/teams","hooks_url":"https://api.github.com/repos/tophernuts/rails/hooks","issue_events_url":"https://api.github.com/repos/tophernuts/rails/issues/events{/number}","events_url":"https://api.github.com/repos/tophernuts/rails/events","assignees_url":"https://api.github.com/repos/tophernuts/rails/assignees{/user}","branches_url":"https://api.github.com/repos/tophernuts/rails/branches{/branch}","tags_url":"https://api.github.com/repos/tophernuts/rails/tags","blobs_url":"https://api.github.com/repos/tophernuts/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tophernuts/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tophernuts/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/tophernuts/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tophernuts/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/tophernuts/rails/languages","stargazers_url":"https://api.github.com/repos/tophernuts/rails/stargazers","contributors_url":"https://api.github.com/repos/tophernuts/rails/contributors","subscribers_url":"https://api.github.com/repos/tophernuts/rails/subscribers","subscription_url":"https://api.github.com/repos/tophernuts/rails/subscription","commits_url":"https://api.github.com/repos/tophernuts/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/tophernuts/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/tophernuts/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/tophernuts/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/tophernuts/rails/contents/{+path}","compare_url":"https://api.github.com/repos/tophernuts/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tophernuts/rails/merges","archive_url":"https://api.github.com/repos/tophernuts/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tophernuts/rails/downloads","issues_url":"https://api.github.com/repos/tophernuts/rails/issues{/number}","pulls_url":"https://api.github.com/repos/tophernuts/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/tophernuts/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/tophernuts/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tophernuts/rails/labels{/name}","releases_url":"https://api.github.com/repos/tophernuts/rails/releases{/id}","deployments_url":"https://api.github.com/repos/tophernuts/rails/deployments","created_at":"2018-07-27T19:33:19Z","updated_at":"2018-07-27T19:33:39Z","pushed_at":"2018-07-27T22:35:31Z","git_url":"git://github.com/tophernuts/rails.git","ssh_url":"git@github.com:tophernuts/rails.git","clone_url":"https://github.com/tophernuts/rails.git","svn_url":"https://github.com/tophernuts/rails","homepage":"http://rubyonrails.org","size":164737,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tophernuts:4-2-stable","ref":"4-2-stable","sha":"3804d017333da16d76d9fc6633faf5635c7b03d7","user":{"login":"tophernuts","id":4359781,"node_id":"MDQ6VXNlcjQzNTk3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/4359781?v=4","gravatar_id":"","url":"https://api.github.com/users/tophernuts","html_url":"https://github.com/tophernuts","followers_url":"https://api.github.com/users/tophernuts/followers","following_url":"https://api.github.com/users/tophernuts/following{/other_user}","gists_url":"https://api.github.com/users/tophernuts/gists{/gist_id}","starred_url":"https://api.github.com/users/tophernuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophernuts/subscriptions","organizations_url":"https://api.github.com/users/tophernuts/orgs","repos_url":"https://api.github.com/users/tophernuts/repos","events_url":"https://api.github.com/users/tophernuts/events{/privacy}","received_events_url":"https://api.github.com/users/tophernuts/received_events","type":"User","site_admin":false},"repo":{"id":142616552,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MTY1NTI=","name":"rails","full_name":"tophernuts/rails","owner":{"login":"tophernuts","id":4359781,"node_id":"MDQ6VXNlcjQzNTk3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/4359781?v=4","gravatar_id":"","url":"https://api.github.com/users/tophernuts","html_url":"https://github.com/tophernuts","followers_url":"https://api.github.com/users/tophernuts/followers","following_url":"https://api.github.com/users/tophernuts/following{/other_user}","gists_url":"https://api.github.com/users/tophernuts/gists{/gist_id}","starred_url":"https://api.github.com/users/tophernuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tophernuts/subscriptions","organizations_url":"https://api.github.com/users/tophernuts/orgs","repos_url":"https://api.github.com/users/tophernuts/repos","events_url":"https://api.github.com/users/tophernuts/events{/privacy}","received_events_url":"https://api.github.com/users/tophernuts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tophernuts/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/tophernuts/rails","forks_url":"https://api.github.com/repos/tophernuts/rails/forks","keys_url":"https://api.github.com/repos/tophernuts/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tophernuts/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tophernuts/rails/teams","hooks_url":"https://api.github.com/repos/tophernuts/rails/hooks","issue_events_url":"https://api.github.com/repos/tophernuts/rails/issues/events{/number}","events_url":"https://api.github.com/repos/tophernuts/rails/events","assignees_url":"https://api.github.com/repos/tophernuts/rails/assignees{/user}","branches_url":"https://api.github.com/repos/tophernuts/rails/branches{/branch}","tags_url":"https://api.github.com/repos/tophernuts/rails/tags","blobs_url":"https://api.github.com/repos/tophernuts/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tophernuts/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tophernuts/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/tophernuts/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tophernuts/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/tophernuts/rails/languages","stargazers_url":"https://api.github.com/repos/tophernuts/rails/stargazers","contributors_url":"https://api.github.com/repos/tophernuts/rails/contributors","subscribers_url":"https://api.github.com/repos/tophernuts/rails/subscribers","subscription_url":"https://api.github.com/repos/tophernuts/rails/subscription","commits_url":"https://api.github.com/repos/tophernuts/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/tophernuts/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/tophernuts/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/tophernuts/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/tophernuts/rails/contents/{+path}","compare_url":"https://api.github.com/repos/tophernuts/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tophernuts/rails/merges","archive_url":"https://api.github.com/repos/tophernuts/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tophernuts/rails/downloads","issues_url":"https://api.github.com/repos/tophernuts/rails/issues{/number}","pulls_url":"https://api.github.com/repos/tophernuts/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/tophernuts/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/tophernuts/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tophernuts/rails/labels{/name}","releases_url":"https://api.github.com/repos/tophernuts/rails/releases{/id}","deployments_url":"https://api.github.com/repos/tophernuts/rails/deployments","created_at":"2018-07-27T19:33:19Z","updated_at":"2018-07-27T19:33:39Z","pushed_at":"2018-07-27T22:35:31Z","git_url":"git://github.com/tophernuts/rails.git","ssh_url":"git@github.com:tophernuts/rails.git","clone_url":"https://github.com/tophernuts/rails.git","svn_url":"https://github.com/tophernuts/rails","homepage":"http://rubyonrails.org","size":164737,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/2"},"html":{"href":"https://github.com/tophernuts/rails/pull/2"},"issue":{"href":"https://api.github.com/repos/tophernuts/rails/issues/2"},"comments":{"href":"https://api.github.com/repos/tophernuts/rails/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tophernuts/rails/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/tophernuts/rails/statuses/b5de331557e31761b0405d82ca23bbe4146be318"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"seanhealy"}}