{"action":"created","issue":{"url":"https://api.github.com/repos/OneZoom/OZtree/issues/101","repository_url":"https://api.github.com/repos/OneZoom/OZtree","labels_url":"https://api.github.com/repos/OneZoom/OZtree/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/OneZoom/OZtree/issues/101/comments","events_url":"https://api.github.com/repos/OneZoom/OZtree/issues/101/events","html_url":"https://github.com/OneZoom/OZtree/issues/101","id":333092927,"node_id":"MDU6SXNzdWUzMzMwOTI5Mjc=","number":101,"title":"Fake leaf and threshold settings producing unwanted artefacts at tips of tree","user":{"login":"jrosindell","id":3009279,"node_id":"MDQ6VXNlcjMwMDkyNzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3009279?v=4","gravatar_id":"","url":"https://api.github.com/users/jrosindell","html_url":"https://github.com/jrosindell","followers_url":"https://api.github.com/users/jrosindell/followers","following_url":"https://api.github.com/users/jrosindell/following{/other_user}","gists_url":"https://api.github.com/users/jrosindell/gists{/gist_id}","starred_url":"https://api.github.com/users/jrosindell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrosindell/subscriptions","organizations_url":"https://api.github.com/users/jrosindell/orgs","repos_url":"https://api.github.com/users/jrosindell/repos","events_url":"https://api.github.com/users/jrosindell/events{/privacy}","received_events_url":"https://api.github.com/users/jrosindell/received_events","type":"User","site_admin":false},"labels":[{"id":927428524,"node_id":"MDU6TGFiZWw5Mjc0Mjg1MjQ=","url":"https://api.github.com/repos/OneZoom/OZtree/labels/Version%203.3","name":"Version 3.3","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-17T21:05:37Z","updated_at":"2018-06-18T12:41:12Z","closed_at":null,"author_association":"MEMBER","body":"On Safari there is a little bug where the semicircle of a node reverses and bends inwards instead of outwards temporarily whilst something is loading - I think this related to the ‘fake leaf’ code - see attached images (not screen shots but camera pics from pointing at the screen as was hard to catch at the right moment otherwise as it’s related to fake leaves and refresh)… In general I think the code that sets the threshold for detail could probably do with being tweaked as it seems quite sensitive to reducing the detail and then increasing it again which leads to strange artefacts on the tips of the tree - this issue has always been there but somehow now on the Polytomy view it’s worse."},"comment":{"url":"https://api.github.com/repos/OneZoom/OZtree/issues/comments/398040737","html_url":"https://github.com/OneZoom/OZtree/issues/101#issuecomment-398040737","issue_url":"https://api.github.com/repos/OneZoom/OZtree/issues/101","id":398040737,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODA0MDczNw==","user":{"login":"lentinj","id":586911,"node_id":"MDQ6VXNlcjU4NjkxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/586911?v=4","gravatar_id":"","url":"https://api.github.com/users/lentinj","html_url":"https://github.com/lentinj","followers_url":"https://api.github.com/users/lentinj/followers","following_url":"https://api.github.com/users/lentinj/following{/other_user}","gists_url":"https://api.github.com/users/lentinj/gists{/gist_id}","starred_url":"https://api.github.com/users/lentinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lentinj/subscriptions","organizations_url":"https://api.github.com/users/lentinj/orgs","repos_url":"https://api.github.com/users/lentinj/repos","events_url":"https://api.github.com/users/lentinj/events{/privacy}","received_events_url":"https://api.github.com/users/lentinj/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T12:41:12Z","updated_at":"2018-06-18T12:41:12Z","author_association":"COLLABORATOR","body":"> Should there be a testing framework on the JS that checks explicitly the functionality of the object pool? \r\n\r\nIt's not the object pool itself that's at fault, but the shape classes that don't release properly. Yes they could be wrapped in unit-tests that check each parameter is released, but the bigger problem here is what to do if anything is relying on this behaviour (see later).\r\n\r\nI think all of this code is living on borrowed time to be honest. The shapes aren't useful abstractions IMO, and a lot of performance is lost generating this very large heap of objects, and in particular sorting them. I think we should be going straight from get_shapes() to rendering on an individual canvas for branch/leaf/signpost. Things like circle_cut_image() give you a more useful level of abstraction for canvas operations, and make it easier to draw all shapes of one type in one go, reducing canvas context switches, which take time.\r\n\r\nHaving multiple canvases should eradicate the need for height (and thus the sort), and allows the browser to use the GPU for composition. One could also potentially do things like render the full leaves with an SVG/DOM layer instead of canvas, so we get to use regular hover interactions rather than having to recreate our own.\r\n\r\n> You say that you can fix without worry about the other versions of the tree, but isn't this just because you're in branch 3.3 - although the main job is to get OTOP working we do need the final implementation to not break any of the functionality that works currently when we pull it all to the server.\r\n\r\nSay I fix this by instead forcing ``shape.counter_wise = false`` in release(). This could create a bug in the regular view if, for example, an early arc shape set ``shape.counter_wise = true`` and later shapes relied on recycling these counter_wise arc shapes.\r\n\r\nOTOH, forcing a reset in OTOP code won't change any behaviour outside OTOP. Which, given I'm working in OTOP, I should notice."}}
{"actor":{"display_login":"lentinj"}}