{"action":"created","issue":{"url":"https://api.github.com/repos/paypal/downshift/issues/353","repository_url":"https://api.github.com/repos/paypal/downshift","labels_url":"https://api.github.com/repos/paypal/downshift/issues/353/labels{/name}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/353/comments","events_url":"https://api.github.com/repos/paypal/downshift/issues/353/events","html_url":"https://github.com/paypal/downshift/issues/353","id":301607647,"number":353,"title":"Change how to prevent default events","user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"labels":[{"id":853276044,"url":"https://api.github.com/repos/paypal/downshift/labels/BREAKING%20CHANGE","name":"BREAKING CHANGE","color":"b73354","default":false},{"id":654664869,"url":"https://api.github.com/repos/paypal/downshift/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":711522174,"url":"https://api.github.com/repos/paypal/downshift/labels/needs%20investigation","name":"needs investigation","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-02T00:12:17Z","updated_at":"2018-03-05T13:08:41Z","closed_at":null,"author_association":"MEMBER","body":"Right now if you add a custom event handler (like `onKeyDown` to the `getInputProps` for example), you can prevent the default behavior with `event.preventDefault()`. This has worked pretty well, but honestly it's overloading the feature of preventing the default from events so we should come up with another way to signal preventing the default behavior.\r\n\r\nWhat if instead you simply add a property to the event like: `event.preventDownshiftDefault = true` and then downshift references that rather than `event.defaultPrevented`?\r\n\r\nI think that'd be pretty simple and straightforward and the upgrade for this breaking change would be pretty smooth. In fact, we could support both for a little while without much trouble.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/paypal/downshift/issues/comments/370413692","html_url":"https://github.com/paypal/downshift/issues/353#issuecomment-370413692","issue_url":"https://api.github.com/repos/paypal/downshift/issues/353","id":370413692,"user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T13:08:41Z","updated_at":"2018-03-05T13:08:41Z","author_association":"MEMBER","body":"Yeah, it was kind of a last minute feature and in retrospect wasn't thought through very well 😅 "}}
{"actor":{"display_login":"kentcdodds"}}