{"action":"created","issue":{"url":"https://api.github.com/repos/slamdata/quasar/issues/3907","repository_url":"https://api.github.com/repos/slamdata/quasar","labels_url":"https://api.github.com/repos/slamdata/quasar/issues/3907/labels{/name}","comments_url":"https://api.github.com/repos/slamdata/quasar/issues/3907/comments","events_url":"https://api.github.com/repos/slamdata/quasar/issues/3907/events","html_url":"https://github.com/slamdata/quasar/pull/3907","id":374196838,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTUzOTk3","number":3907,"title":"compact/canonicalize in execute (after evaluation)","user":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"labels":[{"id":513635755,"node_id":"MDU6TGFiZWw1MTM2MzU3NTU=","url":"https://api.github.com/repos/slamdata/quasar/labels/version:%20revision","name":"version: revision","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"assignees":[{"login":"djspiewak","id":752,"node_id":"MDQ6VXNlcjc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/752?v=4","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-26T01:54:54Z","updated_at":"2018-10-26T15:56:58Z","closed_at":"2018-10-26T15:10:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/slamdata/quasar/pulls/3907","html_url":"https://github.com/slamdata/quasar/pull/3907","diff_url":"https://github.com/slamdata/quasar/pull/3907.diff","patch_url":"https://github.com/slamdata/quasar/pull/3907.patch"},"body":"[ch2936]"},"comment":{"url":"https://api.github.com/repos/slamdata/quasar/issues/comments/433456554","html_url":"https://github.com/slamdata/quasar/pull/3907#issuecomment-433456554","issue_url":"https://api.github.com/repos/slamdata/quasar/issues/3907","id":433456554,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ1NjU1NA==","user":{"login":"alissapajer","id":1088100,"node_id":"MDQ6VXNlcjEwODgxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1088100?v=4","gravatar_id":"","url":"https://api.github.com/users/alissapajer","html_url":"https://github.com/alissapajer","followers_url":"https://api.github.com/users/alissapajer/followers","following_url":"https://api.github.com/users/alissapajer/following{/other_user}","gists_url":"https://api.github.com/users/alissapajer/gists{/gist_id}","starred_url":"https://api.github.com/users/alissapajer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alissapajer/subscriptions","organizations_url":"https://api.github.com/users/alissapajer/orgs","repos_url":"https://api.github.com/users/alissapajer/repos","events_url":"https://api.github.com/users/alissapajer/events{/privacy}","received_events_url":"https://api.github.com/users/alissapajer/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T15:56:58Z","updated_at":"2018-10-26T15:56:58Z","author_association":"CONTRIBUTOR","body":"@djspiewak hm so the only place I've found where we're materializing before storing or returning results is in [`SegmentsWrapper.sliceToSegments`](https://github.com/slamdata/quasar/blob/master/yggdrasil/src/main/scala/quasar/yggdrasil/nihdb/SegmentsWrapper.scala#L110), which we call (for one) in [`MimirPTableStore#write`](https://github.com/slamdata/quasar/blob/master/mimir/src/main/scala/quasar/mimir/storage/storage/MimirPTableStore.scala#L82). We need to call `materialized` in `SegmentsWrapper.sliceToSegments` though because an `ArraySegment` contains an array of its actual values. "}}
{"actor":{"display_login":"alissapajer"}}