{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/217965936","pull_request_review_id":155799478,"id":217965936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzk2NTkzNg==","diff_hunk":"@@ -194,3 +194,42 @@ IDATA\n j9sysinfo_get_cache_info(struct J9PortLibrary *portLibrary, struct const J9CacheInfoQuery * query) {\n \treturn J9PORT_ERROR_SYSINFO_NOT_SUPPORTED;\n }\n+\n+/**\n+ * Initiates the J9CgroupMetricIteratorState attributes depending on subsystem\n+ * @param[in] portLibrary The Port Library instance\n+ * @param[in] subsystem It represents which Cgroup Subsystem state should be initiated\n+ * @param[in] state Instance of the struct J9CgroupMetricIteratorState which gets initiated basing on the subsystem\n+ * @return 0 on success error code on failure\n+ */\n+int32_t\n+j9sysinfo_cgroup_subsystem_iterator_init(struct J9PortLibrary *portLibrary, uint64_t subsystem, struct J9CgroupMetricIteratorState *state)\n+{\n+\treturn J9PORT_ERROR_SYSINFO_CGROUP_SUBSYSTEM_UNAVAILABLE;\n+}","path":"runtime/port/common/j9sysinfo.c","position":23,"original_position":23,"commit_id":"d3318087e3001f611360e19e23dd1cd6f7a726c8","original_commit_id":"ac3222d5a0e7d4f89fd32d75b0531023b95a425c","user":{"login":"bharathappali","id":14173012,"node_id":"MDQ6VXNlcjE0MTczMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/14173012?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathappali","html_url":"https://github.com/bharathappali","followers_url":"https://api.github.com/users/bharathappali/followers","following_url":"https://api.github.com/users/bharathappali/following{/other_user}","gists_url":"https://api.github.com/users/bharathappali/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathappali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathappali/subscriptions","organizations_url":"https://api.github.com/users/bharathappali/orgs","repos_url":"https://api.github.com/users/bharathappali/repos","events_url":"https://api.github.com/users/bharathappali/events{/privacy}","received_events_url":"https://api.github.com/users/bharathappali/received_events","type":"User","site_admin":false},"body":"@DanHeidinga Thank you for the review. I felt that these methods may be a good fit in OpenJ9 as its the only one which uses  these methods and that too only in the javadump use case. We could move it to OMR if any other future use cases for such mechanism arise. Let me know if this is ok with you.","created_at":"2018-09-17T07:12:05Z","updated_at":"2018-09-17T07:12:06Z","html_url":"https://github.com/eclipse/openj9/pull/2550#discussion_r217965936","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2550","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/217965936"},"html":{"href":"https://github.com/eclipse/openj9/pull/2550#discussion_r217965936"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2550"}},"in_reply_to_id":217140771},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2550","id":205961491,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTYxNDkx","html_url":"https://github.com/eclipse/openj9/pull/2550","diff_url":"https://github.com/eclipse/openj9/pull/2550.diff","patch_url":"https://github.com/eclipse/openj9/pull/2550.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2550","number":2550,"state":"open","locked":false,"title":"added changes to display Cgroup information in a key value pair","user":{"login":"bharathappali","id":14173012,"node_id":"MDQ6VXNlcjE0MTczMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/14173012?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathappali","html_url":"https://github.com/bharathappali","followers_url":"https://api.github.com/users/bharathappali/followers","following_url":"https://api.github.com/users/bharathappali/following{/other_user}","gists_url":"https://api.github.com/users/bharathappali/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathappali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathappali/subscriptions","organizations_url":"https://api.github.com/users/bharathappali/orgs","repos_url":"https://api.github.com/users/bharathappali/repos","events_url":"https://api.github.com/users/bharathappali/events{/privacy}","received_events_url":"https://api.github.com/users/bharathappali/received_events","type":"User","site_admin":false},"body":"[To display Container Information in Javadump](https://github.com/eclipse/openj9/issues/1932) An iterator model for displaying Cgroup Information has been added.\r\n\r\nThese changes are depended on [OMR PR 2767](https://github.com/eclipse/omr/pull/2767)\r\nDoc issue https://github.com/eclipse/openj9-docs/issues/56 and also https://github.com/eclipse/openj9-docs/pull/79\r\nCloses #1932\r\n\r\nSigned-off-by: bharathappali <bharath.appali@gmail.com>","created_at":"2018-08-03T08:35:03Z","updated_at":"2018-09-17T07:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"594b32faa1b0d9ee58bdf25c5fe5017dbcca2437","assignee":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"assignees":[{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962110,"node_id":"MDU6TGFiZWw2OTc5NjIxMTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false},{"id":1051906638,"node_id":"MDU6TGFiZWwxMDUxOTA2NjM4","url":"https://api.github.com/repos/eclipse/openj9/labels/depends:doc","name":"depends:doc","color":"d4c5f9","default":false},{"id":709763910,"node_id":"MDU6TGFiZWw3MDk3NjM5MTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/depends:omr","name":"depends:omr","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2550/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2550/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2550/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/d3318087e3001f611360e19e23dd1cd6f7a726c8","head":{"label":"bharathappali:javacore-cgroup-info","ref":"javacore-cgroup-info","sha":"d3318087e3001f611360e19e23dd1cd6f7a726c8","user":{"login":"bharathappali","id":14173012,"node_id":"MDQ6VXNlcjE0MTczMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/14173012?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathappali","html_url":"https://github.com/bharathappali","followers_url":"https://api.github.com/users/bharathappali/followers","following_url":"https://api.github.com/users/bharathappali/following{/other_user}","gists_url":"https://api.github.com/users/bharathappali/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathappali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathappali/subscriptions","organizations_url":"https://api.github.com/users/bharathappali/orgs","repos_url":"https://api.github.com/users/bharathappali/repos","events_url":"https://api.github.com/users/bharathappali/events{/privacy}","received_events_url":"https://api.github.com/users/bharathappali/received_events","type":"User","site_admin":false},"repo":{"id":143398603,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzOTg2MDM=","name":"openj9","full_name":"bharathappali/openj9","private":false,"owner":{"login":"bharathappali","id":14173012,"node_id":"MDQ6VXNlcjE0MTczMDEy","avatar_url":"https://avatars0.githubusercontent.com/u/14173012?v=4","gravatar_id":"","url":"https://api.github.com/users/bharathappali","html_url":"https://github.com/bharathappali","followers_url":"https://api.github.com/users/bharathappali/followers","following_url":"https://api.github.com/users/bharathappali/following{/other_user}","gists_url":"https://api.github.com/users/bharathappali/gists{/gist_id}","starred_url":"https://api.github.com/users/bharathappali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharathappali/subscriptions","organizations_url":"https://api.github.com/users/bharathappali/orgs","repos_url":"https://api.github.com/users/bharathappali/repos","events_url":"https://api.github.com/users/bharathappali/events{/privacy}","received_events_url":"https://api.github.com/users/bharathappali/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bharathappali/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/bharathappali/openj9","forks_url":"https://api.github.com/repos/bharathappali/openj9/forks","keys_url":"https://api.github.com/repos/bharathappali/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bharathappali/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bharathappali/openj9/teams","hooks_url":"https://api.github.com/repos/bharathappali/openj9/hooks","issue_events_url":"https://api.github.com/repos/bharathappali/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/bharathappali/openj9/events","assignees_url":"https://api.github.com/repos/bharathappali/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/bharathappali/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/bharathappali/openj9/tags","blobs_url":"https://api.github.com/repos/bharathappali/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bharathappali/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bharathappali/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/bharathappali/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bharathappali/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/bharathappali/openj9/languages","stargazers_url":"https://api.github.com/repos/bharathappali/openj9/stargazers","contributors_url":"https://api.github.com/repos/bharathappali/openj9/contributors","subscribers_url":"https://api.github.com/repos/bharathappali/openj9/subscribers","subscription_url":"https://api.github.com/repos/bharathappali/openj9/subscription","commits_url":"https://api.github.com/repos/bharathappali/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/bharathappali/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/bharathappali/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/bharathappali/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/bharathappali/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/bharathappali/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bharathappali/openj9/merges","archive_url":"https://api.github.com/repos/bharathappali/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bharathappali/openj9/downloads","issues_url":"https://api.github.com/repos/bharathappali/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/bharathappali/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/bharathappali/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/bharathappali/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bharathappali/openj9/labels{/name}","releases_url":"https://api.github.com/repos/bharathappali/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/bharathappali/openj9/deployments","created_at":"2018-08-03T08:12:50Z","updated_at":"2018-09-12T06:03:55Z","pushed_at":"2018-09-12T21:02:34Z","git_url":"git://github.com/bharathappali/openj9.git","ssh_url":"git@github.com:bharathappali/openj9.git","clone_url":"https://github.com/bharathappali/openj9.git","svn_url":"https://github.com/bharathappali/openj9","homepage":"","size":34039,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"72950710697a73e652d6f94afa073e26fabaaa31","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-09-15T22:10:38Z","pushed_at":"2018-09-17T03:40:45Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":34266,"stargazers_count":1410,"watchers_count":1410,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":276,"open_issues":441,"watchers":1410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2550"},"html":{"href":"https://github.com/eclipse/openj9/pull/2550"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2550"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2550/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2550/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2550/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/d3318087e3001f611360e19e23dd1cd6f7a726c8"}},"author_association":"NONE"}}
{"actor":{"display_login":"bharathappali"}}