{"action":"created","comment":{"url":"https://api.github.com/repos/enactjs/enact/pulls/comments/226028827","pull_request_review_id":165753735,"id":226028827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjAyODgyNw==","diff_hunk":"@@ -125,11 +126,10 @@ const MediaSliderDecorator = hoc((config, Wrapped) => {\t// eslint-disable-line n\n \n \t\tmove (clientX) {\n \t\t\tthis.setState((state) => {\n-\t\t\t\tif (clientX >= state.minX && clientX <= state.maxX) {\n-\t\t\t\t\treturn {\n-\t\t\t\t\t\tx: calcProportion(state.minX, state.maxX, clientX)\n-\t\t\t\t\t};\n-\t\t\t\t}\n+\t\t\t\tconst value = clamp(state.minX, state.maxX, clientX);\n+\t\t\t\treturn {","path":"packages/moonstone/VideoPlayer/MediaSliderDecorator.js","position":18,"original_position":18,"commit_id":"0a6c3ce0c25e55847f3fad20db95d3dbd33f8f92","original_commit_id":"0a6c3ce0c25e55847f3fad20db95d3dbd33f8f92","user":{"login":"ryanjduffy","id":788456,"node_id":"MDQ6VXNlcjc4ODQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788456?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"body":"I think we _could_ optimize this to return `null` when `x` isn't changing but I doubt it'll make a material difference given that the slider will already be updating frequently during playback. Noting for future consideration only.","created_at":"2018-10-17T17:39:18Z","updated_at":"2018-10-17T17:39:18Z","html_url":"https://github.com/enactjs/enact/pull/1991#discussion_r226028827","pull_request_url":"https://api.github.com/repos/enactjs/enact/pulls/1991","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments/226028827"},"html":{"href":"https://github.com/enactjs/enact/pull/1991#discussion_r226028827"},"pull_request":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1991"}}},"pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1991","id":223488400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDg4NDAw","html_url":"https://github.com/enactjs/enact/pull/1991","diff_url":"https://github.com/enactjs/enact/pull/1991.diff","patch_url":"https://github.com/enactjs/enact/pull/1991.patch","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1991","number":1991,"state":"open","locked":false,"title":"ENYO-5692: Fix VideoPlayer to clamp knob position","user":{"login":"xbinary","id":1725168,"node_id":"MDQ6VXNlcjE3MjUxNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1725168?v=4","gravatar_id":"","url":"https://api.github.com/users/xbinary","html_url":"https://github.com/xbinary","followers_url":"https://api.github.com/users/xbinary/followers","following_url":"https://api.github.com/users/xbinary/following{/other_user}","gists_url":"https://api.github.com/users/xbinary/gists{/gist_id}","starred_url":"https://api.github.com/users/xbinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbinary/subscriptions","organizations_url":"https://api.github.com/users/xbinary/orgs","repos_url":"https://api.github.com/users/xbinary/repos","events_url":"https://api.github.com/users/xbinary/events{/privacy}","received_events_url":"https://api.github.com/users/xbinary/received_events","type":"User","site_admin":false},"body":"### Checklist\r\n\r\n* [x] I have read and understand the [contribution guide](http://enactjs.com/docs/developer-guide/contributing/)\r\n* [ ] A [CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included\r\n* [ ] At least one test case is included for this feature or bug fix\r\n* [x] Documentation was added or is not needed\r\n\r\n* [ ] This is an API breaking change\r\n\r\n### Issue Resolved / Feature Added\r\nWhen pointer is located on the left side of the progress bar,\r\nKnob is located to minimum X position\r\n\r\n### Resolution\r\nclamp `clientX` of pointer\r\n\r\n### Additional Considerations\r\n\r\n### Links\r\n\r\n### Comments\r\n","created_at":"2018-10-17T06:59:00Z","updated_at":"2018-10-17T17:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6400bce89aba12bf53481835ee1d5d4d4157cf1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enactjs/enact/pulls/1991/commits","review_comments_url":"https://api.github.com/repos/enactjs/enact/pulls/1991/comments","review_comment_url":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1991/comments","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/0a6c3ce0c25e55847f3fad20db95d3dbd33f8f92","head":{"label":"enactjs:ENYO-5692-hyeok","ref":"ENYO-5692-hyeok","sha":"0a6c3ce0c25e55847f3fad20db95d3dbd33f8f92","user":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"node_id":"MDEwOlJlcG9zaXRvcnk2NzY1MzA2NQ==","name":"enact","full_name":"enactjs/enact","private":false,"owner":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-10-15T21:52:36Z","pushed_at":"2018-10-17T17:36:16Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":16551,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":28,"watchers":82,"default_branch":"master"}},"base":{"label":"enactjs:develop","ref":"develop","sha":"a7e0787fde7122e3cc1bef41a7efce635613d4a0","user":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"node_id":"MDEwOlJlcG9zaXRvcnk2NzY1MzA2NQ==","name":"enact","full_name":"enactjs/enact","private":false,"owner":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-10-15T21:52:36Z","pushed_at":"2018-10-17T17:36:16Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":16551,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":28,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1991"},"html":{"href":"https://github.com/enactjs/enact/pull/1991"},"issue":{"href":"https://api.github.com/repos/enactjs/enact/issues/1991"},"comments":{"href":"https://api.github.com/repos/enactjs/enact/issues/1991/comments"},"review_comments":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1991/comments"},"review_comment":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1991/commits"},"statuses":{"href":"https://api.github.com/repos/enactjs/enact/statuses/0a6c3ce0c25e55847f3fad20db95d3dbd33f8f92"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryanjduffy"}}