{"action":"created","issue":{"url":"https://api.github.com/repos/Jguer/yay/issues/284","repository_url":"https://api.github.com/repos/Jguer/yay","labels_url":"https://api.github.com/repos/Jguer/yay/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/Jguer/yay/issues/284/comments","events_url":"https://api.github.com/repos/Jguer/yay/issues/284/events","html_url":"https://github.com/Jguer/yay/pull/284","id":308083058,"number":284,"title":"Do not depend on the Internet for keys_test.go","user":{"login":"qrwteyrutiyoup","id":73939,"avatar_url":"https://avatars0.githubusercontent.com/u/73939?v=4","gravatar_id":"","url":"https://api.github.com/users/qrwteyrutiyoup","html_url":"https://github.com/qrwteyrutiyoup","followers_url":"https://api.github.com/users/qrwteyrutiyoup/followers","following_url":"https://api.github.com/users/qrwteyrutiyoup/following{/other_user}","gists_url":"https://api.github.com/users/qrwteyrutiyoup/gists{/gist_id}","starred_url":"https://api.github.com/users/qrwteyrutiyoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qrwteyrutiyoup/subscriptions","organizations_url":"https://api.github.com/users/qrwteyrutiyoup/orgs","repos_url":"https://api.github.com/users/qrwteyrutiyoup/repos","events_url":"https://api.github.com/users/qrwteyrutiyoup/events{/privacy}","received_events_url":"https://api.github.com/users/qrwteyrutiyoup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-23T15:50:18Z","updated_at":"2018-03-23T17:25:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Jguer/yay/pulls/284","html_url":"https://github.com/Jguer/yay/pull/284","diff_url":"https://github.com/Jguer/yay/pull/284.diff","patch_url":"https://github.com/Jguer/yay/pull/284.patch"},"body":"We now mock a PGP key server to provide the keys used during the\r\ntesting, making it so that we do not need the Internet anymore for\r\nthe testing of the PGP key import feature."},"comment":{"url":"https://api.github.com/repos/Jguer/yay/issues/comments/375741083","html_url":"https://github.com/Jguer/yay/pull/284#issuecomment-375741083","issue_url":"https://api.github.com/repos/Jguer/yay/issues/284","id":375741083,"user":{"login":"Morganamilo","id":16593899,"avatar_url":"https://avatars2.githubusercontent.com/u/16593899?v=4","gravatar_id":"","url":"https://api.github.com/users/Morganamilo","html_url":"https://github.com/Morganamilo","followers_url":"https://api.github.com/users/Morganamilo/followers","following_url":"https://api.github.com/users/Morganamilo/following{/other_user}","gists_url":"https://api.github.com/users/Morganamilo/gists{/gist_id}","starred_url":"https://api.github.com/users/Morganamilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morganamilo/subscriptions","organizations_url":"https://api.github.com/users/Morganamilo/orgs","repos_url":"https://api.github.com/users/Morganamilo/repos","events_url":"https://api.github.com/users/Morganamilo/events{/privacy}","received_events_url":"https://api.github.com/users/Morganamilo/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T17:25:56Z","updated_at":"2018-03-23T17:25:56Z","author_association":"COLLABORATOR","body":"This is how it should have been the first time, but I kinda forgot gpg uses the internet. Honestly I did not look into the tests that much last time.\r\n\r\nGiving them a proper look though, why is `config.BuildDir` set? we're just testing keys right not building anything?\r\n\r\nAlso we might have other tests in future that make use of test data (or we might have some sh scripts) so I would probably move the keys to `tests/keys`. Or could you just generate the keys through gpg?\r\n\r\nAnd that web server you start, I don't know how it behaves exactly but if it's possible it should reject connections from outside of the program or outside of the device."}}
{"actor":{"display_login":"Morganamilo"}}