{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/184949329","pull_request_review_id":116241855,"id":184949329,"diff_hunk":"@@ -2184,20 +2184,44 @@ void TypeChecker::endVisit(ElementaryTypeNameExpression const& _expr)\n \n void TypeChecker::endVisit(Literal const& _literal)\n {\n-\tbool const v050 = m_scope->sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050);\n+\tbool const v050 = m_scope->sourceUnit().annotation().experimentalFeatures.count(ExperimentalFeature::V050) > 0;\n \n \tif (_literal.looksLikeAddress())\n \t{\n-\t\tif (_literal.passesAddressChecksum())\n+\t\tbool acceptableAddress = true;\n+\t\tif (_literal.value().length() != 42) // \"0x\" + 40 hex digits\n+\t\t{\n+\t\t\tstring error =\n+\t\t\t\t\t\"This looks like an address but is not exactly 20 bytes long. Current length is \" + to_string(_literal.value().length()) +","path":"libsolidity/analysis/TypeChecker.cpp","position":14,"original_position":14,"commit_id":"2a36866cebcdd751c8e4e14f8bfd32a065a8e844","original_commit_id":"2a36866cebcdd751c8e4e14f8bfd32a065a8e844","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Should be unindented by one tab.","created_at":"2018-04-30T10:01:34Z","updated_at":"2018-04-30T10:01:34Z","html_url":"https://github.com/ethereum/solidity/pull/3534#discussion_r184949329","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/3534","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/184949329"},"html":{"href":"https://github.com/ethereum/solidity/pull/3534#discussion_r184949329"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3534"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/3534","id":169545878,"html_url":"https://github.com/ethereum/solidity/pull/3534","diff_url":"https://github.com/ethereum/solidity/pull/3534.diff","patch_url":"https://github.com/ethereum/solidity/pull/3534.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/3534","number":3534,"state":"open","locked":false,"title":"[WIP] Strict checking of address literals","user":{"login":"meowingtwurtle","id":1988485,"avatar_url":"https://avatars2.githubusercontent.com/u/1988485?v=4","gravatar_id":"","url":"https://api.github.com/users/meowingtwurtle","html_url":"https://github.com/meowingtwurtle","followers_url":"https://api.github.com/users/meowingtwurtle/followers","following_url":"https://api.github.com/users/meowingtwurtle/following{/other_user}","gists_url":"https://api.github.com/users/meowingtwurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/meowingtwurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meowingtwurtle/subscriptions","organizations_url":"https://api.github.com/users/meowingtwurtle/orgs","repos_url":"https://api.github.com/users/meowingtwurtle/repos","events_url":"https://api.github.com/users/meowingtwurtle/events{/privacy}","received_events_url":"https://api.github.com/users/meowingtwurtle/received_events","type":"User","site_admin":false},"body":"WIP. DO NOT MERGE.\n\nCloses #2907.","created_at":"2018-02-16T04:26:27Z","updated_at":"2018-04-30T10:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92ef3749508d636023f7a9bccbafac61445a6c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/3534/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/3534/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/3534/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/2a36866cebcdd751c8e4e14f8bfd32a065a8e844","head":{"label":"meowingtwurtle:strictAddresses","ref":"strictAddresses","sha":"2a36866cebcdd751c8e4e14f8bfd32a065a8e844","user":{"login":"meowingtwurtle","id":1988485,"avatar_url":"https://avatars2.githubusercontent.com/u/1988485?v=4","gravatar_id":"","url":"https://api.github.com/users/meowingtwurtle","html_url":"https://github.com/meowingtwurtle","followers_url":"https://api.github.com/users/meowingtwurtle/followers","following_url":"https://api.github.com/users/meowingtwurtle/following{/other_user}","gists_url":"https://api.github.com/users/meowingtwurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/meowingtwurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meowingtwurtle/subscriptions","organizations_url":"https://api.github.com/users/meowingtwurtle/orgs","repos_url":"https://api.github.com/users/meowingtwurtle/repos","events_url":"https://api.github.com/users/meowingtwurtle/events{/privacy}","received_events_url":"https://api.github.com/users/meowingtwurtle/received_events","type":"User","site_admin":false},"repo":{"id":117014401,"name":"solidity","full_name":"meowingtwurtle/solidity","owner":{"login":"meowingtwurtle","id":1988485,"avatar_url":"https://avatars2.githubusercontent.com/u/1988485?v=4","gravatar_id":"","url":"https://api.github.com/users/meowingtwurtle","html_url":"https://github.com/meowingtwurtle","followers_url":"https://api.github.com/users/meowingtwurtle/followers","following_url":"https://api.github.com/users/meowingtwurtle/following{/other_user}","gists_url":"https://api.github.com/users/meowingtwurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/meowingtwurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meowingtwurtle/subscriptions","organizations_url":"https://api.github.com/users/meowingtwurtle/orgs","repos_url":"https://api.github.com/users/meowingtwurtle/repos","events_url":"https://api.github.com/users/meowingtwurtle/events{/privacy}","received_events_url":"https://api.github.com/users/meowingtwurtle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meowingtwurtle/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":true,"url":"https://api.github.com/repos/meowingtwurtle/solidity","forks_url":"https://api.github.com/repos/meowingtwurtle/solidity/forks","keys_url":"https://api.github.com/repos/meowingtwurtle/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meowingtwurtle/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meowingtwurtle/solidity/teams","hooks_url":"https://api.github.com/repos/meowingtwurtle/solidity/hooks","issue_events_url":"https://api.github.com/repos/meowingtwurtle/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/meowingtwurtle/solidity/events","assignees_url":"https://api.github.com/repos/meowingtwurtle/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/meowingtwurtle/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/meowingtwurtle/solidity/tags","blobs_url":"https://api.github.com/repos/meowingtwurtle/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meowingtwurtle/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meowingtwurtle/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/meowingtwurtle/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meowingtwurtle/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/meowingtwurtle/solidity/languages","stargazers_url":"https://api.github.com/repos/meowingtwurtle/solidity/stargazers","contributors_url":"https://api.github.com/repos/meowingtwurtle/solidity/contributors","subscribers_url":"https://api.github.com/repos/meowingtwurtle/solidity/subscribers","subscription_url":"https://api.github.com/repos/meowingtwurtle/solidity/subscription","commits_url":"https://api.github.com/repos/meowingtwurtle/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/meowingtwurtle/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/meowingtwurtle/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/meowingtwurtle/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/meowingtwurtle/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/meowingtwurtle/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meowingtwurtle/solidity/merges","archive_url":"https://api.github.com/repos/meowingtwurtle/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meowingtwurtle/solidity/downloads","issues_url":"https://api.github.com/repos/meowingtwurtle/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/meowingtwurtle/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/meowingtwurtle/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/meowingtwurtle/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meowingtwurtle/solidity/labels{/name}","releases_url":"https://api.github.com/repos/meowingtwurtle/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/meowingtwurtle/solidity/deployments","created_at":"2018-01-10T21:43:19Z","updated_at":"2018-01-10T21:43:24Z","pushed_at":"2018-04-28T22:53:23Z","git_url":"git://github.com/meowingtwurtle/solidity.git","ssh_url":"git@github.com:meowingtwurtle/solidity.git","clone_url":"https://github.com/meowingtwurtle/solidity.git","svn_url":"https://github.com/meowingtwurtle/solidity","homepage":"","size":18420,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"d577f06ad8951b42f8df6fa0e9feca90eb2785eb","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-04-30T08:33:36Z","pushed_at":"2018-04-30T09:57:20Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":18878,"stargazers_count":4681,"watchers_count":4681,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1222,"mirror_url":null,"archived":false,"open_issues_count":557,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1222,"open_issues":557,"watchers":4681,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3534"},"html":{"href":"https://github.com/ethereum/solidity/pull/3534"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3534"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/3534/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3534/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/3534/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/2a36866cebcdd751c8e4e14f8bfd32a065a8e844"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chriseth"}}