{"action":"created","issue":{"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/41","repository_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager","labels_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/41/comments","events_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/41/events","html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/41","id":328032657,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjcyNDQ2","number":41,"title":"Return stderr as part of command err","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-31T07:57:46Z","updated_at":"2018-05-31T08:20:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/41","html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/41","diff_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/41.diff","patch_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/41.patch"},"body":"In #38 we introduced a bug because `command.Run` no longer returned the stderr string as part of the `error`. This caused a problem in the `deletions.yaml` handling because we rely on the stderr output of `kubectl` to determine if the command just failed because the to-be-deleted resource just wasn't found.\r\n\r\nThis reverts the behavior.\r\n\r\nhttps://github.com/zalando-incubator/cluster-lifecycle-manager/blob/master/provisioner/clusterpy.go#L820-L825"},"comment":{"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/comments/393451797","html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/41#issuecomment-393451797","issue_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/41","id":393451797,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQ1MTc5Nw==","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T08:20:06Z","updated_at":"2018-05-31T08:20:06Z","author_association":"COLLABORATOR","body":":+1:"}}
{"actor":{"display_login":"mikkeloscar"}}