{"action":"created","issue":{"url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/32","repository_url":"https://api.github.com/repos/dgilperez/validates_zipcode","labels_url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/32/comments","events_url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/32/events","html_url":"https://github.com/dgilperez/validates_zipcode/pull/32","id":314235246,"number":32,"title":"Make GB and UK regexes the same and add tests to ensure this","user":{"login":"Onumis","id":1113178,"avatar_url":"https://avatars0.githubusercontent.com/u/1113178?v=4","gravatar_id":"","url":"https://api.github.com/users/Onumis","html_url":"https://github.com/Onumis","followers_url":"https://api.github.com/users/Onumis/followers","following_url":"https://api.github.com/users/Onumis/following{/other_user}","gists_url":"https://api.github.com/users/Onumis/gists{/gist_id}","starred_url":"https://api.github.com/users/Onumis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Onumis/subscriptions","organizations_url":"https://api.github.com/users/Onumis/orgs","repos_url":"https://api.github.com/users/Onumis/repos","events_url":"https://api.github.com/users/Onumis/events{/privacy}","received_events_url":"https://api.github.com/users/Onumis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-13T20:07:54Z","updated_at":"2018-04-22T19:41:43Z","closed_at":"2018-04-22T19:39:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dgilperez/validates_zipcode/pulls/32","html_url":"https://github.com/dgilperez/validates_zipcode/pull/32","diff_url":"https://github.com/dgilperez/validates_zipcode/pull/32.diff","patch_url":"https://github.com/dgilperez/validates_zipcode/pull/32.patch"},"body":"For https://github.com/dgilperez/validates_zipcode/issues/31\r\n\r\nEnded up uniting GB and UK, so that they are now a great and truly united Britain/Kingdom!\r\n\r\nAdded a bunch of postcode that are valid (taken from postcodes.io), but not sure if enough.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/comments/383406958","html_url":"https://github.com/dgilperez/validates_zipcode/pull/32#issuecomment-383406958","issue_url":"https://api.github.com/repos/dgilperez/validates_zipcode/issues/32","id":383406958,"user":{"login":"dgilperez","id":264590,"avatar_url":"https://avatars1.githubusercontent.com/u/264590?v=4","gravatar_id":"","url":"https://api.github.com/users/dgilperez","html_url":"https://github.com/dgilperez","followers_url":"https://api.github.com/users/dgilperez/followers","following_url":"https://api.github.com/users/dgilperez/following{/other_user}","gists_url":"https://api.github.com/users/dgilperez/gists{/gist_id}","starred_url":"https://api.github.com/users/dgilperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgilperez/subscriptions","organizations_url":"https://api.github.com/users/dgilperez/orgs","repos_url":"https://api.github.com/users/dgilperez/repos","events_url":"https://api.github.com/users/dgilperez/events{/privacy}","received_events_url":"https://api.github.com/users/dgilperez/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T19:41:43Z","updated_at":"2018-04-22T19:41:43Z","author_association":"OWNER","body":"So I looked deeper into this and I found an official regex provided by the GB goverment, which I ended up implementing for both `UK` and `GB`:\r\n\r\nhttps://assets.publishing.service.gov.uk/government/uploads/system/uploads/attachment_data/file/488478/Bulk_Data_Transfer_-_additional_validation_valid_from_12_November_2015.pdf\r\n\r\nAnother funny thing is that `GB` is the official ISO country code, but there is an exception with `UK`, which is a reserved key for the same country. Hence, merging was the way to go. \r\n\r\nThanks @Onumis 🍺 !"}}
{"actor":{"display_login":"dgilperez"}}