{"action":"closed","number":717,"pull_request":{"url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717","id":198088684,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDg4Njg0","html_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/717","diff_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/717.diff","patch_url":"https://github.com/graphql-dotnet/graphql-dotnet/pull/717.patch","issue_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/717","number":717,"state":"closed","locked":false,"title":"#475 when registering a field throw an error if the name doesn't match the spec","user":{"login":"KoditkarVedant","id":18693839,"node_id":"MDQ6VXNlcjE4NjkzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/18693839?v=4","gravatar_id":"","url":"https://api.github.com/users/KoditkarVedant","html_url":"https://github.com/KoditkarVedant","followers_url":"https://api.github.com/users/KoditkarVedant/followers","following_url":"https://api.github.com/users/KoditkarVedant/following{/other_user}","gists_url":"https://api.github.com/users/KoditkarVedant/gists{/gist_id}","starred_url":"https://api.github.com/users/KoditkarVedant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoditkarVedant/subscriptions","organizations_url":"https://api.github.com/users/KoditkarVedant/orgs","repos_url":"https://api.github.com/users/KoditkarVedant/repos","events_url":"https://api.github.com/users/KoditkarVedant/events{/privacy}","received_events_url":"https://api.github.com/users/KoditkarVedant/received_events","type":"User","site_admin":false},"body":"Fix: #475 \r\n- [x] Adds field name validator as stated by spec\r\n- [x] Update `AddField` in `ComplexGraphType` and `Name` in `FieldBuilder<TSourceType, TReturnType>` to call validator\r\n- [x] Update `FieldBuilder` and `ConnectionBuilder` to set `default` as default field name.\r\n- [x] Added Test cases for changes","created_at":"2018-06-28T16:40:46Z","updated_at":"2018-06-29T23:12:01Z","closed_at":"2018-06-29T23:12:01Z","merged_at":"2018-06-29T23:12:00Z","merge_commit_sha":"d4717ba0978d4f424d692295a9239c3f49b42687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717/commits","review_comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717/comments","review_comment_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/717/comments","statuses_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/609cf11fa8f9e958ac2b63c12a847391f117d07e","head":{"label":"KoditkarVedant:#475-when-registering-a-field-throw-an-error-if-the-name-doesnt-match-the-spec","ref":"#475-when-registering-a-field-throw-an-error-if-the-name-doesnt-match-the-spec","sha":"609cf11fa8f9e958ac2b63c12a847391f117d07e","user":{"login":"KoditkarVedant","id":18693839,"node_id":"MDQ6VXNlcjE4NjkzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/18693839?v=4","gravatar_id":"","url":"https://api.github.com/users/KoditkarVedant","html_url":"https://github.com/KoditkarVedant","followers_url":"https://api.github.com/users/KoditkarVedant/followers","following_url":"https://api.github.com/users/KoditkarVedant/following{/other_user}","gists_url":"https://api.github.com/users/KoditkarVedant/gists{/gist_id}","starred_url":"https://api.github.com/users/KoditkarVedant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoditkarVedant/subscriptions","organizations_url":"https://api.github.com/users/KoditkarVedant/orgs","repos_url":"https://api.github.com/users/KoditkarVedant/repos","events_url":"https://api.github.com/users/KoditkarVedant/events{/privacy}","received_events_url":"https://api.github.com/users/KoditkarVedant/received_events","type":"User","site_admin":false},"repo":{"id":133175733,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNzU3MzM=","name":"graphql-dotnet","full_name":"KoditkarVedant/graphql-dotnet","owner":{"login":"KoditkarVedant","id":18693839,"node_id":"MDQ6VXNlcjE4NjkzODM5","avatar_url":"https://avatars1.githubusercontent.com/u/18693839?v=4","gravatar_id":"","url":"https://api.github.com/users/KoditkarVedant","html_url":"https://github.com/KoditkarVedant","followers_url":"https://api.github.com/users/KoditkarVedant/followers","following_url":"https://api.github.com/users/KoditkarVedant/following{/other_user}","gists_url":"https://api.github.com/users/KoditkarVedant/gists{/gist_id}","starred_url":"https://api.github.com/users/KoditkarVedant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoditkarVedant/subscriptions","organizations_url":"https://api.github.com/users/KoditkarVedant/orgs","repos_url":"https://api.github.com/users/KoditkarVedant/repos","events_url":"https://api.github.com/users/KoditkarVedant/events{/privacy}","received_events_url":"https://api.github.com/users/KoditkarVedant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KoditkarVedant/graphql-dotnet","description":"GraphQL for .NET","fork":true,"url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet","forks_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/forks","keys_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/teams","hooks_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/hooks","issue_events_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/events","assignees_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/tags","blobs_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/languages","stargazers_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/stargazers","contributors_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/contributors","subscribers_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/subscribers","subscription_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/subscription","commits_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/merges","archive_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/downloads","issues_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/KoditkarVedant/graphql-dotnet/deployments","created_at":"2018-05-12T19:07:00Z","updated_at":"2018-06-26T04:54:38Z","pushed_at":"2018-06-29T23:06:45Z","git_url":"git://github.com/KoditkarVedant/graphql-dotnet.git","ssh_url":"git@github.com:KoditkarVedant/graphql-dotnet.git","clone_url":"https://github.com/KoditkarVedant/graphql-dotnet.git","svn_url":"https://github.com/KoditkarVedant/graphql-dotnet","homepage":"http://graphql-dotnet.github.io","size":3356,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql-dotnet:master","ref":"master","sha":"ba812e71b8ed438a41693ca64dbe54a9c1903144","user":{"login":"graphql-dotnet","id":13958777,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/13958777?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-dotnet","html_url":"https://github.com/graphql-dotnet","followers_url":"https://api.github.com/users/graphql-dotnet/followers","following_url":"https://api.github.com/users/graphql-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/graphql-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-dotnet/subscriptions","organizations_url":"https://api.github.com/users/graphql-dotnet/orgs","repos_url":"https://api.github.com/users/graphql-dotnet/repos","events_url":"https://api.github.com/users/graphql-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38632468,"node_id":"MDEwOlJlcG9zaXRvcnkzODYzMjQ2OA==","name":"graphql-dotnet","full_name":"graphql-dotnet/graphql-dotnet","owner":{"login":"graphql-dotnet","id":13958777,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTU4Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/13958777?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-dotnet","html_url":"https://github.com/graphql-dotnet","followers_url":"https://api.github.com/users/graphql-dotnet/followers","following_url":"https://api.github.com/users/graphql-dotnet/following{/other_user}","gists_url":"https://api.github.com/users/graphql-dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-dotnet/subscriptions","organizations_url":"https://api.github.com/users/graphql-dotnet/orgs","repos_url":"https://api.github.com/users/graphql-dotnet/repos","events_url":"https://api.github.com/users/graphql-dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql-dotnet/graphql-dotnet","description":"GraphQL for .NET","fork":false,"url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet","forks_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/forks","keys_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/teams","hooks_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/hooks","issue_events_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/events","assignees_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/tags","blobs_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/languages","stargazers_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/stargazers","contributors_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/contributors","subscribers_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/subscribers","subscription_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/subscription","commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/merges","archive_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/downloads","issues_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/deployments","created_at":"2015-07-06T16:47:15Z","updated_at":"2018-06-29T23:11:54Z","pushed_at":"2018-06-29T23:12:00Z","git_url":"git://github.com/graphql-dotnet/graphql-dotnet.git","ssh_url":"git@github.com:graphql-dotnet/graphql-dotnet.git","clone_url":"https://github.com/graphql-dotnet/graphql-dotnet.git","svn_url":"https://github.com/graphql-dotnet/graphql-dotnet","homepage":"http://graphql-dotnet.github.io","size":3338,"stargazers_count":2130,"watchers_count":2130,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":360,"open_issues":106,"watchers":2130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717"},"html":{"href":"https://github.com/graphql-dotnet/graphql-dotnet/pull/717"},"issue":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/717"},"comments":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/graphql-dotnet/graphql-dotnet/statuses/609cf11fa8f9e958ac2b63c12a847391f117d07e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joemcbride","id":255007,"node_id":"MDQ6VXNlcjI1NTAwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/255007?v=4","gravatar_id":"","url":"https://api.github.com/users/joemcbride","html_url":"https://github.com/joemcbride","followers_url":"https://api.github.com/users/joemcbride/followers","following_url":"https://api.github.com/users/joemcbride/following{/other_user}","gists_url":"https://api.github.com/users/joemcbride/gists{/gist_id}","starred_url":"https://api.github.com/users/joemcbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemcbride/subscriptions","organizations_url":"https://api.github.com/users/joemcbride/orgs","repos_url":"https://api.github.com/users/joemcbride/repos","events_url":"https://api.github.com/users/joemcbride/events{/privacy}","received_events_url":"https://api.github.com/users/joemcbride/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":10,"additions":134,"deletions":11,"changed_files":6}}
{"actor":{"display_login":"joemcbride"}}