{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12","id":194815298,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODE1Mjk4","html_url":"https://github.com/mattlockyer/composables-998/pull/12","diff_url":"https://github.com/mattlockyer/composables-998/pull/12.diff","patch_url":"https://github.com/mattlockyer/composables-998/pull/12.patch","issue_url":"https://api.github.com/repos/mattlockyer/composables-998/issues/12","number":12,"state":"open","locked":false,"title":"Basic tests for ERC998NFTEnumerable / ERC998FTEnumerable","user":{"login":"achadha235","id":1176261,"node_id":"MDQ6VXNlcjExNzYyNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1176261?v=4","gravatar_id":"","url":"https://api.github.com/users/achadha235","html_url":"https://github.com/achadha235","followers_url":"https://api.github.com/users/achadha235/followers","following_url":"https://api.github.com/users/achadha235/following{/other_user}","gists_url":"https://api.github.com/users/achadha235/gists{/gist_id}","starred_url":"https://api.github.com/users/achadha235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achadha235/subscriptions","organizations_url":"https://api.github.com/users/achadha235/orgs","repos_url":"https://api.github.com/users/achadha235/repos","events_url":"https://api.github.com/users/achadha235/events{/privacy}","received_events_url":"https://api.github.com/users/achadha235/received_events","type":"User","site_admin":false},"body":"Heyo\r\n\r\n**Problem:** Need test for ERC998NFTEnumerable / ERC998FTEnumerable\r\n\r\n**Solution:** Add some coverage for these interfaces.\r\n\r\nBasic idea is to setup a set of SampleNFTs/SampleERC20s, add them to a composable and then use the enumeration to find / remove them.\r\n\r\n**New Tests**\r\n```\r\n✓ should return the correct number of totalTokenContracts and balances after ERC20 contracts are added (2179ms)\r\n✓ should return the correct number of totalChildTokens and totalChildTokens after NFT contracts are added (6732ms)\r\n✓ should return the correct number of totalTokenContracts after ERC20 contracts are removed (39ms)\r\n✓ should return the correct number of totalChildTokens and totalChildContracts when NFT contracts are removed (6381ms)\r\n\r\n 42 passing (19s)\r\n```","created_at":"2018-06-14T08:30:54Z","updated_at":"2018-06-14T08:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mattlockyer/composables-998/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattlockyer/composables-998/issues/12/comments","statuses_url":"https://api.github.com/repos/mattlockyer/composables-998/statuses/17fe78cc9318d0ec9cac0b66e69351d44ebde4bf","head":{"label":"achadha235:master","ref":"master","sha":"17fe78cc9318d0ec9cac0b66e69351d44ebde4bf","user":{"login":"achadha235","id":1176261,"node_id":"MDQ6VXNlcjExNzYyNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1176261?v=4","gravatar_id":"","url":"https://api.github.com/users/achadha235","html_url":"https://github.com/achadha235","followers_url":"https://api.github.com/users/achadha235/followers","following_url":"https://api.github.com/users/achadha235/following{/other_user}","gists_url":"https://api.github.com/users/achadha235/gists{/gist_id}","starred_url":"https://api.github.com/users/achadha235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achadha235/subscriptions","organizations_url":"https://api.github.com/users/achadha235/orgs","repos_url":"https://api.github.com/users/achadha235/repos","events_url":"https://api.github.com/users/achadha235/events{/privacy}","received_events_url":"https://api.github.com/users/achadha235/received_events","type":"User","site_admin":false},"repo":{"id":137097851,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwOTc4NTE=","name":"composables-998","full_name":"achadha235/composables-998","owner":{"login":"achadha235","id":1176261,"node_id":"MDQ6VXNlcjExNzYyNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1176261?v=4","gravatar_id":"","url":"https://api.github.com/users/achadha235","html_url":"https://github.com/achadha235","followers_url":"https://api.github.com/users/achadha235/followers","following_url":"https://api.github.com/users/achadha235/following{/other_user}","gists_url":"https://api.github.com/users/achadha235/gists{/gist_id}","starred_url":"https://api.github.com/users/achadha235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achadha235/subscriptions","organizations_url":"https://api.github.com/users/achadha235/orgs","repos_url":"https://api.github.com/users/achadha235/repos","events_url":"https://api.github.com/users/achadha235/events{/privacy}","received_events_url":"https://api.github.com/users/achadha235/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achadha235/composables-998","description":"An implementation and documentation repo for developing the ERC-998 standard for Ethereum.","fork":true,"url":"https://api.github.com/repos/achadha235/composables-998","forks_url":"https://api.github.com/repos/achadha235/composables-998/forks","keys_url":"https://api.github.com/repos/achadha235/composables-998/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achadha235/composables-998/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achadha235/composables-998/teams","hooks_url":"https://api.github.com/repos/achadha235/composables-998/hooks","issue_events_url":"https://api.github.com/repos/achadha235/composables-998/issues/events{/number}","events_url":"https://api.github.com/repos/achadha235/composables-998/events","assignees_url":"https://api.github.com/repos/achadha235/composables-998/assignees{/user}","branches_url":"https://api.github.com/repos/achadha235/composables-998/branches{/branch}","tags_url":"https://api.github.com/repos/achadha235/composables-998/tags","blobs_url":"https://api.github.com/repos/achadha235/composables-998/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achadha235/composables-998/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achadha235/composables-998/git/refs{/sha}","trees_url":"https://api.github.com/repos/achadha235/composables-998/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achadha235/composables-998/statuses/{sha}","languages_url":"https://api.github.com/repos/achadha235/composables-998/languages","stargazers_url":"https://api.github.com/repos/achadha235/composables-998/stargazers","contributors_url":"https://api.github.com/repos/achadha235/composables-998/contributors","subscribers_url":"https://api.github.com/repos/achadha235/composables-998/subscribers","subscription_url":"https://api.github.com/repos/achadha235/composables-998/subscription","commits_url":"https://api.github.com/repos/achadha235/composables-998/commits{/sha}","git_commits_url":"https://api.github.com/repos/achadha235/composables-998/git/commits{/sha}","comments_url":"https://api.github.com/repos/achadha235/composables-998/comments{/number}","issue_comment_url":"https://api.github.com/repos/achadha235/composables-998/issues/comments{/number}","contents_url":"https://api.github.com/repos/achadha235/composables-998/contents/{+path}","compare_url":"https://api.github.com/repos/achadha235/composables-998/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achadha235/composables-998/merges","archive_url":"https://api.github.com/repos/achadha235/composables-998/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achadha235/composables-998/downloads","issues_url":"https://api.github.com/repos/achadha235/composables-998/issues{/number}","pulls_url":"https://api.github.com/repos/achadha235/composables-998/pulls{/number}","milestones_url":"https://api.github.com/repos/achadha235/composables-998/milestones{/number}","notifications_url":"https://api.github.com/repos/achadha235/composables-998/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achadha235/composables-998/labels{/name}","releases_url":"https://api.github.com/repos/achadha235/composables-998/releases{/id}","deployments_url":"https://api.github.com/repos/achadha235/composables-998/deployments","created_at":"2018-06-12T16:14:11Z","updated_at":"2018-06-14T08:22:19Z","pushed_at":"2018-06-14T08:22:18Z","git_url":"git://github.com/achadha235/composables-998.git","ssh_url":"git@github.com:achadha235/composables-998.git","clone_url":"https://github.com/achadha235/composables-998.git","svn_url":"https://github.com/achadha235/composables-998","homepage":null,"size":559,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattlockyer:master","ref":"master","sha":"aaf1b66089ad0668b16701cc0d08ca86ebcf637d","user":{"login":"mattlockyer","id":321340,"node_id":"MDQ6VXNlcjMyMTM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/321340?v=4","gravatar_id":"","url":"https://api.github.com/users/mattlockyer","html_url":"https://github.com/mattlockyer","followers_url":"https://api.github.com/users/mattlockyer/followers","following_url":"https://api.github.com/users/mattlockyer/following{/other_user}","gists_url":"https://api.github.com/users/mattlockyer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattlockyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattlockyer/subscriptions","organizations_url":"https://api.github.com/users/mattlockyer/orgs","repos_url":"https://api.github.com/users/mattlockyer/repos","events_url":"https://api.github.com/users/mattlockyer/events{/privacy}","received_events_url":"https://api.github.com/users/mattlockyer/received_events","type":"User","site_admin":false},"repo":{"id":130340045,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzNDAwNDU=","name":"composables-998","full_name":"mattlockyer/composables-998","owner":{"login":"mattlockyer","id":321340,"node_id":"MDQ6VXNlcjMyMTM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/321340?v=4","gravatar_id":"","url":"https://api.github.com/users/mattlockyer","html_url":"https://github.com/mattlockyer","followers_url":"https://api.github.com/users/mattlockyer/followers","following_url":"https://api.github.com/users/mattlockyer/following{/other_user}","gists_url":"https://api.github.com/users/mattlockyer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattlockyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattlockyer/subscriptions","organizations_url":"https://api.github.com/users/mattlockyer/orgs","repos_url":"https://api.github.com/users/mattlockyer/repos","events_url":"https://api.github.com/users/mattlockyer/events{/privacy}","received_events_url":"https://api.github.com/users/mattlockyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattlockyer/composables-998","description":"An implementation and documentation repo for developing the ERC-998 standard for Ethereum.","fork":false,"url":"https://api.github.com/repos/mattlockyer/composables-998","forks_url":"https://api.github.com/repos/mattlockyer/composables-998/forks","keys_url":"https://api.github.com/repos/mattlockyer/composables-998/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattlockyer/composables-998/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattlockyer/composables-998/teams","hooks_url":"https://api.github.com/repos/mattlockyer/composables-998/hooks","issue_events_url":"https://api.github.com/repos/mattlockyer/composables-998/issues/events{/number}","events_url":"https://api.github.com/repos/mattlockyer/composables-998/events","assignees_url":"https://api.github.com/repos/mattlockyer/composables-998/assignees{/user}","branches_url":"https://api.github.com/repos/mattlockyer/composables-998/branches{/branch}","tags_url":"https://api.github.com/repos/mattlockyer/composables-998/tags","blobs_url":"https://api.github.com/repos/mattlockyer/composables-998/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattlockyer/composables-998/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattlockyer/composables-998/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattlockyer/composables-998/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattlockyer/composables-998/statuses/{sha}","languages_url":"https://api.github.com/repos/mattlockyer/composables-998/languages","stargazers_url":"https://api.github.com/repos/mattlockyer/composables-998/stargazers","contributors_url":"https://api.github.com/repos/mattlockyer/composables-998/contributors","subscribers_url":"https://api.github.com/repos/mattlockyer/composables-998/subscribers","subscription_url":"https://api.github.com/repos/mattlockyer/composables-998/subscription","commits_url":"https://api.github.com/repos/mattlockyer/composables-998/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattlockyer/composables-998/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattlockyer/composables-998/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattlockyer/composables-998/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattlockyer/composables-998/contents/{+path}","compare_url":"https://api.github.com/repos/mattlockyer/composables-998/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattlockyer/composables-998/merges","archive_url":"https://api.github.com/repos/mattlockyer/composables-998/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattlockyer/composables-998/downloads","issues_url":"https://api.github.com/repos/mattlockyer/composables-998/issues{/number}","pulls_url":"https://api.github.com/repos/mattlockyer/composables-998/pulls{/number}","milestones_url":"https://api.github.com/repos/mattlockyer/composables-998/milestones{/number}","notifications_url":"https://api.github.com/repos/mattlockyer/composables-998/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattlockyer/composables-998/labels{/name}","releases_url":"https://api.github.com/repos/mattlockyer/composables-998/releases{/id}","deployments_url":"https://api.github.com/repos/mattlockyer/composables-998/deployments","created_at":"2018-04-20T09:23:07Z","updated_at":"2018-06-13T21:55:22Z","pushed_at":"2018-06-14T06:16:36Z","git_url":"git://github.com/mattlockyer/composables-998.git","ssh_url":"git@github.com:mattlockyer/composables-998.git","clone_url":"https://github.com/mattlockyer/composables-998.git","svn_url":"https://github.com/mattlockyer/composables-998","homepage":null,"size":558,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12"},"html":{"href":"https://github.com/mattlockyer/composables-998/pull/12"},"issue":{"href":"https://api.github.com/repos/mattlockyer/composables-998/issues/12"},"comments":{"href":"https://api.github.com/repos/mattlockyer/composables-998/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mattlockyer/composables-998/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattlockyer/composables-998/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mattlockyer/composables-998/statuses/17fe78cc9318d0ec9cac0b66e69351d44ebde4bf"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":138,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"achadha235"}}