{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/183634183","pull_request_review_id":114666552,"id":183634183,"diff_hunk":"@@ -47,7 +47,7 @@\n         = _(\"Web Services\")\n       = miq_tab_header('ipmi', nil, {'ng-click' => \"changeAuthTab('ipmi')\"}) do\n         = _(\"IPMI\")\n-    - elsif %w(ems_network).include?(controller_name)\n+    - elsif %w(ems_network).include?(controller_name) && record.emstype == 'nuage_network'","path":"app/views/layouts/angular/_multi_auth_credentials.html.haml","position":5,"original_position":5,"commit_id":"d2939cf9126814fabb0782d70a9af59f1ecb2069","original_commit_id":"d2939cf9126814fabb0782d70a9af59f1ecb2069","user":{"login":"mzazrivec","id":6648365,"avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"body":"We'd like to avoid constructs like the above as much as possible and use `supports?` mechanism instead.","created_at":"2018-04-24T07:49:50Z","updated_at":"2018-04-24T07:49:50Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832#discussion_r183634183","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/183634183"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832#discussion_r183634183"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832","id":183609737,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3832","number":3832,"state":"open","locked":false,"title":"Bug 1518304: Don't show events tab for openstack network provider edit","user":{"login":"sseago","id":1120000,"avatar_url":"https://avatars3.githubusercontent.com/u/1120000?v=4","gravatar_id":"","url":"https://api.github.com/users/sseago","html_url":"https://github.com/sseago","followers_url":"https://api.github.com/users/sseago/followers","following_url":"https://api.github.com/users/sseago/following{/other_user}","gists_url":"https://api.github.com/users/sseago/gists{/gist_id}","starred_url":"https://api.github.com/users/sseago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sseago/subscriptions","organizations_url":"https://api.github.com/users/sseago/orgs","repos_url":"https://api.github.com/users/sseago/repos","events_url":"https://api.github.com/users/sseago/events{/privacy}","received_events_url":"https://api.github.com/users/sseago/received_events","type":"User","site_admin":false},"body":"https://bugzilla.redhat.com/show_bug.cgi?id=1518304\r\n\r\nThe current UI leaves the Events endpoint tab active for openstack network provider\r\nedit, but the tab is empty, since it's hidden for network providers except for\r\nnuage_network. With this change, the tab link is hidden in cases where the\r\ntab content is empty.\r\n\r\n\r\n","created_at":"2018-04-24T03:11:15Z","updated_at":"2018-04-24T07:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f954c632f7018e477f2ffa67059a8325c3585c48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":505074429,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/bug","name":"bug","color":"ee0701","default":true},{"id":736077187,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3832/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/d2939cf9126814fabb0782d70a9af59f1ecb2069","head":{"label":"sseago:network_provider_events_ui","ref":"network_provider_events_ui","sha":"d2939cf9126814fabb0782d70a9af59f1ecb2069","user":{"login":"sseago","id":1120000,"avatar_url":"https://avatars3.githubusercontent.com/u/1120000?v=4","gravatar_id":"","url":"https://api.github.com/users/sseago","html_url":"https://github.com/sseago","followers_url":"https://api.github.com/users/sseago/followers","following_url":"https://api.github.com/users/sseago/following{/other_user}","gists_url":"https://api.github.com/users/sseago/gists{/gist_id}","starred_url":"https://api.github.com/users/sseago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sseago/subscriptions","organizations_url":"https://api.github.com/users/sseago/orgs","repos_url":"https://api.github.com/users/sseago/repos","events_url":"https://api.github.com/users/sseago/events{/privacy}","received_events_url":"https://api.github.com/users/sseago/received_events","type":"User","site_admin":false},"repo":{"id":77863596,"name":"manageiq-ui-classic","full_name":"sseago/manageiq-ui-classic","owner":{"login":"sseago","id":1120000,"avatar_url":"https://avatars3.githubusercontent.com/u/1120000?v=4","gravatar_id":"","url":"https://api.github.com/users/sseago","html_url":"https://github.com/sseago","followers_url":"https://api.github.com/users/sseago/followers","following_url":"https://api.github.com/users/sseago/following{/other_user}","gists_url":"https://api.github.com/users/sseago/gists{/gist_id}","starred_url":"https://api.github.com/users/sseago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sseago/subscriptions","organizations_url":"https://api.github.com/users/sseago/orgs","repos_url":"https://api.github.com/users/sseago/repos","events_url":"https://api.github.com/users/sseago/events{/privacy}","received_events_url":"https://api.github.com/users/sseago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sseago/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/sseago/manageiq-ui-classic","forks_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/sseago/manageiq-ui-classic/deployments","created_at":"2017-01-02T21:41:06Z","updated_at":"2017-01-02T21:41:12Z","pushed_at":"2018-04-24T03:10:15Z","git_url":"git://github.com/sseago/manageiq-ui-classic.git","ssh_url":"git@github.com:sseago/manageiq-ui-classic.git","clone_url":"https://github.com/sseago/manageiq-ui-classic.git","svn_url":"https://github.com/sseago/manageiq-ui-classic","homepage":null,"size":54545,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"1387e2aeee9955ea172c47437813a6d4213f9da9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2018-04-23T15:07:32Z","pushed_at":"2018-04-24T03:11:16Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":62482,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":241,"open_issues":293,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3832"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3832"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3832/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3832/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/d2939cf9126814fabb0782d70a9af59f1ecb2069"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mzazrivec"}}