{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/17716","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/17716/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/17716/comments","events_url":"https://api.github.com/repos/apple/swift/issues/17716/events","html_url":"https://github.com/apple/swift/pull/17716","id":338045458,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDc2NzA3","number":17716,"title":"Add constraints to FixedWidthInteger.Stride and .Magnitude","user":{"login":"stephentyrone","id":641446,"node_id":"MDQ6VXNlcjY0MTQ0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/641446?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentyrone","html_url":"https://github.com/stephentyrone","followers_url":"https://api.github.com/users/stephentyrone/followers","following_url":"https://api.github.com/users/stephentyrone/following{/other_user}","gists_url":"https://api.github.com/users/stephentyrone/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentyrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentyrone/subscriptions","organizations_url":"https://api.github.com/users/stephentyrone/orgs","repos_url":"https://api.github.com/users/stephentyrone/repos","events_url":"https://api.github.com/users/stephentyrone/events{/privacy}","received_events_url":"https://api.github.com/users/stephentyrone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-07-03T20:34:47Z","updated_at":"2018-07-04T05:20:39Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17716","html_url":"https://github.com/apple/swift/pull/17716","diff_url":"https://github.com/apple/swift/pull/17716.diff","patch_url":"https://github.com/apple/swift/pull/17716.patch"},"body":"Add the constraint that these associatedtypes themselves conform to FixedWidthInteger and to SignedInteger and UnsignedInteger, respectively. These are effectively part of the semantic requirement of the protocol already, because the requirements on .min and .max effectively force FixedWidthInteger to be twos-complement, which requires Magnitude not be Self for signed types. Also, in practice it's generally necessary to have these two constraints in order to effectively use the FixedWidthInteger protocol anyway; witness that by adding them to the protocol, we eliminate them as constraints from a number of extensions.\r\n\r\nResolves [SR-8156](https://bugs.swift.org/browse/SR-8156)."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/402366166","html_url":"https://github.com/apple/swift/pull/17716#issuecomment-402366166","issue_url":"https://api.github.com/repos/apple/swift/issues/17716","id":402366166,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjM2NjE2Ng==","user":{"login":"swift-ci","id":15467072,"node_id":"MDQ6VXNlcjE1NDY3MDcy","avatar_url":"https://avatars0.githubusercontent.com/u/15467072?v=4","gravatar_id":"","url":"https://api.github.com/users/swift-ci","html_url":"https://github.com/swift-ci","followers_url":"https://api.github.com/users/swift-ci/followers","following_url":"https://api.github.com/users/swift-ci/following{/other_user}","gists_url":"https://api.github.com/users/swift-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-ci/subscriptions","organizations_url":"https://api.github.com/users/swift-ci/orgs","repos_url":"https://api.github.com/users/swift-ci/repos","events_url":"https://api.github.com/users/swift-ci/events{/privacy}","received_events_url":"https://api.github.com/users/swift-ci/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T05:20:39Z","updated_at":"2018-07-04T05:20:39Z","author_association":"CONTRIBUTOR","body":"Build comment file: \n--------------\n# Summary for master full\n\n**Unexpected test results, excluded stats for Core, xcproj, StencilSwiftKit, CoreStore, Turnstile, ObjectMapper**\n\n**Regressions found (see below)**\n\n- [Debug-batch](#debug-batch-7509fbfe56d094f6)\n    - [debug-batch brief](#debug-batch-brief-7509fbfe56d094f6)\n    - [debug-batch detailed](#debug-batch-detailed-7509fbfe56d094f6)\n- [Release](#release-7509fbfe56d094f6)\n    - [release brief](#release-brief-7509fbfe56d094f6)\n    - [release detailed](#release-detailed-7509fbfe56d094f6)\n\n\n\n<a name=\"debug-batch-7509fbfe56d094f6\">\n\n# Debug-batch\n\n<a name=\"debug-batch-brief-7509fbfe56d094f6\">\n\n## debug-batch brief\n<details>\n<summary>Regressed (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Improved (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nLLVM.NumLLVMBytesOutput | 1,137,323,640 | 1,137,325,054 | 1,414 | 0.0%\ntime.swift-driver.wall | 2213.0s | 2234.6s | 21.6s | 0.98%\n</details>\n\n<a name=\"debug-batch-detailed-7509fbfe56d094f6\">\n\n## debug-batch detailed\n<details>\n<summary>Regressed (1)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumASTBytesAllocated | 27,518,189,065 | 28,213,293,935 | 695,104,870 | 2.53% :no_entry:\n</details>\n<details>\n<summary>Improved (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumSourceLinesPerSecond | 1,770,416 | 1,728,123 | -42,293 | -2.39% :white_check_mark:\nSema.SuperclassTypeRequest | 132,285 | 55,989 | -76,296 | -57.68% :white_check_mark:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (74)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumDecls | 82,964 | 82,964 | 0 | 0.0%\nAST.NumDependencies | 158,496 | 158,518 | 22 | 0.01%\nAST.NumImportedExternalDefinitions | 1,394,849 | 1,394,849 | 0 | 0.0%\nAST.NumInfixOperators | 26,388 | 26,388 | 0 | 0.0%\nAST.NumLinkLibraries | 0 | 0 | 0 | 0.0%\nAST.NumLoadedModules | 207,331 | 207,331 | 0 | 0.0%\nAST.NumLocalTypeDecls | 8 | 8 | 0 | 0.0%\nAST.NumObjCMethods | 22,546 | 22,546 | 0 | 0.0%\nAST.NumPostfixOperators | 14 | 14 | 0 | 0.0%\nAST.NumPrecedenceGroups | 16,201 | 16,201 | 0 | 0.0%\nAST.NumPrefixOperators | 127 | 127 | 0 | 0.0%\nAST.NumReferencedDynamicNames | 180 | 180 | 0 | 0.0%\nAST.NumReferencedMemberNames | 3,795,617 | 3,795,628 | 11 | 0.0%\nAST.NumReferencedTopLevelNames | 272,867 | 272,867 | 0 | 0.0%\nAST.NumSourceBuffers | 362,793 | 362,793 | 0 | 0.0%\nAST.NumSourceLines | 2,351,367 | 2,351,367 | 0 | 0.0%\nAST.NumTotalClangImportedEntities | 4,586,913 | 4,586,913 | 0 | 0.0%\nAST.NumUsedConformances | 196,467 | 196,457 | -10 | -0.01%\nDriver.ChildrenMaxRSS | 70,709,667,840 | 71,250,812,928 | 541,145,088 | 0.77%\nDriver.DriverDepCascadingDynamic | 0 | 0 | 0 | 0.0%\nDriver.DriverDepCascadingExternal | 0 | 0 | 0 | 0.0%\nDriver.DriverDepCascadingMember | 0 | 0 | 0 | 0.0%\nDriver.DriverDepCascadingNominal | 0 | 0 | 0 | 0.0%\nDriver.DriverDepCascadingTopLevel | 0 | 0 | 0 | 0.0%\nDriver.DriverDepDynamic | 0 | 0 | 0 | 0.0%\nDriver.DriverDepExternal | 0 | 0 | 0 | 0.0%\nDriver.DriverDepMember | 0 | 0 | 0 | 0.0%\nDriver.DriverDepNominal | 0 | 0 | 0 | 0.0%\nDriver.DriverDepTopLevel | 0 | 0 | 0 | 0.0%\nDriver.NumDriverJobsRun | 16,691 | 16,691 | 0 | 0.0%\nDriver.NumDriverJobsSkipped | 0 | 0 | 0 | 0.0%\nDriver.NumDriverPipePolls | 266,966 | 268,822 | 1,856 | 0.7%\nDriver.NumDriverPipeReads | 292,115 | 291,907 | -208 | -0.07%\nDriver.NumProcessFailures | 0 | 0 | 0 | 0.0%\nFrontend.NumProcessFailures | 0 | 0 | 0 | 0.0%\nIRModule.NumIRAliases | 13,236 | 13,236 | 0 | 0.0%\nIRModule.NumIRBasicBlocks | 3,757,962 | 3,757,962 | 0 | 0.0%\nIRModule.NumIRComdatSymbols | 0 | 0 | 0 | 0.0%\nIRModule.NumIRFunctions | 2,146,382 | 2,146,382 | 0 | 0.0%\nIRModule.NumIRGlobals | 2,274,223 | 2,274,218 | -5 | -0.0%\nIRModule.NumIRIFuncs | 0 | 0 | 0 | 0.0%\nIRModule.NumIRInsts | 42,169,073 | 42,169,073 | 0 | 0.0%\nIRModule.NumIRNamedMetaData | 81,820 | 81,820 | 0 | 0.0%\nIRModule.NumIRValueSymbols | 3,914,175 | 3,914,170 | -5 | -0.0%\nLLVM.NumLLVMBytesOutput | 1,137,323,640 | 1,137,325,054 | 1,414 | 0.0%\nParse.NumFunctionsParsed | 149,311 | 149,311 | 0 | 0.0%\nSILModule.NumSILGenDefaultWitnessTables | 0 | 0 | 0 | 0.0%\nSILModule.NumSILGenFunctions | 1,529,462 | 1,529,462 | 0 | 0.0%\nSILModule.NumSILGenGlobalVariables | 24,821 | 24,821 | 0 | 0.0%\nSILModule.NumSILGenVtables | 16,289 | 16,289 | 0 | 0.0%\nSILModule.NumSILGenWitnessTables | 42,913 | 42,913 | 0 | 0.0%\nSILModule.NumSILOptDefaultWitnessTables | 0 | 0 | 0 | 0.0%\nSILModule.NumSILOptFunctions | 1,385,772 | 1,385,772 | 0 | 0.0%\nSILModule.NumSILOptGlobalVariables | 25,588 | 25,588 | 0 | 0.0%\nSILModule.NumSILOptVtables | 25,013 | 25,013 | 0 | 0.0%\nSILModule.NumSILOptWitnessTables | 74,612 | 74,612 | 0 | 0.0%\nSema.EnumRawTypeRequest | 14,950 | 14,950 | 0 | 0.0%\nSema.InheritedTypeRequest | 96,048 | 96,048 | 0 | 0.0%\nSema.NamedLazyMemberLoadFailureCount | 23,483 | 23,483 | 0 | 0.0%\nSema.NamedLazyMemberLoadSuccessCount | 3,941,281 | 3,940,856 | -425 | -0.01%\nSema.NominalTypeLookupDirectCount | 28,663,848 | 28,661,864 | -1,984 | -0.01%\nSema.NumConformancesDeserialized | 4,815,717 | 4,824,766 | 9,049 | 0.19%\nSema.NumConstraintScopes | 10,288,732 | 10,288,790 | 58 | 0.0%\nSema.NumConstraintsConsideredForEdgeContraction | 30,213,326 | 30,213,153 | -173 | -0.0%\nSema.NumDeclsDeserialized | 33,901,345 | 33,969,559 | 68,214 | 0.2%\nSema.NumDeclsValidated | 2,891,528 | 2,891,649 | 121 | 0.0%\nSema.NumFunctionsTypechecked | 925,101 | 925,101 | 0 | 0.0%\nSema.NumGenericSignatureBuilders | 1,624,362 | 1,617,735 | -6,627 | -0.41%\nSema.NumLazyGenericEnvironments | 6,542,063 | 6,572,436 | 30,373 | 0.46%\nSema.NumLazyGenericEnvironmentsLoaded | 745,060 | 745,061 | 1 | 0.0%\nSema.NumLazyIterableDeclContexts | 5,633,443 | 5,663,771 | 30,328 | 0.54%\nSema.NumTypesDeserialized | 35,639,107 | 35,901,938 | 262,831 | 0.74%\nSema.NumTypesValidated | 3,039,718 | 3,039,780 | 62 | 0.0%\nSema.NumUnloadedLazyIterableDeclContexts | 3,802,062 | 3,832,395 | 30,333 | 0.8%\n</details>\n\n<a name=\"release-7509fbfe56d094f6\">\n\n# Release\n\n<a name=\"release-brief-7509fbfe56d094f6\">\n\n## release brief\n<details>\n<summary>Regressed (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Improved (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (2)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nLLVM.NumLLVMBytesOutput | 988,672,576 | 988,672,244 | -332 | -0.0%\ntime.swift-driver.wall | 3624.5s | 3636.9s | 12.4s | 0.34%\n</details>\n\n<a name=\"release-detailed-7509fbfe56d094f6\">\n\n## release detailed\n<details>\n<summary>Regressed (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Improved (0)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\n</details>\n<details>\n<summary>Unchanged (delta < 1.0% or delta < 100.0ms) (23)</summary>\n\nname | old | new | delta | delta_pct\n---: | ---: | ---: | ---: | ---:\nAST.NumImportedExternalDefinitions | 309,933 | 309,933 | 0 | 0.0%\nAST.NumLoadedModules | 19,326 | 19,326 | 0 | 0.0%\nAST.NumTotalClangImportedEntities | 1,012,211 | 1,012,211 | 0 | 0.0%\nAST.NumUsedConformances | 201,980 | 201,970 | -10 | -0.0%\nIRModule.NumIRBasicBlocks | 3,133,390 | 3,133,390 | 0 | 0.0%\nIRModule.NumIRFunctions | 1,737,620 | 1,737,620 | 0 | 0.0%\nIRModule.NumIRGlobals | 1,890,833 | 1,890,828 | -5 | -0.0%\nIRModule.NumIRInsts | 29,850,598 | 29,850,598 | 0 | 0.0%\nIRModule.NumIRValueSymbols | 3,326,865 | 3,326,860 | -5 | -0.0%\nLLVM.NumLLVMBytesOutput | 988,672,576 | 988,672,244 | -332 | -0.0%\nSILModule.NumSILGenFunctions | 739,648 | 739,648 | 0 | 0.0%\nSILModule.NumSILOptFunctions | 999,915 | 999,915 | 0 | 0.0%\nSema.NumConformancesDeserialized | 2,315,353 | 2,323,890 | 8,537 | 0.37%\nSema.NumConstraintScopes | 10,170,429 | 10,170,502 | 73 | 0.0%\nSema.NumDeclsDeserialized | 7,217,770 | 7,221,094 | 3,324 | 0.05%\nSema.NumDeclsValidated | 2,086,914 | 2,086,922 | 8 | 0.0%\nSema.NumFunctionsTypechecked | 418,120 | 418,120 | 0 | 0.0%\nSema.NumGenericSignatureBuilders | 356,035 | 356,029 | -6 | -0.0%\nSema.NumLazyGenericEnvironments | 1,249,483 | 1,250,908 | 1,425 | 0.11%\nSema.NumLazyGenericEnvironmentsLoaded | 152,831 | 152,831 | 0 | 0.0%\nSema.NumLazyIterableDeclContexts | 850,001 | 851,424 | 1,423 | 0.17%\nSema.NumTypesDeserialized | 8,734,567 | 8,755,244 | 20,677 | 0.24%\nSema.NumTypesValidated | 1,366,152 | 1,366,194 | 42 | 0.0%\n</details>\n\n--------------\n"}}
{"actor":{"display_login":"swift-ci"}}