{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/205511750","pull_request_review_id":140796198,"id":205511750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTUxMTc1MA==","diff_hunk":"@@ -80,6 +89,29 @@ def action_setup\n           raise message\n         end\n       end\n+\n+      def _fix_acl(certificate, group)","path":"chef/cookbooks/crowbar-openstack/libraries/provider_ssl_setup.rb","position":21,"original_position":21,"commit_id":"68a9047d9a08ce3f9b4fc3f883a114ab171e681d","original_commit_id":"68a9047d9a08ce3f9b4fc3f883a114ab171e681d","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/CyclomaticComplexity: Cyclomatic complexity for _fix_acl is too high. [8/6]<br>Metrics/PerceivedComplexity: Perceived complexity for _fix_acl is too high. [9/7]","created_at":"2018-07-26T15:57:20Z","updated_at":"2018-07-26T15:57:21Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1717#discussion_r205511750","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/205511750"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1717#discussion_r205511750"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717","id":203868775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODY4Nzc1","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1717","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1717.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1717.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1717","number":1717,"state":"open","locked":false,"title":"Set a proper ACL for shared certificates (bsc#1101154)","user":{"login":"aplanas","id":645701,"node_id":"MDQ6VXNlcjY0NTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/645701?v=4","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},"body":"If the user is sharing a certificate between different OpenStack\r\nservices, this needs to be readed for different system users.  For\r\nexample, if the client store the certificate in /etc/apache2/ssl.key,\r\nthis directory and all the parents needs to be read for all the\r\nOpenStack service users, and also the certificates contained there.\r\n\r\nTo address that we use the ACL from the operating system, via the\r\n`setfacl` command.\r\n\r\n(cherry picked from commit af89dd5de374eb0f9f84c35370f8e8dc166e8771)","created_at":"2018-07-25T15:05:13Z","updated_at":"2018-07-26T15:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"465a6ce21d8cf1651b78bf4838ddd25fae7b3471","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1717/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/68a9047d9a08ce3f9b4fc3f883a114ab171e681d","head":{"label":"aplanas:bsc1101154_stable","ref":"bsc1101154_stable","sha":"68a9047d9a08ce3f9b4fc3f883a114ab171e681d","user":{"login":"aplanas","id":645701,"node_id":"MDQ6VXNlcjY0NTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/645701?v=4","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},"repo":{"id":41664449,"node_id":"MDEwOlJlcG9zaXRvcnk0MTY2NDQ0OQ==","name":"crowbar-openstack","full_name":"aplanas/crowbar-openstack","owner":{"login":"aplanas","id":645701,"node_id":"MDQ6VXNlcjY0NTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/645701?v=4","gravatar_id":"","url":"https://api.github.com/users/aplanas","html_url":"https://github.com/aplanas","followers_url":"https://api.github.com/users/aplanas/followers","following_url":"https://api.github.com/users/aplanas/following{/other_user}","gists_url":"https://api.github.com/users/aplanas/gists{/gist_id}","starred_url":"https://api.github.com/users/aplanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aplanas/subscriptions","organizations_url":"https://api.github.com/users/aplanas/orgs","repos_url":"https://api.github.com/users/aplanas/repos","events_url":"https://api.github.com/users/aplanas/events{/privacy}","received_events_url":"https://api.github.com/users/aplanas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aplanas/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/aplanas/crowbar-openstack","forks_url":"https://api.github.com/repos/aplanas/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/aplanas/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aplanas/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aplanas/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/aplanas/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/aplanas/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/aplanas/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/aplanas/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/aplanas/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/aplanas/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/aplanas/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aplanas/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aplanas/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/aplanas/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aplanas/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/aplanas/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/aplanas/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/aplanas/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/aplanas/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/aplanas/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/aplanas/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/aplanas/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/aplanas/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/aplanas/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/aplanas/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/aplanas/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aplanas/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/aplanas/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aplanas/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/aplanas/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/aplanas/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/aplanas/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/aplanas/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aplanas/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/aplanas/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/aplanas/crowbar-openstack/deployments","created_at":"2015-08-31T08:26:34Z","updated_at":"2018-07-20T09:27:47Z","pushed_at":"2018-07-26T15:57:10Z","git_url":"git://github.com/aplanas/crowbar-openstack.git","ssh_url":"git@github.com:aplanas/crowbar-openstack.git","clone_url":"https://github.com/aplanas/crowbar-openstack.git","svn_url":"https://github.com/aplanas/crowbar-openstack","homepage":null,"size":21134,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:stable/4.0","ref":"stable/4.0","sha":"8905289aec0176a52c86633faed792086dde7d31","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwNjkwMw==","name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-07-24T08:46:08Z","pushed_at":"2018-07-26T15:57:11Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":21124,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":81,"license":null,"forks":85,"open_issues":81,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1717"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1717"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1717/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1717/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/68a9047d9a08ce3f9b4fc3f883a114ab171e681d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}