{"action":"created","comment":{"url":"https://api.github.com/repos/apache/jmeter/pulls/comments/167627478","pull_request_review_id":95873224,"id":167627478,"diff_hunk":"@@ -328,17 +304,13 @@ public void setXML() {\n \n     /**\n      * Check if xml validation mode is set\n-     * \n-     * @return boolean\n      */\n     public boolean isXML() {\n         return getPropertyAsLong(FORMAT_KEY) == 2;\n     }\n \n     /**\n-     * Sets the name of the file where tidy writes the output to\n-     * \n-     * @return name of file\n+     * Gets the name of the file where tidy writes the output to","path":"src/components/org/apache/jmeter/assertions/HTMLAssertion.java","position":271,"original_position":271,"commit_id":"a79f1c0921cbaf1e2fe03b7143b0fea50295b6fc","original_commit_id":"258a1542b7c720dfbf88e1f51b88c532439f2d2b","user":{"login":"FSchumacher","id":1997314,"avatar_url":"https://avatars3.githubusercontent.com/u/1997314?v=4","gravatar_id":"","url":"https://api.github.com/users/FSchumacher","html_url":"https://github.com/FSchumacher","followers_url":"https://api.github.com/users/FSchumacher/followers","following_url":"https://api.github.com/users/FSchumacher/following{/other_user}","gists_url":"https://api.github.com/users/FSchumacher/gists{/gist_id}","starred_url":"https://api.github.com/users/FSchumacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FSchumacher/subscriptions","organizations_url":"https://api.github.com/users/FSchumacher/orgs","repos_url":"https://api.github.com/users/FSchumacher/repos","events_url":"https://api.github.com/users/FSchumacher/events{/privacy}","received_events_url":"https://api.github.com/users/FSchumacher/received_events","type":"User","site_admin":false},"body":"If we remove the return tag, javadoc will complain.","created_at":"2018-02-12T17:24:51Z","updated_at":"2018-02-12T17:24:51Z","html_url":"https://github.com/apache/jmeter/pull/356#discussion_r167627478","pull_request_url":"https://api.github.com/repos/apache/jmeter/pulls/356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/jmeter/pulls/comments/167627478"},"html":{"href":"https://github.com/apache/jmeter/pull/356#discussion_r167627478"},"pull_request":{"href":"https://api.github.com/repos/apache/jmeter/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/apache/jmeter/pulls/356","id":157694772,"html_url":"https://github.com/apache/jmeter/pull/356","diff_url":"https://github.com/apache/jmeter/pull/356.diff","patch_url":"https://github.com/apache/jmeter/pull/356.patch","issue_url":"https://api.github.com/repos/apache/jmeter/issues/356","number":356,"state":"open","locked":false,"title":"Sonar fixes","user":{"login":"ham1","id":3393038,"avatar_url":"https://avatars2.githubusercontent.com/u/3393038?v=4","gravatar_id":"","url":"https://api.github.com/users/ham1","html_url":"https://github.com/ham1","followers_url":"https://api.github.com/users/ham1/followers","following_url":"https://api.github.com/users/ham1/following{/other_user}","gists_url":"https://api.github.com/users/ham1/gists{/gist_id}","starred_url":"https://api.github.com/users/ham1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ham1/subscriptions","organizations_url":"https://api.github.com/users/ham1/orgs","repos_url":"https://api.github.com/users/ham1/repos","events_url":"https://api.github.com/users/ham1/events{/privacy}","received_events_url":"https://api.github.com/users/ham1/received_events","type":"User","site_admin":false},"body":"## Description\r\n* Removed `clone()` methods which just called `super.clone()`\r\n* Reduced size/complexity of methods by breaking them into smaller ones and/or reducing nesting\r\n* Replaced `size() == 0` with `isEmpty()`\r\n* Formatting\r\n* Removed blank or useless comments\r\n\r\n## How Has This Been Tested?\r\nant test\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n- Dev fix\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [code style][style-guide] of this project.\r\n- [x] I have updated the documentation accordingly.\r\n\r\n[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines\r\n","created_at":"2017-12-11T23:02:11Z","updated_at":"2018-02-12T17:24:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0da300bdf29762ba5746c298a4e2cb7f6a40abcb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/jmeter/pulls/356/commits","review_comments_url":"https://api.github.com/repos/apache/jmeter/pulls/356/comments","review_comment_url":"https://api.github.com/repos/apache/jmeter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/jmeter/issues/356/comments","statuses_url":"https://api.github.com/repos/apache/jmeter/statuses/a79f1c0921cbaf1e2fe03b7143b0fea50295b6fc","head":{"label":"ham1:sonar_fixes","ref":"sonar_fixes","sha":"a79f1c0921cbaf1e2fe03b7143b0fea50295b6fc","user":{"login":"ham1","id":3393038,"avatar_url":"https://avatars2.githubusercontent.com/u/3393038?v=4","gravatar_id":"","url":"https://api.github.com/users/ham1","html_url":"https://github.com/ham1","followers_url":"https://api.github.com/users/ham1/followers","following_url":"https://api.github.com/users/ham1/following{/other_user}","gists_url":"https://api.github.com/users/ham1/gists{/gist_id}","starred_url":"https://api.github.com/users/ham1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ham1/subscriptions","organizations_url":"https://api.github.com/users/ham1/orgs","repos_url":"https://api.github.com/users/ham1/repos","events_url":"https://api.github.com/users/ham1/events{/privacy}","received_events_url":"https://api.github.com/users/ham1/received_events","type":"User","site_admin":false},"repo":{"id":51246359,"name":"jmeter","full_name":"ham1/jmeter","owner":{"login":"ham1","id":3393038,"avatar_url":"https://avatars2.githubusercontent.com/u/3393038?v=4","gravatar_id":"","url":"https://api.github.com/users/ham1","html_url":"https://github.com/ham1","followers_url":"https://api.github.com/users/ham1/followers","following_url":"https://api.github.com/users/ham1/following{/other_user}","gists_url":"https://api.github.com/users/ham1/gists{/gist_id}","starred_url":"https://api.github.com/users/ham1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ham1/subscriptions","organizations_url":"https://api.github.com/users/ham1/orgs","repos_url":"https://api.github.com/users/ham1/repos","events_url":"https://api.github.com/users/ham1/events{/privacy}","received_events_url":"https://api.github.com/users/ham1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ham1/jmeter","description":"Mirror of Apache JMeter","fork":true,"url":"https://api.github.com/repos/ham1/jmeter","forks_url":"https://api.github.com/repos/ham1/jmeter/forks","keys_url":"https://api.github.com/repos/ham1/jmeter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ham1/jmeter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ham1/jmeter/teams","hooks_url":"https://api.github.com/repos/ham1/jmeter/hooks","issue_events_url":"https://api.github.com/repos/ham1/jmeter/issues/events{/number}","events_url":"https://api.github.com/repos/ham1/jmeter/events","assignees_url":"https://api.github.com/repos/ham1/jmeter/assignees{/user}","branches_url":"https://api.github.com/repos/ham1/jmeter/branches{/branch}","tags_url":"https://api.github.com/repos/ham1/jmeter/tags","blobs_url":"https://api.github.com/repos/ham1/jmeter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ham1/jmeter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ham1/jmeter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ham1/jmeter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ham1/jmeter/statuses/{sha}","languages_url":"https://api.github.com/repos/ham1/jmeter/languages","stargazers_url":"https://api.github.com/repos/ham1/jmeter/stargazers","contributors_url":"https://api.github.com/repos/ham1/jmeter/contributors","subscribers_url":"https://api.github.com/repos/ham1/jmeter/subscribers","subscription_url":"https://api.github.com/repos/ham1/jmeter/subscription","commits_url":"https://api.github.com/repos/ham1/jmeter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ham1/jmeter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ham1/jmeter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ham1/jmeter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ham1/jmeter/contents/{+path}","compare_url":"https://api.github.com/repos/ham1/jmeter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ham1/jmeter/merges","archive_url":"https://api.github.com/repos/ham1/jmeter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ham1/jmeter/downloads","issues_url":"https://api.github.com/repos/ham1/jmeter/issues{/number}","pulls_url":"https://api.github.com/repos/ham1/jmeter/pulls{/number}","milestones_url":"https://api.github.com/repos/ham1/jmeter/milestones{/number}","notifications_url":"https://api.github.com/repos/ham1/jmeter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ham1/jmeter/labels{/name}","releases_url":"https://api.github.com/repos/ham1/jmeter/releases{/id}","deployments_url":"https://api.github.com/repos/ham1/jmeter/deployments","created_at":"2016-02-07T12:12:57Z","updated_at":"2016-02-07T12:13:04Z","pushed_at":"2018-02-12T13:27:13Z","git_url":"git://github.com/ham1/jmeter.git","ssh_url":"git@github.com:ham1/jmeter.git","clone_url":"https://github.com/ham1/jmeter.git","svn_url":"https://github.com/ham1/jmeter","homepage":null,"size":129296,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"33f09a9652e16220585aa9589a68672292e9bd74","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":688352,"name":"jmeter","full_name":"apache/jmeter","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/jmeter","description":"Mirror of Apache JMeter","fork":false,"url":"https://api.github.com/repos/apache/jmeter","forks_url":"https://api.github.com/repos/apache/jmeter/forks","keys_url":"https://api.github.com/repos/apache/jmeter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/jmeter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/jmeter/teams","hooks_url":"https://api.github.com/repos/apache/jmeter/hooks","issue_events_url":"https://api.github.com/repos/apache/jmeter/issues/events{/number}","events_url":"https://api.github.com/repos/apache/jmeter/events","assignees_url":"https://api.github.com/repos/apache/jmeter/assignees{/user}","branches_url":"https://api.github.com/repos/apache/jmeter/branches{/branch}","tags_url":"https://api.github.com/repos/apache/jmeter/tags","blobs_url":"https://api.github.com/repos/apache/jmeter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/jmeter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/jmeter/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/jmeter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/jmeter/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/jmeter/languages","stargazers_url":"https://api.github.com/repos/apache/jmeter/stargazers","contributors_url":"https://api.github.com/repos/apache/jmeter/contributors","subscribers_url":"https://api.github.com/repos/apache/jmeter/subscribers","subscription_url":"https://api.github.com/repos/apache/jmeter/subscription","commits_url":"https://api.github.com/repos/apache/jmeter/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/jmeter/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/jmeter/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/jmeter/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/jmeter/contents/{+path}","compare_url":"https://api.github.com/repos/apache/jmeter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/jmeter/merges","archive_url":"https://api.github.com/repos/apache/jmeter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/jmeter/downloads","issues_url":"https://api.github.com/repos/apache/jmeter/issues{/number}","pulls_url":"https://api.github.com/repos/apache/jmeter/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/jmeter/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/jmeter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/jmeter/labels{/name}","releases_url":"https://api.github.com/repos/apache/jmeter/releases{/id}","deployments_url":"https://api.github.com/repos/apache/jmeter/deployments","created_at":"2010-05-26T23:38:07Z","updated_at":"2018-02-12T10:00:44Z","pushed_at":"2018-02-12T17:18:21Z","git_url":"git://github.com/apache/jmeter.git","ssh_url":"git@github.com:apache/jmeter.git","clone_url":"https://github.com/apache/jmeter.git","svn_url":"https://github.com/apache/jmeter","homepage":null,"size":152749,"stargazers_count":1594,"watchers_count":1594,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":703,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":703,"open_issues":10,"watchers":1594,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/jmeter/pulls/356"},"html":{"href":"https://github.com/apache/jmeter/pull/356"},"issue":{"href":"https://api.github.com/repos/apache/jmeter/issues/356"},"comments":{"href":"https://api.github.com/repos/apache/jmeter/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/jmeter/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/jmeter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/jmeter/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/apache/jmeter/statuses/a79f1c0921cbaf1e2fe03b7143b0fea50295b6fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"FSchumacher"}}