{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/223967054","pull_request_review_id":163219535,"id":223967054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk2NzA1NA==","diff_hunk":"@@ -0,0 +1,29 @@\n+import React from 'react';","path":"stories/Builders/BadgeSelectItemBuilder/Example.js","position":1,"original_position":1,"commit_id":"56851f40162b62ca3157017743cde93df27a6be8","original_commit_id":"56851f40162b62ca3157017743cde93df27a6be8","user":{"login":"shlomitc","id":6093192,"node_id":"MDQ6VXNlcjYwOTMxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6093192?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomitc","html_url":"https://github.com/shlomitc","followers_url":"https://api.github.com/users/shlomitc/followers","following_url":"https://api.github.com/users/shlomitc/following{/other_user}","gists_url":"https://api.github.com/users/shlomitc/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomitc/subscriptions","organizations_url":"https://api.github.com/users/shlomitc/orgs","repos_url":"https://api.github.com/users/shlomitc/repos","events_url":"https://api.github.com/users/shlomitc/events{/privacy}","received_events_url":"https://api.github.com/users/shlomitc/received_events","type":"User","site_admin":false},"body":"@LittleTal @wuwa - please review this page as well. this is the beginning for the \"Item Builder\" pattern we've been talking about\r\nhttps://wix-wix-style-react-pr-2219.surge.sh/?selectedKind=WIP%2FBuilders&selectedStory=BadgeSelectItemBuilder&full=0&addons=0&stories=1&panelRight=0","created_at":"2018-10-10T07:41:40Z","updated_at":"2018-10-10T07:51:14Z","html_url":"https://github.com/wix/wix-style-react/pull/2219#discussion_r223967054","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2219","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/223967054"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2219#discussion_r223967054"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2219"}}},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/2219","id":214084304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDg0MzA0","html_url":"https://github.com/wix/wix-style-react/pull/2219","diff_url":"https://github.com/wix/wix-style-react/pull/2219.diff","patch_url":"https://github.com/wix/wix-style-react/pull/2219.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/2219","number":2219,"state":"open","locked":false,"title":"Badge group component","user":{"login":"Noam3kCH","id":8627139,"node_id":"MDQ6VXNlcjg2MjcxMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8627139?v=4","gravatar_id":"","url":"https://api.github.com/users/Noam3kCH","html_url":"https://github.com/Noam3kCH","followers_url":"https://api.github.com/users/Noam3kCH/followers","following_url":"https://api.github.com/users/Noam3kCH/following{/other_user}","gists_url":"https://api.github.com/users/Noam3kCH/gists{/gist_id}","starred_url":"https://api.github.com/users/Noam3kCH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noam3kCH/subscriptions","organizations_url":"https://api.github.com/users/Noam3kCH/orgs","repos_url":"https://api.github.com/users/Noam3kCH/repos","events_url":"https://api.github.com/users/Noam3kCH/events{/privacy}","received_events_url":"https://api.github.com/users/Noam3kCH/received_events","type":"User","site_admin":false},"body":"### What changed\r\nGuild Week task 18\r\nAdded new component badge group. which is badge with dropdown to choose other badges.\r\nper zeplin: https://app.zeplin.io/project/5864e02695b5754a69f56150/screen/5a1eee8100d7a41d2f6c7801\r\n\r\n- [x] Change is tested\r\n_component tests completed. e2e tests **not**._  \r\n- [x] Change is documented\r\n_added storybook page under 'Other'_\r\n- [ ] Build is green\r\n_it will not be green until merged wix-ui-backoffice PR: https://github.com/wix/wix-ui-backoffice/pull/216\r\nwhich this change relies on._\r\n- [x] Change of UX is approved by [wuwa](https://github.com/wuwa) or [milkyfruit](https://github.com/milkyfruit)\r\n_it's in zeplin so we assume it is._\r\n\r\n**Caveats - and further work to be done**\r\n- since the badge could potentially change width on every selection, the dropdown width changes accordingly. this could be a problem in various cases. I suggest adding a width param to this component, and as a prerequisite, to the wix-ui-backoffice badge component.\r\n- e2e tests were not added due to time restrictions.\r\n- A driver factory was made per the paradigm of other components, we're unsure about how this is exported into a testkit.\r\n- to test how this looks without merging first, you could build the badgeSize branch on wix-ui-backoffice and copy over the badge component.  \r\n\r\n![image](https://user-images.githubusercontent.com/8627139/45252159-eda14d80-b35a-11e8-8883-5d6e49647fa6.png)\r\n\r\n### Thanks for allowing us to contribute ;)\r\n","created_at":"2018-09-08T08:19:44Z","updated_at":"2018-10-10T07:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b223aeea7f87cbb5693995be77b5ceb9e7dbc4","assignee":{"login":"shlomitc","id":6093192,"node_id":"MDQ6VXNlcjYwOTMxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6093192?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomitc","html_url":"https://github.com/shlomitc","followers_url":"https://api.github.com/users/shlomitc/followers","following_url":"https://api.github.com/users/shlomitc/following{/other_user}","gists_url":"https://api.github.com/users/shlomitc/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomitc/subscriptions","organizations_url":"https://api.github.com/users/shlomitc/orgs","repos_url":"https://api.github.com/users/shlomitc/repos","events_url":"https://api.github.com/users/shlomitc/events{/privacy}","received_events_url":"https://api.github.com/users/shlomitc/received_events","type":"User","site_admin":false},"assignees":[{"login":"shlomitc","id":6093192,"node_id":"MDQ6VXNlcjYwOTMxOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6093192?v=4","gravatar_id":"","url":"https://api.github.com/users/shlomitc","html_url":"https://github.com/shlomitc","followers_url":"https://api.github.com/users/shlomitc/followers","following_url":"https://api.github.com/users/shlomitc/following{/other_user}","gists_url":"https://api.github.com/users/shlomitc/gists{/gist_id}","starred_url":"https://api.github.com/users/shlomitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlomitc/subscriptions","organizations_url":"https://api.github.com/users/shlomitc/orgs","repos_url":"https://api.github.com/users/shlomitc/repos","events_url":"https://api.github.com/users/shlomitc/events{/privacy}","received_events_url":"https://api.github.com/users/shlomitc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2219/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2219/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/2219/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/56851f40162b62ca3157017743cde93df27a6be8","head":{"label":"wix:badgeGroup","ref":"badgeGroup","sha":"56851f40162b62ca3157017743cde93df27a6be8","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-10-09T12:46:31Z","pushed_at":"2018-10-10T07:49:21Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":9107,"stargazers_count":383,"watchers_count":383,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":85,"open_issues":98,"watchers":383,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"14e3159864858db7b6078cc967faab3a1d15a645","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-10-09T12:46:31Z","pushed_at":"2018-10-10T07:49:21Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":9107,"stargazers_count":383,"watchers_count":383,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":85,"open_issues":98,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2219"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2219"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2219"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2219/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2219/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2219/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/56851f40162b62ca3157017743cde93df27a6be8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shlomitc"}}